diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/mako/view_helpers.rb b/lib/mako/view_helpers.rb index abc1234..def5678 100644 --- a/lib/mako/view_helpers.rb +++ b/lib/mako/view_helpers.rb @@ -0,0 +1,15 @@+module ViewHelpers + # Returns today's date in Day, Date Month Year format + # + # @return [String] + def today + Time.now.strftime('%A, %d...
Add some helpers for the rendered HTML documents
diff --git a/lib/morph/line_buffer.rb b/lib/morph/line_buffer.rb index abc1234..def5678 100644 --- a/lib/morph/line_buffer.rb +++ b/lib/morph/line_buffer.rb @@ -1,4 +1,6 @@ module Morph + # Line-oriented buffer. Send data to the buffer. Extract lines once they + # are completed with newlines class LineBuffer ...
Add comment explaining what LineBuffer class does
diff --git a/smiling.gemspec b/smiling.gemspec index abc1234..def5678 100644 --- a/smiling.gemspec +++ b/smiling.gemspec @@ -23,6 +23,5 @@ gem.add_dependency 'nokogiri', '~> 1.5.0' gem.add_dependency 'httparty', '~> 0.8.0' + gem.add_dependency('jruby-openssl') if RUBY_PLATFORM == 'java' end - -
Add jruby-openssl to dependencies when using JRuby
diff --git a/lib/ry_safe/safe/node.rb b/lib/ry_safe/safe/node.rb index abc1234..def5678 100644 --- a/lib/ry_safe/safe/node.rb +++ b/lib/ry_safe/safe/node.rb @@ -6,7 +6,7 @@ include Util::Dates include Util::Hashable - SEPARATOR = '/' + SEPARATOR = File::SEPARATOR attr_accessor :name, :parent
Use File separator instead of slash
diff --git a/lib/tasks/test_jobs.rake b/lib/tasks/test_jobs.rake index abc1234..def5678 100644 --- a/lib/tasks/test_jobs.rake +++ b/lib/tasks/test_jobs.rake @@ -1,5 +1,5 @@ namespace :test_jobs do - task :notify_admins_on_inconsistent_states do + task notify_admins_on_inconsistent_states: :environment do if Test...
Add ":environment" dependency to rake task or the task will raise with "NameError: uninitialized constant TestJob"
diff --git a/lib/symmetric_encryption.rb b/lib/symmetric_encryption.rb index abc1234..def5678 100644 --- a/lib/symmetric_encryption.rb +++ b/lib/symmetric_encryption.rb @@ -1,9 +1,12 @@+require 'zlib' require 'symmetric_encryption/version' require 'symmetric_encryption/cipher' require 'symmetric_encryption/symmetric...
Make Reader and Writer load on demand
diff --git a/lib/tty/table/operations.rb b/lib/tty/table/operations.rb index abc1234..def5678 100644 --- a/lib/tty/table/operations.rb +++ b/lib/tty/table/operations.rb @@ -58,9 +58,11 @@ # @api public def run_operations(*args) operation_types = args - table.each_with_index do |val, row, co...
Fix to work on actual internal data.
diff --git a/db/migrate/003_rename_user_to_username.rb b/db/migrate/003_rename_user_to_username.rb index abc1234..def5678 100644 --- a/db/migrate/003_rename_user_to_username.rb +++ b/db/migrate/003_rename_user_to_username.rb @@ -0,0 +1,9 @@+class RenameUserToUsername < ActiveRecord::Migration + def self.up + rename...
Rename the user column to users.
diff --git a/lib/ultracart_xml_parser.rb b/lib/ultracart_xml_parser.rb index abc1234..def5678 100644 --- a/lib/ultracart_xml_parser.rb +++ b/lib/ultracart_xml_parser.rb @@ -11,11 +11,15 @@ module UltraCartXMLParser def self.parse(io) - document = Nokogiri::XML(io) do |config| + document = Nokogiri::XML::Read...
Switch to Nokogiri::XML::Reader to enable parsing large XML files
diff --git a/lib/xcode/install/cli.rb b/lib/xcode/install/cli.rb index abc1234..def5678 100644 --- a/lib/xcode/install/cli.rb +++ b/lib/xcode/install/cli.rb @@ -10,8 +10,7 @@ end def installed? - `xcode-select -p` - $?.success? + File.exist?('/Library/Developer/CommandLineTools/usr/l...
Check CLI tools installed by libxcrun.dylib instead of `xcode-select -p` - Success of `xcode-select -p` command will be true if any Xcode.app is installed, or an alternate Xcode.app version has been selected, even if CLI tools have never been installed - More details: https://macops.ca/developer-binaries-on-os-x...
diff --git a/sambao21_workstation/attributes/global_npm_packages.rb b/sambao21_workstation/attributes/global_npm_packages.rb index abc1234..def5678 100644 --- a/sambao21_workstation/attributes/global_npm_packages.rb +++ b/sambao21_workstation/attributes/global_npm_packages.rb @@ -1,5 +1,7 @@ node.default["global_npm_pa...
Add hubot and coffee-script to global npm
diff --git a/spec/factories/products.rb b/spec/factories/products.rb index abc1234..def5678 100644 --- a/spec/factories/products.rb +++ b/spec/factories/products.rb @@ -12,7 +12,8 @@ after(:create) do |product, evaluator| create(:primary_picture, :sparkfun_pic, product: product) - create_list(:product...
Fix error when creating product from factory with multiple pictures
diff --git a/config/environments/production.rb b/config/environments/production.rb index abc1234..def5678 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -24,7 +24,7 @@ # Disable delivery errors, bad email addresses will be ignored # config.action_mailer.raise_delivery_errors ...
Fix path to mailer config. [Story1932717]
diff --git a/tasks/extension.rake b/tasks/extension.rake index abc1234..def5678 100644 --- a/tasks/extension.rake +++ b/tasks/extension.rake @@ -23,9 +23,9 @@ ext.lib_dir = File.join( 'lib', This.name ) ext.gem_spec = This.ruby_gemspec - ext.cross_compile = true # enable cross comp...
Add x64 architecture to Windows cross-compilation targets
diff --git a/embulk-input-bigquery.gemspec b/embulk-input-bigquery.gemspec index abc1234..def5678 100644 --- a/embulk-input-bigquery.gemspec +++ b/embulk-input-bigquery.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ['lib'] - spec.add_dependency '...
Change google-cloud-bigquery dependency to 1.2 or higher.
diff --git a/lib/kramdown/converter/latex_repositext/render_record_marks_mixin.rb b/lib/kramdown/converter/latex_repositext/render_record_marks_mixin.rb index abc1234..def5678 100644 --- a/lib/kramdown/converter/latex_repositext/render_record_marks_mixin.rb +++ b/lib/kramdown/converter/latex_repositext/render_record_ma...
Remove another instance of break_out_of_song (not needed any more)
diff --git a/capistrano-graphite.gemspec b/capistrano-graphite.gemspec index abc1234..def5678 100644 --- a/capistrano-graphite.gemspec +++ b/capistrano-graphite.gemspec @@ -22,4 +22,5 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency ...
Add rspec for basic rake test
diff --git a/spec/cmd_init_spec.rb b/spec/cmd_init_spec.rb index abc1234..def5678 100644 --- a/spec/cmd_init_spec.rb +++ b/spec/cmd_init_spec.rb @@ -19,7 +19,7 @@ it "Asks to import if Solutionfile exists" do FileUtils.touch('Solutionfile.json') out, err, status = Open3.capture3(capcmd('murano', 'init', '--...
Update test with mr->murano change.
diff --git a/bin/hosts.rb b/bin/hosts.rb index abc1234..def5678 100644 --- a/bin/hosts.rb +++ b/bin/hosts.rb @@ -0,0 +1,44 @@+#!/usr/bin/env ruby +# +# Generate Nagios hosts files from unix hosts file +# +# e.g. +# 10.1.1.1 gw.failmode.com +# 10.1.1.5 mail.failmode.com + +require 'erb' + +hosts_file = ARGV[0] || '/etc...
Move this into Nagios tasks
diff --git a/hologram.gemspec b/hologram.gemspec index abc1234..def5678 100644 --- a/hologram.gemspec +++ b/hologram.gemspec @@ -6,12 +6,15 @@ Gem::Specification.new do |spec| spec.name = "hologram" spec.version = Hologram::VERSION - spec.authors = ["JD Cantrell"] - spec.email = ["j...
Add dependencies and an author
diff --git a/spec/timezone_spec.rb b/spec/timezone_spec.rb index abc1234..def5678 100644 --- a/spec/timezone_spec.rb +++ b/spec/timezone_spec.rb @@ -3,11 +3,3 @@ describe command('date') do its(:stdout) { should match /JST/ } end - -describe command('strings /etc/localtime') do - its(:stdout) { should match /JST-9...
Fix redundancy test to timezone spec
diff --git a/app/helpers/reports_helper.rb b/app/helpers/reports_helper.rb index abc1234..def5678 100644 --- a/app/helpers/reports_helper.rb +++ b/app/helpers/reports_helper.rb @@ -22,7 +22,16 @@ def ordered_pickup_and_dropoff_addresses(trips) trips.collect do |trip| - [{time: trip.pickup_time, address:...
Sort trip properly regardless appointment_time presence
diff --git a/lib/generators/thincloud/postmark/templates/thincloud_postmark.rb b/lib/generators/thincloud/postmark/templates/thincloud_postmark.rb index abc1234..def5678 100644 --- a/lib/generators/thincloud/postmark/templates/thincloud_postmark.rb +++ b/lib/generators/thincloud/postmark/templates/thincloud_postmark.rb...
Use convention in postmark initializer template
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,4 +1,6 @@ Rails.application.routes.draw do + root to: redirect('/imports') + require 'sidekiq/web' # see config/initializers/sidekiq.rb for security details mount Sidekiq::Web, at...
Send homepage to imports list Seems as good a place as any for now, but might end up somewhere else once we have other pages. Mostly I just wanted something that wouldn't error!
diff --git a/lib/rutabaga.rb b/lib/rutabaga.rb index abc1234..def5678 100644 --- a/lib/rutabaga.rb +++ b/lib/rutabaga.rb @@ -1,3 +1,22 @@+# speed up rspec under ruby 1.9 because it doesn't work otherwise +if RUBY_VERSION > '1.9.2' + class Object + def to_ary + nil + end + + def to_hash + nil + en...
Put in monkey patch to speed up rspec tests Due to method_missing being called constantly in rspec, this patches the major call categories.
diff --git a/lib/klarna_gateway/controllers/admin/orders_controller.rb b/lib/klarna_gateway/controllers/admin/orders_controller.rb index abc1234..def5678 100644 --- a/lib/klarna_gateway/controllers/admin/orders_controller.rb +++ b/lib/klarna_gateway/controllers/admin/orders_controller.rb @@ -8,7 +8,7 @@ private ...
Fix bug in cancelling orders
diff --git a/lib/autobahn/concurrency.rb b/lib/autobahn/concurrency.rb index abc1234..def5678 100644 --- a/lib/autobahn/concurrency.rb +++ b/lib/autobahn/concurrency.rb @@ -7,19 +7,12 @@ module Concurrency java_import 'java.lang.Thread' java_import 'java.lang.InterruptedException' - java_import 'java.uti...
Use include_package instead of individual imports in Concurrency
diff --git a/lib/docu_sign/anchor_tab.rb b/lib/docu_sign/anchor_tab.rb index abc1234..def5678 100644 --- a/lib/docu_sign/anchor_tab.rb +++ b/lib/docu_sign/anchor_tab.rb @@ -23,7 +23,7 @@ "YOffset" => self.y_offset, "Unit" => self.unit, "IgnoreIfNotPresent" => self.ignore_if_not_present? - ...
Remove unassigned attributes in anchor tabs.
diff --git a/lib/gitlab/plugin_logger.rb b/lib/gitlab/plugin_logger.rb index abc1234..def5678 100644 --- a/lib/gitlab/plugin_logger.rb +++ b/lib/gitlab/plugin_logger.rb @@ -5,4 +5,3 @@ end end end -
Remove trailing line from plugin logger Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/lib/remotely_exceptional.rb b/lib/remotely_exceptional.rb index abc1234..def5678 100644 --- a/lib/remotely_exceptional.rb +++ b/lib/remotely_exceptional.rb @@ -6,7 +6,4 @@ # The namespace for the RemotelyExceptional gem. module RemotelyExceptional - # The namespace that specialized handlers live in. - ...
Remove duplicate Handlers module definition
diff --git a/app/models/email_processor.rb b/app/models/email_processor.rb index abc1234..def5678 100644 --- a/app/models/email_processor.rb +++ b/app/models/email_processor.rb @@ -4,11 +4,19 @@ end def process - # all of your application-specific code here - creating models, - # processing reports, etc - ...
Save the running of email creator
diff --git a/lib/settled/settings.rb b/lib/settled/settings.rb index abc1234..def5678 100644 --- a/lib/settled/settings.rb +++ b/lib/settled/settings.rb @@ -9,6 +9,7 @@ def initialize( &block ) @configuration = {} + @files = [] @instance_strategies = [] if block_given? @@ -26,8 +27,12 ...
Refactor to lazily evaluate when using file(s) DSL method.
diff --git a/lib/tarquinn/handler.rb b/lib/tarquinn/handler.rb index abc1234..def5678 100644 --- a/lib/tarquinn/handler.rb +++ b/lib/tarquinn/handler.rb @@ -9,8 +9,8 @@ end def perform_redirect? - @perform_redirect = is_redirect? if @perform_redirect.nil? - @perform_redirect + return @perform_redirect u...
Use more direct cached getter
diff --git a/lib/tasks/accounts.rake b/lib/tasks/accounts.rake index abc1234..def5678 100644 --- a/lib/tasks/accounts.rake +++ b/lib/tasks/accounts.rake @@ -3,7 +3,7 @@ task :fund=>:environment do if Date.today.day == 1 || Date.today.day == 15 Household.all.each do |household| - household.accounts....
Fix saving funding rake task.
diff --git a/db/migrate/20161023220641_create_elastic_product_state.rb b/db/migrate/20161023220641_create_elastic_product_state.rb index abc1234..def5678 100644 --- a/db/migrate/20161023220641_create_elastic_product_state.rb +++ b/db/migrate/20161023220641_create_elastic_product_state.rb @@ -11,8 +11,10 @@ t.inde...
Correct migration to apply Postgres specific instructions .. only for Postgres Fixes #2
diff --git a/lib/vimentor/rclient.rb b/lib/vimentor/rclient.rb index abc1234..def5678 100644 --- a/lib/vimentor/rclient.rb +++ b/lib/vimentor/rclient.rb @@ -3,6 +3,13 @@ def initialize() @connection = Rserve::Connection.new + r_init() + end + + def r_init() + @connection.eval("library(Matri...
Create r_init function and load libs for sequential mining
diff --git a/ext/rkerberos/extconf.rb b/ext/rkerberos/extconf.rb index abc1234..def5678 100644 --- a/ext/rkerberos/extconf.rb +++ b/ext/rkerberos/extconf.rb @@ -21,5 +21,5 @@ raise 'kdb5 library not found' end -$CFLAGS << '-std=c99' +$CFLAGS << '-std=c99 -Wall -pedantic' create_makefile('rkerberos')
Raise warning level to pedantic This allows us to see possible mistakes earlier, allowing for a stricter adherance to the C standard
diff --git a/models/survey_submission.rb b/models/survey_submission.rb index abc1234..def5678 100644 --- a/models/survey_submission.rb +++ b/models/survey_submission.rb @@ -23,4 +23,10 @@ def restart_todo end end + + ::Course::Survey::Response.class_eval do + def attempting? + !submitted? + end ...
Add attempting? to survey submission
diff --git a/examples/abandoned_transactions.rb b/examples/abandoned_transactions.rb index abc1234..def5678 100644 --- a/examples/abandoned_transactions.rb +++ b/examples/abandoned_transactions.rb @@ -8,7 +8,7 @@ # You can pass the credentials parameters to PagSeguro::Transaction#find_abandoned options = { - cred...
Fix class name to PagSeguro::AccountCredentials
diff --git a/app/models/game.rb b/app/models/game.rb index abc1234..def5678 100644 --- a/app/models/game.rb +++ b/app/models/game.rb @@ -5,7 +5,7 @@ has_many :rounds, dependent: :destroy def finished? - odd_team_score.abs >= 500 || even_team_score >= 500 + odd_team_score.abs >= 500 || even_team_score.abs ...
Fix bug where abs wasn't applied to both scores
diff --git a/app/models/game.rb b/app/models/game.rb index abc1234..def5678 100644 --- a/app/models/game.rb +++ b/app/models/game.rb @@ -1,3 +1,8 @@ class Game < ActiveRecord::Base mount_uploader :image, ImageUploader + + validates :name, presence: true + + # TODO: Remove this and create the default image + valid...
Add validations to the Game
diff --git a/app/models/item.rb b/app/models/item.rb index abc1234..def5678 100644 --- a/app/models/item.rb +++ b/app/models/item.rb @@ -23,11 +23,6 @@ belongs_to :raid#, :counter_cache => true alias_method :buyer, :member - # Class Methods ------------------------------------------------------------- - def ...
Clean leftover junk out of Item
diff --git a/app/models/plan.rb b/app/models/plan.rb index abc1234..def5678 100644 --- a/app/models/plan.rb +++ b/app/models/plan.rb @@ -1,5 +1,5 @@ class Plan < ApplicationRecord belongs_to :user - has_many :recipes + has_many :recipes, dependent: :destroy end
Add dependent destroy option to has_many ingredients relationship
diff --git a/pipeline/db/migrate/20160203175157_devise_create_users.rb b/pipeline/db/migrate/20160203175157_devise_create_users.rb index abc1234..def5678 100644 --- a/pipeline/db/migrate/20160203175157_devise_create_users.rb +++ b/pipeline/db/migrate/20160203175157_devise_create_users.rb @@ -30,6 +30,9 @@ # t.str...
Add extra fields to user table
diff --git a/week-9/ruby-review-1/ruby-review-1.rb b/week-9/ruby-review-1/ruby-review-1.rb index abc1234..def5678 100644 --- a/week-9/ruby-review-1/ruby-review-1.rb +++ b/week-9/ruby-review-1/ruby-review-1.rb @@ -0,0 +1,61 @@+# U2.W6: Testing Assert Statements + +# I worked on this challenge with: Coline Forde + + +# 2...
Add ruby review 1 challenge
diff --git a/lib/be_gateway/client.rb b/lib/be_gateway/client.rb index abc1234..def5678 100644 --- a/lib/be_gateway/client.rb +++ b/lib/be_gateway/client.rb @@ -3,7 +3,6 @@ module BeGateway class Client - cattr_accessor :rack_app cattr_accessor :rack_app, :stub_app def initialize(params) @@ -57,6 +5...
Add default adapter to faraday for real http requests
diff --git a/lib/hbc/container/air.rb b/lib/hbc/container/air.rb index abc1234..def5678 100644 --- a/lib/hbc/container/air.rb +++ b/lib/hbc/container/air.rb @@ -25,7 +25,11 @@ end def extract - @command.run!(self.class.installer_cmd, - :args => ['-silent', '-location', @cask.staged_path, Path...
Improve error message for AIR app reinstallation Adobe AIR Installer forbids the silent reinstallation of existing AIR apps; any attempt fails with exit code 9. In the absence of known workarounds, we merely wrap the failure in a clearer error message.
diff --git a/haxby.rb b/haxby.rb index abc1234..def5678 100644 --- a/haxby.rb +++ b/haxby.rb @@ -3,6 +3,7 @@ class Haxby < Formula homepage 'https://github.com/tabletcorry/haxby' url "https://github.com/tabletcorry/haxby/tarball/haxby-0.1" + head "git://github.com/tabletcorry/haxby.git" sha256 "686714...
Add a HEAD config line to formula Allows you to build the formula from the set version or HEAD, if desired.
diff --git a/spec/intergration/lib/poro_validator/validators/format_validator_spec.rb b/spec/intergration/lib/poro_validator/validators/format_validator_spec.rb index abc1234..def5678 100644 --- a/spec/intergration/lib/poro_validator/validators/format_validator_spec.rb +++ b/spec/intergration/lib/poro_validator/validat...
Add reminder to create better macro/matcher
diff --git a/spec/lib/regxing/generator/less_simple_expression_spec.rb b/spec/lib/regxing/generator/less_simple_expression_spec.rb index abc1234..def5678 100644 --- a/spec/lib/regxing/generator/less_simple_expression_spec.rb +++ b/spec/lib/regxing/generator/less_simple_expression_spec.rb @@ -9,5 +9,10 @@ let(:exp...
Test for accepting the or operator
diff --git a/spec/controllers/social_networking/shared_item_controller_spec.rb b/spec/controllers/social_networking/shared_item_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/social_networking/shared_item_controller_spec.rb +++ b/spec/controllers/social_networking/shared_item_controller_spec.rb...
Add test cases for shared item controller. * Added spec for hide action. * Added spec for page action. [#90191168]
diff --git a/multilateration.gemspec b/multilateration.gemspec index abc1234..def5678 100644 --- a/multilateration.gemspec +++ b/multilateration.gemspec @@ -20,4 +20,5 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "rspec" end
Add rspec gem as a development dependency
diff --git a/db/migrate/20160913195129_move_repo_data_from_database_to_settings.rb b/db/migrate/20160913195129_move_repo_data_from_database_to_settings.rb index abc1234..def5678 100644 --- a/db/migrate/20160913195129_move_repo_data_from_database_to_settings.rb +++ b/db/migrate/20160913195129_move_repo_data_from_databas...
Use find_by instead of dynamic find_by_region
diff --git a/lib/spree_auth_devise.rb b/lib/spree_auth_devise.rb index abc1234..def5678 100644 --- a/lib/spree_auth_devise.rb +++ b/lib/spree_auth_devise.rb @@ -1,4 +1,3 @@ require 'spree_core' require 'spree/auth/devise' require 'spree/authentication_helpers' -require 'coffee_script'
Remove loose require for coffee_script Fixes #176
diff --git a/lib/tasks/data_loader.rb b/lib/tasks/data_loader.rb index abc1234..def5678 100644 --- a/lib/tasks/data_loader.rb +++ b/lib/tasks/data_loader.rb @@ -1,6 +1,6 @@ module DataLoader - def check_for_file taskname + def check_for_file unless ENV['FILE'] puts '' puts "usage: This task req...
Add function to check for dir
diff --git a/lib/tasks/emergency.rake b/lib/tasks/emergency.rake index abc1234..def5678 100644 --- a/lib/tasks/emergency.rake +++ b/lib/tasks/emergency.rake @@ -26,5 +26,15 @@ user.reset_authorization! end end + + desc "Get meta info for all domains in the connection logs" + task :get_all_meta...
Add a rake task to go through all the collected domains in the connection logs
diff --git a/lib/tasks/haml-lint.rake b/lib/tasks/haml-lint.rake index abc1234..def5678 100644 --- a/lib/tasks/haml-lint.rake +++ b/lib/tasks/haml-lint.rake @@ -2,5 +2,14 @@ require 'haml_lint/rake_task' require 'haml_lint/inline_javascript' + # Workaround for warnings from parser/current + # TODO: Remove this...
Convert parser warnings to stdout in haml_lint So we ignore it in static-analysis when status is 0, yet still report it if it's not.
diff --git a/app/models/gobierto_people.rb b/app/models/gobierto_people.rb index abc1234..def5678 100644 --- a/app/models/gobierto_people.rb +++ b/app/models/gobierto_people.rb @@ -4,6 +4,10 @@ end def self.classes_with_vocabularies + [GobiertoPeople::Person] + end + + def self.classes_with_custom_fields ...
Add GobiertoPeople::Person to classes with custom fields enabled
diff --git a/app/models/helpdesk_ticket.rb b/app/models/helpdesk_ticket.rb index abc1234..def5678 100644 --- a/app/models/helpdesk_ticket.rb +++ b/app/models/helpdesk_ticket.rb @@ -8,6 +8,44 @@ # Model constratins/validation validates :project, presence: true # Must always be associated to a project + + # + # ...
FIX: Add missing permissions to helpdesk ticket
diff --git a/app/services/search_orders.rb b/app/services/search_orders.rb index abc1234..def5678 100644 --- a/app/services/search_orders.rb +++ b/app/services/search_orders.rb @@ -26,11 +26,11 @@ @search = OpenFoodNetwork::Permissions.new(current_user).editable_orders.ransack(params[:q]) return paginated_re...
Fix multiple results with 'inventory_items_shipment_id_null' ransack query The q['inventory_items_shipment_id_null'] search element was generating duplicates where there were multiple line items on an order that were ready to be shipped, with id = null
diff --git a/lesson04/basic_musical_notation.rb b/lesson04/basic_musical_notation.rb index abc1234..def5678 100644 --- a/lesson04/basic_musical_notation.rb +++ b/lesson04/basic_musical_notation.rb @@ -7,15 +7,18 @@ # LEFT HAND SPACES A C E Garage use_synth :piano +# Just Like Reading a Book play :E3 play chord(:E4...
Add comment as to where first set of notes came from in the text
diff --git a/hero_spec.rb b/hero_spec.rb index abc1234..def5678 100644 --- a/hero_spec.rb +++ b/hero_spec.rb @@ -1,5 +1,9 @@ require './hero' describe Hero do - + it "has a capitalized name" do + hero = Hero.new 'mike' + + expect(hero.name).to eq 'Mike' # это hero.name == 'Mike' + end end
Add test for capitalized letter
diff --git a/lib/lims-laboratory-app/laboratory/tube/bulk_create_tube.rb b/lib/lims-laboratory-app/laboratory/tube/bulk_create_tube.rb index abc1234..def5678 100644 --- a/lib/lims-laboratory-app/laboratory/tube/bulk_create_tube.rb +++ b/lib/lims-laboratory-app/laboratory/tube/bulk_create_tube.rb @@ -14,7 +14,7 @@ ...
Use string instead of symbols
diff --git a/lib/devise_kerberos_authenticatable/kerberos_adapter.rb b/lib/devise_kerberos_authenticatable/kerberos_adapter.rb index abc1234..def5678 100644 --- a/lib/devise_kerberos_authenticatable/kerberos_adapter.rb +++ b/lib/devise_kerberos_authenticatable/kerberos_adapter.rb @@ -5,7 +5,7 @@ module KerberosAdapte...
Allow credentials in test env
diff --git a/lib/yandex/pdd/client.rb b/lib/yandex/pdd/client.rb index abc1234..def5678 100644 --- a/lib/yandex/pdd/client.rb +++ b/lib/yandex/pdd/client.rb @@ -2,6 +2,8 @@ require 'yandex/pdd/client/domains' require 'yandex/pdd/client/mailboxes' +require 'yandex/pdd/client/maillists' +require 'yandex/pdd/client/sub...
Support for maillists and subscription was enabled
diff --git a/backend/spree_backend.gemspec b/backend/spree_backend.gemspec index abc1234..def5678 100644 --- a/backend/spree_backend.gemspec +++ b/backend/spree_backend.gemspec @@ -23,8 +23,7 @@ s.add_dependency 'jquery-rails', '~> 3.0.0' s.add_dependency 'jquery-ui-rails', '~> 4.0.0' - # Set to 3.4.5 until htt...
Update select2-rails now that it has been fixed.
diff --git a/db/data_migrations/20200204184925_update_geographical_area_description.rb b/db/data_migrations/20200204184925_update_geographical_area_description.rb index abc1234..def5678 100644 --- a/db/data_migrations/20200204184925_update_geographical_area_description.rb +++ b/db/data_migrations/20200204184925_update_...
Add data migration to fix F006 geographical area description
diff --git a/lib/cloudflare.rb b/lib/cloudflare.rb index abc1234..def5678 100644 --- a/lib/cloudflare.rb +++ b/lib/cloudflare.rb @@ -22,6 +22,6 @@ module CloudFlare def self.connection(api_key, email = nil) - Connection.new(api_key, email = nil) + Connection.new(api_key, email) end end
Fix CloudFlare.connection to pass in email address CloudFlare.connection would nil out the email address, even if it was passed in. This commit fixes that behavior.
diff --git a/lib/guard/ronn.rb b/lib/guard/ronn.rb index abc1234..def5678 100644 --- a/lib/guard/ronn.rb +++ b/lib/guard/ronn.rb @@ -3,14 +3,14 @@ require 'ronn' module Guard - class Ronn < Guard + class Ronn < Plugin require 'guard/ronn/runner' require 'guard/ronn/inspector' require 'guard/ronn/not...
Update plugin to match Guard 2.0.0 changes
diff --git a/lib/jade-rails.rb b/lib/jade-rails.rb index abc1234..def5678 100644 --- a/lib/jade-rails.rb +++ b/lib/jade-rails.rb @@ -7,14 +7,16 @@ class << self def compile(source, options = {}) - jade_js = File.read(File.expand_path('../../vendor/assets/javascripts/jade/jade.js', __FILE__)) - contex...
Jade.compile: Improve performance by memoizing context.
diff --git a/lib/mult_table.rb b/lib/mult_table.rb index abc1234..def5678 100644 --- a/lib/mult_table.rb +++ b/lib/mult_table.rb @@ -24,15 +24,18 @@ end end - # @return #line(0) + # Same as calling #line(0) + # + # @return [Array<Integer>] def header_line self.line(0) end # Generate all...
Fix documentation glitches in MultTable
diff --git a/db/migrate/20090517111301_update_text_columns_to_medium_text.rb b/db/migrate/20090517111301_update_text_columns_to_medium_text.rb index abc1234..def5678 100644 --- a/db/migrate/20090517111301_update_text_columns_to_medium_text.rb +++ b/db/migrate/20090517111301_update_text_columns_to_medium_text.rb @@ -0,0...
Increase the blob size, since some tickets get really big...
diff --git a/db/migrate/20150212232559_add_accepted_terms_of_use_to_users.rb b/db/migrate/20150212232559_add_accepted_terms_of_use_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20150212232559_add_accepted_terms_of_use_to_users.rb +++ b/db/migrate/20150212232559_add_accepted_terms_of_use_to_users.rb @@ -1,5...
Use the correct field in the migration
diff --git a/db/migrate/20220311192934_change_content_shares_name_to_text.rb b/db/migrate/20220311192934_change_content_shares_name_to_text.rb index abc1234..def5678 100644 --- a/db/migrate/20220311192934_change_content_shares_name_to_text.rb +++ b/db/migrate/20220311192934_change_content_shares_name_to_text.rb @@ -0,0...
Change type of content_shares.name to text closes LS-3036 flag = none Change-Id: Idf26d753b0bced34f33dc0619b693a93df8e6dd7 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286935 Tested-by: Service Cloud Jenkins <9144042a601061f88f1e1d7a1753ea3e2972119d@instructure.com> Reviewed-by: Isaac Moore <25810822539...
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.29.0.5' + s.version = '0.29.0.6' s.summary = 'Common primitives for ...
Package version is increased from 0.29.0.5 to 0.29.0.6
diff --git a/lib/licence_location_identifier.rb b/lib/licence_location_identifier.rb index abc1234..def5678 100644 --- a/lib/licence_location_identifier.rb +++ b/lib/licence_location_identifier.rb @@ -8,6 +8,6 @@ end def self.authority_types - ["DIS","LBO","UTA","CTY","LGD"] + ["DIS","LBO","UTA","CTY","LGD...
Add MTD to supported licence authority types
diff --git a/src/cookbooks/resource_container_host_linux/spec/firewall_spec.rb b/src/cookbooks/resource_container_host_linux/spec/firewall_spec.rb index abc1234..def5678 100644 --- a/src/cookbooks/resource_container_host_linux/spec/firewall_spec.rb +++ b/src/cookbooks/resource_container_host_linux/spec/firewall_spec.rb...
Verify that the SSH port is open by default references #2
diff --git a/lib/pling/gateway/action_mailer.rb b/lib/pling/gateway/action_mailer.rb index abc1234..def5678 100644 --- a/lib/pling/gateway/action_mailer.rb +++ b/lib/pling/gateway/action_mailer.rb @@ -37,10 +37,10 @@ private def default_configuration - { + super.merge({ :...
Include default configuration values from Pling::Gateway::Base
diff --git a/spec/defines/volume_spec.rb b/spec/defines/volume_spec.rb index abc1234..def5678 100644 --- a/spec/defines/volume_spec.rb +++ b/spec/defines/volume_spec.rb @@ -0,0 +1,56 @@+require 'spec_helper' + +describe 'gluster::volume', type: :define do + let(:title) { 'storage1' } + let(:params) do + { + r...
Add very basic spec test for gluster::volume Not much to see, but better than nothing.
diff --git a/spec/features/login_spec.rb b/spec/features/login_spec.rb index abc1234..def5678 100644 --- a/spec/features/login_spec.rb +++ b/spec/features/login_spec.rb @@ -2,6 +2,7 @@ feature 'Login page' do scenario 'when visiting /login' do + pending visit admin_login_path expect(page).to have_c...
Mark failing spec feature as pending
diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb index abc1234..def5678 100644 --- a/spec/models/project_spec.rb +++ b/spec/models/project_spec.rb @@ -18,10 +18,20 @@ end describe 'when user position is not nobody' do - let(:user) { FactoryGirl.create :user, :chief } - ...
Add testd for all postitions
diff --git a/spec/setup/active_record.rb b/spec/setup/active_record.rb index abc1234..def5678 100644 --- a/spec/setup/active_record.rb +++ b/spec/setup/active_record.rb @@ -5,23 +5,23 @@ ActiveRecord::Migration.verbose = false ActiveRecord::Schema.define do - create_table :delayed_jobs, :force => true do |table| ...
Add index to AR spec setup
diff --git a/app/controllers/api/releases_controller.rb b/app/controllers/api/releases_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/releases_controller.rb +++ b/app/controllers/api/releases_controller.rb @@ -13,7 +13,7 @@ return end - if release.version == current_device.f...
Fix bug where release.version format did not match current_device.fbos_version
diff --git a/enom.gemspec b/enom.gemspec index abc1234..def5678 100644 --- a/enom.gemspec +++ b/enom.gemspec @@ -10,6 +10,7 @@ s.has_rdoc = false s.add_dependency "httparty", "~> 0.10.0" s.add_dependency "public_suffix", "~> 1.2.0" + s.add_development_dependency "test-unit" s.add_development_dependency "sho...
Add test-unit as dev dependency
diff --git a/data/hooks/post-receive.rb b/data/hooks/post-receive.rb index abc1234..def5678 100644 --- a/data/hooks/post-receive.rb +++ b/data/hooks/post-receive.rb @@ -1,18 +1,6 @@ # A bit of ruby comments oldrev, newrev, refname = gets.split - -if refname.split("/").last != "master" - puts "You did not push to ma...
Print water before first in git CLI
diff --git a/middleman-bootstrap-navbar.gemspec b/middleman-bootstrap-navbar.gemspec index abc1234..def5678 100644 --- a/middleman-bootstrap-navbar.gemspec +++ b/middleman-bootstrap-navbar.gemspec @@ -21,6 +21,7 @@ gem.test_files = gem.files.grep(%r(^(test|spec|features)/)) gem.require_paths = ['lib'] + gem....
Add Rake as dev dependency
diff --git a/db/migrate/20150109162748_change_activity_log_activity_to_long_text.rb b/db/migrate/20150109162748_change_activity_log_activity_to_long_text.rb index abc1234..def5678 100644 --- a/db/migrate/20150109162748_change_activity_log_activity_to_long_text.rb +++ b/db/migrate/20150109162748_change_activity_log_acti...
Change activity_log.activity to longtext to handle long process logs. mirrors uploads table
diff --git a/db/migrate/20150217095648_remove_null_constraints_from_spree_tables.rb b/db/migrate/20150217095648_remove_null_constraints_from_spree_tables.rb index abc1234..def5678 100644 --- a/db/migrate/20150217095648_remove_null_constraints_from_spree_tables.rb +++ b/db/migrate/20150217095648_remove_null_constraints_...
Remove the null constraint on several spree tables As with globalize 5.0 the original table column won't be updated anymore (https://github.com/globalize/globalize/pull/396#issuecomment-70192861), we need to remove the null constraints from the `spree_taxonomies.name` `spree_taxons.name` and `spree_properties.presenta...
diff --git a/lib/ditty/cli.rb b/lib/ditty/cli.rb index abc1234..def5678 100644 --- a/lib/ditty/cli.rb +++ b/lib/ditty/cli.rb @@ -11,6 +11,7 @@ include Thor::Actions desc 'server', 'Start the Ditty server' + require './application' if File.exists?('application.rb') def server # Ensure the token...
fix: Load the application if present
diff --git a/backend/app/models/article.rb b/backend/app/models/article.rb index abc1234..def5678 100644 --- a/backend/app/models/article.rb +++ b/backend/app/models/article.rb @@ -1,7 +1,7 @@ class Article < ActiveRecord::Base include Utils - default_scope order('created_at DESC') + default_scope { order('creat...
Use Default Scope with a block
diff --git a/lib/npmdc/cli.rb b/lib/npmdc/cli.rb index abc1234..def5678 100644 --- a/lib/npmdc/cli.rb +++ b/lib/npmdc/cli.rb @@ -15,7 +15,7 @@ default: Npmdc::Config::DEPEPENDENCY_TYPES method_option :format, aliases: [:f], desc: 'Output format', - ...
Fix --format available options to be strings instead of symbols
diff --git a/app/controllers/alexa_interface_controller.rb b/app/controllers/alexa_interface_controller.rb index abc1234..def5678 100644 --- a/app/controllers/alexa_interface_controller.rb +++ b/app/controllers/alexa_interface_controller.rb @@ -2,14 +2,18 @@ def recommend respond_to do |f| f.json { - ...
Add catch for no intent in request and fix syntax error in creating new request with AlexaRubykit
diff --git a/lib/allrecipes/page_parser.rb b/lib/allrecipes/page_parser.rb index abc1234..def5678 100644 --- a/lib/allrecipes/page_parser.rb +++ b/lib/allrecipes/page_parser.rb @@ -23,7 +23,7 @@ end def recipes_grid - @page.search(recipes_grid_class)[1] + @page.search(recipes_grid_class)[-1] end de...
Use proper index for recipes grid. Always choose the last one, in order to skip both collection and staff picks
diff --git a/refuckulate.rb b/refuckulate.rb index abc1234..def5678 100644 --- a/refuckulate.rb +++ b/refuckulate.rb @@ -10,7 +10,7 @@ def log(msg) @log_count += 1 - sleep(0.3) + sleep(0.7) puts "[CMKREF #{@log_count}] #{msg}" end end @@ -27,6 +27,27 @@ log "Checking to see if your project is totally fuc...
Throw away unneeded CMake artifacts
diff --git a/lib/sastrawi/stemmer/context/visitor/prefix_disambiguator.rb b/lib/sastrawi/stemmer/context/visitor/prefix_disambiguator.rb index abc1234..def5678 100644 --- a/lib/sastrawi/stemmer/context/visitor/prefix_disambiguator.rb +++ b/lib/sastrawi/stemmer/context/visitor/prefix_disambiguator.rb @@ -17,10 +17,17 @@...
Fix missing part of implementation of "PrefixDisambiguator" class
diff --git a/lib/deep_cover/node/module.rb b/lib/deep_cover/node/module.rb index abc1234..def5678 100644 --- a/lib/deep_cover/node/module.rb +++ b/lib/deep_cover/node/module.rb @@ -23,13 +23,15 @@ check_completion has_tracker :body_entry has_child const: {const: ModuleName} - has_child body: [N...
Use can_be_empty for Module and Class
diff --git a/definitions/bundle_config.rb b/definitions/bundle_config.rb index abc1234..def5678 100644 --- a/definitions/bundle_config.rb +++ b/definitions/bundle_config.rb @@ -1,5 +1,8 @@ define :bundle_config do execute "bundle config #{params[:name]}" do user node['current_user'] + environment({ + 'P...
Use bundle from user's rbenv
diff --git a/dayoneme.gemspec b/dayoneme.gemspec index abc1234..def5678 100644 --- a/dayoneme.gemspec +++ b/dayoneme.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.6" + spec.add_developme...
Use latest bundler and rspec gems
diff --git a/tasks/java.rake b/tasks/java.rake index abc1234..def5678 100644 --- a/tasks/java.rake +++ b/tasks/java.rake @@ -2,15 +2,28 @@ desc "Create the java installation package" task :java do - pkg_name = "rubyrep-#{RR::VERSION::STRING}" + jruby_version='9.1.10.0' + pkg_name = "rubyrep-#{RR::VERSIO...
Update the jruby installation package generator Updates: * works with current version of rubyrep * adds isolation from existing ruby installations * builds the jruby installation package from scratch including jruby download & gem installation
diff --git a/sorting.rb b/sorting.rb index abc1234..def5678 100644 --- a/sorting.rb +++ b/sorting.rb @@ -1,4 +1,4 @@-class Array +module Enumerable def quicksort return self if self.size <= 1 pivot = self.shift
Extend Enumerable instead of Array