diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/test/unit/code/builder/java/java_interface_model_builder_test.rb b/test/unit/code/builder/java/java_interface_model_builder_test.rb index abc1234..def5678 100644 --- a/test/unit/code/builder/java/java_interface_model_builder_test.rb +++ b/test/unit/code/builder/java/java_interface_model_builder_test.rb @@ ...
Create unit test to java interface model builder.
diff --git a/lib/docs/scrapers/phpunit.rb b/lib/docs/scrapers/phpunit.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/phpunit.rb +++ b/lib/docs/scrapers/phpunit.rb @@ -24,7 +24,7 @@ HTML version '5' do - self.release = '5.4' + self.release = '5.5' self.base_url = "https://phpunit.de...
Update PHPUnit documentation (5.5, 4.8)
diff --git a/lib/checkers.rb b/lib/checkers.rb index abc1234..def5678 100644 --- a/lib/checkers.rb +++ b/lib/checkers.rb @@ -1,2 +1,53 @@+require_relative "./board" + module Checkers + class Game + INPUT_MAP = { + "1" => 0, "2" => 1, "3" => 2, "4" => 3, + "5" => 4, "6" => 5, "7" => 6, "8" => 7, + "a...
Add simple game loop with no error checking
diff --git a/app/views/course/video/videos/_video_lesson_plan_item.json.jbuilder b/app/views/course/video/videos/_video_lesson_plan_item.json.jbuilder index abc1234..def5678 100644 --- a/app/views/course/video/videos/_video_lesson_plan_item.json.jbuilder +++ b/app/views/course/video/videos/_video_lesson_plan_item.json....
Fix the video settings title in lesson plan
diff --git a/lib/judopay.rb b/lib/judopay.rb index abc1234..def5678 100644 --- a/lib/judopay.rb +++ b/lib/judopay.rb @@ -1,8 +1,8 @@-require "judopay/version" -require File.expand_path('../judopay/api', __FILE__) -require File.expand_path('../judopay/payment', __FILE__) -require File.expand_path('../judopay/transaction...
Use require_relative instead of File.expand_path
diff --git a/lib/kenny_g.rb b/lib/kenny_g.rb index abc1234..def5678 100644 --- a/lib/kenny_g.rb +++ b/lib/kenny_g.rb @@ -10,6 +10,7 @@ def play_game(game_params = {}) QuickGameSetup.new(game_params).play_game end + alias_method :start_game, :play_game def details "Nothing to do yet! Kic...
Add alias method to start game * after testing in irb, the first thing I wrote was start game. So...
diff --git a/lib/todoist.rb b/lib/todoist.rb index abc1234..def5678 100644 --- a/lib/todoist.rb +++ b/lib/todoist.rb @@ -1,6 +1,16 @@ require 'uri' require 'json' require 'faraday' + +module Todoist + class InvalidURIError < StandardError; end + class InvalidJSONPathError < StandardError; end + class InvalidJSONEr...
Swap module definition and require lines.
diff --git a/deployment/puppet/osnailyfacter/modular/ssl/ssl_keys_saving_post.rb b/deployment/puppet/osnailyfacter/modular/ssl/ssl_keys_saving_post.rb index abc1234..def5678 100644 --- a/deployment/puppet/osnailyfacter/modular/ssl/ssl_keys_saving_post.rb +++ b/deployment/puppet/osnailyfacter/modular/ssl/ssl_keys_saving...
Rewrite post test for ssl keys saving task Change-Id: I4fa25b87c4a5f31a92a266c3b31fba6698f13807 Closes-Bug: #1523465
diff --git a/db/data_migration/20170207113434_fix_html_attachments_nil_organisations.rb b/db/data_migration/20170207113434_fix_html_attachments_nil_organisations.rb index abc1234..def5678 100644 --- a/db/data_migration/20170207113434_fix_html_attachments_nil_organisations.rb +++ b/db/data_migration/20170207113434_fix_h...
Fix nil organisations for HtmlPublicationPresenter Some HtmlPublication were provoking an error on government frontend due to nil organisations for the attachment attachable. We are fixing this adding an organisation to the attachable which has no one, selecting it from the previous editions.
diff --git a/db/data_migrations/20200203173115_add_entry_date_and_time_to_query_tool.rb b/db/data_migrations/20200203173115_add_entry_date_and_time_to_query_tool.rb index abc1234..def5678 100644 --- a/db/data_migrations/20200203173115_add_entry_date_and_time_to_query_tool.rb +++ b/db/data_migrations/20200203173115_add_...
Move Entry Date & Time query tool field migration to core.
diff --git a/platforms/ios/framework/Tangram-es.podspec b/platforms/ios/framework/Tangram-es.podspec index abc1234..def5678 100644 --- a/platforms/ios/framework/Tangram-es.podspec +++ b/platforms/ios/framework/Tangram-es.podspec @@ -22,7 +22,7 @@ s.requires_arc = true - s.vendored_frameworks = 'TangramMap.framew...
Update framework file name in podspec
diff --git a/logr.gemspec b/logr.gemspec index abc1234..def5678 100644 --- a/logr.gemspec +++ b/logr.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = "logr" spec.version = Logr::VERSION - spec.authors = ["Peter Marton"] - spec.email = ["martonpe@secretsaucepartne...
Fix executables dir in gemspec and add new author
diff --git a/lib/rackspace-monitoring/monitoring/requests/update_entity.rb b/lib/rackspace-monitoring/monitoring/requests/update_entity.rb index abc1234..def5678 100644 --- a/lib/rackspace-monitoring/monitoring/requests/update_entity.rb +++ b/lib/rackspace-monitoring/monitoring/requests/update_entity.rb @@ -0,0 +1,22 @...
Add an update path for entities
diff --git a/test/test_serializer.rb b/test/test_serializer.rb index abc1234..def5678 100644 --- a/test/test_serializer.rb +++ b/test/test_serializer.rb @@ -19,7 +19,7 @@ begin assert_equal JSON, memcache.instance_variable_get('@ring').servers.first.serializer - memcached(19128) do |newdc| + ...
Change a port number in the specs to avoid a potential conflict
diff --git a/test/dummy/app/models/photo.rb b/test/dummy/app/models/photo.rb index abc1234..def5678 100644 --- a/test/dummy/app/models/photo.rb +++ b/test/dummy/app/models/photo.rb @@ -1,3 +1,4 @@ class Photo < ActiveRecord::Base has_dynamic_attached_file :image, styles: { thumb: '100x100#' } + do_not_validate_atta...
Add do_not_validate_attachment_file_type to dummy Photo model to keep newer Paperclip from raising errors since we don't validate the attachment
diff --git a/models/device_oid_lookup.rb b/models/device_oid_lookup.rb index abc1234..def5678 100644 --- a/models/device_oid_lookup.rb +++ b/models/device_oid_lookup.rb @@ -1,14 +1,16 @@ class DeviceOidLookup include java.lang.Runnable - def initialize known_device, local_device + def initialize known_device, loca...
Move Oid filtering logic into KnownDevice.
diff --git a/gitnesse.gemspec b/gitnesse.gemspec index abc1234..def5678 100644 --- a/gitnesse.gemspec +++ b/gitnesse.gemspec @@ -18,5 +18,6 @@ gem.add_dependency("bundler","~> 1.2.1") gem.add_dependency("gollum","~> 2.3.4") gem.add_development_dependency("minitest-matchers") + gem.add_development_dependency("c...
Add cucumber as a development dependency.
diff --git a/db/migrate/20130403003950_add_last_activity_column_into_project.rb b/db/migrate/20130403003950_add_last_activity_column_into_project.rb index abc1234..def5678 100644 --- a/db/migrate/20130403003950_add_last_activity_column_into_project.rb +++ b/db/migrate/20130403003950_add_last_activity_column_into_projec...
Use raw SQL instead of Rails models in 20130403003950 migration Closes gitlab-org/gitlab-development-kit#109 Closes https://github.com/gitlabhq/gitlabhq/issues/10123
diff --git a/Casks/vivaldi.rb b/Casks/vivaldi.rb index abc1234..def5678 100644 --- a/Casks/vivaldi.rb +++ b/Casks/vivaldi.rb @@ -1,6 +1,6 @@ cask :v1 => 'vivaldi' do version '1.0.83.38' - sha256 '84153229b9d59561c9d6f570aa77875ed8b410ff43d2b4298167a0dc300b2a59' + sha256 '54682a12066ab6b446003d3c1735e7504136a043d0d...
Fix checksum in Vivaldi Cask
diff --git a/models/init.rb b/models/init.rb index abc1234..def5678 100644 --- a/models/init.rb +++ b/models/init.rb @@ -4,8 +4,4 @@ property :category, String property :packagename, String property :versions, String - property :keywords, String - property :descriptions, String - property :homepages, String ...
Update db model to match build_db.rb
diff --git a/db/migrate/20150331194114_set_value_as_earnable_coins.rb b/db/migrate/20150331194114_set_value_as_earnable_coins.rb index abc1234..def5678 100644 --- a/db/migrate/20150331194114_set_value_as_earnable_coins.rb +++ b/db/migrate/20150331194114_set_value_as_earnable_coins.rb @@ -1,11 +1,5 @@ class SetValueAsEa...
Set the value from the coins cache
diff --git a/db/migrate/20170302131100_rename_tracks_to_enclosures.rb b/db/migrate/20170302131100_rename_tracks_to_enclosures.rb index abc1234..def5678 100644 --- a/db/migrate/20170302131100_rename_tracks_to_enclosures.rb +++ b/db/migrate/20170302131100_rename_tracks_to_enclosures.rb @@ -0,0 +1,22 @@+class RenameTracks...
Add migration that renames tracks -> enclosures, track_like -> enclosure_like, entry_track -> entry_enclosure
diff --git a/lib/dotopts/api.rb b/lib/dotopts/api.rb index abc1234..def5678 100644 --- a/lib/dotopts/api.rb +++ b/lib/dotopts/api.rb @@ -5,8 +5,13 @@ CONFIG_FILE = '.options' # Configure - def self.configure!(config_file) - if config_file = config_file || config_file() + # + # @param [String] configuraiton...
Fix interface on configure method. [bug]
diff --git a/lib/email_trail.rb b/lib/email_trail.rb index abc1234..def5678 100644 --- a/lib/email_trail.rb +++ b/lib/email_trail.rb @@ -5,7 +5,7 @@ class Base def self.delivering_email(message) - EmailTrailMessage.create( + EmailTrail.create( to: message.to.to_s, cc: message.cc.to_...
Use the correct table name
diff --git a/lib/erd/railtie.rb b/lib/erd/railtie.rb index abc1234..def5678 100644 --- a/lib/erd/railtie.rb +++ b/lib/erd/railtie.rb @@ -11,7 +11,7 @@ initializer 'erd' do ActiveSupport.on_load(:after_initialize) do if Rails.env.development? - Rails.application.routes.append do + R...
Prepend the root route instead of appending it By prepending the /erd route instead of appending it we can simply give this route the highest priority. That way it won't get overridden by other, more generic route definitions. fix #25
diff --git a/lib/github/ldap.rb b/lib/github/ldap.rb index abc1234..def5678 100644 --- a/lib/github/ldap.rb +++ b/lib/github/ldap.rb @@ -13,17 +13,16 @@ @connection.authenticate(options[:admin_user], options[:admin_password]) - if encryption = check_encryption(options[:encryptation]) + if encryption...
Fix more typos about the encryption protocol.
diff --git a/sample/db/samples/payments.rb b/sample/db/samples/payments.rb index abc1234..def5678 100644 --- a/sample/db/samples/payments.rb +++ b/sample/db/samples/payments.rb @@ -12,7 +12,7 @@ # reference it as such. Make it explicit here that this table has been renamed. Spree::CreditCard.table_name = 'spree_credit...
Fix payment sample card for 2015 Fixes #5845
diff --git a/pry-power_assert.gemspec b/pry-power_assert.gemspec index abc1234..def5678 100644 --- a/pry-power_assert.gemspec +++ b/pry-power_assert.gemspec @@ -8,9 +8,9 @@ spec.version = PryPowerAssert::VERSION spec.authors = ["yui-knk"] spec.email = ["spiketeika@gmail.com"] - spec.summary...
Add summary, description and homepage to gemspec
diff --git a/builder/test-integration/spec/hypriotos-image/kernel_modules_spec.rb b/builder/test-integration/spec/hypriotos-image/kernel_modules_spec.rb index abc1234..def5678 100644 --- a/builder/test-integration/spec/hypriotos-image/kernel_modules_spec.rb +++ b/builder/test-integration/spec/hypriotos-image/kernel_mod...
Add tests for kernel modules
diff --git a/base/db/migrate/20120109081509_update_notify_permissions.rb b/base/db/migrate/20120109081509_update_notify_permissions.rb index abc1234..def5678 100644 --- a/base/db/migrate/20120109081509_update_notify_permissions.rb +++ b/base/db/migrate/20120109081509_update_notify_permissions.rb @@ -6,15 +6,22 @@ r...
Fix postgres build after e2ba584 by fixing ilegal use of SQL's "GROUP BY"
diff --git a/lib/app/routes/metadata.rb b/lib/app/routes/metadata.rb index abc1234..def5678 100644 --- a/lib/app/routes/metadata.rb +++ b/lib/app/routes/metadata.rb @@ -6,7 +6,7 @@ exercise = JSON.parse(response)["assignments"].first language = exercise["track"] slug = exercise["slug"] - ...
Add hack to recognize perl5 test suite
diff --git a/lib/postmon_cli.rb b/lib/postmon_cli.rb index abc1234..def5678 100644 --- a/lib/postmon_cli.rb +++ b/lib/postmon_cli.rb @@ -2,5 +2,4 @@ require "postmon_cli/wrapper" module PostmonCli - # Your code goes here... end
Remove espaços em branco e comentários
diff --git a/lib/psychic/cli.rb b/lib/psychic/cli.rb index abc1234..def5678 100644 --- a/lib/psychic/cli.rb +++ b/lib/psychic/cli.rb @@ -13,15 +13,20 @@ if given_args && (split_pos = given_args.index('--')) @extra_args = given_args.slice(split_pos + 1, given_args.length).map do | arg | #...
Fix detecting extra args that don't have a left-hand/right-hand side
diff --git a/lib/redness/red.rb b/lib/redness/red.rb index abc1234..def5678 100644 --- a/lib/redness/red.rb +++ b/lib/redness/red.rb @@ -31,7 +31,13 @@ yield redis.exec rescue - redis.discard + begin + redis.discard + rescue Redis::CommandError + # It's possible the multi ...
Handle occasional command error when discarding a transaction. There seems to be a bug in the Redis client, where a multi may return without successfully executing the call. Only appears to happen when redis is persisting.
diff --git a/lib/deep_cover/ast_root.rb b/lib/deep_cover/ast_root.rb index abc1234..def5678 100644 --- a/lib/deep_cover/ast_root.rb +++ b/lib/deep_cover/ast_root.rb @@ -1,20 +1,29 @@ require 'backports/2.1.0/enumerable/to_h' +require_relative 'has_tracker' module DeepCover class AstRoot + module FreezingIsPain...
Use tracker code in Root
diff --git a/test/models/events/competitions/portland_short_track_series_test.rb b/test/models/events/competitions/portland_short_track_series_test.rb index abc1234..def5678 100644 --- a/test/models/events/competitions/portland_short_track_series_test.rb +++ b/test/models/events/competitions/portland_short_track_series...
Add basic test for short track
diff --git a/lib/stackdriver.rb b/lib/stackdriver.rb index abc1234..def5678 100644 --- a/lib/stackdriver.rb +++ b/lib/stackdriver.rb @@ -24,7 +24,10 @@ http.use_ssl = true http.start do |http| - http.post(uri.path, msg, headers) + response = http.post(uri.path, msg, headers) + if response.code...
Raise error unless we get a 201 - Created response
diff --git a/4-auth/structured_data/active_record/app/controllers/user_books_controller.rb b/4-auth/structured_data/active_record/app/controllers/user_books_controller.rb index abc1234..def5678 100644 --- a/4-auth/structured_data/active_record/app/controllers/user_books_controller.rb +++ b/4-auth/structured_data/active...
Add books_by_creator doc region for book querying in 4-auth
diff --git a/omnibus/config/software/more-ruby-cleanup-supermarket.rb b/omnibus/config/software/more-ruby-cleanup-supermarket.rb index abc1234..def5678 100644 --- a/omnibus/config/software/more-ruby-cleanup-supermarket.rb +++ b/omnibus/config/software/more-ruby-cleanup-supermarket.rb @@ -26,11 +26,13 @@ build do b...
Fix the cleanup of cached gems Make sure we expand the path first so this works Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/test/models/crawler_test.rb b/test/models/crawler_test.rb index abc1234..def5678 100644 --- a/test/models/crawler_test.rb +++ b/test/models/crawler_test.rb @@ -0,0 +1,23 @@+require 'test_helper' + +class ProviderMock + include Celluloid + def load_events; end +end + +class CrawlerTest < ActiveSupport::Te...
Create test for `Crawler` class
diff --git a/lib/sidekiq/limit_fetch.rb b/lib/sidekiq/limit_fetch.rb index abc1234..def5678 100644 --- a/lib/sidekiq/limit_fetch.rb +++ b/lib/sidekiq/limit_fetch.rb @@ -26,8 +26,14 @@ UnitOfWork.new(queue, job) if job end + # Backwards compatibility for sidekiq v6.1.0 + # @see https://github.com/mperham/side...
Fix compatibility issue for sidekiq v6.1.0+ Since v6.1.0 Sidekiq::BasicFetcher doesn't support class-level method bulk_requeue. See https://github.com/mperham/sidekiq/pull/4602 for details. For backwards compatibility we should support both interfaces depending on class method presence.
diff --git a/lib/smart_titles/helper.rb b/lib/smart_titles/helper.rb index abc1234..def5678 100644 --- a/lib/smart_titles/helper.rb +++ b/lib/smart_titles/helper.rb @@ -1,6 +1,6 @@ module SmartTitles module Helper - MISSING_TRANSLATION = 0 + MISSING_TRANSLATION = Object.new # <title><%= head_title %></t...
Use blank object as a missing translation so that it is unique.
diff --git a/lib/godmin/authorization.rb b/lib/godmin/authorization.rb index abc1234..def5678 100644 --- a/lib/godmin/authorization.rb +++ b/lib/godmin/authorization.rb @@ -9,7 +9,7 @@ helper_method :policy rescue_from NotAuthorizedError do - render text: "Forbidden", status: 403, layout: false + ...
Use layout and better message for not authorized page
diff --git a/lib/looks/gravatar/image.rb b/lib/looks/gravatar/image.rb index abc1234..def5678 100644 --- a/lib/looks/gravatar/image.rb +++ b/lib/looks/gravatar/image.rb @@ -24,7 +24,7 @@ new(id, url, rating) end - attr_accessor :id, :url, :rating + attr_reader :id, :url, :rating def ...
Use 'attr_reader' in Gravatar API
diff --git a/dynosaur.gemspec b/dynosaur.gemspec index abc1234..def5678 100644 --- a/dynosaur.gemspec +++ b/dynosaur.gemspec @@ -17,7 +17,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ['lib'] - spec.add_runtime_dependency 'platform-api', '~> 2.0.0' + spec.ad...
Update platform-api requirement from ~> 2.0.0 to >= 2.0, < 2.3 Updates the requirements on [platform-api](https://github.com/heroku/platform-api) to permit the latest version. - [Release notes](https://github.com/heroku/platform-api/releases) - [Commits](https://github.com/heroku/platform-api/compare/v2.0.0...v2.2.0) ...
diff --git a/lib/protobuf/nats/runner.rb b/lib/protobuf/nats/runner.rb index abc1234..def5678 100644 --- a/lib/protobuf/nats/runner.rb +++ b/lib/protobuf/nats/runner.rb @@ -6,6 +6,7 @@ module Protobuf module Nats class Runner + include ::Protobuf::Logging def initialize(options) @options ...
Fix thread dump on TRAP signal
diff --git a/lib/simple_sqs/processor.rb b/lib/simple_sqs/processor.rb index abc1234..def5678 100644 --- a/lib/simple_sqs/processor.rb +++ b/lib/simple_sqs/processor.rb @@ -22,7 +22,7 @@ private def process event - logger.info "Processing SQS event #{event.inspect}" + logger.debug "Processing SQS event #{e...
Move event logging to debug
diff --git a/spec/acceptance/image_spec.rb b/spec/acceptance/image_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/image_spec.rb +++ b/spec/acceptance/image_spec.rb @@ -0,0 +1,33 @@+require 'spec_helper' + +describe 'image show page controls', :type => :feature do + before(:each) do + @you = create(:use...
Write up acceptance spec for image/show
diff --git a/spec/protocol/message_spec.rb b/spec/protocol/message_spec.rb index abc1234..def5678 100644 --- a/spec/protocol/message_spec.rb +++ b/spec/protocol/message_spec.rb @@ -0,0 +1,16 @@+describe Kafka::Protocol::Message do + it "encodes and decodes messages" do + message = Kafka::Protocol::Message.new( + ...
Add a spec for encoding and decoding a message
diff --git a/spec/views/tags_views_spec.rb b/spec/views/tags_views_spec.rb index abc1234..def5678 100644 --- a/spec/views/tags_views_spec.rb +++ b/spec/views/tags_views_spec.rb @@ -32,11 +32,15 @@ it "has tag's ideas" do @tag = @tag1 + + user = create(:user) + user.confirm! + assign(:ideas...
Create an idea owner for Tag view specs Create a user record to act as the owner of ideas belonging to the tag records.
diff --git a/spec/isolation/components/mailer_configuration/with_hanami_mailer_spec.rb b/spec/isolation/components/mailer_configuration/with_hanami_mailer_spec.rb index abc1234..def5678 100644 --- a/spec/isolation/components/mailer_configuration/with_hanami_mailer_spec.rb +++ b/spec/isolation/components/mailer_configur...
Isolate global state (env vars) for a mailer configuration test, by running it in a separated process
diff --git a/spec/features/deleting_a_challenge_spec.rb b/spec/features/deleting_a_challenge_spec.rb index abc1234..def5678 100644 --- a/spec/features/deleting_a_challenge_spec.rb +++ b/spec/features/deleting_a_challenge_spec.rb @@ -0,0 +1,60 @@+require "spec_helper" + +feature "Deleting a challenege" do + include Omn...
Add feature spec to cover deleting a challenge
diff --git a/spec/models/webhook/event_register_spec.rb b/spec/models/webhook/event_register_spec.rb index abc1234..def5678 100644 --- a/spec/models/webhook/event_register_spec.rb +++ b/spec/models/webhook/event_register_spec.rb @@ -25,19 +25,19 @@ end it 'serializes the record' do - expect_any_instance...
Call original on event_register spec
diff --git a/spec/requests/authentication_pages_spec.rb b/spec/requests/authentication_pages_spec.rb index abc1234..def5678 100644 --- a/spec/requests/authentication_pages_spec.rb +++ b/spec/requests/authentication_pages_spec.rb @@ -9,7 +9,33 @@ it { should have_content('Sign in')} it { should have_title('Si...
Create tests for valid and invalid authentication
diff --git a/spec/v3/services/preference/update_spec.rb b/spec/v3/services/preference/update_spec.rb index abc1234..def5678 100644 --- a/spec/v3/services/preference/update_spec.rb +++ b/spec/v3/services/preference/update_spec.rb @@ -1,6 +1,7 @@ describe Travis::API::V3::Services::Preference::Update, set_app: true do - ...
Add assertion to confirm token presence
diff --git a/examples/hist.rb b/examples/hist.rb index abc1234..def5678 100644 --- a/examples/hist.rb +++ b/examples/hist.rb @@ -20,7 +20,7 @@ fig, ax = *plt.subplots -n, bins, patches = *ax.hist(x, num_bins, normed: 1) +n, bins, patches = *ax.hist(x, num_bins, density: 1) y = mlab.normpdf(bins, mu, sigma) ax.p...
Use density instead of normed
diff --git a/week-6/gps2.rb b/week-6/gps2.rb index abc1234..def5678 100644 --- a/week-6/gps2.rb +++ b/week-6/gps2.rb @@ -0,0 +1,43 @@+# Your Names +# 1) +# 2) + +# We spent [#] hours on this challenge. + +# Bakery Serving Size portion calculator. + +def serving_size_calc(item_to_make, num_of_ingredients) + library = {...
Add gps 2.3 - second go around
diff --git a/spec/features/report_html_spec.rb b/spec/features/report_html_spec.rb index abc1234..def5678 100644 --- a/spec/features/report_html_spec.rb +++ b/spec/features/report_html_spec.rb @@ -0,0 +1,64 @@+require 'spec_helper' +require './features/step_definitions/testing_dsl' + +describe "HTML report" do + # As ...
Convert html report integration test to RSpec
diff --git a/lib/db_text_search/case_insensitive_string_finder/collate_nocase_adapter.rb b/lib/db_text_search/case_insensitive_string_finder/collate_nocase_adapter.rb index abc1234..def5678 100644 --- a/lib/db_text_search/case_insensitive_string_finder/collate_nocase_adapter.rb +++ b/lib/db_text_search/case_insensitive...
Change TODO to point to the COLLATE NOCASE issue
diff --git a/search-engine/lib/ban_list/custom_standard.rb b/search-engine/lib/ban_list/custom_standard.rb index abc1234..def5678 100644 --- a/search-engine/lib/ban_list/custom_standard.rb +++ b/search-engine/lib/ban_list/custom_standard.rb @@ -27,7 +27,7 @@ change( "2018-10-05", - "https://discordapp.com/c...
Fix Dirty Work B&R link
diff --git a/moby.gemspec b/moby.gemspec index abc1234..def5678 100644 --- a/moby.gemspec +++ b/moby.gemspec @@ -18,7 +18,5 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - # specify any dependencies here; for example: - # s.add_development_depend...
Add rspec as a development dependency
diff --git a/spec/autotest/rails_rspec2_spec.rb b/spec/autotest/rails_rspec2_spec.rb index abc1234..def5678 100644 --- a/spec/autotest/rails_rspec2_spec.rb +++ b/spec/autotest/rails_rspec2_spec.rb @@ -26,16 +26,11 @@ end describe 'mappings' do - before do - rails_rspec2_autotest.find_order = %w( - ...
Remove unncessary before hook from example. - Closes #348
diff --git a/spec/lib/checklists/action_spec.rb b/spec/lib/checklists/action_spec.rb index abc1234..def5678 100644 --- a/spec/lib/checklists/action_spec.rb +++ b/spec/lib/checklists/action_spec.rb @@ -33,12 +33,13 @@ describe ".load_all" do subject { described_class.load_all } - it "returns a list of action...
Add validation for action section field
diff --git a/spec/lib/pavlov_rss/reader_spec.rb b/spec/lib/pavlov_rss/reader_spec.rb index abc1234..def5678 100644 --- a/spec/lib/pavlov_rss/reader_spec.rb +++ b/spec/lib/pavlov_rss/reader_spec.rb @@ -3,6 +3,10 @@ require 'fake_web' describe PavlovRss::Reader do + after do + FakeWeb.clean_registry + end + des...
Add FakeWeb.clean_registry for right use of FakeWeb
diff --git a/spec/lita/handlers/diceman_spec.rb b/spec/lita/handlers/diceman_spec.rb index abc1234..def5678 100644 --- a/spec/lita/handlers/diceman_spec.rb +++ b/spec/lita/handlers/diceman_spec.rb @@ -1,4 +1,5 @@ require "spec_helper" describe Lita::Handlers::Diceman, lita_handler: true do + it { routes_command("...
Add basic test for !dice
diff --git a/spec/models/talk_spec.rb b/spec/models/talk_spec.rb index abc1234..def5678 100644 --- a/spec/models/talk_spec.rb +++ b/spec/models/talk_spec.rb @@ -6,7 +6,6 @@ describe "attributes validation" do it { is_expected.to validate_presence_of :title } - it { is_expected.to validate_presence_of :even...
Remove the test for my last commit
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -1,6 +1,7 @@ require 'rails_helper' RSpec.describe User do + subject { create(:user) } it '#push works' do FakeWeb.register_uri( :post, @@ -9...
Remove deprecation messages on factory_girl
diff --git a/lib/tent-validator/response_expectation/header_validator.rb b/lib/tent-validator/response_expectation/header_validator.rb index abc1234..def5678 100644 --- a/lib/tent-validator/response_expectation/header_validator.rb +++ b/lib/tent-validator/response_expectation/header_validator.rb @@ -2,6 +2,14 @@ clas...
Add support for named header expectations
diff --git a/spec/dummy/config/environments/development.rb b/spec/dummy/config/environments/development.rb index abc1234..def5678 100644 --- a/spec/dummy/config/environments/development.rb +++ b/spec/dummy/config/environments/development.rb @@ -22,19 +22,21 @@ # Raise an error on page load if there are pending migrat...
Fix error when running ./bin/setup with Rails 5.0.0.1 When trying to set up development environment via `./bin/setup` using a new RVM gemset with Ruby 2.3.0 and Rails 5.0.0.1, the following error occures: ``` Resolving dependencies... The Gemfile's dependencies are satisfied Database 'dummy_development' already exist...
diff --git a/pingboard.gemspec b/pingboard.gemspec index abc1234..def5678 100644 --- a/pingboard.gemspec +++ b/pingboard.gemspec @@ -10,6 +10,9 @@ s.authors = ["Bryan B. Cabalo"] s.email = 'bcabalo@gmail.com' s.require_paths = %w(lib) + + s.required_ruby_version = ">= 2.0.0" + s.files ...
Add gem Ruby version requirement
diff --git a/spec/ruby-progressbar/format/molecule_spec.rb b/spec/ruby-progressbar/format/molecule_spec.rb index abc1234..def5678 100644 --- a/spec/ruby-progressbar/format/molecule_spec.rb +++ b/spec/ruby-progressbar/format/molecule_spec.rb @@ -1,22 +1,30 @@ require 'rspectacular' +require 'ruby-progressbar/format/mole...
Refactor: Update tests for 'Molecule' to the new format -------------------------------------------------------------------------------- Branch: refactor/massive-update Signed-off-by: Jeff Felchner <8a84c204e2d4c387d61d20f7892a2bbbf0bc8ae8@thekompanee.com>
diff --git a/spec/unit/brightbox/bb_config/account_spec.rb b/spec/unit/brightbox/bb_config/account_spec.rb index abc1234..def5678 100644 --- a/spec/unit/brightbox/bb_config/account_spec.rb +++ b/spec/unit/brightbox/bb_config/account_spec.rb @@ -16,12 +16,18 @@ context "when config has no default account", :vcr do...
Isolate another spec's config file Sharing configs across tests suffers from another shared state problem where the config incorporates access/refresh token caching so an access token is cached with sanitised values "<TOKEN>" and used to replay and failing. Seems the only safe way to test this code is to drop every s...
diff --git a/spree_postal_service.gemspec b/spree_postal_service.gemspec index abc1234..def5678 100644 --- a/spree_postal_service.gemspec +++ b/spree_postal_service.gemspec @@ -6,9 +6,9 @@ #s.description = 'Add (optional) gem description here' s.required_ruby_version = '>= 1.8.7' - # s.author = 'Davi...
Fix for warning on install - The validation message from Rubygems was: authors may not be empty
diff --git a/app/models/manageiq/providers/hawkular/middleware_manager/middleware_server.rb b/app/models/manageiq/providers/hawkular/middleware_manager/middleware_server.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/hawkular/middleware_manager/middleware_server.rb +++ b/app/models/manageiq/provid...
Allow mw server reports work with mw_server_eap and mw_server_wildfly
diff --git a/methodbox/db/migrate/20100628110331_remove_links_through_has_many.rb b/methodbox/db/migrate/20100628110331_remove_links_through_has_many.rb index abc1234..def5678 100644 --- a/methodbox/db/migrate/20100628110331_remove_links_through_has_many.rb +++ b/methodbox/db/migrate/20100628110331_remove_links_through...
Remove all previous ways of linking things. part of OBE-105
diff --git a/example/campain_app_config.ru b/example/campain_app_config.ru index abc1234..def5678 100644 --- a/example/campain_app_config.ru +++ b/example/campain_app_config.ru @@ -3,9 +3,15 @@ use Aws::Xray::Rack, name: 'campain-app' +class DbConnectionError < StandardError + def initialize + super('Could not ...
Increase error rate in example app
diff --git a/lib/formalist/rich_text/rendering/embedded_form_renderer.rb b/lib/formalist/rich_text/rendering/embedded_form_renderer.rb index abc1234..def5678 100644 --- a/lib/formalist/rich_text/rendering/embedded_form_renderer.rb +++ b/lib/formalist/rich_text/rendering/embedded_form_renderer.rb @@ -3,18 +3,18 @@ m...
Tweak EmbeddedFormRenderer API a little Make the container a single, positional parameter, followed by a splat of options.
diff --git a/app/helpers/users_helper.rb b/app/helpers/users_helper.rb index abc1234..def5678 100644 --- a/app/helpers/users_helper.rb +++ b/app/helpers/users_helper.rb @@ -3,7 +3,7 @@ # Returns the Gravatar for the given user. def gravatar_for(user) gravatar_id = Digest::MD5.hexdigest(user.email.downcase) - ...
Use "mystery man" if there's no Gravatar image Use a simple (not distracting) "mystery man" image if there's no gravatar image for a given user. Signed-off-by: David A. Wheeler <9ae72d22d8b894b865a7a496af4fab6320e6abb2@dwheeler.com>
diff --git a/app/models/campaign_link.rb b/app/models/campaign_link.rb index abc1234..def5678 100644 --- a/app/models/campaign_link.rb +++ b/app/models/campaign_link.rb @@ -2,5 +2,4 @@ belongs_to :campaign validates :title, length: { maximum: 77 } - validates :campaign_id, presence: true end
Remove explicit requiring of campaign id for links
diff --git a/app/policies/user_policy.rb b/app/policies/user_policy.rb index abc1234..def5678 100644 --- a/app/policies/user_policy.rb +++ b/app/policies/user_policy.rb @@ -1,9 +1,9 @@ class UserPolicy < Struct.new(:current_user, :target_user) def update? - target_user == current_user || Role.user_is_at_least_a?(...
Fix error when trying to update user profile
diff --git a/Casks/avira-antivirus.rb b/Casks/avira-antivirus.rb index abc1234..def5678 100644 --- a/Casks/avira-antivirus.rb +++ b/Casks/avira-antivirus.rb @@ -2,6 +2,7 @@ version :latest sha256 :no_check + # avira-update.com was verified as official when first introduced to the cask url 'https://install.av...
Fix `url` stanza comment for Avira Antivirus.
diff --git a/examples/chats/echo_server.rb b/examples/chats/echo_server.rb index abc1234..def5678 100644 --- a/examples/chats/echo_server.rb +++ b/examples/chats/echo_server.rb @@ -13,5 +13,4 @@ end end -Skype.attach -Skype.thread.join +Skype.attach.join
Simplify echo example once more
diff --git a/Casks/vagrant-manager.rb b/Casks/vagrant-manager.rb index abc1234..def5678 100644 --- a/Casks/vagrant-manager.rb +++ b/Casks/vagrant-manager.rb @@ -1,11 +1,11 @@ cask :v1 => 'vagrant-manager' do - version '2.1.2' - sha256 '8510664b4834c98ed9b72baa30aae611f640ca2292725a8cd6ae6d99d412dd4b' + version '2.2....
Update Vagrant Manager to version 2.2.1
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,11 +1,16 @@ require 'sinatra' class Redirector < Sinatra::Base + not_found do + halt 404, 'Not found' + end + get '/' do 'homepage' end get '/:short_link' do - "i'm redirecting you to #{params[:short_li...
Add not_found and redirect overview
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,4 +1,4 @@-require 'sinatra' +require 'sinatra/base' require 'em-websocket' require 'pp'
Change to proper sinatra require for Sinatr::Base
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -46,3 +46,13 @@ end end + +get '/orders' do + orders_data = Order.all + if orders_data.empty? + return 'There are no orders in database' + else + orders = orders_data.as_json.to_json + end + +end
Return orders in RESTful way
diff --git a/ct_angular_js_rails.gemspec b/ct_angular_js_rails.gemspec index abc1234..def5678 100644 --- a/ct_angular_js_rails.gemspec +++ b/ct_angular_js_rails.gemspec @@ -17,7 +17,7 @@ s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"] s.test_files = Dir["test/**/*"] - s.add_d...
Change to rails version 4.1.0
diff --git a/rubygems-compile.gemspec b/rubygems-compile.gemspec index abc1234..def5678 100644 --- a/rubygems-compile.gemspec +++ b/rubygems-compile.gemspec @@ -5,7 +5,7 @@ s.summary = 'A set of rubygems commands that interface with the MacRuby compiler' s.description = <<-EOS -A set of rubygems commands...
Include a full stop in the description
diff --git a/app/controllers/reports/contribution_reports_for_project_owners_controller.rb b/app/controllers/reports/contribution_reports_for_project_owners_controller.rb index abc1234..def5678 100644 --- a/app/controllers/reports/contribution_reports_for_project_owners_controller.rb +++ b/app/controllers/reports/contr...
Fix the contributions report on the project for channel admins
diff --git a/lib/foreman_tasks/triggers.rb b/lib/foreman_tasks/triggers.rb index abc1234..def5678 100644 --- a/lib/foreman_tasks/triggers.rb +++ b/lib/foreman_tasks/triggers.rb @@ -7,7 +7,7 @@ end def trigger(action, *args, &block) - foreman_tasks.dynflow.world.trigger action, *args, &block + forem...
Fix Triggers module to only delegate to ForemanTasks
diff --git a/lib/semvergen.rb b/lib/semvergen.rb index abc1234..def5678 100644 --- a/lib/semvergen.rb +++ b/lib/semvergen.rb @@ -3,6 +3,7 @@ require "semvergen/launcher" require "semvergen/interface" require "semvergen/bump" +require "semvergen/release" require "semvergen/change_log_file" require "semvergen/shell" ...
Make sure this code actually works.
diff --git a/lib/skyed/git.rb b/lib/skyed/git.rb index abc1234..def5678 100644 --- a/lib/skyed/git.rb +++ b/lib/skyed/git.rb @@ -14,7 +14,7 @@ ENV['GIT_SSH'] = '/tmp/ssh-git' path = "/tmp/skyed.#{SecureRandom.hex}" r = ::Git.clone(stack[:custom_cookbooks_source][:url], path) - puts r.pa...
INF-941: Add check if remore is cloned
diff --git a/lib/librarian/dsl/receiver.rb b/lib/librarian/dsl/receiver.rb index abc1234..def5678 100644 --- a/lib/librarian/dsl/receiver.rb +++ b/lib/librarian/dsl/receiver.rb @@ -26,15 +26,19 @@ else case specfile when Specfile - instance_eval(specfile.path.read, specfile.path...
Use eval with a binding rather than instance_eval when evaluating a string.
diff --git a/lib/stack_master/parameter_resolver.rb b/lib/stack_master/parameter_resolver.rb index abc1234..def5678 100644 --- a/lib/stack_master/parameter_resolver.rb +++ b/lib/stack_master/parameter_resolver.rb @@ -19,8 +19,7 @@ begin parameters[key] = resolve_parameter_value(value) rescue...
Raise correct typed exception and also decorate it with something useful
diff --git a/lib/mongoid/extensions/set.rb b/lib/mongoid/extensions/set.rb index abc1234..def5678 100644 --- a/lib/mongoid/extensions/set.rb +++ b/lib/mongoid/extensions/set.rb @@ -9,7 +9,7 @@ # @example Mongoize the object. # set.mongoize # - # @return [ Hash ] The object mongoized. + #...
Correct code documentation for Set extension It appears the code documentation for Set was copied incorrectly from Range. Set mongoizes/demongoizes to/from Array, not Hash.
diff --git a/roles/edgeuno.rb b/roles/edgeuno.rb index abc1234..def5678 100644 --- a/roles/edgeuno.rb +++ b/roles/edgeuno.rb @@ -5,6 +5,30 @@ :hosted_by => "EdgeUno", :location => "Bogotá, Colombia", :networking => { + :firewall => { + :inet => [ + { + :action => "ACCEPT", + :so...
Enable snmp monitoring for Edgeuno machines
diff --git a/spec/unit/ice_nine/freezer/numeric/class_methods/deep_freeze_spec.rb b/spec/unit/ice_nine/freezer/numeric/class_methods/deep_freeze_spec.rb index abc1234..def5678 100644 --- a/spec/unit/ice_nine/freezer/numeric/class_methods/deep_freeze_spec.rb +++ b/spec/unit/ice_nine/freezer/numeric/class_methods/deep_fr...
Add bigdecimal specs for numeric freezer
diff --git a/lib/vagrant/util/safe_exec.rb b/lib/vagrant/util/safe_exec.rb index abc1234..def5678 100644 --- a/lib/vagrant/util/safe_exec.rb +++ b/lib/vagrant/util/safe_exec.rb @@ -8,13 +8,20 @@ # forking. module SafeExec def safe_exec(command) + # Create a list of things to rescue from. Since th...
Fix errno not defined [closes GH-465]
diff --git a/rticles.gemspec b/rticles.gemspec index abc1234..def5678 100644 --- a/rticles.gemspec +++ b/rticles.gemspec @@ -16,7 +16,7 @@ s.files = `git ls-files`.split($\) - s.add_dependency "rails", "~> 3.2.8", '<4.1' + s.add_dependency "rails", ">=3.2.8", '<4.1' s.add_dependency "acts_as_list", ">=...
Fix that Rails version spec excluded Rails 4.0.
diff --git a/ruby_interop.rb b/ruby_interop.rb index abc1234..def5678 100644 --- a/ruby_interop.rb +++ b/ruby_interop.rb @@ -1,5 +1,6 @@ require_relative 'core' require_relative 'numbers' +require_relative 'testing' System_Print=->to_print{Kernel.print to_print} System_PrintLine=->to_print{System_Print[to_print+"\n"...
Print "T" instead of "True" for ruby interop