diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/providers/common.rb b/providers/common.rb index abc1234..def5678 100644 --- a/providers/common.rb +++ b/providers/common.rb @@ -8,6 +8,12 @@ action :create gid new_resource.group end + end + + directory new_resource.path do + action :create + owner new_resource.owner + group ne...
Set up directory for checkout with proper perms
diff --git a/spec/factories/got_fixed_issues.rb b/spec/factories/got_fixed_issues.rb index abc1234..def5678 100644 --- a/spec/factories/got_fixed_issues.rb +++ b/spec/factories/got_fixed_issues.rb @@ -2,7 +2,9 @@ FactoryGirl.define do factory :got_fixed_issue, :class => 'Issue' do - title "MyString" + title ...
Extend FactoryGirl model of Issue
diff --git a/spec/models/file_depot_nfs_spec.rb b/spec/models/file_depot_nfs_spec.rb index abc1234..def5678 100644 --- a/spec/models/file_depot_nfs_spec.rb +++ b/spec/models/file_depot_nfs_spec.rb @@ -1,5 +1,5 @@ describe FileDepotNfs do - let(:ignore_uri) { "nfs://ignore.com/directory" } + let(:uri) {...
Fix NFS File Depot Spec Test Tried to rename the "uri" attribute inadvertantly in previous incarnation of this test and broke it. Fixing now.
diff --git a/examples/packages/databases/mysql_source.rb b/examples/packages/databases/mysql_source.rb index abc1234..def5678 100644 --- a/examples/packages/databases/mysql_source.rb +++ b/examples/packages/databases/mysql_source.rb @@ -0,0 +1,41 @@+# Install the latest MySQL database from source +package :mysql do + ...
Add example how to install MySQL from source
diff --git a/log.gemspec b/log.gemspec index abc1234..def5678 100644 --- a/log.gemspec +++ b/log.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-log' - s.version = '2.1.0.0' + s.version = '2.1.1.0' s.summary = 'Logging to STD IO with levels, tagging, and coloring' ...
Package version is increased from 2.1.0.0 to 2.1.1.0
diff --git a/spec/features/create_posts_spec.rb b/spec/features/create_posts_spec.rb index abc1234..def5678 100644 --- a/spec/features/create_posts_spec.rb +++ b/spec/features/create_posts_spec.rb @@ -1 +1,13 @@ require 'rails_helper.rb' + +feature 'Creating Posts' do + scenario 'Can create post' do + visit '/' + ...
Create a failure test for creating posts
diff --git a/spec/integration/load_path_spec.rb b/spec/integration/load_path_spec.rb index abc1234..def5678 100644 --- a/spec/integration/load_path_spec.rb +++ b/spec/integration/load_path_spec.rb @@ -0,0 +1,11 @@+require 'spec_helper' + +describe ROM::Roda::Plugin do + it 'uses load_path relative to application by de...
Add failing spec to test TravisCI
diff --git a/spec/regexp-random_example_spec.rb b/spec/regexp-random_example_spec.rb index abc1234..def5678 100644 --- a/spec/regexp-random_example_spec.rb +++ b/spec/regexp-random_example_spec.rb @@ -16,7 +16,8 @@ random_example_matches( /\w{10}/, /(we(need(to(go(deeper)?)?)?)?) \1/, - /case ins...
Test for random_example with OrGroup Missing test area for 100% coverage
diff --git a/spec/features/example_feature_spec.rb b/spec/features/example_feature_spec.rb index abc1234..def5678 100644 --- a/spec/features/example_feature_spec.rb +++ b/spec/features/example_feature_spec.rb @@ -8,6 +8,6 @@ scenario "When using Chrome, it works", js: true do visit "/users" - expect(page).t...
Correct expectation in feature spec
diff --git a/spec/read_time_estimator_spec.rb b/spec/read_time_estimator_spec.rb index abc1234..def5678 100644 --- a/spec/read_time_estimator_spec.rb +++ b/spec/read_time_estimator_spec.rb @@ -9,9 +9,10 @@ end end - describe "time_per_word" do + describe "minutes_to_read" do it "should output an amoun...
Replace time_per_word spec with minutes_to_read spec. PA-2182
diff --git a/spec/support/platform_helpers.rb b/spec/support/platform_helpers.rb index abc1234..def5678 100644 --- a/spec/support/platform_helpers.rb +++ b/spec/support/platform_helpers.rb @@ -1,8 +1,6 @@ def windows? !!(RUBY_PLATFORM =~ /mswin|mingw|windows/) end - -# def jruby? def unix? !windows?
Remove the unused platform helper Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/raygun/testable.rb b/lib/raygun/testable.rb index abc1234..def5678 100644 --- a/lib/raygun/testable.rb +++ b/lib/raygun/testable.rb @@ -4,7 +4,14 @@ class ItWorksException < StandardError; end def track_test_exception - Raygun.track_exception(ItWorksException.new("Woohoo!")) + Rayg...
Add some informative output to the test task
diff --git a/lib/redactor2_rails.rb b/lib/redactor2_rails.rb index abc1234..def5678 100644 --- a/lib/redactor2_rails.rb +++ b/lib/redactor2_rails.rb @@ -17,21 +17,21 @@ require 'redactor2_rails/orm/mongoid' require 'redactor2_rails/engine' - mattr_accessor :images_file_types, :files_file_types + mattr_accessor...
Add possibility to update main configs by Redactor2Rails.devise_user=:admin
diff --git a/lib/tasks/article.rake b/lib/tasks/article.rake index abc1234..def5678 100644 --- a/lib/tasks/article.rake +++ b/lib/tasks/article.rake @@ -16,4 +16,10 @@ Rails.logger.info 'Updating views for newly added articles' Article.update_new_views end + + desc 'Update ratings for all articles' + task...
Add rake task to update ratings
diff --git a/lib/zebra/print_job.rb b/lib/zebra/print_job.rb index abc1234..def5678 100644 --- a/lib/zebra/print_job.rb +++ b/lib/zebra/print_job.rb @@ -28,11 +28,12 @@ def send_to_printer(path) # My ip is 192.168.101.99 - if RUBY_PLATFORM =~ /darwin/ - `lpr -h 192.168.101.99 -P #{@printer}` - ...
Remove conditional lp command args
diff --git a/lib/zebra/print_job.rb b/lib/zebra/print_job.rb index abc1234..def5678 100644 --- a/lib/zebra/print_job.rb +++ b/lib/zebra/print_job.rb @@ -24,13 +24,10 @@ def check_existent_printers(printer) existent_printers = Cups.show_destinations - puts "EXISTENT PRINTERS: \n" - existent_printe...
Remove logger info from print job
diff --git a/spec/keen-cli/collections_spec.rb b/spec/keen-cli/collections_spec.rb index abc1234..def5678 100644 --- a/spec/keen-cli/collections_spec.rb +++ b/spec/keen-cli/collections_spec.rb @@ -11,6 +11,14 @@ expect(_).to eq(true) end + it 'deletes the collection with filters' do + filters = '[{...
Add spec for filtered delete
diff --git a/test/spec/settings/get_setting.rb b/test/spec/settings/get_setting.rb index abc1234..def5678 100644 --- a/test/spec/settings/get_setting.rb +++ b/test/spec/settings/get_setting.rb @@ -1,21 +1,27 @@-data = { - "some_setting" => "some value" -} +module GetSetting + def self.data + { + "some_setting...
Test uses a control module
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,7 +4,7 @@ license 'MIT' description 'Installs/Configures New Relic' long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) -version '2.7.2' +version '2.8.0' %w( debian ubuntu redhat cent...
Enable the thread profiler based on attributes
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -1,7 +1,7 @@-name 'magic' +name 'et_magic' version File.read(File.join(File.dirname(__FILE__), 'VERSION')).strip description 'Cookbook helpers and other magical things' lo...
Rename cookbook to et_magic cookbook
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -2,26 +2,16 @@ require 'beaker-puppet' require 'beaker/puppet_install_helper' require 'beaker/module_install_helper' -require 'pry' ...
Clean up acceptance spec helper
diff --git a/spec/tty/table/options_spec.rb b/spec/tty/table/options_spec.rb index abc1234..def5678 100644 --- a/spec/tty/table/options_spec.rb +++ b/spec/tty/table/options_spec.rb @@ -7,7 +7,10 @@ let(:widths) { [] } let(:aligns) { [] } let(:object) { - described_class.new rows, :column_widths => widths, :c...
Fix test failing on some rubies.
diff --git a/app/controllers/spree/admin/integration_controller.rb b/app/controllers/spree/admin/integration_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/integration_controller.rb +++ b/app/controllers/spree/admin/integration_controller.rb @@ -1,8 +1,10 @@ module Spree module Admin ...
Use augury admin api for integration registration
diff --git a/lib/flash_patch/rails_3_1_session_loader.rb b/lib/flash_patch/rails_3_1_session_loader.rb index abc1234..def5678 100644 --- a/lib/flash_patch/rails_3_1_session_loader.rb +++ b/lib/flash_patch/rails_3_1_session_loader.rb @@ -0,0 +1,14 @@+module FlashPatch + class Rails31SessionLoader + def initialize(de...
Implement loader for Rails 3 1 session string by a Rails 3 0 app
diff --git a/lib/sastrawi/dictionary/array_dictionary.rb b/lib/sastrawi/dictionary/array_dictionary.rb index abc1234..def5678 100644 --- a/lib/sastrawi/dictionary/array_dictionary.rb +++ b/lib/sastrawi/dictionary/array_dictionary.rb @@ -36,7 +36,7 @@ # Add a word to the dictionary def add(word) - ...
Remove all whitespace from the start and the end before adding a word to dictionary
diff --git a/lib/vagrant/ansible_auto/cap/guest/posix.rb b/lib/vagrant/ansible_auto/cap/guest/posix.rb index abc1234..def5678 100644 --- a/lib/vagrant/ansible_auto/cap/guest/posix.rb +++ b/lib/vagrant/ansible_auto/cap/guest/posix.rb @@ -0,0 +1,16 @@+ +# Here for documentation purposes only + +module VagrantPlugins + m...
Add POSIX capability parent module for documentation purposes
diff --git a/test/text_bringer/test_buffer.rb b/test/text_bringer/test_buffer.rb index abc1234..def5678 100644 --- a/test/text_bringer/test_buffer.rb +++ b/test/text_bringer/test_buffer.rb @@ -0,0 +1,14 @@+require "test/unit" +require "text_bringer/buffer" + +class TestBuffer < Test::Unit::TestCase + include TextBring...
Add a test for TextBringer::Buffer.
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index abc1234..def5678 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -4,7 +4,7 @@ Rails.application.config.assets.version = '1.0' # Add additional assets to the asset load path -# Rails.application.config.a...
Fix asset paths for production
diff --git a/templates/guide/fulldoc/html/setup.rb b/templates/guide/fulldoc/html/setup.rb index abc1234..def5678 100644 --- a/templates/guide/fulldoc/html/setup.rb +++ b/templates/guide/fulldoc/html/setup.rb @@ -5,6 +5,14 @@ result = '' log.enter_level(Logger::ERROR) { result = super } result + end + + ...
Update URL links for readme file in guide template
diff --git a/test/unit/lookups/pelias_test.rb b/test/unit/lookups/pelias_test.rb index abc1234..def5678 100644 --- a/test/unit/lookups/pelias_test.rb +++ b/test/unit/lookups/pelias_test.rb @@ -23,7 +23,7 @@ end def test_query_for_reverse_geocode - lookup = Geocoder::Lookup::Mapzen.new + lookup = Geocoder::...
Use lookup indicated by test file.
diff --git a/test/integration/pretty_print_test.rb b/test/integration/pretty_print_test.rb index abc1234..def5678 100644 --- a/test/integration/pretty_print_test.rb +++ b/test/integration/pretty_print_test.rb @@ -12,7 +12,7 @@ tmp.write str tmp.flush is_ok = `ruby -c #{tmp.path} 2>&1` - assert_equal "S...
Allow for slightly different Syntax OK message from JRuby.
diff --git a/sunspot-queue.gemspec b/sunspot-queue.gemspec index abc1234..def5678 100644 --- a/sunspot-queue.gemspec +++ b/sunspot-queue.gemspec @@ -13,6 +13,7 @@ s.add_dependency "resque" s.add_dependency "sunspot_rails", ">= 1.3.0" + s.add_development_dependency "rake" s.add_development_dependen...
Add rake as a development dependency. Rake is acting odd unless it's run through bundle exec.
diff --git a/omniauth-orcid.gemspec b/omniauth-orcid.gemspec index abc1234..def5678 100644 --- a/omniauth-orcid.gemspec +++ b/omniauth-orcid.gemspec @@ -1,3 +1,4 @@+require "date" require File.expand_path("../lib/omniauth-orcid/version", __FILE__) Gem::Specification.new do |s|
Fix "undefined method `today' for Date:Class" error.
diff --git a/_plugins/jekyll-pages-directory.rb b/_plugins/jekyll-pages-directory.rb index abc1234..def5678 100644 --- a/_plugins/jekyll-pages-directory.rb +++ b/_plugins/jekyll-pages-directory.rb @@ -0,0 +1,52 @@+# https://github.com/bbakersmith/jekyll-pages-directory/blob/master/_plugins/jekyll-pages-directory.rb +mo...
Add plugin to enable _pages directory https://github.com/bbakersmith/jekyll-pages-directory
diff --git a/lib/chore/strategies/worker/single_worker_strategy.rb b/lib/chore/strategies/worker/single_worker_strategy.rb index abc1234..def5678 100644 --- a/lib/chore/strategies/worker/single_worker_strategy.rb +++ b/lib/chore/strategies/worker/single_worker_strategy.rb @@ -1,6 +1,6 @@ module Chore module Strategy...
Fix SingleWorker's job startup call
diff --git a/lib/fog/octocloud/requests/compute/local_create_vm.rb b/lib/fog/octocloud/requests/compute/local_create_vm.rb index abc1234..def5678 100644 --- a/lib/fog/octocloud/requests/compute/local_create_vm.rb +++ b/lib/fog/octocloud/requests/compute/local_create_vm.rb @@ -8,6 +8,8 @@ target.mkdir unless t...
Raise if cube doesn't exist.
diff --git a/xtime.rb b/xtime.rb index abc1234..def5678 100644 --- a/xtime.rb +++ b/xtime.rb @@ -1,6 +1,6 @@ #!/usr/bin/env ruby def mem(pid); `ps p #{pid} -o rss`.split.last.to_i; end -t = Time.now +t0 = Process.clock_gettime(Process::CLOCK_MONOTONIC) pid = Process.spawn(*ARGV.to_a) mm = 0 @@ -14,5 +14,5 @@ end ...
Use monotonic time for measuring wall-clock time
diff --git a/test/cli/command/test_sessions.rb b/test/cli/command/test_sessions.rb index abc1234..def5678 100644 --- a/test/cli/command/test_sessions.rb +++ b/test/cli/command/test_sessions.rb @@ -0,0 +1,41 @@+# frozen_string_literal: true + +require "helpers" + +# Tests for KBSecret::CLI::Command::Sessions +class KBSe...
test/cli: Add tests for `kbsecret sessions`
diff --git a/Casks/clamxav.rb b/Casks/clamxav.rb index abc1234..def5678 100644 --- a/Casks/clamxav.rb +++ b/Casks/clamxav.rb @@ -0,0 +1,7 @@+class Clamxav < Cask + url 'http://www.clamxav.com/downloads/ClamXav_2.3.6.dmg' + homepage 'http://www.clamxav.com/' + version '2.3.6' + sha1 '4e59947bc049109c375613979fb6092f...
Add ClamXav (Version 2.3.6) Cask
diff --git a/lib/generators/crono/install/templates/migrations/create_crono_jobs.rb b/lib/generators/crono/install/templates/migrations/create_crono_jobs.rb index abc1234..def5678 100644 --- a/lib/generators/crono/install/templates/migrations/create_crono_jobs.rb +++ b/lib/generators/crono/install/templates/migrations/...
Fix MySQL default text size limit
diff --git a/s3-authorize.gemspec b/s3-authorize.gemspec index abc1234..def5678 100644 --- a/s3-authorize.gemspec +++ b/s3-authorize.gemspec @@ -18,7 +18,7 @@ spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1....
Remove version of development dependency "bundler"
diff --git a/spec/ethos/entity.rb b/spec/ethos/entity.rb index abc1234..def5678 100644 --- a/spec/ethos/entity.rb +++ b/spec/ethos/entity.rb @@ -41,6 +41,12 @@ entity = Entity.new asserts(entity.value) == 1 + end + + spec do + entity = Entity.new value: 2 + + asserts(entity.value) == 2 end end
Allow default attributes to be overridden
diff --git a/spec/minimax_spec.rb b/spec/minimax_spec.rb index abc1234..def5678 100644 --- a/spec/minimax_spec.rb +++ b/spec/minimax_spec.rb @@ -0,0 +1,39 @@+require_relative '../lib/tic_tac_toe.rb' +require 'pry' + +describe TicTacToe do + # let(:ttt){TicTacToe.new} + describe '#minimax' do + context 'a player wi...
Test for minimax method, create test for winning, losing, draw, and step a way from winning and losing
diff --git a/aphrodite/app/controllers/api/v2/base_controller.rb b/aphrodite/app/controllers/api/v2/base_controller.rb index abc1234..def5678 100644 --- a/aphrodite/app/controllers/api/v2/base_controller.rb +++ b/aphrodite/app/controllers/api/v2/base_controller.rb @@ -32,7 +32,7 @@ headers['Access-Control-Allow-Ori...
[aphrodite] Add Authorization to headers for CORS
diff --git a/backend/spec/controllers/spree/admin/alerts_spec.rb b/backend/spec/controllers/spree/admin/alerts_spec.rb index abc1234..def5678 100644 --- a/backend/spec/controllers/spree/admin/alerts_spec.rb +++ b/backend/spec/controllers/spree/admin/alerts_spec.rb @@ -14,7 +14,7 @@ end before do - # Spree::Al...
Stop hitting Spree's servers when running specs I noticed this while running specs offline. We were hitting Spree's "alert" endpoint every time we ran this backend spec.
diff --git a/DKHelper.podspec b/DKHelper.podspec index abc1234..def5678 100644 --- a/DKHelper.podspec +++ b/DKHelper.podspec @@ -9,5 +9,5 @@ s.platform = :ios s.ios.deployment_target = "7.1" s.requires_arc = true - s.source_files = 'DKHelper/*' + s.source_files = 'Sourc...
Update podspec file to link the sources
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -1,7 +1,7 @@ require 'aruba/cucumber' require 'stack_master' require 'stack_master/testing' -require 'aruba/in_process' +require 'aruba/processes/in_process' req...
Fix build failures from deprecated require
diff --git a/app/controllers/main_controller.rb b/app/controllers/main_controller.rb index abc1234..def5678 100644 --- a/app/controllers/main_controller.rb +++ b/app/controllers/main_controller.rb @@ -14,12 +14,13 @@ end def stats - @most_followed = Person.all :include => :user, :order => 'users.followers_c...
Fix bug on stats page when Person doesn't have a User
diff --git a/app/controllers/pacs_controller.rb b/app/controllers/pacs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pacs_controller.rb +++ b/app/controllers/pacs_controller.rb @@ -1,10 +1,22 @@ class PacsController < EmbeddedToolsController + before_action :authenticate, if: :authentication_requir...
Add a temporary authentication on pacs tool Disclaimer: I don't think there should be an automated test for this since it will be removed in a few days.
diff --git a/games/network_game.rb b/games/network_game.rb index abc1234..def5678 100644 --- a/games/network_game.rb +++ b/games/network_game.rb @@ -1,6 +1,6 @@ #/usr/bin/env ruby -require './state' -require './client' +require File.expand_path('../../lib/state.rb', __FILE__) +require File.expand_path('../../lib/client...
Update network game to use new paths
diff --git a/app/controllers/bids_controller.rb b/app/controllers/bids_controller.rb index abc1234..def5678 100644 --- a/app/controllers/bids_controller.rb +++ b/app/controllers/bids_controller.rb @@ -1,11 +1,6 @@ class BidsController < ApplicationController before_action :set_round, only: [:index, :create] befo...
Fix bug where users were being confused across multiple rounds
diff --git a/app/controllers/pins_controller.rb b/app/controllers/pins_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pins_controller.rb +++ b/app/controllers/pins_controller.rb @@ -13,8 +13,8 @@ end def create - @user = User.find(params[:id]) - @pin = Pin.new(song_id: params[:song_id], ...
Fix controller create method with local variables
diff --git a/Casks/google-earth-pro.rb b/Casks/google-earth-pro.rb index abc1234..def5678 100644 --- a/Casks/google-earth-pro.rb +++ b/Casks/google-earth-pro.rb @@ -8,7 +8,9 @@ license :gratis tags :vendor => 'Google' - app 'Google Earth Pro.app' + pkg 'Install Google Earth.pkg' + + uninstall :pkgutil => 'com...
Change install to pkg in Google Earth Pro Cask
diff --git a/Casks/intellij-idea-ce.rb b/Casks/intellij-idea-ce.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce.rb +++ b/Casks/intellij-idea-ce.rb @@ -1,6 +1,6 @@ cask 'intellij-idea-ce' do - version '2016.2.3' - sha256 '3a180ff30a8c9b7bf8bf38f6297fcd9ec6d8994e2b0489b97bfbeead362fb3b8' + version '2016....
Update IntelliJ IDEA CE to 2016.2.4
diff --git a/Casks/mendeley-desktop.rb b/Casks/mendeley-desktop.rb index abc1234..def5678 100644 --- a/Casks/mendeley-desktop.rb +++ b/Casks/mendeley-desktop.rb @@ -1,6 +1,6 @@ cask :v1 => 'mendeley-desktop' do - version '1.13.5' - sha256 '99cc040095b198c984f8193eb7b5da4c39bbf77ac1b715161b4036ca7d55db35' + version '...
Upgrade Mendeley Desktop to v1.13.6
diff --git a/app/lib/service_change_notifier.rb b/app/lib/service_change_notifier.rb index abc1234..def5678 100644 --- a/app/lib/service_change_notifier.rb +++ b/app/lib/service_change_notifier.rb @@ -12,7 +12,7 @@ 'error' => 'Request is nil') elsif request == Net::HTTPSuccess ...
Use service url instead of service
diff --git a/app/models/govuk_taxonomy/taxon.rb b/app/models/govuk_taxonomy/taxon.rb index abc1234..def5678 100644 --- a/app/models/govuk_taxonomy/taxon.rb +++ b/app/models/govuk_taxonomy/taxon.rb @@ -2,10 +2,13 @@ # If you're changing it, consider extracting to a common Gem first, eh module GovukTaxonomy class Tax...
Fix subtle 'delegate' v Forwardable conflict These two methods of delegation aren't compatible. Since 'delegate' is the one preferred by RuboCop, this removes all instances of the 'Forwardable' module, and replaces them with plain 'delegate' calls.
diff --git a/app/models/manual_with_sections.rb b/app/models/manual_with_sections.rb index abc1234..def5678 100644 --- a/app/models/manual_with_sections.rb +++ b/app/models/manual_with_sections.rb @@ -1,17 +1,9 @@ class ManualWithSections - attr_writer :sections, :removed_sections + attr_accessor :sections, :removed_...
Make array accessors return mutable instance vars While this isn't ideal, it's going to make it easier for me to move methods in `ManualWithSections` up into `Manual` incrementally.
diff --git a/Formula/gnupg.rb b/Formula/gnupg.rb index abc1234..def5678 100644 --- a/Formula/gnupg.rb +++ b/Formula/gnupg.rb @@ -1,12 +1,12 @@ require 'brewkit' class Gnupg <Formula - @url='ftp://ftp.gnupg.org/gcrypt/gnupg/gnupg-1.4.9.tar.bz2' + @url='ftp://ftp.gnupg.org/gcrypt/gnupg/gnupg-1.4.10.tar.bz2' @home...
Update GnuPG formula to 1.4.10 and include --disable-asm to prevent breakage
diff --git a/app/jobs/gend_image_process_job.rb b/app/jobs/gend_image_process_job.rb index abc1234..def5678 100644 --- a/app/jobs/gend_image_process_job.rb +++ b/app/jobs/gend_image_process_job.rb @@ -14,20 +14,16 @@ gend_image.src_image.image, gend_image.captions.map(&:text_pos)).to_blob - gend_image...
Revert "Move thumbnail generation into separate method." This reverts commit 888b3dca1800747075255e6765b789492d795035.
diff --git a/Formula/nitro.rb b/Formula/nitro.rb index abc1234..def5678 100644 --- a/Formula/nitro.rb +++ b/Formula/nitro.rb @@ -3,9 +3,9 @@ class Nitro < Formula homepage "https://github.com/hobu/nitro" # TODO: request a tagged release - url "https://github.com/hobu/nitro.git", :revision => "c0c3fbba2638a68d330...
Upgrade to latest Nitro HEAD
diff --git a/Formula/picat.rb b/Formula/picat.rb index abc1234..def5678 100644 --- a/Formula/picat.rb +++ b/Formula/picat.rb @@ -4,20 +4,17 @@ url "http://picat-lang.org/download/picat24_src.tar.gz" version "2.4.8" sha256 "72b452a8ba94d6187d837dcdb46aab0d7dc724651bac99a8cf2ada5c0a3543dd" - depends_on "gcc" => ...
Update according to homebrew dev
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -21,28 +21,4 @@ yield end end - - def resource_users resource - user_ids = [0] - - if resource.publicat...
Refactor the Media content users method
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -42,6 +42,6 @@ end def object_error_messages?(resource, *attrs) - (resource.errors.keys & attrs).present? + (re...
Fix for new Errors class
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/application_mailer.rb +++ b/app/mailers/application_mailer.rb @@ -1,4 +1,6 @@ class ApplicationMailer < ActionMailer::Base + include Roadie::Rails::Automatic + default from: ENV['MAILGU...
Add roadie to inline CSS for emails
diff --git a/app/models/events/delete_event.rb b/app/models/events/delete_event.rb index abc1234..def5678 100644 --- a/app/models/events/delete_event.rb +++ b/app/models/events/delete_event.rb @@ -3,9 +3,9 @@ validates :ref_type, presence: true, inclusion: { in: %w{branch tag} } validates :ref, presence: true - ...
Fix incorrect method name in DeleteEvent.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,3 +1,10 @@ Rapporteur::Engine.routes.draw do get '/(.:format)', to: 'statuses#show', as: :status end + +unless Rails.application.routes.routes.any? { |r| Rapporteur::Engine == r.app.app...
Add backward-compatible auto-mounting of Rails Engine.
diff --git a/Kiwi-KIF.podspec b/Kiwi-KIF.podspec index abc1234..def5678 100644 --- a/Kiwi-KIF.podspec +++ b/Kiwi-KIF.podspec @@ -9,7 +9,7 @@ s.platform = :ios, '5.1' s.source = { :git => "https://github.com/garnett/Kiwi-KIF.git", :tag => "#{s.version}" } s.requires_arc = true - + s.ios.xcconfig = { '...
Fix compile issue for xcode6 beta 5
diff --git a/app/workers/push_update_worker.rb b/app/workers/push_update_worker.rb index abc1234..def5678 100644 --- a/app/workers/push_update_worker.rb +++ b/app/workers/push_update_worker.rb @@ -5,7 +5,8 @@ def perform(timeline, account_id, status_id) account = Account.find(account_id) - status = Status.f...
Add proper message to PushUpdateWorker, use redis directly
diff --git a/sector-five/enemy.rb b/sector-five/enemy.rb index abc1234..def5678 100644 --- a/sector-five/enemy.rb +++ b/sector-five/enemy.rb @@ -1,5 +1,5 @@ class Enemy - SPEED = 4 + MAX_SPEED = 6 attr_reader :x, :y, :radius @@ -7,13 +7,14 @@ @image = Gosu::Image.new('images/enemy.png') @window = wind...
Add random speeds to enemies
diff --git a/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb b/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/adapters/postgresql/prepared_statements_test.rb +++ b/activerecord/test/cases/adapters/postgresql/pre...
Fix PG prepared statement test
diff --git a/fast_bitarray.gemspec b/fast_bitarray.gemspec index abc1234..def5678 100644 --- a/fast_bitarray.gemspec +++ b/fast_bitarray.gemspec @@ -14,6 +14,7 @@ spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.requir...
Build extconf.rb after gem installation
diff --git a/test/support/kitchen_helper.rb b/test/support/kitchen_helper.rb index abc1234..def5678 100644 --- a/test/support/kitchen_helper.rb +++ b/test/support/kitchen_helper.rb @@ -5,11 +5,9 @@ module KitchenHelper def in_kitchen - Dir.mktmpdir do |dir| - Dir.chdir(dir) do - knife_command(Chef::...
Fix DRY in kitchen test helper
diff --git a/config/initializers/public_host.rb b/config/initializers/public_host.rb index abc1234..def5678 100644 --- a/config/initializers/public_host.rb +++ b/config/initializers/public_host.rb @@ -1 +1 @@-Whitehall.public_host = ENV['FACTER_govuk_platform'] == 'production' ? 'www.gov.uk' : 'www.dev.gov.uk' +Whiteha...
Make this more clear with parentheses
diff --git a/test/unit/health_check/search_check_test.rb b/test/unit/health_check/search_check_test.rb index abc1234..def5678 100644 --- a/test/unit/health_check/search_check_test.rb +++ b/test/unit/health_check/search_check_test.rb @@ -1,9 +1,51 @@ require_relative "../../test_helper" -require "health_check/logging_co...
Add some simple testing for the SearchCheck struct
diff --git a/pronto-rubocop.gemspec b/pronto-rubocop.gemspec index abc1234..def5678 100644 --- a/pronto-rubocop.gemspec +++ b/pronto-rubocop.gemspec @@ -19,7 +19,7 @@ s.test_files = `git ls-files -- {spec}/*`.split("\n") s.require_paths = ['lib'] - s.add_dependency 'rubocop', '~> 0.13.0' + s.add_dependency ...
Update rubocop dependency version from 0.13.0 to 0.14.0
diff --git a/features/step_definitions/rspec.rb b/features/step_definitions/rspec.rb index abc1234..def5678 100644 --- a/features/step_definitions/rspec.rb +++ b/features/step_definitions/rspec.rb @@ -9,7 +9,9 @@ Then(/^the output should contain the following:$/) do |text| real_text = text.gsub('{SOURCE_FILE}', Vi...
Make expectation message more readble in cucumber tests
diff --git a/CoreDataKit.podspec b/CoreDataKit.podspec index abc1234..def5678 100644 --- a/CoreDataKit.podspec +++ b/CoreDataKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "CoreDataKit" - s.version = "0.6.0" + s.version = "0.6.1" s.license = "MIT" s.summary = "CoreDat...
Include Importing subdirectory files in podspec
diff --git a/flipper-cloud.gemspec b/flipper-cloud.gemspec index abc1234..def5678 100644 --- a/flipper-cloud.gemspec +++ b/flipper-cloud.gemspec @@ -24,5 +24,5 @@ gem.metadata = Flipper::METADATA gem.add_dependency 'flipper', "~> #{Flipper::VERSION}" - gem.add_dependency "brow", "~> 0.2.0" + gem.add_depen...
Update brow dependency to latest
diff --git a/http-protocol.gemspec b/http-protocol.gemspec index abc1234..def5678 100644 --- a/http-protocol.gemspec +++ b/http-protocol.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = "http-protocol" - s.version = '0.1.0' + s.version = '0.1.1' s.summary = "HTTP protocol library designed to facil...
Package version is increased from 0.1.0 to 0.1.1
diff --git a/jetpack-rails.gemspec b/jetpack-rails.gemspec index abc1234..def5678 100644 --- a/jetpack-rails.gemspec +++ b/jetpack-rails.gemspec @@ -12,6 +12,7 @@ s.description = %q{A sweet boostrap mashup for Rails applications. The philosophy is pretty simple, it should make building Rails apps go a lot faster. ...
Add MIT License to Gemspec
diff --git a/guard-kitchen.gemspec b/guard-kitchen.gemspec index abc1234..def5678 100644 --- a/guard-kitchen.gemspec +++ b/guard-kitchen.gemspec @@ -11,7 +11,7 @@ spec.description = %q{Guard plugin for test kitchen} spec.summary = %q{Guard plugin for test kitchen} spec.homepage = "http://github.com...
Use a SPDX compliant license string in the gemspec This is the correct string to use here Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/session_spec.rb b/spec/session_spec.rb index abc1234..def5678 100644 --- a/spec/session_spec.rb +++ b/spec/session_spec.rb @@ -7,6 +7,11 @@ expect { Net::SSH::Session.new('host', 'user', 'password', :timeout => 'data') }.to raise_error ArgumentError, "Timeout value should b...
Raise error if :timeout option is not numeric
diff --git a/spree_ipay88.gemspec b/spree_ipay88.gemspec index abc1234..def5678 100644 --- a/spree_ipay88.gemspec +++ b/spree_ipay88.gemspec @@ -16,7 +16,7 @@ s.require_path = 'lib' s.requirements << 'none' - s.add_dependency 'spree_core', '~> 2.1.1' + s.add_dependency 'spree_core', '~> 2.3.0' s.add_devel...
Change requirements for ipay88 for spree 2.3.0
diff --git a/app/helpers/easy_app/dates_helper.rb b/app/helpers/easy_app/dates_helper.rb index abc1234..def5678 100644 --- a/app/helpers/easy_app/dates_helper.rb +++ b/app/helpers/easy_app/dates_helper.rb @@ -1,8 +1,8 @@ module EasyAPP module DatesHelper - def ll(date) - date != '' ? l(date) : '' + def ...
Allow to pass a hash of options to *ll* helper method
diff --git a/gemfiles/travis.rb b/gemfiles/travis.rb index abc1234..def5678 100644 --- a/gemfiles/travis.rb +++ b/gemfiles/travis.rb @@ -1,5 +1,6 @@ source "https://rubygems.org".freeze gem "codeclimate-test-reporter".freeze +gem "rake".freeze gem "rspec".freeze gem "simplecov".freeze
Add rake to Travis gemfile.
diff --git a/spec/player_spec.rb b/spec/player_spec.rb index abc1234..def5678 100644 --- a/spec/player_spec.rb +++ b/spec/player_spec.rb @@ -1,5 +1,5 @@ require 'spec_helper' -require_relatite '../src/team.rb' +require_relative '../src/team.rb' describe Team do end
Fix typo in require call.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,7 @@ require 'vcs_toolkit' RSpec.configure do |config| - # Use defaults for now + config.expect_with :rspec do |expect_config| + expect_config.syntax = :expect + en...
Use expect syntax for all tests
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,14 +3,3 @@ #dependencies require 'minitest/autorun' require 'webmock/minitest' - -require 'turn' - -Turn.config do |c| - # :outline - turn's original case/test outline mode [...
Remove turn gem to get tests to run
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,4 +1,9 @@ require 'rspec' +require 'webmock/rspec' require 'spidr/version' include Spidr + +RSpec.configure do |config| + config.after { WebMock.reset! } +end
Reset Webmock after each spec.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -23,3 +23,24 @@ PuppetlabsSpec::Files.cleanup end end + +require 'pathname' +dir = Pathname.new(__FILE__).parent +Puppet[:modulepath] = File.join(dir, 'fixtures', 'modules'...
Use modulesync to manage meta files
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,6 +11,16 @@ config.color = true config.default_formatter = "doc" config.backtrace_exclusion_patterns = [] + + config.mock_with :rspec do |c| + # TODO: upgrade shoul...
Enable both should and expect syntax for now
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,7 +10,7 @@ if ENV['TOKEN'] Paperlex.token = ENV['TOKEN'] -elsif ENV['CONTRACTABLE_TOKEN'] +elsif ENV['REMOTE_SIGNATURE_TOKEN'] # we'll set Paperlex.token where needed i...
Correct env variable reference in the specs
diff --git a/lib/everything/piece.rb b/lib/everything/piece.rb index abc1234..def5678 100644 --- a/lib/everything/piece.rb +++ b/lib/everything/piece.rb @@ -5,12 +5,6 @@ extend Forwardable attr_reader :full_path - - # TODO: Add the following methods: - # - dir (Relative to Everything.path) - # -...
Remove TODOs that are done
diff --git a/lib/fake_delete/core.rb b/lib/fake_delete/core.rb index abc1234..def5678 100644 --- a/lib/fake_delete/core.rb +++ b/lib/fake_delete/core.rb @@ -10,7 +10,7 @@ end def only_deleted - scoped.tap { |x| x.default_scoped = false }.where("#{self.table_name}.deleted != 0") + scoped.tap...
Use <> instead of != (SQL standards)
diff --git a/lib/gifts/repo_table.rb b/lib/gifts/repo_table.rb index abc1234..def5678 100644 --- a/lib/gifts/repo_table.rb +++ b/lib/gifts/repo_table.rb @@ -13,8 +13,9 @@ end def add(path) + path = File.expand_path(path) + git_repo = Repo.new(path) - db_repo = table[path] || table.add(pat...
Use absolute path of repo.
diff --git a/lib/gitlab/lfs_token.rb b/lib/gitlab/lfs_token.rb index abc1234..def5678 100644 --- a/lib/gitlab/lfs_token.rb +++ b/lib/gitlab/lfs_token.rb @@ -20,13 +20,8 @@ def token Gitlab::Redis.with do |redis| token = redis.get(redis_key) - - if token - redis.expire(redis_key, EXPI...
Fix race condition that can be triggered if the token expires right after we retrieve it, but before we can set the new expiry time.
diff --git a/lib/overcommit/utils.rb b/lib/overcommit/utils.rb index abc1234..def5678 100644 --- a/lib/overcommit/utils.rb +++ b/lib/overcommit/utils.rb @@ -4,7 +4,7 @@ include ConsoleMethods def hook_name - File.basename($0).gsub('-', '_') + File.basename($0).tr('-', '_') end ...
Address style cleanups in Utils As pointed out by Joe on https://gerrit.causes.com/#/c/22332/2/lib/overcommit/utils.rb Change-Id: I5cc01a344f2b9ca9098969b72ff21ad3c91eb430 Reviewed-on: https://gerrit.causes.com/22356 Reviewed-by: Aiden Scandella <1faf1e8390cdac9204f160c35828cc423b7acd7b@causes.com> Tested-by: Aiden S...
diff --git a/app/helpers/gui_helper.rb b/app/helpers/gui_helper.rb index abc1234..def5678 100644 --- a/app/helpers/gui_helper.rb +++ b/app/helpers/gui_helper.rb @@ -1,7 +1,7 @@ module GuiHelper def progress_bar(now, max, classes='green', width=200) - ratio = 1.0*now/max + ratio = [1.0*now/max, 1.0].min ...
Fix invalid width for progress bars
diff --git a/lib/tasks/pictures.rake b/lib/tasks/pictures.rake index abc1234..def5678 100644 --- a/lib/tasks/pictures.rake +++ b/lib/tasks/pictures.rake @@ -49,5 +49,11 @@ end end end + + [:exif_data, :dimensions].each do |name| + desc '[OBSOLETE] Stub for old migration' + task name do ...
Add rake task stubs for old migrations