diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/features/support/paths.rb b/features/support/paths.rb index abc1234..def5678 100644 --- a/features/support/paths.rb +++ b/features/support/paths.rb @@ -27,7 +27,9 @@ when /^a member's page$/ @member = @organisation.members.active.last member_path(@member) - + when /^the members pag...
Add a new cucumber path 'the members page' => members_path.
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -23,5 +23,5 @@ spec.add_development_dependency "gc_ruboconfig", "~> 2.25.0" spec.add_development_dependency "rspec", "~> 3.1" spec.add_development_dependency "rspec_junit_formatter", "...
Update rubocop requirement from ~> 1.18.0 to ~> 1.19.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://gi...
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -19,7 +19,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "gc_ruboconfig", "~> 3.2.0" + spec.add_d...
Update gc_ruboconfig requirement from ~> 3.2.0 to ~> 3.3.0 Updates the requirements on [gc_ruboconfig](https://github.com/gocardless/ruboconfig) to permit the latest version. - [Release notes](https://github.com/gocardless/ruboconfig/releases) - [Changelog](https://github.com/gocardless/gc_ruboconfig/blob/master/CHANG...
diff --git a/spec/command_parser_spec.rb b/spec/command_parser_spec.rb index abc1234..def5678 100644 --- a/spec/command_parser_spec.rb +++ b/spec/command_parser_spec.rb @@ -41,7 +41,7 @@ end end - describe '#fize' do + describe '#fire' do it 'fires a bullet' do command_parser.fire
Fix a typo in the spec
diff --git a/spec/multibuildpack_spec.rb b/spec/multibuildpack_spec.rb index abc1234..def5678 100644 --- a/spec/multibuildpack_spec.rb +++ b/spec/multibuildpack_spec.rb @@ -4,7 +4,7 @@ it "works with node" do Hatchet::Runner.new("node_multi", buildpack_url: "https://github.com/ddollar/heroku-buildpack-multi.git"...
Use non default node version for tests Previously we were checking for a custom version that coincidentally matched the default version of node that the ruby buildpack was using. This was a mistake and not noticed when the default version was rev-d. The fixture has been updated to use 4.1.2.
diff --git a/spec/routing/broker_spec.rb b/spec/routing/broker_spec.rb index abc1234..def5678 100644 --- a/spec/routing/broker_spec.rb +++ b/spec/routing/broker_spec.rb @@ -1,10 +1,65 @@ require 'spec_helper' describe 'routing to the broker dashboard' do - it 'routes /broker/dashboard to broker/dashboard#index' do ...
Add broker provider routing spec.
diff --git a/ext/mecaby/extconf.rb b/ext/mecaby/extconf.rb index abc1234..def5678 100644 --- a/ext/mecaby/extconf.rb +++ b/ext/mecaby/extconf.rb @@ -7,4 +7,4 @@ have_func('mecab_model_new', %[mecab.h]) -create_makefile('mecaby') +create_makefile('mecaby/mecaby')
Fix the path of extension library file
diff --git a/lib/days/app.rb b/lib/days/app.rb index abc1234..def5678 100644 --- a/lib/days/app.rb +++ b/lib/days/app.rb @@ -21,14 +21,45 @@ }) set(:config, nil) + set :method_override, true + + configure :production, :development do + enable :sessions + end + + helpers do + def logged_...
Enable session and condition for admin_only
diff --git a/command_line/dash_upper_c_spec.rb b/command_line/dash_upper_c_spec.rb index abc1234..def5678 100644 --- a/command_line/dash_upper_c_spec.rb +++ b/command_line/dash_upper_c_spec.rb @@ -3,7 +3,7 @@ describe 'The -C command line option' do before :all do @script = fixture(__FILE__, 'dash_upper_c_scri...
Resolve realpath to fixture directory in -C spec * Fixes #84.
diff --git a/examples/sprinkle/sprinkle.rb b/examples/sprinkle/sprinkle.rb index abc1234..def5678 100644 --- a/examples/sprinkle/sprinkle.rb +++ b/examples/sprinkle/sprinkle.rb @@ -9,7 +9,7 @@ package :sprinkle do description 'Sprinkle Provisioning Tool' - gem 'sprinkle' do + gem 'crafterm-sprinkle' do sour...
Update gem name since example uses the github gem server
diff --git a/config/initializers/urlhelpers.rb b/config/initializers/urlhelpers.rb index abc1234..def5678 100644 --- a/config/initializers/urlhelpers.rb +++ b/config/initializers/urlhelpers.rb @@ -1,7 +1,6 @@ module Oauth2Provider module ApplicationHelper def method_missing method, *args, &block - puts "LO...
Remove call to 'puts' left behind.
diff --git a/lib/work_dir.rb b/lib/work_dir.rb index abc1234..def5678 100644 --- a/lib/work_dir.rb +++ b/lib/work_dir.rb @@ -2,6 +2,7 @@ require 'work_dir/base' require 'work_dir/repo' require 'work_dir/website' +require 'work_dir/phantom' # Top-level module for work dir module WorkDir @@ -36,5 +37,9 @@ def w...
Add phantom to work dir
diff --git a/lib/engineyard-serverside-adapter/version.rb b/lib/engineyard-serverside-adapter/version.rb index abc1234..def5678 100644 --- a/lib/engineyard-serverside-adapter/version.rb +++ b/lib/engineyard-serverside-adapter/version.rb @@ -1,7 +1,7 @@ module EY module Serverside class Adapter - VERSION = ...
Add .pre for next release
diff --git a/lib/rubaidh/authentication/users_controller_mixin.rb b/lib/rubaidh/authentication/users_controller_mixin.rb index abc1234..def5678 100644 --- a/lib/rubaidh/authentication/users_controller_mixin.rb +++ b/lib/rubaidh/authentication/users_controller_mixin.rb @@ -4,7 +4,7 @@ def self.included(controller)...
Add activate method to the users controller mixin
diff --git a/money.rb b/money.rb index abc1234..def5678 100644 --- a/money.rb +++ b/money.rb @@ -1,5 +1,9 @@+require './exchange' + class Money attr_accessor :value, :currency + + @exchange = Exchange.new def initialize(value, currency) @value, @currency = value, currency @@ -14,6 +18,8 @@ end cla...
Create exchange object in Money class
diff --git a/SwiftyChardet.podspec b/SwiftyChardet.podspec index abc1234..def5678 100644 --- a/SwiftyChardet.podspec +++ b/SwiftyChardet.podspec @@ -1,12 +1,12 @@ Pod::Spec.new do |s| - s.platform = :ios s.ios.deployment_target = "8.0" + s.osx.deployment_target = "10.10" s.name = "SwiftyChardet" - s.ve...
Update deployment target for OSX
diff --git a/db/migrate/20171108153515_add_info_about_last_transfer_request_on_balance.rb b/db/migrate/20171108153515_add_info_about_last_transfer_request_on_balance.rb index abc1234..def5678 100644 --- a/db/migrate/20171108153515_add_info_about_last_transfer_request_on_balance.rb +++ b/db/migrate/20171108153515_add_in...
Change balances to use last last transaction request
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -2,4 +2,4 @@ require 'bundler/setup' Bundler.require(:default) -run Rack::Jekyll.new(:destination => '_site') +run Rack::Jekyll.new
Remove needless destination option in Jekyll.new
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -5,7 +5,7 @@ class HomeController < ApplicationController def index - transport = Thrift::FramedTransport.new(Th...
Use 127.0.0.1 instead of localhost to appease Mac OS For some unknown reason, this works perfectly with 127.0.0.1 but doesn't work with localhost. Eh?
diff --git a/app/controllers/main_controller.rb b/app/controllers/main_controller.rb index abc1234..def5678 100644 --- a/app/controllers/main_controller.rb +++ b/app/controllers/main_controller.rb @@ -7,6 +7,6 @@ @events = Event.find(:all, :conditions => { :project_id => @projects }, :order => "created_at DESC...
Order the meeting in dashboard
diff --git a/rack-zippy.gemspec b/rack-zippy.gemspec index abc1234..def5678 100644 --- a/rack-zippy.gemspec +++ b/rack-zippy.gemspec @@ -14,7 +14,7 @@ gem.license = 'MIT' gem.files = `git ls-files`.split($/) - gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } + gem.executa...
Configure gem to have no executables
diff --git a/github-pages.gemspec b/github-pages.gemspec index abc1234..def5678 100644 --- a/github-pages.gemspec +++ b/github-pages.gemspec @@ -4,9 +4,9 @@ s.name = "github-pages" s.version = "0.0.1" - s.summary = "GitHub Pages" - s.description = "Bootstr...
Use complete sentences for summary and description
diff --git a/recipes/drivers.rb b/recipes/drivers.rb index abc1234..def5678 100644 --- a/recipes/drivers.rb +++ b/recipes/drivers.rb @@ -11,9 +11,13 @@ node['drivers'].each do |pkg| windev_install_driver pkg["name"] do - source pkg["source"] + if pkg["save_as"] + source pkg["source"] + cache "depot...
Allow use of depot-ed driver packages (fixes #6)
diff --git a/recipes/initial.rb b/recipes/initial.rb index abc1234..def5678 100644 --- a/recipes/initial.rb +++ b/recipes/initial.rb @@ -13,6 +13,12 @@ mode 0777 end +# Remove ruby 1.8.7 installation +if platform?("ubuntu", "debian") + package 'ruby1.8' do + action :purge + end +end # 1. Packages / Depende...
Purge old ruby version before starting.
diff --git a/sunlight-congress.gemspec b/sunlight-congress.gemspec index abc1234..def5678 100644 --- a/sunlight-congress.gemspec +++ b/sunlight-congress.gemspec @@ -19,6 +19,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.3" + spec.add_development_dependency "minitest" spec...
Add minitest as a development dependency for 1.8 compat
diff --git a/lib/chunky_png/canvas/data_url_importing.rb b/lib/chunky_png/canvas/data_url_importing.rb index abc1234..def5678 100644 --- a/lib/chunky_png/canvas/data_url_importing.rb +++ b/lib/chunky_png/canvas/data_url_importing.rb @@ -10,7 +10,7 @@ # @raise ChunkyPNG::SignatureMismatch if the provides string is...
Allow importing base64 strings without "=" padding.
diff --git a/lib/generators/comment/templates/comment.rb b/lib/generators/comment/templates/comment.rb index abc1234..def5678 100644 --- a/lib/generators/comment/templates/comment.rb +++ b/lib/generators/comment/templates/comment.rb @@ -12,4 +12,7 @@ # NOTE: Comments belong to a user belongs_to :user + + # NOTE...
Fix for Mass Assigment Security
diff --git a/lib/generators/spree/site/site_generator.rb b/lib/generators/spree/site/site_generator.rb index abc1234..def5678 100644 --- a/lib/generators/spree/site/site_generator.rb +++ b/lib/generators/spree/site/site_generator.rb @@ -5,16 +5,14 @@ class SiteGenerator < Rails::Generators::Base class_option :au...
Use highline for spree:install prompts
diff --git a/qbwc_requests.gemspec b/qbwc_requests.gemspec index abc1234..def5678 100644 --- a/qbwc_requests.gemspec +++ b/qbwc_requests.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_dependency "qbxml", "~> 0.3.0" + sp...
Update qbxml to version 0.4.0
diff --git a/research/interface.rb b/research/interface.rb index abc1234..def5678 100644 --- a/research/interface.rb +++ b/research/interface.rb @@ -0,0 +1,7 @@+links.each do |link| + link.page_source.to_nokogiri.css(selector).xpath(selector).each do |url| + url.css(s1).xpath(s2).each do |image_link| + image_l...
Add idea that helped shape the gem UI
diff --git a/app/models/coursewareable/asset.rb b/app/models/coursewareable/asset.rb index abc1234..def5678 100644 --- a/app/models/coursewareable/asset.rb +++ b/app/models/coursewareable/asset.rb @@ -12,9 +12,6 @@ # Validations validates_presence_of :user, :classroom, :assetable validates_attachment_pres...
Refactor file upload limits due to latest gem updates.
diff --git a/app/services/fetch_atom_service.rb b/app/services/fetch_atom_service.rb index abc1234..def5678 100644 --- a/app/services/fetch_atom_service.rb +++ b/app/services/fetch_atom_service.rb @@ -29,7 +29,7 @@ def process_headers(url, response) Rails.logger.debug "Processing link header" - link_header ...
Fix handling of multiple Link headers (that should not be a thing though)
diff --git a/test/models/api_key_test.rb b/test/models/api_key_test.rb index abc1234..def5678 100644 --- a/test/models/api_key_test.rb +++ b/test/models/api_key_test.rb @@ -17,9 +17,27 @@ should belong_to(:user) - test "creating a new Api Key should generate an access token" do + test "creating a new api key sh...
Add assertations for the expired? method on the ApiKey model
diff --git a/spec/support/ems_refresh_helper.rb b/spec/support/ems_refresh_helper.rb index abc1234..def5678 100644 --- a/spec/support/ems_refresh_helper.rb +++ b/spec/support/ems_refresh_helper.rb @@ -0,0 +1,45 @@+module Spec + module Support + module EmsRefreshHelper + def serialize_inventory + # These...
Move EmsRefresh spec helper methods to core Move these helper methods of of the vmware repo to core. VMware and Azure have similar methods and every provider with graph and classic refresh can benefit from these methods.
diff --git a/lib/github_api/client/repos/merging.rb b/lib/github_api/client/repos/merging.rb index abc1234..def5678 100644 --- a/lib/github_api/client/repos/merging.rb +++ b/lib/github_api/client/repos/merging.rb @@ -16,26 +16,30 @@ # Perform a merge # - # = Inputs - # * <tt>:base</tt> - Required Strin...
Change repository mergin api to use new parser. Update docs.
diff --git a/lib/spree/chimpy/controller_filters.rb b/lib/spree/chimpy/controller_filters.rb index abc1234..def5678 100644 --- a/lib/spree/chimpy/controller_filters.rb +++ b/lib/spree/chimpy/controller_filters.rb @@ -11,7 +11,7 @@ def find_mail_chimp_params mc_eid = params[:mc_eid] || session[:mc_eid] ...
Save order source also if record_ms_details params is present This way, we do not need to set session[:order_id]
diff --git a/config/initializers/carrier_wave.rb b/config/initializers/carrier_wave.rb index abc1234..def5678 100644 --- a/config/initializers/carrier_wave.rb +++ b/config/initializers/carrier_wave.rb @@ -3,9 +3,7 @@ config.fog_credentials = { provider: 'AWS', aws_access_key_id: ENV['S3_ACCESS_KEY...
Update AWS s3 information - 2
diff --git a/config/initializers/fast_gettext.rb b/config/initializers/fast_gettext.rb index abc1234..def5678 100644 --- a/config/initializers/fast_gettext.rb +++ b/config/initializers/fast_gettext.rb @@ -6,7 +6,7 @@ # temporarily force it off while we load stuff. Vmdb::FastGettextHelper.register_locales gettex...
Disable fuzzy matching for rmsgmerge
diff --git a/app/views/user/api_details.builder b/app/views/user/api_details.builder index abc1234..def5678 100644 --- a/app/views/user/api_details.builder +++ b/app/views/user/api_details.builder @@ -6,6 +6,9 @@ if @user.description xml.tag! "description", @user.description end + xml.tag! "contribut...
Add new <contributor-terms> element to user details
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -19,7 +19,7 @@ desc "Commit modified files on server to source control, in case anyone has edited them directly" task :commit_edits do - run "cd #{current_path}; svn commit -m 'Manual upda...
Disable remote commits that don't work
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -13,12 +13,6 @@ server "172.16.58.128", :app, :web, :db, :primary => true -namespace :deploy do - task :restart, :roles => :app, :except => { :no_release => true } do - run "touch #{Fi...
Fix restart in capistrano script
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -11,6 +11,8 @@ # TODO: Is there a nicer way of including `nvm`? 'PATH' => "$HOME/.nvm/v0.10.23/bin:$PATH" } + +set :branch, fetch(:branch, "master") set :node_user, "combee" set :dep...
Capistrano: Deploy can use a branch.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -13,11 +13,11 @@ match 'favicon/:feed' => 'icon#get' resource :members, only: :create - match 'signup' => 'members#new', as: :sign_up + get 'signup' => 'members#new', as: :sign_up ...
Use specific method name instead of `match` refs: https://github.com/fastladder/fastladder/pull/24#issuecomment-15001229
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,7 +1,7 @@ # Be sure to restart your server when you modify this file. #Avalon::Application.config.session_...
Fix authentication bug in non-SSL production mode
diff --git a/lib/flipper/adapters/dual_write.rb b/lib/flipper/adapters/dual_write.rb index abc1234..def5678 100644 --- a/lib/flipper/adapters/dual_write.rb +++ b/lib/flipper/adapters/dual_write.rb @@ -4,7 +4,7 @@ include ::Flipper::Adapter # Public: The name of the adapter. - attr_reader :name + ...
Add methods for local and remote
diff --git a/core/app/models/spree/option_type.rb b/core/app/models/spree/option_type.rb index abc1234..def5678 100644 --- a/core/app/models/spree/option_type.rb +++ b/core/app/models/spree/option_type.rb @@ -9,7 +9,7 @@ has_many :option_type_prototypes, class_name: 'Spree::OptionTypePrototype' has_many :proto...
Add allow_blank to uniqueness validation of option type name
diff --git a/app/models/link_relationship.rb b/app/models/link_relationship.rb index abc1234..def5678 100644 --- a/app/models/link_relationship.rb +++ b/app/models/link_relationship.rb @@ -21,4 +21,6 @@ belongs_to :linkable, polymorphic: true, touch: true + + # TODO: Find way how to touch categories throug...
Add todo for caching links issue
diff --git a/app/models/local_restriction.rb b/app/models/local_restriction.rb index abc1234..def5678 100644 --- a/app/models/local_restriction.rb +++ b/app/models/local_restriction.rb @@ -3,6 +3,7 @@ def initialize(gss_code) @gss_code = gss_code + @time_zone = Time.find_zone("London") end def all_r...
Set time zone to London Borrowed from: https://github.com/alphagov/content-publisher/commit/4ae1c4ed683bf0b24eb11d135aebd3cdd1a8ffa6 We need to make sure the alert level changes go out at the correct time. The time zone on the server is incorrect, which means that when we're using dates and times to set the level the...
diff --git a/cookbooks/groove/recipes/default.rb b/cookbooks/groove/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/groove/recipes/default.rb +++ b/cookbooks/groove/recipes/default.rb @@ -8,8 +8,9 @@ # stamp = `date +%s` +groove_working = "/Users/fire/groove" -git "/tmp/groove-#{stamp}" do +git "#...
Build groove with ninja in home directory.
diff --git a/app/lib/notifier.rb b/app/lib/notifier.rb index abc1234..def5678 100644 --- a/app/lib/notifier.rb +++ b/app/lib/notifier.rb @@ -6,43 +6,43 @@ def call return unless appointment.previous_changes - notify_customer(appointment) - notify_guiders(appointment) + notify_customer + notify_guid...
Clean up method signatures in Notify object appointment didn’t need to be passed in to each and every object.
diff --git a/app/models/token.rb b/app/models/token.rb index abc1234..def5678 100644 --- a/app/models/token.rb +++ b/app/models/token.rb @@ -2,7 +2,7 @@ belongs_to :user validates :name, :secret, presence: true - validate :secret_is_valid + validate :secret_is_valid_base32 before_validation :normalize_sec...
Rename method to reveal intent
diff --git a/jekyll-theme-midnight.gemspec b/jekyll-theme-midnight.gemspec index abc1234..def5678 100644 --- a/jekyll-theme-midnight.gemspec +++ b/jekyll-theme-midnight.gemspec @@ -4,7 +4,7 @@ s.name = "jekyll-theme-midnight" s.version = "0.0.1" s.authors = ["Please come forward"] - s.emai...
Update contact email in Gemspec
diff --git a/src/modules/youtube.rb b/src/modules/youtube.rb index abc1234..def5678 100644 --- a/src/modules/youtube.rb +++ b/src/modules/youtube.rb @@ -1,18 +1,7 @@ require 'uri' require 'net/http' -def fetch(uri_str, limit = 10) - # You should choose better exception. - raise ArgumentError, 'HTTP redirect too de...
Split fetching uris to own file Signed-off-by: Aki Saarinen <278bc57fbbff6b7b38435aea0f9d37e3d879167e@akisaarinen.fi>
diff --git a/spec/firebase_id_token/configuration_spec.rb b/spec/firebase_id_token/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/firebase_id_token/configuration_spec.rb +++ b/spec/firebase_id_token/configuration_spec.rb @@ -11,8 +11,8 @@ describe '.project_ids=' do it 'changes default values...
Make a small convention change
diff --git a/spec/core/threadgroup/list_spec.rb b/spec/core/threadgroup/list_spec.rb index abc1234..def5678 100644 --- a/spec/core/threadgroup/list_spec.rb +++ b/spec/core/threadgroup/list_spec.rb @@ -3,11 +3,13 @@ describe "ThreadGroup#list" do it "should return the list of threads in the group" do thread = Th...
Add 'sleep' checks to threadgroup spec to avoid the same race conditions seen in kernel/sleep_spec.
diff --git a/spec/factories/shipment_factory.rb b/spec/factories/shipment_factory.rb index abc1234..def5678 100644 --- a/spec/factories/shipment_factory.rb +++ b/spec/factories/shipment_factory.rb @@ -9,7 +9,7 @@ state 'pending' order address - stock_location + stock_location { DefaultStockLocation....
Fix problem with shipment's stock location creation
diff --git a/spec/regression/regression_spec.rb b/spec/regression/regression_spec.rb index abc1234..def5678 100644 --- a/spec/regression/regression_spec.rb +++ b/spec/regression/regression_spec.rb @@ -1,7 +1,7 @@ require "spec_helper" describe "regression test" do - command("#{File.expand_path("../../../bin/foodcri...
Move argument to the correct location Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/testunitxml.gemspec b/testunitxml.gemspec index abc1234..def5678 100644 --- a/testunitxml.gemspec +++ b/testunitxml.gemspec @@ -0,0 +1,10 @@+spec = Gem::Specification.new do |s| + s.name = 'rubyjedi-testunitxml' + s.version = '0.1.6.3' + s.authors = ['Henrik Mårtensson', "Laurence A. Lee"] + s.email = ...
Add a Gemspec so we can play nicely with the rest of the RubyGems ecosystem.
diff --git a/spec/open_classes/string/to_markdown_heading_spec.rb b/spec/open_classes/string/to_markdown_heading_spec.rb index abc1234..def5678 100644 --- a/spec/open_classes/string/to_markdown_heading_spec.rb +++ b/spec/open_classes/string/to_markdown_heading_spec.rb @@ -9,26 +9,26 @@ case_no: 1, case...
Fix rubocop warning 'TrailingComma' in to_markdown_heading
diff --git a/spec/views/projects/pipelines/show.html.haml_spec.rb b/spec/views/projects/pipelines/show.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/projects/pipelines/show.html.haml_spec.rb +++ b/spec/views/projects/pipelines/show.html.haml_spec.rb @@ -0,0 +1,51 @@+require 'spec_helper' + +describe ...
Add view specs for pipelines graph
diff --git a/ldp_testsuite_wrapper.gemspec b/ldp_testsuite_wrapper.gemspec index abc1234..def5678 100644 --- a/ldp_testsuite_wrapper.gemspec +++ b/ldp_testsuite_wrapper.gemspec @@ -22,8 +22,8 @@ spec.add_dependency "faraday" spec.add_dependency "ruby-progressbar" - spec.add_development_dependency "bundler", "~>...
Update bundler and rake versions in gemspec.
diff --git a/spec/best_boy_spec.rb b/spec/best_boy_spec.rb index abc1234..def5678 100644 --- a/spec/best_boy_spec.rb +++ b/spec/best_boy_spec.rb @@ -0,0 +1,26 @@+require 'spec_helper' + +describe BestBoy do + describe 'its configuration interface' do + it 'defaults or :active_record as ORM' do + expect(BestBoy...
Add spec for configuration interface
diff --git a/spec/commands_spec.rb b/spec/commands_spec.rb index abc1234..def5678 100644 --- a/spec/commands_spec.rb +++ b/spec/commands_spec.rb @@ -16,13 +16,13 @@ it 'should successfully trigger the command' do event = double - bot.execute_command(:test, event, []) + bot.execute_command...
Call execute_command with check_permissions as false in all instances
diff --git a/spree_sitemap.gemspec b/spree_sitemap.gemspec index abc1234..def5678 100644 --- a/spree_sitemap.gemspec +++ b/spree_sitemap.gemspec @@ -16,7 +16,7 @@ s.requirements << 'none' s.add_dependency 'spree_core', '>= 1.0.0' - s.add_dependency 'sitemap_generator', '~> 3.1' + s.add_dependency 'sitemap_gene...
Upgrade sitemap_generator gem to version 4.0.1
diff --git a/lib/bluecap/handlers/event.rb b/lib/bluecap/handlers/event.rb index abc1234..def5678 100644 --- a/lib/bluecap/handlers/event.rb +++ b/lib/bluecap/handlers/event.rb @@ -16,6 +16,8 @@ key(data[:event][:name], data[:event][:timestamp]), data[:event][:id], 1) + + nil end ...
Return nil, don't want to return data to client
diff --git a/qa/qa/runtime/user.rb b/qa/qa/runtime/user.rb index abc1234..def5678 100644 --- a/qa/qa/runtime/user.rb +++ b/qa/qa/runtime/user.rb @@ -12,12 +12,14 @@ end def ssh_key - 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDFf6RYK3qu/RKF/3ndJmL5xgMLp3O9' \ - '6x8lTay+QGZ0+9FnnAXMdUqBq/ZU6d/g...
Use heredoc so it's more clear
diff --git a/lib/bra/model/component_creator.rb b/lib/bra/model/component_creator.rb index abc1234..def5678 100644 --- a/lib/bra/model/component_creator.rb +++ b/lib/bra/model/component_creator.rb @@ -4,14 +4,14 @@ module Bra module Model class ComponentCreator + include Bra::Common::Types::Validators + ...
Use validators to pass this test.
diff --git a/lib/github_cli/commands/merging.rb b/lib/github_cli/commands/merging.rb index abc1234..def5678 100644 --- a/lib/github_cli/commands/merging.rb +++ b/lib/github_cli/commands/merging.rb @@ -5,6 +5,12 @@ namespace :merge + option :base, :type => :string, :required => true, + :desc => "The...
Add specific options to merge command.
diff --git a/lib/litmus_mailer/mail_observer.rb b/lib/litmus_mailer/mail_observer.rb index abc1234..def5678 100644 --- a/lib/litmus_mailer/mail_observer.rb +++ b/lib/litmus_mailer/mail_observer.rb @@ -13,9 +13,11 @@ Rails.logger.debug "Deleting Litmus test #{existing_test['id']} (#{existing_test['name']})" ...
Add support for non-multipart emails
diff --git a/lib/locomotive/carrierwave/base.rb b/lib/locomotive/carrierwave/base.rb index abc1234..def5678 100644 --- a/lib/locomotive/carrierwave/base.rb +++ b/lib/locomotive/carrierwave/base.rb @@ -3,11 +3,16 @@ class Base def to_liquid - { - :url => self.url, - :filename =...
Fix for the performance problem when rendering carrierwave fields. Using size check only when it's needed
diff --git a/lib/pronto/rails_best_practices.rb b/lib/pronto/rails_best_practices.rb index abc1234..def5678 100644 --- a/lib/pronto/rails_best_practices.rb +++ b/lib/pronto/rails_best_practices.rb @@ -3,10 +3,10 @@ module Pronto class RailsBestPractices < Runner - def run(patches, _) - return [] unless pat...
Update runner to expect parameters via initialize
diff --git a/lib/requests/find_all_by_filter.rb b/lib/requests/find_all_by_filter.rb index abc1234..def5678 100644 --- a/lib/requests/find_all_by_filter.rb +++ b/lib/requests/find_all_by_filter.rb @@ -1,8 +1,10 @@ module HonestRenter class FindAllByFilter - def initialize(resource_name, session) + def initiali...
Add limit and offset functionality to find_all_by_rental_id
diff --git a/lib/run_keeper/activity_request.rb b/lib/run_keeper/activity_request.rb index abc1234..def5678 100644 --- a/lib/run_keeper/activity_request.rb +++ b/lib/run_keeper/activity_request.rb @@ -21,18 +21,10 @@ activities -= activities.reject { |activity| (activity.start_time > @options[:start]) && (activ...
Fix parsing of runkeeper multi-page response.
diff --git a/lib/snapshot/latest_ios_version.rb b/lib/snapshot/latest_ios_version.rb index abc1234..def5678 100644 --- a/lib/snapshot/latest_ios_version.rb +++ b/lib/snapshot/latest_ios_version.rb @@ -13,7 +13,9 @@ end matched = output.match(/iOS ([\d\.]+) \(.*/) - if matched.length > 1 + if ma...
Check for case where matched is nil. (Occurs when Xcode license agreement needs to be accepted)
diff --git a/lib/tasks/certificate_factory.rake b/lib/tasks/certificate_factory.rake index abc1234..def5678 100644 --- a/lib/tasks/certificate_factory.rake +++ b/lib/tasks/certificate_factory.rake @@ -18,7 +18,7 @@ options = { user_id: user.id, limit: ENV['LIMIT'], - jurisdiction: ENV['JURISDICTION'] || ...
Use fetch to set default
diff --git a/lib/track_sensor/newbold_dt8000.rb b/lib/track_sensor/newbold_dt8000.rb index abc1234..def5678 100644 --- a/lib/track_sensor/newbold_dt8000.rb +++ b/lib/track_sensor/newbold_dt8000.rb @@ -6,7 +6,7 @@ # @raise [IOError] if a device is not plugged in def new_race - write ' ' + write ' '...
Send 2 spaces to start a Newbold race According to Chris, you need 2 when there are only 2 lanes. Strange.
diff --git a/lib/frenetic/configuration.rb b/lib/frenetic/configuration.rb index abc1234..def5678 100644 --- a/lib/frenetic/configuration.rb +++ b/lib/frenetic/configuration.rb @@ -16,7 +16,7 @@ end def adapter - @_cfg[:adapter] || :net_http + @_cfg[:adapter] || Faraday.default_adapter end ...
Use Faraday's default adapter instead of explicitly specifying one
diff --git a/lib/onfido/requestable.rb b/lib/onfido/requestable.rb index abc1234..def5678 100644 --- a/lib/onfido/requestable.rb +++ b/lib/onfido/requestable.rb @@ -1,6 +1,9 @@ module Onfido module Requestable - def make_request(url:, payload:, method:) + def make_request(options) + url = options.fetch(:u...
Remove required keyword params to support < 2.1 version
diff --git a/lib/usps/configuration.rb b/lib/usps/configuration.rb index abc1234..def5678 100644 --- a/lib/usps/configuration.rb +++ b/lib/usps/configuration.rb @@ -1,9 +1,16 @@ module USPS + # Configuration options: + # username: Provided by the USPS during registration + # timeout: How many seconds to wait for...
Add some documentation to the config class.
diff --git a/db/migrate/20110125100508_tags.rb b/db/migrate/20110125100508_tags.rb index abc1234..def5678 100644 --- a/db/migrate/20110125100508_tags.rb +++ b/db/migrate/20110125100508_tags.rb @@ -4,8 +4,8 @@ create_table :tags do primary_key :id String :name, :null => false - Fixnum :user_id, :n...
Fix migration for ruby 2.4
diff --git a/lib/concurrent/concern/logging.rb b/lib/concurrent/concern/logging.rb index abc1234..def5678 100644 --- a/lib/concurrent/concern/logging.rb +++ b/lib/concurrent/concern/logging.rb @@ -17,7 +17,12 @@ def log(level, progname, message = nil, &block) #NOTE: Cannot require 'concurrent/configurati...
Fix uninitialized instance variable warning
diff --git a/app/models/due_item.rb b/app/models/due_item.rb index abc1234..def5678 100644 --- a/app/models/due_item.rb +++ b/app/models/due_item.rb @@ -2,4 +2,8 @@ include MyplaceonlineActiveRecordIdentityConcern belongs_to :calendar + + def final_search_result + self.calendar + end end
Add due items to full text search results
diff --git a/app/models/metering.rb b/app/models/metering.rb index abc1234..def5678 100644 --- a/app/models/metering.rb +++ b/app/models/metering.rb @@ -7,6 +7,22 @@ relevant_fields.each do |field| next unless self.class.report_col_options.include?(field) group, source, * = field.split('_') + + i...
Fix mapping string field to ChargeableField
diff --git a/test/client/metrics.rb b/test/client/metrics.rb index abc1234..def5678 100644 --- a/test/client/metrics.rb +++ b/test/client/metrics.rb @@ -4,7 +4,7 @@ app_coverage:100, test_coverage:100, line_ratio:1.8, - hits_ratio:5.8 + hits_ratio:5.0 } MAX = {
Reduce client-side min hits-ratio metric
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -1,7 +1,7 @@ CarrierWave.configure do |config| config.permissions = 0666 config.directory_permissions = 0777 - co...
Switch from :file to :fog for storage in initializer
diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb index abc1234..def5678 100644 --- a/config/initializers/inflections.rb +++ b/config/initializers/inflections.rb @@ -14,3 +14,7 @@ # ActiveSupport::Inflector.inflections(:en) do |inflect| # inflect.acronym 'RESTful' # end + +ActiveS...
Add a custom inflector for Medical Equipment
diff --git a/examples/media_with_external_file.rb b/examples/media_with_external_file.rb index abc1234..def5678 100644 --- a/examples/media_with_external_file.rb +++ b/examples/media_with_external_file.rb @@ -0,0 +1,26 @@+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) +require 'awesome_print' +require 'coll...
Add example media post with external url
diff --git a/lib/endpoint_base/sinatra/base.rb b/lib/endpoint_base/sinatra/base.rb index abc1234..def5678 100644 --- a/lib/endpoint_base/sinatra/base.rb +++ b/lib/endpoint_base/sinatra/base.rb @@ -8,7 +8,7 @@ include EndpointBase::Concerns::ExceptionHandler get '/' do - 'ok\n' + "#{self.cla...
Print sinatra class name on status response
diff --git a/lib/facebook_ads/models/ad_set.rb b/lib/facebook_ads/models/ad_set.rb index abc1234..def5678 100644 --- a/lib/facebook_ads/models/ad_set.rb +++ b/lib/facebook_ads/models/ad_set.rb @@ -4,6 +4,6 @@ module FacebookAds class AdSet < FacebookAds::Model field :targeting - field :created_at + field ...
Use actual field name from Facebook
diff --git a/lib/shinseibank/cli/subcommand.rb b/lib/shinseibank/cli/subcommand.rb index abc1234..def5678 100644 --- a/lib/shinseibank/cli/subcommand.rb +++ b/lib/shinseibank/cli/subcommand.rb @@ -3,9 +3,9 @@ class ShinseiBank module CLI class Subcommand < Thor - DEFAULT_CREDENTIALS_PATH = "./shinsei_accou...
Allow passing credentials via environment variables
diff --git a/recipes/repository.rb b/recipes/repository.rb index abc1234..def5678 100644 --- a/recipes/repository.rb +++ b/recipes/repository.rb @@ -18,7 +18,7 @@ # case node['platform_family'] -when 'fedora', 'rhel', 'amazon' +when %w(centos redhat scientific oracle fedora amazon) include_recipe 'yum-atomic' wh...
Fix foodcritic warning for platforms (FC024)
diff --git a/fastlane/lib/update_native_sdks.rb b/fastlane/lib/update_native_sdks.rb index abc1234..def5678 100644 --- a/fastlane/lib/update_native_sdks.rb +++ b/fastlane/lib/update_native_sdks.rb @@ -26,6 +26,14 @@ mode: :append, text: "\n s.header_dir = \"Branch\"" ) + + ...
Adjust Branch-SDK paths relative to submodule
diff --git a/lib/dog.rb b/lib/dog.rb index abc1234..def5678 100644 --- a/lib/dog.rb +++ b/lib/dog.rb @@ -1,7 +1,12 @@ class Dog - attr_accessor :name + attr_accessor :name, :fangs def initialize(name="Pochi") @name = name + @fangs = 2 + end + + def alived? + true end end
Fix codes to pass tests
diff --git a/spec/sequence_spec.rb b/spec/sequence_spec.rb index abc1234..def5678 100644 --- a/spec/sequence_spec.rb +++ b/spec/sequence_spec.rb @@ -4,7 +4,7 @@ describe PGExaminer do it "should be able to tell when a sequence exists" do - a = examine "" + a = examine "SELECT 1" # No-op. b = examine <...
Fix spec failure on JRuby.
diff --git a/lib/odo.rb b/lib/odo.rb index abc1234..def5678 100644 --- a/lib/odo.rb +++ b/lib/odo.rb @@ -17,6 +17,11 @@ html = Html.for url, considering: { assets: assets } + unless File.directory? target + FileUtils.mkdir_p target + end + + File.open("#{target}/index.html", 'w') { |f| f.write htm...
Write the modified HTML to a file.
diff --git a/twg.gemspec b/twg.gemspec index abc1234..def5678 100644 --- a/twg.gemspec +++ b/twg.gemspec @@ -10,6 +10,6 @@ s.add_dependency 'cinch', '>= 2.0.5' s.add_dependency 'cinchize' - s.add_dependency 'i18n' + s.add_dependency 'i18n', '0.6.4' s.add_dependency 'httparty' end
Fix i18n gem to 0.6.4
diff --git a/spec/puppet-lint/plugins/ghostbuster_defines_spec.rb b/spec/puppet-lint/plugins/ghostbuster_defines_spec.rb index abc1234..def5678 100644 --- a/spec/puppet-lint/plugins/ghostbuster_defines_spec.rb +++ b/spec/puppet-lint/plugins/ghostbuster_defines_spec.rb @@ -11,35 +11,28 @@ end describe 'ghostbuster_de...
Revert ghostbuster_defines unit test logic
diff --git a/spec/serializers/all_aboard/board_serializer_spec.rb b/spec/serializers/all_aboard/board_serializer_spec.rb index abc1234..def5678 100644 --- a/spec/serializers/all_aboard/board_serializer_spec.rb +++ b/spec/serializers/all_aboard/board_serializer_spec.rb @@ -4,5 +4,6 @@ let(:board) { FactoryGirl.create(...
Add missing spec for board ID in serializer. Forgot to add that as I was handfighting Ember.
diff --git a/lib/docs/scrapers/react_native.rb b/lib/docs/scrapers/react_native.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/react_native.rb +++ b/lib/docs/scrapers/react_native.rb @@ -3,7 +3,7 @@ self.name = 'React Native' self.slug = 'react_native' self.type = 'react' - self.release = '0....
Update React Native documentation (0.35)
diff --git a/lib/reek/logging_error_handler.rb b/lib/reek/logging_error_handler.rb index abc1234..def5678 100644 --- a/lib/reek/logging_error_handler.rb +++ b/lib/reek/logging_error_handler.rb @@ -10,7 +10,7 @@ when Errors::BaseError warn exception.long_message else - warn exception + ...
Make conversion from exception to string explicit JRuby does not perform automatic conversion from RuntimeError to String.