diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/redirects_controller.rb b/app/controllers/redirects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/redirects_controller.rb +++ b/app/controllers/redirects_controller.rb @@ -6,7 +6,7 @@ redirect.used! redirect_to redirect.destination_uri, status: redirect.stat...
Fix deprecation warning about using render: text
diff --git a/app/controllers/resources_controller.rb b/app/controllers/resources_controller.rb index abc1234..def5678 100644 --- a/app/controllers/resources_controller.rb +++ b/app/controllers/resources_controller.rb @@ -14,7 +14,7 @@ redirect_to root_path else flash[:error] = @resource.errors.full_me...
Change redirect to render for error message display in update and create.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -23,6 +23,17 @@ # Application configuration can go into files in config/initializers # -- all .rb files in that directory are automatically loaded after loading ...
Configure SMTP via env vars
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -12,6 +12,9 @@ # Application configuration should go into files in config/initializers # -- all .rb files in that directory are automatically loaded. + # add ...
Add validators folder to autoload paths.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -11,5 +11,6 @@ # Settings in config/environments/* take precedence over those specified here. # Application configuration should go into files in config/initialize...
Add lib directory to auto_load path
diff --git a/test/cookbooks/test/recipes/kill.rb b/test/cookbooks/test/recipes/kill.rb index abc1234..def5678 100644 --- a/test/cookbooks/test/recipes/kill.rb +++ b/test/cookbooks/test/recipes/kill.rb @@ -1,5 +1,5 @@ chef_client_updater "Install Chef #{node['chef_client_updater']['version']}" do channel 'current' - ...
Fix a typo in the property name Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/tests/rip/parsers/construct_test.rb b/tests/rip/parsers/construct_test.rb index abc1234..def5678 100644 --- a/tests/rip/parsers/construct_test.rb +++ b/tests/rip/parsers/construct_test.rb @@ -17,4 +17,9 @@ unless_condition = parser.unless_condition.parse('unless (false)') assert_equal 'false', unl...
Add test for arbitrary object in binary condition rule
diff --git a/core/app/classes/fact_url.rb b/core/app/classes/fact_url.rb index abc1234..def5678 100644 --- a/core/app/classes/fact_url.rb +++ b/core/app/classes/fact_url.rb @@ -23,11 +23,18 @@ return unless @fact.site_url proxy_url + "/?url=" + CGI.escape(@fact.site_url) + - "&factlink_id=" + URI.escape...
Use scrollto for scroll url, and open_id for sharing url
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -3,3 +3,4 @@ # Initialize the Rails application. Rails.application.initialize! +
Create .env file Create .gitignore file Add client id and secret to .env file
diff --git a/Formula/bartycrouch.rb b/Formula/bartycrouch.rb index abc1234..def5678 100644 --- a/Formula/bartycrouch.rb +++ b/Formula/bartycrouch.rb @@ -1,7 +1,7 @@ class Bartycrouch < Formula desc "Incrementally update/translate your Strings files" homepage "https://github.com/Flinesoft/BartyCrouch" - url "http...
Update formula to version 4.5.0
diff --git a/spec/controllers/rpt/badge_reports_controller_spec.rb b/spec/controllers/rpt/badge_reports_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/rpt/badge_reports_controller_spec.rb +++ b/spec/controllers/rpt/badge_reports_controller_spec.rb @@ -0,0 +1,53 @@+require "rails_helper" +requir...
Add tests for badge report
diff --git a/spec/account_spec.rb b/spec/account_spec.rb index abc1234..def5678 100644 --- a/spec/account_spec.rb +++ b/spec/account_spec.rb @@ -29,6 +29,18 @@ Account.count.must_equal 5 end + it 'has the correct account type' do + Account.count.must_equal 0 + + %w{asset liability revenue expe...
Add test to check account type
diff --git a/spec/slacken_spec.rb b/spec/slacken_spec.rb index abc1234..def5678 100644 --- a/spec/slacken_spec.rb +++ b/spec/slacken_spec.rb @@ -5,6 +5,9 @@ subject { described_class.translate(source) } let(:source) { fixture('example.html') } + # This test checks whether the behavior of this translation ...
Add a description of `scripts/update_markup_fixture.rb`
diff --git a/spec/buckaroo_client/service/credit_management_spec.rb b/spec/buckaroo_client/service/credit_management_spec.rb index abc1234..def5678 100644 --- a/spec/buckaroo_client/service/credit_management_spec.rb +++ b/spec/buckaroo_client/service/credit_management_spec.rb @@ -9,7 +9,7 @@ end it 'raises e...
Fix spec error and deprecation warning
diff --git a/spec/features/embed_stats_spec.rb b/spec/features/embed_stats_spec.rb index abc1234..def5678 100644 --- a/spec/features/embed_stats_spec.rb +++ b/spec/features/embed_stats_spec.rb @@ -0,0 +1,12 @@+# frozen_string_literal: true + +require 'rails_helper' + +describe 'course stats embed page', type: :feature,...
Add spec for embedded course stats
diff --git a/sauce-connect.rb b/sauce-connect.rb index abc1234..def5678 100644 --- a/sauce-connect.rb +++ b/sauce-connect.rb @@ -3,8 +3,8 @@ class SauceConnect < Formula homepage "https://docs.saucelabs.com/reference/sauce-connect/" - url "https://saucelabs.com/downloads/sc-4.3.11-osx.zip" - sha1 "5d0aa851d21f3d...
Upgrade to Sauce Connect 4.3.13
diff --git a/PINRemoteImage.podspec b/PINRemoteImage.podspec index abc1234..def5678 100644 --- a/PINRemoteImage.podspec +++ b/PINRemoteImage.podspec @@ -9,12 +9,12 @@ Pod::Spec.new do |s| s.name = "PINRemoteImage" - s.version = "1.1.1" + s.version = "1.1.2" s.summary = "...
Update podspec for 1.1.2 release
diff --git a/spec/knapsack/task_loader_spec.rb b/spec/knapsack/task_loader_spec.rb index abc1234..def5678 100644 --- a/spec/knapsack/task_loader_spec.rb +++ b/spec/knapsack/task_loader_spec.rb @@ -2,11 +2,13 @@ describe '#load_tasks' do let(:rspec_rake_task_path) { "#{Knapsack.root}/lib/tasks/knapsack_rspec.rake...
Fix spec for task loader
diff --git a/spec/mobility/accumulator_spec.rb b/spec/mobility/accumulator_spec.rb index abc1234..def5678 100644 --- a/spec/mobility/accumulator_spec.rb +++ b/spec/mobility/accumulator_spec.rb @@ -23,13 +23,20 @@ end describe "#backends" do - it "returns backend class for given attribute name" do + before ...
Add spec checking KeyError on mobility.backends
diff --git a/SAMContentMode.podspec b/SAMContentMode.podspec index abc1234..def5678 100644 --- a/SAMContentMode.podspec +++ b/SAMContentMode.podspec @@ -1,14 +1,14 @@ Pod::Spec.new do |spec| spec.name = 'SAMContentMode' - spec.version = '0.1.1' + spec.version = '0.1.2' spec.authors = {'Sam Soffes' => 'sam@soff....
Support for Mac. Version 0.1.2
diff --git a/spec/unit/executable_file_spec.rb b/spec/unit/executable_file_spec.rb index abc1234..def5678 100644 --- a/spec/unit/executable_file_spec.rb +++ b/spec/unit/executable_file_spec.rb @@ -1,13 +1,19 @@ # frozen_string_literal: true -RSpec.describe TTY::Which, '#executable_file?' do - it "checks if file is e...
Change to check global executable without directory parameter
diff --git a/config/initializers/secret_token.rb b/config/initializers/secret_token.rb index abc1234..def5678 100644 --- a/config/initializers/secret_token.rb +++ b/config/initializers/secret_token.rb @@ -9,4 +9,4 @@ # Make sure your secret_key_base is kept private # if you're sharing your code publicly. -SoprPlatfo...
Change to read secret_key from env. variable or fallback to current key
diff --git a/lib/aws/plugins/json_serializer.rb b/lib/aws/plugins/json_serializer.rb index abc1234..def5678 100644 --- a/lib/aws/plugins/json_serializer.rb +++ b/lib/aws/plugins/json_serializer.rb @@ -29,7 +29,9 @@ context.http_request.headers['X-Amz-Target'] = target super(context).on_complete do |r...
Handle empty body for JSON parsing
diff --git a/lib/flail/rails/action_dispatch.rb b/lib/flail/rails/action_dispatch.rb index abc1234..def5678 100644 --- a/lib/flail/rails/action_dispatch.rb +++ b/lib/flail/rails/action_dispatch.rb @@ -8,8 +8,15 @@ end module InstanceMethods - def render_exception(env, exception) - Flail::...
Fix render_exception method signature for Rails 5
diff --git a/lib/junos-ez/facts/switch_style.rb b/lib/junos-ez/facts/switch_style.rb index abc1234..def5678 100644 --- a/lib/junos-ez/facts/switch_style.rb +++ b/lib/junos-ez/facts/switch_style.rb @@ -8,6 +8,12 @@ :NONE when /^(ex9)|(ex43)/i :VLAN_L2NG + when /^(qfx5)|(qfx3)/i + if facts[...
Fix for PR 945745. Update switch style value for QFX device based on Junos software version
diff --git a/lib/minitest-spec-rails/railtie.rb b/lib/minitest-spec-rails/railtie.rb index abc1234..def5678 100644 --- a/lib/minitest-spec-rails/railtie.rb +++ b/lib/minitest-spec-rails/railtie.rb @@ -5,25 +5,24 @@ config.minitest_spec_rails.mini_shoulda = false config.before_initialize do |app| - i...
Change initializers around to always require ActiveSupport first.
diff --git a/test/factories/projects_factory.rb b/test/factories/projects_factory.rb index abc1234..def5678 100644 --- a/test/factories/projects_factory.rb +++ b/test/factories/projects_factory.rb @@ -2,6 +2,7 @@ factory :project do unit campus + user after(:build) do |project| project.tuto...
ENHANCE: Add user to project factory
diff --git a/test/test_belongs_to_association.rb b/test/test_belongs_to_association.rb index abc1234..def5678 100644 --- a/test/test_belongs_to_association.rb +++ b/test/test_belongs_to_association.rb @@ -14,4 +14,16 @@ assert_equal 42, @other.account_id end + + def test_does_not_inherit_when_parent_not_prese...
Add a few more tests
diff --git a/db/fixtures/development/01_admin.rb b/db/fixtures/development/01_admin.rb index abc1234..def5678 100644 --- a/db/fixtures/development/01_admin.rb +++ b/db/fixtures/development/01_admin.rb @@ -3,6 +3,7 @@ s.id = 1 s.name = 'Administrator' s.email = 'admin@example.com' + s.notification_email...
Fix dev fixture for admin
diff --git a/week-9/ruby-review-1/ruby_review.rb b/week-9/ruby-review-1/ruby_review.rb index abc1234..def5678 100644 --- a/week-9/ruby-review-1/ruby_review.rb +++ b/week-9/ruby-review-1/ruby_review.rb @@ -0,0 +1,102 @@+# First Ruby Review + +# I worked on this challenge [with: Darius Atmar]. +# This challenge took me [...
Copy the code from coderpad and do another refactor.
diff --git a/spec/app_spec.rb b/spec/app_spec.rb index abc1234..def5678 100644 --- a/spec/app_spec.rb +++ b/spec/app_spec.rb @@ -32,6 +32,13 @@ log.should include("Run completed") end + it "should log to debug on the cleanup step" do + Example.logger.level = Logger::DEBUG + + @app.run + log.should in...
Add additional spec to App to test debug output
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,5 +1,5 @@ class HomeController < ApplicationController def index - @studies = Study.order(:updated_at).page par...
Sort studies recently updated first, show 10 per page
diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tags_controller.rb +++ b/app/controllers/tags_controller.rb @@ -1,5 +1,17 @@ class TagsController < ApplicationController + before_action :set_tag + def show - @tag = Tag.find_...
Add destroy action to tags.
diff --git a/lib/folio/engine.rb b/lib/folio/engine.rb index abc1234..def5678 100644 --- a/lib/folio/engine.rb +++ b/lib/folio/engine.rb @@ -26,13 +26,10 @@ g.helper false end - begin - config.autoload_paths << self.root.join('lib') - config.eager_load_paths << self.root.join('lib') - con...
Revert "fix duplicate loading of frozen config array" This reverts commit f3a14682df25caecf76a586afc6b1883f7d4cc6b.
diff --git a/app/controllers/books_controller.rb b/app/controllers/books_controller.rb index abc1234..def5678 100644 --- a/app/controllers/books_controller.rb +++ b/app/controllers/books_controller.rb @@ -1,8 +1,12 @@ class BooksController < ApplicationController get '/books' do - @user = User.find(session[:use...
Add conditional to /books controller action so that only account holders can access book index
diff --git a/app/serializers/user_serializer.rb b/app/serializers/user_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/user_serializer.rb +++ b/app/serializers/user_serializer.rb @@ -18,10 +18,4 @@ def last_online object.last_request_at.iso8601 if object.last_request_at? end - - cached - - ...
Remove caching from user serializer, last_request_at doesn't break the cache
diff --git a/lib/archiving.rb b/lib/archiving.rb index abc1234..def5678 100644 --- a/lib/archiving.rb +++ b/lib/archiving.rb @@ -6,17 +6,22 @@ t0 = date.to_datetime t1 = t0.next_day deliveries = Delivery.where(created_at: t0..t1).includes(:links, :click_events, :open_events, :address, :postfix_log_lines, ...
Delete archived emails and don't archive if no emails
diff --git a/app/models/repository/destroying.rb b/app/models/repository/destroying.rb index abc1234..def5678 100644 --- a/app/models/repository/destroying.rb +++ b/app/models/repository/destroying.rb @@ -1,5 +1,11 @@ module Repository::Destroying extend ActiveSupport::Concern + + included do + scope :destroying...
Add scopes and default scope, adjust migrations.
diff --git a/app/models/spree/order_decorator.rb b/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/order_decorator.rb +++ b/app/models/spree/order_decorator.rb @@ -1,5 +1,7 @@ Spree::Order.class_eval do include ActiveSupport::Callbacks + + after_update :destroy_empty_shipmen...
Destroy empty shipments after updating
diff --git a/app/serializers/guide_serializer.rb b/app/serializers/guide_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/guide_serializer.rb +++ b/app/serializers/guide_serializer.rb @@ -10,6 +10,7 @@ attribute :featured_image do if object.featured_image { + canopy_url: object.pic...
Add canopy image guide serializer
diff --git a/dev_environment/roles/dev.rb b/dev_environment/roles/dev.rb index abc1234..def5678 100644 --- a/dev_environment/roles/dev.rb +++ b/dev_environment/roles/dev.rb @@ -9,5 +9,6 @@ "recipe[adam::apt-update]", "recipe[mongodb::default]", "recipe[rabbitmq]", + "recipe[rabbitmq::mgmt_console]", "recipe...
[DEV] Add the rabbitmq management plugin
diff --git a/lib/redfish/util.rb b/lib/redfish/util.rb index abc1234..def5678 100644 --- a/lib/redfish/util.rb +++ b/lib/redfish/util.rb @@ -17,7 +17,9 @@ class << self # Generate a random password with lowercase, uppercase and numeric values def generate_password(size = 10) - size.times.map { ...
Update code so it runs in earlier version of jruby
diff --git a/lib/vpaid_parser.rb b/lib/vpaid_parser.rb index abc1234..def5678 100644 --- a/lib/vpaid_parser.rb +++ b/lib/vpaid_parser.rb @@ -1,5 +1,62 @@ require 'vpaid_parser/version' +require 'nokogiri' +require 'open-uri' class VpaidParser - # Your code goes here... + + def initialize(url) + begin + @va...
Add classifying and unwrapping logic
diff --git a/activeresource.gemspec b/activeresource.gemspec index abc1234..def5678 100644 --- a/activeresource.gemspec +++ b/activeresource.gemspec @@ -1,4 +1,4 @@-version = File.read("../RAILS_VERSION").strip +version = File.read(File.expand_path("../../RAILS_VERSION", __FILE__)).strip Gem::Specification.new do |s...
Load RAILS_VERSION relative to the gemspec file.
diff --git a/lib/api-client/parser.rb b/lib/api-client/parser.rb index abc1234..def5678 100644 --- a/lib/api-client/parser.rb +++ b/lib/api-client/parser.rb @@ -1,3 +1,5 @@+require 'json' + # ApiClient::Parser provides a method to parse the request response. module ApiClient::Parser # Parse the JSON response. @@ -...
Fix for 'uninitialized constant JSON (NameError)'
diff --git a/app/models/notifier.rb b/app/models/notifier.rb index abc1234..def5678 100644 --- a/app/models/notifier.rb +++ b/app/models/notifier.rb @@ -10,7 +10,7 @@ end def occurence_report(user, occurence, sent_at = Time.now) - subject "[#{occurence.error.project.name}] An error occured" + subject ...
Include the error id in the mail title
diff --git a/app/models/api_key.rb b/app/models/api_key.rb index abc1234..def5678 100644 --- a/app/models/api_key.rb +++ b/app/models/api_key.rb @@ -9,6 +9,7 @@ # class ApiKey < ActiveRecord::Base + attr_accessible :access_token before_create :generate_access_token private
Allow editing of api key access token
diff --git a/app/models/listing.rb b/app/models/listing.rb index abc1234..def5678 100644 --- a/app/models/listing.rb +++ b/app/models/listing.rb @@ -7,18 +7,10 @@ has_many :donation_applications, dependent: :destroy has_many :applicants, through: :donation_applications + validates_presence_of :title, :creator +...
Fix bug in Listing importer required headers Add validation to Listing so listings that don't include the required fields will not be saved.
diff --git a/lib/inch/rake/suggest.rb b/lib/inch/rake/suggest.rb index abc1234..def5678 100644 --- a/lib/inch/rake/suggest.rb +++ b/lib/inch/rake/suggest.rb @@ -2,6 +2,7 @@ require "rake" require "rake/tasklib" +require "inch/cli" module Inch # Holds all Rake tasks
Fix error in Rake task (thanks @tabolario) Inch::CLI needs to be required manually (see CHANGELOG for 0.4.7). Fixes #24
diff --git a/lib/parrot/file_cache.rb b/lib/parrot/file_cache.rb index abc1234..def5678 100644 --- a/lib/parrot/file_cache.rb +++ b/lib/parrot/file_cache.rb @@ -0,0 +1,27 @@+require 'digest' +require 'singleton' + +class FileCache + + include Singleton + + attr_accessor :cache + + def initialize + @cache = {} + ...
Add file cache for checking the content change
diff --git a/lib/resync/xml/parser.rb b/lib/resync/xml/parser.rb index abc1234..def5678 100644 --- a/lib/resync/xml/parser.rb +++ b/lib/resync/xml/parser.rb @@ -2,10 +2,7 @@ module Resync module XML - class Parser - - # ------------------------------ - # Public methods + module Parser # @r...
Change Parser from class to module
diff --git a/lib/rspec_sequel/base.rb b/lib/rspec_sequel/base.rb index abc1234..def5678 100644 --- a/lib/rspec_sequel/base.rb +++ b/lib/rspec_sequel/base.rb @@ -15,7 +15,7 @@ @prefix = "expected #{target.inspect} to" valid?(target.db, target, target.class, @attribute, @options) else - @pr...
Use .classify instead of .singularize.humanize
diff --git a/lib/w3clove/validator.rb b/lib/w3clove/validator.rb index abc1234..def5678 100644 --- a/lib/w3clove/validator.rb +++ b/lib/w3clove/validator.rb @@ -3,10 +3,12 @@ # for all pages on a sitemap and output the errors # module W3Clove - class Validator + module Validator + extend self + ## # Pa...
Make Validator class a module as it doesn't need to be instantiated
diff --git a/lib/maskable_attribute/maskable_attribute.rb b/lib/maskable_attribute/maskable_attribute.rb index abc1234..def5678 100644 --- a/lib/maskable_attribute/maskable_attribute.rb +++ b/lib/maskable_attribute/maskable_attribute.rb @@ -16,7 +16,7 @@ value = unmasked if !value.blank? and value.match(/\...
Fix Failing Number Mask Value Fix the Maskable Attribute to accommodate the failing test where the resulting value for a mask could end up being a number rather than a string.
diff --git a/lib/attr_deprecated.rb b/lib/attr_deprecated.rb index abc1234..def5678 100644 --- a/lib/attr_deprecated.rb +++ b/lib/attr_deprecated.rb @@ -1,22 +1,48 @@ require "attr_deprecated/version" require 'active_support' +require 'active_record' +require 'active_model' module AttrDeprecated - module Model +...
Define and test deprecation behavior for a getter method
diff --git a/lib/mongo_benchpress/mongo_ruby_driver_bp.rb b/lib/mongo_benchpress/mongo_ruby_driver_bp.rb index abc1234..def5678 100644 --- a/lib/mongo_benchpress/mongo_ruby_driver_bp.rb +++ b/lib/mongo_benchpress/mongo_ruby_driver_bp.rb @@ -11,7 +11,7 @@ }, :insert_batch => Proc.new { |coll, object, i| ...
Update batch insert to be identical to original ruby test
diff --git a/lib/rooftop/algolia_search/post_searching.rb b/lib/rooftop/algolia_search/post_searching.rb index abc1234..def5678 100644 --- a/lib/rooftop/algolia_search/post_searching.rb +++ b/lib/rooftop/algolia_search/post_searching.rb @@ -5,23 +5,13 @@ def self.included(base) base.extend ClassMethods ...
Add a search class method
diff --git a/lib/route_translator/extensions/route_set.rb b/lib/route_translator/extensions/route_set.rb index abc1234..def5678 100644 --- a/lib/route_translator/extensions/route_set.rb +++ b/lib/route_translator/extensions/route_set.rb @@ -11,13 +11,23 @@ translated_path_ast = ::ActionDispatch::Journey::Pars...
Add support for Rails 5.1.0.rc1 An internal change in actionpack removed a couple of unused parameters from the add_route method signature. This commit reflect that change. Close: #163 Ref: ccfa785535d912c3529b0562d9f2e7a2dc4b7ed7@6ddd65c9f366c5bca70cfce770d144e2fca1e679
diff --git a/app/models/ontology.rb b/app/models/ontology.rb index abc1234..def5678 100644 --- a/app/models/ontology.rb +++ b/app/models/ontology.rb @@ -10,6 +10,8 @@ belongs_to :owner, :polymorphic => true has_many :versions, :class_name => 'OntologyVersion' + + attr_accessible :uri, :name, :description ...
Whitelist uri, name, description for mass-assignability on Ontology.
diff --git a/lib/templates/new_project/site/blog/_init.rb b/lib/templates/new_project/site/blog/_init.rb index abc1234..def5678 100644 --- a/lib/templates/new_project/site/blog/_init.rb +++ b/lib/templates/new_project/site/blog/_init.rb @@ -5,7 +5,7 @@ # In this simple example, we're simply adding some convenience meth...
Fix new project template ;-)
diff --git a/lib/test_after_commit/database_statements.rb b/lib/test_after_commit/database_statements.rb index abc1234..def5678 100644 --- a/lib/test_after_commit/database_statements.rb +++ b/lib/test_after_commit/database_statements.rb @@ -9,9 +9,9 @@ @_current_transaction_records.push([]) if @_current_trans...
Raise an exception without a variable
diff --git a/lib/yard/generators/helpers/method_helper.rb b/lib/yard/generators/helpers/method_helper.rb index abc1234..def5678 100644 --- a/lib/yard/generators/helpers/method_helper.rb +++ b/lib/yard/generators/helpers/method_helper.rb @@ -0,0 +1,36 @@+module YARD + module Generators::Helpers + module MethodHelper...
Create MethodHelper for specific method formatting helper methods
diff --git a/lib/redshift_cursor.rb b/lib/redshift_cursor.rb index abc1234..def5678 100644 --- a/lib/redshift_cursor.rb +++ b/lib/redshift_cursor.rb @@ -1,8 +1,12 @@ require 'redshift_cursor/version' -require 'redshift_cursor/active_record/connection_adapters/redshift_type_map' -require 'postgresql_cursor' +require '...
Use ActiveSupport.on_load hook instead of eagerly loading external dependencies
diff --git a/lib/salesforce_bulk.rb b/lib/salesforce_bulk.rb index abc1234..def5678 100644 --- a/lib/salesforce_bulk.rb +++ b/lib/salesforce_bulk.rb @@ -12,69 +12,4 @@ require 'salesforce_bulk/batch' require 'salesforce_bulk/batch_result' require 'salesforce_bulk/batch_result_collection' -require 'salesforce_bulk/que...
Delete old Api class from root file as its been replaced by the new Client class. Researching other popular gems this file seems to be empty as a standard perhaps? Best practice?
diff --git a/lib/storey/migrator.rb b/lib/storey/migrator.rb index abc1234..def5678 100644 --- a/lib/storey/migrator.rb +++ b/lib/storey/migrator.rb @@ -14,6 +14,7 @@ def migrate(schema, options={}) Storey.switch schema do + puts "= Migrating #{schema}" ::ActiveRecord::Migrator.migrate(::Ac...
Add notice about which schema is being migrated
diff --git a/lib/tasks/install.rake b/lib/tasks/install.rake index abc1234..def5678 100644 --- a/lib/tasks/install.rake +++ b/lib/tasks/install.rake @@ -1,9 +1,8 @@ namespace :orientation do desc "Install a fresh new Orientation" task install: :environment do + cp '.env.example', '.env' cp 'config/databas...
Fix order dependency issue and unnecessary config in setup task
diff --git a/lib/trashed/railtie.rb b/lib/trashed/railtie.rb index abc1234..def5678 100644 --- a/lib/trashed/railtie.rb +++ b/lib/trashed/railtie.rb @@ -28,8 +28,8 @@ app.config.trashed.gauge_sample_rate ||= 0.05 app.config.trashed.logger ||= Rails.logger - app.middleware.insert_after 'Rack::Runtime...
Fix deprecation warnings from Rails This commit fixes the deprecation warnings coming from inserting middleware. This just removes the quotes, per the deprecation warning: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For e...
diff --git a/Casks/firefoxdeveloperedition.rb b/Casks/firefoxdeveloperedition.rb index abc1234..def5678 100644 --- a/Casks/firefoxdeveloperedition.rb +++ b/Casks/firefoxdeveloperedition.rb @@ -5,6 +5,7 @@ url "https://download.mozilla.org/?product=firefox-aurora-latest-ssl&os=osx&lang=en-US" homepage 'https://www....
Add tag stanza to Firefox Developer Edition
diff --git a/app/concerns/authentication/api.rb b/app/concerns/authentication/api.rb index abc1234..def5678 100644 --- a/app/concerns/authentication/api.rb +++ b/app/concerns/authentication/api.rb @@ -37,11 +37,11 @@ rescue JWT::ExpiredSignature error = {message: "Authorization token has expired."} re...
Fix Redundant Return issue with token decoding method
diff --git a/recipes/openstack-db.rb b/recipes/openstack-db.rb index abc1234..def5678 100644 --- a/recipes/openstack-db.rb +++ b/recipes/openstack-db.rb @@ -24,12 +24,12 @@ db_create_with_user( "identity", node["openstack"]["identity"]["db"]["username"], - db_password("keystone") + get_password "db", "keystone"...
Move from db_password to get_password
diff --git a/scripts/users.rb b/scripts/users.rb index abc1234..def5678 100644 --- a/scripts/users.rb +++ b/scripts/users.rb @@ -1,4 +1,4 @@-require_relative '../lib/fogbugz/fogbugz' +require 'fogbugz' interface = Fogbugz::Interface.new(YAML.load_file('config.yml')[:fogbugz]) interface.authenticate
Update Users script to reflect Fogbugz extraction
diff --git a/spec/afip_bill/check_digit_spec.rb b/spec/afip_bill/check_digit_spec.rb index abc1234..def5678 100644 --- a/spec/afip_bill/check_digit_spec.rb +++ b/spec/afip_bill/check_digit_spec.rb @@ -0,0 +1,43 @@+require 'spec_helper' +require "afip_bill/check_digit" + +describe AfipBill::CheckDigit do + subject { de...
Test coverage for CheckDigit class
diff --git a/spec/classes/trove_db_sync_spec.rb b/spec/classes/trove_db_sync_spec.rb index abc1234..def5678 100644 --- a/spec/classes/trove_db_sync_spec.rb +++ b/spec/classes/trove_db_sync_spec.rb @@ -0,0 +1,42 @@+require 'spec_helper' + +describe 'trove::db::sync' do + + shared_examples_for 'trove-dbsync' do + + i...
Add unit test for sync.pp Change-Id: I9ac96d91693eaf066e4674a63199286063ef6f28 Closes-Bug: #1689241
diff --git a/config/initializers/check_submodules.rb b/config/initializers/check_submodules.rb index abc1234..def5678 100644 --- a/config/initializers/check_submodules.rb +++ b/config/initializers/check_submodules.rb @@ -0,0 +1,30 @@+# encoding: utf-8 +#-- +# Copyright (C) 2012 Gitorious AS +# +# This program is fr...
Add initializer to notify users of missing submodules
diff --git a/spec/models/commit_request_spec.rb b/spec/models/commit_request_spec.rb index abc1234..def5678 100644 --- a/spec/models/commit_request_spec.rb +++ b/spec/models/commit_request_spec.rb @@ -14,7 +14,9 @@ }] } cr = CommitRequest.new(value) - cr.should be_valid + cr.should ...
Add expectation of enqueue in commit request spec
diff --git a/spec/state_machine-mongoid_spec.rb b/spec/state_machine-mongoid_spec.rb index abc1234..def5678 100644 --- a/spec/state_machine-mongoid_spec.rb +++ b/spec/state_machine-mongoid_spec.rb @@ -13,35 +13,34 @@ context "new vehicle" do before(:each) do - @vehicle = Vehicle.new + @vehicle = Vehi...
Clear up the specs a tiny bit
diff --git a/testing/lib/refinerycms-testing.rb b/testing/lib/refinerycms-testing.rb index abc1234..def5678 100644 --- a/testing/lib/refinerycms-testing.rb +++ b/testing/lib/refinerycms-testing.rb @@ -1,5 +1,4 @@ require 'refinerycms-core' -require 'rspec-rails' require 'refinery/generators/testing_generator' modul...
Remove initializer that loads refinery tests into rspec runlist We don't want users running Refinery's tests when they are just running rake rspec from within their application
diff --git a/canon-interpreter.rb b/canon-interpreter.rb index abc1234..def5678 100644 --- a/canon-interpreter.rb +++ b/canon-interpreter.rb @@ -25,11 +25,12 @@ puts "Warning: empty canon given." else num_beats = canon[0][0].length - for i in 0..voices - 1 - sleep i * num_beats + voices.times do ...
Fix interpreter to have right number of voices.
diff --git a/app/models/tag_list.rb b/app/models/tag_list.rb index abc1234..def5678 100644 --- a/app/models/tag_list.rb +++ b/app/models/tag_list.rb @@ -1,5 +1,4 @@ # encoding: utf-8 -require 'shellwords' # The TagList class is used to convert a string to an array of tags. # @@ -10,19 +9,13 @@ # taglist = TagLi...
Allow some more characters to tags
diff --git a/Lipstick.podspec b/Lipstick.podspec index abc1234..def5678 100644 --- a/Lipstick.podspec +++ b/Lipstick.podspec @@ -19,4 +19,5 @@ s.source_files = 'Source/**/*.swift' s.frameworks = 'UIKit' + s.dependency 'SwiftKitStaging' end
Add SwiftKitStaging as a dependency.
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -7,7 +7,7 @@ } node.default['bash_it']['custom_plugins'] = { - 'sprout-base' => %w( + 'sprout-bash-it' => %w( bash_it/custom/disable_ctrl-s_output_control.bash ...
Install custom plugins from bash-it repository, not sprout-base. :)
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -13,8 +13,8 @@ config.cassette_library_dir = 'spec/vcr_cassettes' config.configure_rspec_metadata! config.filter_sensitive_data("library.edu") { "library.nyu.edu" } - conf...
Clean up spec helper for style
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -7,7 +7,6 @@ require 'rubygems' require 'bundler/setup' -require 'right_on' if ENV['COVERAGE'] require 'simplecov' @@ -16,6 +15,8 @@ SimpleCov.start end +require 'rig...
Fix coverage task as it needs to load prior to library
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,7 +1,9 @@ require_relative '../lib/payment_processor' require_relative '../lib/payment_processor_connection' +require_relative '../lib/charge_response' require_relative '../li...
Add surrogate and charge response for surrogate example
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,6 +1,30 @@ # encoding: utf-8 + +require 'devtools/spec_helper' + +if ENV['COVERAGE'] == 'true' + require 'simplecov' + require 'coveralls' + + SimpleCov.formatter = SimpleCov...
Add simplecov and coveralls to ice_nine
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,27 +1,15 @@ require 'serverspec' -require 'net/ssh' - -include SpecInfra::Helper::DetectOS -include SpecInfra::Helper::Exec -include SpecInfra::Helper::Ssh if ENV['RAKE_ANS...
Update integration testing to work with Serverspec 2.N
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -18,7 +18,7 @@ end config.filter_run :focus - config.filter_run_excluding type: :feature unless ENV['S3_BUCKET_NAME'] + config.filter_run_excluding type: :feature unless E...
Check for presence of AWS_BUCKET key
diff --git a/week-9/ruby-review-2/ruby-review.rb b/week-9/ruby-review-2/ruby-review.rb index abc1234..def5678 100644 --- a/week-9/ruby-review-2/ruby-review.rb +++ b/week-9/ruby-review-2/ruby-review.rb @@ -0,0 +1,80 @@+# U2.W6: Testing Assert Statements + +# I worked on this challenge Kevin Corso. + + +# 2. Review the s...
Add ruby review pair file
diff --git a/lib/anvil/heroku/command/release.rb b/lib/anvil/heroku/command/release.rb index abc1234..def5678 100644 --- a/lib/anvil/heroku/command/release.rb +++ b/lib/anvil/heroku/command/release.rb @@ -12,7 +12,7 @@ error("Usage: heroku release SLUG_URL") unless slug_url = shift_argument validate_arguments!...
Fix hostname in "releasing to..." message Uses `heroku.host`, which is wrong - "herokuapp.com" is correct!
diff --git a/lib/iridium/commands/application.rb b/lib/iridium/commands/application.rb index abc1234..def5678 100644 --- a/lib/iridium/commands/application.rb +++ b/lib/iridium/commands/application.rb @@ -3,7 +3,7 @@ class Application < Thor include Thor::Actions - argument :app_path, :type => :string...
Refactor away from declared arguments
diff --git a/lib/itamae/resource/http_request.rb b/lib/itamae/resource/http_request.rb index abc1234..def5678 100644 --- a/lib/itamae/resource/http_request.rb +++ b/lib/itamae/resource/http_request.rb @@ -7,13 +7,9 @@ UrlNotFoundError = Class.new(StandardError) define_attribute :headers, type: Hash, defa...
Use 'required: true' on url attribute
diff --git a/lib/tasks/scheduled_publishing.rake b/lib/tasks/scheduled_publishing.rake index abc1234..def5678 100644 --- a/lib/tasks/scheduled_publishing.rake +++ b/lib/tasks/scheduled_publishing.rake @@ -29,6 +29,7 @@ begin ScheduledEditionsPublisher.publish_all_due_editions rescue ScheduledEditi...
Use Airbrake as well as ExceptionNotifier
diff --git a/spec/lib/child_benefit_tax_calculator_spec.rb b/spec/lib/child_benefit_tax_calculator_spec.rb index abc1234..def5678 100644 --- a/spec/lib/child_benefit_tax_calculator_spec.rb +++ b/spec/lib/child_benefit_tax_calculator_spec.rb @@ -14,7 +14,7 @@ :gross_pension_contributions => 10, :net_pension...
Fix syntax error in lib spec
diff --git a/spec/models/miq_worker/systemd_common_spec.rb b/spec/models/miq_worker/systemd_common_spec.rb index abc1234..def5678 100644 --- a/spec/models/miq_worker/systemd_common_spec.rb +++ b/spec/models/miq_worker/systemd_common_spec.rb @@ -0,0 +1,26 @@+RSpec.describe MiqWorker::SystemdCommon do + describe ".servi...
Add spec test for workers <=> systemd units
diff --git a/lib/halite/converter/misc.rb b/lib/halite/converter/misc.rb index abc1234..def5678 100644 --- a/lib/halite/converter/misc.rb +++ b/lib/halite/converter/misc.rb @@ -31,7 +31,7 @@ # @param output_path [String] Output path for the cookbook. # @return [void] def self.write(gem_data, output_...
Include the changelog too, if present.
diff --git a/lib/klarna_gateway/engine.rb b/lib/klarna_gateway/engine.rb index abc1234..def5678 100644 --- a/lib/klarna_gateway/engine.rb +++ b/lib/klarna_gateway/engine.rb @@ -7,17 +7,13 @@ end config.to_prepare do - require 'httplog' if Rails.env.development? Spree::PermittedAttributes.source_a...
Fix the autoload issues in dev by using to_prepare
diff --git a/lib/registerable_calendar.rb b/lib/registerable_calendar.rb index abc1234..def5678 100644 --- a/lib/registerable_calendar.rb +++ b/lib/registerable_calendar.rb @@ -3,7 +3,7 @@ class RegisterableCalendar extend Forwardable - attr_accessor :calendar, :slug, :live + attr_accessor :calendar, :slug ...
Remove unused method from registerable calendar This class used to be used by both panopticon and rummager. Now that panopticon is removed as a dependency (https://github.com/alphagov/calendars/pull/135) these methods aren't necessary anymore.
diff --git a/gstreamer/sample/gst-gi.rb b/gstreamer/sample/gst-gi.rb index abc1234..def5678 100644 --- a/gstreamer/sample/gst-gi.rb +++ b/gstreamer/sample/gst-gi.rb @@ -0,0 +1,55 @@+# Copyright (C) 2013 Ruby-GNOME2 Project Team +# +# This library is free software; you can redistribute it and/or +# modify it under the ...
Add GObject Introspection based GStreamer binding as sample
diff --git a/lib/tasks/testing_tasks.rake b/lib/tasks/testing_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/testing_tasks.rake +++ b/lib/tasks/testing_tasks.rake @@ -1,5 +1,9 @@+Rails::TestTask.new :test do |t| + t.pattern = "test/**/*_test.rb" +end + namespace :test do - Rails::TestTask.new("lib") do |t|...
Fix general rake test task
diff --git a/lib/sufia.rb b/lib/sufia.rb index abc1234..def5678 100644 --- a/lib/sufia.rb +++ b/lib/sufia.rb @@ -30,5 +30,9 @@ config.assets.paths << config.root.join('vendor', 'assets', 'fonts') config.assets.precompile << %r(vjs\.(?:eot|ttf|woff)$) + config.assets.precompile += %w( fontawesome-webfont.w...
Make sure a few required assets are explicitly listed on the asset pipeline. This removes the runtime error that asks the developer to manually add them when running the application for the very first time.