diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/dummy/app/admin/categories.rb b/spec/dummy/app/admin/categories.rb index abc1234..def5678 100644 --- a/spec/dummy/app/admin/categories.rb +++ b/spec/dummy/app/admin/categories.rb @@ -1,5 +1,10 @@ ActiveAdmin.register Category do - action_item 'state_action_category', only: :show do + action_item_a...
Fix active admin deprecated in dummy app
diff --git a/spec/features/create_match_spec.rb b/spec/features/create_match_spec.rb index abc1234..def5678 100644 --- a/spec/features/create_match_spec.rb +++ b/spec/features/create_match_spec.rb @@ -0,0 +1,21 @@+require 'spec_helper' + +feature 'Create match' do + background do + @project = create(:project, state...
Add acceptance spec for match creation
diff --git a/spec/bundler/fetcher/base_spec.rb b/spec/bundler/fetcher/base_spec.rb index abc1234..def5678 100644 --- a/spec/bundler/fetcher/base_spec.rb +++ b/spec/bundler/fetcher/base_spec.rb @@ -0,0 +1,78 @@+require "spec_helper" + +describe Bundler::Fetcher::Base do + let(:downloader) { double(:downloader) } + le...
Add unit tests for abstract `Bundler::Fetcher::Base` class
diff --git a/spec/features/auth_signin_spec.rb b/spec/features/auth_signin_spec.rb index abc1234..def5678 100644 --- a/spec/features/auth_signin_spec.rb +++ b/spec/features/auth_signin_spec.rb @@ -0,0 +1,8 @@+require 'spec_helper' +RSpec.feature "User Sign Up", :type => :feature do + scenario "A user can access the si...
Add auth_signin spec to features spec folder with test for visiting signin page
diff --git a/spec/support/description_helper.rb b/spec/support/description_helper.rb index abc1234..def5678 100644 --- a/spec/support/description_helper.rb +++ b/spec/support/description_helper.rb @@ -0,0 +1,14 @@+require 'spec_helper' + +def existing(key) + -> { instances.any key } +end + +def unknown(key) + -> { in...
DRY: Use more descriptive :existing, :unknown
diff --git a/spec/requests/healthcheck_spec.rb b/spec/requests/healthcheck_spec.rb index abc1234..def5678 100644 --- a/spec/requests/healthcheck_spec.rb +++ b/spec/requests/healthcheck_spec.rb @@ -9,16 +9,16 @@ get "/healthcheck" expect(response.status).to eq(200) - expect(data.fetch(:status)).to eq("ok")...
Make healthcheck tests less brittle I've encountered these tests [failing a][1] [few times][2] because the test environment had a long sidekiq latency. I've amended the tests so we can assert that the right tests are present, and the right structure of data is returned. The internals of the healthcheck is tested in ...
diff --git a/spec/unit/recipes/default_spec.rb b/spec/unit/recipes/default_spec.rb index abc1234..def5678 100644 --- a/spec/unit/recipes/default_spec.rb +++ b/spec/unit/recipes/default_spec.rb @@ -7,7 +7,29 @@ end.converge('chef-grafana::default') end - it 'converges successfully' do - expect { :chef_run }...
Add unit test to install a specific version. Signed-off-by: Stefan Sundin <0e17f6afaad5343e7f7d39057fdf65e398c03ec8@outreach.io>
diff --git a/test/compiler_test.rb b/test/compiler_test.rb index abc1234..def5678 100644 --- a/test/compiler_test.rb +++ b/test/compiler_test.rb @@ -9,9 +9,23 @@ @compiler = IronRubyInline::Compiler.new end - should "have temp file name for parameters output" do + should "have temp file name ...
Add Compiler with output specified context.
diff --git a/spec/models/depot_spec.rb b/spec/models/depot_spec.rb index abc1234..def5678 100644 --- a/spec/models/depot_spec.rb +++ b/spec/models/depot_spec.rb @@ -1,5 +1,10 @@ require 'spec_helper' describe Depot do - pending "add some examples to (or delete) #{__FILE__}" + before { @depot = build(:depot) } + + ...
Add a depot model spec.
diff --git a/serverspec/spec/consul_parameters.rb b/serverspec/spec/consul_parameters.rb index abc1234..def5678 100644 --- a/serverspec/spec/consul_parameters.rb +++ b/serverspec/spec/consul_parameters.rb @@ -4,12 +4,14 @@ require 'active_support' require 'net/http' require 'uri' +require 'cgi' module ConsulParame...
Modify to use CONSUL_SECRET_KEY on serverspec.
diff --git a/mrblib/Shapes.rb b/mrblib/Shapes.rb index abc1234..def5678 100644 --- a/mrblib/Shapes.rb +++ b/mrblib/Shapes.rb @@ -5,39 +5,39 @@ class Array def to_curve - Build.curve self + Siren.curve self end def to_polyline - Build.polyline self + Siren.polyline self end def to_polygo...
Update methods to each new name in Shape array.
diff --git a/tasks.rb b/tasks.rb index abc1234..def5678 100644 --- a/tasks.rb +++ b/tasks.rb @@ -11,8 +11,11 @@ sh "git submodule update" end end - sh "./codegen.py spec #{spec} lib/amqp/protocol.rb" - sh "ruby -c lib/amqp/protocol.rb" + output = "lib/amqp/protocol.rb" + sh "./codegen.py...
Test if generated file exists before checking the syntax.
diff --git a/config/initializers/spree.rb b/config/initializers/spree.rb index abc1234..def5678 100644 --- a/config/initializers/spree.rb +++ b/config/initializers/spree.rb @@ -17,8 +17,8 @@ config.searcher_class = OpenFoodNetwork::Searcher # 109 should be Australia. Hardcoded for CI (Jenkins), where countries a...
Fix error when setting up a fresh db
diff --git a/oembed.gemspec b/oembed.gemspec index abc1234..def5678 100644 --- a/oembed.gemspec +++ b/oembed.gemspec @@ -2,8 +2,8 @@ require File.expand_path('../lib/oembed/version', __FILE__) Gem::Specification.new do |gem| - gem.authors = ["Alex Soulim"] - gem.email = ["soulim@gmail.com"] + gem.au...
Update author name and email address :)
diff --git a/test/integration/users_profile_test.rb b/test/integration/users_profile_test.rb index abc1234..def5678 100644 --- a/test/integration/users_profile_test.rb +++ b/test/integration/users_profile_test.rb @@ -19,4 +19,16 @@ assert_match formatted_day(event.date), response.body end end + + test "u...
Include a display test for a user's events
diff --git a/test/ipinfodb_test.rb b/test/ipinfodb_test.rb index abc1234..def5678 100644 --- a/test/ipinfodb_test.rb +++ b/test/ipinfodb_test.rb @@ -17,10 +17,21 @@ def test_valid_api_key puts "IPINFODB_API_KEY=<your_api_key> required to run this test" unless ENV["IPINFODB_API_KEY"] + assert_nothing_raise...
Add integration test for actual geolocation i.e. use some real IP address.
diff --git a/test/models/tutorial_enrolment_test.rb b/test/models/tutorial_enrolment_test.rb index abc1234..def5678 100644 --- a/test/models/tutorial_enrolment_test.rb +++ b/test/models/tutorial_enrolment_test.rb @@ -0,0 +1,17 @@+require "test_helper" + +class TutorialEnrolmentTest < ActiveSupport::TestCase + def test...
NEW: Add tutorial enrolment model test
diff --git a/lib/bitex_bot/models/open_sell.rb b/lib/bitex_bot/models/open_sell.rb index abc1234..def5678 100644 --- a/lib/bitex_bot/models/open_sell.rb +++ b/lib/bitex_bot/models/open_sell.rb @@ -2,9 +2,11 @@ # OpenSells are open sell positions that are closed by one SellClosingFlow. # TODO: document attributes. # -...
Use nested module/class definitions instead of compact style.
diff --git a/lib/bundler/vendored_molinillo.rb b/lib/bundler/vendored_molinillo.rb index abc1234..def5678 100644 --- a/lib/bundler/vendored_molinillo.rb +++ b/lib/bundler/vendored_molinillo.rb @@ -1,3 +1,5 @@ vendor = File.expand_path('../vendor/Molinillo-0.1.0/lib', __FILE__) -$:.unshift(vendor) unless $:.include?(ven...
[VendoredMolinillo] Remove vendor path from load path after requiring
diff --git a/test/test_fizzbuzz.rb b/test/test_fizzbuzz.rb index abc1234..def5678 100644 --- a/test/test_fizzbuzz.rb +++ b/test/test_fizzbuzz.rb @@ -17,21 +17,9 @@ class TestFizzbuzz < Test::Unit::TestCase - should "say 1 for 1" do - assert_equal "1", FizzBuzz.say(1) - end - - should "say 2 for 2" do - ass...
Refactor tests to improve readability (also tests need this)
diff --git a/lib/kitno/cli.rb b/lib/kitno/cli.rb index abc1234..def5678 100644 --- a/lib/kitno/cli.rb +++ b/lib/kitno/cli.rb @@ -7,7 +7,7 @@ long_desc <<-TRANSFORM TRANSFORM - option :dry, type: :boolean, default: false + option :dry, type: :boolean, default: false, desc: 'Performs a dry run, printing ...
Add a description to --dry option
diff --git a/lib/goban.rb b/lib/goban.rb index abc1234..def5678 100644 --- a/lib/goban.rb +++ b/lib/goban.rb @@ -1,5 +1,11 @@+require "net/http" + module Goban def self.create - "http://goban.co/boards/p/269Cn0b" + uri = URI("http://goban.co/boards") + res = Net::HTTP.post_form(uri, "board[hash]" => "") ...
Create a new board with each request
diff --git a/lib/bkwrapper/backup/compressor.rb b/lib/bkwrapper/backup/compressor.rb index abc1234..def5678 100644 --- a/lib/bkwrapper/backup/compressor.rb +++ b/lib/bkwrapper/backup/compressor.rb @@ -2,7 +2,7 @@ module Backup module Compressor def compress_command - "zip /var/tmp/#{compressed_file...
Store just the name of a saved file (junk the path) By default, zip will store the full path (relative to the current path).
diff --git a/lib/time_warp.rb b/lib/time_warp.rb index abc1234..def5678 100644 --- a/lib/time_warp.rb +++ b/lib/time_warp.rb @@ -2,28 +2,28 @@ module TimeWarpAbility - def reset_to_real_time - Time.testing_offset = 0 - end + def reset_to_real_time + Time.testing_offset = 0 + end - def pretend_n...
Remove extra level of indentation
diff --git a/lib/dining-table/columns/column.rb b/lib/dining-table/columns/column.rb index abc1234..def5678 100644 --- a/lib/dining-table/columns/column.rb +++ b/lib/dining-table/columns/column.rb @@ -26,7 +26,7 @@ label = determine_label(:header) return label if label object_class = tab...
Remove dependency on Rails' human_attribute_name (check if class responds to it)
diff --git a/lib/ellen/handlers/google_image.rb b/lib/ellen/handlers/google_image.rb index abc1234..def5678 100644 --- a/lib/ellen/handlers/google_image.rb +++ b/lib/ellen/handlers/google_image.rb @@ -1,18 +1,18 @@ module Ellen module Handlers class GoogleImage < Base - on /image (.+)/, name: "image", desc...
Add optional `me`: e.g. `image me ellen`
diff --git a/lib/engineyard/model/deployment.rb b/lib/engineyard/model/deployment.rb index abc1234..def5678 100644 --- a/lib/engineyard/model/deployment.rb +++ b/lib/engineyard/model/deployment.rb @@ -9,14 +9,14 @@ :environment => environment, :migration_command => migration_command, ...
Use UTC for started and finished times for deploys
diff --git a/lib/ephemeral_response/net_http.rb b/lib/ephemeral_response/net_http.rb index abc1234..def5678 100644 --- a/lib/ephemeral_response/net_http.rb +++ b/lib/ephemeral_response/net_http.rb @@ -2,6 +2,8 @@ class HTTP alias request_without_ephemeral_response request alias connect_without_ephemeral_res...
Use Net::HTTP debugger when connection established
diff --git a/lib/fluent/plugin/in_named_pipe.rb b/lib/fluent/plugin/in_named_pipe.rb index abc1234..def5678 100644 --- a/lib/fluent/plugin/in_named_pipe.rb +++ b/lib/fluent/plugin/in_named_pipe.rb @@ -25,7 +25,7 @@ raise ConfigError, "#{e.class}: #{e.message}" end - @parser = Plugin.new_parser(con...
Use @format instead of conf['format'] for symmetricity with formatter
diff --git a/storm.rb b/storm.rb index abc1234..def5678 100644 --- a/storm.rb +++ b/storm.rb @@ -2,19 +2,18 @@ class Storm < Formula homepage "http://csdms.colorado.edu/wiki/Model:STORM" - head "https://csdms.colorado.edu/svn/storm/trunk", - :using => UnsafeSubversionDownloadStrategy + head "https://github.co...
Update formula for BMI version
diff --git a/lib/podio/models/linked_account.rb b/lib/podio/models/linked_account.rb index abc1234..def5678 100644 --- a/lib/podio/models/linked_account.rb +++ b/lib/podio/models/linked_account.rb @@ -29,5 +29,12 @@ Podio.connection.delete("/linked_account/#{id}").status end + def update_options(id, att...
Add update method for linked accounts options
diff --git a/lib/tasks/update_billing_plan.rake b/lib/tasks/update_billing_plan.rake index abc1234..def5678 100644 --- a/lib/tasks/update_billing_plan.rake +++ b/lib/tasks/update_billing_plan.rake @@ -1,7 +1,7 @@ # Updates billing plan at Onapp for all users, as per ONAPP_BILLING_PLAN_ID env variable task update_bil...
Check Onapp ID for updating billing plan
diff --git a/lib/tty/tree/directory_renderer.rb b/lib/tty/tree/directory_renderer.rb index abc1234..def5678 100644 --- a/lib/tty/tree/directory_renderer.rb +++ b/lib/tty/tree/directory_renderer.rb @@ -1,4 +1,3 @@-# encoding: utf-8 # frozen_string_literal: true module TTY
Change to remove encoding comment
diff --git a/test/models/audio_version_test.rb b/test/models/audio_version_test.rb index abc1234..def5678 100644 --- a/test/models/audio_version_test.rb +++ b/test/models/audio_version_test.rb @@ -25,11 +25,17 @@ audio_version_with_template.audio_version_template(true).wont_be_nil end - it 'validates se...
Make audio version test better
diff --git a/vagrant_base/libxml/recipes/default.rb b/vagrant_base/libxml/recipes/default.rb index abc1234..def5678 100644 --- a/vagrant_base/libxml/recipes/default.rb +++ b/vagrant_base/libxml/recipes/default.rb @@ -24,7 +24,7 @@ case node.platform when "ubuntu", "debian" then - %w(libssl-dev libxml2-dev libxslt1-...
Add one more package to the libxml cookbook
diff --git a/lib/code_driven_development/test_component/context.rb b/lib/code_driven_development/test_component/context.rb index abc1234..def5678 100644 --- a/lib/code_driven_development/test_component/context.rb +++ b/lib/code_driven_development/test_component/context.rb @@ -13,6 +13,7 @@ end def indent...
Add whitespace before every describe block.
diff --git a/app/concerns/couriers/fusionable.rb b/app/concerns/couriers/fusionable.rb index abc1234..def5678 100644 --- a/app/concerns/couriers/fusionable.rb +++ b/app/concerns/couriers/fusionable.rb @@ -37,6 +37,7 @@ notify "Adding to Fusion Tables", photo.key table.select("ROWID", "WHERE nam...
Allow up to 5 queries per second
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -1,6 +1,16 @@ class PagesController < HighVoltage::PagesController def show @user ||= User.new + + KM.rec...
Add KISS events to pages controller
diff --git a/app/models/visualization/relator.rb b/app/models/visualization/relator.rb index abc1234..def5678 100644 --- a/app/models/visualization/relator.rb +++ b/app/models/visualization/relator.rb @@ -18,7 +18,7 @@ end #initialize def overlays - @overlas ||= Overlay::Collection.new(visualizati...
Revert "Memoize (almost) all the things related to visualizations" This reverts commit 0ecba01487cefa7eab25994cdf7e0e4d7f035e4d.
diff --git a/rakelib/send_last_tweets_media.rake b/rakelib/send_last_tweets_media.rake index abc1234..def5678 100644 --- a/rakelib/send_last_tweets_media.rake +++ b/rakelib/send_last_tweets_media.rake @@ -0,0 +1,17 @@+require "dotenv" +require_relative "../lib/fortuna_luca/telegram/client" +require_relative "../lib/for...
Add rake task for Twitter media
diff --git a/fdcollector.gemspec b/fdcollector.gemspec index abc1234..def5678 100644 --- a/fdcollector.gemspec +++ b/fdcollector.gemspec @@ -1,7 +1,6 @@ Gem::Specification.new do |s| s.name = 'fdcollector' - s.version = '1.0' - s.date = '2012-06-26' + s.version = '1.0.0' s.summary...
Change version number to a triplet (X.X.X) Remove explicit date setting from gemspec
diff --git a/lib/dalli/cas/client.rb b/lib/dalli/cas/client.rb index abc1234..def5678 100644 --- a/lib/dalli/cas/client.rb +++ b/lib/dalli/cas/client.rb @@ -1 +1 @@-puts "You can remove `require 'dalli/cas/client'` as this code has been rolled into the standard 'dalli/client'. +puts "You can remove `require 'dalli/cas/...
Fix SyntaxError: unterminated string meets end of file This is meant to be a deprecation warning, but currently any code that loads this file will raise a SyntaxError.
diff --git a/lib/eventbrite/error.rb b/lib/eventbrite/error.rb index abc1234..def5678 100644 --- a/lib/eventbrite/error.rb +++ b/lib/eventbrite/error.rb @@ -1,33 +1,48 @@ module Eventbrite class Error < StandardError - attr_reader :type, :message + attr_reader :message, :description, :code - def self.from...
Refactor Error to mirror Twitter::Error
diff --git a/lib/mercenary/option.rb b/lib/mercenary/option.rb index abc1234..def5678 100644 --- a/lib/mercenary/option.rb +++ b/lib/mercenary/option.rb @@ -31,9 +31,9 @@ def eql?(other) return false unless self.class.eql?(other.class) - instance_variables.each do |var| + instance_variables.map d...
Check that all instance variables equal other instance variables
diff --git a/lib/metasploit/model.rb b/lib/metasploit/model.rb index abc1234..def5678 100644 --- a/lib/metasploit/model.rb +++ b/lib/metasploit/model.rb @@ -9,13 +9,9 @@ # # Project # + +require 'metasploit/model/engine' require 'metasploit/model/version' - -# Only include the Rails engine when using Rails. This al...
Remove if defined? Rails check for requiring engine MSP-11359
diff --git a/lib/rack_dav/handler.rb b/lib/rack_dav/handler.rb index abc1234..def5678 100644 --- a/lib/rack_dav/handler.rb +++ b/lib/rack_dav/handler.rb @@ -14,13 +14,12 @@ def call(env) request = Rack::Request.new(env) - pp request response = Rack::Response.new - + begin ...
Set status code if available. Force all header values to strings.
diff --git a/lib/tasks/fix_utf8.rake b/lib/tasks/fix_utf8.rake index abc1234..def5678 100644 --- a/lib/tasks/fix_utf8.rake +++ b/lib/tasks/fix_utf8.rake @@ -0,0 +1,51 @@+# credit: http://markmcb.com/2011/11/07/replacing-ae%E2%80%9C-ae%E2%84%A2-aeoe-etc-with-utf-8-characters-in-ruby-on-rails/ + +namespace :onebody do + ...
Add rake task to correct UTF-8 encoding errors in old data. Cedar Ridge has the oldest data and was migrated many times. If you're seeing stuff like — in your news items, comments, notes, etc., then run `rake onebody:fix_utf8` and see if that fixes the issue. Worked for us.
diff --git a/capistrano-offroad.gemspec b/capistrano-offroad.gemspec index abc1234..def5678 100644 --- a/capistrano-offroad.gemspec +++ b/capistrano-offroad.gemspec @@ -13,9 +13,12 @@ s.version = CapistranoOffroad::VERSION::STRING s.summary = "Capistrano add-ons and recipes for non-rails projects" s.description...
Add Capistrano dependency to gemspec.
diff --git a/middleman-bootstrap-navbar.gemspec b/middleman-bootstrap-navbar.gemspec index abc1234..def5678 100644 --- a/middleman-bootstrap-navbar.gemspec +++ b/middleman-bootstrap-navbar.gemspec @@ -9,7 +9,7 @@ gem.name = 'middleman-bootstrap-navbar' gem.version = Middleman::BootstrapNavbar::VERSI...
Change authors to author in gemspec, remove Rake version constraint
diff --git a/lib/appsignal/hooks/net_http.rb b/lib/appsignal/hooks/net_http.rb index abc1234..def5678 100644 --- a/lib/appsignal/hooks/net_http.rb +++ b/lib/appsignal/hooks/net_http.rb @@ -6,7 +6,7 @@ register :net_http def dependencies_present? - Appsignal.config[:instrument_net_http] + Ap...
Make net http dependencies checker more robust
diff --git a/app/models/comment.rb b/app/models/comment.rb index abc1234..def5678 100644 --- a/app/models/comment.rb +++ b/app/models/comment.rb @@ -1,8 +1,8 @@ class Comment < ActiveRecord::Base validates :body, :presence => true - validates :asciicast_id, :presence => true - validates :user_id, :presence => tr...
Validate presence of a model, not id
diff --git a/app/models/project.rb b/app/models/project.rb index abc1234..def5678 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -1,7 +1,9 @@ class Project < ActiveRecord::Base belongs_to :client before_save :default_values + has_one :client + has_many :issues validates :name, pres...
Add has_many :issues to Project
diff --git a/db/migrate/20121005142110_regenerate_err_fingerprints.rb b/db/migrate/20121005142110_regenerate_err_fingerprints.rb index abc1234..def5678 100644 --- a/db/migrate/20121005142110_regenerate_err_fingerprints.rb +++ b/db/migrate/20121005142110_regenerate_err_fingerprints.rb @@ -4,7 +4,7 @@ if err.notice...
Fix fingerprinting migration as it is refactored Commit https://github.com/pinglamb/errbit/commit/da3946bef7921e5a6df0d55fc2f556b641884ada refactored fingerprinting into a Fingerprint module, updated the migration for that
diff --git a/montrose.gemspec b/montrose.gemspec index abc1234..def5678 100644 --- a/montrose.gemspec +++ b/montrose.gemspec @@ -27,7 +27,7 @@ spec.add_development_dependency "appraisal" spec.add_development_dependency "m" spec.add_development_dependency "minitest" - spec.add_development_dependency "rake" + s...
Address security vulnerability in rake https://github.com/advisories/GHSA-jppv-gw3r-w3q8
diff --git a/action_cable.gemspec b/action_cable.gemspec index abc1234..def5678 100644 --- a/action_cable.gemspec +++ b/action_cable.gemspec @@ -5,8 +5,8 @@ s.summary = 'Framework for websockets.' s.description = 'Action Cable is a framework for realtime communication over websockets.' - s.author = ['Pratik Nai...
Expand authors given recent work
diff --git a/lib/executor.rb b/lib/executor.rb index abc1234..def5678 100644 --- a/lib/executor.rb +++ b/lib/executor.rb @@ -2,10 +2,9 @@ # executes packer commands against template files class SingelExecutor - def initialize(filename) - @filename = filename - @packer_dir = File.absolute_path(File.join(File.d...
Handle packer templates outside the working dir
diff --git a/lib/git/gsub.rb b/lib/git/gsub.rb index abc1234..def5678 100644 --- a/lib/git/gsub.rb +++ b/lib/git/gsub.rb @@ -28,7 +28,7 @@ target_files = (`git grep -l #{from} #{path}`).each_line.map(&:chomp).join ' ' if system_support_gsed? - system %|gsed -i "" s/#{from}/#{to}/g #{target_files}|...
Fix option for gnu sed
diff --git a/core/lib/spree/testing_support/common_rake.rb b/core/lib/spree/testing_support/common_rake.rb index abc1234..def5678 100644 --- a/core/lib/spree/testing_support/common_rake.rb +++ b/core/lib/spree/testing_support/common_rake.rb @@ -14,7 +14,7 @@ Spree::InstallGenerator.start ["--lib_name=#{ENV['LIB_NAM...
Remove trace from common rake
diff --git a/base/lib/paperclip/social_stream.rb b/base/lib/paperclip/social_stream.rb index abc1234..def5678 100644 --- a/base/lib/paperclip/social_stream.rb +++ b/base/lib/paperclip/social_stream.rb @@ -1,6 +1,6 @@ # Create new Paperclip::Interpolations method for subtype class module Paperclip::Interpolations #:nod...
Fix paperclip interpolation in subjects without actor
diff --git a/lib/poke/map.rb b/lib/poke/map.rb index abc1234..def5678 100644 --- a/lib/poke/map.rb +++ b/lib/poke/map.rb @@ -1,6 +1,8 @@ require 'rmagick' module Poke + # Map reads an ASCII file and coverts it to an object that can be read and + # manipulated by other program objects. class Map include P...
Add class doc for Map
diff --git a/benchmarks/mab2_document_parsing.rb b/benchmarks/mab2_document_parsing.rb index abc1234..def5678 100644 --- a/benchmarks/mab2_document_parsing.rb +++ b/benchmarks/mab2_document_parsing.rb @@ -0,0 +1,14 @@+require "metacrunch/mab2" +require "benchmark/ips" + +Benchmark.ips do |x| + x.config(time: 5, warmup...
Add benchmark for document parsing.
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -14,10 +14,8 @@ # limitations under the License. # -default["logstash"]["package_url"] = "http://semicomplete.com/files/logstash/logstash-1.1.0-monolithic.jar" -# defaul...
Use string literals where possible
diff --git a/MetalBender.podspec b/MetalBender.podspec index abc1234..def5678 100644 --- a/MetalBender.podspec +++ b/MetalBender.podspec @@ -10,6 +10,6 @@ s.ios.deployment_target = '10.0' s.requires_arc = true s.ios.source_files = 'Sources/**/*.{swift,metal}' - s.dependency 'SwiftProtobuf', :git => 'https://gi...
Set SwiftProtobuf pod version to 0.9.903
diff --git a/app/controllers/api/repository_controller.rb b/app/controllers/api/repository_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/repository_controller.rb +++ b/app/controllers/api/repository_controller.rb @@ -2,7 +2,7 @@ skip_before_filter :verify_authenticity_token def create - ...
Add GitHub event to repository save
diff --git a/webapp/lib/trisano.rb b/webapp/lib/trisano.rb index abc1234..def5678 100644 --- a/webapp/lib/trisano.rb +++ b/webapp/lib/trisano.rb @@ -1,5 +1,5 @@ module Trisano - VERSION = %w(3 5 4).freeze + VERSION = %w(3 5 5).freeze end require 'trisano/application'
Set TriSano version to 3.5.5
diff --git a/lib/file.rb b/lib/file.rb index abc1234..def5678 100644 --- a/lib/file.rb +++ b/lib/file.rb @@ -5,7 +5,7 @@ def chunk @chunks = Array.new self.rewind - while (content = self.read(512)) + while (content = self.read(102400)) @chunks << Tornado::Chunk.new(content) end @chunk...
Improve chunking a lot. Chunks of 100KB seems pretty reasonable.
diff --git a/spec/runtime/environment_rb_spec.rb b/spec/runtime/environment_rb_spec.rb index abc1234..def5678 100644 --- a/spec/runtime/environment_rb_spec.rb +++ b/spec/runtime/environment_rb_spec.rb @@ -3,14 +3,25 @@ describe "environment.rb file" do before :each do system_gems "rack-1.0.0" + build_git "no...
Add a failing test for a locked git-based gem without a gemspec.
diff --git a/app/models/answer.rb b/app/models/answer.rb index abc1234..def5678 100644 --- a/app/models/answer.rb +++ b/app/models/answer.rb @@ -7,4 +7,9 @@ has_many :votes, :as => :voteable validates :body, presence: true + + def time_since_creation + hours_number = ((Time.now - created_at) / 3600).round + ...
Add time_since_creation method to Answer model
diff --git a/app/models/answer.rb b/app/models/answer.rb index abc1234..def5678 100644 --- a/app/models/answer.rb +++ b/app/models/answer.rb @@ -6,5 +6,11 @@ validates_presence_of :content, :question_id, :user_id - + def score + count = 0 + self.votes.each do |vote| + count = count + vote.status + end +...
Add score method to Answer model
diff --git a/app/controllers/seats_controller.rb b/app/controllers/seats_controller.rb index abc1234..def5678 100644 --- a/app/controllers/seats_controller.rb +++ b/app/controllers/seats_controller.rb @@ -1,2 +1,47 @@ class SeatsController < ApplicationController + # Including these in case, well, they could cram in m...
Add seat actions in controller.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,5 +1,5 @@ class UsersController < ApplicationController - before_filter :set_access_control_headers, only: :pres...
Use before_action instead of before_filter
diff --git a/app/models/champs/checkbox_champ.rb b/app/models/champs/checkbox_champ.rb index abc1234..def5678 100644 --- a/app/models/champs/checkbox_champ.rb +++ b/app/models/champs/checkbox_champ.rb @@ -8,4 +8,8 @@ def to_s value == 'on' ? 'oui' : 'non' end + + def for_export + value == 'on' ? 'on' : 'o...
Make the CheckboxChamp export similar to YesNoChamp Previously, nil values would be returned as nil and not as off
diff --git a/app/models/concerns/search_cache.rb b/app/models/concerns/search_cache.rb index abc1234..def5678 100644 --- a/app/models/concerns/search_cache.rb +++ b/app/models/concerns/search_cache.rb @@ -7,7 +7,7 @@ def calculate_tsvector ActiveRecord::Base.connection.execute(" - UPDATE proposals SET tsv...
Use model table name instead of hardcoding it
diff --git a/app/models/spree/order_decorator.rb b/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/order_decorator.rb +++ b/app/models/spree/order_decorator.rb @@ -1,18 +1,24 @@ module Spree Order.class_eval do - # TODO: fix the cart error populating and make it work with ...
Change the way shortages are added to line items
diff --git a/app/policies/ezborrow_authorizer.rb b/app/policies/ezborrow_authorizer.rb index abc1234..def5678 100644 --- a/app/policies/ezborrow_authorizer.rb +++ b/app/policies/ezborrow_authorizer.rb @@ -1,6 +1,6 @@ class EZBorrowAuthorizer < PatronStatusAuthorizer def initialize(user) super(user) - @author...
Add TNS patron statuses to EZBorrow authorizer
diff --git a/db/migrate/20110618232719_add_version_reverted_from.rb b/db/migrate/20110618232719_add_version_reverted_from.rb index abc1234..def5678 100644 --- a/db/migrate/20110618232719_add_version_reverted_from.rb +++ b/db/migrate/20110618232719_add_version_reverted_from.rb @@ -0,0 +1,13 @@+class AddVersionRevertedFr...
Add reverted_from column for vestal_version
diff --git a/base/app/controllers/followers_controller.rb b/base/app/controllers/followers_controller.rb index abc1234..def5678 100644 --- a/base/app/controllers/followers_controller.rb +++ b/base/app/controllers/followers_controller.rb @@ -4,19 +4,11 @@ respond_to :html, :js def index - @followers = - c...
Update followers controller to new ViSH view
diff --git a/omniauth.gemspec b/omniauth.gemspec index abc1234..def5678 100644 --- a/omniauth.gemspec +++ b/omniauth.gemspec @@ -5,7 +5,7 @@ Gem::Specification.new do |spec| spec.add_dependency 'hashie', ['>= 1.2', '< 4'] - spec.add_dependency 'rack', ['>= 1.0', '< 2.0'] + spec.add_dependency 'rack', ['>= 1.0', ...
Update rack dependency to <3 :heart:
diff --git a/spec/cc/yaml/nodes/ratings_spec.rb b/spec/cc/yaml/nodes/ratings_spec.rb index abc1234..def5678 100644 --- a/spec/cc/yaml/nodes/ratings_spec.rb +++ b/spec/cc/yaml/nodes/ratings_spec.rb @@ -0,0 +1,18 @@+require "spec_helper" + +describe CC::Yaml::Nodes::Ratings do + specify "with an invalid path, it drops n...
Add spec for invalid ratings.paths elements
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -5,6 +5,5 @@ description 'Installs/Configures java_wrapper' long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) version '0.1.0' -depends 'ark' recipe "java_wrapper", "Wra...
Revert "added missing dependency to ark" This reverts commit 1f6bd3e2032e31e02959cc41ec81aa087711561e.
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -18,6 +18,6 @@ depends "yum" depends "postgresql" depends "php-fpm" -depends "nginx", "~> 1.0.0" +depends "nginx", ">= 1.0.0" depends "ark" depends ...
Change test sign It has breaking my prod platform
diff --git a/spec/ruby/core/symbol/size_spec.rb b/spec/ruby/core/symbol/size_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/core/symbol/size_spec.rb +++ b/spec/ruby/core/symbol/size_spec.rb @@ -1,4 +1,5 @@ require File.expand_path('../../../spec_helper', __FILE__) +require File.expand_path('../shared/length', __...
Add missing 'require' for shared spec.
diff --git a/spec/rx-rspec/async_runner_spec.rb b/spec/rx-rspec/async_runner_spec.rb index abc1234..def5678 100644 --- a/spec/rx-rspec/async_runner_spec.rb +++ b/spec/rx-rspec/async_runner_spec.rb @@ -29,7 +29,6 @@ runner.await_done {|_| } end.to fail_with(/timeout/i) expect(Time.now - start).to b...
Remove async runner assert that timeout is not too late. Travis is just too irregular.
diff --git a/spec/sse/open-world/date-1_spec.rb b/spec/sse/open-world/date-1_spec.rb index abc1234..def5678 100644 --- a/spec/sse/open-world/date-1_spec.rb +++ b/spec/sse/open-world/date-1_spec.rb @@ -0,0 +1,66 @@+# coding: utf-8 +# +require 'spec_helper' + +# Auto-generated by build_w3c_tests.rb +# +# date-1 +# Added ...
Add date-1 spec, which is pending as RDF.rb does more xsd:date comparisons.
diff --git a/config/initializers/rack_patches.rb b/config/initializers/rack_patches.rb index abc1234..def5678 100644 --- a/config/initializers/rack_patches.rb +++ b/config/initializers/rack_patches.rb @@ -0,0 +1,6 @@+# Workaround for incorrect counting of the keyspace in nested params in rack +# https://github.com/rack...
Add workaround for poor query key counting in Rack 1.1.6 Otherwise queries with lots of nested params, such as route updates, produce 'exceeded available parameter key space' errors.
diff --git a/config/software/loom-provisioner.rb b/config/software/loom-provisioner.rb index abc1234..def5678 100644 --- a/config/software/loom-provisioner.rb +++ b/config/software/loom-provisioner.rb @@ -1,4 +1,4 @@-name 'loom-provisioner' +name project default_version 'develop' dependency 'ruby' @@ -13,15 +13,11 ...
Use copy/mkdir builtin Builder methods
diff --git a/config/setup_load_paths.rb b/config/setup_load_paths.rb index abc1234..def5678 100644 --- a/config/setup_load_paths.rb +++ b/config/setup_load_paths.rb @@ -0,0 +1,16 @@+if ENV['MY_RUBY_HOME'] && ENV['MY_RUBY_HOME'].include?('rvm') + begin + rvm_path = File.dirname(File.dirname(ENV['MY_RUBY_HOME']))...
Add setup file for RVM + Passenger integration across restarts (thanks @raquelgb for the link)
diff --git a/cookbooks/rs_utils/recipes/setup_timezone.rb b/cookbooks/rs_utils/recipes/setup_timezone.rb index abc1234..def5678 100644 --- a/cookbooks/rs_utils/recipes/setup_timezone.rb +++ b/cookbooks/rs_utils/recipes/setup_timezone.rb @@ -23,7 +23,7 @@ # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE....
Test using unless for logic.
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -1,6 +1,6 @@ gem 'cucumber' require 'cucumber' -gem 'rspec' +gem 'rspec', '~> 1.3' require 'spec' require File.dirname(__FILE__) + "/../../lib/rubigen"
Fix features when RSpec 2.x is also present on the system
diff --git a/Library/Formula/stanford-parser.rb b/Library/Formula/stanford-parser.rb index abc1234..def5678 100644 --- a/Library/Formula/stanford-parser.rb +++ b/Library/Formula/stanford-parser.rb @@ -0,0 +1,27 @@+require 'formula' + +class StanfordParser <Formula + url 'http://nlp.stanford.edu/software/stanford-parse...
Add formula for the Stanford Parser Signed-off-by: Adam Vandenberg <flangy@gmail.com> * Install privately to libexec * Link .csh scripts into bin * Includes a smoke test
diff --git a/config/initializers/redis.rb b/config/initializers/redis.rb index abc1234..def5678 100644 --- a/config/initializers/redis.rb +++ b/config/initializers/redis.rb @@ -4,6 +4,14 @@ # else # Redis.new :thread_safe => true # end -$redis = Redis.connect :thread_safe => true, :url => ENV['REDISTOGO_URL'] +redi...
Use proper Redis configuration for production env
diff --git a/no-style-please.gemspec b/no-style-please.gemspec index abc1234..def5678 100644 --- a/no-style-please.gemspec +++ b/no-style-please.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "no-style-please" - spec.version = "0.1.5" + spec.version = "0.1.6" spec.au...
Update gem version in gemspec
diff --git a/lib/selenium/webdriver/common/element_mini.rb b/lib/selenium/webdriver/common/element_mini.rb index abc1234..def5678 100644 --- a/lib/selenium/webdriver/common/element_mini.rb +++ b/lib/selenium/webdriver/common/element_mini.rb @@ -6,13 +6,13 @@ class Element # Click in a way that is reliable ...
[JT][111704448] Rename monkey patch methods, add firefox to checkbox click method
diff --git a/test/session_test/activation_test.rb b/test/session_test/activation_test.rb index abc1234..def5678 100644 --- a/test/session_test/activation_test.rb +++ b/test/session_test/activation_test.rb @@ -7,7 +7,6 @@ assert UserSession.activated? Authlogic::Session::Base.controller = nil a...
Remove debugger call in test
diff --git a/CDYObjectModel.podspec b/CDYObjectModel.podspec index abc1234..def5678 100644 --- a/CDYObjectModel.podspec +++ b/CDYObjectModel.podspec @@ -10,6 +10,6 @@ spec.subspec 'Core' do |ss| ss.platform = :ios, '6.0' - ss.source_files = 'CDYObjectModel/Core/*.{h,m}' + ss.source_files = 'Core/*.{h,m}'...
Correct files location in spec
diff --git a/spec/routing/users_routing_spec.rb b/spec/routing/users_routing_spec.rb index abc1234..def5678 100644 --- a/spec/routing/users_routing_spec.rb +++ b/spec/routing/users_routing_spec.rb @@ -27,6 +27,10 @@ expect(:post => "/login").to route_to("users#login") end + it "routes to #signup" do + ...
Add route test for signup.
diff --git a/prefnerd.gemspec b/prefnerd.gemspec index abc1234..def5678 100644 --- a/prefnerd.gemspec +++ b/prefnerd.gemspec @@ -1,13 +1,18 @@-# coding: utf-8 - Gem::Specification.new do |spec| spec.name = 'prefnerd' spec.version = '0.1' spec.authors = ['Greg Hurrell'] spec.email ...
Add summary and description to gemspec
diff --git a/app/helpers/alexa_utterance_helper.rb b/app/helpers/alexa_utterance_helper.rb index abc1234..def5678 100644 --- a/app/helpers/alexa_utterance_helper.rb +++ b/app/helpers/alexa_utterance_helper.rb @@ -0,0 +1,24 @@+module AlexaUtteranceHelper + + def random_utterance + @sample_utterances = [ + "Alex...
Add helper method with a response when user asks for help
diff --git a/app/controllers/callbacks_controller.rb b/app/controllers/callbacks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/callbacks_controller.rb +++ b/app/controllers/callbacks_controller.rb @@ -1,6 +1,16 @@ # frozen_string_literal: true class CallbacksController < Devise::OmniauthCallbacksCo...
Add missing logic to google_oauth2 callback
diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb index abc1234..def5678 100644 --- a/app/controllers/dashboard_controller.rb +++ b/app/controllers/dashboard_controller.rb @@ -3,9 +3,7 @@ def index return unless current_user gon_user - gon.push(users_for_selec...
Remove notice and alert from `gon`