diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/yard/handlers/class_handler.rb b/lib/yard/handlers/class_handler.rb index abc1234..def5678 100644 --- a/lib/yard/handlers/class_handler.rb +++ b/lib/yard/handlers/class_handler.rb @@ -2,7 +2,7 @@ handles TkCLASS def process - if statement.tokens.to_s =~ /^class\s+(#{NAMESPACEMATCH})(\s*<.+|...
Fix whitespace matching issue, clean up error message.
diff --git a/db/migrate/20170320113139_add_loan_accountable_column.rb b/db/migrate/20170320113139_add_loan_accountable_column.rb index abc1234..def5678 100644 --- a/db/migrate/20170320113139_add_loan_accountable_column.rb +++ b/db/migrate/20170320113139_add_loan_accountable_column.rb @@ -0,0 +1,7 @@+class AddLoanAccoun...
Add accountable column with migration
diff --git a/docs/analytics_scripts/p_and_e_program_leaders_to_csv.rb b/docs/analytics_scripts/p_and_e_program_leaders_to_csv.rb index abc1234..def5678 100644 --- a/docs/analytics_scripts/p_and_e_program_leaders_to_csv.rb +++ b/docs/analytics_scripts/p_and_e_program_leaders_to_csv.rb @@ -0,0 +1,10 @@+# Usernames of pro...
Add script for identifying program leaders on P&E Dashboard This is for use by WMF staff for the Community Insights survey.
diff --git a/MenuPopOverView.podspec b/MenuPopOverView.podspec index abc1234..def5678 100644 --- a/MenuPopOverView.podspec +++ b/MenuPopOverView.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "MenuPopOverView" - s.version = "0.0.2" + s.version = "0.0.3" s.summary = "A custom PopOve...
Update pods to version 0.0.3
diff --git a/UIView+DragDrop.podspec b/UIView+DragDrop.podspec index abc1234..def5678 100644 --- a/UIView+DragDrop.podspec +++ b/UIView+DragDrop.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "UIView+DragDrop" - s.version = "0.0.2" + s.version = "1.0.0" s.summary = ...
Update podspec, bump version to 1.0.0
diff --git a/lib/one_click_orgs/model_wrapper.rb b/lib/one_click_orgs/model_wrapper.rb index abc1234..def5678 100644 --- a/lib/one_click_orgs/model_wrapper.rb +++ b/lib/one_click_orgs/model_wrapper.rb @@ -2,6 +2,8 @@ class ModelWrapper extend ActiveModel::Naming include ActiveModel::Validations + include...
Make ModelWrapper conform with Rails 3.2's ActiveModel requirements.
diff --git a/texttube_baby.gemspec b/texttube_baby.gemspec index abc1234..def5678 100644 --- a/texttube_baby.gemspec +++ b/texttube_baby.gemspec @@ -17,7 +17,7 @@ spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.requir...
Correct the version numbers, texttube is a changing.
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -1,9 +1,9 @@ # encoding: utf-8 class CommentsController < ApplicationController - load_and_authorize...
Improve comments controller before filters
diff --git a/app/controllers/searches_controller.rb b/app/controllers/searches_controller.rb index abc1234..def5678 100644 --- a/app/controllers/searches_controller.rb +++ b/app/controllers/searches_controller.rb @@ -25,7 +25,7 @@ respond_to do |format| format.html - format.json do + format.js do...
Revert "render json for search instead of jrender json for search instead of js" This reverts commit aaf2431a6f573fdf121d81c2e26ad7d58e031626.
diff --git a/lib/reunion/web/app.rb b/lib/reunion/web/app.rb index abc1234..def5678 100644 --- a/lib/reunion/web/app.rb +++ b/lib/reunion/web/app.rb @@ -7,15 +7,21 @@ set :root, File.dirname(__FILE__) - def get_all_transactions + + + def get_transfer_pairs + get_cached_books.transfer_pairs +...
Refactor caching to cache entire books object
diff --git a/lib/extensions/time_bounded_record/active_record/base.rb b/lib/extensions/time_bounded_record/active_record/base.rb index abc1234..def5678 100644 --- a/lib/extensions/time_bounded_record/active_record/base.rb +++ b/lib/extensions/time_bounded_record/active_record/base.rb @@ -8,11 +8,11 @@ private ...
Disable lint for baby_squeel queries
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -6,4 +6,5 @@ javascripts_dir = 'assets/javascripts' relative_assets = true line_comments = false -# output_style = :compressed+# output_style = :compressed +disable_warnings = true
Add disable_warnings to disable the @media query/@extend deprecation warnings.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -4,10 +4,10 @@ Bundler.require -require File.join(File.dirname(__FILE__), "prey_fetcher.rb") +require File.join(File.dirname(__FILE__), "web.rb") # Set Sinatra's variables -set :app_file, File.join(File.dirname(__...
Load web.rb in rackup file
diff --git a/app/models/repository.rb b/app/models/repository.rb index abc1234..def5678 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -20,14 +20,32 @@ property :accessibility def metadata - total = Tire.search('metadata', :search_type => 'count') do - query { all } - end.resu...
Add get all metadata with certain field method I refactored the count query into a separate method so it can be used by multiple methods. Then I added a method to return all records which have a certain field defined. A concrete value can be passed in addition. Signed-off-by: Konrad Reiche <4ff0213f56e2082fcd8c882d04...
diff --git a/app/uploaders/header_video_uploader.rb b/app/uploaders/header_video_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/header_video_uploader.rb +++ b/app/uploaders/header_video_uploader.rb @@ -16,7 +16,7 @@ end version :webm do - process :encode_video => [:webm] + process :encode_vi...
Use the same resolution constraints with webm that are used with mp4 Signed-off-by: Max Fierke <0706025b2bbcec1ed8d64822f4eccd96314938d0@maxfierke.com>
diff --git a/app/views/families/index.json.jbuilder b/app/views/families/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/families/index.json.jbuilder +++ b/app/views/families/index.json.jbuilder @@ -4,6 +4,7 @@ json.points member.points json.color member.color json.imgUrl member.img_url + jso...
Add pending rewards to member
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -3,6 +3,6 @@ use Rack::ShowExceptions -set :protection, :except => [:http_origin] +disable :protection run Sinatra::Application
Disable all Rack::Protection stuff to see if that prevents the random HTTP 500 errors.
diff --git a/app/workers/video_processing_worker.rb b/app/workers/video_processing_worker.rb index abc1234..def5678 100644 --- a/app/workers/video_processing_worker.rb +++ b/app/workers/video_processing_worker.rb @@ -5,6 +5,7 @@ video = Video.find(video_id) video.set_metadata video.set_duration + video...
Set the air date in the video processor
diff --git a/ci_environment/rvm/attributes/default.rb b/ci_environment/rvm/attributes/default.rb index abc1234..def5678 100644 --- a/ci_environment/rvm/attributes/default.rb +++ b/ci_environment/rvm/attributes/default.rb @@ -1,6 +1,6 @@ include_attribute "travis_build_environment::default" -default[:rvm][:version] = ...
Update RVM to the latest release
diff --git a/lib/ec2ssh/hosts.rb b/lib/ec2ssh/hosts.rb index abc1234..def5678 100644 --- a/lib/ec2ssh/hosts.rb +++ b/lib/ec2ssh/hosts.rb @@ -8,7 +8,7 @@ @dotfile = dotfile @ec2 = Hash.new do |h,region| key = dotfile.aws_key(keyname) - raise AwsEnvNotDefined if key['access_key_id'].empty? ||...
Fix undefined method `empty?` when aws keys not set key['access_key_id'] and key['secret_access_key'], when it it empty, return nil
diff --git a/lib/flipper/feature.rb b/lib/flipper/feature.rb index abc1234..def5678 100644 --- a/lib/flipper/feature.rb +++ b/lib/flipper/feature.rb @@ -43,11 +43,14 @@ ] end + def gate_for(thing) + find_gate(thing) || raise(GateNotFound.new(thing)) + end + private - def gate_for(thing...
Split up gate_for and finding of gate. Publicized gate_for for internal use. Finding the gate is still private.
diff --git a/lib/hyrax/errors.rb b/lib/hyrax/errors.rb index abc1234..def5678 100644 --- a/lib/hyrax/errors.rb +++ b/lib/hyrax/errors.rb @@ -1,4 +1,6 @@ module Hyrax + require 'active_fedora/errors' + # Generic Hyrax exception class. class HyraxError < StandardError; end
Fix the uninitialized constant ActiveFedora::ObjectNotFoundError NameError.
diff --git a/lib/peek/railtie.rb b/lib/peek/railtie.rb index abc1234..def5678 100644 --- a/lib/peek/railtie.rb +++ b/lib/peek/railtie.rb @@ -19,7 +19,7 @@ end initializer 'peek.persist_request_data' do - ActiveSupport::Notifications.subscribe('process_action.action_controller') do + ActiveSupport::...
Switch to action_dispatch.request for notification
diff --git a/core/app/models/spree/stock/estimator.rb b/core/app/models/spree/stock/estimator.rb index abc1234..def5678 100644 --- a/core/app/models/spree/stock/estimator.rb +++ b/core/app/models/spree/stock/estimator.rb @@ -15,7 +15,7 @@ shipping_methods.each do |shipping_method| cost = calculate_...
Allow shipping calculators to return nil values if no service is matched. With shipping calculators returning 0, we run the risk of choosing and charging a cost of $0 in cases where for example spree_active_shipping has a failed rate query with the carrier API. This could be a very expensive mistake. Current problem ...
diff --git a/server.rb b/server.rb index abc1234..def5678 100644 --- a/server.rb +++ b/server.rb @@ -4,7 +4,13 @@ File.open('./helios.pid', 'w') { |f| f.write $$ } -Helios::Lights.load_saved_light_state +begin + Helios::Lights.load_saved_light_state +rescue Exception => ex + Helios::Logger.instance.error("Error...
Add catch block for loading light state
diff --git a/activerecord/lib/rails/generators/active_record/migration.rb b/activerecord/lib/rails/generators/active_record/migration.rb index abc1234..def5678 100644 --- a/activerecord/lib/rails/generators/active_record/migration.rb +++ b/activerecord/lib/rails/generators/active_record/migration.rb @@ -44,7 +44,7 @@ ...
Fix rubocop warning re unused argument
diff --git a/test/turing/face/data_store_test.rb b/test/turing/face/data_store_test.rb index abc1234..def5678 100644 --- a/test/turing/face/data_store_test.rb +++ b/test/turing/face/data_store_test.rb @@ -18,4 +18,18 @@ data = ds.find('curriculum', 'projects/feed_engine') assert data.body.include?('# Feed Engi...
Test the tracking of changes in the data store
diff --git a/lib/open_data/agent.rb b/lib/open_data/agent.rb index abc1234..def5678 100644 --- a/lib/open_data/agent.rb +++ b/lib/open_data/agent.rb @@ -1,15 +1,37 @@ module OpenData - # A person or organisation. Named after foaf:Agent but using schema.org naming for internals + # A person or organisation. + # + ...
Rename Agent attributes to match FOAF and add YARD docs
diff --git a/db/migrate/20140411231959_add_twitter_omniauth_to_users.rb b/db/migrate/20140411231959_add_twitter_omniauth_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20140411231959_add_twitter_omniauth_to_users.rb +++ b/db/migrate/20140411231959_add_twitter_omniauth_to_users.rb @@ -0,0 +1,11 @@+class AddT...
Create twitter omniauth DB migration Add in provider and uid fields in preparation for 'omniauth-twitter' implementation.
diff --git a/db/migrate/20161201160541_drop_column_user_id_in_states.rb b/db/migrate/20161201160541_drop_column_user_id_in_states.rb index abc1234..def5678 100644 --- a/db/migrate/20161201160541_drop_column_user_id_in_states.rb +++ b/db/migrate/20161201160541_drop_column_user_id_in_states.rb @@ -4,9 +4,12 @@ migratio...
Add unique visualization_id to migration
diff --git a/HandySwift.podspec b/HandySwift.podspec index abc1234..def5678 100644 --- a/HandySwift.podspec +++ b/HandySwift.podspec @@ -0,0 +1,27 @@+Pod::Spec.new do |s| + + s.name = "HandySwift" + s.version = "0.8" + s.summary = "Handy Swift features that didn't make it into the Swift standard li...
Add podspec file for CocoaPods support
diff --git a/lib/stacker/logging.rb b/lib/stacker/logging.rb index abc1234..def5678 100644 --- a/lib/stacker/logging.rb +++ b/lib/stacker/logging.rb @@ -10,6 +10,8 @@ class PrettyLogger < SimpleDelegator def initialize logger + super + old_formatter = logger.formatter logger.form...
Fix bug with SimpleDelegator in Ruby 2.1 Signed-off-by: Evan Owen <a31932a4150a6c43f7c4879727da9a731c3d5877@gmail.com>
diff --git a/config/initializers/devise_async.rb b/config/initializers/devise_async.rb index abc1234..def5678 100644 --- a/config/initializers/devise_async.rb +++ b/config/initializers/devise_async.rb @@ -4,5 +4,5 @@ else config.enabled = true end - config.backend = :delayed_job -end+ config.backend = :side...
Use sidekiq as devise async engine
diff --git a/lib/facebooker/rails/extensions/rack_setup.rb b/lib/facebooker/rails/extensions/rack_setup.rb index abc1234..def5678 100644 --- a/lib/facebooker/rails/extensions/rack_setup.rb +++ b/lib/facebooker/rails/extensions/rack_setup.rb @@ -1,2 +1,8 @@+# Somewhere in 2.3 RewindableInput was removed- rack supports i...
Allow the rack middle_ware to fall back from after RewindableInput to after Session::CookieStore if RewindableInput is not available. It was removed somewhere in Rails 2.3
diff --git a/app/controllers/auth.rb b/app/controllers/auth.rb index abc1234..def5678 100644 --- a/app/controllers/auth.rb +++ b/app/controllers/auth.rb @@ -1,4 +1,8 @@ enable :sessions + +get "/" do + erb :welcome +end get '/login' do if current_user
Add index route to welcome page
diff --git a/config/initializers/6_rack_profiler.rb b/config/initializers/6_rack_profiler.rb index abc1234..def5678 100644 --- a/config/initializers/6_rack_profiler.rb +++ b/config/initializers/6_rack_profiler.rb @@ -3,7 +3,8 @@ # initialization is skipped so trigger it Rack::MiniProfilerRails.initialize!(Rails....
Disable Rack::MiniProfiler for /teaspoon path
diff --git a/config/initializers/wrap_parameters.rb b/config/initializers/wrap_parameters.rb index abc1234..def5678 100644 --- a/config/initializers/wrap_parameters.rb +++ b/config/initializers/wrap_parameters.rb @@ -9,6 +9,6 @@ end # To enable root element in JSON for ActiveRecord objects. -# ActiveSupport.on_load(...
Enable root keys on json responses
diff --git a/app/models/avatar.rb b/app/models/avatar.rb index abc1234..def5678 100644 --- a/app/models/avatar.rb +++ b/app/models/avatar.rb @@ -1,7 +1,7 @@ class Avatar < Attachment mount_uploader :file, AvatarUploader - belongs_to :owner, class_name: "User" + belongs_to :owner, class_name: "User", dependent: :...
Add dependent: :destroy to Avatar/Company association
diff --git a/spec/gimli/markup/code_block_spec.rb b/spec/gimli/markup/code_block_spec.rb index abc1234..def5678 100644 --- a/spec/gimli/markup/code_block_spec.rb +++ b/spec/gimli/markup/code_block_spec.rb @@ -0,0 +1,21 @@+# encoding: utf-8 + +require './spec/spec_helper' + +require './lib/gimli' +require './lib/gimli/m...
Add tests for code block
diff --git a/spec/private/core_ext/kernel_spec.rb b/spec/private/core_ext/kernel_spec.rb index abc1234..def5678 100644 --- a/spec/private/core_ext/kernel_spec.rb +++ b/spec/private/core_ext/kernel_spec.rb @@ -1,11 +1,9 @@ require File.dirname(__FILE__) + '/../../spec_helper' - describe "Kernel#require" do - befor...
Clean up empty lines in Kernel extensions.
diff --git a/app/models/application_record.rb b/app/models/application_record.rb index abc1234..def5678 100644 --- a/app/models/application_record.rb +++ b/app/models/application_record.rb @@ -19,7 +19,7 @@ def update_without_validate!(**args) with_transaction_returning_status do assign_attributes(**args)...
10907: Remove useless bang from save
diff --git a/spec/acceptance/01_zookeeper_spec.rb b/spec/acceptance/01_zookeeper_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/01_zookeeper_spec.rb +++ b/spec/acceptance/01_zookeeper_spec.rb @@ -25,7 +25,7 @@ class { 'zookeeper': install_method => 'archive', - archive_version ...
Use latest available version of ZooKeeper
diff --git a/spec/models/paper_admin_task_spec.rb b/spec/models/paper_admin_task_spec.rb index abc1234..def5678 100644 --- a/spec/models/paper_admin_task_spec.rb +++ b/spec/models/paper_admin_task_spec.rb @@ -8,21 +8,13 @@ end describe "updating paper admin" do - - let(:task) { PaperAdminTask.create(phase: p...
Fix paper admin task spec
diff --git a/recipes/fix_profile.rb b/recipes/fix_profile.rb index abc1234..def5678 100644 --- a/recipes/fix_profile.rb +++ b/recipes/fix_profile.rb @@ -16,7 +16,8 @@ case node['platform_family'] when 'windows' # fix profile - file 'C:\Users\vagrant\Documents\WindowsPowerShell\Microsoft.PowerShell_profile.ps1' do ...
Update powershell profile path username
diff --git a/app/models/page_part.rb b/app/models/page_part.rb index abc1234..def5678 100644 --- a/app/models/page_part.rb +++ b/app/models/page_part.rb @@ -4,7 +4,7 @@ default_scope :order => 'name' # Associations - belongs_to :page, :touch => true + belongs_to :page # Validations validates_presen...
Revert "Touch page timestamp when updating a part" This reverts commit b83063904b9761fa3ffa854db3766507bc7cf9f2.
diff --git a/pp.rb b/pp.rb index abc1234..def5678 100644 --- a/pp.rb +++ b/pp.rb @@ -2,7 +2,7 @@ require 'erb' # The version of Coq. -version = `coqc -v`.match(/version ([^(]*) \(/)[1] +version = `coqc -v`.match(/version (\S+)/)[1] Dir.glob("src/*.v.erb") do |file_name| renderer = ERB.new(File.read(file_name, ...
Improve the version regexp for compatibility with Coq 8.14
diff --git a/canon-interpreter.rb b/canon-interpreter.rb index abc1234..def5678 100644 --- a/canon-interpreter.rb +++ b/canon-interpreter.rb @@ -1,3 +1,5 @@+ + def play_melody(mel) num_bars = mel.length for i in 0..num_bars - 1 @@ -13,10 +15,13 @@ end def play_beat(beat) + proportion_sustain = 0.7 + proport...
Update interpreter to deal with rationals and have good envelopes.
diff --git a/tagedit-rails.gemspec b/tagedit-rails.gemspec index abc1234..def5678 100644 --- a/tagedit-rails.gemspec +++ b/tagedit-rails.gemspec @@ -6,10 +6,10 @@ Gem::Specification.new do |spec| spec.name = "tagedit-rails" spec.version = Tagedit::Rails::VERSION - spec.authors = ["Matthew"] ...
Edit description and summary for gemspec.
diff --git a/spec/dummy/app/models/dummy_user.rb b/spec/dummy/app/models/dummy_user.rb index abc1234..def5678 100644 --- a/spec/dummy/app/models/dummy_user.rb +++ b/spec/dummy/app/models/dummy_user.rb @@ -1,17 +1,7 @@-class DummyUser - include ActiveModel::Validations - - attr_accessor :alchemy_roles, :language, :cac...
Make DummyUser class inherit from ActiveRecord again. This reverts changes from 7b1e66940ff744535469f0bbeb563adadfa68f13
diff --git a/spec/factories/changeset_factory.rb b/spec/factories/changeset_factory.rb index abc1234..def5678 100644 --- a/spec/factories/changeset_factory.rb +++ b/spec/factories/changeset_factory.rb @@ -14,6 +14,10 @@ FactoryGirl.define do factory :changeset do notes { FFaker::Lorem.paragraph } + end + + fa...
Add second Changeset factory, this one with payloads
diff --git a/spec/features/access_denied_spec.rb b/spec/features/access_denied_spec.rb index abc1234..def5678 100644 --- a/spec/features/access_denied_spec.rb +++ b/spec/features/access_denied_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' + +feature "Access Denied" do + before do + @user = FactoryGirl.create(:user...
Add coverage for rescue from CanCan AccessDenied
diff --git a/middleman-webp.gemspec b/middleman-webp.gemspec index abc1234..def5678 100644 --- a/middleman-webp.gemspec +++ b/middleman-webp.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency "middleman-core", "~> 4.0.0" ...
Declare dependency according to Middleman docs https://github.com/middleman/middleman#versioning
diff --git a/async.podspec b/async.podspec index abc1234..def5678 100644 --- a/async.podspec +++ b/async.podspec @@ -1,22 +1,23 @@ Pod::Spec.new do |s| -s.name = "async" -s.version = "1.0.0" -s.summary = "Async is a utility framework which provides asynchronous working to help processing b...
Fix error git url podspec
diff --git a/test/unit/model/test_test.rb b/test/unit/model/test_test.rb index abc1234..def5678 100644 --- a/test/unit/model/test_test.rb +++ b/test/unit/model/test_test.rb @@ -23,4 +23,14 @@ assert test.respond_to? 'ws_security=' end + def test_has_tag + test = Test.new {|t| t.tags = ["dev", "ss1"] } + ...
Add support for tags at test case scope.
diff --git a/recipes/bsd_service.rb b/recipes/bsd_service.rb index abc1234..def5678 100644 --- a/recipes/bsd_service.rb +++ b/recipes/bsd_service.rb @@ -29,6 +29,11 @@ mode 00755 end + # Remove wrong rc.d script created by an older version of cookbook + file '/etc/rc.d/chef-client' do + action :delete + ...
Remove wrong rc.d script created by an older version of cookbook
diff --git a/spec/lib/reveal-ck/commands/listen_to_reload_browser_spec.rb b/spec/lib/reveal-ck/commands/listen_to_reload_browser_spec.rb index abc1234..def5678 100644 --- a/spec/lib/reveal-ck/commands/listen_to_reload_browser_spec.rb +++ b/spec/lib/reveal-ck/commands/listen_to_reload_browser_spec.rb @@ -12,11 +12,19 @@...
Update reload browser spec to verify output_dir
diff --git a/app/controllers/exam_authorization_requests_controller.rb b/app/controllers/exam_authorization_requests_controller.rb index abc1234..def5678 100644 --- a/app/controllers/exam_authorization_requests_controller.rb +++ b/app/controllers/exam_authorization_requests_controller.rb @@ -1,6 +1,8 @@ class ExamAutho...
Replace create! by find_or_create_by! to avoid multiple creations
diff --git a/summon.rb b/summon.rb index abc1234..def5678 100644 --- a/summon.rb +++ b/summon.rb @@ -1,5 +1,5 @@ class Summon < Formula - desc "A command-line tool to make working with secrets easier" + desc "Tool to make working with secrets easier" homepage "https://github.com/conjurinc/summon" url "https://g...
Update description to pass homebrew audit
diff --git a/capistrano-ext-puppetize.gemspec b/capistrano-ext-puppetize.gemspec index abc1234..def5678 100644 --- a/capistrano-ext-puppetize.gemspec +++ b/capistrano-ext-puppetize.gemspec @@ -14,8 +14,9 @@ spec.add_dependency 'capistrano', '>=2.0.0' spec.add_dependency 'capistrano-ext' - spec.add_dependency 'c...
Change spec dependancies to development only
diff --git a/acceptance/setup/pre_suite/12_upgrade_distros.rb b/acceptance/setup/pre_suite/12_upgrade_distros.rb index abc1234..def5678 100644 --- a/acceptance/setup/pre_suite/12_upgrade_distros.rb +++ b/acceptance/setup/pre_suite/12_upgrade_distros.rb @@ -0,0 +1,21 @@+def upgrade_pkgs_on_host(host, os) + case os + w...
Upgrade distros to ensure all packages are the latest Without this we are seeing elements fall behind, such as the new SSL changes to the EPEL mirror which are no longer compatible with the SSL setup on older RHEL6/7 boxes. Signed-off-by: Ken Barber <470bc578162732ac7f9d387d34c4af4ca6e1b6f7@bob.sh>
diff --git a/spec/delayed_job_mongoid_spec.rb b/spec/delayed_job_mongoid_spec.rb index abc1234..def5678 100644 --- a/spec/delayed_job_mongoid_spec.rb +++ b/spec/delayed_job_mongoid_spec.rb @@ -1,5 +1,5 @@ require 'spec_helper' describe Delayed::Backend::Mongoid::Job do - it_should_behave_like 'a delayed_job backend...
Convert specs to the new RSpec expectation syntax See http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
diff --git a/activesupport/lib/active_support/ordered_hash.rb b/activesupport/lib/active_support/ordered_hash.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/ordered_hash.rb +++ b/activesupport/lib/active_support/ordered_hash.rb @@ -5,7 +5,7 @@ end module ActiveSupport - # <tt>ActiveSupport:...
Add a commend about deprecation of ActiveSupport::OrderedHash It is in the code to provides backward compatibility for people that have this class serialized as YAML in some storage. Closes #22681
diff --git a/lib/data_mapper/engine/veritas_engine.rb b/lib/data_mapper/engine/veritas_engine.rb index abc1234..def5678 100644 --- a/lib/data_mapper/engine/veritas_engine.rb +++ b/lib/data_mapper/engine/veritas_engine.rb @@ -6,8 +6,25 @@ # Engine for Veritas class VeritasEngine < self + + # @see Engine#...
Add more comprehensive docs for Engine::VeritasEngine
diff --git a/lib/earth/locality/country/data_miner.rb b/lib/earth/locality/country/data_miner.rb index abc1234..def5678 100644 --- a/lib/earth/locality/country/data_miner.rb +++ b/lib/earth/locality/country/data_miner.rb @@ -16,7 +16,7 @@ store 'name', :field_number => 0 end - import 'country-specif...
Fix typo in attribution of Country flight route inefficiency factor data
diff --git a/lib/invision_bridge/invision_bridge.rb b/lib/invision_bridge/invision_bridge.rb index abc1234..def5678 100644 --- a/lib/invision_bridge/invision_bridge.rb +++ b/lib/invision_bridge/invision_bridge.rb @@ -7,14 +7,20 @@ module ClassMethods def establish_bridge() if Rails - config...
Improve error message when database configuration can't be read
diff --git a/lib/tritium/parser/instructions/block.rb b/lib/tritium/parser/instructions/block.rb index abc1234..def5678 100644 --- a/lib/tritium/parser/instructions/block.rb +++ b/lib/tritium/parser/instructions/block.rb @@ -5,6 +5,7 @@ attr :statements, true def initialize(filename, line_num, statemen...
Make sure to set parents after load
diff --git a/lib/vhdl_test_script/dsl/dummy_entity.rb b/lib/vhdl_test_script/dsl/dummy_entity.rb index abc1234..def5678 100644 --- a/lib/vhdl_test_script/dsl/dummy_entity.rb +++ b/lib/vhdl_test_script/dsl/dummy_entity.rb @@ -1,5 +1,6 @@ module VhdlTestScript::DSL class DummyEntity + class UndefinedPortError < NoM...
Raise UndefinedPortError instead of NoMethodError
diff --git a/test/test_lesstidy.rb b/test/test_lesstidy.rb index abc1234..def5678 100644 --- a/test/test_lesstidy.rb +++ b/test/test_lesstidy.rb @@ -8,6 +8,7 @@ pass4: "div[name='foo'] { color: red; }", pass5: "div[name='foo'] { .gradient('$*&!*@#()&!#'); }", pass6: "tt { a: b; }", + pass7: "#menu a,di...
Add one more test case.
diff --git a/lib/traffic_light_controller/config.rb b/lib/traffic_light_controller/config.rb index abc1234..def5678 100644 --- a/lib/traffic_light_controller/config.rb +++ b/lib/traffic_light_controller/config.rb @@ -4,13 +4,13 @@ @config = Hashie::Mash.new(YAML.load_file('./config/config.yml')) end - d...
Use a better argument name
diff --git a/lib/url_format/url_format_validator.rb b/lib/url_format/url_format_validator.rb index abc1234..def5678 100644 --- a/lib/url_format/url_format_validator.rb +++ b/lib/url_format/url_format_validator.rb @@ -1,6 +1,6 @@ class UrlFormatValidator < ActiveModel::EachValidator def validate_each(record, attribut...
Add a check for TLD.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,13 +1,10 @@ require 'rubygems' require 'open-uri' -# requests -url = 'http://api.seobrain.ru/v1/projects?apiKey=d602c8a1-922e-4663-adad-c8cd6e891cde' +url = 'http://api.seobrain.ru/v1/projects/amvzjvb1/positions?apiKey=d602c8a...
Fix regex to select correct numbers
diff --git a/avg.rb b/avg.rb index abc1234..def5678 100644 --- a/avg.rb +++ b/avg.rb @@ -11,8 +11,8 @@ if res.average != avg diff = (res.average - avg) res.map! { |el| (el - diff).round(precision) } - elsif precision != 2 - res.map! { |el| el.round(precision) } + else + res.m...
Fix round situation when we have 1st shot in
diff --git a/script/cruise_build.rb b/script/cruise_build.rb index abc1234..def5678 100644 --- a/script/cruise_build.rb +++ b/script/cruise_build.rb @@ -1,4 +1,10 @@ #!/usr/bin/env ruby + +# Yes, this could be more abstracted, etc. Choosing explicitness for now. +# svn co and rake co need to be in same exec, or cruise ...
Put svn co and rake task in same exec statement for unified return code
diff --git a/script/cruise_build.rb b/script/cruise_build.rb index abc1234..def5678 100644 --- a/script/cruise_build.rb +++ b/script/cruise_build.rb @@ -1,4 +1,10 @@ #!/usr/bin/env ruby + +# Yes, this could be more abstracted, etc. Choosing explicitness for now. +# svn co and rake co need to be in same exec, or cruise ...
Put svn co and rake task in same exec statement for unified return code git-svn-id: 96bd6241e080dd4199045f7177cf3384e2eaed71@1423 2d86388d-c40f-0410-ad6a-a69da6a65d20
diff --git a/whipped-cream.gemspec b/whipped-cream.gemspec index abc1234..def5678 100644 --- a/whipped-cream.gemspec +++ b/whipped-cream.gemspec @@ -4,29 +4,29 @@ require 'whipped-cream/version' Gem::Specification.new do |spec| - spec.name = "whipped-cream" + spec.name = 'whipped-cream' spec.v...
Clean up gemspec, add summary/description
diff --git a/keycutter.gemspec b/keycutter.gemspec index abc1234..def5678 100644 --- a/keycutter.gemspec +++ b/keycutter.gemspec @@ -13,8 +13,6 @@ s.summary = %q{Gemcutter key management} s.description = %q{Multiple gemcutter accounts? Manage your keys with ease.} - s.rubyforge_project = "keycutter" - s....
Drop removed spec property rubyforge_project The RubyGems gemspec property rubyforge_project has been removed without a replacement. ## Background * [RubyForge was closed down in 2013][1]. * [rubygems/rubygems#2436 deprecated the `rubyforge_project` property][2]. [1]: https://twitter.com/evanphx/status/399552820380...
diff --git a/spec/controllers/educators_controller_spec.rb b/spec/controllers/educators_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/educators_controller_spec.rb +++ b/spec/controllers/educators_controller_spec.rb @@ -0,0 +1,33 @@+require 'rails_helper' + +describe EducatorsController, :type ...
Write a very skinny EducatorsController + TODO: Get Devise test helpers like 'educator_session' working within Rspec controller context
diff --git a/test/unit/gateways/epsilon_test.rb b/test/unit/gateways/epsilon_test.rb index abc1234..def5678 100644 --- a/test/unit/gateways/epsilon_test.rb +++ b/test/unit/gateways/epsilon_test.rb @@ -1,6 +1,8 @@ require 'test_helper' class EpsilonGatewayTest < MiniTest::Test + include SamplePaymentMethods + def...
Add post_data method encoding test
diff --git a/config/initializers/slack_api.rb b/config/initializers/slack_api.rb index abc1234..def5678 100644 --- a/config/initializers/slack_api.rb +++ b/config/initializers/slack_api.rb @@ -7,7 +7,7 @@ client = Slack.realtime client.on :team_join do |data| - welcome = "Welcome to slashrocket, <@#{data['user']['n...
Remove brackets from welcome message
diff --git a/lib/dugway/liquid/filters/comparison_filters.rb b/lib/dugway/liquid/filters/comparison_filters.rb index abc1234..def5678 100644 --- a/lib/dugway/liquid/filters/comparison_filters.rb +++ b/lib/dugway/liquid/filters/comparison_filters.rb @@ -0,0 +1,42 @@+module ComparisonFilters + def num_gt(input, operand)...
Include our custom comparison filters
diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/projects_controller.rb +++ b/app/controllers/projects_controller.rb @@ -12,7 +12,7 @@ authorize! :read, @project, :message => "You are not authorised to view Project ##{@p...
Change ProjectsController to explicitly render show action for html format, hopefully fixing the issue where project JSON is being rendered when using the back button in Safari/Chrome
diff --git a/lib/hibiki/cli.rb b/lib/hibiki/cli.rb index abc1234..def5678 100644 --- a/lib/hibiki/cli.rb +++ b/lib/hibiki/cli.rb @@ -1,11 +1,31 @@ require 'socket' +require 'yaml' module Hibiki module Cli class << self def start(args = ARGV) - exit 0 + + config = YAML.load_file('/etc/h...
Load yaml config and listen to the ports
diff --git a/app/controllers/pages.rb b/app/controllers/pages.rb index abc1234..def5678 100644 --- a/app/controllers/pages.rb +++ b/app/controllers/pages.rb @@ -7,8 +7,8 @@ # I wonder if merb-action-args could conceivably support nil defaults def show(id, version = '') @page = Page.first(:slug =>...
Fix a 500 error when trying to show/edit an invalid page at a given version
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -12,7 +12,7 @@ recipe "java::oracle_i386", "Installs the 32-bit jvm without setting it as the default" -%w{ debian ubuntu centos redhat scientific fedora amazon arch oracle freebsd windows }.each do |os| +%w{...
Add suse OS support to the cookbook.
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -10,26 +10,26 @@ supports 'centos' supports 'debian' supports 'fedora' +supports 'freebsd' +supports 'mac_os_x' supports 'oracle' supports 'redhat' -supports 'freebsd' supports 'scientific' -supports 'mac_os...
Remove pessimistic locking in cookbook deps This makes it easier to integrate this cookbook onto nodes with large run lists.
diff --git a/spec/guest-tools/guesttools_spec.rb b/spec/guest-tools/guesttools_spec.rb index abc1234..def5678 100644 --- a/spec/guest-tools/guesttools_spec.rb +++ b/spec/guest-tools/guesttools_spec.rb @@ -1,7 +1,5 @@ require 'spec_helper' -# Since 20140106. See IMAGE-440. Addresses IMAGE-400. -# Certified Ubuntu imag...
Clean up test for mdata-* tools
diff --git a/spec/project/default_config_spec.rb b/spec/project/default_config_spec.rb index abc1234..def5678 100644 --- a/spec/project/default_config_spec.rb +++ b/spec/project/default_config_spec.rb @@ -1,4 +1,8 @@ describe 'config/default.yml' do + subject(:default_config) do + RuboCop::ConfigLoader.load_file('c...
Move test subject to beginning of describe
diff --git a/lib/bugzilla_helper.rb b/lib/bugzilla_helper.rb index abc1234..def5678 100644 --- a/lib/bugzilla_helper.rb +++ b/lib/bugzilla_helper.rb @@ -23,11 +23,13 @@ status = 'NOTFOUND' if url =~ /https?:\/\/bugzilla\.redhat\.com\/show_bug\.cgi\?id=(\d+)/ id = $1 - result = [] tries = 1 ...
Make code a little more precise
diff --git a/spec/partyhat_util_spec.rb b/spec/partyhat_util_spec.rb index abc1234..def5678 100644 --- a/spec/partyhat_util_spec.rb +++ b/spec/partyhat_util_spec.rb @@ -20,10 +20,16 @@ } end - it "should successfully convert experience to level" do - @sliding_experiences.each do |key, value| - convert...
Test coverage back to 100%
diff --git a/lib/epub/book.rb b/lib/epub/book.rb index abc1234..def5678 100644 --- a/lib/epub/book.rb +++ b/lib/epub/book.rb @@ -10,7 +10,8 @@ def manifest end - def spine + def each_page_by_spine + @package.spine.items end def toc @@ -22,8 +23,9 @@ def other_navigation end ...
Add tiny methods to EPUB::Book
diff --git a/lib/fewer/app.rb b/lib/fewer/app.rb index abc1234..def5678 100644 --- a/lib/fewer/app.rb +++ b/lib/fewer/app.rb @@ -23,18 +23,21 @@ end def call(env) - names = names_from_path(env['PATH_INFO']) - engine = engine_klass.new(root, names) + eng = engine(names_from_path(env['PATH_INFO'...
Add method to fetch instantiated engine directly from App.
diff --git a/spec/luchadeer_spec.rb b/spec/luchadeer_spec.rb index abc1234..def5678 100644 --- a/spec/luchadeer_spec.rb +++ b/spec/luchadeer_spec.rb @@ -0,0 +1,24 @@+require 'spec_helper' + +describe Luchadeer do + let(:api_key) { 'VinnCo' } + + describe '.configure' do + it 'returns a Luchadeer::Client' do + ...
Add missing specs for Luchadeer.configure
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,6 +1,6 @@ cask :v1 => 'handbrakecli-nightly' do - version '6985svn' - sha256 'c2dd1a1c94dff36b74bbabea48d0361666208b94b305aa0e9b87aa182...
Update HandbrakeCLI Nightly to v7010svn HandBrakeCLI Nightly v7010svn built 2015-03-25.
diff --git a/lib/sub_diff/differ.rb b/lib/sub_diff/differ.rb index abc1234..def5678 100644 --- a/lib/sub_diff/differ.rb +++ b/lib/sub_diff/differ.rb @@ -4,10 +4,10 @@ # # The payload contains: # - # match - the string segment matching the search. - # prefix - the string segment preceding the ma...
Remove multiple references to "segment" in docs
diff --git a/lib/tasks/migrate.rake b/lib/tasks/migrate.rake index abc1234..def5678 100644 --- a/lib/tasks/migrate.rake +++ b/lib/tasks/migrate.rake @@ -1,4 +1,9 @@ namespace :migrate do + task :swap_old_tag_uniqueness_index do + Tag.collection.drop_index('tag_id_1') # this is the generated name for the unique inde...
Update the unique index on tags Previously we required Tag#tag_id to be unique across all tags, but actually it should be unique within the scope of a given tag_type.
diff --git a/app/models/contractor.rb b/app/models/contractor.rb index abc1234..def5678 100644 --- a/app/models/contractor.rb +++ b/app/models/contractor.rb @@ -26,10 +26,6 @@ end def corporate_id - if acn.present? - acn - else - abn - end + acn.present? ? acn : abn end end
Use shorthand syntax to simplify code (refactor only)
diff --git a/AreaMetricsSDK.podspec b/AreaMetricsSDK.podspec index abc1234..def5678 100644 --- a/AreaMetricsSDK.podspec +++ b/AreaMetricsSDK.podspec @@ -6,6 +6,7 @@ s.author = { "AreaMetrics, Inc." => "engineering@areametrics.com" } s.platform = :ios, "7.0" s.source = { :git => "https://github.com/AreaMetrics/i...
Add source_files line to podspec
diff --git a/spec/models/attachment_spec.rb b/spec/models/attachment_spec.rb index abc1234..def5678 100644 --- a/spec/models/attachment_spec.rb +++ b/spec/models/attachment_spec.rb @@ -4,10 +4,6 @@ it { should belong_to(:object) } it { should validate_presence_of(:file) } - - it "show the avaible codes" do - ...
Remove a test on an old test for the attribute code.
diff --git a/spec/parser/token_list_spec.rb b/spec/parser/token_list_spec.rb index abc1234..def5678 100644 --- a/spec/parser/token_list_spec.rb +++ b/spec/parser/token_list_spec.rb @@ -25,4 +25,9 @@ it "should not accept any other input" do lambda { TokenList.new(:notcode) }.should raise_error(ArgumentError) ...
Make sure string data is not parsed out
diff --git a/spec/recipes/ec2_hints_spec.rb b/spec/recipes/ec2_hints_spec.rb index abc1234..def5678 100644 --- a/spec/recipes/ec2_hints_spec.rb +++ b/spec/recipes/ec2_hints_spec.rb @@ -3,12 +3,8 @@ describe 'aws::ec2_hints' do let(:chef_run) { ChefSpec::SoloRunner.converge(described_recipe) } - it 'sets up the di...
Test for an ohai_hint resource