diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -1,35 +1,38 @@ require 'voxpupuli/acceptance/spec_helper_acceptance' configure_beaker do |host| - # Configure all nodes in nodeset -...
Unify node setup in acceptance helper
diff --git a/qa/qa/page/admin/settings/repository_storage.rb b/qa/qa/page/admin/settings/repository_storage.rb index abc1234..def5678 100644 --- a/qa/qa/page/admin/settings/repository_storage.rb +++ b/qa/qa/page/admin/settings/repository_storage.rb @@ -10,21 +10,11 @@ end def enable_hashed_storag...
Remove unnecessary section looking in admin settings qa Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/lib/app.rb b/lib/app.rb index abc1234..def5678 100644 --- a/lib/app.rb +++ b/lib/app.rb @@ -4,7 +4,7 @@ require 'incoming/dallas/models' require 'omniauth/strategies/dallas' -require 'omniauth-dropbox' +require 'omniauth-dropbox2' DataMapper::Logger.new($stdout, (ENV['DATAMAPPER_LOG_LEVEL'] || :info)...
Fix require for dropbox2 auth
diff --git a/lib/etl.rb b/lib/etl.rb index abc1234..def5678 100644 --- a/lib/etl.rb +++ b/lib/etl.rb @@ -0,0 +1,49 @@+############################################################################### +# Copyright (C) 2015 Chuck Smith +# +# This program is free software: you can redistribute it and/or modify +# it under ...
Add top-level include file that parses config and sets up Sequel modules.
diff --git a/mrbgem.rake b/mrbgem.rake index abc1234..def5678 100644 --- a/mrbgem.rake +++ b/mrbgem.rake @@ -3,6 +3,9 @@ MRuby::Gem::Specification.new('mruby-jpeg') do |spec| spec.license = 'MIT' spec.authors = 'Carson McDonald' + spec.version = '0.1.0' + spec.description = 'mruby wrapper for libjpeg.' + spec....
Add version and description to spec.
diff --git a/Formula/android-ndk.rb b/Formula/android-ndk.rb index abc1234..def5678 100644 --- a/Formula/android-ndk.rb +++ b/Formula/android-ndk.rb @@ -11,7 +11,17 @@ def install bin.mkpath prefix.install Dir['*'] - %w[ ndk-build ndk-gdb ndk-stack ].each { |app| ln_s prefix+app, bin+app } + + # Creat...
Fix Android NDK packaging for execs Instead of symlinking the execs themselves, launch a script with the hard-coded path. This is similar to how adb works in the android-sdk. Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '1.2.0.1' + s.version = '1.3.0.0' s.summary = 'Common primitives for pl...
Package version is increased from 1.2.0.1 to 1.3.0.0
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'messaging' - s.version = '0.6.1.0' + s.version = '0.6.2.0' s.summary = 'Messaging primitives for Eve...
Package version is increased from 0.6.1.0 to 0.6.2.0
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.9.1.0' + s.version = '0.9.2.0' s.summary = 'Messaging primitives for...
Package version is increased from 0.9.1.0 to 0.9.2.0
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-messaging' - s.version = '0.25.0.0' + s.version = '0.25.0.1' s.summary = 'Common primitives for ...
Package version is increased from 0.25.0.0 to 0.25.0.1
diff --git a/mailer.rb b/mailer.rb index abc1234..def5678 100644 --- a/mailer.rb +++ b/mailer.rb @@ -25,7 +25,7 @@ @message_text, @message_url = message_text, message_url mail(:to => to, :bcc => "contact@openaustralia.org", :from => "noreply@openaustraliafoundation.org.au", - :subject => "A Citizen is c...
Make the tweet post the actual subject contents
diff --git a/HysteriaPlayer.podspec b/HysteriaPlayer.podspec index abc1234..def5678 100644 --- a/HysteriaPlayer.podspec +++ b/HysteriaPlayer.podspec @@ -5,7 +5,7 @@ s.homepage = 'https://github.com/StreetVoice/HysteriaPlayer' s.license = 'MIT' s.author = { 'Stan Tsai' => 'feocms@gmail.com' } - s...
Update podspec refers to master branch
diff --git a/activesupport/test/abstract_unit.rb b/activesupport/test/abstract_unit.rb index abc1234..def5678 100644 --- a/activesupport/test/abstract_unit.rb +++ b/activesupport/test/abstract_unit.rb @@ -7,16 +7,8 @@ $:.unshift("#{root}/activerecord/lib") end - require 'test/unit' - -begin - require 'mocha' -re...
Remove automatic rubygems loading from AS test runner
diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -14,7 +14,7 @@ get :index - expect(assigns(:aretefact...
Fix spelling of `artefact`, and actually test it This test wasn't doing anything before this change, as we weren't validating the assignment of the variable (which wasn't spelled right anyway).
diff --git a/spec/controllers/experiments_controller_spec.rb b/spec/controllers/experiments_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/experiments_controller_spec.rb +++ b/spec/controllers/experiments_controller_spec.rb @@ -1,6 +1,18 @@ require 'rails_helper' describe ExperimentsControll...
Add experiment to rspec for experiment controller
diff --git a/spec/lib/pg_search/configuration/column_spec.rb b/spec/lib/pg_search/configuration/column_spec.rb index abc1234..def5678 100644 --- a/spec/lib/pg_search/configuration/column_spec.rb +++ b/spec/lib/pg_search/configuration/column_spec.rb @@ -0,0 +1,29 @@+require "spec_helper" + +describe PgSearch::Configurat...
Add unit test coverage for Column
diff --git a/rails/script/update.rb b/rails/script/update.rb index abc1234..def5678 100644 --- a/rails/script/update.rb +++ b/rails/script/update.rb @@ -11,9 +11,9 @@ echo 'created tmp dir'; echo 'cloning rails'; git clone git://github.com/rails/rails.git; - cp ./rails/actionpack/lib/action_view/locale/en-US.y...
Update default rails translations fetching script due to locale naming changes
diff --git a/spec/features/jobs/job_new_spec.rb b/spec/features/jobs/job_new_spec.rb index abc1234..def5678 100644 --- a/spec/features/jobs/job_new_spec.rb +++ b/spec/features/jobs/job_new_spec.rb @@ -3,17 +3,11 @@ # I want to create a new job # So other people can see it feature "Create a new job", :devise do - ...
Improve job create feature test
diff --git a/lib/parsley_simple_form/constraints/basics/type_constraint.rb b/lib/parsley_simple_form/constraints/basics/type_constraint.rb index abc1234..def5678 100644 --- a/lib/parsley_simple_form/constraints/basics/type_constraint.rb +++ b/lib/parsley_simple_form/constraints/basics/type_constraint.rb @@ -13,8 +13,9 ...
Fix bug for non-mapped types
diff --git a/app/controllers/errors_controller.rb b/app/controllers/errors_controller.rb index abc1234..def5678 100644 --- a/app/controllers/errors_controller.rb +++ b/app/controllers/errors_controller.rb @@ -7,6 +7,9 @@ end def system_health + # send metric to AWS for the number of delayed jobs currently run...
[TTPLAT-1024] Set up metrics for delayed job queue length.
diff --git a/app/models/grade_span_expectation.rb b/app/models/grade_span_expectation.rb index abc1234..def5678 100644 --- a/app/models/grade_span_expectation.rb +++ b/app/models/grade_span_expectation.rb @@ -4,6 +4,8 @@ belongs_to :assessment_target has_many :unifying_themes, :through ...
Use default scope in gse model to limit searches to grades 9-11
diff --git a/Casks/intellij-idea.rb b/Casks/intellij-idea.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea.rb +++ b/Casks/intellij-idea.rb @@ -1,6 +1,6 @@ class IntellijIdea < Cask - version '13.1.4b' - sha256 'e72c5c2e41a0de9fd7b81093bc3d9e4357e02200dbd209fa9384ddfa4cc52e08' + version '13.1.5' + sha256 '...
Update IntelliJ IDEA to 13.1.5
diff --git a/0_code_wars/directions_reduction.rb b/0_code_wars/directions_reduction.rb index abc1234..def5678 100644 --- a/0_code_wars/directions_reduction.rb +++ b/0_code_wars/directions_reduction.rb @@ -0,0 +1,59 @@+# http://www.codewars.com/kata/550f22f4d758534c1100025a/train/ruby +# --- iteration 1 --- +REDUCEABLE_...
Add code wars (5) - directions reduction
diff --git a/app/controllers/admin_controller.rb b/app/controllers/admin_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin_controller.rb +++ b/app/controllers/admin_controller.rb @@ -1,2 +1,6 @@ class AdminController < ApplicationController + before_action :authorize_admin + def authorize_admin ...
Check if admin before loading the admin page
diff --git a/app/controllers/index_controller.rb b/app/controllers/index_controller.rb index abc1234..def5678 100644 --- a/app/controllers/index_controller.rb +++ b/app/controllers/index_controller.rb @@ -5,14 +5,8 @@ # All of these endpoints should use https://www.inaturalist.org as the base URL, particularly endpoint...
Update get request to hit the API
diff --git a/app/controllers/teams_controller.rb b/app/controllers/teams_controller.rb index abc1234..def5678 100644 --- a/app/controllers/teams_controller.rb +++ b/app/controllers/teams_controller.rb @@ -47,6 +47,7 @@ authorize Team.first @team = BusinessUnit.new(new_team_params) + @team.role = 'responde...
Add Team property responder when creating Business Unit
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -13,7 +13,7 @@ end def update - if current_user.update_without_password(user_params) + if current_user....
Use update_attributes instead of update_without_password because strong parameters already filter out any possible password params.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,6 +1,8 @@ class UsersController < ApplicationController before_action :authenticate_user!, :admin_only!, only:...
Set standard curriculum in artroom controller action
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -19,8 +19,8 @@ def current # look into eager loading @user = current_user - @parcels = @user.parcels....
Add date sort to parcels and trips in users controller
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -13,4 +13,9 @@ users_repo.toggle_admin(params[:id]) redirect_to users_url, notice: "User's permissions has ...
Add toggle_paused method to UsersController
diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/votes_controller.rb +++ b/app/controllers/votes_controller.rb @@ -29,7 +29,7 @@ end if model - @votable = model.find(params[:votable_id]) + @votable = model.fin...
Handle bad votable ID without exception
diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/votes_controller.rb +++ b/app/controllers/votes_controller.rb @@ -22,6 +22,15 @@ redirect_to question_path(@question) end + def upvote + @vote = @answer.votes.where(use...
Add upvote action to VotesController
diff --git a/DFImageManager.podspec b/DFImageManager.podspec index abc1234..def5678 100644 --- a/DFImageManager.podspec +++ b/DFImageManager.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = "DFImageManager" - s.version = "0.0.12" - s.summary = "Complete solution for fetching, caching and ...
Increase podspec version to 0.0.13
diff --git a/spec/controllers/magazines_controller_index_bench_spec.rb b/spec/controllers/magazines_controller_index_bench_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/magazines_controller_index_bench_spec.rb +++ b/spec/controllers/magazines_controller_index_bench_spec.rb @@ -0,0 +1,18 @@+# frozen_strin...
:rotating_light: Add performance test for /api/magazines
diff --git a/spec/controllers/site_controller_spec.rb b/spec/controllers/site_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/site_controller_spec.rb +++ b/spec/controllers/site_controller_spec.rb @@ -10,7 +10,7 @@ it "GET search" do get :search, {search: "git-init"} expect(assigns(:...
Fix partial name for render_template expectation
diff --git a/lib/appointment_ticket.rb b/lib/appointment_ticket.rb index abc1234..def5678 100644 --- a/lib/appointment_ticket.rb +++ b/lib/appointment_ticket.rb @@ -10,7 +10,7 @@ client.tickets.create( type: 'task', group_id: ZENDESK_ONLINE_BOOKING_GROUP, - subject: 'Online Booking Request', + ...
Include service in appointment ticket subject
diff --git a/sentry-raven.gemspec b/sentry-raven.gemspec index abc1234..def5678 100644 --- a/sentry-raven.gemspec +++ b/sentry-raven.gemspec @@ -16,7 +16,7 @@ gem.license = 'Apache-2.0' gem.required_ruby_version = '>= 1.9.0' - gem.add_dependency "faraday", ">= 0.7.6", "<= 0.9.x" + gem.add_dependency "faraday",...
Fix error in previous commit - need to support 0.9.x
diff --git a/test/html_filters/task_list_test.rb b/test/html_filters/task_list_test.rb index abc1234..def5678 100644 --- a/test/html_filters/task_list_test.rb +++ b/test/html_filters/task_list_test.rb @@ -27,4 +27,26 @@ assert_html_eq(mato.process(input).render_html, output) end + + def test_empty_task_list +...
Add test for empty task list
diff --git a/spec/support/checks/extend_test_check.rb b/spec/support/checks/extend_test_check.rb index abc1234..def5678 100644 --- a/spec/support/checks/extend_test_check.rb +++ b/spec/support/checks/extend_test_check.rb @@ -4,8 +4,8 @@ class MyCheck < ExtendCheck def pattern - '' + 'NilClass...
Fix syntactically invalid Machete pattern in a check used in specs The invalid pattern caused the following spec failure: 1) Command line interface strict when given --strict argument Failure/Error: it { assert_partial_output "strict checked", all_stdout } expected "" to include "strict checked" # ...
diff --git a/lib/http/response/body.rb b/lib/http/response/body.rb index abc1234..def5678 100644 --- a/lib/http/response/body.rb +++ b/lib/http/response/body.rb @@ -9,7 +9,7 @@ include Enumerable def_delegator :to_s, :empty? - def initialize(client, encoding) + def initialize(client, encoding =...
Set default HTTP::Response::Body encoding to Encoding::BINARY Otherwise we break Webmock
diff --git a/core/db/migrate/20140120135026_remove_facts_without_site.rb b/core/db/migrate/20140120135026_remove_facts_without_site.rb index abc1234..def5678 100644 --- a/core/db/migrate/20140120135026_remove_facts_without_site.rb +++ b/core/db/migrate/20140120135026_remove_facts_without_site.rb @@ -1,11 +1,11 @@ class...
Use Fact.ids and don't use keep_if
diff --git a/test/controllers/attachments_controller_test.rb b/test/controllers/attachments_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/attachments_controller_test.rb +++ b/test/controllers/attachments_controller_test.rb @@ -18,6 +18,7 @@ setup do sign_in users(:alice) + Tenant.c...
Fix race condition when tenant is not set in tests
diff --git a/lib/quick_travel/party.rb b/lib/quick_travel/party.rb index abc1234..def5678 100644 --- a/lib/quick_travel/party.rb +++ b/lib/quick_travel/party.rb @@ -2,8 +2,8 @@ class Party < Adapter LOGIN_URL = '/login.json' - attr_accessor :phone, :mobile, :email # if has a contact - attr_accessor :po...
Make these readers (but maybe they aren't even needed)
diff --git a/lib/stripe/list_object.rb b/lib/stripe/list_object.rb index abc1234..def5678 100644 --- a/lib/stripe/list_object.rb +++ b/lib/stripe/list_object.rb @@ -6,7 +6,7 @@ end def all(filters={}) - response, api_key = Stripe.request(:get, url, api_key, filters) + response, api_key = Stripe.req...
Fix confusion in ListObject around where api_key was coming from Fixes #69
diff --git a/prepare.rb b/prepare.rb index abc1234..def5678 100644 --- a/prepare.rb +++ b/prepare.rb @@ -9,7 +9,8 @@ FileUtils.rm_r("#{prepared_dir}", :verbose => true) FileUtils.cp_r("./", "#{prepared_dir}", :verbose => true) FileUtils.rm_r(Dir.glob("#{prepared_dir}/**/*.{psd}"), :verbose => true) -FileUtils.rm_r(["...
Delete .DS_Store files and tests directory.
diff --git a/testing/lib/refinery/testing/controller_macros/methods.rb b/testing/lib/refinery/testing/controller_macros/methods.rb index abc1234..def5678 100644 --- a/testing/lib/refinery/testing/controller_macros/methods.rb +++ b/testing/lib/refinery/testing/controller_macros/methods.rb @@ -2,29 +2,34 @@ module Test...
Change *args splat to options hash because we need a hash instead of array.
diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb index abc1234..def5678 100644 --- a/app/controllers/groups_controller.rb +++ b/app/controllers/groups_controller.rb @@ -18,6 +18,10 @@ @group = Group.new(groups_params) if @group.save + # Write a new relationship to...
Add Group Creator to group as admin.
diff --git a/app/decorators/category_decorator.rb b/app/decorators/category_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/category_decorator.rb +++ b/app/decorators/category_decorator.rb @@ -14,7 +14,9 @@ end def div_color - unless model.color.blank? + if model.color.blank? + content...
Add message when no color chosen
diff --git a/app/models/spree/stock/quantifier.rb b/app/models/spree/stock/quantifier.rb index abc1234..def5678 100644 --- a/app/models/spree/stock/quantifier.rb +++ b/app/models/spree/stock/quantifier.rb @@ -11,6 +11,8 @@ end def total_on_hand + # Associated stock_items no longer exist if the var...
Add explanatory comment on soft-deleted variant stock logic
diff --git a/app/presenters/govspeak_presenter.rb b/app/presenters/govspeak_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/govspeak_presenter.rb +++ b/app/presenters/govspeak_presenter.rb @@ -15,7 +15,7 @@ private def interpolate_fact_values(string) - return string if !string.match(EMBEDDED_F...
Use `unless` instead of if negate
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -12,5 +12,5 @@ end unless ENV['CUSTOM_DEVICE_SET_PATH'] == 'false' - SimCtl.device_set_path = Dir.mktmpdir + SimCtl.device_set_path = Dir.mktmpdir 'foo bar' end
Test device set path with spaces
diff --git a/app/value_objects/contacts_search.rb b/app/value_objects/contacts_search.rb index abc1234..def5678 100644 --- a/app/value_objects/contacts_search.rb +++ b/app/value_objects/contacts_search.rb @@ -8,14 +8,15 @@ end def search_name - search.where "title LIKE :name OR description LIKE :name", name: ...
Fix deprication warning, and issue with ambiguous fields
diff --git a/app/controllers/door/log_entries_controller.rb b/app/controllers/door/log_entries_controller.rb index abc1234..def5678 100644 --- a/app/controllers/door/log_entries_controller.rb +++ b/app/controllers/door/log_entries_controller.rb @@ -21,7 +21,11 @@ # TODO: Move to token-based authentication when there ...
Determine the remote IP only by request.remote_ip Also log any unauthorized attempts.
diff --git a/app/lib/manual_update_type.rb b/app/lib/manual_update_type.rb index abc1234..def5678 100644 --- a/app/lib/manual_update_type.rb +++ b/app/lib/manual_update_type.rb @@ -26,8 +26,8 @@ manual. sections. select(&:needs_exporting?). - all? { |d| - d.minor_update? && d.has_ever_been...
Rename local variable d -> s in ManualUpdateType This must've been missed when we renamed `SpecialistDocument` to `Section`. Presumably `d` is short for `document`; `s` is short for `section`.
diff --git a/kata/04.rb b/kata/04.rb index abc1234..def5678 100644 --- a/kata/04.rb +++ b/kata/04.rb @@ -0,0 +1,92 @@+module Kata04 + + class Weather + + # line 1: header + # line 2: separator + # lines 3-31: observations + # line 32: summary + def lines + @lines ||= File.readlines 'kata/data/weath...
Add Kata 4 - before DRY
diff --git a/app/models/data_model/gene.rb b/app/models/data_model/gene.rb index abc1234..def5678 100644 --- a/app/models/data_model/gene.rb +++ b/app/models/data_model/gene.rb @@ -16,16 +16,16 @@ def potentially_druggable_genes #return Go or other potentially druggable categories - citation_ids = Dat...
Update DataModel::Gene to use the new schema changes
diff --git a/Library/Homebrew/test/test_sandbox.rb b/Library/Homebrew/test/test_sandbox.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/test_sandbox.rb +++ b/Library/Homebrew/test/test_sandbox.rb @@ -4,25 +4,25 @@ class SandboxTest < Homebrew::TestCase def setup skip "sandbox not implemented" unles...
Manage sandbox test resources in setup/teardown
diff --git a/app/controllers/audits_controller.rb b/app/controllers/audits_controller.rb index abc1234..def5678 100644 --- a/app/controllers/audits_controller.rb +++ b/app/controllers/audits_controller.rb @@ -3,8 +3,8 @@ # GET /audits.json def index if params[:start_date] and params[:end_date] - @start_d...
Simplify the date parsing in audits controller. Former-commit-id: 0dfce56b42f22a8c9f3d57ae9860beff08bc0cb3
diff --git a/app/controllers/organs_controller.rb b/app/controllers/organs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/organs_controller.rb +++ b/app/controllers/organs_controller.rb @@ -33,6 +33,7 @@ respond_to do |format| format.html format.json { render :json => Organ.find(par...
Add fragment support to organ controller show
diff --git a/app/controllers/twilio_controller.rb b/app/controllers/twilio_controller.rb index abc1234..def5678 100644 --- a/app/controllers/twilio_controller.rb +++ b/app/controllers/twilio_controller.rb @@ -1,4 +1,7 @@ class TwilioController < ApplicationController + # skip the csrf verification because this endpoin...
Disable csrf check for twilio controller
diff --git a/app/dashboards/dashboard_manifest.rb b/app/dashboards/dashboard_manifest.rb index abc1234..def5678 100644 --- a/app/dashboards/dashboard_manifest.rb +++ b/app/dashboards/dashboard_manifest.rb @@ -10,9 +10,9 @@ # Dashboards returned from this method must be Rails models for Administrate # to work corre...
Change resource listing at sidebar of administrate
diff --git a/_plugins/url_encode.rb b/_plugins/url_encode.rb index abc1234..def5678 100644 --- a/_plugins/url_encode.rb +++ b/_plugins/url_encode.rb @@ -0,0 +1,13 @@+# From https://stackoverflow.com/questions/15976495/how-to-url-encode-in-jekyll-liquid/17769287#17769287 +require 'liquid' +require 'uri' + +# Percent enc...
Fix badly encoded subject in mailto templates
diff --git a/sfn-parameters.gemspec b/sfn-parameters.gemspec index abc1234..def5678 100644 --- a/sfn-parameters.gemspec +++ b/sfn-parameters.gemspec @@ -10,6 +10,6 @@ s.description = 'SparkleFormation Parameters Callback' s.license = 'Apache-2.0' s.require_path = 'lib' - s.add_dependency 'sfn', '>= 1.0.0', '< ...
Update minumum constraint to ensure properly functioning compile param usage via config
diff --git a/apps/web/views/tasks/index.rb b/apps/web/views/tasks/index.rb index abc1234..def5678 100644 --- a/apps/web/views/tasks/index.rb +++ b/apps/web/views/tasks/index.rb @@ -20,7 +20,7 @@ def task_statuses { - 'in progress' => 'In progress', + 'in progress' => 'Open', 'assigne...
Use better name instead 'in progress' for task attribute
diff --git a/app/controllers/static_controller.rb b/app/controllers/static_controller.rb index abc1234..def5678 100644 --- a/app/controllers/static_controller.rb +++ b/app/controllers/static_controller.rb @@ -1,4 +1,6 @@ class StaticController < ApplicationController + skip_before_action :require_login, only: :contact...
Make Contact Us page accessible when not logged in.
diff --git a/lib/cb/Utils/string.rb b/lib/cb/Utils/string.rb index abc1234..def5678 100644 --- a/lib/cb/Utils/string.rb +++ b/lib/cb/Utils/string.rb @@ -7,4 +7,4 @@ self.sub!(/^[a-z\d]*/) { $&.capitalize } self.gsub(/(?:_|(\/))([a-z\d]*)/) { "#{$2.capitalize}" }.gsub('/', '::') end -end+end
Add newline to file (shouldn't make a difference)
diff --git a/site-cookbooks/dna/recipes/dotfiles.rb b/site-cookbooks/dna/recipes/dotfiles.rb index abc1234..def5678 100644 --- a/site-cookbooks/dna/recipes/dotfiles.rb +++ b/site-cookbooks/dna/recipes/dotfiles.rb @@ -3,11 +3,12 @@ # # Download dotfiles # -git "Download wilr/dotfiles" do - repository "http://github.c...
Use DNA dot files rather than my personal one at this stage
diff --git a/lib/dm-tags/tagging.rb b/lib/dm-tags/tagging.rb index abc1234..def5678 100644 --- a/lib/dm-tags/tagging.rb +++ b/lib/dm-tags/tagging.rb @@ -10,6 +10,8 @@ belongs_to :tag def taggable - eval("#{taggable_type}.get!(#{taggable_id})") if taggable_type and taggable_id + if taggable_type and taggabl...
[dm-tags] Remove eval and use send, as it's safer
diff --git a/app/uploaders/attachment_uploader.rb b/app/uploaders/attachment_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/attachment_uploader.rb +++ b/app/uploaders/attachment_uploader.rb @@ -1,6 +1,10 @@ # encoding: utf-8 class AttachmentUploader < CarrierWave::Uploader::Base + def store_dir + ...
Add s3 storage dir structure
diff --git a/app/models/business.rb b/app/models/business.rb index abc1234..def5678 100644 --- a/app/models/business.rb +++ b/app/models/business.rb @@ -1,4 +1,5 @@ class Business < ActiveRecord::Base + Elasticsearch::Model.client = Elasticsearch::Client.new url: ENV['BONSAI_URL'], log: true include Elasticsear...
Add connection params for elasticsearch to model as troubleshoot
diff --git a/spec/factories/subscription_factory.rb b/spec/factories/subscription_factory.rb index abc1234..def5678 100644 --- a/spec/factories/subscription_factory.rb +++ b/spec/factories/subscription_factory.rb @@ -1,5 +1,9 @@ FactoryGirl.define do factory :subscription, class: Spree::Subscription do + before(:...
Fix failing test * Create a product before create a subscription factory
diff --git a/spec/models/method_parens_rule_spec.rb b/spec/models/method_parens_rule_spec.rb index abc1234..def5678 100644 --- a/spec/models/method_parens_rule_spec.rb +++ b/spec/models/method_parens_rule_spec.rb @@ -26,4 +26,18 @@ expect(%(def valid ruby)).to violate(MethodParensRule) end end + + contex...
Test MethodParensRule against non-method definitions
diff --git a/app/models/specfile.rb b/app/models/specfile.rb index abc1234..def5678 100644 --- a/app/models/specfile.rb +++ b/app/models/specfile.rb @@ -18,6 +18,6 @@ specfile.srpm_id = srpm.id specfile.branch_id = branch.id specfile.spec = spec - specfile.save + specfile.save! end end
Raise exception of Specfile record can't be saved
diff --git a/app/models/spitcast.rb b/app/models/spitcast.rb index abc1234..def5678 100644 --- a/app/models/spitcast.rb +++ b/app/models/spitcast.rb @@ -10,6 +10,7 @@ def parse_response(spot, request, responses) responses.each do |response| + next unless response.gmt record = unscoped.where...
Fix for Spitcast forecast data with no timestamp
diff --git a/lib/pry-remote-auto.rb b/lib/pry-remote-auto.rb index abc1234..def5678 100644 --- a/lib/pry-remote-auto.rb +++ b/lib/pry-remote-auto.rb @@ -26,6 +26,7 @@ sleep 1 system 'osascript', '-e', 'tell application "Terminal" to do script "' + cmd + '"' + system 'osascript', '-e', 'tell applicat...
Bring Terminal window to foreground
diff --git a/lib/queue_publisher.rb b/lib/queue_publisher.rb index abc1234..def5678 100644 --- a/lib/queue_publisher.rb +++ b/lib/queue_publisher.rb @@ -7,6 +7,9 @@ end attr_reader :exchange, :channel + + class PublishFailedError < StandardError + end def send_message(item) return if @noop @@ -20,7 +...
Use a custom exception for publish failure This should make it easier to filter in errbit, and be a bit cleaner.
diff --git a/lib/rivendell/tools.rb b/lib/rivendell/tools.rb index abc1234..def5678 100644 --- a/lib/rivendell/tools.rb +++ b/lib/rivendell/tools.rb @@ -26,8 +26,10 @@ end def self.script(opts, global_opts) + require 'logger' + logger = Logger.new($stdout) arguments = opts[:arguments] - eval File.r...
Add a logger for script
diff --git a/lib/sagepayadminapi.rb b/lib/sagepayadminapi.rb index abc1234..def5678 100644 --- a/lib/sagepayadminapi.rb +++ b/lib/sagepayadminapi.rb @@ -1,5 +1,3 @@-require_relative "./sagepayadminapi/version" - class SagePayAdminAPI VERSION = '0.0.2'
Remove require version from class file.
diff --git a/spec/unit/resource/cron_access_spec.rb b/spec/unit/resource/cron_access_spec.rb index abc1234..def5678 100644 --- a/spec/unit/resource/cron_access_spec.rb +++ b/spec/unit/resource/cron_access_spec.rb @@ -21,7 +21,7 @@ let(:resource) { Chef::Resource::CronAccess.new("bob") } it "has a default action ...
Fix the default action in the cron_access spec Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/views/users/show.html.erb_spec.rb b/spec/views/users/show.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/users/show.html.erb_spec.rb +++ b/spec/views/users/show.html.erb_spec.rb @@ -1,5 +1,10 @@ require 'spec_helper' describe "users/show.html.erb" do - pending "add some examples t...
Test for username in view spec
diff --git a/lib/starscope/datum.rb b/lib/starscope/datum.rb index abc1234..def5678 100644 --- a/lib/starscope/datum.rb +++ b/lib/starscope/datum.rb @@ -15,10 +15,8 @@ fqn[0...-1].reverse.each do |test| if test.to_sym == @scope[i] score += 5 - elsif Regexp.new(test).match(@scope[i]) - sc...
Simplify match scoring a bit
diff --git a/lib/tasks/crawler.rake b/lib/tasks/crawler.rake index abc1234..def5678 100644 --- a/lib/tasks/crawler.rake +++ b/lib/tasks/crawler.rake @@ -1,7 +1,6 @@ namespace :crawler do - desc 'Spider the site route pages' - task :routes => :environment do + def connect_to_site require 'net/http' req...
Add stop and stop area crawling
diff --git a/lib/tasks/demoviz.rake b/lib/tasks/demoviz.rake index abc1234..def5678 100644 --- a/lib/tasks/demoviz.rake +++ b/lib/tasks/demoviz.rake @@ -0,0 +1,15 @@+namespace :demoviz do + desc "Clear stale demo visualizations" + task clear: :environment do + Visualization.where("updated_at < ?", 6.hours.ago).des...
Add rake tasks to cleanup demo visualizations
diff --git a/lib/tasks/spec_db.rake b/lib/tasks/spec_db.rake index abc1234..def5678 100644 --- a/lib/tasks/spec_db.rake +++ b/lib/tasks/spec_db.rake @@ -7,11 +7,7 @@ failed = false databases.each do |database| - failed = true unless test_against database - end - - if failed - fail...
Rework `rake db:spec` to fail immediately on errors.
diff --git a/test/mem_model/test_rooted_base.rb b/test/mem_model/test_rooted_base.rb index abc1234..def5678 100644 --- a/test/mem_model/test_rooted_base.rb +++ b/test/mem_model/test_rooted_base.rb @@ -18,10 +18,22 @@ refute Account.exists? 314159 end - def test_exists - refute Account.exists? @account.id -...
Add separate Maglev and MRI RootedBase test for now
diff --git a/lib/tictactoe_board.rb b/lib/tictactoe_board.rb index abc1234..def5678 100644 --- a/lib/tictactoe_board.rb +++ b/lib/tictactoe_board.rb @@ -2,22 +2,22 @@ class TictactoeBoard - attr_accessor :board, :turn + attr_accessor :board_arr, :turn attr_reader :valid_slots - def initialize (board = Array...
Change variable name to board_arr
diff --git a/irc_tools.gemspec b/irc_tools.gemspec index abc1234..def5678 100644 --- a/irc_tools.gemspec +++ b/irc_tools.gemspec @@ -10,7 +10,7 @@ spec.email = ["markglenfletcher@googlemail.com"] spec.summary = %q{TODO} spec.description = %q{TODO} - spec.homepage = "TODO" + spec.homepage ...
Add github repo url to gemspec
diff --git a/veritas-arango-adapter.gemspec b/veritas-arango-adapter.gemspec index abc1234..def5678 100644 --- a/veritas-arango-adapter.gemspec +++ b/veritas-arango-adapter.gemspec @@ -14,6 +14,7 @@ s.require_paths = %w(lib) s.extra_rdoc_files = %w(README.md) + s.add_dependency('aql', '~> 0.0.1') ...
Add aql ~> 0.0.1 dependency
diff --git a/test/features/deals/search_deals_test.rb b/test/features/deals/search_deals_test.rb index abc1234..def5678 100644 --- a/test/features/deals/search_deals_test.rb +++ b/test/features/deals/search_deals_test.rb @@ -8,4 +8,11 @@ page.text.must_include "Widgets" page.text.wont_include "Seahawks Suite f...
Test to check if only published and public search results are returned.
diff --git a/lib/active_admin/seo/view_helpers.rb b/lib/active_admin/seo/view_helpers.rb index abc1234..def5678 100644 --- a/lib/active_admin/seo/view_helpers.rb +++ b/lib/active_admin/seo/view_helpers.rb @@ -12,13 +12,13 @@ title = seo_metas.map(&:title).find(&:present?) buffer << content_tag(:title, ...
Allow static url for og:image
diff --git a/lib/activerecord/humanized_errors.rb b/lib/activerecord/humanized_errors.rb index abc1234..def5678 100644 --- a/lib/activerecord/humanized_errors.rb +++ b/lib/activerecord/humanized_errors.rb @@ -2,8 +2,7 @@ module HumanizedErrors def humanized_errors - errors.clear - send :run_validatio...
Use `valid?` to trigger validations. Instead of juggling with ActiveRecord internals, use the `valid?` method totrigger validation callbacks, making errors be available when using humanized_errors method.
diff --git a/lib/bayvid_hasselhoff/puts_slowly.rb b/lib/bayvid_hasselhoff/puts_slowly.rb index abc1234..def5678 100644 --- a/lib/bayvid_hasselhoff/puts_slowly.rb +++ b/lib/bayvid_hasselhoff/puts_slowly.rb @@ -0,0 +1,20 @@+module BayvidHasselhoff + class PutsSlowly + attr_reader :strang + + def initialize(strang)...
Add a PutsSlowly class to, you know, puts slowly.
diff --git a/lib/chargify/booking_value_report.rb b/lib/chargify/booking_value_report.rb index abc1234..def5678 100644 --- a/lib/chargify/booking_value_report.rb +++ b/lib/chargify/booking_value_report.rb @@ -18,15 +18,15 @@ table << headers @products.values.each do |product| - table << Row.new(@t...
Rename because more rows are coming
diff --git a/runner/daily_runner.rb b/runner/daily_runner.rb index abc1234..def5678 100644 --- a/runner/daily_runner.rb +++ b/runner/daily_runner.rb @@ -12,6 +12,7 @@ stats.connect Pod.where(:deleted => false).each do |pod| + puts "Grabbing stats for: #{pod.name}" data = stats.stat_for_pod pod.id...
Make sure it echos something out, heroku cancels a task after an hour if it's not outputted anything
diff --git a/integration-tests/spec/runtime_injection_spec.rb b/integration-tests/spec/runtime_injection_spec.rb index abc1234..def5678 100644 --- a/integration-tests/spec/runtime_injection_spec.rb +++ b/integration-tests/spec/runtime_injection_spec.rb @@ -17,9 +17,15 @@ require 'torquebox-core' - it "should wor...
Add integration test to ensure InjectionError is raised for invalid injections
diff --git a/app/helpers/sites_helper.rb b/app/helpers/sites_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sites_helper.rb +++ b/app/helpers/sites_helper.rb @@ -10,14 +10,12 @@ puts sites if sites.count > 100 #all is well sites.each do |site| - if Site.find_by_site_url(site["site_url"...
Update sites from sites helper instead of trying to create new ones
diff --git a/lib/versionator/detector/owncloud.rb b/lib/versionator/detector/owncloud.rb index abc1234..def5678 100644 --- a/lib/versionator/detector/owncloud.rb +++ b/lib/versionator/detector/owncloud.rb @@ -6,7 +6,7 @@ set :app_name, "ownCloud" set :project_url, "http://owncloud.org/" - set :detec...
Fix ownCloud detector to also detect the development version
diff --git a/api/lib/spree/api/controller_setup.rb b/api/lib/spree/api/controller_setup.rb index abc1234..def5678 100644 --- a/api/lib/spree/api/controller_setup.rb +++ b/api/lib/spree/api/controller_setup.rb @@ -17,6 +17,7 @@ include CanCan::ControllerAdditions append_view_path File.expand_path(...
Append application view paths to possible view path locations
diff --git a/merb_datamapper/lib/merb_datamapper/merbtasks.rb b/merb_datamapper/lib/merb_datamapper/merbtasks.rb index abc1234..def5678 100644 --- a/merb_datamapper/lib/merb_datamapper/merbtasks.rb +++ b/merb_datamapper/lib/merb_datamapper/merbtasks.rb @@ -3,34 +3,27 @@ namespace :dm do task :merb_start do - Me...
Return automigration stuff to merb_datamapper rake tasks
diff --git a/app/controllers/doctors_controller.rb b/app/controllers/doctors_controller.rb index abc1234..def5678 100644 --- a/app/controllers/doctors_controller.rb +++ b/app/controllers/doctors_controller.rb @@ -2,7 +2,7 @@ include Pageable def index - @doctors = Doctor.page(@page).per(@per_page) + @docto...
Order doctors by last name