diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/ffi/gphoto2_port/gp_port_result.rb b/lib/ffi/gphoto2_port/gp_port_result.rb index abc1234..def5678 100644 --- a/lib/ffi/gphoto2_port/gp_port_result.rb +++ b/lib/ffi/gphoto2_port/gp_port_result.rb @@ -2,7 +2,34 @@ module GPhoto2Port # libgphoto2_port/gphoto2/gphoto2-port-result.h GP_OK = 0 -...
Add all return code constants
diff --git a/lib/generators/templates/carpetbomb.rb b/lib/generators/templates/carpetbomb.rb index abc1234..def5678 100644 --- a/lib/generators/templates/carpetbomb.rb +++ b/lib/generators/templates/carpetbomb.rb @@ -12,6 +12,8 @@ markdown = Redcarpet::Markdown.new(Redcarpet::Render::HTML, ...
Enable tables and footnotes options in redcarpet
diff --git a/lib/myplaceonline_execution_context.rb b/lib/myplaceonline_execution_context.rb index abc1234..def5678 100644 --- a/lib/myplaceonline_execution_context.rb +++ b/lib/myplaceonline_execution_context.rb @@ -29,11 +29,11 @@ def self.permission_target=(x); self[:permission_target] = x; end def self.brows...
Fix bug caching browser detection object
diff --git a/script/cruise_build.rb b/script/cruise_build.rb index abc1234..def5678 100644 --- a/script/cruise_build.rb +++ b/script/cruise_build.rb @@ -11,7 +11,7 @@ when "racing_on_rails" exec "rake cruise" when "aba", "atra", "obra", "wsba" - exec "git clone git@butlerpress.com:#{project_name}.git local && rake...
Drop local dir before fetching local
diff --git a/lib/transam_core/transam_object_key.rb b/lib/transam_core/transam_object_key.rb index abc1234..def5678 100644 --- a/lib/transam_core/transam_object_key.rb +++ b/lib/transam_core/transam_object_key.rb @@ -0,0 +1,30 @@+#------------------------------------------------------------------------------ +# +# Tran...
Refactor object_key logic to a real plugin. This deprecates the unique_key mixin
diff --git a/lib/twitter_cldr/timezones/location.rb b/lib/twitter_cldr/timezones/location.rb index abc1234..def5678 100644 --- a/lib/twitter_cldr/timezones/location.rb +++ b/lib/twitter_cldr/timezones/location.rb @@ -14,6 +14,12 @@ def resource @resource ||= TwitterCldr.get_locale_resource(tz.locale, :ti...
Add helper for getting correct period when getting a TZ name
diff --git a/knife-ec-backup.gemspec b/knife-ec-backup.gemspec index abc1234..def5678 100644 --- a/knife-ec-backup.gemspec +++ b/knife-ec-backup.gemspec @@ -19,7 +19,7 @@ # s.add_dependency "mixlib-cli", ">= 1.2.2" s.add_dependency "sequel" s.add_dependency "pg" - s.add_dependency "chef", "~> 11.8" + s.add_de...
Allow us to use chef 12
diff --git a/lib/dimples/renderer.rb b/lib/dimples/renderer.rb index abc1234..def5678 100644 --- a/lib/dimples/renderer.rb +++ b/lib/dimples/renderer.rb @@ -10,7 +10,9 @@ callback = proc { @source.contents } @engine = if @source.path - Tilt.new(@source.path, {}, &callback) + ...
Implement passing rendering options to Tilt
diff --git a/lib/nehm/http_client.rb b/lib/nehm/http_client.rb index abc1234..def5678 100644 --- a/lib/nehm/http_client.rb +++ b/lib/nehm/http_client.rb @@ -14,8 +14,32 @@ # Exception classes class Status404 < StandardError; end + class ConnectionError < StandardError; end def get(api_version, uri_...
Move code with URI forming to separate method Add ConnectionError exception class
diff --git a/app/models/person_edition.rb b/app/models/person_edition.rb index abc1234..def5678 100644 --- a/app/models/person_edition.rb +++ b/app/models/person_edition.rb @@ -2,7 +2,7 @@ require 'attachable' class PersonEdition < Edition - include Attachable + include AttachableWithMetadata # type (Staff / ...
Make PersonEdition attach with metadata
diff --git a/lib/bonsai/webserver.rb b/lib/bonsai/webserver.rb index abc1234..def5678 100644 --- a/lib/bonsai/webserver.rb +++ b/lib/bonsai/webserver.rb @@ -13,7 +13,7 @@ get '/' do begin Page.find("index").render - rescue + rescue Exception => e @error = e.message erb :e...
Fix missing explicit exception assignments
diff --git a/lib/tasks/comments.rake b/lib/tasks/comments.rake index abc1234..def5678 100644 --- a/lib/tasks/comments.rake +++ b/lib/tasks/comments.rake @@ -5,7 +5,6 @@ with_indifferent_access[ENV["RAILS_ENV"] || 'development'] conn = Bunny.new(host: config[:host], - port: config[:port], ...
Remove port from bunny initilization
diff --git a/week-4/largest-integer/my_solution.rb b/week-4/largest-integer/my_solution.rb index abc1234..def5678 100644 --- a/week-4/largest-integer/my_solution.rb +++ b/week-4/largest-integer/my_solution.rb @@ -13,4 +13,5 @@ # Your Solution Below def largest_integer(list_of_nums) # Your code goes here! + list_of...
Add solution file for challenge 4.6
diff --git a/lib/sensu-plugin/cli.rb b/lib/sensu-plugin/cli.rb index abc1234..def5678 100644 --- a/lib/sensu-plugin/cli.rb +++ b/lib/sensu-plugin/cli.rb @@ -6,9 +6,15 @@ class CLI include Mixlib::CLI + # Implementing classes should override this to produce appropriate + # output for their handler...
Add some comments to the base CLI class
diff --git a/spec/pacts/content_store/delete_endpoint_spec.rb b/spec/pacts/content_store/delete_endpoint_spec.rb index abc1234..def5678 100644 --- a/spec/pacts/content_store/delete_endpoint_spec.rb +++ b/spec/pacts/content_store/delete_endpoint_spec.rb @@ -0,0 +1,48 @@+require "rails_helper" + +RSpec.describe "DELETE e...
Add pacts for deleting from content store.
diff --git a/app/resources/api/conversion_resource.rb b/app/resources/api/conversion_resource.rb index abc1234..def5678 100644 --- a/app/resources/api/conversion_resource.rb +++ b/app/resources/api/conversion_resource.rb @@ -10,7 +10,7 @@ ## # Properties # - attributes :status + attributes :status, ...
Add createdAt attribute to Conversion API
diff --git a/features/step_definitions/merge_steps.rb b/features/step_definitions/merge_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/merge_steps.rb +++ b/features/step_definitions/merge_steps.rb @@ -0,0 +1,73 @@+Given /^the articles are set up$/ do + + user_one = User.new + user...
Set up with users and articles for Merge Similar Articles
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Update the cookie key to not clash with Specialist Publisher
diff --git a/spec/api_class_spec.rb b/spec/api_class_spec.rb index abc1234..def5678 100644 --- a/spec/api_class_spec.rb +++ b/spec/api_class_spec.rb @@ -15,7 +15,7 @@ end it "should respond to unrestricted methods" do - LastFM.should_receive(:send_api_request).with("apiclass.foo", {:bar => :baz}).and_return({...
Add request_method param to send_api_request
diff --git a/Casks/beyond-compare.rb b/Casks/beyond-compare.rb index abc1234..def5678 100644 --- a/Casks/beyond-compare.rb +++ b/Casks/beyond-compare.rb @@ -1,6 +1,6 @@ cask 'beyond-compare' do - version '4.1.3.20814' - sha256 '3f2dac1ce5273bf0e9c973e7ee7f82c6ee3720546cabcfc4b2b0017fab561f4c' + version '4.1.5.21031'...
Update Beyond Compare to 4.1.5.21031
diff --git a/lib/sastrawi/stop_word_remover/stop_word_remover.rb b/lib/sastrawi/stop_word_remover/stop_word_remover.rb index abc1234..def5678 100644 --- a/lib/sastrawi/stop_word_remover/stop_word_remover.rb +++ b/lib/sastrawi/stop_word_remover/stop_word_remover.rb @@ -6,6 +6,9 @@ def initialize(dictionary) ...
Add comment to "StopWordRemover" class
diff --git a/lib/dropbox_api/authenticator.rb b/lib/dropbox_api/authenticator.rb index abc1234..def5678 100644 --- a/lib/dropbox_api/authenticator.rb +++ b/lib/dropbox_api/authenticator.rb @@ -6,8 +6,8 @@ def initialize(client_id, client_secret) @auth_code = OAuth2::Client.new(client_id, client_secret, { -...
Use API v2 endpoints rather than v1. Closes #10.
diff --git a/lib/mspec/helpers/environment.rb b/lib/mspec/helpers/environment.rb index abc1234..def5678 100644 --- a/lib/mspec/helpers/environment.rb +++ b/lib/mspec/helpers/environment.rb @@ -11,13 +11,22 @@ env end + def windows_env_echo(var) + `cmd.exe /C ECHO %#{var}%`.strip + end + def username ...
Add helper to find the user's home directory.
diff --git a/lib/nacre/concerns/searchable.rb b/lib/nacre/concerns/searchable.rb index abc1234..def5678 100644 --- a/lib/nacre/concerns/searchable.rb +++ b/lib/nacre/concerns/searchable.rb @@ -15,16 +15,22 @@ end def default_search_options + options = default_get_options + options[:pagination] = { + ...
Create default get options and derive search defaults from it
diff --git a/lib/quickbooks/service_handle.rb b/lib/quickbooks/service_handle.rb index abc1234..def5678 100644 --- a/lib/quickbooks/service_handle.rb +++ b/lib/quickbooks/service_handle.rb @@ -10,11 +10,11 @@ end def access_token - @access_token ||= OAuth::AccessToken.new($qb_oauth_consumer, @intuit_tok...
Correct a bug that prevented all requests I originally wrote ServiceHandle as part of a Rails application and then extracted it to this gem. I missed the change from a global to an argument here, making it impossible to make requests.
diff --git a/assignments/ruby/anagram/anagram_test.rb b/assignments/ruby/anagram/anagram_test.rb index abc1234..def5678 100644 --- a/assignments/ruby/anagram/anagram_test.rb +++ b/assignments/ruby/anagram/anagram_test.rb @@ -23,6 +23,12 @@ assert_equal ['abc', 'bac'], anagrams end + def test_does_not_confuse_...
Add test to the ruby:anagram test Catch a bug that one of the students came up with today.
diff --git a/SSPPullToRefresh.podspec b/SSPPullToRefresh.podspec index abc1234..def5678 100644 --- a/SSPPullToRefresh.podspec +++ b/SSPPullToRefresh.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'SSPPullToRefresh' - s.version = '0.1.9' + s.version = '0.1.10' s.summary ...
Update pod spec to 0.1.10
diff --git a/cookbooks/chef/attributes/default.rb b/cookbooks/chef/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/chef/attributes/default.rb +++ b/cookbooks/chef/attributes/default.rb @@ -5,4 +5,4 @@ default[:chef][:server][:version] = "12.13.0-1" # Set the default client version -default[:chef]...
Update chef client to 12.20.3
diff --git a/SetNeedsReadable.podspec b/SetNeedsReadable.podspec index abc1234..def5678 100644 --- a/SetNeedsReadable.podspec +++ b/SetNeedsReadable.podspec @@ -8,7 +8,7 @@ Pod::Spec.new do |s| s.name = 'SetNeedsReadable' - s.version = '2.0' + s.version = '2.1' s.summary ...
Update .podspec version to 2.1
diff --git a/Casks/little-flocker.rb b/Casks/little-flocker.rb index abc1234..def5678 100644 --- a/Casks/little-flocker.rb +++ b/Casks/little-flocker.rb @@ -1,6 +1,6 @@ cask 'little-flocker' do - version '0.99.93' - sha256 '3dd1daa8d94d8182ac6194e84d36f7cc70502e4c6db1b9a7e1508d484206f597' + version '0.99.95' + sha2...
Update to Little Flocker RC5 Update to Little Flocker RC5
diff --git a/Casks/one-password-3.rb b/Casks/one-password-3.rb index abc1234..def5678 100644 --- a/Casks/one-password-3.rb +++ b/Casks/one-password-3.rb @@ -0,0 +1,7 @@+class OnePassword3 < Cask + url 'https://d13itkw33a7sus.cloudfront.net/dist/1P/mac/1Password-3.8.21.zip' + homepage 'https://agilebits.com/onepasswor...
Add cask for 1Password 3
diff --git a/Casks/radiant-player.rb b/Casks/radiant-player.rb index abc1234..def5678 100644 --- a/Casks/radiant-player.rb +++ b/Casks/radiant-player.rb @@ -1,8 +1,8 @@ cask 'radiant-player' do - version '1.5.0' - sha256 '5740a8a4f6eebadb6b961f0510120bbd225e8c7c5b94f7a8da0f6710ee5f79d8' + version '1.6.2' + sha256 '...
Update Radiant Player to 1.6.2
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -11,3 +11,5 @@ config.redis = {url: "redis://#{host}:#{port}", namespace: namespace} end +Sidekiq::Logging.logger = Rails.logger +
Use Rails.logger as Sidekiq logger.
diff --git a/lib/cequel.rb b/lib/cequel.rb index abc1234..def5678 100644 --- a/lib/cequel.rb +++ b/lib/cequel.rb @@ -12,10 +12,12 @@ module Cequel def self.connect(configuration) + thrift_options = configuration[:thrift] || {} Keyspace.new( CassandraCQL::Database.new( configuration[:host] |...
Add thrift client options when setting up connection
diff --git a/week-5/nums-commas/my_solution.rb b/week-5/nums-commas/my_solution.rb index abc1234..def5678 100644 --- a/week-5/nums-commas/my_solution.rb +++ b/week-5/nums-commas/my_solution.rb @@ -8,17 +8,53 @@ # 0. Pseudocode -# What is the input? -# What is the output? (i.e. What should the code return?) +# What ...
Complete MVP for solo challenge
diff --git a/cookbooks/goget/recipes/goget.rb b/cookbooks/goget/recipes/goget.rb index abc1234..def5678 100644 --- a/cookbooks/goget/recipes/goget.rb +++ b/cookbooks/goget/recipes/goget.rb @@ -6,6 +6,7 @@ goget 'github.com/atotto/clipboard/cmd/gopaste' do binary_name 'gopaste' end -goget 'github.com/mdempsky/gocode...
Workaround: Use ikgo/gocode for Go 1.11 modules
diff --git a/Library/Homebrew/test/test_checksum.rb b/Library/Homebrew/test/test_checksum.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/test_checksum.rb +++ b/Library/Homebrew/test/test_checksum.rb @@ -7,16 +7,16 @@ end def test_equality - a = Checksum.new(:sha1, 'deadbeef'*5) - b = Checksum...
Use TEST_SHA1 constant in checksum tests
diff --git a/gimlet-model.gemspec b/gimlet-model.gemspec index abc1234..def5678 100644 --- a/gimlet-model.gemspec +++ b/gimlet-model.gemspec @@ -20,6 +20,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "rspec" spec.add_depend...
Add rspec as a development dependency
diff --git a/examples/show_experiences.rb b/examples/show_experiences.rb index abc1234..def5678 100644 --- a/examples/show_experiences.rb +++ b/examples/show_experiences.rb @@ -1,8 +1,56 @@+require 'csv' + module ShowExperiences + CREATE_CSV = true + + # Show information about each experience. Also creates a CSV...
Add more detail to experience example, including csv export
diff --git a/ruby/rna-transcription/complement.rb b/ruby/rna-transcription/complement.rb index abc1234..def5678 100644 --- a/ruby/rna-transcription/complement.rb +++ b/ruby/rna-transcription/complement.rb @@ -1,24 +1,20 @@ class Complement - def self.of_dna(dna_str) - dna_str.gsub(/[#{dna_to_rna.keys.join}]/, dna...
Change methods to class constants
diff --git a/app/models/floating_ip.rb b/app/models/floating_ip.rb index abc1234..def5678 100644 --- a/app/models/floating_ip.rb +++ b/app/models/floating_ip.rb @@ -12,13 +12,10 @@ belongs_to :cloud_network belongs_to :network_port belongs_to :network_router + alias_attribute :name, :address def self.avai...
Use alias_attribute instead of using a method for name
diff --git a/app/models/councillor.rb b/app/models/councillor.rb index abc1234..def5678 100644 --- a/app/models/councillor.rb +++ b/app/models/councillor.rb @@ -3,5 +3,6 @@ has_and_belongs_to_many :committees has_many :motions + has_many :councillor_vote has_many :items, as: :origin end
Fix Councillor Vote Not Deleting Because a councillor association for has_many which is not been set up.
diff --git a/app/models/repository.rb b/app/models/repository.rb index abc1234..def5678 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -20,10 +20,10 @@ def next_pending sha = nil query = commits.pending.order("commited_at ASC") - if sha && commit = Commit.find_by_sha(sha) - que...
Improve next pending commit method
diff --git a/app/models/spree/user.rb b/app/models/spree/user.rb index abc1234..def5678 100644 --- a/app/models/spree/user.rb +++ b/app/models/spree/user.rb @@ -0,0 +1,80 @@+module Spree + class User < ActiveRecord::Base + include Core::UserBanners + + devise :database_authenticatable, :token_authenticatable, :r...
Add User class from spree_auth_devise as is
diff --git a/publify_core/app/models/trackback.rb b/publify_core/app/models/trackback.rb index abc1234..def5678 100644 --- a/publify_core/app/models/trackback.rb +++ b/publify_core/app/models/trackback.rb @@ -4,14 +4,6 @@ class Trackback < Feedback content_fields :excerpt validates :title, :excerpt, :url, presenc...
Remove superfluous initializer from Trackback No new Trackback objects should be stored in the database, and also no tests fail when this code is removed.
diff --git a/lib/samuel.rb b/lib/samuel.rb index abc1234..def5678 100644 --- a/lib/samuel.rb +++ b/lib/samuel.rb @@ -15,6 +15,7 @@ end def logger + @logger = nil if !defined?(@logger) return @logger if !@logger.nil? if defined?(RAILS_DEFAULT_LOGGER)
Fix "instance variable @logger not initialized" warning
diff --git a/Casks/acquia-dev-desktop.rb b/Casks/acquia-dev-desktop.rb index abc1234..def5678 100644 --- a/Casks/acquia-dev-desktop.rb +++ b/Casks/acquia-dev-desktop.rb @@ -0,0 +1,19 @@+cask :v1 => 'acquia-dev-desktop' do + version '2-2015-04-03' + sha256 '958d23385827695f3bc79d3d5b78995fdb9c5dfa5528d2b03efe321aa8fb0...
Add Acquia Dev Desktop 2. Acquia Dev Desktop 2 is a free app that allows you to run and develop Drupal sites locally on your computer and optionally hos them using Acquia Cloud. Use Acquia Dev Desktop to evaluate Drupal, add and test other Drupak modules, and develop sites while on a plane or away from an internet con...
diff --git a/spec/features/deleting_files_spec.rb b/spec/features/deleting_files_spec.rb index abc1234..def5678 100644 --- a/spec/features/deleting_files_spec.rb +++ b/spec/features/deleting_files_spec.rb @@ -9,6 +9,5 @@ instance.store!(image) end - it 'deletes the image when assigned a `nil` value' do - end...
Mark unimplemented spec as pending
diff --git a/lib/gir_ffi-gnome_keyring/found.rb b/lib/gir_ffi-gnome_keyring/found.rb index abc1234..def5678 100644 --- a/lib/gir_ffi-gnome_keyring/found.rb +++ b/lib/gir_ffi-gnome_keyring/found.rb @@ -4,6 +4,9 @@ load_class :Found class Found + remove_method :attributes + remove_method :attributes= + ...
Remove old methods before redefining
diff --git a/lib/miq_tools_services/bugzilla.rb b/lib/miq_tools_services/bugzilla.rb index abc1234..def5678 100644 --- a/lib/miq_tools_services/bugzilla.rb +++ b/lib/miq_tools_services/bugzilla.rb @@ -14,7 +14,11 @@ def service @service ||= begin require 'active_bugzilla' - bz = ActiveBugzill...
Support RailsConfig objects for credentials
diff --git a/spec/magic-equals-multi-via-query.rb b/spec/magic-equals-multi-via-query.rb index abc1234..def5678 100644 --- a/spec/magic-equals-multi-via-query.rb +++ b/spec/magic-equals-multi-via-query.rb @@ -0,0 +1,18 @@+require_relative 'spec_helper' +require 'uri' + +describe 'Noodle' do + it "should allow finding ...
Add query test (/nodes/_/?blah blah)
diff --git a/spec/providers/service_runit_spec.rb b/spec/providers/service_runit_spec.rb index abc1234..def5678 100644 --- a/spec/providers/service_runit_spec.rb +++ b/spec/providers/service_runit_spec.rb @@ -2,9 +2,11 @@ describe 'service_runit provider' do let(:runner) do - ChefSpec::Runner.new(step_into: ['g...
Refactor graphite_service_runit provider spec to use fauxhai data.
diff --git a/lib/str_sanitizer/html_entities.rb b/lib/str_sanitizer/html_entities.rb index abc1234..def5678 100644 --- a/lib/str_sanitizer/html_entities.rb +++ b/lib/str_sanitizer/html_entities.rb @@ -0,0 +1,38 @@+require 'htmlentities' + +class StrSanitizer + module HtmlEntities + + # Instantiate htmlentities clas...
Add HtmlEntities module which encodes and decodes HTML entities
diff --git a/lib/travis/addons/handlers/base.rb b/lib/travis/addons/handlers/base.rb index abc1234..def5678 100644 --- a/lib/travis/addons/handlers/base.rb +++ b/lib/travis/addons/handlers/base.rb @@ -19,7 +19,10 @@ def data @data ||= Serializer::Generic.const_get(object_type.camelize).new(object).da...
Decrypt payload for all event handlers When handing off notification payload to travis-tasks, ensure that the payload is decrypted. This caused https://github.com/travis-ci/travis-ci/issues/2813 (Notice that encrypted 'channels' were fine, because it was passed on separately by the IRC event handler.)
diff --git a/lib/omniauth/strategies/wordpress_hosted.rb b/lib/omniauth/strategies/wordpress_hosted.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/wordpress_hosted.rb +++ b/lib/omniauth/strategies/wordpress_hosted.rb @@ -32,7 +32,7 @@ end def raw_info - @raw_info ||= access_token.g...
Update endpoints used by WP OAuth Server 3.1.3
diff --git a/lib/piggybak_braintree/payment_decorator.rb b/lib/piggybak_braintree/payment_decorator.rb index abc1234..def5678 100644 --- a/lib/piggybak_braintree/payment_decorator.rb +++ b/lib/piggybak_braintree/payment_decorator.rb @@ -7,7 +7,7 @@ validates :payment_method_nonce, presence: true - [:mont...
Remove validations for number and cvv if nonce presence
diff --git a/lib/pronto/rake_task/travis_pull_request.rb b/lib/pronto/rake_task/travis_pull_request.rb index abc1234..def5678 100644 --- a/lib/pronto/rake_task/travis_pull_request.rb +++ b/lib/pronto/rake_task/travis_pull_request.rb @@ -31,19 +31,19 @@ end def run_task(verbose) - return if pull_re...
Rename method to avoid name collision
diff --git a/test/fixtures/cookbooks/jenkins_server_wrapper/attributes/default.rb b/test/fixtures/cookbooks/jenkins_server_wrapper/attributes/default.rb index abc1234..def5678 100644 --- a/test/fixtures/cookbooks/jenkins_server_wrapper/attributes/default.rb +++ b/test/fixtures/cookbooks/jenkins_server_wrapper/attribute...
Switch to openjdk since Oracle jdk artifacts have been removed Signed-off-by: Richard Baker <43588b937db6c0a9556777fbd43852676d68c9bf@digital.cabinet-office.gov.uk>
diff --git a/app/metrics/beeminder/compose_goals.rb b/app/metrics/beeminder/compose_goals.rb index abc1234..def5678 100644 --- a/app/metrics/beeminder/compose_goals.rb +++ b/app/metrics/beeminder/compose_goals.rb @@ -7,7 +7,7 @@ Array(options[slug_key]).flat_map do |slug, factor| next [] if factor.blank? ...
Use utc timestamp in beeminder compose metric
diff --git a/spec/lib/github-backup/backup_spec.rb b/spec/lib/github-backup/backup_spec.rb index abc1234..def5678 100644 --- a/spec/lib/github-backup/backup_spec.rb +++ b/spec/lib/github-backup/backup_spec.rb @@ -0,0 +1,86 @@+require File.expand_path('../../../spec_helper', __FILE__) + +describe GithubBackup::Backup do...
Add basic specs for Backup Covers most of the initialization of a Backup object. TODO: Define GithubBackup::Config#== Set default backup directory to Dir.pwd
diff --git a/spec/plugins/last_modified_at_spec.rb b/spec/plugins/last_modified_at_spec.rb index abc1234..def5678 100644 --- a/spec/plugins/last_modified_at_spec.rb +++ b/spec/plugins/last_modified_at_spec.rb @@ -9,7 +9,7 @@ it "has last revised date" do setup("1984-03-06-last-modified-at.md", "last_modifi...
Set fixture date to 04, not 03
diff --git a/spec/support/test/resource_service.rb b/spec/support/test/resource_service.rb index abc1234..def5678 100644 --- a/spec/support/test/resource_service.rb +++ b/spec/support/test/resource_service.rb @@ -0,0 +1,14 @@+require ::File.expand_path('../resource.pb', __FILE__) + +module Test + class ResourceService...
Add back in ResourceService implementation for spec
diff --git a/lib/chef/provider/template_finder.rb b/lib/chef/provider/template_finder.rb index abc1234..def5678 100644 --- a/lib/chef/provider/template_finder.rb +++ b/lib/chef/provider/template_finder.rb @@ -29,15 +29,31 @@ def find(template_name, options = {}) if options[:local] - return opt...
[CHEF-3249] Replace ternary operators with more explicit conditionals; split them out to separate methods for ease of maintenance.
diff --git a/lib/electric_sheep/transports/scp.rb b/lib/electric_sheep/transports/scp.rb index abc1234..def5678 100644 --- a/lib/electric_sheep/transports/scp.rb +++ b/lib/electric_sheep/transports/scp.rb @@ -1,6 +1,21 @@ module ElectricSheep module Transports - module SCP + class SCP + include ElectricSh...
Add a skeleton for SCP transport.
diff --git a/app/controllers/spree/chimpy/subscribers_controller.rb b/app/controllers/spree/chimpy/subscribers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/chimpy/subscribers_controller.rb +++ b/app/controllers/spree/chimpy/subscribers_controller.rb @@ -11,7 +11,8 @@ flash[:error] = Spr...
Use root_url as referer if missing Otherwise, respond_to will try to generate a URL for the resource and fail (no route for it)
diff --git a/sprout-osx-apps/attributes/hipchat.rb b/sprout-osx-apps/attributes/hipchat.rb index abc1234..def5678 100644 --- a/sprout-osx-apps/attributes/hipchat.rb +++ b/sprout-osx-apps/attributes/hipchat.rb @@ -1,4 +1,4 @@-default['sprout']['hipchat']['url'] = "http://downloads.hipchat.com.s3.amazonaws.com/osx/HipCha...
Update HipChat recipe to install newer version
diff --git a/app/serializers/endpoint_serializer.rb b/app/serializers/endpoint_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/endpoint_serializer.rb +++ b/app/serializers/endpoint_serializer.rb @@ -1,3 +1,4 @@ class EndpointSerializer < ActiveModel::Serializer attributes :name, :public, :certifica...
Add district association to endpoint serializer
diff --git a/app/controllers/articles_controller.rb b/app/controllers/articles_controller.rb index abc1234..def5678 100644 --- a/app/controllers/articles_controller.rb +++ b/app/controllers/articles_controller.rb @@ -7,11 +7,6 @@ return redirect_to(home_path) end - if @article_category.nil? - # No ...
Remove stray article catgory check
diff --git a/app/controllers/feedback_controller.rb b/app/controllers/feedback_controller.rb index abc1234..def5678 100644 --- a/app/controllers/feedback_controller.rb +++ b/app/controllers/feedback_controller.rb @@ -35,7 +35,8 @@ comment: { value: feedback_comment }, - submitter_id: client.c...
Tag tickets created from feedback form with `online_booking` So the feedback can easily be identified in Zendesk.
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -3,6 +3,7 @@ class SessionsController < Devise::OmniauthCallbacksController skip_before_action :verif...
Allow current users from banned countries
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -4,6 +4,9 @@ get '/users/:id' do + if session[:user_id] != params[:id].to_i + halt 401, "Not authorized to v...
Add 401 stat page to deny users access to other user's profiles.
diff --git a/lib/shard_handler/thread_registry.rb b/lib/shard_handler/thread_registry.rb index abc1234..def5678 100644 --- a/lib/shard_handler/thread_registry.rb +++ b/lib/shard_handler/thread_registry.rb @@ -7,6 +7,7 @@ # the current thread and not on process or other threads. # # @see ActiveSupport::PerThread...
Mark ThreadRegistry as a private api
diff --git a/config/unicorn/production.rb b/config/unicorn/production.rb index abc1234..def5678 100644 --- a/config/unicorn/production.rb +++ b/config/unicorn/production.rb @@ -7,8 +7,6 @@ timeout 180 listen "127.0.0.1:8080" -# Spawn unicorn master worker for user apps (group: apps) -user 'apps', 'apps' # Fill p...
Remove user setting for Unicorn
diff --git a/lib/tritium/parser/macros/asset.2.rb b/lib/tritium/parser/macros/asset.2.rb index abc1234..def5678 100644 --- a/lib/tritium/parser/macros/asset.2.rb +++ b/lib/tritium/parser/macros/asset.2.rb @@ -3,23 +3,24 @@ ->(args) do file_name, type = args location = "" - puts "DEPRECATION WARNING: Don't use as...
Use the log() function in tritium for the warnings
diff --git a/lib/underskog/response/parse_json.rb b/lib/underskog/response/parse_json.rb index abc1234..def5678 100644 --- a/lib/underskog/response/parse_json.rb +++ b/lib/underskog/response/parse_json.rb @@ -14,7 +14,9 @@ when 'false' false else - MultiJson.load(body) + ...
Use data field in json response as data
diff --git a/app/interactors/api/compound_events.rb b/app/interactors/api/compound_events.rb index abc1234..def5678 100644 --- a/app/interactors/api/compound_events.rb +++ b/app/interactors/api/compound_events.rb @@ -34,14 +34,17 @@ end def courses - course_ids = events.distinct.select(:course_id)...
Remove unnecessary DISTINCT from compound queries
diff --git a/app/presenters/respondent_presenter.rb b/app/presenters/respondent_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/respondent_presenter.rb +++ b/app/presenters/respondent_presenter.rb @@ -10,9 +10,10 @@ end def acas_early_conciliation_certificate_number - if target.acas_early_conc...
Fix edge case on review page Manually navigating to the review page before filling in respondent details causes all I18n values for no acas number reason. This fixes that.
diff --git a/chef-repo/site-cookbooks/sysbench/recipes/configure.rb b/chef-repo/site-cookbooks/sysbench/recipes/configure.rb index abc1234..def5678 100644 --- a/chef-repo/site-cookbooks/sysbench/recipes/configure.rb +++ b/chef-repo/site-cookbooks/sysbench/recipes/configure.rb @@ -13,6 +13,6 @@ cli_options: node['...
Fix CPU model name detection
diff --git a/core/string/shared/to_sym.rb b/core/string/shared/to_sym.rb index abc1234..def5678 100644 --- a/core/string/shared/to_sym.rb +++ b/core/string/shared/to_sym.rb @@ -7,6 +7,26 @@ "abc=".send(@method).should == :abc= end + it "special cases !@ and ~@" do + "!@".to_sym.should == :"!" + "~@".to_...
Add specs for special operator's symbol values
diff --git a/MetaData/HTMLDOMKit.podspec b/MetaData/HTMLDOMKit.podspec index abc1234..def5678 100644 --- a/MetaData/HTMLDOMKit.podspec +++ b/MetaData/HTMLDOMKit.podspec @@ -2,7 +2,6 @@ s.name = "HTMLDOMKit" s.version = "0.0.1" s.summary = "An HTML DOM generation tool written in Swi...
Revert "reverted pod spec change" This reverts commit 03640ec187f3fefa188c0e83cd30529b58576319.
diff --git a/db/migrate/20190626175626_add_group_creation_level_to_namespaces.rb b/db/migrate/20190626175626_add_group_creation_level_to_namespaces.rb index abc1234..def5678 100644 --- a/db/migrate/20190626175626_add_group_creation_level_to_namespaces.rb +++ b/db/migrate/20190626175626_add_group_creation_level_to_names...
Add a subgroup_creation_level column to the namespaces table
diff --git a/app/controllers/answers_controller.rb b/app/controllers/answers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/answers_controller.rb +++ b/app/controllers/answers_controller.rb @@ -1,6 +1,7 @@ class AnswersController < ApplicationController before_filter :authenticate_user! before_...
Add accept action to AnswersController
diff --git a/app/controllers/kaizens_controller.rb b/app/controllers/kaizens_controller.rb index abc1234..def5678 100644 --- a/app/controllers/kaizens_controller.rb +++ b/app/controllers/kaizens_controller.rb @@ -20,8 +20,11 @@ else @kaizen.user = user end - @kaizen.save - redirect_to @kaizen + ...
Add logic to render edit on Kaizen save failure
diff --git a/app/controllers/schools_controller.rb b/app/controllers/schools_controller.rb index abc1234..def5678 100644 --- a/app/controllers/schools_controller.rb +++ b/app/controllers/schools_controller.rb @@ -27,14 +27,15 @@ end def districts - results = School.search_schools("District "); + districts_num_li...
Change districts method to create a json with calculated totals per district for amoutn owed and enrollment - uses methods from School model.
diff --git a/app/controllers/surveys_controller.rb b/app/controllers/surveys_controller.rb index abc1234..def5678 100644 --- a/app/controllers/surveys_controller.rb +++ b/app/controllers/surveys_controller.rb @@ -21,7 +21,7 @@ redirect '/questions/new' end else - redirect '/?errors=unable_to_create_sur...
Fix bug where new survey title doesn't meet min. 5 char validation
diff --git a/app/views/api/v1/places/show.json.rabl b/app/views/api/v1/places/show.json.rabl index abc1234..def5678 100644 --- a/app/views/api/v1/places/show.json.rabl +++ b/app/views/api/v1/places/show.json.rabl @@ -2,5 +2,6 @@ child :ownerships do attributes :user_id, :name + attributes :contact_by_phone, :cont...
Add new flags to API response.
diff --git a/add_all.rb b/add_all.rb index abc1234..def5678 100644 --- a/add_all.rb +++ b/add_all.rb @@ -5,6 +5,7 @@ sources = JSON.parse(File.read(File.join(File.dirname($0), 'ubuntu.json'))) successes = sources.select do |src| + puts "-------------------\nAdding #{src.inspect}\n" if src['key_url'] system(...
Add dividers for prettier output
diff --git a/app/helpers/bootstrap_flash_helper.rb b/app/helpers/bootstrap_flash_helper.rb index abc1234..def5678 100644 --- a/app/helpers/bootstrap_flash_helper.rb +++ b/app/helpers/bootstrap_flash_helper.rb @@ -5,7 +5,7 @@ # includes ................................................................... # constants...
Tweak bootstrap flash helper a bit to use danger instead of error alert class
diff --git a/spec/github-pages-dependencies_spec.rb b/spec/github-pages-dependencies_spec.rb index abc1234..def5678 100644 --- a/spec/github-pages-dependencies_spec.rb +++ b/spec/github-pages-dependencies_spec.rb @@ -3,7 +3,7 @@ describe(GitHubPages::Dependencies) do CORE_DEPENDENCIES = %w( jekyll kramdown liqu...
Add 'listen' to core dependencies.
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -4,4 +4,4 @@ license "Apache 2.0" description "A cookbook used to set up a Flume agent." long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) -version "1.0" +v...
Increase to 1.1 for next release development
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -21,6 +21,9 @@ supports 'redhat' supports 'smartos' supports 'scientific' +supports 'suse' +supports 'opensuse' +supports 'opensuseleap' supports 'ubuntu' supports 'windows'
Add suse to the readme Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/suby/downloader/addict7ed_spec.rb b/spec/suby/downloader/addict7ed_spec.rb index abc1234..def5678 100644 --- a/spec/suby/downloader/addict7ed_spec.rb +++ b/spec/suby/downloader/addict7ed_spec.rb @@ -1,12 +1,12 @@ require_relative '../../spec_helper' describe Suby::Downloader::Addic7ed do - file = ...
Use another example for addic7ed
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -1,10 +1,10 @@ class CommentsController < ApplicationController expose(:campaign) expose(:game) - ...
Use subject in comments controller
diff --git a/lib/brexit_checker/action.rb b/lib/brexit_checker/action.rb index abc1234..def5678 100644 --- a/lib/brexit_checker/action.rb +++ b/lib/brexit_checker/action.rb @@ -1,3 +1,5 @@+require "addressable/uri" + class BrexitChecker::Action include ActiveModel::Validations @@ -8,12 +10,14 @@ validates_prese...
Send path instead of full URL in ecommerce tracking This is so performance analysts can more easily compare data across different reports (as standard GOV.UK tracking/reports uses paths rather than full URLs)
diff --git a/app/controllers/products_controller.rb b/app/controllers/products_controller.rb index abc1234..def5678 100644 --- a/app/controllers/products_controller.rb +++ b/app/controllers/products_controller.rb @@ -39,6 +39,6 @@ private def product_params - params.require(:product).permit! + params.requi...
Fix params.permit for Products Controller
diff --git a/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_rule3.rb b/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_rule3.rb index abc1234..def5678 100644 --- a/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_rule3.rb +++ b/lib/sastrawi/morphology/disambiguator/disambiguator_prefix_...
Add implementation of third rule of disambiguator prefix
diff --git a/app/models/virtual_machine_instance.rb b/app/models/virtual_machine_instance.rb index abc1234..def5678 100644 --- a/app/models/virtual_machine_instance.rb +++ b/app/models/virtual_machine_instance.rb @@ -1,8 +1,8 @@ class VirtualMachineInstance < ActiveRecord::Base belongs_to :benchmark_execution val...
Fix missing dependent destroy behavior that prevented metric observations from deletion
diff --git a/app/presenters/field/file_presenter.rb b/app/presenters/field/file_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/field/file_presenter.rb +++ b/app/presenters/field/file_presenter.rb @@ -6,7 +6,7 @@ def input(form, method, options={}) form.form_group(method, :label => { :text => l...
Maintain uploaded file when validation fails
diff --git a/spec-tests/spec/localhost/tor_spec.rb b/spec-tests/spec/localhost/tor_spec.rb index abc1234..def5678 100644 --- a/spec-tests/spec/localhost/tor_spec.rb +++ b/spec-tests/spec/localhost/tor_spec.rb @@ -6,5 +6,10 @@ describe file('/etc/tor/torrc') do it { should be_file } - its(:content) { should match ...
Improve tor spect test slightly
diff --git a/spec/features/user_management_spec.rb b/spec/features/user_management_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_management_spec.rb +++ b/spec/features/user_management_spec.rb @@ -0,0 +1,94 @@+require 'spec_helper' + +RSpec.feature "User management" do + let(:campus) { create(:campus) ...
Add User Management feature spec A first pass at a feature spec for user management tasks.