Datasets:
seniruk
/
git-diff_to_commit_msg_large

Dataset card Data Studio Files
xet
 Community
diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/models/entity_descriptor_spec.rb b/spec/models/entity_descriptor_spec.rb index abc1234..def5678 100644 --- a/spec/models/entity_descriptor_spec.rb +++ b/spec/models/entity_descriptor_spec.rb @@ -5,4 +5,11 @@ it { is_expected.to validate_presence :entities_descriptor } it { is_expected.to valida...
Enhance test cases for EntityDescriptor
diff --git a/spec/support/matchers/be_parsed_as.rb b/spec/support/matchers/be_parsed_as.rb index abc1234..def5678 100644 --- a/spec/support/matchers/be_parsed_as.rb +++ b/spec/support/matchers/be_parsed_as.rb @@ -6,6 +6,7 @@ end failure_message do |actual| - %Q{expected "#{actual}" to be parsed as #{expected}...
Add 'got instead' message to custom matcher
diff --git a/redis-semaphore.gemspec b/redis-semaphore.gemspec index abc1234..def5678 100644 --- a/redis-semaphore.gemspec +++ b/redis-semaphore.gemspec @@ -15,7 +15,6 @@ s.add_dependency 'redis' s.add_development_dependency 'rake' s.add_development_dependency 'rspec', '>= 2.14' - s.add_development_dependency ...
Remove `pry` as development dependency
diff --git a/spec/ruby/core/file/initialize_spec.rb b/spec/ruby/core/file/initialize_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/core/file/initialize_spec.rb +++ b/spec/ruby/core/file/initialize_spec.rb @@ -2,6 +2,14 @@ describe "File#initialize" do it "needs to be reviewed for spec completeness" +end + ...
Add spec for ignoring encoding options in 1.8
diff --git a/active_importer.gemspec b/active_importer.gemspec index abc1234..def5678 100644 --- a/active_importer.gemspec +++ b/active_importer.gemspec @@ -8,8 +8,8 @@ spec.version = ActiveImporter::VERSION spec.authors = ["Ernesto Garcia"] spec.email = ["gnapse@gmail.com"] - spec.descript...
Add sensible summary and description strings to gemspec
diff --git a/lib/express_templates/components/forms/basic_fields.rb b/lib/express_templates/components/forms/basic_fields.rb index abc1234..def5678 100644 --- a/lib/express_templates/components/forms/basic_fields.rb +++ b/lib/express_templates/components/forms/basic_fields.rb @@ -3,7 +3,7 @@ module Forms mod...
Make basic file field component
diff --git a/spec/epr_spec_helper.rb b/spec/epr_spec_helper.rb index abc1234..def5678 100644 --- a/spec/epr_spec_helper.rb +++ b/spec/epr_spec_helper.rb @@ -30,7 +30,7 @@ # # @note This assumes the driver is on a page with the avatar dropdown menu def self.logout - avatar_icon = driver.find_element(:css, '.h...
Fix CSS selector for logging out in tests
diff --git a/spec/features/access_control_spec.rb b/spec/features/access_control_spec.rb index abc1234..def5678 100644 --- a/spec/features/access_control_spec.rb +++ b/spec/features/access_control_spec.rb @@ -0,0 +1,61 @@+require 'spec_helper' + +RSpec.feature "Access control", type: :feature do + def log_in_as_editor...
Add failing test for access control
diff --git a/spec/item_merge_spec.rb b/spec/item_merge_spec.rb index abc1234..def5678 100644 --- a/spec/item_merge_spec.rb +++ b/spec/item_merge_spec.rb @@ -0,0 +1,29 @@+require 'spec_helper' + +class Poloxy::Config + attr_accessor :deliver +end + +klass = 'Poloxy::ItemMerge::PerItem' +describe klass do + before :con...
Add test for P::ItemMerge factory
diff --git a/spec/features/stats_features_spec.rb b/spec/features/stats_features_spec.rb index abc1234..def5678 100644 --- a/spec/features/stats_features_spec.rb +++ b/spec/features/stats_features_spec.rb @@ -0,0 +1,58 @@+require 'spec_helper' + +describe "Stats" do + before :all do + load "#{Rails.root}/db/seeds.r...
Update stats feature specs to run against sensu api v0.10.2
diff --git a/spec/steps/step_spec.rb b/spec/steps/step_spec.rb index abc1234..def5678 100644 --- a/spec/steps/step_spec.rb +++ b/spec/steps/step_spec.rb @@ -1,16 +1,8 @@ require "rails_helper" describe Step do - class TestQuestionA < Question - self.model_attribute = :first_name - end - - class TestQuestionB <...
Test coverage for invalid fields not updating the model
diff --git a/lib/polymer-rails/railtie.rb b/lib/polymer-rails/railtie.rb index abc1234..def5678 100644 --- a/lib/polymer-rails/railtie.rb +++ b/lib/polymer-rails/railtie.rb @@ -3,7 +3,7 @@ class Railtie < ::Rails::Railtie initializer :polymer_html_import do helpers = %q{ include AssetTagHelper } - ...
Fix html_import_tag helper in Rails 3
diff --git a/lib/projector/projections.rb b/lib/projector/projections.rb index abc1234..def5678 100644 --- a/lib/projector/projections.rb +++ b/lib/projector/projections.rb @@ -13,12 +13,12 @@ @json = get_json path @json.each do |_regex, options| - @commands.push options['type'] if options.key? 't...
Switch to parentheses for some things
diff --git a/lib/puppet/type/x509_cert.rb b/lib/puppet/type/x509_cert.rb index abc1234..def5678 100644 --- a/lib/puppet/type/x509_cert.rb +++ b/lib/puppet/type/x509_cert.rb @@ -39,6 +39,7 @@ newparam(:days) do newvalues(/\d+/) + defaultto(3650) end newparam(:owner) do
Add default value for days
diff --git a/fluent-plugin-in-kinesis.gemspec b/fluent-plugin-in-kinesis.gemspec index abc1234..def5678 100644 --- a/fluent-plugin-in-kinesis.gemspec +++ b/fluent-plugin-in-kinesis.gemspec @@ -12,7 +12,9 @@ spec.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } spec.require_paths = ["...
Add missing dependencies and specify versions
diff --git a/app/business_processes/enrollment_event_client.rb b/app/business_processes/enrollment_event_client.rb index abc1234..def5678 100644 --- a/app/business_processes/enrollment_event_client.rb +++ b/app/business_processes/enrollment_event_client.rb @@ -5,10 +5,10 @@ def initialize @stack = Middleware:...
Change chain names to match updated handler names
diff --git a/app/controllers/fancyengine/webhook_controller.rb b/app/controllers/fancyengine/webhook_controller.rb index abc1234..def5678 100644 --- a/app/controllers/fancyengine/webhook_controller.rb +++ b/app/controllers/fancyengine/webhook_controller.rb @@ -10,6 +10,9 @@ head :bad_request and return e...
Add comment explaining the need to iterate through the request classes in the webhook controller.
diff --git a/lib/sql_condition_builder.rb b/lib/sql_condition_builder.rb index abc1234..def5678 100644 --- a/lib/sql_condition_builder.rb +++ b/lib/sql_condition_builder.rb @@ -3,7 +3,7 @@ MINOR = 1 TINY = 0 VERSION = "#{MAJOR}.#{MINOR}.#{TINY}" - + def initialize @strings = [] @bind_variables =...
Use a descendant AR class to get around errors in rails 2.3.5
diff --git a/lib/sslyze/x509/extension.rb b/lib/sslyze/x509/extension.rb index abc1234..def5678 100644 --- a/lib/sslyze/x509/extension.rb +++ b/lib/sslyze/x509/extension.rb @@ -1,3 +1,5 @@+require 'delegate' + module SSLyze module X509 # @@ -5,64 +7,7 @@ # # @see http://www.rubydoc.info/stdlib/openssl...
Use SimpleDelegator for the SSLyze::X509::Extension base class.
diff --git a/lib/text/simon_similarity.rb b/lib/text/simon_similarity.rb index abc1234..def5678 100644 --- a/lib/text/simon_similarity.rb +++ b/lib/text/simon_similarity.rb @@ -8,22 +8,23 @@ # Author: Wilker Lúcio <wilkerlucio@gmail.com> # +require "set" + module Text module SimonSimilarity def compare_stri...
Use a Set for simpler, more efficient lookups.
diff --git a/spec/lib/hamster/hash/new_spec.rb b/spec/lib/hamster/hash/new_spec.rb index abc1234..def5678 100644 --- a/spec/lib/hamster/hash/new_spec.rb +++ b/spec/lib/hamster/hash/new_spec.rb @@ -14,7 +14,7 @@ hash['snazzy?'].should == 'oh yeah' end - describe "from a subclass" do + context "from a ...
Use 'context' to describe test context in Hash.new spec
diff --git a/spec/nio/selectables/pipe_spec.rb b/spec/nio/selectables/pipe_spec.rb index abc1234..def5678 100644 --- a/spec/nio/selectables/pipe_spec.rb +++ b/spec/nio/selectables/pipe_spec.rb @@ -18,8 +18,13 @@ let :unwritable_subject do reader, pipe = IO.pipe + #HACK: On OS X 10.8, this str must be larger...
Fix the setup of unwritable_subject in tests on OS X 10.8
diff --git a/lib/action_mailbox/mail_ext/addresses.rb b/lib/action_mailbox/mail_ext/addresses.rb index abc1234..def5678 100644 --- a/lib/action_mailbox/mail_ext/addresses.rb +++ b/lib/action_mailbox/mail_ext/addresses.rb @@ -1,26 +1,21 @@ class Mail::Message def from_address - Mail::Address.new from.first + he...
Use the address lists that have already been supplied to ensure we get the names as well
diff --git a/lib/ci_in_a_can/cli/structure_builder.rb b/lib/ci_in_a_can/cli/structure_builder.rb index abc1234..def5678 100644 --- a/lib/ci_in_a_can/cli/structure_builder.rb +++ b/lib/ci_in_a_can/cli/structure_builder.rb @@ -11,14 +11,24 @@ def create directories_to_create = [@root, "#{@root}/jobs", "#{@...
Break out file operations to single methods.
diff --git a/lib/link_to_active_state/view_helpers.rb b/lib/link_to_active_state/view_helpers.rb index abc1234..def5678 100644 --- a/lib/link_to_active_state/view_helpers.rb +++ b/lib/link_to_active_state/view_helpers.rb @@ -1,8 +1,6 @@ module LinkToActiveState module ViewHelpers - alias_method :rails_link_to, :l...
Use alias_method_chain for more standard override, and support arrays for :active_on
diff --git a/lib/mechanize/robots_disallowed_error.rb b/lib/mechanize/robots_disallowed_error.rb index abc1234..def5678 100644 --- a/lib/mechanize/robots_disallowed_error.rb +++ b/lib/mechanize/robots_disallowed_error.rb @@ -22,7 +22,7 @@ end def to_s - "Access disallowed by robots.txt: #{uri}" + "...
Use url instead of uri.
diff --git a/lib/pronto/formatter/github_formatter.rb b/lib/pronto/formatter/github_formatter.rb index abc1234..def5678 100644 --- a/lib/pronto/formatter/github_formatter.rb +++ b/lib/pronto/formatter/github_formatter.rb @@ -13,8 +13,6 @@ message.path, ...
Remove output message in GitHub formatter
diff --git a/cookbooks/wt_cam/attributes/default.rb b/cookbooks/wt_cam/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/wt_cam/attributes/default.rb +++ b/cookbooks/wt_cam/attributes/default.rb @@ -7,10 +7,10 @@ # default['wt_cam']['app_pool'] = "CAM" -default['wt_cam'][['cam']'download_url'] = ""...
Fix a typo in the wt_cam attributes file
diff --git a/rb/lib/selenium/webdriver/firefox/bridge.rb b/rb/lib/selenium/webdriver/firefox/bridge.rb index abc1234..def5678 100644 --- a/rb/lib/selenium/webdriver/firefox/bridge.rb +++ b/rb/lib/selenium/webdriver/firefox/bridge.rb @@ -6,11 +6,7 @@ class Bridge < Remote::Bridge def initialize(opts = {...
JariBakken: Add ability to override Firefox::Bridge's @launcher git-svn-id: aa1aa1384423cb28c2b1e29129bb3a91de1d9196@11117 07704840-8298-11de-bf8c-fd130f914ac9
diff --git a/app/models/concierge.rb b/app/models/concierge.rb index abc1234..def5678 100644 --- a/app/models/concierge.rb +++ b/app/models/concierge.rb @@ -16,10 +16,10 @@ # Returns a Conversation. def find_conversation # If we have an explicit conversation number try that first - conversation = @conversa...
Use params[] instead of params.fetch()
diff --git a/test/features/visit_all_page_test.rb b/test/features/visit_all_page_test.rb index abc1234..def5678 100644 --- a/test/features/visit_all_page_test.rb +++ b/test/features/visit_all_page_test.rb @@ -12,7 +12,8 @@ return if visited.include? current_path visited << current_path all('a').each do |a...
Fix some linked page aren't visited.
diff --git a/lib/futures_pipeline/client.rb b/lib/futures_pipeline/client.rb index abc1234..def5678 100644 --- a/lib/futures_pipeline/client.rb +++ b/lib/futures_pipeline/client.rb @@ -18,11 +18,12 @@ get("/api/v1/careers.json", options) end - # Get a single career using O*NET code. + # Get a single ...
Add documentation for error handling
diff --git a/config/initializers/kaminari_config.rb b/config/initializers/kaminari_config.rb index abc1234..def5678 100644 --- a/config/initializers/kaminari_config.rb +++ b/config/initializers/kaminari_config.rb @@ -1,5 +1,5 @@ Kaminari.configure do |config| - # config.default_per_page = 25 + # config.default_per_pa...
Change config to default of 10 listings per page
diff --git a/db/migrate/20120223093906_make_project_membership_polymorphic_on_subject.rb b/db/migrate/20120223093906_make_project_membership_polymorphic_on_subject.rb index abc1234..def5678 100644 --- a/db/migrate/20120223093906_make_project_membership_polymorphic_on_subject.rb +++ b/db/migrate/20120223093906_make_proj...
Resolve an issue where migrations would be canceled in production Rails.env Referencing a model inside a migration seems to confuse AR's mapping of tables and columns. Doing a raw execute resolves this.
diff --git a/spec/virtualbox_spec.rb b/spec/virtualbox_spec.rb index abc1234..def5678 100644 --- a/spec/virtualbox_spec.rb +++ b/spec/virtualbox_spec.rb @@ -4,7 +4,7 @@ it { should be_installed.by('homebrew_cask') } end -describe package('virtualbox'), :if => os[:family] == 'debian' do +describe package('virtualbo...
Fix package name on Debian.
diff --git a/lib/kosmos/packages/mechjeb.rb b/lib/kosmos/packages/mechjeb.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/mechjeb.rb +++ b/lib/kosmos/packages/mechjeb.rb @@ -0,0 +1,8 @@+class MechJeb < Kosmos::Package + title 'MechJeb' + url 'http://addons.cursecdn.com/files/2201/514/MechJeb2-2.2.1.0.zip' ...
Add a package for MechJeb.
diff --git a/db/migrate/20151031092713_change_conference_id_to_venue_id_in_rooms.rb b/db/migrate/20151031092713_change_conference_id_to_venue_id_in_rooms.rb index abc1234..def5678 100644 --- a/db/migrate/20151031092713_change_conference_id_to_venue_id_in_rooms.rb +++ b/db/migrate/20151031092713_change_conference_id_to_...
Fix sqlite behavior with not null constraint, so that it works both for sqlite and mysql
diff --git a/app/models/stance_choice.rb b/app/models/stance_choice.rb index abc1234..def5678 100644 --- a/app/models/stance_choice.rb +++ b/app/models/stance_choice.rb @@ -2,7 +2,7 @@ belongs_to :poll_option belongs_to :stance, dependent: :destroy has_one :poll, through: :poll_option - delegate :has_variable_...
Allow nil for has_variable_score for stances
diff --git a/event_girl_client.gemspec b/event_girl_client.gemspec index abc1234..def5678 100644 --- a/event_girl_client.gemspec +++ b/event_girl_client.gemspec @@ -7,7 +7,7 @@ spec.name = "event_girl_client" spec.version = EventGirlClient::VERSION spec.authors = ["Susanne Dewein", "Tam Eas...
Add Tam to author emails
diff --git a/lib/stackato-lkg/amazon/ec2.rb b/lib/stackato-lkg/amazon/ec2.rb index abc1234..def5678 100644 --- a/lib/stackato-lkg/amazon/ec2.rb +++ b/lib/stackato-lkg/amazon/ec2.rb @@ -0,0 +1,94 @@+require 'aws-sdk' +require 'contracts' +require_relative 'service' + +module StackatoLKG + module Amazon + class EC2 <...
Add interface to EC2 service
diff --git a/lib/tasks/data_generators.rake b/lib/tasks/data_generators.rake index abc1234..def5678 100644 --- a/lib/tasks/data_generators.rake +++ b/lib/tasks/data_generators.rake @@ -0,0 +1,16 @@+namespace :higgins do + namespace :test_data do + desc 'Create 10 test questions about the artifact of the day' + t...
Add a rake task to generate test question.
diff --git a/lib/flip_fab/features_by_name.rb b/lib/flip_fab/features_by_name.rb index abc1234..def5678 100644 --- a/lib/flip_fab/features_by_name.rb +++ b/lib/flip_fab/features_by_name.rb @@ -17,6 +17,6 @@ FeaturesByName.new Hash[@features_by_name.map{|name, feature| [name, (feature.with_context context)]}] ...
Add support for :each to FeaturesByName instances
diff --git a/lib/frecon/configuration_file.rb b/lib/frecon/configuration_file.rb index abc1234..def5678 100644 --- a/lib/frecon/configuration_file.rb +++ b/lib/frecon/configuration_file.rb @@ -19,8 +19,14 @@ end def read - data = open(@filename, "rb") do |io| - io.read + begin + data = open(@filename, ...
Return nil if ConfigurationFile is unreadable.
diff --git a/lib/gitlab/optimistic_locking.rb b/lib/gitlab/optimistic_locking.rb index abc1234..def5678 100644 --- a/lib/gitlab/optimistic_locking.rb +++ b/lib/gitlab/optimistic_locking.rb @@ -16,6 +16,6 @@ end end - alias :retry_optimistic_lock :retry_lock + alias_method :retry_optimistic_lock, :ret...
Fix Rubocop offense in OptimisticLocking module
diff --git a/attributes/passenger.rb b/attributes/passenger.rb index abc1234..def5678 100644 --- a/attributes/passenger.rb +++ b/attributes/passenger.rb @@ -7,4 +7,4 @@ # the default value of this attribute is set in the recipe. if set here using "which # ruby" it results in failed chef runs on Windows just by bein...
Change empty string to nil
diff --git a/lib/link_thumbnailer/response.rb b/lib/link_thumbnailer/response.rb index abc1234..def5678 100644 --- a/lib/link_thumbnailer/response.rb +++ b/lib/link_thumbnailer/response.rb @@ -18,8 +18,8 @@ def extract_charset content_type = @response['Content-Type'] || '' - m = content_type.match(/ch...
Fix a mistake in regular expression
diff --git a/lib/simple_captcha_audio/view.rb b/lib/simple_captcha_audio/view.rb index abc1234..def5678 100644 --- a/lib/simple_captcha_audio/view.rb +++ b/lib/simple_captcha_audio/view.rb @@ -4,9 +4,11 @@ alias_method :__simple_captcha_options__, :simple_captcha_options def simple_captcha_options(options = ...
Correct logic for the audio link generation and make audio ag visible
diff --git a/lib/tasks/gulp_assets_tasks.rake b/lib/tasks/gulp_assets_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/gulp_assets_tasks.rake +++ b/lib/tasks/gulp_assets_tasks.rake @@ -1,7 +1,7 @@ namespace :gulp_assets do desc "Compile Gulp Assets" task :precompile do - system('gulp precompile') + ...
Use sh in rake task instead of system
diff --git a/libraries/selinux_file_helper.rb b/libraries/selinux_file_helper.rb index abc1234..def5678 100644 --- a/libraries/selinux_file_helper.rb +++ b/libraries/selinux_file_helper.rb @@ -29,7 +29,7 @@ line.chomp # extracting version and module name - if (match = line.match(/^module\s+(\w...
Allow "-" and "_" for module names Without this change, it will force the module to be installed on every run which slows client runs considerably if you have multiple modules you add. This patch is the same as noted in this PR [1]. [1] https://github.com/chef-cookbooks/selinux/pull/61 Signed-off-by: Lance Albertso...
diff --git a/udp2sqs_server.gemspec b/udp2sqs_server.gemspec index abc1234..def5678 100644 --- a/udp2sqs_server.gemspec +++ b/udp2sqs_server.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = "udp2sqs_server" spec.version = Udp2sqsServer::VERSION - spec.authors = ["MalcyL, ...
Add me to Gemspec :blue_heart:
diff --git a/lib/email_assessor.rb b/lib/email_assessor.rb index abc1234..def5678 100644 --- a/lib/email_assessor.rb +++ b/lib/email_assessor.rb @@ -28,13 +28,13 @@ protected - def self.domain_in_file?(domain, filename) - return false unless filename.present? && File.exists?(filename) + def self.domain_in_fi...
Rename the variable filename to file_name for better semantics
diff --git a/motion/core_ext/ns_dictionary.rb b/motion/core_ext/ns_dictionary.rb index abc1234..def5678 100644 --- a/motion/core_ext/ns_dictionary.rb +++ b/motion/core_ext/ns_dictionary.rb @@ -7,5 +7,5 @@ end end - delegate :symbolize_keys, :to => :to_hash + delegate :symbolize_keys, :with_indifferent_acce...
Add more delegation to NSDictionary
diff --git a/assertions/published_gem.rb b/assertions/published_gem.rb index abc1234..def5678 100644 --- a/assertions/published_gem.rb +++ b/assertions/published_gem.rb @@ -12,7 +12,7 @@ def check begin - json = RestClient.get("http://rubygems.org/api/v1/versions/#{engine.project_name}.json") + ...
Use https to access rubygems.org
diff --git a/railties/lib/rails/tasks/yarn.rake b/railties/lib/rails/tasks/yarn.rake index abc1234..def5678 100644 --- a/railties/lib/rails/tasks/yarn.rake +++ b/railties/lib/rails/tasks/yarn.rake @@ -3,7 +3,7 @@ namespace :yarn do desc "Install all JavaScript dependencies as specified via Yarn" task :install do ...
Raise an error when lockfile diff is generated https://yarnpkg.com/en/docs/cli/install#toc-yarn-install-frozen-lockfile
diff --git a/lib/puppet-lint/plugins/absolute_template_path.rb b/lib/puppet-lint/plugins/absolute_template_path.rb index abc1234..def5678 100644 --- a/lib/puppet-lint/plugins/absolute_template_path.rb +++ b/lib/puppet-lint/plugins/absolute_template_path.rb @@ -1,27 +1,25 @@ PuppetLint.new_check(:absolute_template_path)...
Refactor the lint plugin to add short circuits These changes add more proactive filtering to avoid deeper nesting by testing for values and ending the iteration faster.
diff --git a/module_creation_helper.gemspec b/module_creation_helper.gemspec index abc1234..def5678 100644 --- a/module_creation_helper.gemspec +++ b/module_creation_helper.gemspec @@ -14,4 +14,6 @@ s.test_files = `git ls-files -- test/*`.split("\n") s.rdoc_options = %w(--line-numbers --inline-source -...
Add missing dependencies to gemspec
diff --git a/spec/middleware_spec.rb b/spec/middleware_spec.rb index abc1234..def5678 100644 --- a/spec/middleware_spec.rb +++ b/spec/middleware_spec.rb @@ -1,7 +1,6 @@-# -*- encoding: utf-8 -*- require 'spec_helper' -describe 'UTF8Cleaner::Middleware' do +describe UTF8Cleaner::Middleware do let :env do { ...
Clean up Middleware spec file a little bit
diff --git a/lib/status_checker.rb b/lib/status_checker.rb index abc1234..def5678 100644 --- a/lib/status_checker.rb +++ b/lib/status_checker.rb @@ -17,9 +17,8 @@ if response.nil? { 'message_id' => @message_id, - 'notifications' => [{ 'level' => "info", - 'subject' => "Quickbooks id: ...
Revert "Replace events with notifications", as it's a v5 feature and has syntax errors and is causing production problems. This reverts commit 689dbf388241f41eb1a98739e0ccb8d761a56780.
diff --git a/lib/tumblr/request.rb b/lib/tumblr/request.rb index abc1234..def5678 100644 --- a/lib/tumblr/request.rb +++ b/lib/tumblr/request.rb @@ -18,6 +18,9 @@ # Performs post request def post(path, params={}) + if Array === params[:tags] + params[:tags] = params[:tags].join(',') + end ...
Allow tags to be passed as an array Closes #6
diff --git a/lib/npmdc/modules_directory.rb b/lib/npmdc/modules_directory.rb index abc1234..def5678 100644 --- a/lib/npmdc/modules_directory.rb +++ b/lib/npmdc/modules_directory.rb @@ -16,14 +16,6 @@ def scoped? basename.start_with?('@') - end - - def files - Dir.glob("#{path}/*").map { |file_pa...
Move ModulesDirectory methods to private
diff --git a/lib/petstore/resources/pets.rb b/lib/petstore/resources/pets.rb index abc1234..def5678 100644 --- a/lib/petstore/resources/pets.rb +++ b/lib/petstore/resources/pets.rb @@ -4,6 +4,10 @@ module Resources class Pets < Petstore::Resource set_path 'pet' + + def get(id) + super + e...
Add get method with required id parameter.
diff --git a/ext/concurrent/extconf.rb b/ext/concurrent/extconf.rb index abc1234..def5678 100644 --- a/ext/concurrent/extconf.rb +++ b/ext/concurrent/extconf.rb @@ -1,5 +1,6 @@ require 'fileutils' +$:.unshift(File.expand_path('../../../lib', __FILE__)) require 'concurrent/utility/native_extension_loader' EXTENSIO...
Fix building using native extensions
diff --git a/spec/models/pin_spec.rb b/spec/models/pin_spec.rb index abc1234..def5678 100644 --- a/spec/models/pin_spec.rb +++ b/spec/models/pin_spec.rb @@ -1,6 +1,8 @@ require 'rails_helper' RSpec.describe Pin, type: :model do + let!(:pin) { create(:pin)} + describe 'validations' do it { is_expected.to val...
Add pin class method spec; not passing yet
diff --git a/test/integration/pdf_delivery_test.rb b/test/integration/pdf_delivery_test.rb index abc1234..def5678 100644 --- a/test/integration/pdf_delivery_test.rb +++ b/test/integration/pdf_delivery_test.rb @@ -11,4 +11,15 @@ headers["Content-Disposition"] assert_equal "application/pdf", headers["Content-Typ...
Add test to confirm the chosen template is rendered
diff --git a/test/example/global_options_example.rb b/test/example/global_options_example.rb index abc1234..def5678 100644 --- a/test/example/global_options_example.rb +++ b/test/example/global_options_example.rb @@ -0,0 +1,64 @@+# coding: utf-8 + +require "example_helper" + +Feature "global options" do + as_a "user" ...
Add example for global options
diff --git a/railties/lib/rails/tasks/statistics.rake b/railties/lib/rails/tasks/statistics.rake index abc1234..def5678 100644 --- a/railties/lib/rails/tasks/statistics.rake +++ b/railties/lib/rails/tasks/statistics.rake @@ -8,7 +8,7 @@ %w(Models app/models), %w(Mailers app/mailers), %w(C...
Use JavaScripts instead of Javascripts in `rake stats`
diff --git a/test/models/request_geolocator_test.rb b/test/models/request_geolocator_test.rb index abc1234..def5678 100644 --- a/test/models/request_geolocator_test.rb +++ b/test/models/request_geolocator_test.rb @@ -18,7 +18,13 @@ end test "does not suggests a location unless it's city-specific" do - # This ...
Migrate a comment to code
diff --git a/lib/extensions/action_controller/base.rb b/lib/extensions/action_controller/base.rb index abc1234..def5678 100644 --- a/lib/extensions/action_controller/base.rb +++ b/lib/extensions/action_controller/base.rb @@ -6,7 +6,29 @@ helper_method :current_user, :current_user? - protected + def current_user...
Move current_user from protection section so it can be used in a controller
diff --git a/test/features/create_service_test.rb b/test/features/create_service_test.rb index abc1234..def5678 100644 --- a/test/features/create_service_test.rb +++ b/test/features/create_service_test.rb @@ -19,12 +19,6 @@ assert_content page, "No se pudo crear el servicio" end - test "Attempt to create a se...
Remove test for service creation with invalid file
diff --git a/lib/cucumber/gherkin/steps_parser.rb b/lib/cucumber/gherkin/steps_parser.rb index abc1234..def5678 100644 --- a/lib/cucumber/gherkin/steps_parser.rb +++ b/lib/cucumber/gherkin/steps_parser.rb @@ -12,11 +12,9 @@ end def parse(text) ast_builder = ::Gherkin::AstBuilder.new - token...
Remove hack to set the i18n language when parsing nested steps. The possibility to initialise the matcher with a language was introduced in gherkin v3.1.2. To work with earlier gherkin v3.x.x versions using send to call a private method was necessary.
diff --git a/lib/with_advisory_lock/postgresql.rb b/lib/with_advisory_lock/postgresql.rb index abc1234..def5678 100644 --- a/lib/with_advisory_lock/postgresql.rb +++ b/lib/with_advisory_lock/postgresql.rb @@ -10,7 +10,7 @@ end def execute_successful?(pg_function) - sql = "SELECT #{pg_function}(#{lock_ke...
Add SQL comment to original lock string for PostgreSQL The PostgreSQL implementation requires translating the user-specified lock string into a pair of 32 bit numbers, which makes the lock and unlock statements opaque in the SQL logs. To aid debugging, add a SQL comment containing the original lock string. The commen...
diff --git a/lib/wpclient/paginated_collection.rb b/lib/wpclient/paginated_collection.rb index abc1234..def5678 100644 --- a/lib/wpclient/paginated_collection.rb +++ b/lib/wpclient/paginated_collection.rb @@ -9,6 +9,8 @@ @current_page = current_page @per_page = per_page end + + alias total_entires ...
Add alias for total_entries to total
diff --git a/lib/active_cmis/internal/connection.rb b/lib/active_cmis/internal/connection.rb index abc1234..def5678 100644 --- a/lib/active_cmis/internal/connection.rb +++ b/lib/active_cmis/internal/connection.rb @@ -11,8 +11,6 @@ # The return value is the unparsed body, unless an error occured # If an e...
Add helper function to get an atom entry
diff --git a/lib/netsuite/records/payment_method.rb b/lib/netsuite/records/payment_method.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/payment_method.rb +++ b/lib/netsuite/records/payment_method.rb @@ -5,7 +5,8 @@ include Support::RecordRefs include Support::Actions - actions :get + ...
Add missing actions to payment methods https://system.na1.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/PaymentMethod.html
diff --git a/lib/conjure/provision/docker/host.rb b/lib/conjure/provision/docker/host.rb index abc1234..def5678 100644 --- a/lib/conjure/provision/docker/host.rb +++ b/lib/conjure/provision/docker/host.rb @@ -18,7 +18,7 @@ end def started_container_id(image_name, daemon_command, run_options = nil) - ...
Add auto-restart setting to containers
diff --git a/lib/superstore/belongs_to/association.rb b/lib/superstore/belongs_to/association.rb index abc1234..def5678 100644 --- a/lib/superstore/belongs_to/association.rb +++ b/lib/superstore/belongs_to/association.rb @@ -51,7 +51,7 @@ if reflection.default_primary_key? association_class.find_by_i...
Use find_by rather than where for belongs_to query
diff --git a/ostatus/lib/social_stream/ostatus/models/activity.rb b/ostatus/lib/social_stream/ostatus/models/activity.rb index abc1234..def5678 100644 --- a/ostatus/lib/social_stream/ostatus/models/activity.rb +++ b/ostatus/lib/social_stream/ostatus/models/activity.rb @@ -21,7 +21,7 @@ c...
Include webfinger uri in Salmon instead of ID
diff --git a/lib/travis/api/v3/models/subscription.rb b/lib/travis/api/v3/models/subscription.rb index abc1234..def5678 100644 --- a/lib/travis/api/v3/models/subscription.rb +++ b/lib/travis/api/v3/models/subscription.rb @@ -1,16 +1,17 @@ module Travis::API::V3 - class Models::Subscription < Struct.new(:id, :valid_to,...
Change struct to a real class
diff --git a/lib/gene_genie/template_evaluator.rb b/lib/gene_genie/template_evaluator.rb index abc1234..def5678 100644 --- a/lib/gene_genie/template_evaluator.rb +++ b/lib/gene_genie/template_evaluator.rb @@ -19,7 +19,7 @@ # maximum of 1000 def recommended_size [ - [((Math.log(permutations))**2)....
Increase maximum pool size to 5000
diff --git a/lib/nyan_cat_wide_music_formatter.rb b/lib/nyan_cat_wide_music_formatter.rb index abc1234..def5678 100644 --- a/lib/nyan_cat_wide_music_formatter.rb +++ b/lib/nyan_cat_wide_music_formatter.rb @@ -0,0 +1,9 @@+# -*- coding: utf-8 -*- +require 'nyan_cat_formatter' +require 'nyan_cat_format/wide' +require 'nya...
Add NyanCatWideMusicFormatter (combination of 'wide' and 'music').
diff --git a/lib/extlib/string.rb b/lib/extlib/string.rb index abc1234..def5678 100644 --- a/lib/extlib/string.rb +++ b/lib/extlib/string.rb @@ -1,4 +1,13 @@ class String + # Overwrite this method to provide your own translations. + def self.translate(value) + translations[value] || value + end + + def self.tra...
Add missing String methods that broke dm-validations completely.
diff --git a/lib/findrepos/cli.rb b/lib/findrepos/cli.rb index abc1234..def5678 100644 --- a/lib/findrepos/cli.rb +++ b/lib/findrepos/cli.rb @@ -18,13 +18,22 @@ def list(directory = '.') # :nodoc: Findrepos.list(directory, recursive: options[:recursive]).each do |repo| if Findrepos.clean?(repo) - ...
Add and use a say_git_status helper
diff --git a/lib/flyover_comments/authorization.rb b/lib/flyover_comments/authorization.rb index abc1234..def5678 100644 --- a/lib/flyover_comments/authorization.rb +++ b/lib/flyover_comments/authorization.rb @@ -22,7 +22,7 @@ end def can_flag_flyover_comment?(comment, user) - if Object.const_defined?("...
Make pundit use a flag policy, not comment policy if app is using pundit
diff --git a/lib/stroke_counter/keyboard/logger.rb b/lib/stroke_counter/keyboard/logger.rb index abc1234..def5678 100644 --- a/lib/stroke_counter/keyboard/logger.rb +++ b/lib/stroke_counter/keyboard/logger.rb @@ -44,8 +44,8 @@ hand = log[:hand] end size[hand] -= 1 unless hand.nil? - l2r = counts[:l2r...
Add to_f to fix float probabilities problem
diff --git a/lib/thinking_sphinx/rake_interface.rb b/lib/thinking_sphinx/rake_interface.rb index abc1234..def5678 100644 --- a/lib/thinking_sphinx/rake_interface.rb +++ b/lib/thinking_sphinx/rake_interface.rb @@ -9,7 +9,7 @@ end def configure - ThinkingSphinx::Commands::Configure.call configuration, options +...
Use configure command via commander. This way, it can be safely overridden.
diff --git a/Casks/dwarf-fortress.rb b/Casks/dwarf-fortress.rb index abc1234..def5678 100644 --- a/Casks/dwarf-fortress.rb +++ b/Casks/dwarf-fortress.rb @@ -5,7 +5,7 @@ url "http://www.bay12games.com/dwarves/df_#{version.sub(%r{^0+\.},'').gsub('.','_')}_osx.tar.bz2" name 'Dwarf Fortress' homepage 'http://www.ba...
Update license for Dwarf Fortress to 'gratis'. Dwarf Fortress is closed source but may be freely distributed. The following is the copyright information provided with the software. *** COPYRIGHT INFORMATION **************************** Copyright (c) 2002-2015. All rights are retained by Tarn Adams, save ...
diff --git a/lib/paypoint/blue.rb b/lib/paypoint/blue.rb index abc1234..def5678 100644 --- a/lib/paypoint/blue.rb +++ b/lib/paypoint/blue.rb @@ -25,7 +25,11 @@ # # @return [Hashie::Mash] the parsed, snake_cased response def self.parse_payload(json) - payload = JSON.parse(json.is_a?(IO) ? json.read : ...
Fix payload parsing for binary encoded JSON
diff --git a/spec/controllers/tags_controller_spec.rb b/spec/controllers/tags_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/tags_controller_spec.rb +++ b/spec/controllers/tags_controller_spec.rb @@ -28,5 +28,10 @@ get :show, {id: 2} expect(response).to render_template("show") ...
Add test for assigning tags
diff --git a/lib/proxy_fetcher.rb b/lib/proxy_fetcher.rb index abc1234..def5678 100644 --- a/lib/proxy_fetcher.rb +++ b/lib/proxy_fetcher.rb @@ -3,7 +3,12 @@ require "proxy_fetcher/proxy" module ProxyFetcher - SOURCES = ["http://www.xroxy.com/proxyrss.xml"] + SOURCES = [ + "http://www.xroxy.com/proxyrss.xml", ...
Rename variables missed after refactor, add additional proxy sources
diff --git a/spec/migrations/migrate_pipeline_sidekiq_queues_spec.rb b/spec/migrations/migrate_pipeline_sidekiq_queues_spec.rb index abc1234..def5678 100644 --- a/spec/migrations/migrate_pipeline_sidekiq_queues_spec.rb +++ b/spec/migrations/migrate_pipeline_sidekiq_queues_spec.rb @@ -0,0 +1,50 @@+require 'spec_helper' ...
Add specs for pipeline sidekiq queues migration
diff --git a/Casks/1password-beta.rb b/Casks/1password-beta.rb index abc1234..def5678 100644 --- a/Casks/1password-beta.rb +++ b/Casks/1password-beta.rb @@ -1,6 +1,6 @@ cask :v1 => '1password-beta' do - version '5.3.BETA-16' - sha256 '173e337ec6b2636579ce5362401f714b18808daa69e734a35c5615b0cdddf019' + version '5.3.B...
Update 1Password.app to version 5.3.BETA-17
diff --git a/Casks/rowmote-helper.rb b/Casks/rowmote-helper.rb index abc1234..def5678 100644 --- a/Casks/rowmote-helper.rb +++ b/Casks/rowmote-helper.rb @@ -1,6 +1,6 @@ cask :v1 => 'rowmote-helper' do - version '3.9.4' - sha256 'ea0b33ef5e5572892985b6abe07b214efe29483f36a1aa903339b75fb3c3028d' + version '4.1.2' + s...
Upgrade Rowmote Helper.app to v4.1.2 change version + sha256
diff --git a/lib/document_generator.rb b/lib/document_generator.rb index abc1234..def5678 100644 --- a/lib/document_generator.rb +++ b/lib/document_generator.rb @@ -29,7 +29,6 @@ def generate_spec_helper! unless File.exist?("spec/spec_helper.rb") - puts "The file does not exist" File.open("...
Remove puts statement used for debugging
diff --git a/lib/brewery_db.rb b/lib/brewery_db.rb index abc1234..def5678 100644 --- a/lib/brewery_db.rb +++ b/lib/brewery_db.rb @@ -14,7 +14,7 @@ extend self def respond_to?(method, include_private=false) - client.respond_to?(method, include_private) || super + super || client.respond_to?(method, include_...
Call super first in respond_to?.
diff --git a/lib/buoys/link.rb b/lib/buoys/link.rb index abc1234..def5678 100644 --- a/lib/buoys/link.rb +++ b/lib/buoys/link.rb @@ -3,12 +3,17 @@ attr_accessor :text, :options attr_reader :current + CONFIG = { + current_class: (Buoys::Config.current_class || 'current'), + link_current: (Buoys::...
Use Buoys::Config class to treat configurations
diff --git a/lib/tasks/tasks.rake b/lib/tasks/tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/tasks.rake +++ b/lib/tasks/tasks.rake @@ -2,6 +2,7 @@ require 'pry' require './lib/sequence_base' require 'dm-core' +require 'csv' ['lib', 'models'].each do |dir| Dir.glob(File.join(File.expand_path('../..', F...
Change print from tab delimited to csv.
diff --git a/lib/figaro/cli.rb b/lib/figaro/cli.rb index abc1234..def5678 100644 --- a/lib/figaro/cli.rb +++ b/lib/figaro/cli.rb @@ -7,14 +7,14 @@ desc "heroku:set", "Send Figaro configuration to Heroku" method_option "app", - aliases: ["a"], + aliases: ["-a"], desc: "Specify a Heroku app" ...
Fix Thor aliases to work for older versions of Thor …as is required in older versions of Rails (< 3.2).
diff --git a/lib/hubert/dsl.rb b/lib/hubert/dsl.rb index abc1234..def5678 100644 --- a/lib/hubert/dsl.rb +++ b/lib/hubert/dsl.rb @@ -1,5 +1,20 @@ module Hubert module DSL + class << self + def extended(klass) + builders[klass] = Builder.new + end + + def builders + @builder ||= {} + ...
Use Builder object to generate paths
diff --git a/lib/patch_mailer_paths.rb b/lib/patch_mailer_paths.rb index abc1234..def5678 100644 --- a/lib/patch_mailer_paths.rb +++ b/lib/patch_mailer_paths.rb @@ -5,5 +5,4 @@ Rails.configuration.to_prepare do # Add theme templates to the mailer templates (not overriding the defaults). ActionMailer::Base.app...
Remove some very verbose debug logging
diff --git a/lib/physeng/simulation.rb b/lib/physeng/simulation.rb index abc1234..def5678 100644 --- a/lib/physeng/simulation.rb +++ b/lib/physeng/simulation.rb @@ -26,7 +26,7 @@ p.move! rects << [screenx, screeny, 1, 1] end - @screen.update_rects *dirty + @screen.update_rect...
Update whole screen instead of just dirty rects Updating the dirty rects seems to trigger some X error