diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -13,4 +13,3 @@ css_dir = "css" sass_dir = "_sass" -output_style = :compressed
Remove compass option output_style as it's not being used.
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -11,5 +11,5 @@ reverse_proxy_options preserve_host: true # Forward the path /test* to http://example.com/test* - reverse_proxy '/latin-america/', 'http://www.terra-i.org/latin-america/' + reverse_proxy /^\/gfw-a...
Create PROXY to redirect to the assets js file
diff --git a/spec/support/shared_context_for_api.rb b/spec/support/shared_context_for_api.rb index abc1234..def5678 100644 --- a/spec/support/shared_context_for_api.rb +++ b/spec/support/shared_context_for_api.rb @@ -7,8 +7,7 @@ shared_context 'authenticated user via local token', authenticated: true do - let(:use...
Remove unnecessary :username variable from shared context for api
diff --git a/week-4/simple-string.rb b/week-4/simple-string.rb index abc1234..def5678 100644 --- a/week-4/simple-string.rb +++ b/week-4/simple-string.rb @@ -0,0 +1,28 @@+# Solution Below + +old_string = "Ruby is cool" +new_string = old_string.reverse.upcase + + +# RSpec Tests. They are included in this file because the...
Add simple string methods exercise
diff --git a/features/step_definitions/cli_steps.rb b/features/step_definitions/cli_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/cli_steps.rb +++ b/features/step_definitions/cli_steps.rb @@ -23,6 +23,10 @@ end end +Then /^it succeeds$/ do + @last_error.should be_nil +end + Then /^it fai...
Add a step to verify successful exit status
diff --git a/hostel.gemspec b/hostel.gemspec index abc1234..def5678 100644 --- a/hostel.gemspec +++ b/hostel.gemspec @@ -17,10 +17,10 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ['lib'] - spec.add_dependency 'activesupport', '~> 4.0.0' + spec.add_dependency 'actives...
Remove explicit dependency on a specific rails version
diff --git a/raygun_client.gemspec b/raygun_client.gemspec index abc1234..def5678 100644 --- a/raygun_client.gemspec +++ b/raygun_client.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'raygun_client' - s.version = '0.5.1.0' + s.version = '0.5.2.0' s.summary = 'Client f...
Package version is increased from 0.5.1.0 to 0.5.2.0
diff --git a/display.rb b/display.rb index abc1234..def5678 100644 --- a/display.rb +++ b/display.rb @@ -3,7 +3,8 @@ # # Android Cluster Toolkit # -# list.rb - list which android devices are plugged in ($devices and adb_devices) +# display.rb - list which android devices are plugged in +# (in both $devices[:connected...
Make device lines stand out a bit more.
diff --git a/language/comment_spec.rb b/language/comment_spec.rb index abc1234..def5678 100644 --- a/language/comment_spec.rb +++ b/language/comment_spec.rb @@ -0,0 +1,15 @@+require_relative '../spec_helper' + +describe "The comment" do + ruby_version_is "2.7" do + it "can be placed between fluent dot now" do + ...
Add new specs. Comment lines can be placed between fluent dot now
diff --git a/test/integration/games_interface_test.rb b/test/integration/games_interface_test.rb index abc1234..def5678 100644 --- a/test/integration/games_interface_test.rb +++ b/test/integration/games_interface_test.rb @@ -17,8 +17,8 @@ # TODO: Redo this whole test. # assert_select 'div#error_explanation' ...
Comment out unused variable assignments
diff --git a/lib/braingasm/machine.rb b/lib/braingasm/machine.rb index abc1234..def5678 100644 --- a/lib/braingasm/machine.rb +++ b/lib/braingasm/machine.rb @@ -57,7 +57,7 @@ end def inst_print_cell - print @tape[dp].chr + print @tape[@dp].chr @ip + 1 end
Use instanace variable instead of getter method
diff --git a/lib/duckduckgo/search.rb b/lib/duckduckgo/search.rb index abc1234..def5678 100644 --- a/lib/duckduckgo/search.rb +++ b/lib/duckduckgo/search.rb @@ -10,9 +10,10 @@ results = [] html = open("#{RESOURCE_URL}#{CGI::escape(query)}") + document = Nokogiri::HTML(html) - document.css('.result'...
Use the 'links' id when finding results, rather than the 'results' class
diff --git a/lib/github_api/client.rb b/lib/github_api/client.rb index abc1234..def5678 100644 --- a/lib/github_api/client.rb +++ b/lib/github_api/client.rb @@ -7,7 +7,10 @@ @gists ||= Github::Gists.new(options) end - def git_data(options) + # The Git Database API gives you access to read and write r...
Fix git_data params issue, add method documentation.
diff --git a/db/migrate/20160510232957_change_rereview_and_resubmission_deadlines.rb b/db/migrate/20160510232957_change_rereview_and_resubmission_deadlines.rb index abc1234..def5678 100644 --- a/db/migrate/20160510232957_change_rereview_and_resubmission_deadlines.rb +++ b/db/migrate/20160510232957_change_rereview_and_r...
Fix error in former migration.
diff --git a/site-cookbooks/dna/recipes/dotfiles.rb b/site-cookbooks/dna/recipes/dotfiles.rb index abc1234..def5678 100644 --- a/site-cookbooks/dna/recipes/dotfiles.rb +++ b/site-cookbooks/dna/recipes/dotfiles.rb @@ -17,6 +17,7 @@ git "Download lvv/git-prompt" do repository "http://github.com/lvv/git-prompt.git" ...
Use git-prompt pre switch to bash v4
diff --git a/lib/gds_api/need_api.rb b/lib/gds_api/need_api.rb index abc1234..def5678 100644 --- a/lib/gds_api/need_api.rb +++ b/lib/gds_api/need_api.rb @@ -3,7 +3,7 @@ class GdsApi::NeedApi < GdsApi::Base def needs(options = {}) - query = "?"+options.map { |k,v| "#{k}=#{v}" }.join("&") unless options.empty? + ...
Use query_string method instead of manually mapping query parameters
diff --git a/lib/model/class_meta.rb b/lib/model/class_meta.rb index abc1234..def5678 100644 --- a/lib/model/class_meta.rb +++ b/lib/model/class_meta.rb @@ -14,6 +14,11 @@ return @name == obj.name end + def add_attribute(attribute) + @attributes ||= [] + @attributes << attribute + ...
Add method to add attribute to class.
diff --git a/lib/opal/path_reader.rb b/lib/opal/path_reader.rb index abc1234..def5678 100644 --- a/lib/opal/path_reader.rb +++ b/lib/opal/path_reader.rb @@ -17,7 +17,7 @@ def read(path) full_path = expand(path) return nil if full_path.nil? - File.open(full_path, 'rb:UTF-8', &:read) + File.op...
Return nil from PathReader if the file is missing
diff --git a/lib/speed_gun/config.rb b/lib/speed_gun/config.rb index abc1234..def5678 100644 --- a/lib/speed_gun/config.rb +++ b/lib/speed_gun/config.rb @@ -5,6 +5,10 @@ # @!attribute [rw] # @return [true, false] true if enabled speed gun property :enable, default: true + + # @!attribute [rw] + # @return [Obj...
Add logger sttribute into Config
diff --git a/lib/string_to_pinyin.rb b/lib/string_to_pinyin.rb index abc1234..def5678 100644 --- a/lib/string_to_pinyin.rb +++ b/lib/string_to_pinyin.rb @@ -2,21 +2,18 @@ class String def to_pinyin - h = Hash.new idx_file_path = File.expand_path('../../data/idx99-tone.txt',__FILE__) - open(idx_file_path...
Switch to a more efficient grep based search method
diff --git a/lib/tasks/cucumber.rake b/lib/tasks/cucumber.rake index abc1234..def5678 100644 --- a/lib/tasks/cucumber.rake +++ b/lib/tasks/cucumber.rake @@ -1,53 +1,15 @@-# IMPORTANT: This file is generated by cucumber-rails - edit at your own peril. -# It is recommended to regenerate this file in the future when you u...
Update Cucumber rake file to the current version. Maybe this will help with our jruby issue.
diff --git a/lib/tasks/reminder.rake b/lib/tasks/reminder.rake index abc1234..def5678 100644 --- a/lib/tasks/reminder.rake +++ b/lib/tasks/reminder.rake @@ -1,9 +1,12 @@ require File.expand_path('../../services/slack', __FILE__) +require 'date' namespace :slack do desc 'Reminder for Caviar deadline' task :remi...
Stop warning slack on saturdays or sundays
diff --git a/lib/jstdutil/redgreen.rb b/lib/jstdutil/redgreen.rb index abc1234..def5678 100644 --- a/lib/jstdutil/redgreen.rb +++ b/lib/jstdutil/redgreen.rb @@ -1,3 +1,9 @@+begin + require 'Win32/Console/ANSI' if PLATFORM =~ /win32/ +rescue LoadError + raise 'You must gem install win32console to use color on Windows'...
Add win32console if on windows
diff --git a/definitions/sn-centos-6.3/definition.rb b/definitions/sn-centos-6.3/definition.rb index abc1234..def5678 100644 --- a/definitions/sn-centos-6.3/definition.rb +++ b/definitions/sn-centos-6.3/definition.rb @@ -1,10 +1,18 @@ require File.dirname(__FILE__) + "/../.centos/session.rb" iso = "CentOS-6.3-x86_64...
Fix issues specific to 6.3 kickstarts Before adding the escape, it was going right into the memory test every time. Also needed to override the default memory of 384 with 512 as the installer was failing due to insufficient memory.
diff --git a/spec/adminable/field_collector_spec.rb b/spec/adminable/field_collector_spec.rb index abc1234..def5678 100644 --- a/spec/adminable/field_collector_spec.rb +++ b/spec/adminable/field_collector_spec.rb @@ -0,0 +1,26 @@+describe Adminable::FieldCollector do + let!(:collection) { Adminable::FieldCollector.new...
Add specs for field collector
diff --git a/spec/messages/surround_message_spec.rb b/spec/messages/surround_message_spec.rb index abc1234..def5678 100644 --- a/spec/messages/surround_message_spec.rb +++ b/spec/messages/surround_message_spec.rb @@ -3,11 +3,11 @@ describe Lumos::SurroundMessage do it "returns message" do - expect(described_cla...
Fix surround spec (in the right place) :P
diff --git a/example.rb b/example.rb index abc1234..def5678 100644 --- a/example.rb +++ b/example.rb @@ -11,13 +11,13 @@ until_time = Time.utc(2011, 6, 30) metadata_prefix = 'datacite' -list_records_config = Stash::Harvester::ListRecordsConfig.new( +list_records_config = Stash::Harvester::OAIPMH::ListRecordsConfig.n...
Update to reflect module structure
diff --git a/twoffein-client.gemspec b/twoffein-client.gemspec index abc1234..def5678 100644 --- a/twoffein-client.gemspec +++ b/twoffein-client.gemspec @@ -6,7 +6,7 @@ gem.email = ["dsiw@dsiw-it.de"] gem.description = %q{Client for twoffein.de API} gem.summary = %q{Client for twoffein.de API} -...
Add homepage and dependencies to gemspec
diff --git a/features/step_definitions/get_steps.rb b/features/step_definitions/get_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/get_steps.rb +++ b/features/step_definitions/get_steps.rb @@ -2,7 +2,7 @@ Given(/^I created an OVH client with my credentials$/) do # pending # Write code here th...
Complete Mock definition to unsure tests to pass
diff --git a/lib/tasks/mail_test.rake b/lib/tasks/mail_test.rake index abc1234..def5678 100644 --- a/lib/tasks/mail_test.rake +++ b/lib/tasks/mail_test.rake @@ -0,0 +1,5 @@+task :send_mail_test => :environment do + user = User.find(1) + Notifier.email_for_present_draw_user(user, "Powerball") + puts "sent mail to tes...
Add test task to sen email
diff --git a/lib/tasks/shownotes.rake b/lib/tasks/shownotes.rake index abc1234..def5678 100644 --- a/lib/tasks/shownotes.rake +++ b/lib/tasks/shownotes.rake @@ -3,7 +3,7 @@ task fetch: :environment do require 'net/http' - MINIMUM_SHOW = 490 + MINIMUM_SHOW = 489 # Before that the URLs are not consistent ...
Set minimum show to 489 instead of 490
diff --git a/spec/docker/docker_entrypoint_spec.rb b/spec/docker/docker_entrypoint_spec.rb index abc1234..def5678 100644 --- a/spec/docker/docker_entrypoint_spec.rb +++ b/spec/docker/docker_entrypoint_spec.rb @@ -7,13 +7,7 @@ end [ - "/docker-entrypoint.d/01-lib-messages.sh", - "/docker-entrypoint.d/02-lib...
Test only own docker_entry.d files
diff --git a/spec/features/submit_searches_spec.rb b/spec/features/submit_searches_spec.rb index abc1234..def5678 100644 --- a/spec/features/submit_searches_spec.rb +++ b/spec/features/submit_searches_spec.rb @@ -4,6 +4,6 @@ scenario "render results page on search submit" do visit('/') click_on('Find Trials...
Update feature test because we changed the view it was expecting
diff --git a/test/support/integration_fixtures.rb b/test/support/integration_fixtures.rb index abc1234..def5678 100644 --- a/test/support/integration_fixtures.rb +++ b/test/support/integration_fixtures.rb @@ -1,17 +1,15 @@ module IntegrationFixtures include Fixtures::DefaultMappings - def sample_document_attribut...
Use constant for test data There is no need for this data to be available as a method.
diff --git a/lib/healthy/a19/response_validator.rb b/lib/healthy/a19/response_validator.rb index abc1234..def5678 100644 --- a/lib/healthy/a19/response_validator.rb +++ b/lib/healthy/a19/response_validator.rb @@ -16,7 +16,7 @@ when '500' validate_500 else - raise ::Healthy::UnknownF...
Fix that patient_id is not known
diff --git a/lib/i18n/hygiene/key_usage_checker.rb b/lib/i18n/hygiene/key_usage_checker.rb index abc1234..def5678 100644 --- a/lib/i18n/hygiene/key_usage_checker.rb +++ b/lib/i18n/hygiene/key_usage_checker.rb @@ -5,6 +5,8 @@ def initialize(directories:) @directories = directories + + raise "Must...
Raise if git isn't installed
diff --git a/lib/middleman/pagination/extension.rb b/lib/middleman/pagination/extension.rb index abc1234..def5678 100644 --- a/lib/middleman/pagination/extension.rb +++ b/lib/middleman/pagination/extension.rb @@ -9,7 +9,7 @@ end def manipulate_resource_list(resources) - mainpulated = ManipulatedRe...
Sort resources by path for consistency across installations
diff --git a/lib/omniauth/strategies/spiceworks.rb b/lib/omniauth/strategies/spiceworks.rb index abc1234..def5678 100644 --- a/lib/omniauth/strategies/spiceworks.rb +++ b/lib/omniauth/strategies/spiceworks.rb @@ -5,14 +5,15 @@ option :name, 'spiceworks' option :client_options, { - site: 'https://a...
Fix how we access the response hash. We now parse the response hash and get user from it before getting our values.
diff --git a/lib/tasks/create_importer_schema.rake b/lib/tasks/create_importer_schema.rake index abc1234..def5678 100644 --- a/lib/tasks/create_importer_schema.rake +++ b/lib/tasks/create_importer_schema.rake @@ -0,0 +1,22 @@+# encoding: utf-8 +namespace :db do + desc 'Create importer schema and assign privileges to o...
[importer] Implement rake task to create importer schema for those users that don't have it
diff --git a/interchangeable.gemspec b/interchangeable.gemspec index abc1234..def5678 100644 --- a/interchangeable.gemspec +++ b/interchangeable.gemspec @@ -20,4 +20,6 @@ spec.add_development_dependency "bundler", "~> 1.6" spec.add_development_dependency "rake" + + spec.add_runtime_dependency "terminal-table" ...
Add a dependency on terminal table.
diff --git a/Casks/jawbone-updater.rb b/Casks/jawbone-updater.rb index abc1234..def5678 100644 --- a/Casks/jawbone-updater.rb +++ b/Casks/jawbone-updater.rb @@ -4,7 +4,7 @@ url "http://content.jawbone.com/store/dashboard/Jawbone_Updater-#{version}.pkg" name 'Jawbone Updater' - homepage 'http://jawbone.com/' + ...
Fix homepage to use SSL in Jawbone Updater Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/app/controllers/admin/pages_controller.rb b/app/controllers/admin/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/pages_controller.rb +++ b/app/controllers/admin/pages_controller.rb @@ -10,12 +10,13 @@ def surveys csv = CSV.generate do |builder| - builder <...
Include updated_at in surveys CSV
diff --git a/app/controllers/admin/users_controller.rb b/app/controllers/admin/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/users_controller.rb +++ b/app/controllers/admin/users_controller.rb @@ -3,7 +3,10 @@ if @team.present? @users = @team.users else - @users = Us...
Order admin users page by name
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -25,7 +25,7 @@ protected def log_error(error) caller[0] =~ /`([^']*)'/ and where =...
Fix method name in log_error to display exception text instead of class name for a second time
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -23,7 +23,7 @@ end def get_items_to_vote_on(user) - Item.where('id NOT IN (?)', g...
Fix Having Hardcode Item Type Number Get Next Item Fix the Hardcode Item Type number having to be Hardcode in order to get the next item for the user.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,4 +2,8 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want t...
Clear alert after every action.
diff --git a/app/controllers/derivatives_controller.rb b/app/controllers/derivatives_controller.rb index abc1234..def5678 100644 --- a/app/controllers/derivatives_controller.rb +++ b/app/controllers/derivatives_controller.rb @@ -18,7 +18,7 @@ return end - masterfile = MasterFile.find(params[:id]) + mas...
Remove new PIDs after each feature instead of waiting until teardown
diff --git a/app/helpers/sapphire_cms/client_helper.rb b/app/helpers/sapphire_cms/client_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sapphire_cms/client_helper.rb +++ b/app/helpers/sapphire_cms/client_helper.rb @@ -8,7 +8,7 @@ end def precached_blocks - blocks = ContentBlock.where(precache...
Stop pre-caching blocks that aren't published
diff --git a/plugins/kernel_v1/plugin.rb b/plugins/kernel_v1/plugin.rb index abc1234..def5678 100644 --- a/plugins/kernel_v1/plugin.rb +++ b/plugins/kernel_v1/plugin.rb @@ -11,28 +11,31 @@ basic functionality of Vagrant version 1. DESC - # Core configuration keys provided by the kernel. - confi...
Mark core config classes as upgrade safe
diff --git a/test/json_serializer_test.rb b/test/json_serializer_test.rb index abc1234..def5678 100644 --- a/test/json_serializer_test.rb +++ b/test/json_serializer_test.rb @@ -1,7 +1,7 @@ require 'cutest' require_relative '../lib/json_serializer' -Post = Struct.new :id, :title +Post = Struct.new :id, :title, :creat...
Add another attribute to Post struct to check that is not included.
diff --git a/rb/lib/selenium/webdriver/remote/response.rb b/rb/lib/selenium/webdriver/remote/response.rb index abc1234..def5678 100644 --- a/rb/lib/selenium/webdriver/remote/response.rb +++ b/rb/lib/selenium/webdriver/remote/response.rb @@ -64,6 +64,10 @@ file = "#{class_name}(#{file})" end ...
JariBakken: Set method to 'unknown' if not provided in the server's stack frame. r11605
diff --git a/middleman-alias.gemspec b/middleman-alias.gemspec index abc1234..def5678 100644 --- a/middleman-alias.gemspec +++ b/middleman-alias.gemspec @@ -18,10 +18,10 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency "middleman-core", ["~> ...
Update aruba to allow the latest version of middleman-core
diff --git a/gramola.rb b/gramola.rb index abc1234..def5678 100644 --- a/gramola.rb +++ b/gramola.rb @@ -1,11 +1,15 @@ #!/usr/bin/env ruby -# Just play all the music files under your '/Music' folder using afplay -# Usage: './gramola.rb' or 'ruby gramola.rb' +# Just shuffle play all the music files under your '/Music' f...
Make it shuffle the songs
diff --git a/spec/string_calculator_spec.rb b/spec/string_calculator_spec.rb index abc1234..def5678 100644 --- a/spec/string_calculator_spec.rb +++ b/spec/string_calculator_spec.rb @@ -7,4 +7,8 @@ it 'returns 0 if empty string provided' do expect(subject.add("")).to eq(0) end + + it 'returns number if one nu...
Test case for one number provided
diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb index abc1234..def5678 100644 --- a/app/controllers/welcome_controller.rb +++ b/app/controllers/welcome_controller.rb @@ -4,7 +4,7 @@ @total_payments_received = Payment.sum :amount @total_invoices_unpaid = @total_invoice...
Use more strict SQL in payments query SQLite is not as strict here so I didn't catch this locally. Postgres requires this strictness per the SQL standard.
diff --git a/ObjectMapperDeep.podspec b/ObjectMapperDeep.podspec index abc1234..def5678 100644 --- a/ObjectMapperDeep.podspec +++ b/ObjectMapperDeep.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'ObjectMapperDeep' - s.version = '0.14.2' + s.version = '0.14.3' s.license = 'MIT' s.summary = 'JSON Objec...
Update pod spec version to 0.14.3
diff --git a/src/controllers/systems_controller.rb b/src/controllers/systems_controller.rb index abc1234..def5678 100644 --- a/src/controllers/systems_controller.rb +++ b/src/controllers/systems_controller.rb @@ -16,6 +16,12 @@ register Sinatra::Reloader end + set(:clone) do |is_clone| + condition do + ...
Add route to duplicate system
diff --git a/spree_related_products.gemspec b/spree_related_products.gemspec index abc1234..def5678 100644 --- a/spree_related_products.gemspec +++ b/spree_related_products.gemspec @@ -17,8 +17,8 @@ s.has_rdoc = true - s.add_dependency 'spree_core', '~> 1.3.0' - s.add_dependency 'spree_promo', '~> 1.3.0' + s.a...
Allow 1.3.0.rc1 to be used.
diff --git a/app/models/per_transcript_coverage.rb b/app/models/per_transcript_coverage.rb index abc1234..def5678 100644 --- a/app/models/per_transcript_coverage.rb +++ b/app/models/per_transcript_coverage.rb @@ -1,6 +1,6 @@ class PerTranscriptCoverage < ActiveRecord::Base belongs_to :read_group, :inverse_of => :per...
Fix bug which prevented deleting read group The bug was caused by extra ':dependent => :destroy' in PerTranscriptCoverage model: belongs_to :bedgraph_file, :inverse_of => :per_transcript_coverages, :dependent => :destroy Deleting read group caused deleting per_transcript_coverages, which caused deleting bedgraph_fil...
diff --git a/app/models/services/setup_new_game.rb b/app/models/services/setup_new_game.rb index abc1234..def5678 100644 --- a/app/models/services/setup_new_game.rb +++ b/app/models/services/setup_new_game.rb @@ -1,5 +1,45 @@ class SetupNewGame + def initialize(json, game) + @game = game + @patrol_boat = json[...
Establish new game and create all appropriate models
diff --git a/app/serializers/teaching_period_serializer.rb b/app/serializers/teaching_period_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/teaching_period_serializer.rb +++ b/app/serializers/teaching_period_serializer.rb @@ -1,11 +1,3 @@ class TeachingPeriodSerializer < ActiveModel::Serializer - at...
ENHANCE: Remove the redundant functions from teaching period serializer
diff --git a/app/services/search/global_service.rb b/app/services/search/global_service.rb index abc1234..def5678 100644 --- a/app/services/search/global_service.rb +++ b/app/services/search/global_service.rb @@ -2,6 +2,8 @@ module Search class GlobalService + include Gitlab::Utils::StrongMemoize + attr_ac...
Reduce diff with EE in Search::GlobalService Signed-off-by: Rémy Coutable <4ea0184b9df19e0786dd00b28e6daa4d26baeb3e@rymai.me>
diff --git a/app/workers/inbound_mail_processor.rb b/app/workers/inbound_mail_processor.rb index abc1234..def5678 100644 --- a/app/workers/inbound_mail_processor.rb +++ b/app/workers/inbound_mail_processor.rb @@ -6,9 +6,10 @@ def self.perform(mail_id) mail = InboundMail.find(mail_id) to_address = mail.messa...
Stop logging emails without valid tokens This is filling the resque logs
diff --git a/version_gemfile.gemspec b/version_gemfile.gemspec index abc1234..def5678 100644 --- a/version_gemfile.gemspec +++ b/version_gemfile.gemspec @@ -18,5 +18,5 @@ gem.add_development_dependency("rake", "~> 13.0.6") gem.add_development_dependency("rspec", "~> 3.11.0") - gem.add_development_dependency("st...
Update standard requirement from ~> 1.11.0 to ~> 1.12.1 Updates the requirements on [standard](https://github.com/testdouble/standard) to permit the latest version. - [Release notes](https://github.com/testdouble/standard/releases) - [Changelog](https://github.com/testdouble/standard/blob/main/CHANGELOG.md) - [Commits...
diff --git a/solidus_legacy_return_authorizations.gemspec b/solidus_legacy_return_authorizations.gemspec index abc1234..def5678 100644 --- a/solidus_legacy_return_authorizations.gemspec +++ b/solidus_legacy_return_authorizations.gemspec @@ -15,7 +15,7 @@ s.require_path = "lib" s.requirements << "none" - s.add_d...
Support solidus versions ~> 1.0
diff --git a/spec/unit/error/service_error/errors_spec.rb b/spec/unit/error/service_error/errors_spec.rb index abc1234..def5678 100644 --- a/spec/unit/error/service_error/errors_spec.rb +++ b/spec/unit/error/service_error/errors_spec.rb @@ -0,0 +1,24 @@+# encoding: utf-8 + +require 'spec_helper' + +RSpec.describe Githu...
Add tests for error types.
diff --git a/lib/flowchart/choice.rb b/lib/flowchart/choice.rb index abc1234..def5678 100644 --- a/lib/flowchart/choice.rb +++ b/lib/flowchart/choice.rb @@ -1,9 +1,5 @@ module Flowchart class Choice - def initialize(choices = []) - @choices = choices - end - def decide(data) raise NotImpleme...
Remove unnecessary constructor from Flowchart::Choice
diff --git a/lib/open_tree_struct.rb b/lib/open_tree_struct.rb index abc1234..def5678 100644 --- a/lib/open_tree_struct.rb +++ b/lib/open_tree_struct.rb @@ -1,4 +1,6 @@ require 'ostruct' + +# Author:: Igor class OpenTreeStruct < OpenStruct def initialize(hash={})
Add mention to author in source code
diff --git a/lib/rails_datamapper.rb b/lib/rails_datamapper.rb index abc1234..def5678 100644 --- a/lib/rails_datamapper.rb +++ b/lib/rails_datamapper.rb @@ -22,7 +22,7 @@ end def full_config - YAML::load(ERB.new(config_file.read).result) + YAML::load(ERB.new(File.read(config_file)).result) ...
Fix undefined method `read' for string error
diff --git a/lib/skeptick/command.rb b/lib/skeptick/command.rb index abc1234..def5678 100644 --- a/lib/skeptick/command.rb +++ b/lib/skeptick/command.rb @@ -27,10 +27,10 @@ def run opts = {} - opts[:chdir] = Skeptick.cd_path if Skeptick.cd_path + opts[:chdir] = Skeptick.cd_path.to_s if Skeptick.c...
Call to_s on cd_dir path
diff --git a/spec/commands/zremrangebyscore_spec.rb b/spec/commands/zremrangebyscore_spec.rb index abc1234..def5678 100644 --- a/spec/commands/zremrangebyscore_spec.rb +++ b/spec/commands/zremrangebyscore_spec.rb @@ -26,7 +26,7 @@ it_should_behave_like "a zset-only command" - it "should throw a command error" do...
Reword description in zremrangebyscore spec "Should" is unnecessary in spec descriptions as it is implied. Change-Id: I1e77bb758635a3107ebada7deb86c4d75ac5786d Reviewed-on: http://gerrit.causes.com/37709 Reviewed-by: Shane da Silva <6f6e68d1df92f30cb4b3ce35260ddf94a402f33d@causes.com> Tested-by: Shane da Silva <6f6e6...
diff --git a/spec/integration/integration_helper.rb b/spec/integration/integration_helper.rb index abc1234..def5678 100644 --- a/spec/integration/integration_helper.rb +++ b/spec/integration/integration_helper.rb @@ -21,7 +21,11 @@ end def use_cucumber_config(file) - system("mv config/#{file} config/cuc...
Raise exeption if yaml file doesn't exist
diff --git a/spec/libraries/random_password_spec.rb b/spec/libraries/random_password_spec.rb index abc1234..def5678 100644 --- a/spec/libraries/random_password_spec.rb +++ b/spec/libraries/random_password_spec.rb @@ -0,0 +1,51 @@+require_relative '../spec_helper' +require_relative '../../libraries/random_password' + +d...
Add specs for new library
diff --git a/capistrano-send.gemspec b/capistrano-send.gemspec index abc1234..def5678 100644 --- a/capistrano-send.gemspec +++ b/capistrano-send.gemspec @@ -9,6 +9,7 @@ spec.authors = ["Guillaume Dott"] spec.email = ["guillaume+github@dott.fr"] spec.summary = %q{Send notifications after a de...
Correct some warnings in gemspec
diff --git a/spec/controllers/pwb/api/v1/agency_controller_spec.rb b/spec/controllers/pwb/api/v1/agency_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/pwb/api/v1/agency_controller_spec.rb +++ b/spec/controllers/pwb/api/v1/agency_controller_spec.rb @@ -2,6 +2,60 @@ module Pwb RSpec.describe...
Fix specs for agency api controller
diff --git a/GADI.podspec b/GADI.podspec index abc1234..def5678 100644 --- a/GADI.podspec +++ b/GADI.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "GADI" - s.version = "0.0.2" + s.version = "0.0.3" s.summary = "Google Analytics Dependency Injection for iOS" s.homepage ...
Update pod spec file 0.0.3
diff --git a/src/simplify/replace_shared_strings.rb b/src/simplify/replace_shared_strings.rb index abc1234..def5678 100644 --- a/src/simplify/replace_shared_strings.rb +++ b/src/simplify/replace_shared_strings.rb @@ -14,7 +14,7 @@ ast.each.with_index do |a, i| next unless a.is_a?(Array) if a[0] == :sh...
Fix bug in shared string replacement
diff --git a/app/controllers/api/motions_controller.rb b/app/controllers/api/motions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/motions_controller.rb +++ b/app/controllers/api/motions_controller.rb @@ -1,10 +1,14 @@ class Api::MotionsController < ApiController def index - @motions = if @...
Change API Motions Query To Use Multiple Criteria
diff --git a/config/initializers/new_rails_defaults.rb b/config/initializers/new_rails_defaults.rb index abc1234..def5678 100644 --- a/config/initializers/new_rails_defaults.rb +++ b/config/initializers/new_rails_defaults.rb @@ -11,11 +11,11 @@ ActiveRecord::Base.store_full_sti_class = true end -ActionController::...
Set routing behavior back to Rails 2 style.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,5 +1,5 @@ class ApplicationController < ActionController::Base # Prevent CSRF attacks ...
Disable forgery protection for API calls (cherry picked from commit f3d9f07)
diff --git a/app/controllers/invitations_controller.rb b/app/controllers/invitations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/invitations_controller.rb +++ b/app/controllers/invitations_controller.rb @@ -1,5 +1,5 @@ class InvitationsController < Devise::InvitationsController - after_action :ve...
Make accepting an invitation work again
diff --git a/signantia_analysis.rb b/signantia_analysis.rb index abc1234..def5678 100644 --- a/signantia_analysis.rb +++ b/signantia_analysis.rb @@ -16,9 +16,28 @@ opts.on( '-d', "--database DATABASE", - "The database URI - e.g. sqlite:db/example.sqlite3" + "The database URI", + " e.g. sqlite:db/e...
Add corpus and regex options to script.
diff --git a/spf_parse.gemspec b/spf_parse.gemspec index abc1234..def5678 100644 --- a/spf_parse.gemspec +++ b/spf_parse.gemspec @@ -19,6 +19,8 @@ gem.require_paths = ["lib"] gem.required_ruby_version = '>= 1.9.1' + gem.add_dependency "parslet", "~> 1.0" + gem.add_development_dependency "bundler", "~> 1.6" ...
Add parslet ~> 1.0 as a dependency.
diff --git a/cookbooks/passenger/attributes/default.rb b/cookbooks/passenger/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/passenger/attributes/default.rb +++ b/cookbooks/passenger/attributes/default.rb @@ -1,4 +1,9 @@-default[:passenger][:ruby_version] = "2.5" +if node[:lsb][:release].to_f < 20.0...
Use ruby 2.7 on Ubuntu 20.04
diff --git a/lib/dm-sqlserver-adapter/spec/setup.rb b/lib/dm-sqlserver-adapter/spec/setup.rb index abc1234..def5678 100644 --- a/lib/dm-sqlserver-adapter/spec/setup.rb +++ b/lib/dm-sqlserver-adapter/spec/setup.rb @@ -7,7 +7,15 @@ class SqlserverAdapter < Adapter def connection_uri - "#{super};...
Make SQL Server instance name configurable via DM_DB_SQLSERVER_INSTANCE.
diff --git a/lib/font_awesome/sass/rails/helpers.rb b/lib/font_awesome/sass/rails/helpers.rb index abc1234..def5678 100644 --- a/lib/font_awesome/sass/rails/helpers.rb +++ b/lib/font_awesome/sass/rails/helpers.rb @@ -2,7 +2,10 @@ module Sass module Rails module ViewHelpers - def icon(icon, text="",...
Change icon helper input params Before: ```ruby <%= icon :spinner, nil, class: "fa-spin" %> #=> <i class="fa fa-spinner fa-spin"></i> <%= icon :spinner, "Loading", class: "fa-spin" %> #=> <i class="fa fa-spinner fa-spin">Loading</i> ``` After ```ruby <%= icon :spinner, class: "fa-spin" %> #=> <i class="fa ...
diff --git a/lib/input_sanitizer/restricted_hash.rb b/lib/input_sanitizer/restricted_hash.rb index abc1234..def5678 100644 --- a/lib/input_sanitizer/restricted_hash.rb +++ b/lib/input_sanitizer/restricted_hash.rb @@ -7,6 +7,25 @@ def key_allowed?(key) @allowed_keys.include?(key) + end + + def transfo...
Fix RestrictedHash for Rails 4.2 In 4.2 the implementation of transform_keys (that is used by stringify_keys for example) in ActiveSupport's hash extension changed: rails/rails@f1bad130. Now it tries to create a new instance of the class of the object the stringify_keys is called on and not just creating new class. Th...
diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb index abc1234..def5678 100644 --- a/spec/classes/init_spec.rb +++ b/spec/classes/init_spec.rb @@ -1,7 +1,35 @@ require 'spec_helper' -describe 'users' do +describe 'users', :type => 'class' do context 'with defaults for all parameters' do + it {...
Update main users class unit tests.
diff --git a/no-style-please.gemspec b/no-style-please.gemspec index abc1234..def5678 100644 --- a/no-style-please.gemspec +++ b/no-style-please.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "no-style-please" - spec.version = "0.4.5" + spec.version = "0.4.6" spec.au...
Update gem version to 0.4.6
diff --git a/spec/app/root_spec.rb b/spec/app/root_spec.rb index abc1234..def5678 100644 --- a/spec/app/root_spec.rb +++ b/spec/app/root_spec.rb @@ -23,11 +23,14 @@ end it "should return a success response code" do - last_response.should be_ok + puts last_response + #last_response.status.shoul...
Comment test; docs not present on CI.
diff --git a/Casks/a-better-finder-attributes.rb b/Casks/a-better-finder-attributes.rb index abc1234..def5678 100644 --- a/Casks/a-better-finder-attributes.rb +++ b/Casks/a-better-finder-attributes.rb @@ -0,0 +1,7 @@+class ABetterFinderAttributes < Cask + url 'http://www.publicspace.net/download/ABFAX.dmg' + homepage...
Add A Better Finder Attributes
diff --git a/lib/vcloud/net_launcher/net_launch.rb b/lib/vcloud/net_launcher/net_launch.rb index abc1234..def5678 100644 --- a/lib/vcloud/net_launcher/net_launch.rb +++ b/lib/vcloud/net_launcher/net_launch.rb @@ -19,7 +19,7 @@ net_config[:fence_mode] ||= 'isolated' Vcloud::Core.logger.info("Provisi...
Remove unused var assignment in NetLaunch To fix lint warning: ``` lib/vcloud/net_launcher/net_launch.rb:22:13: W: Useless assignment to variable - net. net = Vcloud::Core::OrgVdcNetwork.provision(net_config) ^^^ ```
diff --git a/lib/weather_reporter/configuration.rb b/lib/weather_reporter/configuration.rb index abc1234..def5678 100644 --- a/lib/weather_reporter/configuration.rb +++ b/lib/weather_reporter/configuration.rb @@ -26,7 +26,7 @@ def valid_yaml_syntax unless file.instance_of?(Hash) - raise WeatherRepor...
Change exception message in method valid_yaml_syntax Change message from Invalid file format to Invalid syntax in yaml
diff --git a/app/helpers/notification_helper.rb b/app/helpers/notification_helper.rb index abc1234..def5678 100644 --- a/app/helpers/notification_helper.rb +++ b/app/helpers/notification_helper.rb @@ -1,4 +1,4 @@-require_relative "../../lib/notification_file_lookup" +require "notification_file_lookup" module Notific...
Fix require line in helper. Was getting Undefined constant errors in dev randomly.
diff --git a/spec/features/submit_feedback_spec.rb b/spec/features/submit_feedback_spec.rb index abc1234..def5678 100644 --- a/spec/features/submit_feedback_spec.rb +++ b/spec/features/submit_feedback_spec.rb @@ -18,50 +18,4 @@ end custom_matchers = [:method, :uri, :host, :path, :valid_uuid, normalised_body] - -...
Remove tests around feedback form
diff --git a/spec/unit/plugins/windows/dmi_spec.rb b/spec/unit/plugins/windows/dmi_spec.rb index abc1234..def5678 100644 --- a/spec/unit/plugins/windows/dmi_spec.rb +++ b/spec/unit/plugins/windows/dmi_spec.rb @@ -0,0 +1,72 @@+# +# Author:: Stuart Preston (<stuart@chef.io>) +# Copyright:: Copyright (c) 2018, Chef Softwa...
Add regression tests for Windows dmi plugin. Signed-off-by: Pete Higgins <e3b6cda228242c30b711ac17cb264f1dbadfd0b6@peterhiggins.org>
diff --git a/app/services/post_stream_window.rb b/app/services/post_stream_window.rb index abc1234..def5678 100644 --- a/app/services/post_stream_window.rb +++ b/app/services/post_stream_window.rb @@ -1,6 +1,6 @@ class PostStreamWindow def self.for(topic:, from: (topic.highest_post_number+1), order: :desc, limit: Si...
Use lt/gt or equal to in post stream window
diff --git a/spec/features/top_spec.rb b/spec/features/top_spec.rb index abc1234..def5678 100644 --- a/spec/features/top_spec.rb +++ b/spec/features/top_spec.rb @@ -4,7 +4,7 @@ describe "GET /" do scenario "Sponser links should be exist" do visit "/" - expect(page).to have_css 'section.sponsors_logo ...
Fix broken spec in Top
diff --git a/spec/models/album_spec.rb b/spec/models/album_spec.rb index abc1234..def5678 100644 --- a/spec/models/album_spec.rb +++ b/spec/models/album_spec.rb @@ -24,7 +24,7 @@ it 'must be deleted if the user is deleted' do album = create(:album) Album.all.count.should eq(1) - album.user.delete + al...
Use destroy so callback is triggered
diff --git a/smart_logger.gemspec b/smart_logger.gemspec index abc1234..def5678 100644 --- a/smart_logger.gemspec +++ b/smart_logger.gemspec @@ -6,7 +6,7 @@ s.description = "Smart grouping of log entries" s.authors = ["Boris Dinkevich"] s.email = 'do@itlater.com' - s.homepage = 'http://rubygems.or...
Change homepage to github page