diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,5 +9,8 @@ end RSpec.configure do |config| - config.after { clear_cookies } + config.after do + clear_cookies + Mingo.collection.remove + end end
Remove all documents from the Mingo collection (but leave any indexes) after each spec run.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,6 +1,6 @@ require 'codeclimate-test-reporter' +CodeClimate::TestReporter.start + require 'svgeez' -CodeClimate::TestReporter.start - $LOAD_PATH.unshift File.expand_path('../...
Move svgeez require below testreporter.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,6 +11,8 @@ Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f} RSpec.configure do |config| + config.include FactoryGirl::Syntax::Methods + # == Mock Framew...
Add FactoryGirl to rspec config
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,11 +1,8 @@-require 'rspec' require 'fakefs/spec_helpers' -require 'rspec' require 'pact/support' require 'webmock/rspec' require 'support/factories' require 'support/spec_s...
Remove redundant requires for spec.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..')) +$LOAD_PATH.unshift(File.dirname(__FILE__)) require 'rspec' require 'flowdock-irc'
Fix require paths for ruby >1.9.2
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,7 +1,7 @@ require 'pathname' require 'rubygems' -gem 'rspec', '~>1.1.12' +gem 'rspec', '>=1.1.12' require 'spec' require Pathname(__FILE__).dirname.parent.expand_path + '...
Use RSpec >= 1.1.12 so 1.2 can be used as well
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -8,22 +8,20 @@ require path end +require 'simplecov' +SimpleCov.coverage_dir(File.join('spec', 'coverage')) + if ENV['TRAVIS'] require 'coveralls' - Coveralls.wear! -else...
Use Coveralls as a SimpleCov formatter rather than standalone
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,24 +6,6 @@ require 'rspec' require 'capybara' -RSpec.configure do |config| - # Workaround for http://code.google.com/p/selenium/issues/detail?id=3147: - # Rerun the example...
Remove workaround for "docElement is null" error The bug seems to be fixed in Selenium, and it works for me locally, so let's try and see how we do without this.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,10 @@+# frozen_string_literal: true + +# Hack to remove VERSION (which is loaded/required via Gemfile -> *.gemspec) before simplecov +# Without this, simplecov reports the ...
Fix to ensure version file is tracked in code coverage
diff --git a/spec/support/vcr.rb b/spec/support/vcr.rb index abc1234..def5678 100644 --- a/spec/support/vcr.rb +++ b/spec/support/vcr.rb @@ -5,5 +5,5 @@ config.hook_into :webmock config.ignore_localhost = true config.configure_rspec_metadata! - # config.default_cassette_options = { match_requests_on: [:method,...
Add allow_playback_repeats to default cassette options
diff --git a/0_code_wars/regex_fun_1_few_days_at_gym.rb b/0_code_wars/regex_fun_1_few_days_at_gym.rb index abc1234..def5678 100644 --- a/0_code_wars/regex_fun_1_few_days_at_gym.rb +++ b/0_code_wars/regex_fun_1_few_days_at_gym.rb @@ -0,0 +1,16 @@+# http://www.codewars.com/kata/5720a81309e1f9b232001c5b/ +# --- iteration ...
Add code wars (7) - few days at the gym
diff --git a/spec/controllers/posts_controller_spec.rb b/spec/controllers/posts_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/posts_controller_spec.rb +++ b/spec/controllers/posts_controller_spec.rb @@ -10,12 +10,12 @@ it 'should get index' do get :index - expect(response).to have_...
Add post update and delete tests
diff --git a/spec/controllers/tasks_controller_spec.rb b/spec/controllers/tasks_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/tasks_controller_spec.rb +++ b/spec/controllers/tasks_controller_spec.rb @@ -20,7 +20,7 @@ name: "Write a Todo App", }, } - post ...
Update spec call to rails 5 style.
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -3,7 +3,8 @@ describe UsersController do describe "GET 'show'" do it "returns http s...
Create user before performing show action
diff --git a/spec/features/instrument_versions_spec.rb b/spec/features/instrument_versions_spec.rb index abc1234..def5678 100644 --- a/spec/features/instrument_versions_spec.rb +++ b/spec/features/instrument_versions_spec.rb @@ -3,21 +3,22 @@ feature "Instrument Versions", js: true, versioning: true do before :each ...
Fix instrument versions feature spec
diff --git a/spec/lib/training/training_loader_spec.rb b/spec/lib/training/training_loader_spec.rb index abc1234..def5678 100644 --- a/spec/lib/training/training_loader_spec.rb +++ b/spec/lib/training/training_loader_spec.rb @@ -0,0 +1,30 @@+# frozen_string_literal: true +require 'rails_helper' +require "#{Rails.root}/...
Add start of TrainingLoader spec
diff --git a/spec/services/spree/cart/add_item_spec.rb b/spec/services/spree/cart/add_item_spec.rb index abc1234..def5678 100644 --- a/spec/services/spree/cart/add_item_spec.rb +++ b/spec/services/spree/cart/add_item_spec.rb @@ -0,0 +1,29 @@+require 'spec_helper' + +module Spree + describe Cart::AddItem do + subjec...
Why: Add Item to a Card service has been manipulated to accept rate and context, this test is to check that a travel product with rate and context can be added.
diff --git a/lesson14/dont_think_twice_its_all_right.rb b/lesson14/dont_think_twice_its_all_right.rb index abc1234..def5678 100644 --- a/lesson14/dont_think_twice_its_all_right.rb +++ b/lesson14/dont_think_twice_its_all_right.rb @@ -0,0 +1,14 @@+# Lesson 14 - 'Slash' chords and Bass runs +# Don't Think Twice It's Alrig...
Add Don't Think Twice It's Alright
diff --git a/BBSInspector.podspec b/BBSInspector.podspec index abc1234..def5678 100644 --- a/BBSInspector.podspec +++ b/BBSInspector.podspec @@ -8,14 +8,14 @@ Pod::Spec.new do |s| s.name = "BBSInspector" - s.version = "0.1.0" + s.version = "0.1.1" s.summary = "Extendable device and appl...
Update pod specification for 0.1.1
diff --git a/files/rubygems-customization/default/operating_system.rb b/files/rubygems-customization/default/operating_system.rb index abc1234..def5678 100644 --- a/files/rubygems-customization/default/operating_system.rb +++ b/files/rubygems-customization/default/operating_system.rb @@ -4,8 +4,8 @@ # system. # Alwa...
Stop 'chef gem' from installing Gem documentation
diff --git a/app/models/neighborly/balanced/bankaccount/payment_generator.rb b/app/models/neighborly/balanced/bankaccount/payment_generator.rb index abc1234..def5678 100644 --- a/app/models/neighborly/balanced/bankaccount/payment_generator.rb +++ b/app/models/neighborly/balanced/bankaccount/payment_generator.rb @@ -24,...
Fix error when doing a instand payment
diff --git a/lib/migration_tools/migration_extension.rb b/lib/migration_tools/migration_extension.rb index abc1234..def5678 100644 --- a/lib/migration_tools/migration_extension.rb +++ b/lib/migration_tools/migration_extension.rb @@ -23,7 +23,8 @@ ActiveRecord::Migration.class_eval do extend MigrationTools::Migration...
Replace alias_method_chain with 2 alias_method
diff --git a/lib/mongo_profiler/models/profile_group.rb b/lib/mongo_profiler/models/profile_group.rb index abc1234..def5678 100644 --- a/lib/mongo_profiler/models/profile_group.rb +++ b/lib/mongo_profiler/models/profile_group.rb @@ -5,7 +5,7 @@ field :name, type: String - has_many :profiles + has_many :pr...
Delete related profiles when deleting groups
diff --git a/api/lib/spree/api/testing_support/helpers.rb b/api/lib/spree/api/testing_support/helpers.rb index abc1234..def5678 100644 --- a/api/lib/spree/api/testing_support/helpers.rb +++ b/api/lib/spree/api/testing_support/helpers.rb @@ -32,7 +32,7 @@ end def upload_image(filename) - fixt...
Revert "Need to pass through a content-type when using upload_image to appease paperclip" This reverts commit b04d57cd7ed194fcf59c4ed67e844c832bdbcc2d.
diff --git a/app/controllers/base_controller_decorator.rb b/app/controllers/base_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/base_controller_decorator.rb +++ b/app/controllers/base_controller_decorator.rb @@ -4,7 +4,7 @@ def save_search keywords = @searcher.try!(:keywords) - ...
Optimize checking for search results. `present?` accidentally runs additional query.
diff --git a/src/bosh-dev/spec/support/ruby_version.rb b/src/bosh-dev/spec/support/ruby_version.rb index abc1234..def5678 100644 --- a/src/bosh-dev/spec/support/ruby_version.rb +++ b/src/bosh-dev/spec/support/ruby_version.rb @@ -3,7 +3,7 @@ module Bosh::Dev class RubyVersion class << self - @@versions = ['...
Fix outdated ruby version variable [#156834184](https://www.pivotaltracker.com/story/show/156834184) Co-authored-by: Josh Russett <51387f2e18a282e19bf73e3a4ebd17eb7c8325fd@pivotal.io>
diff --git a/app/models/utils/nav/customization_parser.rb b/app/models/utils/nav/customization_parser.rb index abc1234..def5678 100644 --- a/app/models/utils/nav/customization_parser.rb +++ b/app/models/utils/nav/customization_parser.rb @@ -29,7 +29,7 @@ name: c[0], path: c[1], per...
783: Fix custom menu item icons
diff --git a/motion-addressbook.gemspec b/motion-addressbook.gemspec index abc1234..def5678 100644 --- a/motion-addressbook.gemspec +++ b/motion-addressbook.gemspec @@ -17,8 +17,7 @@ gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] - gem.add_dependency 'bubble-wrap', '~...
Make bubble-wrap a dev dependency for the app example.
diff --git a/weather_hacker.gemspec b/weather_hacker.gemspec index abc1234..def5678 100644 --- a/weather_hacker.gemspec +++ b/weather_hacker.gemspec @@ -17,6 +17,7 @@ gem.add_dependency 'rake', '>= 0.9.2' gem.add_dependency "httparty" + gem.add_dependency "awesome_print" gem.add_development_dependency "rspec...
Add dependencies for bin/ script
diff --git a/lib/puppet/functions/extlib/has_module.rb b/lib/puppet/functions/extlib/has_module.rb index abc1234..def5678 100644 --- a/lib/puppet/functions/extlib/has_module.rb +++ b/lib/puppet/functions/extlib/has_module.rb @@ -27,7 +27,6 @@ return false unless File.exist?(metadata_json) metadata = JSON.par...
Use a shorter syntax to return
diff --git a/seo_rails_helpers.gemspec b/seo_rails_helpers.gemspec index abc1234..def5678 100644 --- a/seo_rails_helpers.gemspec +++ b/seo_rails_helpers.gemspec @@ -19,7 +19,5 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ['lib'] - spec.add_development_dependen...
Remove bundler and rake dependency
diff --git a/modules/assets/spec/classes/assets_spec.rb b/modules/assets/spec/classes/assets_spec.rb index abc1234..def5678 100644 --- a/modules/assets/spec/classes/assets_spec.rb +++ b/modules/assets/spec/classes/assets_spec.rb @@ -0,0 +1,10 @@+require_relative '../../../../spec_helper' + +describe 'assets', :type => ...
Add stub rspec test to module
diff --git a/app/controllers/html_versions_controller.rb b/app/controllers/html_versions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/html_versions_controller.rb +++ b/app/controllers/html_versions_controller.rb @@ -2,7 +2,7 @@ layout 'detailed-guidance' before_filter :find_publication - be...
Rename mistakenly named method to show intent
diff --git a/spec/controllers/api/api_controller_spec.rb b/spec/controllers/api/api_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/api/api_controller_spec.rb +++ b/spec/controllers/api/api_controller_spec.rb @@ -13,12 +13,31 @@ it 'Response with correct JSON status structure' do ha...
Add unit tests for status/health API endpoints Closes [SCI-2746].
diff --git a/spec/service_objects/ak_user_params_spec.rb b/spec/service_objects/ak_user_params_spec.rb index abc1234..def5678 100644 --- a/spec/service_objects/ak_user_params_spec.rb +++ b/spec/service_objects/ak_user_params_spec.rb @@ -1,11 +1,6 @@-require 'browser' +describe AkUserParams do -describe AkUserParams d...
Add working spec for ak user params creation
diff --git a/lib/byebug/interfaces/remote_interface.rb b/lib/byebug/interfaces/remote_interface.rb index abc1234..def5678 100644 --- a/lib/byebug/interfaces/remote_interface.rb +++ b/lib/byebug/interfaces/remote_interface.rb @@ -27,7 +27,7 @@ end def puts(message) - @socket.printf(message) + @socke...
Fix yet another issue recently in remote debugging
diff --git a/spec/coverage_helper.rb b/spec/coverage_helper.rb index abc1234..def5678 100644 --- a/spec/coverage_helper.rb +++ b/spec/coverage_helper.rb @@ -1,8 +1,9 @@ # frozen_string_literal: true require 'simplecov' -require 'simplecov-lcov' if ENV['CI'] + require 'simplecov-lcov' + SimpleCov::Formatter::Lco...
Modify simplecov-lcov to be required only in CI environment
diff --git a/lib/hdo/utils/representative_vote_feed.rb b/lib/hdo/utils/representative_vote_feed.rb index abc1234..def5678 100644 --- a/lib/hdo/utils/representative_vote_feed.rb +++ b/lib/hdo/utils/representative_vote_feed.rb @@ -14,6 +14,7 @@ propositions.map { |proposition| Entry.new(result, proposition) } ...
Fix duplicate vote feed items
diff --git a/lib/sinatra-active-model-serializers/json.rb b/lib/sinatra-active-model-serializers/json.rb index abc1234..def5678 100644 --- a/lib/sinatra-active-model-serializers/json.rb +++ b/lib/sinatra-active-model-serializers/json.rb @@ -9,6 +9,17 @@ def json(object, options={}) options = options.merge(...
Add Mongoid::Criteria fetcher for root element
diff --git a/oc-chef-pedant/spec/api/groups_acl_spec.rb b/oc-chef-pedant/spec/api/groups_acl_spec.rb index abc1234..def5678 100644 --- a/oc-chef-pedant/spec/api/groups_acl_spec.rb +++ b/oc-chef-pedant/spec/api/groups_acl_spec.rb @@ -0,0 +1,59 @@+require 'pedant/rspec/common' +require 'pedant/acl' + +describe "Groups AC...
Add tests for returning a 403 when removing admin group from any ACE This work isn't done yet, but these are the tests that will show when it is done. For now the tests are marked pending so they can go down into master.
diff --git a/lib/tasks/migrate_old_tinymce_assets.rake b/lib/tasks/migrate_old_tinymce_assets.rake index abc1234..def5678 100644 --- a/lib/tasks/migrate_old_tinymce_assets.rake +++ b/lib/tasks/migrate_old_tinymce_assets.rake @@ -5,19 +5,29 @@ desc 'Migrate old TinyMCE images to new polymorphic format' \ 'IT S...
Improve speed and error handling of TinyMceAssets migration task [SCI-3459]
diff --git a/test/integration/test_editor.rb b/test/integration/test_editor.rb index abc1234..def5678 100644 --- a/test/integration/test_editor.rb +++ b/test/integration/test_editor.rb @@ -0,0 +1,52 @@+require_relative "../capybara_helper" + +context "editor interface" do + include Capybara::DSL + + setup do + @pa...
Test the help panel's "Emoji" section This test is passing. I wrote it so I can safely change this panel in a subsequent commit.
diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb index abc1234..def5678 100644 --- a/app/controllers/reports_controller.rb +++ b/app/controllers/reports_controller.rb @@ -16,8 +16,9 @@ @report = Reports::TotalInventoryValue.new(params, session) end - def orders_by_cre...
Update controller to use new graphs models
diff --git a/app/controllers/sources_controller.rb b/app/controllers/sources_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sources_controller.rb +++ b/app/controllers/sources_controller.rb @@ -13,9 +13,7 @@ end def create - SourceResolver.resolve(source) - - if source.persisted? + if...
Use the return of the SourceResolver
diff --git a/app/controllers/v1/ping_controller.rb b/app/controllers/v1/ping_controller.rb index abc1234..def5678 100644 --- a/app/controllers/v1/ping_controller.rb +++ b/app/controllers/v1/ping_controller.rb @@ -1,5 +1,7 @@-class V1::PingController < ApplicationController - def ping - render json: { result: 'pong'...
Use nested module/class definitions in V1:PingController
diff --git a/lib/cloud_sesame/query/ast/string_value.rb b/lib/cloud_sesame/query/ast/string_value.rb index abc1234..def5678 100644 --- a/lib/cloud_sesame/query/ast/string_value.rb +++ b/lib/cloud_sesame/query/ast/string_value.rb @@ -3,8 +3,8 @@ module AST class StringValue < Abstract::Value - SINGLE_QUATE = ...
Replace regex in StringValue with compiled regex
diff --git a/lib/tasks/2018_10_03_remove_fc_from_procedure_presentation.rake b/lib/tasks/2018_10_03_remove_fc_from_procedure_presentation.rake index abc1234..def5678 100644 --- a/lib/tasks/2018_10_03_remove_fc_from_procedure_presentation.rake +++ b/lib/tasks/2018_10_03_remove_fc_from_procedure_presentation.rake @@ -0,0...
Migrate now obsolete displayed fields, filters and sorts
diff --git a/lib/hstore_radio_buttons/button_options.rb b/lib/hstore_radio_buttons/button_options.rb index abc1234..def5678 100644 --- a/lib/hstore_radio_buttons/button_options.rb +++ b/lib/hstore_radio_buttons/button_options.rb @@ -2,7 +2,7 @@ class ButtonOptions attr_accessor :name, :options def initializ...
Fix attempt for an integration project
diff --git a/lib/yard/server/commands/frames_command.rb b/lib/yard/server/commands/frames_command.rb index abc1234..def5678 100644 --- a/lib/yard/server/commands/frames_command.rb +++ b/lib/yard/server/commands/frames_command.rb @@ -6,7 +6,9 @@ def run main_url = request.path.gsub(/^(.+)?\/...
Fix titles for File urls in frames
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/groups_controller_spec.rb +++ b/spec/controllers/groups_controller_spec.rb @@ -1,17 +1,23 @@ require 'rails_helper' RSpec.describe GroupsController, type: :control...
Set second groups controller test to pending
diff --git a/test/unit/edition_clone_test.rb b/test/unit/edition_clone_test.rb index abc1234..def5678 100644 --- a/test/unit/edition_clone_test.rb +++ b/test/unit/edition_clone_test.rb @@ -0,0 +1,56 @@+require "test_helper" + +class EditionCloneTest < ActiveSupport::TestCase + def setup + @user = User.create :name ...
Add better tests for Edition.build_clone method This method is likely to become more important as part of a feature to allow switching between different Edition types through the publisher admin UI. These tests aim to make sure that Edition.build_clone does what it says it does.
diff --git a/db/migrate/20141110212737_create_schools.rb b/db/migrate/20141110212737_create_schools.rb index abc1234..def5678 100644 --- a/db/migrate/20141110212737_create_schools.rb +++ b/db/migrate/20141110212737_create_schools.rb @@ -0,0 +1,22 @@+class CreateSchools < ActiveRecord::Migration + def change + creat...
Add create schools migration file
diff --git a/Formula/guile.rb b/Formula/guile.rb index abc1234..def5678 100644 --- a/Formula/guile.rb +++ b/Formula/guile.rb @@ -3,10 +3,10 @@ class Guile < Formula homepage 'http://www.gnu.org/software/guile/' url 'ftp://ftp.gnu.org/gnu/guile/guile-1.8.7.tar.gz' - head 'ftp://ftp.gnu.org/pub/gnu/guile/guile-2.0...
Update Guile head to 2.0.1 Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/db/migrate/20160316151832_create_accounts.rb b/db/migrate/20160316151832_create_accounts.rb index abc1234..def5678 100644 --- a/db/migrate/20160316151832_create_accounts.rb +++ b/db/migrate/20160316151832_create_accounts.rb @@ -1,7 +1,8 @@ class CreateAccounts < ActiveRecord::Migration def change c...
Add balance to the accounts
diff --git a/db/migrate/20211219153054_create_profiles.rb b/db/migrate/20211219153054_create_profiles.rb index abc1234..def5678 100644 --- a/db/migrate/20211219153054_create_profiles.rb +++ b/db/migrate/20211219153054_create_profiles.rb @@ -11,14 +11,14 @@ t.timestamps end - User.find_each do |user| - ...
Use an INSERT INTO ... SELECT to move profile data and drop the old columns
diff --git a/spec/unit/inspect_spec.rb b/spec/unit/inspect_spec.rb index abc1234..def5678 100644 --- a/spec/unit/inspect_spec.rb +++ b/spec/unit/inspect_spec.rb @@ -12,6 +12,15 @@ event :stop, :yellow => :red } end - expect(fsm.inspect).to match(/^<#FiniteMachine::StateMachine:0x#{fsm.object_id....
Change to be less brittle
diff --git a/SwiftReorder.podspec b/SwiftReorder.podspec index abc1234..def5678 100644 --- a/SwiftReorder.podspec +++ b/SwiftReorder.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'SwiftReorder' - s.version = '3.0.1' + s.version = '3.1.0' s.license = 'MIT' s.summary = 'Easy drag-and-drop reordering fo...
Update podspec for version 3.1.0
diff --git a/app/controllers/admin/guides_controller.rb b/app/controllers/admin/guides_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/guides_controller.rb +++ b/app/controllers/admin/guides_controller.rb @@ -1,6 +1,6 @@ class Admin::GuidesController < InheritedResources::Base - before_filter...
Update progress action to store some notes, and save the edition at the end
diff --git a/app/controllers/announcements_controller.rb b/app/controllers/announcements_controller.rb index abc1234..def5678 100644 --- a/app/controllers/announcements_controller.rb +++ b/app/controllers/announcements_controller.rb @@ -1,5 +1,4 @@ class AnnouncementsController < PublicFacingController - def index ...
Remove broken and untested announcement atom feed
diff --git a/app/controllers/travel_advice_controller.rb b/app/controllers/travel_advice_controller.rb index abc1234..def5678 100644 --- a/app/controllers/travel_advice_controller.rb +++ b/app/controllers/travel_advice_controller.rb @@ -23,7 +23,7 @@ private def fetch_artefact_and_publication_for_country(count...
Use the country parameter instead of params[:slug in fetch method
diff --git a/app/presenters/tree_builder_report_roles.rb b/app/presenters/tree_builder_report_roles.rb index abc1234..def5678 100644 --- a/app/presenters/tree_builder_report_roles.rb +++ b/app/presenters/tree_builder_report_roles.rb @@ -16,7 +16,7 @@ def root_options user = User.current_user title = if user...
Fix typo in Edit Report Menus tree https://bugzilla.redhat.com/show_bug.cgi?id=1443502
diff --git a/app/models/persistent_volume.rb b/app/models/persistent_volume.rb index abc1234..def5678 100644 --- a/app/models/persistent_volume.rb +++ b/app/models/persistent_volume.rb @@ -3,4 +3,7 @@ include NewWithTypeStiMixin serialize :capacity, Hash delegate :name, :to => :parent, :prefix => true + has_ma...
Add relationship between pods and persistent volumes Refactored code Added refactoring to persistent volume page to support UI Added small refactoring
diff --git a/Casks/the-unarchiver.rb b/Casks/the-unarchiver.rb index abc1234..def5678 100644 --- a/Casks/the-unarchiver.rb +++ b/Casks/the-unarchiver.rb @@ -1,5 +1,5 @@ class TheUnarchiver < Cask - url 'http://theunarchiver.googlecode.com/files/TheUnarchiver3.3.zip' + url 'http://theunarchiver.googlecode.com/files/Th...
Update to version 3.4 of the unarchiver. This version, unlike the preceeding 3.3, is sandboxed so it can be included in the App Store.
diff --git a/rails/app/models/policy_member_distance.rb b/rails/app/models/policy_member_distance.rb index abc1234..def5678 100644 --- a/rails/app/models/policy_member_distance.rb +++ b/rails/app/models/policy_member_distance.rb @@ -13,6 +13,11 @@ belongs_to :policy, foreign_key: :dream_id belongs_to :member, fore...
Add a note about needing to rename these terrible attribute names
diff --git a/lib/cloud_foundry/language_pack/extensions.rb b/lib/cloud_foundry/language_pack/extensions.rb index abc1234..def5678 100644 --- a/lib/cloud_foundry/language_pack/extensions.rb +++ b/lib/cloud_foundry/language_pack/extensions.rb @@ -18,7 +18,7 @@ end def self.delimiter_for(prefix) - (prefix....
Fix URL generation for custom URL assets
diff --git a/lib/travis/api/v3/services/requests/create.rb b/lib/travis/api/v3/services/requests/create.rb index abc1234..def5678 100644 --- a/lib/travis/api/v3/services/requests/create.rb +++ b/lib/travis/api/v3/services/requests/create.rb @@ -1,7 +1,7 @@ module Travis::API::V3 class Services::Requests::Create < Se...
Increase requests creation limit to 50
diff --git a/app/controllers/api/posts_controller.rb b/app/controllers/api/posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/posts_controller.rb +++ b/app/controllers/api/posts_controller.rb @@ -7,7 +7,7 @@ current_site.posts end - posts = scope.published.page(params.dig(:p...
Order by recently for posts API
diff --git a/app/controllers/portfolio_controller.rb b/app/controllers/portfolio_controller.rb index abc1234..def5678 100644 --- a/app/controllers/portfolio_controller.rb +++ b/app/controllers/portfolio_controller.rb @@ -2,15 +2,6 @@ unloadable layout 'portfolio' - - PRIVATE_ACCESS = [ - :user_setup, - :c...
Revert "Re enable anonymous mode" This reverts commit 3d88c55560f8905a7d131d829add6c4dfa2aa000.
diff --git a/app/helpers/concerns_helper/sessions.rb b/app/helpers/concerns_helper/sessions.rb index abc1234..def5678 100644 --- a/app/helpers/concerns_helper/sessions.rb +++ b/app/helpers/concerns_helper/sessions.rb @@ -11,7 +11,7 @@ def reset_session_and_refresh_security_code reset_session - @user.update #r...
Change refresh security code method
diff --git a/app/presenters/ci/pipeline_presenter.rb b/app/presenters/ci/pipeline_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/ci/pipeline_presenter.rb +++ b/app/presenters/ci/pipeline_presenter.rb @@ -1,6 +1,13 @@ module Ci class PipelinePresenter < Gitlab::View::Presenter::Delegated - present...
Move part of pipeline presenter to main CE file
diff --git a/test/controllers/items_controller_test.rb b/test/controllers/items_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/items_controller_test.rb +++ b/test/controllers/items_controller_test.rb @@ -9,6 +9,11 @@ @base_title = "RailsOnlineShop" end + test "should get root" do + ...
Create test for getting the rot_url
diff --git a/test/controllers/items_controller_test.rb b/test/controllers/items_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/items_controller_test.rb +++ b/test/controllers/items_controller_test.rb @@ -5,9 +5,13 @@ # assert true # end + def setup + @base_title = "RailsOnlineShop"...
Create special function "setup" to have ability to use instance variables throughout tests. This runs before running any of the tests, helps to refactor if certain things will be used multiple times
diff --git a/test/support/coerceable_test_sqlserver.rb b/test/support/coerceable_test_sqlserver.rb index abc1234..def5678 100644 --- a/test/support/coerceable_test_sqlserver.rb +++ b/test/support/coerceable_test_sqlserver.rb @@ -11,15 +11,11 @@ module ClassMethods - def coerce_tests(*methods) + ...
Allow coerced tests to be a Regexp.
diff --git a/crass.gemspec b/crass.gemspec index abc1234..def5678 100644 --- a/crass.gemspec +++ b/crass.gemspec @@ -16,8 +16,7 @@ s.require_paths = ['lib'] - s.files = `git ls-files`.split($/) - s.test_files = s.files.grep(%r{^(test|spec|features)/}) + s.files = `git ls-files -z`.split("\x0").grep_v(%r{^...
Remove test files and omit them
diff --git a/lib/warden_oauth_provider/token_strategy.rb b/lib/warden_oauth_provider/token_strategy.rb index abc1234..def5678 100644 --- a/lib/warden_oauth_provider/token_strategy.rb +++ b/lib/warden_oauth_provider/token_strategy.rb @@ -11,14 +11,14 @@ if !request_token or request_token.invalidated? fail...
Fix for 404 redirect error
diff --git a/lib/zendesk_apps_support/app_requirement.rb b/lib/zendesk_apps_support/app_requirement.rb index abc1234..def5678 100644 --- a/lib/zendesk_apps_support/app_requirement.rb +++ b/lib/zendesk_apps_support/app_requirement.rb @@ -2,7 +2,7 @@ module ZendeskAppsSupport class AppRequirement TYPES = %w(autom...
Align array elements for Rubocop
diff --git a/test/integration/pushing_gems/path_test.rb b/test/integration/pushing_gems/path_test.rb index abc1234..def5678 100644 --- a/test/integration/pushing_gems/path_test.rb +++ b/test/integration/pushing_gems/path_test.rb @@ -11,3 +11,15 @@ should_push_gem end + +class PathWithTrailingSlashTest < Geminabox:...
Test coverage for URLs with trailing slashes.
diff --git a/rubygems-code_finder.gemspec b/rubygems-code_finder.gemspec index abc1234..def5678 100644 --- a/rubygems-code_finder.gemspec +++ b/rubygems-code_finder.gemspec @@ -18,6 +18,6 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_depe...
Set bundler lower version limit
diff --git a/relax.gemspec b/relax.gemspec index abc1234..def5678 100644 --- a/relax.gemspec +++ b/relax.gemspec @@ -17,4 +17,5 @@ s.add_development_dependency 'rake' s.add_development_dependency 'mocha' + s.add_development_dependency 'sqlite3' end
Add Sqlite3 to dev dependency
diff --git a/recipes/root_shell_bash.rb b/recipes/root_shell_bash.rb index abc1234..def5678 100644 --- a/recipes/root_shell_bash.rb +++ b/recipes/root_shell_bash.rb @@ -0,0 +1,7 @@+execute "set the root user shell to bash" do + command "dscl . -create /Users/root UserShell /bin/bash" +end + +link "/root" do + to "/...
Change the root shell to bash
diff --git a/app/controllers/spree/admin/admin_controller_decorator.rb b/app/controllers/spree/admin/admin_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/admin_controller_decorator.rb +++ b/app/controllers/spree/admin/admin_controller_decorator.rb @@ -1,17 +1,5 @@ require File.e...
Remove authorize_admin filter from Admin::BaseController, as this is now in Spree
diff --git a/cl.rb b/cl.rb index abc1234..def5678 100644 --- a/cl.rb +++ b/cl.rb @@ -8,10 +8,12 @@ deindenters = [] last_tag = nil +last_lists = [] +lists = {} tags.each do |tag| - indent_level = 0 - puts tag + lists[tag] = {} + current_list = lists[tag]['root'] = [] rev_spec = last_tag ? "#{last_tag}..#{t...
Store commits and print in reverse
diff --git a/lib/oxford/learners/dictionaries/english.rb b/lib/oxford/learners/dictionaries/english.rb index abc1234..def5678 100644 --- a/lib/oxford/learners/dictionaries/english.rb +++ b/lib/oxford/learners/dictionaries/english.rb @@ -1,13 +1,20 @@+require 'nokogiri' +require 'open-uri' + module Oxford module Lea...
Add look_up method instead of parsing in initialize
diff --git a/lib/processing_framework/compress_helper.rb b/lib/processing_framework/compress_helper.rb index abc1234..def5678 100644 --- a/lib/processing_framework/compress_helper.rb +++ b/lib/processing_framework/compress_helper.rb @@ -1,16 +1,20 @@ module ProcessingFramework - class CompressHelper - def CompressH...
Use new shell_out! methods for system commands
diff --git a/spec/json_world/property_definable_spec.rb b/spec/json_world/property_definable_spec.rb index abc1234..def5678 100644 --- a/spec/json_world/property_definable_spec.rb +++ b/spec/json_world/property_definable_spec.rb @@ -28,6 +28,16 @@ subject do klass.as_json_schema end + + it "returns t...
Add an test example for .as_json_schema
diff --git a/app/helpers/users_helper.rb b/app/helpers/users_helper.rb index abc1234..def5678 100644 --- a/app/helpers/users_helper.rb +++ b/app/helpers/users_helper.rb @@ -1,2 +1,9 @@ module UsersHelper + def account_types + User.account_types.keys.to_a + end + + def display_account_type + @user.profile.accou...
Create users helper to display account types
diff --git a/bosh-director/lib/bosh/director/models/release_version.rb b/bosh-director/lib/bosh/director/models/release_version.rb index abc1234..def5678 100644 --- a/bosh-director/lib/bosh/director/models/release_version.rb +++ b/bosh-director/lib/bosh/director/models/release_version.rb @@ -6,9 +6,9 @@ many_to_man...
Validate format before validating presence Signed-off-by: Maria Shaldibina <a39f51a90bfcf8ca23756ef12127e1cf20796cba@pivotallabs.com>
diff --git a/lib/sitemap_generator/adapters/s3_adapter.rb b/lib/sitemap_generator/adapters/s3_adapter.rb index abc1234..def5678 100644 --- a/lib/sitemap_generator/adapters/s3_adapter.rb +++ b/lib/sitemap_generator/adapters/s3_adapter.rb @@ -9,11 +9,13 @@ @fog_provider = opts[:fog_provider] || ENV['FOG_PROVIDER'] ...
Allow callers to override the file adapter with an enhanced version
diff --git a/tab_manager.rb b/tab_manager.rb index abc1234..def5678 100644 --- a/tab_manager.rb +++ b/tab_manager.rb @@ -17,9 +17,11 @@ def next @index = (@index + 1) % @tabs.count + current_tab.refresh_window end def previous @index = (@index - 1) % @tabs.count + current_tab.refresh_window ...
Implement window refresh after switching tab
diff --git a/config/projects/codethink-compiler-flags.rb b/config/projects/codethink-compiler-flags.rb index abc1234..def5678 100644 --- a/config/projects/codethink-compiler-flags.rb +++ b/config/projects/codethink-compiler-flags.rb @@ -8,14 +8,16 @@ compiler_flags = case platform when "aix" - # Use G...
Fix AIX build, and make it a 64-bit one
diff --git a/omnibus/config/projects/chef-server-fips.rb b/omnibus/config/projects/chef-server-fips.rb index abc1234..def5678 100644 --- a/omnibus/config/projects/chef-server-fips.rb +++ b/omnibus/config/projects/chef-server-fips.rb @@ -13,8 +13,8 @@ # See the License for the specific language governing permissions and...
Fix `omnibus cache missing` etc Seems like the _second parameter_ to `instance_eval` is not *only* > used when reporting compilation errors but also fixes the __FILE__ references. Without this change, omnibus cache missing would end up trying to read omnibus_overrides.rb from a path relative to the CWD, and th...
diff --git a/SwiftyBluetooth.podspec b/SwiftyBluetooth.podspec index abc1234..def5678 100644 --- a/SwiftyBluetooth.podspec +++ b/SwiftyBluetooth.podspec @@ -6,7 +6,7 @@ s.authors = { 'Jordane Belanger' => 'jordane.belanger@gmail.com' } s.summary = 'Fully featured closures based library for CoreBluetooth'...
Fix Podspec to point to correct sources location
diff --git a/core/db/migrate/20140315053743_add_timestamps_to_spree_assets.rb b/core/db/migrate/20140315053743_add_timestamps_to_spree_assets.rb index abc1234..def5678 100644 --- a/core/db/migrate/20140315053743_add_timestamps_to_spree_assets.rb +++ b/core/db/migrate/20140315053743_add_timestamps_to_spree_assets.rb @@ ...
Add timestamps fields to spree_assets Initial motivation here was make assets_spec green. As of Rails 4.0.4 touching an object without timestamps won't touch its associations. Plus timestamps are usually handy so no reason for not having them in spree_assets too See https://github.com/rails/rails/commit/73ba2c14cd7d7...
diff --git a/spec/models/provider_spec.rb b/spec/models/provider_spec.rb index abc1234..def5678 100644 --- a/spec/models/provider_spec.rb +++ b/spec/models/provider_spec.rb @@ -22,5 +22,13 @@ require 'rails_helper' RSpec.describe Provider, type: :model do - pending "add some examples to (or delete) #{__FILE__}" + ...
Add tests for provider model
diff --git a/spec/synchronization_spec.rb b/spec/synchronization_spec.rb index abc1234..def5678 100644 --- a/spec/synchronization_spec.rb +++ b/spec/synchronization_spec.rb @@ -7,6 +7,16 @@ it { should validate_presence_of(:model_name) } it { should validate_presence_of(:last_record_updated_at) } it { should va...
Replace usage of have_named_sope matcher which was removed from Shoulda.
diff --git a/lib/agharta/file_recipe.rb b/lib/agharta/file_recipe.rb index abc1234..def5678 100644 --- a/lib/agharta/file_recipe.rb +++ b/lib/agharta/file_recipe.rb @@ -13,12 +13,8 @@ @path = recipe_path end - def load! + def execute eval(File.read(path), binding) - end - - def execute -...
Join load method to execute method.
diff --git a/spec/factories/course_survey_responses.rb b/spec/factories/course_survey_responses.rb index abc1234..def5678 100644 --- a/spec/factories/course_survey_responses.rb +++ b/spec/factories/course_survey_responses.rb @@ -6,8 +6,11 @@ course end survey { build(:survey, course: course) } + poin...
Fix survey response factory awarding random exp
diff --git a/lib/mail_job.rb b/lib/mail_job.rb index abc1234..def5678 100644 --- a/lib/mail_job.rb +++ b/lib/mail_job.rb @@ -6,11 +6,17 @@ end def perform + # TODO: Put this in a transaction so if the forwarding fails it doesn't save the email email = Email.create!(from: message_hash[:from].match("<(.*)>...
Send the message to a different place depending on the environment
diff --git a/spec/services/files/multi_service_spec.rb b/spec/services/files/multi_service_spec.rb index abc1234..def5678 100644 --- a/spec/services/files/multi_service_spec.rb +++ b/spec/services/files/multi_service_spec.rb @@ -0,0 +1,54 @@+require "spec_helper" + +describe Files::MultiService do + subject { describe...
Add some initial specs for Files::MultiService class
diff --git a/lib/nyny/app.rb b/lib/nyny/app.rb index abc1234..def5678 100644 --- a/lib/nyny/app.rb +++ b/lib/nyny/app.rb @@ -30,7 +30,7 @@ def run! port=9292 use Rack::CommonLogger use BetterErrors::Middleware unless NYNY.env.production? - Rack::Handler.pick(['puma', 'webrick']).run new, ...
Include puma in priority list