diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/test_objects_controller.rb b/app/controllers/test_objects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/test_objects_controller.rb +++ b/app/controllers/test_objects_controller.rb @@ -1,6 +1,14 @@ class TestObjectsController < MyplaceonlineController def may_upload ...
Add common things to test object controller such as bubble text and date sorting
diff --git a/app/controllers/users/locale_controller.rb b/app/controllers/users/locale_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users/locale_controller.rb +++ b/app/controllers/users/locale_controller.rb @@ -11,6 +11,7 @@ if request.method == 'POST' render json: { success: true } ...
Add flash notice to confirm locale change
diff --git a/app/controllers/window_rails_controller.rb b/app/controllers/window_rails_controller.rb index abc1234..def5678 100644 --- a/app/controllers/window_rails_controller.rb +++ b/app/controllers/window_rails_controller.rb @@ -26,8 +26,15 @@ redirect_to '/' end format.js do + content ...
Allow providing URL for content or IFrame (for content currently not working)
diff --git a/kde-phonon.rb b/kde-phonon.rb index abc1234..def5678 100644 --- a/kde-phonon.rb +++ b/kde-phonon.rb @@ -2,9 +2,8 @@ class KdePhonon < Formula homepage 'http://phonon.kde.org/' - # yes, phonon-src is only shipped as .tar.xz file. - url 'ftp://ftp.kde.org/pub/kde/stable/phonon/4.6.0/src/phonon-4.6.0.t...
Use KDE http mirror, add sha1
diff --git a/Nocilla.podspec b/Nocilla.podspec index abc1234..def5678 100644 --- a/Nocilla.podspec +++ b/Nocilla.podspec @@ -20,6 +20,7 @@ 'Nocilla/DSL/LSStubRequestDSL.h', 'Nocilla/DSL/LSStubResponseDSL.h', 'Nocilla/Matchers/*.h', + 'Nocilla/Model/LSHTTPBody.h', 'Nocilla/Categories/NSString+Nocil...
[podspec] Fix build of user’s test target by completing public headers.
diff --git a/Casks/omnioutliner-beta.rb b/Casks/omnioutliner-beta.rb index abc1234..def5678 100644 --- a/Casks/omnioutliner-beta.rb +++ b/Casks/omnioutliner-beta.rb @@ -1,6 +1,6 @@ cask 'omnioutliner-beta' do - version '4.4.x-r251827' - sha256 'c2be9c83f1009b6407aea2b6b35da8210b8545a5acfe7aafe0853082b414d056' + vers...
Update OmniOutliner Beta to version 4.4.x-r253921 This commit updates the version and sha256 stanzas.
diff --git a/lib/cartodb_importer/import_mapinfofile.rb b/lib/cartodb_importer/import_mapinfofile.rb index abc1234..def5678 100644 --- a/lib/cartodb_importer/import_mapinfofile.rb +++ b/lib/cartodb_importer/import_mapinfofile.rb @@ -11,7 +11,7 @@ def import_for_org(path, file_name) if REQUIRED_EXT.inject(tru...
Use double quotes for windows compatibility.
diff --git a/lib/reveal-ck/commands/start_web_server.rb b/lib/reveal-ck/commands/start_web_server.rb index abc1234..def5678 100644 --- a/lib/reveal-ck/commands/start_web_server.rb +++ b/lib/reveal-ck/commands/start_web_server.rb @@ -27,7 +27,7 @@ def build_rack_app(doc_root) Rack::Builder.new do ...
Make it so that index.html is the default again I believe this changed in rack over here: https://github.com/rack/rack/commit/3f8db47322c8294e1c2399a481471c811361790e#diff-baa2333b40f04569ff6bd9ffb872fa51
diff --git a/concise_logging.gemspec b/concise_logging.gemspec index abc1234..def5678 100644 --- a/concise_logging.gemspec +++ b/concise_logging.gemspec @@ -9,7 +9,7 @@ spec.authors = ["Gerry Shaw"] spec.email = ["gerry_shaw@yahoo.com"] spec.summary = %q{Alternate logging for Rails productio...
Add link to home page
diff --git a/lib/Storm/Network/Firewall/firewall.rb b/lib/Storm/Network/Firewall/firewall.rb index abc1234..def5678 100644 --- a/lib/Storm/Network/Firewall/firewall.rb +++ b/lib/Storm/Network/Firewall/firewall.rb @@ -0,0 +1,75 @@+require "Storm/Base/model" +require "Storm/Base/sodserver" + +module Storm + module Netwo...
Add Firewall class and APIs
diff --git a/core/app/models/spree/stock/splitter/base.rb b/core/app/models/spree/stock/splitter/base.rb index abc1234..def5678 100644 --- a/core/app/models/spree/stock/splitter/base.rb +++ b/core/app/models/spree/stock/splitter/base.rb @@ -20,7 +20,7 @@ end def build_package(contents=[]) - ...
Use fully-qualified constant when referencing Package within Spree::Stock::Splitter::Base Fixes #2832
diff --git a/lib/data_mapper/mapper/relationship/builder/many_to_one.rb b/lib/data_mapper/mapper/relationship/builder/many_to_one.rb index abc1234..def5678 100644 --- a/lib/data_mapper/mapper/relationship/builder/many_to_one.rb +++ b/lib/data_mapper/mapper/relationship/builder/many_to_one.rb @@ -9,7 +9,7 @@ d...
Make the receiver of the call explicit
diff --git a/lib/attribute_ext/hidden_attributes.rb b/lib/attribute_ext/hidden_attributes.rb index abc1234..def5678 100644 --- a/lib/attribute_ext/hidden_attributes.rb +++ b/lib/attribute_ext/hidden_attributes.rb @@ -3,7 +3,7 @@ def self.included(base) base.extend(ClassMethods) base.alias_method_chain...
Modify as_json instead of to_json for hiding attributes.
diff --git a/lib/octicons_gem/test/octicons_test.rb b/lib/octicons_gem/test/octicons_test.rb index abc1234..def5678 100644 --- a/lib/octicons_gem/test/octicons_test.rb +++ b/lib/octicons_gem/test/octicons_test.rb @@ -7,5 +7,8 @@ assert x_icon["name"] assert x_icon["keywords"] assert x_icon["heights"] + ...
Add deeper asserts to octicons test
diff --git a/app/controllers/neighborly/api/v1/tags_controller.rb b/app/controllers/neighborly/api/v1/tags_controller.rb index abc1234..def5678 100644 --- a/app/controllers/neighborly/api/v1/tags_controller.rb +++ b/app/controllers/neighborly/api/v1/tags_controller.rb @@ -4,13 +4,7 @@ before_action :require_admin...
Use only respond_with on create a tag
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -3,7 +3,8 @@ get '/sotechsha', to: 'sotechsha_overview_page#index' # Redirects - get "/releases/2016/12/12/new-backend", to: redirect('/blogs/2016/12/12/new-backend') + get "/re...
Change url: s/blogs/news/ to fit into coderdojo.com URI pattern
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -6,6 +6,10 @@ get "/browse/:top_level_slug", to: "browse#top_level_browse_page" get "/browse/:top_level_slug/:second_level_slug", to: "browse#second_level_browse_page" + # Note that th...
Add note about routing changes The routes for this app are defined in two places - here and in collections-publisher. This note reminds us to change both. Would've prevented https://github.com/alphagov/collections-publisher/pull/93
diff --git a/server/app/controllers/files_controller.rb b/server/app/controllers/files_controller.rb index abc1234..def5678 100644 --- a/server/app/controllers/files_controller.rb +++ b/server/app/controllers/files_controller.rb @@ -19,7 +19,7 @@ rescue Exception => e logger.error e.message logger.inf...
Add a newline when assembling error response message so that the error and the backtrace don't blend together on the same line. git-svn-id: 907a5e332d9df9b9d6ff346e9993373f8c03b4a0@114 59d7d9da-0ff4-4beb-9ab8-e480f87378b2
diff --git a/pivotal_workstation/attributes/rvm.rb b/pivotal_workstation/attributes/rvm.rb index abc1234..def5678 100644 --- a/pivotal_workstation/attributes/rvm.rb +++ b/pivotal_workstation/attributes/rvm.rb @@ -4,7 +4,7 @@ # "ruby-1.8.7-p358" => { :env => "CC=gcc-4.2" }, # "ruby-1.9.2-p290" => { :env => "CC=gcc-...
Change default ruby 2 to patch level 353
diff --git a/app/contexts/merge_requests_load_context.rb b/app/contexts/merge_requests_load_context.rb index abc1234..def5678 100644 --- a/app/contexts/merge_requests_load_context.rb +++ b/app/contexts/merge_requests_load_context.rb @@ -9,7 +9,7 @@ merge_requests = case type when 'all' then me...
Fix missing assigned_to renaming in 2e839ce fixes #4360.
diff --git a/app/controllers/event_streams_controller.rb b/app/controllers/event_streams_controller.rb index abc1234..def5678 100644 --- a/app/controllers/event_streams_controller.rb +++ b/app/controllers/event_streams_controller.rb @@ -1,5 +1,11 @@ class EventStreamsController < ApplicationController + before_action ...
Add some untested basic auth to streams controller
diff --git a/db/data_migration/20140328161525_migrate_environmental_detailed_guides.rb b/db/data_migration/20140328161525_migrate_environmental_detailed_guides.rb index abc1234..def5678 100644 --- a/db/data_migration/20140328161525_migrate_environmental_detailed_guides.rb +++ b/db/data_migration/20140328161525_migrate_...
Change the parent categories for EA subcategories.
diff --git a/app/controllers/srpm_all_bugs_controller.rb b/app/controllers/srpm_all_bugs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/srpm_all_bugs_controller.rb +++ b/app/controllers/srpm_all_bugs_controller.rb @@ -1,8 +1,24 @@ class SrpmAllBugsController < ApplicationController + # after_action ...
Add example for debuging used attributes
diff --git a/app/models/region.rb b/app/models/region.rb index abc1234..def5678 100644 --- a/app/models/region.rb +++ b/app/models/region.rb @@ -30,7 +30,7 @@ self.geom = recipe.make unless recipe.errors.empty? recipe.errors.each do |e| - @errors.add(:recipe, e) + self.errors.add(:recipe, ...
Fix bug with errors in Region.rb
diff --git a/database_sanitizer.gemspec b/database_sanitizer.gemspec index abc1234..def5678 100644 --- a/database_sanitizer.gemspec +++ b/database_sanitizer.gemspec @@ -20,7 +20,7 @@ spec.add_development_dependency 'rake', '~> 10' spec.add_development_dependency 'pg', '~> 0.17' - spec.add_runtime_dependency 'ac...
Fix rspec version to work with rspec 4
diff --git a/app/models/organization.rb b/app/models/organization.rb index abc1234..def5678 100644 --- a/app/models/organization.rb +++ b/app/models/organization.rb @@ -8,7 +8,6 @@ has_many :event_groups, dependent: :destroy has_many :stewardships, dependent: :destroy has_many :stewards, through: :stewardships,...
Revert Organization / Event relationship.
diff --git a/app/serializers/spree/payment_serializer.rb b/app/serializers/spree/payment_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/spree/payment_serializer.rb +++ b/app/serializers/spree/payment_serializer.rb @@ -2,10 +2,11 @@ class PaymentSerializer < ActiveModel::Serializer embed :ids, ...
Add state to payment serializer
diff --git a/app/models/csv_db.rb b/app/models/csv_db.rb index abc1234..def5678 100644 --- a/app/models/csv_db.rb +++ b/app/models/csv_db.rb @@ -3,7 +3,8 @@ class << self def convert_save(target_model, csv_data, role = :default, &block) csv_file = csv_data.read - CSV.parse(csv_file, :headers => true,...
Make compatible with Ruby 1.8.7.
diff --git a/app/models/device.rb b/app/models/device.rb index abc1234..def5678 100644 --- a/app/models/device.rb +++ b/app/models/device.rb @@ -14,10 +14,11 @@ has_many :peripherals, dependent: :destroy has_many :tools, dependent: :destroy has_many :images, dependent: :destroy - v...
Validate presence (but not uniqueness) of `name`
diff --git a/spec/controllers/boards_controller_spec.rb b/spec/controllers/boards_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/boards_controller_spec.rb +++ b/spec/controllers/boards_controller_spec.rb @@ -34,4 +34,8 @@ end end + describe "access control" do + it "exists" + end ...
Add pending test for BoardsController access control.
diff --git a/spec/integration/one_signal_client_spec.rb b/spec/integration/one_signal_client_spec.rb index abc1234..def5678 100644 --- a/spec/integration/one_signal_client_spec.rb +++ b/spec/integration/one_signal_client_spec.rb @@ -23,4 +23,13 @@ expect(status).to be_success expect(status.id).to_not be_nil ...
Add integration test for notify operation
diff --git a/test/as_test.rb b/test/as_test.rb index abc1234..def5678 100644 --- a/test/as_test.rb +++ b/test/as_test.rb @@ -0,0 +1,17 @@+require 'test_helper' + +describe 'Redis::Breadcrumb' do + before do + Redis::Breadcrumb.redis = MockRedis.new + end + + it 'can create a method to access the key through' do +...
Add 'can create a method to access the through' test
diff --git a/spec/support/real_time/connected_client.rb b/spec/support/real_time/connected_client.rb index abc1234..def5678 100644 --- a/spec/support/real_time/connected_client.rb +++ b/spec/support/real_time/connected_client.rb @@ -1,5 +1,5 @@ RSpec.shared_context 'connected client' do |opts| - let(:client) { Slack::...
Remove since Slack::RealTime::Store is the default anyway.
diff --git a/advent-of-code-day-4/lib/main.rb b/advent-of-code-day-4/lib/main.rb index abc1234..def5678 100644 --- a/advent-of-code-day-4/lib/main.rb +++ b/advent-of-code-day-4/lib/main.rb @@ -32,4 +32,5 @@ if __FILE__ == $0 secret_key = gets.chomp puts Hasher.lowest_initial_zeroes_added_number(secret_key, 5) + ...
Complete day 4 part 2 I needed no new implementation. I just called my existing method with a different number.
diff --git a/alpha-blog/app/models/article.rb b/alpha-blog/app/models/article.rb index abc1234..def5678 100644 --- a/alpha-blog/app/models/article.rb +++ b/alpha-blog/app/models/article.rb @@ -1,3 +1,9 @@ class Article < ActiveRecord::Base + # title and description for record is mandatory + validates :title, presen...
Add validations for title and description attributes
diff --git a/config/initializers/jasminerice.rb b/config/initializers/jasminerice.rb index abc1234..def5678 100644 --- a/config/initializers/jasminerice.rb +++ b/config/initializers/jasminerice.rb @@ -1 +1 @@-Rails.application.config.assets.paths << File.join(Rails.root, "spec", "javascripts") +Rails.application.config...
Add both javascript and stylesheet paths.
diff --git a/features/step_definitions/generator_steps.rb b/features/step_definitions/generator_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/generator_steps.rb +++ b/features/step_definitions/generator_steps.rb @@ -1,10 +1,10 @@ Before do - `mv #{Rails.root}/features/ #{Rails.root}/features.o...
Make generator steps less noisy if there isn't a features dir in the testing app
diff --git a/spec/travis/addons/email/instruments/event_handler_spec.rb b/spec/travis/addons/email/instruments/event_handler_spec.rb index abc1234..def5678 100644 --- a/spec/travis/addons/email/instruments/event_handler_spec.rb +++ b/spec/travis/addons/email/instruments/event_handler_spec.rb @@ -3,10 +3,13 @@ describe ...
Add enough stubs to instruments spec
diff --git a/app/decorators/user_decorator.rb b/app/decorators/user_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/user_decorator.rb +++ b/app/decorators/user_decorator.rb @@ -24,6 +24,6 @@ end def role - object.role.humanize + object.role.to_s.humanize end end
Fix admin user roles humanize string
diff --git a/app/models/description_object.rb b/app/models/description_object.rb index abc1234..def5678 100644 --- a/app/models/description_object.rb +++ b/app/models/description_object.rb @@ -1,6 +1,7 @@ class DescriptionObject < ActiveFedora::Base include Hydra::ModelMixins::RightsMetadata + before_save :set_pe...
Add default permissions settings on DescriptionObject as a before_save callback
diff --git a/yahag.gemspec b/yahag.gemspec index abc1234..def5678 100644 --- a/yahag.gemspec +++ b/yahag.gemspec @@ -8,8 +8,8 @@ gem.version = Yahag::VERSION gem.authors = ['Max Riveiro'] gem.email = ['kavu13@gmail.com'] - gem.description = %q{TODO: Write a gem description} - gem.summary...
Fix gem desciption and summary
diff --git a/app/controllers/backend/taxes_controller.rb b/app/controllers/backend/taxes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/backend/taxes_controller.rb +++ b/app/controllers/backend/taxes_controller.rb @@ -34,7 +34,7 @@ def load Tax.import_all_from_nomenclature(Preference[:co...
Fix load in taxes controller to be used by test
diff --git a/app/models/concerns/submittable/solvable.rb b/app/models/concerns/submittable/solvable.rb index abc1234..def5678 100644 --- a/app/models/concerns/submittable/solvable.rb +++ b/app/models/concerns/submittable/solvable.rb @@ -1,7 +1,7 @@ module Solvable def submit_solution!(user, attributes={}) conte...
Refactor solution Hash to string conversion
diff --git a/app/controllers/checkin/groups_controller.rb b/app/controllers/checkin/groups_controller.rb index abc1234..def5678 100644 --- a/app/controllers/checkin/groups_controller.rb +++ b/app/controllers/checkin/groups_controller.rb @@ -4,7 +4,10 @@ @groups = {} date = params[:date] ? Date.parse(params[:da...
Fix old style AR query.
diff --git a/app/controllers/browserlog/logs_controller.rb b/app/controllers/browserlog/logs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/browserlog/logs_controller.rb +++ b/app/controllers/browserlog/logs_controller.rb @@ -16,7 +16,7 @@ respond_to do |format| format.json do ...
Remove trailing whitespace before comma
diff --git a/app/controllers/incident_events_controller.rb b/app/controllers/incident_events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/incident_events_controller.rb +++ b/app/controllers/incident_events_controller.rb @@ -11,9 +11,9 @@ if params[:Digits] case params[:Digits] whe...
Create events by acknowledging and resolving from phone.
diff --git a/alpha-blog/app/controllers/users_controller.rb b/alpha-blog/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/alpha-blog/app/controllers/users_controller.rb +++ b/alpha-blog/app/controllers/users_controller.rb @@ -14,8 +14,9 @@ @user = User.new(user_params) if @user.save + ...
Add sign in upon sign up
diff --git a/config/initializers/_jiffybag.rb b/config/initializers/_jiffybag.rb index abc1234..def5678 100644 --- a/config/initializers/_jiffybag.rb +++ b/config/initializers/_jiffybag.rb @@ -7,4 +7,5 @@ AWS_SECRET_ACCESS_KEY AWS_BUCKET OPENSPACE_API_KEY + LEGATO_OAUTH_ACCESS_TOKEN }
Add access token to JiffyBag
diff --git a/lib/minitest/ruby_golf_metrics/reporter.rb b/lib/minitest/ruby_golf_metrics/reporter.rb index abc1234..def5678 100644 --- a/lib/minitest/ruby_golf_metrics/reporter.rb +++ b/lib/minitest/ruby_golf_metrics/reporter.rb @@ -22,7 +22,7 @@ if erg.passed begin source = RubyGo...
Make alle whitespace not count, not just spaces
diff --git a/lib/oh_auth/endpoints/authenticate_user.rb b/lib/oh_auth/endpoints/authenticate_user.rb index abc1234..def5678 100644 --- a/lib/oh_auth/endpoints/authenticate_user.rb +++ b/lib/oh_auth/endpoints/authenticate_user.rb @@ -11,13 +11,19 @@ user = User.find(request.params['username']) if u...
Add the correct content type header
diff --git a/app/importers/student_assessment_importer.rb b/app/importers/student_assessment_importer.rb index abc1234..def5678 100644 --- a/app/importers/student_assessment_importer.rb +++ b/app/importers/student_assessment_importer.rb @@ -1,5 +1,5 @@ class StudentAssessmentImporter - WHITELIST = Regexp.union(/ACCESS...
Stop importing STAR data from X2 + The STAR SFTP server is the only source of truth about STAR + One system was importing results with subject "Math" (STAR SFTP), the other with subject "Mathematics" (Aspen X2) + Only import assessment results from one system (STAR SFTP), use the same subject name as Aspen X2 ("Mathem...
diff --git a/app/models/renalware/letters/letter_query.rb b/app/models/renalware/letters/letter_query.rb index abc1234..def5678 100644 --- a/app/models/renalware/letters/letter_query.rb +++ b/app/models/renalware/letters/letter_query.rb @@ -27,7 +27,7 @@ end def search - @search ||= Letter.extend(...
Resolve global letters list N+1 issues
diff --git a/app/controllers/projects/uploads_controller.rb b/app/controllers/projects/uploads_controller.rb index abc1234..def5678 100644 --- a/app/controllers/projects/uploads_controller.rb +++ b/app/controllers/projects/uploads_controller.rb @@ -1,11 +1,8 @@ class Projects::UploadsController < Projects::ApplicationC...
Simplify the `skip_before_filter` logic for UploadsController
diff --git a/cucumber-timed_formatter.gemspec b/cucumber-timed_formatter.gemspec index abc1234..def5678 100644 --- a/cucumber-timed_formatter.gemspec +++ b/cucumber-timed_formatter.gemspec @@ -6,8 +6,10 @@ s.name = "cucumber-timed_formatter" s.version = Cucumber::Formatter::Timed::VERSION s.date = File.mtime(__...
Add more description to gemspec
diff --git a/GTScrollNavigationBar.podspec b/GTScrollNavigationBar.podspec index abc1234..def5678 100644 --- a/GTScrollNavigationBar.podspec +++ b/GTScrollNavigationBar.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "GTScrollNavigationBar" - s.version = "0.3" + s.version = "0.4" s.summa...
Update Podspec to 0.4 since it breaks API compatibility
diff --git a/rails/pluralization/hsb.rb b/rails/pluralization/hsb.rb index abc1234..def5678 100644 --- a/rails/pluralization/hsb.rb +++ b/rails/pluralization/hsb.rb @@ -0,0 +1,27 @@+module RailsI18n + module Pluralization + module UpperSorbian + def self.rule + lambda do |n| + mod100 = n % 100 ...
Add pluralization rule for Upper Sorbian
diff --git a/app/models/order_query.rb b/app/models/order_query.rb index abc1234..def5678 100644 --- a/app/models/order_query.rb +++ b/app/models/order_query.rb @@ -3,10 +3,11 @@ attr_accessor :warehouse_id, :order_number - validates :warehouse_id, length: { is: 2 } - validates :order_number, length: { is: 6 } ...
Change validations to generate an exception when parameters are incorrect ID:575
diff --git a/app/models/poll_option.rb b/app/models/poll_option.rb index abc1234..def5678 100644 --- a/app/models/poll_option.rb +++ b/app/models/poll_option.rb @@ -32,8 +32,10 @@ def display_name(zone: nil) if poll.dates_as_options formatted_datetime(name, zone || poll.time_zone) + elsif poll.poll_opt...
Fix casing for user-generated poll options in email
diff --git a/app/controllers/wpcc_controller.rb b/app/controllers/wpcc_controller.rb index abc1234..def5678 100644 --- a/app/controllers/wpcc_controller.rb +++ b/app/controllers/wpcc_controller.rb @@ -1,6 +1,10 @@ class WpccController < EmbeddedToolsController def exclude_syndicated_iframe_resizer? true + end ...
Update canonical url for WPCC
diff --git a/app/models/spree/purchase_order.rb b/app/models/spree/purchase_order.rb index abc1234..def5678 100644 --- a/app/models/spree/purchase_order.rb +++ b/app/models/spree/purchase_order.rb @@ -5,7 +5,7 @@ belongs_to :payment_method has_many :payments, as: :source - validates_presence_of :po_number...
Use newer form of presence validation
diff --git a/app/models/visualization/member.rb b/app/models/visualization/member.rb index abc1234..def5678 100644 --- a/app/models/visualization/member.rb +++ b/app/models/visualization/member.rb @@ -1,7 +1,7 @@ # encoding: utf-8 require 'virtus' require 'virtus/attribute/writer/coercible' -require_relative '../../....
Make Visualization::Member use the default repository in Visualization module
diff --git a/app/overrides/include_augury_js.rb b/app/overrides/include_augury_js.rb index abc1234..def5678 100644 --- a/app/overrides/include_augury_js.rb +++ b/app/overrides/include_augury_js.rb @@ -1,13 +1,7 @@-if Rails.env.development? - Deface::Override.new(virtual_path: 'spree/layouts/admin', - ...
Update include augury js override
diff --git a/app/helpers/icons_helper.rb b/app/helpers/icons_helper.rb index abc1234..def5678 100644 --- a/app/helpers/icons_helper.rb +++ b/app/helpers/icons_helper.rb @@ -1,4 +1,5 @@ module IconsHelper + include FontAwesome::Sass::Rails::ViewHelpers def garden_icon icon('far', 'square') end
Include font awesome (so specs pass)
diff --git a/app/helpers/repos_helper.rb b/app/helpers/repos_helper.rb index abc1234..def5678 100644 --- a/app/helpers/repos_helper.rb +++ b/app/helpers/repos_helper.rb @@ -1,6 +1,6 @@ module ReposHelper - def link_to_or_log_in(text: text, path: path, html_class: "") - path = user_signed_in? ? path : user_omniauth_...
Fix ruby circular reference warnings
diff --git a/activesupport/lib/active_support/core_ext/float/rounding.rb b/activesupport/lib/active_support/core_ext/float/rounding.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/core_ext/float/rounding.rb +++ b/activesupport/lib/active_support/core_ext/float/rounding.rb @@ -12,9 +12,9 @@ ...
Revert "Fix example using wrong method name" This reverts commit 5745b25c9f71d86458f2d1cda65f800cbe4e6733.
diff --git a/app/presenters/tree_builder_automation_manager_providers.rb b/app/presenters/tree_builder_automation_manager_providers.rb index abc1234..def5678 100644 --- a/app/presenters/tree_builder_automation_manager_providers.rb +++ b/app/presenters/tree_builder_automation_manager_providers.rb @@ -22,7 +22,7 @@ #...
Remove descendants matching for automation providers - needed for configured systems groups only
diff --git a/lib/rails_config/railtie.rb b/lib/rails_config/railtie.rb index abc1234..def5678 100644 --- a/lib/rails_config/railtie.rb +++ b/lib/rails_config/railtie.rb @@ -1,14 +1,18 @@ if defined?(Rails::Railtie) module RailsConfig class Railtie < Rails::Railtie + config.rails_config = ActiveSupport::Ord...
Add the ability to define the settings object via config.rails_config.constant
diff --git a/lib/tasks/schema_tests.rake b/lib/tasks/schema_tests.rake index abc1234..def5678 100644 --- a/lib/tasks/schema_tests.rake +++ b/lib/tasks/schema_tests.rake @@ -0,0 +1,8 @@+namespace :test do + Rake::TestTask.new(:schemas => "test:prepare") do |t| + t.libs << 'test' + t.test_files = `grep -rlE "schem...
Add a test:schemas rake task This rake task only runs tests that have the word "schema" in them. We can run this task instead of the full test (which takes 8 minutes) when testing as a downstream build from govuk-content-schemas. Having "schema" in the test file is obviously going to cause false positives, but hopefu...
diff --git a/atlas.gemspec b/atlas.gemspec index abc1234..def5678 100644 --- a/atlas.gemspec +++ b/atlas.gemspec @@ -24,4 +24,5 @@ spec.add_development_dependency 'rake' spec.add_development_dependency 'vcr' spec.add_development_dependency 'rspec' + spec.add_development_dependency "pry" end
Add pry as a development dependency.
diff --git a/event_store-client.gemspec b/event_store-client.gemspec index abc1234..def5678 100644 --- a/event_store-client.gemspec +++ b/event_store-client.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'event_store-client' - s.version = '0.1.1' + s.version = '0.1.2' ...
Package version is increased from 0.1.1 to 0.1.2
diff --git a/format_utils.rb b/format_utils.rb index abc1234..def5678 100644 --- a/format_utils.rb +++ b/format_utils.rb @@ -11,7 +11,7 @@ def random_quote @quotes = IO.readlines 'dict.txt' if @quotes.nil? has_quote = rand(10000) % 2 - has_quote == 1 ? @quotes[rand(@quotes.size)] : '' + has_quote == 1 ? @quotes...
Use Array.sample to pick abritary quote
diff --git a/lib/newline_hw/config.rb b/lib/newline_hw/config.rb index abc1234..def5678 100644 --- a/lib/newline_hw/config.rb +++ b/lib/newline_hw/config.rb @@ -6,7 +6,7 @@ DEFAULTS = { "editor" => "atom", "terminal" => "Terminal", - "start_editor" => true, + "launch_editor" => true, ...
Rename start_editor to launch editor for a bit of clarity.
diff --git a/test/factories/products.rb b/test/factories/products.rb index abc1234..def5678 100644 --- a/test/factories/products.rb +++ b/test/factories/products.rb @@ -3,7 +3,7 @@ association :category, factory: :product_nature_category association :nature, factory: :product_nature association :variant, ...
Fix last static attribute in factories
diff --git a/app/serializers/task_definition_serializer.rb b/app/serializers/task_definition_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/task_definition_serializer.rb +++ b/app/serializers/task_definition_serializer.rb @@ -10,7 +10,7 @@ :restrict_status_updates, :group_s...
FIX: Include :has_task_assessment_resources? in task_def serialiser
diff --git a/plugin/pv-prepare-commit-msg.rb b/plugin/pv-prepare-commit-msg.rb index abc1234..def5678 100644 --- a/plugin/pv-prepare-commit-msg.rb +++ b/plugin/pv-prepare-commit-msg.rb @@ -7,7 +7,7 @@ commit_msg = IO.read(commit_msg_file_path) unless commit_msg.include?($1) or commit_msg =~ /Merge branch/ ...
Print id by default as commit description
diff --git a/plugins/guests/alpine/plugin.rb b/plugins/guests/alpine/plugin.rb index abc1234..def5678 100644 --- a/plugins/guests/alpine/plugin.rb +++ b/plugins/guests/alpine/plugin.rb @@ -6,42 +6,42 @@ name 'Alpine guest' description 'Alpine Linux guest support.' - guest('alpine', 'linux') do + ...
alpine: Replace capability strings with symbols Those were introduced upstream in b29864f45097.
diff --git a/telemetry-logger.gemspec b/telemetry-logger.gemspec index abc1234..def5678 100644 --- a/telemetry-logger.gemspec +++ b/telemetry-logger.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'telemetry-logger' - s.version = '0.1.2' + s.version = '0.1.3' s.summary ...
Package version is incremented from patch number 0.1.2 to 0.1.3
diff --git a/spec/dummy/db/migrate/20110625220409_add_locked_to_forem_topics.rb b/spec/dummy/db/migrate/20110625220409_add_locked_to_forem_topics.rb index abc1234..def5678 100644 --- a/spec/dummy/db/migrate/20110625220409_add_locked_to_forem_topics.rb +++ b/spec/dummy/db/migrate/20110625220409_add_locked_to_forem_topic...
Add default for forem_topics locked to false in spec migrations
diff --git a/Formula/changelogparser.rb b/Formula/changelogparser.rb index abc1234..def5678 100644 --- a/Formula/changelogparser.rb +++ b/Formula/changelogparser.rb @@ -6,7 +6,7 @@ url "https://github.com/lottadot/changelogparser/archive/0.1.0.tar.gz" version "0.1.0" # shasum -a 256 - sha256 "178045c5d0a960b2b...
Fix typo wrt Changelogparser 0.1.0
diff --git a/test/test_coffee_script.rb b/test/test_coffee_script.rb index abc1234..def5678 100644 --- a/test/test_coffee_script.rb +++ b/test/test_coffee_script.rb @@ -4,13 +4,13 @@ class TestCoffeeScript < Test::Unit::TestCase def test_compile - assert_equal "(function() {\n puts('Hello, World!');\n})();\n",...
Update test output for CoffeeScript 0.9.x
diff --git a/test/test_id_generation.rb b/test/test_id_generation.rb index abc1234..def5678 100644 --- a/test/test_id_generation.rb +++ b/test/test_id_generation.rb @@ -1,7 +1,7 @@ require 'test_helper' class TestIdGeneration < Test::Unit::TestCase - should "attachment IDs are UUIDs" do + should "use UUIDs for att...
Fix id generation test wording.
diff --git a/benchmarks/before.rb b/benchmarks/before.rb index abc1234..def5678 100644 --- a/benchmarks/before.rb +++ b/benchmarks/before.rb @@ -42,8 +42,8 @@ observers << MethodProfiler.observe(Example) observers << MethodProfiler.observe(Aop) observers << MethodProfiler.observe(Aop::Pointcut) - observers << ...
Fix benchmarks after moving classes
diff --git a/app/controllers/concerns/exception_handler.rb b/app/controllers/concerns/exception_handler.rb index abc1234..def5678 100644 --- a/app/controllers/concerns/exception_handler.rb +++ b/app/controllers/concerns/exception_handler.rb @@ -0,0 +1,13 @@+module ExceptionHandler + extend ActiveSupport::Concern + + ...
Create exception handler for request errors
diff --git a/spec/features/category_scopes_spec.rb b/spec/features/category_scopes_spec.rb index abc1234..def5678 100644 --- a/spec/features/category_scopes_spec.rb +++ b/spec/features/category_scopes_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' -describe 'Tracked categories', js: true do +describe 'Tracked categ...
Add feature spec for tracking a template, update broken bits
diff --git a/spec/requests/odata/root_json_spec.rb b/spec/requests/odata/root_json_spec.rb index abc1234..def5678 100644 --- a/spec/requests/odata/root_json_spec.rb +++ b/spec/requests/odata/root_json_spec.rb @@ -20,11 +20,13 @@ include_context "odata_with_forms" it "renders as expected" do + entity_1_n...
10592: Fix nondeterministic form name in spec
diff --git a/lib/acts_as_tenant/controller_extensions.rb b/lib/acts_as_tenant/controller_extensions.rb index abc1234..def5678 100644 --- a/lib/acts_as_tenant/controller_extensions.rb +++ b/lib/acts_as_tenant/controller_extensions.rb @@ -1,52 +1,48 @@ module ActsAsTenant module ControllerExtensions - extend Active...
Fix to get current_tenant working3
diff --git a/lib/administrate/field/belongs_to_search.rb b/lib/administrate/field/belongs_to_search.rb index abc1234..def5678 100644 --- a/lib/administrate/field/belongs_to_search.rb +++ b/lib/administrate/field/belongs_to_search.rb @@ -5,6 +5,8 @@ module Field class BelongsToSearch < Administrate::Field::Belong...
[Assets] Make sure assets are properly added
diff --git a/site-cookbooks/rapidftr/recipes/default.rb b/site-cookbooks/rapidftr/recipes/default.rb index abc1234..def5678 100644 --- a/site-cookbooks/rapidftr/recipes/default.rb +++ b/site-cookbooks/rapidftr/recipes/default.rb @@ -18,15 +18,14 @@ action :pull tag node.rapidftr.tag cmd_timeout 30*60 - notifie...
Use separate prod config for solr
diff --git a/spec/unit/honeybadger/backend/test_spec.rb b/spec/unit/honeybadger/backend/test_spec.rb index abc1234..def5678 100644 --- a/spec/unit/honeybadger/backend/test_spec.rb +++ b/spec/unit/honeybadger/backend/test_spec.rb @@ -15,6 +15,14 @@ it { should respond_to :notifications } + describe "#notification...
Test cached key for test backend.
diff --git a/db/migrate/20130828171743_create_bz_query_entries.rb b/db/migrate/20130828171743_create_bz_query_entries.rb index abc1234..def5678 100644 --- a/db/migrate/20130828171743_create_bz_query_entries.rb +++ b/db/migrate/20130828171743_create_bz_query_entries.rb @@ -0,0 +1,17 @@+class CreateBzQueryEntries < Activ...
Add new bz_query_entries migation file.
diff --git a/app/models/jellyfish_odl/service/server.rb b/app/models/jellyfish_odl/service/server.rb index abc1234..def5678 100644 --- a/app/models/jellyfish_odl/service/server.rb +++ b/app/models/jellyfish_odl/service/server.rb @@ -10,9 +10,10 @@ end def provision - # create key_pair name: serv...
Change status to running after provision
diff --git a/app/controllers/base_controller_decorator.rb b/app/controllers/base_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/base_controller_decorator.rb +++ b/app/controllers/base_controller_decorator.rb @@ -3,7 +3,7 @@ def save_search - keywords = @searcher.try :keywords + ...
Use “try!” instead of “try” since it’s more reliable
diff --git a/app/mailers/nopassword/no_password_emails.rb b/app/mailers/nopassword/no_password_emails.rb index abc1234..def5678 100644 --- a/app/mailers/nopassword/no_password_emails.rb +++ b/app/mailers/nopassword/no_password_emails.rb @@ -1,6 +1,6 @@ module Nopassword class NoPasswordEmails < ActionMailer::Base - ...
Use proper syntax for including helpers
diff --git a/app/presenters/dspace/community_presenter.rb b/app/presenters/dspace/community_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/dspace/community_presenter.rb +++ b/app/presenters/dspace/community_presenter.rb @@ -9,7 +9,7 @@ end def metadata_fields - @metadata_fields ||= Dspace::Met...
Change variable ref to method
diff --git a/ember_devise_simple_auth.gemspec b/ember_devise_simple_auth.gemspec index abc1234..def5678 100644 --- a/ember_devise_simple_auth.gemspec +++ b/ember_devise_simple_auth.gemspec @@ -14,7 +14,7 @@ s.description = "This gem enhances the stock Devise::SessionsController to be slightly more ajax friendly." ...
Add lib directory to gemspec
diff --git a/3/ruby/code.rb b/3/ruby/code.rb index abc1234..def5678 100644 --- a/3/ruby/code.rb +++ b/3/ruby/code.rb @@ -1,46 +1,65 @@ #!/usr/bin/env ruby -def find_factors_of_an_integer integer, array_of_factors = [] - - for i in 2..integer - if integer % i == 0 - integer = integer / i - if !array_of...
Remove whitespace in problem 3
diff --git a/cookbooks/universe_ubuntu/spec/unit/recipes/default_spec.rb b/cookbooks/universe_ubuntu/spec/unit/recipes/default_spec.rb index abc1234..def5678 100644 --- a/cookbooks/universe_ubuntu/spec/unit/recipes/default_spec.rb +++ b/cookbooks/universe_ubuntu/spec/unit/recipes/default_spec.rb @@ -9,7 +9,7 @@ describ...
Use simple quote when don't need interpolation, indentation
diff --git a/Casks/prezi.rb b/Casks/prezi.rb index abc1234..def5678 100644 --- a/Casks/prezi.rb +++ b/Casks/prezi.rb @@ -5,7 +5,7 @@ # akamaihd.net is the official download host per the vendor homepage url "https://prezi-a.akamaihd.net/desktop/Prezi#{version}.dmg" name 'Prezi' - homepage 'http://www.prezi.com/...
Fix homepage to use SSL in Prezi Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/spec/first_letters_spec.rb b/spec/first_letters_spec.rb index abc1234..def5678 100644 --- a/spec/first_letters_spec.rb +++ b/spec/first_letters_spec.rb @@ -16,4 +16,9 @@ matcher = ABCing::FirstLetters.new(['Cobra', 'Acid', 'Bee']) expect(matcher.letters).to eq(['A', 'B', 'C']) end + + it 'Retu...
Test edgecase where an empty result is returned for FirstLetters
diff --git a/script/import-customers.rb b/script/import-customers.rb index abc1234..def5678 100644 --- a/script/import-customers.rb +++ b/script/import-customers.rb @@ -0,0 +1,51 @@+# frozen_string_literal: true + +# Read customer entries in CSV format from STDIN and create those records in +# the database. Example: +#...
Add example script for importing customers