diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/unit/ldap/search_spec.rb b/spec/unit/ldap/search_spec.rb index abc1234..def5678 100644 --- a/spec/unit/ldap/search_spec.rb +++ b/spec/unit/ldap/search_spec.rb @@ -0,0 +1,30 @@+# -*- ruby encoding: utf-8 -*- + +describe Net::LDAP, "search method" do + class FakeConnection + def search(args) + ...
Add test case showing incorrect behaviour for failed searches
diff --git a/core/app/controllers/users_controller.rb b/core/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/core/app/controllers/users_controller.rb +++ b/core/app/controllers/users_controller.rb @@ -12,17 +12,17 @@ def activities respond_to do |format| + # TODO: This needs to becom...
Use @user instead of current_user
diff --git a/config/initializers/cached_settings.rb b/config/initializers/cached_settings.rb index abc1234..def5678 100644 --- a/config/initializers/cached_settings.rb +++ b/config/initializers/cached_settings.rb @@ -25,7 +25,7 @@ # Rather than getting the app name, get the root folder name so that # disc...
Use entire Rails.root since we store the app in current
diff --git a/redmine-personal_wiki_page.gemspec b/redmine-personal_wiki_page.gemspec index abc1234..def5678 100644 --- a/redmine-personal_wiki_page.gemspec +++ b/redmine-personal_wiki_page.gemspec @@ -20,6 +20,7 @@ spec.require_paths = ["lib"] spec.add_dependency "rails", "~> 4.2.0" + spec.add_dependency "redmi...
Add missing dependency to redmine-more_view_hooks
diff --git a/app/helpers/version_helper.rb b/app/helpers/version_helper.rb index abc1234..def5678 100644 --- a/app/helpers/version_helper.rb +++ b/app/helpers/version_helper.rb @@ -23,7 +23,7 @@ html << if object.persisted? link_to object.to_s, url_for_object(object) else - object.to_s if object + ...
Revert "A little failsave, which seems to be necessary in production." This reverts commit cbf06b9f85c62b726bca093d39c4a636cb6af081.
diff --git a/app/mailers/noisy_workflow.rb b/app/mailers/noisy_workflow.rb index abc1234..def5678 100644 --- a/app/mailers/noisy_workflow.rb +++ b/app/mailers/noisy_workflow.rb @@ -6,7 +6,7 @@ def make_noise(guide,action) @guide = guide @action = action - mail(:to => "dev@alphagov.co.uk", + mail(:to =...
Send notification emails to eds@
diff --git a/PeerTalk.podspec b/PeerTalk.podspec index abc1234..def5678 100644 --- a/PeerTalk.podspec +++ b/PeerTalk.podspec @@ -1,17 +1,14 @@-{ - "name": "PeerTalk", - "version": "0.0.1", - "summary": "iOS and OS X Cocoa library for communicating over USB and TCP.", - "description": " PeerTalk i...
Convert podspec to valid syntax
diff --git a/chef/roles/rubygems_db_master.rb b/chef/roles/rubygems_db_master.rb index abc1234..def5678 100644 --- a/chef/roles/rubygems_db_master.rb +++ b/chef/roles/rubygems_db_master.rb @@ -10,12 +10,18 @@ "postgresql" => { "version" => "9.2", "data_directory" => "/var/lib/pg_data", - "listen_address"...
Put pg attributes in the correct format
diff --git a/simple_backend/app/controllers/auth.rb b/simple_backend/app/controllers/auth.rb index abc1234..def5678 100644 --- a/simple_backend/app/controllers/auth.rb +++ b/simple_backend/app/controllers/auth.rb @@ -14,12 +14,6 @@ puts "made it to signup" content_type :json user = User.create(params[:user]) - ...
Delete unneeded /signout route in Sinatra
diff --git a/spec/requests/catalog_controller_spec.rb b/spec/requests/catalog_controller_spec.rb index abc1234..def5678 100644 --- a/spec/requests/catalog_controller_spec.rb +++ b/spec/requests/catalog_controller_spec.rb @@ -0,0 +1,37 @@+require "rails_helper" + +RSpec.describe CatalogController do + describe "RSS fee...
Add spec for RSS feed
diff --git a/app/models/embed_stat.rb b/app/models/embed_stat.rb index abc1234..def5678 100644 --- a/app/models/embed_stat.rb +++ b/app/models/embed_stat.rb @@ -13,7 +13,9 @@ def self.csv CSV.generate(row_sep: "\r\n") do |csv| csv << ["Dataset Name", "Dataset URL", "Referring URL", "First Detected"] - ...
Improve sql query for generating report
diff --git a/spec/features/admin/categories_spec.rb b/spec/features/admin/categories_spec.rb index abc1234..def5678 100644 --- a/spec/features/admin/categories_spec.rb +++ b/spec/features/admin/categories_spec.rb @@ -22,7 +22,23 @@ click_button "Create axis" + expect(page).to have_content "Category created s...
Add test for editing an existing category
diff --git a/spec/features/teams/ad_members_spec.rb b/spec/features/teams/ad_members_spec.rb index abc1234..def5678 100644 --- a/spec/features/teams/ad_members_spec.rb +++ b/spec/features/teams/ad_members_spec.rb @@ -0,0 +1,54 @@+require 'spec_helper.rb' + +feature 'Adding and removing member of a team', js: true do + ...
Add team add and delete member feature spec
diff --git a/hexp.gemspec b/hexp.gemspec index abc1234..def5678 100644 --- a/hexp.gemspec +++ b/hexp.gemspec @@ -10,16 +10,18 @@ gem.description = 'HTML expressions' gem.summary = gem.description gem.homepage = 'https://github.com/plexus/hexp' + gem.license = 'MIT' gem.require_paths = %w[lib...
Add license to gemspec, update dependencies
diff --git a/spec/reports/signatures_report_spec.rb b/spec/reports/signatures_report_spec.rb index abc1234..def5678 100644 --- a/spec/reports/signatures_report_spec.rb +++ b/spec/reports/signatures_report_spec.rb @@ -13,6 +13,7 @@ end it 'generates CSV' do + # Create a shift inside our weekly report period ...
Add comment on factory call [skip ci]
diff --git a/examples/roundtrip.rb b/examples/roundtrip.rb index abc1234..def5678 100644 --- a/examples/roundtrip.rb +++ b/examples/roundtrip.rb @@ -28,7 +28,7 @@ puts("Plaintext:\n#{plain}") # Perform symmetric encryption on PLAIN. -cipher = GPGME::encrypt(nil, plain, {:armor => true +cipher = GPGME::encrypt(nil, p...
Add extra "," before :passphrase_callback.
diff --git a/hkdf.gemspec b/hkdf.gemspec index abc1234..def5678 100644 --- a/hkdf.gemspec +++ b/hkdf.gemspec @@ -4,6 +4,7 @@ s.authors = ['John Downey'] s.email = ['jdowney@gmail.com'] s.homepage = 'http://github.com/jtdowney/hkdf' + s.license = 'MIT' s.summary = %q{HMAC-based Key Deriv...
Add MIT license to gemspec
diff --git a/test/cookbooks/test/recipes/default.rb b/test/cookbooks/test/recipes/default.rb index abc1234..def5678 100644 --- a/test/cookbooks/test/recipes/default.rb +++ b/test/cookbooks/test/recipes/default.rb @@ -14,5 +14,5 @@ extend Apache2::Cookbook::Helpers service_name lazy { apache_platform_service_name }...
Add start action to the apache2 resource
diff --git a/test/validator/schema_validation_helpers.rb b/test/validator/schema_validation_helpers.rb index abc1234..def5678 100644 --- a/test/validator/schema_validation_helpers.rb +++ b/test/validator/schema_validation_helpers.rb @@ -22,8 +22,11 @@ end def generate_schema - @id ||= 0 - @id += 1 - { '...
Rework generation of test schema ids
diff --git a/MNTPullToReact.podspec b/MNTPullToReact.podspec index abc1234..def5678 100644 --- a/MNTPullToReact.podspec +++ b/MNTPullToReact.podspec @@ -1,11 +1,3 @@-# -# Be sure to run `pod spec lint MNTPullToReact.podspec' to ensure this is a -# valid spec and to remove all comments including this before submitting...
Remove comments in the podspec
diff --git a/db/migrate/20161031154415_remove_redirect_capital_funding_guide.rb b/db/migrate/20161031154415_remove_redirect_capital_funding_guide.rb index abc1234..def5678 100644 --- a/db/migrate/20161031154415_remove_redirect_capital_funding_guide.rb +++ b/db/migrate/20161031154415_remove_redirect_capital_funding_guid...
Remove the bad draft in our migration As well as removing the old capital-funding-guide manual and reslugging the new one, we also want to remove an bad draft that has no title. We use the existing CliManualDeleter for this purpose, and pass in a StringIO with a "y" in it to get around the required keyboard input.
diff --git a/Casks/perma.rb b/Casks/perma.rb index abc1234..def5678 100644 --- a/Casks/perma.rb +++ b/Casks/perma.rb @@ -2,7 +2,7 @@ version '1.0.0' sha256 '7987bacb6852d9874d899beefed84f0f2dcbbbb2893e481a607a623c994eb62a' - # http://perma-dl.s3.amazonaws.com twas verified as official when first introduced to t...
Fix `url` stanza comment for Perma.
diff --git a/spec/classes/ironic_client_spec.rb b/spec/classes/ironic_client_spec.rb index abc1234..def5678 100644 --- a/spec/classes/ironic_client_spec.rb +++ b/spec/classes/ironic_client_spec.rb @@ -22,6 +22,20 @@ describe 'ironic::client' do + shared_examples_for 'ironic client' do + + it { is_expected.to co...
Fix unit test for ironic::client class Change-Id: Ibe49da4ba431e01822a18f5929dfa32d2544dab0
diff --git a/spec/nql/dependency_tables_spec.rb b/spec/nql/dependency_tables_spec.rb index abc1234..def5678 100644 --- a/spec/nql/dependency_tables_spec.rb +++ b/spec/nql/dependency_tables_spec.rb @@ -21,7 +21,7 @@ end it 'must have multiple dependency tables' do - tree = parse 'a.b.c = 1 & d.e: 2 | f.g.h = 1...
Test using parenthesis in dependency tables spec
diff --git a/interview-cake/apple_stock.rb b/interview-cake/apple_stock.rb index abc1234..def5678 100644 --- a/interview-cake/apple_stock.rb +++ b/interview-cake/apple_stock.rb @@ -0,0 +1,60 @@+# Writing programming interview questions hasn't made me rich. Maybe trading Apple stocks will. +# Suppose we could access yes...
Write both n^2 and n time solution for Apple Stocks question
diff --git a/Framer.podspec b/Framer.podspec index abc1234..def5678 100644 --- a/Framer.podspec +++ b/Framer.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'Framer' - s.version = '1.4.2' + s.version = '1.4.3' s.summary = 'Comfortable syntax for working with frames' ...
Change pod spev version -> 1.4.3
diff --git a/railties/lib/rails/commands/application.rb b/railties/lib/rails/commands/application.rb index abc1234..def5678 100644 --- a/railties/lib/rails/commands/application.rb +++ b/railties/lib/rails/commands/application.rb @@ -15,4 +15,16 @@ require 'rails/generators' require 'rails/generators/rails/app/app_gene...
Use Thor's self.exit_on_failure? to exit whenever accessing the generators from the CLI and a Thor::Error is raised.
diff --git a/db/migrate/20200601185920_add_external_id_to_gp_charges.rb b/db/migrate/20200601185920_add_external_id_to_gp_charges.rb index abc1234..def5678 100644 --- a/db/migrate/20200601185920_add_external_id_to_gp_charges.rb +++ b/db/migrate/20200601185920_add_external_id_to_gp_charges.rb @@ -0,0 +1,7 @@+# frozen_st...
Add migration to include external_id in charges
diff --git a/lib/action_mailer_queue.rb b/lib/action_mailer_queue.rb index abc1234..def5678 100644 --- a/lib/action_mailer_queue.rb +++ b/lib/action_mailer_queue.rb @@ -1,4 +1,8 @@+require "mail" require "mail/active_record" + +require "action_mailer" + require "action_mailer_queue/mailer" require "action_mailer_que...
Add more specific require statements.
diff --git a/lib/comma/render_as_csv.rb b/lib/comma/render_as_csv.rb index abc1234..def5678 100644 --- a/lib/comma/render_as_csv.rb +++ b/lib/comma/render_as_csv.rb @@ -4,7 +4,7 @@ end def render_with_csv(options = nil, extra_options = {}, &block) - return render_without_csv(options, extra_options, &block) un...
Fix for csv options being present
diff --git a/lib/hawk/model/querying.rb b/lib/hawk/model/querying.rb index abc1234..def5678 100644 --- a/lib/hawk/model/querying.rb +++ b/lib/hawk/model/querying.rb @@ -46,6 +46,14 @@ where(offset: n) end + def order(by) + where(order: by) + end + + def includes(what) ...
Add order and includes finders through query string params
diff --git a/Library/Contributions/examples/brew-audit.rb b/Library/Contributions/examples/brew-audit.rb index abc1234..def5678 100644 --- a/Library/Contributions/examples/brew-audit.rb +++ b/Library/Contributions/examples/brew-audit.rb @@ -26,6 +26,11 @@ problems << " * Remove 'use_mirror' from url." end + #...
Add depends_on spacing checks to brew_audit
diff --git a/lib/opal/haml/processor.rb b/lib/opal/haml/processor.rb index abc1234..def5678 100644 --- a/lib/opal/haml/processor.rb +++ b/lib/opal/haml/processor.rb @@ -4,6 +4,8 @@ module Opal module Haml class Processor < ::Opal::Processor + self.default_mime_type = 'application/javascript' + def e...
Set app/js as the default mime type As the class ivar value is not inherited. fixes #5 (hopefully)
diff --git a/lib/rack_request_helper.rb b/lib/rack_request_helper.rb index abc1234..def5678 100644 --- a/lib/rack_request_helper.rb +++ b/lib/rack_request_helper.rb @@ -30,6 +30,7 @@ end end + # for Cloudflare behind proxy def cf_connecting_ip @env["HTTP_CF_CONNECTING_IP"] end
Fix fecthing wrong ip address behind Cloudflare
diff --git a/lib/sass/rails/template.rb b/lib/sass/rails/template.rb index abc1234..def5678 100644 --- a/lib/sass/rails/template.rb +++ b/lib/sass/rails/template.rb @@ -3,6 +3,9 @@ module Sass module Rails class SassTemplate < Sprockets::SassTemplate + def self.default_mime_type + 'text/css' + ...
Add a default mime extension for .sass files
diff --git a/bower2gem.gemspec b/bower2gem.gemspec index abc1234..def5678 100644 --- a/bower2gem.gemspec +++ b/bower2gem.gemspec @@ -9,18 +9,9 @@ spec.authors = ["Sean Collins"] spec.email = ["sean@cllns.com"] - spec.summary = %q{TODO: Write a short summary, because Rubygems requires one.} -...
Update Gemspec, so it can be built
diff --git a/lib/statue/backends/udp.rb b/lib/statue/backends/udp.rb index abc1234..def5678 100644 --- a/lib/statue/backends/udp.rb +++ b/lib/statue/backends/udp.rb @@ -2,10 +2,11 @@ module Statue class UDPBackend - attr_reader :address + attr_reader :host, :port def initialize(host = nil, port = nil)...
Change UDPBackned to be compatible with jruby.
diff --git a/lib/unpoly/rails/engine.rb b/lib/unpoly/rails/engine.rb index abc1234..def5678 100644 --- a/lib/unpoly/rails/engine.rb +++ b/lib/unpoly/rails/engine.rb @@ -2,25 +2,31 @@ module Rails class Engine < ::Rails::Engine initializer 'unpoly-rails.assets' do |app| - # The gem package has a dis...
Fix a bug where unpoly-rails would crash when loaded by a Rails app that has completely removed the asset pipeline
diff --git a/config/initializers/apipie.rb b/config/initializers/apipie.rb index abc1234..def5678 100644 --- a/config/initializers/apipie.rb +++ b/config/initializers/apipie.rb @@ -2,7 +2,7 @@ config.app_name = "popHealth" config.api_base_url = "/api" config.doc_base_url = "...
Update api version from 3.0 to 5.0 so as not to confuse users
diff --git a/lib/dooby.rb b/lib/dooby.rb index abc1234..def5678 100644 --- a/lib/dooby.rb +++ b/lib/dooby.rb @@ -3,9 +3,13 @@ #dependencies require 'fileutils' require 'digest/sha1' + +require 'redline' +gem 'colored', '1.2' require 'colored' -require 'redline' +gem 'highline', '1.6.1' require 'highline/imp...
Load explicit version of the gems if we need explicit version of the gems
diff --git a/test/routing/topic_namespacing_test.rb b/test/routing/topic_namespacing_test.rb index abc1234..def5678 100644 --- a/test/routing/topic_namespacing_test.rb +++ b/test/routing/topic_namespacing_test.rb @@ -0,0 +1,65 @@+require 'test_helper' + +class TopicRoutingTest < ActionDispatch::IntegrationTest + it "r...
Add tests for namespaced routing
diff --git a/lib/asset_hosting_with_minimum_ssl.rb b/lib/asset_hosting_with_minimum_ssl.rb index abc1234..def5678 100644 --- a/lib/asset_hosting_with_minimum_ssl.rb +++ b/lib/asset_hosting_with_minimum_ssl.rb @@ -6,7 +6,7 @@ end def call(source, request) - if request.ssl? + if request && request.ssl? ...
Support calling with a false request object.
diff --git a/lib/fund_america/selling_agreement.rb b/lib/fund_america/selling_agreement.rb index abc1234..def5678 100644 --- a/lib/fund_america/selling_agreement.rb +++ b/lib/fund_america/selling_agreement.rb @@ -0,0 +1,21 @@+module FundAmerica + class SellingAgreement + class << self + + # End point: https://...
Add Selling Agreement API points
diff --git a/pragma-rails.gemspec b/pragma-rails.gemspec index abc1234..def5678 100644 --- a/pragma-rails.gemspec +++ b/pragma-rails.gemspec @@ -20,6 +20,9 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ['lib'] + spec.add_dependency 'pragma', '~> 0.1.0' + spec....
Add Pragma and Rails dependencies
diff --git a/lib/yummydata/criteria/last_update.rb b/lib/yummydata/criteria/last_update.rb index abc1234..def5678 100644 --- a/lib/yummydata/criteria/last_update.rb +++ b/lib/yummydata/criteria/last_update.rb @@ -4,36 +4,64 @@ module Criteria module LastUpdate - - include Yummydata::Criteria::ServiceDes...
Add the functions that return count of statements and first of statement and arbitrary position of statement
diff --git a/netfox.podspec b/netfox.podspec index abc1234..def5678 100644 --- a/netfox.podspec +++ b/netfox.podspec @@ -14,6 +14,7 @@ s.source = { :git => "https://github.com/kasketis/netfox.git", :tag => '1.7.2' } s.platform = :ios, '8.0' + s.platform = :osx, '10.0' s.requires_arc = true ...
Update podspec to support OS X
diff --git a/lib/chef/knife/cloudformation_inspect.rb b/lib/chef/knife/cloudformation_inspect.rb index abc1234..def5678 100644 --- a/lib/chef/knife/cloudformation_inspect.rb +++ b/lib/chef/knife/cloudformation_inspect.rb @@ -22,8 +22,17 @@ stack = provider.stacks.get(stack_name) if(config[:attribute]) ...
Allow some ruby-isms within attribute to allow deep stack inspection
diff --git a/jruby-http-kit.gemspec b/jruby-http-kit.gemspec index abc1234..def5678 100644 --- a/jruby-http-kit.gemspec +++ b/jruby-http-kit.gemspec @@ -20,6 +20,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "rack" spec.add_d...
Add rack as development dependency
diff --git a/site-cookbooks/backup_restore/spec/recipes/configure_mysql_spec.rb b/site-cookbooks/backup_restore/spec/recipes/configure_mysql_spec.rb index abc1234..def5678 100644 --- a/site-cookbooks/backup_restore/spec/recipes/configure_mysql_spec.rb +++ b/site-cookbooks/backup_restore/spec/recipes/configure_mysql_spe...
Add chef-spec for configuire_mysql recipe
diff --git a/app/models/role.rb b/app/models/role.rb index abc1234..def5678 100644 --- a/app/models/role.rb +++ b/app/models/role.rb @@ -1,21 +1,29 @@ class Role < ActiveRecord::Base - ADMIN = 'admin' - CONVENOR = 'convenor' - TUTOR = 'tutor' - STUDENT = 'student' + + def self.student + Role.find(student_id) + end ...
Change Role to use functions instead of scope queries
diff --git a/app/models/stop.rb b/app/models/stop.rb index abc1234..def5678 100644 --- a/app/models/stop.rb +++ b/app/models/stop.rb @@ -22,7 +22,15 @@ end def self.near(location) - Stop.geo_near(location).max_distance(0.01) + if DateTime.now.wday == 0 + service_id = 2 + elsif Datetime.now.wday == ...
Add narrowing functionality to api
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,4 +2,12 @@ acts_as_authentic do |c| c.login_field = 'email' end + + def generate_authentication_token + token = loop do + t = SecureRandom.base64.tr('+/=', 'Qrt')...
Allow single access token requests for GET
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -4,6 +4,11 @@ devise :database_authenticatable, :registerable, :recoverable, :rememberable, :trackable, :validatable, :omniauthable, :omniauth_providers => [:face...
Add activerecord relationship and validations
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,6 +1,5 @@ class User < ActiveRecord::Base # Include default devise modules. Others available are: # :confirmable, :lockable, :timeoutable and :omniauthable - devise :database...
User: Remove registerable, trackable, and rememberable
diff --git a/lib/active_set/adapter_activerecord.rb b/lib/active_set/adapter_activerecord.rb index abc1234..def5678 100644 --- a/lib/active_set/adapter_activerecord.rb +++ b/lib/active_set/adapter_activerecord.rb @@ -6,8 +6,17 @@ class Adapter::ActiveRecord < Adapter::Base private - def can_process_with_act...
Add some ActiveRecord adapter common methods for working with scopes and properly eager loading associations
diff --git a/clock.gemspec b/clock.gemspec index abc1234..def5678 100644 --- a/clock.gemspec +++ b/clock.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'clock' s.summary = 'Clock interface with support for dependency configuration for real and null object implementations' - s.version = '0.0.3.0' ...
Package version is increased from 0.0.3.0 to 0.0.3.1
diff --git a/spec/features/term_recap_emails_spec.rb b/spec/features/term_recap_emails_spec.rb index abc1234..def5678 100644 --- a/spec/features/term_recap_emails_spec.rb +++ b/spec/features/term_recap_emails_spec.rb @@ -0,0 +1,22 @@+# frozen_string_literal: true + +require 'rails_helper' + +describe 'term recap emails...
Add basic spec coverage for Term Recap Emails
diff --git a/lib/feed2email/lazy_smtp_connection.rb b/lib/feed2email/lazy_smtp_connection.rb index abc1234..def5678 100644 --- a/lib/feed2email/lazy_smtp_connection.rb +++ b/lib/feed2email/lazy_smtp_connection.rb @@ -1,10 +1,9 @@ require 'net/smtp' +require 'feed2email/configurable' module Feed2Email class LazySM...
Use Configurable module in LazySMTPConnection
diff --git a/lib/jekyll/assets_plugin/site_patch.rb b/lib/jekyll/assets_plugin/site_patch.rb index abc1234..def5678 100644 --- a/lib/jekyll/assets_plugin/site_patch.rb +++ b/lib/jekyll/assets_plugin/site_patch.rb @@ -26,15 +26,15 @@ @assets.css_compressor = assets_config.css_compressor # bind je...
Fix name of jekyll site getter
diff --git a/recipes/configure.rb b/recipes/configure.rb index abc1234..def5678 100644 --- a/recipes/configure.rb +++ b/recipes/configure.rb @@ -3,7 +3,7 @@ user "root" cwd "/tmp" code <<-EOH - sed -i 's|LS_HEAP_SIZE="500m"|LS_HEAP_SIZE="<%= node[:logstash][:javaheap] %>"|' /etc/init/logstash + sed -i 's|LS_HEA...
Change the java heap from 500m to 2g
diff --git a/lib/quickbooks/service/access_token.rb b/lib/quickbooks/service/access_token.rb index abc1234..def5678 100644 --- a/lib/quickbooks/service/access_token.rb +++ b/lib/quickbooks/service/access_token.rb @@ -12,7 +12,7 @@ if response code = response.code.to_i if code == 200 - ...
Use respons.plain_body in AccessToken Service
diff --git a/lib/rspec_api_documentation/railtie.rb b/lib/rspec_api_documentation/railtie.rb index abc1234..def5678 100644 --- a/lib/rspec_api_documentation/railtie.rb +++ b/lib/rspec_api_documentation/railtie.rb @@ -1,7 +1,7 @@ module RspecApiDocumentation class Railtie < Rails::Railtie rake_tasks do - lo...
Use direct path to rake file Before this, we were relying on the Gem's `lib` dir being on the $LOAD_PATH, and thus `load` would find the `tasks/doc.rake` file. This can break when a different gem also has a `tasks/docs.rake` file, and it's further up in the load path. Same goes for a Rails app with a `tasks/docs.rake`...
diff --git a/lib/rubocop/cop/mixin/unused_argument.rb b/lib/rubocop/cop/mixin/unused_argument.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/mixin/unused_argument.rb +++ b/lib/rubocop/cop/mixin/unused_argument.rb @@ -7,13 +7,6 @@ module UnusedArgument def join_force?(force_class) force...
Correct with source location info rather than regexp in UnusedArgument
diff --git a/lib/wrapper/resources/search_result.rb b/lib/wrapper/resources/search_result.rb index abc1234..def5678 100644 --- a/lib/wrapper/resources/search_result.rb +++ b/lib/wrapper/resources/search_result.rb @@ -11,6 +11,7 @@ :title, :uri, :anv, - :s...
Add thumb accessor to search results model
diff --git a/test/unit/donation_test.rb b/test/unit/donation_test.rb index abc1234..def5678 100644 --- a/test/unit/donation_test.rb +++ b/test/unit/donation_test.rb @@ -1,7 +1,9 @@ require 'test_helper' class DonationTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end + test "donatio...
Test Donation generates Gravatar URL Using app settings for the url format
diff --git a/spec/acceptance/alternative_pgdata_spec.rb b/spec/acceptance/alternative_pgdata_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/alternative_pgdata_spec.rb +++ b/spec/acceptance/alternative_pgdata_spec.rb @@ -0,0 +1,24 @@+require 'spec_helper_acceptance' + +# These tests ensure that postgres can...
Create acceptance test for pgdata
diff --git a/spec/ruby/1.8/library/matrix/clone_spec.rb b/spec/ruby/1.8/library/matrix/clone_spec.rb index abc1234..def5678 100644 --- a/spec/ruby/1.8/library/matrix/clone_spec.rb +++ b/spec/ruby/1.8/library/matrix/clone_spec.rb @@ -14,8 +14,8 @@ b.class.should == Matrix b.should == @a b.should_not === @a...
Use size functions instead of constants. Signed-off-by: Federico Builes <4398fca13d724d48186a783e21c40201bb8cf2d7@gmail.com>
diff --git a/spec/metadata/shared_link_spec.rb b/spec/metadata/shared_link_spec.rb index abc1234..def5678 100644 --- a/spec/metadata/shared_link_spec.rb +++ b/spec/metadata/shared_link_spec.rb @@ -10,7 +10,7 @@ it "works with a hash URL" do url = "http://www.dropbox.com/my/cats/name/s/mittens" - share...
Use old style hash syntax Just in case someone is using this library with an old Ruby version.
diff --git a/spec/models/study_content_spec.rb b/spec/models/study_content_spec.rb index abc1234..def5678 100644 --- a/spec/models/study_content_spec.rb +++ b/spec/models/study_content_spec.rb @@ -10,10 +10,9 @@ end context 'when patient data section does not exist' do - it 'should return nil' do + it 'sho...
Clean up empty field test
diff --git a/app/controllers/api/v1/symbols_controller.rb b/app/controllers/api/v1/symbols_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/symbols_controller.rb +++ b/app/controllers/api/v1/symbols_controller.rb @@ -1,7 +1,10 @@ class Api::V1::SymbolsController < Api::V1::Base inherit_resour...
Allow the API SymbolsController to belong to a sentence.
diff --git a/lib/catissue/domain/participant/clinical/treatment_regimen.rb b/lib/catissue/domain/participant/clinical/treatment_regimen.rb index abc1234..def5678 100644 --- a/lib/catissue/domain/participant/clinical/treatment_regimen.rb +++ b/lib/catissue/domain/participant/clinical/treatment_regimen.rb @@ -0,0 +1,13 @...
Remove bogus caTissue treatment_order property.
diff --git a/Futility.podspec b/Futility.podspec index abc1234..def5678 100644 --- a/Futility.podspec +++ b/Futility.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "Futility" - s.version = "1.0.4" + s.version = "1.1" s.summary = "Some reusable iOS goodness, brought to you by Futuri...
Update podspec for version 1.1
diff --git a/app/controllers/api/sign_ups_controller.rb b/app/controllers/api/sign_ups_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/sign_ups_controller.rb +++ b/app/controllers/api/sign_ups_controller.rb @@ -1,6 +1,12 @@ module Api class SignUpsController < BaseController skip_before_ac...
Fix api sign ups controller
diff --git a/app/controllers/es_hero/home_controller.rb b/app/controllers/es_hero/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/es_hero/home_controller.rb +++ b/app/controllers/es_hero/home_controller.rb @@ -2,7 +2,7 @@ class HomeController < ActionController::Base layout false - pr...
Set with: exception (no existing issue since only get requests)
diff --git a/app/controllers/static_pages_controller.rb b/app/controllers/static_pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/static_pages_controller.rb +++ b/app/controllers/static_pages_controller.rb @@ -1,5 +1,5 @@ class StaticPagesController < ApplicationController - caches_page :accessi...
Remove faq from list of static pages to cache
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,4 +2,12 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want ...
Add 'name' to strong parameters for Devise Since strong parameters are handled in the controllers in Rails 4, devise needs to be told to allow the 'name' field in the user registration form to be passed to the model for record creation. If this isn't done, the field may be filled in by the user but the parameter won't...
diff --git a/app/workers/feed_eater_schedule_worker.rb b/app/workers/feed_eater_schedule_worker.rb index abc1234..def5678 100644 --- a/app/workers/feed_eater_schedule_worker.rb +++ b/app/workers/feed_eater_schedule_worker.rb @@ -1,11 +1,11 @@ require 'gtfsgraph' class FeedEaterScheduleWorker < FeedEaterWorker - def...
Add feed_import_id to FESW job; Create and update FeedScheduleImport log record
diff --git a/muxr.gemspec b/muxr.gemspec index abc1234..def5678 100644 --- a/muxr.gemspec +++ b/muxr.gemspec @@ -8,8 +8,8 @@ gem.version = Muxr::VERSION gem.authors = ["Yehuda Katz"] gem.email = ["wycats@gmail.com"] - gem.description = %q{TODO: Write a gem description} - gem.summary ...
Add summary/description to the gemspec.
diff --git a/lib/bittrex/client.rb b/lib/bittrex/client.rb index abc1234..def5678 100644 --- a/lib/bittrex/client.rb +++ b/lib/bittrex/client.rb @@ -1,5 +1,6 @@ require 'faraday' require 'base64' +require 'json' module Bittrex class Client
Add missing require 'json' to Client
diff --git a/lib/chaplin/server.rb b/lib/chaplin/server.rb index abc1234..def5678 100644 --- a/lib/chaplin/server.rb +++ b/lib/chaplin/server.rb @@ -7,6 +7,8 @@ def self.setup(project_path) set :public_folder, project_path + '/public' + set :static_cache_control, [:public, :max_age => 300] + se...
Set cache control for static files
diff --git a/db/migrate/20140703161500_migrate_bsf_locations_to_areas.rb b/db/migrate/20140703161500_migrate_bsf_locations_to_areas.rb index abc1234..def5678 100644 --- a/db/migrate/20140703161500_migrate_bsf_locations_to_areas.rb +++ b/db/migrate/20140703161500_migrate_bsf_locations_to_areas.rb @@ -0,0 +1,11 @@+class ...
Migrate locations to Mapit areas. Finds the regional Mapit area identifiers for business support locations and populates the areas array with them.
diff --git a/lib/dnsimple/error.rb b/lib/dnsimple/error.rb index abc1234..def5678 100644 --- a/lib/dnsimple/error.rb +++ b/lib/dnsimple/error.rb @@ -9,8 +9,19 @@ def initialize(http_response) @http_response = http_response - super(http_response.parsed_response["message"]) + super(message_from(htt...
Use code as message for non JSON responses
diff --git a/nyny.gemspec b/nyny.gemspec index abc1234..def5678 100644 --- a/nyny.gemspec +++ b/nyny.gemspec @@ -23,4 +23,5 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" spec.add_development_dependency "rspec" + spec.add_development_dependency "ruby-prof" end
Add ruby-prof as dev dependency
diff --git a/lib/html_processor.rb b/lib/html_processor.rb index abc1234..def5678 100644 --- a/lib/html_processor.rb +++ b/lib/html_processor.rb @@ -10,6 +10,7 @@ ACTION_FORM = '//form[@class="action-form"]'.freeze DATATABLE_DEFAULT = '//table[contains(@class, "datatable-default")]'.freeze INTRO_IMG ...
Add xpath targeting the intro paragraph.
diff --git a/openshift.rb b/openshift.rb index abc1234..def5678 100644 --- a/openshift.rb +++ b/openshift.rb @@ -7,7 +7,7 @@ depends_on "go" => :build def install - output_dir = "_output/local/go/bin" + output_dir = "_output/local/bin/darwin/amd64/" system "make", "all", "WHAT=cmd/openshift", "GOFLA...
Update path to binary files
diff --git a/tools/scripts/mosaic/log_to_mux.rb b/tools/scripts/mosaic/log_to_mux.rb index abc1234..def5678 100644 --- a/tools/scripts/mosaic/log_to_mux.rb +++ b/tools/scripts/mosaic/log_to_mux.rb @@ -0,0 +1,35 @@+def main() + if ARGF.argv.empty? + puts "#{$PROGRAM_NAME} <log_file>" + return 1 + end + + logfil...
Add script to to parse generation logs
diff --git a/lib/json_serializer.rb b/lib/json_serializer.rb index abc1234..def5678 100644 --- a/lib/json_serializer.rb +++ b/lib/json_serializer.rb @@ -38,8 +38,8 @@ def serializable_object return nil unless @object - if object.kind_of?(Enumerable) - object.to_a.map { |item| self.class.new(item).to_ha...
Use instance variable instead of accessor method.
diff --git a/lib/fog/storm_on_demand.rb b/lib/fog/storm_on_demand.rb index abc1234..def5678 100644 --- a/lib/fog/storm_on_demand.rb +++ b/lib/fog/storm_on_demand.rb @@ -11,6 +11,7 @@ service(:billing, 'storm_on_demand/billing', 'Billing') service(:monitoring, 'storm_on_demand/monitoring', 'Monitoring') se...
[stormondemand|account] Add Account service to the service lsit
diff --git a/lib/metrics/updater.rb b/lib/metrics/updater.rb index abc1234..def5678 100644 --- a/lib/metrics/updater.rb +++ b/lib/metrics/updater.rb @@ -10,8 +10,12 @@ end def self.run_child_process - puts 'Metrics updating process started.' @child_id = fork do + + # Reconnect the database...
[Updater] Reconnect to DB after forking.
diff --git a/lib/spree_fishbowl.rb b/lib/spree_fishbowl.rb index abc1234..def5678 100644 --- a/lib/spree_fishbowl.rb +++ b/lib/spree_fishbowl.rb @@ -2,19 +2,13 @@ require 'spree_fishbowl/engine' module SpreeFishbowl - - @@fishbowl = nil - - def self.connection - @@fishbowl - end def self.enabled? Spr...
Simplify Fishbowl connections - no more long-running socket connections
diff --git a/lib/neo4j_dev_rails.rb b/lib/neo4j_dev_rails.rb index abc1234..def5678 100644 --- a/lib/neo4j_dev_rails.rb +++ b/lib/neo4j_dev_rails.rb @@ -4,7 +4,7 @@ module Neo4jDevRails require File.expand_path('../neo4j_dev_rails/railtie', __FILE__) if defined?(Rails) - def clean_neo4j + def self.clean_neo4j ...
Make clean_neo4j a Module method, not ment to be mixed in
diff --git a/lib/kippt_simple/client.rb b/lib/kippt_simple/client.rb index abc1234..def5678 100644 --- a/lib/kippt_simple/client.rb +++ b/lib/kippt_simple/client.rb @@ -7,8 +7,8 @@ attr_reader :username, :token def initialize args - raise ArgumentError.new('Username and token required') if args[:usernam...
Raise better error message when username or token is empty.
diff --git a/lib/ordinalize_full.rb b/lib/ordinalize_full.rb index abc1234..def5678 100644 --- a/lib/ordinalize_full.rb +++ b/lib/ordinalize_full.rb @@ -7,8 +7,13 @@ in_full ? ordinalize_in_full : ordinalize_in_short end + alias_method :ordinalize_full, \ def ordinalize_in_full - I18n.t("ordinalize_full...
Raise NotImplementedError for unsupported locales
diff --git a/lib/tasks/cruise.rake b/lib/tasks/cruise.rake index abc1234..def5678 100644 --- a/lib/tasks/cruise.rake +++ b/lib/tasks/cruise.rake @@ -8,7 +8,11 @@ exit_status = $?.exitstatus puts "Stopping virtual display..." `sh -e /etc/init.d/xvfb stop` + puts "Cleaning up..." + FileUtils.rm_rf("#{...
Clean up the public/uploads folder after ci runs.
diff --git a/lib/peddler/request.rb b/lib/peddler/request.rb index abc1234..def5678 100644 --- a/lib/peddler/request.rb +++ b/lib/peddler/request.rb @@ -4,9 +4,9 @@ module Peddler class Request - attr :client, :headers, :last_response + attr :client, :headers - attr_accessor :body + attr_accessor :bo...
Add setter to last_response to fix broken test
diff --git a/lib/license_auto/logger.rb b/lib/license_auto/logger.rb index abc1234..def5678 100644 --- a/lib/license_auto/logger.rb +++ b/lib/license_auto/logger.rb @@ -1,5 +1,6 @@ require 'log4r' require 'license_auto/config/config' +require 'log4r/outputter/datefileoutputter' module LicenseAuto def self.logger...
Modify LUTO to AUTO from config
diff --git a/lib/commands/place_command.rb b/lib/commands/place_command.rb index abc1234..def5678 100644 --- a/lib/commands/place_command.rb +++ b/lib/commands/place_command.rb @@ -1,12 +1,12 @@ class PlaceCommand def initialize(x, y, direction) - @x = x - @y = y + @x = x.to_i + @y = y.to_i @directi...
Initialize PlaceCommand with an integer instead of string
diff --git a/lib/redcloth_filter.rb b/lib/redcloth_filter.rb index abc1234..def5678 100644 --- a/lib/redcloth_filter.rb +++ b/lib/redcloth_filter.rb @@ -4,18 +4,27 @@ include ActionView::Helpers::UrlHelper def initialize(text) - @smilies = JSON.parse(Rails.cache.read('smilies_list')) || [] @text = smiliz...
Fix textilize when smilies are empty Signed-off-by: chatgris <f9469d12bf3d131e7aae80be27ccfe58aa9db1f1@af83.com>
diff --git a/lib/sermepa_web_tpv.rb b/lib/sermepa_web_tpv.rb index abc1234..def5678 100644 --- a/lib/sermepa_web_tpv.rb +++ b/lib/sermepa_web_tpv.rb @@ -1,4 +1,4 @@-require 'active_support' +require 'active_support/core_ext/module/attribute_accessors' module SermepaWebTpv mattr_accessor :transaction_model_transac...
Load attribute accessors module only
diff --git a/recipes/github_ssh_keys.rb b/recipes/github_ssh_keys.rb index abc1234..def5678 100644 --- a/recipes/github_ssh_keys.rb +++ b/recipes/github_ssh_keys.rb @@ -9,8 +9,14 @@ user WS_USER end +execute "make sure .ssh/config is owned by the user" do + only_if "test -e #{WS_HOME}/.ssh/config" + command "cho...
Correct ownership of ~/.ssh/config if it is wrong. Make sure when github is added to the config it creates the file as the user not root