diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/compare.rb b/lib/compare.rb index abc1234..def5678 100644 --- a/lib/compare.rb +++ b/lib/compare.rb @@ -1,46 +1,35 @@-@code = 'BYYY' +@code = %w(R R B B) -@guess = 'RGGG' +@guess = 'BGRB' -def match? - @code == @guess +def color_and_postion?(color, position) + color == @code[position] end -def...
Refactor logic for comparison of guess * Use hash to hold black / white pegs(results) * Compare with #each_with_index for color, position
diff --git a/app/models/contact.rb b/app/models/contact.rb index abc1234..def5678 100644 --- a/app/models/contact.rb +++ b/app/models/contact.rb @@ -4,8 +4,6 @@ validates :email, :format => {:with => /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i} validates :order_number, :format => {:with => /(^$)|(^R\d{9}$)/i, :m...
Replace topic method with association
diff --git a/mustermann/mustermann.gemspec b/mustermann/mustermann.gemspec index abc1234..def5678 100644 --- a/mustermann/mustermann.gemspec +++ b/mustermann/mustermann.gemspec @@ -7,8 +7,8 @@ s.authors = ["Konstantin Haase", "Zachary Scott"] s.email = "sinatrarb@googlegroups.com" ...
Update summary and description in gemspec file.
diff --git a/frag.gemspec b/frag.gemspec index abc1234..def5678 100644 --- a/frag.gemspec +++ b/frag.gemspec @@ -8,7 +8,7 @@ gem.authors = ['George Ogata'] gem.email = ['george.ogata@gmail.com'] gem.license = 'MIT' - gem.summary = "Generate regions of files from the output of shell co...
Make gem summary match Github project.
diff --git a/ci_environment/perlbrew/attributes/multi.rb b/ci_environment/perlbrew/attributes/multi.rb index abc1234..def5678 100644 --- a/ci_environment/perlbrew/attributes/multi.rb +++ b/ci_environment/perlbrew/attributes/multi.rb @@ -7,5 +7,5 @@ { :name => "5.12", :version => "perl-5.12.5" }, ...
Revert "updated the preinstalled perl modules" Looks like the issue is fixed! https://github.com/travis-ci/travis-cookbooks/commit/8d3b68d0153b75419df460ca0f4458cdd628c5e0#commitcomment-4625656 Thanks @kentfredric !!! This reverts commit 8d3b68d0153b75419df460ca0f4458cdd628c5e0.
diff --git a/db/migrate/20140808035741_create_comments.rb b/db/migrate/20140808035741_create_comments.rb index abc1234..def5678 100644 --- a/db/migrate/20140808035741_create_comments.rb +++ b/db/migrate/20140808035741_create_comments.rb @@ -2,6 +2,10 @@ def change create_table :comments do |t| t.text :com...
Change comments migration file to have commentable_id, commentable_type, and ancestry
diff --git a/automaton.rb b/automaton.rb index abc1234..def5678 100644 --- a/automaton.rb +++ b/automaton.rb @@ -1,6 +1,7 @@ class Automaton PICTURE = [" ", "█"] ROW_WIDTH = `/usr/bin/env tput cols`.to_i + UNKNOWN_VALUE_PICTURE = "?" def display_grid(grid) puts grid.map { |cell| picture(cell) }.join @@...
Convert neighbourhood into Wolfram code
diff --git a/files/default/tests/minitest/default_test.rb b/files/default/tests/minitest/default_test.rb index abc1234..def5678 100644 --- a/files/default/tests/minitest/default_test.rb +++ b/files/default/tests/minitest/default_test.rb @@ -17,18 +17,8 @@ # require 'minitest/spec' -require 'net/http' +require File.e...
Remove failing tests from minitest.
diff --git a/sluggi.gemspec b/sluggi.gemspec index abc1234..def5678 100644 --- a/sluggi.gemspec +++ b/sluggi.gemspec @@ -15,8 +15,8 @@ spec.required_ruby_version = ">= 1.9.3" - spec.add_dependency "activerecord", "~> 4.0" - spec.add_dependency "railties", "~> 4.0" + spec.add_dependency "activerecord", ">= 4.0"...
Allow newer versions of activerecord, railties
diff --git a/lib/lifesaver/indexing/model_additions.rb b/lib/lifesaver/indexing/model_additions.rb index abc1234..def5678 100644 --- a/lib/lifesaver/indexing/model_additions.rb +++ b/lib/lifesaver/indexing/model_additions.rb @@ -42,8 +42,9 @@ private def enqueue_indexing(options) + operation = opt...
Use variable to remove 80 char violation
diff --git a/lib/mindbody-api/services/sale_service.rb b/lib/mindbody-api/services/sale_service.rb index abc1234..def5678 100644 --- a/lib/mindbody-api/services/sale_service.rb +++ b/lib/mindbody-api/services/sale_service.rb @@ -5,7 +5,7 @@ operation :get_accepted_card_type, :locals => false operati...
Add location attribute to checkout_shopping_cart method
diff --git a/lib/nanoc/toolbox/nanoc_monkey_patches.rb b/lib/nanoc/toolbox/nanoc_monkey_patches.rb index abc1234..def5678 100644 --- a/lib/nanoc/toolbox/nanoc_monkey_patches.rb +++ b/lib/nanoc/toolbox/nanoc_monkey_patches.rb @@ -1,19 +1,3 @@ module Nanoc3::Helpers::Blogging - # patch url_for and atom_tag_for to om...
Remove the monkey patches functions
diff --git a/lib/rb/lib/thrift/transport/httpclient.rb b/lib/rb/lib/thrift/transport/httpclient.rb index abc1234..def5678 100644 --- a/lib/rb/lib/thrift/transport/httpclient.rb +++ b/lib/rb/lib/thrift/transport/httpclient.rb @@ -1,6 +1,7 @@ require 'thrift/transport' require 'net/http' +require 'net/https' require ...
rb: Support SSL and correct Content-Type in HTTPClient [THRIFT-156] Author: Dave Engberg git-svn-id: 8d8e29b1fb681c884914062b88f3633e3a187774@704994 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/plugins/hosts/windows/cap/ssh.rb b/plugins/hosts/windows/cap/ssh.rb index abc1234..def5678 100644 --- a/plugins/hosts/windows/cap/ssh.rb +++ b/plugins/hosts/windows/cap/ssh.rb @@ -10,14 +10,15 @@ def self.set_ssh_key_permissions(env, key_path) script_path = Host.scripts_path.join("set_ss...
Fix path variable name. Return process result.
diff --git a/lib/generators/cover_me/install/templates/cover_me.rake b/lib/generators/cover_me/install/templates/cover_me.rake index abc1234..def5678 100644 --- a/lib/generators/cover_me/install/templates/cover_me.rake +++ b/lib/generators/cover_me/install/templates/cover_me.rake @@ -1,11 +1,11 @@ namespace :cover_me d...
Remove whitespace from rake task template ಠ_ಠ
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -23,9 +23,15 @@ { :host => "127.0.0.1", :port => free_server_port }, ], + # The public site. + :public_site => [ + { :host => "127.0.0.1", :port => 50100 }, + ], + ...
Add public site to the server config.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -11,7 +11,7 @@ post 'start_work', to: 'editions#progress', activity: { request_type: 'start_work' } post 'skip_fact_check', to: 'editions#progress', - acti...
Make skip_fact_check use proper workflow transitions
diff --git a/config/initializers/resolve_controller.rb b/config/initializers/resolve_controller.rb index abc1234..def5678 100644 --- a/config/initializers/resolve_controller.rb +++ b/config/initializers/resolve_controller.rb @@ -1,6 +1,6 @@-# Re-open ResolveController include the highlight helper +# Re-open ResolveCont...
Add the E-ZBorrow helper to the ResolveController
diff --git a/hako.gemspec b/hako.gemspec index abc1234..def5678 100644 --- a/hako.gemspec +++ b/hako.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ['lib'] spec.required_ruby_version = '>= 2.3.0' - spec.add_dependency 'aws-sdk', '>= 2.3.22' + spec.add_dependency 'aws-sdk', '>= 2.6.43' spec.add_development...
Use aws-sdk v2.6.43 or later for setting placement policy.
diff --git a/ellen-syoboi_calendar.gemspec b/ellen-syoboi_calendar.gemspec index abc1234..def5678 100644 --- a/ellen-syoboi_calendar.gemspec +++ b/ellen-syoboi_calendar.gemspec @@ -7,9 +7,8 @@ spec.version = Ellen::SyoboiCalendar::VERSION spec.authors = ["Ryo Nakamura"] spec.email = ["r7kamu...
Write summary and homepage into gemspec
diff --git a/event_store-messaging.gemspec b/event_store-messaging.gemspec index abc1234..def5678 100644 --- a/event_store-messaging.gemspec +++ b/event_store-messaging.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'event_store-messaging' s.summary = 'Messaging primitives for EventStore using the...
Package version is increased from 0.1.1.0 to 0.2.0.0
diff --git a/event_store-messaging.gemspec b/event_store-messaging.gemspec index abc1234..def5678 100644 --- a/event_store-messaging.gemspec +++ b/event_store-messaging.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'event_store-messaging' s.summary = 'Messaging primitives for EventStore using the...
Package version is increased from 0.2.4 to 0.2.5
diff --git a/lib/solid.rb b/lib/solid.rb index abc1234..def5678 100644 --- a/lib/solid.rb +++ b/lib/solid.rb @@ -14,7 +14,8 @@ class << self def unproxify(object) - if object.class.name.end_with?('::LiquidDropClass') + class_name = object.class.name + if class_name && class_name.end_with?('::Liq...
Fix unproxify now support anonymous classes
diff --git a/rightscale-cli.gemspec b/rightscale-cli.gemspec index abc1234..def5678 100644 --- a/rightscale-cli.gemspec +++ b/rightscale-cli.gemspec @@ -2,14 +2,14 @@ s.name = 'rightscale-cli' s.version = '0.5.6' s.date = '2014-02-18' - s.summary = "rightscale-cli" - s.description = "Rig...
Use single quotes appropriately in gemspec.
diff --git a/lib/tasks/configuration/expression_engine.rb b/lib/tasks/configuration/expression_engine.rb index abc1234..def5678 100644 --- a/lib/tasks/configuration/expression_engine.rb +++ b/lib/tasks/configuration/expression_engine.rb @@ -17,7 +17,7 @@ Pathname.new(paths.first).join('..').basename end - ...
Fix typo: ee_systems => ee_system
diff --git a/resources/default.rb b/resources/default.rb index abc1234..def5678 100644 --- a/resources/default.rb +++ b/resources/default.rb @@ -7,17 +7,17 @@ action :checkout do daun = ::Daun::RuggedDaun.new(destination) unless ::File.foreach("#{destination}/.git/config").any?{ |l| l[repository] } - # TODO: h...
Check config value before converging.
diff --git a/handlebars-rails.gemspec b/handlebars-rails.gemspec index abc1234..def5678 100644 --- a/handlebars-rails.gemspec +++ b/handlebars-rails.gemspec @@ -11,7 +11,7 @@ gem.description = "Use Handlebars.js client- and server-side" gem.email = "james.a.rosen@gmail.com" gem.homepag...
Add myself to the authors list
diff --git a/contribsearch.rb b/contribsearch.rb index abc1234..def5678 100644 --- a/contribsearch.rb +++ b/contribsearch.rb @@ -3,7 +3,9 @@ require 'pp' require 'json' - -octo = Octokit.contribs('pengwynn/octokit') - -pp octo+#returns an array of all usernames from a repo +def repo_contrib_locs(user_repo) + repo_c...
Add initial working method to return all contributor usernames from a repo
diff --git a/lib/cosy/helper/midi_renderer_helper.rb b/lib/cosy/helper/midi_renderer_helper.rb index abc1234..def5678 100644 --- a/lib/cosy/helper/midi_renderer_helper.rb +++ b/lib/cosy/helper/midi_renderer_helper.rb @@ -28,30 +28,18 @@ # Make MIDIator cleanup at program termination: class MIDIator::Driver + al...
Send note offs for every pitch/channel combination instead of tracking held notes
diff --git a/semantic_range.gemspec b/semantic_range.gemspec index abc1234..def5678 100644 --- a/semantic_range.gemspec +++ b/semantic_range.gemspec @@ -13,9 +13,7 @@ spec.homepage = "https://libraries.io/github/librariesio/semantic_range" spec.license = "MIT" - spec.files = `git ls-files -z`...
gemspec: Reduce size of packaged gem - Drop bindir and executables setting, since this gem ships no executable
diff --git a/html5_validators.gemspec b/html5_validators.gemspec index abc1234..def5678 100644 --- a/html5_validators.gemspec +++ b/html5_validators.gemspec @@ -19,6 +19,8 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ['lib'] s.add_development_dependency ...
Add required development dependency (selenium-webdriver and puma.)
diff --git a/lib/gitlab/build/ha_validate/nightly.rb b/lib/gitlab/build/ha_validate/nightly.rb index abc1234..def5678 100644 --- a/lib/gitlab/build/ha_validate/nightly.rb +++ b/lib/gitlab/build/ha_validate/nightly.rb @@ -32,7 +32,7 @@ end def self.get_access_token - ENV['HA_VALIDATE_TOKEN'] + ...
Use general token to poll gitlab-provisioner pipeline status
diff --git a/lib/recaptcha_mailhide/configuration.rb b/lib/recaptcha_mailhide/configuration.rb index abc1234..def5678 100644 --- a/lib/recaptcha_mailhide/configuration.rb +++ b/lib/recaptcha_mailhide/configuration.rb @@ -1,5 +1,15 @@ module RecaptchaMailhide class Configuration - attr_accessor :private_key, :publ...
Make private_key and public_key raise exceptions if missing from config.
diff --git a/iOS-Slide-Menu.podspec b/iOS-Slide-Menu.podspec index abc1234..def5678 100644 --- a/iOS-Slide-Menu.podspec +++ b/iOS-Slide-Menu.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'iOS-Slide-Menu' - s.version = '1.4.5' + s.version = '1.4.6' s.summary = 'A Slide Menu for iOS' s.homepa...
Update pod spec for version 1.4.6
diff --git a/iOS-Slide-Menu.podspec b/iOS-Slide-Menu.podspec index abc1234..def5678 100644 --- a/iOS-Slide-Menu.podspec +++ b/iOS-Slide-Menu.podspec @@ -8,7 +8,7 @@ :file => 'License.txt' } s.author = {'Aryan Ghassemi' => 'https://github.com/aryaxt/iOS-Slide-Menu'} - s.source = {:git => 'https://gith...
Update podspec to point to our repo
diff --git a/lib/embulk/input/googlespreadsheet/error.rb b/lib/embulk/input/googlespreadsheet/error.rb index abc1234..def5678 100644 --- a/lib/embulk/input/googlespreadsheet/error.rb +++ b/lib/embulk/input/googlespreadsheet/error.rb @@ -1,7 +1,8 @@ module Embulk module Input class Googlespreadsheet < InputPlugi...
Remove Traceable module cuz doesnt work
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -1,8 +1,10 @@-require 'cutest' -require 'redis' -require 'ohm' -require 'ohm/contrib' -require 'override' +$:.unshift(File.expand_path("../lib", File.dirname(__FILE__))) + +require "cutest" +require "...
Make running tests easier by adding ../lib to load path.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -1,4 +1,3 @@-require 'rubygems' require 'test/unit' if ENV['LEFTRIGHT'] @@ -9,10 +8,6 @@ end end -unless $LOAD_PATH.include? 'lib' - $LOAD_PATH.unshift(File.dirname(__FILE__)) - $LOAD_PATH....
Remove unnecessary and require 'rubygems'
diff --git a/spec/unit/veritas/immutable/freeze_spec.rb b/spec/unit/veritas/immutable/freeze_spec.rb index abc1234..def5678 100644 --- a/spec/unit/veritas/immutable/freeze_spec.rb +++ b/spec/unit/veritas/immutable/freeze_spec.rb @@ -43,8 +43,9 @@ expect { subject }.to_not change { object.instance_variable_get(:@_...
Fix spec description to match the fact that it does not set the ivar
diff --git a/features/step_definitions/user_steps.rb b/features/step_definitions/user_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/user_steps.rb +++ b/features/step_definitions/user_steps.rb @@ -1,4 +1,5 @@ Given /^I am logged in as a user$/ do + User.destroy_all user = User.create(:email ...
Destroy previous users before creating new one
diff --git a/spec/acceptance/class_spec.rb b/spec/acceptance/class_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/class_spec.rb +++ b/spec/acceptance/class_spec.rb @@ -1,24 +1,12 @@ require 'spec_helper_acceptance' -describe 'graphite' do +shared_examples_for "working graphite" do |puppet_manifest| it...
Extend acceptance tests to cover custom root_dir This will prevent us from breaking the functionality in ed5642d again.
diff --git a/spec/bluster/listener_spec.rb b/spec/bluster/listener_spec.rb index abc1234..def5678 100644 --- a/spec/bluster/listener_spec.rb +++ b/spec/bluster/listener_spec.rb @@ -0,0 +1,35 @@+# encoding: utf-8 + +require 'spec_helper' + +module Bluster + shared_examples_for 'a Rubyesque listener' do + let :listen...
Add simple tests for Listeners
diff --git a/app/helpers/bounties_helper.rb b/app/helpers/bounties_helper.rb index abc1234..def5678 100644 --- a/app/helpers/bounties_helper.rb +++ b/app/helpers/bounties_helper.rb @@ -3,6 +3,7 @@ def scoped_product_bounties_path(product, options={}) state = options[:state] || params[:state] user = options[...
Include user filter in scoped helper
diff --git a/app/models/lottery_division.rb b/app/models/lottery_division.rb index abc1234..def5678 100644 --- a/app/models/lottery_division.rb +++ b/app/models/lottery_division.rb @@ -27,7 +27,7 @@ end def reverse_loaded_draws - ordered_loaded_draws.reorder(created_at: :desc) + loaded_draws.reorder(create...
Remove redundant ordering in lottery division model
diff --git a/app/validators/ip_validator.rb b/app/validators/ip_validator.rb index abc1234..def5678 100644 --- a/app/validators/ip_validator.rb +++ b/app/validators/ip_validator.rb @@ -8,7 +8,7 @@ if BLOCKED_COUNTRIES.include? geocode&.country_code&.upcase record.errors.add :base, "Spam registration suspecte...
Fix issue with missing geocode data locally
diff --git a/lib/cowsay.rb b/lib/cowsay.rb index abc1234..def5678 100644 --- a/lib/cowsay.rb +++ b/lib/cowsay.rb @@ -1,6 +1,16 @@ require 'active_support' require 'logger' module Cowsay + class NullObject + def method_missing(*args, &block) + self + end + end + + def Maybe(value) + value.nil? ? NullO...
Use Null Object for output
diff --git a/spec/classes/git_gitosis_spec.rb b/spec/classes/git_gitosis_spec.rb index abc1234..def5678 100644 --- a/spec/classes/git_gitosis_spec.rb +++ b/spec/classes/git_gitosis_spec.rb @@ -0,0 +1,10 @@+require 'spec_helper' + +describe 'git::gitosis' do + + context 'defaults' do + it { should contain_package('g...
Add spec for gitosis class
diff --git a/spec/core/core_spec.rb b/spec/core/core_spec.rb index abc1234..def5678 100644 --- a/spec/core/core_spec.rb +++ b/spec/core/core_spec.rb @@ -45,6 +45,32 @@ end end + context 'a postfix conditional' do + + it 'is a call wrapped' do + # + # `break if a == 3` + # is equivalent to + ...
Add core spec for `break if a == 3`
diff --git a/lib/wbench.rb b/lib/wbench.rb index abc1234..def5678 100644 --- a/lib/wbench.rb +++ b/lib/wbench.rb @@ -3,6 +3,7 @@ require 'net/http' require 'uri' require 'capybara' +require 'selenium/webdriver' require 'wbench/version' require 'wbench/benchmark' @@ -14,10 +15,14 @@ require 'wbench/timings/latency...
Set capybara timeout to 10 seconds.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -11,5 +11,7 @@ # Settings in config/environments/* take precedence over those specified here. # Application configuration should go into files in config/initialize...
Add represent_boolean_as_integer to fix minitest
diff --git a/config/deploy/test.rb b/config/deploy/test.rb index abc1234..def5678 100644 --- a/config/deploy/test.rb +++ b/config/deploy/test.rb @@ -21,4 +21,15 @@ end after :publishing, :restart + + desc 'Run pending Rails migrations' + task :migrate do + on roles(:db) do + within current_path.join('r...
Add task to migrate our Rails app that's in a subdirectory
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -2,6 +2,10 @@ require 'active_record' require 'yaml' require 'erb' +require 'dotenv' +require 'octokit' + +Dotenv.load if ENV['DATABASE_URL'] db = URI.parse(ENV['DA...
Configure octokit in production in addition to development
diff --git a/spec/builders/mobi_spec.rb b/spec/builders/mobi_spec.rb index abc1234..def5678 100644 --- a/spec/builders/mobi_spec.rb +++ b/spec/builders/mobi_spec.rb @@ -10,13 +10,15 @@ end end - before(:all) { generate_book } + before(:all) do + generate_book + @builder = Polytexnic::Builde...
Move builder.build! into before(:all) block for MOBI [#52758883]
diff --git a/spec/factories/link_set.rb b/spec/factories/link_set.rb index abc1234..def5678 100644 --- a/spec/factories/link_set.rb +++ b/spec/factories/link_set.rb @@ -8,12 +8,12 @@ after(:create) do |link_set, evaluator| evaluator.links_hash.each do |link_type, target_content_ids| - target_content...
Include position in LinkSet factory This includes the position value that was missing previously.
diff --git a/spec/unit/api_actions_spec.rb b/spec/unit/api_actions_spec.rb index abc1234..def5678 100644 --- a/spec/unit/api_actions_spec.rb +++ b/spec/unit/api_actions_spec.rb @@ -14,11 +14,13 @@ describe '#find' do let(:story) { subject.find(:story, 1) } + it 'calls get and returns resource object...
Improve title of spec and removing extra whitespace
diff --git a/spec/factories/user_tables.rb b/spec/factories/user_tables.rb index abc1234..def5678 100644 --- a/spec/factories/user_tables.rb +++ b/spec/factories/user_tables.rb @@ -22,6 +22,24 @@ user_table.unstub(:create_canonical_visualization) end + trait :with_db_table do + before(:create) do |...
Add trait for full user table
diff --git a/recipes/reserve_ip_for_vcac_vm_in_network.rb b/recipes/reserve_ip_for_vcac_vm_in_network.rb index abc1234..def5678 100644 --- a/recipes/reserve_ip_for_vcac_vm_in_network.rb +++ b/recipes/reserve_ip_for_vcac_vm_in_network.rb @@ -1,7 +1,9 @@ # Cookbook Name: Infoblox # Recipe Name: reserve_ip_for_vcac_vm_in...
Revert changes for network workflow
diff --git a/spec/default_search_spec.rb b/spec/default_search_spec.rb index abc1234..def5678 100644 --- a/spec/default_search_spec.rb +++ b/spec/default_search_spec.rb @@ -8,6 +8,7 @@ it "Should match partial titles" do default_search('b2041590', 'remains of the day', 10) + default_search('b7113006', 'time...
Add another example that was previously failing.
diff --git a/spec/features/editing_submissions_spec.rb b/spec/features/editing_submissions_spec.rb index abc1234..def5678 100644 --- a/spec/features/editing_submissions_spec.rb +++ b/spec/features/editing_submissions_spec.rb @@ -18,7 +18,7 @@ visit edit_assignment_submission_path assignment, submission w...
Update the alert content for resubmissions
diff --git a/lib/adhearsion/initializer/punchblock.rb b/lib/adhearsion/initializer/punchblock.rb index abc1234..def5678 100644 --- a/lib/adhearsion/initializer/punchblock.rb +++ b/lib/adhearsion/initializer/punchblock.rb @@ -1,4 +1,5 @@ require 'punchblock' +require 'timeout' module Adhearsion class Initializer @...
Add very basic Punchblock queue polling
diff --git a/spec/default_spec.rb b/spec/default_spec.rb index abc1234..def5678 100644 --- a/spec/default_spec.rb +++ b/spec/default_spec.rb @@ -2,8 +2,9 @@ describe 'elasticsearch_lwrp::default' do let(:chef_run) { ChefSpec::SoloRunner.new.converge(described_recipe) } - + let(:node) { chef_run.node } + i...
Correct resource action to allow ChefSpec to pass
diff --git a/lib/cb/models/cb_application_external.rb b/lib/cb/models/cb_application_external.rb index abc1234..def5678 100644 --- a/lib/cb/models/cb_application_external.rb +++ b/lib/cb/models/cb_application_external.rb @@ -10,7 +10,7 @@ def initialize(args = {}) @job_did = args[:job_did] || '' ...
Add default SiteID (cbnsv) to external applications if none present
diff --git a/test_app/spec/rails_generators/rails_generators_spec.rb b/test_app/spec/rails_generators/rails_generators_spec.rb index abc1234..def5678 100644 --- a/test_app/spec/rails_generators/rails_generators_spec.rb +++ b/test_app/spec/rails_generators/rails_generators_spec.rb @@ -6,6 +6,7 @@ describe Impressionist ...
Mark failing tests as pending
diff --git a/lib/iron_worker_ng/code/dir_container.rb b/lib/iron_worker_ng/code/dir_container.rb index abc1234..def5678 100644 --- a/lib/iron_worker_ng/code/dir_container.rb +++ b/lib/iron_worker_ng/code/dir_container.rb @@ -0,0 +1,29 @@+require 'fileutils' + +module IronWorkerNG + module Code + class DirContainer ...
Support for local code execution.
diff --git a/lib/tugboat/middleware/create_droplet.rb b/lib/tugboat/middleware/create_droplet.rb index abc1234..def5678 100644 --- a/lib/tugboat/middleware/create_droplet.rb +++ b/lib/tugboat/middleware/create_droplet.rb @@ -6,23 +6,17 @@ say "Queueing creation of droplet '#{env["create_droplet_name"]}'...", ...
Change to tenary operators for defaults
diff --git a/lib/admin_module/command/client_access.rb b/lib/admin_module/command/client_access.rb index abc1234..def5678 100644 --- a/lib/admin_module/command/client_access.rb +++ b/lib/admin_module/command/client_access.rb @@ -9,7 +9,8 @@ module AdminModule module Command module ClientAccess - private de...
Put 'private' specifier on separate line * Older versions of ruby do not like individual 'private' specifiers for method definitions
diff --git a/lib/alternate_rails/controller_helpers.rb b/lib/alternate_rails/controller_helpers.rb index abc1234..def5678 100644 --- a/lib/alternate_rails/controller_helpers.rb +++ b/lib/alternate_rails/controller_helpers.rb @@ -1,9 +1,21 @@ module AlternateRails module ControllerHelpers - def set_alternate_for...
Send Content-Location headers if no extension has been provided
diff --git a/dmm-ruby.gemspec b/dmm-ruby.gemspec index abc1234..def5678 100644 --- a/dmm-ruby.gemspec +++ b/dmm-ruby.gemspec @@ -20,6 +20,7 @@ gem.add_dependency('faraday', '~> 0.8') gem.add_dependency('faraday_middleware') gem.add_dependency('multi_xml') + gem.add_development_dependency('rake') gem.add_dev...
Add `rake` for development dependency.
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -5,6 +5,8 @@ render text: "#{params[:id]}.3agPbEGMW8yyXAdNJmtYhleq07pUgmnN1oCrhN9iRwA" when "OLj4hja-R9m7...
Update challenge response for March 2017 SSL renewal
diff --git a/app/controllers/steps_controller.rb b/app/controllers/steps_controller.rb index abc1234..def5678 100644 --- a/app/controllers/steps_controller.rb +++ b/app/controllers/steps_controller.rb @@ -27,6 +27,10 @@ private def step_params - params.require(:step).permit @step.questions.keys + if params...
Allow pressing Continue from a static step
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,15 +1,23 @@ class UsersController < ApplicationController - def new + + def new + @user = User.new end ...
Add logic to user controller
diff --git a/jsonapi-authorization.gemspec b/jsonapi-authorization.gemspec index abc1234..def5678 100644 --- a/jsonapi-authorization.gemspec +++ b/jsonapi-authorization.gemspec @@ -6,15 +6,13 @@ Gem::Specification.new do |spec| spec.name = "jsonapi-authorization" spec.version = JSONAPI::Authorizati...
Update gemspec with correct informations
diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/votes_controller.rb +++ b/app/controllers/votes_controller.rb @@ -1,6 +1,6 @@ class VotesController < ApplicationController - before_filter :authenticate_user! + before_filter :...
Add comment note about Voting authentication
diff --git a/app/models/concerns/address_part.rb b/app/models/concerns/address_part.rb index abc1234..def5678 100644 --- a/app/models/concerns/address_part.rb +++ b/app/models/concerns/address_part.rb @@ -2,6 +2,8 @@ class AddressPart < Tokenable include Mongoid::Geospatial + + validates_presence_of :name fi...
Validate presence of name for address parts
diff --git a/lib/marc2linkeddata/oclc_creative_work.rb b/lib/marc2linkeddata/oclc_creative_work.rb index abc1234..def5678 100644 --- a/lib/marc2linkeddata/oclc_creative_work.rb +++ b/lib/marc2linkeddata/oclc_creative_work.rb @@ -8,23 +8,32 @@ def get_works # assume an exampleOfWork can only ever link to on...
Revise OCLC query for works in an example work
diff --git a/lib/test/spec/rails/controller_helpers.rb b/lib/test/spec/rails/controller_helpers.rb index abc1234..def5678 100644 --- a/lib/test/spec/rails/controller_helpers.rb +++ b/lib/test/spec/rails/controller_helpers.rb @@ -1,3 +1,5 @@+require 'action_controller/test_case' + module Test module Spec module...
Include the TestProcess module so functional tests run.
diff --git a/app/views/login/login.json.jbuilder b/app/views/login/login.json.jbuilder index abc1234..def5678 100644 --- a/app/views/login/login.json.jbuilder +++ b/app/views/login/login.json.jbuilder @@ -5,5 +5,6 @@ json.status 'success' json.apikey @apikey json.expires @expires + json.authenticated_as_id @us...
Add authenticated_as_id to login response
diff --git a/app/workers/process_album_worker.rb b/app/workers/process_album_worker.rb index abc1234..def5678 100644 --- a/app/workers/process_album_worker.rb +++ b/app/workers/process_album_worker.rb @@ -3,7 +3,6 @@ sidekiq_options queue: :utility def perform(title, versions=:all) - require 'process_photos' ...
Remove explicit require, this is autoloaded now
diff --git a/lib/authlogic/regex.rb b/lib/authlogic/regex.rb index abc1234..def5678 100644 --- a/lib/authlogic/regex.rb +++ b/lib/authlogic/regex.rb @@ -10,7 +10,7 @@ # for regular expressions. def self.email return @email_regex if @email_regex - email_name_regex = '[A-Z0-9\.%\+\-]+' + email_...
Add _ as allowed character in email, fixes change made last night
diff --git a/app/controllers/ajax/report_controller.rb b/app/controllers/ajax/report_controller.rb index abc1234..def5678 100644 --- a/app/controllers/ajax/report_controller.rb +++ b/app/controllers/ajax/report_controller.rb @@ -39,7 +39,7 @@ current_user.report object, params[:reason] @response[:status] = :...
Apply review suggestion from @raccube Co-authored-by: Karina Kwiatek <a279f78642aaf231facf94ac593d2ad2fd791699@users.noreply.github.com>
diff --git a/lib/core_ext/object.rb b/lib/core_ext/object.rb index abc1234..def5678 100644 --- a/lib/core_ext/object.rb +++ b/lib/core_ext/object.rb @@ -14,6 +14,8 @@ end def to_equal(expected) - self == expected + if self != expected + raise RuntimeError.new("expected #{self} to equal #{expected}") +...
Raise an exception to make the test fail
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -10,7 +10,7 @@ def page_is_mine? (current_user && (params[:username] == current_user....
Fix page_is_mine? to work for /entries/anything
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,4 +2,8 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want t...
Add get_current_user to base app controller
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,6 +2,10 @@ # Prevent CSRF attacks by raising an exception. # For APIs, you may want ...
Add Basic Auth to production & staging
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -21,7 +21,9 @@ helper_method :current_user def require_staff - redirect_to "/" unl...
Fix require_staff to not crash
diff --git a/lib/seory.rb b/lib/seory.rb index abc1234..def5678 100644 --- a/lib/seory.rb +++ b/lib/seory.rb @@ -1,7 +1,7 @@ require "seory/version" module Seory - CONTENTS = %w[title h1 h2 meta_description meta_keywords canonical_url image_url].map(&:to_sym) + CONTENTS = %w[title h1 h2 meta_description meta_keywo...
Change content name image_url -> og_image_url
diff --git a/walkon.gemspec b/walkon.gemspec index abc1234..def5678 100644 --- a/walkon.gemspec +++ b/walkon.gemspec @@ -14,11 +14,11 @@ spec.license = "MIT" spec.files = `git ls-files`.split($/) - spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } - spec.test_files = spe...
Remove gems we don't need and refactor gemspec dir lookups
diff --git a/lib/tictactoe_rules.rb b/lib/tictactoe_rules.rb index abc1234..def5678 100644 --- a/lib/tictactoe_rules.rb +++ b/lib/tictactoe_rules.rb @@ -28,4 +28,14 @@ board.valid_slots == [] || won?(board, "X") || won?(board, "O") ? true : false end + def winner(board) + if won?(board, turn) + "X" + ...
Add logic to return winner
diff --git a/lib/speed_gun/railtie.rb b/lib/speed_gun/railtie.rb index abc1234..def5678 100644 --- a/lib/speed_gun/railtie.rb +++ b/lib/speed_gun/railtie.rb @@ -9,6 +9,7 @@ SpeedGun.config[:backtrace_remove] = Rails.root.to_s + '/' SpeedGun.config[:backtrace_includes] = [/^(app|config|lib|test|spec)/] Spe...
Add default config of authorize
diff --git a/lib/tasks/webpacker.rake b/lib/tasks/webpacker.rake index abc1234..def5678 100644 --- a/lib/tasks/webpacker.rake +++ b/lib/tasks/webpacker.rake @@ -19,4 +19,21 @@ task :install do exec "./bin/rails app:template LOCATION=#{WEBPACKER_APP_TEMPLATE_PATH}" end + + desc "add everything needed for reac...
Add task for installing react requirements and configuring them against the default
diff --git a/lib/thailand/district.rb b/lib/thailand/district.rb index abc1234..def5678 100644 --- a/lib/thailand/district.rb +++ b/lib/thailand/district.rb @@ -23,6 +23,8 @@ all end + alias_method :subdistricts, :subregions + alias_method :subdistricts?, :subregions? alias_method :tambon, :subr...
Add alias methods for District
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,9 +1,14 @@ # myapp.rb require 'sinatra' require 'json' + get '/c/:id' do |id| "Hello world! #{id}" {"id" => id, "ala" => "Some html string. <i>with formatting</i>"}.to_json end + +get '/' do + redirect to('index....
Add root path redirect to index.html
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,6 +1,12 @@ require "sinatra/base" class F2fIncomingApp < Sinatra::Base + hook_path = ENV["WEBHOOK_SECRET_PATH"] || "incoming" + + get "/#{hook_path}" do + ":metal:\n" + end + get "/*" do redirect "http://www.farm...
Set up the incoming hook path
diff --git a/lib/faye-rails/server_list.rb b/lib/faye-rails/server_list.rb index abc1234..def5678 100644 --- a/lib/faye-rails/server_list.rb +++ b/lib/faye-rails/server_list.rb @@ -19,6 +19,11 @@ end alias push << - alias clear! clear + def clear! + self.each do |server| + server.stop + end + cle...
Make sure that if there is a listening server that it's shut down before clearing the server list.
diff --git a/lib/geocoder/results/yahoo.rb b/lib/geocoder/results/yahoo.rb index abc1234..def5678 100644 --- a/lib/geocoder/results/yahoo.rb +++ b/lib/geocoder/results/yahoo.rb @@ -11,7 +11,7 @@ (1..3).to_a.map{ |i| @data["line#{i}"] }.reject{ |i| i.nil? or i == "" }.join(", ") end - def self.yahoo_attr...
Use more generic method name.
diff --git a/lib/modules/autocompletion.rb b/lib/modules/autocompletion.rb index abc1234..def5678 100644 --- a/lib/modules/autocompletion.rb +++ b/lib/modules/autocompletion.rb @@ -16,9 +16,15 @@ type = result.class.name.underscore identifier = result.send(identifier_field(type)) + geom_type = resul...
Add identifier and geom_type to autocomplete results
diff --git a/lib/postmark/handlers/mail.rb b/lib/postmark/handlers/mail.rb index abc1234..def5678 100644 --- a/lib/postmark/handlers/mail.rb +++ b/lib/postmark/handlers/mail.rb @@ -12,6 +12,7 @@ api_key = settings.delete(:api_key) api_client = ::Postmark::ApiClient.new(api_key, settings) api_client....
Return self from Mail::Postmark delivery handler.
diff --git a/lib/tic_tac_toe/rack_shell.rb b/lib/tic_tac_toe/rack_shell.rb index abc1234..def5678 100644 --- a/lib/tic_tac_toe/rack_shell.rb +++ b/lib/tic_tac_toe/rack_shell.rb @@ -6,37 +6,42 @@ module TicTacToe class RackShell + attr_accessor :req + def self.new_shell + router, player = TicTacToe::Rout...
Move the router setup code into the new_shell function
diff --git a/client.rb b/client.rb index abc1234..def5678 100644 --- a/client.rb +++ b/client.rb @@ -14,6 +14,7 @@ include Singleplatform::Client::Locations include Singleplatform::Client::Menus + include Singleplatform::Client::Photos def initialize @base_url = BASE_URL
Include Photos module in Client class
diff --git a/lib/biovision/base/privilege_methods.rb b/lib/biovision/base/privilege_methods.rb index abc1234..def5678 100644 --- a/lib/biovision/base/privilege_methods.rb +++ b/lib/biovision/base/privilege_methods.rb @@ -12,6 +12,11 @@ ::UserPrivilege.user_has_privilege?(current_user, privilege_name) end...
Add helpers to check if current user is in privilege group