diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/services/notify_registered_user_from_proposed_org_spec.rb b/spec/services/notify_registered_user_from_proposed_org_spec.rb index abc1234..def5678 100644 --- a/spec/services/notify_registered_user_from_proposed_org_spec.rb +++ b/spec/services/notify_registered_user_from_proposed_org_spec.rb @@ -10,4 +1...
Add spec for NotifyRegisteredUserFromProposedOrg associating user with org
diff --git a/db/data_migration/20161110163557_create_unpublishing_record_for_newton_grade_separated_junction.rb b/db/data_migration/20161110163557_create_unpublishing_record_for_newton_grade_separated_junction.rb index abc1234..def5678 100644 --- a/db/data_migration/20161110163557_create_unpublishing_record_for_newton_...
Create unpublishing for withdrawn edition 383738 Fixes an error with `DocumentCollection` sync checks with `document_id = 256174`. This collection contains a `Document` with an id of `258249` which managed to get itself into a state where the `Edition` (383738) had a state of `withdrawn` but there was no corresponding...
diff --git a/event_store-messaging.gemspec b/event_store-messaging.gemspec index abc1234..def5678 100644 --- a/event_store-messaging.gemspec +++ b/event_store-messaging.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'event_store-messaging' s.summary = 'Messaging primitives for EventStore using the...
Package version is increased from 0.1.0.0 to 0.1.0.1
diff --git a/performance/aur.rb b/performance/aur.rb index abc1234..def5678 100644 --- a/performance/aur.rb +++ b/performance/aur.rb @@ -5,12 +5,20 @@ require 'aurb' -Benchmark.bm 7 do |x| - x.report 'search' do +Benchmark.bm 20 do |x| + x.report 'aurb upgrade' do + Aurb.aur.upgrade *`pacman -Qm`.split(/\n/) +...
Add contenders to performance check
diff --git a/spritesh.gemspec b/spritesh.gemspec index abc1234..def5678 100644 --- a/spritesh.gemspec +++ b/spritesh.gemspec @@ -10,6 +10,6 @@ spec.summary = "Build an SVG sprite from a folder of SVG files." spec.authors = ["Hugo Giraudel", "Cade Scroggins"] spec.email = ["h.giraudel@de.eden...
Update a file in gemspec file
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -30,8 +30,5 @@ # Custom directories with classes and modules you want to be autoloadable. config.autoload_paths += %W(#{config.root}/lib) - - # Google Analyti...
Remove unused AB test config
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -9,6 +9,20 @@ module ReactRailsStarterApp class Application < Rails::Application + # Initialize configuration defaults for originally generated Rails version. + ...
Move the auto generated config to top of file Keep our custom modifications at the bottom
diff --git a/lib/at_users.rb b/lib/at_users.rb index abc1234..def5678 100644 --- a/lib/at_users.rb +++ b/lib/at_users.rb @@ -2,9 +2,11 @@ def self.render(content, messageboard) at_names = AtNotificationExtractor.new(content).extract members = messageboard.members_from_list(at_names) + members.each { |m...
Fix bug in rendering @usernames
diff --git a/lib/charting.rb b/lib/charting.rb index abc1234..def5678 100644 --- a/lib/charting.rb +++ b/lib/charting.rb @@ -29,7 +29,7 @@ def self.detect_available_plugin available = subclasses.select(&:available?) - available.max { |klass_a, klass_b| klass_a.priority <=> klass_b.priority } + available....
Use max_by instead of max in Charting.detect_available_plugin
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -22,7 +22,8 @@ } end -# Fix the bug described here:http://stackoverflow.com/questions/9122411/rails-javascript-too-many-parameter-keys-whats-a-good-way-to-normalize-f ...
Fix "exceeded available parameter key space" bug with large POST requests Rack attempts to parse the POST data as a form if the Content-Type header matches one of its understood formats. Sometimes the Content-Type header is not set correctly by calls to the API and it tries to parse large requests. We blank the types ...
diff --git a/jsrebuild.gemspec b/jsrebuild.gemspec index abc1234..def5678 100644 --- a/jsrebuild.gemspec +++ b/jsrebuild.gemspec @@ -1,4 +1,6 @@-# -*- encoding: utf-8 -*- +#!/usr/bin/env gem build +# encoding: utf-8 + lib = File.expand_path('../lib/', __FILE__) $:.unshift lib unless $:.include?(lib)
Make gemspec executable and build the gem.
diff --git a/fibonacci/fib_cfe.rb b/fibonacci/fib_cfe.rb index abc1234..def5678 100644 --- a/fibonacci/fib_cfe.rb +++ b/fibonacci/fib_cfe.rb @@ -3,9 +3,9 @@ $_ = $$ / $$ # 1 @_ = $_ + $_ # 2 -$- = $_ - @_ # -1 +$-_ = $_ - @_ # -1 $__= @_ * @_ + $_ # 5 -@__= $__ ** (@_ ** $-) # sqrt(5) +@__= $__ ** (@_ ** $-_) # s...
Refactor to not use $- variable
diff --git a/krb5-auth.gemspec b/krb5-auth.gemspec index abc1234..def5678 100644 --- a/krb5-auth.gemspec +++ b/krb5-auth.gemspec @@ -7,7 +7,7 @@ s.email = %q{clalance@redhat.com} s.platform = Gem::Platform::RUBY s.summary = %q{Kerberos binding for Ruby} - s.files ...
Make sure to include the COPYING and TODO files in the gemspec, so that generated gems get those files (COPYING, in particular, is absolutely required)
diff --git a/manifests/cf-manifest/spec/secret_generation_spec.rb b/manifests/cf-manifest/spec/secret_generation_spec.rb index abc1234..def5678 100644 --- a/manifests/cf-manifest/spec/secret_generation_spec.rb +++ b/manifests/cf-manifest/spec/secret_generation_spec.rb @@ -7,6 +7,8 @@ } specify "it should pro...
Disable generate-cf-secrets test on Mac This test fails on Mac because there isn't an `mkpasswd` command available. Short of writing our own hash+salt function, it seems there is no portable alternative. So we have to mark this test as "pending" if being run on Mac. I think that because the tests are run using Bundle...
diff --git a/app/actions.rb b/app/actions.rb index abc1234..def5678 100644 --- a/app/actions.rb +++ b/app/actions.rb @@ -11,7 +11,18 @@ end @real = @topics.sample.twitter_handles.where("real_twitter_handle_id is null").sample.tweets.sample @fake = TwitterHandle.where("real_twitter_handle_id = ?", [@real.twitter...
Add Json output option to showing a topic The json object returned has the keys `real`: _Content of the real tweet_ `fake`: _Content of the fake tweet_ `real_handle`: _Handle of user who created the real tweet_ `fake_handle`: _Handle of user who created the fake tweet_ `tweet_topic`: _Topic of the tweets sent_ `topic`...
diff --git a/db/migrate/20170622172712_create_incline_action_groups.rb b/db/migrate/20170622172712_create_incline_action_groups.rb index abc1234..def5678 100644 --- a/db/migrate/20170622172712_create_incline_action_groups.rb +++ b/db/migrate/20170622172712_create_incline_action_groups.rb @@ -1,8 +1,8 @@ class CreateInc...
Fix foreign keys in incline_action_groups.
diff --git a/poseidon/config.rb b/poseidon/config.rb index abc1234..def5678 100644 --- a/poseidon/config.rb +++ b/poseidon/config.rb @@ -18,3 +18,5 @@ end $num_instances=3 +$vb_memory = 2048 +$vb_cpus = 2
Make the VMs a little bigger, so users do not have to wait for too long (hopefully)
diff --git a/app/helpers/posts_helper.rb b/app/helpers/posts_helper.rb index abc1234..def5678 100644 --- a/app/helpers/posts_helper.rb +++ b/app/helpers/posts_helper.rb @@ -10,9 +10,9 @@ class PostScrubber < Rails::Html::PermitScrubber def initialize super - self.tags = %w[a p b i em strong hr h1 h2 ...
Allow span tags and lang attributes
diff --git a/app/helpers/theme_helper.rb b/app/helpers/theme_helper.rb index abc1234..def5678 100644 --- a/app/helpers/theme_helper.rb +++ b/app/helpers/theme_helper.rb @@ -5,27 +5,18 @@ # happier if we didn't have to override undocumented methods. Ho # hum. -- pdcawley - def render_file(template_path, use_full...
Make our theme loading a little more Rails 1.1ish. Should now work with respond_to git-svn-id: 70ab0960c3db1cbf656efd6df54a8f3de72dc710@1034 820eb932-12ee-0310-9ca8-eeb645f39767
diff --git a/app/models/internal_post.rb b/app/models/internal_post.rb index abc1234..def5678 100644 --- a/app/models/internal_post.rb +++ b/app/models/internal_post.rb @@ -28,7 +28,6 @@ end def number_of_comments - comments.count + comments.count end - end
Improve code according houndci comments
diff --git a/lib/napa/cli.rb b/lib/napa/cli.rb index abc1234..def5678 100644 --- a/lib/napa/cli.rb +++ b/lib/napa/cli.rb @@ -30,8 +30,8 @@ desc 'console [environment]', 'Start the Napa console' options aliases: 'c' - def console(environment = 'development' ) - ENV['RACK_ENV'] = environment + ...
Fix napa console when using IRB. IRB was taking extra arguments, "console" and optionally the environment, when running `napa console <environment>`. IRB then interprets this as a script name, and errors out. These arguments are now removed from ARGV before starting the interpreter.
diff --git a/app/helpers/manageiq/providers/lenovo/toolbar_overrides/ems_physical_infra_center.rb b/app/helpers/manageiq/providers/lenovo/toolbar_overrides/ems_physical_infra_center.rb index abc1234..def5678 100644 --- a/app/helpers/manageiq/providers/lenovo/toolbar_overrides/ems_physical_infra_center.rb +++ b/app/help...
Remove to_json from toolbar data as it's not needed After https://github.com/ManageIQ/manageiq-ui-classic/pull/5997 `to_json` is not needed and will break the data format. Related to https://github.com/ManageIQ/manageiq-ui-classic/pull/6289 fix
diff --git a/akami.gemspec b/akami.gemspec index abc1234..def5678 100644 --- a/akami.gemspec +++ b/akami.gemspec @@ -21,6 +21,7 @@ s.add_development_dependency "rspec", "~> 2.14" s.add_development_dependency "mocha", "~> 0.13" s.add_development_dependency "timecop", "~> 0.5" + s.add_development_dependency ...
Add transpec as a development dependency
diff --git a/spec/builders/mobi_spec.rb b/spec/builders/mobi_spec.rb index abc1234..def5678 100644 --- a/spec/builders/mobi_spec.rb +++ b/spec/builders/mobi_spec.rb @@ -10,13 +10,15 @@ end end - before(:all) { generate_book } + before(:all) do + generate_book + @builder = Polytexnic::Builde...
Move builder.build! into before(:all) block for MOBI [#52758883]
diff --git a/spec/fixtures/factories.rb b/spec/fixtures/factories.rb index abc1234..def5678 100644 --- a/spec/fixtures/factories.rb +++ b/spec/fixtures/factories.rb @@ -13,6 +13,11 @@ permissions %w(signin editor) end + factory :gds_editor, parent: :user do + organisation_slug "government-digital-service" ...
Add factory for gds_editor User
diff --git a/spec/acceptance/freeradius__mod_spec.rb b/spec/acceptance/freeradius__mod_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/freeradius__mod_spec.rb +++ b/spec/acceptance/freeradius__mod_spec.rb @@ -14,7 +14,8 @@ } file { '/etc/raddb/mods-config/perl/auth.pl': ensure => file...
Fix dependencies in acceptance tests
diff --git a/spec/taint_aliases_spec.rb b/spec/taint_aliases_spec.rb index abc1234..def5678 100644 --- a/spec/taint_aliases_spec.rb +++ b/spec/taint_aliases_spec.rb @@ -10,9 +10,23 @@ end TaintAliases::TAINT_ALIASES.each do |a| + suffix = 'aeiou'[a[-1]] ? 'd' : 'ed' + query = a + suffix + "?" + ...
Add specs for untaints and taint queries They're not particularly thorough, but they sound pretty enterprise.
diff --git a/config/environment.rb b/config/environment.rb index abc1234..def5678 100644 --- a/config/environment.rb +++ b/config/environment.rb @@ -1,5 +1,7 @@ # Load the Rails application. require File.expand_path('../application', __FILE__) +Jbuilder.key_format camelize: :lower + # Initialize the Rails applicati...
Use camelCase in JBuilder output Signed-off-by: Max Fierke <0706025b2bbcec1ed8d64822f4eccd96314938d0@maxfierke.com>
diff --git a/lib/tasks/deployment/20191004110122_update_the_brain.rake b/lib/tasks/deployment/20191004110122_update_the_brain.rake index abc1234..def5678 100644 --- a/lib/tasks/deployment/20191004110122_update_the_brain.rake +++ b/lib/tasks/deployment/20191004110122_update_the_brain.rake @@ -0,0 +1,12 @@+namespace :aft...
Add rake task to nobble the brain
diff --git a/lib/onfido/api.rb b/lib/onfido/api.rb index abc1234..def5678 100644 --- a/lib/onfido/api.rb +++ b/lib/onfido/api.rb @@ -4,19 +4,40 @@ @api_key = options[:api_key] end - def method_missing(method, *args) - klass = method.to_s.split('_').collect(&:capitalize).join - Object.const_get...
Replace method_missing with explicit methods Replace the use of method_missing in Onfido::API with explicit methods for each resource. This allows users to create verifying doubles in rspec tests, as well as making it clearer what methods are available on the class.
diff --git a/lib/rottendesk.rb b/lib/rottendesk.rb index abc1234..def5678 100644 --- a/lib/rottendesk.rb +++ b/lib/rottendesk.rb @@ -18,7 +18,7 @@ def logger=(logger) @logger = logger @logger.formatter = proc do |severity, datetime, progname, msg| - "Rottendesk #{severity}: #{msg}" + "Ro...
Add newline in logger message
diff --git a/lib/c2y/dsl/context/user.rb b/lib/c2y/dsl/context/user.rb index abc1234..def5678 100644 --- a/lib/c2y/dsl/context/user.rb +++ b/lib/c2y/dsl/context/user.rb @@ -10,14 +10,12 @@ instance_eval(&block) end - private + [:github, :groups].each do |attr| + define_method(attr) do |arg| + ...
Use dynamic method definition in User
diff --git a/config/initializers/nr_sidekiq_queue_latency.rb b/config/initializers/nr_sidekiq_queue_latency.rb index abc1234..def5678 100644 --- a/config/initializers/nr_sidekiq_queue_latency.rb +++ b/config/initializers/nr_sidekiq_queue_latency.rb @@ -0,0 +1,13 @@+class NewRelicQueueLatencyLogger + def call(worker, j...
Add queue latency for Sidekiq jobs in NR
diff --git a/lib/jsonapi/resource_for.rb b/lib/jsonapi/resource_for.rb index abc1234..def5678 100644 --- a/lib/jsonapi/resource_for.rb +++ b/lib/jsonapi/resource_for.rb @@ -16,7 +16,11 @@ else def resource_for(type) resource_name = JSONAPI::Resource._resource_name_from_type(type) - re...
Raise a NameError if a resource can not be found
diff --git a/recipes/cluster.rb b/recipes/cluster.rb index abc1234..def5678 100644 --- a/recipes/cluster.rb +++ b/recipes/cluster.rb @@ -25,21 +25,20 @@ cluster_nodes = node['rabbitmq']['clustering']['cluster_nodes'] cluster_nodes = cluster_nodes.to_json +auto_cluster_nodes = cluster_nodes +static_cluster_nodes = cl...
Fix resource cloning deprecation warnings
diff --git a/recipes/install.rb b/recipes/install.rb index abc1234..def5678 100644 --- a/recipes/install.rb +++ b/recipes/install.rb @@ -24,16 +24,6 @@ include_recipe 'yum-epel' if platform_family?('rhel') -# fedora >= 22 workaround -# dnf provider for fedora not yet in chef -# https://github.com/chef/chef/issues/3...
Remove the DNF workaround since Chef supports DNF now Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/app/controllers/users/profiles_controller.rb b/app/controllers/users/profiles_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users/profiles_controller.rb +++ b/app/controllers/users/profiles_controller.rb @@ -1,9 +1,13 @@ class Users::ProfilesController < Devise::SessionsController # be...
Add json endpoint for users
diff --git a/aptly.gemspec b/aptly.gemspec index abc1234..def5678 100644 --- a/aptly.gemspec +++ b/aptly.gemspec @@ -13,7 +13,6 @@ s.files = files.grep(/^(lib|bin)/) s.homepage = 'https://github.com/ryanuber/ruby-aptly' s.license = 'Apache 2.0' - s.executables = files.grep(/^bin/) { |f| Fi...
Remove unused executables line in gemspec
diff --git a/lib/serverspec/type/user.rb b/lib/serverspec/type/user.rb index abc1234..def5678 100644 --- a/lib/serverspec/type/user.rb +++ b/lib/serverspec/type/user.rb @@ -29,11 +29,11 @@ end def minimum_days_between_password_change - @runner.minimum_user_days_between_password_change(@name).stdout.to_i...
Use get_ prefix as per changes in serverspec
diff --git a/lib/bluecap/handlers/event.rb b/lib/bluecap/handlers/event.rb index abc1234..def5678 100644 --- a/lib/bluecap/handlers/event.rb +++ b/lib/bluecap/handlers/event.rb @@ -10,11 +10,12 @@ Time.at(timestamp).strftime('%Y%m%d') end - def key(name, timestamp=Time.now.to_i) + def key(name, times...
Set default timestamp in handle, not key
diff --git a/lib/cortex/snippets/client.rb b/lib/cortex/snippets/client.rb index abc1234..def5678 100644 --- a/lib/cortex/snippets/client.rb +++ b/lib/cortex/snippets/client.rb @@ -4,16 +4,18 @@ module Cortex module Snippets class Client + include ActionView::Helpers::TranslationHelper + def initial...
Modify expected block input + add TranslationHelper for content_tag
diff --git a/lib/descartes/models/users.rb b/lib/descartes/models/users.rb index abc1234..def5678 100644 --- a/lib/descartes/models/users.rb +++ b/lib/descartes/models/users.rb @@ -34,16 +34,12 @@ end def add_favorite(uuid) - preferences = JSON.parse(self.preferences) - preferences['favorites'].push(uuid)....
Revert "need to parse out preferences before adding/removing favorites" This reverts commit 4b8ecce1c2f19662e7c96f6272ad90482e4f89b2.
diff --git a/lib/dm-salesforce/property.rb b/lib/dm-salesforce/property.rb index abc1234..def5678 100644 --- a/lib/dm-salesforce/property.rb +++ b/lib/dm-salesforce/property.rb @@ -5,5 +5,3 @@ require 'dm-salesforce/property/serial' require 'dm-salesforce/property/boolean' -require 'dm-salesforce/property/integer' -...
Remove references to unecessary Integer and Float (in the DM1 case).
diff --git a/refinerycms-inquiries.gemspec b/refinerycms-inquiries.gemspec index abc1234..def5678 100644 --- a/refinerycms-inquiries.gemspec +++ b/refinerycms-inquiries.gemspec @@ -16,7 +16,7 @@ s.files = `git ls-files`.split("\n") s.test_files = `git ls-files -- spec/*`.split("\n") - s.add_d...
Use non dev versions for Refinery's extension dependencies.
diff --git a/memdash.gemspec b/memdash.gemspec index abc1234..def5678 100644 --- a/memdash.gemspec +++ b/memdash.gemspec @@ -11,7 +11,8 @@ gem.homepage = 'https://github.com/bryckbost/memdash' gem.add_dependency 'activerecord', '~> 3.0' - gem.add_dependency 'dalli', '~> 2.0' + gem.add_dependency 'dalli', ...
Add Sinatra as a run time dependency
diff --git a/core/app/models/spree/calculator/default_tax.rb b/core/app/models/spree/calculator/default_tax.rb index abc1234..def5678 100644 --- a/core/app/models/spree/calculator/default_tax.rb +++ b/core/app/models/spree/calculator/default_tax.rb @@ -23,7 +23,7 @@ end def compute_shipment(shipment) - ...
Use amount, not cost, to compute a shipment in default tax calculator
diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index abc1234..def5678 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -7,16 +7,16 @@ end def create_user(opt={ }) - email = opt[:email] || 'test@indeos.es' + @user_id_counter ||= 0 + id = @user_id_counter += 1 + email = opt[:em...
Add id to created users
diff --git a/lib/sequel/plugins/pg_trgm.rb b/lib/sequel/plugins/pg_trgm.rb index abc1234..def5678 100644 --- a/lib/sequel/plugins/pg_trgm.rb +++ b/lib/sequel/plugins/pg_trgm.rb @@ -3,7 +3,7 @@ module PgTrgm module DatasetMethods def text_search(column, query) - where("? % ?", column, query)...
Replace implicit SQL literal in filter method. Sequel 4.46 deprecated implicitly treating strings in filter methods as SQL literals, and encourages explicitly using Sequel.lit. https://github.com/jeremyevans/sequel/blob/master/CHANGELOG#L237
diff --git a/app/models/renalware/pathology/view_historical_observations.rb b/app/models/renalware/pathology/view_historical_observations.rb index abc1234..def5678 100644 --- a/app/models/renalware/pathology/view_historical_observations.rb +++ b/app/models/renalware/pathology/view_historical_observations.rb @@ -11,9 +1...
Remove unnecessary filtering on historical obs
diff --git a/spec/helpers/html_tag_spec.rb b/spec/helpers/html_tag_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/html_tag_spec.rb +++ b/spec/helpers/html_tag_spec.rb @@ -10,6 +10,10 @@ it "returns an simple self-closing tag with option" do tag("hr", :class => "thin").should == %[<hr class="thin" /...
Add test for the orphean tag on html_tag_helper
diff --git a/markdown-style.rb b/markdown-style.rb index abc1234..def5678 100644 --- a/markdown-style.rb +++ b/markdown-style.rb @@ -2,3 +2,5 @@ exclude_rule 'line-length' exclude_rule 'no-duplicate-header' + +rule 'ul-indent', :indent => 4
Allow unordered lists with four-space indentation By default, Markdown lint expects unordered lists to be indented using two spaces, but all lists here already use four: <https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md#md007---unordered-list-indentation>.
diff --git a/spec/hermod/xml_section_builder/integer_node_spec.rb b/spec/hermod/xml_section_builder/integer_node_spec.rb index abc1234..def5678 100644 --- a/spec/hermod/xml_section_builder/integer_node_spec.rb +++ b/spec/hermod/xml_section_builder/integer_node_spec.rb @@ -0,0 +1,29 @@+require "minitest_helper" + +modul...
Add tests for integer nodes Somehow this spec file was missed
diff --git a/lib/active_record/connection_adapters/clickhouse/oid/date_time.rb b/lib/active_record/connection_adapters/clickhouse/oid/date_time.rb index abc1234..def5678 100644 --- a/lib/active_record/connection_adapters/clickhouse/oid/date_time.rb +++ b/lib/active_record/connection_adapters/clickhouse/oid/date_time.rb...
Return back inspect for datetime type cast
diff --git a/config/initializers/_patch.rb b/config/initializers/_patch.rb index abc1234..def5678 100644 --- a/config/initializers/_patch.rb +++ b/config/initializers/_patch.rb @@ -1,4 +1,4 @@-# patch to correct utf8 string wrongly encoded as ASCII-8BIT +# patch to correct utf8 string wrongly encoded as ASCII-8BIT and ...
Patch ProxyPacRb to disallow use of proxypac on file system (for security)
diff --git a/config/initializers/sentry.rb b/config/initializers/sentry.rb index abc1234..def5678 100644 --- a/config/initializers/sentry.rb +++ b/config/initializers/sentry.rb @@ -0,0 +1,6 @@+Raven.configure do |config| + config.processors -= [Raven::Processor::PostData] # Send POST data + config.processors -= [Rave...
Send POST data and cookies with Sentry
diff --git a/config/initializers/tmpdir.rb b/config/initializers/tmpdir.rb index abc1234..def5678 100644 --- a/config/initializers/tmpdir.rb +++ b/config/initializers/tmpdir.rb @@ -1,7 +1,9 @@ # frozen_string_literal: true -class Dir - def self.tmpdir - OpenWebslides.config.tmpdir.to_s +unless Rails.env.test? + ...
Allow Travis to pass upload test
diff --git a/whitesimilarity.gemspec b/whitesimilarity.gemspec index abc1234..def5678 100644 --- a/whitesimilarity.gemspec +++ b/whitesimilarity.gemspec @@ -10,7 +10,7 @@ spec.email = ['elpapapollo@gmail.com'] spec.description = %q{An implementation of the White Similarity Algorithm in C} spec.summary...
Add homepage and remove development dependency 'rake-compiler'
diff --git a/config/puma.rb b/config/puma.rb index abc1234..def5678 100644 --- a/config/puma.rb +++ b/config/puma.rb @@ -1,2 +1,3 @@ port ENV['PORT'] || 3000 environment ENV['RAILS_ENV'] || 'development' +threads 0, 16
Set the default number of threads
diff --git a/db/migrate/20170706125048_add_daily_menus.rb b/db/migrate/20170706125048_add_daily_menus.rb index abc1234..def5678 100644 --- a/db/migrate/20170706125048_add_daily_menus.rb +++ b/db/migrate/20170706125048_add_daily_menus.rb @@ -3,7 +3,7 @@ create_table :daily_menus do |t| t.datetime :date, null:...
Add cascade to foreign key
diff --git a/spec/defines/osx_defaults_spec.rb b/spec/defines/osx_defaults_spec.rb index abc1234..def5678 100644 --- a/spec/defines/osx_defaults_spec.rb +++ b/spec/defines/osx_defaults_spec.rb @@ -0,0 +1,34 @@+require 'spec_helper' + +describe 'boxen::osx_defaults' do + let(:title) { 'example' } + let(:domain) { 'co...
Add simple specs around boxen::osx_defaults
diff --git a/spec/helpers/users_helper_spec.rb b/spec/helpers/users_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/users_helper_spec.rb +++ b/spec/helpers/users_helper_spec.rb @@ -1,15 +1,7 @@ require 'rails_helper' -# Specs in this file have access to a helper object that includes -# the UsersHelper...
Add User Helper Spec File
diff --git a/spec/requests/rails_admin_spec.rb b/spec/requests/rails_admin_spec.rb index abc1234..def5678 100644 --- a/spec/requests/rails_admin_spec.rb +++ b/spec/requests/rails_admin_spec.rb @@ -11,4 +11,16 @@ end end + # A common mistake for translators is to forget to change the YAML file's + # root key ...
Add test to ensure English localization is working. A common mistake for translators is to forget to change the YAML file's root key from en to their own locale (as people tend to use the English file as template for a new translation).
diff --git a/lib/cangaroo/webhook/client.rb b/lib/cangaroo/webhook/client.rb index abc1234..def5678 100644 --- a/lib/cangaroo/webhook/client.rb +++ b/lib/cangaroo/webhook/client.rb @@ -14,7 +14,23 @@ def post(payload, request_id, parameters) request_body = body(payload, request_id, parameters).to_json ...
Send POST with connection key as HTTP basic auth password when enabled
diff --git a/lib/modules/comfy_opengraph.rb b/lib/modules/comfy_opengraph.rb index abc1234..def5678 100644 --- a/lib/modules/comfy_opengraph.rb +++ b/lib/modules/comfy_opengraph.rb @@ -37,7 +37,7 @@ def get_fragment_value(fragment) if fragment.tag =~ /file/ # get path when fragment is file - # URI.join(ro...
Put back code commented out
diff --git a/lib/vagrant-managed-servers.rb b/lib/vagrant-managed-servers.rb index abc1234..def5678 100644 --- a/lib/vagrant-managed-servers.rb +++ b/lib/vagrant-managed-servers.rb @@ -1,6 +1,7 @@ require "pathname" require "vagrant-managed-servers/plugin" +require "vagrant-winrm-syncedfolders/plugin" module Vagr...
Add a require statement so that the vagrant-winrm-syncedfolders plugin is loaded This will force the `vagrant-winrm-syncedfolders` plugin to be loaded.
diff --git a/lib/open_food_network/user_balance_calculator.rb b/lib/open_food_network/user_balance_calculator.rb index abc1234..def5678 100644 --- a/lib/open_food_network/user_balance_calculator.rb +++ b/lib/open_food_network/user_balance_calculator.rb @@ -6,7 +6,7 @@ end def balance - -completed_orders...
Convert relation to array to be able to use sum
diff --git a/lib/capistrano/lephare/defaults.rb b/lib/capistrano/lephare/defaults.rb index abc1234..def5678 100644 --- a/lib/capistrano/lephare/defaults.rb +++ b/lib/capistrano/lephare/defaults.rb @@ -31,3 +31,5 @@ set :mysqldump_args, "--opt --single-transaction" set :db_pull_filename, "app/Resources/database/#{fet...
Add default value for crontab
diff --git a/lib/capistrano/tasks/database.rake b/lib/capistrano/tasks/database.rake index abc1234..def5678 100644 --- a/lib/capistrano/tasks/database.rake +++ b/lib/capistrano/tasks/database.rake @@ -1,3 +1,8 @@+def system_v(cmd) + info "Execute '#{cmd}'" + system cmd +end + desc 'Copy database from the server to y...
Make cap task db2local more robust and verbose - "--password=" instead of "-p " for compatibility with different mysql versions - log all locally executed commands
diff --git a/roles/osx-ah.rb b/roles/osx-ah.rb index abc1234..def5678 100644 --- a/roles/osx-ah.rb +++ b/roles/osx-ah.rb @@ -0,0 +1,8 @@+name "osx-ah" +description "This role is specific to machines require the software loadset for the Center for the Arts" + + # Include the classlab role, which contains the ba...
Add Art History role with OIV dock attribute
diff --git a/lib/psd/layer_info/unicode_name.rb b/lib/psd/layer_info/unicode_name.rb index abc1234..def5678 100644 --- a/lib/psd/layer_info/unicode_name.rb +++ b/lib/psd/layer_info/unicode_name.rb @@ -6,8 +6,7 @@ def parse pos = @file.tell - len = @file.read_int * 2 - @data = @file.read(len).unpa...
Fix parsing and decoding of UTF-16 layer name.
diff --git a/lib/rrj/models/concerns/methods.rb b/lib/rrj/models/concerns/methods.rb index abc1234..def5678 100644 --- a/lib/rrj/models/concerns/methods.rb +++ b/lib/rrj/models/concerns/methods.rb @@ -10,8 +10,8 @@ # Create thread keepalive def create_keepalive - ::Log.info "Janus Instance #{name}...
Fix test for create thread keepalive
diff --git a/lib/graphql/types/relay/base_connection.rb b/lib/graphql/types/relay/base_connection.rb index abc1234..def5678 100644 --- a/lib/graphql/types/relay/base_connection.rb +++ b/lib/graphql/types/relay/base_connection.rb @@ -24,6 +24,10 @@ # end # class Types::PostConnection < Types::BaseConnec...
Add example of nullable options to Types::Relay::BaseConnection
diff --git a/lib/rubocop/cop/lint/useless_comparison.rb b/lib/rubocop/cop/lint/useless_comparison.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/lint/useless_comparison.rb +++ b/lib/rubocop/cop/lint/useless_comparison.rb @@ -10,18 +10,14 @@ # x.top >= x.top class UselessComparison < Cop M...
Modify Lint/UselessComparison to use NodePattern
diff --git a/csv_to_popolo.gemspec b/csv_to_popolo.gemspec index abc1234..def5678 100644 --- a/csv_to_popolo.gemspec +++ b/csv_to_popolo.gemspec @@ -19,6 +19,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.6" + spec.add_development_dependency "json-schema", "~> 2.0.0" spec....
Add development dependency on json-schema
diff --git a/site-cookbooks/backup_restore/spec/recipes/configure_ruby_spec.rb b/site-cookbooks/backup_restore/spec/recipes/configure_ruby_spec.rb index abc1234..def5678 100644 --- a/site-cookbooks/backup_restore/spec/recipes/configure_ruby_spec.rb +++ b/site-cookbooks/backup_restore/spec/recipes/configure_ruby_spec.rb...
Add chef-spec for configuire_ruby recipe
diff --git a/week-4/good-guess/my_solution.rb b/week-4/good-guess/my_solution.rb index abc1234..def5678 100644 --- a/week-4/good-guess/my_solution.rb +++ b/week-4/good-guess/my_solution.rb @@ -1,6 +1,7 @@ # Good Guess -# I worked on this challenge [by myself, with: ]. - - +# I worked on this challenge Abe and Brian. ...
Insert the files and codes
diff --git a/pulitzer.gemspec b/pulitzer.gemspec index abc1234..def5678 100644 --- a/pulitzer.gemspec +++ b/pulitzer.gemspec @@ -26,9 +26,9 @@ s.add_dependency "carrierwave" s.add_dependency "carrierwave-aws" s.add_dependency "mini_magick" - s.add_dependency "cancancan" s.add_development_dependency "sqlit...
Move back cancan only as a dev dependency
diff --git a/readthis.gemspec b/readthis.gemspec index abc1234..def5678 100644 --- a/readthis.gemspec +++ b/readthis.gemspec @@ -22,6 +22,6 @@ spec.add_development_dependency 'activesupport', '> 4.0' spec.add_development_dependency 'bundler', '~> 1.16' spec.add_development_dependency 'hiredis', '~> 0.6' - spec...
Update rake requirement from ~> 12.3 to ~> 13.0 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/compare/v...
diff --git a/lib/bosh/inception/cli_helpers/settings.rb b/lib/bosh/inception/cli_helpers/settings.rb index abc1234..def5678 100644 --- a/lib/bosh/inception/cli_helpers/settings.rb +++ b/lib/bosh/inception/cli_helpers/settings.rb @@ -8,7 +8,7 @@ # Defaults to ~/.bosh_inception; and can be overridden with either: ...
Expand $SETTINGS or ~/.bosh_inception path before using
diff --git a/spec/parameter_handler_spec.rb b/spec/parameter_handler_spec.rb index abc1234..def5678 100644 --- a/spec/parameter_handler_spec.rb +++ b/spec/parameter_handler_spec.rb @@ -7,7 +7,7 @@ describe "ParameterHandler" do include Helpers::Examples - describe "valid" do + context "valid" do before(:all...
Use the RSpec context method.
diff --git a/lib/generators/anonymous_user_generator.rb b/lib/generators/anonymous_user_generator.rb index abc1234..def5678 100644 --- a/lib/generators/anonymous_user_generator.rb +++ b/lib/generators/anonymous_user_generator.rb @@ -1,4 +1,4 @@-class AnonymousUserGenerator < Rails::Generators::NamedBase +class Anonymou...
Use Base instead of NamedBase.
diff --git a/spec/error_spec.rb b/spec/error_spec.rb index abc1234..def5678 100644 --- a/spec/error_spec.rb +++ b/spec/error_spec.rb @@ -0,0 +1,15 @@+describe 'Error' do + + it 'raises returned errors' do + + http_client = double(MessageBird::HttpClient) + client = MessageBird::Client.new('', http_client) + + ...
Add test to assert errors are raised when returend by service
diff --git a/spec/spec_suite.rb b/spec/spec_suite.rb index abc1234..def5678 100644 --- a/spec/spec_suite.rb +++ b/spec/spec_suite.rb @@ -6,15 +6,15 @@ end def run_core_examples - system("ruby #{dir}/core_spec_suite.rb #{spec_opts}") || raise("Core suite Failed") + system("ruby -W #{dir}/core_spec_suite.rb ...
Enable Ruby warnings during spec suite
diff --git a/textrazor.gemspec b/textrazor.gemspec index abc1234..def5678 100644 --- a/textrazor.gemspec +++ b/textrazor.gemspec @@ -26,4 +26,5 @@ spec.add_development_dependency "rspec", "~> 3.0.0" spec.add_development_dependency "pry" spec.add_development_dependency "pry-byebug" + spec.add_development_depend...
Add dotenv as a development dependency Signed-off-by: Aymeric Brisse <a462d6a602eb500679b027b39ff035d803cbe1e9@perfect-memory.com>
diff --git a/tiny_tds.gemspec b/tiny_tds.gemspec index abc1234..def5678 100644 --- a/tiny_tds.gemspec +++ b/tiny_tds.gemspec @@ -11,5 +11,7 @@ s.authors = ['Ken Collins', 'Erik Bryn'] s.email = 'ken@metaskills.net' s.extensions = ['ext/tiny_tds/extconf.rb'] - s.files = Dir['CHANGELOG', 'MIT-LICENSE', 'README.r...
Use git existing files to build gem files manifest
diff --git a/spec/models/bootstrap_haml_helpers/scaffolding/container_spec.rb b/spec/models/bootstrap_haml_helpers/scaffolding/container_spec.rb index abc1234..def5678 100644 --- a/spec/models/bootstrap_haml_helpers/scaffolding/container_spec.rb +++ b/spec/models/bootstrap_haml_helpers/scaffolding/container_spec.rb @@ ...
Add container spec from lux.
diff --git a/lib/ffi.rb b/lib/ffi.rb index abc1234..def5678 100644 --- a/lib/ffi.rb +++ b/lib/ffi.rb @@ -13,7 +13,7 @@ require 'ffi/ffi' -elsif defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby' +elsif defined?(RUBY_ENGINE) && (RUBY_ENGINE == 'jruby' || RUBY_ENGINE == 'rbx') $LOAD_PATH.delete(File.dirname(__FILE_...
Apply JRuby loading logic to rbx as well
diff --git a/lib/fog/providers.rb b/lib/fog/providers.rb index abc1234..def5678 100644 --- a/lib/fog/providers.rb +++ b/lib/fog/providers.rb @@ -14,6 +14,7 @@ require 'fog/providers/ecloud' require 'fog/providers/go_grid' require 'fog/providers/google' +require 'fog/providers/hp' require 'fog/providers/linode' requ...
Add a new HP provider.
diff --git a/lib/pagelime-rack.rb b/lib/pagelime-rack.rb index abc1234..def5678 100644 --- a/lib/pagelime-rack.rb +++ b/lib/pagelime-rack.rb @@ -1,2 +1,9 @@-require 'pagelime' -require 'rack/pagelime' +require_relative 'pagelime' +require_relative 'pagelime/s3_client' +require_relative 'pagelime/xml_processor' +require...
Use configure block to setup defaults
diff --git a/vendor/dotenv.rb b/vendor/dotenv.rb index abc1234..def5678 100644 --- a/vendor/dotenv.rb +++ b/vendor/dotenv.rb @@ -2,6 +2,12 @@ file = File.expand_path("../../.env", __FILE__) if File.exists?(file) File.read(file).split("\n").map {|x| x.split("=") }.each do |k,v| - ENV[k.strip] = v.strip + if k....
Add check for the word export in .env
diff --git a/lib/royce/methods.rb b/lib/royce/methods.rb index abc1234..def5678 100644 --- a/lib/royce/methods.rb +++ b/lib/royce/methods.rb @@ -39,7 +39,7 @@ def has_role? name # grab each role name and check for inclusion - roles.pluck(:name).include?(name.to_s) + roles.exists?(name: name.to_s)...
Use exists? to test for presence of a role.
diff --git a/test-page.gemspec b/test-page.gemspec index abc1234..def5678 100644 --- a/test-page.gemspec +++ b/test-page.gemspec @@ -16,4 +16,5 @@ gem.version = Test::Page::VERSION gem.add_development_dependency "rspec", "~>2.0" + gem.add_development_dependency "simplecov" end
Add SimpleCov for development dependency.
diff --git a/lib/tasks/metro.rake b/lib/tasks/metro.rake index abc1234..def5678 100644 --- a/lib/tasks/metro.rake +++ b/lib/tasks/metro.rake @@ -1,6 +1,26 @@ namespace :metro do - desc "Import metro data from go-metro.com" task import: :environment do + desc "Import metro data from go-metro.com" Metro::Impo...
Add rake task to titleize existing data
diff --git a/features/step_definitions/filtering_steps.rb b/features/step_definitions/filtering_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/filtering_steps.rb +++ b/features/step_definitions/filtering_steps.rb @@ -4,7 +4,6 @@ end Then(/^I can get a list of all documents with matching metad...
Remove some duplication in steps Stubbing the content store again in these steps isn't needed.
diff --git a/pagelapse.gemspec b/pagelapse.gemspec index abc1234..def5678 100644 --- a/pagelapse.gemspec +++ b/pagelapse.gemspec @@ -20,4 +20,6 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" + spec.add_dependency "capybara" + spec.add_dependency "poltergeist" end...
Add capybara dependencies to gemspec
diff --git a/omnibus-ansible-dk/config/projects/ansible-dk.rb b/omnibus-ansible-dk/config/projects/ansible-dk.rb index abc1234..def5678 100644 --- a/omnibus-ansible-dk/config/projects/ansible-dk.rb +++ b/omnibus-ansible-dk/config/projects/ansible-dk.rb @@ -2,8 +2,8 @@ maintainer "OmniTI" homepage "https://github.com/o...
Fix project name in comments in project file
diff --git a/lib/cerberus/builder/maven2.rb b/lib/cerberus/builder/maven2.rb index abc1234..def5678 100644 --- a/lib/cerberus/builder/maven2.rb +++ b/lib/cerberus/builder/maven2.rb @@ -8,7 +8,8 @@ def run Dir.chdir @config[:application_root] cmd = @config[:builder, :maven2, :cmd] || 'mvn' - @output = `#{...
Set default task of Maven2 builder to 'test' git-svn-id: 6b26ca77393dff49db3326cae3426b51e4e94954@65 65aa75ef-ce15-0410-bc34-cdc86d5f77e6
diff --git a/test/html_renderer_test.rb b/test/html_renderer_test.rb index abc1234..def5678 100644 --- a/test/html_renderer_test.rb +++ b/test/html_renderer_test.rb @@ -11,7 +11,7 @@ binding_klass.expect :today, Time.now.to_s binding_klass.expect :last_updated, Time.now.to_s - renderer = Mako::HTMLRendere...
Change arg from binding to bound
diff --git a/upcoming.gemspec b/upcoming.gemspec index abc1234..def5678 100644 --- a/upcoming.gemspec +++ b/upcoming.gemspec @@ -13,7 +13,7 @@ s.required_ruby_version = '>= 2.0' - s.add_dependency 'activesupport', '~> 4.1' + s.add_dependency 'activesupport', '~> 5.0' %w(rake minitest-given).each do |d| ...
Allow activesupport 5.x in dependencies
diff --git a/spec/models/task_user_spec.rb b/spec/models/task_user_spec.rb index abc1234..def5678 100644 --- a/spec/models/task_user_spec.rb +++ b/spec/models/task_user_spec.rb @@ -3,9 +3,9 @@ describe TaskUser do before(:each) do @valid_attributes = { - :user_id => 1, - :task_id => 1, - :unread ...
Update specs: use factory instead of magic numbers in TaskUser spec.