diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/java_spec.rb b/spec/java_spec.rb index abc1234..def5678 100644 --- a/spec/java_spec.rb +++ b/spec/java_spec.rb @@ -6,19 +6,16 @@ set_java_version(app.directory, jdk_version) app.setup! app.set_config("JVM_COMMON_BUILDPACK" => "https://github.com/heroku/heroku-buildpack-jvm-common/tarball...
Set the default buildpack url for the java sample to the master branch of the java buildpack repo
diff --git a/spec/support/all/bad_tests.rb b/spec/support/all/bad_tests.rb index abc1234..def5678 100644 --- a/spec/support/all/bad_tests.rb +++ b/spec/support/all/bad_tests.rb @@ -4,7 +4,6 @@ next if file.closed? next if file.path == '/dev/null' next if file.path.end_with? '.pry_history' - nex...
Stop checking for open zxcvbn.js files in specs
diff --git a/lib/keep_track/creation.rb b/lib/keep_track/creation.rb index abc1234..def5678 100644 --- a/lib/keep_track/creation.rb +++ b/lib/keep_track/creation.rb @@ -4,17 +4,19 @@ included do after_create do - user = nil - if not self.activity_user.nil? + if self.activity_user ...
Clean up the code and allow tracked :user to be Proc or a Symbol/String, setting activity_user on a tracked object takes priority over :user attribute in model definition
diff --git a/RxKeyboard.podspec b/RxKeyboard.podspec index abc1234..def5678 100644 --- a/RxKeyboard.podspec +++ b/RxKeyboard.podspec @@ -11,8 +11,8 @@ s.frameworks = 'UIKit', 'Foundation' s.requires_arc = true - s.dependency 'RxSwift', '>= 4.1.2' - s.dependency 'RxCocoa', '>= 4.1.2' + s.dependency '...
Fix supported Swift version to 4.0.0
diff --git a/lib/travis/builder/base.rb b/lib/travis/builder/base.rb index abc1234..def5678 100644 --- a/lib/travis/builder/base.rb +++ b/lib/travis/builder/base.rb @@ -18,7 +18,7 @@ def buildable @buildable ||= Travis::Buildable.new( - :script => 'bundle exec rake', + :script => 'rak...
Revert "Shouldn't we use bundle exec rake?" This reverts commit 13ebda7a9eb2cb70ddd197d91108a5c814544299.
diff --git a/config/initializers/transam_transit_extensions.rb b/config/initializers/transam_transit_extensions.rb index abc1234..def5678 100644 --- a/config/initializers/transam_transit_extensions.rb +++ b/config/initializers/transam_transit_extensions.rb @@ -1,8 +1,5 @@ # Technique caged from http://stackoverflow.com...
Fix double loading of asset extensions for transit asset classes
diff --git a/ab.gemspec b/ab.gemspec index abc1234..def5678 100644 --- a/ab.gemspec +++ b/ab.gemspec @@ -19,10 +19,8 @@ spec.test_files = `git ls-files -- {spec}/*`.split("\n") spec.require_paths = ['lib'] - spec.add_development_dependency 'rake', '~> 10.3' + spec.add_development_dependency 'rake', '~> 11.0' ...
Update gemspec with newer gem versions
diff --git a/aggregate.gemspec b/aggregate.gemspec index abc1234..def5678 100644 --- a/aggregate.gemspec +++ b/aggregate.gemspec @@ -15,7 +15,7 @@ "LICENSE", "README.textile" ] - s.files = `git ls-files -z`.split("\x0") + s.files = Dir.glob("**/*") s.homepage = %q{http://github.com/josephruscio/aggreg...
Use Dir.glob instead of git ls-files
diff --git a/db/migrate/20131203025507_question_translation.rb b/db/migrate/20131203025507_question_translation.rb index abc1234..def5678 100644 --- a/db/migrate/20131203025507_question_translation.rb +++ b/db/migrate/20131203025507_question_translation.rb @@ -1,4 +1,4 @@-class QuestionTranslation < ActiveRecord::Migra...
Fix name conflict in migration
diff --git a/lib/arug/trader/money.rb b/lib/arug/trader/money.rb index abc1234..def5678 100644 --- a/lib/arug/trader/money.rb +++ b/lib/arug/trader/money.rb @@ -8,15 +8,6 @@ def initialize(amount, currency) @amount = BigDecimal.new(amount.to_s) @currency = currency.upcase - end - - def...
Remove superfluous addition definition on Money.
diff --git a/tests/spec/features/highlighting_error_output_spec.rb b/tests/spec/features/highlighting_error_output_spec.rb index abc1234..def5678 100644 --- a/tests/spec/features/highlighting_error_output_spec.rb +++ b/tests/spec/features/highlighting_error_output_spec.rb @@ -12,7 +12,7 @@ within('.output-stderr') ...
Update regex for failing to compile
diff --git a/omf_common/omf_common.gemspec b/omf_common/omf_common.gemspec index abc1234..def5678 100644 --- a/omf_common/omf_common.gemspec +++ b/omf_common/omf_common.gemspec @@ -20,6 +20,7 @@ # specify any dependencies here; for example: s.add_development_dependency "minitest", "~> 3.2" + s.add_development_d...
Include EM minispec in required dev gems
diff --git a/lib/couch_blog/engine.rb b/lib/couch_blog/engine.rb index abc1234..def5678 100644 --- a/lib/couch_blog/engine.rb +++ b/lib/couch_blog/engine.rb @@ -6,8 +6,7 @@ require 'cmtool' Cmtool::Menu.register do append_to :publications do - resource_link CouchBlog::Post, scope:...
Add label to cmtool menu item
diff --git a/Ruby/lib/rack-mini-profiler.rb b/Ruby/lib/rack-mini-profiler.rb index abc1234..def5678 100644 --- a/Ruby/lib/rack-mini-profiler.rb +++ b/Ruby/lib/rack-mini-profiler.rb @@ -1,6 +1,6 @@ require 'mini_profiler/profiler' require 'patches/sql_patches' -if defined?(::Rails) && ::Rails::VERSION::MAJOR.to_i == ...
Load railtie under Rails 4.x
diff --git a/lib/ephemeral/app/api.rb b/lib/ephemeral/app/api.rb index abc1234..def5678 100644 --- a/lib/ephemeral/app/api.rb +++ b/lib/ephemeral/app/api.rb @@ -11,5 +11,6 @@ format :json group(:builds) { mount Ephemeral::Resources::Build } + group(:files) { mount Ephemeral::Resources::File } end end...
Add files group to API
diff --git a/git_pissed.gemspec b/git_pissed.gemspec index abc1234..def5678 100644 --- a/git_pissed.gemspec +++ b/git_pissed.gemspec @@ -7,9 +7,9 @@ spec.name = 'git_pissed' spec.version = GitPissed::VERSION spec.authors = ['Chris Hunt'] - spec.email = ['chrishunt@github.com'] - s...
Add description and summary to gemspec
diff --git a/lib/merb_activerecord.rb b/lib/merb_activerecord.rb index abc1234..def5678 100644 --- a/lib/merb_activerecord.rb +++ b/lib/merb_activerecord.rb @@ -1,10 +1,17 @@-if defined?(Merb::Plugins) +if defined?(Merb::Plugins) dependency "activerecord" require File.join(File.dirname(__FILE__) / "merb" / "orm...
Revert "Use simple before_app_loads hook instead of bootloader subclass." This reverts commit a15f43ae003cc68c671ab325586fa026f5673373.
diff --git a/lib/mumukit/auth/user.rb b/lib/mumukit/auth/user.rb index abc1234..def5678 100644 --- a/lib/mumukit/auth/user.rb +++ b/lib/mumukit/auth/user.rb @@ -2,23 +2,29 @@ class Mumukit::Auth::User - attr_accessor :social_id, :user + attr_accessor :social_id, :user, :metadata def initialize(social_id) ...
Refactor to support when no permissions
diff --git a/lib/number_recognizer.rb b/lib/number_recognizer.rb index abc1234..def5678 100644 --- a/lib/number_recognizer.rb +++ b/lib/number_recognizer.rb @@ -1,4 +1,10 @@ class NumberRecognizer + KNOWN_FORMATS = { + 'Dutch mobile' => [316, 8], + 'Belgian mobile' => [324, 8], + 'Suriname' => [597,7], + '...
Use a lookup table instead of hand-crafted method to match a number
diff --git a/upstreamer.gemspec b/upstreamer.gemspec index abc1234..def5678 100644 --- a/upstreamer.gemspec +++ b/upstreamer.gemspec @@ -23,6 +23,7 @@ spec.require_paths = ["lib"] spec.add_runtime_dependency "octokit" + spec.add_runtime_dependency "rugged" spec.add_development_dependency "bundler", "~> 1.7" ...
Add rugged as runtime dependency
diff --git a/lib/spotify/api/inbox.rb b/lib/spotify/api/inbox.rb index abc1234..def5678 100644 --- a/lib/spotify/api/inbox.rb +++ b/lib/spotify/api/inbox.rb @@ -1,8 +1,32 @@ module Spotify class API # @!group Inbox + + # Post an array of tracks to a Spotify user's inbox. + # + # @example + # track...
Add documentation for Inbox subsystem
diff --git a/app/models/hint.rb b/app/models/hint.rb index abc1234..def5678 100644 --- a/app/models/hint.rb +++ b/app/models/hint.rb @@ -1,7 +1,7 @@ class Hint < ActiveRecord::Base validates :hint, presence: true, length: { maximum: 500 } validates :priority, presence: true, numericality: true - validates :point...
Remove limit in point value and fix error messages
diff --git a/lib/tasks/aggregate.rake b/lib/tasks/aggregate.rake index abc1234..def5678 100644 --- a/lib/tasks/aggregate.rake +++ b/lib/tasks/aggregate.rake @@ -0,0 +1,37 @@+namespace :aggregate do + namespace :hourly do + desc "Aggregate hourly impressions for every impression every recorded." + task all: :envi...
Add tasks to generate hourly aggregations.
diff --git a/app/models/page.rb b/app/models/page.rb index abc1234..def5678 100644 --- a/app/models/page.rb +++ b/app/models/page.rb @@ -4,7 +4,6 @@ class Page < ActiveRecord::Base validates :url, presence: true, url: true - after_save :populate_content attr_accessible :content, :url
Remove after_save callback which seemed to be causing infinite loop
diff --git a/lib/punchblock/dsl.rb b/lib/punchblock/dsl.rb index abc1234..def5678 100644 --- a/lib/punchblock/dsl.rb +++ b/lib/punchblock/dsl.rb @@ -20,12 +20,12 @@ write @protocol::Hangup.new end - def reject(reason = :declined) # :nodoc: - write @protocol::Reject.new(reason) + def reject(reaso...
Update DSL for options hash requirement
diff --git a/spec/bundler/installer/gem_installer_spec.rb b/spec/bundler/installer/gem_installer_spec.rb index abc1234..def5678 100644 --- a/spec/bundler/installer/gem_installer_spec.rb +++ b/spec/bundler/installer/gem_installer_spec.rb @@ -20,6 +20,7 @@ it "invokes install method with build_args", :rubygems => ">=...
Remove several CLI flags that need to be set via config in Bundler 2
diff --git a/Casks/qlstephen.rb b/Casks/qlstephen.rb index abc1234..def5678 100644 --- a/Casks/qlstephen.rb +++ b/Casks/qlstephen.rb @@ -2,7 +2,7 @@ version '1.4.3' sha256 '73f9a467ba2eb4244ffe1dbf9be435d3481a438c8ec64d2bd9bb1ba60d576a66' - # github.com/downloads/whomwah/qlstephen was verified as official when ...
Fix `url` stanza comment for QLStephen.
diff --git a/Casks/tangerine.rb b/Casks/tangerine.rb index abc1234..def5678 100644 --- a/Casks/tangerine.rb +++ b/Casks/tangerine.rb @@ -9,6 +9,8 @@ homepage 'https://www.karelia.com/products/tangerine/' license :commercial + auto_updates true + app 'Tangerine!.app' postflight do
Add auto_updates flag to Tangerine!
diff --git a/lib/yubioath/reset.rb b/lib/yubioath/reset.rb index abc1234..def5678 100644 --- a/lib/yubioath/reset.rb +++ b/lib/yubioath/reset.rb @@ -0,0 +1,17 @@+require 'yubioath' +require 'bindata' + +module YubiOATH + class Reset + def self.send(to:) + ::YubiOATH::Response.read(to.transmit(Request.new.to_bi...
Implement the 'Reset' instruction, but don't expose it via the CLI
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -6,8 +6,6 @@ # cities = City.create([{ name: 'Chicago' }, { name: 'Copenhagen' }]) # Mayor.create(name: 'Emanuel', city: cities.first) -Page.create(title: 'Home', content: 'home', published: true, url: 'ho...
Fix uninitialized constant during db setup Fixes #92
diff --git a/api/config/initializers/cors.rb b/api/config/initializers/cors.rb index abc1234..def5678 100644 --- a/api/config/initializers/cors.rb +++ b/api/config/initializers/cors.rb @@ -13,7 +13,7 @@ 'https://lachlan.hackclub.com', 'http://lachlan.hackclub.com', ...
Fix typo in CORS initializer
diff --git a/config/initializers/rails_admin.rb b/config/initializers/rails_admin.rb index abc1234..def5678 100644 --- a/config/initializers/rails_admin.rb +++ b/config/initializers/rails_admin.rb @@ -45,4 +45,13 @@ end end + config.model 'Document' do + list do + field :id + field :name + f...
Remove Data form admin view of Documents Data is generally large and it is not useful to load it. Increases page load time and transfers a lot of data to browser
diff --git a/lib/app/routes/exercises.rb b/lib/app/routes/exercises.rb index abc1234..def5678 100644 --- a/lib/app/routes/exercises.rb +++ b/lib/app/routes/exercises.rb @@ -1,19 +1,21 @@ module Xapi module Routes class Exercises < Core + helpers do + def require_key + unless params[:key] + ...
Move guard into helper method
diff --git a/lib/bench_press/runnable.rb b/lib/bench_press/runnable.rb index abc1234..def5678 100644 --- a/lib/bench_press/runnable.rb +++ b/lib/bench_press/runnable.rb @@ -25,6 +25,7 @@ def run r,w = IO.pipe fork do + GC.disable run_it time = Benchmark.realtime do ...
Disable garbage collector when benchmarking
diff --git a/lib/bundler/cli/platform.rb b/lib/bundler/cli/platform.rb index abc1234..def5678 100644 --- a/lib/bundler/cli/platform.rb +++ b/lib/bundler/cli/platform.rb @@ -9,7 +9,7 @@ def run platforms, ruby_version = Bundler.ui.silence do [Bundler.definition.platforms.map {|p| "* #{p}" }, - ...
[Platform] Print out an exact version from the lockfile
diff --git a/lib/chart/receivers/line.rb b/lib/chart/receivers/line.rb index abc1234..def5678 100644 --- a/lib/chart/receivers/line.rb +++ b/lib/chart/receivers/line.rb @@ -1,3 +1,5 @@+require 'chart/topic' + module Chart module Receivers class Line @@ -12,15 +14,7 @@ def guess_config_for(topic) ...
Make config guessing the same on the client as the server
diff --git a/spec/features/thredded/user_tracks_read_topics_and_posts_spec.rb b/spec/features/thredded/user_tracks_read_topics_and_posts_spec.rb index abc1234..def5678 100644 --- a/spec/features/thredded/user_tracks_read_topics_and_posts_spec.rb +++ b/spec/features/thredded/user_tracks_read_topics_and_posts_spec.rb @@ ...
Work around mysterious test failure
diff --git a/spec_support.gemspec b/spec_support.gemspec index abc1234..def5678 100644 --- a/spec_support.gemspec +++ b/spec_support.gemspec @@ -18,4 +18,5 @@ s.test_files = Dir["spec/**/*"] s.add_development_dependency "rspec" + s.add_dependency "jruby-openssl" end
Add jruby-openssl as a dependency for jruby in the gemspec
diff --git a/app/mailers/georgia/notifier.rb b/app/mailers/georgia/notifier.rb index abc1234..def5678 100644 --- a/app/mailers/georgia/notifier.rb +++ b/app/mailers/georgia/notifier.rb @@ -13,7 +13,6 @@ end def notify_admins(message, url) - return if Rails.env.development? or Rails.env.test? @mes...
Send emails in dev too, use letter_opener in main app
diff --git a/app/models/build/bower_error.rb b/app/models/build/bower_error.rb index abc1234..def5678 100644 --- a/app/models/build/bower_error.rb +++ b/app/models/build/bower_error.rb @@ -2,16 +2,17 @@ # Encapsulate Bower errors # parsed from Bower JSON output class BowerError < BuildError - attr_reader :pa...
Add a stacktrace if present from Bower
diff --git a/approvals.gemspec b/approvals.gemspec index abc1234..def5678 100644 --- a/approvals.gemspec +++ b/approvals.gemspec @@ -23,7 +23,12 @@ s.add_development_dependency 'rspec', '~> 3.1' s.add_dependency 'thor', '~> 0.18' - s.add_dependency 'nokogiri', '~> 1.6' + + if RUBY_VERSION < "2.1" + s.add_de...
:open_hands: Support EOL Ruby versions by locking Nokogiri to pre v1.7
diff --git a/erm.gemspec b/erm.gemspec index abc1234..def5678 100644 --- a/erm.gemspec +++ b/erm.gemspec @@ -1,6 +1,6 @@ require "rubygems" -$:.unshift File.join(File.dirname(__FILE__), *%w[.. lib]) +$:.unshift File.join(File.dirname(__FILE__), "lib") require "erm/version" Gem::Specification.new do |s|
Fix gem spec lib path
diff --git a/app/mailers/adhoc_mailer.rb b/app/mailers/adhoc_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/adhoc_mailer.rb +++ b/app/mailers/adhoc_mailer.rb @@ -3,7 +3,7 @@ default from: ENV.fetch('FROM_EMAIL') def send_adhoc_email(subject, body, user_ids) - users = User.where("id IN (?)", user_id...
Use hash condition in where.
diff --git a/lib/geocoder/models/base.rb b/lib/geocoder/models/base.rb index abc1234..def5678 100644 --- a/lib/geocoder/models/base.rb +++ b/lib/geocoder/models/base.rb @@ -28,7 +28,7 @@ private # ---------------------------------------------------------------- def geocoder_init(options) - unless ...
Fix for geocoding with STI models
diff --git a/lib/gitlab/client/groups.rb b/lib/gitlab/client/groups.rb index abc1234..def5678 100644 --- a/lib/gitlab/client/groups.rb +++ b/lib/gitlab/client/groups.rb @@ -1,8 +1,18 @@ class Gitlab::Client # Defines methods related to groups. module Groups - def groups - get("/groups") + + # Gets a li...
Add ability for group api to page results
diff --git a/app/models/topic_section.rb b/app/models/topic_section.rb index abc1234..def5678 100644 --- a/app/models/topic_section.rb +++ b/app/models/topic_section.rb @@ -4,8 +4,4 @@ has_many :topic_section_guides, -> { order(position: :asc) }, dependent: :destroy accepts_nested_attributes_for :topic_section_g...
Remove unused topic section scope
diff --git a/lib/news/news_controller.rb b/lib/news/news_controller.rb index abc1234..def5678 100644 --- a/lib/news/news_controller.rb +++ b/lib/news/news_controller.rb @@ -1,6 +1,5 @@ require_relative 'news_service' require_relative 'news_repository' -require_relative 'relevance/relevance_command' class NewsContro...
Remove require "relevance functionality" from news controller
diff --git a/msfl_visitors.gemspec b/msfl_visitors.gemspec index abc1234..def5678 100644 --- a/msfl_visitors.gemspec +++ b/msfl_visitors.gemspec @@ -1,7 +1,7 @@ Gem::Specification.new do |s| s.name = 'msfl_visitors' - s.version = '0.1.0.rc0' - s.date = '2015-05-06' + s.version = '0.1.0.rc1' ...
Update gem version now that all comparison fields and AND are parseable
diff --git a/app/uploaders/image_uploader.rb b/app/uploaders/image_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/image_uploader.rb +++ b/app/uploaders/image_uploader.rb @@ -7,8 +7,28 @@ process :set_content_type - version :thumb do + version :huge do + process resize_to_fit: [1024, 1024] + e...
Add various version sizes similar to imgur.
diff --git a/absorb_api.gemspec b/absorb_api.gemspec index abc1234..def5678 100644 --- a/absorb_api.gemspec +++ b/absorb_api.gemspec @@ -6,11 +6,11 @@ Gem::Specification.new do |spec| spec.name = "absorb_api" spec.version = AbsorbApi::VERSION - spec.authors = ["npezza93"] + spec.authors ...
Update gemspec to publish gem
diff --git a/manifests/cf-manifest/spec/manifest/oauth_spec.rb b/manifests/cf-manifest/spec/manifest/oauth_spec.rb index abc1234..def5678 100644 --- a/manifests/cf-manifest/spec/manifest/oauth_spec.rb +++ b/manifests/cf-manifest/spec/manifest/oauth_spec.rb @@ -1,11 +1,32 @@-RSpec.describe "Google OAuth" do +RSpec.descr...
Add some tests for cf-manifest oauth Signed-off-by: Toby Lorne <527052641d65eef236eeef9545b2acac74c35d57@digital.cabinet-office.gov.uk>
diff --git a/app/models/renalware/patients/practice_search_query.rb b/app/models/renalware/patients/practice_search_query.rb index abc1234..def5678 100644 --- a/app/models/renalware/patients/practice_search_query.rb +++ b/app/models/renalware/patients/practice_search_query.rb @@ -12,7 +12,7 @@ term = "%#{sear...
Use outer join onto addresses when searcing for practice Otherwise a pratice with no address will not show up. Unlikely to have that I know, but useful for testing.
diff --git a/app/abilities/owner_ability.rb b/app/abilities/owner_ability.rb index abc1234..def5678 100644 --- a/app/abilities/owner_ability.rb +++ b/app/abilities/owner_ability.rb @@ -26,7 +26,6 @@ # Everyone can show and watch anyone can :show, Owner - # TODO: Don't like the use of persisted? here. Refa...
Remove out of date comment
diff --git a/app/models/installer_report.rb b/app/models/installer_report.rb index abc1234..def5678 100644 --- a/app/models/installer_report.rb +++ b/app/models/installer_report.rb @@ -17,6 +17,13 @@ find(/^Writing to a (temp directory)!$/) == "temp directory" end + def learner + learner_id = find(/^Not fo...
Add learner method to InstallerReports
diff --git a/lib/suspenders/generators/stylelint_generator.rb b/lib/suspenders/generators/stylelint_generator.rb index abc1234..def5678 100644 --- a/lib/suspenders/generators/stylelint_generator.rb +++ b/lib/suspenders/generators/stylelint_generator.rb @@ -3,11 +3,13 @@ module Suspenders class StylelintGenerator < G...
Fix style lint destroying action
diff --git a/Casks/yourkit-java-profiler.rb b/Casks/yourkit-java-profiler.rb index abc1234..def5678 100644 --- a/Casks/yourkit-java-profiler.rb +++ b/Casks/yourkit-java-profiler.rb @@ -1,6 +1,6 @@ cask :v1 => 'yourkit-java-profiler' do - version '2015-build-15044' - sha256 '4a1ccfe84645026701dd45414e53ddfb948b2dd0fa8...
Update Yourkit Java Profiler to 2015-build-15050
diff --git a/lib/action_dispatch/exception_wrapper.rb b/lib/action_dispatch/exception_wrapper.rb index abc1234..def5678 100644 --- a/lib/action_dispatch/exception_wrapper.rb +++ b/lib/action_dispatch/exception_wrapper.rb @@ -5,7 +5,7 @@ file, line = trace.split(":") line_number = line.to_i { -...
Make sure code extract is always a hash
diff --git a/lib/rubocop/formatter/junit_formatter.rb b/lib/rubocop/formatter/junit_formatter.rb index abc1234..def5678 100644 --- a/lib/rubocop/formatter/junit_formatter.rb +++ b/lib/rubocop/formatter/junit_formatter.rb @@ -3,6 +3,11 @@ module RuboCop module Formatter class JUnitFormatter < BaseFormatter + + ...
Include test cases for all cops, and then emit failure tags only for those with offences
diff --git a/tty-file.gemspec b/tty-file.gemspec index abc1234..def5678 100644 --- a/tty-file.gemspec +++ b/tty-file.gemspec @@ -9,8 +9,8 @@ spec.authors = ["Piotr Murach"] spec.email = [""] - spec.summary = %q{File manipulation utility methods} - spec.description = %q{File manipulation u...
Change to update dependencies and lock ruby version
diff --git a/lib/transactional_factories/test_case.rb b/lib/transactional_factories/test_case.rb index abc1234..def5678 100644 --- a/lib/transactional_factories/test_case.rb +++ b/lib/transactional_factories/test_case.rb @@ -1,21 +1,25 @@ module TransactionalFactories module ClassMethods def suite_with_transact...
Add a way to disable transactional factories for a single test.
diff --git a/spec/core/float/divmod_spec.rb b/spec/core/float/divmod_spec.rb index abc1234..def5678 100644 --- a/spec/core/float/divmod_spec.rb +++ b/spec/core/float/divmod_spec.rb @@ -2,9 +2,15 @@ describe "Float#divmod" do it "returns an [quotient, modulus] from dividing self by other" do - 3.14.divmod(2).ins...
Expand Float divmod array equality comparisons to use be_close with a default tolerance.
diff --git a/files/aerobase-cookbooks/aerobase/recipes/java-home.rb b/files/aerobase-cookbooks/aerobase/recipes/java-home.rb index abc1234..def5678 100644 --- a/files/aerobase-cookbooks/aerobase/recipes/java-home.rb +++ b/files/aerobase-cookbooks/aerobase/recipes/java-home.rb @@ -18,7 +18,7 @@ cmd_helper = CmdHelper.ne...
Add java_home to current session
diff --git a/test/integration/post_show_test.rb b/test/integration/post_show_test.rb index abc1234..def5678 100644 --- a/test/integration/post_show_test.rb +++ b/test/integration/post_show_test.rb @@ -3,8 +3,18 @@ class PostShowTest < ActionDispatch::IntegrationTest setup do @post = create(:post, :whatever, :wi...
Add test for displaying credits in page 2
diff --git a/test/error_handling_test.rb b/test/error_handling_test.rb index abc1234..def5678 100644 --- a/test/error_handling_test.rb +++ b/test/error_handling_test.rb @@ -19,13 +19,23 @@ def test_always_raise_timeout_error Geocoder::Configuration.always_raise = [TimeoutError] - assert_raise(TimeoutError) ...
Test exceptions with all lookups.
diff --git a/lib/fit_commit/cli.rb b/lib/fit_commit/cli.rb index abc1234..def5678 100644 --- a/lib/fit_commit/cli.rb +++ b/lib/fit_commit/cli.rb @@ -12,26 +12,37 @@ end def execute - action_name = args.shift - case action_name - when "install" - FitCommit::Installer.new.install - ...
Print error if binary not run from git repo
diff --git a/lib/jekyll/version.rb b/lib/jekyll/version.rb index abc1234..def5678 100644 --- a/lib/jekyll/version.rb +++ b/lib/jekyll/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module Jekyll - VERSION = "4.3.0" + VERSION = "5.0.0.dev" end
Mark initiation of v5.0 development To prevent users from pointing their Gemfile to the repository and breaking their site.
diff --git a/app/helpers/application_helper/toolbar/ansible_credential_center.rb b/app/helpers/application_helper/toolbar/ansible_credential_center.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/toolbar/ansible_credential_center.rb +++ b/app/helpers/application_helper/toolbar/ansible_credential_c...
Add Policy button to enable tagging of Ansible Credential Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526219 Add Policy toolbar button to enable tagging of any Ansible Credential from its summary page.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -7,6 +7,8 @@ namespace :admin do root 'dashboard#index' - resources :sites + constraints ->(_req) { Apartment::Tenant.current == 'public' } do + resources :sites + end ...
Add constraint for system only resources in admin
diff --git a/db/migrate/20200511153912_change_column_type_control_on_sample.rb b/db/migrate/20200511153912_change_column_type_control_on_sample.rb index abc1234..def5678 100644 --- a/db/migrate/20200511153912_change_column_type_control_on_sample.rb +++ b/db/migrate/20200511153912_change_column_type_control_on_sample.rb...
Add migration - schema to come, after upgrading mysql to try to get rid of all the trivial changes
diff --git a/app/controllers/spree/admin/overview_controller_decorator.rb b/app/controllers/spree/admin/overview_controller_decorator.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/overview_controller_decorator.rb +++ b/app/controllers/spree/admin/overview_controller_decorator.rb @@ -5,7 +5,7 @@ ...
Make admins get multi enterprise dashboard
diff --git a/lib/walkman/player.rb b/lib/walkman/player.rb index abc1234..def5678 100644 --- a/lib/walkman/player.rb +++ b/lib/walkman/player.rb @@ -1,11 +1,11 @@ require "singleton" require "forwardable" - -SERVICES = [Walkman::Service::Rdio] module Walkman class Player include Singleton + + SERVICES = ...
Move SERVICES within the class
diff --git a/test/integration/api_operations/list_test.rb b/test/integration/api_operations/list_test.rb index abc1234..def5678 100644 --- a/test/integration/api_operations/list_test.rb +++ b/test/integration/api_operations/list_test.rb @@ -7,14 +7,18 @@ should "retrieve districts" do VCR.use_cassette("distric...
Add some explicit assertions to list tests
diff --git a/config/deploy/production.rb b/config/deploy/production.rb index abc1234..def5678 100644 --- a/config/deploy/production.rb +++ b/config/deploy/production.rb @@ -13,7 +13,6 @@ server 'dash15.code.org', :app, :web server 'dash16.code.org', :app, :web server 'dash17.code.org', :app, :web -server 'dash18.code...
Remove dash18, which is becoming the new archive machine
diff --git a/tablerize.gemspec b/tablerize.gemspec index abc1234..def5678 100644 --- a/tablerize.gemspec +++ b/tablerize.gemspec @@ -2,10 +2,10 @@ Gem::Specification.new do |gem| gem.name = 'tablerize' - gem.summary = 'Convert YAML to HTML tables.' + gem.summary = 'Say goodbye to aligning ta...
Make gemspec text consistent with repo text
diff --git a/catalinker/lib/server.rb b/catalinker/lib/server.rb index abc1234..def5678 100644 --- a/catalinker/lib/server.rb +++ b/catalinker/lib/server.rb @@ -5,6 +5,7 @@ require_relative './RESTService.rb' set :bind, '0.0.0.0' +enable :static get '/' do "Catalinker"
Enable (explicitly) static file access
diff --git a/app/controllers/relationships_controller.rb b/app/controllers/relationships_controller.rb index abc1234..def5678 100644 --- a/app/controllers/relationships_controller.rb +++ b/app/controllers/relationships_controller.rb @@ -2,15 +2,11 @@ before_filter :authenticate_user! #TODO: Use ajax? + #TODO: A...
Refactor controller to include new connection creating methods
diff --git a/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-ansible_tower-configuration_manager-job.rb b/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-ansible_tower-configuration_manager-job.rb index abc1234..def5678 100644 --- a/lib/miq_automation_engine/service...
Introduce AnsibleTower's Job subclassed from OrchestrationStack (transferred from ManageIQ/manageiq@2cfe41f01bb6120f4f6f8c50a0e3a4762c415ec5)
diff --git a/app/validators/panopticon_slug_validator.rb b/app/validators/panopticon_slug_validator.rb index abc1234..def5678 100644 --- a/app/validators/panopticon_slug_validator.rb +++ b/app/validators/panopticon_slug_validator.rb @@ -1,3 +1,5 @@+require 'net/http' + class PanopticonSlugValidator < ActiveModel::Each...
Add net/http to panopticon slug validator so that we can create things again net/http must have been required in some of the frontend code that we've now removed
diff --git a/test/models/unit_test.rb b/test/models/unit_test.rb index abc1234..def5678 100644 --- a/test/models/unit_test.rb +++ b/test/models/unit_test.rb @@ -0,0 +1,15 @@+require 'test_helper' + +class UnitTest < ActiveSupport::TestCase + test 'ensure valid response from unit ilo data' do + unit = Unit.first + ...
TEST: Add test for unit ilo progress
diff --git a/spec/models/game_spec.rb b/spec/models/game_spec.rb index abc1234..def5678 100644 --- a/spec/models/game_spec.rb +++ b/spec/models/game_spec.rb @@ -1,5 +1,15 @@ require 'rails_helper' RSpec.describe Game, type: :model do - pending "add some examples to (or delete) #{__FILE__}" + describe "#deal" do + ...
Create unit test for Game.deal
diff --git a/spec/numeric_ext_spec.rb b/spec/numeric_ext_spec.rb index abc1234..def5678 100644 --- a/spec/numeric_ext_spec.rb +++ b/spec/numeric_ext_spec.rb @@ -14,12 +14,28 @@ end end + shared_context 'having correct precision' do |n| + it 'sets default precision without an argument' do + e...
Add examples for testing precision is set
diff --git a/spec/support/postgres.rb b/spec/support/postgres.rb index abc1234..def5678 100644 --- a/spec/support/postgres.rb +++ b/spec/support/postgres.rb @@ -10,7 +10,7 @@ DEFAULT_TEST_DATABASE = 'postgres:///rspec-sequel-test' def self.connect_to_postgres - test_database = unless ENV['TEST_DATABASE'] + ...
Fix test database connection string setup
diff --git a/sli/admin-tools/admin-rails/app/models/user_account_validation.rb b/sli/admin-tools/admin-rails/app/models/user_account_validation.rb index abc1234..def5678 100644 --- a/sli/admin-tools/admin-rails/app/models/user_account_validation.rb +++ b/sli/admin-tools/admin-rails/app/models/user_account_validation.rb...
Fix error message for duplicate email validation attempts
diff --git a/tools/run_old_experiment.rb b/tools/run_old_experiment.rb index abc1234..def5678 100644 --- a/tools/run_old_experiment.rb +++ b/tools/run_old_experiment.rb @@ -28,6 +28,9 @@ # remove them ourselves. Dir.glob('**/*pyc').each { |f| File.delete(f) } +# Also make sure that hassel has been compiled. +system ...
Make sure hassel has been compiled
diff --git a/tests/test_command_matcher_move.rb b/tests/test_command_matcher_move.rb index abc1234..def5678 100644 --- a/tests/test_command_matcher_move.rb +++ b/tests/test_command_matcher_move.rb @@ -0,0 +1,35 @@+require './lib/toy_robot_simulator/command/matcher/base' +require 'minitest/autorun' + +class CommandMatch...
Implement CommandMatcherMoveTest to guide design This class is intended to test and document the development of a command matching object, which understands the 'MOVE' command.
diff --git a/db/migrate/20161125172005_add_braintree_configuration_to_stores.rb b/db/migrate/20161125172005_add_braintree_configuration_to_stores.rb index abc1234..def5678 100644 --- a/db/migrate/20161125172005_add_braintree_configuration_to_stores.rb +++ b/db/migrate/20161125172005_add_braintree_configuration_to_store...
Add default configuration to stores in a migration
diff --git a/plugins/disk_stats.rb b/plugins/disk_stats.rb index abc1234..def5678 100644 --- a/plugins/disk_stats.rb +++ b/plugins/disk_stats.rb @@ -2,7 +2,7 @@ provides 'disk_stats' collect_data(:linux) do disk_stats Mash.new - so = shell_out("iostat -d") + so = shell_out("iostat -d -k") parsing_d...
Use -k option on iostat: Display statistics in kilobytes per second instead of blocks per second
diff --git a/app/models/item.rb b/app/models/item.rb index abc1234..def5678 100644 --- a/app/models/item.rb +++ b/app/models/item.rb @@ -1,5 +1,4 @@ class Item < ApplicationRecord - attr_accessor :category_id validates :name, presence: { message: "Name field can't be left blank"}, length: { in: 3..64, message: "N...
Remove the attr_accessor, which was preventing me from updating changes when saving the database
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -6,8 +6,8 @@ has_many :participations has_many :challenges, through: :participations - validates :username, presence: true - validates :email, presence: true + validates :use...
Add uniqueness validation to User model
diff --git a/color-scheme-validator.gemspec b/color-scheme-validator.gemspec index abc1234..def5678 100644 --- a/color-scheme-validator.gemspec +++ b/color-scheme-validator.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |spec| spec.name = "color-scheme-validator" - spec.version = "0.3.0" + spec...
Upgrade activemodel version from 4.x to 5.x
diff --git a/spec/lib/action_subscriber/configuration_spec.rb b/spec/lib/action_subscriber/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/lib/action_subscriber/configuration_spec.rb +++ b/spec/lib/action_subscriber/configuration_spec.rb @@ -2,9 +2,15 @@ describe "default values" do specify { expe...
Add specs for default settings
diff --git a/spec/models/questions_spec.rb b/spec/models/questions_spec.rb index abc1234..def5678 100644 --- a/spec/models/questions_spec.rb +++ b/spec/models/questions_spec.rb @@ -5,4 +5,8 @@ it "has a valid factory" do expect(build(:question)).to be_valid end + + it "is invalid without a title" do + exp...
Test for question title validation
diff --git a/config/environments/staging.rb b/config/environments/staging.rb index abc1234..def5678 100644 --- a/config/environments/staging.rb +++ b/config/environments/staging.rb @@ -28,5 +28,5 @@ # Expands the lines which load the assets config.assets.debug = true - config.middleware.insert 0, Slimmer::App,...
Switch slimmer middleware insertion to be less specific about placement
diff --git a/config/software/loom-server.rb b/config/software/loom-server.rb index abc1234..def5678 100644 --- a/config/software/loom-server.rb +++ b/config/software/loom-server.rb @@ -8,8 +8,8 @@ mkdir "#{install_dir}/bin" copy "#{project_dir}/server/bin/*", "#{install_dir}/bin" command "cp -fpPR #{project_dir...
Install logrotate file into correct location
diff --git a/app/serializers/api/v1/update_serializer.rb b/app/serializers/api/v1/update_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/api/v1/update_serializer.rb +++ b/app/serializers/api/v1/update_serializer.rb @@ -7,7 +7,7 @@ attribute :updated_at, key: :date def updated_at - ...
Format date to give month in short form
diff --git a/rack-secure-upload.gemspec b/rack-secure-upload.gemspec index abc1234..def5678 100644 --- a/rack-secure-upload.gemspec +++ b/rack-secure-upload.gemspec @@ -16,6 +16,8 @@ gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } gem.require_paths = ['lib'] + gem.required_ruby...
Add required ruby version in gemspec
diff --git a/lib/boson/libraries/gem_library.rb b/lib/boson/libraries/gem_library.rb index abc1234..def5678 100644 --- a/lib/boson/libraries/gem_library.rb +++ b/lib/boson/libraries/gem_library.rb @@ -10,7 +10,7 @@ class GemLibrary < Library #:stopdoc: def self.is_a_gem?(name) - Object.const_defined?(:...
Update for new version of RubyGems Changed Gem.searcher.find to Gem::Specification.find_by_name
diff --git a/lib/coding_test_dg/rule/product.rb b/lib/coding_test_dg/rule/product.rb index abc1234..def5678 100644 --- a/lib/coding_test_dg/rule/product.rb +++ b/lib/coding_test_dg/rule/product.rb @@ -7,7 +7,7 @@ def apply(checkout) ft_products = checkout.cart.select(&:product_code).select{|p| p.product_co...
Make slice each value configurable to accommodate 3 for 1
diff --git a/lib/ey-core/models/server_usage.rb b/lib/ey-core/models/server_usage.rb index abc1234..def5678 100644 --- a/lib/ey-core/models/server_usage.rb +++ b/lib/ey-core/models/server_usage.rb @@ -8,6 +8,7 @@ attribute :dedicated attribute :location attribute :deis + attribute :provisioned_id has_one ...
Add provisioned_id attribute to ServerUsage
diff --git a/lib/learn_web/response_parsable.rb b/lib/learn_web/response_parsable.rb index abc1234..def5678 100644 --- a/lib/learn_web/response_parsable.rb +++ b/lib/learn_web/response_parsable.rb @@ -1,5 +1,5 @@ module LearnWeb - module AttributePopulatable + module ResponseParsable def self.included(base) ...
Fix bad copy paste job