language
string
code-snippit
string
instruction
string
flaws
list
flaw_count
int64
python
}, blocking=True, ) assert len(client.async_send_command.call_args_list) == 1 args = client.async_send_command.call_args[0][0] assert args["command"] == "endpoint.invoke_cc_api" assert args["nodeId"] == 20 assert args["endpoint"] == 0 assert args["args"] == [ { "...
Review this code and list any quality issues.
[]
0
python
self.setup_clean_chain = True self.num_nodes = 1 self.extra_args = [['-keypool=100']] self.wallet_names = [] def skip_test_if_missing_module(self): self.skip_if_no_wallet() self.skip_if_no_py_sqlite3() def run_test(self): # Make a descriptor wallet self....
Review this code and list any quality issues.
[ { "issue": "I checked that this Regex is fine because the origin fingerprint can only be a hex string `(\\da-f)` and the `origin_part` is found even if the `desc_verify` doesn't contain hardened marker such as in `wpkh([58d258be/84/1/0]/0/*`. That's why I believe the subsequent `\"h\" in origin_part` check is r...
1
python
self.tip = block.hash_int self.block_time += 1 height += 1 # Start node1 and node2 with assumevalid so they accept a block with a bad signature. self.start_node(1, extra_args=["-assumevalid=" + block102.hash_hex]) self.start_node(2, extra_args=["-assumevalid=" + block102...
Review this code and list any quality issues.
[ { "issue": "This is racy and will fail CI. You can reproduce this by adding a `time.sleep(9)` before the `with`?", "severity": "critical", "line": 26 } ]
1
python
"""Inference for FastChat models.""" import abc from typing import Optional import warnings import torch try: from transformers import AutoTokenizer, AutoModelForCausalLM, LlamaTokenizer, LlamaForCausalLM, AutoModel, LlamaForCausalLM, AutoConfig except ImportError: from transformers import AutoTokenizer, Auto...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\nfrom fastchat.serve.compression import load_compress_model\r\n```", "severity": "minor", "line": 13 } ]
1
python
content_id = get_binding_value('%s_content_id' % (card_name if is_amplify else 'player')) formats, subtitles = self._extract_formats_from_vmap_url(vmap_url, content_id or twid) thumbnails = [] for suffix in ('_small', '', '_large', '_x_large', '_original'): ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n videos = traverse_obj(status, (\r\n (None, 'quoted_status'), 'extended_entities', 'media', lambda _, m: m['type'] != 'photo', {dict}))\r\n```", "severity": "minor", "line": 26 } ]
1
python
# Execute without inputs and without use_defaults response = await tool.execute( user_id=user.id, session_id=str(uuid.uuid4()), tool_call_id=str(uuid.uuid4()), username_agent_slug=agent_marketplace_id, inputs={}, use_defaults=False, session=session, ) ...
Review this code and list any quality issues.
[]
0
python
def testRepeatedValues(self): x2233 = np.array([2] * 3 + [3] * 4 + [5] * 5 + [6] * 4, dtype=int) x3344 = x2233 + 1 x2356 = np.array([2] * 3 + [3] * 4 + [5] * 10 + [6] * 4, dtype=int) x3467 = np.array([3] * 10 + [4] * 2 + [6] * 10 + [7] * 4, dtype=int) self._testOne(x2233, x3344, ...
Review this code and list any quality issues.
[]
0
python
-------- subprocess.run Raises ------ pytest.xfail If platform is Cygwin and subprocess reports a fork() failure. """ if capture_output: stdout = stderr = subprocess.PIPE try: proc = subprocess.run( command, env=env, timeout=timeout, check=che...
Review this code and list any quality issues.
[ { "issue": "This should be a plain fail not an xfail, also made it a bit more verbose to make stdout and stderr output easier to read:\r\n\r\n```suggestion\r\n pytest.fail(\r\n f\"Subprocess failed with exit code {e.returncode}:\\n\\n\"\r\n f\"STDOUT:\\n{e.stdout}\\n\\nSTDERR:\\n{e....
1
python
dy_label The label for the `dy` line. Defaults to :class:`~.MathTex` for ``str`` and ``float`` inputs. include_secant_line Whether to include the secant line in the graph, or just the df/dx lines and labels. secant_line_color The color of the secant line...
Review this code and list any quality issues.
[]
0
python
) json_input_data = json.dumps(input_data) if existing_execution: await AgentNodeExecutionInputOutput.prisma().create( data={ "name": input_name, "data": json_input_data, "referencedByInputExecId": existing_execution.id, } ...
Review this code and list any quality issues.
[]
0
python
param_names = [debug_param2name_id(p) for p in params] print_rank_0(f'{tag} step = {step_id} mod = {debug_module2name_id(sub_module)} p_names = {param_names}', force=False) def _dump_param_ids(self, tag, mod_id, p_ids, step_id=None): if step_id is None: step_id = se...
Review this code and list any quality issues.
[]
0
python
1 1 2 0.227877 2 2 3 1.267767 3 2 4 -0.562860 The aggregation is for each column. >>> df.groupby('A').agg('min') B C A 1 1 0.227877 2 3 -0.562860 Multiple aggregations >>> df.groupby('A').agg(['min', 'max']) B C min max mi...
Review this code and list any quality issues.
[]
0
python
if opts.ffmpeg_location is not None: opts.ffmpeg_location = expand_path(opts.ffmpeg_location) if opts.user_agent is not None: opts.headers.setdefault('User-Agent', opts.user_agent) if opts.referer is not None: opts.headers.setdefault('Referer', opts.referer) if opts.no_sponsorblock...
Review this code and list any quality issues.
[ { "issue": "My suggestion used items so we can write `\"{policy}\" is not a valid color policy for {name}`. Not a big deal, but idk why you changed it.", "severity": "minor", "line": 26 } ]
1
python
def itemsize(self) -> int: """ Return the number of bytes in this dtype. For Arrow-backed dtypes: - Returns the fixed-width bit size divided by 8 for standard fixed-width types. - For boolean types, returns the NumPy itemsize. - Falls back to the NumPy dtype itemsize for...
Review this code and list any quality issues.
[ { "issue": "Can you move this outside the try except?", "severity": "major", "line": 26 } ]
1
python
op_bit_len = op.bitLength() op_val = op.getValue() if op_bit_len == 8: chars = struct.pack("<B", op_val & 0xFF) elif op_bit_len == 16: chars = struct.pack("<H", op_val & 0xFFFF) elif op_bit_len == 32: chars = struct.pack("<I", op_val & 0xFFFFFFFF) elif op_bit_len == 64: ...
Review this code and list any quality issues.
[ { "issue": "Should these functions both divide by `8`? Also, should we be using floor division (`//`) for consistent typing? Floor division should allow us to remove the extra `int` cast.", "severity": "minor", "line": 26 } ]
1
python
}, }, { 'url': 'https://www.aph.gov.au/News_and_Events/Watch_Read_Listen/ParlView/video/3406614', 'only_matching': True, }] _API_URL = 'https://vodapi.aph.gov.au/api/search/parlview/%s' def _real_extract(self, url): video_id = self._match_id(url) api_data = self._downloa...
Review this code and list any quality issues.
[ { "issue": "How about\n```suggestion\n 'duration': ('files', 'file', 'duration', {DURATION_RE.fullmatch}, 'duration', {parse_duration}),\n```\nwhere we define `DURATION_RE` above as\n```py\n DURATION_RE = re.compile(r'(?P<duration>\\d+:\\d+:\\d+):\\d+')\n```", "severity": "minor", ...
1
python
# Another thread computed the value before us. Early exit! return self._handle_cache_hit(cached_result) except CacheKeyNotFoundError: # No cache hit -> we will call the cached function # below. pass # We acquired the lock before an...
Review this code and list any quality issues.
[ { "issue": "**question:** Whats the reason why this is moved to lazy-loading?", "severity": "minor", "line": 26 } ]
1
python
'presence_penalty', 'frequency_penalty', 'logit_bias', 'logprobs', 'top_logprobs', ) else: openai_unsupported_model_settings = () # The o1-mini model doesn't support the `system` role, so we default to `user`. # See https://github.com/pydantic...
Review this code and list any quality issues.
[]
0
python
self.timeout = timeout self.sleep = sleep self.blocking = blocking self.blocking_timeout = blocking_timeout self.thread_local = bool(thread_local) self.local = threading.local() if self.thread_local else SimpleNamespace() self.local.token = None self.register_scri...
Review this code and list any quality issues.
[]
0
python
"aws_bedrock": "mem0.embeddings.aws_bedrock.AWSBedrockEmbedding", } @classmethod def create(cls, provider_name, config, vector_config: Optional[dict]): if provider_name == "upstash_vector" and vector_config and vector_config.enable_embeddings: return MockEmbeddings() class_type ...
Review this code and list any quality issues.
[ { "issue": "Hey, can you please change the name to `MongoDB` in the original vectorstore file?", "severity": "minor", "line": 26 } ]
1
python
else: assert self.type == other.type # mypy doesn't realize we've proven that either # both are ints, or both are tuples of ints. # and both of these are comparable. return self.value < other.value # type: ignore class GlobalFeature(HashableModel): feat...
Review this code and list any quality issues.
[ { "issue": "i don't understand this - doesn't the `address` contain the information needed to pick the right process? can you maybe include an example that shows how these are not the same?", "severity": "minor", "line": 26 } ]
1
python
"filepath", [ "http://example.com/file.txt", "https://example.com/file.txt", ], ) def test_get_protocol_and_path_http_with_version(self, filepath): version = Version(load=None, save=None) expected_error_message = "Versioning is not supported for HTTP proto...
Review this code and list any quality issues.
[]
0
python
async def new_context(self, **context_options: Any) -> BrowserContext: """Create persistent context instead of regular one. Merge launch options with context options.""" if self._context: raise RuntimeError('Persistent browser can have only one context') launch_options = self._brows...
Review this code and list any quality issues.
[ { "issue": "Why is this needed `ignore_errors=True`? We checked that dir exists, what kind of errors are we expecting here?", "severity": "minor", "line": 26 } ]
1
python
if not task.collective: task.done = True self.db.add(task) logger.debug(f"inserting TextLabels for {message_id=}, {text_labels_id=}") model = TextLabels( id=text_labels_id, api_client_id=self.api_client.id, message_id=message_id, ...
Review this code and list any quality issues.
[ { "issue": "send message_id inside send_new_report_message, this would be easier for the mod team to search the DB", "severity": "minor", "line": 26 } ]
1
python
pylint). """ for comment in comment_list: if comment.value.startswith(("# type:", "# noqa", "# pylint:")): return True return False def _contains_fmt_skip_comment(comment_line: str, mode: Mode) -> bool: """ Checks if the given comment contains FMT_SKIP alone or paired with oth...
Review this code and list any quality issues.
[ { "issue": "I sort of feel the old formatting was better here; \"for ... in\" feels like a single unit that shouldn't be split up.", "severity": "minor", "line": 26 } ]
1
python
assert ri < r s, t, r = si, ti, ri assert gcdex(a, b) == (s, t, r) def test_gcdex(): f, g = 2*x, x**2 - 16 s, t, h = x/32, Rational(-1, 16), 1 F, G, S, T, H = [ Poly(u, x, domain='QQ') for u in (f, g, s, t, h) ] assert F.half_gcdex(G) == (S, H) assert F.gcdex(G) == (S, T, H) as...
Review this code and list any quality issues.
[]
0
python
extension=extension, size=file_size, storage_key="", ) def _extract_filename(url_path: str, content_disposition: str | None) -> str | None: filename: str | None = None # Try to extract from Content-Disposition header first if content_disposition: # Manually extract filename* pa...
Review this code and list any quality issues.
[ { "issue": "[nitpick] The fallback logic assumes that `''` indicates an empty language tag, but this is too simplistic for RFC 5987. If the format is malformed, it would be safer to extract everything after the last `'` character rather than specifically looking for `''`.\n```suggestion\n # Fallb...
1
python
# The above is a special broken case, since distinct values # are less than 3, mid-points are automatically calculated # and return different values as compared to when using weights # since the extra 1 breakes the tie. For now the test is slightly # modified, in future we need to decide what to do when...
Review this code and list any quality issues.
[ { "issue": "This comment seems off. Let me try a rephrasing from my current understanding of the code:\r\n\r\n\r\n```suggestion\r\n # This test assumes that subsampling in `_BinMapper` is disabled\r\n # (when `n_samples < 2e5`) and therefore the binning results should be\r\n # deterministic.\r\n # O...
1
python
) if not torch.cuda.is_available(): raise RuntimeError( "AWQ quantization requires a GPU. " "Please use a machine with at least 1 GPU." ) @override def quantize(self, config: QuantizationConfig) -> dict[str, Any]: """Main quantization met...
Review this code and list any quality issues.
[ { "issue": "Let's throw an exception (NotImplementedError) if config.format_type != pytorch since it's the only one we support", "severity": "minor", "line": 26 } ]
1
python
f"Using BAdam optimizer with ratio-based update, update ratio is {finetuning_args.badam_update_ratio}, " f"mask mode is {finetuning_args.badam_mask_mode}" ) return optimizer def _create_adam_mini_optimizer( model: "PreTrainedModel", training_args: "TrainingArguments", ) -> "torch.opti...
Review this code and list any quality issues.
[]
0
python
new_rule_features = findall_features(new_rule["rule"]["features"]) overlapping_rules = [] for dirpath, dirnames, filenames in os.walk(rules_path): for filename in filenames: if filename.endswith(".yml"): rule_path = os.path.join(dirpath, filename) with open(...
Review this code and list any quality issues.
[ { "issue": "Would you mind adding a main routine and using argparse to retrieve these from the command line?", "severity": "minor", "line": 26 } ]
1
python
) if system_prompt: system_message = SystemMessageAction(content=system_prompt) # Insert the system message directly at the beginning of the events list events.insert(0, system_message) logger.info( '[ConversationMemory] Add...
Review this code and list any quality issues.
[ { "issue": "Ahh. Not a review comment, just a note, it shouldn’t have been condensed I think", "severity": "minor", "line": 26 } ]
1
python
assert target_python.py_version_info == expected_py_version_info assert target_python.py_version == expected_py_version def test_init__py_version_info_none(self) -> None: """ Test passing py_version_info=None. """ target_python = TargetPython(py_version_info=None) a...
Review this code and list any quality issues.
[]
0
python
ExceptionGroup = ExceptionGroup # pragma: lax no cover with try_import() as logfire_imports_successful: from logfire.testing import CaptureLogfire pytestmark = pytest.mark.anyio def success_response(_model_messages: list[ModelMessage], _agent_info: AgentInfo) -> ModelResponse: return ModelResponse(parts=[...
Review this code and list any quality issues.
[ { "issue": "I think we should specifically define this method to return the `model_id`s of the wrapped models with the `fallback` prefix, like with the `model_name` and `system` methods:\r\n\r\nhttps://github.com/pydantic/pydantic-ai/blob/9a0757c97593ae9bd6aa778460b0ceff0d44068e/pydantic_ai_slim/pydantic_ai/mod...
1
python
bark_options = [ (pattern_speaker.sub(r"Speaker \1", f.stem), str(f.with_suffix(".wav"))) for f in speakers_path.rglob(f"{lang}_speaker_*.npz") ] voice_options = builtin_options + eng_options ...
Review this code and list any quality issues.
[ { "issue": "The comparison 'session['voice'] not in voice_options' is incorrect. The session['voice'] is a string path, but voice_options is a list of tuples in the format (label, path). This comparison will always be True because it's comparing a string to tuples. The correct check should iterate through the v...
1
python
'upload_date': '20150828', 'description': 'md5:1d4905ce48c66c9299c617f08e106e0f', }, }, { 'url': 'http://ecchi.iwara.tv/videos/Vb4yf2yZspkzkBO', 'md5': '7e5f1f359cd51a027ba4a7b7710a50f0', 'info_dict': { 'id': '0B1LvuHnL-sRFNXB1WHNqbGw4SXc', 'ext': ...
Review this code and list any quality issues.
[ { "issue": "This is using `urlh.geturl()` in order to account for any redirects. Change this only if you are sure this isn't needed", "severity": "minor", "line": 26 } ]
1
python
DeprecationWarning, stacklevel=2) A = np.asarray(A) # squareness checked in `_logm` # Avoid circular import ... this is OK, right? import scipy.linalg._matfuncs_inv_ssq F = scipy.linalg._matfuncs_inv_ssq._logm(A) F = _maybe_real(A, F) errtol = 1000*eps # TODO use a better error approximatio...
Review this code and list any quality issues.
[ { "issue": "the documented shape already includes `...`, did you mean to put the other message here? Same for `sqrtm`", "severity": "minor", "line": 26 } ]
1
python
parts = path.split(os.sep) match_parts = match.split("/") if len(parts) < len(match_parts): return None if not all( fnmatch(part, match_part) for part, match_part in zip(reversed(parts), reversed(match_parts)) ): return None return os.sep.join(parts[: -len(match_par...
Review this code and list any quality issues.
[ { "issue": "Is this a known false positive?", "severity": "minor", "line": 26 } ]
1
python
@overload def transpose( a: _ArrayLike[_SCT], axes: _ShapeLike | None = ... ) -> NDArray[_SCT]: ... @overload def transpose( a: ArrayLike, axes: _ShapeLike | None = ... ) -> NDArray[Any]: ... @overload def matrix_transpose(x: _ArrayLike[_SCT], /) -> NDArray[_SCT]: ... @overload def matrix_transpose(x: ...
Review this code and list any quality issues.
[ { "issue": "This typevar has been renamed in the meantime. This should fix the mypy errors\r\n\r\n```suggestion\r\n a: _ArrayLike[_SCT],\r\n kth: _ArrayLikeInt,\r\n axis: SupportsIndex | None = -1,\r\n kind: _PartitionKind = \"introselect\",\r\n order: None = None,\r\n) -> NDArray[_SCT]: ...\r\n`...
1
python
""" polygon = np.zeros((box.shape[0], 4, 2), dtype=box.dtype) polygon[:, :, 0] = box[:, [0, 2, 2, 0]] polygon[:, :, 1] = box[:, [1, 1, 3, 3]] return polygon def polygon_to_mask(polygon: np.ndarray, resolution_wh: Tuple[int, int]) -> np.ndarray: """Generate a mask from a polygon. Args: ...
Review this code and list any quality issues.
[ { "issue": "- [ ] Let's keep the signature of the function consistent with that of `box_iou_batch`.\n- [ ] Let's also ensure that the boxes can be simply represented as lists and well as `np.ndarray`s.\n\n\n```suggestion\ndef box_iou(boxes_true: Union[List, np.ndarray], boxes_detection: Union[List, np.ndarray])...
1
python
def truncate_string(s, l): half = int(l // 2) return s[:half] + s[-half:] if len(s) > l else s if __name__ == "__main__": parser = argparse.ArgumentParser() parser.add_argument("--input-file", type=str, required=True) parser.add_argument("--model", type=str, default="gpt-3.5-turbo") parser.add...
Review this code and list any quality issues.
[]
0
python
'md5': '01982d58021af81c969958459bd81f13', 'info_dict': { 'id': 'e16348f1-040e-4596-b922-77b45fa8d253', 'ext': 'mp4', 'title': 'The Transhumanist Plan for Humanity | Billy Crone', 'description': None, 'upload_date': '20240903', 'duration': ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n data = self._download_json(\r\n 'https://core.subsplash.com/media/v1/media-items',\r\n display_id, headers=self._get_headers(url, display_id),\r\n```", "severity": "minor", "line": 26 } ]
1
python
self.raise_login_required() class SaucePlusChannelIE(FloatplaneChannelBaseIE): _VALID_URL = r'https?://(?:(?:www|beta)\.)?sauceplus\.com/channel/(?P<id>[\w-]+)/home(?:/(?P<channel>[\w-]+))?' _BASE_URL = 'https://www.sauceplus.com' _ENTRY_IE_TYPE = SaucePlusIE _HEADERS = { 'Origin': _BASE_URL, ...
Review this code and list any quality issues.
[ { "issue": "Likewise, this isn't needed here. The video IE will do the authwall handling. And with this removed, devs without an account (such as the reviewer / me) can test the extractor", "severity": "critical", "line": 26 } ]
1
python
from __future__ import unicode_literals from .common import InfoExtractor from ..utils import ( int_or_none, parse_duration, qualities, try_get ) class VeohIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)?veoh\.com/(?:watch|videos|embed|iphone/#_Watch)/(?P<id>(?:v|e|yapi-)[\da-zA-Z]+)' _...
Review this code and list any quality issues.
[ { "issue": "```py\r\n 'description': 'md5:...',\r\n```", "severity": "minor", "line": 22 } ]
1
python
from typing import TYPE_CHECKING from protego import Protego # type: ignore[import-untyped] from yarl import URL from crawlee._utils.web import is_status_code_client_error if TYPE_CHECKING: from typing_extensions import Self from crawlee.http_clients import HttpClient from crawlee.proxy_configuration i...
Review this code and list any quality issues.
[ { "issue": "Could you please use sentences in arg description? (applies to all occurencies)", "severity": "minor", "line": 26 } ]
1
python
assert_type(MAR_f4.argmax(), np.intp) assert_type(MAR_f4.argmax(fill_value=6.28318, keepdims=False), np.intp) assert_type(MAR_b.argmax(axis=0), Any) assert_type(MAR_f4.argmax(axis=0), Any) assert_type(MAR_b.argmax(keepdims=True), Any) assert_type(MAR_f4.argmax(out=MAR_subclass), MaskedNDArraySubclass) assert_type(MAR_f...
Review this code and list any quality issues.
[]
0
python
def append_vectorized_mobject(self, vectorized_mobject: VMobject) -> None: if self.has_new_path_started(): # Remove last point, which is starting # a new path self.points = self.points[:-1] self.append_points(vectorized_mobject.points) def apply_function( ...
Review this code and list any quality issues.
[ { "issue": "This one would probably also be autofixed:\r\n```suggestion\r\n axis: Vector3DLike = OUT,\r\n```", "severity": "minor", "line": 26 } ]
1
python
self.stream = stream self.stream_events = stream_events self.stream_intermediate_steps = stream_intermediate_steps self.stream_executor_events = stream_executor_events self.store_executor_outputs = store_executor_outputs self.input_schema = input_schema self.metadata = me...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n if self.add_workflow_history_to_steps and self.db is None:\n log_warning(\n \"Workflow history is enabled (add_workflow_history_to_steps=True) but no database is configured. \"\n \"History won't be persisted. Add a database to persist r...
1
python
def distance_transform_edt( img: NdarrayOrTensor, sampling: None | float | list[float] = None, force_scipy: bool = False ) -> NdarrayOrTensor: """ Euclidean distance transform, either GPU based with CuPy / cuCIM or CPU based with scipy.ndimage. Choice depends on cuCIM being available or scipy can be...
Review this code and list any quality issues.
[ { "issue": "Thanks for the PR, I would suggest all the input should be channel-first since most of the monai transform follows instead of onlt treating 4D with channel-first which may cause confusion with CHW and HWD just like @john-zielke-snkeos said.\r\nhttps://github.com/Project-MONAI/MONAI/blob/e5f933781b1a...
1
python
Parameters ---------- link : RigidLink The target link. local_point : torch.Tensor or None, shape (3,) Coordinates of the point in the link’s *local* frame. If None, the link origin is used (back-compat). Returns ------- jacobian : tor...
Review this code and list any quality issues.
[ { "issue": "Just call `local_point = torch.as_tensor(local_point, device=gs.device, dtype=torch.float32)` systematically if not None. Take inspiration from `RigidSolver._sanitize_1D_io_variables`.", "severity": "critical", "line": 26 } ]
1
python
------- :class:`Mobject` ``self`` See Also -------- :meth:`add` """ for mobject in mobjects: if mobject in self.submobjects: self.submobjects.remove(mobject) return self def __sub__(self, other): raise NotImpl...
Review this code and list any quality issues.
[ { "issue": "Like with animate I felt an inline example was necessary as the method signature doesn't give anything away.", "severity": "minor", "line": 26 } ]
1
python
"DecoderLayer", ], ) model = accelerate.dispatch_model( model, device_map=device_map, offload_buffers=True ) else: model.to(device) return model, tokenizer elif gptq_config and gptq_config.wbits < 16: model, toke...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if dtype is not None: # Overwrite dtype if it is provided in the arguments.\r\n```", "severity": "minor", "line": 26 } ]
1
python
) items = [] accounts_d = async_to_sync(get_account_id_to_name_mapping)() cloudtrail_errors = {} cloudtrail_errors_j = red.get( config.get( "celery.cache_cloudtrail_errors_by_arn.redis_key", "CLOUDTRAIL_ERRORS_BY_ARN", ) ) if cloudtrail_errors_j: ...
Review this code and list any quality issues.
[ { "issue": "Ahhh, I don't seem to have permission to push to this branch... this line should be:\r\n`ujson.loads(role_details.get(\"policy\", {}))` instead of `ujson.loads(role_details.get(\"policy\"), {})`\r\nand that should fix the unit tests.", "severity": "critical", "line": 26 } ]
1
python
) mocker.patch.object(tool_loader, "load_tool_for_script_node", return_value=(None, tool)) mocker.patch( "promptflow._core.tools_manager.BuiltinsManager._load_tool_from_module", return_value=(mock_python_func, {}), ) tool_resolver = ToolResolver(working_dir=Path...
Review this code and list any quality issues.
[]
0
python
"""The Dexcom integration.""" from pydexcom import AccountError, Dexcom, SessionError from homeassistant.const import CONF_PASSWORD, CONF_USERNAME from homeassistant.core import HomeAssistant from homeassistant.exceptions import ConfigEntryNotReady from .const import CONF_SERVER, PLATFORMS, SERVER_OUS from .coordina...
Review this code and list any quality issues.
[ { "issue": "Answering @epenet's [question in the superseded PR](https://github.com/home-assistant/core/pull/161355#discussion_r2711412683) regarding `lambda` usage...\r\n\r\n`Dexcom` [uses `kwargs`](https://github.com/gagebenne/pydexcom/blob/696cc9c6bc2b48628ceebda2f64049c36dbf8c17/pydexcom/dexcom.py#L39):\r\n`...
1
python
class AvatarSession: """AvatarTalkAPI avatar session""" def __init__( self, *, api_url: NotGivenOr[str | None] = NOT_GIVEN, api_secret: NotGivenOr[str | None] = NOT_GIVEN, avatar_name: NotGivenOr[str | None] = NOT_GIVEN, avatar_expression: NotGivenOr[str | None] ...
Review this code and list any quality issues.
[ { "issue": "can you provide a default api url?", "severity": "minor", "line": 26 } ]
1
python
ElectricCurrentConverter: ( UnitOfElectricCurrent.AMPERE, UnitOfElectricCurrent.MILLIAMPERE, 0.001, ), ElectricPotentialConverter: ( UnitOfElectricPotential.MILLIVOLT, UnitOfElectricPotential.VOLT, 1000, ), EnergyConverter: (UnitOfEnergy.WATT_HOUR, UnitOfE...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n CONCENTRATION_PARTS_PER_BILLION,\r\n```", "severity": "minor", "line": 26 } ]
1
python
from yt_dlp.utils.traversal import ( traverse_obj, ) from .common import InfoExtractor from ..utils import ( ExtractorError, join_nonempty, parse_duration, unified_timestamp, url_or_none, ) class ParlviewIE(InfoExtractor): _WORKING = True _VALID_URL = r'https?://(?:www\.)?aph\.gov\.au...
Review this code and list any quality issues.
[ { "issue": "yt-dlp uses relative imports\n```suggestion\n```", "severity": "minor", "line": 4 } ]
1
python
Parameters ---------- data : iterable[(int, pd.DataFrame)] The data to write. Each element should be a tuple of sid, data where data has the following format: columns : ('open', 'high', 'low', 'close', 'volume') open : float64 hig...
Review this code and list any quality issues.
[]
0
python
message_bytes, input_bytes = parse_blob(input_bytes) message_48 = type(respond_additions).from_bytes(message_bytes) assert message_48 == respond_additions assert bytes(message_48) == bytes(respond_additions) message_bytes, input_bytes = parse_blob(input_bytes) message_49 = type(reject_additions).fr...
Review this code and list any quality issues.
[]
0
python
"""Test that the selection is kept when the dropdown is closed.""" get_selectbox_input(app, "selectbox 4 (more options)").click() # Take a snapshot of the selection dropdown: expect(app.locator('[data-baseweb="popover"]').first).to_be_visible() # Click outside to close the dropdown: app.get_by_tes...
Review this code and list any quality issues.
[]
0
python
if TYPE_CHECKING: from typing import Any from typing_extensions import Self from manim.typing import Point3D TEXT_MOB_SCALE_FACTOR = 0.05 DEFAULT_LINE_SPACING_SCALE = 0.3 TEXT2SVG_ADJUSTMENT_FACTOR = 4.8 __all__ = ["Text", "Paragraph", "MarkupText", "register_font"] def remove_invisible_chars(mobject:...
Review this code and list any quality issues.
[ { "issue": "It would be nice to have a small PR refactoring this code. I suggest defining an inner function called something like `get_mobject_without_dots(mob)` or `exclude_dots_from_mobject(mob)` and then doing something like:\r\n```py\r\n if isinstance(mobject, Text):\r\n submob_group = mobject[:]\...
1
python
@unittest.skipIf(not is_peft_available(), "Only with PEFT") def test_lora_adapter_metadata_is_loaded_correctly(self, rank, lora_alpha, use_dora): from peft import LoraConfig from diffusers.loaders.peft import PeftAdapterMixin init_dict, _ = self.prepare_init_args_and_inputs_for_common() ...
Review this code and list any quality issues.
[]
0
python
vol.Required(CONF_USERNAME): cv.string, vol.Required(CONF_HEATING_TYPE, default=DEFAULT_HEATING_TYPE.value): vol.In( [e.value for e in HeatingType] ), } ) class ViCareConfigFlow(ConfigFlow, domain=DOMAIN): """Handle a config flow for ViCare.""" VERSION = 1 async def async...
Review this code and list any quality issues.
[ { "issue": "Make sure you're using Python 3.14. It's valid syntax to leave out the parentheses (and preferred by prek/pre-commit/ruff) then.", "severity": "minor", "line": 26 } ]
1
python
request_configs_buf, ] results = [] failed_rank = -1 try: for i in range(self.num_ranks): failed_rank = i self.sockets[i].send_multipart(msg_buf, copy=False) # TODO(Jiayi): we can use zmq poll to optimize a bit for...
Review this code and list any quality issues.
[ { "issue": "nit: it's better not to use f-string when using loggers.\r\n\r\n```suggestion\r\n logger.error(\r\n \"Timeout occurred for rank %d, \"\r\n \"recreating all sockets. Error: %s\",\r\n failed_rank, e\r\n )\r\n```", "severity": "crit...
1
python
_TESTS = [{ 'url': 'https://www.microsoft.com/en-us/videoplayer/embed/RWL07e', 'md5': '69a3bff81349094e91b303ff51393de2 Microsoft for Public Health and Social Services [RWL07e].mp4', 'info_dict': { 'id': 'RWL07e', 'title': '...', 'ext': 'mp4', 'th...
Review this code and list any quality issues.
[ { "issue": "typo? or is it actually small `m`?", "severity": "minor", "line": 26 } ]
1
python
endpoint=endpoint, timeout=timeout, retries=retries, ) def send_requests( self, requests: List[Request], deployment: str, head: bool = False, shard_id: Optional[int] = None, polling_type: PollingType = PollingType.ANY, endpoint...
Review this code and list any quality issues.
[]
0
python
from collections import OrderedDict from mindsdb.integrations.libs.const import HANDLER_CONNECTION_ARG_TYPE as ARG_TYPE connection_args = OrderedDict( url={ "type": ARG_TYPE.URL, "description": "Confluence URL", "label": "url", "required": True }, username={ "type"...
Review this code and list any quality issues.
[]
0
python
""" module = typeobj.__module__ if module is None or module == str.__class__.__module__: return typeobj.__name__ # Avoid reporting __builtin__ return module + "." + typeobj.__name__ def min_version(the_module: Any, min_version_str: str = "", *_args: Any) -> bool: """ Convert version strin...
Review this code and list any quality issues.
[]
0
python
self.xml.endElement("natural") else: self.xml.characters(str(related_att)) else: self.xml.addQuickElement("None") self.xml.endElement("field") def handle_m2m_field(self, obj, field): """ Handle a ManyToManyField. Related objects are only seria...
Review this code and list any quality issues.
[ { "issue": "If we move this boolean test into your helper, then we can avoid adding this branch and ensure we aren't missing analogous changes for the `queryset_iterator` nested function.", "severity": "major", "line": 26 } ]
1
python
return next_op def _actor_info_summary_str(info: _ActorPoolInfo) -> str: total = info.running + info.pending + info.restarting base = f"Actors: {total}" if total == info.running: return base else: return f"{base} ({info})" def _format_schema_mismatch_section( title: str, entries...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n truncate_num_mismatched_fields_to: Max entries shown before truncation.\n \n Returns:\n A formatted message for the warning section, or \"\" if entries is empty.\n```", "severity": "minor", "line": 26 } ]
1
python
}, }, { # new BV video id format 'url': 'https://www.bilibili.com/video/BV1JE411F741', 'only_matching': True, }, { # Anthology 'url': 'https://www.bilibili.com/video/BV1bK411W797', 'info_dict': { 'id': 'BV1bK411W797', 'title': '物语中的人物是如何吐槽自...
Review this code and list any quality issues.
[ { "issue": "there is no longer any anthology in the tests?", "severity": "minor", "line": 26 } ]
1
python
import pytest import torch import deepspeed from deepspeed.ops.op_builder import FPQuantizerBuilder if not deepspeed.ops.__compatible_ops__[FPQuantizerBuilder.NAME]: pytest.skip("FPQuantizer op is not available on this system", allow_module_level=True) from deepspeed.ops.fp_quantizer import FP_Quantize, matmul_f...
Review this code and list any quality issues.
[ { "issue": "Will the following work?\r\n```suggestion\r\n quant_config = QuantizationConfig(group_size = quantization_group_size, q_dtype = FPQuantizerBuilder.get_default_quant_dtype())\r\n```", "severity": "minor", "line": 26 } ]
1
python
command = [ sys.executable, "-m", "manim", "--renderer", "opengl", "-ql", "--write_to_movie", "--media_dir", str(tmp_path), simple_scenes_path, scene_name, ] out, err, exit_code = capture(command) assert exit_code == 0, ...
Review this code and list any quality issues.
[ { "issue": "Could you rename this to something like \"video_config\". Reason is that `config` is used as manim's global config, not really an issue atm but in future if someone imports it in here it could get overwritten and also avoids confusion with the global config.", "severity": "minor", "line": 26...
1
python
Formatter().format_transcripts([self.transcript]) def test_srt_formatter(self): content = SRTFormatter().format_transcript(self.transcript) lines = content.split('\n') # test starting lines self.assertEqual(lines[0], "1") self.assertEqual(lines[1], "00:00:00,000 --> 00:00:0...
Review this code and list any quality issues.
[ { "issue": "This probably should be two separate tests. It would also be great if you could test whether `{'text': 'line between', 'start': 1.5, 'duration': 2.0},` has been formatted correctly, since in this case `start + duration` is larger than the `start` of the next line.", "severity": "minor", "lin...
1
python
} ) d = dd.from_pandas(df, npartitions=2) d.to_parquet( tmpdir, partition_on=partition_on, write_index=False, engine="pyarrow" ) out = dd.read_parquet( tmpdir, index=False, gather_statistics=False, engine="pyarrow" ) out = out.compute() for...
Review this code and list any quality issues.
[]
0
python
f"{entity_info.primary_attribute.attribute_id}" ) self._attr_device_info = DeviceInfo( identifiers={(DOMAIN, f"{ID_TYPE_DEVICE_ID}_{node_device_id}")} ) self._attr_available = self._endpoint.node.available # mark endpoint postfix if the device has the primary attribut...
Review this code and list any quality issues.
[ { "issue": "Note: It keeps current behavior to have `self._name_postfix` get set to `self._get_name_modifier()` (label) AFTER doing the translation + endpoint-postfix calculations above. If we set `self._attr_name = None`, single endpoint entities with a label won't include the label postfix in the entity name ...
1
python
self.mod = mod self.has_device = hasattr(self.mod, "device") self.has_cpu_thresh = hasattr(self.mod, "cpu_tresh") def __call__(self, inputs, *args, **kwargs): try: return self.mod(inputs, *args, **kwargs) except RuntimeError as e: if "OutOfMemoryError" not in...
Review this code and list any quality issues.
[ { "issue": "I think this will crash if self.mod does not have \"device\" property", "severity": "critical", "line": 26 } ]
1
python
revision=revision, data_dir=data_dir, data_files=data_files, download_config=download_config, download_mode=download_mode, ).get_module() except Exception as e1: # All the attempts failed, before raising ...
Review this code and list any quality issues.
[ { "issue": "Should we change and make more specific the raised messages?", "severity": "minor", "line": 26 } ]
1
python
def test_novariance(self): """ Check that methods handle no variance in data Primarily for Scott and FD as the SD and IQR are both 0 in this case """ novar_dataset = np.ones(100) novar_resultdict = {'fd': 1, 'scott': 1, 'rice': 1, 'sturges': 1, ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n assert(len(edges_auto) < 20)\r\n```", "severity": "minor", "line": 26 } ]
1
python
), ): evaluator.evaluate(evaluation_config) # Check the results. mock_build_inference_engine.assert_not_called() mock_save_evaluation_output.assert_not_called() mock_check_prerequisites.assert_called_once() mock_get_evaluation_function.assert_not_called() @pytest.mark.parametrize( ...
Review this code and list any quality issues.
[]
0
python
# Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. # SPDX-License-Identifier: Apache-2.0 """Tests that ensure the boot time to init process is within spec.""" import datetime import re import time import pytest from framework.properties import global_props # The maximum acceptable boot time i...
Review this code and list any quality issues.
[ { "issue": "That's fine, we are going to remove this test soon. \r\n\r\nSo overall we should expect a ~20ms boot time regression in the dashboards?", "severity": "major", "line": 16 } ]
1
python
# 4. ToTensor + Normalize (deterministic) to_tensor = transforms.ToTensor() normalize = transforms.Normalize([0.5], [0.5]) image = normalize(to_tensor(image)) if dest_image is not None: dest_image = normalize(to_tensor(dest_image)) return (image, dest_image) if dest_...
Review this code and list any quality issues.
[]
0
python
MoveMsg, MoveRetMsg, PinMsg, PinRetMsg, ) from lmcache.v1.cache_controller.observability import PrometheusLogger from lmcache.v1.token_database import ChunkedTokenDatabase """ The kv controller use `(instance_id, worker_id)` -> [location -> set[chunk_hash]] as kv_pool. When the the number of instance is s...
Review this code and list any quality issues.
[ { "issue": "Could you remind me the benefit of changing the data structure of `kv_pool` from `dict[int, list[KVChunkMetadata]]` to `dict[tuple[str, int], dict[str, set[int]]]`?", "severity": "minor", "line": 26 } ]
1
python
class TransformerBlock(nn.Module): """ A transformer block, based on: "Dosovitskiy et al., An Image is Worth 16x16 Words: Transformers for Image Recognition at Scale <https://arxiv.org/abs/2010.11929>" """ def __init__( self, hidden_size: int, mlp_dim: int, num_heads...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n dropout_rate (float, optional): fraction of the input units to drop. Defaults to 0.0.\r\n qkv_bias (bool, optional): apply bias term for the qkv linear layer. Defaults to False.\r\n```", "severity": "minor", "line": 26 } ]
1
python
'title': 'Екатерина Михайлова: "Горе от ума" не про женщин написана', 'description': 'md5:fa3bdd59ee829dfaf16e3efcb13f1d19', 'uploader': 'Полина Цветкова+Евгения Акопова', 'channel': 'Все там будем', 'channel_id': 'budem', 'channel_url': 'https://budem.mave.di...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n 'channel_id', 'episode_code')\r\n display_id = f'{channel_id}-{episode_code}'\r\n```", "severity": "minor", "line": 26 } ]
1
python
This method does not perform memory usage measurement. Instead, it just reads the data received through the `event_data` parameter, which is expected to be supplied by the event manager. Args: event_data: System info data from which memory usage is read. """ snapshot = Memor...
Review this code and list any quality issues.
[ { "issue": "I think we could skip calling `get_memory_info()` when `event_data.memory_info` is `MemoryInfo` and just use `memory_info.total_size.bytes` instead.", "severity": "major", "line": 26 } ]
1
python
self.seg1 = torch.tensor(self.seg1) self.segn = torch.tensor(self.segn) def test_script_save(net, *inputs, device=None, rtol=1e-4, atol=0.0): """ Test the ability to save `net` as a Torchscript object, reload it, and apply inference. The value `inputs` is forward-passed through the original and lo...
Review this code and list any quality issues.
[ { "issue": "Can we just get rid of the try/except blocks?", "severity": "minor", "line": 26 } ]
1
python
# XXX: torch 1.6.0 DataLoader will auto convert tuple to list elif isinstance(batch[1], (tuple, list)): loaded = [] for x in batch[1]: assert torch.is_tensor(x) x = x.to(self.device).detach() loaded.append(x) ...
Review this code and list any quality issues.
[ { "issue": "How can we guard against overflow if entries into `meta_buffer` is more than `TENSOR_META_SIZE`", "severity": "critical", "line": 26 } ]
1
python
from __future__ import annotations import click import cloup from manim import __version__ from manim._config import cli_ctx_settings, console from manim.cli.cfg.group import cfg from manim.cli.checkhealth.commands import checkhealth from manim.cli.default_group import DefaultGroup from manim.cli.init.commands import...
Review this code and list any quality issues.
[ { "issue": "Do we need to mention that it is unused here? It just seems like something that's easy to forget if we ever change it to actually use the parameter.", "severity": "minor", "line": 26 } ]
1
python
import itertools import re from .common import InfoExtractor from ..utils import ( ExtractorError, clean_html, determine_ext, dict_get, extract_attributes, float_or_none, int_or_none, parse_duration, str_or_none, try_get, unified_strdate, url_or_none, urljoin, ) cl...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n _DOMAINS = r'(?:xhamster\\.(?:com|one|desi)|xhms\\.pro|xhamster\\d+\\.(?:com|desi)|xhday\\.com|xhvid\\.com)'\r\n```\r\n\r\n[**Don't capture groups you don't use**](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#dont-capture-groups-you-dont-use)", "severity": "m...
1
python
And, Or, Not, Gt, Ge, Lt, Le, Eq, Ne, Mask, IdxMax, IdxMin, If, ] class OpsWrapper: """Ops Wrapper""" def __init__(self): self._ops = {} def reset(self): self._ops = {} def register(self, ops_list): for _operator in ops_list: ...
Review this code and list any quality issues.
[ { "issue": "Add more docs about the `register` function (especially the `ops_list`).", "severity": "minor", "line": 26 } ]
1
python
# you may not use this file except in compliance with the License. # You may obtain a copy of the License at # http://www.apache.org/licenses/LICENSE-2.0 # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR ...
Review this code and list any quality issues.
[ { "issue": "Could mention the paper link here. \r\nYou may check whether this one is the correct link.\r\n\"<https://arxiv.org/pdf/1711.11585.pdf>\"", "severity": "minor", "line": 26 } ]
1
python
@pytest.fixture(autouse=True) def mock_get_battery(): """Mock get_battery function.""" with ( patch( "homeassistant.components.tessie.get_battery", return_value=TEST_VEHICLE_BATTERY, ) as mock_get_battery, patch( "homeassistant.components.tessie.coordi...
Review this code and list any quality issues.
[]
0
python
'description': 'md5:fb5a6c2e506f013cc76f133f673bc5c8', 'uploader': 'Nomad Capitalist', 'thumbnail': 'https://data-1.utreon.com/v/ZD/k1/Mj/C4ZxXhYBBmE/C4ZxXhYBBmE_628342076198c9c06dd6b2c665978584_cover.jpg', 'release_date': '20210723', } }, { 'url': 'https://utreon...
Review this code and list any quality issues.
[ { "issue": "why not directly parse it from the string. That way, if they add new resolutions, it will automatically work", "severity": "minor", "line": 26 } ]
1
python
---------- number The numeric value to be displayed. It can later be modified using `.set_value()`. num_decimal_places The number of decimal places after the decimal separator. Values are automatically rounded. mob_class The class for rendering digits and units, by default `MathTex`....
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n Size of the font.\r\n```", "severity": "minor", "line": 26 } ]
1
python
attention_mask: Optional[torch.Tensor] = None, position_ids: Optional[torch.LongTensor] = None, past_key_values: Optional[Cache] = None, output_attentions: bool = False, use_cache: bool = False, cache_position: Optional[torch.LongTensor] = None, **kwargs, ) -> tuple[t...
Review this code and list any quality issues.
[]
0
python
from typing import NamedTuple, Optional import transformers from oumi.core.configs import ModelParams from oumi.core.configs.internal.internal_model_config import ( InternalFeatureFirstDimAction, InternalFeatureSpec, InternalModelConfig, InternalVisualModelConfig, ) from oumi.core.registry import REGI...
Review this code and list any quality issues.
[ { "issue": "it can also be an `oumi` custom model (but they aren't normally reaching this code path). \r\n\r\nCan we log some warning here with model name? The function is cached so the logging should happen only once.", "severity": "major", "line": 26 } ]
1
python
continue subtitle = self._decrypt_subtitles(data, iv, sid).decode('utf-8') lang_code = self._search_regex(r'lang_code=["\']([^"\']+)', subtitle, 'subtitle_lang_code', fatal=False) if not lang_code: continue subtitles[lang_code] = self._extract_subtitles(su...
Review this code and list any quality issues.
[ { "issue": "Verbose log will automatically show this\r\n```suggestion\r\n```", "severity": "minor", "line": 26 } ]
1
python
compose_version = None try: compose_version = docker.compose.version() except DockerException: pytest.fail("`docker compose` not available. Make sure compose plugin is installed") try: docker_version = docker.version() except NotImplementedError: docker_version = run_comm...
Review this code and list any quality issues.
[ { "issue": "It _should_ fix the `ruff` formatting error in CI:\n```suggestion\n health_response = api_request(\"GET\", path=\"monitor/health\")\n```", "severity": "minor", "line": 26 } ]
1