language string | code-snippit string | instruction string | flaws list | flaw_count int64 |
|---|---|---|---|---|
python | elif beta == 0:
f_score = precision
else:
# The score is defined as:
# score = (1 + beta**2) * precision * recall / (beta**2 * precision + recall)
# Therefore, we can express the score in terms of confusion matrix entries as:
# score = (1 + beta**2) * tp / ((1 + beta**2) * tp... | Review this code and list any quality issues. | [
{
"issue": "Why remove the assert statement?",
"severity": "minor",
"line": 26
}
] | 1 |
python | if self.get_matter_attribute_value(clusters.Identify.Attributes.IdentifyType):
supported_features |= VacuumEntityFeature.LOCATE
# create a map of supported run modes
run_modes: list[clusters.RvcRunMode.Structs.ModeOptionStruct] = (
self.get_matter_attribute_value(
... | Review this code and list any quality issues. | [
{
"issue": "`_calculate_features` adds `CLEAN_AREA` based on `ServiceArea.SupportedAreas`, but feature recalculation is currently skipped when `AcceptedCommandList` is unchanged. If supported areas change over time (including becoming available after startup), `supported_features` can become stale and `CLEAN_AR... | 1 |
python | nv.validate_min((), kwargs)
result = masked_reductions.min(
self._data,
self._mask,
skipna=skipna,
axis=axis,
)
return self._wrap_reduction_result("min", result, skipna=skipna, axis=axis)
def max(self, *, skipna: bool = True, axis: AxisInt | N... | Review this code and list any quality issues. | [
{
"issue": "I think this should always be a NumPy array; can you check? Change this to `assert isinstance(result, np.ndarray)` and see that tests still pass.",
"severity": "minor",
"line": 26
}
] | 1 |
python | """
The result of a call to build/run when passing the detailed_summary=True argument.
Attributes:
- summary_text_one_line (str): One line summary of the progress.
- summary_text (str): Detailed summary of the progress.
- status (LuigiStatusCode): Luigi Status Code. See :class:`~luigi.e... | Review this code and list any quality issues. | [
{
"issue": "maybe \r\n\r\n return \"LuigiRunResult with status {0}\".format(self.status)\r\n\r\n?",
"severity": "minor",
"line": 26
}
] | 1 |
python | Attributes
----------
subset_size : int
The size at which characters are grouped into subsets.
used : dict[tuple[str, int], dict[CharacterCodeType, GlyphIndexType]]
A dictionary of font files to character maps. The key is a font filename and
subset within that font. The value is a di... | Review this code and list any quality issues. | [
{
"issue": "Your definition of \"charmap\" is a map of charcodes to glyph indices, whereas freetype's definition maps glyph indices to charcodes (see e.g. the swapping in embedTTFType3. Both are obviously equivalent and I can imaging why this definition actually works better for us, but that probably warrants ... | 1 |
python | wpf = WeightProofHandler(
blockchain_constants, BlockchainMock(sub_blocks, header_cache, height_to_hash, summaries)
)
wpf_verify = WeightProofHandler(
blockchain_constants, BlockchainMock(sub_blocks, header_cache, height_to_hash, {})
)
for x in range(10, -1, -1):
... | Review this code and list any quality issues. | [
{
"issue": "i think all these tests need to move, how are they related to Weight Proofs ?",
"severity": "minor",
"line": 26
}
] | 1 |
python | )
async def test_wait_trigger_matches_with_zero_timeout(
hass: HomeAssistant, caplog: pytest.LogCaptureFixture, timeout_param: int | str
) -> None:
"""Test the wait trigger that matches with zero timeout option."""
event = "test_event"
events = async_capture_events(hass, event)
action = {
"w... | Review this code and list any quality issues. | [
{
"issue": "This change converts valid Python 3 syntax to deprecated Python 2 syntax. In Python 3, multiple exceptions must be caught using parentheses: `except (ExceptionA, ExceptionB):`. The Python 2 syntax `except ExceptionA, ExceptionB:` is not valid in Python 3 and will cause a syntax error. This line shou... | 1 |
python | from typing import Any
def get_llm_metadata(
model_name: str,
llm_type: str,
session_id: str | None = None,
user_id: str | None = None,
) -> dict[str, Any]:
"""
Generate LLM metadata for OpenHands CLI.
Args:
model_name: Name of the LLM model
agent_name: Name of the agent (... | Review this code and list any quality issues. | [] | 0 |
python | python -m monai.bundle run --net#input_chns 1 ...
# Override config values with another config file `/path/to/another.json`:
python -m monai.bundle run --net %/path/to/another.json ...
# Override config values with part content of another config file:
python -m monai.bundle run --net %... | Review this code and list any quality issues. | [
{
"issue": "It's really key for what's going here that the default value for `workflow_name` will be `ConfigWorkflow` is `None` is passed as the argument, it's worth commenting here that that's the case.",
"severity": "minor",
"line": 26
}
] | 1 |
python | # The Growatt API sometimes delivers stale yesterday values after a midnight
# reset (0 → stale → 0), causing TOTAL_INCREASING double-counting.
if (
entity_description.state_class is SensorStateClass.TOTAL_INCREASING
and not entity_description.never_resets
and return_... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n _LOGGER.debug(\n \"Suppressing midnight bounce for %s: stale value %s matches \"\n \"pre-reset value, keeping %s\",\n variable,\n current_val,\n previ... | 1 |
python | if host == 'win64':
try:
with zipfile.ZipFile(archive, 'r') as zip:
zip.extractall(tag)
# Remove the top level directory to match tar's --strip-components=1
extracted_items = os.listdir(tag)
top_level_dir = os.path.join(tag, extracted_items[0])
... | Review this code and list any quality issues. | [
{
"issue": "Your new code still looks wrong, when someone sets `HOST=x86_64-apple-darwin` on an arm machine, where signing isn't needed for that case.\n\nWhy not use `args.host` and keep the `\"arm64-apple-darwin\"` string?",
"severity": "critical",
"line": 26
}
] | 1 |
python | },
'skip': 'Requires Authentication',
}]
def _perform_login(self, username, password):
webpage = self._download_webpage(self._LOGIN_URL, None)
form = self._search_regex(
r'(?s)<form[^>]+action="/account/login"[^>]*>(.+?)</form>',
webpage, 'login form', default=No... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n return # If only one profile, Hidive auto-selects it\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | def reverse_target_pattern(pattern: str) -> tuple[str, str | None]:
"""
Process a target pattern for reverse mapping (when targets become sources).
This handles several edge cases in checkpoint conversion mappings:
- Removes `^` prefix and `$` suffix (start/end of string anchors)
- Removes negative... | Review this code and list any quality issues. | [
{
"issue": "A slightly simpler version such as this one should work the same way no?\r\n```suggestion\r\n # Allow capturing groups in patterns, i.e. to add/remove a prefix to all keys (e.g. timm_wrapper, sam3)\r\n capturing_group_match = re.search(r\"\\(.+?\\)\", pattern)\r\n```",
"severity": "minor",... | 1 |
python | 'url': 'https://murrtube.net/v/0J2Q',
'md5': '31262f6ac56f0ca75e5a54a0f3fefcb6',
'info_dict': {
'id': '8442998c52134968d9caa36e473e1a6bac6ca',
'ext': 'mp4',
'uploader': 'Hayel',
'title': 'Who\'s in charge now?',
'des... | Review this code and list any quality issues. | [
{
"issue": "need to do this or else we are passing a `re.Match` object around as the id\r\n```suggestion\r\n video_id = self._match_id(url)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | class LookupClientInterface(metaclass=abc.ABCMeta):
"""Abstract interface for lookup clients."""
def lookup_cache(self, lookup_id: str) -> Optional[int]:
"""
Lookup the cache for the given lookup ID.
Args:
lookup_id: The lookup ID to lookup
"""
return None
... | Review this code and list any quality issues. | [] | 0 |
python | 'info_dict': {
'id': 'gdansk-stare-miasto',
'ext': 'mp4',
'title': 'GDAŃSK - widok na Stare Miasto'
}
}]
def _real_extract(self, url):
video_id = self._match_id(url)
webpage = self._download_webpage(url, video_id)
title = self._html_search_re... | Review this code and list any quality issues. | [
{
"issue": "If formats already extracted, it not necessary to set `url` and `ext` field, as this information already in `formats` field\r\n```suggestion\r\n```",
"severity": "major",
"line": 26
}
] | 1 |
python | raise Exception("Internal error") from e
return kv_id
raise
if row is None:
raise Exception("Internal error")
if use_file:
path = self.get_key_value_path(store_id=store_id, blob_hash=blob_hash)
path.parent.mkdir(parents=True, exist_ok=Tru... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n del self.unconfirmed_keys_values[store_id]\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | rawhex = "0100000001b14bdcbc3e01bdaad36cc08e81e69c82e1060bc14e518db2b49aa43ad90ba260000000004a01ff473" + \
"04402203f16c6f40162ab686621ef3000b04e75418a0c0cb2d8aebeac894ae360ac1e780220ddc15ecdfc3507ac48e168" + \
"1a33eb60996631bf6bf5bc0a0682c4db743ce7ca2b01ffffffff0140420f00000000001976a914660d4e... | Review this code and list any quality issues. | [
{
"issue": "[d641c5a](https://github.com/bitcoin/bitcoin/pull/34054/changes/d641c5a): _Add functional test exercising tx downloadman recently confirmed filter_:\n\nThis passes with the fix, which means we're not fully reproducing the error:\n```suggestion\n assert ibd_wtxid not in peer_inver.getdata_... | 1 |
python | )
limit_to_placeholder_values: bool = SchemaField(
description="Whether to limit the selection to placeholder values.",
default=False,
)
class Output(BlockSchema):
result: Any = SchemaField(description="The value passed as input.")
def __init__(self):
su... | Review this code and list any quality issues. | [
{
"issue": "You have to set a default value for fmt_string to None or set fmt_string to advanced=True",
"severity": "minor",
"line": 26
}
] | 1 |
python | # DecisionTreeRegressor with `criterion="absolute_error"`
# ------------------------------------------------------
# :class:`tree.DecisionTreeRegressor` with `criterion="absolute_error"`
# now runs much faster. It has now `O(n * log(n))` complexity compared to
# `O(n**2)` previously, which allows to scale to millions o... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n# Classical MDS, also known as \"Principal Coordinates Analysis\" (PCoA)\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | citation_regexp = re.compile(r"\(\[([^\]]+)\]\((https?:\/\/[^\)]+)\)")
async for event in stream:
_LOGGER.debug("Event[%s]", getattr(event, "type", None))
if isinstance(event, LLMResponseOutputItemAddedEvent):
if isinstance(event.item, LLMResponseFunctionCallOutputItem):
... | Review this code and list any quality issues. | [
{
"issue": "Side note for the future: Consider using a match/case statement instead. It has builtin support for isinstance check.\r\n\r\nhttps://peps.python.org/pep-0636/#adding-a-ui-matching-objects",
"severity": "minor",
"line": 26
}
] | 1 |
python | if (
(old_idx > 0)
and (new_idx > 0)
and (old_fields[old_idx - 1] == new_fields[new_idx - 1])
):
old_idx -= 1
new_idx -= 1
elif (new_idx == 0) or (
old_idx > 0 and dp[o... | Review this code and list any quality issues. | [
{
"issue": "The new warning formatting logic builds a full O(N*M) DP table to compute the longest common subsequence of fields just to identify mismatches, which adds quadratic time and memory overhead in the number of fields and significantly increases the complexity of this logging path. Since this code is on... | 1 |
python | A dictionary representing the function signature in the format expected by LLM tools.
Raises:
ValueError: If the block specified by sink_node.block_id is not found.
"""
block = get_available_blocks()[sink_node.block_id]
if not block:
raise ValueError(f"Block not ... | Review this code and list any quality issues. | [
{
"issue": "What is \"The {link.sink_name} of the tool\" supposed to represents ?",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'info_dict': {
'id': '6376598467112',
'ext': 'mp4',
'title': 'Pedro Sousa «Hjulmand pode ter uma saída limpa do Sporting daqui a um ano»',
'description': '',
'uploader_id': '6108484330001',
'duration': 65.237,
'thumbnail': r're:^https:/... | Review this code and list any quality issues. | [
{
"issue": "we don't use `video_data` for anything else, so let's get the BC `video_id` right away\r\n```suggestion\r\n video_id = self._search_json(\r\n r'videoHandler\\.addBrightcoveVideoWithJson\\(\\[',\r\n webpage, 'video data', display_id)['brightcoveVideoId']\r\n```",
"sev... | 1 |
python | "High Private Use Surrogates",
"Low Surrogates",
"Variation Selectors",
"Specials",
"Egyptian Hieroglyph Format Controls",
"Tags",
"Variation Selectors Supplement",
}
def parse_unicode_data() -> None:
lines: list[str] = [line.decode("utf-8") for line in urlopen(URL)]
for line in lines... | Review this code and list any quality issues. | [] | 0 |
python | async def on_shutdown():
file_utils.remove_folder(project.dir)
async def export(q: Q):
shutil.make_archive('app', 'zip', '.', project.dir)
q.app.zip_path, = await q.site.upload(['app.zip'])
q.page["meta"].script = ui.inline_script(f'window.open("{q.app.zip_path}", "_blank");')
os.remove("app.zip")... | Review this code and list any quality issues. | [
{
"issue": "I think using a proper table would be a better fit both in terms of UI and UX. The dependency removal can work on selection basis: Display \"Remove selected\" button, enabled only when selected > 0.",
"severity": "minor",
"line": 26
}
] | 1 |
python | )
print(color_yellow_bold(msg))
print(color_green_bold("Let's start by refining your project idea:"))
convo = AgentConvo(self)
convo.construct_and_add_message_from_prompt('spec_writer/ask_questions.prompt', {})
user_response = initial_prompt
while True:
llm_... | Review this code and list any quality issues. | [
{
"issue": "instead of `[\"\", \"yes\", \"ok\", \"y\", \"continue\"]` we should use `AFFIRMATIVE_ANSWERS`",
"severity": "minor",
"line": 26
}
] | 1 |
python | NOTICE
Role: You are a professional engineer; the main goal is to write PEP8 compliant, elegant, modular, easy to read and maintain Python 3.9 code (but you can also use other programming language)
ATTENTION: Use '##' to SPLIT SECTIONS, not '#'. Output format carefully referenced "Format example".
## Code: {filename} ... | Review this code and list any quality issues. | [] | 0 |
python | }, note=f'Downloading {media_typ} stream data',
impersonate=self._IMPERSONATE_TARGET)
path_template = traverse_obj(stream, ('resource', 'uri', {str}))
def format_path(params):
path = path_template
for i, val in (params or {}).items():
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n format_id = traverse_obj(quality, ('name', {str}))\r\n\r\n m3u8_data = self._download_webpage(\r\n url, media_id, fatal=False, impersonate=self._IMPERSONATE_TARGET,\r\n note=join_nonempty('Downloading', format_id, ... | 1 |
python | )
else:
token_ids = output["output_ids"]
log_probs = None
routed_experts = None
if self.config.enable_rollout_routing_replay:
if self.config.skip_tokenizer_init:
routed_experts = output.get("meta_info", {}).get("routed_experts", None)
... | Review this code and list any quality issues. | [
{
"issue": "**Keep Profiler Logic Cohesive**: The profiler logic seems to be scattered across the main workflow. It would be better to encapsulate it to keep the main execution path clean and cohesive. Avoid adding too much profiling-specific code directly into the core rollout logic",
"severity": "minor",
... | 1 |
python | host=entry.data[CONF_HOST],
username=entry.data[CONF_USERNAME],
password=entry.data[CONF_PASSWORD],
session=session,
use_ssl=entry.data[SECTION_ADVANCED_SETTINGS][CONF_SSL],
)
coordinator = AirOSDataUpdateCoordinator(hass, entry, airos_device)
await coordinator.async_config_... | Review this code and list any quality issues. | [] | 0 |
python | )
out, _ = capfd.readouterr()
assert "user log" not in out
assert "error log" not in out
# flow logs won't stream
assert "Executing node print_val. node run id:" not in out
# executor logs won't stream
assert "Node print_val completes." not in out
def test_fo... | Review this code and list any quality issues. | [] | 0 |
python | attention_mask = dummy_input.ne(0).to(torch.long)
model = Jais2ForCausalLM.from_pretrained(model_id, torch_dtype=torch.float16, device_map="auto")
with torch.no_grad():
logits = model(dummy_input, attention_mask=attention_mask).logits
logits = logits.float()
# fmt: off
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n torch.tensor(EXPECTED_LOGITS_BATCH0, device=torch_device),\n```",
"severity": "major",
"line": 26
}
] | 1 |
python | def test_constraints_not_installed_by_default(
script: PipTestEnvironment, data: TestData
) -> None:
script.scratch_path.joinpath("c.txt").write_text("requiresupper")
result = script.pip(
"install",
"--no-build-isolation",
"--no-index",
"-f",
data.find_links,
... | Review this code and list any quality issues. | [] | 0 |
python | )
result = annotator.annotate(scene=test_image.copy(), detections=detections)
assert_image_mostly_same(test_image, result, similarity_threshold=0.85)
class TestEllipseAnnotator:
"""Tests for EllipseAnnotator class"""
def test_annotate_with_no_detections(self, test_image):
"""Test that... | Review this code and list any quality issues. | [] | 0 |
python | return code
class OpenCodeInterpreter(object):
"""https://github.com/KillianLucas/open-interpreter"""
def __init__(self, auto_run: bool = True) -> None:
interpreter = Interpreter()
interpreter.auto_run = auto_run
interpreter.model = CONFIG.openai_api_model or "gpt-3.5-turbo"
in... | Review this code and list any quality issues. | [
{
"issue": "also, provide an English version for the comments.",
"severity": "minor",
"line": 26
}
] | 1 |
python | return found
def bb_contains_stackstring(bb: ghidra.program.model.block.CodeBlock) -> bool:
"""check basic block for stackstring indicators
true if basic block contains enough moves of constant bytes to the stack
"""
count = 0
for insn in listing.getInstructions(bb, True):
if is_mov_imm_t... | Review this code and list any quality issues. | [
{
"issue": "Can we sub [`getAddress(0)`](https://ghidra.re/ghidra_docs/api/ghidra/program/database/code/InstructionDB.html#getAddress(int)) for `getOpObjects(0)[0]`?",
"severity": "minor",
"line": 26
}
] | 1 |
python | # Log token fetch status
if provider_tokens:
logger.info(
f'/start endpoint: Fetched provider tokens: {list(provider_tokens.keys())}',
extra={'session_id': conversation_id},
)
else:
logger.warning(
'/start endpoint: No provider tokens fetched (provider... | Review this code and list any quality issues. | [] | 0 |
python | 'thumbnail': 'https://media.cnn.com/api/v1/images/stellar/prod/221205163510-robin-meade-sign-off.jpg?c=original',
'duration': 158.0,
'title': 'Robin Meade signs off after HLN\'s last broadcast',
'description': 'md5:9f28e46df86b7eb1efe36a7d1cd46f2c',
'upload_date': '202212... | Review this code and list any quality issues. | [
{
"issue": "Get the ld+json `VideoObject` for the headline video:\r\n```suggestion\r\n json_ld = traverse_obj([\r\n variadic(x) for x in self._yield_json_ld(webpage, display_id, fatal=False)],\r\n (..., ((..., 'video'), None), lambda _, v: v['@type'] == 'VideoObject'))\r\n js... | 1 |
python | if local_path in self.rendered_files:
self.rendered_files[local_path].unlink()
self.rendered_files[local_path] = tmpfile
os.makedirs(tmpfile.parent, exist_ok=True)
shutil.copy(local_path, tmpfile)
file_type = mimetypes.guess_type(confi... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n return config[\"scene_names\"][0] + \"@\" + datetime.now().strftime(\"%y-%m-%d@%H-%M-%S\")\r\n```\r\ngot this from here:\r\n",
"severity": "minor",
"line": 26
... | 1 |
python | screenshots = []
with sync_playwright() as p:
browser = p.chromium.launch()
page = browser.new_page()
page.goto(self.url)
viewport_height = page.viewport_size["height"]
screenshot_counter = 1
screenshot_data_list = []
def c... | Review this code and list any quality issues. | [
{
"issue": "why having duplicate data structures `screenshots` and `screenshot_data_list`?\r\n\r\nkeep only one of the two, and drop the other",
"severity": "major",
"line": 26
}
] | 1 |
python | cls._default_config._unique_sections[default_section.name] = default_section
elif def_sections := cls._default_config._sections.get(default_section.name, None):
def_sections[default_section.id] = default_section
else:
cls._default_config._sections[default_section.name] = {default... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n cls._serializer._section_class[section.name] = section.__class__\r\n cls.__json_serializer._section_class[section.name] = section.__class__\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | for media in traverse_obj(media_data, 'medias', default=[]):
if not media.get('url') or media.get('type') != 'HLS':
continue
f, subs = self._extract_m3u8_formats_and_subtitles(
update_url_query(media['url'], {'id_token': self._ID_TOKEN}),
media_dat... | Review this code and list any quality issues. | [
{
"issue": "Something like this:\r\n```py\r\n return {\r\n 'thumbnails': thumbnails,\r\n 'formats': formats,\r\n 'subtitles': subtitles,\r\n **traverse_obj(media_data, {\r\n 'id': ('id', {str}),\r\n 'title': ('name', {str}),\r\n ... | 1 |
python | 'upload_date': '20230325',
},
'params': {'skip_download': True},
'skip': 'Live might have ended',
}
]
def _real_extract(self, url):
match = self._match_valid_url(url)
video_id = match.group('id')
video_key = match.group('key')
webpage ... | Review this code and list any quality issues. | [
{
"issue": "same as above\r\n```suggestion\r\n 'https://services.radio-canada.ca/media/validation/v2/', video_id, query={\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | ... print(reader.variable_labels()) # doctest: +SKIP
{'index': '', 'col_1': 'This is an example', 'col_2': ''}
>>> pd.read_stata(path) # doctest: +SKIP
index col_1 col_2
0 0 1 2
1 1 3 4
"""
self._ensure_open()
return dict(... | Review this code and list any quality issues. | [
{
"issue": "Can `_read_stata_doc` (and any associated variables) be removed after this change?",
"severity": "minor",
"line": 26
}
] | 1 |
python | {
'execution_providers': [ 'cuda' ]
}, headers =
{
'Authorization': 'Bearer ' + create_session_body.get('access_token')
})
set_state_body = set_state_response.json()
assert set_state_body.get('execution_providers') == [ 'cuda' ]
assert set_state_response.status_code == 200
set_state_response = test_client.... | Review this code and list any quality issues. | [
{
"issue": "I wonder why this can pass on invalid paths",
"severity": "minor",
"line": 26
}
] | 1 |
python | # TODO, make this more understandable, and/or combine
# its functionality with AnimationGroup's method
# build_animations_with_timings
lag_ratio = self.lag_ratio
full_length = (num_submobjects - 1) * lag_ratio + 1
value = alpha * full_length
lower = index * lag_ratio
... | Review this code and list any quality issues. | [
{
"issue": "This is really not needed imo.",
"severity": "minor",
"line": 26
}
] | 1 |
python | class PixivSketchUserIE(PixivSketchBaseIE):
IE_NAME = 'pixiv:sketch:user'
_VALID_URL = r'https?://sketch\.pixiv\.net/@(?P<id>[a-zA-Z0-9_-]+)/?'
_TESTS = [{
'url': 'https://sketch.pixiv.net/@nuhutya',
'only_matching': True,
}, {
'url': 'https://sketch.pixiv.net/@namahyou',
... | Review this code and list any quality issues. | [
{
"issue": "u can make additional requests here if needed",
"severity": "minor",
"line": 26
}
] | 1 |
python | }, {
'url': 'https://beta.crunchyroll.com/pt-br/watch/G8WUN8VKP/the-ruler-of-conspiracy',
'only_matching': True,
}]
# We want to support lazy playlist filtering and movie listings cannot be inside a playlist
_RETURN_TYPE = 'video'
def _real_extract(self, url):
lang, internal_id ... | Review this code and list any quality issues. | [
{
"issue": "have you / has anyone tested if many logged-in requests to the switch endpoint results in a soft ban? (like unsigned cms endpoint requests would do before)",
"severity": "minor",
"line": 26
}
] | 1 |
python | @override_settings(USE_THOUSAND_SEPARATOR=True)
def test_list_display_for_value_boolean(self):
self.assertEqual(
display_for_value(True, "", boolean=True),
'<img src="/static/admin/img/icon-yes.svg" alt="True">',
)
self.assertEqual(
display_for_value(False... | Review this code and list any quality issues. | [
{
"issue": "Can this test case show something more realistic like raw HTML?",
"severity": "minor",
"line": 26
}
] | 1 |
python | url_or_none,
urlencode_postdata
)
class CanvasIE(InfoExtractor):
_VALID_URL = r'https?://mediazone\.vrt\.be/api/v1/(?P<site_id>canvas|een|ketnet|vrt(?:video|nieuws)|sporza|dako)/assets/(?P<id>[^/?#&]+)'
_TESTS = [{
'url': 'https://mediazone.vrt.be/api/v1/ketnet/assets/md-ast-4ac54990-ce66-4d00-a8c... | Review this code and list any quality issues. | [
{
"issue": "Are you sure HLS always have DRM? Otherwise, it shouldn't be removed like this",
"severity": "minor",
"line": 26
}
] | 1 |
python | if video_url is None or video_id is None:
return info_dict
base_name = 'clip' if '/clips/' in video_url else 'montage'
info_dict['webpage_url'] = f'https://allstar.gg/{base_name}?{base_name}={video_id}'
info_dict['webpage_url_basename'] = base_name
return info_dict
def... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n profile_data = self._download_json(\r\n urljoin('https://api.allstar.gg/v1/users/profile/', display_id), display_id)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | p2shscript = CScript([OP_0, sha256(script)])
return script_to_p2sh_script(p2shscript)
def output_key_to_p2tr_script(key):
assert len(key) == 32
return program_to_witness_script(1, key)
def check_key(key):
if isinstance(key, str):
key = bytes.fromhex(key) # Assuming this is hex string
if... | Review this code and list any quality issues. | [
{
"issue": "d1a2e27: it would be nice to have a more general interface where we can pass the parent + child amount and fees.\r\n\r\ncc @vasild - you might be interested in this too. I hadn't considered passing both wallet and node as arguments to the function in #32385. there are other functions in util.py whic... | 1 |
python | @classmethod
def _get_by_tag(cls, cycle: Cycle, tag: str) -> Optional[Scenario]:
scenarios = cls._get_all_by_cycle(cycle)
for scenario in scenarios:
if scenario.has_tag(tag):
return scenario
return None
@classmethod
def _get_all_by_tag(cls, tag: str) -> L... | Review this code and list any quality issues. | [
{
"issue": "Maybe, we can sort by `config_id` as well. It has some business meaning since it is populated by a user. So it makes sense to sort by `config_id` in case of multiple scenario configurations.\r\nWe can also sort by label (which can be different from the name). \r\n\r\nWhat do you think?",
"severi... | 1 |
python | relationship = 'credentials'
class InventoryUpdateCancel(GenericCancelView):
model = models.InventoryUpdate
serializer_class = serializers.InventoryUpdateCancelSerializer
class InventoryUpdateNotificationsList(SubListAPIView):
model = models.Notification
serializer_class = serializers.NotificationSe... | Review this code and list any quality issues. | [
{
"issue": "Oh this sucks. Thanks for digging up and figuring out this sloppy work.",
"severity": "minor",
"line": 26
}
] | 1 |
python | use_gpu=use_gpu,
chunk_size=chunk_size,
dtype=kv_dtype,
device=device,
)
tpg = get_tp_group()
else:
vllm_gpu_connector = VLLMPagedMemGPUConnectorV2(
hidden_dim_size,
num_layer,
use_gpu=use_gpu,
... | Review this code and list any quality issues. | [
{
"issue": "super nit (sorry): \r\n```python\r\n\r\nif role == \"scheduler\" and lmcache_config.enable_scheduler_bypass_lookup:\r\n assert (\r\n engine.save_only_first_rank\r\n or lmcache_config.get_extra_config_value(\r\n \"remote_enable_mla_worker_id_as0\", metadata.use... | 1 |
python | return list(selector({
'formats': formats,
'has_merged_format': any('none' not in (f.get('acodec'), f.get('vcodec')) for f in formats),
'incomplete_formats': (all(f.get('vcodec') == 'none' for f in formats) # No formats with video
or all(f.get('aco... | Review this code and list any quality issues. | [
{
"issue": "Side note: I think having `simulate` result in a different default format spec should be considered a bug. A dry-run should be no different than the real thing, right?\r\n\r\nIt looks like we can trace this logic back to https://github.com/ytdl-org/youtube-dl/commit/0017d9ad6de831384e74db14a821e4c94... | 1 |
python | device_class=SensorDeviceClass.ENUM,
options=[
"calculating_baseline",
"normal",
"high",
"low",
],
),
TractiveSensorEntityDescription(
key=ATTR_RESTING_RESPIRATORY_RATE,
translation_key="resting_respiratory_rate",
signal_pre... | Review this code and list any quality issues. | [
{
"issue": "You shouldn't combine two types of changes in a single PR. If it's supposed to be a bugfix, it shouldn't add new entities.\n\nBTW, if possible, after the release of the new version of aiotractive, this PR should be split into two parts. One to bump the aiotractive version, the other to migrate senso... | 1 |
python | if fingerprint_generator and header_generator is not self._DEFAULT_HEADER_GENERATOR:
raise ValueError(
'Do not use `header_generator` and `fingerprint_generator` arguments at the same time. '
'Choose only one. `fingerprint_generator` generates headers as well.'
)
... | Review this code and list any quality issues. | [
{
"issue": "Why can't we just use `len(self._pages)`?",
"severity": "minor",
"line": 26
}
] | 1 |
python | input_tensor = torch.randn(d0, d1, num_heads, head_dim, device=ds_engine.device)
scatter_idx = 2
batch_dim_idx = 0
outputs = []
seq_dims = [0] #seq first API
#TODO: Add support for batch first (that seq_dims=[0,1]) after PR for bs>1 issue with batch first is fixed
## See... | Review this code and list any quality issues. | [] | 0 |
python | stroke_width=stroke_width,
fill_color=fill_color,
stroke_opacity=stroke_opacity,
stroke_color=stroke_color,
**kwargs,
)
self._move_into_position(width, height)
def _ensure_valid_file(self):
"""Reads self.file_name and determines whether the gi... | Review this code and list any quality issues. | [
{
"issue": "use the `/` operator here: https://docs.python.org/3/library/pathlib.html#operators",
"severity": "minor",
"line": 26
}
] | 1 |
python | import numba
@normalize_token.register(numba.core.serialize.ReduceMixin)
def normalize_numba_ufunc(obj):
return normalize_token((obj._reduce_class(), obj._reduce_states()))
@normalize_token.register_lazy("pyarrow")
def register_pyarrow():
import pyarrow as pa
@normalize_token.register(pa.Dat... | Review this code and list any quality issues. | [
{
"issue": "In the tests, we assert that `tokenize(thing)` equals `tokenize(cloudpickle.loads(cloudpickle.dumps(thing)))`.\r\n\r\nI need to dig into what pyarrow is doing when pickling Arrays / ChunkedArrays, but it seems to \"normalize\" the data in a couple of ways\r\n\r\n1. ChunkedArrays with multiple chunks... | 1 |
python | #
# Copyright 2016 Quantopian, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in wr... | Review this code and list any quality issues. | [
{
"issue": "What do you think about calling this `_contracts` and exposing it with a `contracts` property?\n\nI imagine this being particularly useful in conjunction with `data.history` and `data.current`, which can take a list of contracts as an arg, so you could do:\n\n```\nCL_history = data.history(future_ch... | 1 |
python | elt = EmptyLineTracker(mode=mode)
split_line_features = {
feature
for feature in {Feature.TRAILING_COMMA_IN_CALL, Feature.TRAILING_COMMA_IN_DEF}
if supports_feature(versions, feature)
}
block: Optional[LinesBlock] = None
for current_line in lines.visit(src_node):
block = ... | Review this code and list any quality issues. | [
{
"issue": "This feels a bit janky to using `decode_bytes` like this, but I can't think of anything better. Could we add a comment to this whole logic explaining what it does?",
"severity": "minor",
"line": 26
}
] | 1 |
python | spend_2_1_id = self.nodes[0].sendrawtransaction(spend_2_1['hex'])
assert_equal(set(self.nodes[0].getrawmempool()), {spend_1_id, spend_2_1_id, timelock_tx_id})
self.sync_all()
self.log.info("invalidate the last block")
for node in self.nodes:
node.invalidateblock(last_block[... | Review this code and list any quality issues. | [
{
"issue": "actually this is wrong, the test is checking that `timelock_tx_id` is *not* in mempool. If we don't use `invalidateblock` it's essentially impossible to trigger this behavior since the chain should not move backwards in height ever.\r\n\r\nI re-read this PR after writing up https://github.com/bitcoi... | 1 |
python | glyph: GlyphIndexType) -> tuple[int, CharacterCodeType]:
"""
Record character code *charcode* at glyph index *glyph* as using font *font*.
Parameters
----------
font : FT2Font
A font that is being used for the provided string.
chars : str or CharacterCodeType... | Review this code and list any quality issues. | [
{
"issue": "I guess that should be `charcodes` (plural)?",
"severity": "minor",
"line": 26
}
] | 1 |
python | )[0]
center_x, center_y = center_coordinates
return (
center_x - text_w // 2,
center_y - text_h // 2,
center_x + text_w // 2,
center_y + text_h // 2,
)
def annotate(
self, scene: ImageType, key_points: KeyPoints, labels: List[str] = No... | Review this code and list any quality issues. | [
{
"issue": "if labels are `None`, this fails with `TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'`\r\n\r\nSomething basic would work, for example:\r\n```\r\nif labels is None:\r\n labels = [str(i) for i in range(K)]\r\n```\r\n\r\nI've checked - it produces the correct COCO IDs for both ul... | 1 |
python | # %%
# Finally, we assemble the dataset and perform a train test split:
import pandas as pd
from sklearn.model_selection import train_test_split
X = pd.DataFrame(
np.concatenate(
[X_informative, X_shuffled, X_near_unique_categories],
axis=1,
),
columns=["informative", "shuffled", "near_uni... | Review this code and list any quality issues. | [] | 0 |
python | import inspect
from . import _api
def kwarg_doc(text):
"""
Decorator for defining the documentation used when artist properties are
passed through as keyword arguments.
See e.g. the ``**kwargs`` section in `.Axes.text`.
The given text is stored in a privat variable ``_kwarg_doc`` on the method.... | Review this code and list any quality issues. | [
{
"issue": "The phrasing of this implies that this is already implemented via interpolation",
"severity": "minor",
"line": 16
}
] | 1 |
python | metadata_address=0x5000,
app_ldscript="nrf52840_layout_b.ld",
app_address=0x80000,
),
"nrf52840_dongle_opensk":
nrf52840dk_opensk_board._replace(
path="third_party/tock/boards/nordic/nrf52840_dongle_opensk",),
"nrf52840_dongle_dfu":
nrf52840dk_opensk_b... | Review this code and list any quality issues. | [
{
"issue": "`CARGO_TARGET_DIR = os.environ.get(\"CARGO_TARGET_DIR\", \"target\")`\r\n\r\nshould also work? The second parameter is the default, if not present.",
"severity": "minor",
"line": 26
}
] | 1 |
python | It should work as a factory for creating new browser instances.
"""
AUTOMATION_LIBRARY = 'playwright'
def __init__(
self,
*,
browser_type: BrowserType = 'chromium',
browser_launch_options: Mapping[str, Any] | None = None,
browser_new_context_options: Mapping[str, An... | Review this code and list any quality issues. | [
{
"issue": "Little out of scope, but since we're touching it... Couldn't we set this docstring in the `BaseBrowserPlugin.__init__`? Same for the `BaseBrowserController`.",
"severity": "minor",
"line": 26
}
] | 1 |
python | # base class "ArrowExtensionArray" defined the type as "ArrowDtype")
_dtype: StringDtype # type: ignore[assignment]
_storage = "pyarrow"
_na_value: libmissing.NAType | float = libmissing.NA
def __init__(self, values) -> None:
_chk_pyarrow_available()
if isinstance(values, (pa.Array, pa... | Review this code and list any quality issues. | [
{
"issue": "Worth raising if `dtype.storage != \"pyarrow\"`?",
"severity": "minor",
"line": 26
}
] | 1 |
python | "This can be avoided by either filtering beforehand, or\n"
"passing in the name of the column instead:\n"
"\n"
"df2 = df[df.foo < 0]\n"
"df2.groupby(df2.bar)\n"
"# or\n"
"df[df.foo < 0].groupby('bar')\n"
"\n"
"For more infor... | Review this code and list any quality issues. | [
{
"issue": "Now that we have dropped support for Python 2 we can probably include these keywords explicitly in the signature. Previously we avoided this because they were after a `*args`, which was not valid Python syntax.",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.histogram_only = histogram_only
self.extra_params = extra_params
@staticmethod
def _check_data_uniformity(keys: list[str], result: dict) -> bool:
"""
Check data uniformity since DataAnalyzer provides no support to multi-modal images with different
affine matrices/spacings d... | Review this code and list any quality issues. | [
{
"issue": "The docstrings of `get_all_case_stats` and `_get_all_case_stats` need to be updated.",
"severity": "minor",
"line": 26
}
] | 1 |
python | from __future__ import annotations
import pytest
from chia_rs.sized_bytes import bytes32
from chia_rs.sized_ints import uint32, uint64
from chia._tests.util.db_connection import DBConnection
from chia.consensus.coinbase import create_farmer_coin, create_pool_coin
from chia.full_node.coin_store import CoinStore
# bla... | Review this code and list any quality issues. | [
{
"issue": "this seems to be a duplication of the existing fixture. duplicating would defeat what i believe is it's purpose of having a single place to define a new db version to be tested against and then having all relevant tests parametried accordingly.\r\n\r\nhttps://github.com/Chia-Network/chia-blockchain... | 1 |
python | self.stretch_to_fit_width(width)
self.stretch_to_fit_height(height)
class Square(Rectangle):
"""A rectangle with equal side lengths.
Parameters
----------
side_length : :class:`float`, optional
The length of the sides of the square.
kwargs : Any
Additional arguments to be ... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n self.add(square_1, square_2, square_3)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | sources: Set[Path],
fast: bool,
write_back: WriteBack,
mode: Mode,
report: "Report",
workers: Optional[int],
) -> None:
"""Reformat multiple files using a ProcessPoolExecutor."""
from concurrent.futures import Executor, ThreadPoolExecutor, ProcessPoolExecutor
executor: Executor
work... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n loop = asyncio.new_event_loop()\r\n asyncio.set_event_loop(loop)\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | DeltaGeneratorSingleton._instance = self
self._main_dg = delta_generator_cls(root_container=_RootContainer.MAIN)
self._sidebar_dg = delta_generator_cls(
root_container=_RootContainer.SIDEBAR, parent=self._main_dg
)
self._event_dg = delta_generator_cls(
root_conta... | Review this code and list any quality issues. | [] | 0 |
python | def reset_points(self):
self.rgbas = np.zeros((0, 4))
self.points = np.zeros((0, 3))
return self
def init_uniforms(self):
super().init_uniforms()
self.uniforms["point_radius"] = (
self.stroke_width * OpenGLPMObject.OPENGL_POINT_RADIUS_SCALE_FACTOR
)
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n opacity = self.rgbas[-1, 3]\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | expected = pd.array([None, None, True], dtype="bool[pyarrow]")
expected[-1] = getattr(other[-1], op_name)(a[-1])
tm.assert_extension_array_equal(result, expected)
def test_comparison_methods_list(comparison_op, dtype):
op_name = f"__{comparison_op.__name__}__"
a = pd.array(["a", None, "c"], dtype=dty... | Review this code and list any quality issues. | [] | 0 |
python | self.generate(wallet, 1)
block_files = list(node.blocks_path.glob('blk[0-9][0-9][0-9][0-9][0-9].dat'))
undo_files = list(node.blocks_path.glob('rev[0-9][0-9][0-9][0-9][0-9].dat'))
assert_equal(len(block_files), len(undo_files))
assert_greater_than(len(block_files), 1) # we want at lea... | Review this code and list any quality issues. | [
{
"issue": "nit: could put this already into the commit that introduces the blocks_key_path property to TestNode.",
"severity": "minor",
"line": 26
}
] | 1 |
python | def _real_extract(self, url):
video_id = self._match_id(url)
api_path = f'/videos/{video_id}'
""""
{
'views': 94,
'uploaded': True,
'publicURl': '55cc94',
'date': '2021-10-20T21:17:23.887Z',
'name': '55cc94',
'video... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n return {\r\n 'id': video_id,\r\n 'title': json_data.get('name') or video_id,\r\n 'url': 'https://streamff.com/%s' % json_data['videoLink'],\r\n 'view_count': int_or_none(json_data.get('views')),\r\n 'timestamp': parse_is... | 1 |
python | for _ in range(TEST_WORKER_COUNT):
worker = HostEchoWorker(path, blob_path)
workers.append(worker)
worker.start()
for wrk in workers:
wrk.join()
# Create snapshot.
snapshot = test_vm.snapshot_full()
test_vm.resume()
# Check that sockets are no longer working on wor... | Review this code and list any quality issues. | [
{
"issue": "hmm the original had a typo: recieved",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'x-ms-wmv': 'wmv',
'x-msvideo': 'avi',
# application (streaming playlists)
'dash+xml': 'mpd',
'f4m+xml': 'f4m',
'hds+xml': 'f4m',
'vnd.apple.mpegurl': 'm3u8',
'vnd.ms-sstr+xml': 'ism',
'x-mpegurl': 'm3u8',
# audio
('audio', 'mp4'): 'm4a',... | Review this code and list any quality issues. | [
{
"issue": "Suggestion\r\n```diff\r\ndiff --git a/yt_dlp/utils.py b/yt_dlp/utils.py\r\nindex eee257f16..b01f22370 100644\r\n--- a/yt_dlp/utils.py\r\n+++ b/yt_dlp/utils.py\r\n@@ -3467,13 +3467,13 @@ def mimetype2ext(mt, default=NO_DEFAULT):\r\n 'x-mpegurl': 'm3u8',\r\n\r\n # audio\r\n- ('a... | 1 |
python | retry.error = e
continue
raise
if not video_list.get('videos'):
break
yield from video_list['videos']
query['before_time'] = traverse_obj(video_list, ('videos', -1, 'timestamp'))
if not query['before_time']:
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n videos = self._extract_video_list(username, user_id)\r\n```\r\nwhy LazyList?",
"severity": "major",
"line": 26
}
] | 1 |
python | # output
# Test that Jupytext markdown comments are preserved before fmt:off/on blocks
# %% [markdown]
# fmt: off
# fmt: on
# Also test with other comments
# Some comment
# %% [markdown]
# Another comment
# fmt: off
x = 1
# fmt: on
# Test multiple markdown comments
# %% [markdown]
# First markdown
# %% [code]
# Co... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n\n```\n\nThe `output` section can be omitted to automatically assert no changes",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'series': ('custom_data', 'program_name'),
'title': ('custom_data', 'program_name'),
}),
}
class TBSJPPlaylistIE(InfoExtractor):
_VALID_URL = r'https://cu\.tbs\.co\.jp/playlist/(?P<id>[\da-f]+)'
_TESTS = [{
'url': 'https://cu.tbs.co.jp/playlist/184f9970e7ba48e4915f1... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n # TODO: it's likely possible to get most/all of the metadata from the playlist page json instead\r\n```\r\nIs this meant to be a todo?",
"severity": "minor",
"line": 26
}
] | 1 |
python | 'episode_number': 12,
'episode_id': 24,
},
}, {
'note': 'Empty title',
'url': 'https://duoplay.ee/17/uhikarotid?ep=14',
'md5': '6aca68be71112314738dd17cced7f8bf',
'info_dict': {
'id': '17',
'ext': 'mp4',
'title': 'Episode 14',
... | Review this code and list any quality issues. | [
{
"issue": "This test is currently failing due to `episode_number` and `episode` missing.\r\nIf you accept the other suggestion, then `episode_id` will also need to be removed, `series_id` needs to be made a string, and the `id` entries need to be updated to include the episode number.\r\nI think it would be go... | 1 |
python | from __future__ import annotations
import logging
import os
import shutil
import struct
import sys
import tempfile
from dataclasses import dataclass
from enum import Enum, auto
from math import prod
from pathlib import Path
from io import BufferedWriter
from typing import IO, Any, Sequence, Mapping, Union
from string ... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\nfrom typing import IO, Any, Sequence, Mapping\r\n```",
"severity": "minor",
"line": 14
}
] | 1 |
python | _VALID_URL = r'https?://(?:www\.)?tv5monde\.com/tv/video/(?P<id>[^/?#]+)'
_TESTS = [{
# documentary
'url': 'https://www.tv5monde.com/tv/video/65931-baudouin-l-heritage-d-un-roi-baudouin-l-heritage-d-un-roi',
'md5': 'd2a708902d3df230a357c99701aece05',
'info_dict': {
'id': ... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n 'description': 'md5:da441d0b328793dfb4059884fbee6af3',\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | self.storage_manager = storage_manager
def on_evict(
self, backend: StorageBackendInterface, keys: List[CacheEngineKey]
):
"""
remove keys from lookup server only if they don't exist in local backends.
:param StorageBackendInterface backend: The backend ... | Review this code and list any quality issues. | [
{
"issue": "Rather than defining an internal class, we can have this class defined in `storage_backend_listener.py`.",
"severity": "minor",
"line": 26
}
] | 1 |
python | Sorting by any additional 'by' grouping columns is not required.
For each row in the left DataFrame:
- A "backward" search selects the last row in the right DataFrame whose
'on' key is less than or equal to the left's key.
- A "forward" search selects the first row in the right DataFrame whos... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\n a numeric column, such as datetimelike, integer, or float. ``on``\n or ``left_on`` / ``right_on`` must be given.\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | # Update job's status to job manager
job_id = self._due_jobs_list[i][0]
self._inactive_jobs.add(job_id)
print("======> ", job_id, "expired.")
self._due_jobs_list = self._due_jobs_list[idx:]
else:
print("Unsupported scheduling policy!")
... | Review this code and list any quality issues. | [
{
"issue": "Seems this is how to use to use the job scheduler\r\n\r\nShould it be examples like a comments? or testing files? why do we list here as prod codes?",
"severity": "minor",
"line": 26
}
] | 1 |
python | if iter_time - start_time > TIME_INTERVAL_FOR_CUDA_MEMORY_CLEANING:
empty_cuda()
start_time = iter_time
self.call_hook("after_train_epoch")
self._epoch += 1
@torch.no_grad()
def val(self, data_loader, **kwargs):
start_time = time.time()
self.mode... | Review this code and list any quality issues. | [
{
"issue": "should be start_time = iter_time",
"severity": "minor",
"line": 26
}
] | 1 |
python | def test_reformat_one_with_stdin_and_existing_path(self) -> None:
with patch(
"black.format_stdin_to_stdout",
return_value=lambda *args, **kwargs: black.Changed.YES,
) as fsts:
report = MagicMock()
# Even with an existing file, since we are forcing stdin, ... | Review this code and list any quality issues. | [
{
"issue": "The docstring may be a bit redundant, because the \"doesn't fail\" could be communicated in the test name, which also is displayed when the tests are run. But take it or leave it.",
"severity": "critical",
"line": 26
}
] | 1 |
python | }, {
'url': 'https://allstar.gg/profile?user=cherokee&view=Mobile Clips',
'info_dict': {
'id': '62b8bdfc9021052f7905882d',
'title': 'cherokee - Mobile Clips',
},
'playlist_mincount': 1
}]
_PAGE_SIZE = 10
@staticmethod
def _set_webpage_url(info_di... | Review this code and list any quality issues. | [
{
"issue": "`webpage_url` should be handled in the baseclass method `_parse_video_data`. We shouldn't ever have to manually set `webpage_url_basename` in the extractor. See above suggestion\r\n```suggestion\r\n def _get_page(self, user_id, display_id, game, query, page_num):\r\n```",
"severity": "major",... | 1 |
python | Union[float, np.ndarray]
The midpoint of the points
"""
return center_of_mass([point1, point2])
def line_intersection(line1: Sequence[float], line2: Sequence[float]) -> np.ndarray:
"""Returns intersection point of two lines, each defined with
a pair of vectors determining the end points.
... | Review this code and list any quality issues. | [
{
"issue": "```suggestion\r\n Error is produced if the two lines don't intersect with each other\r\n```",
"severity": "minor",
"line": 26
}
] | 1 |
python | class Migration(migrations.Migration):
dependencies = [
("tests", "0054_delete_notyetregisteredgenericsetting_and_more"),
("wagtailcore", "0094_alter_page_locale"),
]
operations = [
migrations.CreateModel(
name="PreviewableGenericSetting",
fields=[
... | Review this code and list any quality issues. | [] | 0 |
python | from ._utils import generate_tool_call_id as _generate_tool_call_id, now_utc as _now_utc
from .exceptions import UnexpectedModelBehavior
from .usage import RequestUsage
if TYPE_CHECKING:
from .models.instrumented import InstrumentationSettings
# Register manually MIME types that are not in the standard library
# ... | Review this code and list any quality issues. | [
{
"issue": "This will affect the global mimetypes db for the current interpreter. Let's [instantiate an explicit `MimeTypes`](https://docs.python.org/3/library/mimetypes.html#mimetypes-objects) object instead, and attach the additional types directly to it.\r\n\r\nYou can then use your instance's [`guess_type()... | 1 |
python | This parameter is deprecated. Please use 'convexify' and 'decompose_(robot|object)_error_threshold' instead.
decompose_object_error_threshold : bool, optional:
For basic rigid objects (mug, table...), skip convex decomposition if the relative difference between the
volume of original mesh and its co... | Review this code and list any quality issues. | [
{
"issue": "As you said, maybe`default_amature` is a more accurate name",
"severity": "minor",
"line": 26
}
] | 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.