id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
b720303df7352d4a7a1f61e467e0a124913c0d41 | Analyze and fix the following issue in the Linux kernel code: ext4: fix memory leaks in error path handling of ext4_ext_zeroout() | Problem Details:
When EIO occurs after bio is submitted, there is no memory free
operation for bio, which results in memory leakage. And there is also
no check against bio_alloc() for bio.
Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
Signed-off-by: "Theodore Ts'o" ... | ```diff
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 236b834b4ca8..228eeaf2dccf 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2544,7 +2544,7 @@ static void bi_complete(struct bio *bio, int error)
/* FIXME!! we need to try to merge to left or right after zero-out */
static int ext4_ext_zeroou... |
f818a73674c5d197f66b636a46d7d578d7258129 | Analyze and fix the following issue in the Linux kernel code: ceph: fix cap removal races | Problem Details:
The iterate_session_caps helper traverses the session caps list and tries
to grab an inode reference. However, the __ceph_remove_cap was clearing
the inode backpointer _before_ removing itself from the session list,
causing a null pointer dereference.
Clear cap->ci under protection of s_cap_lock to a... | ```diff
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 0c1681806867..d9400534b279 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -858,6 +858,8 @@ static int __ceph_is_any_caps(struct ceph_inode_info *ci)
}
/*
+ * Remove a cap. Take steps to deal with a racing iterate_session_caps.
+ *
* caller should ho... |
06efbeb4a47b6f865e1c9d175ab9d6e90b69ae9e | Analyze and fix the following issue in the Linux kernel code: hp_accel: fix race in device removal | Problem Details:
The work queue has to be flushed after the device has been made
inaccessible. The patch closes a window during which a work queue might
remain active after the device is removed and would then lead to ACPI
calls with undefined behavior.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Acked-by: Eric Pi... | ```diff
diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
index c8ab50516672..7580f55e67e3 100644
--- a/drivers/hwmon/hp_accel.c
+++ b/drivers/hwmon/hp_accel.c
@@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
lis3lv02d_joystick_disable();
lis3lv02d_poweroff(&lis3_... |
a3ed2a15719219769bb095b28009c1d654a419e8 | Analyze and fix the following issue in the Linux kernel code: mqueue: fix kernel BUG caused by double free() on mq_open() | Problem Details:
In case of aborting because we reach the maximum amount of memory which
can be allocated to message queues per user (RLIMIT_MSGQUEUE), we would
try to free the message area twice when bailing out: first by the error
handling code itself, and then later when cleaning up the inode through
delete_inode().... | ```diff
diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 722b0130aa94..59a009dc54a8 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -158,7 +158,7 @@ static struct inode *mqueue_get_inode(struct super_block *sb,
u->mq_bytes + mq_bytes >
task_rlimit(p, RLIMIT_MSGQUEUE)) {
spin_unlock(&mq_lock);
- k... |
de145b44b95b9d3212a82d1c0f29b09778ef33c5 | Analyze and fix the following issue in the Linux kernel code: fbdev: bfin-t350mcqb-fb: fix fbmem allocation with blanking lines | Problem Details:
The current allocation does not include the memory required for blanking
lines. So avoid memory corruption when multiple devices are using the DMA
memory near each other.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Cc: <stable@kern... | ```diff
diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c
index 44e49c28b2a7..c2ec3dcd4e91 100644
--- a/drivers/video/bfin-t350mcqb-fb.c
+++ b/drivers/video/bfin-t350mcqb-fb.c
@@ -488,9 +488,9 @@ static int __devinit bfin_t350mcqb_probe(struct platform_device *pdev)
fbinfo->fbops = &bfi... |
747388d78a0ae768fd82b55c4ed38aa646a72364 | Analyze and fix the following issue in the Linux kernel code: memcg: fix css_is_ancestor() RCU locking | Problem Details:
Some callers (in memcontrol.c) calls css_is_ancestor() without
rcu_read_lock. Because css_is_ancestor() has to access RCU protected
data, it should be under rcu_read_lock().
This makes css_is_ancestor() itself does safe access to RCU protected
area. (At least, "root" can have refcnt==0 if it's not a... | ```diff
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 6db8b7f297a1..6d870f2d1228 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4464,15 +4464,36 @@ unsigned short css_depth(struct cgroup_subsys_state *css)
}
EXPORT_SYMBOL_GPL(css_depth);
+/**
+ * css_is_ancestor - test "root" css is an ancestor of "... |
7f0f15464185a92f9d8791ad231bcd7bf6df54e4 | Analyze and fix the following issue in the Linux kernel code: memcg: fix css_id() RCU locking for real | Problem Details:
Commit ad4ba375373937817404fd92239ef4cadbded23b ("memcg: css_id() must be
called under rcu_read_lock()") modifies memcontol.c for fixing RCU check
message. But Andrew Morton pointed out that the fix doesn't seems sane
and it was just for hidining lockdep messages.
This is a patch for do proper things... | ```diff
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 3a53c771e503..6db8b7f297a1 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4435,7 +4435,15 @@ __setup("cgroup_disable=", cgroup_disable);
*/
unsigned short css_id(struct cgroup_subsys_state *css)
{
- struct css_id *cssid = rcu_dereference(css->id);... |
475f9aa6aa538befcbd0fa95bdebada600f247cd | Analyze and fix the following issue in the Linux kernel code: kexec: fix OOPS in crash_kernel_shrink | Problem Details:
Two "echo 0 > /sys/kernel/kexec_crash_size" OOPSes kernel. Also content
of this file is invalid after first shrink to zero: it shows 1 instead of
0.
This scenario is unlikely to happen often (root privs, valid crashkernel=
in cmdline, dump-capture kernel not loaded), I hit it only by chance.
This pa... | ```diff
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 87ebe8adc474..474a84715eac 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1134,11 +1134,9 @@ int crash_shrink_memory(unsigned long new_size)
free_reserved_phys_range(end, crashk_res.end);
- if (start == end) {
- crashk_res.end = end;
+ if (start ==... |
d586ebbb8814e039545d38f69029533f3f17748d | Analyze and fix the following issue in the Linux kernel code: mmc: atmel-mci: fix in debugfs: response value printing | Problem Details:
In debugfs, printing of command response reports resp[2] twice: fix it to
resp[3].
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <t... | ```diff
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index b77b9b0c0695..fb279f4ed8b3 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -266,7 +266,7 @@ static int atmci_req_show(struct seq_file *s, void *v)
"CMD%u(0x%x) flg %x rsp %x %x %x %x err %d\n",
... |
ebb1fea9b3adf25d7e2f643c614163af4f93a17f | Analyze and fix the following issue in the Linux kernel code: mmc: atmel-mci: fix two parameters swapped | Problem Details:
Two parameters were swapped in the calls to atmci_init_slot().
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Reported-by: Anders Grahn <anders.grahn@hd-wireless.se>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: <linux-mmc@vger.kernel.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Mor... | ```diff
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 88be37d9e9a5..57d3cb2dbb5f 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -1751,13 +1751,13 @@ static int __init atmci_probe(struct platform_device *pdev)
ret = -ENODEV;
if (pdata->slot[0].bus_wid... |
34441427aab4bdb3069a4ffcda69a99357abcb2e | Analyze and fix the following issue in the Linux kernel code: revert "procfs: provide stack information for threads" and its fixup commits | Problem Details:
Originally, commit d899bf7b ("procfs: provide stack information for
threads") attempted to introduce a new feature for showing where the
threadstack was located and how many pages are being utilized by the
stack.
Commit c44972f1 ("procfs: disable per-task stack usage on NOMMU") was
applied to fix the ... | ```diff
diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
index a4f30faa4f1f..1e359b62c40a 100644
--- a/Documentation/filesystems/proc.txt
+++ b/Documentation/filesystems/proc.txt
@@ -316,7 +316,7 @@ address perms offset dev inode pathname
08049000-0804a000 rw-p 000... |
3c904afd7358e9ef515eb5df36b6f25c2b7fc2da | Analyze and fix the following issue in the Linux kernel code: it8761e_gpio: fix bug in gpio numbering | Problem Details:
The SIO chip contains 16 possible gpio lines, not 14. The schematic was
not read carefully.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.... | ```diff
diff --git a/drivers/gpio/it8761e_gpio.c b/drivers/gpio/it8761e_gpio.c
index 753219cf993a..41a9388f2fde 100644
--- a/drivers/gpio/it8761e_gpio.c
+++ b/drivers/gpio/it8761e_gpio.c
@@ -80,8 +80,8 @@ static int it8761e_gpio_get(struct gpio_chip *gc, unsigned gpio_num)
u16 reg;
u8 bit;
- bit = gpio_num % 7;
-... |
f33d7e2d2d113a63772bbc993cdec3b5327f0ef1 | Analyze and fix the following issue in the Linux kernel code: dma-mapping: fix dma_sync_single_range_* | Problem Details:
dma_sync_single_range_for_cpu() and dma_sync_single_range_for_device() use
a wrong address with a partial synchronization.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <ak... | ```diff
diff --git a/include/asm-generic/dma-mapping-common.h b/include/asm-generic/dma-mapping-common.h
index e694263445f7..69206957b72c 100644
--- a/include/asm-generic/dma-mapping-common.h
+++ b/include/asm-generic/dma-mapping-common.h
@@ -131,7 +131,7 @@ static inline void dma_sync_single_range_for_cpu(struct devic... |
94c1f90bb0bac8c2b75569a247b89145022c4c24 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fix bug and coding style issue in usbdux.c | Problem Details:
This is a patch to the usbdux.c file that resolve 2 errors in coding and
fix the warning about lengt of code lines
Signed-off-by: Morgan Gatti <morgan.gatti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index 8942ae45708d..df71515c7a30 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -793,7 +793,7 @@ static int usbduxsub_stop(struct usbduxsub *usbduxsub)
}
stat... |
801de52358abc9f42ee6291dae2425bca04228d6 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fixed C99 comments style issues in wl_profile.c | Problem Details:
This is a patch to the wl_profile.c file that fixes the C99 comments
style issues found by the checkpatch.pl tool.
Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/wl_profile.c b/drivers/staging/wlags49_h2/wl_profile.c
index 13ade7035731..292d5792dd75 100644
--- a/drivers/staging/wlags49_h2/wl_profile.c
+++ b/drivers/staging/wlags49_h2/wl_profile.c
@@ -91,7 +91,7 @@
#include <debug.h>
#include <hcf.h>
-//#include <hcfdef.h>
+/* ... |
a9560a72759c6208c4072a30fb45aac7c6c014d4 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fixed long line lengths in comedi.h | Problem Details:
This patch fixes quite a few long line lengths in comedi.h as reported by
checkpatch.pl
Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 20a6fee4dae6..1538146b37a3 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -156,15 +156,15 @@
#define TRIG_ANY 0xffffffff
#define TRIG_INVALID 0x00000000
-#define TRIG_NONE 0x00000001 /... |
f65515275ea3e45fdcd0fb78455f542d6fdca086 | Analyze and fix the following issue in the Linux kernel code: staging: vt6655: Fix kernel BUG on driver wpa initialization | Problem Details:
In http://bugzilla.novell.com/show_bug.cgi?id=597299, the vt6655 driver
generates a kernel BUG on a NULL pointer dereference at NULL. This problem
has been traced to a failure in the wpa_set_wpadev() routine. As the vt6656
driver does not call this routine, the vt6655 code is similarly set to skip
the ... | ```diff
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 8a63a031d00b..7020ed41e0ca 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1091,11 +1091,13 @@ device_found1(struct pci_dev *pcid, const struct pci_device_id *ent)
... |
5ae8cb9525f0481025b9bc156c7a181aff7ded47 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49: build fixes | Problem Details:
Now that the code actually gets selected in the kernel config
properly, all of the build errors start showing up.
This patch papers over a few of them to get the code to build, I have
no idea if it actually works now or not...
Cc: Henk de Groot <pe1dnn@amsat.org>
Signed-off-by: Greg Kroah-Hartman <gr... | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.c b/drivers/staging/wlags49_h2/dhf.c
index d5fb1a97e855..80a4707885d8 100644
--- a/drivers/staging/wlags49_h2/dhf.c
+++ b/drivers/staging/wlags49_h2/dhf.c
@@ -286,14 +286,14 @@ int i;
fw->signature[i+1] != (/* HCF_BIG_ENDIAN ? 'B' : */ 'L'))
rc = DHF_ERR_INC... |
ce7f6389790f24e07e7e32518c798451e799a830 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fixed unnecessary braces issues in wl_profile.c | Problem Details:
This is a patch to the wl_profile.c file that fixes the unnecessary braces
style issues found by the checkpatch.pl tool.
Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/wl_profile.c b/drivers/staging/wlags49_h2/wl_profile.c
index e4e78a4ace15..13ade7035731 100644
--- a/drivers/staging/wlags49_h2/wl_profile.c
+++ b/drivers/staging/wlags49_h2/wl_profile.c
@@ -189,9 +189,8 @@ void parse_config(struct net_device *dev)
DBG_TRACE(DbgInfo, "... |
ad602259451ddc8b0f83cb312cb54223317eda74 | Analyze and fix the following issue in the Linux kernel code: staging: dt3155v4l: last fix to correct a bug introduces a bug. Correct it. | Problem Details:
The previous patch "use_local_copy_qtype_ops.patch"
http://lkml.org/lkml/2010/5/9/40
has introduced a new BUG.
This patch corrects it.
Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dt3155v4l/dt3155v4l.c b/drivers/staging/dt3155v4l/dt3155v4l.c
index a5e409170418..49463611f4f3 100644
--- a/drivers/staging/dt3155v4l/dt3155v4l.c
+++ b/drivers/staging/dt3155v4l/dt3155v4l.c
@@ -612,7 +612,7 @@ dt3155_queue_dma_contig_init(struct videobuf_queue *q,
unsigned int... |
b8aab1278147e3b067903983a835ef3c68281b13 | Analyze and fix the following issue in the Linux kernel code: Staging: dt3155v4l: correcting a bug | Problem Details:
dt3155v4l driver, as in -rc6-next-20100506 has a BUG.
When it modifies q->int_ops structure in videobuf-dma-contig
module the change is visible for all other modules using it.
Make a local copy of this structure and use its modification
to solve the bug.
Signed-off-by: Marin Mitov <mitov@issp.bas.bg>... | ```diff
diff --git a/drivers/staging/dt3155v4l/dt3155v4l.c b/drivers/staging/dt3155v4l/dt3155v4l.c
index b1695ad9b56e..a5e409170418 100644
--- a/drivers/staging/dt3155v4l/dt3155v4l.c
+++ b/drivers/staging/dt3155v4l/dt3155v4l.c
@@ -612,9 +612,14 @@ dt3155_queue_dma_contig_init(struct videobuf_queue *q,
unsigned in... |
4a28ea9cedaa673b8a1a7f84628d784d020f3b47 | Analyze and fix the following issue in the Linux kernel code: viafb: get rid of i2c debug cruft | Problem Details:
It's ugly and adds a global.h dependency.
Cc: ScottFang@viatech.com.cn
Cc: JosephChan@via.com.tw
Cc: Harald Welte <laforge@gnumonks.org>
Acked-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Jonathan Corbet <corbet@lwn.net> | ```diff
diff --git a/drivers/video/via/via_i2c.c b/drivers/video/via/via_i2c.c
index febc1dda69c1..84ec2d6e98c4 100644
--- a/drivers/video/via/via_i2c.c
+++ b/drivers/video/via/via_i2c.c
@@ -52,7 +52,7 @@ static void via_i2c_setscl(void *data, int state)
val |= 0x80;
break;
default:
- DEBUG_MSG("viafb_i2c: spe... |
9bf10920a094d71cec1076d3fa941aa6f31b09eb | Analyze and fix the following issue in the Linux kernel code: staging: winbond: localpara.h whitespace and indentation fixes. | Problem Details:
I fixed all problems found by checkpatch.pl except a number of long
lines that I didn't find a good way to break up and still keep it
readable. I added the () to #define MAX_IE_APPEND_SIZE (256 + 4).
I also moved som comments around after pointers from Pekka.
Signed-off-by: Lars Lindley <lindley@coyot... | ```diff
diff --git a/drivers/staging/winbond/localpara.h b/drivers/staging/winbond/localpara.h
index fcf6a0442dc2..d7980575bed1 100644
--- a/drivers/staging/winbond/localpara.h
+++ b/drivers/staging/winbond/localpara.h
@@ -1,263 +1,267 @@
#ifndef __WINBOND_LOCALPARA_H
#define __WINBOND_LOCALPARA_H
-//==============... |
512abd006d57f9e12905dae8d63c7b08474f8f87 | Analyze and fix the following issue in the Linux kernel code: Staging: fix typo in Makefile | Problem Details:
This actually gets the adis16255 driver to build properly.
Cc: Matthias Brugger <mensch0815@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 5526870777c6..d5fdf1349815 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -49,4 +49,4 @@ obj-$(CONFIG_VIDEO_DT3155) += dt3155v4l/
obj-$(CONFIG_CRYSTALHD) += crystalhd/
obj-$(CONFIG_CXT1E1) += cxt1e1/
obj-$(CONFI... |
85798ec85ec6146bff3af886c06d72cc66940a05 | Analyze and fix the following issue in the Linux kernel code: staging: iio: Documentation fixes | Problem Details:
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/Documentation/sysfs-class-iio b/drivers/staging/iio/Documentation/sysfs-class-iio
index 723858215786..ff19f6e22e34 100644
--- a/drivers/staging/iio/Documentation/sysfs-class-iio
+++ b/drivers/staging/iio/Documentation/sysfs-class-iio
@@ -66,7 +66,7 @@ KernelVersion: 2.6.35
Cont... |
dd7ad5c8083de5c1820f1da711458582b10e0ed2 | Analyze and fix the following issue in the Linux kernel code: staging: ti-st: depends on RFKILL | Problem Details:
Fix build errors. st_kim.c uses rfkill*() interfaces, so it
should depend on RFKILL.
st_kim.c:(.text+0x291b21): undefined reference to `rfkill_unregister'
st_kim.c:(.text+0x291b31): undefined reference to `rfkill_destroy'
st_kim.c:(.text+0x291d8a): undefined reference to `rfkill_alloc'
st_kim.c:(.tex... | ```diff
diff --git a/drivers/staging/ti-st/Kconfig b/drivers/staging/ti-st/Kconfig
index 120e8db1368b..3ab204ddc29d 100644
--- a/drivers/staging/ti-st/Kconfig
+++ b/drivers/staging/ti-st/Kconfig
@@ -5,6 +5,7 @@
menu "Texas Instruments shared transport line discipline"
config TI_ST
tristate "shared transport core dr... |
7c1e68ba9236ef848a715cbb60b13947b9ae7289 | Analyze and fix the following issue in the Linux kernel code: staging: cxt1e1: fix semaphore build breakage | Problem Details:
Fix build errors by including linux/semaphore.h:
drivers/staging/cxt1e1/pmcc4_private.h:144: error: field 'sr_sem_busy' has incomplete type
drivers/staging/cxt1e1/pmcc4_private.h:146: error: field 'sr_sem_wait' has incomplete type
drivers/staging/cxt1e1/pmcc4_private.h:189: error: field 'sem_wdbusy' h... | ```diff
diff --git a/drivers/staging/cxt1e1/pmcc4_private.h b/drivers/staging/cxt1e1/pmcc4_private.h
index 0ae18c444a75..b2b6e3702630 100644
--- a/drivers/staging/cxt1e1/pmcc4_private.h
+++ b/drivers/staging/cxt1e1/pmcc4_private.h
@@ -20,6 +20,7 @@
#include <linux/kernel.h>
#include <linux/sched.h>
+#include <linux... |
0809a7bbe8fbcb4e899b0a3224d8461bd74987e0 | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix incorrect handling of type 2 and 3 RX messages | Problem Details:
According to Intel Wimax i3200, i5x50 and i6x60 device specification documents,
the host driver must not reset the device if the normalized sequence numbers
are greater than 1023 for type 2 and type 3 RX messages.
This patch removes the code that incorrectly used to reset the device.
Signed-off-by: Pr... | ```diff
diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c
index 71b697f3a68d..66f968a24d49 100644
--- a/drivers/net/wimax/i2400m/rx.c
+++ b/drivers/net/wimax/i2400m/rx.c
@@ -743,12 +743,12 @@ unsigned __i2400m_roq_update_ws(struct i2400m *i2400m, struct i2400m_roq *roq,
unsigned new_nws, nsn_... |
d11a6e4495ee1fbb38b59bc88d49d050d3736929 | Analyze and fix the following issue in the Linux kernel code: wimax i2400m: fix race condition while accessing rx_roq by using kref count | Problem Details:
This patch fixes the race condition when one thread tries to destroy
the memory allocated for rx_roq, while another thread still happen
to access rx_roq.
Such a race condition occurs when i2400m-sdio kernel module gets
unloaded, destroying the memory allocated for rx_roq while rx_roq
is accessed by i24... | ```diff
diff --git a/drivers/net/wimax/i2400m/i2400m.h b/drivers/net/wimax/i2400m/i2400m.h
index 7a9c2c5b25cb..b8c7dbfead49 100644
--- a/drivers/net/wimax/i2400m/i2400m.h
+++ b/drivers/net/wimax/i2400m/i2400m.h
@@ -412,7 +412,7 @@ struct i2400m_barker_db;
*
* @tx_size_max: biggest TX message sent.
*
- * @rx_lock:... |
85a19e07e30f67c517266cafe92b7bcd9b98966d | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix system freeze caused by an infinite loop [v1] | Problem Details:
This patch fixes an infinite loop caused by i2400m_tx_fifo_push() due
to a corner case where there is no tail space in the TX FIFO.
Please refer the documentation in the code for details.
Signed-off-by: Prasanna S. Panchamukhi <prasannax.s.panchamukhi@intel.com> | ```diff
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c
index 101550a2f5a2..609f1ca6e9fc 100644
--- a/drivers/net/wimax/i2400m/tx.c
+++ b/drivers/net/wimax/i2400m/tx.c
@@ -341,6 +341,14 @@ size_t __i2400m_tx_tail_room(struct i2400m *i2400m)
* @padding: ensure that there is at least this man... |
9e6e3bd52b0f77ca5cc385892c14ff8ba5ecfa67 | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: modify i2400m_tx_fifo_push() to check for head room space in the TX FIFO [v1] | Problem Details:
This fixes i2400m_tx_fifo_push(); the check for having enough
space in the TX FIFO's tail was obscure and broken in certain
corner cases. The new check works in all cases and is way
clearer. Please refer the documentation in the code for details.
Signed-off-by: Prasanna S. Panchamukhi <prasannax.s.pan... | ```diff
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c
index 1725f2b022a2..101550a2f5a2 100644
--- a/drivers/net/wimax/i2400m/tx.c
+++ b/drivers/net/wimax/i2400m/tx.c
@@ -396,8 +396,20 @@ void *i2400m_tx_fifo_push(struct i2400m *i2400m, size_t size, size_t padding)
/* Is there space at the... |
718e94907d79e74bbc7cfdb3cda2266079c5e993 | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix BUILD_BUG_ON() to use the maximum message size constant [v1] | Problem Details:
The older method of computing the maximum PDU size relied
on a method that doesn't work when we prop the maximum
number of payloads up to the physical limit, and thus we kill
the whole computation and just verify that the constants are
congruent.
Signed-off-by: Prasanna S. Panchamukhi <prasannax.s.pan... | ```diff
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c
index a5002c8467c2..1725f2b022a2 100644
--- a/drivers/net/wimax/i2400m/tx.c
+++ b/drivers/net/wimax/i2400m/tx.c
@@ -287,19 +287,6 @@ enum {
* documents, the maximum size of each message can be up to 16KiB.
*/
I2400M_TX_MSG_SIZE =... |
2354161dd33b204d36caa0bc48c95cc6c1a984fb | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: Correct the error path handlers order in i2400m_post_reset() | Problem Details:
When bus_setup fails in i2400m_post_reset(), it falls to the error path handler
"error_bus_setup:" which includes unlock the mutext. However, we didn't ever
try to the obtain the lock when running bus_setup.
The patch is to fix the misplaced error path handler "error_bus_setup:".
Signed-off-by: Cindy... | ```diff
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c
index d83fe84407bf..39cf96a90d7a 100644
--- a/drivers/net/wimax/i2400m/driver.c
+++ b/drivers/net/wimax/i2400m/driver.c
@@ -629,12 +629,12 @@ int i2400m_post_reset(struct i2400m *i2400m)
error_dev_start:
if (i2400m->bus_releas... |
f4e413458104210bc29aa5c437882c68b4b20100 | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix for missed reset events if triggered by dev_reset_handle() | Problem Details:
The problem is only seen on SDIO interface since on USB, a bus reset would
really re-probe the driver, but on SDIO interface, a bus reset will not
re-enumerate the SDIO bus, so no driver re-probe is happening. Therefore,
on SDIO interface, the reset event should be still detected and handled by
dev_res... | ```diff
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c
index 3a6c8ddb5353..1674dba43f83 100644
--- a/drivers/net/wimax/i2400m/driver.c
+++ b/drivers/net/wimax/i2400m/driver.c
@@ -436,7 +436,8 @@ int i2400m_dev_start(struct i2400m *i2400m, enum i2400m_bri bm_flags)
result = __i2400... |
49d72df3f6cd63b49528306a2577ae7a6a0e9d6b | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: correct the error path handlers in dev_start() | Problem Details:
This fix is to correct order of the handlers in the error path
of dev_start(). When i2400m_firmware_check fails, all the works done
before it should be released or cleared.
Signed-off-by: Cindy H Kao <cindy.h.kao@intel.com> | ```diff
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c
index 94dc83c3969d..3a6c8ddb5353 100644
--- a/drivers/net/wimax/i2400m/driver.c
+++ b/drivers/net/wimax/i2400m/driver.c
@@ -403,10 +403,10 @@ retry:
error_dev_initialize:
error_check_mac_addr:
+error_fw_check:
i2400m->ready... |
f22cf689a6353f072bca15d0a26f870e62dfacf8 | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix the race condition for accessing TX queue | Problem Details:
The race condition happens when the TX queue is accessed by
the TX work while the same TX queue is being destroyed because
a bus reset is triggered either by debugfs entry or simply
by failing waking up the device from WiMAX IDLE mode.
This fix is to prevent the TX queue from being accessed by
multipl... | ```diff
diff --git a/drivers/net/wimax/i2400m/i2400m-sdio.h b/drivers/net/wimax/i2400m/i2400m-sdio.h
index b9c4bed3b457..360d4fb195f4 100644
--- a/drivers/net/wimax/i2400m/i2400m-sdio.h
+++ b/drivers/net/wimax/i2400m/i2400m-sdio.h
@@ -99,7 +99,10 @@ enum {
*
* @tx_workqueue: workqeueue used for data TX; we don't us... |
570eb0ea65db625e0b11ca97f4ae857bc1193250 | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix insufficient size of Tx buffer for 12 payload of 1400 MTU. | Problem Details:
This patch increases the Tx buffer size so as to accommodate 12 payloads
of 1408 (1400 MTU 16 bytes aligned). Currently Tx buffer is 32 KiB which
is insufficient to accommodate 12 payloads of 1408 size.
This patch
- increases I2400M_TX_BUF_SIZE from 32KiB to 64KiB
- Adds a BUILD_BUG_ON if the calcula... | ```diff
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c
index fab27e4a4cb3..8561c0766535 100644
--- a/drivers/net/wimax/i2400m/tx.c
+++ b/drivers/net/wimax/i2400m/tx.c
@@ -258,8 +258,10 @@ enum {
* Doc says maximum transaction is 16KiB. If we had 16KiB en
* route and 16KiB being queued,... |
4818d14de36228a749f714b450a85c1b35542e6f | Analyze and fix the following issue in the Linux kernel code: wimax/i2400m: fix incorrect return -ESHUTDOWN when there is no Tx buffer available | Problem Details:
i2400m_tx() routine was returning -ESHUTDOWN even when there was no Tx buffer
available. This patch fixes the i2400m_tx() to return -ESHUTDOWN only when
the device is down(i2400m->tx_buf is NULL) and also to return -ENOSPC
when there is no Tx buffer. Error seen in the kernel log.
kernel: i2400m_sdio mm... | ```diff
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c
index 6db909ecf1c9..fab27e4a4cb3 100644
--- a/drivers/net/wimax/i2400m/tx.c
+++ b/drivers/net/wimax/i2400m/tx.c
@@ -643,9 +643,11 @@ int i2400m_tx(struct i2400m *i2400m, const void *buf, size_t buf_len,
* current one is out of payload... |
3d69438031b00c601c991ab447cafb7d5c3c59a6 | Analyze and fix the following issue in the Linux kernel code: cifs: guard against hardlinking directories | Problem Details:
When we made serverino the default, we trusted that the field sent by the
server in the "uniqueid" field was actually unique. It turns out that it
isn't reliably so.
Samba, in particular, will just put the st_ino in the uniqueid field when
unix extensions are enabled. When a share spans multiple files... | ```diff
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index ecf0ffbe2b64..0c2fd17439c8 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -502,6 +502,7 @@ struct dfs_info3_param {
#define CIFS_FATTR_DFS_REFERRAL 0x1
#define CIFS_FATTR_DELETE_PENDING 0x2
#define CIFS_FATTR_NEED_REVAL 0x4
+#define CI... |
f9ab70e787c3b94ce7c56324b4afbc8051e99424 | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: Fix whitespace problems criticized by checkpatch.pl | Problem Details:
Trailing spaces at the end of a line or before a tab are against
Documentation/CodingStyle "3.1: Spaces" and should be avoided. It is
also common style to add a single space after commas unless it is
followed either by a newline or a tab.
Reported-by: Mikal Sande <mikal.sande@gmail.com>
Reported-by: L... | ```diff
diff --git a/drivers/staging/batman-adv/main.h b/drivers/staging/batman-adv/main.h
index 6749ce036b91..8818e2b80938 100644
--- a/drivers/staging/batman-adv/main.h
+++ b/drivers/staging/batman-adv/main.h
@@ -70,7 +70,7 @@
#define MODULE_DEACTIVATING 2
#define BCAST_QUEUE_LEN 256
-#define BATMAN_QUEUE_LE 256
... |
f94cee241099b31732460c255c6af24979ec778e | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: Reorganize sequence number handling | Problem Details:
BATMAN and broadcast packets are tracked with a sequence number window of
currently 64 entries to measure and avoid duplicates. Packets which have a
sequence number smaller than the newest received packet minus 64 are not
within this sequence number window anymore and are called "old packets"
from now ... | ```diff
diff --git a/drivers/staging/batman-adv/bitarray.c b/drivers/staging/batman-adv/bitarray.c
index 7848305bd14b..2fef6e35f8c3 100644
--- a/drivers/staging/batman-adv/bitarray.c
+++ b/drivers/staging/batman-adv/bitarray.c
@@ -68,7 +68,7 @@ void bit_shift(TYPE_OF_WORD *seq_bits, int32_t n)
int32_t word_offset, wo... |
b7bce588b3a6a058e00d9629c25cf170dede63fc | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: fix whitespace style issues | Problem Details:
This patch fixes unnecessary whitespaces before a quoted
newline that the remaining batman-adv files had.
Reported-by: Luis de Bethencourt <luisbg@ubuntu.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@... | ```diff
diff --git a/drivers/staging/batman-adv/bat_sysfs.c b/drivers/staging/batman-adv/bat_sysfs.c
index 1811c8da6609..e2c000b80ca0 100644
--- a/drivers/staging/batman-adv/bat_sysfs.c
+++ b/drivers/staging/batman-adv/bat_sysfs.c
@@ -75,7 +75,7 @@ static ssize_t show_aggr_ogm(struct kobject *kobj, struct attribute *at... |
0887635b26e0cb6369c0438e55d9323d3aef3f69 | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: fix whitespace style issues | Problem Details:
This patch fixes the 31 unnecessary whitespaces before a quoted
newline that the batman-adv files had.
Signed-off-by: Luis de Bethencourt <luisbg@ubuntu.com>
[sven.eckelmann@gmx.de: Redone to apply against current version]
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lind... | ```diff
diff --git a/drivers/staging/batman-adv/device.c b/drivers/staging/batman-adv/device.c
index fbfe234104d2..9887f05925e1 100644
--- a/drivers/staging/batman-adv/device.c
+++ b/drivers/staging/batman-adv/device.c
@@ -65,7 +65,7 @@ int bat_device_setup(void)
batman_class = class_create(THIS_MODULE, "batman-adv")... |
bdc0c7ebf770e21d024c2e94c3d578392b59c5b1 | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: Fix aggregation direct-link bug | Problem Details:
So far, neighbour's secondary interface OGMs can involuntarily
piggyback on primary interface OGMs that arrived on the same secondary
interface before. Secondary interface OGMs should NEVER leave their
direct neighbour broadcast domain! This patch ensures that secondary
interface OGMs can only be aggre... | ```diff
diff --git a/drivers/staging/batman-adv/aggregation.c b/drivers/staging/batman-adv/aggregation.c
index d25e5a89dac3..e1bd32185439 100644
--- a/drivers/staging/batman-adv/aggregation.c
+++ b/drivers/staging/batman-adv/aggregation.c
@@ -81,9 +81,15 @@ static bool can_aggregate_with(struct batman_packet *new_batma... |
bd13b616aa9d082dce760759b7473da5ed399452 | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: fix aggregation timing bug | Problem Details:
batman-adv aggregates routing packets to reduce the number of packets in
the air. Every outgoing packet is compared with other packets in the
buffer to determine whether it can be aggregated or not. Packets sent
at a lower interval can be held back longer to maximize the aggregation.
Due to insufficien... | ```diff
diff --git a/drivers/staging/batman-adv/aggregation.c b/drivers/staging/batman-adv/aggregation.c
index 7917322a7e2a..d25e5a89dac3 100644
--- a/drivers/staging/batman-adv/aggregation.c
+++ b/drivers/staging/batman-adv/aggregation.c
@@ -52,6 +52,8 @@ static bool can_aggregate_with(struct batman_packet *new_batman... |
adaaa0c6ab89e82684389b80002bce893179cf2c | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: only modify hna-table on active module | Problem Details:
If we haven't set the module to MODULE_ACTIVE state before (in general,
no interface has yet been added to batman-adv) then the hna table is not
initialised yet. If the kernel changes the mac address of the bat0
interface at this moment then an hna_local_add() called by interface_set_mac_addr()
then re... | ```diff
diff --git a/drivers/staging/batman-adv/soft-interface.c b/drivers/staging/batman-adv/soft-interface.c
index 0e2307f3cb96..a42b21f40192 100644
--- a/drivers/staging/batman-adv/soft-interface.c
+++ b/drivers/staging/batman-adv/soft-interface.c
@@ -152,9 +152,13 @@ int interface_set_mac_addr(struct net_device *de... |
89485d4931769d40353ea49bff1596accff8f06e | Analyze and fix the following issue in the Linux kernel code: ALSA: include/sound/asound.h whitespace fixups | Problem Details:
This fixes some whitespace/indentation flaws I stumbled over.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/include/sound/asound.h b/include/sound/asound.h
index 098595500632..9f1eecf99e6b 100644
--- a/include/sound/asound.h
+++ b/include/sound/asound.h
@@ -574,7 +574,7 @@ enum {
#define SNDRV_TIMER_FLG_SLAVE (1<<0) /* cannot be controlled */
struct snd_timer_id {
- int dev_class;
+ int dev_class;
... |
083e3e8d3dfeb191f349081c052ad3d20e8861f3 | Analyze and fix the following issue in the Linux kernel code: ath9k: Fix bug in handling rx frames with invalid descriptor content | Problem Details:
Don't send them for further processing.
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index ac60c4ee62d3..da54ff5f3d7e 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -718,6 +718,7 @@ static bool ath_edma_get_buffers(struct ath_softc *sc,
__skb_unlink(sk... |
8607b79c794a706e6df79d44da261887c5f5def2 | Analyze and fix the following issue in the Linux kernel code: wl1271: fix notifier interface supported test | Problem Details:
The "(wl == NULL)" test doesn't work here because "wl" is always
non-null. The intent of the code is to return if the interface
was not supported by the driver.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linvil... | ```diff
diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
index b61cd102752f..55aa813c82c7 100644
--- a/drivers/net/wireless/wl12xx/wl1271_main.c
+++ b/drivers/net/wireless/wl12xx/wl1271_main.c
@@ -852,7 +852,7 @@ static int wl1271_dev_notify(struct notifier_block *me, u... |
89713422a768458a0d375f0c2f3586cd5ccde6a1 | Analyze and fix the following issue in the Linux kernel code: PCI: aerdrv: introduce default_downstream_reset_link | Problem Details:
I noticed that when I inject a fatal error to an endpoint via
aer-inject, aer_root_reset() is called as reset_link for a
downstream port at upstream of the endpoint:
pcieport 0000:00:06.0: AER: Uncorrected (Fatal) error received: id=5401
:
pcieport 0000:52:02.0: Root Port link has been reset
I... | ```diff
diff --git a/Documentation/PCI/pcieaer-howto.txt b/Documentation/PCI/pcieaer-howto.txt
index 8c406a496799..26d3d945c3c2 100644
--- a/Documentation/PCI/pcieaer-howto.txt
+++ b/Documentation/PCI/pcieaer-howto.txt
@@ -13,7 +13,7 @@ Reporting (AER) driver and provides information on how to use it, as
well as how t... |
17e21854bd59862f4ee47d1c7e828549f782711b | Analyze and fix the following issue in the Linux kernel code: PCI: aerdrv: rework do_recovery | Problem Details:
Move dev_printks for debug into do_recovery().
This allows do_recovery() to return void.
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> | ```diff
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
index 210e53c2fdc1..9dcd3aeeafb6 100644
--- a/drivers/pci/pcie/aer/aerdrv_core.c
+++ b/drivers/pci/pcie/aer/aerdrv_core.c
@@ -465,8 +465,7 @@ static pci_ers_result_t reset_link(struct pcie_device *aerdev,
* error detected mes... |
98ca3964fe8da0d742331af80952443af5cff464 | Analyze and fix the following issue in the Linux kernel code: PCI: aerdrv: rework find_source_device | Problem Details:
Return bool to indicate that the source device is found or not.
This allows us to skip calling aer_process_err_devices() if we can.
And move dev_printk for debug into this function.
v2: return bool instead of int
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Reviewed-by: Kenji Kanesh... | ```diff
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
index ad15eea54fd0..5fa5c76719b0 100644
--- a/drivers/pci/pcie/aer/aerdrv_core.c
+++ b/drivers/pci/pcie/aer/aerdrv_core.c
@@ -215,11 +215,13 @@ added:
/**
* find_source_device - search through device hierarchy for source dev... |
e012b4c41987c40cc2dd82ab48e0569f1d7aa970 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fixed long line lengths in comedi.h | Problem Details:
This patches fixes some of the long line lengths that checkpatch.pl was
complaining about in comedi.h
Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 8e4caaacfc1c..20a6fee4dae6 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -46,8 +46,10 @@
#define COMEDI_DEVCONF_AUX_DATA2_LENGTH 26
#define COMEDI_DEVCONF_AUX_DATA1_LENGTH 27
#define... |
5e220112c8c8e59c253f6ad473687444b3ca90bf | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fixed long line length in comedidev.h | Problem Details:
This patch fixes a long line length in comedidev.h to make checkpatch.pl happy
Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index c38ebb4aa75f..4eb2b77f56dc 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -374,7 +374,9 @@ enum subdevice_runflags {
SRF_RUNNING = 0x08000000
};
-int comedi_check_chanlist... |
67b0e64a7b219550cc3378800f680e2bb86a10f9 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fixed printk call lengths and log levels | Problem Details:
This is a patch to include log levels and fix some over length lines in
printk calls in drivers.c
Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 1f48b6dca08b..4a29ed737e3f 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -95,7 +95,8 @@ static void __comedi_device_detach(struct comedi_device *dev)
if (dev->driver)
dev->driver... |
97b9e5ae4039ab32ea5fcef999f6e54ca4af5c94 | Analyze and fix the following issue in the Linux kernel code: Staging: crystalhd: fix missing semicolon | Problem Details:
A semicolon is missing at the end of a statement, but it does compile
fine without it as the macro BCMLOG_ERR expands to a do {...} while (0);
Signed-off-by: Charles Clément <caratorn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
index d826715809df..1a7ca8ba7f85 100644
--- a/drivers/staging/crystalhd/crystalhd_cmds.c
+++ b/drivers/staging/crystalhd/crystalhd_cmds.c
@@ -309,7 +309,7 @@ static BC_STATUS bc_cproc_download_fw(struct crystalh... |
25e2831dc459a45424f1dbdce7556d3ab5bc012d | Analyze and fix the following issue in the Linux kernel code: Staging: hv: util.h: fix up space mess again | Problem Details:
Again, use tabs, not spaces, it's not difficult to remember...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/utils.h b/drivers/staging/hv/utils.h
index ecbeab69a23f..a4b9fd06e270 100644
--- a/drivers/staging/hv/utils.h
+++ b/drivers/staging/hv/utils.h
@@ -77,26 +77,26 @@ struct shutdown_msg_data {
/* Time Sync IC defs */
-#define ICTIMESYNCFLAG_PROBE 0
-#define ICTIMESYNCFLAG_SYNC ... |
e61fbe66cbe10fed6bcc2d07ac802a7386b93673 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: Channel.c: fix up compiler warning | Problem Details:
In the series of ASSERT removals, somehow we ended up with a compiler
warning in Channel.c. This patch fixes that up.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Channel.c b/drivers/staging/hv/Channel.c
index 158f62d8553a..eab7d16dd5ef 100644
--- a/drivers/staging/hv/Channel.c
+++ b/drivers/staging/hv/Channel.c
@@ -376,7 +376,7 @@ static int VmbusChannelCreateGpadlHeader(void *Kbuffer, u32 Size,
struct vmbus_channel_gpadl_header *gpaHea... |
2342df0e63f4ca9a4227ea06f951f09180497914 | Analyze and fix the following issue in the Linux kernel code: Staging: dt3155v4l: fix some sparse warnings | Problem Details:
Mostly some __iomem markings and some static functions as well.
Cc: Marin Mitov <mitov@issp.bas.bg
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dt3155v4l/dt3155v4l.c b/drivers/staging/dt3155v4l/dt3155v4l.c
index d596e9d49222..881c3e99bd47 100644
--- a/drivers/staging/dt3155v4l/dt3155v4l.c
+++ b/drivers/staging/dt3155v4l/dt3155v4l.c
@@ -65,7 +65,7 @@ static u8 config_init = ACQ_MODE_EVEN;
* in a byte pointed by data.
*/
... |
6e1b4e24e6e4025b399159f3605bfa958464272a | Analyze and fix the following issue in the Linux kernel code: Staging: vt6656: code cleanup, resolved sparse finding | Problem Details:
Cleared sparse warning 'Using plain integer as NULL pointer'
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/vt6656/wmgr.c b/drivers/staging/vt6656/wmgr.c
index 1824551bcc3c..5af98e9a8f03 100644
--- a/drivers/staging/vt6656/wmgr.c
+++ b/drivers/staging/vt6656/wmgr.c
@@ -958,12 +958,12 @@ s_vMgrRxAssocResponse(
sFrame.pBuf = (PBYTE)pRxPacket->p80211Header;
// decode the fr... |
d16e1834af457fdce62714e5207c259400e274f4 | Analyze and fix the following issue in the Linux kernel code: Staging: arlan: fixed unnecessary whitespace style issue in arlan-main.c | Problem Details:
This is a patch to the arlan-main.c file that fixes the unnecessary whitespace
issues found by the checkpatch.pl tool.
Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/arlan/arlan-main.c b/drivers/staging/arlan/arlan-main.c
index 58deb96e1a37..301b979d0437 100644
--- a/drivers/staging/arlan/arlan-main.c
+++ b/drivers/staging/arlan/arlan-main.c
@@ -76,18 +76,18 @@ MODULE_PARM_DESC(entry_and_exit_debug, "Arlan driver function entry and exit deb
str... |
40447df803971a8663a7d5f96c8a19160dfd1776 | Analyze and fix the following issue in the Linux kernel code: Staging: cxt1e1: fix up one remaining THIS_MODULE usage | Problem Details:
Copied from original Patch by Randy Dunlap
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 8d4e8d28af59..4c8610293fcc 100644
--- a/drivers/staging/cxt1e1/hwprobe.c
+++ b/drivers/staging/cxt1e1/hwprobe.c
@@ -283,7 +283,7 @@ c4_hdw_init (struct pci_dev * pdev, int found)
*/
char *cp = hi->dev... |
318a5b2a505fe7a99f0d89889e7a84d57ec49b15 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: cb_pcidas64: fix up build warnings | Problem Details:
Now that the 8255.h file is being included properly, we were
using the incorrect function prototypes, which causes a build
warning now. This fixes it up and preserves the __iomem markings that
sparse wants to see.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
S... | ```diff
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 3443fc1b9186..79aa286e9bb4 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1183,8 +1183,8 @@ static int ao_cmdtest(struct comedi_device ... |
c5efe58b83bc5c1d5811800faf03b1089d1ef054 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: 8255: fix up previous static markings. | Problem Details:
Ian pointed out that exported symbols should not be marked as static :)
Fixed this up by properly including the 8255.h file, and fixing
the function prototypes there, as the CONFIG variables were not getting
set so users of the header file were seeing the incorrect function
prototypes.
Cc: Ian Abbott... | ```diff
diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
index e777ddfc8af0..b2e80dd5c266 100644
--- a/drivers/staging/comedi/drivers/8255.c
+++ b/drivers/staging/comedi/drivers/8255.c
@@ -82,6 +82,7 @@ I/O port base address can be found in the output of 'lspci -v'.
#include... |
1e18c0d5b41ff2b482f1b5178da4f69d3223261c | Analyze and fix the following issue in the Linux kernel code: Staging: line6: driver: fix up sparse warnings | Problem Details:
minor stuff.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index 258555417bc7..1d5a47302763 100644
--- a/drivers/staging/line6/driver.c
+++ b/drivers/staging/line6/driver.c
@@ -399,7 +399,7 @@ static void line6_data_received(struct urb *urb)
static int line6_send(struct usb_line6 *line6, unsi... |
74112d3f3a64afb98179169cf8af691ccc63434d | Analyze and fix the following issue in the Linux kernel code: Staging: iio: industrialio-trigger.c: minor fixups | Problem Details:
We needed to include a header file that declared the functions that are
being exported in this file.
Also fix up an indentation problem, and some sparse warnings.
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/industrialio-trigger.c b/drivers/staging/iio/industrialio-trigger.c
index 46bd94ab7d91..5682e61600f6 100644
--- a/drivers/staging/iio/industrialio-trigger.c
+++ b/drivers/staging/iio/industrialio-trigger.c
@@ -18,6 +18,7 @@
#include "iio.h"
#include "trigger.h"
+#include "tr... |
19ca92e0bca3499a12eb9b612b90bbe90d2cc895 | Analyze and fix the following issue in the Linux kernel code: Staging: iio: ring_sw.c: fix up sparse warnings | Problem Details:
NULL usage, static stuff, etc.
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c
index 5ee3e4533515..1f14cd4770e7 100644
--- a/drivers/staging/iio/ring_sw.c
+++ b/drivers/staging/iio/ring_sw.c
@@ -21,10 +21,10 @@ static inline int __iio_allocate_sw_ring_buffer(struct iio_sw_ring_buffer *ring,
return -EINVAL;
__i... |
0deebb4fc4784699afec04231f981aaad3126ff9 | Analyze and fix the following issue in the Linux kernel code: Staging: iio: industrialio-ring.c: fix up sparse warnings | Problem Details:
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/industrialio-ring.c b/drivers/staging/iio/industrialio-ring.c
index fc27d22a7ab1..ada159bbb1f7 100644
--- a/drivers/staging/iio/industrialio-ring.c
+++ b/drivers/staging/iio/industrialio-ring.c
@@ -58,7 +58,7 @@ EXPORT_SYMBOL(iio_push_or_escallate_ring_event);
* This function ... |
7cfce527a2cec1a2757136eb44d8dfa473a82d37 | Analyze and fix the following issue in the Linux kernel code: Staging: iio: accel: fix up some sparse warnings. | Problem Details:
Minor stuff (static, NULL, etc.)
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/accel/lis3l02dq_ring.c b/drivers/staging/iio/accel/lis3l02dq_ring.c
index 9214d847fa33..78d8572e6323 100644
--- a/drivers/staging/iio/accel/lis3l02dq_ring.c
+++ b/drivers/staging/iio/accel/lis3l02dq_ring.c
@@ -207,7 +207,7 @@ static const u8 read_all_tx_array[] = {
* @rx_array... |
d1d8abdb05bddce645649c17949b0bc62e6f096b | Analyze and fix the following issue in the Linux kernel code: Staging: iio: trigger: fix up some global variables | Problem Details:
These should be static.
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/trigger/iio-trig-gpio.c b/drivers/staging/iio/trigger/iio-trig-gpio.c
index e40099ff6230..1da285d28632 100644
--- a/drivers/staging/iio/trigger/iio-trig-gpio.c
+++ b/drivers/staging/iio/trigger/iio-trig-gpio.c
@@ -25,8 +25,8 @@
#include "../iio.h"
#include "../trigger.h"
-LI... |
341713f265950884d2edbbf55088127a915927ad | Analyze and fix the following issue in the Linux kernel code: Staging: iio: light: tsl2563: fix static sparse warning | Problem Details:
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index f8a08365f19d..e4b0a5ef1c1f 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -607,7 +607,7 @@ static ssize_t tsl2563_show_name(struct device *dev,
return sprintf(buf, "%s\n"... |
acbbfe236eb6fa25fdfb2a8762d0ad260f6b667c | Analyze and fix the following issue in the Linux kernel code: Staging: iio: adc: max1363_ring.c: fix up sparse warnings | Problem Details:
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/adc/max1363_ring.c b/drivers/staging/iio/adc/max1363_ring.c
index 85fde751a154..c8aa01109ec2 100644
--- a/drivers/staging/iio/adc/max1363_ring.c
+++ b/drivers/staging/iio/adc/max1363_ring.c
@@ -142,7 +142,7 @@ static int max1363_ring_predisable(struct iio_dev *indio_dev)
* the... |
f03de82b3f10b2e8b7f75f3d4323ec38d131a99c | Analyze and fix the following issue in the Linux kernel code: Staging: iio: max1363_core: fix bug in kzalloc call | Problem Details:
The operands were switched around :(
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
index 4a77657285da..905f8560d31f 100644
--- a/drivers/staging/iio/adc/max1363_core.c
+++ b/drivers/staging/iio/adc/max1363_core.c
@@ -958,9 +958,8 @@ static int __devinit max1363_probe(struct i2c_client *client,
}
... |
1b183e4b93c4e05160d2c8f08b9546dd4752084b | Analyze and fix the following issue in the Linux kernel code: Staging: iio: adc: max1363_core: fix up some sparse warnings | Problem Details:
Also fix a minor coding style issue.
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
index fa91cc14c64f..4a77657285da 100644
--- a/drivers/staging/iio/adc/max1363_core.c
+++ b/drivers/staging/iio/adc/max1363_core.c
@@ -139,16 +139,15 @@ static const struct max1363_mode max1363_mode_table[] = {
};
co... |
cb6405b15f7b2814f8f5170482b2e13ccfcb6376 | Analyze and fix the following issue in the Linux kernel code: Staging: iio: light trivial whitespace fix | Problem Details:
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index da3d51c52c7c..f8a08365f19d 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -646,7 +646,7 @@ static int __devinit tsl2563_probe(struct i2c_client *client,
err = tsl2563_d... |
26de7208281fd21606201ab3314f60e517d6c56f | Analyze and fix the following issue in the Linux kernel code: Staging: iio: accelerometers trivial checkpatch related fixes | Problem Details:
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/accel/lis3l02dq_ring.c b/drivers/staging/iio/accel/lis3l02dq_ring.c
index 7617da81871c..9214d847fa33 100644
--- a/drivers/staging/iio/accel/lis3l02dq_ring.c
+++ b/drivers/staging/iio/accel/lis3l02dq_ring.c
@@ -192,8 +192,7 @@ error_ret:
}
-static const u8 read_all_tx_array[... |
4e4b592cb51342878166a2ea2bcf6151f0a3a29d | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: hwdrv_apci3xxx.c: loads of sparse cleanups | Problem Details:
__iomem pointer fixes, and static cleanups.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3xxx.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3xxx.c
index 3692326d474a..2e20bc7cdcdb 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3xxx.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3xxx.c
@@ -67,10 +67... |
882980133d0d94ad060a727f17362e27b9fec263 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: hwdrv_apci2032.c: static sparse fix | Problem Details:
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci2032.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci2032.c
index 2d325163c169..d7d22236778d 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci2032.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci2032.c
@@ -53,7 +53,... |
1a538dfd16a4aa3a57a4c792c928fe83b05aacf0 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: hwdrv_apci035.h: fix sparse warnings | Problem Details:
This let us delete two variables and mark one as static.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.h b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.h
index e0023c8cb628..68db9c10c99e 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.h
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.h
@@ -19,22 +19,8 @... |
08b93e7bda617a623ffae77940e4acfa31204367 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: hwdrv_apci035.c: fix sparse warnings | Problem Details:
Some variables should be static.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
index 791297266fc0..1369e22b7ee6 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
@@ -52,9 +52,9 @@... |
525d1b1395858606103d4663a570cc8725ff2ced | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: adl_pci9111.c: fix sparse warnings | Problem Details:
divisor and other problems fixed.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c b/drivers/staging/comedi/drivers/adl_pci9111.c
index bbe0e332dae8..36a254cd4413 100644
--- a/drivers/staging/comedi/drivers/adl_pci9111.c
+++ b/drivers/staging/comedi/drivers/adl_pci9111.c
@@ -358,8 +358,8 @@ struct pci9111_private_data {
int ao_read... |
5f35f3f19fd12226482f8b57c70d9a0f82470c87 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: adl_pci9118.c: fix unsigned problem with divisors | Problem Details:
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
index dc4bd0423e6f..ccef549778e4 100644
--- a/drivers/staging/comedi/drivers/adl_pci9118.c
+++ b/drivers/staging/comedi/drivers/adl_pci9118.c
@@ -921,7 +921,8 @@ static int pci9118_ai_cmdtest(struct comedi_d... |
a8cb9ad9ad872dc600314c1c8d07c420b3cdefbb | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: adv_pci1710.c: fix unsigned problem with divisors | Problem Details:
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
index 5c1ff779af2c..67c4f11a36ab 100644
--- a/drivers/staging/comedi/drivers/adv_pci1710.c
+++ b/drivers/staging/comedi/drivers/adv_pci1710.c
@@ -937,7 +937,8 @@ static int pci171x_ai_cmdtest(struct comedi_d... |
a7f22a84ba2e5a99b874bf36a772b5d7424cec11 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: amplc_dio200.c: fix NULL sparse warnings | Problem Details:
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/amplc_dio200.c b/drivers/staging/comedi/drivers/amplc_dio200.c
index 6a87652e7e2a..8eb67651486a 100644
--- a/drivers/staging/comedi/drivers/amplc_dio200.c
+++ b/drivers/staging/comedi/drivers/amplc_dio200.c
@@ -661,7 +661,7 @@ dio200_inttrig_start_intr(struct comedi_d... |
f31d0008cef0df52d1a2662ef56a24bdd88b0105 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: cb_pcidas64.c: fix sparse warnings | Problem Details:
This fixes a bunch of iomem and other sparse warnings.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 0d9e92e59f9d..3443fc1b9186 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1101,9 +1101,9 @@ struct pcidas64_private {
resource_size_t... |
d18c5906d0914d911a13d342ff61a6bca6aff597 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: das1800.c: fix a locking error on the error path. | Problem Details:
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index d91c2d9d595b..de5e82fec878 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -1637,7 +1637,8 @@ static int das1800_ai_rinsn(struct comedi_device *dev,
}... |
e3752a1dfd8a003139dee2c80de3d915534e2b39 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: quatech_daqp_cs.c: fix up the irq | Problem Details:
The irq needs to return the correct type. Also fix up some other
sparse warnings that were found.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 3325f24448b5..fb427dbe98f5 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -244,8 +244,7 @@ static int daqp_ai_cancel(str... |
2f78c64255bc6e960bf822f65bd80830f053e182 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: addi_common.c: sparse cleanups | Problem Details:
Now that we are properly marking the variable as __iomem, don't
cast it.
Also fix up some other sparse warnings.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/addi-data/addi_common.c b/drivers/staging/comedi/drivers/addi-data/addi_common.c
index 6625fdc8e903..2c986413a81a 100644
--- a/drivers/staging/comedi/drivers/addi-data/addi_common.c
+++ b/drivers/staging/comedi/drivers/addi-data/addi_common.c
@@ -293,8 +293,8 @@ stati... |
6610944a91079a4002da310d3d5488feaae4a74a | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix up sparse warning in hyperv_utils.c | Problem Details:
The function isn't called by anyone else, so mark it static.
Also remove version.h, as it is not needed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/hyperv_utils.c b/drivers/staging/hv/hyperv_utils.c
index ca52fbada7d1..cbebad3e40a0 100644
--- a/drivers/staging/hv/hyperv_utils.c
+++ b/drivers/staging/hv/hyperv_utils.c
@@ -24,7 +24,6 @@
#include <linux/slab.h>
#include <linux/sysctl.h>
#include <linux/reboot.h>
-#include <l... |
8474ddd7cba04c2e8d8691abda32ae0f4a684137 | Analyze and fix the following issue in the Linux kernel code: staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop | Problem Details:
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c
index f8de45dc4b6e..5ee3e4533515 100644
--- a/drivers/staging/iio/ring_sw.c
+++ b/drivers/staging/iio/ring_sw.c
@@ -295,7 +295,7 @@ again:
return -EAGAIN;
memcpy(data, last_written_p_copy, ring->buf.bpd);
- if (unlikely(ring->last... |
b3413092cc86d6c1b5b1408c3bb37998a82a588a | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix up formatting issues in utils.h | Problem Details:
-------- cut here and print out and paste on wall --------
Tabs, not spaces
-------- cut here and print out and paste on wall --------
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/utils.h b/drivers/staging/hv/utils.h
index 4e09804e5b9e..0f2507dcc892 100644
--- a/drivers/staging/hv/utils.h
+++ b/drivers/staging/hv/utils.h
@@ -18,54 +18,54 @@
* Haiyang Zhang <haiyangz@microsoft.com>
* Hank Janssen <hjanssen@microsoft.com>
*/
-#ifndef _UTILS_H_
-#d... |
7029a87455af3cf303e8d6d0db8c26b6a94f1020 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: drivers.c sparse cleanup | Problem Details:
Fix up some sparse issues in drivers.c
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index c26c6446a0ee..c38ebb4aa75f 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -351,9 +351,6 @@ void cleanup_polling(void);
void start_polling(struct comedi_device *);
void stop_p... |
472dfe77b91d8026c3ccda22c60db0e92bc27863 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: kcomedilib: make it typesafe | Problem Details:
If we really are passing in a struct comedi_device, then say we are,
don't mess around with void pointers for no reason.
This also fixes up the comedi_bond.c driver, which is the only
user of the kcomedilib code.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Si... | ```diff
diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
index 23ec58d2e239..ca92c43fdb38 100644
--- a/drivers/staging/comedi/comedilib.h
+++ b/drivers/staging/comedi/comedilib.h
@@ -24,13 +24,14 @@
#ifndef _LINUX_COMEDILIB_H
#define _LINUX_COMEDILIB_H
-void *comedi_open(const ch... |
e6e4d05d4d440f1989f696baa146263957593345 | Analyze and fix the following issue in the Linux kernel code: Staging: cxt1e1: fix cxt1e1 module names | Problem Details:
On Mon, 2010-05-03 at 10:09 -0700, Randy Dunlap wrote:
> Lots of cxt1e1 source code uses THIS_MODULE->name, which won't build
> when CONFIG_MODULES is not enabled, so use KBUILD_MODNAME instead.
Perhaps a conversion to pr_<level> is better?
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Randy... | ```diff
diff --git a/drivers/staging/cxt1e1/functions.c b/drivers/staging/cxt1e1/functions.c
index c95c62dfb04b..738129d62bbf 100644
--- a/drivers/staging/cxt1e1/functions.c
+++ b/drivers/staging/cxt1e1/functions.c
@@ -11,6 +11,8 @@
* GNU General Public License for more details.
*/
+#define pr_fmt(fmt) KBUILD_M... |
3b9fdcd5e85104e622c0ec5f626c81b831ddfae2 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fix all checkpatch.pl issues in dt2811.c | Problem Details:
Patch resolves all checkpatch.pl isues in dt2811.c
Signed-off-by: Iain Churcher <iain.linux.coding@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
index 51ef695698a3..ea9bfb7fd88e 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -34,13 +34,13 @@ Configuration options:
[0] - I/O port base address
[1] - IR... |
aad4029a49e17d8529b8b802d4ecd774ef941f7c | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Adjusted some long line lengths in drivers.c | Problem Details:
This patch fixes some long line lengths in drivers.c that checkpatch.pl was
complaining about
Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index d7a450917405..a8f3d790b3d5 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -172,7 +172,8 @@ attached:
}
if (!dev->board_name) {
- printk(KERN_WARNING "BUG: dev->board_name=<%p>\n... |
b8c623e5dde98a00ada4af47bec92a708794c573 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fix Checkpatch.pl issues in mpc624.c | Problem Details:
This patch resolves all checkpatch.pl issues in the mpc624.c file
Signed-off-by: Iain Churcher <iain.linux.coding@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/mpc624.c b/drivers/staging/comedi/drivers/mpc624.c
index 12e72c828157..9874ac3749c3 100644
--- a/drivers/staging/comedi/drivers/mpc624.c
+++ b/drivers/staging/comedi/drivers/mpc624.c
@@ -40,20 +40,20 @@ Status: working
Configuration Options:
[0] - I/O base address... |
4212c686381a0ab62601ea7a272e7ff4c2ea4cb7 | Analyze and fix the following issue in the Linux kernel code: Staging: adis16255: Fix compile error | Problem Details:
This patch solves a compilation error in today linux-next tree.
The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/adis16255/Makefile b/drivers/staging/adis16255/Makefile
index 3f8b1f06b194..8057372d3781 100644
--- a/drivers/staging/adis16255/Makefile
+++ b/drivers/staging/adis16255/Makefile
@@ -1 +1 @@
-obj-$(CONFIG_ADIS16255) +dis16255.o
+obj-$(CONFIG_ADIS16255) += adis1625.o
``` |
ea4ceb18b525fd7016c10995c0f1313a729c7e2b | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: Fixing wrap-around bug in vis | Problem Details:
When the seqno for a vis packet had a wrap around from i.e. 255 to 0,
add_packet() would falsely claim the older packet with the seqno 255 as
newer as the one with the seqno of 0 and would therefore ignore the new
packet. This happens with all following vis packets until the old vis
packet expires afte... | ```diff
diff --git a/drivers/staging/batman-adv/vis.c b/drivers/staging/batman-adv/vis.c
index 222db0189a6d..28eac7e05235 100644
--- a/drivers/staging/batman-adv/vis.c
+++ b/drivers/staging/batman-adv/vis.c
@@ -27,6 +27,22 @@
#include "hard-interface.h"
#include "hash.h"
+/* Returns the smallest signed integer in t... |
f6497e38fda6970819daacb67725d67474079381 | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: Fix VIS output bug for secondary interfaces | Problem Details:
TQ and HNA records for originators on secondary interfaces were
wrongly being included on the primary interface. Ensure we output a
line for each source interface on every node, so we correctly separate
primary and secondary interface records.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signe... | ```diff
diff --git a/drivers/staging/batman-adv/proc.c b/drivers/staging/batman-adv/proc.c
index 7de60e84bc96..c9366bcbb360 100644
--- a/drivers/staging/batman-adv/proc.c
+++ b/drivers/staging/batman-adv/proc.c
@@ -41,7 +41,7 @@ static int proc_interfaces_read(struct seq_file *seq, void *offset)
rcu_read_lock();
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.