id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
107c32fe68f0b64acb7edd31d44d79b87c7fa8b4 | Analyze and fix the following issue in the Linux kernel code: Staging: batman-adv: don't have interrupts disabled while sending. | Problem Details:
send_vis_packets() would disable interrupts before calling
dev_queue_xmit() which resulting in a backtrace in local_bh_enable().
Fix this by using kref on the vis_info object so that we can call
send_vis_packets() without holding vis_hash_lock. vis_hash_lock also
used to protect recv_list, so we now ne... | ```diff
diff --git a/drivers/staging/batman-adv/vis.c b/drivers/staging/batman-adv/vis.c
index fedec1bb3097..0b5c63fbb401 100644
--- a/drivers/staging/batman-adv/vis.c
+++ b/drivers/staging/batman-adv/vis.c
@@ -29,22 +29,26 @@
struct hashtable_t *vis_hash;
DEFINE_SPINLOCK(vis_hash_lock);
+static DEFINE_SPINLOCK(rec... |
dc1da7f7bae9e71e56f365d7e987760c88c116bd | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix up remaining coding style issue in proc.c | Problem Details:
Move the external variable into a .h file, where it belongs.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi_fops.h b/drivers/staging/comedi/comedi_fops.h
index cb503c88c7f4..da4b4f5553f5 100644
--- a/drivers/staging/comedi/comedi_fops.h
+++ b/drivers/staging/comedi/comedi_fops.h
@@ -5,5 +5,6 @@
extern struct class *comedi_class;
extern const struct file_operations comedi_f... |
8e81f184d9fc3c607a2f0b236d765eb348fbd845 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix up coding issues in proc.c | Problem Details:
Fixes all but one.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c
index 5a22fe62c400..2b41faf37c60 100644
--- a/drivers/staging/comedi/proc.c
+++ b/drivers/staging/comedi/proc.c
@@ -33,9 +33,6 @@
#include <linux/proc_fs.h>
/* #include <linux/string.h> */
-int comedi_read_procmem(char *buf, char **s... |
ecfe20db3e0e2ff9df4007c4f1d34b27a24265fd | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix up coding style issues in range.c | Problem Details:
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 188c47948033..c35ade94a12d 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -22,7 +22,7 @@
*/
#include "comedidev.h"
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
const struct com... |
baf22b64aa7eb2d32c4ff49262b8d26c18bb232a | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix coding style issues in comedidev.h | Problem Details:
This resolves some coding style issues in comedidev.h
And yes, volatile here meant nothing, removing it is ok.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index ebdccfdf220e..4e1955b1bf2c 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -57,7 +57,7 @@
static int __init x ## _init_module(void) \
{return comedi_driver_register(&(x))... |
981bdf41ea7bbeece1f08045e0456c725a4d8f2f | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix up coding style issues in comedilib.h | Problem Details:
This resolves some issues with comedilib.h
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
index 3918d53b3040..27dd3bec88af 100644
--- a/drivers/staging/comedi/comedilib.h
+++ b/drivers/staging/comedi/comedilib.h
@@ -164,10 +164,10 @@ int comedi_get_subdevice_type(unsigned int minor, unsigned int subdevice);
int com... |
d87d909a45b7b6bf411559e85d386ef0a2f4bbae | Analyze and fix the following issue in the Linux kernel code: Staging: cxt1e1: use netdev_priv to fix build | Problem Details:
Fix cxt1e1 build error:
drivers/staging/cxt1e1/linux.c:1195: error: 'struct net_device' has no member named 'priv'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Bob Beers <bob.beers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index 23e184da9723..aee7018f9d3f 100644
--- a/drivers/staging/cxt1e1/linux.c
+++ b/drivers/staging/cxt1e1/linux.c
@@ -1192,7 +1192,7 @@ c4_add_dev (hdw_info_t * hi, int brdno, unsigned long f0, unsigned long f1,
hi->de... |
c849d2538ebeef1ac26fad7a10c18b1e0fc35161 | Analyze and fix the following issue in the Linux kernel code: Staging: iio: Fix remaining code style issues | Problem Details:
fix code style issues
Signed-of-by: Roel Van Nyen <roel.vannyen@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 37f58f66e491..7c9a12e0e8fe 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -809,7 +809,7 @@ int iio_device_register(struct iio_dev *dev_info)
ret = iio_dev... |
6cbfa62589d71500d8097fd33e8f9958d484b071 | Analyze and fix the following issue in the Linux kernel code: Staging: memrar: fix printk format warning | Problem Details:
Fix printk format warning in memrar:
drivers/staging/memrar/memrar_handler.c:393: warning: format '%u' expects type 'unsigned int', but argument 4 has type 'size_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ossama Othman <ossama.othman@intel.com>
Signed-off-by: Greg Kroah-Hartman <greg... | ```diff
diff --git a/drivers/staging/memrar/memrar_handler.c b/drivers/staging/memrar/memrar_handler.c
index 4bbf66f4223d..3e0dfe365769 100644
--- a/drivers/staging/memrar/memrar_handler.c
+++ b/drivers/staging/memrar/memrar_handler.c
@@ -390,7 +390,7 @@ static int memrar_init_rar_resources(char const *devname)
(un... |
3dc1536b217182b6aeaca815d26cf0dfb71fb80c | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8192u: fix space coding style issue in ieee80211_crypt.h | Problem Details:
This is a patch to the ieee80211_crypt.h file that fixed up a space
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8192u/ieee80211_crypt.h b/drivers/staging/rtl8192u/ieee80211_crypt.h
index b58a3bcc0dc0..0b4ea431982d 100644
--- a/drivers/staging/rtl8192u/ieee80211_crypt.h
+++ b/drivers/staging/rtl8192u/ieee80211_crypt.h
@@ -77,7 +77,7 @@ struct ieee80211_crypt_data {
int ieee80211_register... |
1fc5af161f09da027d442a691de67644b66fd012 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8192u: fix comments and space coding style issue in dot11d.h | Problem Details:
This is a patch to the dot11d.h file that fixed up a comments and space
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8192u/dot11d.h b/drivers/staging/rtl8192u/dot11d.h
index 15b7a4ba37b6..0851b9db17a6 100644
--- a/drivers/staging/rtl8192u/dot11d.h
+++ b/drivers/staging/rtl8192u/dot11d.h
@@ -4,44 +4,44 @@
#ifdef ENABLE_DOT11D
#include "ieee80211.h"
-//#define ENABLE_DOT11D
-
-//#define DOT11... |
1695eb36bf4616c6ec062d2dc2c3abe54d3aa313 | Analyze and fix the following issue in the Linux kernel code: Staging: serqt_usb2: fix space coding style issue in serqt_usb2.c | Problem Details:
This is a patch to the serqt_usb2.c files that fixed space error and
warning found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
index 44f2d4eaf84b..27841ef6a568 100644
--- a/drivers/staging/serqt_usb2/serqt_usb2.c
+++ b/drivers/staging/serqt_usb2/serqt_usb2.c
@@ -413,7 +413,7 @@ static void qt_read_bulk_callback(struct urb *urb)
case 0x... |
cb73da2524df912ddec4aed0b6df1c0374f4ffc1 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se: fix coding style issues in r8180_core.c | Problem Details:
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John Church <j.church@ymail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 88fe6232a47d..84a745bb9ca0 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -44,24 +44,24 @@
#include "ieee80211/dot11d.h"
static struct pci_device_id rtl8180... |
b46966ee8f7c75fcff9e7390d29b1f62650b0784 | Analyze and fix the following issue in the Linux kernel code: Staging: vt6655: fix brace coding style issue in ioctl.c | Problem Details:
This is a patch to the ioctl.c file that fixes up a brace warning found
by the checkpatch.pl tool
Signed-off-by: Ng Kian Yong <ngky@comp.nus.edu.sg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index d9a5fd21ab31..38577ca841ea 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -83,7 +83,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq) {
pReq->wResult = 0;
- switch(pReq->w... |
593ef41c95c82a7c8d09c28db4893f4dd2ff0134 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se: fixed checkpatch.pl warnings and errors in r8180_rtl8225z2.c | Problem Details:
This is a patch to the r8180_rtl8225z2.c file that fixes up errors and
warnings found by the checkpatch.pl tool
Signed-off-by: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8187se/r8180_rtl8225z2.c b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
index 6edf5a46fa40..2a2afd51cf42 100644
--- a/drivers/staging/rtl8187se/r8180_rtl8225z2.c
+++ b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
@@ -1,14 +1,13 @@
/*
- This is part of the rtl8180-sa2400 driver
- ... |
08db6c59a2d4d8162d7544ffaa9aa7d27ce9e50a | Analyze and fix the following issue in the Linux kernel code: Staging: quatech_usb2: fix coding style issues | Problem Details:
This is a patch to the file quatech_usb2.c that fixes two space before
tabular and one line of more than 80 characters warnings found by
checkpatch.pl
Signed-off-by: Soeren Moeller <soerenmoeller2001@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/quatech_usb2/quatech_usb2.c b/drivers/staging/quatech_usb2/quatech_usb2.c
index 1561f74a413b..ecd73135b319 100644
--- a/drivers/staging/quatech_usb2/quatech_usb2.c
+++ b/drivers/staging/quatech_usb2/quatech_usb2.c
@@ -57,7 +57,7 @@ static int debug;
#define QT2_HW_FLOW_CONTROL_MASK... |
33f84a8f2110afbb819c8336cb73d517fc0b2891 | Analyze and fix the following issue in the Linux kernel code: Staging: phison: fix incorrect tabs in phison.c | Problem Details:
This patch fixes two incorrect tab warnings found by the checkpatch.pl
tool
Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/phison/phison.c b/drivers/staging/phison/phison.c
index 0c495eacb75b..42783d7367e3 100644
--- a/drivers/staging/phison/phison.c
+++ b/drivers/staging/phison/phison.c
@@ -23,7 +23,7 @@
#define PHISON_DEBUG
#define DRV_NAME "phison_e-box" /* #0003 */
-#define DRV_VERSION "0.91"... |
fa51929f66ce7953714df1193b13750c39871065 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix copyright and comments style issue in dhfcfg.h | Problem Details:
This is a patch to the dhfcfg.h file that fixed up a copyright and
commets style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhfcfg.h b/drivers/staging/wlags49_h2/dhfcfg.h
index a0c26c678c59..75c279f268ae 100644
--- a/drivers/staging/wlags49_h2/dhfcfg.h
+++ b/drivers/staging/wlags49_h2/dhfcfg.h
@@ -22,7 +22,7 @@
* software indicates your acceptance of these terms and conditions. If you do
... |
1ef61183ceaf2ebb59df817834c0cc755d99c634 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix space and comments style issue in dhf.h | Problem Details:
This is a patch to the dhf.c file that fixed up a space and comments
style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.h b/drivers/staging/wlags49_h2/dhf.h
index 13abcdd6282e..dbe0611fd032 100644
--- a/drivers/staging/wlags49_h2/dhf.h
+++ b/drivers/staging/wlags49_h2/dhf.h
@@ -1,5 +1,5 @@
-// vim:tw=110:ts=4:
+/* vim:tw=110:ts=4: */
#ifndef DHF_H
#define DHF_H
@@ -82,7 +82,7... |
7adea182f1fcaac3c0f37007a15d27f80ef56b85 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix copyright and space style issue in dhf.h | Problem Details:
This is a patch to the dhf.h file that fixed up a copyright anf space
style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.h b/drivers/staging/wlags49_h2/dhf.h
index c071f342a655..13abcdd6282e 100644
--- a/drivers/staging/wlags49_h2/dhf.h
+++ b/drivers/staging/wlags49_h2/dhf.h
@@ -38,9 +38,9 @@
* software indicates your acceptance of these terms and conditions. If you do
* not agree wi... |
437de951eca9c831dc69a47b58603b1d8d9cbf82 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix trailing statements coding style issue in dhf.c | Problem Details:
This is a patch to the dhf.c file that fixed up a trailing statements
Errors found by the checkpatch.pl tools, like
trailing statements should be on next line
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.c b/drivers/staging/wlags49_h2/dhf.c
index 3af43988b953..d5fb1a97e855 100644
--- a/drivers/staging/wlags49_h2/dhf.c
+++ b/drivers/staging/wlags49_h2/dhf.c
@@ -278,16 +278,19 @@ CFG_PROG_STRCT *p;
int i;
/* validate the image */
- for (i = 0; i < sizeof(signat... |
068b561c3c96e7a52a4974da457fb8591064d40b | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix TAB and space coding style issue dhf.c | Problem Details:
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.c b/drivers/staging/wlags49_h2/dhf.c
index 369036412c68..3af43988b953 100644
--- a/drivers/staging/wlags49_h2/dhf.c
+++ b/drivers/staging/wlags49_h2/dhf.c
@@ -120,7 +120,7 @@ char signature[14] = "FUPU7D37dhfwci";
#if defined(_MSC_VER) && _MSC_VER == 800 /* Visua... |
ccc75a583d993c4d51e2b62ae340cebb23ae886f | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix copyright style issue in dhf.c | Problem Details:
This is a patch to the dhf.c file that fixed up a copyright style Errors
found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.c b/drivers/staging/wlags49_h2/dhf.c
index 8997980671f8..369036412c68 100644
--- a/drivers/staging/wlags49_h2/dhf.c
+++ b/drivers/staging/wlags49_h2/dhf.c
@@ -54,8 +54,8 @@
* software indicates your acceptance of these terms and conditions. If you do
* not agree wi... |
fd547f1fead33e55190a1c670575fea467ee24ee | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix comments coding style issue in dhf.c | Problem Details:
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/dhf.c b/drivers/staging/wlags49_h2/dhf.c
index b6f5834b1aff..8997980671f8 100644
--- a/drivers/staging/wlags49_h2/dhf.c
+++ b/drivers/staging/wlags49_h2/dhf.c
@@ -1,5 +1,5 @@
-// vim:tw=110:ts=4:
+/* vim:tw=110:ts=4: */
/********************************************... |
01ce33545f2ef939ef73a93974b89c92a27e5522 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix TAB and space coding style issue in ap_h2.c | Problem Details:
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/ap_h2.c b/drivers/staging/wlags49_h2/ap_h2.c
index e31149813891..eb8244c4d6f0 100644
--- a/drivers/staging/wlags49_h2/ap_h2.c
+++ b/drivers/staging/wlags49_h2/ap_h2.c
@@ -26,7 +26,7 @@
#include "hcfcfg.h" /* to get hcf_16 etc defined as well as */
- ... |
0a13dfdffcef1e72cd4edf9bb9b03d8a3f5fea70 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix comments coding style issue in ap_h2.c | Problem Details:
This is a patch to the ap_h2.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlags49_h2/ap_h2.c b/drivers/staging/wlags49_h2/ap_h2.c
index f5123d2cb4c1..e31149813891 100644
--- a/drivers/staging/wlags49_h2/ap_h2.c
+++ b/drivers/staging/wlags49_h2/ap_h2.c
@@ -25,10 +25,10 @@
*/
-#include "hcfcfg.h" // to get hcf_16 etc defined as well as
- ... |
b93634c4e38e3fbe476b53b1e68ec391ad0ecc86 | Analyze and fix the following issue in the Linux kernel code: Staging: wlags49_h2: fix spaces, macros and comments coding style issue in debug.h | Problem Details:
This is a patch to the debug.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
and
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
and
do not use C99 // comments
and
Macros with complex values shou... | ```diff
diff --git a/drivers/staging/wlags49_h2/debug.h b/drivers/staging/wlags49_h2/debug.h
index 0b52e17b3011..2c3dd140a35f 100644
--- a/drivers/staging/wlags49_h2/debug.h
+++ b/drivers/staging/wlags49_h2/debug.h
@@ -22,7 +22,7 @@
* software indicates your acceptance of these terms and conditions. If you do
* no... |
044bc96bef5e78d4bb9b5c7ad12814afafb901cf | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: fix p80211wext_mhz_to_channel for channel 14 | Problem Details:
Channel 14 is 2484 Mhz (cf p80211wext_channel_to_mhz) so this patch
corrects what seems to be just a typo.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/p80211wext.c b/drivers/staging/wlan-ng/p80211wext.c
index 936be55a5ffb..e1b54094d954 100644
--- a/drivers/staging/wlan-ng/p80211wext.c
+++ b/drivers/staging/wlan-ng/p80211wext.c
@@ -73,7 +73,7 @@ static u8 p80211_mhz_to_channel(u16 mhz)
if (mhz >= 5000)
return (mhz - 50... |
5813b6243cf02b89c6e6a6a8debc10477e5ce3a8 | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: fix spaces coding style issue in p80211conv.c | Problem Details:
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index a1605fbc8092..71c3595fe830 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -208,7 +208,7 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,
p80211_wep->da... |
e5851c205d7d1920389ab4368f6f374d3594b93d | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wbusb.c Coding style fixes. | Problem Details:
I fixed the reported checkpatch.pl problems except for a bunch of
long lines and some printk:s.
I also removed versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 3482eec18651..d7694e6a37a1 100644
--- a/drivers/staging/winbond/wbusb.c
+++ b/drivers/staging/winbond/wbusb.c
@@ -142,19 +142,17 @@ static void hal_set_radio_mode(struct hw_data *pHwData, unsigned char radio_off)
if (pHwData-... |
912457fa4f63d69625653c6ca8d92c564907d14b | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wbusb_s.h Coding style fixes. | Problem Details:
I fixed comments and some spacing.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wbusb_s.h b/drivers/staging/winbond/wbusb_s.h
index 0c7e6a383f2d..8961ae594c4e 100644
--- a/drivers/staging/winbond/wbusb_s.h
+++ b/drivers/staging/winbond/wbusb_s.h
@@ -1,16 +1,10 @@
-//++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-// Copyrig... |
83ad993d65738b6058a019b9c20ee65a57b0eecf | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wblinux_f.h Coding style fixes v2. | Problem Details:
I fixed whitespace and comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wblinux_f.h b/drivers/staging/winbond/wblinux_f.h
index 868e87727240..0a9d214f7187 100644
--- a/drivers/staging/winbond/wblinux_f.h
+++ b/drivers/staging/winbond/wblinux_f.h
@@ -4,13 +4,14 @@
#include "core.h"
#include "mds_s.h"
-//=======================================... |
5a7df3c449e7db7cf4b7807862e11f11c47c2331 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wbhal_s.h Coding style fixes. | Problem Details:
I fixed checkpatch warnings except some long lines and typedefs.
I also removed versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wbhal_s.h b/drivers/staging/winbond/wbhal_s.h
index 372a05e3021a..33457c2e39be 100644
--- a/drivers/staging/winbond/wbhal_s.h
+++ b/drivers/staging/winbond/wbhal_s.h
@@ -4,179 +4,166 @@
#include <linux/types.h>
#include <linux/if_ether.h> /* for ETH_ALEN */
-//[20040722 ... |
b66e65e2fea9392bdccc27b14b00c26b286eb248 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wbhal_f.h Coding style fixes. | Problem Details:
I fixed all checkpatch problems and also converted the
function arguments from hungarian notation and CamelCase.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Dan Carpenter <error27@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wbhal_f.h b/drivers/staging/winbond/wbhal_f.h
index 64a008db30f4..401c024bead8 100644
--- a/drivers/staging/winbond/wbhal_f.h
+++ b/drivers/staging/winbond/wbhal_f.h
@@ -1,70 +1,91 @@
-//=====================================================================
-// Device related... |
6112fd6ebbdc8901b40b43940908fa09f8af7cc4 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wb35rx.c Coding style fixes v2. | Problem Details:
New patch that fixes an unclear comment too.
I fixed checkpatch issues except for long lines and printk:s.
I also removed version comments and the () in a return statement.
Generated .o is identical to master and i checked the code with
Dan Carpenters strip_whitespace.pl and diff.
Signed-off-by: Lars... | ```diff
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index d7b57e62db08..efe82b141c10 100644
--- a/drivers/staging/winbond/wb35rx.c
+++ b/drivers/staging/winbond/wb35rx.c
@@ -1,13 +1,15 @@
-//============================================================================
-// Copyright ... |
42cb2945a9fbfb1602e50c802f6b379244820a6a | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wb35tx_f.h Coding style fixes. | Problem Details:
I fixed the checkpatch.pl problems and converted the function
arguments away from CamelCase and hungarian notation.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/wb35tx_f.h b/drivers/staging/winbond/wb35tx_f.h
index a7af9cbe202a..1d3b515f83bc 100644
--- a/drivers/staging/winbond/wb35tx_f.h
+++ b/drivers/staging/winbond/wb35tx_f.h
@@ -4,18 +4,20 @@
#include "core.h"
#include "wbhal_f.h"
-//====================================
-// ... |
b08585fc584f5e090cf94535171be3ffc6549d98 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: fix comments and space coding style issue in mlmetxrx_f.h | Problem Details:
This is a patch to the mlmetxrx_f.h file that fixed up a comments and
space Errors found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mlmetxrx_f.h b/drivers/staging/winbond/mlmetxrx_f.h
index 6c04e3e03e31..d1aa2617d24b 100644
--- a/drivers/staging/winbond/mlmetxrx_f.h
+++ b/drivers/staging/winbond/mlmetxrx_f.h
@@ -1,10 +1,10 @@
-//================================================================
+/* =======... |
4095aef6dc485545ebbd96d23eac0b11b729e765 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: fix brace, comments and space coding style issue in mlmetxrx.c | Problem Details:
This is a patch to the mlmetxrx.c file that fixed up a brace, comments
and space Errors found by the checkpatch.pl tool.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mlmetxrx.c b/drivers/staging/winbond/mlmetxrx.c
index f856b94a7810..dcd8a11b5d03 100644
--- a/drivers/staging/winbond/mlmetxrx.c
+++ b/drivers/staging/winbond/mlmetxrx.c
@@ -1,26 +1,26 @@
-//============================================================================
-// Mo... |
25e47dfc863406a29d7e66c4d673cc712647b50f | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wb35reg_s.h Coding styls fixes. | Problem Details:
I fixed all problems reported by checkpatch.pl except
some long lines. I also removed commented away code and
revision comments.
Checked for regressions with Dan Carpenters
strip_whitespace.pl and diff.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-b... | ```diff
diff --git a/drivers/staging/winbond/wb35reg_s.h b/drivers/staging/winbond/wb35reg_s.h
index 32ef4b8a2d2a..4eff009444b8 100644
--- a/drivers/staging/winbond/wb35reg_s.h
+++ b/drivers/staging/winbond/wb35reg_s.h
@@ -5,98 +5,100 @@
#include <linux/types.h>
#include <asm/atomic.h>
-//==========================... |
d4279a9f2cfd349b8e308770b826ae09f3f5b86d | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: wb35reg_f.h Coding style fixes. | Problem Details:
I fixed the checkpatch things except a couple of long lines.
I also removed hungarian notation and CamelCase from the argument names
and some "commented away" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Si... | ```diff
diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h
index d352bce5c171..bf23c1084199 100644
--- a/drivers/staging/winbond/wb35reg_f.h
+++ b/drivers/staging/winbond/wb35reg_f.h
@@ -3,59 +3,63 @@
#include "wbhal_s.h"
-//====================================
-// Interface fun... |
89343a0e058c26965696c74321248768a1292f12 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: sysdef.h Coding style fixes. | Problem Details:
I fixed the C99 comments and removed commented away code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/sysdef.h b/drivers/staging/winbond/sysdef.h
index 251b9c553b6c..9195adf98e14 100644
--- a/drivers/staging/winbond/sysdef.h
+++ b/drivers/staging/winbond/sysdef.h
@@ -1,31 +1,19 @@
+/* Winbond WLAN System Configuration defines */
-
-//
-// Winbond WLAN System Configuration... |
c64ba207ddcb7ea426032ae7166b5f666ea1d3c5 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: sme_api.h Coding style fixes. | Problem Details:
I fixed the things reported by checkpatch.pl except
one long line and a __inline.
I also removed commented away code and versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <... | ```diff
diff --git a/drivers/staging/winbond/sme_api.h b/drivers/staging/winbond/sme_api.h
index b5898294eb8a..8f4596c9e9b3 100644
--- a/drivers/staging/winbond/sme_api.h
+++ b/drivers/staging/winbond/sme_api.h
@@ -2,12 +2,6 @@
* sme_api.h
*
* Copyright(C) 2002 Winbond Electronics Corp.
- *
- * modification histo... |
152f1bc0517f95f6866046f00c7ef7aff1ca58cd | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: scan_s.h Coding style fixes. | Problem Details:
I fixed all things reported by checkpatch.pl except a couple
of long lines and typedefs.
I also removed "commented away" code and a history comment.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Gre... | ```diff
diff --git a/drivers/staging/winbond/scan_s.h b/drivers/staging/winbond/scan_s.h
index 209717f5d47d..85e7523196d0 100644
--- a/drivers/staging/winbond/scan_s.h
+++ b/drivers/staging/winbond/scan_s.h
@@ -4,117 +4,107 @@
#include <linux/types.h>
#include "localpara.h"
-//
-// SCAN task global CONSTANTS, STRUC... |
d20279d7d45e3428b2202385e488ea57fbc4ab39 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: fix brace and space coding style issue in mac_structures.h | Problem Details:
This is a patch to the mac_structures.h file that fixed up a brace and
space Errors found by the checkpatch.pl tool.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mac_structures.h b/drivers/staging/winbond/mac_structures.h
index 80d7e4a88997..7441015cb187 100644
--- a/drivers/staging/winbond/mac_structures.h
+++ b/drivers/staging/winbond/mac_structures.h
@@ -180,8 +180,7 @@ enum enum_MMPDUResultCode
// Define the transmission const... |
03a4389c808a552abb734483310b52140491ed00 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: fix comments coding style issue in mac_structures.h | Problem Details:
This is a patch to the mac_structures.h file that fixed up a comments
Errors found by the checkpatch.pl tool
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mac_structures.h b/drivers/staging/winbond/mac_structures.h
index f24dbb955bfe..80d7e4a88997 100644
--- a/drivers/staging/winbond/mac_structures.h
+++ b/drivers/staging/winbond/mac_structures.h
@@ -1,4 +1,4 @@
-//++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++... |
5dcf8f668c330e72bf3a1de9e8b9451912a68ccd | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: fix comments coding style issue in core.h | Problem Details:
This is a patch to the core.h file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/core.h b/drivers/staging/winbond/core.h
index 0a2060bf4f94..b87d6c07600f 100644
--- a/drivers/staging/winbond/core.h
+++ b/drivers/staging/winbond/core.h
@@ -12,14 +12,16 @@
#define WB_MAX_LINK_NAME_LEN 40
struct wbsoft_priv {
- u32 adapterIndex; // 20060703.4 Add for us... |
f9a4191cfbe86c5f96a6c6d340ab8bb65fa5c211 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: mto.c Coding style fixes | Problem Details:
I changed all things reported by checkpatch.pl except some long lines
and the use of externs in a .c file. I also removed revision comments
and "commented out" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
S... | ```diff
diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c
index 5e7fa1cd0aea..9cd212783d61 100644
--- a/drivers/staging/winbond/mto.c
+++ b/drivers/staging/winbond/mto.c
@@ -1,222 +1,181 @@
-//============================================================================
-// MTO.C -
-//
-// Des... |
75df20e0385198e80439bfc33c001fcecf094622 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: mto.h Coding style fixes | Problem Details:
I fixed all problems reported by checkpatch.pl except for a couple of
long lines. I also removed version comments and removed "commented away"
code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h
index fb4781d5781b..a0f659cf99ff 100644
--- a/drivers/staging/winbond/mto.h
+++ b/drivers/staging/winbond/mto.h
@@ -1,13 +1,10 @@
-//==================================================================
-// MTO.H
-//
-// Revision history
-/... |
1a48ba148c45052efc2e1505e28198b725a23e95 | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: mlme_s.h Coding style fixes | Problem Details:
I fixed all problems found by checkpatch.pl except typedefs.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mlme_s.h b/drivers/staging/winbond/mlme_s.h
index 1217a1c025e5..a7ef3c78022e 100644
--- a/drivers/staging/winbond/mlme_s.h
+++ b/drivers/staging/winbond/mlme_s.h
@@ -7,28 +7,29 @@
#include "mac_structures.h"
#include "mds_s.h"
-//+++++++++++++++++++++++++++++++++++++++++... |
5ea0525500f7cd3c09d4ee7beb66079d6abef8ab | Analyze and fix the following issue in the Linux kernel code: Staging: winbond: mds_s.h coding style fixes. | Problem Details:
I fixed all problems reported by checkpatch.pl except some
long lines.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/winbond/mds_s.h b/drivers/staging/winbond/mds_s.h
index 217ff0819a93..89328c5dbdad 100644
--- a/drivers/staging/winbond/mds_s.h
+++ b/drivers/staging/winbond/mds_s.h
@@ -15,122 +15,121 @@ enum {
WLAN_PREAMBLE_TYPE_LONG,
};
-//////////////////////////////////////////////////////... |
8eb3e22e56ee35a6a65c956bd2862c8247443cbd | Analyze and fix the following issue in the Linux kernel code: Staging: wavelan: fix initialise statics to 0 in wavelan_cs.p.h | Problem Details:
This is a patch to the wavelan_cs.p.h fix initialise statics to 0
Errors found by the checkpatch.pl tools, like
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wavelan/wavelan_cs.p.h b/drivers/staging/wavelan/wavelan_cs.p.h
index 9427eb2727a1..7196267976f0 100644
--- a/drivers/staging/wavelan/wavelan_cs.p.h
+++ b/drivers/staging/wavelan/wavelan_cs.p.h
@@ -745,14 +745,14 @@ static void
*/
/* Shared memory speed, in ns */
-static int me... |
fb549675ffc09afecea771229ce48a33c7ea604e | Analyze and fix the following issue in the Linux kernel code: Staging: wavelan: fix macros, spaces and TAB coding style issue in wavelan_cs.p.h | Problem Details:
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
and
Macros complex expr -> (complex expr)
Signed-off-by: Ruslan Pisarev <ruslan@rp... | ```diff
diff --git a/drivers/staging/wavelan/wavelan_cs.p.h b/drivers/staging/wavelan/wavelan_cs.p.h
index 8fbfaa8a5a67..9427eb2727a1 100644
--- a/drivers/staging/wavelan/wavelan_cs.p.h
+++ b/drivers/staging/wavelan/wavelan_cs.p.h
@@ -123,7 +123,7 @@
* writing a Wavelan ISA driver for the MACH microkernel. Girish
*... |
b2561f212210a7c31b4d1c7d7136c38724719fa8 | Analyze and fix the following issue in the Linux kernel code: Staging: wavelan: fix spaces and TAB coding style issue in wavelan_cs.h | Problem Details:
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Ha... | ```diff
diff --git a/drivers/staging/wavelan/wavelan_cs.h b/drivers/staging/wavelan/wavelan_cs.h
index 2e4bfe4147c6..42e268dbae98 100644
--- a/drivers/staging/wavelan/wavelan_cs.h
+++ b/drivers/staging/wavelan/wavelan_cs.h
@@ -18,7 +18,7 @@
*/
/*
- * Definitions for the AT&T GIS (formerly NCR) WaveLAN PCMCIA card:... |
604ef85819ec42c3ec8faca62eee8deb534b89c9 | Analyze and fix the following issue in the Linux kernel code: Staging: wavelan: fix spaces and TAB coding style and macros issue in wavelan.p.h | Problem Details:
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
and
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Rus... | ```diff
diff --git a/drivers/staging/wavelan/wavelan.p.h b/drivers/staging/wavelan/wavelan.p.h
index dbe8de6e5f52..d5f322c68d05 100644
--- a/drivers/staging/wavelan/wavelan.p.h
+++ b/drivers/staging/wavelan/wavelan.p.h
@@ -125,7 +125,7 @@
* writing a WaveLAN ISA driver for the Mach microkernel. Girish
* Welling <w... |
a0ec96206192a58ec1c429aa1436717d2a351d0c | Analyze and fix the following issue in the Linux kernel code: Staging: wavelan: fix spaces and TAB coding style issue in wavelan.h | Problem Details:
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Ha... | ```diff
diff --git a/drivers/staging/wavelan/wavelan.h b/drivers/staging/wavelan/wavelan.h
index 9ab360558ffd..1ebae10b8696 100644
--- a/drivers/staging/wavelan/wavelan.h
+++ b/drivers/staging/wavelan/wavelan.h
@@ -26,8 +26,7 @@
* product (OEM, like DEC RoamAbout, Digital Ocean, or Epson),
* you might need to modif... |
cebb7e83361aba7ff05ec5cfb1bd1d5c8d983eed | Analyze and fix the following issue in the Linux kernel code: Staging: wavelan: fix spaces and TAB coding style issue in i82586.h | Problem Details:
This is a patch to the i82586.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Har... | ```diff
diff --git a/drivers/staging/wavelan/i82586.h b/drivers/staging/wavelan/i82586.h
index 5f65b250646f..27f832498139 100644
--- a/drivers/staging/wavelan/i82586.h
+++ b/drivers/staging/wavelan/i82586.h
@@ -30,14 +30,13 @@
#define ADDR_LEN 6
#define I82586NULL 0xFFFF
-#define toff(t,p,f) (unsigned short)((void... |
ceb0525c9e4f7e6a3ec762deb0960be3522030dc | Analyze and fix the following issue in the Linux kernel code: Staging: iio: fix typo in userspace example codes and document | Problem Details:
Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
index 6a8fa0c9372e..08e012fa8460 100644
--- a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
+++ b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
@@ -19,7 +19,... |
acc4e4168f87c05be31c3259ee0cb6262473c8ea | Analyze and fix the following issue in the Linux kernel code: staging: usbip: fix coding style issues in the usbip driver | Problem Details:
This is a patch to the usbip driver that fixes up some coding style
issues found by the checkpack.pl tool
Signed-off-by: Michael Sprecher <sprecher.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/usbip/vhci_tx.c b/drivers/staging/usbip/vhci_tx.c
index b71b4c2fbd86..e1c1f716a1c2 100644
--- a/drivers/staging/usbip/vhci_tx.c
+++ b/drivers/staging/usbip/vhci_tx.c
@@ -179,7 +179,7 @@ static int vhci_send_cmd_unlink(struct vhci_device *vdev)
memset(&msg, 0, sizeof(msg));
mem... |
005126872a3a605d6f7fc2f739f5d4234f9df92c | Analyze and fix the following issue in the Linux kernel code: Staging: usbip: fix space before tab in vhci_hcd.c | Problem Details:
This is a patch to the vhci_hcd.c fix space before tab
warning found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index 0b1766122d38..be5d8db98165 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -1072,7 +1072,7 @@ static struct hc_driver vhci_hc_driver = {
.flags = HCD_USB2,
.start = vhci_start,
... |
1bd3302c383e8179423d15a53891c49663a06e23 | Analyze and fix the following issue in the Linux kernel code: Staging: usbip: fix space before tab in usbip_common.h | Problem Details:
This is a patch to the usbip_common.h fix space before tab
warning found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/usbip/usbip_common.h b/drivers/staging/usbip/usbip_common.h
index 6f1dcb197d13..e1bbd1287e28 100644
--- a/drivers/staging/usbip/usbip_common.h
+++ b/drivers/staging/usbip/usbip_common.h
@@ -182,7 +182,7 @@ struct usbip_header_basic {
__u32 devid;
#define USBIP_DIR_OUT 0
-#defin... |
41f8b96e3d1a25e328ae77727fefa4e3c780f8a4 | Analyze and fix the following issue in the Linux kernel code: Staging: dream: smd: smd_qmi: fix code style issues | Problem Details:
This fixes some code style issues detected with the checkpatch.pl
script, like not necessary braces {} in some if and else statements and
include a KERN_INFO facility level in a printk() function.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dream/smd/smd_qmi.c b/drivers/staging/dream/smd/smd_qmi.c
index 9e9067fb271b..76fce5142d9e 100644
--- a/drivers/staging/dream/smd/smd_qmi.c
+++ b/drivers/staging/dream/smd/smd_qmi.c
@@ -211,11 +211,10 @@ static int qmi_send(struct qmi_ctxt *ctxt, struct qmi_msg *msg)
qmi_dump_ms... |
eb450e894524f912941b121ff036dae14b83d53d | Analyze and fix the following issue in the Linux kernel code: Staging: dream: pmem: fix some code style issues | Problem Details:
This fixes some code style issues like prohibited spaces after that open
parenthesis '(' and before that close parenthesis ')', and lines over 80
characters.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dream/pmem.c b/drivers/staging/dream/pmem.c
index 6edfdd4ef804..dbd2b1d14c4f 100644
--- a/drivers/staging/dream/pmem.c
+++ b/drivers/staging/dream/pmem.c
@@ -38,17 +38,17 @@
* the file should not be released until put_pmem_file is called */
#define PMEM_FLAGS_BUSY 0x1
/* indicat... |
665752e528c32e40d9f5c684abd53ebd2f1ae724 | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: fix dangling i2c pointers | Problem Details:
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/wis-saa7113.c b/drivers/staging/go7007/wis-saa7113.c
index 5c12b4d38459..bd925457f8b7 100644
--- a/drivers/staging/go7007/wis-saa7113.c
+++ b/drivers/staging/go7007/wis-saa7113.c
@@ -289,6 +289,7 @@ static int wis_saa7113_probe(struct i2c_client *client,
if (write_regs(clie... |
5ff0dd18267efc0e7b0352fe54b74114b58535ae | Analyze and fix the following issue in the Linux kernel code: Staging: dream: fix dangling i2c pointers | Problem Details:
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dream/synaptics_i2c_rmi.c b/drivers/staging/dream/synaptics_i2c_rmi.c
index d2ca116a1c25..ae2f72ca7351 100644
--- a/drivers/staging/dream/synaptics_i2c_rmi.c
+++ b/drivers/staging/dream/synaptics_i2c_rmi.c
@@ -535,6 +535,7 @@ err_input_register_device_failed:
err_input_dev_alloc_fa... |
593a961649226aae13705dc066ee277f112b8397 | Analyze and fix the following issue in the Linux kernel code: Staging: dream: smd: smd_private: fix code style issues | Problem Details:
This put open braces '{' following structs on the same line.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dream/smd/smd_private.h b/drivers/staging/dream/smd/smd_private.h
index c0eb3de1be54..1b2e1c89ea2e 100644
--- a/drivers/staging/dream/smd/smd_private.h
+++ b/drivers/staging/dream/smd/smd_private.h
@@ -16,24 +16,21 @@
#ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
#define _ARCH_ARM... |
17e7b137df499a9d6c9c69dd28d427e6117aa17c | Analyze and fix the following issue in the Linux kernel code: Staging: dream: smd: smd_qmi: fix code style issues | Problem Details:
This fixes some code style issues about to #include <linux/uaccess.h>
instead of <asm/uaccess.h> and some not necessary braces {}.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dream/smd/smd_qmi.c b/drivers/staging/dream/smd/smd_qmi.c
index 687db142904c..9e9067fb271b 100644
--- a/drivers/staging/dream/smd/smd_qmi.c
+++ b/drivers/staging/dream/smd/smd_qmi.c
@@ -25,7 +25,7 @@
#include <linux/miscdevice.h>
#include <linux/workqueue.h>
-#include <asm/uacce... |
f4d52b072d35ad2cc3720af65853e6fcc9d8414f | Analyze and fix the following issue in the Linux kernel code: Staging: otus: Add null check and fix coding style issue | Problem Details:
This patch removes mixing of declarations and code and adds a null-test
after a kmalloc.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/ioctl.c b/drivers/staging/otus/ioctl.c
index b9dd943e07a1..a48c8e4a9ea7 100644
--- a/drivers/staging/otus/ioctl.c
+++ b/drivers/staging/otus/ioctl.c
@@ -867,6 +867,7 @@ int usbdrvwext_giwscan(struct net_device *dev,
char *current_ev = extra;
char *end_buf;
int i;
+ struct... |
a3327f07987468794f4afc602790aca6856e1a5a | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix usb_main_dev.c style errors | Problem Details:
Correct several style errors related to pointers in usb_main_dev.c.
Signed-off-by: Trey Evans <lewis.r.evans@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/usb_main_dev.c b/drivers/staging/rt2860/usb_main_dev.c
index 1873a79bb033..abe9f241ff93 100644
--- a/drivers/staging/rt2860/usb_main_dev.c
+++ b/drivers/staging/rt2860/usb_main_dev.c
@@ -153,7 +153,7 @@ static void rt2870_disconnect(struct usb_device *dev, struct rt_rtmp_adap... |
1995dbabd44a5540a9950512c8b87e888a399c2a | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix coding style issue in rt3070.c, rt3090.c, rt30xx.c | Problem Details:
This is a patch to the rt3070.c, rt3090.c, rt30xx.c files that fixes up
errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/chips/rt3070.c b/drivers/staging/rt2860/chips/rt3070.c
index 627bad943a3c..3a17fd10ec1f 100644
--- a/drivers/staging/rt2860/chips/rt3070.c
+++ b/drivers/staging/rt2860/chips/rt3070.c
@@ -56,7 +56,7 @@ void NICInitRT3070RFRegisters(struct rt_rtmp_adapter *pAd)
u32 RfReg = 0... |
3d401c96e08c8e942306387d6ae82be0cc4de12f | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix coding style issue in rt_usb.c | Problem Details:
This is a patch to the rt_usb.c file that fixes up errors found by the
checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_usb.c b/drivers/staging/rt2860/rt_usb.c
index 01a7eb4e8ba8..bcfc0f54d2aa 100644
--- a/drivers/staging/rt2860/rt_usb.c
+++ b/drivers/staging/rt2860/rt_usb.c
@@ -233,8 +233,7 @@ static void rtusb_dataout_complete(unsigned long data)
FREE_HTTX_RING(pAd, BulkOutPipeId, pHTT... |
015ffcbeb3a95bd67fd9851a6428508a2e48837f | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix coding style issue in rt_pci_rbus.c | Problem Details:
This is a patch to the rt_pci_rbus.c file that fixes up errors found by
the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_pci_rbus.c b/drivers/staging/rt2860/rt_pci_rbus.c
index acdf09f148e8..3004be6da003 100644
--- a/drivers/staging/rt2860/rt_pci_rbus.c
+++ b/drivers/staging/rt2860/rt_pci_rbus.c
@@ -81,7 +81,7 @@ void RTMP_AllocateTxDescMemory(struct rt_rtmp_adapter *pAd,
u32 Inde... |
52acccb144ef698577a372b60a17e56b686fa064 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix coding style issue in rt_main_dev.c | Problem Details:
This is a patch to the rt_main_dev.c file that fixes up errors found by
the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_main_dev.c b/drivers/staging/rt2860/rt_main_dev.c
index fbddb00cfedd..ad60ceaf4b88 100644
--- a/drivers/staging/rt2860/rt_main_dev.c
+++ b/drivers/staging/rt2860/rt_main_dev.c
@@ -439,13 +439,13 @@ int rt28xx_open(struct net_device *dev)
RTMPInitPCIeLinkCtrlValue(pAd);
... |
cc9b5222f225d03d8815a4d7225f0cbf01755ef3 | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix coding style issue in rt_linux.c | Problem Details:
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rt2860/rt_linux.c b/drivers/staging/rt2860/rt_linux.c
index fd9a2072139b..bfda187d2fbb 100644
--- a/drivers/staging/rt2860/rt_linux.c
+++ b/drivers/staging/rt2860/rt_linux.c
@@ -82,7 +82,7 @@ char const *pWirelessFloodEventText[IW_FLOOD_EVENT_TYPE_NUM] = {
};
/* timeout -- ms */... |
9fd453c981b07f8cd501a938085b901b0c8c0bf5 | Analyze and fix the following issue in the Linux kernel code: Staging: rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe | Problem Details:
To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
change the type of the first parameter to linux_pci_{map,unmap}_single()
from void * to struct rt_rtmp_adapter *. Also do not define the macros
PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
not used and if the... | ```diff
diff --git a/drivers/staging/rt2860/rt_linux.h b/drivers/staging/rt2860/rt_linux.h
index a7c540f8e3e3..b370fb21e423 100644
--- a/drivers/staging/rt2860/rt_linux.h
+++ b/drivers/staging/rt2860/rt_linux.h
@@ -455,10 +455,11 @@ void hex_dump(char *str, unsigned char *pSrcBufVA, unsigned int SrcBufLen);
* Device ... |
5d6892b3c6811cfd20e3d71d89fa77f4b6bd089b | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix spaces and TAB coding style issue in inode.c | Problem Details:
This is a patch to the inode.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <greg... | ```diff
diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
index 63275529ff55..9286e863b0e7 100644
--- a/drivers/staging/pohmelfs/inode.c
+++ b/drivers/staging/pohmelfs/inode.c
@@ -685,7 +685,7 @@ static int pohmelfs_readpages_trans_complete(struct page **__pages, unsigned int
goto err_... |
75cc5d9c648f6af2362ae4da54f5d237d0cc75ee | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix spaces and TAB coding style issue in netfs.h | Problem Details:
This is a patch to the netfs.h file that fixed up a TAB and spaces
WARNING found by the checkpatch.pl tools, like
WARNING: please, no space before tabs
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de... | ```diff
diff --git a/drivers/staging/pohmelfs/netfs.h b/drivers/staging/pohmelfs/netfs.h
index 35c898a3a9dd..63391d2c25a4 100644
--- a/drivers/staging/pohmelfs/netfs.h
+++ b/drivers/staging/pohmelfs/netfs.h
@@ -489,7 +489,7 @@ void pohmelfs_crypto_thread_make_ready(struct pohmelfs_crypto_thread *th);
struct netfs_stat... |
9b835ea87b43354d6bd053fba7f79cc84b588a3d | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix comments, spaces and TAB coding style issue in netfs.h | Problem Details:
This is a patch to the netfs.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
... | ```diff
diff --git a/drivers/staging/pohmelfs/netfs.h b/drivers/staging/pohmelfs/netfs.h
index 01cba006e07a..35c898a3a9dd 100644
--- a/drivers/staging/pohmelfs/netfs.h
+++ b/drivers/staging/pohmelfs/netfs.h
@@ -305,7 +305,7 @@ struct pohmelfs_inode {
};
struct netfs_trans;
-typedef int (* netfs_trans_complete_t)(st... |
3420bc94e5c569a3385e781bf65c7d86c3053342 | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix spaces and TAB coding style issue in dir.c | Problem Details:
This is a patch to the dir.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh... | ```diff
diff --git a/drivers/staging/pohmelfs/dir.c b/drivers/staging/pohmelfs/dir.c
index 79819f07bfb9..059e9d2ddf6b 100644
--- a/drivers/staging/pohmelfs/dir.c
+++ b/drivers/staging/pohmelfs/dir.c
@@ -105,7 +105,7 @@ static struct pohmelfs_name *pohmelfs_insert_hash(struct pohmelfs_inode *pi,
if (ret) {
printk... |
5ac7af8942a4e7aca1eebee9b0b4ebc14c8cda89 | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix spaces and TAB coding style issue in config.c | Problem Details:
This is a patch to the config.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like:
ERROR: switch and case should be at the same indent
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman ... | ```diff
diff --git a/drivers/staging/pohmelfs/config.c b/drivers/staging/pohmelfs/config.c
index eed0e5545a55..6571a6ae05a5 100644
--- a/drivers/staging/pohmelfs/config.c
+++ b/drivers/staging/pohmelfs/config.c
@@ -509,13 +509,13 @@ static int pohmelfs_cn_crypto(struct cn_msg *msg)
}
switch (crypto->type) {
- ca... |
e3f052f2b84f66fcaa9b9149e1e0b4930d78c307 | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix spaces and TAB coding style issue in crypto.c | Problem Details:
This is a patch to the crypto.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@i... | ```diff
diff --git a/drivers/staging/pohmelfs/crypto.c b/drivers/staging/pohmelfs/crypto.c
index 884183c0913a..2fdb3e01460d 100644
--- a/drivers/staging/pohmelfs/crypto.c
+++ b/drivers/staging/pohmelfs/crypto.c
@@ -170,17 +170,17 @@ static int pohmelfs_crypto_process(struct ablkcipher_request *req,
err = crypto_ablk... |
c1989b36df51b08a59b858920b4c84c392a63d12 | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix spaces and TAB coding style issue in net.c | Problem Details:
This is a patch to the net.c file that fixed up a TAB and spaces Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@iorem... | ```diff
diff --git a/drivers/staging/pohmelfs/net.c b/drivers/staging/pohmelfs/net.c
index 4a86f0b1ea88..9279897ff161 100644
--- a/drivers/staging/pohmelfs/net.c
+++ b/drivers/staging/pohmelfs/net.c
@@ -713,8 +713,8 @@ static int pohmelfs_crypto_cap_response(struct netfs_state *st)
dprintk("%s: cipher '%s': %s, has... |
d241fd58e407cd3943cabd61217a0ae32c795c1d | Analyze and fix the following issue in the Linux kernel code: Staging: dt3155: fix parentheses and bracket spacing style issues | Problem Details:
This is a patch to the dt3155_drv.c file that removes spaces after open
parentheses and brackets and before close parentheses and brackets.
Signed-off-by: Jason Baldus <jason.baldus@gmail.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dt3155/dt3155_drv.c b/drivers/staging/dt3155/dt3155_drv.c
index 7e6095f43f16..91ebfadba9a7 100644
--- a/drivers/staging/dt3155/dt3155_drv.c
+++ b/drivers/staging/dt3155/dt3155_drv.c
@@ -95,7 +95,7 @@ int dt3155_errno = 0;
#endif
/* wait queue for interrupts */
-wait_queue_head_t... |
484d3be1bded596a404ac99401652c7728be2f24 | Analyze and fix the following issue in the Linux kernel code: Staging: dt3155: fix coding style issue in dt3155_isr.c | Problem Details:
This is a patch to the dt3155_isr.c file that fixes up a coding
style warning and errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dt3155/dt3155_isr.c b/drivers/staging/dt3155/dt3155_isr.c
index 09d7d9b8272d..1ebcec0c3091 100644
--- a/drivers/staging/dt3155/dt3155_isr.c
+++ b/drivers/staging/dt3155/dt3155_isr.c
@@ -1,7 +1,7 @@
/*
Copyright 1996,2002,2005 Gregory D. Hager, Alfred A. Rizzi, Noah J. Cowan,
- ... |
ac4898a0f81d3b3c218cb4d17bac1750ef82e456 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fixed coding style issues in drivers.c | Problem Details:
This patch fixes coding style issues found by checkpatch.pl, and doesnt
line break string literals.
Signed-off-by: Zachary Richey <zr.public@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 44d6b62c230d..4b69d06ca735 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -102,7 +102,7 @@ static void __comedi_device_detach(struct comedi_device *dev)
if (dev->driver)
dev->driv... |
b4ae23ce014d25af6c09bf3e82b4fd94b0cd2cb9 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: drivers: fix coding style issues in das08.c | Problem Details:
This is a patch to the das08.c file that fixes up the following issues
found by the checkpatch.pl tool.
WARNING: line over 80 characters x 6
ERROR: code indent should use tabs where possible x 3
ERROR: spaces required around that '?' (ctx:VxV) x 4
ERROR: spaces required around that ':' (ctx:VxV) x 4
E... | ```diff
diff --git a/drivers/staging/comedi/drivers/das08.c b/drivers/staging/comedi/drivers/das08.c
index f4258334532c..9cb144f7e70c 100644
--- a/drivers/staging/comedi/drivers/das08.c
+++ b/drivers/staging/comedi/drivers/das08.c
@@ -1,55 +1,55 @@
/*
- comedi/drivers/das08.c
- DAS08 driver
-
- COMEDI - Linux... |
3c0d681e7d31fe747a2cbed0a93dd92049521683 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: drivers: fix coding style issues in das16.c | Problem Details:
This is a patch to the das16.c file that fixes up the following issues
found by the checkpatch.pl tool.
WARNING: line over 80 characters x 23
ERROR: spaces required around that '?' (ctx:VxV) x 2
ERROR: spaces required around that ':' (ctx:VxV) x 2
WARNING: printk() should include KERN_ facility level ... | ```diff
diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c
index f2aadda9b241..ccee4f1802d6 100644
--- a/drivers/staging/comedi/drivers/das16.c
+++ b/drivers/staging/comedi/drivers/das16.c
@@ -74,7 +74,8 @@ Keithley Manuals:
4922.PDF (das-1400)
4923.PDF (das1200, 1400, 1600... |
48fe6039452cac9b98f2b4e1313e35765c2769df | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix coding style issue in comedi.h | Problem Details:
This is a patch to the comedi.h files that fixes up errors found by the
checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index b559a9c2f857..1251e074cb2b 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -490,7 +490,8 @@
I8254_BINARY = 0
};
- static inline unsigned NI_USUAL_PFI_SELECT(unsigned pfi_channel) {
+... |
8487d0e93a24de43c847b923f7bbbd9097e59d47 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: comedi_parport: added KERN_ facility levels to printk messages. | Problem Details:
This is a patch to the comedi_parport.c file that fixes the
KERN_ facility warnings found by the checkpatch.pl tool
Signed-off-by: Stephen Palmateer <stephen.palmateer@netsweeper.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 043afe4439c7..fcd7721c5537 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -309,18 +309,18 @@ static int parport_attach(struc... |
1bf2ee4ea19d3ebeb8fe35c03dd44cb1d851e19f | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: das1800: fix kfree coding style issue | Problem Details:
Signed-off-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 3c3e0455c7c4..d91c2d9d595b 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -797,10 +797,8 @@ static int das1800_detach(struct comedi_device *dev)
fre... |
a5729c005c35ce5b7b8cdbe407c0d0dedf4991dd | Analyze and fix the following issue in the Linux kernel code: Staging: hv: fix spaces coding style issue in vstorage.h | Problem Details:
This is a patch to the vstorage.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that ':' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.... | ```diff
diff --git a/drivers/staging/hv/vstorage.h b/drivers/staging/hv/vstorage.h
index 6d160a53914e..4ea597d7a7d7 100644
--- a/drivers/staging/hv/vstorage.h
+++ b/drivers/staging/hv/vstorage.h
@@ -28,7 +28,7 @@
#define REVISION_STRING(REVISION_) #REVISION_
#define FILL_VMSTOR_REVISION(RESULT_LVALUE_) \
{ ... |
251211c3fa0d218e90f1fb4ce3b475213df467d2 | Analyze and fix the following issue in the Linux kernel code: Staging: dream: Kconfig fix for non-HTC hardware | Problem Details:
> All of the Kconfig menu items under "config DREAM" should be listed
> indented under the 'DREAM' symbol, but they are not. (using xconfig)
> In menuconfig, the DREAM symbol isn't listed (since it depends on BROKEN),
> but the other (subordinate) symbols are still listed.
Ok, this should fix it ... o... | ```diff
diff --git a/drivers/staging/dream/Kconfig b/drivers/staging/dream/Kconfig
index 4afa081c870c..707cc71a8a6a 100644
--- a/drivers/staging/dream/Kconfig
+++ b/drivers/staging/dream/Kconfig
@@ -1,16 +1,14 @@
config DREAM
- tristate "HTC Dream support"
- depends on BROKEN
+ tristate "HTC Dream support"... |
b9e2af544d4fe1a74006a68c744fbdaea13f1665 | Analyze and fix the following issue in the Linux kernel code: Staging: dream: fix gpio_input compilation | Problem Details:
gpio_* drivers still need drivers in staging. Yes, that will need to
be fixed, but at least fix compilation for now.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/dream/Makefile b/drivers/staging/dream/Makefile
index 2b7915197078..43d1eec8e257 100644
--- a/drivers/staging/dream/Makefile
+++ b/drivers/staging/dream/Makefile
@@ -1,3 +1,4 @@
+EXTRA_CFLAGS=-Idrivers/staging/dream/include
obj-$(CONFIG_MSM_ADSP) += qdsp5/ smd/
obj-$(CONFIG_MSM_C... |
1b2e434e1b46c0414e9645cce6179e0fef5e388b | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix coding style in range.c | Problem Details:
add missing space before closing brace
Signed-off-by: John Sheehan <john.d.sheehan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 8313dfcb6732..188c47948033 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -29,7 +29,7 @@ const struct comedi_lrange range_bipolar5 = { 1, {BIP_RANGE(5)} };
const struct comedi_lrange range_bi... |
ee21350fae9333acc11e3b1b77c887fd94e450f5 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix export symbol warnings in ni_daq_700.c | Problem Details:
This is a patch to the ni_daq_700.c file that fixes several EXPORT_SYMBOL
warnings found by the checkpatch.pl tool
Signed-off-by: Robert Babilon <robert.babilon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/ni_daq_700.c b/drivers/staging/comedi/drivers/ni_daq_700.c
index 7ea64538e055..7844203c1ed7 100644
--- a/drivers/staging/comedi/drivers/ni_daq_700.c
+++ b/drivers/staging/comedi/drivers/ni_daq_700.c
@@ -145,6 +145,7 @@ void subdev_700_interrupt(struct comedi_device *d... |
2a613e41ec7684ba863d54a9df3d964e2c7aa4c1 | Analyze and fix the following issue in the Linux kernel code: Staging: cx25821 fixed C99 comments, white spaces and unnecessary braces | Problem Details:
This patch fixes some C99 style comments, trailing white spaces and some
unnecessary 'if' braces found by checkpatch.pl
Signed-off-by: Wouter Van Rooy <wouter.vanrooy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/cx25821/cx25821-alsa.c b/drivers/staging/cx25821/cx25821-alsa.c
index 061add30ba8a..f5a7719b9b9c 100644
--- a/drivers/staging/cx25821/cx25821-alsa.c
+++ b/drivers/staging/cx25821/cx25821-alsa.c
@@ -42,10 +42,10 @@
#define AUDIO_SRAM_CHANNEL SRAM_CH08
-#define dprintk(level,fmt,... |
0686e4f4a2e6f33c418c8d57d9a4fc82b89557b2 | Analyze and fix the following issue in the Linux kernel code: Staging: hv: trivial whitespace fixes found by checkpatch.pl | Problem Details:
Signed-off-by: Lars Lindley <lindley@coyote.org>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/hv/Connection.c b/drivers/staging/hv/Connection.c
index cf9c416e4b16..dbf00560e0ac 100644
--- a/drivers/staging/hv/Connection.c
+++ b/drivers/staging/hv/Connection.c
@@ -259,8 +259,8 @@ static void VmbusProcessChannelEvent(void *context)
VmbusChannelOnChannelEvent(channel);
/*... |
25f1a98bfd0b2a097c8477e4b7bdf6dccf3886b6 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: amplc_pci230: fix brace coding style issue | Problem Details:
Fixed multiple brace coding style issue.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c
index 091a1a5822a8..7fffd967d47e 100644
--- a/drivers/staging/comedi/drivers/amplc_pci230.c
+++ b/drivers/staging/comedi/drivers/amplc_pci230.c
@@ -669,9 +669,9 @@ static short pci230_ai_read(struct comedi... |
59200df52cf7d4bfb93aeb30289a8e9d2af3058d | Analyze and fix the following issue in the Linux kernel code: Staging: dt3155: fix wait_ibsyclr function | Problem Details:
The wait_ibsyclr function is supposed to return the status of the I2C
cycle. Currently it will always return FALSE because the IIC_CSR2
register is not re-read in order to update the cached register value.
This results in the NEW_CYCLE bit still being 1.
The current code actually works correctly only... | ```diff
diff --git a/drivers/staging/dt3155/dt3155_io.c b/drivers/staging/dt3155/dt3155_io.c
index 6b9c68501a61..7792e712d16e 100644
--- a/drivers/staging/dt3155/dt3155_io.c
+++ b/drivers/staging/dt3155/dt3155_io.c
@@ -74,23 +74,22 @@ u8 i2c_pm_lut_data;
* wait_ibsyclr()
*
* This function handles read/write timin... |
641b63f9981a082eeefab3b395203a54dcd6e93b | Analyze and fix the following issue in the Linux kernel code: Staging: crystalhd: Whitespace fixes, indentation fixes and 3 changed #includes | Problem Details:
These patches fixes some whitspace and indentation warnings from
checkpatch.pl
Also these changed #includes:
bc_dts_glob_lnx.h:43: WARNING: Use #include <linux/param.h> instead of <asm/param.h>
rystalhd_lnx.h:45: WARNING: Use #include <linux/io.h> instead of <asm/io.h>
crystalhd_lnx.h:49: WARNING: ... | ```diff
diff --git a/drivers/staging/crystalhd/bc_dts_glob_lnx.h b/drivers/staging/crystalhd/bc_dts_glob_lnx.h
index b3125e3e0372..0fd34e20dc88 100644
--- a/drivers/staging/crystalhd/bc_dts_glob_lnx.h
+++ b/drivers/staging/crystalhd/bc_dts_glob_lnx.h
@@ -40,7 +40,7 @@
#include <sys/time.h>
#include <time.h>
#include... |
15df6385d940ad5486b4c2de8ab45979b13349fe | Analyze and fix the following issue in the Linux kernel code: Staging: crystalhd: fix device_create() return value check | Problem Details:
Use IS_ERR() instead of comparing to NULL.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index 54bad652c0c5..3c562f0f86b3 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -376,7 +376,7 @@ static int __devinit chd_dec_init_chdev(struct crystalhd_... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.