id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
1a468ba10c3bdbc25ef7aa7fecda20ee27007bdf | Analyze and fix the following issue in the Linux kernel code: backlight: mbp_nvidia_bl - Add a debug switch | Problem Details:
This patch adds a debug switch to enable (little) diagnostic
output, to help to trace down the remaining problems.
Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-dresden.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com> | ```diff
diff --git a/drivers/video/backlight/mbp_nvidia_bl.c b/drivers/video/backlight/mbp_nvidia_bl.c
index ce09b83244ac..3bb4c0a50c62 100644
--- a/drivers/video/backlight/mbp_nvidia_bl.c
+++ b/drivers/video/backlight/mbp_nvidia_bl.c
@@ -36,6 +36,11 @@ struct dmi_match_data {
struct backlight_ops backlight_ops;
};
... |
c78a628849675580c7c5e1f07193c632e4b6827f | Analyze and fix the following issue in the Linux kernel code: backlight: Add support for MacBook 5, MacBook Air 2, and MacBook Pro 5 | Problem Details:
This patch adds support for the new Apple models incorporating an Nvidia
chipset. Apple still uses the same protocol as on older models, but the
registers moved to a different address. To do this, two sets of functions
are added for the Intel/Nvidia chipset models and passed by the DMI_MATCH
function.... | ```diff
diff --git a/drivers/video/backlight/mbp_nvidia_bl.c b/drivers/video/backlight/mbp_nvidia_bl.c
index 65864c500455..ce09b83244ac 100644
--- a/drivers/video/backlight/mbp_nvidia_bl.c
+++ b/drivers/video/backlight/mbp_nvidia_bl.c
@@ -27,52 +27,142 @@
static struct backlight_device *mbp_backlight_device;
-stat... |
d379ee8acd0719736ee7f1d1ccc3b5765880eaf8 | Analyze and fix the following issue in the Linux kernel code: leds: just ignore invalid GPIOs in leds-gpio | Problem Details:
Sometimes it's awkward to make sure that the array in the
platform_data handed to the leds-gpio driver has only valid
data ... some leds may not be always available, and coping
with that currently requires patching or rebuilding the array.
This patch fixes that by making it be OK to pass an invalid
GP... | ```diff
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 8fa352ac20f8..102ef4a14c5f 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -78,6 +78,13 @@ static int __devinit create_gpio_led(const struct gpio_led *template,
{
int ret;
+ /* skip leds that aren't available */
... |
7fbc3a9b132e93b2ba1fd889c1ad8a4135731cc3 | Analyze and fix the following issue in the Linux kernel code: leds: Fix &&/|| confusion in leds-pca9532.c | Problem Details:
This fixes the expression in the driver to do the correct thing,
not that I think anyone would send SND_* without EV_SND.
Thanks to Roel Kluin <roel.kluin@gmail.com> for noticing.
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com> | ```diff
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index bd3b431c9710..3937244fdcab 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -169,7 +169,7 @@ static int pca9532_event(struct input_dev *dev, unsigned int type,
{
struct pca9532_data *data = input_get_drv... |
0b56129be72c38179697b7441aacbe133d515ff9 | Analyze and fix the following issue in the Linux kernel code: leds: add BD2802GU LED driver | Problem Details:
ROHM BD2802GU is a RGB LED controller attached to i2c bus and specifically
engineered for decoration purposes. This RGB controller incorporates
lighting patterns and illuminates.
This driver is designed to minimize power consumption, so when there is no
emitting LED, it enters to reset state. And be... | ```diff
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index db84d8f616dc..b77baecd50ca 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -210,6 +210,13 @@ config LEDS_PWM
help
This option enables support for pwm driven LEDs
+config LEDS_BD2802
+ tristate "LED driver for BD2802 RGB LED"
... |
b2bdc3e7130001804f27e7c1254930143119f435 | Analyze and fix the following issue in the Linux kernel code: leds: Fix leds-gpio driver multiple module_init/exit usage | Problem Details:
You can't have multiple module_init()/module_exit calls so resort to messy
ifdefs potentially pending some code refactoring.
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com> | ```diff
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index f8bcf98fc15c..0daa2d21cbde 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -178,19 +178,6 @@ static struct platform_driver gpio_led_driver = {
},
};
-static int __init gpio_led_init(void)
-{
- return platform_dri... |
f379188958ae8af30105eb1f27d0e0abf6a51558 | Analyze and fix the following issue in the Linux kernel code: fsl-diu-fb: Pass the proper device for dma mapping routines | Problem Details:
The driver should pass a device that specifies internal DMA ops, but
currently NULL pointers are passed, and thus following bug pops up:
Freescale DIU driver
------------[ cut here ]------------
kernel BUG at arch/powerpc/include/asm/dma-mapping.h:237!
Oops: Exception in kernel mode, sig: 5 [#... | ```diff
diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index fb51197d1c98..f153c581cbd7 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c
@@ -1352,14 +1352,15 @@ static int fsl_diu_resume(struct of_device *ofdev)
#endif /* CONFIG_PM */
/* Align to 64-bit(8-byte), 32-b... |
bd86ef378412fc30282daf722a833f734e4e2236 | Analyze and fix the following issue in the Linux kernel code: cpm_uart: Initialize port.dev before it's used. | Problem Details:
Previously, this caused NULL to sometimes be passed as a device
to the DMA code. With recent DMA changes, that now causes a BUG().
Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org> | ```diff
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c
index 5c6ef51da274..4dd00bea191a 100644
--- a/drivers/serial/cpm_uart/cpm_uart_core.c
+++ b/drivers/serial/cpm_uart/cpm_uart_core.c
@@ -1339,13 +1339,13 @@ static int __devinit cpm_uart_probe(struct of_device *ofdev,
... |
09318c47b6121c8d18cee50ca7e270a8b7dfd274 | Analyze and fix the following issue in the Linux kernel code: ASoC: Fix null dereference in ak4535_remove() | Problem Details:
ak4535_remove() from sound/soc/codecs/ak4535.c calls
i2c_unregister_device() with a possibly null pointer.
This bug was found by smatch (http://repo.or.cz/w/smatch.git/).
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> | ```diff
diff --git a/sound/soc/codecs/ak4535.c b/sound/soc/codecs/ak4535.c
index 1f63d387a2f4..dd3380202766 100644
--- a/sound/soc/codecs/ak4535.c
+++ b/sound/soc/codecs/ak4535.c
@@ -659,7 +659,8 @@ static int ak4535_remove(struct platform_device *pdev)
snd_soc_free_pcms(socdev);
snd_soc_dapm_free(socdev);
#if def... |
1a52084d0919c2799258737c21fb328a9de159b5 | Analyze and fix the following issue in the Linux kernel code: futex: split out atomic logic from futex_lock_pi() | Problem Details:
Refactor the atomic portion of futex_lock_pi() into futex_lock_pi_atomic().
This logic will be needed by requeue_pi, so modularize it to reduce
code duplication. The only significant change is passing of the task
to try and take the lock for. This simplifies the -EDEADLK test as if
the lock is owned... | ```diff
diff --git a/kernel/futex.c b/kernel/futex.c
index 421fb5e42a10..986b16e44534 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -556,6 +556,127 @@ lookup_pi_state(u32 uval, struct futex_hash_bucket *hb,
return 0;
}
+/**
+ * futex_lock_pi_atomic() - atomic work required to acquire a pi aware futex
+ * @ua... |
3ef48fac6e8e2362a4e6ef31dd043c89fe107875 | Analyze and fix the following issue in the Linux kernel code: [ARM] omap: fix omap1 clock usecount decrement bug | Problem Details:
Same fix as per a7f8c59, but for OMAP1 instead.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
index dafe4f71d15f..336e51dc6127 100644
--- a/arch/arm/mach-omap1/clock.c
+++ b/arch/arm/mach-omap1/clock.c
@@ -590,27 +590,28 @@ static void omap1_init_ext_clk(struct clk * clk)
static int omap1_clk_enable(struct clk *clk)
{
int ret = 0... |
8a057d84912f36e53f970c4d177cb4bb6b2f9e08 | Analyze and fix the following issue in the Linux kernel code: perf_counter: move the event overflow output bits to record_type | Problem Details:
Per suggestion from Paul, move the event overflow bits to record_type
and sanitize the enums a bit.
Breaks the ABI -- again ;-)
Suggested-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Orig-LKML-Reference: <... | ```diff
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 43083afffe0f..06a6fba9f531 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -73,15 +73,6 @@ enum sw_event_ids {
PERF_SW_EVENTS_MAX = 7,
};
-/*
- * IRQ-notification data record type:
- */
-enum per... |
9dd499889bdb12ac0e412ccdd718fe0d348258f2 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: kerneltop: add real-time data acquisition thread | Problem Details:
Decouple kerneltop display from event acquisition by introducing
a separate data acquisition thread. This fixes annnoying kerneltop
display refresh jitter and missed events.
Also add a -r <prio> option, to switch the data acquisition thread
to real-time priority.
Signed-off-by: Mike Galbraith <efault... | ```diff
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
index 430810dae1fe..33b4fcf6e489 100644
--- a/Documentation/perf_counter/kerneltop.c
+++ b/Documentation/perf_counter/kerneltop.c
@@ -77,6 +77,8 @@
#include <errno.h>
#include <ctype.h>
#include <time.h>
+#include <s... |
394ee07623cf556c8daae2b3c00cf5fea47f0811 | Analyze and fix the following issue in the Linux kernel code: perf_counter: provide generic callchain bits | Problem Details:
Provide the generic callchain support bits. If hw_event->callchain is
set the arch specific perf_callchain() function is called upon to
provide a perf_callchain_entry structure filled with the current
callchain.
If it does so, it is added to the overflow output event.
Signed-off-by: Peter Zijlstra <a... | ```diff
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index edf5bfb7ff51..43083afffe0f 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -140,8 +140,9 @@ struct perf_counter_hw_event {
include_tid : 1, /* include the tid */
mmap : 1... |
5ed00415e304203a0a9dcaef226d6d3f1106070e | Analyze and fix the following issue in the Linux kernel code: perf_counter: re-arrange the perf_event_type | Problem Details:
Breaks ABI yet again :-)
Change the event type so that [0, 2^31-1] are regular event types, but
[2^31, 2^32-1] forms a bitmask for overflow events.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Paul Mackerras <paulus@samba.org>
Orig-LKML-Reference: <20090330171024.047961770@chello.... | ```diff
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 037a81145aca..edf5bfb7ff51 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -210,13 +210,15 @@ struct perf_event_header {
};
enum perf_event_type {
- PERF_EVENT_IP = 0,
+
PERF_EVENT_GROUP = 1,
... |
d5d2bc0dd0379deddb9ede66fec90a3083eaec57 | Analyze and fix the following issue in the Linux kernel code: perf_counter: make it possible for hw_perf_counter_init to return error codes | Problem Details:
Impact: better error reporting
At present, if hw_perf_counter_init encounters an error, all it can do
is return NULL, which causes sys_perf_counter_open to return an EINVAL
error to userspace. This isn't very informative for userspace; it means
that userspace can't tell the difference between "sorry,... | ```diff
diff --git a/arch/powerpc/kernel/perf_counter.c b/arch/powerpc/kernel/perf_counter.c
index 560dd1e7b524..0a4d14f279ae 100644
--- a/arch/powerpc/kernel/perf_counter.c
+++ b/arch/powerpc/kernel/perf_counter.c
@@ -624,13 +624,13 @@ hw_perf_counter_init(struct perf_counter *counter)
int err;
if (!ppmu)
- ret... |
38ff667b321b00f5e6830e93fb4ab11a653a2920 | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix update_userpage() | Problem Details:
It just occured to me it is possible to have multiple contending
updates of the userpage (mmap information vs overflow vs counter).
This would break the seqlock logic.
It appear the arch code uses this from NMI context, so we cannot
possibly serialize its use, therefore separate the data_head update
f... | ```diff
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 0d833228eee5..8ac18852dcfe 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -160,10 +160,45 @@ struct perf_counter_hw_event {
struct perf_counter_mmap_page {
__u32 version; /* version number of this... |
925d519ab82b6dd7aca9420d809ee83819c08db2 | Analyze and fix the following issue in the Linux kernel code: perf_counter: unify and fix delayed counter wakeup | Problem Details:
While going over the wakeup code I noticed delayed wakeups only work
for hardware counters but basically all software counters rely on
them.
This patch unifies and generalizes the delayed wakeup to fix this
issue.
Since we're dealing with NMI context bits here, use a cmpxchg() based
single link list ... | ```diff
diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index cb32d571c9c7..20a44d0c9fdd 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -132,7 +132,7 @@ static inline int irqs_disabled_flags(unsigned long flags)
struct irq_chip;
#ifdef CO... |
c7138f37f905bb7987b1f9f5a8ee73667db39f25 | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix perf_poll() | Problem Details:
Impact: fix kerneltop 100% CPU usage
Only return a poll event when there's actually been one, poll_wait()
doesn't actually wait for the waitq you pass it, it only enqueues
you on it.
Only once all FDs have been iterated and none of thm returned a
poll-event will it schedule().
Also make it return PO... | ```diff
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 2b5e66d5ebdf..48212c15b7d6 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -246,6 +246,7 @@ struct file;
struct perf_mmap_data {
struct rcu_head rcu_head;
int nr_pages;
+ atomic_t wakeup;
... |
f66c6b2066b44d4ab8e8ac1ee4cae543738fe2ac | Analyze and fix the following issue in the Linux kernel code: perf_counter: update documentation | Problem Details:
Impact: documentation fix
This updates the perfcounter documentation to reflect recent changes.
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/Documentation/perf_counter/design.txt b/Documentation/perf_counter/design.txt
index fddd32189a50..aaf105c02fba 100644
--- a/Documentation/perf_counter/design.txt
+++ b/Documentation/perf_counter/design.txt
@@ -11,7 +11,9 @@ thus be used to profile the code that runs on that CPU.
The Linux Perfor... |
0fd112e41cd6f6d4779cbe327c3632d087e31476 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: remove glib dependency and fix bugs in kerneltop.c, fix poll() | Problem Details:
Paul Mackerras wrote:
> I noticed the poll stuff is bogus - we have a 2D array of struct
> pollfds (MAX_NR_CPUS x MAX_COUNTERS), we fill in a sub-array (with the
> rest being uninitialized, since the array is on the stack) and then
> pass the first nr_cpus elements to poll. Not what we really meant, ... | ```diff
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
index ea13e4e67229..7ebde7a336c6 100644
--- a/Documentation/perf_counter/kerneltop.c
+++ b/Documentation/perf_counter/kerneltop.c
@@ -1157,10 +1157,10 @@ static void mmap_read(struct mmap_data *md)
int main(int argc,... |
cbe46555dc4de6403cd757139d42289b5f21abb9 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: remove glib dependency and fix bugs in kerneltop.c | Problem Details:
The glib dependency in kerneltop.c is only for a little bit of list
manipulation, and I find it inconvenient. This adds a 'next' field to
struct source_line, which lets us link them together into a list. The
code to do the linking ourselves turns out to be no longer or more
difficult than using glib.... | ```diff
diff --git a/Documentation/perf_counter/Makefile b/Documentation/perf_counter/Makefile
index 666da95a7877..194b66215588 100644
--- a/Documentation/perf_counter/Makefile
+++ b/Documentation/perf_counter/Makefile
@@ -3,7 +3,7 @@ BINS = kerneltop perfstat
all: $(BINS)
kerneltop: kerneltop.c ../../include/linux... |
193e8df1b465f206f8a286202680702e1c153367 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: fix build warning in kerneltop.c | Problem Details:
Fix:
kerneltop.c: In function ‘record_ip’:
kerneltop.c:1005: warning: format ‘%016llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Paul Mackerras <paulus@samba.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Orig-LKM... | ```diff
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
index 25e80bc44556..8f9a303f28d8 100644
--- a/Documentation/perf_counter/kerneltop.c
+++ b/Documentation/perf_counter/kerneltop.c
@@ -1002,7 +1002,7 @@ static void record_ip(uint64_t ip, int counter)
assert(left <= m... |
bcbcb37cdb67d8100acfa66df40c4d636c28c4d1 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: use mmap() output | Problem Details:
update kerneltop to use the mmap() output to gather overflow information
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Paul Mackerras <paulus@samba.org>
Orig-LKML-Reference: <20090323172417.677932499@chello.nl>
Signed-off-by: Ingo Molnar <mingo@el... | ```diff
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
index a72c9bd28071..80b790553ec8 100644
--- a/Documentation/perf_counter/kerneltop.c
+++ b/Documentation/perf_counter/kerneltop.c
@@ -84,6 +84,7 @@
#include <sys/prctl.h>
#include <sys/wait.h>
#include <sys/uio.h>
+#... |
7b732a75047738e4f85438ed2f9cd34bf5f2a19a | Analyze and fix the following issue in the Linux kernel code: perf_counter: new output ABI - part 1 | Problem Details:
Impact: Rework the perfcounter output ABI
use sys_read() only for instant data and provide mmap() output for all
async overflow data.
The first mmap() determines the size of the output buffer. The mmap()
size must be a PAGE_SIZE multiple of 1+pages, where pages must be a
power of 2 or 0. Further mmap... | ```diff
diff --git a/arch/powerpc/kernel/perf_counter.c b/arch/powerpc/kernel/perf_counter.c
index e4349281b07d..d48596ab6557 100644
--- a/arch/powerpc/kernel/perf_counter.c
+++ b/arch/powerpc/kernel/perf_counter.c
@@ -417,8 +417,7 @@ void hw_perf_restore(u64 disable)
atomic64_set(&counter->hw.prev_count, val);
c... |
b09d2501ed3d294619cbfbcf828ad39324d0e548 | Analyze and fix the following issue in the Linux kernel code: mutex: drop "inline" from mutex_lock() inside kernel/mutex.c | Problem Details:
Impact: build fix
mutex_lock() is was defined inline in kernel/mutex.c, but wasn't
declared so not in <linux/mutex.h>. This didn't cause a problem until
checkin 3a2d367d9aabac486ac4444c6c7ec7a1dab16267 added the
atomic_dec_and_mutex_lock() inline in between declaration and
definion.
This broke build... | ```diff
diff --git a/kernel/mutex.c b/kernel/mutex.c
index 5d79781394a3..fd95eaa672e6 100644
--- a/kernel/mutex.c
+++ b/kernel/mutex.c
@@ -89,7 +89,7 @@ __mutex_lock_slowpath(atomic_t *lock_count);
*
* This function is similar to (but not equivalent to) down().
*/
-void inline __sched mutex_lock(struct mutex *loc... |
3ab8d792b1348eaabfe550ba60902d781d160dd4 | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: fix event_id type | Problem Details:
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
index 7bf2a516f18b..7bfb0f0d8005 100644
--- a/Documentation/perf_counter/kerneltop.c
+++ b/Documentation/perf_counter/kerneltop.c
@@ -99,7 +99,7 @@ static int run_perfstat = 0;
static int system_wide = 0;
... |
ef45fa9e6c1694d3e8063f39749097a6e496b12c | Analyze and fix the following issue in the Linux kernel code: perf_counter tools: fix comment for sym_weight() | Problem Details:
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
index 9db65a4f1042..7bf2a516f18b 100644
--- a/Documentation/perf_counter/kerneltop.c
+++ b/Documentation/perf_counter/kerneltop.c
@@ -473,7 +473,7 @@ static struct sym_entry sym_table[MAX_SYMS];
static void show_detai... |
9aaa131a279834dff75c290c91f0058f62d72d46 | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix type/event_id layout on big-endian systems | Problem Details:
Impact: build fix for powerpc
Commit db3a944aca35ae61 ("perf_counter: revamp syscall input ABI")
expanded the hw_event.type field into a union of structs containing
bitfields. In particular it introduced a type field and a raw_type
field, with the intention that the 1-bit raw_type field should
overla... | ```diff
diff --git a/arch/powerpc/kernel/perf_counter.c b/arch/powerpc/kernel/perf_counter.c
index 830ca9c4494c..6413d9c0313b 100644
--- a/arch/powerpc/kernel/perf_counter.c
+++ b/arch/powerpc/kernel/perf_counter.c
@@ -602,12 +602,13 @@ hw_perf_counter_init(struct perf_counter *counter)
return NULL;
if ((s64)count... |
e077df4f439681e43f0db8255b2d215b342ebdc6 | Analyze and fix the following issue in the Linux kernel code: perf_counter: hook up the tracepoint events | Problem Details:
Impact: new perfcounters feature
Enable usage of tracepoints as perf counter events.
tracepoint event ids can be found in /debug/tracing/event/*/*/id
and (for now) are represented as -65536+id in the type field.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.... | ```diff
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 08c11a6afebc..065984c1ff57 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -53,6 +53,8 @@ enum hw_event_types {
PERF_COUNT_PAGE_FAULTS_MAJ = -7,
PERF_SW_EVENTS_MIN = -8,
+
+ PERF_TP_EVENTS_MIN ... |
f16009527595ee562308653bc3d0039166d2ab15 | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix up counter free paths | Problem Details:
Impact: fix crash during perfcounters use
I found another counter free path, create a free_counter() call to
accomodate generic tear-down.
Fixes an RCU bug.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Orig-LKML... | ```diff
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index 99d5930f0a52..97f891ffeb40 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -1150,6 +1150,11 @@ static void free_counter_rcu(struct rcu_head *head)
kfree(counter);
}
+static void free_counter(struct perf_counter *counter)
+{
... |
01ef09d9ffb5ce9f8d62d1e5206da3d5ca612acc | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix uninitialized usage of event_list | Problem Details:
Impact: fix boot crash
When doing the generic context switch event I ran into some early
boot hangs, which were caused by inf func recursion (event, fault,
event, fault).
I eventually tracked it down to event_list not being initialized
at the time of the first event. Fix this.
Signed-off-by: Peter Z... | ```diff
diff --git a/include/linux/init_task.h b/include/linux/init_task.h
index 219748d00262..ca226a91abee 100644
--- a/include/linux/init_task.h
+++ b/include/linux/init_task.h
@@ -124,6 +124,8 @@ extern struct cred init_cred;
# define INIT_PERF_COUNTERS(tsk) \
.perf_counter_ctx.counter_list = \
LIST_HEA... |
b6c5a71da1477d261bc36254fe1f20d32b57598d | Analyze and fix the following issue in the Linux kernel code: perf_counter: abstract wakeup flag setting in core to fix powerpc build | Problem Details:
Impact: build fix for powerpc
Commit bd753921015e7905 ("perf_counter: software counter event
infrastructure") introduced a use of TIF_PERF_COUNTERS into the core
perfcounter code. This breaks the build on powerpc because we use
a flag in a per-cpu area to signal wakeups on powerpc rather than
a threa... | ```diff
diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index b43076ff92c9..cb32d571c9c7 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -142,10 +142,17 @@ static inline unsigned long get_perf_counter_pending(void)
return x;
}
-static inl... |
7bb497bd885eedd0f56dfe3cc1b5ff20710d33b9 | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix crash on perfmon v1 systems | Problem Details:
Impact: fix boot crash on Intel Perfmon Version 1 systems
Intel Perfmon v1 does not support the global MSRs, nor does
it offer the generalized MSR ranges. So support v2 and later
CPUs only.
Also mark pmc_ops as read-mostly - to avoid false cacheline
sharing.
Cc: Paul Mackerras <paulus@samba.org>
Cc:... | ```diff
diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index 22dab06c08a4..6cba9d47b711 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -57,12 +57,14 @@ struct pmc_x86_ops {
int max_events;
};
-static struct pmc_x86_ops *pmc_ops;
+s... |
4e193bd4dfdc983d12969b51439b4a1fbaf2daad | Analyze and fix the following issue in the Linux kernel code: perf_counter: include missing header | Problem Details:
Impact: build fix
In order to compile a kernel with performance counter patches,
<asm/irq_regs.h> has to be included to provide the declaration of
struct pt_regs *get_irq_regs(void);
[ This bug was masked by unrelated x86 header file changes in the
x86 tree, but occurs in the tip:perfcounters/core ... | ```diff
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index d6cc22271ef4..0018c5e81249 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -24,6 +24,8 @@
#include <linux/vmstat.h>
#include <linux/rculist.h>
+#include <asm/irq_regs.h>
+
/*
* Each CPU has a list of per CPU counters:
*/... |
039fc91e064b81c2820ff16c304be5aba35fd126 | Analyze and fix the following issue in the Linux kernel code: perf_counter: fix hrtimer sampling | Problem Details:
Impact: fix deadlock with perfstat
Fix for the perfstat fubar..
We cannot unconditionally call hrtimer_cancel() without ever having done
hrtimer_init() on the thing.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Orig-LKML-Reference: <1236959027.22447.149.camel@twins>
Signed-off-by: Ingo Mol... | ```diff
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index 8d6ecfa64c0e..d6cc22271ef4 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -1571,9 +1571,9 @@ static int cpu_clock_perf_counter_enable(struct perf_counter *counter)
int cpu = raw_smp_processor_id();
atomic64_set(&hwc->prev_... |
82bae4f8c2fd64a2bb1e2e72c508853ed2b4a299 | Analyze and fix the following issue in the Linux kernel code: perf_counter: x86: use ULL postfix for 64bit constants | Problem Details:
Fix a build warning on 32bit machines by explicitly marking the
constants as 64-bit.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index a2e3b76bfdc1..22dab06c08a4 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -84,9 +84,9 @@ static u64 pmc_intel_event_map(int event)
static u64 pmc_intel_raw_event(u64 event)
... |
595258aaeac4cc6e187b98b1bf29bb176febe763 | Analyze and fix the following issue in the Linux kernel code: perf_counter: x86: fix 32-bit irq_period assumption | Problem Details:
No need to assume the irq_period is 32bit.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
index 155bc3c239b6..1cedc3468ce5 100644
--- a/arch/x86/kernel/cpu/perf_counter.c
+++ b/arch/x86/kernel/cpu/perf_counter.c
@@ -449,7 +449,7 @@ __hw_perf_counter_set_period(struct perf_counter *counter,
struct hw_perf_co... |
1661c6155589f8faa1338f3cda696ea3f4cb2da1 | Analyze and fix the following issue in the Linux kernel code: ALSA: opl3sa2: add ZV port control | Problem Details:
Add ZV port control switch.
This patch is done after solution
given in the ALSA bug #2872 report.
The patch resolves the issue.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/isa/opl3sa2.c b/sound/isa/opl3sa2.c
index ef95279da7a3..0481a55334b9 100644
--- a/sound/isa/opl3sa2.c
+++ b/sound/isa/opl3sa2.c
@@ -481,6 +481,7 @@ OPL3SA2_DOUBLE_TLV("Master Playback Volume", 0, 0x07, 0x08, 0, 0, 15, 1,
OPL3SA2_SINGLE("Mic Playback Switch", 0, 0x09, 7, 1, 1),
OPL3SA2_SINGL... |
1bab88b2310998de18b32529a27ea835d164254a | Analyze and fix the following issue in the Linux kernel code: net/9p: handle correctly interrupted 9P requests | Problem Details:
Currently the 9p code crashes when a operation is interrupted, i.e. for
example when the user presses ^C while reading from a file.
This patch fixes the code that is responsible for interruption and flushing
of 9P operations.
Signed-off-by: Latchesar Ionkov <lucho@ionkov.net> | ```diff
diff --git a/include/net/9p/client.h b/include/net/9p/client.h
index 4012e07162e5..e26812274b75 100644
--- a/include/net/9p/client.h
+++ b/include/net/9p/client.h
@@ -98,7 +98,6 @@ enum p9_req_status_t {
struct p9_req_t {
int status;
int t_err;
- u16 flush_tag;
wait_queue_head_t *wq;
struct p9_fcall *t... |
6d208da89aabee8502debe842832ca0ab298d16d | Analyze and fix the following issue in the Linux kernel code: audit: Fix possible return value truncation in audit_get_context() | Problem Details:
The audit subsystem treats syscall return codes as type long, unfortunately
the audit_get_context() function mistakenly converts the return code to an
int type in the parameters which could cause problems on systems where the
sizeof(int) != sizeof(long).
Signed-off-by: Paul Moore <paul.moore@hp.com>
S... | ```diff
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index b344b86557a2..e821d626dfe6 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -752,7 +752,7 @@ static void audit_set_auditable(struct audit_context *ctx)
static inline struct audit_context *audit_get_context(struct task_struct *tsk,
int... |
b3897f567100d18e0597f638b911d23aa5e0dd23 | Analyze and fix the following issue in the Linux kernel code: Audit: fix handling of 'strings' with NULL characters | Problem Details:
currently audit_log_n_untrustedstring() uses audit_string_contains_control()
to check if the 'string' has any control characters. If the 'string' has an
embedded NULL audit_string_contains_control() will return that the data has
no control characters and will then pass the string to audit_log_n_string... | ```diff
diff --git a/kernel/audit.c b/kernel/audit.c
index ce6d8ea3131e..fa3805516dff 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1382,7 +1382,7 @@ void audit_log_n_string(struct audit_buffer *ab, const char *string,
int audit_string_contains_control(const char *string, size_t len)
{
const unsigned char *p... |
6b96255998053a89f45c0855de954b71f5c3887b | Analyze and fix the following issue in the Linux kernel code: auditsc: fix kernel-doc notation | Problem Details:
Fix auditsc kernel-doc notation:
Warning(linux-2.6.28-git7//kernel/auditsc.c:2156): No description found for parameter 'attr'
Warning(linux-2.6.28-git7//kernel/auditsc.c:2156): Excess function parameter 'u_attr' description in '__audit_mq_open'
Warning(linux-2.6.28-git7//kernel/auditsc.c:2204): No des... | ```diff
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 738c03695b79..b344b86557a2 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -2149,7 +2149,7 @@ int audit_set_loginuid(struct task_struct *task, uid_t loginuid)
* __audit_mq_open - record audit data for a POSIX MQ open
* @oflag: open flag
* @mod... |
e44543b83bf4ab84dc6bd5b88158c78b1ed1c208 | Analyze and fix the following issue in the Linux kernel code: ext4: Fix off-by-one-error in ext4_valid_extent_idx() | Problem Details:
Signed-off-by: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> | ```diff
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ac77d8b8251d..6132353dcf62 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -342,7 +342,7 @@ static int ext4_valid_extent_idx(struct inode *inode,
ext4_fsblk_t block = idx_pblock(ext_idx);
struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s... |
f73953c0656f2db9073c585c4df2884a8ecd101e | Analyze and fix the following issue in the Linux kernel code: ext4: Fix big-endian problem in __ext4_check_blockref() | Problem Details:
Commit fe2c8191 introduced a regression on big-endian system, because
the checks to make sure block references in non-extent inodes are
valid failed to use le32_to_cpu().
Reported-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Tested-by: Alexander ... | ```diff
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index a2e7952bc5f9..c6bd6ced3bb7 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -372,16 +372,16 @@ static int ext4_block_to_path(struct inode *inode,
}
static int __ext4_check_blockref(const char *function, struct inode *inode,
- unsigned int *p, uns... |
5d4d9e8ad6c646c4811bf0049df761dee6affc3d | Analyze and fix the following issue in the Linux kernel code: b44: Fix sizes passed to b44_sync_dma_desc_for_{device,cpu}() | Problem Details:
> > ------------[ cut here ]------------
> > WARNING: at lib/dma-debug.c:539 check_sync+0xe9/0x341() (Not tainted)
> > Hardware name: HP Compaq nx6110 (PY501EA#AB9)
> > b44 0000:02:0e.0: DMA-API: device driver tries to sync DMA memory it has not
> > allocated [device address=0x0000000075941040] [size=1... | ```diff
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 5c84541e0737..95698c6db50f 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -703,7 +703,7 @@ static int b44_alloc_rx_skb(struct b44 *bp, int src_idx, u32 dest_idx_unmasked)
if (bp->flags & B44_FLAG_RX_RING_HACK)
b44_sync_dma_desc_for_devic... |
81c522851436dbc058c9c0c11b32e60d76b180ce | Analyze and fix the following issue in the Linux kernel code: e1000: fix loss of multicast packets | Problem Details:
e1000 (and e1000e, igb, ixgbe, ixgb) all do a series of
operations each time a multicast address is added. The flow goes
something like
1) stack adds one multicast address
2) stack passes whole current list of unicast and multicast
addresses to driver
3) driver clears entire list in hardware
4) dr... | ```diff
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 93b861d032b5..a65023d772cb 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -2335,6 +2335,12 @@ static void e1000_set_rx_mode(struct net_device *netdev)
int mta_reg_count = (hw->mac_type == e1... |
2b05e0021b21e1dc484a1237b7fa674e8a3704bb | Analyze and fix the following issue in the Linux kernel code: vxge: should include tcp.h | Problem Details:
Fix this build error:
drivers/net/vxge/vxge-main.c: In function 'vxge_get_vpath_no':
drivers/net/vxge/vxge-main.c:695: error: dereferencing pointer to
incomplete type
...
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 61ef16118157..b7f08f3e524b 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -43,6 +43,7 @@
#include <linux/if_vlan.h>
#include <linux/pci.h>
+#include <linux/tcp.h>
#include <net/ip.h>
#include <l... |
fa15ce8ad59e9653d50b8596596cb02d3566d4aa | Analyze and fix the following issue in the Linux kernel code: mfd: fix da903x warning | Problem Details:
The da903x interrupt handler is retruning an int instead of an irqreturn_t.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> | ```diff
diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
index 99f8dcfe3d98..7283d88656af 100644
--- a/drivers/mfd/da903x.c
+++ b/drivers/mfd/da903x.c
@@ -413,7 +413,7 @@ static void da903x_irq_work(struct work_struct *work)
enable_irq(chip->client->irq);
}
-static int da903x_irq_handler(int irq, void *dat... |
895d9f0f15ff6b2d20bfbdc2b8205d1791437294 | Analyze and fix the following issue in the Linux kernel code: mfd: fix MAINTAINERS entry | Problem Details:
The MFD git repo is living on kernel.org, and patches should be sent at
sameo@linux.intel.com.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index 6360b9b9bbbd..587bc8bd6f73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3034,8 +3034,9 @@ S: Maintained
MULTIFUNCTION DEVICES (MFD)
P: Samuel Ortiz
-M: sameo@openedhand.com
+M: sameo@linux.intel.com
L: linux-kernel@vger.kernel.org
+T: git kernel.org:/pub/scm/l... |
01ab10393c510342ec4ce85df11ccfa3df06bbb2 | Analyze and fix the following issue in the Linux kernel code: sh: Fix up DSP context save/restore. | Problem Details:
There were a number of issues with the DSP context save/restore code,
mostly left-over relics from when it was introduced on SH3-DSP with
little follow-up testing, resulting in things like task_pt_dspregs()
referencing incorrect state on the stack.
This follows the MIPS convention of tracking the DSP ... | ```diff
diff --git a/arch/sh/include/asm/processor_32.h b/arch/sh/include/asm/processor_32.h
index efdd78a53b11..9a8714945dc9 100644
--- a/arch/sh/include/asm/processor_32.h
+++ b/arch/sh/include/asm/processor_32.h
@@ -57,6 +57,14 @@ asmlinkage void __init sh_cpu_init(void);
#define SR_IMASK 0x000000f0
#define SR_FD ... |
a27873cd234b4248dda342721d6262943e5fa235 | Analyze and fix the following issue in the Linux kernel code: sh: Fix up number of on-chip DMA channels on SH7091. | Problem Details:
This accidentally regressed when the multi-IRQ changes went in,
switching SH7091 from 4 to 6 channels. Add SH7091 back in to the
4-channel dependency list.
Reported-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org> | ```diff
diff --git a/arch/sh/drivers/dma/Kconfig b/arch/sh/drivers/dma/Kconfig
index f13a05285a9d..666713ac5fcf 100644
--- a/arch/sh/drivers/dma/Kconfig
+++ b/arch/sh/drivers/dma/Kconfig
@@ -12,21 +12,25 @@ config SH_DMA
config SH_DMA_IRQ_MULTI
bool
depends on SH_DMA
- default y if CPU_SUBTYPE_SH7750 || CPU_SUBTYP... |
924b6231edfaf1e764ffb4f97ea382bf4facff58 | Analyze and fix the following issue in the Linux kernel code: intel-iommu: Fix device-to-iommu mapping for PCI-PCI bridges. | Problem Details:
When the DMAR table identifies that a PCI-PCI bridge belongs to a given
IOMMU, that means that the bridge and all devices behind it should be
associated with the IOMMU. Not just the bridge itself.
This fixes the device_to_iommu() function accordingly.
(It's broken if you have the same PCI bus numbers... | ```diff
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index f3eebd2b2d72..6262c198e56e 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -477,11 +477,16 @@ static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn)
if (drhd->ignored)
continue;
- for (i = 0; i < d... |
d0b03bd1c6725a3463290d7f9626e4b583518a5a | Analyze and fix the following issue in the Linux kernel code: x2apic/intr-remap: decouple interrupt remapping from x2apic | Problem Details:
interrupt remapping must be enabled before enabling x2apic, but
interrupt remapping doesn't depend on x2apic, it can be used
separately. Enable interrupt remapping in init_dmars even x2apic
is not supported.
[dwmw2: Update Kconfig accordingly, fix build with INTR_REMAP && !X2APIC]
Signed-off-by: Weid... | ```diff
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 3f27e5c0c9c9..229cf611d6ff 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -251,6 +251,7 @@ config SMP
config X86_X2APIC
bool "Support x2apic"
depends on X86_LOCAL_APIC && X86_64
+ select INTR_REMAP
---help---
This enables x2apic support ... |
c07c9a78a95cab0a9bf0b253d0c52e7798af38c5 | Analyze and fix the following issue in the Linux kernel code: video: build fix | Problem Details:
acpi_video_device_write_state() and friends now return ssize_t,
while the constify patch assumed it was still int.
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 52779549d367..0e7e689634a7 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -217,7 +217,7 @@ static const struct file_operations acpi_video_bus_POST_info_fops = {
};
static int acpi_video_bus_POST_open_fs(struct inode *inode, stru... |
0e501834f8c2ba7de2a56e332d346dcf4ac0b593 | Analyze and fix the following issue in the Linux kernel code: thinkpad-acpi: rework brightness support | Problem Details:
Refactor and redesign the brightness control backend...
In order to fix bugzilla #11750...
Add a new brightness control mode: support direct NVRAM checkpointing
of the backlight level (i.e. store directly to NVRAM without the need
for UCMS calls), and use that together with the EC-based control.
Disa... | ```diff
diff --git a/Documentation/laptops/thinkpad-acpi.txt b/Documentation/laptops/thinkpad-acpi.txt
index 25ed43d0a21f..3d7650768bb5 100644
--- a/Documentation/laptops/thinkpad-acpi.txt
+++ b/Documentation/laptops/thinkpad-acpi.txt
@@ -1157,10 +1157,15 @@ display backlight brightness control methods have 16 levels, ... |
73a94d86a8625371f76de0ee12dc5bacd3ed42c0 | Analyze and fix the following issue in the Linux kernel code: thinkpad-acpi: add new debug helpers and warn of deprecated atts | Problem Details:
Add a debug helper that discloses the TGID of the userspace task
attempting to access the driver. This is highly useful when dealing
with bug reports, since often the user has no idea that some userspace
application is accessing thinkpad-acpi...
Also add a helper to log warnings about sysfs attribute... | ```diff
diff --git a/Documentation/laptops/thinkpad-acpi.txt b/Documentation/laptops/thinkpad-acpi.txt
index f6e6bc66eed3..e8f52fbadfe0 100644
--- a/Documentation/laptops/thinkpad-acpi.txt
+++ b/Documentation/laptops/thinkpad-acpi.txt
@@ -1484,6 +1484,8 @@ will enable all debugging output classes. It takes a bitmask, ... |
3dcc2c3b00cad01a0e3667607f8644e891e4dc8b | Analyze and fix the following issue in the Linux kernel code: thinkpad-acpi: cleanup debug helpers | Problem Details:
Fix the vdbg_printk macro definition to be sane when
CONFIG_THINKPAD_ACPI_DEBUG is undefined, and move the mess into a file
section of its own.
This doesn't change anything in the current code, but future code will
need the proper behaviour.
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>... | ```diff
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index c83ec94eb8d9..3367df9d4f99 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -184,17 +184,6 @@ enum {
#define TPACPI_DBG_ALL 0xffff
#define TPACPI_DBG_INIT 0x0001
#de... |
c542aadeb4700bc316834d862d52ba3d2664f13a | Analyze and fix the following issue in the Linux kernel code: panasonic-laptop: Fix autoloading | Problem Details:
This patch adds MODULE_DEVICE_TABLE() to panasonic-laptop.c in order
to ensure automatic loading of the module on systems with the respective
"MAT*" ACPI devices.
Signed-off-by: Martin Lucina <mato@kotelna.sk>
Signed-off-by: Harald Welte <laforge@gnumonks.org>
Signed-off-by: Len Brown <len.brown@intel... | ```diff
diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
index c47a44dcb702..ecaca412a2a1 100644
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -184,6 +184,7 @@ static const struct acpi_device_id pcc_device_ids[] = {
{ "MAT0... |
50f6bb0ab75794ad02cb5db503cc8c99465ceaf4 | Analyze and fix the following issue in the Linux kernel code: [ARM] pxa/cm-x2xx: fix ucb1400 not being registered | Problem Details:
This patch fixes cm-x2xx not registering the ucb1400. This is
because of the splitting of ucb1400 driver half year ago.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
Signed-off-by: Eric Miao <eric.miao@marvell.com> | ```diff
diff --git a/arch/arm/mach-pxa/cm-x2xx.c b/arch/arm/mach-pxa/cm-x2xx.c
index 117b5435f8d5..b50ef39eabfc 100644
--- a/arch/arm/mach-pxa/cm-x2xx.c
+++ b/arch/arm/mach-pxa/cm-x2xx.c
@@ -121,7 +121,7 @@ static inline void cmx2xx_init_dm9000(void) {}
/* UCB1400 touchscreen controller */
#if defined(CONFIG_TOUCHSCR... |
6328a57401dc5f5cf9931738eb7268fcd8058c49 | Analyze and fix the following issue in the Linux kernel code: Enable PNPACPI _PSx Support, v3 | Problem Details:
(This is an update to the patch presented earlier in
http://lkml.org/lkml/2008/12/8/284, with new error handling.)
This patch sets the power of PnP ACPI devices to D0 when they
are activated and to D3 when they are disabled. The latter is
in correspondence with the ACPI 3.0 specification, whereas the... | ```diff
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index 2834846a185d..9a3a682c6981 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -83,7 +83,6 @@ static int pnpacpi_set_resources(struct pnp_dev *dev)
acpi_handle handle = dev->data;
struct acpi_buffer buffer;
... |
38eb76a54d803e6792816623651b1a9cb85f8d01 | Analyze and fix the following issue in the Linux kernel code: nfsd41: Add a create session replay cache | Problem Details:
Replace the nfs4_client cl_seqid field with a single struct nfs41_slot used
for the create session replay cache.
The CREATE_SESSION slot sets the sl_session pointer to NULL. Otherwise, the
slot and it's replay cache are used just like the session slots.
Fix unconfirmed create_session replay response ... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 463ae39df148..58f9797eb09e 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -649,6 +649,8 @@ static inline void
free_client(struct nfs4_client *clp)
{
shutdown_callback_client(clp);
+ nfsd4_release_respages(clp->cl_slot.sl_cache_entry... |
ec6b5d7b5064fde27aee798b81107ea3a830de85 | Analyze and fix the following issue in the Linux kernel code: nfsd41: create_session operation | Problem Details:
Implement the create_session operation confoming to
http://tools.ietf.org/html/draft-ietf-nfsv4-minorversion1-26
Look up the client id (generated by the server on exchange_id,
given by the client on create_session).
If neither a confirmed or unconfirmed client is found
then the client id is stale
If a... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index f25a7d2a9fac..463ae39df148 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -68,6 +68,7 @@ static u32 current_delegid = 1;
static u32 nfs4_init;
static stateid_t zerostateid; /* bits all 0 */
static stateid_t onestateid; ... |
c3d06f9ce8544fecfe13e377d1e2c2e47fe18dbc | Analyze and fix the following issue in the Linux kernel code: nfsd41: hard page limit for DRC | Problem Details:
Use no more than 1/128th of the number of free pages at nfsd startup for the
v4.1 DRC.
This is an arbitrary default which should probably end up under the control
of an administrator.
Signed-off-by: Andy Adamson <andros@netapp.com>
[moved added fields in struct svc_serv under CONFIG_NFSD_V4_1]
Signed... | ```diff
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index b5168d1898ec..b53a098e97a4 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -22,6 +22,7 @@
#include <linux/freezer.h>
#include <linux/fs_struct.h>
#include <linux/kthread.h>
+#include <linux/swap.h>
#include <linux/sunrpc/types.h>
#include <li... |
074fe897536f095309c5aaffcf912952882ab2cb | Analyze and fix the following issue in the Linux kernel code: nfsd41: DRC save, restore, and clear functions | Problem Details:
Cache all the result pages, including the rpc header in rq_respages[0],
for a request in the slot table cache entry.
Cache the statp pointer from nfsd_dispatch which points into rq_respages[0]
just past the rpc header. When setting a cache entry, calculate and save the
length of the nfs data minus the... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 9243dca3576c..a37b91dab1bf 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -852,6 +852,148 @@ out_err:
return;
}
+void
+nfsd4_set_statp(struct svc_rqst *rqstp, __be32 *statp)
+{
+ struct nfsd4_compoundres *resp = rqstp->rq_resp;
+
+... |
0733d21338747483985a5964e852af160d88e429 | Analyze and fix the following issue in the Linux kernel code: nfsd41: exchange_id operation | Problem Details:
Implement the exchange_id operation confoming to
http://tools.ietf.org/html/draft-ietf-nfsv4-minorversion1-28
Based on the client provided name, hash a client id.
If a confirmed one is found, compare the op's creds and
verifier. If the creds match and the verifier is different
then expire the old cli... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index cfc01f415d15..4f963e902972 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -832,12 +832,152 @@ out_err:
return;
}
+/*
+ * Set the exchange_id flags returned by the server.
+ */
+static void
+nfsd4_set_ex_flags(struct nfs4_client *ne... |
c4bf7868064ce8b9c75d8049d077e593c20602b3 | Analyze and fix the following issue in the Linux kernel code: nfsd41: release_session when client is expired | Problem Details:
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
[add CONFIG_NFSD_V4_1 to fix v4.0 regression bug]
Signed-off-by: Andy Adamson <andros@netapp.com>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index b2611999600a..f23385b13065 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -511,6 +511,12 @@ expire_client(struct nfs4_client *clp)
sop = list_entry(clp->cl_openowners.next, struct nfs4_stateowner, so_perclient);
release_openowner(... |
c5c67c7cba6a652d1c62dce45b0c130e5cb2a802 | Analyze and fix the following issue in the Linux kernel code: x86, mtrr: remove debug message | Problem Details:
The MTRR code grew a new debug message which triggers commonly:
[ 40.142276] get_mtrr: cpu0 reg00 base=0000000000 size=0000080000 write-back
[ 40.142280] get_mtrr: cpu0 reg01 base=0000080000 size=0000040000 write-back
[ 40.142284] get_mtrr: cpu0 reg02 base=0000100000 size=0000040000 write-... | ```diff
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index 37f28fc7cf95..0b776c09aff3 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -462,9 +462,6 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
*base = base_hi... |
19be358212af35bd64d449da82279874099a1a85 | Analyze and fix the following issue in the Linux kernel code: Staging: serqt_usb: fix build due to proc tty changes | Problem Details:
Just delete the proc tty usage in the driver as it's not needed and will
go away when it switches over to a usb-serial driver. This fixes the
build error in the driver.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/serqt_usb/serqt_usb.c b/drivers/staging/serqt_usb/serqt_usb.c
index 3b73c782e3c9..1781510c53fd 100644
--- a/drivers/staging/serqt_usb/serqt_usb.c
+++ b/drivers/staging/serqt_usb/serqt_usb.c
@@ -288,8 +288,6 @@ static void serial_throttle(struct tty_struct *tty);
static void serial_... |
2961f24f78f456a0a2d0dada56ee795232fe21b3 | Analyze and fix the following issue in the Linux kernel code: Staging: BUG to BUG_ON changes | Problem Details:
Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 3e397d01ccce..6e13e450dc73 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
@@ -544,8 +544,7 @@ unsigned int comedi_buf_munge(struct comedi_async *async, unsigned int num_bytes
if (s->m... |
bbe364ddedd84ee5a4bec65fa0ca56caf09d6802 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix build error, select SND_RAWMIDI | Problem Details:
line6 needs to select SND_RAWMIDI, like many other drivers do.
ERROR: "snd_rawmidi_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_rawmidi_new" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_rawmidi_transmit_peek" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "s... | ```diff
diff --git a/drivers/staging/line6/Kconfig b/drivers/staging/line6/Kconfig
index 84f5be71ccff..7852d4a960c5 100644
--- a/drivers/staging/line6/Kconfig
+++ b/drivers/staging/line6/Kconfig
@@ -1,6 +1,7 @@
config LINE6_USB
tristate "Line6 USB support"
depends on USB && SND
+ select SND_RAWMIDI
help
This... |
9cd57f777724b941cd2e22a7124be7c09bb3132b | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in variax.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index f25493dde797..f9d96984733a 100644
--- a/drivers/staging/line6/variax.c
+++ b/drivers/staging/line6/variax.c
@@ -46,9 +46,10 @@ static const char variax_request_model2[] = {
/*
Decode data transmitted by workbench.
*/
-static ... |
6353773b5230514d4f1d3dc98a84a72e3a954e87 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in toneport.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/toneport.c b/drivers/staging/line6/toneport.c
index d894f4851ef2..eaa1229002aa 100644
--- a/drivers/staging/line6/toneport.c
+++ b/drivers/staging/line6/toneport.c
@@ -75,34 +75,43 @@ static struct line6_pcm_properties toneport_pcm_properties = {
/*
For the led on Guitarp... |
68dc3dde0213c0560b6117998088f3e992934d37 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in pcm.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 489d398e65bb..fc4113f33159 100644
--- a/drivers/staging/line6/pcm.c
+++ b/drivers/staging/line6/pcm.c
@@ -34,12 +34,13 @@ int snd_line6_trigger(struct snd_pcm_substream *substream, int cmd)
clear_bit(BIT_PREPARED, &line6pcm->flags);
... |
ce9b490cbf1cffa988fce64e6ff824bdd241d87e | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in midibuf.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/midibuf.c b/drivers/staging/line6/midibuf.c
index 5726bb148a5a..ab0a5f30fbca 100644
--- a/drivers/staging/line6/midibuf.c
+++ b/drivers/staging/line6/midibuf.c
@@ -18,18 +18,19 @@
static int midibuf_message_length(unsigned char code)
{
- if(code < 0x80)
+ if (code < 0x80)
... |
d7e3733619a612ffabced37c878b9d30f060ff69 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in midi.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/midi.c b/drivers/staging/line6/midi.c
index f72681963e44..89a2b17e9caf 100644
--- a/drivers/staging/line6/midi.c
+++ b/drivers/staging/line6/midi.c
@@ -26,19 +26,23 @@
#define OUTPUT_DUMP_ONLY 0
-#define line6_rawmidi_substream_midi(substream) ((struct snd_line6_midi *)((... |
766f9d20a1b1fcf5c84b3eb1d96f35a4d882cdeb | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in dumprequest.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/dumprequest.c b/drivers/staging/line6/dumprequest.c
index 89bc0994d07b..decbaa971b68 100644
--- a/drivers/staging/line6/dumprequest.c
+++ b/drivers/staging/line6/dumprequest.c
@@ -42,13 +42,15 @@ void line6_dump_finished(struct line6_dump_request *l6dr)
/*
Send an asynchron... |
36445bc118848df0eed1e2da400b2b66041a2c9c | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in driver.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index 0484ee60778d..85a20d0002c0 100644
--- a/drivers/staging/line6/driver.c
+++ b/drivers/staging/line6/driver.c
@@ -50,7 +50,7 @@ static struct usb_device_id line6_id_table[] = {
{ USB_DEVICE(LINE6_VENDOR_ID, LINE6_DEVID_VARIAX) },... |
dfc70567d76b9d506855fd5b334a4dd0ebdf1aa7 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in audio.c | Problem Details:
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/audio.c b/drivers/staging/line6/audio.c
index 37f759a76158..3aa946899ced 100644
--- a/drivers/staging/line6/audio.c
+++ b/drivers/staging/line6/audio.c
@@ -25,12 +25,12 @@ static char *line6_id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
*/
int line6_init_audio(struct usb_line6 *line6... |
0fdef36aca8a2900d3a5c113f6973d84cf38d7b7 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in pod.c | Problem Details:
2 errors left, but they are minor.
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 614e9dc2ad19..fa5caa245d85 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
@@ -113,7 +113,7 @@ static struct line6_pcm_properties pod_pcm_properties = {
static const char pod_request_version[] = { 0xf0, 0x... |
010f378e8c839a03f7741c95791a7b9980a9cdc2 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in playback.c | Problem Details:
2 errors left, but they are minor.
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/playback.c b/drivers/staging/line6/playback.c
index 34cfbdbb15a2..acb06126a6a5 100644
--- a/drivers/staging/line6/playback.c
+++ b/drivers/staging/line6/playback.c
@@ -24,30 +24,31 @@
/*
Software stereo volume control.
*/
-static void change_volume(struct urb *urb_out, int... |
6efc5667ef588df7156e1c481383f8dbff4fa409 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix checkpatch errors in capture.c | Problem Details:
2 errors left, but they are minor.
Lots of warnings also fixed up.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c
index d6c1d1a70459..8393e25a10b1 100644
--- a/drivers/staging/line6/capture.c
+++ b/drivers/staging/line6/capture.c
@@ -35,7 +35,7 @@ static int submit_audio_in_urb(struct snd_pcm_substream *substream)
spin_lock_irqsave(&line6pcm->... |
536165d8ef6933131bf7166338eafa77b75f8bb7 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix up NULL assignment mistakes | Problem Details:
Should use NULL for a pointer, not 0, otherwise sparse complains.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/audio.c b/drivers/staging/line6/audio.c
index d035420c7bfb..37f759a76158 100644
--- a/drivers/staging/line6/audio.c
+++ b/drivers/staging/line6/audio.c
@@ -62,10 +62,10 @@ void line6_cleanup_audio(struct usb_line6 *line6)
{
struct snd_card *card = line6->card;
- if(card =... |
b702ed253d33d056987e92299687d8ed85195896 | Analyze and fix the following issue in the Linux kernel code: Staging: line6: static function cleanups | Problem Details:
This fixes all of the static function warnings that sparse complains
about.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/audio.c b/drivers/staging/line6/audio.c
index f6ad27412797..d035420c7bfb 100644
--- a/drivers/staging/line6/audio.c
+++ b/drivers/staging/line6/audio.c
@@ -10,6 +10,7 @@
*/
#include "driver.h"
+#include "audio.h"
#include <sound/core.h>
#include <sound/initval.h>
diff... |
4717b03b56fedd1c44fe6a0701cd4e36e97efbab | Analyze and fix the following issue in the Linux kernel code: Staging: line6: fix bus_id usage | Problem Details:
bus_id is now gone in the linux-next tree, so replace it with dev_name()
so the code works properly.
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/line6/audio.c b/drivers/staging/line6/audio.c
index e15fa1f6ee48..f6ad27412797 100644
--- a/drivers/staging/line6/audio.c
+++ b/drivers/staging/line6/audio.c
@@ -36,7 +36,8 @@ int line6_init_audio(struct usb_line6 *line6)
strcpy(card->driver, DRIVER_NAME);
strcpy(card->shortna... |
c4739ea63c56928103bc1748c6d9b1df5d815a02 | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix some sparse warnings | Problem Details:
This resolves a lot of the more obvious sparse warnings in the code.
There still are some major problems in the ioctl handlers dealing with
user and kernel pointers that this patch does not resolve, that needs to
be addressed still.
Also, the locking seems to be a bit strange in places, which sparse
... | ```diff
diff --git a/drivers/staging/heci/heci.h b/drivers/staging/heci/heci.h
index 9b279f3e84a1..14192e0cc227 100644
--- a/drivers/staging/heci/heci.h
+++ b/drivers/staging/heci/heci.h
@@ -124,12 +124,12 @@ void heci_wd_timer(unsigned long data);
* input output function prototype
*/
int heci_ioctl_get_version(s... |
bc154a3862260ef8d83ff750daa1b6cfbfa129cc | Analyze and fix the following issue in the Linux kernel code: Staging: heci: fix checkpatch warnings | Problem Details:
This resolves the outstanding scripts/checkpatch.pl warnings
Cc: Anas Nashif <anas.nashif@intel.com>
Cc: Marcin Obara <marcin.obara@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/heci/heci_main.c b/drivers/staging/heci/heci_main.c
index 6782fe9f785a..3db9a0388645 100644
--- a/drivers/staging/heci/heci_main.c
+++ b/drivers/staging/heci/heci_main.c
@@ -175,7 +175,7 @@ static struct pci_driver heci_driver = {
/*
* file operations structure will be use heci c... |
0f386e2b4c6109164e82277513a9570fc9ec644c | Analyze and fix the following issue in the Linux kernel code: Staging: p9auth: fix up sparse warnings | Problem Details:
Everything needs to be static, as sparse complains and you don't want to
polute the global kernel symbol namespace. So mark everything as such
and move one function around to prevent a forward declaration from being
needed.
Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <... | ```diff
diff --git a/drivers/staging/p9auth/p9auth.c b/drivers/staging/p9auth/p9auth.c
index c1e5bc4f30ae..a6078bb813cb 100644
--- a/drivers/staging/p9auth/p9auth.c
+++ b/drivers/staging/p9auth/p9auth.c
@@ -61,13 +61,10 @@ struct cap_dev {
struct cdev cdev;
};
-char *cap_hash(char *plain_text, unsigned int plain_t... |
77dc1139f4a125d46e03fdbb3ac8ab8737ab67d6 | Analyze and fix the following issue in the Linux kernel code: Staging: p9auth: fix up codingstyle issues | Problem Details:
This fixes up a number of scripts/codingstyle.pl warnings and errors
Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/p9auth/p9auth.c b/drivers/staging/p9auth/p9auth.c
index 5824c7f88cca..c1e5bc4f30ae 100644
--- a/drivers/staging/p9auth/p9auth.c
+++ b/drivers/staging/p9auth/p9auth.c
@@ -18,8 +18,7 @@
#include <linux/fcntl.h>
#include <linux/cdev.h>
#include <linux/syscalls.h>
-#include <asm/syst... |
9752ef46c6d32b7ccf10b874f00e433844db2b1a | Analyze and fix the following issue in the Linux kernel code: Staging: p9auth: fix dependency/build error | Problem Details:
Fix p9auth dependency/build failure. It needs to depend on
CRYPTO.
p9auth.c:(.text+0x107297): undefined reference to `crypto_alloc_base'
p9auth.c:(.text+0x1073d4): undefined reference to `crypto_destroy_tfm'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ashwin Ganti <ashwin.ganti@gmail.c... | ```diff
diff --git a/drivers/staging/p9auth/Kconfig b/drivers/staging/p9auth/Kconfig
index f53884457447..d1c66d262020 100644
--- a/drivers/staging/p9auth/Kconfig
+++ b/drivers/staging/p9auth/Kconfig
@@ -1,6 +1,7 @@
config PLAN9AUTH
tristate "Plan 9 style capability device implementation"
default n
+ depends on CRY... |
5dba0826999683fe39aa8b49480b0e953afd117a | Analyze and fix the following issue in the Linux kernel code: Staging: p9auth: fix credential logic | Problem Details:
current->uid is no longer allowed in the 2.6.29 kernel, so use
the proper credential api to be able to alter the uid and euid values.
Note, this now builds properly, hopefully still works properly, would be
good for someone to test it out...
Cc: Ashwin Ganti <ashwin.ganti@gmail.com>
Signed-off-by: Gr... | ```diff
diff --git a/drivers/staging/p9auth/p9auth.c b/drivers/staging/p9auth/p9auth.c
index 6704d97194a8..4f079faeb8a1 100644
--- a/drivers/staging/p9auth/p9auth.c
+++ b/drivers/staging/p9auth/p9auth.c
@@ -31,6 +31,8 @@
#include <linux/interrupt.h>
#include <linux/scatterlist.h>
#include <linux/crypto.h>
+#include ... |
70e2db22bd520018b39ea7d50ebbcec5042efd9f | Analyze and fix the following issue in the Linux kernel code: Staging: epl: fix up epl/kernel/*.h files | Problem Details:
Only include a file if it's needed.
Also remove some unused comments from the boilerplate text.
And delete some empty .h files
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/epl/EplNmtkCal.c b/drivers/staging/epl/EplNmtkCal.c
index 4ad71a71e013..4453c09838cb 100644
--- a/drivers/staging/epl/EplNmtkCal.c
+++ b/drivers/staging/epl/EplNmtkCal.c
@@ -69,8 +69,6 @@
****************************************************************************/
-#include "k... |
046f45fa714046ac400e22f48ec8ac77e7faf5cc | Analyze and fix the following issue in the Linux kernel code: Staging: epl: fix up epl/user/*.h files | Problem Details:
Only include a file if it's needed.
Also remove some unused comments from the boilerplate text.
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/epl/user/EplCfgMau.h b/drivers/staging/epl/user/EplCfgMau.h
index b5ee972b90b0..4ac770f1310c 100644
--- a/drivers/staging/epl/user/EplCfgMau.h
+++ b/drivers/staging/epl/user/EplCfgMau.h
@@ -69,19 +69,16 @@
**************************************************************************... |
e05ab09aeb36c55f0f3fe3146f9a87ddad9497bf | Analyze and fix the following issue in the Linux kernel code: Staging: epl: fix sparse warning in proc_fs.c | Problem Details:
proc_fs.c needs to include proc_fs.h
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/epl/proc_fs.c b/drivers/staging/epl/proc_fs.c
index 739d3899353a..aef8b0c22c7d 100644
--- a/drivers/staging/epl/proc_fs.c
+++ b/drivers/staging/epl/proc_fs.c
@@ -94,6 +94,8 @@
#include "fec.h"
#endif
+#include "proc_fs.h"
+
/*****************************************************... |
01f5e0322d5e04049f0b1fb5d747d088dec45241 | Analyze and fix the following issue in the Linux kernel code: Staging: epl: clean up demo_main.c | Problem Details:
Fix some static symbols and drop the kernel version checks.
Also comment out the init and exit functions, as they don't get used
anymore.
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de... | ```diff
diff --git a/drivers/staging/epl/demo_main.c b/drivers/staging/epl/demo_main.c
index 74ab74f80f94..7ad10fc2b1d0 100644
--- a/drivers/staging/epl/demo_main.c
+++ b/drivers/staging/epl/demo_main.c
@@ -74,7 +74,6 @@
#include <linux/init.h>
#include <linux/errno.h>
#include <linux/major.h>
-#include <linux/versi... |
85df0b85205a716feeaea7caecbb274d422d3b7b | Analyze and fix the following issue in the Linux kernel code: Staging: epl: fix up some non-ANSI functions | Problem Details:
() isn't valid, you need to put (void).
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
Cc: Ronald Sieber <Ronald.Sieber@systec-electronic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/epl/EplDllkCal.c b/drivers/staging/epl/EplDllkCal.c
index 88ce4b1145a1..0e283d5d0181 100644
--- a/drivers/staging/epl/EplDllkCal.c
+++ b/drivers/staging/epl/EplDllkCal.c
@@ -202,7 +202,7 @@ static tEplDllkCalInstance EplDllkCalInstance_g;
//
//-------------------------------------... |
0191492309432aab9c1e224691dcb05a3563726a | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix 64bit build errors | Problem Details:
This patch fixes the 64bit build errors in the comedi code.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi_compat32.c b/drivers/staging/comedi/comedi_compat32.c
index 2fa771e4c127..1b9c2a7c824f 100644
--- a/drivers/staging/comedi/comedi_compat32.c
+++ b/drivers/staging/comedi/comedi_compat32.c
@@ -37,16 +37,16 @@
#include <linux/ioctl32.h> /* for (un)register_ioctl32_conve... |
f10fe5742ba6ad6a2219cbe774e1b9d3db0ef23d | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: Fix cases of open curly on wrong line | Problem Details:
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 26cc41073b0b..ff6118e8ad4a 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2431,8 +2431,7 @@ static uint8_t I2Cread(comedi_device *dev, uint8_t addr)
/* Byte2 ... |
d52a63bf6a298c4ffca6a5735926a585f3dd69e0 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: usbduxfast: fix run-time error | Problem Details:
If debugging is enabled, this printk will oops, fix that issue.
From: Bernd Porr <BerndPorr@f2s.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index b1a7cbec731d..2c888d1f3afc 100644
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -498,8 +498,7 @@ static int usbduxfastsub_upload(struct usbduxfast... |
979200719d35934367bbf97d9b7d22d5b5281dda | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: comedi_open: Fix null pointer dereference. | Problem Details:
This can happen if other minor devices are used.
From: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 6867b0938e15..fa5ef2ee4eda 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1760,7 +1760,8 @@ static int comedi_open(struct inode *inode, struct file *file)
const unsi... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.