id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
56d92c60e6dc708541711e9de4993e7d527d08e8 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: newer gcc warning fixes | Problem Details:
Fix GCC warning in call to request_module(): "format not a string
literal and no format arguments".
From: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index fbd3d1c6c647..6867b0938e15 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1757,7 +1757,6 @@ void do_become_nonbusy(comedi_device *dev, comedi_subdevice *s)
static i... |
44fdfaa91197dab07583f61c4e0542cb0e2b379c | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: comedi_rt_task_context_t fix | Problem Details:
Fix redefinition of macro comedi_rt_task_context_t
From: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/comedi_rt_timer.c b/drivers/staging/comedi/drivers/comedi_rt_timer.c
index e0b76cc8bd06..878160eae080 100644
--- a/drivers/staging/comedi/drivers/comedi_rt_timer.c
+++ b/drivers/staging/comedi/drivers/comedi_rt_timer.c
@@ -104,8 +104,6 @@ static inline RTIME nano2coun... |
53b670a75bef4bf6484bbf6ca6a896c365676fd4 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix bug with invalid minor number usage. | Problem Details:
Return error instead of segfaulting if user trys to run comedi_config on
a device file with and invalid minor number.
From: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: David Schleef <ds@schleef.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 1464f550a5af..fbd3d1c6c647 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -104,9 +104,13 @@ static int comedi_ioctl(struct inode *inode, struct file *file,
const unsi... |
3cd74e8693678a463b944c358cdb22f7bee533ba | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: usbduxfast bugfix | Problem Details:
Fixed bug in firmware loading with multiple usbduxfast boards.
From: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: David Schleef <ds@schleef.org>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index 861d8989a491..625dde7e198d 100644
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -1715,7 +1715,7 @@ static int usbduxfast_attach(comedi_device *dev... |
6fadb98d3d370ffb98648ab5b66ead2a3af4d1c8 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: fix bus_id use in jr3_pci driver | Problem Details:
bus_id is going away, so don't use it.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
index f58b8f1440b2..3ba05d9c7176 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
@@ -56,7 +56,7 @@ static void comedi_fw_release(struct device *dev)
}
static ... |
0a3b8b642247b509d3308cd9c32156d21505fcb8 | Analyze and fix the following issue in the Linux kernel code: Staging: comedi: usbduxfast: add comedi debug to Kconfig | Problem Details:
This patch moves CONFIG_COMEDI_DEBUG to Kconfig and cleans up the code
as it didn't actually compile with debug enabled.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Bernd Porr <BerndPorr@f2s.com>
Cc: David Schleef <ds@schleef.org>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc... | ```diff
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index b47ca1e7e383..ab9439fa1983 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -6,6 +6,13 @@ config COMEDI
Enable support a wide range of data acquision devices
for Linux.
+config COMEDI_... |
1cc41726fddd423090d529f3eb845b55774b1ff4 | Analyze and fix the following issue in the Linux kernel code: Staging: phison: fix kconfig for clean build | Problem Details:
phison is an ATA driver, not a classic IDE driver, so fix the Kconfig file
so that it will build.
drivers/staging/phison/phison.c:43: error: implicit declaration of function 'ATA_BMDMA_SHT'
drivers/staging/phison/phison.c:43: error: initializer element is not constant
drivers/staging/phison/phison.c:4... | ```diff
diff --git a/drivers/staging/phison/Kconfig b/drivers/staging/phison/Kconfig
index 2b3920b84daf..1dd63ce0c68a 100644
--- a/drivers/staging/phison/Kconfig
+++ b/drivers/staging/phison/Kconfig
@@ -1,5 +1,5 @@
config IDE_PHISON
tristate "PCIE ATA PS5000 IDE support"
- depends on IDE
+ depends on ATA && ATA_SFF
... |
33210206b69db88925a318b053ab7aa9693c097f | Analyze and fix the following issue in the Linux kernel code: Staging: phison: fix up checkpatch and other formatting issues | Problem Details:
Minor touchups to fix up the coding style issues in the phison driver.
Cc: Evan Ko <evan_ko@phison.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/phison/phison.c b/drivers/staging/phison/phison.c
index 571d03df8d65..fd299b8cc96e 100644
--- a/drivers/staging/phison/phison.c
+++ b/drivers/staging/phison/phison.c
@@ -22,33 +22,32 @@
#define PHISON_DEBUG
-#define DRV_NAME "PHISON E-BOX" //#0003
-#define DRV_VERSION "0.91... |
8532b09fde479026bd5b9fe0feb09dd5e9810362 | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix checkpatch errors and warnings | Problem Details:
After this, only warnings are line length ones.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index 98988356d6cd..85b705453066 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -21,9 +21,9 @@
#include <linux/tty_flip.h>
#include <linux/module.h>
#include <linux/serial.h>
+#includ... |
87ed9bd2259c55537a9a621826829d6bc3baa5f7 | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix up c++ comments | Problem Details:
Convert all C++ comments to /* */
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index 55eeaba40698..0e3830be7676 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -117,9 +117,8 @@ struct ATENINTL_port
__u8 SpRegOffset;
__u8 ControlRegOffset;
__u8 DcrRegOffs... |
12cbe0b3384b281a2e0fb03638a342d9c128629f | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix up the get_uart_reg function | Problem Details:
Name it something sane, and fix up the code to be cleaner.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index 886f3b5f81f6..38770354085a 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -229,10 +229,6 @@ static int debug = 0;
/* FIXME make this somehow dynamic and not build time specific */... |
e514adb0f282b11f8ed42c0941c18ba0cab16dca | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix up the set_uart_reg function | Problem Details:
Name it something sane, and fix up the code to be cleaner.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index 20c731d5dd8d..886f3b5f81f6 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -230,8 +230,6 @@ static int debug = 0;
static int RS485mode = 0;
/* setting and get register values */... |
e9abe30d6a9bec985e528591ec31d8293b8ebb9f | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix up the get_reg_sync function | Problem Details:
Name it something sane, and fix up the code to be cleaner.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index bc212f798e44..20c731d5dd8d 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -230,8 +230,6 @@ static int debug = 0;
static int RS485mode = 0;
/* setting and get register values */... |
8433b6a69347022822131891ea4ac30880108a6c | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix up the set_reg_sync function | Problem Details:
Name it something sane, and fix up the code to be cleaner.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index 3078587eab5a..bc212f798e44 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -230,8 +230,6 @@ static int debug = 0;
static int RS485mode = 0;
/* setting and get register values */... |
085c0904af64bfe9edaf9011facb0d2daea105bf | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: clean up init and exit functions | Problem Details:
This makes them smaller, and fixes the name of the serial driver
structure.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/aten2011.c b/drivers/staging/uc2322/aten2011.c
index 6b4c80834d8e..8fe5044f8d17 100644
--- a/drivers/staging/uc2322/aten2011.c
+++ b/drivers/staging/uc2322/aten2011.c
@@ -2858,7 +2858,7 @@ static struct usb_serial *ATEN2011_get_usb_serial(struct usb_serial_port *port,
retur... |
907aff4ab004e5568b763c113e08b12b53e3e390 | Analyze and fix the following issue in the Linux kernel code: Staging: aten2011: fix up sparse warnings | Problem Details:
This resolves all of the sparse warnings.
Cc: Russell Lang <gsview@ghostgum.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/uc2322/TODO b/drivers/staging/uc2322/TODO
index 8d96ad42a43b..c189a64c4185 100644
--- a/drivers/staging/uc2322/TODO
+++ b/drivers/staging/uc2322/TODO
@@ -1,6 +1,5 @@
TODO:
- checkpatch.pl cleanups
- - sparse cleanups
- remove dead and useless code (auditing the tty ioctls to
... |
793bccbd0e5d22903ab4e28a598159a9bf59a0f1 | Analyze and fix the following issue in the Linux kernel code: Staging: stlc45xx: fix printk format warnings | Problem Details:
Fix staging/stlc45xx printk format warnings:
drivers/staging/stlc45xx/stlc45xx.c:453: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
drivers/staging/stlc45xx/stlc45xx.c:509: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
drivers/staging/stlc45xx/st... | ```diff
diff --git a/drivers/staging/stlc45xx/stlc45xx.c b/drivers/staging/stlc45xx/stlc45xx.c
index 1defbb50219e..3eced5520c56 100644
--- a/drivers/staging/stlc45xx/stlc45xx.c
+++ b/drivers/staging/stlc45xx/stlc45xx.c
@@ -450,7 +450,7 @@ static ssize_t stlc45xx_sysfs_store_cal_rssi(struct device *dev,
mutex_lock(&st... |
36ec4ab8c406c56a1ef7a65e135372e4efd1412f | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix kconfig dependencies | Problem Details:
pohmelfs wants to use CONNECTOR, so it selects CONNECTOR,
but when CONFIG_NET is not enabled, connector.c will not build,
since select does not follow the dependency chain.
Selecting NET is not a good idea, since that would build lots
of code that someone seemingly didn't want to build/store
and kconfi... | ```diff
diff --git a/drivers/staging/pohmelfs/Kconfig b/drivers/staging/pohmelfs/Kconfig
index 4c6276b5728a..58158b8780f4 100644
--- a/drivers/staging/pohmelfs/Kconfig
+++ b/drivers/staging/pohmelfs/Kconfig
@@ -1,13 +1,14 @@
config POHMELFS
tristate "POHMELFS filesystem support"
+ depends on NET
select CONNECTOR
... |
02d84ca5ed407f18ebd4fba3522780ec4bdb5267 | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix printk format warnings v2 | Problem Details:
drivers/staging/pohmelfs/inode.c:917: warning: format '%u' expects type 'unsigned int', but argument 4 has type 'size_t'
drivers/staging/pohmelfs/inode.c:1036: warning: format '%u' expects type 'unsigned int', but argument 7 has type 'size_t'
drivers/staging/pohmelfs/trans.c:164: warning: format '%u' e... | ```diff
diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
index 908fc646e97c..5bf16504cd6f 100644
--- a/drivers/staging/pohmelfs/inode.c
+++ b/drivers/staging/pohmelfs/inode.c
@@ -914,7 +914,7 @@ ssize_t pohmelfs_write(struct file *file, const char __user *buf,
kiocb.ki_pos = pos;
kio... |
de459f26f3a14ca04ee14424b454d2dc08fe426e | Analyze and fix the following issue in the Linux kernel code: Staging: pohmelfs: fix build breakage | Problem Details:
drivers/staging/pohmelfs/inode.c:982: error: implicit declaration of
function 'DQUOT_TRANSFER'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
index 0980c3cfe269..908fc646e97c 100644
--- a/drivers/staging/pohmelfs/inode.c
+++ b/drivers/staging/pohmelfs/inode.c
@@ -979,7 +979,7 @@ int pohmelfs_setattr_raw(struct inode *inode, struct iattr *attr)
if ((attr->ia_valid & A... |
e333720166a432ea890dbd438b465fd0cee3be32 | Analyze and fix the following issue in the Linux kernel code: Staging: DST: fix build dependancy | Problem Details:
On Mon, Jan 19, 2009 at 10:12:24AM -0800, Randy Dunlap (randy.dunlap@oracle.com) wrote:
>
> DST build fails when CONFIG_BLOCK=n:
DST should depend on block and block device, in the original patch its
kconfig entry was in the BLK_DEV menu, so this dependency was satisfied
automatically. Should attache... | ```diff
diff --git a/drivers/staging/dst/Kconfig b/drivers/staging/dst/Kconfig
index 9a02b3f4d61a..448d342ac2a2 100644
--- a/drivers/staging/dst/Kconfig
+++ b/drivers/staging/dst/Kconfig
@@ -1,6 +1,6 @@
config DST
tristate "Distributed storage"
- depends on NET && CRYPTO && SYSFS
+ depends on NET && CRYPTO && SYSFS ... |
f72c4bf5e184353bd848b9b6de87fe2b07a3066c | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: Fix remaining build warnings | Problem Details:
Fixed remaining four build warnings in drivers/staging/rt2860/:
drivers/staging/rt2860/common/mlme.c:900: warning: format ‘%d’ expects type ‘int’, but argument 2 has type ‘ULONG’
drivers/staging/rt2860/common/rtmp_init.c:2049: warning: ‘Value’ may be used uninitialized in this function
drivers/staging... | ```diff
diff --git a/drivers/staging/rt2860/common/mlme.c b/drivers/staging/rt2860/common/mlme.c
index 75f810ca9ae2..4562cf538dc6 100644
--- a/drivers/staging/rt2860/common/mlme.c
+++ b/drivers/staging/rt2860/common/mlme.c
@@ -897,7 +897,7 @@ VOID MlmePeriodicExec(
{
if ((pAd->StaCfg.bRadio == TRUE) && (pAd->Sam... |
f4b44e763d1bd1dd00213c1e5820a594b55122dc | Analyze and fix the following issue in the Linux kernel code: Staging: rt2860: fix printk format warnings | Problem Details:
Fix staging/rt28x0 printk format warnings:
linux-next-20090209/drivers/staging/rt2860/common/spectrum.c:1599: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
linux-next-20090209/drivers/staging/rt2860/rt_linux.c:857: warning: format '%d' expects type 'int', but arg... | ```diff
diff --git a/drivers/staging/rt2860/common/spectrum.c b/drivers/staging/rt2860/common/spectrum.c
index 0265a6d1df1a..b3650ec46563 100644
--- a/drivers/staging/rt2860/common/spectrum.c
+++ b/drivers/staging/rt2860/common/spectrum.c
@@ -1596,7 +1596,7 @@ static VOID PeerMeasureReportAction(
if ((pMeasureRepor... |
9c515551f17493248cd287997d46d6d7e3203b1d | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se: ! x & y problem in inactive code | Problem Details:
Fix ! x & y problem in inactivated code
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index ff1f23f99f27..6ecd12de4296 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -3161,7 +3161,7 @@ void rtl8180_prepare_beacon(struct net_device *dev)
return ;
... |
b318a3a6c3ac92cfab6b3f94eab9890659957938 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se: fix build warnings | Problem Details:
drivers/staging/rtl8187se/r8180_wx.c:1386: warning: initialization from incompatible pointer type
drivers/staging/rtl8187se/r8180_wx.c:1388: warning: initialization from incompatible pointer type
Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Signed-off-by: Greg Kroah-Hartman <gregk... | ```diff
diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
index 8b3901d87f87..979ba0b5f331 100644
--- a/drivers/staging/rtl8187se/r8180_wx.c
+++ b/drivers/staging/rtl8187se/r8180_wx.c
@@ -1274,8 +1274,8 @@ static int r8180_wx_set_enc_ext(struct net_device *dev,
}
static int r8... |
4913affd6ca41158fb29e19ca53ed2c83c041157 | Analyze and fix the following issue in the Linux kernel code: Staging: rtl8187se: fix printk format warnings | Problem Details:
Fix staging/rtl8187se printk format warnings:
drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:845: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:852: warning: format '%d' expects type 'int', but argument 2 has type 'size... | ```diff
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c
index 6aad61e78041..d1295e56fd42 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c
@@ -842,14 +842,14 @@ int ieee80211_wx_se... |
bdd345d8560ab09162edd7c8fb64b7eb280a70d2 | Analyze and fix the following issue in the Linux kernel code: Staging: Android: fix more printk formats | Problem Details:
Fix more android ram_console printk format warnings:
drivers/staging/android/ram_console.c:238: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
drivers/staging/android/ram_console.c:238: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
Signed-off-by:... | ```diff
diff --git a/drivers/staging/android/ram_console.c b/drivers/staging/android/ram_console.c
index d2c8f23072a0..3375c1cce2b3 100644
--- a/drivers/staging/android/ram_console.c
+++ b/drivers/staging/android/ram_console.c
@@ -235,8 +235,8 @@ static int __init ram_console_init(struct ram_console_buffer *buffer,
... |
7fce939942ba642b40d1d26581e824871eb3b081 | Analyze and fix the following issue in the Linux kernel code: Staging: android: ram_console: fix printk format warning | Problem Details:
Fix android printk format warnings:
linux-next-20090209/drivers/staging/android/ram_console.c:228: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
linux-next-20090209/drivers/staging/android/ram_console.c:228: warning: format '%d' expects type 'int', but argument 4 has type '... | ```diff
diff --git a/drivers/staging/android/ram_console.c b/drivers/staging/android/ram_console.c
index 643ac5ce381d..d2c8f23072a0 100644
--- a/drivers/staging/android/ram_console.c
+++ b/drivers/staging/android/ram_console.c
@@ -225,7 +225,7 @@ static int __init ram_console_init(struct ram_console_buffer *buffer,
... |
45eb7ae173a444884bb05bb842f07b2ab57aef41 | Analyze and fix the following issue in the Linux kernel code: Staging: android: binder: fix printk format warnings | Problem Details:
Fix printk format warnings in android binder:
drivers/staging/android/binder.c:2652: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
drivers/staging/android/binder.c:2659: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgp... | ```diff
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 758131cad08a..79e90fed27d3 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -2649,14 +2649,22 @@ static void binder_vma_open(struct vm_area_struct *vma)
{
struct binder_proc *proc = v... |
41d8532b5fc61fb384980cf3e19e61c12a02c87d | Analyze and fix the following issue in the Linux kernel code: Staging: otus: 80211core/amsdu.c: Fix Coding Style | Problem Details:
Signed-off-by: Dragoslav Zaric <dragoslav.zaric.kd@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/80211core/amsdu.c b/drivers/staging/otus/80211core/amsdu.c
index c9123d58b82f..0321288d107e 100644
--- a/drivers/staging/otus/80211core/amsdu.c
+++ b/drivers/staging/otus/80211core/amsdu.c
@@ -34,53 +34,53 @@
/* Stephen Chen Atheros Communications, INC. 2007.2 ... |
0009e125b629b83a540273ecf35ce18c5334e4fc | Analyze and fix the following issue in the Linux kernel code: Staging: otus: fix mixed declarations | Problem Details:
Fix otus ISO C90 warnings:
drivers/staging/otus/80211core/cmmsta.c:740: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/80211core/coid.c:219: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/80211core/coid.c:1437: warning: ISO C90 forbids mixed declar... | ```diff
diff --git a/drivers/staging/otus/80211core/cmmsta.c b/drivers/staging/otus/80211core/cmmsta.c
index c75ba11ee43d..b28a4e25e107 100644
--- a/drivers/staging/otus/80211core/cmmsta.c
+++ b/drivers/staging/otus/80211core/cmmsta.c
@@ -724,6 +724,9 @@ void zfStaUpdateWmeParameter(zdev_t* dev, zbuf_t* buf)
/* proces... |
1472dc9b8848d80d1d8b5a9c4119d17dc9387fcb | Analyze and fix the following issue in the Linux kernel code: Staging: otus: logical/bit and confusion | Problem Details:
fix logical/bit and confusion
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: <lrodriguez@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/otus/80211core/cwm.c b/drivers/staging/otus/80211core/cwm.c
index 80f1141bf910..1bd0b1ff12dc 100644
--- a/drivers/staging/otus/80211core/cwm.c
+++ b/drivers/staging/otus/80211core/cwm.c
@@ -75,9 +75,9 @@ void zfCoreCwmBusy(zdev_t* dev, u16_t busy)
if((wd->wlanMode == ZM_MODE_... |
a5c281cbf95b9d647007600646c50b4f91843510 | Analyze and fix the following issue in the Linux kernel code: Staging: altera: fix printk format warnings | Problem Details:
Fix printk format warnings in altera pcie chdma:
drivers/staging/altpciechdma/altpciechdma.c:429: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:433: warning: format '%08x' expects type 'unsigned int', but argument 3... | ```diff
diff --git a/drivers/staging/altpciechdma/altpciechdma.c b/drivers/staging/altpciechdma/altpciechdma.c
index df685a98250f..3e41e0861481 100644
--- a/drivers/staging/altpciechdma/altpciechdma.c
+++ b/drivers/staging/altpciechdma/altpciechdma.c
@@ -427,11 +427,13 @@ static int ape_sg_to_chdma_table(struct scatter... |
c6f5af88438b3e22d56a6b2aafaee5ffc4bc030e | Analyze and fix the following issue in the Linux kernel code: Staging: go7007: fix build error | Problem Details:
VID_TYPE_CAPTURE is a v4l1 thing only.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/go7007/go7007-v4l2.c b/drivers/staging/go7007/go7007-v4l2.c
index 868edb65e7bf..06cacd37bbd8 100644
--- a/drivers/staging/go7007/go7007-v4l2.c
+++ b/drivers/staging/go7007/go7007-v4l2.c
@@ -1827,7 +1827,6 @@ static const struct v4l2_ioctl_ops video_ioctl_ops = {
static struct vid... |
b6da26e017c6dbf40079fc9db6f9c9ecc09b8ff2 | Analyze and fix the following issue in the Linux kernel code: Staging: agnx: Fixup debug.h checkpatch warnings | Problem Details:
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/agnx/debug.h b/drivers/staging/agnx/debug.h
index e3e25dda0ba0..761d99c2d3f0 100644
--- a/drivers/staging/agnx/debug.h
+++ b/drivers/staging/agnx/debug.h
@@ -23,7 +23,7 @@ static inline void agnx_bug(char *reason)
static inline void agnx_print_desc(struct agnx_desc *desc)
{
- ... |
b8341a8d32f3dc08ac6da569b6d152a1db7a0109 | Analyze and fix the following issue in the Linux kernel code: Staging: me4000: fix various checkpatch.pl warnings about bracing | Problem Details:
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
index bfdf3e17d371..7f7c88e014af 100644
--- a/drivers/staging/me4000/me4000.c
+++ b/drivers/staging/me4000/me4000.c
@@ -1261,9 +1261,8 @@ static int me4000_reset_board(struct me4000_info *info)
info->me4000_regbase + ME4000_AO... |
1836842b206b9244c0d1f5075be0d07a69e14045 | Analyze and fix the following issue in the Linux kernel code: Staging: me4000: inline keyword should sit between storage class and type | Problem Details:
fixes some checkpatch.pl errors complaining about wrong position of the
inline keyword
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
index 73ed3bc33436..6301c9b16ed3 100644
--- a/drivers/staging/me4000/me4000.c
+++ b/drivers/staging/me4000/me4000.c
@@ -246,17 +246,17 @@ static irqreturn_t me4000_ext_int_isr(int, void *);
Inline functions
--------------------... |
387ed8f8ed047b7a70578767c4bc9d86a82312bf | Analyze and fix the following issue in the Linux kernel code: Staging: me4000: return is not a function, no parentheses required | Problem Details:
fixes some checkpatch.pl errors about unneccessary parentheses.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
index dbe93f9a18c0..73ed3bc33436 100644
--- a/drivers/staging/me4000/me4000.c
+++ b/drivers/staging/me4000/me4000.c
@@ -248,12 +248,12 @@ static irqreturn_t me4000_ext_int_isr(int, void *);
static int inline me4000_buf_count(struc... |
07d2a2823014927e3578377a07868400837a79c6 | Analyze and fix the following issue in the Linux kernel code: Staging: me4000: use linux/uaccess.h and linux/io.h | Problem Details:
This fixes the following checkpatch.pl warnings:
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
index e1c4a8078901..dbe93f9a18c0 100644
--- a/drivers/staging/me4000/me4000.c
+++ b/drivers/staging/me4000/me4000.c
@@ -36,8 +36,8 @@
#include <linux/vmalloc.h>
#include <linux/slab.h>
#include <asm/pgtable.h>
-#include <asm/uacce... |
ea045ba02086c008505ab1a6a7a60856072be65f | Analyze and fix the following issue in the Linux kernel code: Staging: wlan-ng: Remove WLAN_INCLUDE_DEBUG and some related, mostly unused | Problem Details:
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 60820da4aebf..036518e3b9ca 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -112,7 +112,6 @@
/*================================================================*/
... |
0c59dbaadf1bebdccacd616f3ebf375d81027f02 | Analyze and fix the following issue in the Linux kernel code: Staging: w35und: kill WBDEBUG and remove common.h header file | Problem Details:
The only remaining thing in common.h header file is the WBDEBUG() macro which
is unconditionally defined as printk(). Kill the macro and remove the header
file.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de... | ```diff
diff --git a/drivers/staging/winbond/common.h b/drivers/staging/winbond/common.h
deleted file mode 100644
index 4409edd59ba1..000000000000
--- a/drivers/staging/winbond/common.h
+++ /dev/null
@@ -1,23 +0,0 @@
-//
-// common.h
-//
-// This file contains the OS dependant definition and function.
-// Every OS has ... |
94aa5b44cc0c2e6ba76098cfca800ee3d901c9a3 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: do not use assignment in if condition | Problem Details:
This fixes some errors reported by checkpatch.pl
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 591fc1418f7f..04dde4b82817 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -519,19 +519,22 @@ static ssize_t odev_set_picture(struct asus_oled_dev *odev, const char ... |
118015c4d4796df499e8779ff4d581fad6565d81 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: fix various checkpatch.pl issues regarding missing or obsolete spaces | Problem Details:
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 41bf409a3932..591fc1418f7f 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -80,20 +80,20 @@ struct oled_dev_desc_str {
};
/* table of devices that work with this... |
526fd20a351cd8ab598969f38d1c38cd869cd104 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: trailing statements should be on next line | Problem Details:
fix the following error reported by checkpatch.pl
ERROR: trailing statements should be on next line
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index cb632a04a995..41bf409a3932 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -160,8 +160,10 @@ static void enable_oled(struct asus_oled_dev *odev, uint8_t enabl)
S... |
b0e5ca810ae532153c9a44dbaeff529ee5028383 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: do not initialise statics to 0 or NULL | Problem Details:
fix the following error reported by checkpatch.pl
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 7718230a9060..cb632a04a995 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -56,10 +56,10 @@ MODULE_AUTHOR("Jakub Schmidtke, sjakub@gmail.com");
MODULE_DESCRIPTION("... |
ccdb24592f850c4951e76f95f8b4365be3c4e742 | Analyze and fix the following issue in the Linux kernel code: Staging: asus_oled: fix sparse warnings about using plain integer as NULL pointer | Problem Details:
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 666a186e212b..7718230a9060 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -56,7 +56,7 @@ MODULE_AUTHOR("Jakub Schmidtke, sjakub@gmail.com");
MODULE_DESCRIPTION("As... |
524ca9c196605ff38ae0532aad29ec2e91ad45d6 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Fix a warning dump emitted by rtnl_watchdog during LTP tests | Problem Details:
Fix a softlock warning message thrown up by the rtnl_timer.
This was observed during the LTP tests (interface up/down test)
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 884e56aa9f0f..c41dea0013bc 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -2258,7 +2258,6 @@ int sxg_second_open(struct net_device * dev)
/* Re-enable interrupts */
SXG_ENABLE_ALL_INTERRUPTS(ada... |
b9346e0fc5f0761c63a6e26c6436f0d6d645c826 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Read the correct MAC address from the card for Rev B cards | Problem Details:
Read the correct MAC address from EEPROM/Flash.
Without this fix, all the interfaces were using the same MAC address.
This works on Rev B firmware.
Signed-off-by: Christopher Harrer <charrer@alacritech.com>
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gr... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 59b241e8e288..884e56aa9f0f 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -834,14 +834,15 @@ static void sxg_config_pci(struct pci_dev *pcidev)
static inline int sxg_read_config(struct adapter_t *adapter)
{
/... |
544ed364f4cac1ed6024711132e059c2746325a5 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Fix interface bug not working after open is called second time. | Problem Details:
Fix the problem of the interface not working after a sequence of up-down-up
events. The problem was observed only on systems where the card was using MSI-X
interrupts. On the second time open, the driver did not request MSI-X vector
but was trying to use normal interrupts.
Signed-off-by: LinSysSoft Sa... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index c914b9877fa8..59b241e8e288 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -2254,7 +2254,7 @@ int sxg_second_open(struct net_device * dev)
SXG_ENABLE_ALL_INTERRUPTS(adapter);
netif_carrier_on(dev);
- ... |
aa1256eafb610796dbc0900bd7de05b36e613472 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Fix the module in Kconfig file for Sahara SXG driver | Problem Details:
* Update the module name in Kconfig help section.
This is a classic case of documentation keeping out of pace with
development
And this was overlooked by me ages ago when we had fixed the Makefile for
sxg_ethtool to compile.
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Cc: Christo... | ```diff
diff --git a/drivers/staging/sxg/Kconfig b/drivers/staging/sxg/Kconfig
index 6e6cf0b9ef99..c5cbdafee4d3 100644
--- a/drivers/staging/sxg/Kconfig
+++ b/drivers/staging/sxg/Kconfig
@@ -8,4 +8,4 @@ config SXG
10Gbe network cards.
To compile this driver as a module, choose
- M here: the module will be c... |
9fd6966c62e6ad770a8b193d71d36beb9b82d351 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Fix memory leak caused by double allocation of rings | Problem Details:
* The receive rings were getting allocated twice. Once at probe time
and once at open time. This leaked huge amounts of memory.
Fix this leak and now allocation is done only once.
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index d52212a09acb..c914b9877fa8 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -613,8 +613,7 @@ static bool sxg_download_microcode(struct adapter_t *adapter,
*/
static int sxg_allocate_resources(struct adapter_t *a... |
b9d1081a833806e2f8ee7d8b827202e1bd5949b2 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Fix memory leak in case of allocation failure | Problem Details:
* Fix a memory leak if allocation of skb fails in sxg_fill_descriptor_block.
In sxg_fill_descriptor_block(), if allocation of skb failed in loop,
we just came out shouting. This rollbacks all the successful operation
before skb allocation fails and then returns.
Signed-off-by: LinSysSoft Sahara ... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index da286f5765cb..9ce3af53c891 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -4212,6 +4212,21 @@ static int sxg_fill_descriptor_block(struct adapter_t *adapter,
adapter->FreeRcvBufferCount, adapter->AllRcvBlock... |
c1f46a001fd878f1be4e08ce1df2d5677e335926 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: fix napi interface build | Problem Details:
Fix staging/sxg napi interface calls:
drivers/staging/sxg/sxg.c:1271: error: implicit declaration of function 'netif_rx_schedule_prep'
linux-next-20090209/drivers/staging/sxg/sxg.c:1272: error: implicit declaration of function '__netif_rx_schedule'
drivers/staging/sxg/sxg.c:1325: error: implicit decla... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 287edb7b86f1..5d31e1bd9718 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -1268,8 +1268,8 @@ static void sxg_interrupt(struct adapter_t *adapter)
{
WRITE_REG(adapter->UcodeRegs[0].Icr, SXG_ICR(0, SXG_ICR_MASK)... |
c5e5cf5a1824f5efbe97880bc7d667053866afc3 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Removed unnecessary checks while taking Transmit Locks | Problem Details:
Fix the locking issue of locks in transmit code path.
There was an unnecessary check for interrupt context in transmit code path.
Removed that.
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman ... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 951904320d9e..75c4982d6a3f 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -119,7 +119,7 @@ static int sxg_poll(struct napi_struct *napi, int budget);
static int sxg_process_isr(struct adapter_t *adapter, u32 Mes... |
96e7088c9a7ef3a49c8ba9ca660f73744b0b09c5 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: fix build warnings in sxg.c | Problem Details:
This compiles out some functions that are not being used to keep the
build clean so that we can see the "real" warnings and errors.
Cc: Mithlesh Thukral <mithlesh@linsyssoft.com>
Cc: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Cc: Christopher Harrer <charrer@alacritech.com>
Signed-off-by: Greg ... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 74c19b40eed1..06966eed7582 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -133,13 +133,14 @@ void sxg_collect_statistics(struct adapter_t *adapter);
#define XXXTODO 0
+#if XXXTODO
static int sxg_mac_set_add... |
5774538441aa4255a510ac304d4a3af589cd2c56 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: fix build warnings in downloadB firmware files | Problem Details:
These variables are never used, so #ifdef them away.
This should probably be fixed up properly from someone who knows why we
are even including these files in the first place, when they do not seem
to be needed at all.
Cc: Mithlesh Thukral <mithlesh@linsyssoft.com>
Cc: LinSysSoft Sahara Team <saharap... | ```diff
diff --git a/drivers/staging/sxg/saharadbgdownloadB.c b/drivers/staging/sxg/saharadbgdownloadB.c
index 0d2ae1495102..3643c4814968 100644
--- a/drivers/staging/sxg/saharadbgdownloadB.c
+++ b/drivers/staging/sxg/saharadbgdownloadB.c
@@ -2,6 +2,7 @@
#define SAHARA_B_UCODE_VERS_DATE "$Date: 2008/08/19 00:05:59... |
a7c0ea6e954635c7c9c60a197320e2fd72a42078 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: fix build warnings in sxg_ethtool | Problem Details:
This fixes some build problems with the ethtool support recently added
for the sxg driver.
This is a very good example of why you need to check the build for
warnings and then fix them...
Cc: Mithlesh Thukral <mithlesh@linsyssoft.com>
Cc: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Cc: Christo... | ```diff
diff --git a/drivers/staging/sxg/sxg_ethtool.c b/drivers/staging/sxg/sxg_ethtool.c
index a0632072a553..000c4d66e6fe 100644
--- a/drivers/staging/sxg/sxg_ethtool.c
+++ b/drivers/staging/sxg/sxg_ethtool.c
@@ -161,14 +161,14 @@ static int sxg_nic_set_settings(struct net_device *netdev,
return -EOPNOTSUPP;
}
-... |
0d41472746cec1f4d8e5c0ca12f4b1cd3819ea40 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Fix to load card on low memory machines | Problem Details:
* Fix problem of crash on 50MB machine.
* Fixed dma_addr_t bug, which resolves issues on x86_32 bit machines.
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Christopher Harrer <charrer@alacritech.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index cb48144885e3..74c19b40eed1 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -30,6 +30,8 @@
* are those of the authors and should not be interpreted as representing
* official policies, either expressed or impli... |
54aed1132631b3f630b71354f8f477c5e6bfaebe | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Add Ethtool functionality enhancement and misc cleanups | Problem Details:
Misc. cleanups in the driver.
* Remove debugging code and variables.
* Fix compile time warnings.
* Remove debugging comments.
* Start cleanup of sxg_stats structure. This structure will eventually become
very small
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Chr... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 69e1513fa26c..fbf5825bdd73 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -105,9 +105,10 @@ static void sxg_complete_slow_send(struct adapter_t *adapter, int irq_context);
static struct sk_buff *sxg_slow_receive... |
6a2946baa97337ad17c967ee8ec0bbfef491af30 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Locking related changes. Fix locking levels | Problem Details:
* Fix locking related issues like taking locks at right level.
* Convert some variables to atomic, to prevent taking them while
incrementing or decrementing them.
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Christopher Harrer <charrer@alacritech.com>
Signed-off-b... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index b8e0e2b7360a..69e1513fa26c 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -108,10 +108,7 @@ static void sxg_process_rcv_error(struct adapter_t *adapter, u32 ErrorStatus);
static bool sxg_mac_filter(struct adapte... |
371d7a9e6f0486fb814582c46785fdb147d7215e | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Ethtool framework and Receive code path changes | Problem Details:
* Add Ethtool framework to driver
* Makefile changes to fix build redundancy.
* Fix ups to error code paths in receieve buffer allocation as well as receive code path.
* Read MAC address from FLASH/EEPROM
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Christopher Harr... | ```diff
diff --git a/drivers/staging/sxg/Makefile b/drivers/staging/sxg/Makefile
index ec48faa7b3e3..8e053222c2ae 100644
--- a/drivers/staging/sxg/Makefile
+++ b/drivers/staging/sxg/Makefile
@@ -1 +1,3 @@
-obj-$(CONFIG_SXG) += sxg.o
+obj-$(CONFIG_SXG) += sxg_nic.o
+
+sxg_nic-y := sxg.o sxg_ethtool.o
diff --git a/driver... |
d0128aa9dc8a19a403cb35b5d3a6ded7210eb921 | Analyze and fix the following issue in the Linux kernel code: Staging: sxg: Receive code and data structure cleanups | Problem Details:
* Cleanup in recevive buffer structure
* Drop receive data buffer as its not needed with use of skbs
* Fix error code paths in receive skb failures
Signed-off-by: LinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: Christopher Harrer <charrer@alacritech.com>
Signed-off-by: Greg Kroah-Har... | ```diff
diff --git a/drivers/staging/sxg/sxg.c b/drivers/staging/sxg/sxg.c
index 679961f42337..b23cbc678345 100644
--- a/drivers/staging/sxg/sxg.c
+++ b/drivers/staging/sxg/sxg.c
@@ -114,6 +114,9 @@ static bool sxg_mac_filter(struct adapter_t *adapter,
static struct net_device_stats *sxg_get_stats(struct net_device *d... |
e9ef456ebc5b3e5a4794b57ad0403f1d9389ed53 | Analyze and fix the following issue in the Linux kernel code: Staging: slicoss: add proper KERN_DEBUG to 2 printks | Problem Details:
Added bonus is this fixes a compiler warning on 4.3.3
Cc: Lior Dotan <liodot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index cabe5e61af8e..e2a254aa6d08 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -170,7 +170,7 @@ static void slic_mcast_set_list(struct net_device *dev);
static uint slic_first_init =... |
6ca497a83e592d64e050c4d04b6dedb8c915f39a | Analyze and fix the following issue in the Linux kernel code: ocfs2: fix rare stale inode errors when exporting via nfs | Problem Details:
For nfs exporting, ocfs2_get_dentry() returns the dentry for fh.
ocfs2_get_dentry() may read from disk when the inode is not in memory,
without any cross cluster lock. this leads to the file system loading a
stale inode.
This patch fixes above problem.
Solution is that in case of inode is not in memo... | ```diff
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 7219a86d34cc..e15fc7d50827 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -244,6 +244,10 @@ static struct ocfs2_lock_res_ops ocfs2_rename_lops = {
.flags = 0,
};
+static struct ocfs2_lock_res_ops ocfs2_nfs_sync_lops = {
+ .flags = 0,... |
516b7e52abc7efd61c084b217c61985a403828ed | Analyze and fix the following issue in the Linux kernel code: ocfs2/dlm: Do not purge lockres that is being migrated dlm_purge_lockres() | Problem Details:
This patch attempts to fix a fine race between purging and migration.
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com> | ```diff
diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
index 4060bb328bc8..d490b66ad9d7 100644
--- a/fs/ocfs2/dlm/dlmthread.c
+++ b/fs/ocfs2/dlm/dlmthread.c
@@ -162,12 +162,28 @@ static int dlm_purge_lockres(struct dlm_ctxt *dlm,
spin_lock(&res->spinlock);
if (!__dlm_lockres_unused(res)) {
- sp... |
1d46dc08d33138c29c63d717807c08ab704fc773 | Analyze and fix the following issue in the Linux kernel code: ocfs2: fix leaf start calculation in ocfs2_dx_dir_rebalance() | Problem Details:
ocfs2_dx_dir_rebalance() is passed the block offset of a dx leaf which needs
rebalancing. Since we rebalance an entire cluster at a time however, this
function needs to calculate the beginning of that cluster, in blocks. The
calculation was wrong, which would result in a read of non-leaf blocks. Fix
th... | ```diff
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index 5e6aeb00cb43..e71160cda110 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -3941,8 +3941,7 @@ static int ocfs2_dx_dir_rebalance(struct ocfs2_super *osb, struct inode *dir,
goto out_commit;
}
- orig_leaves_start = leaf_blkno & ~(osb->s_clustersize_bit... |
6a891a24e4d0056c365a90ff2d71c38fd366b0d0 | Analyze and fix the following issue in the Linux kernel code: x86, UV: Fix for nodes with memory and no cpus | Problem Details:
Fix initialization of UV blade information for systems that have
nodes with memory but no cpus.
Signed-off-by: Jack Steiner <steiner@sgi.com>
LKML-Reference: <20090330140111.GA18461@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c
index 1248318436e8..de1a50af807b 100644
--- a/arch/x86/kernel/apic/x2apic_uv_x.c
+++ b/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -549,7 +549,8 @@ void __init uv_system_init(void)
unsigned long gnode_upper, lowmem_redir_base, lowm... |
9756b15e1b58453a6fd54b85c1ad8515209e10bb | Analyze and fix the following issue in the Linux kernel code: irq: fix cpumask memory leak on offstack cpumask kernels | Problem Details:
Need to free the old cpumask for affinity and pending_mask.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
LKML-Reference: <49D18FF0.50707@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/include/linux/irq.h b/include/linux/irq.h
index 974890b3c52f..99d147efe399 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -482,6 +482,16 @@ static inline void init_copy_desc_masks(struct irq_desc *old_desc,
#endif
}
+static inline void free_desc_masks(struct irq_desc *old_desc,
+... |
16dd55f309cf69a648ca3b1fc04b3b6f079c8be0 | Analyze and fix the following issue in the Linux kernel code: sony-laptop: fix event reporting for new style events | Problem Details:
In short Fn key events are always reported through acpi.
The input layer gets all the old style events and only those new style
events that, after being decoded, are mapped to an locally represented
events.
rfkill only update the rfkill device status.
Signed-off-by: Matthias Welwarsky <matze@welwarsky... | ```diff
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 011c03596b2c..e02edf68a68e 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -917,10 +917,10 @@ static struct sony_nc_event sony_127_events[] = {
static void sony_acpi_notify(acp... |
14bd31365fbeeccee72b0aead3baa4e5da208281 | Analyze and fix the following issue in the Linux kernel code: sony-laptop should depend on RFKILL | Problem Details:
Fixes this build error when RFKILL is not set:
drivers/platform/x86/sony-laptop.c:1050: undefined reference to `rfkill_unregister'
and so on..
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed... | ```diff
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3608081bc3e0..36b1628d19c6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -165,6 +165,7 @@ config SONY_LAPTOP
depends on ACPI
select BACKLIGHT_CLASS_DEVICE
depends on INPUT
+ depends on RFKILL
... |
6479efb68dce48fa52aed6ff876d8d102f200527 | Analyze and fix the following issue in the Linux kernel code: sony-laptop: new style events typo fixes | Problem Details:
Signed-off-by: Matthias Welwarsky <matze@welwarsky.de>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 5837156f09fd..011c03596b2c 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -865,7 +865,7 @@ struct sony_nc_event {
static struct sony_nc_event sony_100_events[] = {
{ 0x90, S... |
ff07a53a33cff2733c2c20fc75e84e75c2572889 | Analyze and fix the following issue in the Linux kernel code: sony-laptop: Fix some typos in log messages (Unabe/Unable) | Problem Details:
Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 0f710317a94e..5837156f09fd 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -397,7 +397,7 @@ static int sony_laptop_setup_input(struct acpi_device *acpi_device)
sony_laptop_inp... |
a0e0404fb06164100991cacf8e055f6b30f87cc9 | Analyze and fix the following issue in the Linux kernel code: mm: fix misuse of debug_kmap_atomic | Problem Details:
Commit 7ca43e7564679604d86e9ed834e7bbcffd8a4a3f ("mm: use debug_kmap_atomic")
introduced some debug_kmap_atomic() in wrong places.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> | ```diff
diff --git a/arch/x86/mm/highmem_32.c b/arch/x86/mm/highmem_32.c
index 5bc5d1688c1c..8126e8d1a2a4 100644
--- a/arch/x86/mm/highmem_32.c
+++ b/arch/x86/mm/highmem_32.c
@@ -40,7 +40,6 @@ void *kmap_atomic_prot(struct page *page, enum km_type type, pgprot_t prot)
debug_kmap_atomic(type);
- debug_kmap_atomic(... |
f240729832dff3785104d950dad2d3ced4387f6d | Analyze and fix the following issue in the Linux kernel code: dock: fix dereference after kfree() | Problem Details:
dock_remove() calls kfree() on dock_station so we should use
list_for_each_entry_safe() to avoid dereferencing freed memory.
Found by smatch (http://repo.or.cz/w/smatch.git/). Compile tested.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 35094f230b1e..8f62fa01a9c7 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -1146,9 +1146,10 @@ static int __init dock_init(void)
static void __exit dock_exit(void)
{
struct dock_station *dock_station;
+ struct dock_station *tmp;
... |
3688e07f83d81941c4a8b20e29602c6d0c883539 | Analyze and fix the following issue in the Linux kernel code: Fix highmem PPC build failure | Problem Details:
Commit f4112de6b679d84bd9b9681c7504be7bdfb7c7d5 ("mm: introduce
debug_kmap_atomic") broke PPC builds with CONFIG_HIGHMEM=y:
CC init/main.o
In file included from include/linux/highmem.h:25,
from include/linux/pagemap.h:11,
from include/linux/mempolicy.h:6... | ```diff
diff --git a/include/linux/highmem.h b/include/linux/highmem.h
index 7ff5c55f9b55..1fcb7126a01f 100644
--- a/include/linux/highmem.h
+++ b/include/linux/highmem.h
@@ -19,8 +19,21 @@ static inline void flush_kernel_dcache_page(struct page *page)
}
#endif
-#ifdef CONFIG_HIGHMEM
+#include <asm/kmap_types.h>
+
... |
6a491e2e3e52a64c6d88a192c56499d931842ac5 | Analyze and fix the following issue in the Linux kernel code: x86: fix is_io_mapping_possible() build warning on i386 allnoconfig | Problem Details:
i386 allnoconfig:
arch/x86/mm/iomap_32.c: In function 'is_io_mapping_possible':
arch/x86/mm/iomap_32.c:27: warning: comparison is always false due to limited range of data type
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu> | ```diff
diff --git a/arch/x86/mm/iomap_32.c b/arch/x86/mm/iomap_32.c
index e331f77348a7..8056545e2d39 100644
--- a/arch/x86/mm/iomap_32.c
+++ b/arch/x86/mm/iomap_32.c
@@ -23,7 +23,7 @@
int is_io_mapping_possible(resource_size_t base, unsigned long size)
{
-#ifndef CONFIG_X86_PAE
+#if !defined(CONFIG_X86_PAE) && def... |
31c9a24ec82926fcae49483e53566d231e705057 | Analyze and fix the following issue in the Linux kernel code: RCU: make treercu be default | Problem Details:
Impact: switch default config from CLASSIC_RCU to TREE_RCU
Given that I have not gotten any complaints or bug reports on treercu
recently, this patch makes it be the default. There are a number of
other defconfig files that explicitly call out CLASSIC_RCU, but which
have comment headers saying not to... | ```diff
diff --git a/init/Kconfig b/init/Kconfig
index 14c483d2b7c9..26ac8772464d 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -302,7 +302,7 @@ menu "RCU Subsystem"
choice
prompt "RCU Implementation"
- default CLASSIC_RCU
+ default TREE_RCU
config CLASSIC_RCU
bool "Classic RCU"
``` |
9674f35b1ec17577163897f052f405c1e9e5893d | Analyze and fix the following issue in the Linux kernel code: x86: UV BAU and nodes with no memory | Problem Details:
This patch fixes BAU initialization for systems containing
nodes with no memory and for systems with non-consecutive
node numbers.
Fixes and clarifies situations where pnode should be used instead
of node id.
Tested on the UV hardware simulator.
Signed-off-by: Cliff Wickman <cpw@sgi.com>
LKML-Refere... | ```diff
diff --git a/arch/x86/kernel/tlb_uv.c b/arch/x86/kernel/tlb_uv.c
index 79c073247284..b833bc634d17 100644
--- a/arch/x86/kernel/tlb_uv.c
+++ b/arch/x86/kernel/tlb_uv.c
@@ -31,6 +31,34 @@ static unsigned long uv_mmask __read_mostly;
static DEFINE_PER_CPU(struct ptc_stats, ptcstats);
static DEFINE_PER_CPU(struc... |
67dc092187626ac55a60877485f78bc291cbfa81 | Analyze and fix the following issue in the Linux kernel code: ACPI: Remove R40e c-state blacklist | Problem Details:
The recent ACPICA patch
(ACPICA: FADT: Favor 32-bit register addresses for compatibility)
makes machine to use the right FADT HW addresses
and C-states now work fine.
http://bugzilla.kernel.org/show_bug.cgi?id=8246
Signed-off-by: Thomas Renninger <trenn@suse.de>
Tested-by: Mark Doughty <me@markdought... | ```diff
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 5c69e85c1e4d..397f2a7fee48 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -101,57 +101,6 @@ static int set_max_cstate(const struct dmi_system_id *id)
/* Actually this shouldn't be __cpuinitdata, ... |
2a9ef8e1a856be8e526bb9b10fb98c5012f6e3f8 | Analyze and fix the following issue in the Linux kernel code: ACPI: suspend: Add the Pansonic CF51 box to the dmi check table | Problem Details:
The Pansonic CF51-2L requires "acpi_sleep=old_ordering",
so invoke it automatically via DMI.
http://bugzilla.kernel.org/show_bug.cgi?id=12561
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 00456fccfa38..31ff2a9a03d7 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -394,6 +394,15 @@ static struct dmi_system_id __initdata acpisleep_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L300"),
},
},
+ {
+ .callbac... |
07de5bdb7bad607e29dc17c345717403a76a334c | Analyze and fix the following issue in the Linux kernel code: tc1100-wmi: Fix state reporting | Problem Details:
The tc1100-wmi driver should print the current states of wireless LAN and
jogdial brightness control when "cat /sys/devices/platform/tc1100-wmi/wireless"
and "cat /sys/devices/platform/tc1100-wmi/jogdial" are executed, respectively.
What actually happens is that both of those commands print 0 regardles... | ```diff
diff --git a/drivers/platform/x86/tc1100-wmi.c b/drivers/platform/x86/tc1100-wmi.c
index b4a4aa9ee482..44166003d4ef 100644
--- a/drivers/platform/x86/tc1100-wmi.c
+++ b/drivers/platform/x86/tc1100-wmi.c
@@ -94,9 +94,8 @@ static int get_state(u32 *out, u8 instance)
return -ENODEV;
obj = (union acpi_object... |
c6a6f19e22da0a3d74214ee010224c9a30a794c1 | Analyze and fix the following issue in the Linux kernel code: NFS: Add FS-Cache option bit and debug bit | Problem Details:
Add FS-Cache option bit to nfs_server struct. This is set to indicate local
on-disk caching is enabled for a particular superblock.
Also add debug bit for local caching operations.
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
Acked-by: Trond Myklebus... | ```diff
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index bde2557c2a9c..fd3e7f9c6fd3 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -583,6 +583,7 @@ extern void * nfs_root_data(void);
#define NFSDBG_CALLBACK 0x0100
#define NFSDBG_CLIENT 0x0200
#define NFSDBG_MOUNT 0x0400
+#de... |
06b3db1b9bccdc8c2c743122a89745279e5ecc46 | Analyze and fix the following issue in the Linux kernel code: FS-Cache: Add main configuration option, module entry points and debugging | Problem Details:
Add the main configuration option, allowing FS-Cache to be selected; the
module entry and exit functions and the debugging stuff used by these patches.
The two configuration options added are:
CONFIG_FSCACHE
CONFIG_FSCACHE_DEBUG
The first enables the facility, and the second makes the debugging st... | ```diff
diff --git a/fs/Kconfig b/fs/Kconfig
index cef8b18ceaa3..3942df6ad04f 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -66,6 +66,12 @@ config GENERIC_ACL
bool
select FS_POSIX_ACL
+menu "Caches"
+
+source "fs/fscache/Kconfig"
+
+endmenu
+
if BLOCK
menu "CD-ROM/DVD Filesystems"
diff --git a/fs/Makefile b/fs/... |
015640edb1f346e0b2eda703587c4cd1c310ec1d | Analyze and fix the following issue in the Linux kernel code: [SCSI] sg: fix q->queue_lock on scsi_error_handler path | Problem Details:
sg_rq_end_io() is called via rq->end_io. In some rare cases,
sg_rq_end_io calls blk_put_request/blk_rq_unmap_user (when a program
issuing a command has gone before the command completion; e.g. by
interrupting a program issuing a command before the command
completes).
We can't call blk_put_request/blk_... | ```diff
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 1e405184ed76..82312df9b0bf 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1312,8 +1312,10 @@ static void sg_rq_end_io(struct request *rq, int uptodate)
wake_up_interruptible(&sfp->read_wait);
kill_fasync(&sfp->async_qp, SIGPOLL, POLL_IN)... |
0fdf96b67ac2649cc1ddb29b316a0db11586c6a8 | Analyze and fix the following issue in the Linux kernel code: [SCSI] sg: fix iovec bugs introduced by the block layer conversion | Problem Details:
- needs to use copy_from_user for iovec before passing it to
blk_rq_map_user_iov().
- before the block layer conversion, if ->dxfer_len and sum of iovec
disagrees, the shorter one wins. However, currently sg returns
-EINVAL. This restores the old behavior.
Signed-off-by: FUJITA Tomonori <fujita.tomon... | ```diff
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index ffc87851f2e8..1e405184ed76 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1656,10 +1656,30 @@ static int sg_start_req(Sg_request *srp, unsigned char *cmd)
md->null_mapped = hp->dxferp ? 0 : 1;
}
- if (iov_count)
- res = blk_rq_map_user... |
fd6e1c14b73dbab89cb76af895d5612e4a8b5522 | Analyze and fix the following issue in the Linux kernel code: [SCSI] libiscsi: fix iscsi pool error path | Problem Details:
Le lundi 30 mars 2009, Chris Wright a écrit :
> q->queue could be ERR_PTR(-ENOMEM) which will break unwinding
> on error. Make iscsi_pool_free more defensive.
>
Making the freeing of q->queue dependent on q->pool being set looks
really weird (although it is correct at the moment. But this seems
to be... | ```diff
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index dfaa8adf099e..689628359169 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1999,8 +1999,10 @@ iscsi_pool_init(struct iscsi_pool *q, int max, void ***items, int item_size)
q->queue = kfifo_init((void*)q->pool, max * s... |
d8e965076514dcb16410c0d18c6c8de4dcba19fc | Analyze and fix the following issue in the Linux kernel code: [SCSI] aacraid driver update | Problem Details:
changes:
- set aac_cache=2 as default value to avoid performance problem
(Novell bugzilla #469922)
- Dell/PERC controller boot problem fixed (RedHat bugzilla #457552)
- WWN flag added to fix SLES10 SP1/SP2 drive detection problems
- 64-bit support changes
- DECLARE_PCI_DEVICE_TABLE macro added
... | ```diff
diff --git a/Documentation/scsi/aacraid.txt b/Documentation/scsi/aacraid.txt
index ddace3afc83b..30f643f611b2 100644
--- a/Documentation/scsi/aacraid.txt
+++ b/Documentation/scsi/aacraid.txt
@@ -60,17 +60,9 @@ Supported Cards/Chipsets
9005:0285:9005:02d5 Adaptec ASR-2405 (Voodoo40 Lite)
9005:0285:9005:02d6 ... |
f14981616205eedb6fe8b24a09ec103ed976e122 | Analyze and fix the following issue in the Linux kernel code: [SCSI] stex: small code fixes and changes | Problem Details:
These are some small code fixes and changes, including:
- use 64 bit when possible
- remove some unnecessary code (in interrupt, queuecommand routine etc.)
- code change for reset handler
Signed-off-by: Ed Lin <ed.lin@promise.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> | ```diff
diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 47b614e8580c..de6c30e37463 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -160,26 +160,22 @@ struct st_sgitem {
u8 ctrl; /* SG_CF_xxx */
u8 reserved[3];
__le32 count;
- __le32 addr;
- __le32 addr_hi;
+ __le64 addr;
};
struct s... |
a0a25da2a495a889664dc946942b8666665cd1e1 | Analyze and fix the following issue in the Linux kernel code: [SCSI] fcoe, libfc: fix double fcoe_softc memory alloc | Problem Details:
The foce_softc mem was reserved by libfc_host_alloc as well as
by fcoe_host_alloc.
Removes one liner fcoe_host_alloc completely, instead directly calls
libfc_host_alloc to alloc scsi_host with libfc for just one fcoe_softc
as fcoe private data.
Moves libfc_host_alloc to libfc.h since it is a libfc AP... | ```diff
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 30161a26387a..d5f009ad0388 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -70,8 +70,6 @@ static struct fc_lport *fcoe_hostlist_lookup(const struct net_device *);
static int fcoe_hostlist_add(const struct fc_lport *)... |
5919a59503577c2dc6eaa8bfba0f7bde3f9924ba | Analyze and fix the following issue in the Linux kernel code: [SCSI] fcoe: prep work to completely remove fc_transport_fcoe code | Problem Details:
The fcoe transport code was added for generic FCoE transport
infrastructure to allow additional offload related module loading
on demand, this is not required anymore after recently added
different offload approach by having offload related func ops
in netdev.
This patch removes fcoe transport related... | ```diff
diff --git a/drivers/scsi/fcoe/Makefile b/drivers/scsi/fcoe/Makefile
index b78da06d7c0e..e950adfe68c6 100644
--- a/drivers/scsi/fcoe/Makefile
+++ b/drivers/scsi/fcoe/Makefile
@@ -4,5 +4,4 @@ obj-$(CONFIG_FCOE) += fcoe.o
fcoe-y := \
libfcoe.o \
- fcoe_sw.o \
- fc_transport_fcoe.o
+ fcoe_sw.o
diff --git a/dr... |
8976f424d43c80ea32b6e847226e1a8ccdb6e748 | Analyze and fix the following issue in the Linux kernel code: [SCSI] fcoe: create/destroy fcoe Rx threads on CPU hotplug events | Problem Details:
This patch adds support for dynamically created Rx threads
upon CPU hotplug events.
There were existing synchronization problems that this patch
attempts to resolve. The main problem had to do with fcoe_rcv()
running in a different context than the hotplug notifications.
This opened the possiblity tha... | ```diff
diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
index 648a2fc04271..951d2448ad61 100644
--- a/drivers/scsi/fcoe/libfcoe.c
+++ b/drivers/scsi/fcoe/libfcoe.c
@@ -80,6 +80,156 @@ static struct notifier_block fcoe_notifier = {
.notifier_call = fcoe_device_notification,
};
+/**
+ * fcoe_p... |
8c0baccadc86d9f07e663dd255751dd70e461ba3 | Analyze and fix the following issue in the Linux kernel code: [SCSI] libosd: fix blk_put_request called from within request_end_io | Problem Details:
A fix for a very serious and stupid bug in osd_initiator. It
used to call blk_put_request() regardless of if it was from
the end_io callback or if called after a sync execution.
It should call the unlocked version __blk_put_request() instead.
Also fixed is the remove of _abort_unexecuted_bios hack, an... | ```diff
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index 552f58b655d1..2a5f0777148d 100644
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -338,20 +338,6 @@ struct osd_request *osd_start_request(struct osd_dev *dev, gfp_t gfp)
}
EXPORT_SYMBOL(osd_... |
a9bddd74630b2a1f2dedc537417c372b2d9edc76 | Analyze and fix the following issue in the Linux kernel code: [SCSI] fix recovered error handling | Problem Details:
We have a problem with recovered error handling in that any command
which goes down as BLOCK_PC but which returns a sense code of RECOVERED
ERROR gets completed with -EIO. For actual SG_IO commands, this doesn't
matter at all, since the error return code gets dropped in favour of
req->errors which con... | ```diff
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 4b13e36d3aa0..d1cb64ad1a3f 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -791,7 +791,22 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
"%d bytes done.\n",
req->nr_sector... |
545ef9a2dc1e5ac0463f3754e239ffcc5aaa92e2 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Fixup module parms attributes | Problem Details:
The ibmvfc driver really does not handle dynamically changing disc_threads.
To change this dynamically would cause confusion in the driver regarding
the number of event structs allocated. Fix this by simply not allowing
disc_threads to be changed at runtime.
Signed-off-by: Brian King <brking@linux.vne... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 229e360f0220..f0bf102c9bca 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -75,7 +75,7 @@ MODULE_PARM_DESC(max_lun, "Maximum allowed LUN. "
module_param_named(max_targets, max_targets, uint, S... |
039a08981a49e05f09db969cdd3f38f05a5df46f | Analyze and fix the following issue in the Linux kernel code: [SCSI] ibmvfc: Fix dropped interrupts | Problem Details:
This patch fixes a problem of possible dropped interrupts. Currently,
the ibmvfc driver has a race condition where after ibmvfc_interrupt
gets run, the platform code clears the interrupt. This can result in
lost interrupts and, in worst case scenarios, result in command
timeouts. Fix this by implementi... | ```diff
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 93d1fbe4ee5d..229e360f0220 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -640,6 +640,7 @@ static void ibmvfc_release_crq_queue(struct ibmvfc_host *vhost)
ibmvfc_dbg(vhost, "Releasing CRQ\... |
e2494e1b42ebac402324105d57646489d19e2b01 | Analyze and fix the following issue in the Linux kernel code: blktrace: fix pdu_len when tracing packet command requests | Problem Details:
Impact: output all of packet commands - not just the first 4 / 8 bytes
Since commit d7e3c3249ef23b4617393c69fe464765b4ff1645 ("block: add
large command support"), struct request->cmd has been changed from
unsinged char cmd[BLK_MAX_CDB] to unsigned char *cmd.
v1 -> v2: by: FUJITA Tomonori <fujita.tomo... | ```diff
diff --git a/block/blk-core.c b/block/blk-core.c
index 29bcfac6c688..859879d0a0bf 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -132,6 +132,7 @@ void blk_rq_init(struct request_queue *q, struct request *rq)
INIT_HLIST_NODE(&rq->hash);
RB_CLEAR_NODE(&rq->rb_node);
rq->cmd = rq->__cmd;
+ rq->cmd_l... |
a4b3ada83d06554d307dd54abdc62b2e5648264a | Analyze and fix the following issue in the Linux kernel code: blktrace: NUL-terminate user space messages | Problem Details:
Impact: fix corrupted blkparse output
Make sure messages from user space are NUL-terminated strings,
otherwise we could dump random memory to the block trace file.
Additionally, I've limited the message to BLK_TN_MAX_MSG-1
characters, because the last character would be stripped by
vscnprintf anyway.... | ```diff
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 947c5b3f90c4..a400b861fad3 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -327,10 +327,10 @@ static ssize_t blk_msg_write(struct file *filp, const char __user *buffer,
char *msg;
struct blk_trace *bt;
- if (count >... |
67796bf7dc54c035fd97f2681a72e5d2bf2a234a | Analyze and fix the following issue in the Linux kernel code: x86/dma: unify definition of pci_unmap_addr* and pci_unmap_len macros | Problem Details:
Impact: unification of pci-dma macros and pci_32.h removal
This patch unifies the definition of the pci_unmap_addr*, pci_unmap_len*
and DECLARE_PCI_UNMAP* macros. This makes sense because the pci_unmap
functions are no longer no-ops anymore when the kernel runs with
CONFIG_DMA_API_DEBUG. Without an io... | ```diff
diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h
index a0301bfeb954..e545ea01abcf 100644
--- a/arch/x86/include/asm/pci.h
+++ b/arch/x86/include/asm/pci.h
@@ -89,12 +89,40 @@ extern void pci_iommu_alloc(void);
/* MSI arch hook */
#define arch_setup_msi_irqs arch_setup_msi_irqs
-#endif /... |
2121db74ba0fd2259f0e2265511684fadda9ac49 | Analyze and fix the following issue in the Linux kernel code: kmemtrace: trace kfree() calls with NULL or zero-length objects | Problem Details:
Impact: also output kfree(NULL) entries
This patch moves the trace_kfree() calls before the ZERO_OR_NULL_PTR
check so that we can trace call-sites that call kfree() with NULL many
times which might be an indication of a bug.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Mu... | ```diff
diff --git a/mm/slab.c b/mm/slab.c
index fa00fd6a644d..b58400285030 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3773,6 +3773,8 @@ void kfree(const void *objp)
struct kmem_cache *c;
unsigned long flags;
+ trace_kfree(_RET_IP_, objp);
+
if (unlikely(ZERO_OR_NULL_PTR(objp)))
return;
local_irq_save(flag... |
da2635a9854423b4aa3a5f0e4e6efcc39ac99004 | Analyze and fix the following issue in the Linux kernel code: kmemtrace: kmemtrace_alloc() must fill type_id | Problem Details:
Impact: fix trace output
kmemtrace_alloc() was not filling type_id, which allowed garbage to make
it into tracing data.
Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
LKML-Reference: <284dba2732a144849d5aa82258fe0de2ad8dcb0b.1237813499.git.eduard.munteanu@linux360.ro>
Signed-o... | ```diff
diff --git a/kernel/trace/kmemtrace.c b/kernel/trace/kmemtrace.c
index 4f7b5db5dd06..ae259f04ee39 100644
--- a/kernel/trace/kmemtrace.c
+++ b/kernel/trace/kmemtrace.c
@@ -52,6 +52,7 @@ static inline void kmemtrace_alloc(enum kmemtrace_type_id type_id,
tracing_generic_entry_update(&entry->ent, 0, 0);
entry... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.