id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
6daf65310374d24d888201b7a6eba90b44008b7b | Analyze and fix the following issue in the Linux kernel code: PHYLIB: fix an interrupt loop potential when halting | Problem Details:
Ensure the PHY_HALTED state is not entered with the IRQ asserted as it
could lead to an interrupt loop.
There is a small window in phy_stop(), where the state of the PHY machine
indicates it has been halted, but its interrupt output might still be
unmasked. If an interrupt goes active right at this m... | ```diff
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 5a314edc2744..9bc11773705b 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -737,8 +737,6 @@ void phy_stop(struct phy_device *phydev)
if (PHY_HALTED == phydev->state)
goto out_unlock;
- phydev->state = PHY_HALTED;
-
if (p... |
0ac49527318bc388a881152d60f49d7951606024 | Analyze and fix the following issue in the Linux kernel code: PHYLIB: IRQ event workqueue handling fixes | Problem Details:
Keep track of disable_irq_nosync() invocations and call enable_irq() the
right number of times if work has been cancelled that would include them.
Now that the call to flush_work_keventd() (problematic because of
rtnl_mutex being held) has been replaced by cancel_work_sync() another
issue has arisen a... | ```diff
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 4da993dfcfd8..5a314edc2744 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -7,7 +7,7 @@
* Author: Andy Fleming
*
* Copyright (c) 2004 Freescale Semiconductor, Inc.
- * Copyright (c) 2006 Maciej W. Rozycki
+ * Copyright (c)... |
9ff8c68b3c722f732c7a13d6631b149cca8c7091 | Analyze and fix the following issue in the Linux kernel code: PHYLIB: Spinlock fixes for softirqs | Problem Details:
Use spin_lock_bh()/spin_unlock_bh() for the phydev lock throughout as it
is used in phy_timer() that is called as a softirq and all the other
operations may happen in the user context.
There has been a change recently that did such a conversion for some of the
operations on the lock, but some have bee... | ```diff
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 17c1e1555d80..4da993dfcfd8 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -424,7 +424,7 @@ int phy_start_aneg(struct phy_device *phydev)
{
int err;
- spin_lock(&phydev->lock);
+ spin_lock_bh(&phydev->lock);
if (AUTONEG_... |
1f8f4559f8c5829348a010a9e0bbb423310060d1 | Analyze and fix the following issue in the Linux kernel code: Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c | Problem Details:
This patch fixes an apparent potential null dereference bug where we
dereference dev before a null check. This patch simply remvoes the
can't-happen test for a null pointer.
Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Acked-by: Jeff Garzik <jeff... | ```diff
diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
index e64bde46822e..76e55612430b 100644
--- a/drivers/net/tulip/uli526x.c
+++ b/drivers/net/tulip/uli526x.c
@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int irq, void *dev_id)
unsigned long ioaddr = dev->base_addr;
unsigned ... |
bcfef8c3681fa59b653871682956a8fdf5c27c5a | Analyze and fix the following issue in the Linux kernel code: Avoid possible NULL pointer deref in 3c359 driver | Problem Details:
In xl_freemem(), if dev_if is NULL, the line
struct xl_private *xl_priv =(struct xl_private *)dev->priv;
will cause a NULL pointer dereference.
(akpm: don't try to fix it: just delete the pointless test-for-null)
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akp... | ```diff
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index 88d03c085d54..7224d368b2a7 100644
--- a/drivers/net/tokenring/3c359.c
+++ b/drivers/net/tokenring/3c359.c
@@ -1045,11 +1045,6 @@ static irqreturn_t xl_interrupt(int irq, void *dev_id)
u8 __iomem * xl_mmio = xl_priv->xl_mmio ;
... |
7c32f470f4f6a0fdc6944cefcd22f288e59a0ae2 | Analyze and fix the following issue in the Linux kernel code: PHY fixed driver: rework release path and update phy_id notation | Problem Details:
device_bind_driver() error code returning has been fixed. release()
function has been written, so that to free resources in correct way; the
release path is now clean.
Before the rework, it used to cause
Device 'fixed@100:1' does not have a release() function, it is broken
and must be fixed.
BUG: ... | ```diff
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index dd09011c7ee5..432c210513be 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -76,4 +76,18 @@ config FIXED_MII_100_FDX
bool "Emulation for 100M Fdx fixed PHY behavior"
depends on FIXED_PHY
+config FIXED_MII_1000_FDX
+ ... |
ac1d49f8431bef861c7dd63e78be25e4c262eb52 | Analyze and fix the following issue in the Linux kernel code: [netdrvr] sundance: fix phy scanning on IP100A | Problem Details:
Based on a based from Jesse Huang <jesse@icplus.com.tw>.
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c
index a37637ec9b77..ff98f5d597f1 100644
--- a/drivers/net/sundance.c
+++ b/drivers/net/sundance.c
@@ -466,7 +466,7 @@ static int __devinit sundance_probe1 (struct pci_dev *pdev,
#else
int bar = 1;
#endif
- int phy, phy_idx = 0;
+ int phy, phy_end,... |
6b6ec99a03601aba0419f34e17630f7aa8d68e5f | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nfnetlink_log: fix some constants | Problem Details:
Fix timeout (one second is 1 * HZ) and convert max packet copy length
to #defined constant.
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 16ae53918606..2135926199ca 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -37,8 +37,9 @@
#endif
#define NFULNL_NLBUFSIZ_DEFAULT NLMSG_GOODSIZE
-#define NFULNL_TIMEOUT_DEFAULT 100 /* every sec... |
aace57e054e9322e20af52cede7de46ade64a5e2 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nfnetlink_log: fix instance_create() failure path | Problem Details:
Fix memory leak on instance_create() while module is being unloaded.
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index d2e811f46067..16ae53918606 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -152,6 +152,11 @@ instance_create(u_int16_t group_num, int pid)
if (!inst)
goto out_unlock;
+ if (!try_module_get(T... |
c6a8f648362a5d8b934f4267b0ab9f255c130ab0 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nfnetlink_log: fix style | Problem Details:
Fix function definition style to match other functions in nfnetlink_log.c.
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 0fa17421bbc6..d2e811f46067 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -301,8 +301,8 @@ nfulnl_set_flags(struct nfulnl_instance *inst, u_int16_t flags)
return 0;
}
-static struct sk_buff *... |
a50e2e3f3e6303e893c4c438c0692d459d7093a5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] iwlwifi: fix imcomplete conversion to print_mac API | Problem Details:
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index b41addf2056a..b50d20267c8a 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -184,7 +184,7 @@ u8 iwl_hw_find_station(struct iwl_priv *priv, const u8 *addr)
... |
0209dc11c769f51f037a17a4ea7bed43eaee998c | Analyze and fix the following issue in the Linux kernel code: [PATCH] iwlwifi: add debugfs rate scale stats | Problem Details:
This patch adds rates scale statistics to debugfs:
$ cat /sys/kernel/debug/ieee80211/phy<X>/stations/<mac>/rate_stats_table
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
index e5f8cce443ba..287c75705c44 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
@@ -124,6 +124,7 @@ struct iwl_rate_scale_priv {
struct iwl_scale_tbl_i... |
98d7e09af513da19389128f23d49893b11de81fa | Analyze and fix the following issue in the Linux kernel code: [PATCH] iwlwifi: set fixed rate through debugfs | Problem Details:
This patch adds fixed rate setting through debugfs
$ echo <rate_n_flags> > \
/sys/kernel/debug/ieee80211/phy<X>/stations/<mac>/rate_scale_table
Currently there is no way to turn to rate scaling working again.
Will be fixed in later.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-b... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
index c4b8ca128495..e5f8cce443ba 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
@@ -123,7 +123,9 @@ struct iwl_rate_scale_priv {
struct iwl_link_qualit... |
63fddb9f7f65b41277043344ae0d24dbbb451ada | Analyze and fix the following issue in the Linux kernel code: [PATCH] iwlwifi: removing unnecessary memset in 4965 rate scale | Problem Details:
This patch removes redundant memset in rate scale. In rs_alloc_sta,
kzalloc is used so the memset can be avoided. In rs_rate_init, it is
a bug fix since it overrides everything set in other handlers namely
add_debugfs.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zh... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
index edcc542c3b34..86e650dbddff 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
@@ -1776,10 +1776,9 @@ static void *rs_alloc_sta(void *priv, gfp_t gfp)
... |
c14c521e440a6a83835a2879a4c5f4311b1df68f | Analyze and fix the following issue in the Linux kernel code: [PATCH] iwlwifi: fix add_station to avoid FW error | Problem Details:
There were a few Firmware errors reported the most reproducible
http://bughost.org/bugzilla/show_bug.cgi?id=1471
The root cause is rate_n_flags isn't set anymore. This patch fixes
the problem.
Signed-off-by: Ian Schram <ischram@telenet.be>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John ... | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index dacf55ba0b7b..d153ca5f9573 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -464,6 +464,7 @@ u8 iwl_add_station(struct iwl_priv *priv, const u... |
46640a8ccebee34bd16b1af672feaa7dc320f3f6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] iwlwifi: Fix typo in rate sacling algorithm | Problem Details:
This patch fixes tiny typo in 4965 rate sacling algorithm
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
index bc5e67b0b0e2..edcc542c3b34 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
@@ -1672,7 +1672,7 @@ static void rs_initialize_lq(struct iwl_priv *priv,... |
279632be3f546f4d88bdb086fa71479bcde9d641 | Analyze and fix the following issue in the Linux kernel code: [PATCH] rfkill: Fix documentation typos | Problem Details:
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index f9a50dab4168..8909682415dc 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -29,9 +29,9 @@
/**
* enum rfkill_type - type of rfkill switch.
- * RFKILL_TYPE_WLAN: switch is no a Wireless network devices.
- * RFKILL_TYPE_BlU... |
53918994b7c8c3bf0af5f641e1f299856799d883 | Analyze and fix the following issue in the Linux kernel code: [PATCH] mac80211: fix iff_promiscs, iff_allmultis race | Problem Details:
When we update the counters iff_promiscs and iff_allmultis
in struct ieee80211_local we have no common lock held to
protect them. The problem is that the update to each counter
may not be atomic, so we could end up with iff_promiscs == -1
in unfortunate conditions. To fix it, use atomic_t values.
It do... | ```diff
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index b1180536c335..2501bff0d15e 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -59,10 +59,10 @@ static void ieee80211_configure_filter(struct ieee80211_local *local)
unsigned int changed_flags;
unsigned int new_flags ... |
50741ae05a4742cae99361f57d84b5f8d33822a4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] mac80211: fix TKIP IV update | Problem Details:
The TKIP IV should be updated only after MMIC verification,
this patch changes it to be at that spot.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 636de70cd85d..32d19bbf522c 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -153,6 +153,8 @@ struct ieee80211_txrx_data {
int sent_ps_buffered;
int queue;
int load;
+ u32 tkip_iv32;
+ u16 tkip_i... |
fb1c1cd6c5a8988b14c5c6c0dfe55542df3a34c6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] mac80211: fix vlan bug | Problem Details:
VLAN interfaces have yet another bug: they aren't accounted
for properly in the receive path in prepare_for_handlers().
I noticed this by code inspection, but it would be easy for
the compiler to catch such things if we'd just use the proper
enum where appropriate.
Signed-off-by: Johannes Berg <johann... | ```diff
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 52638194e45f..b1180536c335 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -344,6 +344,13 @@ static int ieee80211_open(struct net_device *dev)
if (!sdata->u.vlan.ap)
return -ENOLINK;
break;
+ case IEEE80211_... |
5b2812e925c8e976852867f8d760637c5926d817 | Analyze and fix the following issue in the Linux kernel code: [PATCH] mac80211: fix interface initialisation and deinitialisation | Problem Details:
When an interface is registered it is still uninitialised so
ieee80211_if_reinit() can't be called on it (it will oops.)
Hence, we need to move the uninit method assignment.
Also, this patch fixes the bug that the master device is never
initialised nor deinitialised at all. Oddly, the deinit code
had ... | ```diff
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index ccf84634f156..52638194e45f 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -265,7 +265,6 @@ void ieee80211_if_mgmt_setup(struct net_device *dev)
dev->open = ieee80211_mgmt_open;
dev->stop = ieee80211_mgmt_stop;
... |
fdd0abc8175dc43a14fe414a09fd7e6a162757bd | Analyze and fix the following issue in the Linux kernel code: [PATCH] rt2x00: Fix panic on rmmod with rfkill enabled | Problem Details:
When ieee80211_hw.config indicates that the radio
is enabled and is configuring options that require
the link tuner to be restarted the link tuner will
cause a kernel panic when rfkill has indicated the
radio was in fact disabled.
Signed-off-by: Modestas Vainius <modestas@vainius.eu>
Signed-off-by: Iv... | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 92b725263578..0216096c88cd 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -85,6 +85,9 @@ static void rt2x00lib_stop_link_tuner(struct rt2x00_dev *rt2x00dev)... |
dcf5475bc8458798794af9afafdb3ef33ab67fd9 | Analyze and fix the following issue in the Linux kernel code: [PATCH] rt2x00: Fix obvious typo in comment | Problem Details:
Signed-off-by: Modestas Vainius <modestas@vainius.eu>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt2500pci.c b/drivers/net/wireless/rt2x00/rt2500pci.c
index 929257d34ae4..842da900d7c1 100644
--- a/drivers/net/wireless/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/rt2x00/rt2500pci.c
@@ -244,7 +244,7 @@ static int rt2500pci_rfkill_poll(struct rt2x00_dev *rt2x00dev)
... |
3e30968e55e43ef08ee08c71258711a79c550f25 | Analyze and fix the following issue in the Linux kernel code: [PATCH] rt2x00: make rt2x00lib_stop_link_tuner() reentrant with link_tuner work | Problem Details:
Calling cancel_delayed_work_sync() unconditionally won't hurt
and it will avoid race conditions when another CPU is already
executing link_tuner work.
Signed-off-by: Modestas Vainius <modestas@vainius.eu>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdri... | ```diff
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index f8f7e6e47f80..e8c91fb71a52 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -80,8 +80,7 @@ static void rt2x00lib_start_link_tuner(struct rt2x00_dev *rt2x00dev... |
79010420cc3f78eab911598bfdd29c4b06a83e1f | Analyze and fix the following issue in the Linux kernel code: [PATCH] mac80211: fix virtual interface locking | Problem Details:
Florian Lohoff noticed a bug in mac80211: when bringing the
master interface down while other virtual interfaces are up
we call dev_close() under a spinlock which is not allowed.
This patch removes the sub_if_lock used by mac80211 in favour
of using an RCU list. All list manipulations are already done
... | ```diff
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 4e345f82f044..ccf84634f156 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -93,14 +93,13 @@ static int ieee80211_master_open(struct net_device *dev)
struct ieee80211_sub_if_data *sdata;
int res = -EOPNOTSUPP;
- ... |
1bc0826c8f5f3fa26644a8e878aae0be304a670f | Analyze and fix the following issue in the Linux kernel code: [PATCH] mac80211: renumber and document the hardware flags | Problem Details:
Currently, hardware flags that drivers must set are not
documented well enough. Fix this.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 494a4c022a9b..c5554ad87a17 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -598,6 +598,51 @@ typedef enum set_key_cmd {
SET_KEY, DISABLE_KEY,
} set_key_cmd;
+
+/**
+ * enum ieee80211_hw_flags - hardware flags
+ *
+ * The... |
58c14a8fe64d047218522cf2f18a2d7f24c12f51 | Analyze and fix the following issue in the Linux kernel code: [ATM] net/atm/lec.c: printk warning fix | Problem Details:
net/atm/lec.c: In function 'lec_start_xmit':
net/atm/lec.c:371: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/atm/lec.c b/net/atm/lec.c
index c909c76223e1..7eb1b21a0e94 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -368,7 +368,7 @@ static int lec_start_xmit(struct sk_buff *skb, struct net_device *dev)
#endif
entry = NULL;
vcc = lec_arp_resolve(priv, dst, is_rdesc, &entry);
- pr_debug("%s:vcc:%... |
0aa4f3331b1df09a500e1fda84145255303af573 | Analyze and fix the following issue in the Linux kernel code: [WIRELESS]: Fix Kconfig. | Problem Details:
Seems that a bare "depends" is no longer allowed in Sam's kbuild tree.
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index 6291f13bba09..6426055a8be0 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -3,7 +3,7 @@ config CFG80211
config NL80211
bool "nl80211 new netlink interface support"
- depends CFG80211
+ depends on CFG80211
default y
---help--... |
0c4e85813d0a94eeb8bf813397a4907bdd7bb610 | Analyze and fix the following issue in the Linux kernel code: [NET]: Wrap netdevice hardware header creation. | Problem Details:
Add inline for common usage of hardware header creation, and
fix bug in IPV6 mcast where the assumption about negative return is
an errno. Negative return from hard_header means not enough space
was available,(ie -N bytes).
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-... | ```diff
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index c05bc37df356..4bff23e3b970 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -286,7 +286,7 @@ static int bpq_xmit(struct sk_buff *skb, struct net_device *dev)
skb->protocol = ax25_type_tr... |
8b41d1887db718be9a2cd9e18c58ce25a4c7fd93 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix running without sysfs | Problem Details:
When sysfs support is compiled out the kernel still keeps and maintains
the kobject tree. So it is not safe to skip our kobject reference counting or
to avoid becoming members of the kobject tree. It is safe to not add
the networking specific sysfs attributes.
This patch removes the sysfs special ca... | ```diff
diff --git a/net/core/Makefile b/net/core/Makefile
index ea9b3f32d1c0..b1332f6d0042 100644
--- a/net/core/Makefile
+++ b/net/core/Makefile
@@ -11,7 +11,7 @@ obj-y += dev.o ethtool.o dev_mcast.o dst.o netevent.o \
neighbour.o rtnetlink.o utils.o link_watch.o filter.o
obj-$(CONFIG_XFRM) += flow.o
-ob... |
2e86908f7dfb71b67ca4739d9a6c678b83b01078 | Analyze and fix the following issue in the Linux kernel code: [CCID3]: Move NULL-protection into function | Problem Details:
This moves several instances of testing against NULL into the function which is
used to de-reference the CCID-private data.
Committer note: Made the BUG_ON depend on having CONFIG_IP_DCCP_CCID3_DEBUG, as it
is too much to have this on production code. Also made sure that
... | ```diff
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 0bb338be9dd7..a4099398bcc8 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -302,8 +302,6 @@ static int ccid3_hc_tx_send_packet(struct sock *sk, struct sk_buff *skb)
ktime_t now = ktime_get_real();
s64 delay;
- BUG_ON(hc... |
08831700cc65f85a497d6b32b1c83ca84d71de4a | Analyze and fix the following issue in the Linux kernel code: [DCCP]: Send Reset upon Sync in state REQUEST | Problem Details:
This fixes the code to correspond to RFC 4340, 7.5.4, which states the
exception that a Sync received in state REQUEST generates a Reset (not
a SyncAck).
To achieve this, only a small change is required. Since
dccp_rcv_request_sent_state_process() already uses the correct Reset Code
number 4 ("Packet ... | ```diff
diff --git a/net/dccp/input.c b/net/dccp/input.c
index cde0e704dfce..86ad3ba0649a 100644
--- a/net/dccp/input.c
+++ b/net/dccp/input.c
@@ -540,11 +540,6 @@ int dccp_rcv_state_process(struct sock *sk, struct sk_buff *skb,
return 0;
}
- if (unlikely(dh->dccph_type == DCCP_PKT_SYNC)) {
- dccp_send_sync(sk,... |
e155d7692290f7bc539ccb8ebc3450ec964e53fd | Analyze and fix the following issue in the Linux kernel code: [DCCP]: Fix Reset/Sync-Flood Bug | Problem Details:
This updates sequence number checking with regard to RFC 4340, 7.5.4.
Missing in the code was an exception for sequence-invalid Reset packets,
which get a Sync acknowledging GSR, instead of (as usual) P.seqno.
This can lead to an oscillating ping-pong flood of Reset packets.
In fact, it has been obse... | ```diff
diff --git a/net/dccp/input.c b/net/dccp/input.c
index 6276b23fc204..cde0e704dfce 100644
--- a/net/dccp/input.c
+++ b/net/dccp/input.c
@@ -102,9 +102,6 @@ static int dccp_check_seqno(struct sock *sk, struct sk_buff *skb)
* Update S.GSR, S.SWL, S.SWH
* If P.type != Sync,
* Update S.GAR
- * ... |
fa5fea711f4c3bd71f00181d6f385ef4d53ab375 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: rename ieee80211_cfg.c to cfg.c | Problem Details:
It's just painful to have the extra ieee80211_ prefix.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/mac80211/Makefile b/net/mac80211/Makefile
index 793733835628..219cd9f9341f 100644
--- a/net/mac80211/Makefile
+++ b/net/mac80211/Makefile
@@ -17,7 +17,7 @@ mac80211-objs := \
regdomain.o \
tkip.o \
aes_ccm.o \
- ieee80211_cfg.o \
+ cfg.o \
rx.o \
tx.o \
key.o \
diff --git a/net/mac8... |
693d454dffd43b2bab021d0e039a0c426181c1b0 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: fix warnings introduced by the doc patches | Problem Details:
This fixes a warning about NUM_IEEE80211_MODES missing
in a switch statement. Intentionally do not add a default
case so we get warnings at these places if we need to add
new modes.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-... | ```diff
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 29c0a0e1f52c..5a0564e1dbd6 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -98,6 +98,9 @@ void ieee80211_prepare_rates(struct ieee80211_local *local,
rate->rate == 55 || rate->rate == 110)
rate->flags |= IEEE80211_RATE_BASIC... |
ac630c2b1933e79ff32e3653ae656620cf4b4c79 | Analyze and fix the following issue in the Linux kernel code: [LIBERTAS]: fix oops on the blackfin architecture | Problem Details:
Fixing memory alignment problems on the blackfin architecture (maybe on the
ARM also)
Signed-off-by: Vladimir Davydov <vladimir.davydov@promwad.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c
index 8f073ad1957f..fab93d8fe9c7 100644
--- a/drivers/net/wireless/libertas/scan.c
+++ b/drivers/net/wireless/libertas/scan.c
@@ -13,6 +13,8 @@
#include <net/ieee80211.h>
#include <net/iw_handler.h>
+#include <asm/unali... |
f31ce76b781d15ab6b529663b95223f58171ec80 | Analyze and fix the following issue in the Linux kernel code: [LIBERTAS]: fix oops on the blackfin architecture | Problem Details:
Reserve two bytes to align pointer to the IP header.
Signed-off-by: Vladimir Davydov <vladimir.davydov@promwad.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index e74ec5c309be..0360cad363a8 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -402,10 +402,12 @@ static struct sk_buff *if_cs_receive_data(wlan_private *priv)
}
/... |
28de0b36be2a4e7fb0ba7c9a77d61aeb229b27c0 | Analyze and fix the following issue in the Linux kernel code: [LIBERTAS]: fix interrupts in CF driver | Problem Details:
The following patch fixes the tx transmit timeout problem, which is
caused by the interrupts being incorrectly check and masked. The patch
moves the interrupt masking code so that interrupts are enabled only
when the driver is registered and only disabled when the driver is
unregistered.
Signed-off-by... | ```diff
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index 364da4cac214..e74ec5c309be 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -248,22 +248,26 @@ static irqreturn_t if_cs_interrupt(int irq, void *data)
lbs_deb_enter... |
6f05cbe5882e8b0fc5a984313cbb14ce7741411b | Analyze and fix the following issue in the Linux kernel code: [LIBERTAS]: set dnld_sent correctly for CF parts | Problem Details:
Corrects a minor bug with priv->dnld_sent being set incorrectly in
if_cs_host_to_card.
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index 09c87df5c2fd..364da4cac214 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -617,11 +617,12 @@ static int if_cs_host_to_card(wlan_private *priv, u8 type, u8 *buf, u16... |
61609bc0e4d3bc677ecdccf216a0a77563f52457 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: Add support for setting TX power and radio status | Problem Details:
This adds support for disabling the radio and setting the TXpower
through wext.
This also fixes the prism TXpower ioctl (It always overwrote the TXpower
value in ieee80211_hw_config())
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: ... | ```diff
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 4229d150e783..23853331e8db 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -704,7 +704,12 @@ int ieee80211_hw_config(struct ieee80211_local *local)
local->hw.conf.channel = chan->chan;
local->hw.conf.channel_val... |
501d857ec93e797d4872d6b9b265b7472b455ddf | Analyze and fix the following issue in the Linux kernel code: [IEEE80211]: Fix softmac lockdep reports. | Problem Details:
It seems I was actually able to hit this deadlock, on my quad G5 softmac
locks up more often than not. This fixes it by using an own workqueue
that can safely be flushed under RTNL.
Not sure if the patch is correct with the workqueue naming. And don't
think with the patch it doesn't continually lock u... | ```diff
diff --git a/include/net/ieee80211softmac.h b/include/net/ieee80211softmac.h
index 89119277553d..1ef6282fdded 100644
--- a/include/net/ieee80211softmac.h
+++ b/include/net/ieee80211softmac.h
@@ -229,6 +229,8 @@ struct ieee80211softmac_device {
/* this lock protects this structure */
spinlock_t lock;
+ str... |
6b9bafec6608539d07f7ccdeefe121dabe06604f | Analyze and fix the following issue in the Linux kernel code: [SSB]: Sparse fixes. | Problem Details:
This fixes all Sparse warnings in SSB.
No semantics change.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/ssb/b43_pci_bridge.c b/drivers/ssb/b43_pci_bridge.c
index fa3bd292f5f7..f145d8a4cfde 100644
--- a/drivers/ssb/b43_pci_bridge.c
+++ b/drivers/ssb/b43_pci_bridge.c
@@ -13,6 +13,8 @@
#include <linux/pci.h>
#include <linux/ssb/ssb.h>
+#include "ssb_private.h"
+
static const struct pci_de... |
01449c5a469c8c1c647cfd3705b1ff290be6afff | Analyze and fix the following issue in the Linux kernel code: [BCM43XX]: Change radio hardware switch status printk from debug to regular | Problem Details:
Some distros ship bcm43xx with debugging printout disabled. For those
BCM43xx devices with radio on/off switches, this makes it impossible
to know if the radio is on or off. This patch changes a pair of debug
printk's into ordinary printk's. It also changes the message that
prints when the radio is ini... | ```diff
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
index e038d072398d..45683437a98d 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -2380,7 +2380,7 @@ static int bcm43xx_chip_init(struct bcm43xx_pri... |
5af4ec236f7c98f3671fb26731457a172d85e0e6 | Analyze and fix the following issue in the Linux kernel code: [TCP]: clear_all_retrans_hints prefixed by tcp_ | Problem Details:
In addition, fix its function comment spacing.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> | ```diff
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 4ba256a3f5e0..d78ad9bfcfa7 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1066,8 +1066,8 @@ static inline void tcp_mib_init(void)
TCP_ADD_STATS_USER(TCP_MIB_MAXCONN, -1);
}
-/*from STCP */
-static inline void clear_all_retrans_hints(struc... |
1a09404a2338163f181d170c7abdc2242b6c6f03 | Analyze and fix the following issue in the Linux kernel code: [B43]: Fix sparse warnings. | Problem Details:
The remaining warning in phy.c will be fixed later.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/wireless/b43/debugfs.c b/drivers/net/wireless/b43/debugfs.c
index f82e3ef9bd73..3aafde9f08a8 100644
--- a/drivers/net/wireless/b43/debugfs.c
+++ b/drivers/net/wireless/b43/debugfs.c
@@ -39,7 +39,7 @@
/* The root directory. */
-struct dentry *rootdir;
+static struct dentry *rootdir;... |
05d2fec9f5e5fd1d7169435631b9d55ae4c566d1 | Analyze and fix the following issue in the Linux kernel code: amd8111e big-endian fix | Problem Details:
amd8111e_calc_coalesce() ends up with insane values of tx_data_rate since
->tx_bytes increments missing conversion from little- to host-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c
index babe0de2ce44..1cc74ec88a58 100644
--- a/drivers/net/amd8111e.c
+++ b/drivers/net/amd8111e.c
@@ -709,7 +709,8 @@ static int amd8111e_tx(struct net_device *dev)
lp->tx_complete_idx++;
/*COAL update tx coalescing parameters */
lp->coal_con... |
cf9830195a3f35b1248425b69a01ee43f5b68221 | Analyze and fix the following issue in the Linux kernel code: fix vlan in 8139cp on big-endian | Problem Details:
Layout of opts2 is
: MSB(vlan_tag) : LSB(vlan_tag) : flags : 0 :
regardless of the host endianness. On little-endian
the current code ends up with the right values, but
on big-endian it blows. In r8169.c the same bug
had been fixed in commit d35da12a40426184b1d0844104b1d464753eba19
(r8169: endianness... | ```diff
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index abb2a3471087..a453eda834d5 100644
--- a/drivers/net/8139cp.c
+++ b/drivers/net/8139cp.c
@@ -78,7 +78,7 @@
#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
#define CP_VLAN_TAG_USED 1
#define CP_VLAN_TX_TAG(tx_desc,vlan_tag_value... |
200eef20db6de7535438c9af9becc8169c6cb6c0 | Analyze and fix the following issue in the Linux kernel code: netxen: ethtool fixes | Problem Details:
Resubmitting the patch.
This patch improves ethtool support for printing correct ring statistics,
segmentation offload status, etc.
Signed-off by: Dhananjay Phadke <dhananjay@netxen.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h
index 7bbd5d14175f..fbc2553275dc 100644
--- a/drivers/net/netxen/netxen_nic.h
+++ b/drivers/net/netxen/netxen_nic.h
@@ -919,7 +919,7 @@ struct netxen_adapter {
u16 link_duplex;
u16 state;
u16 link_autoneg;
- int rcsum;
+ int rx... |
2fd37688455857b7b92bc2b1379a4c48aa9af147 | Analyze and fix the following issue in the Linux kernel code: S2io: Added support set_mac_address driver entry point | Problem Details:
- Added set_mac_address driver entry point
- Copying permanent mac address to dev->perm_addr
- Incorporated following review comments from Jeff
- Converted the macro to a function and removed call to memset
- regarding function naming convention, for all callbacks and entry points
will... | ```diff
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 3885f6b83cc3..01e4b1c26a36 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -355,6 +355,16 @@ static char ethtool_driver_stats_keys[][ETH_GSTRING_LEN] = {
timer.data = (unsigned long) arg; \
mod_timer(&timer, (jiffies + exp)) \
+/* ... |
52886051ffdc087a4f7f11540395fd64040101ad | Analyze and fix the following issue in the Linux kernel code: [SKBUFF]: Fix up csum_start when head room changes | Problem Details:
Thanks for noticing the bug where csum_start is not updated
when the head room changes.
This patch fixes that. It also moves the csum/ip_summed
copying into copy_skb_header so that skb_copy_expand gets
it too. I've checked its callers and no one should be upset
by this.
Signed-off-by: Herbert Xu <h... | ```diff
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 35021eb3ed07..944189d96323 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -472,6 +472,9 @@ static void copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
#ifdef CONFIG_INET
new->sp = secpath_get(old->sp);
#endif
+ new->csum_st... |
0cfad07555312468296ea3bbbcdf99038f58678b | Analyze and fix the following issue in the Linux kernel code: [NETLINK]: Avoid pointer in netlink_run_queue | Problem Details:
I was looking at Patrick's fix to inet_diag and it occured
to me that we're using a pointer argument to return values
unnecessarily in netlink_run_queue. Changing it to return
the value will allow the compiler to generate better code
since the value won't have to be memory-backed.
Signed-off-by: Herb... | ```diff
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 695e613a207b..83113dfcbd04 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -220,7 +220,7 @@ struct nl_info {
u32 pid;
};
-extern void netlink_run_queue(struct sock *sk, unsigned int *qlen,
+extern unsigned int netlink_run... |
ad7379d49458a863c520a73a3c36441c572f850e | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix the prototype of call_netdevice_notifiers. | Problem Details:
This replaces the void * parameter with a struct net_device * which
is what is actually required.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 96964fb7478b..cf89ce677e41 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -792,7 +792,7 @@ extern void free_netdev(struct net_device *dev);
extern void synchronize_net(void);
extern int register_netdevice_n... |
596c5c97431eab8465739c169401ea611127b9ad | Analyze and fix the following issue in the Linux kernel code: S2io: code Optimization of isr function | Problem Details:
- Code Optimization of s2io_isr function.
- Isr check using per device napi variable instead of driver global.
- Reduced from 3 to 1 if condition before check for processing packet receive
packets.
- Implemented Jeff's comment to use synchronize_irq. Removed the isr_cnt
variable as it became redund... | ```diff
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index d167bc0ae951..ac6b9b93c025 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -84,7 +84,7 @@
#include "s2io.h"
#include "s2io-regs.h"
-#define DRV_VERSION "2.0.26.1"
+#define DRV_VERSION "2.0.26.2"
/* S2io Driver name & version. */
stat... |
8116f3cf4a2a5a4fa2335e6f32023ac50506698f | Analyze and fix the following issue in the Linux kernel code: [S2IO]: Handle and monitor all of the device errors and alarms | Problem Details:
- Added support to poll entire set of device errors and alarams.
- A note on how device errors and alarms are handled:
- The adapter will automatically recover from uncorrectable ECC errors.
Packets containing corrupted data will be dropped (not transmitted) or tagged
as invalid before being passed... | ```diff
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 63473027b463..182643ff81e5 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -263,7 +263,14 @@ static char ethtool_driver_stats_keys[][ETH_GSTRING_LEN] = {
{"serious_err_cnt"},
{"soft_reset_cnt"},
{"fifo_full_cnt"},
- {"ring_full_cnt"},
... |
1c17ae8af93bed203d9760702882e9f747a51912 | Analyze and fix the following issue in the Linux kernel code: cxgb3 - Set the CQ_ERR bit in CQ contexts. | Problem Details:
The cxgb3 driver is incorrectly configuring the HW CQ context for CQ's
that use overflow-avoidance. Namely the RDMA control CQ. This results
in a bad DMA from the device to bus address 0. The solution is to set
the CQ_ERR bit in the context for these types of CQs.
Signed-off-by: Divy Le Ray <divy@c... | ```diff
diff --git a/drivers/net/cxgb3/sge_defs.h b/drivers/net/cxgb3/sge_defs.h
index 514869e26a76..29b6c800b238 100644
--- a/drivers/net/cxgb3/sge_defs.h
+++ b/drivers/net/cxgb3/sge_defs.h
@@ -106,6 +106,10 @@
#define V_CQ_GEN(x) ((x) << S_CQ_GEN)
#define F_CQ_GEN V_CQ_GEN(1U)
+#define S_CQ_ERR 30
+#define ... |
38bf3184e8c4b8cd4285a24b6f69a300b32f0062 | Analyze and fix the following issue in the Linux kernel code: pasemi_mac: Fix RX checksum flags | Problem Details:
RX side flag to use is CHECKSUM_UNNECESSARY, not CHECKSUM_COMPLETE.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
index dc710a0826b2..0bfdd79de6cf 100644
--- a/drivers/net/pasemi_mac.c
+++ b/drivers/net/pasemi_mac.c
@@ -524,7 +524,7 @@ static int pasemi_mac_clean_rx(struct pasemi_mac *mac, int limit)
skb_put(skb, len);
if (likely((macrx & XCT_MACRX_HT... |
021fa22e01d3d0425d3d15df48f523b69a3a11c4 | Analyze and fix the following issue in the Linux kernel code: pasemi_mac: Fix TX ring wrap checking | Problem Details:
The old logic didn't detect full (tx) ring cases properly, causing
overruns and general badness. Clean it up a bit and abstract out the
ring size checks, always making sure to leave 1 slot open.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
index 4836d405cd5d..dc710a0826b2 100644
--- a/drivers/net/pasemi_mac.c
+++ b/drivers/net/pasemi_mac.c
@@ -69,6 +69,10 @@
#define RX_DESC_INFO(mac, num) ((mac)->rx->desc_info[(num) & (RX_RING_SIZE-1)])
#define RX_BUFF(mac, num) ((mac)->rx->buffer... |
73344863e426a3c56c7f3ac80fc6f1d4cb10460b | Analyze and fix the following issue in the Linux kernel code: pasemi_mac: Fix memcpy amount for short receives | Problem Details:
Fix up memcpy for short receives.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
index 46d5c0eef784..0d80b9d48c26 100644
--- a/drivers/net/pasemi_mac.c
+++ b/drivers/net/pasemi_mac.c
@@ -506,9 +506,7 @@ static int pasemi_mac_clean_rx(struct pasemi_mac *mac, int limit)
netdev_alloc_skb(mac->netdev, len + NET_IP_ALIGN);
... |
6e3f03b72c1e11e19ea233a411a782f7231ba13f | Analyze and fix the following issue in the Linux kernel code: cxgb3 - SGE doorbell overflow warning | Problem Details:
Log doorbell Fifo overflow
Signed-off-by: Divy Le Ray <divy@chelsio.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/cxgb3/regs.h b/drivers/net/cxgb3/regs.h
index aa80313c922e..282427877ea9 100644
--- a/drivers/net/cxgb3/regs.h
+++ b/drivers/net/cxgb3/regs.h
@@ -172,6 +172,14 @@
#define A_SG_INT_CAUSE 0x5c
+#define S_HIPIODRBDROPERR 11
+#define V_HIPIODRBDROPERR(x) ((x) << S_HIPIODRBDROPERR)
+... |
4ecd41bd0ff5dfcb4f2c59d980f9196c160882be | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: printk warning fixes | Problem Details:
drivers/net/wireless/libertas/if_cs.c: In function 'if_cs_prog_helper':
drivers/net/wireless/libertas/if_cs.c:462: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
drivers/net/wireless/libertas/if_cs.c: In function 'if_cs_prog_real':
drivers/net/wireless/libertas/if_cs.c:538: w... | ```diff
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index 4dffc5cc0d1a..09c87df5c2fd 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -459,7 +459,7 @@ static int if_cs_prog_helper(struct if_cs_card *card)
ret = -ENODEV;
... |
70500f5443be1b27ea2c9ab71ce9dc2250af7b19 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: region code values specified as 8bit | Problem Details:
This patch strips away possible mess in regioncode (eg. on my card - 88W8305
chipset - I get 0x3031 instead of expected 0x0031 and as a result the driver
defaults to USA region which is obviously incorrect). Following patch fixes
the issue.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off... | ```diff
diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 4c36e63ae7b0..d64ad87db459 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -174,7 +174,11 @@ static int wlan_ret_get_hw_spec(wlan_private * priv,
lbs_deb_c... |
b1b1907dceadddc7d7317f8ae85a5efec44125d8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix inadvertant removal of bits from commit 831441862956fffa17b9801db37e6ea1650b0f69 | Problem Details:
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c
index f0213eca680b..ce1c18ee6280 100644
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -768,6 +768,7 @@ static int libertas_thread(void *data)
init_waitqueue_entry(&wait, curren... |
ffe143741f9e0fc3731fe6fe977a2273da4837bd | Analyze and fix the following issue in the Linux kernel code: [PATCH] zd1211rw: removed noisy debug messages | Problem Details:
While developing the driver we added a lot of debug messages for
setting hardware registers. These messages make the reading of the
log files difficult and are of no use anymore. This patch removes
those messages in zd_chip.c.
Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
Signed-off-by: Daniel Dr... | ```diff
diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
index c39f1984b84d..7e3c0625129b 100644
--- a/drivers/net/wireless/zd1211rw/zd_chip.c
+++ b/drivers/net/wireless/zd1211rw/zd_chip.c
@@ -500,8 +500,6 @@ int zd_chip_lock_phy_regs(struct zd_chip *chip)
return r;
}
... |
c77dd43e77c530a12a466865805d2068ede96860 | Analyze and fix the following issue in the Linux kernel code: S2IO: Fixes in MSIX related code. | Problem Details:
- Calling store_xmsi_data to store the MSI-X datas during initialization
in s2io-init_nic function
- Disabling NAPI when MSI-X is enabled
- Freeing sp->entries and sp->s2io_entries in s2io_rem_isr
Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com>
Signed-off-by: Ramkrishna Vepa <r... | ```diff
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 588938204e20..e7b432c508f9 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -3892,6 +3892,12 @@ static int s2io_open(struct net_device *dev)
}
}
+ /* NAPI doesn't work well with MSI(X) */
+ if (sp->intr_type != INTA) {
+ if(sp->confi... |
8362cd413e8116306fafbaf414f0419db0595142 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix sparse-reported problems | Problem Details:
A few fields being converted to the wrong sized type, and a few missed
endian conversions.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/11d.c b/drivers/net/wireless/libertas/11d.c
index 8b366ef2fe95..9cf0211de67f 100644
--- a/drivers/net/wireless/libertas/11d.c
+++ b/drivers/net/wireless/libertas/11d.c
@@ -543,7 +543,7 @@ int libertas_cmd_802_11d_domain_info(wlan_private * priv,
nr_subband * ... |
81173e34d454c353d9f0a53760609f3b9d30a311 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix misspelling in debug message | Problem Details:
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/assoc.c b/drivers/net/wireless/libertas/assoc.c
index ffeec2fa60ae..3131afcf4590 100644
--- a/drivers/net/wireless/libertas/assoc.c
+++ b/drivers/net/wireless/libertas/assoc.c
@@ -622,7 +622,7 @@ void libertas_association_worker(struct work_struct *work)
}
if (... |
b031ac10264fa9b805d84b4a440407ac950390cf | Analyze and fix the following issue in the Linux kernel code: [PATCH] drivers/net/wireless/libertas/cmd.c: fix adapter->driver_lock dereference | Problem Details:
adapter is NULL if cmdnode is not.
Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c
index 257d6443f6c7..72e8e27a6fb7 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -958,7 +958,7 @@ static int DownloadcommandToStation(wlan_private * priv,
unsigned long flags;
... |
5707708111ca6c4e9a1160acffdc98a98d95e462 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix assignment of WEP key type | Problem Details:
keytype is a u8
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c
index cd3bddb243b1..257d6443f6c7 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -181,15 +181,13 @@ static int wlan_cmd_802_11_set_wep(wlan_private * priv,
switch (pkey->len... |
9483f03150cbfa1f706355b7f9d218d6086c6fce | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix a few wext abuses... | Problem Details:
o SIOCGIWNAME is not designed to return the version number of the driver.
On the other hand, you are free to abuse SIOCGIWNICKN for that purpose.
o Don't attempt to fix the WE19/WE20 transition in the driver, because
your fixes are bogus, and redundant with the code in the kernel (you may
endup with +... | ```diff
diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c
index 1fb0f91e538a..15395bf0a2ac 100644
--- a/drivers/net/wireless/libertas/wext.c
+++ b/drivers/net/wireless/libertas/wext.c
@@ -21,52 +21,6 @@
#include "assoc.h"
-/**
- * @brief Convert mw value to dbm value
- *
- *... |
b37e5842f5ab66f8d0533ee62ffe35c26ae800a3 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: revert CAPINFO_MASK to its original value | Problem Details:
CAPINFO_MASK changed on commits 981f187b and a091095b. Reverting to the original
value. Also move CAPINFO_MASK into the sole user, join.c. CAPINFO_MASK
should be in host CPU byte order; capability is converted to device
byte order elsewhere.
This fixes OLPC ticket #2161
Signed-off-by: Luis Carlos C... | ```diff
diff --git a/drivers/net/wireless/libertas/join.c b/drivers/net/wireless/libertas/join.c
index 0ebf2f8acbf1..ccb0df1967fb 100644
--- a/drivers/net/wireless/libertas/join.c
+++ b/drivers/net/wireless/libertas/join.c
@@ -20,6 +20,10 @@
/* Supported rates for ad-hoc B mode */
static u8 adhoc_rates_b[5] = { 0x02,... |
9556d2120ceecc158b324fa01e30704ff9f42ae3 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix two debug statements in cmdresp.c | Problem Details:
Purely cosmetic: this moves an lbs_deb_enter() to the proper place
and changes an erraneous lbs_deb_enter_args() into lbs_deb_leave_args()
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 53671e96b043..93bf63bad0f6 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -867,12 +867,12 @@ int libertas_process_event(wlan_private * priv)
wlan_adapter ... |
a2235ed40210081e51bec4bb1be64e4b3511501e | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: remove bss_descriptior->networktsf | Problem Details:
This value was parsed out, but then nowhere used ... except in
some debugfs output. I can't imagine anyone wanting to use this
value for anything real (as no other driver exports it), so
bye-bye.
Along this, made the columns of
/sys/kernel/debug/libertas_wireless/*/getscantable align again.
Signed-of... | ```diff
diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index 4b9533a66511..63e747ac49d0 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -66,7 +66,7 @@ static ssize_t libertas_getscantable(struct file *file, char __user... |
b20c520763a6fe1aabde27f6ba017a67f22f90d5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix WEXT quality reporting | Problem Details:
Found by Ronak and others at Marvell.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/wext.c b/drivers/net/wireless/libertas/wext.c
index e8c0629f9a4b..7d14f9c2aff6 100644
--- a/drivers/net/wireless/libertas/wext.c
+++ b/drivers/net/wireless/libertas/wext.c
@@ -949,7 +949,7 @@ static struct iw_statistics *wlan_get_wireless_stats(struct net_device *dev)
... |
4d4ce1ad02f02e593086fabdad69953ecbd99d9c | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: remove unused adapter->prev_XXXX variables | Problem Details:
There were just used in some debug output, but nowhere else.
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index bf672f51f163..8e99c2de1835 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -65,18 +65,9 @@ void libertas_mac_event_disconnected(wlan_private * priv)
... |
ece561919326236c7fb791a5e883f0eb76af029e | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: make the hex dumper nicer | Problem Details:
Currently, when you define LBS_DEB_HEX, you get every hex dump in the
whole driver, e.g. for LBS_DEB_CMD, LBS_DEB_RX, LBS_DEB_TX etc. This
patch makes sure that you only get the hexdump that you're interested in.
Renamed lbs_dbg_hex() into lbs_deb_hex(), like the other lbs_deb_XXX()
macros.
Made lbs_... | ```diff
diff --git a/drivers/net/wireless/libertas/11d.c b/drivers/net/wireless/libertas/11d.c
index ba4cbcb59113..8b366ef2fe95 100644
--- a/drivers/net/wireless/libertas/11d.c
+++ b/drivers/net/wireless/libertas/11d.c
@@ -124,17 +124,17 @@ static u8 wlan_channel_known_11d(u8 chan,
u8 nr_chan = parsed_region_chan->nr... |
c95c7f930ec6fee029c8e7957ab95b3967578070 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: uppercase some #defines | Problem Details:
Usually constants defined by #define are in ALL_UPPERCASE. This patch
fixes this.
I also shuffled the bits around so that they match the bit positions in the
host-interrupt-state register of the CF/SDIO card :-)
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linvil... | ```diff
diff --git a/drivers/net/wireless/libertas/defs.h b/drivers/net/wireless/libertas/defs.h
index a1c6dae1ba46..eee8a49e358f 100644
--- a/drivers/net/wireless/libertas/defs.h
+++ b/drivers/net/wireless/libertas/defs.h
@@ -159,9 +159,11 @@ static inline void lbs_dbg_hex(char *prompt, u8 * buf, int len)
#define MAR... |
c23a24f6ae083e058ed1e9472979df09915ffdf5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix one more sparse warning | Problem Details:
adhoc_rates_b is only used locally, so make it static
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/join.c b/drivers/net/wireless/libertas/join.c
index 78e398d6f5f3..f71c172101a8 100644
--- a/drivers/net/wireless/libertas/join.c
+++ b/drivers/net/wireless/libertas/join.c
@@ -18,7 +18,7 @@
#include "assoc.h"
/* Supported rates for ad-hoc B mode */
-u8 adhoc_rates_... |
e52414728b930f0adcbc38c6498dd03b3568fe99 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: wlan_ -> libertas_ function prefix renames for main.c | Problem Details:
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c
index 589c583ddbeb..26948595d952 100644
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -256,7 +256,7 @@ static int pre_open_check(struct net_device *dev)
* @param dev A point... |
ffcae953ac021f5051a201c18e133cb0ce38c2b9 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix more mixed-case abuse | Problem Details:
Mistakently introduced by a previous patch to upper-case all command
constants.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c
index 401a630ed4e5..c96ced963d69 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -566,7 +566,7 @@ static int wlan_cmd_802_11_rf_antenna(wlan_private * priv,
S_DS_GEN);
ra... |
2ca10e6d6a3052e7a8380b20588a7b1985ea1197 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix debug build breakage due to field rename | Problem Details:
Missed when fixing mixed-case structure field names.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/join.c b/drivers/net/wireless/libertas/join.c
index 3530c23da798..381739d6ed96 100644
--- a/drivers/net/wireless/libertas/join.c
+++ b/drivers/net/wireless/libertas/join.c
@@ -845,7 +845,7 @@ int libertas_ret_80211_ad_hoc_start(wlan_private * priv,
lbs_deb_join("ADHO... |
b44898eb2c917cd397a0d8654f1c249dd3cdc67e | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix mixed-case abuse in cmd_ds_802_11_ad_hoc_start | Problem Details:
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/hostcmd.h b/drivers/net/wireless/libertas/hostcmd.h
index 6b5e58c88c4e..23871c0f882a 100644
--- a/drivers/net/wireless/libertas/hostcmd.h
+++ b/drivers/net/wireless/libertas/hostcmd.h
@@ -439,7 +439,7 @@ struct cmd_ds_802_11_rate_adapt_rateset {
};
struct cmd_ds_80... |
ea8da92d70c4e320c282d4e94138e40e36880be3 | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix mixed-case abuse in cmd_ds_802_11_ad_hoc_result | Problem Details:
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/hostcmd.h b/drivers/net/wireless/libertas/hostcmd.h
index e4fafbfa358d..6b5e58c88c4e 100644
--- a/drivers/net/wireless/libertas/hostcmd.h
+++ b/drivers/net/wireless/libertas/hostcmd.h
@@ -237,8 +237,8 @@ struct cmd_ds_802_11_associate_rsp {
};
struct cmd_ds_802_11_... |
492b6da7d220b37275efb03710d57215304149fa | Analyze and fix the following issue in the Linux kernel code: [PATCH] libertas: fix mixed-case abuse in cmd_ds_802_11_scan | Problem Details:
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/wireless/libertas/hostcmd.h b/drivers/net/wireless/libertas/hostcmd.h
index 05ea54df71bd..e4fafbfa358d 100644
--- a/drivers/net/wireless/libertas/hostcmd.h
+++ b/drivers/net/wireless/libertas/hostcmd.h
@@ -159,7 +159,7 @@ struct cmd_ds_802_11_subscribe_event {
*/
struct cmd_ds_802_11... |
475fa49c125d914451805a9fb3cd1baa53591538 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: PS mode fix | Problem Details:
tx.mode must be set also for buffered frames. It is used in the tx hanlders
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index acfc3054d467..ca262a99e56f 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1901,6 +1901,7 @@ ieee80211_get_buffered_bc(struct ieee80211_hw *hw, int if_id,
}
sta = tx.sta;
tx.flags |= IEEE80211_TXRXD_TXPS_BUFFERED;
+ tx.u.tx.mode = local->... |
d4e46a3d9869563c6210b01bb651c40cbe65da80 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: fix race conditions with keys | Problem Details:
During receive processing, we select the key long before using it and
because there's no locking it is possible that we kfree() the key
after having selected it but before using it for crypto operations.
Obviously, this is bad.
Secondly, during transmit processing, there are two possible races: We
hav... | ```diff
diff --git a/net/mac80211/ieee80211_ioctl.c b/net/mac80211/ieee80211_ioctl.c
index 1d585cc2c8c7..10ec05624a67 100644
--- a/net/mac80211/ieee80211_ioctl.c
+++ b/net/mac80211/ieee80211_ioctl.c
@@ -73,11 +73,8 @@ static int ieee80211_set_encryption(struct net_device *dev, u8 *sta_addr,
key = NULL;
} else {
... |
c29b9b9b0235d56e5602f61ed38702dd376aae20 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: don't send invalid QoS frames | Problem Details:
Kalle Valo noticed that QoS frames are sent with an invalid QoS control
field; this is because we increase the header length but neither
initialise the space nor actually have enough space in the header
structure for the QoS control field.
This patch fixes it by treating the QoS field specially and ap... | ```diff
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 9e952e37b7df..0820f127da2b 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1487,7 +1487,20 @@ int ieee80211_subif_start_xmit(struct sk_buff *skb,
nh_pos += encaps_len;
h_pos += encaps_len;
}
- memcpy(skb_push(skb, hdrlen), &hdr, hdrlen)... |
077130c0cf7d5ba1992f5b51b96136d7b1c8aad5 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix race when opening a proc file while a network namespace is exiting. | Problem Details:
The problem: proc_net files remember which network namespace the are
against but do not remember hold a reference count (as that would pin
the network namespace). So we currently have a small window where
the reference count on a network namespace may be incremented when opening
a /proc file when it... | ```diff
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
index 358930a3142a..85cc8e8bb862 100644
--- a/fs/proc/proc_net.c
+++ b/fs/proc/proc_net.c
@@ -51,6 +51,12 @@ void proc_net_remove(struct net *net, const char *name)
}
EXPORT_SYMBOL_GPL(proc_net_remove);
+struct net *get_proc_net(const struct inode *inode)... |
4fabcd7118162e36eea5c53e8895ecc13762bef3 | Analyze and fix the following issue in the Linux kernel code: [NETNS]: Fix allnoconfig compilation error. | Problem Details:
When CONFIG_NET=no, init_net is unresolved because net_namespace.c
is not compiled and the include pull init_net definition.
This problem was very similar with the ipc namespace where the kernel
can be compiled with SYSV ipc out.
This patch fix that defining a macro which simply remove init_net
initi... | ```diff
diff --git a/include/linux/init_task.h b/include/linux/init_task.h
index e2c1ffcff62c..513bc3e489f0 100644
--- a/include/linux/init_task.h
+++ b/include/linux/init_task.h
@@ -79,7 +79,7 @@ extern struct nsproxy init_nsproxy;
.nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \
.uts_ns = &init_uts_ns, \
... |
a050c33f4a4d5babaf94a8ba6ae7a200135240b3 | Analyze and fix the following issue in the Linux kernel code: [NETNS]: Fix bad macro definition. | Problem Details:
The macro definition is bad. When calling next_net_device with
parameter name "dev", the resulting code is:
struct net_device *dev = dev and that leads to an unexpected
behavior. Especially when llc_core is compiled in, the kernel panics
at boot time.
The patchset change macro definition with static... | ```diff
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 407658c64fb6..625240ce27f1 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -41,7 +41,8 @@
#include <linux/dmaengine.h>
#include <linux/workqueue.h>
-struct net;
+#include <net/net_namespace.h>
+
struct vlan_g... |
abf07acbb9f122218095d0d221e0f949160ccc37 | Analyze and fix the following issue in the Linux kernel code: [NETNS]: Fix loopback network namespace initialization. | Problem Details:
The core patchset of the network namespace sent by
Eric Biederman does not do dynamic loopback creation.
So there is no call to alloc_netdev_mq which fills the
network namespace field of the netdevice.
This patch assign the loopback to the init network namespace.
Signed-off-by: Daniel Lezcano <dlezca... | ```diff
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index e399f7b201e3..a328da72833c 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -225,6 +225,7 @@ struct net_device loopback_dev = {
| NETIF_F_LLTX
| NETIF_F_NETNS_LOCAL,
.ethtool_ops = &loopback_ethtool_ops,
+ .nd... |
36ac3135f5e824942fada4efa3204066b4b40ab1 | Analyze and fix the following issue in the Linux kernel code: [NETNS]: Fix export symbols. | Problem Details:
Add the appropriate EXPORT_SYMBOLS for proc_net_create,
proc_net_fops_create and proc_net_remove to fix errors when
compiling allmodconfig
Signed-off-by: Mark Nelson <markn@au1.ibm.com>
Acked-by: Benjamin Thery <benjamin.thery@bull.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
index 45dde2f7034d..358930a3142a 100644
--- a/fs/proc/proc_net.c
+++ b/fs/proc/proc_net.c
@@ -31,6 +31,7 @@ struct proc_dir_entry *proc_net_create(struct net *net,
{
return create_proc_info_entry(name,mode, net->proc_net, get_info);
}
+EXPORT_SYMBOL_GPL(p... |
86bba269d08f0c545ae76c90b56727f65d62d57f | Analyze and fix the following issue in the Linux kernel code: [PATCH] NET : convert IP route cache garbage collection from softirq processing to a workqueue | Problem Details:
When the periodic IP route cache flush is done (every 600 seconds on
default configuration), some hosts suffer a lot and eventually trigger
the "soft lockup" message.
dst_run_gc() is doing a scan of a possibly huge list of dst_entries,
eventually freeing some (less than 1%) of them, while holding the
... | ```diff
diff --git a/net/core/dst.c b/net/core/dst.c
index 32267a16e01e..38c741ac5d08 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -9,6 +9,7 @@
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/kernel.h>
+#include <linux/workqueue.h>
#include <linux/mm.h>
#include <linux/module.h>
#include <... |
3c12afe75f61d9402797d63941367962ca36fcc9 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix missed addition of fs/proc/proc_net.c | Problem Details:
My bad.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
new file mode 100644
index 000000000000..45dde2f7034d
--- /dev/null
+++ b/fs/proc/proc_net.c
@@ -0,0 +1,192 @@
+/*
+ * linux/fs/proc/net.c
+ *
+ * Copyright (C) 2007
+ *
+ * Author: Eric Biederman <ebiederm@xmission.com>
+ *
+ * proc net directory handlin... |
50f17787e9b0222ce65cc831407c3ba4790db3ff | Analyze and fix the following issue in the Linux kernel code: [AF_PACKET]: Don't enable global timestamps. | Problem Details:
Andi mentioned he did something like this already, but never submitted
it.
The dhcp client application uses AF_PACKET with a packet filter to
receive data. The application doesn't even use timestamps, but because
the AF_PACKET API has timestamps, they get turned on globally which
causes an expensive t... | ```diff
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 1322d62b5d97..9c26dd9ee649 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -640,11 +640,10 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, struct packe
h->tp_snaplen = snaplen;
h->tp_mac = macoff;
... |
b63bde7bb75f74acf974f43dc2be8798be115007 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: fix preamble setting | Problem Details:
It looks like in commit 28487a90 the condition was unintentionally
negated by moving some code, fix it.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Daniel Drake <dsd@gentoo.org>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Sig... | ```diff
diff --git a/net/mac80211/ieee80211_ioctl.c b/net/mac80211/ieee80211_ioctl.c
index 8296e7de12c7..d48f3aa30e30 100644
--- a/net/mac80211/ieee80211_ioctl.c
+++ b/net/mac80211/ieee80211_ioctl.c
@@ -821,7 +821,7 @@ static int ieee80211_ioctl_prism2_param(struct net_device *dev,
break;
case PRISM2_PARAM_PREAM... |
6c55aa97359af4b503a8baf914de48f2406a895f | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: Remove overly sticky averaging filters for rssi, signal, noise | Problem Details:
The current version of wireless statistics contains a bug in the averaging
that makes the numbers be too sticky and not react to small changes. This
patch removes all averaging.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jiri Benc <jbenc@suse.cz>
Signed-off-by: John W. Linv... | ```diff
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index ba94f58ba02e..e2c6f5cd1cf7 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -485,12 +485,9 @@ ieee80211_rx_h_sta_process(struct ieee80211_txrx_data *rx)
sta->rx_fragments++;
sta->rx_bytes += rx->skb->len;
- sta->last_rssi = (sta->last_rssi ... |
3017b80bf0c4d6a44ccf0d35db9dadf01092b54e | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: fix software decryption | Problem Details:
When doing key selection for software decryption, mac80211 gets
a few things wrong: it always uses pairwise keys if configured,
even if the frame is addressed to a multicast address. Also, it
doesn't allow using a key index of zero if a pairwise key has
also been found.
This patch changes the key sele... | ```diff
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 000b8e3133ba..6a2a0c3e7255 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -1,7 +1,9 @@
/*
- * Low-level hardware driver -- IEEE 802.11 driver (80211.o) interface
+ * mac80211 <-> driver interface
+ *
* Copyright 2002-2005... |
1a84f3fd141d2105d80290316bfa772ba34e9c64 | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: ratelimit some RX messages | Problem Details:
Many if not all of these messages can be triggered by sending
a few rogue frames which is trivially done and then we overflow
our logs.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signe... | ```diff
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 01176ba52df4..7a6e60fcf9d0 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -336,13 +336,16 @@ ieee80211_rx_h_load_key(struct ieee80211_txrx_data *rx)
if (!rx->key) {
if (!rx->u.rx.ra_match)
return TXRX_DROP;
- printk(KERN_DEBUG... |
50339a67e2d4386d8919195989371579cab8649d | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: fix key debugfs | Problem Details:
This fixes two issues with the key debugfs:
1) key index obviously isn't unique
2) various missing break statements led to bogus output
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Michael Wu <flamingice@sourmilk.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Sig... | ```diff
diff --git a/net/mac80211/debugfs_key.c b/net/mac80211/debugfs_key.c
index 7d56dc9e7326..077f907271cf 100644
--- a/net/mac80211/debugfs_key.c
+++ b/net/mac80211/debugfs_key.c
@@ -77,14 +77,17 @@ static ssize_t key_tx_spec_read(struct file *file, char __user *userbuf,
switch (key->alg) {
case ALG_WEP:
len... |
2a8a9a88fc1b18f5c45244d0ef8a5352f6cf761f | Analyze and fix the following issue in the Linux kernel code: [MAC80211]: avoid copying packets to interfaces that are down | Problem Details:
David Woodhouse noticed that under some circumstances the number of slab
allocations kept growing. After looking a bit, this seemed to happen
when you had a management mode interface that was *down*.
The reason for this is that when the device is down, all management
frames get queued to the in-kernel... | ```diff
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 5fc240259f55..00df2a9a2661 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -493,7 +493,16 @@ static void ieee80211_if_shutdown(struct net_device *dev)
case IEEE80211_IF_TYPE_IBSS:
sdata->u.sta.state = IEEE80211_D... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.