id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
0e789d7ffafbfd44f7fb2bdbf1138547d8abc231 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6224): VIDEO_CX23885 depends on DVB_CORE | Problem Details:
Fix the following dependency issue:
ERROR: "dvb_dmx_init" [drivers/media/video/video-buf-dvb.ko] undefined!
ERROR: "dvb_unregister_adapter" [drivers/media/video/video-buf-dvb.ko] undefined!
ERROR: "dvb_register_frontend" [drivers/media/video/video-buf-dvb.ko] undefined!
ERROR: "dvb_unregister_frontend... | ```diff
diff --git a/drivers/media/video/cx23885/Kconfig b/drivers/media/video/cx23885/Kconfig
index 45345fc189e0..ebfcc7c2a89e 100644
--- a/drivers/media/video/cx23885/Kconfig
+++ b/drivers/media/video/cx23885/Kconfig
@@ -1,6 +1,6 @@
config VIDEO_CX23885
tristate "Conexant cx23885 (2388x successor) support"
- depen... |
2060955748dff6280cd211b68c92d9a99d1c78f9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6220): TCM825x: Add support for vidioc_int_g_ifparm call, small cleanups | Problem Details:
vidioc_int_g_ifparm returns platform-specific information about the
interface settings used by the sensor. Support for [gs]_ext_clk has
been removed.
Fix indentation and remove useless & characters.
Remove experiment for typechecking slave callback function arguments.
Signed-off-by: Sakari Ailus <sa... | ```diff
diff --git a/drivers/media/video/tcm825x.c b/drivers/media/video/tcm825x.c
index 3a139f288a9d..41cd6a0b0485 100644
--- a/drivers/media/video/tcm825x.c
+++ b/drivers/media/video/tcm825x.c
@@ -470,46 +470,6 @@ static int tcm825x_configure(struct v4l2_int_device *s)
return 0;
}
-/*
- * Given the image capture... |
588005e1008f2cea61b7a1ae2a86c531e99b8c9c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init() | Problem Details:
There's a serious bug in saa6588.c, it uses a non-initialized spin_lock.
Funny thing is that it works fine with bttv, but completly freezes the
machine if e.g. saa7134 is loaded.
Thanks to Derek Philip for reporting this bug on the rdsd-devel list.
This patch adds the missing spin_lock_init().
Signe... | ```diff
diff --git a/drivers/media/video/saa6588.c b/drivers/media/video/saa6588.c
index 92eabf88a09b..72e344a12c79 100644
--- a/drivers/media/video/saa6588.c
+++ b/drivers/media/video/saa6588.c
@@ -406,6 +406,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
kfree(s);
return -ENOMEM;
... |
56585386e297c54a65feef55810c13b4313bdf1e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6211): pvrusb2: Allocate a debug mask bit for reporting video standard things | Problem Details:
It's useful to see specific details for how the pvrusb2 driver is
figuring out things related to the video standard, independent of
other initialization activities. So let's set up a separate debug
mask bit for this and turn it on.
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carv... | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-debug.h b/drivers/media/video/pvrusb2/pvrusb2-debug.h
index d95a8588e4f8..da6441b88f31 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-debug.h
+++ b/drivers/media/video/pvrusb2/pvrusb2-debug.h
@@ -26,32 +26,33 @@ extern int pvrusb2_debug;
/* These are listed ... |
401c27ce96382b3bdbc7a9c7e7303fd1b3af9ef0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6207): pvrusb2: Fix a potential oops in an error leg cleanup | Problem Details:
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
index 2d5be5cfbccf..5d9045268cf5 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
@@ -2172,6 +2172,7 @@ static void pvr2_hdw_remove_usb_stuff(struct pvr2_hdw *... |
747f07961e9450058522840129cd7bb994f05fb9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6205): pvrusb2: Fix oops in error leg cleanup | Problem Details:
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-context.c b/drivers/media/video/pvrusb2/pvrusb2-context.c
index 6bbed88d7867..22719ba861ac 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-context.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-context.c
@@ -33,8 +33,10 @@ static void pvr2_context_destroy(struct pv... |
289ea1f03353104c4f288f6c70c5c7e1568ea257 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6203): Fix SVideo input on KWorld DVB-T 220 boards | Problem Details:
Fix SVideo input on KWorld DVB-T 220 boards. Without this patch, the
luma pin on the SVideo input is treated as a composite in, and the
chroma pin is ignored.
Also, fix the radio, and provide a second composite input for people who
are used to the existing composite on SVideo connector behaviour.
Sig... | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
index 5c3174a62e58..c4dc9868c48b 100644
--- a/drivers/media/video/saa7134/saa7134-cards.c
+++ b/drivers/media/video/saa7134/saa7134-cards.c
@@ -2771,6 +2771,7 @@ struct saa7134_board saa7134_boards[] = {
.t... |
fc959befe0f0e4647bb4e326e3ae55875401888a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6190): cx23885: GPIO fix for non HVR1800lp boards | Problem Details:
The HVR1250 and HVR1800 boards need the s5h1409 demod GPIO enabled.
Signed-off-by: Steven Toth <stoth@hauppauge.com>
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index 291cc0556222..ffa4c49d6916 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -80,6 +80,15 @@ static struct videobuf_queue_ops dvb_qops = {
};
stati... |
b86b580244511f9b2fb2043d813e9c4c7d294a62 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6165): cx23885: fix Kconfig dependencies | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx23885/Kconfig b/drivers/media/video/cx23885/Kconfig
index ea53466dacbe..333dd29d44b4 100644
--- a/drivers/media/video/cx23885/Kconfig
+++ b/drivers/media/video/cx23885/Kconfig
@@ -8,6 +8,9 @@ config VIDEO_CX23885
select VIDEO_TUNER
select VIDEO_TVEEPROM
select VIDEO_IR
+... |
3c5666aee31decafdca14f6f83d33ec27b27f982 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6164): cx23885: turn off i2c_debug by default | Problem Details:
Turn off i2c_debug by default, to make the driver less verbose.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-i2c.c b/drivers/media/video/cx23885/cx23885-i2c.c
index c40c37f2d139..6b49b414aebf 100644
--- a/drivers/media/video/cx23885/cx23885-i2c.c
+++ b/drivers/media/video/cx23885/cx23885-i2c.c
@@ -29,7 +29,7 @@
#include <media/v4l2-common.h>
-static unsigned int i2... |
fe475163ff9680495af3b1b5b7633ea7a42e4185 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6158): Fix MT2131 tuner lock status problem | Problem Details:
The mt2131 tuner reports lock even when the hardware should not
lock. This patch allows the s5h1409 demodulator to be configured to query
either the tuner driver for status, or the demodulator status when the
application requests lock status. This avoids returning false CARRIER
and/or SIGNAL lock statu... | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index 4ff85f75f9f7..188a5a7819cb 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -84,7 +84,8 @@ static struct s5h1409_config hauppauge_hvr1800lp_config = {... |
3bd4065961aa03d030cd58feec03d60479fc4348 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6154): NMI hang and corrupt transport packet fixes | Problem Details:
The sram allocations for the cx23887 differ slightly from the cx23885.
This patch modifies the cx23887 specific sram memory map to reflect this.
As a result, interrupts and DMA handling have also been enabled in
cx23885_start_dma() for 887 specific boards.
ATSC streaming is now available on cx23885 an... | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-core.c b/drivers/media/video/cx23885/cx23885-core.c
index fda0c1631dbd..5769db47529c 100644
--- a/drivers/media/video/cx23885/cx23885-core.c
+++ b/drivers/media/video/cx23885/cx23885-core.c
@@ -270,7 +270,7 @@ struct sram_channel cx23887_sram_channels[] = {
.n... |
03121f05f98cf9bba8f0fe77ef381c17681e1386 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6152): cx23885: forward compatibility fixes for recent kernels | Problem Details:
- fix #include for <media/video-buf-dvb.h>
- fix cx23885_irq declaration for 2.6.19 and later
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx23885/cx23885-core.c b/drivers/media/video/cx23885/cx23885-core.c
index 876d396fb7a3..4e6e8737e38e 100644
--- a/drivers/media/video/cx23885/cx23885-core.c
+++ b/drivers/media/video/cx23885/cx23885-core.c
@@ -1361,7 +1361,7 @@ static void cx23885_timeout(unsigned long data)
#d... |
f61b48f7a838bb3d089b12fc9d03fd53c9ef5022 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6142): cx25840: fix build warning | Problem Details:
Fix the following build warning:
CC [M] cx25840-core.o
cx25840-core.c: In function 'init_dll1':
cx25840-core.c:147: warning: implicit declaration of function 'udelay'
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
index 90f7859bb48e..15f191e170d2 100644
--- a/drivers/media/video/cx25840/cx25840-core.c
+++ b/drivers/media/video/cx25840/cx25840-core.c
@@ -34,6 +34,7 @@
#include <linux/slab.h>
#include <linux/videodev2.h>
... |
136280322d894e6ec07187f2427b00c3d64ad066 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6122): ivtvfb: fix an obvious bug in ivtvfb_release_buffers() | Problem Details:
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtvfb.c b/drivers/media/video/ivtv/ivtvfb.c
index 73e46f94b45a..9684048fe56c 100644
--- a/drivers/media/video/ivtv/ivtvfb.c
+++ b/drivers/media/video/ivtv/ivtvfb.c
@@ -1064,8 +1064,8 @@ static void ivtvfb_release_buffers (struct ivtv *itv)
struct osd_info *oi = itv->osd_... |
641ed49db6ecf6c539a5eab50a7540542377add1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6121): ivtvfb: replace ivtv_fb prefix to ivtvfb | Problem Details:
ivtvfb: replace ivtv_fb prefix to ivtvfb, change warning to info message
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtvfb.c b/drivers/media/video/ivtv/ivtvfb.c
index c8ca7cbbe38b..73e46f94b45a 100644
--- a/drivers/media/video/ivtv/ivtvfb.c
+++ b/drivers/media/video/ivtv/ivtvfb.c
@@ -52,8 +52,8 @@
#include "ivtv-mailbox.h"
/* card parameters */
-static int ivtv_fb_card_id = -1;
-stat... |
2f3a98931f51be6093df7c6cc2633bf238778b7d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6116): ivtv: VBI cleanups and fixes | Problem Details:
Besides some VBI cleanups this patch also fixes a subtle problem with the
VBI re-insertion stream where the PIO work handler wasn't called quickly
enough, resulting in occasional corrupt data.
Furthermore the CC output didn't disable CC correctly and at the right time,
causing duplicates to be sent.
... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-driver.h b/drivers/media/video/ivtv/ivtv-driver.h
index 41f753c125da..748ef66bd945 100644
--- a/drivers/media/video/ivtv/ivtv-driver.h
+++ b/drivers/media/video/ivtv/ivtv-driver.h
@@ -489,6 +489,15 @@ struct yuv_playback_info
#define IVTV_VBI_FRAMES 32
/* VBI data ... |
f58db9590fc56fe519d6919abae7a70ec17b4d0e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6111): Fix a warning when compiling on x86_64 | Problem Details:
tcm825x.c: In function 'ioctl_try_fmt_cap':
tcm825x.c:639: warning: format '%d' expects type 'int', but argument 4
has type 'long unsigned int'
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tcm825x.c b/drivers/media/video/tcm825x.c
index 4b973b099e59..3a139f288a9d 100644
--- a/drivers/media/video/tcm825x.c
+++ b/drivers/media/video/tcm825x.c
@@ -635,8 +635,8 @@ static int ioctl_try_fmt_cap(struct v4l2_int_device *s,
struct v4l2_pix_format *pix = &f->fmt.pix;
... |
71be258bd9bf41ca3060021f2ed50ad8c672a01e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6100): dvb_net: whitespace cleanup | Problem Details:
Clean whitespace brain-damage caused by previous patch,
"Fix a warning at dvb_net"
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_net.c b/drivers/media/dvb/dvb-core/dvb_net.c
index 13e2998a4043..2117377c141d 100644
--- a/drivers/media/dvb/dvb-core/dvb_net.c
+++ b/drivers/media/dvb/dvb-core/dvb_net.c
@@ -795,8 +795,8 @@ static int dvb_net_ts_callback(const u8 *buffer1, size_t buffer1_len,
}
... |
559e196a56a5d518181efc1d2fefe0892f4689b4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6096): ivtv: fix V4L2_ENC_CMD_STOP_AT_GOP_END support | Problem Details:
Support for V4L2_ENC_CMD_STOP_AT_GOP_END was broken. While the driver
correctly waited for the card to capture until the GOP was complete,
afterwards the driver buffers were just flushed instead of waiting
for the application to read all the pending data.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.n... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
index 170bef61aa62..5b5d6666fa16 100644
--- a/drivers/media/video/ivtv/ivtv-fileops.c
+++ b/drivers/media/video/ivtv/ivtv-fileops.c
@@ -258,19 +258,19 @@ static struct ivtv_buffer *ivtv_get_buffer(struct ivtv_stream *... |
ad8ff0f10b489562012e433acdac92498fe8bdc9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6086): ivtv: fix output mode processing: UDMA_YUV wasn't cleared | Problem Details:
- Always clear when stopping the decoder
- Clear if the filehandle that is being close was used for UDMA_YUV output.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-driver.h b/drivers/media/video/ivtv/ivtv-driver.h
index 03d31860851b..3ed4703956d3 100644
--- a/drivers/media/video/ivtv/ivtv-driver.h
+++ b/drivers/media/video/ivtv/ivtv-driver.h
@@ -517,6 +517,7 @@ struct ivtv_stream {
struct ivtv_open_id {
u32 open_id;
int type... |
f6210c9160dff82ceaaf5e59cf5f8fcd6bdefa38 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6085): cx88-alsa: Fix mmap support | Problem Details:
The driver has long claimed to support mmap, but it didn't work at all. Some
of the dma buffer parameters weren't set, and since video_buf uses vmalloc to
allocate the buffer, a page callback is needed too.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mcheha... | ```diff
diff --git a/drivers/media/video/cx88/cx88-alsa.c b/drivers/media/video/cx88/cx88-alsa.c
index ac317fb856e4..85d632224f3a 100644
--- a/drivers/media/video/cx88/cx88-alsa.c
+++ b/drivers/media/video/cx88/cx88-alsa.c
@@ -28,6 +28,7 @@
#include <linux/init.h>
#include <linux/device.h>
#include <linux/interrupt.... |
aeb292d1342c649ac0b35ae9205b761fd14adb57 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6081): ivtv: Fix static structure initialization | Problem Details:
Convert the initialization of ivtv_i2c_algo_template to C99-style.
Otherwise a future change to struct i2c_algo_bit_data would break
this code.
Also declared that structure const - it's a template after all.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-i2c.c b/drivers/media/video/ivtv/ivtv-i2c.c
index 5e12ebc2a9de..085dc3938da7 100644
--- a/drivers/media/video/ivtv/ivtv-i2c.c
+++ b/drivers/media/video/ivtv/ivtv-i2c.c
@@ -536,14 +536,13 @@ static struct i2c_adapter ivtv_i2c_adap_template = {
#endif
};
-static stru... |
f518b43c452fb2dbe98ee211abfc63cf421927ab | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6078): Coding style fix drivers/media/video/zr36016.c | Problem Details:
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/zr36016.c b/drivers/media/video/zr36016.c
index 62f77584fb85..dd084555da8f 100644
--- a/drivers/media/video/zr36016.c
+++ b/drivers/media/video/zr36016.c
@@ -38,11 +38,11 @@
#include<linux/videodev.h> */
/* I/O commands, error codes */
-#include<asm/io.h>
+#include <asm/i... |
b9758dfe0a2065f6fe3a484cc26886960aa847c1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6077): Coding style fix drivers/media/video/zr36050.c | Problem Details:
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/zr36050.c b/drivers/media/video/zr36050.c
index a6bbd125631c..9f622e00c479 100644
--- a/drivers/media/video/zr36050.c
+++ b/drivers/media/video/zr36050.c
@@ -38,14 +38,14 @@
#include<linux/videodev.h> */
/* I/O commands, error codes */
-#include<asm/io.h>
+#include <asm/i... |
5634f2ec809818983f58880e381ee929187e4ddf | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6076): Coding style fix drivers/media/video/zr36060.c | Problem Details:
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/zr36060.c b/drivers/media/video/zr36060.c
index 97c8f9b9dc12..1ef14fef08e6 100644
--- a/drivers/media/video/zr36060.c
+++ b/drivers/media/video/zr36060.c
@@ -38,14 +38,14 @@
#include<linux/videodev.h> */
/* I/O commands, error codes */
-#include<asm/io.h>
+#include <asm/i... |
c996899d0bc2414c7ff4682500344eb912d5ee1d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6074): tuner: fix ifdef tags to match actual file name | Problem Details:
The file, tuner-driver.h was originally named tuner-hw.h, but we decided to
rename it. At the time, I had forgotten to change the #ifdef __TUNER_HW_H__
to #ifdef __TUNER_DRIVER_H__ . This patch corrects that.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <m... | ```diff
diff --git a/drivers/media/video/tuner-driver.h b/drivers/media/video/tuner-driver.h
index fa51b7cec691..145045561a51 100644
--- a/drivers/media/video/tuner-driver.h
+++ b/drivers/media/video/tuner-driver.h
@@ -19,8 +19,8 @@
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
-#ifndef __TUNER_H... |
59fd8f8d8ee9f7539758419965381bcccfa6f798 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6066): cx88-alsa: Change order of interrupt enabling, fix spurious IRQs | Problem Details:
Currently the driver turns on audio interrupts, then sets the audio interrupt
mask to select which interrupts to get. One could received unwanted
interrupts since the mask is set _after_ interrupts have already been turned
on. Change the order of the operations, and clear any audio interrupt status
b... | ```diff
diff --git a/drivers/media/video/cx88/cx88-alsa.c b/drivers/media/video/cx88/cx88-alsa.c
index 76a8c01208c1..ecb9a74ae03d 100644
--- a/drivers/media/video/cx88/cx88-alsa.c
+++ b/drivers/media/video/cx88/cx88-alsa.c
@@ -136,12 +136,11 @@ static int _cx88_start_audio_dma(snd_cx88_card_t *chip)
struct cx88_core ... |
8beb058f1ecde7bc0554d18ce1baa18b5dfb02d3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6060): ivtv: fix IVTV_IOC_DMA_FRAME bug introduced by highmem bugfix | Problem Details:
The return value of ivtv_udma_fill_sg_list() was changed by the
highmem bugfix, but that return value was still used in ivtv-yuv.c.
Revert to the old return value, but in addition return -1 in case of
a memory allocation error.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Car... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-udma.c b/drivers/media/video/ivtv/ivtv-udma.c
index 5592abbe14e6..7e503adacea0 100644
--- a/drivers/media/video/ivtv/ivtv-udma.c
+++ b/drivers/media/video/ivtv/ivtv-udma.c
@@ -40,6 +40,9 @@ int ivtv_udma_fill_sg_list (struct ivtv_user_dma *dma, struct ivtv_dma_page_inf... |
1aa32c2ffd146dddd76babf842e998502f1b993a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6055): ivtv: improve debug messages | Problem Details:
- add FILE debug flag for open/close/read/write/poll.
- show cmd for encoder/decoder command ioctl.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c
index 3591518ed358..93ddea49f0ed 100644
--- a/drivers/media/video/ivtv/ivtv-driver.c
+++ b/drivers/media/video/ivtv/ivtv-driver.c
@@ -186,8 +186,18 @@ MODULE_PARM_DESC(pal, "Set PAL standard: B, G, H, D, K, I, M, N, Nc,... |
51a99c0428cc6d3a442eef1c9046099c9383d72b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6049): ivtv: fix VBI reinsertion decoding | Problem Details:
- Invalid VBI packets should result in an empty VBI frame, not
in an zero-sized frame that causes the reader to incorrectly
return a 0 (EOF) value.
- PIO completion should not reset the sg_pending_size field.
- The DMA offset detection code should be ignored for PIO transfers:
it somehow messes u... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-irq.c b/drivers/media/video/ivtv/ivtv-irq.c
index 9695e5356163..7272f1a71dd9 100644
--- a/drivers/media/video/ivtv/ivtv-irq.c
+++ b/drivers/media/video/ivtv/ivtv-irq.c
@@ -165,7 +165,7 @@ static int stream_enc_dma_append(struct ivtv_stream *s, u32 data[CX2341X_MBOX_MA
... |
de870b52be9d52c3dad76c9ea7399cb94abcaa1a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6048): ivtv: fix stop stream locking | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-streams.c b/drivers/media/video/ivtv/ivtv-streams.c
index d1cc366c2a35..4272fbc0bc8b 100644
--- a/drivers/media/video/ivtv/ivtv-streams.c
+++ b/drivers/media/video/ivtv/ivtv-streams.c
@@ -751,6 +751,9 @@ int ivtv_stop_v4l2_encode_stream(struct ivtv_stream *s, int gop_e... |
37093b1ea600d84fbf7252baf12eedec85ae40f1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6047): ivtv: Fix scatter/gather DMA timeouts | Problem Details:
It turns out that the cx23415/6 DMA engine cannot do scatter/gather DMA
reliably. Every so often depending on the phase of the moon and your
hardware configuration the cx2341x DMA engine simply chokes on it and
you have to reboot to get it working again.
This change replaced the scatter/gather DMA by ... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-driver.h b/drivers/media/video/ivtv/ivtv-driver.h
index f5de2fd01b1a..e80f9f65a905 100644
--- a/drivers/media/video/ivtv/ivtv-driver.h
+++ b/drivers/media/video/ivtv/ivtv-driver.h
@@ -382,7 +382,6 @@ struct ivtv_mailbox_data {
#define IVTV_F_I_RADIO_USER 5 /* The ... |
3562c43be8cfd6e300508d7c33acebf3369eacd3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6045): ivtv: fix handling of INITIALIZE_INPUT fw call | Problem Details:
The CX2341X_ENC_INITIALIZE_INPUT firmware call requires careful handling,
otherwise the computer can freeze or the top-third of the screen can start
flickering. This patch ensures that CX2341X_ENC_INITIALIZE_INPUT is called
at the right time and in the right way.
In addition the stop capture handling ... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
index 9e867b5229d1..908e640c274d 100644
--- a/drivers/media/video/ivtv/ivtv-fileops.c
+++ b/drivers/media/video/ivtv/ivtv-fileops.c
@@ -892,12 +892,20 @@ int ivtv_v4l2_open(struct inode *inode, struct file *filp)
... |
33bc4dea0ece371ccadbac8bf90fd0b8e2803f06 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6043): ivtv: fix incorrect round-robin implementation | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-irq.c b/drivers/media/video/ivtv/ivtv-irq.c
index 88c6f4ff5c6d..a97d55fd2277 100644
--- a/drivers/media/video/ivtv/ivtv-irq.c
+++ b/drivers/media/video/ivtv/ivtv-irq.c
@@ -859,8 +859,9 @@ irqreturn_t ivtv_irq_handler(int irq, void *dev_id)
}
if ((combo & IVTV_IRQ... |
faebb914399ecf8ecfd0e24b96ac90d7381f7e07 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6039): Typo fix in Nova-TD description | Problem Details:
Typo fix in Nova-TD description
Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
index 4a3c5467d7e0..0227e7fac3cf 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -944,7 +944,7 @@ struct dvb_usb_device_properties dib0700_devices[... |
82e67246cd2a860637ee9d27776ad48d32734f6c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6031): Fix for bug 7819: fixed hotplugging for dvbnet | Problem Details:
The first part of dvb_net_close() is just a cut&paste from
dvb_generic_release(), so maybe it would be better to just call
dvb_generic_release() instead?
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Acked-by: Markus Rechberger <mrechberger@gmail.com>
Acked-by: Oliver Endriss <o.endriss@gmx.de>
Si... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_net.c b/drivers/media/dvb/dvb-core/dvb_net.c
index b9c78d03a7fe..13e2998a4043 100644
--- a/drivers/media/dvb/dvb-core/dvb_net.c
+++ b/drivers/media/dvb/dvb-core/dvb_net.c
@@ -1441,18 +1441,9 @@ static int dvb_net_close(struct inode *inode, struct file *file)
struct ... |
89d969a39da8e9ee5db1c1fb49f55f4206a445ac | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6025): Net_ule(): fix check-after-use | Problem Details:
The Coverity checker spotted that we'd have already oops'ed if "dev"
was NULL.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_net.c b/drivers/media/dvb/dvb-core/dvb_net.c
index bdd797071cb0..b9c78d03a7fe 100644
--- a/drivers/media/dvb/dvb-core/dvb_net.c
+++ b/drivers/media/dvb/dvb-core/dvb_net.c
@@ -357,11 +357,6 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_l... |
5772f81326904f2bfbb2bf2f365b3fb36ee3b7d8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6023): cx88: Clean up some ugly and inconsistent printk()s | Problem Details:
Get rid of the "CORE" prefix from cx88 printks. It was only used a few times,
and it makes it look like they're coming from the kernel core or something.
Fix the message, "TV tuner 60 at 0x1fe, Radio tuner -1 at 0x1fe", by adding a
"cx88[0]" prefix to be consistent, and to keep people who grep their ... | ```diff
diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index 6204a453c11e..e73e8c96d5b9 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -2094,7 +2094,7 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr)
mem... |
b09a79f5848f2143a8ffc724910743027d5a70e0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (6020): cx88: Fix use of uninitialized variable | Problem Details:
An error message for PCI resource allocation failure used the board type
before it was set. Just get rid of the error message, as get_ressources()
[sic] already prints one. Format that error message better, and add the pci
function and subsystem information to better associate the error with what
cau... | ```diff
diff --git a/drivers/media/video/cx88/cx88-core.c b/drivers/media/video/cx88/cx88-core.c
index f31ec96924b9..055264b9cd61 100644
--- a/drivers/media/video/cx88/cx88-core.c
+++ b/drivers/media/video/cx88/cx88-core.c
@@ -1077,8 +1077,11 @@ static int get_ressources(struct cx88_core *core, struct pci_dev *pci)
... |
87410dab1238623e082e9a78a62f1bbeb6c475e3 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5997): cx25840: fix audio mute handling and reporting | Problem Details:
Audio muting for the tuner input was implemented by stopping the
audio microcontroller and restarting it on unmute. However, it
appears that this method can actually crash the audio firmware.
It's rare and seems to happen with NTSC only.
It has been reimplemented by setting to volume to 0. In addit... | ```diff
diff --git a/drivers/media/video/cx25840/cx25840-audio.c b/drivers/media/video/cx25840/cx25840-audio.c
index f897c1ebd5f3..f93b5160bb4f 100644
--- a/drivers/media/video/cx25840/cx25840-audio.c
+++ b/drivers/media/video/cx25840/cx25840-audio.c
@@ -194,19 +194,34 @@ void cx25840_audio_set_path(struct i2c_client *... |
4ebcb48da1eace49ef5f2d83a91984085c6d702d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5988): Fix OOP on videobuf-dvb when hibernating | Problem Details:
Since videobuf_waiton is called with intr=1, it can return -EINTR and therefore
err may be non-zero. This happens when the system goes into the standby state.
Without the BUG() occurring, there's no problem with standby mode while DVB
is being used.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infra... | ```diff
diff --git a/drivers/media/video/video-buf-dvb.c b/drivers/media/video/video-buf-dvb.c
index e617925ba31e..d2af82dc8faf 100644
--- a/drivers/media/video/video-buf-dvb.c
+++ b/drivers/media/video/video-buf-dvb.c
@@ -56,7 +56,6 @@ static int videobuf_dvb_thread(void *data)
struct videobuf_buffer, stream);
... |
a18255bef2a62632ed442fdb90b091193cbabca5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5985): Fix the min/max frequencies of some DVB-C frontends | Problem Details:
The min frequencies of the DVB-C frontends are wrong.
In Europe, the center frequency of the lowest channel is 50.5MHz and not
51MHz. All known cards with the stv0297/tda0002x/ves1820 frontend are
able to tune to this frequency.
I've changed the range to the lowest channel - 1/2 bandwidth and the ... | ```diff
diff --git a/drivers/media/dvb/frontends/stv0297.c b/drivers/media/dvb/frontends/stv0297.c
index 9a343972ff50..17e5cb561cd8 100644
--- a/drivers/media/dvb/frontends/stv0297.c
+++ b/drivers/media/dvb/frontends/stv0297.c
@@ -680,8 +680,8 @@ static struct dvb_frontend_ops stv0297_ops = {
.info = {
.name = "S... |
8509a29ec6050a03d88f2da59fc2e361f6c16534 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5983): Arv.c: fix memset in ioctl | Problem Details:
Looks like memset() is zeroing wrong nr of bytes.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/arv.c b/drivers/media/video/arv.c
index 2666d3b76630..19e9929ffa0f 100644
--- a/drivers/media/video/arv.c
+++ b/drivers/media/video/arv.c
@@ -441,7 +441,7 @@ static int ar_do_ioctl(struct inode *inode, struct file *file,
{
struct video_window *w = arg;
DEBUG(1, "VIDIOCGW... |
473c653fff8dc6a63cad279a8e83395ead12119d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5982): Dev.c: memset fix | Problem Details:
Looks like memset() is zeroing wrong nr of bytes.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
index b876aca69c73..0334b9aaf12a 100644
--- a/drivers/media/video/videodev.c
+++ b/drivers/media/video/videodev.c
@@ -448,7 +448,7 @@ static int __video_do_ioctl(struct inode *inode, struct file *file,
if (cmd == VIDIOCGMBUF) {
st... |
5e76a1cb2ce0918ff2429fcfa2d5655dbd273c54 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5981): Zoran_driver.c: fix memset in ioctl | Problem Details:
Looks like memset() is zeroing wrong nr of bytes.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/zoran_driver.c b/drivers/media/video/zoran_driver.c
index 4dbe2d449b50..d831ca16d9e9 100644
--- a/drivers/media/video/zoran_driver.c
+++ b/drivers/media/video/zoran_driver.c
@@ -3196,7 +3196,7 @@ zoran_do_ioctl (struct inode *inode,
"%s: VIDIOC_QUERYBUF - index=%d, type=%d\n... |
4f76b672c4f9ceb9e7e0aa6224293da0ae7430da | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5980): tda8083: fix frequency and symbolrate info | Problem Details:
The TDA8083 supports a symbol rate from 12..30 MSym/s.
The Grundig 29504-451 tuner uses the TDA8060 down-converter,
which has a frequency range from 920..2200MHz.
Thanks-to: Lars Buerding <lindvb@metatux.net>
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mcheha... | ```diff
diff --git a/drivers/media/dvb/frontends/tda8083.c b/drivers/media/dvb/frontends/tda8083.c
index 67415c9db6f7..0f041e873781 100644
--- a/drivers/media/dvb/frontends/tda8083.c
+++ b/drivers/media/dvb/frontends/tda8083.c
@@ -443,12 +443,12 @@ static struct dvb_frontend_ops tda8083_ops = {
.info = {
.name =... |
5e082f1521598a91c9194b2356b157cade9b6e87 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5978): tuner: Better tuner radio support | Problem Details:
Add radio support for the Thomson DTT7612 tuner.
This tuner uses a different 1st intermediate frequency than the other radio
tuners supported (a lot of NTSC radio tuners probably need this change too).
Add a new tuner-simple parameter, radio_if. It selects the 1st IF used for
radio reception. The r... | ```diff
diff --git a/drivers/media/video/tda9887.c b/drivers/media/video/tda9887.c
index a8f773274fe3..aa311e4f1f61 100644
--- a/drivers/media/video/tda9887.c
+++ b/drivers/media/video/tda9887.c
@@ -97,6 +97,8 @@ struct tvnorm {
#define cAudioIF_6_5 0x03 // bit e0:1
+#define cVideoIFMask 0x1c // bi... |
a75d204860b5051ebd5635278c097bafb4ea53f9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5977): cx8800: Add register debug functions to radio device too | Problem Details:
Add the advanced debug functions to the radio videodev template. One could
already use them from the video and vbi devices.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index 41b5cb63fd2d..58ec76be436c 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -1716,6 +1716,10 @@ static struct video_device cx8800_radio_template =
.vidioc_s_ctrl ... |
b4b38bd63c07c8927b43c6c378eca1db10fdaf2e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5970): ivtv: prevent vertical overflow of yuv output | Problem Details:
When the video standard is changed, there's no guarantee the framebuffer
dimensions are still legal. The yuv output code uses these dimensions to
calculate the size & position for the video overlay. If the framebuffer
dimensions are now illegal, the output may exceed the vertical limit of the
display, ... | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-yuv.c b/drivers/media/video/ivtv/ivtv-yuv.c
index bcea09542e5a..70ddf4060d37 100644
--- a/drivers/media/video/ivtv/ivtv-yuv.c
+++ b/drivers/media/video/ivtv/ivtv-yuv.c
@@ -898,8 +898,21 @@ static void ivtv_yuv_init (struct ivtv *itv)
itv->yuv_info.decode_height = 48... |
813ce47cee33964ff710d2c91063548773cb4cd5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5965): Frontend_ioctl(): fix check-after-use | Problem Details:
The Coverity checker spotted that we have already oops'ed if "fe" was NULL.
Since "fe" being NULL seems impossible at this point this patch removes
the NULL check.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infra... | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index afe797b75de4..fd9bac5eb25e 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -748,7 +748,7 @@ static int dvb_frontend_ioctl(struct inode *inode, struct... |
034d65ed209f8525b1989dc3e6beca92fad57a7d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5962): Fix line-break in err output | Problem Details:
line-breaks in dib0700-remote-query function fixed.
Signed-off-by: Janne Grunau <janne-dvb@grunau.be>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
index a70fe75bcb27..0eca0fc75327 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -274,7 +274,7 @@ static int dib0700_rc_query(struct dvb_usb_device... |
3db78e59500a45e05cbe271c8e1ba5a2b7ce0ef8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5961): Fix support for DiB7000M-devices | Problem Details:
Forgot to initialize the timf_default field.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
index a2b2830f978a..a70fe75bcb27 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -515,6 +515,7 @@ static struct dibx000_bandwidth_config stk7700p_p... |
8779737b8e01b95fe6f1e33dc90ea621281c7b67 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5959): Fix for size of remote keys in DiB0700 | Problem Details:
Fix for size of remote control keys in DiB0700.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dib0700_devices.c b/drivers/media/dvb/dvb-usb/dib0700_devices.c
index b0ae5b731296..a2b2830f978a 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -914,7 +914,7 @@ struct dvb_usb_device_properties dib0700_devices[... |
261efd12fc291e6b3b42011201bfd011484ad90b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5940): Export v4l2_int_device_{, un}register | Problem Details:
This patch fixes the following build error:
<-- snip -->
...
MODPOST 2135 modules
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/v4l2-int-device.c b/drivers/media/video/v4l2-int-device.c
index aa2a8156338d..a643730fa3b2 100644
--- a/drivers/media/video/v4l2-int-device.c
+++ b/drivers/media/video/v4l2-int-device.c
@@ -101,6 +101,7 @@ int v4l2_int_device_register(struct v4l2_int_device *d)
return 0;
}
... |
b4c85248afcc5265ce8c36b9c15e40e6a92b5ae7 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5928): tuner: fix TOP values for the Panasonic VP27 tuner. | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-types.c b/drivers/media/video/tuner-types.c
index 417f642b4359..53a99b39387f 100644
--- a/drivers/media/video/tuner-types.c
+++ b/drivers/media/video/tuner-types.c
@@ -670,6 +670,9 @@ static struct tuner_params tuner_panasonic_vp27_params[] = {
.count = ARRAY_SIZE(tune... |
c6f95d16e0da4d909afc787a3a3dfc504be12177 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5910): ivtv-fb: improve debug message | Problem Details:
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/ivtv/ivtv-fb.c b/drivers/media/video/ivtv/ivtv-fb.c
index 56ce5c08bbb3..b8ad249a0b17 100644
--- a/drivers/media/video/ivtv/ivtv-fb.c
+++ b/drivers/media/video/ivtv/ivtv-fb.c
@@ -439,7 +439,7 @@ static int ivtvfb_ioctl(struct fb_info *info, unsigned int cmd, unsigned long ar
}... |
60e3cac47a442fae74d3429f706350229623bcce | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5885): zr36067: Fix problems with module parameters | Problem Details:
Add permissions to all the module parameters so they can be queried and set
(when possible) via sysfs.
Add description for the vidmem parameter.
Change the video_nr parameter to an array, so that the video number can be
specified when a user has more than one card. The driver would try to give
all c... | ```diff
diff --git a/drivers/media/video/zoran_card.c b/drivers/media/video/zoran_card.c
index 8e12ff80550d..48da36a15fca 100644
--- a/drivers/media/video/zoran_card.c
+++ b/drivers/media/video/zoran_card.c
@@ -64,15 +64,15 @@
extern const struct zoran_format zoran_formats[];
static int card[BUZ_MAX] = { -1, -1, -1... |
18b548ca580838a2cc5813a941e6dab28660bb22 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5884): zr36067: clean up debug function | Problem Details:
Debugging cleanups to the zr36067 driver:
* Use module_param_named() to declare the debug parameter, so we can
use a single global variable to handle the debug level. This makes
the driver a bit smaller (by 648 bytes on x86_64), thanks to one
less level of indirection on every use.
* Change the... | ```diff
diff --git a/drivers/media/video/zoran_card.c b/drivers/media/video/zoran_card.c
index 73162a3a61dd..8e12ff80550d 100644
--- a/drivers/media/video/zoran_card.c
+++ b/drivers/media/video/zoran_card.c
@@ -145,10 +145,9 @@ module_param(pass_through, int, 0);
MODULE_PARM_DESC(pass_through,
"Pass TV signal thro... |
63116febb9233743279a05be510ab8524f5f6242 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (5883): V4L: Fix a compile warning on non-32-bit machines. | Problem Details:
Fix a compile warning on non-32-bit machines in v4l2-int-device.h.
Add internal ioctl interface fallback function for ioctls with one
argument.
Signed-off-by: Sakari Ailus <sakari.ailus@nokia.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/v4l2-int-device.c b/drivers/media/video/v4l2-int-device.c
index 7885d9b38c92..aa2a8156338d 100644
--- a/drivers/media/video/v4l2-int-device.c
+++ b/drivers/media/video/v4l2-int-device.c
@@ -115,13 +115,9 @@ void v4l2_int_device_unregister(struct v4l2_int_device *d)
mutex_unloc... |
258de4badd5b7b5d168307638f755bd4df16c18e | Analyze and fix the following issue in the Linux kernel code: [POWERPC] XilinxFB: add banner output to probe routine when DEBUG is defined | Problem Details:
Debug support: when DEBUG is defined, output relevant details to the
log about the framebuffer registration.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Andrei Konovalov <akonovalov@ru.mvista.com> | ```diff
diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
index 4bc67ab56afa..1a5f1e429c4d 100644
--- a/drivers/video/xilinxfb.c
+++ b/drivers/video/xilinxfb.c
@@ -287,6 +287,11 @@ xilinxfb_drv_probe(struct device *dev)
goto failed4;
}
+ /* Put a banner in the log (for DEBUG) */
+ dev_dbg(dev, "re... |
7f8ada98d9edd83d6ebd01e431e15b024a4a3dc4 | Analyze and fix the following issue in the Linux kernel code: Rework /proc/locks via seq_files and seq_list helpers | Problem Details:
Currently /proc/locks is shown with a proc_read function, but its behavior
is rather complex as it has to manually handle current offset and buffer
length. On the other hand, files that show objects from lists can be
easily reimplemented using the sequential files and the seq_list_XXX()
helpers.
This... | ```diff
diff --git a/fs/locks.c b/fs/locks.c
index c17bc00b1e8d..7f9a3ea47418 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2066,134 +2066,114 @@ int vfs_cancel_lock(struct file *filp, struct file_lock *fl)
EXPORT_SYMBOL_GPL(vfs_cancel_lock);
-static void lock_get_status(char* out, struct file_lock *fl, int id, cha... |
094f2825218fec1b240cb8537d2d0a10edf5ddc9 | Analyze and fix the following issue in the Linux kernel code: fs/locks.c: use list_for_each_entry() instead of list_for_each() | Problem Details:
fs/locks.c: use list_for_each_entry() instead of list_for_each() in
posix_locks_deadlock() and get_locks_status()
Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org> | ```diff
diff --git a/fs/locks.c b/fs/locks.c
index 9a3fe0d8285b..c17bc00b1e8d 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -700,13 +700,12 @@ EXPORT_SYMBOL(posix_test_lock);
static int posix_locks_deadlock(struct file_lock *caller_fl,
struct file_lock *block_fl)
{
- struct list_head *tmp;
+ struct file_lock *fl;
... |
9efa68ed079af97f4e9477eadef567ffe64f7afc | Analyze and fix the following issue in the Linux kernel code: locks: add warning about mandatory locking races | Problem Details:
The mandatory file locking implementation has long-standing races that
probably render it useless. I know of no plans to fix them. Till we
do, we should at least warn people.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/Documentation/filesystems/mandatory-locking.txt b/Documentation/filesystems/mandatory-locking.txt
index bc449d49eee5..0979d1d2ca8b 100644
--- a/Documentation/filesystems/mandatory-locking.txt
+++ b/Documentation/filesystems/mandatory-locking.txt
@@ -3,7 +3,26 @@
Andy Walker <andy@lysaker.kvaerne... |
85c59580b30c82aa771aa33b37217a6b6851bc14 | Analyze and fix the following issue in the Linux kernel code: locks: Fix potential OOPS in generic_setlease() | Problem Details:
This code is run under lock_kernel(), which is dropped during
sleeping operations, so the following race is possible:
CPU1: CPU2:
vfs_setlease(); vfs_setlease();
lock_kernel();
lock_kernel(); /* spin */
generi... | ```diff
diff --git a/fs/locks.c b/fs/locks.c
index 282b6c11670a..43dbc7f566fa 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1343,6 +1343,7 @@ int fcntl_getlease(struct file *filp)
int generic_setlease(struct file *filp, long arg, struct file_lock **flp)
{
struct file_lock *fl, **before, **my_before = NULL, *lease;
+... |
02888f41e9d7fa95d1f5b2f76e0f0af6ea8198cc | Analyze and fix the following issue in the Linux kernel code: locks: fix flock_lock_file() comment | Problem Details:
This comment wasn't updated when lease support was added, and it makes
essentially the same mistake that the code made before a recent bugfix.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> | ```diff
diff --git a/fs/locks.c b/fs/locks.c
index 6e22c8129a80..c7c69d29a576 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -715,8 +715,7 @@ next_task:
}
/* Try to create a FLOCK lock on filp. We always insert new FLOCK locks
- * at the head of the list, but that's secret knowledge known only to
- * flock_lock_file a... |
84d535ade62b6f8ce852745731ad6200c46b977c | Analyze and fix the following issue in the Linux kernel code: Memory shortage can result in inconsistent flocks state | Problem Details:
When the flock_lock_file() is called to change the flock
from F_RDLCK to F_WRLCK or vice versa the existing flock
can be removed without appropriate warning.
Look:
for_each_lock(inode, before) {
struct file_lock *fl = *before;
if (IS_POSIX(fl))
... | ```diff
diff --git a/fs/locks.c b/fs/locks.c
index efe1affe6bed..6e22c8129a80 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -733,6 +733,15 @@ static int flock_lock_file(struct file *filp, struct file_lock *request)
lock_kernel();
if (request->fl_flags & FL_ACCESS)
goto find_conflict;
+
+ if (request->fl_type != F_... |
b842e240f27678aa5d71611cddc8d17a93fb0caf | Analyze and fix the following issue in the Linux kernel code: locks: reverse order of posix_locks_conflict() arguments | Problem Details:
The first argument to posix_locks_conflict() is meant to be a lock request,
and the second a lock from an inode's lock request. It doesn't really
make a difference which order you call them in, since the only
asymmetric test in posix_lock_conflict() is the check whether the second
argument is a posix ... | ```diff
diff --git a/fs/locks.c b/fs/locks.c
index c795eaaf6c4c..51bae6227c25 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -668,7 +668,7 @@ posix_test_lock(struct file *filp, struct file_lock *fl)
for (cfl = filp->f_path.dentry->d_inode->i_flock; cfl; cfl = cfl->fl_next) {
if (!IS_POSIX(cfl))
continue;
- if (p... |
a16e92edcd0a2846455a30823e1bac964e743baa | Analyze and fix the following issue in the Linux kernel code: knfsd: query filesystem for NFSv4 getattr of FATTR4_MAXNAME | Problem Details:
Without this we always return 2^32-1 as the the maximum namelength.
Thanks to Andreas Gruenbacher for bug report and testing.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: Andreas Gruenbacher <agruen@suse.de> | ```diff
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 9cf900740c76..e15f2cf8ac15 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1475,7 +1475,8 @@ nfsd4_encode_fattr(struct svc_fh *fhp, struct svc_export *exp,
err = vfs_getattr(exp->ex_mnt, dentry, &stat);
if (err)
goto out_nfserr;
- if ((b... |
0272e1fd9f4fa8a43357c168e081744f99e67195 | Analyze and fix the following issue in the Linux kernel code: knfsd: let nfsd manage timing out its own leases | Problem Details:
Currently there's a race that can cause an oops in generic_setlease.
(In detail: nfsd, when it removes a lease, does so by calling
vfs_setlease() with F_UNLCK and a pointer to the fl_flock field, which
in turn points to nfsd's existing lease; but the first thing the
setlease code does is call time_out... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 6256492b2363..48fbdac33c7c 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1354,8 +1354,12 @@ void nfsd_break_deleg_cb(struct file_lock *fl)
/* only place dl_time is set. protected by lock_kernel*/
dp->dl_time = get_seconds();
- /... |
246d95ba051101e515670a1cbe2907a88d360b88 | Analyze and fix the following issue in the Linux kernel code: nfsd warning fix | Problem Details:
fs/nfsd/nfsctl.c: In function 'write_filehandle':
fs/nfsd/nfsctl.c:301: warning: 'maxsize' may be used uninitialized in this function
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Acked-by: Neil Brown <neilb@suse.de> | ```diff
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index d135f5f98519..77dc9893b7ba 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -298,7 +298,7 @@ static ssize_t write_filehandle(struct file *file, char *buf, size_t size)
* qword quoting is used, so filehandle will be \x....
*/
char *dname, *pat... |
dd4877bfb6f09cb4a294b459b354c8fc8fa66904 | Analyze and fix the following issue in the Linux kernel code: knfsd: fix callback rpc cred | Problem Details:
It doesn't make sense to make the callback with credentials that the
client made the setclientid with. Instead the spec requires that the
callback occur with the credentials the client authenticated *to*.
It probably doesn't matter what we use for auth_unix, and some more
infrastructure will be needed... | ```diff
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index c17a5202ee3f..c1cb7e009c1e 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -344,28 +344,6 @@ static struct rpc_version * nfs_cb_version[] = {
&nfs_cb_version4,
};
-/*
- * Use the SETCLIENTID credential
- */
-static struc... |
e8ff2a8453cedf38d6d7a0528cb9c308066a3e3e | Analyze and fix the following issue in the Linux kernel code: knfsd: move nfsv4 slab creation/destruction to module init/exit | Problem Details:
We have some slabs that the nfs4 server uses to store state objects.
We're currently creating and destroying those slabs whenever the server
is brought up or down. That seems excessive; may as well just do that
in module initialization and exit.
Also add some minor header cleanup. (Thanks to Andrew ... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 2b20eb8589a0..09573b9f76c7 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1021,7 +1021,7 @@ nfsd4_free_slab(struct kmem_cache **slab)
*slab = NULL;
}
-static void
+void
nfsd4_free_slabs(void)
{
nfsd4_free_slab(&stateowner_slab... |
2fdada03b3876ab9f84ede160f187e888cafefb4 | Analyze and fix the following issue in the Linux kernel code: knfsd: demote some printk()s to dprintk()s | Problem Details:
To quote a recent mail from Andrew Morton:
Look: if there's a way in which an unprivileged user can trigger
a printk we fix it, end of story.
OK. I assume that goes double for printk()s that might be triggered by
random hosts on the internet. So, disable some printk()s that look like
they could b... | ```diff
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 29b7e63cb32c..18ead1790bb3 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -238,12 +238,12 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
break;
case NFS4_OPEN_CLAIM_DELEGATE_PREV:
open->op_... |
599e0a2290b22d959c7748bda83da3614187a299 | Analyze and fix the following issue in the Linux kernel code: knfsd: cleanup of nfsd4 cmp_* functions | Problem Details:
Benny Halevy suggested renaming cmp_* to same_* to make the meaning of
the return value clearer.
Fix some nearby style deviations while we're at it, including a small
swath of creative indentation in nfs4_preprocess_seqid_op().
Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Acked-by: Neil... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 3f559700788f..578d809e85ec 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -462,26 +462,28 @@ copy_cred(struct svc_cred *target, struct svc_cred *source) {
}
static inline int
-same_name(const char *n1, const char *n2) {
+same_name(c... |
9c85fca56b569dfba1f10ae12ce425c0e678df83 | Analyze and fix the following issue in the Linux kernel code: nfsd: fix horrible indentation in nfsd_setattr | Problem Details:
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Acked-by: Neil Brown <neilb@suse.de> | ```diff
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 7867151ebb83..cec78c82b1f9 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -295,7 +295,8 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
if (!iap->ia_valid)
goto out;
- /* NFSv2 does not differentiate between "set-[ac]time-... |
40d24704091c8a29a4c99d25670f1996749aea6f | Analyze and fix the following issue in the Linux kernel code: NFS: Fix a connectathon regression in NFSv3 and NFSv4 | Problem Details:
We're failing basic test6 against Linux servers because they lack a correct
change attribute. The fix is to assume that we always want to invalidate
the readdir caches when we call update_changeattr and/or
nfs_post_op_update_inode on a directory.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.... | ```diff
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 469387920dd9..c44cd02e5181 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -876,11 +876,19 @@ int nfs_post_op_update_inode(struct inode *inode, struct nfs_fattr *fattr)
{
struct nfs_inode *nfsi = NFS_I(inode);
- if (fattr->valid & NFS_ATTR_FATTR)
+ if ... |
2199700f1d660494d2552278354422c51becb686 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Fix buggy UDP transmission | Problem Details:
xs_sendpages() may return a negative result. We sure as hell don't want to
add that to the 'tk_bytes_sent' tally...
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index e97e4ca43ef3..6f32cc57f429 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -587,13 +587,13 @@ static int xs_udp_send_request(struct rpc_task *task)
dprintk("RPC: xs_udp_send_request(%u) = %d\n",
xdr->len - req->rq_byt... |
67f97d83bfcca9d9f8fbeeb14e7c644a82b24e12 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Use correct type in buffer length calculations | Problem Details:
Use correct type signage in gss_krb5_remove_padding() when doing length
calculations. Both xdr_buf.len and iov.iov_len are size_t, which is
unsigned; so use an unsigned type for our temporary length variable to
ensure we don't overflow it..
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-o... | ```diff
diff --git a/net/sunrpc/auth_gss/gss_krb5_wrap.c b/net/sunrpc/auth_gss/gss_krb5_wrap.c
index 42b3220bed39..8bd074df27d3 100644
--- a/net/sunrpc/auth_gss/gss_krb5_wrap.c
+++ b/net/sunrpc/auth_gss/gss_krb5_wrap.c
@@ -42,7 +42,7 @@ gss_krb5_remove_padding(struct xdr_buf *buf, int blocksize)
{
u8 *ptr;
u8 pad;... |
afde94f398b62c8596a8d0cbfc25798f0b52a371 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Fix default hostname created in rpc_create() | Problem Details:
Since 43780b87fa7..., rpc_create() fills in a default hostname based on
the ip address if the servername passed in is null. A small typo made
that default incorrect. (But this information appears to be used only
for debugging right now, so I don't believe the typo causes any bugs in
the current kerne... | ```diff
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 6cdf53c489b7..e9866fc93df1 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -259,7 +259,7 @@ struct rpc_clnt *rpc_create(struct rpc_create_args *args)
*/
if (args->servername == NULL) {
struct sockaddr_in *addr =
- (struct sockaddr_in... |
d75340cc4de5c187fbf0bba234309ca86cf0a2fb | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix nfs_atomic_open() to set the verifier on negative dentries too | Problem Details:
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 41b063c98822..82878a19538d 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -656,11 +656,6 @@ static int nfs_check_verifier(struct inode *dir, struct dentry *dentry)
return 1;
}
-static inline void nfs_set_verifier(struct dentry * dentry, unsigned long verf)
-{... |
446e534985bada0ad7451c08cf213c06695f9b67 | Analyze and fix the following issue in the Linux kernel code: NFS: Fix a bug in nfs_open_revalidate() | Problem Details:
We want to set the verifier when the call to nfs4_open_revalidate()
_succeeds_.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 166a833be661..d58bfb81354e 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1078,7 +1078,7 @@ static int nfs_open_revalidate(struct dentry *dentry, struct nameidata *nd)
lock_kernel();
verifier = nfs_save_change_attribute(dir);
ret = nfs4_open_revalidate(dir,... |
4b841736bc16b320bcdb1e8ece585b3ced9a8811 | Analyze and fix the following issue in the Linux kernel code: NFS: Fix nfs_verify_change_attribute() | Problem Details:
We don't care about whether or not some other process on our client is
changing the directory while we're in nfs_lookup_revalidate(), because the
dcache will take care of ensuring local atomicity.
We can therefore remove the test for nfs_caches_unstable().
Signed-off-by: Trond Myklebust <Trond.Myklebu... | ```diff
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 07df192e23a0..e275a6eb0a7c 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -646,7 +646,7 @@ static int nfs_check_verifier(struct inode *dir, struct dentry *dentry)
{
if (IS_ROOT(dentry))
return 1;
- if (dentry->d_time == NFS_I(dir)->cache_change_attribute)
+ ... |
8edb01828837302055a8f0afddb2256659480bc5 | Analyze and fix the following issue in the Linux kernel code: NFS: Fix the sign of the return value of nfs_save_change_attribute() | Problem Details:
Also fix up the comments.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index 9449286c5867..a765dd456922 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -260,13 +260,13 @@ static inline int NFS_USE_READDIRPLUS(struct inode *inode)
/**
* nfs_save_change_attribute - Returns the inode attribute chang... |
7fdc49c4e49ba926348f71844cda7f5e12709738 | Analyze and fix the following issue in the Linux kernel code: NFS: Fix the ESTALE "revalidation" in _nfs_revalidate_inode() | Problem Details:
For one thing, the test NFS_ATTRTIMEO() == 0 makes no sense: we're
testing whether or not the cache timeout length is zero, which is totally
unrelated to the issue of whether or not we trust the file staleness.
Secondly, we do not want to retry the GETATTR once a file has been declared
stale by the se... | ```diff
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index e37faa3a7bac..185cfd09d7f7 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -607,16 +607,10 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
status = nfs_wait_on_inode(inode);
if (status < 0)
goto out;
- if (NFS_STALE(inode)) ... |
8850df999cd16aa141098e2e8be04a590276f3cc | Analyze and fix the following issue in the Linux kernel code: NFS: Fix atime revalidation in read() | Problem Details:
NFSv3 will correctly update atime on a read() call, so there is no need to
set the NFS_INO_INVALID_ATIME flag unless the call to nfs_refresh_inode()
fails.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c
index 0ae263cdedc6..fc6b1193a631 100644
--- a/fs/nfs/nfs3proc.c
+++ b/fs/nfs/nfs3proc.c
@@ -727,9 +727,9 @@ static int nfs3_read_done(struct rpc_task *task, struct nfs_read_data *data)
{
if (nfs3_async_handle_jukebox(task, data->inode))
return -EAGAIN;
- ... |
c4812998398d9cbce8646494704c52297359ede0 | Analyze and fix the following issue in the Linux kernel code: NFS: Fix atime revalidation in readdir() | Problem Details:
NFSv3 will correctly update atime on a readdir call, so there is no need to
set the NFS_INO_INVALID_ATIME flag unless the call to nfs_refresh_inode()
fails.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 9f8ec3c3e6a7..07df192e23a0 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -200,9 +200,6 @@ int nfs_readdir_filler(nfs_readdir_descriptor_t *desc, struct page *page)
desc->timestamp = timestamp;
desc->timestamp_valid = 1;
SetPageUptodate(page);
- spin_lock(&i... |
6ecc5e8fcad7ad64d68c098249359831331bd299 | Analyze and fix the following issue in the Linux kernel code: NFS: Fix dcache revalidation bugs | Problem Details:
We don't need to force a dentry lookup just because we're making changes to
the directory.
Don't update nfsi->cache_change_attribute in nfs_end_data_update: that
overrides the NFSv3/v4 weak consistency checking that tells us our update
was the only one, and that tells us the dcache is still valid.
Si... | ```diff
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 2b5e611352c5..6518b098e625 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -650,15 +650,11 @@ static int nfs_fsync_dir(struct file *filp, struct dentry *dentry, int datasync)
*/
static int nfs_check_verifier(struct inode *dir, struct dentry *dentry)
{
- unsigne... |
7957c1418f4b6c66e28d4ac3c4d7a8c19d526c48 | Analyze and fix the following issue in the Linux kernel code: NFS: fix nfs_verify_change_attribute | Problem Details:
We always want to check that the verifier and directory
cache_change_attribute match. This also allows us to remove the 'wraparound
hack' for the cache_change_attribute. If we're only checking for equality,
then we don't care about wraparound issues.
Signed-off-by: Trond Myklebust <Trond.Myklebust@net... | ```diff
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 0d98074d0766..ed035a81eea2 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -972,10 +972,6 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
nfsi->read_cache_jiffies = fattr->time_start;
nfsi->last_updated = now;
- /* Fix a w... |
f2115dc9877d480392e48e3c83bc8cbb4b418fee | Analyze and fix the following issue in the Linux kernel code: NFS: Fix over-conservative attribute invalidation in nfs_update_inode() | Problem Details:
We should always be declaring the attribute cache as valid after having
updated it.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 45633f9ad851..721e511f8ba9 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -978,8 +978,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
/* Are we racing with known updates of the metadata on the server? */
data_stable = n... |
1321d8d971028e796978f6a48d195c09158b3bcd | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Fix bytes-per-op accounting for RPC over UDP | Problem Details:
NFS performance metrics reported zero bytes sent per op when mounting with
UDP. The UDP socket transport wasn't properly counting the number of bytes
sent.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index b81494a97a5e..e97e4ca43ef3 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -587,6 +587,7 @@ static int xs_udp_send_request(struct rpc_task *task)
dprintk("RPC: xs_udp_send_request(%u) = %d\n",
xdr->len - req->rq_bytes... |
20c71f5e0f954b00d75009542db2c1f844d94a1e | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix a bug in nfs4_validate_mount_data() | Problem Details:
The previous patch introduced a bug when copying the server address.
Also clarify a copy into the auth_flavours array: currently the two
size calculations are equivalent, but we may decide to change the size
of auth_flavors[] at some point.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 63742bbcb1ce..3804aadc18c4 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1541,7 +1541,7 @@ static int nfs4_validate_mount_data(void *options,
goto out_no_address;
if (copy_from_user(&args->nfs_server.address,
data->host_addr,
- sizeo... |
4417c8c41a51a2ae95b2a2fa2811640b368c4151 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: export per-transport rpcbind netid's | Problem Details:
The rpcbind (v3+) netid is provided by each RPC client transport. This fixes
an omission in IPv6 rpcbind client support, and enables future extension.
Signed-off-by: Tom Talpey <tmt@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
index 902a9c0a2d9a..513b0657e14d 100644
--- a/include/linux/sunrpc/xprt.h
+++ b/include/linux/sunrpc/xprt.h
@@ -56,6 +56,7 @@ enum rpc_display_format_t {
RPC_DISPLAY_HEX_ADDR,
RPC_DISPLAY_HEX_PORT,
RPC_DISPLAY_UNIVERSAL_ADDR,
+ RPC_DIS... |
fe82a183ca3c9188945c4ebeebc2ca45abfa24e5 | Analyze and fix the following issue in the Linux kernel code: NFS: Convert printk's to dprintk's in fs/nfs/nfs?xdr.c | Problem Details:
Due to recent edict to replace or remove printk's that can be triggered en
masse by remote misbehavior. Left a few that only occur just before a BUG.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/nfs2xdr.c b/fs/nfs/nfs2xdr.c
index c5fce7567200..1c570948fc16 100644
--- a/fs/nfs/nfs2xdr.c
+++ b/fs/nfs/nfs2xdr.c
@@ -271,7 +271,7 @@ nfs_xdr_readres(struct rpc_rqst *req, __be32 *p, struct nfs_readres *res)
res->eof = 0;
hdrlen = (u8 *) p - (u8 *) iov->iov_base;
if (iov->iov_len < hd... |
aad700073557c7932ef9f81c19a5e0647f8a6850 | Analyze and fix the following issue in the Linux kernel code: [NFS] [PATCH] NFS: initialize default port in kernel mount client | Problem Details:
If no mount server port number is specified, the previous change to the
kernel mount client inadvertently allows the NFS server's port number to be
the used as the mount server's port number. If the user specifies an NFS
server port (-o port=x), the mount will fail.
The fix below sets the mount server... | ```diff
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 5085f53be2fe..094d2f832c3c 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1027,8 +1027,10 @@ static int nfs_try_mount(struct nfs_parsed_mount_data *args,
sin = args->mount_server.address;
else
sin = args->nfs_server.address;
- if (args->mount_serv... |
89eb21c35b61b5157940e1b78c2c6d0529d11c63 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: fix a signed v. unsigned comparison nit in rpc_bind_new_program | Problem Details:
/home/cel/linux/net/sunrpc/clnt.c: In function ‘rpc_bind_new_program’:
/home/cel/linux/net/sunrpc/clnt.c:445: warning:
comparison between signed and unsigned
RPC version numbers are u32, not int.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@neta... | ```diff
diff --git a/include/linux/sunrpc/clnt.h b/include/linux/sunrpc/clnt.h
index c0d9d14983b3..d9d5c5ad826c 100644
--- a/include/linux/sunrpc/clnt.h
+++ b/include/linux/sunrpc/clnt.h
@@ -117,7 +117,7 @@ struct rpc_create_args {
struct rpc_clnt *rpc_create(struct rpc_create_args *args);
struct rpc_clnt *rpc_bind... |
143b6c4008a7928de7e139c3a77a90e4cad8db2c | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Fix generation of universal addresses for | Problem Details:
Fix some problems with rpcbind v3 and v4 queries from the in-kernel rpcbind
client:
1. The r_addr argument must be a full universal address, not just an IP
address, and
2. The universal address in r_addr is the address of the remote rpcbind
server, not the RPC service being requested
This addresse... | ```diff
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 7db75e177e67..0bb6709018de 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -387,6 +387,15 @@ void rpcb_getport_async(struct rpc_task *task)
dprintk("RPC: %5u %s: trying rpcbind version %u\n",
task->tk_pid, __FUNCTION__, ... |
0c43b3d81cca46ab2469f8802f8bd68b49f1b2a5 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Free address buffers in a loop | Problem Details:
Use more generic logic to free buffers holding formatted addresses. This
makes it less likely a bug will be introduced when adding additional buffer
types in xs_format_peer_address().
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 015f29edb619..b3f40b8dbcba 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -279,10 +279,14 @@ static void xs_format_peer_addresses(struct rpc_xprt *xprt)
}
xprt->address_strings[RPC_DISPLAY_PORT] = buf;
- if (xprt->prot == ... |
b595bb15061567441546be1af883b256bcdfff9c | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Fix a signed v. unsigned comparison in net/sunrpc/xprtsock.c | Problem Details:
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 4ae7eed7f617..56b226797ae3 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -523,7 +523,8 @@ static int xs_tcp_send_request(struct rpc_task *task)
struct rpc_xprt *xprt = req->rq_xprt;
struct sock_xprt *transport = container_o... |
adc24df81d6903d2d6280d77e936aa5e1670d7a1 | Analyze and fix the following issue in the Linux kernel code: SUNRPC: Fix a signed v. unsigned comparison in rpcbind's XDR routines | Problem Details:
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index d1740dbab991..a9d2cdc8e32c 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -490,10 +490,11 @@ static int rpcb_decode_getaddr(struct rpc_rqst *req, __be32 *p,
unsigned short *portp)
{
char *addr;
- int addr_len, ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.