id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
ffd22b8e08fb86692d316cdcc1a4da4d10a016c5
Analyze and fix the following issue in the Linux kernel code: [PATCH] another build fix, header rearrangements (OSK)
Problem Details: Some of the header file rearrangements broke the build for board-osk. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Cc: Russell King <rmk@arm.linux.org.uk> Cc: <tony@atomide.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c index 3a622801d7b0..7d0cf7af88ce 100644 --- a/arch/arm/mach-omap1/board-osk.c +++ b/arch/arm/mach-omap1/board-osk.c @@ -30,6 +30,7 @@ #include <linux/init.h> #include <linux/platform_device.h> #include <linux/irq.h> +#include <lin...
8c1bc04e793a7ff4004180aa42890c3d382ec87f
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix more workqueue build breakage (tps65010)
Problem Details: More fixes to build breakage from the work_struct changes ... this updates the tps65010 driver. Plus, fix some dependencies related to the way it's used on the OMAP OSK: force static linking there, since the resulting kernel can't link. NOTE that until the i2c core gets fixed to work without SMBUS_Q...
```diff diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig index d135568dc9e7..8781aaeb576b 100644 --- a/arch/arm/mach-omap1/Kconfig +++ b/arch/arm/mach-omap1/Kconfig @@ -43,6 +43,7 @@ config MACH_OMAP_H3 config MACH_OMAP_OSK bool "TI OSK Support" depends on ARCH_OMAP1 && ARCH_OMAP16XX + select...
5aff458e9c90df55d6badabd89a1a063a80d9768
Analyze and fix the following issue in the Linux kernel code: [PATCH] KVM: Clean up AMD SVM debug registers load and unload
Problem Details: By letting gcc choose the temporary register for us, we lose arch dependency and some ugliness. Conceivably gcc will also generate marginally better code. Signed-off-by: Avi Kivity <avi@qumranet.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c index a33a89c68138..d6042eed7a78 100644 --- a/drivers/kvm/svm.c +++ b/drivers/kvm/svm.c @@ -1345,53 +1345,18 @@ static void kvm_reput_irq(struct kvm_vcpu *vcpu) static void save_db_regs(unsigned long *db_regs) { -#ifdef __x86_64__ - asm ("mov %%dr0, %%rax \...
4ab70df451c6183dd5474a68edac44684b0b7616
Analyze and fix the following issue in the Linux kernel code: [CPUFREQ] fixes typo in cpufreq.c
Problem Details: This patch fixes a typo in cpufreq.c From: Dhaval Giani <dhaval.giani@gmail.com> Signed-off-by: Dave Jones <davej@redhat.com>
```diff diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9fb2edf36611..d91330432ba2 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -959,7 +959,7 @@ static void cpufreq_out_of_sync(unsigned int cpu, unsigned int old_freq, /** - * cpufreq_quick_get - get the CPU fre...
2fc2c60df3d2b3a557eb8d750779def9d51934b1
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fixup cciss error handling
Problem Details: The previous cciss commit removed the err_out_disable_pdev label, but there was still a user of that. Fix that up. Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
```diff diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 335e218b6dcc..2ee4a44423df 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -2837,7 +2837,7 @@ static int cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev) if (err) { printk(KERN_ERR "cciss: Cannot obtain PCI resources, " ...
82b399133b6ebf667ee635fc69ef26b61eede4bc
Analyze and fix the following issue in the Linux kernel code: IPoIB: Make sure struct ipoib_neigh.queue is always initialized
Problem Details: Move the initialization of ipoib_neigh's skb_queue into ipoib_neigh_alloc(), since commit 2745b5b7 ("IPoIB: Fix skb leak when freeing neighbour") will make iterate over the skb_queue to free any packets left over when freeing the ipoib_neigh structure. This fixes a crash when freeing ipoib_neigh struc...
```diff diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index c09280243726..705eb1d0e554 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -497,8 +497,6 @@ static void neigh_add_path(struct sk_buff *skb, struct ne...
3f4a25f17e1073b5af36678b69755af6e56780c3
Analyze and fix the following issue in the Linux kernel code: [CPUFREQ] Longhaul - fix 200MHz FSB
Problem Details: On board of Epia SP13000 is 10x133Mhz VIA Nehemiah. It is reported as 10x200MHz. This patch is fixing this issue. Signed-off-by: Rafa Bilski <rafalbilski@interia.pl> Signed-off-by: Dave Jones <davej@redhat.com>
```diff diff --git a/arch/i386/kernel/cpu/cpufreq/longhaul.c b/arch/i386/kernel/cpu/cpufreq/longhaul.c index 7233abe5d695..05946293364c 100644 --- a/arch/i386/kernel/cpu/cpufreq/longhaul.c +++ b/arch/i386/kernel/cpu/cpufreq/longhaul.c @@ -410,7 +410,7 @@ static int __init longhaul_get_ranges(void) maxmult=longhaul_...
e11952b971ee729a8fdc2bfb1252f5760c0287b0
Analyze and fix the following issue in the Linux kernel code: [CPUFREQ] p4-clockmod: fix support for Core
Problem Details: Support for Core CPUs was broken in two ways in speedstep-lib: for x86_64, we missed a MSR definition; for both x86_64 and i386, the FSB calculation was wrong by four (it's a quad-pumped bus). Also increase the accuracy of the calculation. Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> ...
```diff diff --git a/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c b/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c index a709f6d67e25..d59277c00911 100644 --- a/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c +++ b/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c @@ -123,23 +123,22 @@ static unsigned int pentiumM_get_frequency(...
7531a0b56f6211a5407c8cda4968c3b7ca9496ab
Analyze and fix the following issue in the Linux kernel code: [CPUFREQ] Fix git URL.
Problem Details: Signed-off-by: Dave Jones <davej@redhat.com>
```diff diff --git a/MAINTAINERS b/MAINTAINERS index a2b6d9fa3502..b444b0b5c772 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -720,7 +720,7 @@ P: Dave Jones M: davej@codemonkey.org.uk L: cpufreq@lists.linux.org.uk W: http://www.codemonkey.org.uk/projects/cpufreq/ -T: git kernel.org/pub/scm/linux/kernel/davej/cpufreq...
3d4a7ef3d3f0c9f3cf8da724d5935253a713d8b6
Analyze and fix the following issue in the Linux kernel code: [CPUFREQ] Fix the bug in duplicate freq elimination code in acpi-cpufreq
Problem Details: Fix the bug in duplicate states elimination in acpi-cpufreq. Bug: Due to duplicate state elimiation in the loop earlier, the number of valid_states can be less than perf->state_count, in which case freq_table was ending up with some garbage/uninitialized entries in the table. Signed-off-by: Venkatesh...
```diff diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c index 60d20cf427aa..18f4715c655d 100644 --- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c +++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c @@ -693,7 +693,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_p...
0a1336c8c93530b93c8ecd8c9882f5e528673cab
Analyze and fix the following issue in the Linux kernel code: IB/ipath: Fix IRQ for PCI Express HCAs
Problem Details: Commit 51f65ebc ("IB/ipath - program intconfig register using new HT irq hook"), which fixed interrupts for HyperTransport HCAs, broke PCI Express HCAs, because for those HCAs, the driver uses the value of pdev->irq before pci_enable_msi() and ends up getting a totally bogus IRQ number. Fix this by us...
```diff diff --git a/drivers/infiniband/hw/ipath/ipath_iba6120.c b/drivers/infiniband/hw/ipath/ipath_iba6120.c index 397da3483af1..ae8bf9950c6d 100644 --- a/drivers/infiniband/hw/ipath/ipath_iba6120.c +++ b/drivers/infiniband/hw/ipath/ipath_iba6120.c @@ -851,12 +851,12 @@ static int ipath_setup_pe_config(struct ipath_d...
ad1f9791e91511fcff21730e55ad8dbc375c79bb
Analyze and fix the following issue in the Linux kernel code: RDMA/amso1100: Fix memory leak in c2_qp_modify()
Problem Details: vq_req is leaked in error cases. Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
```diff diff --git a/drivers/infiniband/hw/amso1100/c2_qp.c b/drivers/infiniband/hw/amso1100/c2_qp.c index 179d005ed4a5..420c1380f5c3 100644 --- a/drivers/infiniband/hw/amso1100/c2_qp.c +++ b/drivers/infiniband/hw/amso1100/c2_qp.c @@ -161,8 +161,10 @@ int c2_qp_modify(struct c2_dev *c2dev, struct c2_qp *qp, if (att...
f47e22c6e4225f40e0dd662398e2cb204f6ec8ed
Analyze and fix the following issue in the Linux kernel code: IB/fmr: ib_flush_fmr_pool() may wait too long
Problem Details: ib_flush_fmr_pool() stashes away the request generation number properly, but then goes ahead and rereads it every time it tests whether the flush generation number has caught up. This means that there is a theoretical possibility of livelock, if the request generation number keeps getting bumped and t...
```diff diff --git a/drivers/infiniband/core/fmr_pool.c b/drivers/infiniband/core/fmr_pool.c index 86a3b2d401db..8926a2bd4a87 100644 --- a/drivers/infiniband/core/fmr_pool.c +++ b/drivers/infiniband/core/fmr_pool.c @@ -394,20 +394,12 @@ EXPORT_SYMBOL(ib_destroy_fmr_pool); */ int ib_flush_fmr_pool(struct ib_fmr_pool ...
a460ef8d0a98ac9ef6b829ae292c9b6c13bc0120
Analyze and fix the following issue in the Linux kernel code: [IA64] fix possible XPC deadlock when disconnecting
Problem Details: This patch eliminates a potential deadlock that is possible when XPC disconnects a channel to a partition that has gone down. This deadlock will occur if at least one of the kthreads created by XPC for the purpose of making callouts to the channel's registerer is detained in the registerer and will not...
```diff diff --git a/arch/ia64/sn/kernel/xpc_channel.c b/arch/ia64/sn/kernel/xpc_channel.c index 1f3540826e68..c08db9c2375d 100644 --- a/arch/ia64/sn/kernel/xpc_channel.c +++ b/arch/ia64/sn/kernel/xpc_channel.c @@ -632,7 +632,7 @@ xpc_process_connect(struct xpc_channel *ch, unsigned long *irq_flags) ch->number, ch->...
1cf24bdbbbd2eb5439796dc399ab1649d150ed1d
Analyze and fix the following issue in the Linux kernel code: [IA64] - Reduce overhead of FP exception logging messages
Problem Details: Improve the scalability of the fpswa code that rate-limits logging of messages. There are 2 distinctly different problems in this code. 1) If prctl is used to disable logging, last_time is never updated. The result is that fpu_swa_count is zeroed out on EVERY fp fault. This causes a very very h...
```diff diff --git a/arch/ia64/kernel/traps.c b/arch/ia64/kernel/traps.c index fffa9e0826bc..ab684747036f 100644 --- a/arch/ia64/kernel/traps.c +++ b/arch/ia64/kernel/traps.c @@ -307,6 +307,15 @@ fp_emulate (int fp_fault, void *bundle, long *ipsr, long *fpsr, long *isr, long return ret.status; } +struct fpu_swa_ms...
8b9c106856d92c8266697328b148d115538b59ce
Analyze and fix the following issue in the Linux kernel code: [IA64] fix arch/ia64/mm/contig.c:235: warning: unused variable `nid'
Problem Details: This warning only shows up with CONFIG_VIRTUAL_MEM_MAP=y and CONFIG_FLATMEM=y. There is only one caller left for register_active_ranges() from the contig.c code ... so it doesn't need to pick up the node number, the node number is always zero. Signed-off-by: Tony Luck <tony.luck@intel.com>
```diff diff --git a/arch/ia64/mm/contig.c b/arch/ia64/mm/contig.c index fd103886bb0a..1e79551231b9 100644 --- a/arch/ia64/mm/contig.c +++ b/arch/ia64/mm/contig.c @@ -232,7 +232,6 @@ void __init paging_init (void) { unsigned long max_dma; - unsigned long nid = 0; unsigned long max_zone_pfns[MAX_NR_ZONES]; num...
18b36c7119aa868fdfae6855b86824db238e5ebc
Analyze and fix the following issue in the Linux kernel code: Fix inotify maintainers entry
Problem Details: Update the inotify entry in MAINTAINERS to be consistent with the rest of the file. Signed-off-by: Cal Peake <cp@absolutedigital.net> Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/MAINTAINERS b/MAINTAINERS index b2024938adcf..9649ed90e793 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1504,8 +1504,10 @@ T: git kernel.org:/pub/scm/linux/kernel/git/dtor/input.git S: Maintained INOTIFY -P: John McCutchan and Robert Love -M: ttb@tentacle.dhs.org and rml@novell.com +P: John M...
86327d19f7d91270b0bbd06ad4581e2f6fa3bec0
Analyze and fix the following issue in the Linux kernel code: Fix typo in new debug options.
Problem Details: Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 0701ddda1df8..818e4589f718 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -437,7 +437,7 @@ config FAIL_PAGE_ALLOC Provide fault-injection capability for alloc_pages(). config FAIL_MAKE_REQUEST - bool "Fault-injection capabilitiy for disk...
47c6bf7760bb8021bf7782f05bcd3b9f73ed2c2e
Analyze and fix the following issue in the Linux kernel code: fix typo in net/ipv4/ip_fragment.c
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 74046efdf875..8ce00d3703da 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -565,7 +565,7 @@ static void ip_frag_queue(struct ipq *qp, struct sk_buff *skb) } else { struct sk_buff *free_it = next; - /* Old fragmnet ...
979c6a1e49875e9277b5113295a48d5641f02465
Analyze and fix the following issue in the Linux kernel code: Kconfig: fix spelling error in config KALLSYMS help text
Problem Details: Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Acked-By: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/init/Kconfig b/init/Kconfig index 9edf103b3ec3..f000edb3bb7a 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -348,7 +348,7 @@ config SYSCTL_SYSCALL If unsure say Y here. config KALLSYMS - bool "Load all symbols for debugging/kksymoops" if EMBEDDED + bool "Load all symbols for debugging/ksy...
87c18aa95199b4b7dd9510b2b927a5e30083da01
Analyze and fix the following issue in the Linux kernel code: Fix small typo in drivers/serial/icom.c
Problem Details: Signed-off-by: Thomas Hisch <t.hisch@gmail.com> Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/drivers/serial/icom.c b/drivers/serial/icom.c index 7d623003e65e..71e6a24d8c28 100644 --- a/drivers/serial/icom.c +++ b/drivers/serial/icom.c @@ -1510,7 +1510,7 @@ static int __devinit icom_probe(struct pci_dev *dev, } if ( (retval = pci_request_regions(dev, "icom"))) { - dev_err(&dev->dev,...
45a98fc622ae700eed34eb2be00743910d50dbe1
Analyze and fix the following issue in the Linux kernel code: [IA64] CONFIG_KEXEC/CONFIG_CRASH_DUMP permutations
Problem Details: Actually, on reflection I think that there is a good case for keeping the options separate. I am thinking particularly of people who want a very small crashdump kernel and thus don't want to compile in kexec. The patch below should fix things up so that all valid combinations of KEXEC, CRASH_DUMP and ...
```diff diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile index 8ae384eb5357..098ee605bf5e 100644 --- a/arch/ia64/kernel/Makefile +++ b/arch/ia64/kernel/Makefile @@ -29,6 +29,7 @@ obj-$(CONFIG_CPU_FREQ) += cpufreq/ obj-$(CONFIG_IA64_MCA_RECOVERY) += mca_recovery.o obj-$(CONFIG_KPROBES) += kprobes.o...
dcb69dd010c182507a8db8940618f6413f65e0af
Analyze and fix the following issue in the Linux kernel code: hwmon: New AMS hardware monitoring driver
Problem Details: This driver adds support for the Apple Motion Sensor (AMS) as found in 2005 revisions of Apple PowerBooks and iBooks. It implements both the PMU and I2C variants. The I2C driver and mouse emulation is based on code by Stelian Pop, while the PMU driver has been developped by Michael Hanselmann. HD par...
```diff diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 23b7eac563b3..891ef6d0b1bf 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -106,6 +106,31 @@ config SENSORS_K8TEMP This driver can also be built as a module. If so, the module will be called k8temp. +config SENSORS_AMS...
75c990291dd7af84ea68f3c3ead934b51d0b81ad
Analyze and fix the following issue in the Linux kernel code: hwmon/f71805f: Fix the device address decoding
Problem Details: The lowest 3 bits are ignored, and the chip decodes all 8 addresses, not only the 2 it needs. Signed-off-by: Jean Delvare <khali@linux-fr.org>
```diff diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c index 37ba421789bc..a272cae8f60e 100644 --- a/drivers/hwmon/f71805f.c +++ b/drivers/hwmon/f71805f.c @@ -102,9 +102,9 @@ superio_exit(int base) * ISA constants */ -#define REGION_LENGTH 2 -#define ADDR_REG_OFFSET 0 -#define DATA_REG_OFFSET 1...
3640543df26fd38f31f0c6decc35c07be2a6307c
Analyze and fix the following issue in the Linux kernel code: [PATCH] netpoll: fix netpoll lockup
Problem Details: current -git doesnt boot on my laptop due to netpoll not unlocking the tx lock in the else branch. booted this up on my laptop with lockdep enabled and there are no locking complaints and it works fine. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/net/core/netpoll.c b/net/core/netpoll.c index a01abdd2d3ea..823215d8e90f 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -55,6 +55,7 @@ static void queue_process(struct work_struct *work) struct netpoll_info *npinfo = container_of(work, struct netpoll_info, tx_work.work); struct ...
b57bd06655a028aba7b92e1c19c2093e7fcfb341
Analyze and fix the following issue in the Linux kernel code: [PATCH] net, 8139too.c: fix netpoll deadlock
Problem Details: fix deadlock in the 8139too driver: poll handlers should never forcibly enable local interrupts, because they might be used by netpoll/printk from IRQ context. ================================= [ INFO: inconsistent lock state ] 2.6.19 #11 --------------------------------- inconsistent {softi...
```diff diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c index 931028f672de..35ad5cff18e6 100644 --- a/drivers/net/8139too.c +++ b/drivers/net/8139too.c @@ -2131,14 +2131,15 @@ static int rtl8139_poll(struct net_device *dev, int *budget) } if (done) { + unsigned long flags; /* * Order is importa...
99a3eb3845f034eb55640a3da73e5e28349678c6
Analyze and fix the following issue in the Linux kernel code: [PATCH] lockdep: fix seqlock_init()
Problem Details: seqlock_init() needs to use spin_lock_init() for dynamic locks, so that lockdep is notified about the presence of a new lock. (this is a fallout of the recent networking merge, which started using the so-far unused seqlock_init() API.) This fix solves the following lockdep-internal warning on current...
```diff diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h index 46000936f8f1..6b0648cfdffc 100644 --- a/include/linux/seqlock.h +++ b/include/linux/seqlock.h @@ -44,8 +44,11 @@ typedef struct { #define SEQLOCK_UNLOCKED \ __SEQLOCK_UNLOCKED(old_style_seqlock_init) -#define seqlock_init(x) \ - do { *...
2a7e9a260ede3b17b5bc25c540a033a45bbf0461
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4954): Fix: On ia64, i2c adap->inb/adap->outb are wrongly evaluated
Problem Details: i2c defines two callbacks (inb/outb). On ia64, since it defines also two macros with those names, it causes the following errors: drivers/media/video/usbvision/usbvision-i2c.c:64:39: macro "outb" passed 4 arguments, but takes just 2 drivers/media/video/usbvision/usbvision-i2c.c: In function `try_write_...
```diff diff --git a/drivers/media/video/usbvision/usbvision-i2c.c b/drivers/media/video/usbvision/usbvision-i2c.c index 92bf9a1f1e2c..0f3fba7ea6fe 100644 --- a/drivers/media/video/usbvision/usbvision-i2c.c +++ b/drivers/media/video/usbvision/usbvision-i2c.c @@ -50,6 +50,11 @@ MODULE_PARM_DESC(i2c_debug, "enable debug ...
77d172ce2719b5ad2dc0637452c8871d9cba344c
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix SG_IO bio leak
Problem Details: This patch fixes bio leaks in SG_IO. rq->bio can be changed after io completion, so we need to reset rq->bio before calling blk_rq_unmap_user() http://marc.theaimsgroup.com/?l=linux-kernel&m=116570666807983&w=2 Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Signed-off-by: Jens Axboe <...
```diff diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index b3e210723a71..045cabd3d4b4 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -228,6 +228,7 @@ static int sg_io(struct file *file, request_queue_t *q, struct request *rq; char sense[SCSI_SENSE_BUFFERSIZE]; unsigned char cmd[BLK_MAX_CDB]; ...
f41464fd84463dee89d53750cb74f6be30b31620
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix thinko in cpu_data.lock removal
Problem Details: Need to remove the initializer as well. Doh. Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/arch/parisc/kernel/processor.c b/arch/parisc/kernel/processor.c index fb81e5687e7c..0af1fad2fc65 100644 --- a/arch/parisc/kernel/processor.c +++ b/arch/parisc/kernel/processor.c @@ -153,8 +153,6 @@ static int __init processor_probe(struct parisc_device *dev) p->cpuid = cpuid; /* save CPU id */ ...
cbb8fc07974073543fdc61da23713ab49ddd3ced
Analyze and fix the following issue in the Linux kernel code: [MIPS] paging_init(): use highend_pfn/highstart_pfn
Problem Details: This patch makes paging_init() use highend_pfn/highstart_pfn globals. It removes the need of 'high' local which was needed only by HIGHMEM config. More important perhaps, it fixes a bug when HIGHMEM is set but there's actually no physical highmem (highend_pfn = 0) Signed-off-by: Franck Bui-Huu <fbui...
```diff diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c index 9e29ba9205f0..ea2d15370bb7 100644 --- a/arch/mips/mm/init.c +++ b/arch/mips/mm/init.c @@ -316,7 +316,7 @@ static int __init page_is_ram(unsigned long pagenr) void __init paging_init(void) { unsigned long zones_size[MAX_NR_ZONES] = { 0, }; - unsign...
2bbc5bdfb165521b28ca1825ea482557bffd3918
Analyze and fix the following issue in the Linux kernel code: [MIPS] IP27: Move definition of nic_t to its sole user.
Problem Details: This also fixes the duplicate definition of nic_t in the s2io driver. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/sn/arch.h b/include/asm-mips/sn/arch.h index 51174af6ac52..da523de628be 100644 --- a/include/asm-mips/sn/arch.h +++ b/include/asm-mips/sn/arch.h @@ -18,7 +18,6 @@ #endif typedef u64 hubreg_t; -typedef u64 nic_t; #define cputonasid(cpu) (cpu_data[(cpu)].p_nasid) #define cp...
a49f99ffca57a2eada23b1ac908a405c17859e35
Analyze and fix the following issue in the Linux kernel code: [NETPOLL]: Fix local_bh_enable() warning.
Problem Details: During boot we get: netconsole: device eth0 not up yet, forcing it e1000: eth0: e1000_watchdog: NIC Link is Up 100 Mbps Full Duplex WARNING (!__warned) at kernel/softirq.c:137 local_bh_enable() Call Trace: [<ffffffff80235baf>] local_bh_enable+0x41/0xa3 [<ffffffff8045ab8e>] netpoll_send_skb+0x116/0x...
```diff diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 156d7fd81fec..a01abdd2d3ea 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -243,7 +243,9 @@ static void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb) /* don't get messages out of order, and no recursion */ if (skb_queue_len(&...
e9cfc147df99790a7d260e9d20b865fa31ec56da
Analyze and fix the following issue in the Linux kernel code: sh: Fixup SH-2 BUG() trap handling.
Problem Details: This adds in support for the BUG() trap on SH-2. Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/kernel/cpu/sh2/entry.S b/arch/sh/kernel/cpu/sh2/entry.S index 34d51b3745ea..d51fa5e9904a 100644 --- a/arch/sh/kernel/cpu/sh2/entry.S +++ b/arch/sh/kernel/cpu/sh2/entry.S @@ -177,15 +177,21 @@ interrupt_entry: 7: .long do_IRQ 8: .long do_exception_error -trap_entry: - add #-0x10,r9 +tr...
e2dfb912d3cea97d8b1d6750abbe9c942b6f73f5
Analyze and fix the following issue in the Linux kernel code: sh: Fix .empty_zero_page alignment for PAGE_SIZE > 4096.
Problem Details: Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/boot/compressed/head.S b/arch/sh/boot/compressed/head.S index 4c26a192277d..a8399b013729 100644 --- a/arch/sh/boot/compressed/head.S +++ b/arch/sh/boot/compressed/head.S @@ -8,6 +8,7 @@ .text #include <linux/linkage.h> +#include <asm/page.h> .global startup startup: @@ -97,7 +98,7 ...
f668f55c3941faacc6f298f434b1af3d5142eed7
Analyze and fix the following issue in the Linux kernel code: sh: Fixup .data.page_aligned.
Problem Details: This had a bogus .data.idt reference, fix it up.. Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/kernel/vmlinux.lds.S b/arch/sh/kernel/vmlinux.lds.S index 77b4026d5688..f34bdcc33a7d 100644 --- a/arch/sh/kernel/vmlinux.lds.S +++ b/arch/sh/kernel/vmlinux.lds.S @@ -51,7 +51,7 @@ SECTIONS } . = ALIGN(PAGE_SIZE); - .data.page_aligned : { *(.data.idt) } + .data.page_aligned : { *(.d...
1dc417d0390b4897dc1d9bbf335e325baecae2c3
Analyze and fix the following issue in the Linux kernel code: sh: Fixup sh_bios() trap handling.
Problem Details: This was inadvertently broken when the entry.S code split up, restore the missing branch and get subsequent traps working under debug again. This manifested itself as a lockup when attempting to reload the VBR base. Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/kernel/entry-common.S b/arch/sh/kernel/entry-common.S index 29136a35d7c7..fc279aeb73ab 100644 --- a/arch/sh/kernel/entry-common.S +++ b/arch/sh/kernel/entry-common.S @@ -79,18 +79,29 @@ debug_kernel_sw: .align 2 3: .long kgdb_handle_exception #endif /* CONFIG_SH_KGDB */ - +#ifdef CONFIG...
b652c23cb0f7808bedb5442c416d91705a465c67
Analyze and fix the following issue in the Linux kernel code: sh: Fix get_wchan().
Problem Details: Some time ago the schedule frame size changed and we failed to reflect this in get_wchan() at the time. This first popped up as a problem on SH7751R where schedule_frame ended up being unaligned and generating an unaligned trap. This fixes it up again.. Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/kernel/process.c b/arch/sh/kernel/process.c index 7347f6afa030..486c06e18033 100644 --- a/arch/sh/kernel/process.c +++ b/arch/sh/kernel/process.c @@ -470,9 +470,10 @@ unsigned long get_wchan(struct task_struct *p) */ pc = thread_saved_pc(p); if (in_sched_functions(pc)) { - schedule_...
dc34d312c7b25d5d0f54c16d143a9526936e5d38
Analyze and fix the following issue in the Linux kernel code: sh: BUG() handling through trapa vector.
Problem Details: Previously we haven't been doing anything with verbose BUG() reporting, and we've been relying on the oops path for handling BUG()'s, which is rather sub-optimal. This switches BUG handling to use a fixed trapa vector (#0x3e) where we construct a small bug frame post trapa instruction to get the conte...
```diff diff --git a/arch/sh/kernel/process.c b/arch/sh/kernel/process.c index f3e2631be144..7347f6afa030 100644 --- a/arch/sh/kernel/process.c +++ b/arch/sh/kernel/process.c @@ -498,6 +498,16 @@ asmlinkage void break_point_trap_software(unsigned long r4, unsigned long r5, { struct pt_regs *regs = RELOC_HIDE(&__regs...
a16147965ca7a84dc08c4457961782e06ac7cd0d
Analyze and fix the following issue in the Linux kernel code: rtc: rtc-sh: fix rtc for out-by-one for the month.
Problem Details: The RMONCNT register, which holds the month in the RTC, takes a value between 1 and 12 while the tm_mon field in the time structures takes a value between 0 and 11. This wasn't being taken into account in rtc-sh resulting in the month being out by one. eg, on my board during boot the RTC is set to: ...
```diff diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c index 1ffc01ea730e..8f22eb1aff5c 100644 --- a/drivers/rtc/rtc-sh.c +++ b/drivers/rtc/rtc-sh.c @@ -268,7 +268,7 @@ static int sh_rtc_read_time(struct device *dev, struct rtc_time *tm) tm->tm_hour = BCD2BIN(readb(rtc->regbase + RHRCNT)); tm->tm_wday =...
a45e724ba07c02bcf3da96ddc4efefbfe10957f5
Analyze and fix the following issue in the Linux kernel code: sh: Fix Solution Engine 7619 build.
Problem Details: Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/boards/se/7619/io.c b/arch/sh/boards/se/7619/io.c index 176f1f39cd9d..2f105c3dd818 100644 --- a/arch/sh/boards/se/7619/io.c +++ b/arch/sh/boards/se/7619/io.c @@ -25,78 +25,78 @@ static inline void delay(void) printk("bad I/O operation (%s) for port 0x%lx at 0x%08x\n", \ #name, (port),...
11cbb70ea326e8ec78b2beb2b0c85c9ec71c279b
Analyze and fix the following issue in the Linux kernel code: sh: Trivial build fixes for SH-2 support.
Problem Details: Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 8e24c40662e3..3aa3b885ab36 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -479,7 +479,7 @@ config SH_CLK_MD int "CPU Mode Pin Setting" depends on CPU_SUBTYPE_SH7619 || CPU_SUBTYPE_SH7206 help - MD2 - MD0 Setting. + MD2 - MD0 pin setting. m...
ff4e2ca7c64cd87ec72fa0d238c1b34493133910
Analyze and fix the following issue in the Linux kernel code: sh: gcc4 symbol export fixups.
Problem Details: gcc 4 for sh changes the names of some compiler intrinsic functions and adds some additional ones. This patch adds the new ones, and fixes up various module symbol resolution issues. Signed-off-by: Stuart Menefy <stuart.menefy@st.com> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/kernel/sh_ksyms.c b/arch/sh/kernel/sh_ksyms.c index ceee79143401..e6106239a0fe 100644 --- a/arch/sh/kernel/sh_ksyms.c +++ b/arch/sh/kernel/sh_ksyms.c @@ -70,13 +70,26 @@ DECLARE_EXPORT(__sdivsi3); DECLARE_EXPORT(__ashrdi3); DECLARE_EXPORT(__ashldi3); DECLARE_EXPORT(__lshrdi3); -DECLARE_E...
b6250e37292b9679b82a3edc28f330a32eed9ae4
Analyze and fix the following issue in the Linux kernel code: sh: landisk board build fixes.
Problem Details: Get the landisk board building again.. Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/arch/sh/boards/landisk/irq.c b/arch/sh/boards/landisk/irq.c index 8f2e1c68b90f..3eba6d086d7f 100644 --- a/arch/sh/boards/landisk/irq.c +++ b/arch/sh/boards/landisk/irq.c @@ -16,8 +16,8 @@ */ #include <linux/init.h> #include <linux/irq.h> -#include <asm/io.h> -#include <asm/irq.h> +#include <lin...
31ccb081ec6c7eedfd7e88a48365c67ce44ecb92
Analyze and fix the following issue in the Linux kernel code: rtc: rtc-sh: fix for period rtc interrupts.
Problem Details: When testing the per second interrupt support (RTC_UIE_ON/RTC_UIE_OFF) of the new RTC system it would die in sh_rtc_interrupt due to a null ptr dereference. The following gets it working correctly. Signed-off-by: Jamie Lenehan <lenehan@twibble.org> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
```diff diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c index 143302a8e79c..1ffc01ea730e 100644 --- a/drivers/rtc/rtc-sh.c +++ b/drivers/rtc/rtc-sh.c @@ -21,7 +21,7 @@ #include <linux/seq_file.h> #include <linux/interrupt.h> #include <linux/spinlock.h> -#include <asm/io.h> +#include <linux/io.h> #ifdef C...
f654c854d1d4e0aca5389ace541647237eb7f753
Analyze and fix the following issue in the Linux kernel code: [HAMRADIO]: Fix baycom_epp.c compile failure.
Problem Details: Fix foobar in 15b1c0e822f578306332d4f4c449250db5c5dceb and e8cc49bb0fdb9e18a99e6780073d1400ba2b0d1f patch series. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c index 8a83db0fb3b7..153b6dc80af4 100644 --- a/drivers/net/hamradio/baycom_epp.c +++ b/drivers/net/hamradio/baycom_epp.c @@ -1177,7 +1177,7 @@ static void baycom_probe(struct net_device *dev) dev->mtu = AX25_DEF_PACLEN; /...
9e8efc824098c241a1cde81f5558d222cb6f9369
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: BUG-FIX - conversion errors
Problem Details: This fixes conversion errors which arose by not properly type-casting from u32 to __u64. Fixed by explicitly casting each type which is not __u64, or by performing operation after assignment. The patch further adds missing debug information to track the current value of X_recv. Signed-off-by: Gerrit ...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index d23af7b475a0..6bc77ff20908 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -123,18 +123,19 @@ static void ccid3_hc_tx_update_x(struct sock *sk, struct timeval *now) if (hctx->ccid3hctx_p > 0) { - hctx->ccid3hctx_x = mi...
a967241129f6dc1db92fee2c808f73a90f5f47a3
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Make debug output consistent
Problem Details: This patch does not alter any algorithm, just the debug message format: * s#%s, sk=%p#%s(%p)#g * when a statename is present, it now uses %s(%p, state=%s) * when only function entry is debugged, it adds an `- entry' Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Acked-by: Ian McDonald <ian...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index ef68c35183ed..d23af7b475a0 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -201,18 +201,17 @@ static void ccid3_hc_tx_no_feedback_timer(unsigned long data) goto restart_timer; } - ccid3_pr_debug("%s, sk=%p, state=%s\n"...
f6282f4da5eb67e08eff94d73a1911c3a008846a
Analyze and fix the following issue in the Linux kernel code: [DCCP]: Warn when discarding packet due to internal errors
Problem Details: This adds a (debug) warning message which is triggered whenever a packet is discarded due to send failure. It also adds a conditional, so that an interruption during dccp_wait_for_ccid is not treated as a `BUG': the rationale is that interruptions are external, whereas bug warnings are concerned with ...
```diff diff --git a/net/dccp/output.c b/net/dccp/output.c index 29a8e8508462..b4df12b24161 100644 --- a/net/dccp/output.c +++ b/net/dccp/output.c @@ -241,7 +241,7 @@ void dccp_write_xmit(struct sock *sk, int block) break; } else err = dccp_wait_for_ccid(sk, skb); - if (err) + if (err && err != -EINTR...
d63d8364cfe17fc9bb738f554f452595f76f21d2
Analyze and fix the following issue in the Linux kernel code: [DCCP]: Simplify TFRC calculation
Problem Details: In migrating towards using the newer functions scaled_div/scaled_div32 for TFRC computations mapped from floating-point onto integer arithmetic, this completes the last stage of modifications. In particular, the overflow case for computing X_calc is circumvented by * breaking the computation into two...
```diff diff --git a/net/dccp/ccids/ccid3.h b/net/dccp/ccids/ccid3.h index cd4fc542f73e..da0ca3c0a7b3 100644 --- a/net/dccp/ccids/ccid3.h +++ b/net/dccp/ccids/ccid3.h @@ -171,23 +171,4 @@ static inline struct ccid3_hc_rx_sock *ccid3_hc_rx_sk(const struct sock *sk) return ccid_priv(dccp_sk(sk)->dccps_hc_rx_ccid); ...
0f9e5b573f7249b0e04a03457b55081d1f60f2bf
Analyze and fix the following issue in the Linux kernel code: [DCCP]: Debug timeval operations
Problem Details: Problem: Most target types in the CCID3 code are u32, so subtle conversion errors can occur if signed time calculations yield negative results: the original values are lost in the conversion to unsigned, calculation errors go undetected. This patch therefore * sets all critical time types from...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 89ef1183e48c..820bc25e14dc 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -128,8 +128,8 @@ static void ccid3_hc_tx_update_x(struct sock *sk, struct timeval *now) hctx->ccid3hctx_x = max_t(u64, hctx->ccid3hctx_x, (...
bfe24a6cc222d27e1491f850802fa6932232b8ef
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Simplify calculation for reverse lookup of p
Problem Details: This simplifies the calculation of a value p for a given fval when the first loss interval is computed (RFC 3448, 6.3.1). It makes use of the two new functions scaled_div/scaled_div32 to provide overflow protection. Additionally, protection against divide-by-zero is extended - in this case the fun...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index bdd13de4f422..89ef1183e48c 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -785,12 +785,12 @@ static u32 ccid3_hc_rx_calc_first_li(struct sock *sk) { struct ccid3_hc_rx_sock *hcrx = ccid3_hc_rx_sk(sk); struct dccp_rx_his...
b9039a2a8df974d7702564318722434bb276a995
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Replace scaled division operations
Problem Details: This replaces the remaining uses of usecs_div with scaled_div32, which internally uses 64bit division and produces a warning on overflow. Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz> Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index aa355d4cfc8a..bdd13de4f422 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -41,27 +41,6 @@ #include "lib/tfrc.h" #include "ccid3.h" -/* - * Reason for maths here is to avoid 32 bit overflow when a is big. - * With this we...
1a21e49a8d60f588c1276f765198b14d5688a778
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Finer-grained resolution of sending rates
Problem Details: This patch * resolves a bug where packets smaller than 32/64 bytes resulted in sending rates of 0 * supports all sending rates from 1/64 bytes/second up to 4Gbyte/second * simplifies the present overflow problems in calculations Current sending rate X and the cached value X_recv of the receiver-est...
```diff diff --git a/include/linux/tfrc.h b/include/linux/tfrc.h index 31a9b25276fe..8a8462b4a4dd 100644 --- a/include/linux/tfrc.h +++ b/include/linux/tfrc.h @@ -37,10 +37,14 @@ struct tfrc_rx_info { * @tfrctx_p: current loss event rate (5.4) * @tfrctx_rto: estimate of RTO, equals 4*RTT (4.3) * @tfrctx_ipi: i...
179ebc9f92da88e15ea86d7d27308c92712d8ee9
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Fix two bugs in sending rate computation
Problem Details: This fixes 1) a bug in the recomputation of the sending rate by the nofeedback timer when no feedback at all has so far been sent by the receiver: min_t was used instead of max_t, which is wrong (cf. RFC 3448, p. 10); 2) an error in the computation of larger initial windows: instead of m...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 92e893ee77c2..c54663f21fdd 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -193,7 +193,7 @@ static void ccid3_hc_tx_no_feedback_timer(unsigned long data) switch (hctx->ccid3hctx_state) { case TFRC_SSTATE_NO_FBACK: /* R...
ff58629824c068e2a75402b5b83f12af0b36d394
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Two optimisations for sending rate recomputation
Problem Details: This performs two optimisations for the recomputation of the sending rate. 1) Currently the target sending rate X_calc is recalculated whenever a) the nofeedback timer expires, or b) a feedback packet is received. In the (a) case, recomputing X_calc is redundant, since * the parameters p and...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index f1b745ee9cb6..92e893ee77c2 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -138,9 +138,6 @@ static void ccid3_hc_tx_update_x(struct sock *sk, struct timeval *now) const __u32 old_x = hctx->ccid3hctx_x; if (hctx->ccid3hc...
45393a66a2c30fc8ed86e6c79a63a3cd5231c69f
Analyze and fix the following issue in the Linux kernel code: [DCCP] ccid3: Check against too large p
Problem Details: This patch follows a suggestion by Ian McDonald and ensures that in the current code the value of p can not exceed 100%. Such a value is illegal and would consequently cause a bug condition in tfrc_calc_x(). The receiver case is also tested, and a warning message is added. Signed-off-by: Gerrit Renk...
```diff diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 66a27b9688ca..f1b745ee9cb6 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -444,9 +444,9 @@ static void ccid3_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb) /* Update loss event rate */ pinv = opt_recv->ccid3...
ed407717852895e04f9e088e09a4f27bb56712b7
Analyze and fix the following issue in the Linux kernel code: [NET]: Fix WAN routers kconfig dependency.
Problem Details: Currently WAN router drivers can be built in-kernel while the register/unregister_wan_device interfaces are built as modules. This causes: drivers/built-in.o: In function `cycx_init': cycx_main.c:(.init.text+0x5c4b): undefined reference to `register_wan_device' drivers/built-in.o: In function `cycx_ex...
```diff diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index d5ab9cf13257..21f76f51c95e 100644 --- a/drivers/net/wan/Kconfig +++ b/drivers/net/wan/Kconfig @@ -382,7 +382,7 @@ config SDLA # Wan router core. config WAN_ROUTER_DRIVERS - bool "WAN router drivers" + tristate "WAN router drivers" depend...
686106ff5ed2cbcd3fc12a22e53c880cf0943eff
Analyze and fix the following issue in the Linux kernel code: [CRYPTO] sha512: Fix sha384 block size
Problem Details: The SHA384 block size should be 128 bytes, not 96 bytes. This was spotted by Andrew Donofrio. Fortunately the block size isn't actually used anywhere so this typo has had no real impact. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
```diff diff --git a/crypto/sha512.c b/crypto/sha512.c index 2dfe7f170b48..15eab9db9be4 100644 --- a/crypto/sha512.c +++ b/crypto/sha512.c @@ -24,7 +24,7 @@ #define SHA384_DIGEST_SIZE 48 #define SHA512_DIGEST_SIZE 64 -#define SHA384_HMAC_BLOCK_SIZE 96 +#define SHA384_HMAC_BLOCK_SIZE 128 #define SHA512_HMAC_BLOCK_...
e45116b8d71ece9dbe41b114368ff7aebe3ae41a
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix typo in 'EXPERIMENTAL' in CC_STACKPROTECTOR on x86_64
Problem Details: Fix typo in 'EXPERIMENTAL' in config CC_STACKPROTECTOR in arch/x86_64/Kconfig. Signed-off-by: Brice Goglin <brice@myri.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig index 3ac581d17202..d4275537b25b 100644 --- a/arch/x86_64/Kconfig +++ b/arch/x86_64/Kconfig @@ -584,7 +584,7 @@ config SECCOMP If unsure, say Y. Only embedded should say N here. config CC_STACKPROTECTOR - bool "Enable -fstack-protector buffer overflo...
8993780a6e44fb4e7ed34e33458506a775356c6e
Analyze and fix the following issue in the Linux kernel code: Make SLES9 "get_kernel_version" work on the kernel binary again
Problem Details: As reported by Andy Whitcroft, at least the SLES9 initrd build process depends on getting the kernel version from the kernel binary. It does that by simply trawling the binary and looking for the signature of the "linux_banner" string (the string "Linux version " to be exact. Which is really broken in...
```diff diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c index dc3e580d1dca..92ea7743fe8f 100644 --- a/fs/proc/proc_misc.c +++ b/fs/proc/proc_misc.c @@ -47,6 +47,7 @@ #include <linux/vmalloc.h> #include <linux/crash_dump.h> #include <linux/pid_namespace.h> +#include <linux/compile.h> #include <asm/uaccess.h> ...
13348beee529cd1200deeac161e1b2de0705b495
Analyze and fix the following issue in the Linux kernel code: [PATCH] myri10ge: fix big_bytes in case of vlan frames
Problem Details: Fix sizing of big_bytes in the case of vlan frames. The 4 VLAN_HLEN bytes were omitted, leading to sizing the big buffer 4 bytes smaller than it should be. Due to how rx buffers are carved from pages, this was harmless for the common (9000, 1500) byte MTUs, but could lead to data corruption for some M...
```diff diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c index d38217a7eb11..a0d1dae39fd2 100644 --- a/drivers/net/myri10ge/myri10ge.c +++ b/drivers/net/myri10ge/myri10ge.c @@ -1696,11 +1696,11 @@ static int myri10ge_open(struct net_device *dev) * tell him the buffer is larger, because ...
1083cfe11285816fb2e2e36aad097f1c3b6db915
Analyze and fix the following issue in the Linux kernel code: [PATCH] ucc_geth: compilation error fixes
Problem Details: Fix compilation failures when building the ucc_geth driver with spinlock debugging. Signed-off-by: Scott Wood <scottwood@freescale.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
```diff diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 1f05511fa390..62d979b0f975 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c @@ -194,9 +194,9 @@ static void enqueue(struct list_head *node, struct list_head *lh) { unsigned long flags; - spin_lock_irqsave(ugeth_lock, flags);...
99eeb8dfb1ce3df744e2e0d00dd627d7a8199ef0
Analyze and fix the following issue in the Linux kernel code: AT91 MMC update for 2.6.19
Problem Details: The driver is usable on the newer SAM9 processors so replace all text references to AT91RM9200 with just AT91. The controller bug where all the words are byte-swapped is fixed on the AT91SAM9 processors. The byte-swapping work-around therefore only needs to be done if cpu_is_at91rm9200(). [Original p...
```diff diff --git a/drivers/mmc/at91_mci.c b/drivers/mmc/at91_mci.c index d500b6b21ea0..08a33c33f6ed 100644 --- a/drivers/mmc/at91_mci.c +++ b/drivers/mmc/at91_mci.c @@ -1,5 +1,5 @@ /* - * linux/drivers/mmc/at91_mci.c - ATMEL AT91RM9200 MCI Driver + * linux/drivers/mmc/at91_mci.c - ATMEL AT91 MCI Driver * * Co...
66a1e421b98edaa62c7d95cc53cb381efa3fb9bf
Analyze and fix the following issue in the Linux kernel code: [MTD] OneNAND: fix oob handling in recent oob patch
Problem Details: There are missing place in recent MTD oob patch http://git.infradead.org/?p=mtd-2.6.git;a=commitdiff;h=7014568bad55c20b7ee4f439d78c9e875912d51f Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
```diff diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index c48aa79ef5c9..63ca61b83bf5 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -871,8 +871,8 @@ static int onenand_read_oob(struct mtd_info *mtd, loff_t from, { BUG_ON(ops->mode ...
76ab40e465e7615e582b9244a1a967bf3f074061
Analyze and fix the following issue in the Linux kernel code: [MTD] Fix ssfdc blksize typo
Problem Details: I will not commit even trivial and obvious one-line fixes without building. I will not commit even trivial and obvious one-line fixes without building. I will not commit even trivial and obvious one-line fixes without building. I will not commit even trivial and obvious one-line fixes without building....
```diff diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index 60a3fba90ab8..a5f3d60047d4 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -445,7 +445,7 @@ static struct mtd_blktrans_ops ssfdcr_tr = { .name = "ssfdc", .major = SSFDCR_MAJOR, .part_bits = SSFDCR_PARTN_BITS, - .blksize = SECTOR_...
7b30d281b9c115890c75d11eaf06881261c256da
Analyze and fix the following issue in the Linux kernel code: mmc: fix "prev->state: 2 != TASK_RUNNING??" problem on SD/MMC card removal
Problem Details: Currently on SD/MMC card removal the system exhibits the following message (the platform is ARM Versatile): prev->state: 2 != TASK_RUNNING?? mmcqd/762[CPU#0]: BUG in __schedule at linux-2.6/kernel/sched.c:3826 (akpm: someone tried to fix this, but it's still wrong) Signed-off-by: Vitaly Wool...
```diff diff --git a/drivers/mmc/mmc_queue.c b/drivers/mmc/mmc_queue.c index a17423a4ed8f..3e35a43819fb 100644 --- a/drivers/mmc/mmc_queue.c +++ b/drivers/mmc/mmc_queue.c @@ -78,8 +78,10 @@ static int mmc_queue_thread(void *d) spin_unlock_irq(q->queue_lock); if (!req) { - if (kthread_should_stop()) + if (kt...
f3a8efa90b1aab16ead76ad7e22d9c5fc2045400
Analyze and fix the following issue in the Linux kernel code: AT91 MMC 5 : Minor cleanups
Problem Details: A number of small cleanups to the AT91RM9200 MMC driver: - fix warnings generated by pr_debug(). - prepend "AT91 MMC:" to printk() messages. Signed-off-by: Andrew Victor <andrew@sanpeople.com> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
```diff diff --git a/drivers/mmc/at91_mci.c b/drivers/mmc/at91_mci.c index 2f11d67d8d07..d500b6b21ea0 100644 --- a/drivers/mmc/at91_mci.c +++ b/drivers/mmc/at91_mci.c @@ -336,10 +336,10 @@ static void at91_mci_handle_transmitted(struct at91mci_host *host) static void at91_mci_enable(struct at91mci_host *host) { at9...
94f060bd0f78814f4daf8c7942bd710af52c7d6f
Analyze and fix the following issue in the Linux kernel code: drm: fix return value check
Problem Details: class_create() and class_device_create() return error code as a pointer on failure. These return values need to be checked by IS_ERR(). Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Dave Airlie <airlied@linux.ie>
```diff diff --git a/drivers/char/drm/drm_sysfs.c b/drivers/char/drm/drm_sysfs.c index ba4b8de83cf0..cc8e2ebe128c 100644 --- a/drivers/char/drm/drm_sysfs.c +++ b/drivers/char/drm/drm_sysfs.c @@ -45,8 +45,8 @@ struct class *drm_sysfs_create(struct module *owner, char *name) int err; class = class_create(owner, nam...
73c9ceab40b1269d6195e556773167c078ac8311
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Generic BUG for powerpc
Problem Details: This makes powerpc use the generic BUG machinery. The biggest reports the function name, since it is redundant with kallsyms, and not needed in general. There is an overall reduction of code, since module_32/64 duplicated several functions. Unfortunately there's no way to tell gcc that BUG won't ret...
```diff diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a35212b7346e..f81d9f6f19f6 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -99,6 +99,11 @@ config AUDIT_ARCH bool default y +config GENERIC_BUG + bool + default y + depends on BUG + config DEFAULT_UIMAGE bool help diff --g...
d10f73480b991da2aa1c000ed38eda3e4a987292
Analyze and fix the following issue in the Linux kernel code: [PPC] Fix compile failure do to introduction of PHY_POLL
Problem Details: PHY_POLL is defined in <linux/phy.h> include it in <linux/fsl_devices.h> so board code will have it defined. Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
```diff diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h index 3da29e2d524a..abb64c437f6f 100644 --- a/include/linux/fsl_devices.h +++ b/include/linux/fsl_devices.h @@ -19,6 +19,7 @@ #define _FSL_DEVICE_H_ #include <linux/types.h> +#include <linux/phy.h> /* * Some conventions on how we ha...
4383162c8f2fa75d916c4901b0d1ebcac7aeaf74
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Remove old dcr.S
Problem Details: When I renamed dcr.S to dcr_low.S (and added dcr.c) it looks like the old dcr.S file didn't properly get removed. This fixes it. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/sysdev/dcr.S b/arch/powerpc/sysdev/dcr.S deleted file mode 100644 index 2078f39e2f17..000000000000 --- a/arch/powerpc/sysdev/dcr.S +++ /dev/null @@ -1,39 +0,0 @@ -/* - * "Indirect" DCR access - * - * Copyright (c) 2004 Eugene Surovegin <ebs@ebshome.net> - * - * This program is free sof...
39f44be375d07a977ba68f900c87cea97cb05f4a
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix SPU coredump code for max_fdset removal
Problem Details: Commit bbea9f69668a3d0cf9feba15a724cd02896f8675 removed the max_fdset element of struct fdtable. It appears that checking max_fds is sufficient now. Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c index 26945c491f6b..725e19561159 100644 --- a/arch/powerpc/platforms/cell/spufs/coredump.c +++ b/arch/powerpc/platforms/cell/spufs/coredump.c @@ -147,7 +147,7 @@ static int spufs_arch_notes_size(void) stru...
dae4828d66ac6db353dee213c594257929a310cb
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix irq routing on some 32-bit PowerMacs
Problem Details: The changes to use pci_read_irq_line() broke interrupt parsing on some 32-bit powermacs (oops). The reason is a bit obscure. The code to parse interrupts happens earlier now, during pcibios_fixup() as the PCI bus is being probed. However, the current implementation pci_device_to_OF_node() for 32-bit ...
```diff diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c index ab5887bff02a..8336deafc624 100644 --- a/arch/powerpc/kernel/pci_32.c +++ b/arch/powerpc/kernel/pci_32.c @@ -736,25 +736,51 @@ scan_OF_pci_childs(struct device_node* node, pci_OF_scan_iterator filter, void* return NULL; } -static...
0204568a088fecd5478153504f9476ee2c46d5bf
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Support ibm,dynamic-reconfiguration-memory nodes
Problem Details: For PAPR partitions with large amounts of memory, the firmware has an alternative, more compact representation for the information about the memory in the partition and its NUMA associativity information. This adds the code to the kernel to parse this alternative representation. The other part of thi...
```diff diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c index c18dbe77fdc2..1fc732a552db 100644 --- a/arch/powerpc/kernel/prom.c +++ b/arch/powerpc/kernel/prom.c @@ -804,6 +804,56 @@ static unsigned long __init dt_mem_next_cell(int s, cell_t **cellp) return of_read_ulong(p, s); } +#ifdef CONFI...
2d911e9a4e74ddbd059f9dabea402a119ef22e3d
Analyze and fix the following issue in the Linux kernel code: [MIPS] Move die and die_if_kernel() from system.h to ptrace.h
Problem Details: This eleminates the need to include ptrace.h into system.h and fixes a harmless namespace conflict on the PC symbol in bpck.c. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/ptrace.h b/include/asm-mips/ptrace.h index 30bf555faeaa..8a1f2b6f04ac 100644 --- a/include/asm-mips/ptrace.h +++ b/include/asm-mips/ptrace.h @@ -82,6 +82,14 @@ struct pt_regs { extern asmlinkage void do_syscall_trace(struct pt_regs *regs, int entryexit); +extern NORET_TYPE voi...
86384d544157db23879064cde36061cdcafc6794
Analyze and fix the following issue in the Linux kernel code: [MIPS] Discard .exit.text at linktime.
Problem Details: This fixes fairly unobvious breakage of various drivers. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S index 79f0317d84ac..2f4508f55fca 100644 --- a/arch/mips/kernel/vmlinux.lds.S +++ b/arch/mips/kernel/vmlinux.lds.S @@ -109,9 +109,6 @@ SECTIONS .con_initcall.init : { *(.con_initcall.init) } __con_initcall_end = .; SECURITY_INI...
5b1d221e6292f9fcf9f12d6c9e94ee9470ee2a24
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix build of several IDE drivers by providing pci_get_legacy_ide_irq
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/pci.h b/include/asm-mips/pci.h index c4d68bebdca6..7f0f120ca07c 100644 --- a/include/asm-mips/pci.h +++ b/include/asm-mips/pci.h @@ -187,4 +187,10 @@ static inline void pcibios_add_platform_entries(struct pci_dev *dev) /* Do platform specific device initialization at pci_enable_de...
d7aef138f3c08c5bbab567bc9a84e43a88f50395
Analyze and fix the following issue in the Linux kernel code: i2c: Fix OMAP clock prescaler to match the comment
Problem Details: Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Tony Lindgren <tony@atomide.com>
```diff diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index dec04da0455c..bcd8367cede1 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -231,8 +231,8 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) * 13 2 1 * 19.2 2 1 */ - if (fclk_rat...
3bacb36db01c7541ffea21d4ff39219e8b211a5c
Analyze and fix the following issue in the Linux kernel code: i2c: Fix return value check in i2c-dev
Problem Details: device_create() returns error code as pointer on failures. This patch checks the return value of device_create() by using IS_ERR(). Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Jean Delvare <khali@linux-fr.org>
```diff diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index cf9381eae8da..909428af2b7e 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -416,8 +416,8 @@ static int i2cdev_attach_adapter(struct i2c_adapter *adap) i2c_dev->dev = device_create(i2c_dev_class, &adap->dev, MKDEV(I2C_...
763d9c046a2e511ec090a8986d3f85edf7448e7e
Analyze and fix the following issue in the Linux kernel code: i2c: fix broken ds1337 initialization
Problem Details: On a custom board with ds1337 RTC I found that upgrade from 2.6.15 to 2.6.18 broke RTC support. The main problem are changes to ds1337_init_client(). When a ds1337 recognizes a problem (e.g. power or clock failure) bit 7 in status register is set. This has to be reset by writing 0 to status register. ...
```diff diff --git a/drivers/i2c/chips/ds1337.c b/drivers/i2c/chips/ds1337.c index 93d483b8b770..ec17d6b684a2 100644 --- a/drivers/i2c/chips/ds1337.c +++ b/drivers/i2c/chips/ds1337.c @@ -347,13 +347,19 @@ static void ds1337_init_client(struct i2c_client *client) if ((status & 0x80) || (control & 0x80)) { /* RTC ...
ad04d5c3879dcf79ba0fa1826eab991f7b7a2de8
Analyze and fix the following issue in the Linux kernel code: i2c: Cleanups to the i2c-nforce2 bus driver
Problem Details: Summary of changes: - fixes: o legacy I/O region size is 64 bytes, not 8 bytes - general cleanup: o removed code for the unsupported I2C block data, block data, proc call and block proc call transfer modes o removed detail warnings about unsupported modes that are covered in a gene...
```diff diff --git a/Documentation/i2c/busses/i2c-nforce2 b/Documentation/i2c/busses/i2c-nforce2 index 5465ed0f4379..7f61fbc03f7f 100644 --- a/Documentation/i2c/busses/i2c-nforce2 +++ b/Documentation/i2c/busses/i2c-nforce2 @@ -14,7 +14,7 @@ Datasheet: not publicly available, but seems to be similar to the A...
26f95c4ae2b1fd1b03531b3d662fc21beedce955
Analyze and fix the following issue in the Linux kernel code: i2c: Fix documentation typos
Problem Details: Fix typos in i2c bus drivers documentation. Signed-off-by: Jean Delvare <khali@linux-fr.org>
```diff diff --git a/Documentation/i2c/busses/i2c-amd8111 b/Documentation/i2c/busses/i2c-amd8111 index db294ee7455a..460dd6635fd2 100644 --- a/Documentation/i2c/busses/i2c-amd8111 +++ b/Documentation/i2c/busses/i2c-amd8111 @@ -5,7 +5,7 @@ Supported adapters: Datasheets: AMD datasheet not yet available, but almost ...
f5f1a24a2caa299bb7d294aee92d7dd3410d9ed7
Analyze and fix the following issue in the Linux kernel code: [PATCH] clocksource: small cleanup
Problem Details: Mostly changing alignment. Just some general cleanup. [akpm@osdl.org: build fix] Signed-off-by: Daniel Walker <dwalker@mvista.com> Acked-by: John Stultz <johnstul@us.ibm.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-o...
```diff diff --git a/drivers/clocksource/acpi_pm.c b/drivers/clocksource/acpi_pm.c index 8ab61ef97b4c..b6bcdbbf57b3 100644 --- a/drivers/clocksource/acpi_pm.c +++ b/drivers/clocksource/acpi_pm.c @@ -77,11 +77,11 @@ static struct clocksource clocksource_acpi_pm = { #ifdef CONFIG_PCI -static int acpi_pm_good; +stati...
4c36a5dec25fb344ad76b11860da3a8b50bd1248
Analyze and fix the following issue in the Linux kernel code: [PATCH] round_jiffies infrastructure
Problem Details: Introduce a round_jiffies() function as well as a round_jiffies_relative() function. These functions round a jiffies value to the next whole second. The primary purpose of this rounding is to cause all "we don't care exactly when" timers to happen at the same jiffy. This avoids multiple timers firing...
```diff diff --git a/include/linux/timer.h b/include/linux/timer.h index c982304dbafd..eeef6643d4c6 100644 --- a/include/linux/timer.h +++ b/include/linux/timer.h @@ -98,4 +98,10 @@ extern void run_local_timers(void); struct hrtimer; extern int it_real_fn(struct hrtimer *); +unsigned long __round_jiffies(unsigned l...
5466b456ed6748e0bfe02831e570004d4c04c1d7
Analyze and fix the following issue in the Linux kernel code: [PATCH] fdtable: Implement new pagesize-based fdtable allocator
Problem Details: This patch provides an improved fdtable allocation scheme, useful for expanding fdtable file descriptor entries. The main focus is on the fdarray, as its memory usage grows 128 times faster than that of an fdset. The allocation algorithm sizes the fdarray in such a way that its memory usage increases...
```diff diff --git a/fs/file.c b/fs/file.c index 17e6a55521e2..857fa49e984c 100644 --- a/fs/file.c +++ b/fs/file.c @@ -32,46 +32,28 @@ struct fdtable_defer { */ static DEFINE_PER_CPU(struct fdtable_defer, fdtable_defer_list); - -/* - * Allocate an fd array, using kmalloc or vmalloc. - * Note: the array isn't clear...
8459d86aff04fa53c2ab6a6b9f355b3063cc8014
Analyze and fix the following issue in the Linux kernel code: [PATCH] dio: only call aio_complete() after returning -EIOCBQUEUED
Problem Details: The only time it is safe to call aio_complete() is when the ->ki_retry function returns -EIOCBQUEUED to the AIO core. direct_io_worker() has historically done this by relying on its caller to translate positive return codes into -EIOCBQUEUED for the aio case. It did this by trying to keep conditional...
```diff diff --git a/fs/direct-io.c b/fs/direct-io.c index f11f05dc9e61..71f4aeac7632 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -226,6 +226,15 @@ static int dio_complete(struct dio *dio, loff_t offset, int ret) { ssize_t transferred = 0; + /* + * AIO submission can race with bio completion to get here w...
6d544bb4d9019c3a0d7ee4af1e4bbbd61a6e16dc
Analyze and fix the following issue in the Linux kernel code: [PATCH] dio: centralize completion in dio_complete()
Problem Details: There have been a lot of bugs recently due to the way direct_io_worker() tries to decide how to finish direct IO operations. In the worst examples it has failed to call aio_complete() at all (hang) or called it too many times (oops). This set of patches cleans up the completion phase with the goal of...
```diff diff --git a/fs/direct-io.c b/fs/direct-io.c index 45d34d807391..b57b671e1106 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -210,19 +210,46 @@ static struct page *dio_get_page(struct dio *dio) return dio->pages[dio->head++]; } -/* - * Called when all DIO BIO I/O has been completed - let the filesyste...
1757128438d41670ded8bc3bc735325cc07dc8f9
Analyze and fix the following issue in the Linux kernel code: [PATCH] md: assorted md and raid1 one-liners
Problem Details: Fix few bugs that meant that: - superblocks weren't alway written at exactly the right time (this could show up if the array was not written to - writting to the array causes lots of superblock updates and so hides these errors). - restarting device recovery after a clean shutdown (version...
```diff diff --git a/drivers/md/md.c b/drivers/md/md.c index 763ecab34813..21e2a7b08841 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -3724,6 +3724,7 @@ static int add_new_disk(mddev_t * mddev, mdu_disk_info_t *info) if (err) export_rdev(rdev); + md_update_sb(mddev, 1); set_bit(MD_RECOVERY_NEEDED, ...
b875e531fc82db592d6093594593d5cafde0a1cd
Analyze and fix the following issue in the Linux kernel code: [PATCH] md: fix innocuous bug in raid6 stripe_to_pdidx
Problem Details: stripe_to_pdidx finds the index of the parity disk for a given stripe. It assumes raid5 in that it uses "disks-1" to determine the number of data disks. This is incorrect for raid6 but fortunately the two usages cancel each other out. The only way that 'data_disks' affects the calculation of pd_idx ...
```diff diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 2e676e33744c..d855f9f59b02 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -823,7 +823,8 @@ static sector_t raid5_compute_sector(sector_t r_sector, unsigned int raid_disks, static sector_t compute_blocknr(struct stripe_head *sh, int i) { ...
46031f9a38a9773021f1872abc713d62467ac22e
Analyze and fix the following issue in the Linux kernel code: [PATCH] md: allow reads that have bypassed the cache to be retried on failure
Problem Details: If a bypass-the-cache read fails, we simply try again through the cache. If it fails again it will trigger normal recovery precedures. update 1: From: NeilBrown <neilb@suse.de> 1/ chunk_aligned_read and retry_aligned_read assume that data_disks == raid_disks - 1 which is not true for raid...
```diff diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 269b7771a30b..2ac2e56a1a40 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -134,6 +134,8 @@ static void __release_stripe(raid5_conf_t *conf, struct stripe_head *sh) if (!test_bit(STRIPE_EXPANDING, &sh->state)) { list_add_tail(&sh->l...
ee2f344b33b507af23610c8fdfdde38d7c10fb33
Analyze and fix the following issue in the Linux kernel code: [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2
Problem Details: The ESB2 appears to emit spurious DMA interrupts when configured for native mode and handling ATAPI devices. Stratus were able to pin this bug down and produce a patch. This is a rework which applies the fixup only to the ESB2 (for now). We can apply it to other chips later if the same problem is fo...
```diff diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 88214943d00a..5969cec58dc1 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -687,8 +687,15 @@ static void ide_dump_status_no_sense(ide_drive_t *drive, const char *msg, u8 sta static int cdrom_decode_status(ide_drive_t *drive, int goo...
783609c6cb4eaa23f2ac5c968a44483584ec133f
Analyze and fix the following issue in the Linux kernel code: [PATCH] sched: decrease number of load balances
Problem Details: Currently at a particular domain, each cpu in the sched group will do a load balance at the frequency of balance_interval. More the cores and threads, more the cpus will be in each sched group at SMP and NUMA domain. And we endup spending quite a bit of time doing load balancing in those domains. Fix...
```diff diff --git a/include/linux/sched.h b/include/linux/sched.h index ea92e5c89089..72d6927d29ed 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -707,6 +707,7 @@ struct sched_domain { unsigned long lb_hot_gained[MAX_IDLE_TYPES]; unsigned long lb_nobusyg[MAX_IDLE_TYPES]; unsigned long lb_nobus...
b18ec80396834497933d77b81ec0918519f4e2a7
Analyze and fix the following issue in the Linux kernel code: [PATCH] sched: improve migration accuracy
Problem Details: Co-opt rq->timestamp_last_tick to maintain a cache_hot_time evaluation reference timestamp at both tick and sched times to prevent said reference, formerly rq->timestamp_last_tick, from being behind task->last_ran at evaluation time, and to move said reference closer to current time on the remote proce...
```diff diff --git a/kernel/sched.c b/kernel/sched.c index 2b2b780939c9..15ce772a471a 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -225,7 +225,8 @@ struct rq { unsigned long nr_uninterruptible; unsigned long expired_timestamp; - unsigned long long timestamp_last_tick; + /* Cached timestamp set by update_cp...
08c183f31bdbb709f177f6d3110d5f288ea33933
Analyze and fix the following issue in the Linux kernel code: [PATCH] sched: add option to serialize load balancing
Problem Details: Large sched domains can be very expensive to scan. Add an option SD_SERIALIZE to the sched domain flags. If that flag is set then we make sure that no other such domain is being balanced. [akpm@osdl.org: build fix] Signed-off-by: Christoph Lameter <clameter@sgi.com> Cc: Peter Williams <pwil3058@bigp...
```diff diff --git a/include/asm-i386/topology.h b/include/asm-i386/topology.h index 978d09596130..ac58580ad664 100644 --- a/include/asm-i386/topology.h +++ b/include/asm-i386/topology.h @@ -89,6 +89,7 @@ static inline int node_to_first_cpu(int node) .flags = SD_LOAD_BALANCE \ | SD_BALANCE_EXEC \ | SD_BAL...
d2f7bf13461e8ead863126ee1e8ba92105959ecc
Analyze and fix the following issue in the Linux kernel code: [PATCH] getdelays: various fixes
Problem Details: - Various cleanups - Report errors to stderr, not stdout - A printf was missing a \n and was hiding from me. Cc: Jay Lan <jlan@sgi.com> Cc: Shailabh Nagar <nagar@watson.ibm.com> Cc: Balbir Singh <balbir@in.ibm.com> Cc: Chris Sturtivant <csturtiv@sgi.com> Cc: Tony Ernst <tee@sgi.com> Cc: Guillaume Th...
```diff diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c index bf2b0e2f87e1..93dd04f86a27 100644 --- a/Documentation/accounting/getdelays.c +++ b/Documentation/accounting/getdelays.c @@ -7,6 +7,8 @@ * Copyright (C) Balbir Singh, IBM Corp. 2006 * Copyright (c) Jay Lan, SGI. 20...
f2f1f8a3b86ccc5e998dc70a3ba35af199fdbc58
Analyze and fix the following issue in the Linux kernel code: [PATCH] cleanup taskstats.h
Problem Details: Fix weird whitespace mangling in taskstats.h Cc: Jay Lan <jlan@sgi.com> Cc: Shailabh Nagar <nagar@watson.ibm.com> Cc: Balbir Singh <balbir@in.ibm.com> Cc: Chris Sturtivant <csturtiv@sgi.com> Cc: Tony Ernst <tee@sgi.com> Cc: Guillaume Thouvenin <guillaume.thouvenin@bull.net> Cc: David Wright <daw@sgi.c...
```diff diff --git a/include/linux/taskstats.h b/include/linux/taskstats.h index 45248806ae9c..15c64037be1b 100644 --- a/include/linux/taskstats.h +++ b/include/linux/taskstats.h @@ -115,31 +115,31 @@ struct taskstats { __u64 ac_majflt; /* Major Page Fault Count */ /* Basic Accounting Fields end */ - /* Extende...
6f88cc2e9c29c181557b477ee396375906acbc90
Analyze and fix the following issue in the Linux kernel code: [PATCH] io-accounting-read-accounting cifs fix
Problem Details: CIFS implements ->readpages and doesn't use read_cache_pages(). So wire the read IO accounting up within CIFS. Cc: Jay Lan <jlan@sgi.com> Cc: Shailabh Nagar <nagar@watson.ibm.com> Cc: Balbir Singh <balbir@in.ibm.com> Cc: Chris Sturtivant <csturtiv@sgi.com> Cc: Tony Ernst <tee@sgi.com> Cc: Guillaume T...
```diff diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 1aa95a50cac2..0f05cab5d24a 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -29,6 +29,7 @@ #include <linux/pagevec.h> #include <linux/smp_lock.h> #include <linux/writeback.h> +#include <linux/task_io_accounting_ops.h> #include <linux/delay.h> #include <...
8bde37f08fe3340435f4320b5a092eeb55acebfd
Analyze and fix the following issue in the Linux kernel code: [PATCH] io-accounting-read-accounting nfs fix
Problem Details: nfs's ->readpages uses read_cache_pages(). Wire it up there. [wfg@mail.ustc.edu.cn: account only successful nfs/fuse reads] Cc: Jay Lan <jlan@sgi.com> Cc: Shailabh Nagar <nagar@watson.ibm.com> Cc: Balbir Singh <balbir@in.ibm.com> Cc: Chris Sturtivant <csturtiv@sgi.com> Cc: Tony Ernst <tee@sgi.com> Cc...
```diff diff --git a/mm/readahead.c b/mm/readahead.c index c0df5ed05f62..0f539e8e827a 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -13,6 +13,7 @@ #include <linux/module.h> #include <linux/blkdev.h> #include <linux/backing-dev.h> +#include <linux/task_io_accounting_ops.h> #include <linux/pagevec.h> void de...
47694bb86af3648d4ec34c7afd46653cefc9b359
Analyze and fix the following issue in the Linux kernel code: [PATCH] pdc202xx_new: fix PLL/timing issues
Problem Details: Fix the CRC errors in the higher UltraDMA modes with the Promise PDC20268 and newer chips that always occur on non-x86 machines and when there are more than 2 adapters on x86 machines. Fix the overclocking issue for PDC20269 and newer chips that occurs when an UltraDMA/133 capable drive is connected. ...
```diff diff --git a/drivers/ide/pci/pdc202xx_new.c b/drivers/ide/pci/pdc202xx_new.c index 3ca581063f72..7cb48576e479 100644 --- a/drivers/ide/pci/pdc202xx_new.c +++ b/drivers/ide/pci/pdc202xx_new.c @@ -39,6 +39,14 @@ #define PDC202_DEBUG_CABLE 0 +#undef DEBUG + +#ifdef DEBUG +#define DBG(fmt, args...) printk("%s:...