id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
58f64d83c37f5073a01573d27043c9c0ccc764f1
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix noise in futex.h
Problem Details: There are some kernel-only bits in the middle of <linux/futex.h> which should be removed in what we export to userspace. Signed-off-by: David Woodhouse <dwmw2@infradead.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/linux/Kbuild b/include/linux/Kbuild index e618b25b5add..a1b04d8a1d01 100644 --- a/include/linux/Kbuild +++ b/include/linux/Kbuild @@ -61,7 +61,6 @@ header-y += fd.h header-y += fdreg.h header-y += fib_rules.h header-y += fuse.h -header-y += futex.h header-y += genetlink.h header-y += g...
1d5636cc078d3750b7f590a20f748aeaa26e2daf
Analyze and fix the following issue in the Linux kernel code: [PATCH] IPMI: misc fixes
Problem Details: Fix various problems pointed out by Andrew Morton and others: * platform_device_unregister checks for NULL, no need to check here. * Formatting fixes. * Remove big macro and convert to a function. * Use strcmp instead of defining a broken case-insensitive comparison, and make the output par...
```diff diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index bfcc6a030a16..4e4691a53890 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -2142,8 +2142,7 @@ cleanup_bmc_device(struct kref *ref) bmc = container_of(ref, struct bmc_devic...
b3fc9941fbc6efe5cb77728adb0fb12be363e73e
Analyze and fix the following issue in the Linux kernel code: [PATCH] CodingStyle updates
Problem Details: Add some kernel coding style comments, mostly pulled from emails by Andrew Morton, Jesper Juhl, and Randy Dunlap. - add paragraph on switch/case indentation (with fixes) - add paragraph on multiple-assignments - add more on Braces - add section on Spaces; add typeof, alignof, & __attribute__ with size...
```diff diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 29c18966b050..0ad6dcb5d45f 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle @@ -35,12 +35,37 @@ In short, 8-char indents make things easier to read, and have the added benefit of warning you when you're nesting your ...
fd43fe19b830d6cd0eba08a6c6a5f71a6bd9c1b0
Analyze and fix the following issue in the Linux kernel code: [PATCH] xtensa: fix irq and misc fixes
Problem Details: Update the architecture specific interrupt handling code for Xtensa to support the new API. Use generic BUG macros in bug.h, and some minor fixes. Signed-off-by: Chris Zankel <chris@zankel.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/xtensa/kernel/irq.c b/arch/xtensa/kernel/irq.c index 1cf744ee0959..c9ea73b7031b 100644 --- a/arch/xtensa/kernel/irq.c +++ b/arch/xtensa/kernel/irq.c @@ -4,7 +4,7 @@ * Xtensa built-in interrupt controller and some generic functions copied * from i386. * - * Copyright (C) 2002 - 2005 Tensi...
5fcf7bb73f66cc1c4ad90788b0f367c4d6852b75
Analyze and fix the following issue in the Linux kernel code: [PATCH] read_zero_pagealigned() locking fix
Problem Details: Ramiro Voicu hits the BUG_ON(!pte_none(*pte)) in zeromap_pte_range: kernel bugzilla 7645. Right: read_zero_pagealigned uses down_read of mmap_sem, but another thread's racing read of /dev/zero, or a normal fault, can easily set that pte again, in between zap_page_range and zeromap_page_range getting t...
```diff diff --git a/drivers/char/mem.c b/drivers/char/mem.c index 089020e0ee5a..4f1813e04754 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -646,7 +646,8 @@ static inline size_t read_zero_pagealigned(char __user * buf, size_t size) count = size; zap_page_range(vma, addr, count, NULL); - z...
15964864c051b31df7d2f9101fe8cc47854a0ab8
Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: fix-rR-is-now-default
Problem Details: `make -d help | grep Makefile` shows patterns, where make tries to rebuild included and top makefiles. While `make -rR is now default' commit should fix this, actually, it was just a little janitorial. This fix is aimed to complete cancelling implicit rules. Cc: Sam Ravnborg <sam@ravnborg.org> Signe...
```diff diff --git a/Makefile b/Makefile index aef96259051f..73e825b39a08 100644 --- a/Makefile +++ b/Makefile @@ -10,8 +10,11 @@ NAME=Avast! A bilge rat! # Comments in this file are targeted only to the developer, do not # expect to learn how to build the kernel reading this file. -# Do not print "Entering directo...
db9a758c3895ae99d647143d1f043938eb68521e
Analyze and fix the following issue in the Linux kernel code: [PATCH] workstruct: fix ieee80211-softmac compile problem
Problem Details: Fix ieee80211-softmac compile problem where it's using schedule_work() on a delayed_work struct. Signed-off-by: David Howells <dhowells@redhat.com> Cc: "John W. Linville" <linville@tuxdriver.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/net/ieee80211/softmac/ieee80211softmac_assoc.c b/net/ieee80211/softmac/ieee80211softmac_assoc.c index eec1a1dd91da..e3f37fdda65f 100644 --- a/net/ieee80211/softmac/ieee80211softmac_assoc.c +++ b/net/ieee80211/softmac/ieee80211softmac_assoc.c @@ -438,7 +438,7 @@ ieee80211softmac_try_reassoc(struct i...
1de1bf06330920802d3b7646a088965bdd918356
Analyze and fix the following issue in the Linux kernel code: V4L/DVB 4949b: Fix container_of pointer retreival
Problem Details: Signed-off-by: Thierry MERLE <thierry.merle@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index 9ff93e7346ae..797b97baf9ed 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -2218,7 +2218,7 @@ int usbvision_power_on(struct usb_u...
db06e2a93ff73270e0053c37c88073094e77913d
Analyze and fix the following issue in the Linux kernel code: [MTD] Fix SSFDC build for variable blocksize.
Problem Details: Signed-off-by: David Woodhouse <dwmw2@infradead.org>
```diff diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index e834cc16c9f9..60a3fba90ab8 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -311,7 +311,6 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) ssfdc->mbd.mtd = mtd; ssfdc->mbd.devnum = -1; - ssfdc->mbd.bl...
67952e8cb111c5b2f9e675dba1bbde4876f9fcf3
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4949a): Fix INIT_WORK
Problem Details: INIT_WORK syntax changed on kernel 2.6.19. Fixing it on usbvision and cx88-input. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-input.c b/drivers/media/video/cx88/cx88-input.c index c6d412b1f218..8136673fe9e8 100644 --- a/drivers/media/video/cx88/cx88-input.c +++ b/drivers/media/video/cx88/cx88-input.c @@ -158,7 +158,7 @@ static void cx88_ir_work(struct work_struct *work) static void cx88_ir_s...
c876a3468d0f136710af81595177889953d1ff71
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4953): Usbvision minor fixes
Problem Details: - fix debug outputs - fix returned parameters on VIDIOC_G_FMT, VIDIOC_S_FMT and VIDIOC_TRY_FMT and mmap size setting Signed-off-by: Thierry MERLE <thierry.merle@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index e660a91d8251..9163b60c7f91 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -87,6 +87,7 @@ MODULE_PARM_DESC(SwitchSVideoInput, " S...
a1ed551cdb4f29157466340760fde68bcda704a9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4941): Remove LINUX_VERSION_CODE and fix identations
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index cf5d4771312d..e660a91d8251 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -47,8 +47,8 @@ #include <media/tuner.h> #include <me...
957883d0b56a649389d0652a727324dd8ba2e83c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4932): Usbvision_v4l2: fix norm setting problems
Problem Details: Patch contents: - fix i2c command broadcast (caused problems for SECAM norm setting) - default input selection at driver open Signed-off-by: Thierry MERLE <thierry.merle@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index eb8f4ca3a15f..f87bd0afbbfa 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -2570,58 +2570,61 @@ static int usbvision_unrequest_in...
40bad67840aa6856cb39a431510a57d940017898
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4930): Usbvision_v4l2 : mmap corrected to get all frames
Problem Details: - private ioctls UVIOCSREG/UVIOCGREG translated to the VIDIOC_INT_G_REGISTER/VIDIOC_INT_S_REGISTER - lost frame bug corrected (mmap rework) - reset scratch buffer is no buffer is queued (prevents useless scratch overflow management) Signed-off-by: Thierry MERLE <thierry.merle@free.fr> Signed-off-by:...
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index 3833f3fbbdf0..eb8f4ca3a15f 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -364,8 +364,6 @@ #endif #include "usbvision.h" -#i...
c8400c700723936d9333c977e51fa77062d26dd4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4924): Fix some bugs on usbvision due to the merge into one module
Problem Details: Found the bug that prevented the driver from loading : a module param conflict between usbvision-i2c and usbvision-core (debug parameter). - correct the module param "debug" conflics in usbvision-i2c.c and usbvision-core.c - add some debug printouts in usbvision-core.c VDIOC_QBUF/VIDIOC_DQBUF - usbvisi...
```diff diff --git a/drivers/media/video/usbvision/usbvision-core.c b/drivers/media/video/usbvision/usbvision-core.c index a23fcd15a1d0..da422e7793ad 100644 --- a/drivers/media/video/usbvision/usbvision-core.c +++ b/drivers/media/video/usbvision/usbvision-core.c @@ -4240,6 +4240,7 @@ static int usbvision_v4l2_do_ioctl(...
2a893dea0f186efc2eb4bcdaee145b20c87d239d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4921): Budget-av, budget-ci: Fix MC1 register programming
Problem Details: Remove bogus read during MC1 programming. A '1' bit could never be cleared using the old code. Use MASK_xx macros. Signed-off-by: Hartmut Birr <e9hack@gmail.com> Signed-off-by: Oliver Endriss <o.endriss@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c index 4d1954072bb4..89ab4b59155c 100644 --- a/drivers/media/dvb/ttpci/budget-av.c +++ b/drivers/media/dvb/ttpci/budget-av.c @@ -360,7 +360,7 @@ static int ciintf_init(struct budget_av *budget_av) saa7146_setgpio(saa, 3, SAA...
4207700d9b238c2db1bcba47a23251c6024687b6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4917): Saa7146: Convert SAA7146_IER_{DIS,EN}ABLE macros to inline functions
Problem Details: Convert SAA7146_IER_{DIS,EN}ABLE macros to inline functions. Fixes a problem with macro expansion (reported by C.Y.M). Signed-off-by: Oliver Endriss <o.endriss@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/include/media/saa7146.h b/include/media/saa7146.h index afa5ff6469b3..796bcf151a3a 100644 --- a/include/media/saa7146.h +++ b/include/media/saa7146.h @@ -42,20 +42,6 @@ extern unsigned int saa7146_debug; #define DEB_INT(x) if (0!=(DEBUG_VARIABLE&0x20)) { DEBUG_PROLOG; printk x; } /* interrupt deb...
122b5dbea6fa3727fc99fbdc2cf5e4d9b8a5bb00
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4913): Fix broken TUNER_LG_NTSC_TAPE radio support
Problem Details: The TUNER_LG_NTSC_TAPE is identical in all respects to the TUNER_PHILIPS_FM1236_MK3. So use the params struct for the Philips tuner. Also add this LG_NTSC_TAPE tuner to the switches where radio specific parameters are set so it behaves like a TUNER_PHILIPS_FM1236_MK3. This change fixes the radio suppor...
```diff diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c index 63db4e97ae6c..fcf8693e4d50 100644 --- a/drivers/media/video/tuner-simple.c +++ b/drivers/media/video/tuner-simple.c @@ -108,6 +108,7 @@ static int tuner_stereo(struct i2c_client *c) case TUNER_PHILIPS_FM1216ME_MK3: ...
bf5dbed6b499787809c78710b209efc76939592b
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4901): Improve debug msgs to show fourcc and buffer length on video_ioctl2
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c index 1be712757e4d..6a0e8ca72948 100644 --- a/drivers/media/video/videodev.c +++ b/drivers/media/video/videodev.c @@ -342,7 +342,7 @@ static void dbgbuf(unsigned int cmd, struct video_device *vfd, dbgarg (cmd, "%02ld:%02d:%02d.%08l...
4be3276a66c09e68a539253ce660913bb2585984
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4896): Dvb-usb: fix vendor ID ordering
Problem Details: The vendor IDs in this file were all in alphabetical order except for this one. Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h index 6a55ea22216f..299382dcb81d 100644 --- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h +++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h @@ -32,8 +32,8 @@ #define USB_VID_PINNACLE 0x2304 #define USB_VID_VISIONPLUS 0x...
a08cc44ec12e0a994ee85ba365315dbee982d6a7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4894): Mxb: fix to load the proper i2c modules
Problem Details: Change order of module requests, so that tuner module is loaded at the end, because the tuner module probes multiple i2c addresses and might grab an i2c address that is not a tuner but something else. Signed-off-by: Michael Hunold <hunold@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infr...
```diff diff --git a/drivers/media/video/mxb.c b/drivers/media/video/mxb.c index b0aea4002d11..152cc6b3e152 100644 --- a/drivers/media/video/mxb.c +++ b/drivers/media/video/mxb.c @@ -160,10 +160,6 @@ static int mxb_probe(struct saa7146_dev* dev) printk("mxb: saa7111 i2c module not available.\n"); return -ENODEV; ...
036171e75ef866b4fd8650c5b890359482ba2a4c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Dvb-budget ci fix
Problem Details: drivers/media/dvb/ttpci/budget-ci.c:220:6: warning: "LINUX_VERSION_CODE" is not defined drivers/media/dvb/ttpci/budget-ci.c:220:28: warning: "KERNEL_VERSION" is not defined drivers/media/dvb/ttpci/budget-ci.c:220:42: error: missing binary operator before token "(" Signed-off-by: Andrew Morton <akpm@os...
```diff diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c index 8f71124099b0..f793a2741e2d 100644 --- a/drivers/media/dvb/ttpci/budget-ci.c +++ b/drivers/media/dvb/ttpci/budget-ci.c @@ -217,11 +217,7 @@ static int msp430_ir_init(struct budget_ci *budget_ci) input_dev->id.vendor =...
0b6389ff16d57d8706bb516bde0211207aae73af
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4891): Lgdt330x: fix broken whitespace
Problem Details: Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/lgdt330x.c b/drivers/media/dvb/frontends/lgdt330x.c index 75be6e4aa176..68aad0f6519f 100644 --- a/drivers/media/dvb/frontends/lgdt330x.c +++ b/drivers/media/dvb/frontends/lgdt330x.c @@ -304,10 +304,10 @@ static int lgdt330x_set_parameters(struct dvb_frontend* fe, stati...
1b5b32bf877d6f77d7eb6580d43623cc113a3b60
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4890): Lgdt330x: fix signal / lock status detection bug
Problem Details: In some cases when using VSB, the AGC status register has been known to falsely report "no signal" when in fact there is a carrier lock. The datasheet labels these status flags as QAM only, yet the lgdt330x module is using these flags for both QAM and VSB. This patch allows for the carrier recovery lo...
```diff diff --git a/drivers/media/dvb/frontends/lgdt330x.c b/drivers/media/dvb/frontends/lgdt330x.c index db3ef58dafba..75be6e4aa176 100644 --- a/drivers/media/dvb/frontends/lgdt330x.c +++ b/drivers/media/dvb/frontends/lgdt330x.c @@ -437,9 +437,6 @@ static int lgdt3302_read_status(struct dvb_frontend* fe, fe_status_t*...
9abec6189aa8b6659222544bf893158fc96e8822
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4883): Fix TD1316 tuner for DVBC
Problem Details: If your device is using the philips tda1316 tuner, i think there is a problem in setting the correct Band. 162 MHz and above should be band 2 (Mid-Band). But in dvbc_philips_tdm1316l_tuner_set_params band 1 is set for frequencies below 200 MHz. Signed-off-by: Thomas Kaiser <linux-dvb@kaiser-linux.li> ...
```diff diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c index 83a1c5f44a0a..a68f5bf01259 100644 --- a/drivers/media/dvb/ttpci/budget-ci.c +++ b/drivers/media/dvb/ttpci/budget-ci.c @@ -946,7 +946,7 @@ static int dvbc_philips_tdm1316l_tuner_set_params(struct dvb_frontend *fe, struc ...
b5471a27b48801507c5bd0eadd83730230515016
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4881): budget-ci IR: add IR debugging information
Problem Details: This adds a ir_debug parameter which is useful in tracking down IR decoding problems. Based on Darren Salt's dvb-ir patchset. Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk> Signed-off-by: David Hardeman <david@hardeman.nu> Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net> Signed...
```diff diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c index 76d3b6694bce..2a3707c87942 100644 --- a/drivers/media/dvb/ttpci/budget-ci.c +++ b/drivers/media/dvb/ttpci/budget-ci.c @@ -92,6 +92,10 @@ static int rc5_device = -1; module_param(rc5_device, int, 0644); MODULE_PARM_DES...
444dadc4391b978b43a778a5a56dfaed1c4ddc61
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4871): Fix i2c dependencies of VIDEO_TVEEPROM and VIDEO_TUNER
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index 9f7e1fe8c97e..87410dbd3df4 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -67,6 +67,7 @@ source "drivers/media/common/Kconfig" config VIDEO_TUNER tristate + depends on I2C config VIDEO_BUF tristate @@ -82,6 +83,7 @@ co...
8949f1a2424a38a4080a2a3561a2698f215a7c4a
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4864): TDA826x I2C read with 2 messages
Problem Details: Added a dump I2C message to the TDA826x-driver to fix I2C read for identification with ttusb2-driver. Signed-off-by: Patrick Boettcher <pb@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/tda826x.c b/drivers/media/dvb/frontends/tda826x.c index 4f01d7b47cd5..79f971dc52b6 100644 --- a/drivers/media/dvb/frontends/tda826x.c +++ b/drivers/media/dvb/frontends/tda826x.c @@ -132,18 +132,21 @@ struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, ...
499c18698990463b84c23ddc98104517fe759ee8
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4862): Fixes uninitialized variables passed to VIDIOC_G_FBUF.
Problem Details: Signed-off-by: Andrea A Odetti <audetto@tiscali.it> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/v4l1-compat.c b/drivers/media/video/v4l1-compat.c index 701856e6adbf..8a13e595304e 100644 --- a/drivers/media/video/v4l1-compat.c +++ b/drivers/media/video/v4l1-compat.c @@ -350,6 +350,7 @@ v4l_compat_translate_ioctl(struct inode *inode, struct video_buffer *buffer = ...
7964b1b1c27dea88eb89b10f774893ec11cf973d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4859): Fix initializations on some video_ioctl2 handlers
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c index 41ec0c4b35a2..9024ea2557fd 100644 --- a/drivers/media/video/videodev.c +++ b/drivers/media/video/videodev.c @@ -1088,9 +1088,13 @@ static int __video_do_ioctl(struct inode *inode, struct file *file, case VIDIOC_G_AUDIO: { ...
2aa92ffd58493887adde850fe510031e48f12bac
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4858): Fix: implement missing VIDIOCSTUNER on v4l1-compat module
Problem Details: Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/v4l1-compat.c b/drivers/media/video/v4l1-compat.c index 06221a0c38aa..701856e6adbf 100644 --- a/drivers/media/video/v4l1-compat.c +++ b/drivers/media/video/v4l1-compat.c @@ -708,7 +708,16 @@ v4l_compat_translate_ioctl(struct inode *inode, } case VIDIOCSTUNER: /* sel...
ff67c614e23bf5a3c16968e2c42ab442121c4beb
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4852): Pvrusb2: Fix horizontal resolution setting problem for 24xxx devices
Problem Details: Fix long-standing issue which prevented use of 24xxx devices at any horizontal resolution other an 720. The problem is in the cx25840 module, if no attempt is made to initialize VBI there. Such a thing should not be needed, but the pvrusb2 driver is updated now to deal with this. Signed-off-by: Mike...
```diff diff --git a/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c b/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c index c80c26be6e4d..848fb233d808 100644 --- a/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c +++ b/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c @@ -260,6 +260,22 @@ int pvr2_i2c_cx2584x_v4l...
fa4cdd0dc4c066a1a4df19005912bf453dc37b6d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4850): Lgh06xf: fix compiler error when not selected
Problem Details: fix build error: lgh06xf.h:29: error: syntax error before '{' token Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/lgh06xf.h b/drivers/media/dvb/frontends/lgh06xf.h index 41c41fc59be1..510b4bedfb24 100644 --- a/drivers/media/dvb/frontends/lgh06xf.h +++ b/drivers/media/dvb/frontends/lgh06xf.h @@ -25,7 +25,7 @@ extern struct dvb_frontend* lgh06xf_attach(struct dvb_frontend* fe, ...
f9a7615686a854cb94b5252e66b836a0a539ad9e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4842): Updated camera driver
Problem Details: A couple of Cafe driver fixes, and support for the hue and saturation controls. Signed-off-by: Jonathan Corbet <corbet@lwn.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c index 684d817ccfe3..dc6e16c2b83b 100644 --- a/drivers/media/video/cafe_ccic.c +++ b/drivers/media/video/cafe_ccic.c @@ -505,6 +505,8 @@ static struct i2c_algorithm cafe_smbus_algo = { /* Somebody is on the bus */ static int cafe_...
49c6b46a05ade5e1c572431844b77755527a152c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4838): Fix cx88-blackbird null pointer
Problem Details: Allows 'debug=1' for cx88-blackbird module (dev needs to be valid for dprintk). Fixes a null-pointer dereference when using debug=1. Signed-off-by: Jelle Foks <jelle@foks.8m.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx88/cx88-blackbird.c b/drivers/media/video/cx88/cx88-blackbird.c index 0037188d77d4..0cf0360588e6 100644 --- a/drivers/media/video/cx88/cx88-blackbird.c +++ b/drivers/media/video/cx88/cx88-blackbird.c @@ -942,9 +942,10 @@ static int mpeg_open(struct inode *inode, struct file *f...
5d9d171aaed2e0b1c5caac96efd4d4150eec97e1
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4825): FIX bug 5760: audio were not working on some bttv drivers
Problem Details: This fixes a bug introduced by the -git commit: bbf7871e1cd58b89f77b1152f457250c6e94b614 It seems that some bttv apps can't work fine when audioset=0. Thanks to Christian Casteyde <casteyde.christian@free.fr> for pointing this. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c index 6e1ddad9f0c1..3c8e4742dccc 100644 --- a/drivers/media/video/bt8xx/bttv-driver.c +++ b/drivers/media/video/bt8xx/bttv-driver.c @@ -1793,7 +1793,7 @@ static int bttv_common_ioctls(struct bttv *btv, unsigned int cm...
589d069cfe7f2bb37c4836641ddffe9e2b51e74e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4794): Dvb: dibx000_common-fix
Problem Details: Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/dibx000_common.c b/drivers/media/dvb/frontends/dibx000_common.c index 61d28de30305..a18c8f45a2ee 100644 --- a/drivers/media/dvb/frontends/dibx000_common.c +++ b/drivers/media/dvb/frontends/dibx000_common.c @@ -63,7 +63,7 @@ static int dibx000_i2c_gated_tuner_xfer(struct ...
d92532d9860663cb39828e18a3e6aed27821f2bf
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4773): Misc fixes for DiB3000 and DiB7000
Problem Details: This patch contains several fixes for the autosearch algorithm and other small ones. Signed-off-by: Patrick Boettcher <pb@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/dvb/frontends/dib3000mc.c b/drivers/media/dvb/frontends/dib3000mc.c index 3561a777568c..5da66178006c 100644 --- a/drivers/media/dvb/frontends/dib3000mc.c +++ b/drivers/media/dvb/frontends/dib3000mc.c @@ -511,16 +511,11 @@ static int dib3000mc_autosearch_start(struct dvb_frontend *demo...
7343826370dd5fe14a2dcec20968f2d3a4431ce6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4723): Bugfix: Select the correct cx8802_dev when enumerating by CX88_MPEG_type
Problem Details: A bug in cx8802_get_driver() meant that in multiboard environments, when testing frontends on the non primary board, the incorrect device was returned resulting in "Unsupported value in .mpeg.." messages. Depending on the electrical design of the hardware (serial, parallel, rising/falling edge detect),...
```diff diff --git a/drivers/media/video/cx88/cx88-mpeg.c b/drivers/media/video/cx88/cx88-mpeg.c index 6f155713ee02..3d8e6d74e064 100644 --- a/drivers/media/video/cx88/cx88-mpeg.c +++ b/drivers/media/video/cx88/cx88-mpeg.c @@ -572,6 +572,8 @@ struct cx8802_driver * cx8802_get_driver(struct cx8802_dev *dev, enum cx88_bo...
f0882589666440d573f657cb3a1d5f66f3caa157
Analyze and fix the following issue in the Linux kernel code: [SPARC64]: Fix several kprobes bugs.
Problem Details: - relbranch_fixup(), for non-branches, would end up setting regs->tnpc incorrectly, in fact it would set it equal to regs->tpc which would cause that instruction to execute twice Also, if this is not a PC-relative branch, we should just leave regs->tnpc as-is. This covers cases like 'jmpl' wh...
```diff diff --git a/arch/sparc64/kernel/kprobes.c b/arch/sparc64/kernel/kprobes.c index 8e75ed762fd8..ae221f0d4a6f 100644 --- a/arch/sparc64/kernel/kprobes.c +++ b/arch/sparc64/kernel/kprobes.c @@ -45,7 +45,11 @@ DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk); int __kprobes arch_prepare_kprobe(struct kprobe *p) ...
306a22c2a20edf3a440bfb4cf2b94c19dfd81a53
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Fix io_apic.c warning
Problem Details: gcc 4.2 warns linux/arch/i386/kernel/io_apic.c: In function ‘create_irq’: linux/arch/i386/kernel/io_apic.c:2488: warning: ‘vector’ may be used uninitialized in this function The warning is false, but somewhat legitimate so work around it. Signed-off-by: Andi Kleen <ak@suse.de>
```diff diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c index e21dcde0790e..2424cc9c7b3d 100644 --- a/arch/i386/kernel/io_apic.c +++ b/arch/i386/kernel/io_apic.c @@ -2485,7 +2485,7 @@ device_initcall(ioapic_init_sysfs); int create_irq(void) { /* Allocate an unused irq */ - int irq, new, vector;...
92715e282be7c7488f892703c8d39b08976a833b
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: Fix boot hang due to nmi watchdog init code
Problem Details: 2.6.19 stopped booting (or booted based on build/config) on our x86_64 systems due to a bug introduced in 2.6.19. check_nmi_watchdog schedules an IPI on all cpus to busy wait on a flag, but fails to set the busywait flag if NMI functionality is disabled. This causes the secondary cpus to spin in an...
```diff diff --git a/arch/i386/kernel/nmi.c b/arch/i386/kernel/nmi.c index f5bc7e1be801..a5e34d655965 100644 --- a/arch/i386/kernel/nmi.c +++ b/arch/i386/kernel/nmi.c @@ -195,6 +195,8 @@ static __cpuinit inline int nmi_known_cpu(void) return 0; } +static int endflag __initdata = 0; + #ifdef CONFIG_SMP /* The per...
16d279d277aedd640d9dba5ddeb172b5e6bc7d75
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: Fix verify_quirk_intel_irqbalance()
Problem Details: Fix verify_quirk_intel_irqbalance(). genapic checks should really happen only on affected versions of the E7520/E7320/E7525 based platforms. AK: This should akpm's Coyote SDV Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Signed-off-by: Andi Kleen <ak@suse.de>
```diff diff --git a/arch/i386/kernel/quirks.c b/arch/i386/kernel/quirks.c index a01320a7b636..34874c398b44 100644 --- a/arch/i386/kernel/quirks.c +++ b/arch/i386/kernel/quirks.c @@ -10,13 +10,38 @@ #if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_SMP) && defined(CONFIG_PCI) static void __devinit verify_quirk_intel_...
a3a79bd7c75f0055df16540c7e9dbe270060ebe8
Analyze and fix the following issue in the Linux kernel code: [PATCH] Sun3: General updates
Problem Details: General compile fixes for 2.6.16 for sun3, and some updates to make the new bootloader work correctly. Tested on 3/50, 3/60, 3/80. Signed-off-by: Sam Creasey <sammy@sammy.net> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m68k/kernel/sun3-head.S b/arch/m68k/kernel/sun3-head.S index bffd69a4a1ab..4b5f050204e8 100644 --- a/arch/m68k/kernel/sun3-head.S +++ b/arch/m68k/kernel/sun3-head.S @@ -67,16 +67,6 @@ ENTRY(_start) 1: lea init_task,%curptr | get initial thread... lea init_thread_union+THREAD_SIZE,%sp | .....
93366c537b3426261cac4db27acc10a99cd91b06
Analyze and fix the following issue in the Linux kernel code: [XFRM]: Fix XFRMGRP_REPORT to use correct multicast group.
Problem Details: XFRMGRP_REPORT uses 0x10 which is a group that belongs to events. The correct value is 0x20. We should really be using xfrm_nlgroups going forward; it was tempting to delete the definition of XFRMGRP_REPORT but it would break at least iproute2. Signed-off-by: J Hadi Salim <hadi@cyberus.ca> Signed-off-...
```diff diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h index 088ba8113f7e..9529ea1ae392 100644 --- a/include/linux/xfrm.h +++ b/include/linux/xfrm.h @@ -357,7 +357,7 @@ struct xfrm_user_report { #define XFRMGRP_EXPIRE 2 #define XFRMGRP_SA 4 #define XFRMGRP_POLICY 8 -#define XFRMGRP_REPORT 0x10 +#define...
15b1c0e822f578306332d4f4c449250db5c5dceb
Analyze and fix the following issue in the Linux kernel code: [AX.25]: Fix default address and broadcast address initialization.
Problem Details: Only the callsign but not the SSID part of an AX.25 address is ASCII based but Linux by initializes the SSID which should be just a 4-bit number from ASCII anyway. Fix that and convert the code to use a shared constant for both default addresses. While at it, use the same style for null_ax25_address ...
```diff diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index 92420f007b97..760d04a671f9 100644 --- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c @@ -325,11 +325,6 @@ static int sp_rebuild_header(struct sk_buff *skb) static void sp_setup(struct net_device *dev) { - stati...
aa8de2f038baec993f07ef66fb3e94481d1ec22b
Analyze and fix the following issue in the Linux kernel code: [PATCH] Generic HID layer - input and event reporting
Problem Details: hid_input_report() was needlessly USB-specific in USB HID. This patch makes the function independent of HID implementation and fixes all the current users. Bluetooth patches comply with this prototype. Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Cc...
```diff diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 1dd9e4f0df1e..18c2b3cf6bcc 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -940,5 +940,64 @@ int hid_set_field(struct hid_field *field, unsigned offset, __s32 value) } EXPORT_SYMBOL_GPL(hid_set_field); +int hid_input_repo...
7bf65382caeecea4ae7206138e92e732b676d6e5
Analyze and fix the following issue in the Linux kernel code: [PATCH] proc_misc build fix
Problem Details: fs/proc/proc_misc.c: In function `version_read_proc': fs/proc/proc_misc.c:256: warning: implicit declaration of function `utsname' Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c index f6d6f81dd446..dc3e580d1dca 100644 --- a/fs/proc/proc_misc.c +++ b/fs/proc/proc_misc.c @@ -39,6 +39,7 @@ #include <linux/seq_file.h> #include <linux/times.h> #include <linux/profile.h> +#include <linux/utsname.h> #include <linux/blkdev.h> #include...
f00b16ad665a9b489d46f612679181f3f914917b
Analyze and fix the following issue in the Linux kernel code: [PATCH] dm io: fix bi_max_vecs
Problem Details: The existing code allocates an extra slot in bi_io_vec[] and uses it to store the region number. This patch hides the extra slot from bio_add_page() so the region number can't get overwritten. Also remove a hard-coded SECTOR_SHIFT and fix a typo in a comment. Signed-off-by: Heinz Mauelshagen <hjm@re...
```diff diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c index da663d2ff552..4eb73d395213 100644 --- a/drivers/md/dm-io.c +++ b/drivers/md/dm-io.c @@ -92,12 +92,12 @@ void dm_io_put(unsigned int num_pages) *---------------------------------------------------------------*/ static inline void bio_set_region(struct...
f4b85dc0a1a6a6af9e67b7993fc833051222f40b
Analyze and fix the following issue in the Linux kernel code: [PATCH] video: pm3fb macros fix
Problem Details: Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/video/pm3fb.h b/include/video/pm3fb.h index ac021379ac40..94c7d2da90ea 100644 --- a/include/video/pm3fb.h +++ b/include/video/pm3fb.h @@ -607,16 +607,16 @@ #define PM3FBDestReadModeOr 0xac98 #define PM3FBDestReadMode_ReadDisable 0<<0 #define PM3FBDestReadMode_ReadEnable 1<<0 - ...
4971bb70c0b0d0810e0c2b66927de2422ff82119
Analyze and fix the following issue in the Linux kernel code: [PATCH] video: neofb stray bracket fix
Problem Details: This code is '#if 0'ed. Anyway if anyone wants to dump neo registers better to have it fixed. Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/neofb.c b/drivers/video/neofb.c index 59a6f5fa5ae6..deaf820cb38f 100644 --- a/drivers/video/neofb.c +++ b/drivers/video/neofb.c @@ -1932,7 +1932,7 @@ static int __devinit neo_init_hw(struct fb_info *info) printk(KERN_DEBUG "--- Neo extended register dump ---\n"); for (int w = 0; w...
f378819a19e2b9639f17a1a82c5e12adc9512390
Analyze and fix the following issue in the Linux kernel code: [PATCH] gxfb: Fixups for the AMD Geode GX framebuffer driver
Problem Details: We cannot assume that the BIOS will be correctly setting up the hardware, so set some bits in various display registers to enable video output. Allow an advanced user to specify a frambuffer size, rather then probing the BIOS. All of these fixes were prompted by the OLPC effort. [akpm@osdl.org: clea...
```diff diff --git a/drivers/video/geode/Kconfig b/drivers/video/geode/Kconfig index 4e173ef20a7d..a814b6c2605c 100644 --- a/drivers/video/geode/Kconfig +++ b/drivers/video/geode/Kconfig @@ -23,6 +23,26 @@ config FB_GEODE_GX If unsure, say N. +config FB_GEODE_GX_SET_FBSIZE + bool "Manually specify the Geode GX ...
024cd7e08896884cfd58c78cd1f2103be12e3c09
Analyze and fix the following issue in the Linux kernel code: [PATCH] softcursor.c: avoid unaligned accesses
Problem Details: Fix some possible unaligned accesses when accessing fields of 'image' pointer. Indeed this pointer was obtained by allocating a block of memory that embeds a temporary array plus an image structure. The temporary buffer was located at the start of the allocated block and depending on its size, the im...
```diff diff --git a/drivers/video/console/softcursor.c b/drivers/video/console/softcursor.c index 7d07d8383569..f577bd80e020 100644 --- a/drivers/video/console/softcursor.c +++ b/drivers/video/console/softcursor.c @@ -1,11 +1,13 @@ /* - * linux/drivers/video/softcursor.c -- Generic software cursor for frame buffer de...
5850e0cf9a2345498fe2545c37118ef9405044eb
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix __init and __devinit annotations
Problem Details: Fix some __init and __devinit annotations. Signed-off-by: Ville Syrjala <syrjala@sci.fi> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index 1b3d3a27307c..7636f10eb885 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -3181,7 +3181,7 @@ static int __devinit atyfb_setup_sparc(struct pci_dev *pdev, #ifdef __i386__ #ifdef CONFIG_FB_A...
27b6859799ea766281828588e1adb17751193075
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix blanking level transitions
Problem Details: Fix a minor problem in blanking level transitions. Reducing the blanking level gradually was impossible. Signed-off-by: Ville Syrjala <syrjala@sci.fi> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index 9ea75f18169c..e6c3991f61ec 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -2825,9 +2825,9 @@ static int atyfb_blank(int blank, struct fb_info *info) #endif gen_cntl = aty_ld_le32(CRTC_GEN...
9b9817cc70709e10ffa9b27af35b2e8f1ef84798
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix sparse warnings
Problem Details: Silence some sparse warnings: * Remove casts from atari out_le32() and friends. * Move accel functions' declarations to atyfb.h. Signed-off-by: Ville Syrjala <syrjala@sci.fi> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds...
```diff diff --git a/drivers/video/aty/atyfb.h b/drivers/video/aty/atyfb.h index b04f49fb976a..e8dc5d10bd87 100644 --- a/drivers/video/aty/atyfb.h +++ b/drivers/video/aty/atyfb.h @@ -227,7 +227,7 @@ static inline u32 aty_ld_le32(int regindex, const struct atyfb_par *par) regindex -= 0x800; #ifdef CONFIG_ATARI - r...
c98959f566e0c695b1b237ad8e0f8f825d31fa71
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix compiler warnings
Problem Details: Fix some compiler warnings and remove an #ifdef. Signed-off-by: Ville Syrjala <syrjala@sci.fi> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index d1e50072228a..9ea75f18169c 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -2350,11 +2350,7 @@ static int __devinit aty_init(struct fb_info *info, const char *name) const char *ramname = NULL...
128806c3b3e263c579af12c061a9b04db3950016
Analyze and fix the following issue in the Linux kernel code: [PATCH] mbxfb: add more registers to debugfs
Problem Details: This patch fixes debugfs for mbxfb and adds some missing registers. The way registers were read was out of sync with the rest of the driver (direct access instead of using readl()) sdram controller registers are now accessible in the sdram/ subdirectory and some other registers are grouped in the mis...
```diff diff --git a/drivers/video/mbx/mbxdebugfs.c b/drivers/video/mbx/mbxdebugfs.c index 84aab3ad024e..472a3ca3d92d 100644 --- a/drivers/video/mbx/mbxdebugfs.c +++ b/drivers/video/mbx/mbxdebugfs.c @@ -10,6 +10,8 @@ struct mbxfb_debugfs_data { struct dentry *clock; struct dentry *display; struct dentry *gsctl; +...
ce7405fb380c097511d0a3d20db25bc167f3c5dc
Analyze and fix the following issue in the Linux kernel code: [PATCH] mbxfb: Fix HSCOEFF3 register address
Problem Details: This patch corrects the address for register HSCOEFF3. Signed-off-by: Raphael Assenat <raph@8d.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Acked-by: James Simmons <jsimmons@infradead.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/mbx/regs.h b/drivers/video/mbx/regs.h index ad20be07666b..a7c63d865aad 100644 --- a/drivers/video/mbx/regs.h +++ b/drivers/video/mbx/regs.h @@ -127,7 +127,7 @@ #define HSCOEFF0 __REG_2700G(0x000021b4) #define HSCOEFF1 __REG_2700G(0x000021b8) #define HSCOEFF2 __REG_2700G(0x000021bc)...
03ae4e0ccc10ad2d8b7f421fbbeac4fe44b806fb
Analyze and fix the following issue in the Linux kernel code: [PATCH] au11oofb: fix to remove flickering
Problem Details: Currently a lot of flickering is seen on the VGA and LCD port when one starts a DBAu1100 board, with 'CONFIG_PRINTK=3Dy'. This patch removes the flickering and as a result all kernel messages come by in a nice steady fashion. Signed-off-by: Freddy Spierenburg <freddy@dusktilldawn.nl> Cc: "Antonino A....
```diff diff --git a/drivers/video/au1100fb.h b/drivers/video/au1100fb.h index 2855534dc235..164fe2f231ec 100644 --- a/drivers/video/au1100fb.h +++ b/drivers/video/au1100fb.h @@ -274,7 +274,7 @@ static struct au1100fb_panel known_lcd_panels[] = .bpp = 16, .control_base = 0x0004886A | LCD_CONTROL_DEFAULT_PO | ...
d95159cf1b12e8e4b169094b35cbd93b887cb939
Analyze and fix the following issue in the Linux kernel code: [PATCH] various fbdev files: mark structs and array read-only
Problem Details: - move some structs and arrays to the read-only (.rodata) section [akpm@osdl.org: build fix] Signed-off-by: Helge Deller <deller@gmx.de> Acked-by: James Simmons <jsimmons@infradead.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 27597c576eff..f439a588394a 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -142,7 +142,7 @@ static struct class backlight_class = { .store = _store, \ } -static str...
c25623f5540694ba70af272170d67f1411be97b1
Analyze and fix the following issue in the Linux kernel code: [PATCH] video: Get the default mode from the right database
Problem Details: If no default mode is specified, it should be grabbed from the supplied database, not the default one. [teanropo@jyu.fi: fix it] [akpm@osdl.org: simplify it] [akpm@osdl.org: remove pointless DEFAULT_MODEDB_INDEX] Signed-off-by: Jordan Crouse <jordan.crouse@amd.com> Cc: Geert Uytterhoeven <geert@linux-...
```diff diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c index d1267904c280..5df41f6f2b86 100644 --- a/drivers/video/modedb.c +++ b/drivers/video/modedb.c @@ -34,8 +34,6 @@ const char *global_mode_option; * Standard video mode definitions (taken from XFree86) */ -#define DEFAULT_MODEDB_INDEX ...
572c04b24bd7b7e4b6a684416325cc3751fa8f45
Analyze and fix the following issue in the Linux kernel code: [PATCH] pmagb-b-fb: Fix a default clock frequency
Problem Details: Inspection of real hardware has revealed one of the clock frequencies known to be supported by PMAGB-B hardware is off by 3kHz. Following is a fix. Please apply. Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> Acked-by: James Simmons <jsimmons@infradead.org> Signed-off-by: Andrew Morton <akpm...
```diff diff --git a/drivers/video/pmagb-b-fb.c b/drivers/video/pmagb-b-fb.c index 73e2d7d16608..a06a064ad757 100644 --- a/drivers/video/pmagb-b-fb.c +++ b/drivers/video/pmagb-b-fb.c @@ -186,7 +186,7 @@ static void __init pmagbbfb_screen_setup(struct fb_info *info) static void __init pmagbbfb_osc_setup(struct fb_info ...
fd717689f46436fc212882ddc6e02a20be920634
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb, rivafb: minor fixes
Problem Details: aty128fb: return an error in the unlikely event that we cannot calculate some key PLL info rivafb: * call CalcStateExt() directly, rather than via function pointers, since CalcStateExt() is the only value ever assigned to ->CalcStateExt(). * propagate error return back from CalcVClock() through call...
```diff diff --git a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c index 276a21530b95..3feddf89d100 100644 --- a/drivers/video/aty/aty128fb.c +++ b/drivers/video/aty/aty128fb.c @@ -1333,6 +1333,8 @@ static int aty128_var_to_pll(u32 period_in_ps, struct aty128_pll *pll, if (vclk * 12 < c.ppll_min) vcl...
945f0ee257b4f91498b4061dc89b8a68c423ea6f
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/S3triofb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/S3triofb.c b/drivers/video/S3triofb.c index 397005eb392d..b3717c8f1bc2 100644 --- a/drivers/video/S3triofb.c +++ b/drivers/video/S3triofb.c @@ -535,8 +535,11 @@ static void __init s3triofb_of_init(struct device_node *dp) #endif fb_info.flags = FBINFO_FLAG_DEFAULT; - if (reg...
57354c42f177a2b58fb1f61125ad2cb2e8743a9b
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/amifb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c index a4e3fca05891..88a47845c4f7 100644 --- a/drivers/video/amifb.c +++ b/drivers/video/amifb.c @@ -2407,10 +2407,10 @@ default_chipset: fb_info.fix.smem_len); if (!videomemory) { printk("amifb: WARNING! unable to map videomem cached writ...
6792951b6ad13d7b2fff71ae7d2982b2fa1d6788
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/atafb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/atafb.c b/drivers/video/atafb.c index 02c41a626fa2..602db660bc73 100644 --- a/drivers/video/atafb.c +++ b/drivers/video/atafb.c @@ -2804,8 +2804,19 @@ int __init atafb_init(void) atafb_set_disp(-1, &fb_info); do_install_cmap(0, &fb_info); - if (register_framebuffer(&fb_info) < 0...
b2a85aebf9d6cb671085d58dfbbd7b11269d49eb
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/atyfb_base
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus...
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index e815b354c09d..b7b4e61b2951 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -3527,6 +3527,10 @@ static int __devinit atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *i atyfb_setup_gene...
d8b8c0a697d60c7d58a3dbda2d78553fd27727b3
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/cirrusfb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c index daf43f535a0b..2c4bc6205738 100644 --- a/drivers/video/cirrusfb.c +++ b/drivers/video/cirrusfb.c @@ -2442,7 +2442,10 @@ static int cirrusfb_pci_register (struct pci_dev *pdev, printk ("Cirrus Logic chipset on PCI bus\n"); pci_set_drvdata(...
d02abed8aa6bd37abcd802de64a63ed2af5e18ff
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/cyberfb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/cyberfb.c b/drivers/video/cyberfb.c index c40e72dafb0e..bc1cc44b1e3f 100644 --- a/drivers/video/cyberfb.c +++ b/drivers/video/cyberfb.c @@ -1055,6 +1055,8 @@ int __init cyberfb_init(void) if (register_framebuffer(&fb_info) < 0) { DPRINTK("EXIT - register_framebuffer fai...
8d4c767ef56473b68a601274612d604c8c334dc9
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/ffb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <t...
```diff diff --git a/drivers/video/ffb.c b/drivers/video/ffb.c index 2a0e8210d398..949141bd44d4 100644 --- a/drivers/video/ffb.c +++ b/drivers/video/ffb.c @@ -968,6 +968,8 @@ static int ffb_init_one(struct of_device *op) if (fb_alloc_cmap(&all->info.cmap, 256, 0)) { printk(KERN_ERR "ffb: Could not allocate color...
1b3349fa448ce41eda5ae0e6d4dc52837d14ad11
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/fm2fb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/fm2fb.c b/drivers/video/fm2fb.c index 998374cfae6d..70ff55b14596 100644 --- a/drivers/video/fm2fb.c +++ b/drivers/video/fm2fb.c @@ -283,6 +283,7 @@ static int __devinit fm2fb_probe(struct zorro_dev *z, if (register_framebuffer(info) < 0) { fb_dealloc_cmap(&info->cmap); + iounm...
1bedb0b2f60dd858fd12e5dd5681fa5da55175f5
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/hpfb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Bjorn Helgaas <bjorn.helgaas@hp.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <to...
```diff diff --git a/drivers/video/hpfb.c b/drivers/video/hpfb.c index 91cf3b577d15..9ab9b839a0f5 100644 --- a/drivers/video/hpfb.c +++ b/drivers/video/hpfb.c @@ -295,6 +295,8 @@ static int __init hpfb_init_one(unsigned long phys_base, unsigned long virt_base if (register_framebuffer(&fb_info) < 0) { fb_dealloc_...
164a765b9895f4f80f91cb7f1aab7539b3f8d335
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/macfb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus...
```diff diff --git a/drivers/video/macfb.c b/drivers/video/macfb.c index 80a043807161..180d94c2b4d2 100644 --- a/drivers/video/macfb.c +++ b/drivers/video/macfb.c @@ -608,6 +608,22 @@ void __init macfb_setup(char *options) } } +static void __init iounmap_macfb(void) +{ + if (valkyrie_cmap_regs) + iounmap(valkyrie...
f190017b889c45364576396a3bfa32acbb16bf2b
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/offb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus...
```diff diff --git a/drivers/video/offb.c b/drivers/video/offb.c index 9a40bbecf76b..9576a55eaf16 100644 --- a/drivers/video/offb.c +++ b/drivers/video/offb.c @@ -402,6 +402,9 @@ static void __init offb_init_fb(const char *name, const char *full_name, fb_alloc_cmap(&info->cmap, 256, 0); if (register_framebuffer(i...
2b7574da255fef27cdb294e19bea26d911443511
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/platinumfb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus...
```diff diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c index cb26c6df0583..233871655824 100644 --- a/drivers/video/platinumfb.c +++ b/drivers/video/platinumfb.c @@ -627,6 +627,9 @@ static int __devinit platinumfb_probe(struct of_device* odev, rc = platinum_init_fb(info); if (rc != 0) { + i...
295a1b476749e8b6fa6c3c0978426360ac7dde4b
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/pvr2fb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c index c7bc80921f16..a93618bc9d27 100644 --- a/drivers/video/pvr2fb.c +++ b/drivers/video/pvr2fb.c @@ -905,6 +905,15 @@ static int __init pvr2fb_dc_init(void) static void pvr2fb_dc_exit(void) { + if (fb_info->screen_base) { + iounmap(fb_info->scre...
027b53dd92e3d1a23c56d85e006a9bb5e63314f9
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/retz3fb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/retz3fb.c b/drivers/video/retz3fb.c index cf41ff177644..bc7ffc84e185 100644 --- a/drivers/video/retz3fb.c +++ b/drivers/video/retz3fb.c @@ -1423,8 +1423,10 @@ int __init retz3fb_init(void) do_install_cmap(0, fb_info); - if (register_framebuffer(fb_info) < 0) + if (register_fr...
9cf2014aad58076aa22faacf27742d9610dea05d
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/stifb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Helge Deller <deller@parisc-linux.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <...
```diff diff --git a/drivers/video/stifb.c b/drivers/video/stifb.c index 3e16e2d9d55d..69f3b264a22e 100644 --- a/drivers/video/stifb.c +++ b/drivers/video/stifb.c @@ -1291,6 +1291,7 @@ out_err3: out_err2: release_mem_region(fix->smem_start, fix->smem_len); out_err1: + iounmap(info->screen_base); fb_dealloc_cmap(&...
e4bf051b4f3121c5abdde836b1429e4a4459adb4
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/tgafb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/tgafb.c b/drivers/video/tgafb.c index 08b3153bfb3f..4b88fab83b74 100644 --- a/drivers/video/tgafb.c +++ b/drivers/video/tgafb.c @@ -1439,6 +1439,8 @@ tgafb_pci_register(struct pci_dev *pdev, const struct pci_device_id *ent) return 0; err1: + if (mem_base) + iounmap(mem_base); ...
a02f6402d5a18f5a4fd35cb82887c1097d0f7792
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/tridentfb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Cc: Knut Petersen <Knut_Petersen@t-online.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvald...
```diff diff --git a/drivers/video/tridentfb.c b/drivers/video/tridentfb.c index 14175cdb9c9c..55e8aa450bfa 100644 --- a/drivers/video/tridentfb.c +++ b/drivers/video/tridentfb.c @@ -1130,7 +1130,8 @@ static int __devinit trident_pci_probe(struct pci_dev * dev, const struct pci_de if (!request_mem_region(tridentfb...
b88a57cc645c59a3652f391f8069b15d42ac0762
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/vesafb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c index 2196448396ec..638ee3745401 100644 --- a/drivers/video/vesafb.c +++ b/drivers/video/vesafb.c @@ -456,6 +456,8 @@ static int __init vesafb_probe(struct platform_device *dev) info->node, info->fix.id); return 0; err: + if (info->screen_...
ef26dd7ffa305382aabcd95fd574d01808a65c41
Analyze and fix the following issue in the Linux kernel code: [PATCH] ioremap balanced with iounmap for drivers/video/virgefb
Problem Details: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: "Antonino A. Daplas" <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/virgefb.c b/drivers/video/virgefb.c index 64378959dd7b..b9fb6fb3600d 100644 --- a/drivers/video/virgefb.c +++ b/drivers/video/virgefb.c @@ -1799,7 +1799,7 @@ int __init virgefb_init(void) #warning release resources printk(KERN_ERR "virgefb.c: register_framebuffer failed\n"); ...
b10a06866600d1eda9e72ff328999e70f077fb3a
Analyze and fix the following issue in the Linux kernel code: [PATCH] pdc202xx_new: fix PIO mode setup
Problem Details: Fix pdcnew_tune_drive() to always set the PIO mode requested, not pick the best possible one, change pdcnew_config_drive_xfer_rate() accordingly, and get rid of the duplicate tuneproc() call in config_chipset_for_dma(). Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: Alan Cox <alan@lxorgu...
```diff diff --git a/drivers/ide/pci/pdc202xx_new.c b/drivers/ide/pci/pdc202xx_new.c index 0592dc0f96c0..3ca581063f72 100644 --- a/drivers/ide/pci/pdc202xx_new.c +++ b/drivers/ide/pci/pdc202xx_new.c @@ -9,6 +9,7 @@ * Split from: * linux/drivers/ide/pdc202xx.c Version 0.35 Mar. 30, 2002 * Copyright (C) 1998-200...
6b49a257850fb8ad91f4c76bb712e9213141a34a
Analyze and fix the following issue in the Linux kernel code: [PATCH] sysctl: fix sys_sysctl interface of ipc sysctls
Problem Details: Currently there is a regression and the ipc sysctls don't show up in the binary sysctl namespace. This patch adds sysctl_ipc_data to read data/write from the appropriate namespace and deliver it in the expected manner. [akpm@osdl.org: warning fix] Signed-off-by: Eric W. Biederman <ebiederm@xmission.c...
```diff diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 10474a63a111..025fcb3c66f8 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -143,6 +143,12 @@ static int sysctl_uts_string(ctl_table *table, int __user *name, int nlen, void __user *oldval, size_t __user *oldlenp, void __user *newval, size_t ne...
9bc9a6bd3cf559bffe962c51efb062e8b5270ca9
Analyze and fix the following issue in the Linux kernel code: [PATCH] sysctl: simplify ipc ns specific sysctls
Problem Details: Refactor the ipc sysctl support so that it is simpler, more readable, and prepares for fixing the bug with the wrong values being returned in the sys_sysctl interface. The function proc_do_ipc_string() was misnamed as it never handled strings. It's magic of when to work with strings and when to work w...
```diff diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 77ea4fc386ef..10474a63a111 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -92,7 +92,9 @@ extern char modprobe_path[]; extern int sg_big_buff; #endif #ifdef CONFIG_SYSVIPC -static int proc_do_ipc_string(ctl_table *table, int write, struct file *filp,...
a124c28ef85d9b780c418b2c5d8f01cd6a06ff3e
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection: Clamp debugfs stacktrace-depth to MAX_STACK_TRACE_DEPTH
Problem Details: Clamp /debug/fail*/stacktrace-depth to MAX_STACK_TRACE_DEPTH. Ensures that a read of /debug/fail*/stacktrace-depth always returns a truthful answer. Signed-off-by: Don Mullis <dwm@meer.net> Cc: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Tor...
```diff diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 244782940349..5da665ac2d89 100644 --- a/lib/fault-inject.c +++ b/lib/fault-inject.c @@ -53,6 +53,8 @@ static bool fail_task(struct fault_attr *attr, struct task_struct *task) return !in_interrupt() && task->make_it_fail; } +#define MAX_STACK_TRACE_...
83ba254688f0edd6fa29512e538c721f1f46a424
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection: stacktrace filtering kconfig fix
Problem Details: `select' doesn't work very well. With alpha `make allmodconfig' we end up with CONFIG_STACKTRACE enabled, so we end up with undefined save_stacktrace() at link time. Cc: Akinobu Mita <akinobu.mita@gmail.com> Cc: Don Mullis <dwm@meer.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Lin...
```diff diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index c24db7221b55..6eccc643c32e 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -417,7 +417,7 @@ config LKDTM config FAULT_INJECTION bool "Fault-injection framework" depends on DEBUG_KERNEL - select STACKTRACE + depends on STACKTRACE select FR...
1ab8509a31187998615e6dd7f53cc02db5be594c
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection Kconfig cleanup
Problem Details: - Fix some spelling and grammatical errors - Make the Kconfig menu more conventional. First you select fault-injection, then under that you select particular clients of it. Cc: Akinobu Mita <akinobu.mita@gmail.com> Cc: Don Mullis <dwm@meer.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-o...
```diff diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1449ca1bf572..c24db7221b55 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -415,7 +415,8 @@ config LKDTM drivers/misc/lkdtm.c config FAULT_INJECTION - bool + bool "Fault-injection framework" + depends on DEBUG_KERNEL select STACKTRACE s...
329409aeda064c4aff00c51f837fcd3bbdaeeba6
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault injection: stacktrace filtering
Problem Details: This patch provides stacktrace filtering feature. The stacktrace filter allows failing only for the caller you are interested in. For example someone may want to inject kmalloc() failures into only e100 module. they want to inject not only direct kmalloc() call, but also indirect allocation, too. - ...
```diff diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index cf075c20eda0..6d6e5ac5ea92 100644 --- a/Documentation/fault-injection/fault-injection.txt +++ b/Documentation/fault-injection/fault-injection.txt @@ -73,13 +73,17 @@ configuration of fault-in...
c17bb4951752d3e0f49cd1ea9d2e868422f9e0d6
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection capability for disk IO
Problem Details: This patch provides fault-injection capability for disk IO. Boot option: fail_make_request=<probability>,<interval>,<space>,<times> <interval> -- specifies the interval of failures. <probability> -- specifies how often it should fail in percent. <space> -- specifies the size of free space where...
```diff diff --git a/block/genhd.c b/block/genhd.c index 653919d50cd4..457fdac4c17d 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -417,6 +417,34 @@ static struct disk_attribute disk_attr_stat = { .show = disk_stats_read }; +#ifdef CONFIG_FAIL_MAKE_REQUEST + +static ssize_t disk_fail_store(struct gendisk * disk...
933e312e73f8fc39652bd4d216a5393cc3a014b9
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection capability for alloc_pages()
Problem Details: This patch provides fault-injection capability for alloc_pages() Boot option: fail_page_alloc=<interval>,<probability>,<space>,<times> <interval> -- specifies the interval of failures. <probability> -- specifies how often it should fail in percent. <space> -- specifies the size of free space wh...
```diff diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index c7f567a57d7d..c66b7b400c9f 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -424,6 +424,13 @@ config FAILSLAB help This option provides fault-injection capabilitiy for kmalloc. +config FAIL_PAGE_ALLOC + bool "Fault-injection capabilitiy f...
8a8b6502fb669c3a0638a08955442814cedc86b1
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection capability for kmalloc
Problem Details: This patch provides fault-injection capability for kmalloc. Boot option: failslab=<interval>,<probability>,<space>,<times> <interval> -- specifies the interval of failures. <probability> -- specifies how often it should fail in percent. <space> -- specifies the size of free space where memory c...
```diff diff --git a/Documentation/fault-injection/fault-injection.txt b/Documentation/fault-injection/fault-injection.txt index 260ce6c199ce..cf075c20eda0 100644 --- a/Documentation/fault-injection/fault-injection.txt +++ b/Documentation/fault-injection/fault-injection.txt @@ -86,7 +86,6 @@ configuration of fault-inje...
6ff1cb355e628f8fc55fa2d01e269e5e1bbc2fe9
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault-injection capabilities infrastructure
Problem Details: This patch provides base functions implement to fault-injection capabilities. - The function should_fail() is taken from failmalloc-1.0 (http://www.nongnu.org/failmalloc/) [akpm@osdl.org: cleanups, comments, add __init] Cc: <okuji@enbug.org> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Sign...
```diff diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h new file mode 100644 index 000000000000..4df4902bc8d8 --- /dev/null +++ b/include/linux/fault-inject.h @@ -0,0 +1,69 @@ +#ifndef _LINUX_FAULT_INJECT_H +#define _LINUX_FAULT_INJECT_H + +#ifdef CONFIG_FAULT_INJECTION + +#include <linux/types...
de1ba09b214056365d9082982905b255caafb7a2
Analyze and fix the following issue in the Linux kernel code: [PATCH] fault injection: documentation and scripts
Problem Details: This patch set provides some fault-injection capabilities. - kmalloc() failures - alloc_pages() failures - disk IO errors We can see what really happens if those failures happen. In order to enable these fault-injection capabilities: 1. Enable relevant config options (CONFIG_FAILSLAB, CONFIG_PAGE...
```diff diff --git a/Documentation/fault-injection/failcmd.sh b/Documentation/fault-injection/failcmd.sh new file mode 100644 index 000000000000..63177aba8106 --- /dev/null +++ b/Documentation/fault-injection/failcmd.sh @@ -0,0 +1,4 @@ +#!/bin/bash + +echo 1 > /proc/self/make-it-fail +exec $* diff --git a/Documentation...
4b75f78edcab291eb29fe9a205cbf7b80c1c644f
Analyze and fix the following issue in the Linux kernel code: [PATCH] lockdep: annotate nfsd4 recover code
Problem Details: > ============================================= > [ INFO: possible recursive locking detected ] > 2.6.18-1.2724.lockdepPAE #1 > --------------------------------------------- > nfsd/6884 is trying to acquire lock: > (&inode->i_mutex){--..}, at: [<c04811e5>] vfs_rmdir+0x73/0xf4 > > but task is already h...
```diff diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index 81b8565d3837..c7774e3a9469 100644 --- a/fs/nfsd/nfs4recover.c +++ b/fs/nfsd/nfs4recover.c @@ -259,7 +259,7 @@ nfsd4_remove_clid_file(struct dentry *dir, struct dentry *dentry) printk("nfsd4: non-file found in client recovery directory\n"); r...
df61bec3ae8983984070db24ae481fe7297a6dff
Analyze and fix the following issue in the Linux kernel code: [PATCH] ISDN: fix warnings
Problem Details: * diva, sedlbauer: the 'ready' label is only used in certain configurations * hfc_pci: - cast 'arg' to proper size for testing and printing - print out 'void __iomem *' variables with %p, rather than using incorrect casts that throw warnings Signed-off-by: Jeff Garzik <jeff@garzik.org> Acked-by: ...
```diff diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c index 3dacfff93f5f..6eebeb441bfd 100644 --- a/drivers/isdn/hisax/diva.c +++ b/drivers/isdn/hisax/diva.c @@ -1121,7 +1121,11 @@ setup_diva(struct IsdnCard *card) bytecnt = 32; } } + +#ifdef __ISAPNP__ ready: +#endif + printk(KERN_INFO...
f6e2cdc8aa395ea813603bfd81b70b5c461a8ebf
Analyze and fix the following issue in the Linux kernel code: [PATCH] ISDN: Avoid a potential NULL ptr deref in ippp
Problem Details: There's a potential problem in isdn_ppp.c::isdn_ppp_decompress(). dev_alloc_skb() may fail and return NULL. If it does we will be passing a NULL skb_out to ipc->decompress() and may also end up dereferencing a NULL pointer at *proto = isdn_ppp_strip_proto(skb_out); Correct this by testing 'skb_ou...
```diff diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c index 175199088bf4..26e46720fc1c 100644 --- a/drivers/isdn/i4l/isdn_ppp.c +++ b/drivers/isdn/i4l/isdn_ppp.c @@ -2536,6 +2536,11 @@ static struct sk_buff *isdn_ppp_decompress(struct sk_buff *skb,struct ippp_struc rsparm.maxdlen = IPPP_RE...
ba6d14aff4112b9518856d2d3979a386cb3a2945
Analyze and fix the following issue in the Linux kernel code: [PATCH] isdn: fix missing unregister_capi_driver
Problem Details: unregister_capi_driver() needs to be called in module cleanup. (It fixes data corruption by reloading t1isa driver) Cc: Kai Germaschewski <kai.germaschewski@gmx.de> Acked-by: Karsten Keil <kkeil@suse.de> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> ...
```diff diff --git a/drivers/isdn/hardware/avm/t1isa.c b/drivers/isdn/hardware/avm/t1isa.c index e47c60b0a8ec..c925020fe9b7 100644 --- a/drivers/isdn/hardware/avm/t1isa.c +++ b/drivers/isdn/hardware/avm/t1isa.c @@ -584,6 +584,7 @@ static void __exit t1isa_exit(void) { int i; + unregister_capi_driver(&capi_driver_t...
e2de257cf15d0508d29fa8a54a0dad78de4e75eb
Analyze and fix the following issue in the Linux kernel code: [PATCH] drivers/isdn: Handcrafted MIN/MAX Macro removal
Problem Details: Cleanups done to use min/max macros from kernel.h. Handcrafted MIN/MAX macros are changed to use macros in kernel.h [akpm@osdl.org: warning fix] Signed-off-by: Amol Lad <amol@verismonetworks.com> Cc: Karsten Keil <kkeil@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torval...
```diff diff --git a/drivers/isdn/hardware/eicon/debug.c b/drivers/isdn/hardware/eicon/debug.c index 6851c6270ce8..d835e74ecf18 100644 --- a/drivers/isdn/hardware/eicon/debug.c +++ b/drivers/isdn/hardware/eicon/debug.c @@ -756,14 +756,14 @@ int diva_get_driver_info (dword id, byte* data, int data_length) { data_...