Add rate limiter lease and dialect regression tests

tests/test_rate_limit.py

@@ -0,0 +1,69 @@
+from __future__ import annotations
+
+from collections import deque
+from types import SimpleNamespace
+
+import pytest
+
+from app.security.rate_limit import APIKeyRateLimiter, RateLimitLease
+
+
+class FakeLimiter:
+    def __init__(self) -> None:
+        self.releases: list[str] = []
+
+    async def release_job(self, api_key_id: str) -> None:
+        self.releases.append(api_key_id)
+
+
+@pytest.mark.asyncio
+async def test_concurrency_lease_release_is_idempotent() -> None:
+    limiter = FakeLimiter()
+    lease = RateLimitLease(limiter, "key-1", True)  # type: ignore[arg-type]
+
+    await lease.release()
+    await lease.release()
+
+    assert limiter.releases == ["key-1"]
+
+
+@pytest.mark.asyncio
+async def test_non_job_lease_does_not_release_concurrency() -> None:
+    limiter = FakeLimiter()
+    lease = RateLimitLease(limiter, "key-1", False)  # type: ignore[arg-type]
+
+    await lease.release()
+    await lease.release()
+
+    assert limiter.releases == []
+
+
+def test_remove_one_removes_only_one_matching_reservation() -> None:
+    values = deque([1.0, 2.0, 2.0, 3.0])
+
+    APIKeyRateLimiter._remove_one(values, 2.0)
+
+    assert list(values) == [1.0, 2.0, 3.0]
+
+
+def test_rate_limit_insert_supports_sqlite_and_postgres_dialects() -> None:
+    from sqlalchemy.dialects import postgresql, sqlite
+    from sqlalchemy.dialects.postgresql import insert as postgresql_insert
+    from sqlalchemy.dialects.sqlite import insert as sqlite_insert
+    from app.security.models import RateLimit
+
+    values = {
+        "api_key_id": "00000000-0000-0000-0000-000000000001",
+        "bucket_type": "requests_minute",
+        "bucket_start": __import__("datetime").datetime.now(__import__("datetime").timezone.utc),
+        "count": 1,
+        "units": 0,
+        "updated_at": __import__("datetime").datetime.now(__import__("datetime").timezone.utc),
+    }
+    for dialect, insert in ((sqlite.dialect(), sqlite_insert), (postgresql.dialect(), postgresql_insert)):
+        statement = insert(RateLimit).values(**values)
+        statement = statement.on_conflict_do_update(
+            index_elements=[RateLimit.api_key_id, RateLimit.bucket_type, RateLimit.bucket_start],
+            set_={"count": RateLimit.count + statement.excluded.count},
+        )
+        assert "ON CONFLICT" in str(statement.compile(dialect=dialect))