fix: iframe sign-in

#1
by burtenshaw HF Staff - opened

This PR opens sign-in outside the Hub iframe so the modal and board login work.

xdotli changed pull request status to closed

Thanks Ben, and sorry for the slow reply. You were right that the Hub's sandbox blocks top-level navigation. Main had moved on since your base: sign-in is now decided in one place, and inside huggingface.co every entry point opens the Space in a new tab, while on the Space's own address it stays in the same tab. So we didn't merge the diff itself, but we took your tests: the four you wrote (modal link, access-error link, failed-login recovery link, composer login) are now test_board_signin.py, adapted to main and run both framed and unframed. I also checked all four by hand in Chrome inside an iframe with the Hub's sandbox, and each opened a new tab. The front page now also opens with the posttrain.com hero you suggested (Start now scrolls to the board). It's live now on the Space (commit d3ab0f1), so I'm closing this PR. Thanks again!

Sign up or log in to comment