Landing page: external links open in a new tab

#3
by madhusoodhans - opened
vLLM Semantic Router org

External links on the landing page (Get API key, Decision API, MoM, Models, explore tiles) did nothing on the Space.

Cause: they used target="_top", which navigates the page around the app. A Space's iframe sandbox allows popups but not top navigation (no allow-top-navigation), so the browser blocked every click.

Fix: external links open in a new tab (target="_blank" rel="noopener noreferrer"). The receipt and returns demos are on the same origin, so they still open inside the Space frame as before. Visitors can get a key in the new tab and paste it back into the landing page.

Tested locally with the Space's iframe sandbox attributes copied exactly:

  • before: all 12 external links blocked
  • after: all 12 open in a new tab, the Space page stays, both demos open in the frame with the key handed over
  • e2e through the gateway with a real key: all pass

Only the landing page build changes (landing/index.html, new JS bundle, SOURCES.txt). Dockerfile is unchanged (already has chmod +x start.sh).

Separate note: "Check key" will keep failing while the Space is private (HF's proxy returns 404 to the key check, which is sent without the sign-in cookie). It works once the Space is public.

๐Ÿค– Generated with Claude Code

shailens changed pull request status to merged

Sign up or log in to comment