repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
NationalSecurityAgency/ghidra | 8,605 | issue_to_patch | Swift: Add the missing field fieldOffsetVectorOffset to TargetClassDescriptor | As part of the swift type metadata, both TargetStructDescriptor and TargetClassDescriptor have a fieldOffsetVectorOffset. This field was missing from TargetClassDescriptor even though it was already included in TargetStructDescriptor.
[swift source](https://github.com/swiftlang/swift/blob/main/include/swift/ABI/Metada... | 4b1fd225467d18aa664adf6cdc68a43fdd3e5025 | 051834401965ec4f73af10e54ea23ced1c2e5dea | diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/swift/types/TargetClassDescriptor.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/swift/types/TargetClassDescriptor.java
index ab18678c007..bf491c5d389 100644
--- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/form... | [
"Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/swift/types/TargetClassDescriptor.java"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,799 | issue_to_patch | Fix “Imported 1 files” | This fixes the following issue:
| Before | After |
|--------|-------|
| <img width="801" height="599" alt="1 files" src="https://github.com/user-attachments/assets/5daf31d6-aafb-4f79-a738-2fc84b96b5cd" /> | <img width="800" height="599" alt="1 file" src="https://github.com/user-attachments/assets/7d2b0894-e3d1-487... | 2f06823fba52a235ea6e3a3746e48aec89680a43 | e5e9b1a60b5d4a805323f787ca6749fb4cb91377 | diff --git a/Ghidra/Features/Base/src/main/java/ghidra/plugins/importer/tasks/ImportBatchTask.java b/Ghidra/Features/Base/src/main/java/ghidra/plugins/importer/tasks/ImportBatchTask.java
index 90e1e94131c..9a91ddd50fe 100644
--- a/Ghidra/Features/Base/src/main/java/ghidra/plugins/importer/tasks/ImportBatchTask.java
+++... | [
"Ghidra/Features/Base/src/main/java/ghidra/plugins/importer/tasks/ImportBatchTask.java"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,591 | issue_to_patch | refactor(pyghidra_launcher): Use importlib.metadata for get_package_version | Hello Ghidra Team,
This pull request provides a comprehensive refactoring of the `get_package_version` helper function in `ghidra/Ghidra/Features/PyGhidra/support/pyghidra_launcher.py`.
The goal is to improve the function's robustness, correctness, and overall code quality.
### Summary of Changes
1. **Repl... | 4e4a14f0d1028230d3aff7c2f0483dc0aa448fb8 | 8148f6364fb65539683c175ee26518413e4ece5a | diff --git a/Ghidra/Features/PyGhidra/support/pyghidra_launcher.py b/Ghidra/Features/PyGhidra/support/pyghidra_launcher.py
index acb95726012..ceb79cc504d 100644
--- a/Ghidra/Features/PyGhidra/support/pyghidra_launcher.py
+++ b/Ghidra/Features/PyGhidra/support/pyghidra_launcher.py
@@ -21,7 +21,8 @@
import sysconfig
fr... | [
"Ghidra/Features/PyGhidra/support/pyghidra_launcher.py"
] | [] | true | ||
NationalSecurityAgency/ghidra | 7,989 | issue_to_patch | Debugger: fix description of `step_into` |  | 8441563165857648ea991e196cd04ef3961d7054 | 6d5a0612907edc5dfde4f2dff2b912a5a6db70f4 | diff --git a/Ghidra/Debug/Debugger-agent-lldb/src/main/py/src/ghidralldb/methods.py b/Ghidra/Debug/Debugger-agent-lldb/src/main/py/src/ghidralldb/methods.py
index f43090b6328..baffe625838 100644
--- a/Ghidra/Debug/Debugger-agent-lldb/src/main/py/src/ghidralldb/methods.py
+++ b/Ghidra/Debug/Debugger-agent-lldb/src/main/... | [
"Ghidra/Debug/Debugger-agent-lldb/src/main/py/src/ghidralldb/methods.py"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,415 | issue_to_patch | Is `USERDEFINED` an old name for `CALLOTHER`?
The HTML P-Code reference documentation [describes](https://github.com/NationalSecurityAgency/ghidra/blob/master/GhidraDocs/languages/html/pseudo-ops.html#L41) `USERDEFINED` as a pseudo p-code operation kind; however, there is no `USERDEFINED` value in the `PcodeOp` class ... | [docs] Rename USERDEFINED to CALLOTHER | Closes #7068 | 31dc3a2f11a9778a4e8d188fb63cbc110288ad93 | ab1bb59aae0e85c1539f7793e8be45fbdb860158 | diff --git a/Ghidra/Features/Decompiler/src/main/doc/pcoderef.xml b/Ghidra/Features/Decompiler/src/main/doc/pcoderef.xml
index 24bdaed3c82..670e372c29e 100644
--- a/Ghidra/Features/Decompiler/src/main/doc/pcoderef.xml
+++ b/Ghidra/Features/Decompiler/src/main/doc/pcoderef.xml
@@ -60,7 +60,7 @@
</tr>
<tr>
<td></td>
... | [
"Ghidra/Features/Decompiler/src/main/doc/pcoderef.xml",
"Ghidra/Features/Decompiler/src/main/doc/sleigh.xml",
"GhidraDocs/languages/html/pcoderef.html",
"GhidraDocs/languages/html/pseudo-ops.html",
"GhidraDocs/languages/html/sleigh_ref.html"
] | [] | true | |
NationalSecurityAgency/ghidra | 8,633 | issue_to_patch | Fix typo in Languages.htm regarding language change | Corrected a typo in the instructions for changing the processor language.
`setlect` corrected to `select` | be482754a73ba9713d099565227b7f19d1f3e89c | 41c152f4eac9554d2674d7694e8750115be3a7d8 | diff --git a/Ghidra/Features/Base/src/main/help/help/topics/LanguageProviderPlugin/Languages.htm b/Ghidra/Features/Base/src/main/help/help/topics/LanguageProviderPlugin/Languages.htm
index c5d5df96e77..a266d9cba89 100644
--- a/Ghidra/Features/Base/src/main/help/help/topics/LanguageProviderPlugin/Languages.htm
+++ b/Ghi... | [
"Ghidra/Features/Base/src/main/help/help/topics/LanguageProviderPlugin/Languages.htm"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,588 | issue_to_patch | Fix spelling and grammar mistakes in the manual index documentation | Found some typos/incorrect grammar as I was reading the documentation describing the manual index format. This pull request fixes the issues I found. Also, I trimmed the blank space from the ends of lines that had it. | 4e4a14f0d1028230d3aff7c2f0483dc0aa448fb8 | 171a7fa8ba39c401a4407bb19daf6d6026f8bf26 | diff --git a/GhidraDocs/languages/manual_index.txt b/GhidraDocs/languages/manual_index.txt
index 60149bf2e84..ef2f38a2cd0 100644
--- a/GhidraDocs/languages/manual_index.txt
+++ b/GhidraDocs/languages/manual_index.txt
@@ -2,26 +2,26 @@
How to Create a Processor Language Manual Index File
------------------------------... | [
"GhidraDocs/languages/manual_index.txt"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,575 | issue_to_patch | Correct winsock.h headers in CreateExampleGDTArchiveScript.java | There is a compile error if you include both winsock.h and winsock2.h. It says you should only include winsock2.h. | 9e3bdc0e5037a9a0fcc42401e571b496f7034de3 | 15482627d8161af2849c27aa0b6b4b31324cbfc4 | diff --git a/Ghidra/Features/Base/ghidra_scripts/CreateExampleGDTArchiveScript.java b/Ghidra/Features/Base/ghidra_scripts/CreateExampleGDTArchiveScript.java
index 5aed3943a32..7a5d52bcf11 100644
--- a/Ghidra/Features/Base/ghidra_scripts/CreateExampleGDTArchiveScript.java
+++ b/Ghidra/Features/Base/ghidra_scripts/Create... | [
"Ghidra/Features/Base/ghidra_scripts/CreateExampleGDTArchiveScript.java"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,581 | issue_to_patch | Fix typos in the contributor's guide and readme | Fixes some minor spelling/capitalization errors and inconsistencies I noticed:
- scrutity -> scrutiny
- to using -> using
- Patch Submission tips -> Patch Submission Tips
- Contributor/Contributors Guide -> Contributor's Guide
- Developer Guide -> Developer's Guide
A bit pedantic, I know.
"Contributor Guid... | 4e4a14f0d1028230d3aff7c2f0483dc0aa448fb8 | 8e7c4f4d71fb48b6fc94b40ecb82fd8a77b10bba | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b19777653b5..b602d8c3c76 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,4 +1,4 @@
-# Contributors Guide
+# Contributor's Guide
Ghidra is an open source project. If you are interested in making it better,
there are many ways you can contribute. For examp... | [
"CONTRIBUTING.md",
"README.md"
] | [] | true | ||
NationalSecurityAgency/ghidra | 7,972 | issue_to_patch | Add eBPF instruction CALLX for indirect calls | Hello,
When clang encounters indirect calls in eBPF programs, it emits a call instruction with a register parameter (`BPF_X`) instead of an immediate value (`BPF_K`). This encoding (`BPF_JMP | BPF_CALL | BPF_X = 0x8d`) is decoded by llvm-objdump as `callx`.
For example, here is a simple C program with an indirect... | dbb9e7feeebe0ab68e05239b46a5ad3f12f02ab7 | 4f3f1059dc67d10db6a82c2c29c93d0d11504401 | diff --git a/Ghidra/Processors/eBPF/data/languages/eBPF.sinc b/Ghidra/Processors/eBPF/data/languages/eBPF.sinc
index dd0e741745c..62a77a1065d 100644
--- a/Ghidra/Processors/eBPF/data/languages/eBPF.sinc
+++ b/Ghidra/Processors/eBPF/data/languages/eBPF.sinc
@@ -17,7 +17,9 @@ define register offset=0 size=8 [ R0 R1 R2 ... | [
"Ghidra/Processors/eBPF/data/languages/eBPF.sinc"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,423 | issue_to_patch | fix(doc): Program names in README | The rest of the build dependencies/programs are named by their official names, with the exception of the Linux and macOS dependencies/programs; instead, they use their command names. For consistency across the documentation, it makes sense to use the actual names rather than the command names.
`g++` is also included... | 42794bc3fa63b707eba3bf055228b12d3085f5eb | 569a0a95a2ad22f1d33f37d99d0476c023f2145e | diff --git a/GhidraDocs/GettingStarted.md b/GhidraDocs/GettingStarted.md
index 3b0bdd6d534..001f90ee4dc 100644
--- a/GhidraDocs/GettingStarted.md
+++ b/GhidraDocs/GettingStarted.md
@@ -216,7 +216,7 @@ binaries for your platform, you will need the following installed on your system
App Store while _Command Line Too... | [
"GhidraDocs/GettingStarted.md",
"README.md"
] | [
{
"comment": "Should this be capitalized Make as well? I mean GNU refers to it with capitalization. https://www.gnu.org/software/make/\r\n\r\nToo busy to PR right now but if someone thinks this should be capitalized change it, just pointing it out.",
"path": "GhidraDocs/GettingStarted.md",
"hunk": "@@... | true | ||
NationalSecurityAgency/ghidra | 8,483 | issue_to_patch | BSim: fix malformed arguments to ./configure on macOS | The `make-postgres.sh` script fails to build PostgreSQL with OpenSSL enabled on macOS even when OpenSSL is present due to the script passing malformed arguments to `./configure`.
The script tries to automatically specify Homebrew's `include` and `lib` directories but without spaces between the arguments, which results... | 7a4100d54bff88530f11b577d4d2547d57630288 | 2be37e6f7b637a34b4ad1d88b417c8d885a9a606 | diff --git a/Ghidra/Features/BSim/support/make-postgres.sh b/Ghidra/Features/BSim/support/make-postgres.sh
index a2ab060f69f..5ab6cec265c 100755
--- a/Ghidra/Features/BSim/support/make-postgres.sh
+++ b/Ghidra/Features/BSim/support/make-postgres.sh
@@ -92,8 +92,8 @@ if [ "$OS" = "Darwin" ]; then
OSDIR="mac_arm_64"
... | [
"Ghidra/Features/BSim/support/make-postgres.sh"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,488 | issue_to_patch | Fix `java.awt.headless=true` inconsistently not being set in some bash scripts | In a few BSim related bash scripts, `java.awt.headless=true` is not set despite a clear intention to do so.
Setting this flag to true is beneficial for macOS users at the very least, because without it macOS's window manager takes the focus away from the terminal window when you run the script and puts it onto the Jav... | 1ca9e32a5712bc48a603f9e60d8f692220071eb7 | 4677edfc70d6079475448f047c5a7c23fcdb24ca | diff --git a/Ghidra/RuntimeScripts/Linux/support/bsim b/Ghidra/RuntimeScripts/Linux/support/bsim
index a9ff1917e5a..d4a1747f36a 100755
--- a/Ghidra/RuntimeScripts/Linux/support/bsim
+++ b/Ghidra/RuntimeScripts/Linux/support/bsim
@@ -18,4 +18,4 @@ VMARG_LIST="-Djava.awt.headless=true "
SCRIPT_FILE="$(readlink -f "$0" 2... | [
"Ghidra/RuntimeScripts/Linux/support/bsim",
"Ghidra/RuntimeScripts/Linux/support/bsim_ctl",
"docker/entrypoint.sh"
] | [
{
"comment": "I feel like the main issue in this file isn't the `+=`, but the fact that this line even exists. Since this is calling into `launch.sh`, the `launch.properties` file should be used, which defines `-Xshare:off`.",
"path": "Ghidra/RuntimeScripts/Linux/support/bsim_ctl",
"hunk": "@@ -19,6 +1... | true | ||
NationalSecurityAgency/ghidra | 8,024 | issue_to_patch | Fixes VxWorksSymTab_Finder.java edge case | Fixes MemoryAccessException that occurs if a candidate entry goes into invalid memory. This addresses an edge case where a candidate symbol table entry boundary is past the end of the binary. | 2abfd4e309f5a20dea947bbd41860ea7f3087527 | 45b91b1818d4b833485e781b4b2bfa882e6d689e | diff --git a/Ghidra/Features/GnuDemangler/ghidra_scripts/VxWorksSymTab_Finder.java b/Ghidra/Features/GnuDemangler/ghidra_scripts/VxWorksSymTab_Finder.java
index 72bc18be2e0..cf2a966bbd6 100644
--- a/Ghidra/Features/GnuDemangler/ghidra_scripts/VxWorksSymTab_Finder.java
+++ b/Ghidra/Features/GnuDemangler/ghidra_scripts/V... | [
"Ghidra/Features/GnuDemangler/ghidra_scripts/VxWorksSymTab_Finder.java"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,457 | issue_to_patch | TaintAnalysis: engine file chooser is not used when building query
**Describe the bug**
In the TaintAnalysis plugin using the CTADL engine, there is a configuration option to set the path of CTADL.
When running a taint query, if this path is incorrect, Ghidra prompts the user to choose the CTADL binary in a file choos... | Fix: TaintAnalysis query use chosen file if none set in tool options | These changes work on a fresh build, but if you would like to test, please see #8452 for the testing steps.
Changes:
- `buildQuery` in the `TaintState` classes now receives a `String engine_path` instead of a `Path engine`
- `queryIndex` now passes `engineFile.toString()` to `buildQuery` to pass chosen file
- Log... | c80f792ee825ab50402d5a7e04fbec2d203d63fb | d5df2590dc6b56f1edf1b7642504909dbd867ae1 | diff --git a/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/taint/AngrTaintState.java b/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/taint/AngrTaintState.java
index b22a1426ae2..33cba2b11b8 100644
--- a/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/taint/AngrTain... | [
"Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/taint/AngrTaintState.java",
"Ghidra/Features/DecompilerDependent/src/main/java/ghidra/app/plugin/core/decompiler/taint/AbstractTaintState.java",
"Ghidra/Features/DecompilerDependent/src/main/java/ghidra/app/plugin/core/decompiler/taint/CreateTarg... | [] | true | |
NationalSecurityAgency/ghidra | 8,393 | issue_to_patch | Fix 80251 "ANL Rm,#data" showing as "ADD" | Should be self explanatory, looks like it was just a typo. | 6c85ba4563f46075574f33c9baef56c425339d43 | e7cad294c9b0a19ec9d74ef733e31451fb47c468 | diff --git a/Ghidra/Processors/8051/data/languages/80251.sinc b/Ghidra/Processors/8051/data/languages/80251.sinc
index 64f7ee5169f..2658335ab4f 100644
--- a/Ghidra/Processors/8051/data/languages/80251.sinc
+++ b/Ghidra/Processors/8051/data/languages/80251.sinc
@@ -225,7 +225,7 @@ macro pop24(val) {
:ANL wrj47,wrj03 is... | [
"Ghidra/Processors/8051/data/languages/80251.sinc"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,394 | issue_to_patch | Fix ANL Areg,Data for 80251 in source mode | ANL Areg,Data should be GROUP1 rather than GROUP2, the incorrect group causes the instruction to fail to decode on source mode 80251. | 6c85ba4563f46075574f33c9baef56c425339d43 | cca3fcc208f9f1f8f69f60ed58dd470f976bddf0 | diff --git a/Ghidra/Processors/8051/data/languages/8051_main.sinc b/Ghidra/Processors/8051/data/languages/8051_main.sinc
index d3d40e01c05..22700c13ac1 100644
--- a/Ghidra/Processors/8051/data/languages/8051_main.sinc
+++ b/Ghidra/Processors/8051/data/languages/8051_main.sinc
@@ -672,7 +672,7 @@ Rel16: relAddr is rel... | [
"Ghidra/Processors/8051/data/languages/8051_main.sinc"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,450 | issue_to_patch | Fixed ida plugin working in IDA 9.x | Although I have already found the following work: https://github.com/NationalSecurityAgency/ghidra/issues/7392, which has attempted to fix idaxml's functionality in IDA 9.x, I still encountered runtime errors on my own IDA 9.0.
## 🎯 Overview
This pull request resolves critical compatibility issues preventing IDA... | 542c2aa617990c2b2ee2ac03bb0b66943a7af760 | a312aaabb1ed236f8ec21169c41b29c5e4e146ed | diff --git a/GhidraBuild/IDAPro/Python/9xx/loaders/xml_loader.py b/GhidraBuild/IDAPro/Python/9xx/loaders/xml_loader.py
index 956e2abb32e..5d2f3dd59f2 100644
--- a/GhidraBuild/IDAPro/Python/9xx/loaders/xml_loader.py
+++ b/GhidraBuild/IDAPro/Python/9xx/loaders/xml_loader.py
@@ -31,11 +31,6 @@
import idc
import sys
-i... | [
"GhidraBuild/IDAPro/Python/9xx/loaders/xml_loader.py",
"GhidraBuild/IDAPro/Python/9xx/plugins/xml_exporter.py",
"GhidraBuild/IDAPro/Python/9xx/plugins/xml_importer.py",
"GhidraBuild/IDAPro/Python/9xx/python/idaxml.py"
] | [] | true | ||
NationalSecurityAgency/ghidra | 8,408 | issue_to_patch | Icons in .rsrc are in wrong color
**Describe the bug**
The graphic for the first icon in the .rsrc section is rendered correctly. The remaining five have blue where there should be yellow.
**To Reproduce**
Steps to reproduce the behavior:
1. Use CodeBrowser to disassemble code
2. Use Function Trees to display ... | [BitmapResource] Fix channel swaped and black icons | Fixes #436
Icons that take the [`getOnePlaneImage`](https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/data/BitmapResource.java#L425) path do not have their color map considered and appear black. Icons that take the [`get32PlaneImage`](ht... | a60e2d8637a83d3f5a8fa13bd817546a429df3e7 | 03593e348de47baaf31545de4854424a3cd04ac1 | diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/data/BitmapResource.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/data/BitmapResource.java
index e4e5437018d..c4e1bdbe44e 100644
--- a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/data... | [
"Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/data/BitmapResource.java"
] | [] | true | |
NationalSecurityAgency/ghidra | 8,404 | issue_to_patch | BSim: Remove extra characters in CommandLineReference.html | Fixing a simple copy-paste error. | c311ecd87d5a2e24e7c740c1ff025ce8ce20b445 | 42bc550c0bf7b1ea06e2b83ac230767080f7d019 | diff --git a/Ghidra/Features/BSim/src/main/help/help/topics/BSim/CommandLineReference.html b/Ghidra/Features/BSim/src/main/help/help/topics/BSim/CommandLineReference.html
index 9e3a52e8133..1934c9ed0b5 100644
--- a/Ghidra/Features/BSim/src/main/help/help/topics/BSim/CommandLineReference.html
+++ b/Ghidra/Features/BSim/... | [
"Ghidra/Features/BSim/src/main/help/help/topics/BSim/CommandLineReference.html"
] | [] | true | ||
Netflix/atlas | 1,923 | issue_to_patch | core: cache exact match keys for data expressions | commonTags and GroupBy.eval recomputed Query.exactKeys(query) on every evaluation to determine which tags to retain. The query is fixed for a given expression, so the result was rebuilt unnecessarily on the eval hot path, showing up as a meaningful share of allocations for large query workloads.
Cache the exact matc... | f518d7f7e7a566853b0edd50db1bcda21b4c96e1 | f0da760b7590220b38f798791722d7382ff5d63e | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
index 44fa73a58..f05983ed0 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala"
] | [] | true | ||
Netflix/atlas | 1,922 | issue_to_patch | core: avoid intermediate map in binary op grouping | Binary math operations on grouped expressions joined the two sides by building an intermediate immutable Map (keyed by Option[String]) with groupBy, then probing it with get. On a load test allocation profile the groupBy accounted for ~23% of allocations: the trie nodes, the Option keys, and the Option returned per pro... | f518d7f7e7a566853b0edd50db1bcda21b4c96e1 | 1643c35d6e7ca679a4cc47d5ca63e09ece5a85f7 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala
index 14bfcfdb9..1b0daf889 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala"
] | [] | true | ||
Netflix/atlas | 1,921 | issue_to_patch | core: move offset label annotation out of core eval | DataExpr.consolidate forced the time series label (via toLabel) on every series and prepended an offset annotation, even though the label is frequently not consumed. On a load test allocation profile this was a significant share of allocations (~15%).
Reduce consolidate to only re-sample the data when the step diffe... | f518d7f7e7a566853b0edd50db1bcda21b4c96e1 | e4f79153d9170a53dabb4a6ea57146eb83ebee0a | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
index 44fa73a58..c8ed63650 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/StyleExpr.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/TimeSeriesExprSuite.scala",
... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala
index e0794e503..e5c79070f 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala
+++ b/atlas-core/src/test/scala/com/n... | true | |
Netflix/atlas | 1,924 | issue_to_patch | core: avoid lambda allocation in query matching | KeyValueQuery.matches and couldMatch used tags.get(k).exists(check) and tags.get(k).fold(true)(check) for the generic Map case. Passing the check method to exists/fold eta-expands it into a Function1 that is allocated on each call, on the per-series query matching hot path.
Use getOrElse(k, null) and call check dire... | f518d7f7e7a566853b0edd50db1bcda21b4c96e1 | 1de13527f092e026487d1bd512a27f17c42fbaa3 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/Query.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/Query.scala
index 0bf891f3a..18572d1a9 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/Query.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/model/Que... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/Query.scala"
] | [] | true | ||
Netflix/atlas | 1,920 | issue_to_patch | core: reduce allocations in group by and aggregate eval | Two allocation hot spots surfaced by an atlas-druid load test allocation profile, both in DataExpr eval:
- GroupBy.eval used the standard library groupBy, which builds an intermediate immutable HashMap that is discarded immediately by the following toList. Accumulate into a mutable map and emit the sorted list direc... | c009a0a135c6672701f6855f6d37435f1a615a59 | 0f195b622abf98e3dd9939933bf7b2b0f1ceba6b | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
index c94e274a5..44fa73a58 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala",
"atlas-eval/src/test/resources/graph/GrapherSuite/a6222045.png",
"atlas-eval/src/test/resources/graph/GrapherSuite/c1400057.png",
"atlas-webapi/src/test/resources/GraphApiSuite/27d8f972.png",
"atlas-webapi/src/test/resources/GraphApiSu... | [] | diff --git a/atlas-eval/src/test/resources/graph/GrapherSuite/a6222045.png b/atlas-eval/src/test/resources/graph/GrapherSuite/a6222045.png
index 2ccd0db48..702703497 100644
Binary files a/atlas-eval/src/test/resources/graph/GrapherSuite/a6222045.png and b/atlas-eval/src/test/resources/graph/GrapherSuite/a6222045.png di... | true | |
Netflix/atlas | 1,918 | issue_to_patch | add CLAUDE.md file | 6bfbacd36b0a8f143f9e500632aba4fd2f0ae09a | aae4a003af61ce4d03b931ccd64f483fe623062e | diff --git a/CLAUDE.md b/CLAUDE.md
new file mode 100644
index 000000000..2d7cb24d2
--- /dev/null
+++ b/CLAUDE.md
@@ -0,0 +1,60 @@
+# Atlas
+
+Netflix Atlas is a metrics platform for managing dimensional time series data. It uses a
+stack-based query language (Atlas Stack Language / ASL).
+
+## Contributing
+
+Follow th... | [
"CLAUDE.md"
] | [] | true | |||
Netflix/atlas | 1,917 | issue_to_patch | core: derive time series labels from tags lazily | The default label for a time series was built eagerly to represent the expression tree, e.g. `(name=a / name=b)`, `abs(name=a)`. For unary and binary operations this went through `String.format`, which allocates a `java.util.Formatter` and parses the pattern on every call, once per series per operation. In allocation p... | 050594a43680660f5c67716b14936272a682166e | ca0c8748e6ca6ef70a5bd00eceaa716d8c7b63b7 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala
index 50dcc50b5..14bfcfdb9 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/StyleExpr.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/TimeSeries.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/PerStepSuite.scala",
"atlas-co... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/model/PerStepSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/model/PerStepSuite.scala
index 70814f9b4..261854b64 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/model/PerStepSuite.scala
+++ b/atlas-core/src/test/scala/com/netflix... | true | |
Netflix/atlas | 1,916 | issue_to_patch | core: unescape list values consumed as data | List elements were stored raw by the interpreter (the raw form is needed for lists used as programs via :each/:map/:call), while scalar tokens are unescaped when pushed. As a result list values consumed as data were not unescaped: name,\u003afoo,:eq matched ":foo" but name,(,\u003afoo,),:in matched "\u003afoo".
Unes... | 5b2e40b69ce23a5c022b2914143f1c59c282473b | 1bd359b0a8a9dd94a326aea48cf2340e54c67fa8 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
index 348384bf7..c94e274a5 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/DataExpr.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/MathExpr.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/QueryVocabulary.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/ast/DataType.scala",
"... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/model/DataExprSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/model/DataExprSuite.scala
index c34ae7f78..ff95e47d3 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/model/DataExprSuite.scala
+++ b/atlas-core/src/test/scala/com/netf... | true | |
Netflix/atlas | 1,915 | issue_to_patch | core: report duration overflow as a client error | A relative time/duration amount that fits in a Long but overflows the duration arithmetic (e.g. s=e-9999999999999999y) threw an ArithmeticException from Duration.ofX, which the request handler maps to a 500 rather than a client error. The week/month/year multipliers also used plain Long multiplication, which silently w... | c55ec72ea18b98a9450e8a47ecc19409d5ceb1df | d4b647302f743921aeecd89fe5d5aaacea3c3ef9 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/util/Strings.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/util/Strings.scala
index 728f83b2c..1d7bf8fa6 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/util/Strings.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/util/S... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/util/Strings.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/util/StringsSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/util/StringsSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/util/StringsSuite.scala
index 8350487bb..d39b6e6ee 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/util/StringsSuite.scala
+++ b/atlas-core/src/test/scala/com/netflix/at... | true | |
Netflix/atlas | 1,914 | issue_to_patch | eval: reject non-positive graph width/height | The w and h query parameters were parsed with no lower bound. A width of 0 reached Step.compute via GraphConfig.stepSize and threw ArithmeticException (/ by zero), which the request handler maps to a 500 rather than a client error; negative or zero dimensions otherwise passed through to produce a degenerate config/imag... | 3d8b25d53599ece331508dcedffb9f372b40a6d0 | 9fc40733972409cb3d5063d46773aacc677acfdf | diff --git a/atlas-eval/src/main/scala/com/netflix/atlas/eval/graph/Grapher.scala b/atlas-eval/src/main/scala/com/netflix/atlas/eval/graph/Grapher.scala
index 057530ee6..d2655b492 100644
--- a/atlas-eval/src/main/scala/com/netflix/atlas/eval/graph/Grapher.scala
+++ b/atlas-eval/src/main/scala/com/netflix/atlas/eval/gra... | [
"atlas-eval/src/main/scala/com/netflix/atlas/eval/graph/Grapher.scala",
"atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala"
] | [] | diff --git a/atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala b/atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala
index 96071984f..ffd84d1c2 100644
--- a/atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala
+++ b/atlas-eval/src/test/scala/com/netflix... | true | |
Netflix/atlas | 1,913 | issue_to_patch | core: bound regex work in :s legend operator (ReDoS) | The :s search-and-replace style operator compiles a fully user-controlled pattern with java.util.regex and matched it with no limit, once per matched series, so a crafted pattern with catastrophic backtracking (e.g. (.*a){25}) could pin a request thread for hundreds of ms per series.
Match against a BoundedCharSeque... | e25a02a4975c5037c4612d258623d361b6b84078 | e68199699dd9c53594fb1842c6fba6ea5981fb92 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/StyleExpr.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/StyleExpr.scala
index f0d3820da..d3a3d3628 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/StyleExpr.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/StyleExpr.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala
index 4da9a30c2..cae4d8222 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/model/StyleExprSuite.scala
+++ b/atlas-core/src/test/scala/com/n... | true | |
Netflix/atlas | 1,912 | issue_to_patch | postgres: fix SQL injection in identifier escaping | Tag keys and group-by labels are used as double-quoted SQL identifiers (column aliases) but were escaped with escapeLiteral, which doubles single quotes and backslashes but not double quotes. A key or label containing a double quote could break out of the identifier and inject arbitrary SQL into the select list (demons... | 93a2d47629e14c2d195296ad05329058c3166095 | 9c56f4da4a038ab24901111605572f54c2e4260e | diff --git a/atlas-postgres/src/main/scala/com/netflix/atlas/postgres/SqlUtils.scala b/atlas-postgres/src/main/scala/com/netflix/atlas/postgres/SqlUtils.scala
index e488eb3fc..d4a5fe48a 100644
--- a/atlas-postgres/src/main/scala/com/netflix/atlas/postgres/SqlUtils.scala
+++ b/atlas-postgres/src/main/scala/com/netflix/a... | [
"atlas-postgres/src/main/scala/com/netflix/atlas/postgres/SqlUtils.scala",
"atlas-postgres/src/test/scala/com/netflix/atlas/postgres/SqlUtilsSuite.scala"
] | [] | diff --git a/atlas-postgres/src/test/scala/com/netflix/atlas/postgres/SqlUtilsSuite.scala b/atlas-postgres/src/test/scala/com/netflix/atlas/postgres/SqlUtilsSuite.scala
index 7284ff752..993ff59dd 100644
--- a/atlas-postgres/src/test/scala/com/netflix/atlas/postgres/SqlUtilsSuite.scala
+++ b/atlas-postgres/src/test/scal... | true | |
Netflix/atlas | 1,911 | issue_to_patch | core: bound rolling-window buffer size | The window size for :rolling-*, :delay, and :trend was taken from the user expression with no upper bound and used to eagerly allocate a double[] per matching series, so a crafted query such as 300000000,:rolling-mean could allocate ~2.4GB per series and exhaust the heap. Bound the size at the RollingBuffer allocation ... | b285c4d863c8fce0eb23ee822e6b762795feabcc | d14d71a876960cbf24431ca554a8eca5f18920d7 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/algorithm/RollingBuffer.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/algorithm/RollingBuffer.scala
index 41502091b..97efe24c6 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/algorithm/RollingBuffer.scala
+++ b/atlas-core/src/main/sc... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/algorithm/RollingBuffer.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/algorithm/OnlineRollingMeanSuite.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/algorithm/RollingBufferSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/algorithm/OnlineRollingMeanSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/algorithm/OnlineRollingMeanSuite.scala
index 222056f65..383ed503e 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/algorithm/OnlineRollingMeanSuite.scala
+... | true | |
Netflix/atlas | 1,910 | issue_to_patch | lsp: drain and ignore binary WebSocket messages | Binary messages fell into a catch-all that emitted a null stream element, which violates the Reactive Streams contract and crashed the WebSocket flow on the first binary frame; a streamed binary message would also leave its data source unconsumed and stall the connection. LSP JSON-RPC is text only, so drain the data so... | 4d9dd55867bfcd0449eefebcad3192ccc5cacd2f | 6d15da68a8177869e90a7e6607a6ac90b8a70739 | diff --git a/atlas-lspapi/src/main/scala/com/netflix/atlas/lspapi/LspWebSocketFlow.scala b/atlas-lspapi/src/main/scala/com/netflix/atlas/lspapi/LspWebSocketFlow.scala
index c1dd8fd39..ed6e7b4da 100644
--- a/atlas-lspapi/src/main/scala/com/netflix/atlas/lspapi/LspWebSocketFlow.scala
+++ b/atlas-lspapi/src/main/scala/com... | [
"atlas-lspapi/src/main/scala/com/netflix/atlas/lspapi/LspWebSocketFlow.scala",
"atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala"
] | [] | diff --git a/atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala b/atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala
index 9d1d111eb..0a07de1f9 100644
--- a/atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala
+++ b/atlas-lspapi/src/test/scala/com/netflix/atlas/... | true | |
Netflix/atlas | 1,909 | issue_to_patch | make MemoryDatabase.rebuildIndex public | Deriving index membership from the data map (#1906) stopped update() from feeding the index pending queue, so the synchronous data->index sync now happens only in rebuildIndex(). Callers that write via update() and previously forced a sync with index.rebuildIndex() no longer see their data: the no-arg BatchUpdateTagInd... | 4b99b45eea7a32d304aef646a1c5add10df75b36 | 3308941044250ff05aac2637ba5c5595027c4d83 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala
index 70e3c2a69..a05897347 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala
+++ b/atlas-core/src/main/scala/com/netflix/at... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala"
] | [] | true | ||
Netflix/atlas | 1,908 | issue_to_patch | Avoid cloning index bitmaps for read-only query operands | RoaringTagIndex query evaluation cloned the matching bitmap at every leaf (`equal`/`hasKey` via withOffsetClone, plus `True`) so the result could be mutated by an enclosing in-place and/or. A multi-term query therefore cloned once per term, and a standalone `:eq` cloned a bitmap that the caller only reads. Roaring bitm... | 43c9e809f7bd6fb297d3c3810a80a5f368d3325d | d18ed21356d861a3a69d2fff559591f4b4f84e38 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
index d31190005..47f2c6847 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
+++ b/atlas-core/src/main/scala/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala",
"atlas-jmh/src/main/scala/com/netflix/atlas/core/index/QueryAllocation.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala
index 36596e610..c1f3741ef 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala
+++ b/atlas-core/sr... | true | |
Netflix/atlas | 1,907 | issue_to_patch | Avoid boxing the primitive when iterating ref-keyed/valued maps | IntRefHashMap, RefIntHashMap, and RefDoubleHashMap exposed foreach as a Function2 callback. Because one parameter is a reference type, no specialized apply variant exists, so the generic apply(Object, Object) is used and the primitive (int key / int value / double value) is boxed on every element. This showed up as box... | 43c9e809f7bd6fb297d3c3810a80a5f368d3325d | a3f92f4da862de0c1c598f296e59c81351287448 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/util/IntRefHashMap.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/util/IntRefHashMap.scala
index 4efecd260..628f0f86b 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/util/IntRefHashMap.scala
+++ b/atlas-core/src/main/scala/com/netflix... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/util/IntRefHashMap.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/util/RefDoubleHashMap.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/util/RefIntHashMap.scala",
"atlas-jmh/src/main/scala/com/netflix/atlas/core/util/IntRefForeach.scala"
] | [] | true | ||
Netflix/atlas | 1,906 | issue_to_patch | Derive in-memory index membership from the data map | The metadata index could retain a series no longer present in the data map ("orphaned series"): a tag query returned it long after its data had aged past the retention window. It happened when a concurrent update revived a block store in the small window between rebuild()'s emptiness check and removing it from the data... | 43c9e809f7bd6fb297d3c3810a80a5f368d3325d | 947b3ecd8783672133917c8a283a900dfc3985bd | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/db/BlockStore.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/db/BlockStore.scala
index 1e59eaa00..ce748cd25 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/db/BlockStore.scala
+++ b/atlas-core/src/main/scala/com/netflix/atlas/core/db/... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/db/BlockStore.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala
index a46f7a023..c69fc8092 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala
+++ b/atlas-core/src/test/scala... | true | |
Netflix/atlas | 1,904 | issue_to_patch | update dependencies | 675dd4ca3d2246b449a009916fb74b82bb2ef81c | d2d6cfe7dd16f4b2f731836674e73463a04d535b | diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index 2ea4799fc..00940609c 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
java: [17, 25]
- scala: [2.13.18, 3.8.3]
+ scala: [2.13.18, 3.8.4]
steps:
... | [
".github/workflows/pr.yml",
"atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala",
"project/Dependencies.scala"
] | [] | diff --git a/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala b/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala
index 29d64d3a0..fae8cd450 100644
--- a/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala
+++ b/atlas-eval/src/test/scala/co... | true | ||
Netflix/atlas | 1,905 | issue_to_patch | ignore Metals/Bloop IDE directories | Add `.metals` and `.bloop` (Scala LSP / Bloop) to .gitignore so IDE-generated directories aren't accidentally committed. | 675dd4ca3d2246b449a009916fb74b82bb2ef81c | 86f9c17e410c22b0c597fad6dd1221e4b6d02529 | diff --git a/.gitignore b/.gitignore
index 9670bdec8..74d8b6486 100644
--- a/.gitignore
+++ b/.gitignore
@@ -26,3 +26,7 @@ target
.idea
.idea_modules
out
+
+# Metals (Scala LSP)
+.metals
+.bloop
| [
".gitignore"
] | [] | true | ||
Netflix/atlas | 1,903 | issue_to_patch | avoid per-block counter increments in executeImpl | The queryBlocks and aggrBlocks counters were incremented once per block inside the innermost query loop. That loop runs roughly (matched series * blocks per series) times, so on a busy node with high limits a single broad query drives billions of increment calls.
Profiling showed the counter bookkeeping (expiry chec... | 7a94a9ecc4665cdd7b4638a9370abc44e6a19615 | 79a806ca07d7bf08ecada5ef5b24682a8bb586ee | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala
index ba4a097f4..b9c0e53be 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala
+++ b/atlas-core/src/main/scala/com/netflix/at... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/db/MemoryDatabase.scala"
] | [] | true | ||
Netflix/atlas | 1,899 | issue_to_patch | tag atlas.eval.datapoints counters with upstream host | The counters emitted by TimeGrouped and AggregatorSettings previously had no dimension identifying the upstream backend, so dropped and buffered counts from all hosts folded together. Thread the groupBy-host key from createStreamsFlow through createProcessorFlow into TimeGrouped so each counter now carries a host tag, ... | 037a2cbedd3ef1bd7a959e462aa57f8e2f1d2849 | 46124a0e5e962950f1d1dca5cd07231d2ca6b672 | diff --git a/atlas-eval/src/main/scala/com/netflix/atlas/eval/model/AggrDatapoint.scala b/atlas-eval/src/main/scala/com/netflix/atlas/eval/model/AggrDatapoint.scala
index b57bc430b..83e7463d3 100644
--- a/atlas-eval/src/main/scala/com/netflix/atlas/eval/model/AggrDatapoint.scala
+++ b/atlas-eval/src/main/scala/com/netf... | [
"atlas-eval/src/main/scala/com/netflix/atlas/eval/model/AggrDatapoint.scala",
"atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala",
"atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/TimeGrouped.scala",
"atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/TimeGroupedSuite.sc... | [] | diff --git a/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/TimeGroupedSuite.scala b/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/TimeGroupedSuite.scala
index e4b0d852d..e33136400 100644
--- a/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/TimeGroupedSuite.scala
+++ b/atlas-eval/src/test/sc... | true | |
Netflix/atlas | 1,896 | issue_to_patch | update dependencies | d151e0ed9ec8f91f272eef6dca7a9d17b23bd001 | f269c137c2bb56e70639bb576ab1027556c1db41 | diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index 48a3e671b..2ea4799fc 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
java: [17, 25]
- scala: [2.13.18, 3.8.1]
+ scala: [2.13.18, 3.8.3]
steps:
... | [
".github/workflows/pr.yml",
"atlas-chart/src/main/scala/com/netflix/atlas/chart/JsonCodec.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/util/SortedTagMap.scala",
"atlas-eval/src/main/scala/com/netflix/atlas/eval/model/LwcMessages.scala",
"project/Dependencies.scala",
"project/build.properties"... | [] | true | |||
Netflix/atlas | 1,895 | issue_to_patch | eval: fix flaky testProcessor state machine in EvaluatorSuite | Simplify the state machine from 4 states to 3, removing the unreliable check that "one" messages had stopped arriving. With async boundaries and buffering in the pipeline, buffered messages for a removed data source can continue to arrive intermittently, causing the old state 3 to never complete. The simplified version... | 71343b39c80e9b6910b6a57b1540b4445092d229 | df28e7b4ae78277abd38856e1998aae52fc083b2 | [
"atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala"
] | [] | diff --git a/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala b/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala
index 81e4b5bcc..29d64d3a0 100644
--- a/atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuite.scala
+++ b/atlas-eval/src/test/scala/co... | true | ||
Netflix/atlas | 1,894 | issue_to_patch | core: add sample-count helper | Macro to help with computing sample-count for all
samples. | ebc4190468401535b3b8a9eb3ae3d096b980db98 | 77814dc318d77ac85f2683c57aadb28d6293a063 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathVocabulary.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathVocabulary.scala
index 5c135c0a0..bff7476d6 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/model/MathVocabulary.scala
+++ b/atlas-core/src/main/scala/com/n... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/model/MathVocabulary.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/ModelExtractorsSuite.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/PercentilesSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/model/ModelExtractorsSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/model/ModelExtractorsSuite.scala
index 9631dbb63..9ff11ee4a 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/model/ModelExtractorsSuite.scala
+++ b/atlas-core/sr... | true | |
Netflix/atlas | 1,893 | issue_to_patch | update to vite 6.4.2 | 7198741cc9367ef61e72e4467775e5b55cbba49d | 238c7688c144036d5831d4f02737cd26532e1af4 | diff --git a/atlas-lsp/test-client/package.json b/atlas-lsp/test-client/package.json
index 62ed50e30..4039fa58c 100644
--- a/atlas-lsp/test-client/package.json
+++ b/atlas-lsp/test-client/package.json
@@ -10,6 +10,6 @@
"monaco-editor": "^0.55.1"
},
"devDependencies": {
- "vite": "~6.2.0"
+ "vite": "~6.... | [
"atlas-lsp/test-client/package.json"
] | [] | true | |||
Netflix/atlas | 1,892 | issue_to_patch | core: add configurable max stack size to interpreter | Prevent exponential stack growth from expressions that use operations like :each and :fcall to repeatedly double the stack. The limit also applies to list literals to prevent unbounded memory growth via large (,...) expressions.
The default limit of 1024 was validated against 1.7M real-world expressions with zero ne... | d7be0b484bc4aaf3a735d8a76b5d1edc5b8608be | c025a52e253918d5304f47286f49a925c3e5aa5a | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Context.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Context.scala
index c18bebd3c..109a6d2c9 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Context.scala
+++ b/atlas-core/src/main/scala/com/netflix/at... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Context.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/LoopSuite.scala",
"atlas-lsp/src/main/java/com/netflix/atlas/lsp/AslLspServer.java",
"atlas-... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/LoopSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/LoopSuite.scala
index 65b00ec7c..9c0503b94 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/LoopSuite.scala
+++ b/atlas-core/src/test/scala/com/netf... | true | |
Netflix/atlas | 1,891 | issue_to_patch | remove jsonp implementation | # Remove JSONP support from atlas-pekko (XSS fix)
## Summary
Remove the `jsonpFilter` directive from `CustomDirectives` to eliminate a Reflected Cross-Site Scripting (XSS) vulnerability
([CWE-79](https://cwe.mitre.org/data/definitions/79.html)).
The `jsonpFilter` method wrote user-supplied `callback` query ... | deaf5103b6b06a1a9fb59cea857921b737f83e84 | 0efae59545133430a2984706a3360183265a17f3 | diff --git a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/CustomDirectives.scala b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/CustomDirectives.scala
index ea8d0a22a..5035457a8 100644
--- a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/CustomDirectives.scala
+++ b/atlas-pekko/src/main/scala/com/netfli... | [
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/CustomDirectives.scala",
"atlas-pekko/src/test/scala/com/netflix/atlas/pekko/CustomDirectivesSuite.scala"
] | [] | diff --git a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/CustomDirectivesSuite.scala b/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/CustomDirectivesSuite.scala
index d4e4370c3..a722a07cf 100644
--- a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/CustomDirectivesSuite.scala
+++ b/atlas-pekko/src/test/s... | true | |
Netflix/atlas | 1,889 | issue_to_patch | lsp: add WebSocket transport module | Add atlas-lspapi module providing a Pekko HTTP WebSocket transport for the LSP servers. This enables embedding the LSP in an Atlas web server, allowing browser-based editors (like the Monaco test client) to connect via WebSocket instead of stdio.
Components:
- LspApi: Pekko HTTP route that upgrades to WebSocket and... | eea688982ccd6e701ccef37008170b621b5ca4ca | cee82d6ac0a5b3ae7ac23f04cce959dbca2c6030 | diff --git a/atlas-lspapi/src/main/resources/reference.conf b/atlas-lspapi/src/main/resources/reference.conf
new file mode 100644
index 000000000..a9e3154f6
--- /dev/null
+++ b/atlas-lspapi/src/main/resources/reference.conf
@@ -0,0 +1,12 @@
+
+atlas {
+ lsp {
+ glossary = ""
+ }
+
+ pekko {
+ api-endpoints = $... | [
"atlas-lspapi/src/main/resources/reference.conf",
"atlas-lspapi/src/main/scala/com/netflix/atlas/lspapi/LspApi.scala",
"atlas-lspapi/src/main/scala/com/netflix/atlas/lspapi/LspWebSocketFlow.scala",
"atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala",
"build.sbt"
] | [] | diff --git a/atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala b/atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala
new file mode 100644
index 000000000..9d1d111eb
--- /dev/null
+++ b/atlas-lspapi/src/test/scala/com/netflix/atlas/lspapi/LspApiSuite.scala
@@ -0,0 +1,58 @@
+/*
+ *... | true | |
Netflix/atlas | 1,888 | issue_to_patch | lsp: add Language Server Protocol module | Add atlas-lsp module implementing LSP for Atlas Stack Language and graph URI documents. Provides real-time editor support including diagnostics, completions, hover, semantic tokens, code actions, document symbols, and go-to-definition.
Two server variants:
- AslLspServer for standalone ASL expressions
- UriLspServ... | c31924e3678dbd7fec3d10d1faa0abc013b1d064 | c71d014e7a0c072a4d278af727a26cd1ec9381b3 | diff --git a/atlas-lsp/GLOSSARY_SPEC.md b/atlas-lsp/GLOSSARY_SPEC.md
new file mode 100644
index 000000000..9bd2ba89e
--- /dev/null
+++ b/atlas-lsp/GLOSSARY_SPEC.md
@@ -0,0 +1,293 @@
+# Atlas Glossary Specification
+
+## Overview
+
+An Atlas glossary file describes the metrics, tag keys, and tag values that exist in
+a ... | [
"atlas-lsp/GLOSSARY_SPEC.md",
"atlas-lsp/README.md",
"atlas-lsp/src/main/java/com/netflix/atlas/lsp/AslLspServer.java",
"atlas-lsp/src/main/java/com/netflix/atlas/lsp/AslTextDocumentService.java",
"atlas-lsp/src/main/java/com/netflix/atlas/lsp/AslWorkspaceService.java",
"atlas-lsp/src/main/java/com/netfli... | [] | diff --git a/atlas-lsp/src/test/resources/sample-glossary.json b/atlas-lsp/src/test/resources/sample-glossary.json
new file mode 100644
index 000000000..654887d6a
--- /dev/null
+++ b/atlas-lsp/src/test/resources/sample-glossary.json
@@ -0,0 +1,534 @@
+{
+ "id": "nflx.sample",
+ "description": "Sample glossary for LSP... | true | |
Netflix/atlas | 1,887 | issue_to_patch | eval: add tests for named color alpha resolution | Add unit tests verifying the Grapher correctly applies alpha transparency to named colors resolved at render time. Named colors like blue1 and red2 are theme-dependent and resolved via DefaultSettings.resolveColor, so alpha must be applied after resolution rather than being merged into the color string at evaluation ti... | 1c1eb72ae07a16341f5d46b9f2d48177da352f94 | effcdb56b95f440ae75f797f829bb71cd0ddf78c | [
"atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala"
] | [] | diff --git a/atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala b/atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala
index 0c014f343..96071984f 100644
--- a/atlas-eval/src/test/scala/com/netflix/atlas/eval/graph/GrapherSuite.scala
+++ b/atlas-eval/src/test/scala/com/netflix... | true | ||
Netflix/atlas | 1,886 | issue_to_patch | core: add syntax tree and URI parser | Add error-tolerant AST construction for Atlas stack language expressions and a URI parser for graph API endpoints.
Interpreter.syntaxTree builds a syntax tree from an expression string, recovering from errors and collecting diagnostics for each problem. The tree contains position info for all tokens, resolved word r... | 9c188cc94aa7c69e99c1083545d30e0651868f99 | 68cf985d50db27dc4ad94a42e061767c4d242fda | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala
index 4c21b0c61..44e0a68f3 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala
+++ b/atlas-core/src/main/scala/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/ast/Diagnostic.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/ast/Severity.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/ast/Sp... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/SyntaxTreeSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/SyntaxTreeSuite.scala
new file mode 100644
index 000000000..78a65c2a0
--- /dev/null
+++ b/atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/SyntaxTreeSuite.... | true | |
Netflix/atlas | 1,885 | issue_to_patch | core: add AST type system for stack language | Introduces a structured type system for the Atlas stack language:
- New `stacklang.ast` package with DataType, Parameter, and IsNumber
- TypedWord trait with typed parameters, outputs, matching, and execution
- TypedMacro for macros with type declarations but body-based execution
- StylePassthrough mixin for tran... | f1032105934aa61f415675da54875209af3d6814 | f261e22bb9801769b4d265b6240ef996fdde00c2 | diff --git a/atlas-core/src/main/resources/reference.conf b/atlas-core/src/main/resources/reference.conf
index 1409bf90c..6140352d0 100644
--- a/atlas-core/src/main/resources/reference.conf
+++ b/atlas-core/src/main/resources/reference.conf
@@ -25,6 +25,27 @@ atlas {
max-datapoints = 500000
}
+ normali... | [
"atlas-core/src/main/resources/reference.conf",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/DataVocabulary.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/EventVocabulary.scala",
"atlas-core/src/main/scala/com/netflix/atlas/core/model/ExprNormalizer.scala",
"atlas-core/src/main/s... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala
index efe43a932..a46f7a023 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/db/MemoryDatabaseSuite.scala
+++ b/atlas-core/src/test/scala... | true | |
Netflix/atlas | 1,884 | issue_to_patch | pekko - Catch DateTimeExceptions in the RequestHandler error response | and treat them as 400's instead of 500s. DTEs should only be thrown when we receive errant user requests. | d5c4247379158421e22f92ac1352246c191451b6 | 3951721cd7133e07e2b1c6fc606734cfa5a196f4 | diff --git a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/RequestHandler.scala b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/RequestHandler.scala
index dfd9f97e0..fa7a62ceb 100644
--- a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/RequestHandler.scala
+++ b/atlas-pekko/src/main/scala/com/netflix/atla... | [
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/RequestHandler.scala"
] | [] | true | ||
Netflix/atlas | 1,882 | issue_to_patch | core: support comments in stack expressions | Add support for stripping comments from stack language expressions. Comments use the `/* ... */` syntax and can be nested. The escape logic is updated to encode the `/` in `/*` sequences so literal values containing that pattern are not misinterpreted as comment delimiters. | a0444a7130cc759f5a7863d98e9d82f29b815385 | 2f250fb3202235ee4cf2246dd462a056a91721b9 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala
index 3c08fe762..4c21b0c61 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala
+++ b/atlas-core/src/main/scala/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/stacklang/Interpreter.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/model/QuerySuite.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/stacklang/InterpreterSuite.scala",
"atlas-eval/src/test/scala/com/netflix/atlas/eval/stream/EvaluatorSuit... | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/model/QuerySuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/model/QuerySuite.scala
index 2a60a73cd..e659c444b 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/model/QuerySuite.scala
+++ b/atlas-core/src/test/scala/com/netflix/atlas... | true | |
Netflix/atlas | 1,883 | issue_to_patch | eval: add output buffer for stream | Helps to avoid backpressure from the consumer causing connection noise.
Port #1876 to 1.9.x. | fdf21cdf87f6102c3ab85e997dfcbbe1bb017752 | 11a868b7325e9ccb2a401d5bcfb49fe83b829867 | diff --git a/atlas-eval/src/main/resources/reference.conf b/atlas-eval/src/main/resources/reference.conf
index 16470b774..26d48c601 100644
--- a/atlas-eval/src/main/resources/reference.conf
+++ b/atlas-eval/src/main/resources/reference.conf
@@ -18,6 +18,9 @@ atlas.eval {
// is too old
num-buffers = 1
+ /... | [
"atlas-eval/src/main/resources/reference.conf",
"atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala",
"atlas-eval/src/test/resources/application.conf"
] | [] | diff --git a/atlas-eval/src/test/resources/application.conf b/atlas-eval/src/test/resources/application.conf
index 89e3521fa..a40b37a8b 100644
--- a/atlas-eval/src/test/resources/application.conf
+++ b/atlas-eval/src/test/resources/application.conf
@@ -39,6 +39,8 @@ atlas {
stream {
simple-legends-enabled =... | true | |
Netflix/atlas | 1,881 | issue_to_patch | pekko: add a monitored buffer operation | This works similar to `Flow.buffer(size, dropNew)`, but has counters for the number of buffered and dropped events.
Port #1875 to 1.9.x. | a0444a7130cc759f5a7863d98e9d82f29b815385 | 5141d1c0f877432d919d4baa304dc48ee004b0f3 | diff --git a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala
index de339e7c3..81ca6f6b0 100644
--- a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala
+++ b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamO... | [
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala",
"atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala"
] | [] | diff --git a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala b/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala
index 559cfb77b..ba48b4ebb 100644
--- a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala
+++ b/atlas-pekko/src/test/scala/com/netflix/atla... | true | |
Netflix/atlas | 1,880 | issue_to_patch | core: fix lessThan matching in RoaringTagIndex | tagOffset returns the insertion point (first element greater than the target) when a tag is not found. The lessThan method iterates backward from this position, but was incorrectly starting at the insertion point itself, which could include values that are not actually less than the query value.
This occurs when the... | 7234c97a55fa270ceb351594f6818813dfaf8506 | e8c123cbc95ec97620148aff571c43dc267d06a6 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
index 01bf521fb..d31190005 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
+++ b/atlas-core/src/main/scala/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala
index 2f65eefdc..36596e610 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/index/RoaringTagIndexSuite.scala
+++ b/atlas-core/sr... | true | |
Netflix/atlas | 1,879 | issue_to_patch | core: reduce memory overhead of SortedTagMap | Always keeps the map compact to ensure there aren't empty spaces in the array. This also allows us to remove the length so with compact object headers it should be 16 bytes instead of 24 bytes overhead per map. | 4e671a4e49a85829c950f7b7b164e7f1a68c5d72 | adb30b7a5417ac15075669bd2659be7d5e765e3c | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/util/SortedTagMap.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/util/SortedTagMap.scala
index f4670a74c..c7417515f 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/util/SortedTagMap.scala
+++ b/atlas-core/src/main/scala/com/netflix/at... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/util/SortedTagMap.scala",
"atlas-core/src/test/scala/com/netflix/atlas/core/util/SortedTagMapSuite.scala"
] | [] | diff --git a/atlas-core/src/test/scala/com/netflix/atlas/core/util/SortedTagMapSuite.scala b/atlas-core/src/test/scala/com/netflix/atlas/core/util/SortedTagMapSuite.scala
index bfbed8d9b..a15f3d0bb 100644
--- a/atlas-core/src/test/scala/com/netflix/atlas/core/util/SortedTagMapSuite.scala
+++ b/atlas-core/src/test/scala... | true | |
Netflix/atlas | 1,878 | issue_to_patch | core: reduce tag index memory overhead | Reduce initial capacity for temporary HashSets used during index construction. Based on production data, the number of unique keys is typically under 10k and unique values are roughly 1/6th of the number of items, so items.length was significantly oversized for both.
Flatten itemTags from Array[Array[Int]] to a pair... | 09fca1be0c543b9ff4710420b0234c7b105ddf03 | 35b2c36773ce6d4e5e5f583fb91241ccaf1522fa | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
index 781870525..01bf521fb 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
+++ b/atlas-core/src/main/scala/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala"
] | [] | true | ||
Netflix/atlas | 1,877 | issue_to_patch | core: tag index optimizations | RoaringBitmap library is published to maven again, bump to the latest version to pick up recent improvemnts. Also use helper methods for intersection and andNot rather than the custom methods. | 18bf58f262061c1299f9fc4cb803bb8736b5f641 | b9a6236125c5ff41b7167ea0128ec0f2ce4f08f3 | diff --git a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala b/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
index d92ca5c99..781870525 100644
--- a/atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala
+++ b/atlas-core/src/main/scala/co... | [
"atlas-core/src/main/scala/com/netflix/atlas/core/index/RoaringTagIndex.scala",
"project/Dependencies.scala"
] | [] | true | ||
Netflix/atlas | 1,876 | issue_to_patch | eval: add output buffer for stream | Helps to avoid backpressure from the consumer causing connection noise. | 1658be32f3a70468d934f9aac0172a297f4153e4 | 9cabb434cd03736ca51df6fa258672218298dfbd | diff --git a/atlas-eval/src/main/resources/reference.conf b/atlas-eval/src/main/resources/reference.conf
index 16470b774..26d48c601 100644
--- a/atlas-eval/src/main/resources/reference.conf
+++ b/atlas-eval/src/main/resources/reference.conf
@@ -18,6 +18,9 @@ atlas.eval {
// is too old
num-buffers = 1
+ /... | [
"atlas-eval/src/main/resources/reference.conf",
"atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala",
"atlas-eval/src/test/resources/application.conf"
] | [] | diff --git a/atlas-eval/src/test/resources/application.conf b/atlas-eval/src/test/resources/application.conf
index 89e3521fa..a40b37a8b 100644
--- a/atlas-eval/src/test/resources/application.conf
+++ b/atlas-eval/src/test/resources/application.conf
@@ -39,6 +39,8 @@ atlas {
stream {
simple-legends-enabled =... | true | |
Netflix/atlas | 1,875 | issue_to_patch | pekko: add a monitored buffer operation | This works similar to `Flow.buffer(size, dropNew)`, but has counters for the number of buffered and dropped events. | b48f7918429a20782b505d82fc3da6cbdbf9c1e7 | cca8c80957a1a2f38bdcafaaf94c27eb7b54cb9b | diff --git a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala
index de339e7c3..81ca6f6b0 100644
--- a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala
+++ b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamO... | [
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala",
"atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala"
] | [] | diff --git a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala b/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala
index 559cfb77b..ba48b4ebb 100644
--- a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/StreamOpsSuite.scala
+++ b/atlas-pekko/src/test/scala/com/netflix/atla... | true | |
Netflix/atlas | 1,874 | issue_to_patch | Backport recent changes to 1.8.x | 46ddf3da17b48b64de0e805c51c9d44fd33c9dc3 | bc1e06881145da6a914f6929e0745affc063e112 | diff --git a/atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala b/atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala
index fa82e98a7..91ab7834b 100644
--- a/atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala
+++ b/atlas-eval/src/main/scala/com/n... | [
"atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala",
"atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/SubscribeApi.scala",
"atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/WebSocketSessionManager.scala",
"atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuit... | [] | diff --git a/atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala b/atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala
index dfe6aa67e..63b7e2b5f 100644
--- a/atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala
+++ b/atlas-lwcapi/src/test/scala/... | true | ||
Netflix/atlas | 1,873 | issue_to_patch | pekko: avoid backpressure for staggered broadcast | Allow the set of cluster members to be updated even if the downstream is still working based on the injected delays. | 5b0f2022b826be86e7efa64f0e2e8e21620cc9e5 | 5ba8b95a2786ae5fd80043b4f14206eb11b650d6 | diff --git a/atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala b/atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala
index c8b590fda..8185cb759 100644
--- a/atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala
+++ b/atlas-eval/src/main/scala/com/n... | [
"atlas-eval/src/main/scala/com/netflix/atlas/eval/stream/EvaluatorImpl.scala",
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/ClusterOps.scala",
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala",
"atlas-pekko/src/test/scala/com/netflix/atlas/pekko/ClusterOpsSuite.scala"
] | [] | diff --git a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/ClusterOpsSuite.scala b/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/ClusterOpsSuite.scala
index 64e00968f..fa83a04ef 100644
--- a/atlas-pekko/src/test/scala/com/netflix/atlas/pekko/ClusterOpsSuite.scala
+++ b/atlas-pekko/src/test/scala/com/netflix/a... | true | |
Netflix/atlas | 1,872 | issue_to_patch | pekko: remove redundant unit in log message | 4c06ed61ba375c562c7eaea8bc7989b866e6d16f | 1c796392ecbd493c92117cda09b7808d8c6f286b | diff --git a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/ClusterOps.scala b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/ClusterOps.scala
index 2165489cd..01102602a 100644
--- a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/ClusterOps.scala
+++ b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/Clus... | [
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/ClusterOps.scala"
] | [] | true | |||
Netflix/atlas | 1,871 | issue_to_patch | lwcapi: heartbeat immediately on ws connect | When subscription delivery is delayed (e.g., due to staggered broadcast), the websocket connection could hit the idle timeout before any data flows. This was because the data source (including heartbeats) was not pushed downstream until the client sent its first subscription message.
- Push the data source on the fi... | cce2d9b02d94b9492ca08c90e2a0592a1db44d64 | d97b94c7ab20e71975635ec8848da89d68114f0f | diff --git a/atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/SubscribeApi.scala b/atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/SubscribeApi.scala
index 71304b2e1..35c18c277 100644
--- a/atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/SubscribeApi.scala
+++ b/atlas-lwcapi/src/main/scala/com/netflix/atl... | [
"atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/SubscribeApi.scala",
"atlas-lwcapi/src/main/scala/com/netflix/atlas/lwcapi/WebSocketSessionManager.scala",
"atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala",
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/ClusterOps.scala"... | [] | diff --git a/atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala b/atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala
index ebf57716c..ecd98785e 100644
--- a/atlas-lwcapi/src/test/scala/com/netflix/atlas/lwcapi/SubscribeApiSuite.scala
+++ b/atlas-lwcapi/src/test/scala/... | true | |
Netflix/atlas | 1,870 | issue_to_patch | pekko: add warn log if byte limit is hit | Ensures it will get logged and be easier to debug. If relying on the caller it might get burried in the pekko plumbing. | 765c540212271370afa41970cc90bf448c68fe17 | 90948fc0551eec6ee3ad25ef16435813073c3122 | diff --git a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala
index 9ae43df93..9f7eae425 100644
--- a/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala
+++ b/atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamO... | [
"atlas-pekko/src/main/scala/com/netflix/atlas/pekko/StreamOps.scala"
] | [] | true | ||
Netflix/atlas | 1,869 | issue_to_patch | 1.8: switch back to scala 3.7.4 | c04f52e2cdc8e7889e3ee1f54f62b554cc43b98c | 1b604d4d7d7c0579f8b6a0d50a148b9493fc6ce2 | diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index 48a3e671b..bfa12c04e 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
java: [17, 25]
- scala: [2.13.18, 3.8.1]
+ scala: [2.13.18, 3.7.4]
steps:
... | [
".github/workflows/pr.yml",
"project/Dependencies.scala"
] | [] | true | |||
Netflix/fast_jsonapi | 474 | issue_to_patch | The project is no longer maintained... | It would be really nice if somebody from the old team could merge this to help clarify the status of the project and mention the fork of it.
Thanks in advance :bow: | 3df917f4073bc3752c2078a84099bc85d5b4f8b9 | 90a57c9bb1cf2ab94d5cc5c19c2e7cdcc04bbccf | diff --git a/README.md b/README.md
index df86d288..35fe34d9 100644
--- a/README.md
+++ b/README.md
@@ -1,9 +1,11 @@
-# Fast JSON API
+# Fast JSON API — :warning: This project is no longer maintained!!!! :warning:
[](https://travis-ci.org/Ne... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 366 | issue_to_patch | [#365] Support frozen array in option | Fix error raised when we pass frozen array to `include` option.
https://github.com/Netflix/fast_jsonapi/blob/fdcaed6f0d72cf793b3117a5081de5fbd7466574/lib/fast_jsonapi/object_serializer.rb#L89 | 91e2beec8e21fb2bfaa2587fd08d956e2bcab9f5 | cdc864c1c281166ed323bfaba082a875ef383ce5 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index b8a24183..e767135d 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -86,7 +86,7 @@ def process_options(options)
raise ArgumentError.new("`params` option passed to seri... | [
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/version.rb",
"spec/lib/object_serializer_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index ef755ccc..74bb2f41 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -473,6 +473,16 @@ class BlahSerializer
options[:include] = [:actors]
expect(serializable_hash['inclu... | true | |
Netflix/fast_jsonapi | 378 | issue_to_patch | pass array of unique movies to serializer | According to JSON API document, `id` should be unique.
https://jsonapi.org/format/#document-resource-objects
`id` of movie generated by `let(:movie)` is always same.
https://github.com/Netflix/fast_jsonapi/blob/master/spec/shared/contexts/movie_context.rb#L438
So I replace array passed to serializer `[movies, m... | cc7f88843a6306aefc9e3ab73499d306cea39fb2 | cbc1d91bfc525a566bdbd8770e236cfb2a97c212 | diff --git a/README.md b/README.md
index 53c8bfa7..4c9151ee 100644
--- a/README.md
+++ b/README.md
@@ -100,6 +100,17 @@ movie.actor_ids = [1, 2, 3]
movie.owner_id = 3
movie.movie_type_id = 1
movie
+
+movies =
+ 2.times.map do |i|
+ m = Movie.new
+ m.id = i + 1
+ m.name = "test movie #{i}"
+ m.actor_ids ... | [
"README.md",
"spec/lib/instrumentation/as_notifications_negative_spec.rb",
"spec/lib/instrumentation/as_notifications_spec.rb",
"spec/lib/object_serializer_caching_spec.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/lib/object_serializer_spec.rb"
] | [
{
"comment": "The problem I see with this change in the documentation is that the variable `movies` is never declared (as far as I could tell) within the documentation. More of a nitpick than a usage issue.",
"path": "README.md",
"hunk": "@@ -298,7 +298,7 @@ options[:links] = {\n prev: '...'\n }\n opt... | diff --git a/spec/lib/instrumentation/as_notifications_negative_spec.rb b/spec/lib/instrumentation/as_notifications_negative_spec.rb
index 6912ed49..de144dea 100644
--- a/spec/lib/instrumentation/as_notifications_negative_spec.rb
+++ b/spec/lib/instrumentation/as_notifications_negative_spec.rb
@@ -10,7 +10,8 @@
... | true | |
Netflix/fast_jsonapi | 370 | issue_to_patch | Validate all include options | Per the spec, https://jsonapi.org/format/#fetching-includes
`If a server is unable to identify a relationship path or does not support inclusion of resources from a path, it MUST respond with 400 Bad Request.`
Currently the library is only checking the first instance due to using detect which stops processing aft... | cc7f88843a6306aefc9e3ab73499d306cea39fb2 | 461705200ade2d8904d3b5fdc40897887be4b433 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index b8a24183..0e306126 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -299,7 +299,7 @@ def link(link_name, link_method_name = nil, &block)
def validate_includes!(include... | [
"lib/fast_jsonapi/object_serializer.rb",
"spec/lib/object_serializer_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index ef755ccc..53c08cae 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -142,12 +142,25 @@
expect { MovieSerializer.new([movie, movie], options).serializable_hash }.to raise_error(Arg... | true | |
Netflix/fast_jsonapi | 354 | issue_to_patch | Fix error on defining anonymous serializer class | With this change it is possible to create anonymous serializer classes.
Fixes #353 | ae93b851037f453ee8e6cc4b4d8fb4dcb62a7469 | 22796a6a811750c3847d809b73bdaed6ca7b393a | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index b8a24183..bc88ee7e 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -130,7 +130,7 @@ def reflected_record_type
return @reflected_record_type if defined?(@reflected_r... | [
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/version.rb",
"spec/lib/object_serializer_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index ef755ccc..7e46d907 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -314,6 +314,15 @@ class BlahBlahSerializer
expect(BlahBlahSerializer.record_type).to be :blah_blah
end
+... | true | |
Netflix/fast_jsonapi | 333 | issue_to_patch | Allow fieldsets to specify no attributes/relationships | Users should be allowed to specify no fields/relationships.
Conceptually it is the difference between `/acceptance/resources/1` and `/acceptance/resources/1?fields[resource]=`.
The corresponding payload would be
```
data: {
type: "resource",
id: 1
}
```
This is a useful feature for APIs when loading ... | 36b8ea2dfc609cc772451fd455775202dd3abb42 | 54e718c7d519c54af91d01b83a261e51cf548401 | diff --git a/lib/fast_jsonapi/serialization_core.rb b/lib/fast_jsonapi/serialization_core.rb
index a456b21e..c11d132a 100644
--- a/lib/fast_jsonapi/serialization_core.rb
+++ b/lib/fast_jsonapi/serialization_core.rb
@@ -44,6 +44,8 @@ def links_hash(record, params = {})
def attributes_hash(record, fieldset = nil, ... | [
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_fields_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_fields_spec.rb b/spec/lib/object_serializer_fields_spec.rb
index 913ba83b..697f209d 100644
--- a/spec/lib/object_serializer_fields_spec.rb
+++ b/spec/lib/object_serializer_fields_spec.rb
@@ -22,6 +22,18 @@
expect(hash[:data][:relationships].keys.sort).to eq %i[actors adverti... | true | |
Netflix/fast_jsonapi | 243 | issue_to_patch | Use a Railtie to extend Rails | Railties are the core of the Rails framework and provide several hooks to extend Rails, using Railties is the 'Rails-way' to introduce extensions/patches to Rails libraries/components.
Based on this I'm going to add hooks to introduce a new renderer for Action Controller as described in https://github.com/Netflix/fa... | 44d5e0f9c5bd54a5fbfd265b805c55e65d95af11 | 1649ad7dcd7f71fc714d8b8772b8c23ee8a61847 | diff --git a/lib/extensions/has_one.rb b/lib/extensions/has_one.rb
index 930ca574..1588359b 100644
--- a/lib/extensions/has_one.rb
+++ b/lib/extensions/has_one.rb
@@ -1,20 +1,18 @@
# frozen_string_literal: true
-if defined?(::ActiveRecord)
- ::ActiveRecord::Associations::Builder::HasOne.class_eval do
- # Based o... | [
"lib/extensions/has_one.rb",
"lib/fast_jsonapi.rb",
"lib/fast_jsonapi/railtie.rb"
] | [] | true | ||
Netflix/fast_jsonapi | 390 | issue_to_patch | Update Readme | ## What?
Fix typo
<img width="645" alt="editing fast_jsonapi readme md at master netflix fast_jsonapi 2019-02-18 19-27-59" src="https://user-images.githubusercontent.com/6765108/52982424-f8edb000-33b3-11e9-8771-42869c32d6ed.png">
| cc7f88843a6306aefc9e3ab73499d306cea39fb2 | f3cf541627c0fe8232ca175751a35677beca19e6 | diff --git a/README.md b/README.md
index 53c8bfa7..52727754 100644
--- a/README.md
+++ b/README.md
@@ -473,7 +473,7 @@ Skylight relies on `ActiveSupport::Notifications` to track these two core method
require 'fast_jsonapi/instrumentation'
```
-The two instrumented notifcations are supplied by these two constants:
+... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 349 | issue_to_patch | Add documentation on how to use helper methods in serializers | Issue #344 was raised because of lack of documentation around this topic, so I just thought it is a good idea to get this documented. | fdcaed6f0d72cf793b3117a5081de5fbd7466574 | d951d26d1258ab2ed88c1b13bb62f59b2b6b7b88 | diff --git a/README.md b/README.md
index 53c8bfa7..8f4454ad 100644
--- a/README.md
+++ b/README.md
@@ -33,6 +33,7 @@ Fast JSON API serialized 250 records in 3.01 ms
* [Conditional Attributes](#conditional-attributes)
* [Conditional Relationships](#conditional-relationships)
* [Sparse Fieldsets](#sparse-fieldse... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 350 | issue_to_patch | Fix Documentation of Meta Per Resource | Some part of the documentation for this got removed during last merge, so fixing it. | fdcaed6f0d72cf793b3117a5081de5fbd7466574 | 20a97cabbf638d8180d3ccd1f161facce62359dc | diff --git a/README.md b/README.md
index 53c8bfa7..77cbf3bf 100644
--- a/README.md
+++ b/README.md
@@ -276,7 +276,12 @@ This will create a `self` reference for the relationship, and a `related` link f
### Meta Per Resource
For every resource in the collection, you can include a meta object containing non-standard m... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 391 | issue_to_patch | Fix typo in README | Minor typo is fixed here.
"autedetect" should be "autodetect". | cc7f88843a6306aefc9e3ab73499d306cea39fb2 | 7d47bab801d913c83b45da597bb0abdf90a4c616 | diff --git a/README.md b/README.md
index 53c8bfa7..929ed5ba 100644
--- a/README.md
+++ b/README.md
@@ -318,7 +318,7 @@ json_string = MovieSerializer.new([movie, movie], options).serialized_json
You can use `is_collection` option to have better control over collection serialization.
-If this option is not provided ... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 395 | issue_to_patch | Fix formatting of `set_id` example in README | Hey,
I fixed a formatting issue in the readme which was hiding some information. | cc7f88843a6306aefc9e3ab73499d306cea39fb2 | 0c1a0e050ab27562a05fa266a065b682957e50de | diff --git a/README.md b/README.md
index 53c8bfa7..eaf4caf2 100644
--- a/README.md
+++ b/README.md
@@ -450,7 +450,7 @@ Option | Purpose | Example
------------ | ------------- | -------------
set_type | Type name of Object | ```set_type :movie ```
key | Key of Object | ```belongs_to :owner, key: :user ```
-set_id | I... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 403 | issue_to_patch | Highlight that this is for JSON:API spec only | * The link was already there but I skipped over it on my first read.
This update makes the fact more prominent.
* I was testing to see if we wanted to move from AM Serializers to
fast_jsonapi but our API is not written according to the JSON:API spec
so, after converting one serializer over, I learned that this woul... | cc7f88843a6306aefc9e3ab73499d306cea39fb2 | 0a9c80817717d67afe3c805d659994667d551b4d | diff --git a/README.md b/README.md
index 53c8bfa7..b4ad5e4d 100644
--- a/README.md
+++ b/README.md
@@ -4,6 +4,10 @@
A lightning fast [JSON:API](http://jsonapi.org/) serializer for Ruby Objects.
+Note: this gem deals only with implementing the JSON:API spec. If your API
+responses are not formatted according to the... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 331 | issue_to_patch | Allow block for id customization | Allow an ID of object to be customized directly on the serializer by
passing a block to `set_id` as opposed to only through a model property.
We already allow for attributes that do not have a model property of the
same name to be customized directly on the serializer using a block.
Closes #315 | 11b5255010fe8ea6ea8971c0786fce8c4c5bbb1b | 0ba5f231fec2595593e51b02ed797efd7f87af87 | diff --git a/README.md b/README.md
index 0038b67c..0df2ba0c 100644
--- a/README.md
+++ b/README.md
@@ -427,7 +427,7 @@ Option | Purpose | Example
------------ | ------------- | -------------
set_type | Type name of Object | ```set_type :movie ```
key | Key of Object | ```belongs_to :owner, key: :user ```
-set_id | I... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_class_methods_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 347b1883..2c2ed6b5 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -195,28 +195,57 @@
describe '#set_id' do
subject(:seri... | true | |
Netflix/fast_jsonapi | 294 | issue_to_patch | Adds a :links option to the relationship macros | This allows specifying a `:links` option to a has_many/has_one relationship, which means you can specify `self` or `related` links as per the JSON API spec (these are often useful for not loading all associated objects in a single payload)
A few people have chatted about this option or various parts of it in issues ... | 11b5255010fe8ea6ea8971c0786fce8c4c5bbb1b | 1ad20d6b7be757755f696bc376374f6299d987e6 | diff --git a/README.md b/README.md
index 0038b67c..b86e4efc 100644
--- a/README.md
+++ b/README.md
@@ -245,15 +245,38 @@ class MovieSerializer
end
```
-### Meta Per Resource
-
-For every resource in the collection, you can include a meta object containing non-standard meta-information about a resource that can not ... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"spec/lib/object_serializer_relationship_links_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [
{
"comment": "I don't think the `&block` argument is used anywhere in the body?",
"path": "lib/fast_jsonapi/relationship.rb",
"hunk": "@@ -26,14 +27,16 @@ def initialize(\n @cached = cached\n @polymorphic = polymorphic\n @conditional_proc = conditional_proc\n+ @links = links || {}... | diff --git a/spec/lib/object_serializer_relationship_links_spec.rb b/spec/lib/object_serializer_relationship_links_spec.rb
new file mode 100644
index 00000000..8c2f2725
--- /dev/null
+++ b/spec/lib/object_serializer_relationship_links_spec.rb
@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+describe FastJsonapi::ObjectSerial... | true | |
Netflix/fast_jsonapi | 336 | issue_to_patch | Minor fix in README.md | Resolve minor typo: **link** to **links**. | ece607af5f19b8997c5fdb8e8bc005fff373ff21 | dbda6b615315e72e1e7e5a1781bf906a955e5c24 | diff --git a/README.md b/README.md
index 0038b67c..7b9671fb 100644
--- a/README.md
+++ b/README.md
@@ -221,7 +221,7 @@ end
```
### Links Per Object
-Links are defined in FastJsonapi using the `link` method. By default, link are read directly from the model property of the same name. In this example, `public_url` is... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 334 | issue_to_patch | require AS core extension for time | `5.minutes` was failing when i ran the performance spec | 11b5255010fe8ea6ea8971c0786fce8c4c5bbb1b | 05ad93084b28d89d9621e784c9eadec6664ed4f4 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 76caa7d1..c515b181 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -3,6 +3,7 @@
require 'active_support/json'
require 'active_support/concern'
require 'active_support/inf... | [
"lib/fast_jsonapi/object_serializer.rb"
] | [] | true | ||
Netflix/fast_jsonapi | 330 | issue_to_patch | Don't share data_links among inherited serializers. | As demonstrated by the included specs, if serializers share a common ancestor that defines data_links, they end up sharing the same data_links object, overwriting each other, so that the last-evaluated sub-class overwrites the others' data_links values. | 11b5255010fe8ea6ea8971c0786fce8c4c5bbb1b | be701f3e06ee1fec0399f4cead255f23a56a6458 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 76caa7d1..8d3ef03d 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -117,7 +117,7 @@ def inherited(subclass)
subclass.transform_method = transform_method
su... | [
"lib/fast_jsonapi/object_serializer.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 347b1883..c72a8f40 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -355,6 +355,22 @@ def year_since_release_calculator(release_ye... | true | |
Netflix/fast_jsonapi | 329 | issue_to_patch | Improve documentation with id_method_name | ```ruby
# invokes b_id_method on the resource of ASerializer, presumably one or more instances of A
ASerializer.has_many(:bs, id_method_name: :b_id_method)
# invokes b_id_method on each instance of `a.bs`, presumably instances of B
ASerializer.has_many(:bs, id_method_name: :b_id_method) do |a|
a.bs
end
```
... | f3368dee2d9e4b312ea68b9828715b87132a023f | 467024f8fd315a15e4f4ada98ec1fd920b30c9e7 | diff --git a/README.md b/README.md
index 0038b67c..1d4afbc8 100644
--- a/README.md
+++ b/README.md
@@ -429,7 +429,7 @@ set_type | Type name of Object | ```set_type :movie ```
key | Key of Object | ```belongs_to :owner, key: :user ```
set_id | ID of Object | ```set_id :owner_id ```
cache_options | Hash to enable cach... | [
"README.md",
"lib/fast_jsonapi/version.rb"
] | [] | true | ||
Netflix/fast_jsonapi | 326 | issue_to_patch | added spec for has_one-through relationship | I'm debugging an issue with [rabl](https://rubygems.org/gems/rabl) in combination with fast_jsonapi within a (private) Rails project.
It occurs when requiring the fast_jsonapi gem and has something to do with a has_one through relationship in the model being serialized, or with rabl and how it handles attributes, o... | 935fc05bebe9e46a1fe3a06e48535df34588638c | 9bff4548065ed6d490af93c78473bf68eab1043f | [
"spec/lib/extensions/active_record_spec.rb"
] | [] | diff --git a/spec/lib/extensions/active_record_spec.rb b/spec/lib/extensions/active_record_spec.rb
index e31ffe78..cbe7c1a5 100644
--- a/spec/lib/extensions/active_record_spec.rb
+++ b/spec/lib/extensions/active_record_spec.rb
@@ -71,3 +71,85 @@ class Account < ActiveRecord::Base
File.delete(@db_file) if File.exis... | true | ||
Netflix/fast_jsonapi | 342 | issue_to_patch | Release 1.5 | 92bcab0a3f00c029de525b3c8b9024a94325a22a | ee76e0c69b31528a223c57830ed178969b29b80b | diff --git a/README.md b/README.md
index 0038b67c..53c8bfa7 100644
--- a/README.md
+++ b/README.md
@@ -221,7 +221,7 @@ end
```
### Links Per Object
-Links are defined in FastJsonapi using the `link` method. By default, link are read directly from the model property of the same name. In this example, `public_url` is... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"lib/fast_jsonapi/version.rb",
"spec/lib/extensions/active_record_spec.rb",
"spec/lib/object_serializer_attribute_param_spec.rb",
"spec/lib/object_serializer_class_method... | [] | diff --git a/spec/lib/extensions/active_record_spec.rb b/spec/lib/extensions/active_record_spec.rb
index e31ffe78..cbe7c1a5 100644
--- a/spec/lib/extensions/active_record_spec.rb
+++ b/spec/lib/extensions/active_record_spec.rb
@@ -71,3 +71,85 @@ class Account < ActiveRecord::Base
File.delete(@db_file) if File.exis... | true | ||
Netflix/fast_jsonapi | 339 | issue_to_patch | Fix params not being hash by default | This fixes a minor thing that has been nagging at me for a while: I always had to do `params && params[:foo]` in an attribute block because params is undefined unless the controller explicitly passes it. I think we should be able to expect params to always be defined.
The bug occurs when no options are passed and th... | ece607af5f19b8997c5fdb8e8bc005fff373ff21 | d5ea95370f6c560d33fcad5acf8cba99bf5ffdef | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 8d3ef03d..6c56b2c0 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -1,5 +1,6 @@
# frozen_string_literal: true
+require 'active_support/time'
require 'active_support/json... | [
"lib/fast_jsonapi/object_serializer.rb",
"spec/lib/object_serializer_attribute_param_spec.rb",
"spec/lib/object_serializer_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [] | diff --git a/spec/lib/object_serializer_attribute_param_spec.rb b/spec/lib/object_serializer_attribute_param_spec.rb
index f92b9c76..3765a8cf 100644
--- a/spec/lib/object_serializer_attribute_param_spec.rb
+++ b/spec/lib/object_serializer_attribute_param_spec.rb
@@ -15,7 +15,7 @@ def viewed?(user)
class MovieS... | true | |
Netflix/fast_jsonapi | 283 | issue_to_patch | Fix confusing error when using include and no relationship was set | If you forgot to set any `has_many` in the serializer and tried to serialize with an `include` you would get:
```
NoMethodError (undefined method `[]' for nil:NilClass):
```
(no backtrace from the gem) That is not very helpful.
Setting the variable with a default case makes sure the right error message gets di... | 40125072c5c1712d98ad6d7894c133926a2cd8d1 | 0c34573b33e76bb9caa1b0fbd82d1e4f61b2bccb | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 7f740c8e..5b54d12d 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -275,7 +275,8 @@ def validate_includes!(includes)
includes.detect do |include_item|
kl... | [
"lib/fast_jsonapi/object_serializer.rb"
] | [] | true | ||
Netflix/fast_jsonapi | 313 | issue_to_patch | Fix set_key_transform's set_type to give priority to pre-set value | fixes #310 | 5a70b1a686d6e7c103030be02baf81c27fb01417 | 64f7b6c50d6104dee7b7957dfd518a01bf3f2277 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 183d622c..de010613 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -143,7 +143,11 @@ def set_key_transform(transform_name)
self.transform_method = mapping[transform... | [
"lib/fast_jsonapi/object_serializer.rb",
"spec/lib/object_serializer_class_methods_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 397ace5a..347b1883 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -411,4 +411,34 @@ def year_since_release_calculator(release_ye... | true | |
Netflix/fast_jsonapi | 312 | issue_to_patch | Do not use ActiveSupport core extensions | Core extensions often don't play well with many other gems... considering that they only seem to be included for one `to_json` call, it would probably be better to avoid using them altogether and call `ActiveSupport::JSON.encode` directly. | 955f4f234d0e6fa768c5457839d5d39d04bad26c | 843739dbeca56ceda2924dc273d861defebc874a | diff --git a/README.md b/README.md
index a03e1a8c..53cec7b8 100644
--- a/README.md
+++ b/README.md
@@ -221,7 +221,7 @@ end
```
### Links Per Object
-Links are defined in FastJsonapi using the `link` method. By default, link are read directly from the model property of the same name.In this example, `public_url` is ... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb"
] | [] | true | ||
Netflix/fast_jsonapi | 306 | issue_to_patch | Support polymorphic includes | This PR adds support for polymorphic includes. It should fix issue https://github.com/Netflix/fast_jsonapi/issues/231 (and duplicate issue https://github.com/Netflix/fast_jsonapi/issues/266).
Also, there is some inconsistency regarding what value should be returned for the `type` key when an object belongs to a name... | 42d92037960d9ba3a5b5b97f7be80a33ca98098b | 7543b91c012aa4e59cf66aad6c092a77e1ff82a8 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index afab5773..26a4f95f 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -295,8 +295,7 @@ def validate_includes!(includes)
relationships_to_serialize = klass.relation... | [
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 236cf8da..85f4a79d 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -278,10 +278,24 @@ def advertising_campaign
end
end
- it 'polymorphic throws an error that polymorphi... | true | |
Netflix/fast_jsonapi | 299 | issue_to_patch | add the option "key" in customizable options in the README | There is an option called "key" that does not exist in the documentation. I had to look in the code to know that it exists. With this option, you can change the json object key.
`belongs_to: owner, key: :user `
```
{
"data": {
"id": "3",
"type": "movie",
"attributes": {
"name": "test mov... | a5414c6b8f92dd564cc4350591c2ea3bbddd96f5 | ce2c8003eebf715058f17ce3b849d3c1f6510b88 | diff --git a/README.md b/README.md
index a03e1a8c..8b402733 100644
--- a/README.md
+++ b/README.md
@@ -409,6 +409,7 @@ serializer.serializable_hash
Option | Purpose | Example
------------ | ------------- | -------------
set_type | Type name of Object | ```set_type :movie ```
+key | Key of Object | ```belongs_to :own... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 288 | issue_to_patch | Fix weak entities case (id is not meaningful attribute) with include. | The problem occurs if the entity has `id` method, but it's not a primary key and not the id for the serializers, i.e. `set_id` was used, e.g. if you use sequel and have a weak entity, who's primary key is not id. In this case `id` method will return `nil`. During serialization `nil` returned from `id` is used for dupli... | a5414c6b8f92dd564cc4350591c2ea3bbddd96f5 | 1dc1f280c9133126c34dd9c73f671125b2173c8f | diff --git a/lib/fast_jsonapi/serialization_core.rb b/lib/fast_jsonapi/serialization_core.rb
index 8598fe0e..e64bf1ae 100644
--- a/lib/fast_jsonapi/serialization_core.rb
+++ b/lib/fast_jsonapi/serialization_core.rb
@@ -134,7 +134,7 @@ def get_included_records(record, includes_list, known_included_objects, fieldset
... | [
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 06aac377..236cf8da 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -158,6 +158,32 @@
end
end
+ context 'id attribute is the same for actors and not a primary key' do
+ bef... | true | |
Netflix/fast_jsonapi | 286 | issue_to_patch | [ci skip] Fix punctuation | 5ff3fa97dae4b6be51bf8ec315cb427667c4ce96 | 71a6921ea50718d38198902fedc34fe59d0a468c | diff --git a/README.md b/README.md
index a03e1a8c..53cec7b8 100644
--- a/README.md
+++ b/README.md
@@ -221,7 +221,7 @@ end
```
### Links Per Object
-Links are defined in FastJsonapi using the `link` method. By default, link are read directly from the model property of the same name.In this example, `public_url` is ... | [
"README.md"
] | [] | true | |||
Netflix/fast_jsonapi | 285 | issue_to_patch | Fixed conditional attributes documentation | See #284 | 40125072c5c1712d98ad6d7894c133926a2cd8d1 | ca16a903577dc9b5b503d7a5860d645e12e79bfa | diff --git a/README.md b/README.md
index f4333d19..0d2162fd 100644
--- a/README.md
+++ b/README.md
@@ -338,15 +338,15 @@ class MovieSerializer
include FastJsonapi::ObjectSerializer
attributes :name, :year
- attribute :release_year, if: Proc.new do |record|
+ attribute :release_year, if: Proc.new { |record|
... | [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 281 | issue_to_patch | Add missing fieldset parameter | Apologies I missed this on #271. Should address any weird bug it might have introduced. | 3df48cd4cb7bdaf127b3eb8eee7a2b25d93d75ad | cebd32578d5dff0e4c50d41db7c424a438fa9f1c | diff --git a/lib/fast_jsonapi/serialization_core.rb b/lib/fast_jsonapi/serialization_core.rb
index 6ec069a9..86a39f13 100644
--- a/lib/fast_jsonapi/serialization_core.rb
+++ b/lib/fast_jsonapi/serialization_core.rb
@@ -67,7 +67,7 @@ def record_hash(record, fieldset, params = {})
temp_hash[:links] = links_h... | [
"lib/fast_jsonapi/serialization_core.rb"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.