repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
OpenCut-app/OpenCut
788
issue_to_patch
feat: display keyboard shortcuts on toolbar buttons
## Changes Made ### Modified Files - `apps/web/src/timeline/components/timeline-toolbar.tsx` - `apps/web/src/preview/components/toolbar.tsx` ### Features Implemented #### Timeline Toolbar Shortcuts | Button | Shortcut | Action | |--------|----------|--------| | Split element | **S** | split | | Split le...
fbe3db74d70c350f893ee5be198e4b324684b143
7b9d2718ed8499cb716af439ce24297c87ca14ee
diff --git a/apps/web/src/preview/components/toolbar.tsx b/apps/web/src/preview/components/toolbar.tsx index 1a5ce1bc6..ba195c9d3 100644 --- a/apps/web/src/preview/components/toolbar.tsx +++ b/apps/web/src/preview/components/toolbar.tsx @@ -4,6 +4,7 @@ import { useState, useEffect } from "react"; import { useEditor } ...
[ "apps/web/src/preview/components/toolbar.tsx", "apps/web/src/timeline/components/timeline-toolbar.tsx" ]
[]
true
OpenCut-app/OpenCut
753
issue_to_patch
[SECURITY] Function constructor in math.ts enables potential code injection ## Description `apps/web/src/utils/math.ts` (lines 25-39) uses `new Function()` to evaluate math expressions. While the current regex validation (`/^[\d.\s+\-*/()]+$/`) is reasonably tight, using the Function constructor is inherently dangerou...
fix(security): replace new Function() with safe math expression parser
## Summary Fixes #725 by replacing the dangerous `new Function()` constructor in `evaluateMathExpression()` with a safe recursive descent parser. ## Problem The `evaluateMathExpression` function in `apps/web/src/utils/math.ts` used `new Function()` to evaluate math expressions. While the current regex validation is ...
5777a555f60b780b7db430fa7bfa66a3bcb2623f
7c3159f741dbe7bb60566c023ba5a7044b279271
diff --git a/apps/web/src/utils/math.ts b/apps/web/src/utils/math.ts index 8043871f7..45196b021 100644 --- a/apps/web/src/utils/math.ts +++ b/apps/web/src/utils/math.ts @@ -1,115 +1,276 @@ -export function clamp({ - value, - min, - max, -}: { - value: number; - min: number; - max: number; -}): number { - retur...
[ "apps/web/src/utils/__tests__/math.test.ts", "apps/web/src/utils/math.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In JavaScript, what do Number.parseFloat(\"1..2\") and Number(\"1..2\") return, and why?`\n\n💡 Result:\n\nNumber.parseFloat(\"1..2\") returns 1, while Number(\"1..2\") returns NaN. parseFl...
diff --git a/apps/web/src/utils/__tests__/math.test.ts b/apps/web/src/utils/__tests__/math.test.ts new file mode 100644 index 000000000..4bdb959f9 --- /dev/null +++ b/apps/web/src/utils/__tests__/math.test.ts @@ -0,0 +1,120 @@ +import { describe, expect, it } from "bun:test"; +import { evaluateMathExpression } from ".....
true
OpenCut-app/OpenCut
753
comment_to_fix
fix(security): replace new Function() with safe math expression parser
_⚠️ Potential issue_ | _🔴 Critical_ <details> <summary>🧩 Analysis chain</summary> 🌐 Web query: `In JavaScript, what do Number.parseFloat("1..2") and Number("1..2") return, and why?` 💡 Result: Number.parseFloat("1..2") returns 1, while Number("1..2") returns NaN. parseFloat parses the string from the beginning,...
5777a555f60b780b7db430fa7bfa66a3bcb2623f
7c3159f741dbe7bb60566c023ba5a7044b279271
diff --git a/apps/web/src/utils/math.ts b/apps/web/src/utils/math.ts index 8043871f7..45196b021 100644 --- a/apps/web/src/utils/math.ts +++ b/apps/web/src/utils/math.ts @@ -1,115 +1,276 @@ -export function clamp({ - value, - min, - max, -}: { - value: number; - min: number; - max: number; -}): number { - retur...
[ "apps/web/src/utils/math.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In JavaScript, what do Number.parseFloat(\"1..2\") and Number(\"1..2\") return, and why?`\n\n💡 Result:\n\nNumber.parseFloat(\"1..2\") returns 1, while Number(\"1..2\") returns NaN. parseFl...
true
OpenCut-app/OpenCut
741
issue_to_patch
Fix OpenCut logo in README
ik that this isn't a critical bug, but the logo wasn't showing in the readme <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated the project header image reference in README. <!-- end of auto-generated comment: release notes by coderabb...
26d523ebad3dfdcb682db049899ada84ac739ed7
cfc9b4e2df53d4e4bd0dcbe1ed54f54cf0d89932
diff --git a/README.md b/README.md index cacc4555c..9e9a8d666 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ <table width="100%"> <tr> <td align="left" width="120"> - <img src="apps/web/public/logos/opencut/1k/logo-white-black.png" alt="OpenCut Logo" width="100" /> + <img src="apps/web/public...
[ "README.md" ]
[]
true
OpenCut-app/OpenCut
711
issue_to_patch
feat(projects): add right-click context menu to project cards
## Summary Adds a right-click context menu to project cards on the projects page. ## Changes - Add context menu with Rename, Duplicate, Info, Delete actions - Works in both grid and list view - Uses existing Radix UI ContextMenu components - Mirrors actions from the existing ProjectMenu dropdown ## How to te...
4d77e3f2bb9884ad9e43761eaf0ede8c1a9cfccc
097891b5e69b43c3594667ccddbdc01712c97131
diff --git a/apps/web/src/app/projects/page.tsx b/apps/web/src/app/projects/page.tsx index b855cefc0..a86cf775c 100644 --- a/apps/web/src/app/projects/page.tsx +++ b/apps/web/src/app/projects/page.tsx @@ -46,6 +46,13 @@ import { } from "@hugeicons/core-free-icons"; import { OcVideoIcon } from "@opencut/ui/icons"; im...
[ "apps/web/src/app/projects/page.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Context menu ignores multi‑select state.**\nWhen multiple projects are selected, the per-item `ProjectMenu` is hidden, but the context menu still allows single-item actions. Consider gating the context menu or swapping to bulk actions in multi-select mode.\n\...
true
OpenCut-app/OpenCut
707
issue_to_patch
chore: improve accessibility and security
## Accessibility & Security Improvements ### Changes - ♿ Improve hero image alt text for screen readers - 🔐 Add `noreferrer` to external links (security best practice) - 📅 Update roadmap date to Feb 2026 ### Impact - No breaking changes - Better a11y compliance - Enhanced security posture ### Files Ch...
fca99d6126c31fbb18ed9f1034cee6f940b040e8
c0268543156b0e1743510a2bb0b292614b91c90a
diff --git a/apps/web/src/app/privacy/page.tsx b/apps/web/src/app/privacy/page.tsx index b71b8d305..4b06405a5 100644 --- a/apps/web/src/app/privacy/page.tsx +++ b/apps/web/src/app/privacy/page.tsx @@ -166,7 +166,7 @@ export default function PrivacyPage() { <a href="https://www.databuddy.cc" target="...
[ "apps/web/src/app/privacy/page.tsx", "apps/web/src/app/roadmap/page.tsx", "apps/web/src/components/landing/hero.tsx" ]
[ { "comment": "Thank you!", "path": "apps/web/src/components/landing/hero.tsx", "hunk": "@@ -14,7 +14,7 @@ export function Hero() {\n \t\t\t\tsrc=\"/landing-page-dark.png\"\n \t\t\t\theight={1903.5}\n \t\t\t\twidth={1269}\n-\t\t\t\talt=\"landing-page.bg\"\n+\t\t\t\talt=\"OpenCut video editor landing page...
true
OpenCut-app/OpenCut
707
comment_to_fix
chore: improve accessibility and security
Thank you!
fca99d6126c31fbb18ed9f1034cee6f940b040e8
c0268543156b0e1743510a2bb0b292614b91c90a
diff --git a/apps/web/src/components/landing/hero.tsx b/apps/web/src/components/landing/hero.tsx index 6f11ad7ca..a8f3f70df 100644 --- a/apps/web/src/components/landing/hero.tsx +++ b/apps/web/src/components/landing/hero.tsx @@ -14,7 +14,7 @@ export function Hero() { src="/landing-page-dark.png" height={1903....
[ "apps/web/src/components/landing/hero.tsx" ]
[ { "comment": "Thank you!", "path": "apps/web/src/components/landing/hero.tsx", "hunk": "@@ -14,7 +14,7 @@ export function Hero() {\n \t\t\t\tsrc=\"/landing-page-dark.png\"\n \t\t\t\theight={1903.5}\n \t\t\t\twidth={1269}\n-\t\t\t\talt=\"landing-page.bg\"\n+\t\t\t\talt=\"OpenCut video editor landing page...
true
OpenCut-app/OpenCut
686
issue_to_patch
Minor wording improvement for clarity
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking chang...
0173db99448d1c4c6415dcf15272e17551b48b04
a315ca6c1801772d2afe881c19c0d6beea8979a4
diff --git a/README.md b/README.md index 1e40f1db8..862835cdc 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ ## Why? - **Privacy**: Your videos stay on your device -- **Free features**: Every basic feature of CapCut is paywalled now +- **Free features**: Most basic CapCut features are now paywalled - **...
[ "README.md" ]
[]
true
OpenCut-app/OpenCut
699
issue_to_patch
Github readme logo fix.
Fixed a broken image reference in the README by restoring the Opencut logo file that had been previously deleted. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated the project logo in the README for improved visual presentation. <sub>...
7bf0984698e43b9aa2dd879f65951318ed410390
7526b9cd1cbcfef3edf73fb3ef53c4d8f54f6904
diff --git a/README.md b/README.md index d0421dd5d..98519cc38 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ <table width="100%"> <tr> <td align="left" width="120"> - <img src="apps/web/public/logos/opencut/1k/logo.png" alt="OpenCut Logo" width="100" /> + <img src="apps/web/public/logos/openc...
[ "README.md", "apps/web/public/logos/opencut/1k/logo-white-black.png" ]
[]
true
OpenCut-app/OpenCut
437
issue_to_patch
feat/Bug solved: implement smooth text dragging with boundary constraints Closes(#425)
### `feat(editor)/Bug solved: Implement smooth and constrained text dragging` Closes **#425** --- ### Description This pull request introduces a smooth, performant, and constrained dragging experience for text elements in the `PreviewPanel`. It addresses the need for better user interaction with text, maki...
b0bcca18f8ef8a42db084b0f8f06dcd2782b6bda
b87f470dc4716d267f618df14461d2c85d92a7b4
diff --git a/apps/web/src/components/editor/preview-panel.tsx b/apps/web/src/components/editor/preview-panel.tsx index 2cba13749..2359ecd83 100644 --- a/apps/web/src/components/editor/preview-panel.tsx +++ b/apps/web/src/components/editor/preview-panel.tsx @@ -31,7 +31,7 @@ interface ActiveElement { } export functi...
[ "apps/web/src/components/editor/preview-panel.tsx" ]
[]
true
OpenCut-app/OpenCut
572
issue_to_patch
fix: use svh to prevent hero mobile layout shift
## Description This PR fixes the hero layout height calculation. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause e...
03e68e77a98512ad66ea91aedfa7ece7fad60683
52a8b8388b16abc8d85637b0ee56504df6487a9f
diff --git a/README.md b/README.md index 99ab706e2..6de558f9e 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ <img src="apps/web/public/logo.png" alt="OpenCut Logo" width="100" /> </td> <td align="right"> - <h1>OpenCut <span style="font-size: 0.7em; font-weight: normal;">(prev AppCut)</span...
[ "README.md", "apps/web/src/components/landing/hero.tsx" ]
[]
true
OpenCut-app/OpenCut
565
issue_to_patch
fix(editor): Don't log expected errors in `AudioWaveform` during unmount
## Description Currently, an error is logged whenever there is an audio layer in the development environment. <img width="1916" height="1020" alt="Image" src="https://github.com/user-attachments/assets/d7aef868-b36a-4037-8a43-7ebe8392242e" /> <img width="1908" height="1022" alt="Image" src="https://github.com/us...
a4f2273e25995be234f20fb1c40d410620706e20
c480c5c1df8ea1a1d26bf045b3e2fb4ee1e7743e
diff --git a/README.md b/README.md index 99ab706e2..6de558f9e 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ <img src="apps/web/public/logo.png" alt="OpenCut Logo" width="100" /> </td> <td align="right"> - <h1>OpenCut <span style="font-size: 0.7em; font-weight: normal;">(prev AppCut)</span...
[ "README.md", "apps/web/src/components/editor/audio-waveform.tsx" ]
[ { "comment": "_💡 Verification agent_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Replace console.error with a project logger (console usage is disallowed by guidelines).**\n\nPer repository guidelines for JS/TS files, avoid console.*. Keep the mounted guard, but route errors through a logger or err...
true
OpenCut-app/OpenCut
498
issue_to_patch
Upgrade to Tailwind CSS v4
## Description This PR upgrades OpenCut to Tailwind CSS v4. ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) - [x] Performance improvement - [x] Code refactoring ## How Has This Been Tested? Please describe the tests that...
10afbda9ddd3c4a7160a9ec381ee9ae5ebcf6a94
cd5642161b117fd5cb707cf9d405176459d9f37c
diff --git a/apps/web/components.json b/apps/web/components.json index 405a08cd6..3289f237a 100644 --- a/apps/web/components.json +++ b/apps/web/components.json @@ -4,7 +4,7 @@ "rsc": true, "tsx": true, "tailwind": { - "config": "tailwind.config.ts", + "config": "", "css": "src/app/globals.css", ...
[ "apps/web/components.json", "apps/web/package.json", "apps/web/postcss.config.mjs", "apps/web/src/app/blog/[slug]/page.tsx", "apps/web/src/app/blog/page.tsx", "apps/web/src/app/contributors/page.tsx", "apps/web/src/app/globals.css", "apps/web/src/app/privacy/page.tsx", "apps/web/src/app/projects/pag...
[ { "comment": "_💡 Verification agent_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Verify that `bg-linear-to-*` utilities exist**\n\nTailwind’s core preset (v4.1.11) does not expose `bg-linear-to-br` / `bg-linear-to-tr`. Unless you registered custom utilities (e.g. via `@layer utilities` in `globals....
true
OpenCut-app/OpenCut
561
issue_to_patch
feat(rename-modal): enhance input visibility in dark theme with border
## Description Enhanced the input visibility in the rename modal by adding a border in dark theme. This improves user experience and accessibility by ensuring the input field is clearly distinguishable from the background. Relates to: UI refinement for dark mode support. ## Type of change - [x] New feature (non...
f750c457651e80ae96a6828f94f24ab98c66a36b
e3bb998c91794c8b0468c18f010af784fecd9fa8
diff --git a/apps/web/src/components/rename-project-dialog.tsx b/apps/web/src/components/rename-project-dialog.tsx index c50f9f71a..dd8dfcc49 100644 --- a/apps/web/src/components/rename-project-dialog.tsx +++ b/apps/web/src/components/rename-project-dialog.tsx @@ -51,7 +51,7 @@ export function RenameProjectDialog({ ...
[ "apps/web/src/components/rename-project-dialog.tsx" ]
[]
true
OpenCut-app/OpenCut
563
issue_to_patch
[BUG] Landing page navbar padding Is uneven ### Platform All ### Browser All ### Current Behavior Discovered a critical bug on the landing page navigation bar. The pr-[14px] value is not correct, it adds too much distance between the "Projects" button and the border, messing up the visual balance of this element....
fix: adjust padding in HeaderBase for landing page
## Description Fixes https://github.com/OpenCut-app/OpenCut/issues/562 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? Tested locally. ## Screenshots (if applicable) <img width="910" height="885" alt="opencutnavbar" src="https://github.com/use...
756a7c7caaeada4fff9a51f2ec4fe2968ac3b01e
e735db07cb1ac6ab188c52ecbf509788bfc2f9f9
diff --git a/README.md b/README.md index 99ab706e2..6de558f9e 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ <img src="apps/web/public/logo.png" alt="OpenCut Logo" width="100" /> </td> <td align="right"> - <h1>OpenCut <span style="font-size: 0.7em; font-weight: normal;">(prev AppCut)</span...
[ "README.md", "apps/web/src/components/header.tsx" ]
[]
true
OpenCut-app/OpenCut
553
issue_to_patch
fix: stickers panel
## Description Nothing was broken to be "unusable", but improvements have been made: - Stickers now resize dynamically, fitting perfectly in the panel (with size cap) - All tab is now scrollable, displaying all the collections - Search bar placeholders now display correctly according to the tab you're on - If you ...
a0f8e2c1a739b69690f7fc6f08294006295c87ad
f52c75ed048815d5a4b7f0b5bcb99acc35ad50d2
diff --git a/apps/web/src/components/editor/media-panel/views/stickers.tsx b/apps/web/src/components/editor/media-panel/views/stickers.tsx index 937a968e3..7d3e073e3 100644 --- a/apps/web/src/components/editor/media-panel/views/stickers.tsx +++ b/apps/web/src/components/editor/media-panel/views/stickers.tsx @@ -80,25 +...
[ "apps/web/src/components/editor/media-panel/views/stickers.tsx", "apps/web/src/components/ui/draggable-item.tsx" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Good integration of setSelectedCategory; add `type=\"button\"` and align wording with “All Collections”**\n\n- The store setter is correctly wired to enable switching to the All tab.\n- Add `type=\"button\"` to the new Button to satisfy the button-type guideline and ...
true
OpenCut-app/OpenCut
552
issue_to_patch
fix: footer icon
## Description Simply changed the OpenCut icon in the footer to be dark when in light mode. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [X] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? Please describe the tests that you ran to ...
f4e127f2d4fb8e50555be0104f7a5844fb0e2aa3
52bd8c55e48a27a1c41eabc0a05694d0fa0ed80b
diff --git a/apps/web/src/components/footer.tsx b/apps/web/src/components/footer.tsx index a7aa724f4..0087502e4 100644 --- a/apps/web/src/components/footer.tsx +++ b/apps/web/src/components/footer.tsx @@ -36,7 +36,13 @@ export function Footer() { {/* Brand Section */} <div className="md:col-span-1...
[ "apps/web/src/components/footer.tsx" ]
[]
true
OpenCut-app/OpenCut
510
issue_to_patch
[BUG] ### Platform Windows 11 ### Browser Chrome ### Current Behavior ### Current Behavior - Background color persists once set - No intuitive way to remove it https://github.com/user-attachments/assets/06623040-99a6-4e83-bdf3-47f08288ae52 ## Bug: Cannot Remove Background Color After Setting It ### Problem Onc...
fix: enable removing background color in text back to transparent and remember last selection
## Improved Background Color Management closes #509 ### What's New - Fixed issue where background color couldn't be removed after being set - Added proper toggle between colored and transparent backgrounds - Now remembers your last selected color when toggling ### Before - Once you set a background color, ...
1b1486ad940c33db8efc3955329ee49e36d58d55
36c96682de2e2cc0a832c16dd2f505585e7f1b72
diff --git a/apps/web/src/components/editor/properties-panel/text-properties.tsx b/apps/web/src/components/editor/properties-panel/text-properties.tsx index a06624eb2..744c2be50 100644 --- a/apps/web/src/components/editor/properties-panel/text-properties.tsx +++ b/apps/web/src/components/editor/properties-panel/text-pr...
[ "apps/web/src/components/editor/properties-panel/text-properties.tsx" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Initialize ref with current background color if available.**\n\nThe ref initialization should consider the element's existing background color to avoid losing the current color state.\n\n\n\n```diff\n // Track the last selected color for toggling\n- const lastSelect...
true
OpenCut-app/OpenCut
510
comment_to_fix
fix: enable removing background color in text back to transparent and remember last selection
_🛠️ Refactor suggestion_ **Initialize ref with current background color if available.** The ref initialization should consider the element's existing background color to avoid losing the current color state. ```diff // Track the last selected color for toggling - const lastSelectedColor = useRef("#000000"); + c...
1b1486ad940c33db8efc3955329ee49e36d58d55
36c96682de2e2cc0a832c16dd2f505585e7f1b72
diff --git a/apps/web/src/components/editor/properties-panel/text-properties.tsx b/apps/web/src/components/editor/properties-panel/text-properties.tsx index a06624eb2..744c2be50 100644 --- a/apps/web/src/components/editor/properties-panel/text-properties.tsx +++ b/apps/web/src/components/editor/properties-panel/text-pr...
[ "apps/web/src/components/editor/properties-panel/text-properties.tsx" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Initialize ref with current background color if available.**\n\nThe ref initialization should consider the element's existing background color to avoid losing the current color state.\n\n\n\n```diff\n // Track the last selected color for toggling\n- const lastSelect...
true
OpenCut-app/OpenCut
520
issue_to_patch
made header sticky on scroll (#519)
closing: #519 attached a screenrecording 😄 Do merge it, really wanna contribute to this, this is just the starting, will be adding more and more values to OpenCut! @mazeincoding https://github.com/user-attachments/assets/2136df41-308d-4d86-8f02-6ba05e6e6794 <!-- This is an auto-generated comment: release...
7e4cd767622e3e1a09e76770ce800f4a541cf0e8
8be094dab6dbc57013f62cf86a48bb566683d85f
diff --git a/apps/web/src/components/header.tsx b/apps/web/src/components/header.tsx index bed04a27c..4d68efb28 100644 --- a/apps/web/src/components/header.tsx +++ b/apps/web/src/components/header.tsx @@ -9,7 +9,13 @@ import Image from "next/image"; export function Header() { const leftContent = ( <Link href="...
[ "apps/web/src/components/header.tsx" ]
[]
true
OpenCut-app/OpenCut
530
issue_to_patch
feat: add an input so the user can go to a specific timestamp
## Description Adds an editable field where the user can input a timecode, moving the timeline to that specific frame. For visual coherence, also removed one of the timestamps (the editor displays time in two places, now it only does next to the play button). ## Type of change Please delete options that are no...
033a9aa1bcc06ee82d611ac2c7deb5575c2fa803
d602981048b7f526f5b11b307b31effc38d17d69
diff --git a/apps/web/src/components/editor-header.tsx b/apps/web/src/components/editor-header.tsx index 98aec2b90..88deaf0cd 100644 --- a/apps/web/src/components/editor-header.tsx +++ b/apps/web/src/components/editor-header.tsx @@ -1,17 +1,8 @@ "use client"; import { Button } from "./ui/button"; -import { - Chevr...
[ "apps/web/src/components/editor-header.tsx", "apps/web/src/components/editor/preview-panel.tsx", "apps/web/src/components/editor/timeline/index.tsx", "apps/web/src/components/editor/timeline/timeline-track.tsx", "apps/web/src/components/ui/editable-timecode.tsx", "apps/web/src/hooks/use-editor-actions.ts"...
[]
true
OpenCut-app/OpenCut
539
issue_to_patch
feat: stickers panel
## Description This PR includes the stickers panel from the Iconify API. You can browse, search, and add the stickers to your OpenCut project. Fixes # (issue) No existing issues were fixed. ## Type of change Please delete options that are not relevant. - [X] New feature (non-breaking change which adds f...
0274fb662647630803598e01c975e6b1439922ab
d73c11c9b1ee6816c24f6d6a4a3782799dcab3d9
diff --git a/apps/web/next.config.ts b/apps/web/next.config.ts index 5142905bc..cd79efb74 100644 --- a/apps/web/next.config.ts +++ b/apps/web/next.config.ts @@ -32,7 +32,15 @@ const nextConfig: NextConfig = { }, { protocol: "https", - hostname: "res.cloudinary.com", + hostname: "api...
[ "apps/web/next.config.ts", "apps/web/src/app/animation/page.tsx", "apps/web/src/components/editor/media-panel/index.tsx", "apps/web/src/components/editor/media-panel/views/media.tsx", "apps/web/src/components/editor/media-panel/views/sounds.tsx", "apps/web/src/components/editor/media-panel/views/stickers....
[ { "comment": "_⚠️ Potential issue_\n\n**Replace <img> with Next.js <Image> per project guidelines and to enable optimizations**\n\nOrganizational standard: “Don’t use <img> elements in Next.js projects.” Switch to next/image and add the import. For SVGs from remote hosts, set unoptimized and ensure hosts are pe...
true
OpenCut-app/OpenCut
522
issue_to_patch
fix: improve keyboard shortcuts dialog scrolling behavior and cursor
fix: improve keyboard shortcuts dialog scrolling and interaction **Problem:** - The entire keyboard shortcuts dialog was scrolling, including the header and footer - The close button didn't show a pointer cursor, making it less obvious it was clickable - The layout had inconsistent spacing and padding **Soluti...
7f91c9ca00cd51bea1cd1e97eeb3c58b7e7a1bae
a88d42f25827b5adf1fc6f7eebabf73b962a814f
diff --git a/apps/web/src/components/keyboard-shortcuts-help.tsx b/apps/web/src/components/keyboard-shortcuts-help.tsx index d4d121d91..fd0af8377 100644 --- a/apps/web/src/components/keyboard-shortcuts-help.tsx +++ b/apps/web/src/components/keyboard-shortcuts-help.tsx @@ -199,8 +199,8 @@ export const KeyboardShortcutsH...
[ "apps/web/src/components/keyboard-shortcuts-help.tsx", "apps/web/src/components/ui/dialog.tsx" ]
[]
true
OpenCut-app/OpenCut
550
issue_to_patch
fix: changed mute track icon to more understandable ones
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Changed icons for the mute track button so it fits more the context. Changed from a microphone to a speaker/volume Fixes # (issue) ## Type of change Please delete options that ...
0274fb662647630803598e01c975e6b1439922ab
4b1a27f511453c328755a334b83cc5c27877152d
diff --git a/apps/web/src/components/editor/timeline/index.tsx b/apps/web/src/components/editor/timeline/index.tsx index 8bb20d728..d8ab2b85d 100644 --- a/apps/web/src/components/editor/timeline/index.tsx +++ b/apps/web/src/components/editor/timeline/index.tsx @@ -21,8 +21,8 @@ import { ZoomOut, Bookmark, Eye,...
[ "apps/web/src/components/editor/timeline/index.tsx" ]
[]
true
OpenCut-app/OpenCut
501
issue_to_patch
[FEATURE] Return to start of Timeline ### Problem I usually want to return to start of Timeline when working on a project, but it can be frustrating if I'm focused on an area of the Timeline that's far from 00:00:00. Examples: - I'm zoomed in and working on details in a specific area - I'm scrolled way down the time...
Feat/timeline return to start
- Add Enter key shortcut for seeking to timeline start (00:00:00) - Add return to start button in timeline toolbar with skip-back icon - Both methods complement existing Home key shortcut - Update keyboard shortcuts help to display Enter key properly - Maintain consistent UI styling with existing playback controls ...
f7fddff1fc8359fc056a2a90488121980fb8ead2
0274fb662647630803598e01c975e6b1439922ab
diff --git a/apps/web/src/components/editor/timeline/index.tsx b/apps/web/src/components/editor/timeline/index.tsx index 8bb20d728..d8261d9bb 100644 --- a/apps/web/src/components/editor/timeline/index.tsx +++ b/apps/web/src/components/editor/timeline/index.tsx @@ -12,6 +12,7 @@ import { SplitSquareHorizontal, Pau...
[ "apps/web/src/components/editor/timeline/index.tsx", "apps/web/src/hooks/use-keyboard-shortcuts-help.ts", "apps/web/src/stores/__tests__/keybindings-store.test.ts", "apps/web/src/stores/keybindings-store.ts" ]
[ { "comment": "_⚠️ Potential issue_\n\n**Replace `__dirname` with ES module alternative.**\n\nThe coding guidelines prohibit using `__dirname` in the global scope. Use `import.meta.url` instead for ES modules.\n\n\n\nApply this diff to fix the issue:\n\n```diff\n- '@': resolve(__dirname, './src'),\n+ '...
diff --git a/apps/web/src/stores/__tests__/keybindings-store.test.ts b/apps/web/src/stores/__tests__/keybindings-store.test.ts new file mode 100644 index 000000000..8aa5b94f6 --- /dev/null +++ b/apps/web/src/stores/__tests__/keybindings-store.test.ts @@ -0,0 +1,65 @@ +import { describe, it, expect, beforeEach } from 'v...
true
OpenCut-app/OpenCut
537
issue_to_patch
Fix missing package on fresh installation
## Description Running `bun dev` on fresh installation yields error due to missing package ``` OpenCut/apps/web git:main ❯ bun dev $ next dev ▲ Next.js 15.4.5 - Local: http://localhost:3000 - Network: http://192.168.86.23:3000 - Environments: .env.local ✓ Starting... It looks lik...
f9aab490808c550c37404992b7ee6f99a1d4a40e
4c171818c3e37e283e724b7f8b18e549dcd3195d
diff --git a/apps/web/package.json b/apps/web/package.json index 48a211db1..a794741dd 100644 --- a/apps/web/package.json +++ b/apps/web/package.json @@ -75,6 +75,7 @@ "@tailwindcss/postcss": "^4.1.11", "@tailwindcss/typography": "^0.5.16", "@types/bun": "latest", + "@types/node": "^24.2.1", "@typ...
[ "apps/web/package.json", "bun.lock" ]
[]
true
OpenCut-app/OpenCut
544
issue_to_patch
fix hero-bg image link
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Fixed broken Hero Image link by renaming ``/landing-page-bg.png`` to right one ``/landing-page-dark.png`` Fixes # (issue) #543 ## Type of change Please delete options that ...
a97eb26fa4552df520f26bbacfaa44d1f8faff3d
6c8c91ee54c43158665b973dfdbf5df4ddfaae5e
diff --git a/apps/web/src/components/landing/hero.tsx b/apps/web/src/components/landing/hero.tsx index 892fbfa9e..5c6294330 100644 --- a/apps/web/src/components/landing/hero.tsx +++ b/apps/web/src/components/landing/hero.tsx @@ -15,7 +15,7 @@ export function Hero() { <div className="min-h-[calc(100vh-4.5rem)] supp...
[ "apps/web/src/components/landing/hero.tsx" ]
[ { "comment": "_💡 Verification agent_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Confirm Tailwind class “opacity-85” exists in your theme.**\n\nTailwind’s default palette doesn’t include 85; ensure you’ve extended opacity or this class will be a no-op.\n\n---\n\n🏁 Script executed:\n\n```shell\n#!/...
true
OpenCut-app/OpenCut
542
issue_to_patch
when you click play and the playhead is at the end of the timeline, play from beginning exactly what the title says
feat(playback): restart from beginning when play pressed at end of timeline (Fixes #536)
## Description When Play (or Space) is pressed while the playhead is at the end of the timeline, playback now restarts from the beginning (time 0) and continues playing. * Compute effectiveDuration from the actual timeline content duration (useTimelineStore.getTotalDuration()) with a fallback to the store’s durat...
38f82767884250fe7c9e99672d06cb59ac957cd0
03e5c155138cfae6d90c134c0c0c2abe1dc3b09e
diff --git a/apps/web/src/stores/playback-store.ts b/apps/web/src/stores/playback-store.ts index feea0f46e..a92cb5307 100644 --- a/apps/web/src/stores/playback-store.ts +++ b/apps/web/src/stores/playback-store.ts @@ -82,6 +82,24 @@ export const usePlaybackStore = create<PlaybackStore>((set, get) => ({ speed: 1.0, ...
[ "apps/web/src/stores/playback-store.ts" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Harden FPS handling: validate finite, > 0; fall back to 30**\n\nDefensively guard against invalid FPS (0, NaN, Infinity). Today, 0 would yield Infinity frameOffset, which degrades end detection. Use a robust fallback.\n\n\n\n```diff\n- const fps = useProjectStor...
true
OpenCut-app/OpenCut
542
comment_to_fix
feat(playback): restart from beginning when play pressed at end of timeline (Fixes #536)
_🛠️ Refactor suggestion_ **Harden FPS handling: validate finite, > 0; fall back to 30** Defensively guard against invalid FPS (0, NaN, Infinity). Today, 0 would yield Infinity frameOffset, which degrades end detection. Use a robust fallback. ```diff - const fps = useProjectStore.getState().activeProject?.fps...
38f82767884250fe7c9e99672d06cb59ac957cd0
03e5c155138cfae6d90c134c0c0c2abe1dc3b09e
diff --git a/apps/web/src/stores/playback-store.ts b/apps/web/src/stores/playback-store.ts index feea0f46e..a92cb5307 100644 --- a/apps/web/src/stores/playback-store.ts +++ b/apps/web/src/stores/playback-store.ts @@ -82,6 +82,24 @@ export const usePlaybackStore = create<PlaybackStore>((set, get) => ({ speed: 1.0, ...
[ "apps/web/src/stores/playback-store.ts" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Harden FPS handling: validate finite, > 0; fall back to 30**\n\nDefensively guard against invalid FPS (0, NaN, Infinity). Today, 0 would yield Infinity frameOffset, which degrades end detection. Use a robust fallback.\n\n\n\n```diff\n- const fps = useProjectStor...
true
OpenCut-app/OpenCut
502
issue_to_patch
feat: 2 modes, feat: extract audio from media videos, feat: duplicate projects, feat: bookmarks managements refactor: tailwind v4...
## Description LOOK SCREENSHOTS SECTION Fixes # (issue) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Code refactoring ## How Has This Been Tested? Please describe the tests that you ran to verify your ...
d022a78ae2330665e7d763fdc6e831a71f3b9ea1
2fcc5e0643a36c040343bc37249e7acbd6caf6de
diff --git a/apps/web/public/landing-page-bg.png b/apps/web/public/landing-page-bg.png deleted file mode 100644 index 4f8739459..000000000 Binary files a/apps/web/public/landing-page-bg.png and /dev/null differ diff --git a/apps/web/public/landing-page-dark.png b/apps/web/public/landing-page-dark.png new file mode 1006...
[ "apps/web/public/landing-page-bg.png", "apps/web/public/landing-page-dark.png", "apps/web/public/landing-page-light.png", "apps/web/src/components/editor/media-panel/tabbar.tsx", "apps/web/src/components/editor/timeline/index.tsx", "apps/web/src/components/header.tsx", "apps/web/src/components/landing/h...
[ { "comment": "_⚠️ Potential issue_\n\n**Missing title/aria-label on SVG**\n\n`<GithubIcon className=\"size-3\" />` needs either a `<title>` or `aria-hidden=\"true\"` per accessibility guidelines.\n\n<details>\n<summary>🤖 Prompt for AI Agents</summary>\n\n```\nIn apps/web/src/app/roadmap/page.tsx around lines 1...
true
OpenCut-app/OpenCut
541
issue_to_patch
fix: TimelinePlayhead being visible when a dialog is open
## Description This fixes an issue with the TimelinePlayhead component being visible when a dialog is open Fixes # (issue) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## Screenshots (if applicable) Before <img width="3199" height="2025" alt="image" src="https://github.c...
fa698c276c7e3f897dac411dba1cf03d5696a2cf
e76724b9d2df9d3c8191198b5caecb710c88487a
diff --git a/apps/web/src/components/ui/dialog.tsx b/apps/web/src/components/ui/dialog.tsx index 2d98285b7..2316ec28d 100644 --- a/apps/web/src/components/ui/dialog.tsx +++ b/apps/web/src/components/ui/dialog.tsx @@ -22,7 +22,7 @@ const DialogOverlay = React.forwardRef< <DialogPrimitive.Overlay ref={ref} c...
[ "apps/web/src/components/ui/dialog.tsx" ]
[ { "comment": "_💡 Verification agent_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Sanity-check for other layers with z-index ≥ 150 that could still sit above the overlay**\n\nIf any app element (including the playhead) uses z-index ≥ 150, it could still appear above the overlay. Recommend a quick sc...
true
OpenCut-app/OpenCut
532
issue_to_patch
[BUG] Video preview sometimes shows wrong layer when multiple video tracks are present ### Platform win 11 ### Browser chrome ### Current Behavior <img width="911" height="859" alt="Image" src="https://github.com/user-attachments/assets/4da032d8-07f1-4b8b-aed3-0c4c1235642f" /> When working with multiple video t...
fix(preview): mute button not affecting embedded video audio, ensure topmost video track renders above lower tracksmute button not affecting embedded video audio (#529)
Summary - Fix preview stacking so that the topmost video track always renders above lower tracks - Make audio layer container non-interactive (pointer-events: none) so it can’t intercept clicks Why When multiple video tracks are present, the preview sometimes showed content from the bottom-most track despite a fu...
8c205273b7f812103ef328aa66812260e1df3183
e60b6fec3a3a4fa371eb74a74385b23d8cf1d775
diff --git a/apps/web/src/components/editor/preview-panel.tsx b/apps/web/src/components/editor/preview-panel.tsx index b9c033825..7263f7ae4 100644 --- a/apps/web/src/components/editor/preview-panel.tsx +++ b/apps/web/src/components/editor/preview-panel.tsx @@ -223,7 +223,8 @@ export function PreviewPanel() { const g...
[ "apps/web/src/components/editor/preview-panel.tsx", "apps/web/src/components/ui/video-player.tsx" ]
[]
true
OpenCut-app/OpenCut
531
issue_to_patch
Add FREESOUND API to docker file
Add FREESOUND API arg when using docker <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added support for configuring FREESOUND_CLIENT_ID and FREESOUND_API_KEY as build arguments and environment variables for the web service, enabling easier integr...
e908bad1679b8182ffbe6006e71bf38c7ada1bc0
0fcc79de5a148e3117fba21ec818353065bda851
diff --git a/apps/web/Dockerfile b/apps/web/Dockerfile index d1a60846e..6c42e7081 100644 --- a/apps/web/Dockerfile +++ b/apps/web/Dockerfile @@ -5,6 +5,9 @@ FROM base AS builder WORKDIR /app +ARG FREESOUND_CLIENT_ID +ARG FREESOUND_API_KEY + COPY package.json package.json COPY bun.lock bun.lock COPY turb...
[ "apps/web/Dockerfile", "docker-compose.yaml" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Build-time secrets can leak – prefer Compose `secrets:`**\n\nPassing the API credentials as build args bakes them into the builder image layers cached by the registry. If the credentials are not strictly needed during the build (see Dockerfile note), drop the `args:`...
true
OpenCut-app/OpenCut
533
issue_to_patch
fix(timeline): keep playhead below dialogs
## Description Timeline playhead rendered above shadcn/Radix Dialogs (e.g., the Keyboard Shortcuts dialog), visually overlapping the modal and intercepting interactions. This PR lowers the playhead’s stacking order so dialogs always appear on top and removes leftover debug logging to comply with project lint rules. ...
88cb750a3b43f87cdb527ae9b18d1bbe0ac2a702
72c815f71cf318862bb4c7aad5c4bcd03d27eef0
diff --git a/apps/web/src/components/editor/timeline/timeline-playhead.tsx b/apps/web/src/components/editor/timeline/timeline-playhead.tsx index 695843a4d..021c3dc35 100644 --- a/apps/web/src/components/editor/timeline/timeline-playhead.tsx +++ b/apps/web/src/components/editor/timeline/timeline-playhead.tsx @@ -126,7 +...
[ "apps/web/src/components/editor/timeline/timeline-playhead.tsx" ]
[]
true
OpenCut-app/OpenCut
514
issue_to_patch
feat: add panel presets
## Description This PR adds panel presets to the editor, so you can have different panel layouts optimised for specific workflows. The feature includes 4 built-in presets (Default, Media, Inspector, Vertical Preview) with a dropdown selector in the editor header. Fixes # (issue) Linter formatted some other files...
d022a78ae2330665e7d763fdc6e831a71f3b9ea1
06d99cb6bebed3ccaf0ad0a303c4c8b31314769a
diff --git a/apps/web/src/app/editor/[project_id]/page.tsx b/apps/web/src/app/editor/[project_id]/page.tsx index cae8e779c..4d5a27fcd 100644 --- a/apps/web/src/app/editor/[project_id]/page.tsx +++ b/apps/web/src/app/editor/[project_id]/page.tsx @@ -30,6 +30,8 @@ export default function Editor() { setTimeline, ...
[ "apps/web/src/app/editor/[project_id]/page.tsx", "apps/web/src/components/editor-header.tsx", "apps/web/src/components/editor/audio-waveform.tsx", "apps/web/src/components/editor/media-panel/tabbar.tsx", "apps/web/src/components/editor/preview-panel.tsx", "apps/web/src/components/keyboard-shortcuts-help.t...
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Consider refactoring to reduce code duplication.**\n\nThe current implementation has significant code duplication across the four layout configurations. Each layout repeats similar `ResizablePanel` and `ResizablePanelGroup` structures with only arrangement difference...
true
OpenCut-app/OpenCut
515
issue_to_patch
feat: add tooltip in TabBar
Here is the video that represents my changes : https://github.com/user-attachments/assets/1b70f1c3-ced5-4df9-9e79-86b431ea4de3 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added tooltips to each tab icon in the media panel, providi...
efa5be2ab8fd5be095995378caddd0784fc3fbd3
af28e4f10c4e1433487690095b11a82fe65ea38e
diff --git a/apps/web/src/components/editor/media-panel/tabbar.tsx b/apps/web/src/components/editor/media-panel/tabbar.tsx index 8d2e38506..4c3965c45 100644 --- a/apps/web/src/components/editor/media-panel/tabbar.tsx +++ b/apps/web/src/components/editor/media-panel/tabbar.tsx @@ -2,6 +2,12 @@ import { cn } from "@/l...
[ "apps/web/src/components/editor/media-panel/tabbar.tsx", "apps/web/src/components/ui/tooltip.tsx" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Add accessibility attributes to the SVG arrow.**\n\nThe SVG arrow lacks proper accessibility attributes and could confuse screen readers.\n\n\n\n```diff\n<svg\n width=\"6\"\n height=\"10\"\n viewBox=\"0 0 6 10\"\n fill=\"none\"\n xmlns=\"http://www.w3.org/2000/s...
true
OpenCut-app/OpenCut
15
issue_to_patch
Add video speed control and improve playback smoothness
Added a speed control dropdown in the timeline toolbar that lets users change video playback speed between 0.5x to 2x. The dropdown shows the current speed and offers preset options. Made video playback smoother by: - Using better timing for speed changes - Improving video synchronization - Reducing playback stut...
14a720256f6cd17aca0e3e150ddef7977f46a4e1
9c61b72bd401d2a50b876bb2afbd571f7403a8e4
diff --git a/apps/web/src/components/editor/properties-panel.tsx b/apps/web/src/components/editor/properties-panel.tsx index 496550b76..2b211c215 100644 --- a/apps/web/src/components/editor/properties-panel.tsx +++ b/apps/web/src/components/editor/properties-panel.tsx @@ -1,132 +1,218 @@ -"use client"; - -import { In...
[ "apps/web/src/components/editor/properties-panel.tsx", "apps/web/src/components/editor/speed-control.tsx", "apps/web/src/components/editor/timeline.tsx", "apps/web/src/components/ui/command.tsx", "apps/web/src/components/ui/video-player.tsx", "apps/web/src/stores/playback-store.ts", "apps/web/src/types/...
[]
true
OpenCut-app/OpenCut
461
issue_to_patch
[FEATURE] All whitespace and line breaks in text are seen ### Problem In OpenCut, it is currently impossible to make multiline text, or text with multiple consecutive spaces, though it is a feature of almost every other video editor on the market. ### Solution The text processor should see line breaks and multiple ...
fix: preserve line breaks in text element rendering
- Change whiteSpace from 'nowrap' to 'pre-wrap' in preview panel - Allows multi-line text content to display correctly - Maintains existing text wrapping behavior ## Description Fixed text rendering in the preview panel to properly display line breaks and whitespace. Previously, text elements with multiple line...
043bf7d70abb705059bed5c0dbcc8007448750ec
66b3550434c1ba1e01b8d24ad6c2aec360130f66
diff --git a/apps/web/src/components/editor/preview-panel.tsx b/apps/web/src/components/editor/preview-panel.tsx index f09e84626..3a3a5e2d1 100644 --- a/apps/web/src/components/editor/preview-panel.tsx +++ b/apps/web/src/components/editor/preview-panel.tsx @@ -277,7 +277,7 @@ export function PreviewPanel() { ...
[ "apps/web/src/components/editor/preview-panel.tsx" ]
[]
true
OpenCut-app/OpenCut
512
issue_to_patch
Update CODE_OF_CONDUCT.md
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking chang...
ae54aff1a9762ceb9e42a534c29c584bbf18d6d5
a0f5dee7996c1c21f1002066d9200d1d98853983
diff --git a/.github/CODE_OF_CONDUCT.md b/.github/CODE_OF_CONDUCT.md index b7277d268..b6d678724 100644 --- a/.github/CODE_OF_CONDUCT.md +++ b/.github/CODE_OF_CONDUCT.md @@ -59,8 +59,7 @@ representative at an online or offline event. ## Enforcement Instances of abusive, harassing, or otherwise unacceptable behavior ...
[ ".github/CODE_OF_CONDUCT.md" ]
[]
true
OpenCut-app/OpenCut
318
issue_to_patch
Add BETTER_AUTH_SECRET and BETTER_AUTH_URL env vars to build job
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated workflow configuration by adding new environment variables to the build process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
e7344d91206e57a8e14bb49665a3c8d84459722d
e419eba29bb2c6092a8c3d3866fbe46ee2937b23
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml index dbcf6f9c1..1bd00ca59 100644 --- a/.github/workflows/bun-ci.yml +++ b/.github/workflows/bun-ci.yml @@ -23,6 +23,8 @@ jobs: env: DATABASE_URL: "postgresql://opencut:opencutthegoat@localhost:5432/opencut" + BETTER_AUTH_SECRET...
[ ".github/workflows/bun-ci.yml" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n_⚠️ Potential issue_\n\n**Hard-coded credentials in workflow – switch to GitHub encrypted secrets**\n\nEmbedding real or placeholder credentials directly in the workflow YAML exposes them to every fork/clone and to all workflow logs (on PRs from forks the values are bl...
true
OpenCut-app/OpenCut
55
issue_to_patch
Fix the CI by passing required env
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking chang...
bbf9aae234ac0813b925b12c2533aac536267340
afb32909fe2491874aefc77bfd13e615f70a69aa
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml index 91bf125cd..4df6212a8 100644 --- a/.github/workflows/bun-ci.yml +++ b/.github/workflows/bun-ci.yml @@ -21,6 +21,9 @@ jobs: matrix: os: [ubuntu-latest, windows-latest, macos-latest] + env: + DATABASE_URL: "postgresql:...
[ ".github/workflows/bun-ci.yml" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n_⚠️ Potential issue_\n\n<details>\n<summary>❓ Verification inconclusive</summary>\n\n**Hard-coded DB credentials leak sensitive information – move to GitHub Secrets**\n\nThe full connection string (including username & password) is committed in plain text. \nThis viol...
true
OpenCut-app/OpenCut
94
issue_to_patch
update: bump Bun version to 1.2.17 in CI workflow
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking chang...
c18b173bc918c7f1688a30586b75792938e57690
51a83f9f216b2c496fba9729ff3dda9e9b720d80
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml index 4df6212a8..34b6d5167 100644 --- a/.github/workflows/bun-ci.yml +++ b/.github/workflows/bun-ci.yml @@ -31,13 +31,13 @@ jobs: - name: Install Bun uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 with: -...
[ ".github/workflows/bun-ci.yml" ]
[]
true
OpenCut-app/OpenCut
172
issue_to_patch
Bump bun version
## Description Bumps bun to v1.2.18 ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not ...
0acead5bb19e57088b1dc664b3cbbafca10d3988
b5d04d591f2ecb400da0c83ee71bfd06f3ddf8c7
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml index 34b6d5167..dbcf6f9c1 100644 --- a/.github/workflows/bun-ci.yml +++ b/.github/workflows/bun-ci.yml @@ -31,13 +31,13 @@ jobs: - name: Install Bun uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 with: -...
[ ".github/workflows/bun-ci.yml", "apps/web/package.json", "package.json" ]
[ { "comment": "_⚠️ Potential issue_\n\n**Cache-key version drift will reduce cache hits.**\n\nThe key hard-codes `1.2.19`, while the installed Bun version is `1.2.18`. \nThis mismatch means every CI run will miss the cache until Bun is actually upgraded again.\n\n```diff\n- key: ${{ runner.os }}-bun-1....
true
OpenCut-app/OpenCut
172
comment_to_fix
Bump bun version
_⚠️ Potential issue_ **Cache-key version drift will reduce cache hits.** The key hard-codes `1.2.19`, while the installed Bun version is `1.2.18`. This mismatch means every CI run will miss the cache until Bun is actually upgraded again. ```diff - key: ${{ runner.os }}-bun-1.2.19-${{ hashFiles('apps/web/b...
0acead5bb19e57088b1dc664b3cbbafca10d3988
b5d04d591f2ecb400da0c83ee71bfd06f3ddf8c7
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml index 34b6d5167..dbcf6f9c1 100644 --- a/.github/workflows/bun-ci.yml +++ b/.github/workflows/bun-ci.yml @@ -31,13 +31,13 @@ jobs: - name: Install Bun uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 with: -...
[ ".github/workflows/bun-ci.yml" ]
[ { "comment": "_⚠️ Potential issue_\n\n**Cache-key version drift will reduce cache hits.**\n\nThe key hard-codes `1.2.19`, while the installed Bun version is `1.2.18`. \nThis mismatch means every CI run will miss the cache until Bun is actually upgraded again.\n\n```diff\n- key: ${{ runner.os }}-bun-1....
true
OpenCut-app/OpenCut
291
issue_to_patch
feat: better-rate-limiting
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added CSRF protection to the waitlist signup form, including secure token generation, validation, and automatic token refresh after submission. * Enhanced security for the waitlist API with ad...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/next.config.ts b/apps/web/next.config.ts index a0a0d31bc..02261068c 100644 --- a/apps/web/next.config.ts +++ b/apps/web/next.config.ts @@ -1,4 +1,5 @@ import type { NextConfig } from "next"; +import { withBotId } from "botid/next/config"; const nextConfig: NextConfig = { compiler: { @@ -21,...
[ "apps/web/next.config.ts", "apps/web/package.json", "apps/web/src/app/api/waitlist/route.ts", "apps/web/src/app/api/waitlist/token/route.ts", "apps/web/src/app/layout.tsx", "apps/web/src/components/landing/hero.tsx", "apps/web/src/lib/rate-limit.ts", "bun.lock" ]
[ { "comment": "_⚠️ Potential issue_\n\n**Remove hardcoded fallback secret - critical security issue.**\n\nUsing a hardcoded fallback secret allows attackers to forge valid CSRF tokens if `BETTER_AUTH_SECRET` is not set. The application should fail fast if the secret is missing.\n\n```diff\n- .createHmac(\"sha...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_⚠️ Potential issue_ **Remove hardcoded fallback secret - critical security issue.** Using a hardcoded fallback secret allows attackers to forge valid CSRF tokens if `BETTER_AUTH_SECRET` is not set. The application should fail fast if the secret is missing. ```diff - .createHmac("sha256", env.BETTER_AUTH_SECRET |...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/token/route.ts b/apps/web/src/app/api/waitlist/token/route.ts new file mode 100644 index 000000000..4c7695fa4 --- /dev/null +++ b/apps/web/src/app/api/waitlist/token/route.ts @@ -0,0 +1,46 @@ +import { NextRequest, NextResponse } from "next/server"; +import { cookies } from "n...
[ "apps/web/src/app/api/waitlist/token/route.ts" ]
[ { "comment": "_⚠️ Potential issue_\n\n**Remove hardcoded fallback secret - critical security issue.**\n\nUsing a hardcoded fallback secret allows attackers to forge valid CSRF tokens if `BETTER_AUTH_SECRET` is not set. The application should fail fast if the secret is missing.\n\n```diff\n- .createHmac(\"sha...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_🛠️ Refactor suggestion_ **Refactor duplicated `allowedHosts` logic.** The `allowedHosts` array is defined twice with identical values. Consider extracting it to reduce duplication. ```diff + const allowedHosts = env.NODE_ENV === "development" + ? ["localhost:3000", "127.0.0.1:3000"] + : ["opencut.app", "w...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/token/route.ts b/apps/web/src/app/api/waitlist/token/route.ts new file mode 100644 index 000000000..4c7695fa4 --- /dev/null +++ b/apps/web/src/app/api/waitlist/token/route.ts @@ -0,0 +1,46 @@ +import { NextRequest, NextResponse } from "next/server"; +import { cookies } from "n...
[ "apps/web/src/app/api/waitlist/token/route.ts" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Refactor duplicated `allowedHosts` logic.**\n\nThe `allowedHosts` array is defined twice with identical values. Consider extracting it to reduce duplication.\n\n```diff\n+ const allowedHosts = env.NODE_ENV === \"development\" \n+ ? [\"localhost:3000\", \"127.0.0....
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_🛠️ Refactor suggestion_ **Add error handling for token refresh.** The token refresh after successful submission lacks error handling, which could prevent subsequent submissions. ```diff fetch("/api/waitlist/token", { credentials: "include" }) .then((res) => res.json()) .then((data) =...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/components/landing/hero.tsx b/apps/web/src/components/landing/hero.tsx index 462e3ba7d..b1910dc5b 100644 --- a/apps/web/src/components/landing/hero.tsx +++ b/apps/web/src/components/landing/hero.tsx @@ -4,7 +4,7 @@ import { motion } from "motion/react"; import { Button } from "../ui/button"; ...
[ "apps/web/src/components/landing/hero.tsx" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Add error handling for token refresh.**\n\nThe token refresh after successful submission lacks error handling, which could prevent subsequent submissions.\n\n```diff\n fetch(\"/api/waitlist/token\", { credentials: \"include\" })\n .then((res) => res...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_🛠️ Refactor suggestion_ **Add cleanup and improve error handling for CSRF token fetch.** The `useEffect` should handle component unmounting to prevent state updates on unmounted components. Also, consider showing user feedback when token fetching fails. ```diff useEffect(() => { + let isMounted = true; ...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/components/landing/hero.tsx b/apps/web/src/components/landing/hero.tsx index 462e3ba7d..b1910dc5b 100644 --- a/apps/web/src/components/landing/hero.tsx +++ b/apps/web/src/components/landing/hero.tsx @@ -4,7 +4,7 @@ import { motion } from "motion/react"; import { Button } from "../ui/button"; ...
[ "apps/web/src/components/landing/hero.tsx" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Add cleanup and improve error handling for CSRF token fetch.**\n\nThe `useEffect` should handle component unmounting to prevent state updates on unmounted components. Also, consider showing user feedback when token fetching fails.\n\n```diff\n useEffect(() => {\n+ ...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_⚠️ Potential issue_ **Remove hardcoded fallback secret - critical security issue.** Same security vulnerability as in the token generation endpoint. The fallback secret must be removed. ```diff - .createHmac("sha256", env.BETTER_AUTH_SECRET || "fallback-secret") + .createHmac("sha256", env.BETTER_AUTH_SECRET)...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/route.ts b/apps/web/src/app/api/waitlist/route.ts index f6f811036..f62e24e9d 100644 --- a/apps/web/src/app/api/waitlist/route.ts +++ b/apps/web/src/app/api/waitlist/route.ts @@ -1,54 +1,77 @@ import { NextRequest, NextResponse } from "next/server"; import { db, eq } from "@...
[ "apps/web/src/app/api/waitlist/route.ts" ]
[ { "comment": "_⚠️ Potential issue_\n\n**Remove hardcoded fallback secret - critical security issue.**\n\nSame security vulnerability as in the token generation endpoint. The fallback secret must be removed.\n\n```diff\n- .createHmac(\"sha256\", env.BETTER_AUTH_SECRET || \"fallback-secret\")\n+ .createHmac...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
was this vibe coded???
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/route.ts b/apps/web/src/app/api/waitlist/route.ts index f6f811036..f62e24e9d 100644 --- a/apps/web/src/app/api/waitlist/route.ts +++ b/apps/web/src/app/api/waitlist/route.ts @@ -1,54 +1,77 @@ import { NextRequest, NextResponse } from "next/server"; import { db, eq } from "@...
[ "apps/web/src/app/api/waitlist/route.ts" ]
[ { "comment": "was this vibe coded???", "path": "apps/web/src/app/api/waitlist/route.ts", "hunk": "@@ -1,64 +1,196 @@\n import { NextRequest, NextResponse } from \"next/server\";\r\n import { db, eq } from \"@opencut/db\";\r\n import { waitlist } from \"@opencut/db/schema\";\r\n+import { checkBotId } fro...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
think BotID also does similar checks > Basic - Ensures valid browser sessions are accessing your sites
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/route.ts b/apps/web/src/app/api/waitlist/route.ts index f6f811036..f62e24e9d 100644 --- a/apps/web/src/app/api/waitlist/route.ts +++ b/apps/web/src/app/api/waitlist/route.ts @@ -1,54 +1,77 @@ import { NextRequest, NextResponse } from "next/server"; import { db, eq } from "@...
[ "apps/web/src/app/api/waitlist/route.ts" ]
[ { "comment": "think BotID also does similar checks \r\n\r\n> Basic - Ensures valid browser sessions are accessing your sites\r\n", "path": "apps/web/src/app/api/waitlist/route.ts", "hunk": "@@ -1,64 +1,196 @@\n import { NextRequest, NextResponse } from \"next/server\";\r\n import { db, eq } from \"@open...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
where did this implementation come from?
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/token/route.ts b/apps/web/src/app/api/waitlist/token/route.ts new file mode 100644 index 000000000..4c7695fa4 --- /dev/null +++ b/apps/web/src/app/api/waitlist/token/route.ts @@ -0,0 +1,46 @@ +import { NextRequest, NextResponse } from "next/server"; +import { cookies } from "n...
[ "apps/web/src/app/api/waitlist/token/route.ts" ]
[ { "comment": "where did this implementation come from?", "path": "apps/web/src/app/api/waitlist/token/route.ts", "hunk": "@@ -0,0 +1,47 @@\n+import { NextRequest, NextResponse } from \"next/server\";\n+import { cookies } from \"next/headers\";\n+import crypto from \"crypto\";\n+import { env } from \"@/e...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_🛠️ Refactor suggestion_ **Refactor the browser validation function to improve maintainability.** The `validateBrowserRequest` function is doing too many things and has become quite large. Consider breaking it down into smaller, focused validation functions for better maintainability and testing. Additionally, ther...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/route.ts b/apps/web/src/app/api/waitlist/route.ts index f6f811036..f62e24e9d 100644 --- a/apps/web/src/app/api/waitlist/route.ts +++ b/apps/web/src/app/api/waitlist/route.ts @@ -1,54 +1,77 @@ import { NextRequest, NextResponse } from "next/server"; import { db, eq } from "@...
[ "apps/web/src/app/api/waitlist/route.ts" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Refactor the browser validation function to improve maintainability.**\n\nThe `validateBrowserRequest` function is doing too many things and has become quite large. Consider breaking it down into smaller, focused validation functions for better maintainability and te...
true
OpenCut-app/OpenCut
291
comment_to_fix
feat: better-rate-limiting
_🛠️ Refactor suggestion_ **Improve error response consistency and remove timing attack vector.** The enhanced security validations have some issues: 1. Different error messages for rate limiting vs other security checks could help attackers identify the specific protection that blocked them. 2. The random delay (li...
d5c52557df6063cf856015b958f1c08c3b9de3de
79f6c680f394ec4a9970124cfe915b05c1b969df
diff --git a/apps/web/src/app/api/waitlist/route.ts b/apps/web/src/app/api/waitlist/route.ts index f6f811036..f62e24e9d 100644 --- a/apps/web/src/app/api/waitlist/route.ts +++ b/apps/web/src/app/api/waitlist/route.ts @@ -1,54 +1,77 @@ import { NextRequest, NextResponse } from "next/server"; import { db, eq } from "@...
[ "apps/web/src/app/api/waitlist/route.ts" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Improve error response consistency and remove timing attack vector.**\n\nThe enhanced security validations have some issues:\n\n1. Different error messages for rate limiting vs other security checks could help attackers identify the specific protection that blocked t...
true
OpenCut-app/OpenCut
43
issue_to_patch
Discussion about adding GitHub Action workflows I am trying to implement GitHub action workflow and noticed the project doesn't have root-level `package.json` and I am curious how to implement action which the app in `apps/web/*`. I know i can use AI but I want to hear from you guyz @mazeincoding @izadoesdev
feat: add Bun CI workflow for building and testing
## Description Added a GitHub Action workflow for Bun app in a monorepo. The bun is locked to v1.2.2 same as in `web/package.json`. Fixes #9 ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change whi...
4b2afb7271c5639062494cec190825b6389bef0a
82e7d2236d3ef5671b6f362b0ea02db0a4a66b6a
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml new file mode 100644 index 000000000..91bf125cd --- /dev/null +++ b/.github/workflows/bun-ci.yml @@ -0,0 +1,50 @@ +name: Bun CI + +concurrency: + group: bun-ci-${{ github.ref }} + cancel-in-progress: true + +on: + push: + branches: [main] + ...
[ ".github/workflows/bun-ci.yml" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Pin the setup-action by commit to mitigate supply-chain risk**\n\nTag `oven-sh/setup-bun@v2.0.2` can be retagged. Use the immutable SHA to ensure build reproducibility:\n\n```diff\n- uses: oven-sh/setup-bun@v2.0.2\n+ # 2.0.2 @ 6f8c51c… (example)\n+ ...
true
OpenCut-app/OpenCut
43
comment_to_fix
feat: add Bun CI workflow for building and testing
_🛠️ Refactor suggestion_ **Pin the setup-action by commit to mitigate supply-chain risk** Tag `oven-sh/setup-bun@v2.0.2` can be retagged. Use the immutable SHA to ensure build reproducibility: ```diff - uses: oven-sh/setup-bun@v2.0.2 + # 2.0.2 @ 6f8c51c… (example) + uses: oven-sh/setup-bun@6f8c...
4b2afb7271c5639062494cec190825b6389bef0a
82e7d2236d3ef5671b6f362b0ea02db0a4a66b6a
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml new file mode 100644 index 000000000..91bf125cd --- /dev/null +++ b/.github/workflows/bun-ci.yml @@ -0,0 +1,50 @@ +name: Bun CI + +concurrency: + group: bun-ci-${{ github.ref }} + cancel-in-progress: true + +on: + push: + branches: [main] + ...
[ ".github/workflows/bun-ci.yml" ]
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Pin the setup-action by commit to mitigate supply-chain risk**\n\nTag `oven-sh/setup-bun@v2.0.2` can be retagged. Use the immutable SHA to ensure build reproducibility:\n\n```diff\n- uses: oven-sh/setup-bun@v2.0.2\n+ # 2.0.2 @ 6f8c51c… (example)\n+ ...
true
OpenCut-app/OpenCut
494
issue_to_patch
Fixed BUG Editor cursor does not stop at the end of an audio file
Get duration of content on the timeline to make sure the playhead moves until the end of the timeline content when the content is less than 10 seconds. Originally it would go all the way to the 10 seconds when timeline content was less than that. I checked how clipchamp does it and they have a min 10 sec timeline but v...
6899450df9f460c8088527f3a06f49116f04a310
281ec63d7e0dfe70534790deb790c5bbd6701502
diff --git a/apps/web/src/components/editor/preview-panel.tsx b/apps/web/src/components/editor/preview-panel.tsx index 639858d09..6cb060614 100644 --- a/apps/web/src/components/editor/preview-panel.tsx +++ b/apps/web/src/components/editor/preview-panel.tsx @@ -211,7 +211,7 @@ export function PreviewPanel() { setDr...
[ "apps/web/src/components/editor/preview-panel.tsx", "apps/web/src/components/editor/timeline/index.tsx", "apps/web/src/components/landing/handlebars.tsx", "apps/web/src/hooks/use-editor-actions.ts", "apps/web/src/stores/playback-store.ts" ]
[]
true
OpenCut-app/OpenCut
499
issue_to_patch
[BUG] auto created multiple projects when I back from edit page ### Platform iPhone ### Browser safari web browser ### Current Behavior ![Image](https://github.com/user-attachments/assets/4d5a4b7c-84ff-43aa-b78a-0f9f3a007fd8) Just attached the screenshot. I’m browsing the website on my phone , and when I am b...
fix(editor): prevent excessive project creation from invalid routes
## Problem Fixes race conditions in the editor component that caused navigation to invalid project IDs to create multiple 'Untitled Project' entries. Users reported accumulating 885+ projects due to this bug (see issue #182). ## Root Cause The useEffect hook in the editor component had race conditions that caused: -...
2bde71d4bc20948ce54795aa61d239c1a94c82d3
a1d2fbd96bb6713c3172198d71e94274af409aee
diff --git a/.github/workflows/bun-ci.yml b/.github/workflows/bun-ci.yml index f01b98780..1f33096a2 100644 --- a/.github/workflows/bun-ci.yml +++ b/.github/workflows/bun-ci.yml @@ -53,5 +53,8 @@ jobs: - name: Run tests working-directory: apps/web - run: echo "No tests implemented yet" - ...
[ ".github/workflows/bun-ci.yml", "apps/web/package.json", "apps/web/scripts/test-excessive-projects.ts", "apps/web/src/__tests__/README.md", "apps/web/src/__tests__/editor-page-integration.test.tsx", "apps/web/src/__tests__/excessive-projects.test.ts", "apps/web/src/__tests__/setup.ts", "apps/web/src/a...
[ { "comment": "_🛠️ Refactor suggestion_\n\n**Import act from the correct module**\n\nThe `act` utility should be imported from React Testing Library for consistency with the testing setup.\n\n```diff\n-import { act } from 'react'\n+import { act } from '@testing-library/react'\n```\n\n<details>\n<summary>🤖 Prom...
diff --git a/apps/web/src/__tests__/README.md b/apps/web/src/__tests__/README.md new file mode 100644 index 000000000..02173edf0 --- /dev/null +++ b/apps/web/src/__tests__/README.md @@ -0,0 +1,164 @@ +# Test Suite: Excessive Project Creation Bug + +This test suite provides comprehensive testing for the excessive projec...
true
OpenCut-app/OpenCut
500
issue_to_patch
feat: add hide or show for media elements, mute or unmute for audio elements
add hide or show for media elements, mute or unmute for audio elements with a nice UI and robust corresponding functionality. add bookmark to mark and unmark timeline frames, synced and stored. ## Description add hide or show for media elements, mute or unmute for audio elements both are effective on timeline an...
b229d94a8da7b258f1b49867e8cee225d5feb735
5a898fa27e6a282ee27ae2c875f20f84d08d405a
diff --git a/apps/web/package.json b/apps/web/package.json index f5cd7da49..9531b6c72 100644 --- a/apps/web/package.json +++ b/apps/web/package.json @@ -43,7 +43,7 @@ "input-otp": "^1.4.1", "lucide-react": "^0.468.0", "motion": "^12.18.1", - "next": "^15.4.3", + "next": "^15.4.5", "next-themes...
[ "apps/web/package.json", "apps/web/src/app/contributors/page.tsx", "apps/web/src/components/editor/audio-waveform.tsx", "apps/web/src/components/editor/preview-panel.tsx", "apps/web/src/components/editor/timeline/index.tsx", "apps/web/src/components/editor/timeline/timeline-element.tsx", "apps/web/src/c...
[]
true
OpenCut-app/OpenCut
495
issue_to_patch
add forward and backward buttons to non-fullscreen view
## Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. Added forward and backward buttons to non-fullscreen view. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [x ] New feature (non-breaking ch...
f15508df62ca407522de448f21711c0711601c91
18b2a8ce5bf34f7a35cbfd418fbaa5f34f5d3c08
diff --git a/apps/web/package.json b/apps/web/package.json index f5cd7da49..9531b6c72 100644 --- a/apps/web/package.json +++ b/apps/web/package.json @@ -43,7 +43,7 @@ "input-otp": "^1.4.1", "lucide-react": "^0.468.0", "motion": "^12.18.1", - "next": "^15.4.3", + "next": "^15.4.5", "next-themes...
[ "apps/web/package.json", "apps/web/src/app/contributors/page.tsx", "apps/web/src/components/editor/preview-panel.tsx", "apps/web/src/components/icons.tsx", "apps/web/src/constants/site.ts", "bun.lock" ]
[]
true
OpenMathLib/OpenBLAS
5,835
issue_to_patch
Fix 32-bit integer overflow in LAPACKE nancheck index arithmetic
The LAPACKE NaN checks compute array offsets in 32-bit `lapack_int`, which overflows for large matrices. Found while running Cholesky on a 47000x47000 matrix: `LAPACKE_dpotrf` with `n = lda >= 46341` crashes in `LAPACKE_dtr_nancheck` before the factorization even runs, because `j*lda` wraps negative. Same family of ove...
a033631ee8486c245967465c2b43b0a3eb9a1b61
ede136ee4e1386387f04ddd8afd4650f93a5b345
diff --git a/lapack-netlib/LAPACKE/utils/lapacke_c_nancheck.c b/lapack-netlib/LAPACKE/utils/lapacke_c_nancheck.c index 82a4242395..971b811eab 100644 --- a/lapack-netlib/LAPACKE/utils/lapacke_c_nancheck.c +++ b/lapack-netlib/LAPACKE/utils/lapacke_c_nancheck.c @@ -42,8 +42,8 @@ lapack_logical LAPACKE_c_nancheck( lapack_i...
[ "lapack-netlib/LAPACKE/utils/lapacke_c_nancheck.c", "lapack-netlib/LAPACKE/utils/lapacke_chp_nancheck.c", "lapack-netlib/LAPACKE/utils/lapacke_cpf_nancheck.c", "lapack-netlib/LAPACKE/utils/lapacke_cpp_nancheck.c", "lapack-netlib/LAPACKE/utils/lapacke_csp_nancheck.c", "lapack-netlib/LAPACKE/utils/lapacke_c...
[]
true
OpenMathLib/OpenBLAS
5,833
issue_to_patch
Fix AIX build with OpenXL (ibm-clang)
Change #5827 broke AIX build with OpenXL (ibm-clang). ``` ../kernel/power/dgemv_t_power10.c:64:33: error: passing 'int' to parameter of incompatible type 'long' 64 | vp = __builtin_vsx_lxvp(0, (__vector_pair *)((void *)&a0[i*2])); | ^ ../kernel/power/dgemv_t_power...
94f85eb6b1390a11be21d67cd2519d069e26d888
faf7ddbbea90c8f274b945dc99680f80c367d9e7
diff --git a/kernel/power/dgemm_kernel_power10.c b/kernel/power/dgemm_kernel_power10.c index 6ec6ee51b2..7955dd3600 100644 --- a/kernel/power/dgemm_kernel_power10.c +++ b/kernel/power/dgemm_kernel_power10.c @@ -94,8 +94,8 @@ typedef FLOAT v4sf_t __attribute__ ((vector_size (16))); #endif #define KERNEL(i) \ rowA...
[ "kernel/power/dgemm_kernel_power10.c", "kernel/power/dgemm_small_kernel_nn_power10.c", "kernel/power/dgemm_small_kernel_nt_power10.c", "kernel/power/dgemm_small_kernel_tt_power10.c", "kernel/power/dgemv_t_power10.c", "kernel/power/zgemm_kernel_power10.c" ]
[]
true
OpenMathLib/OpenBLAS
5,822
issue_to_patch
optimize zgemm, ic/zamin and sdot lsx kernel for 2k3000 cpu
On the 2k3000 CPU, the performance of zgemm lsx is not good. The kernel was optimized and the PQR parameters were set according to the hardware characteristics. performance of ./zgemm.goto 1000 2000 100, LOOPS=20 THREADS=8, before: ``` M=1000,N=1000, K=1000: 40705.41 MFlops 1.965341 sec M=1100,N=1100, K=1100: 4227...
1bd74ad3d1e8d21f86d1a6be35abfcdf27c0208a
4850f86e3d9b8e578a6c715b1083410e94fa06cf
diff --git a/driver/others/parameter.c b/driver/others/parameter.c index 9a1ff57358..3a1363e0ea 100644 --- a/driver/others/parameter.c +++ b/driver/others/parameter.c @@ -790,6 +790,17 @@ int get_L3_size() { return ((ret & 0xffff) + 1) * pow(2, ((ret >> 16) & 0xff)) * pow(2, ((ret >> 24) & 0x7f)) / 1024 / 1024; // M...
[ "driver/others/parameter.c", "kernel/loongarch64/KERNEL.LA264", "kernel/loongarch64/icamin_lsx.S", "kernel/loongarch64/sdot_lsx.S", "kernel/loongarch64/zgemm_kernel_4x4_lsx.S", "kernel/setparam-ref.c", "param.h" ]
[]
true
OpenMathLib/OpenBLAS
5,827
issue_to_patch
Power10: Replace vector pair loads with __builtin_vsx_lxvp
Replace normal vector pair pointer dereferences with the optimized __builtin_vsx_lxvp builtin across DGEMM, ZGEMM, and DGEMV kernels. Also done some identation corrections in dgemm_kernel_power10.c. This is done as part of POWER code cleanup and may not have any performance impact.
91f97c667e0115f30d9a5d944105632ecf4ceef5
3863a7778d4fc26653e721d2f5d7d86063a78194
diff --git a/kernel/power/dgemm_kernel_power10.c b/kernel/power/dgemm_kernel_power10.c index f5cc3dfede..6ec6ee51b2 100644 --- a/kernel/power/dgemm_kernel_power10.c +++ b/kernel/power/dgemm_kernel_power10.c @@ -38,875 +38,837 @@ typedef FLOAT v4sf_t __attribute__ ((vector_size (16))); #endif #ifdef TRMMKERNEL -#def...
[ "kernel/power/dgemm_kernel_power10.c", "kernel/power/dgemm_small_kernel_nn_power10.c", "kernel/power/dgemm_small_kernel_nt_power10.c", "kernel/power/dgemm_small_kernel_tt_power10.c", "kernel/power/dgemv_t_power10.c", "kernel/power/gemm_common.c", "kernel/power/zgemm_kernel_power10.c" ]
[]
true
OpenMathLib/OpenBLAS
5,829
issue_to_patch
Incorrect `dgemm_` results when called concurrently with `dsyevd_` ## Description I am seeing incorrect `dgemm_` results when one application thread is inside `dsyevd_` and another application thread calls `dgemm_`, using the same loaded OpenBLAS library in the same process. This originally surfaced in jax-ml/jax#38...
Fix OpenMP reentrancy issues in LLVM compilations with gmake on ARM64
fixes #5825 - problem was introduced by my #5423 inadvertently invalidating the C11 Atomics capability check in the build system, leading to less reliable locking being used to protect against concurrent calls from OpenMP code.
91f97c667e0115f30d9a5d944105632ecf4ceef5
1145c75a9609c032bdb2659f683b0f7215aedcc6
diff --git a/Makefile.arm64 b/Makefile.arm64 index bcdda04778..49b25ab6f9 100644 --- a/Makefile.arm64 +++ b/Makefile.arm64 @@ -310,12 +310,10 @@ endif ifeq ($(CORE), VORTEXM4) ifneq ($(C_COMPILER), GCC) -ifeq ($(APPLECLANG),1) CCOMMON_OPT += -march=armv8.4-a+sme -else -CCOMMON_OPT += -march=armv8.4-a+sme -override...
[ "Makefile.arm64", "c_check", "kernel/Makefile" ]
[]
true
OpenMathLib/OpenBLAS
5,826
issue_to_patch
Faster GEMV for RVV
Unroll inner loop - 2 rows at a time. Up to 1.5X faster.
91f97c667e0115f30d9a5d944105632ecf4ceef5
6a23c3631317beb67d674bb464cfbfffb82d0258
diff --git a/kernel/riscv64/gemv_n_vector.c b/kernel/riscv64/gemv_n_vector.c index 48eb4e2d68..845e4de296 100644 --- a/kernel/riscv64/gemv_n_vector.c +++ b/kernel/riscv64/gemv_n_vector.c @@ -49,12 +49,33 @@ int CNAME(BLASLONG m, BLASLONG n, BLASLONG dummy1, FLOAT alpha, FLOAT *a, BLASLO { if (n < 0) return(0); ...
[ "kernel/riscv64/gemv_n_vector.c" ]
[]
true
OpenMathLib/OpenBLAS
5,824
issue_to_patch
Shared library build fails on macOS when using NAG Fortran compiler When building OpenBLAS with `BUILD_SHARED_LIBS=ON` on macOS using the NAG Fortran compiler, the build fails during the shared library link step. **Environment:** - macOS (arm64) - NAG Fortran 7.2 (nagfor) - CMake with Unix Makefiles or Ninja **Error...
Fix shared lib build with NAG Fortran on macOS
Fixes #5823 Note: This was done with Claude's help. I tried myself but it got to the point I needed some good insight on how CMake does shared library stuff. On macOS, the shared library link rule for Fortran used two GCC-specific constructs that fail with the NAG Fortran compiler: - `-x f95-cpp-input` — a GCC...
1bd74ad3d1e8d21f86d1a6be35abfcdf27c0208a
7a2b8b5aa619311b71473538cf2a39543aa42ad0
diff --git a/CMakeLists.txt b/CMakeLists.txt index 5f5fffe43d..6a145ac6be 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -263,6 +263,14 @@ if(APPLE) if(NOT NOFORTRAN) set(CMAKE_Fortran_USE_RESPONSE_FILE_FOR_OBJECTS ON) set(CMAKE_Fortran_USE_RESPONSE_FILE_FOR_LIBRARIES ON) + # NAG Fortran does not s...
[ "CMakeLists.txt" ]
[]
true
OpenMathLib/OpenBLAS
5,815
issue_to_patch
RISC-V (riscv64_zvl256b, SpaceMiT K1): DGEMM regression between 0.3.31 and 0.3.33 produces non-PSD matrix from A^T @ A On SpaceMiT K1 hardware (RVA22 + RVV 1.0 (VLEN=256), runtime DYNAMIC_ARCH selects riscv64_zvl256b), DGEMM produces a matrix with significantly negative eigenvalues when computing `A.T @ A` for a 50x50...
Fix contiguous memory check for SGEMM and DGEMM in RISC-V.
Fix contiguous memory check for SGEMM and DGEMM in RISC-V.
6506d703c91e400febc517babb9554ea4a30a5bf
f3f718b228b809903ec9412e0a4cc28fda3def3b
diff --git a/kernel/riscv64/dgemm_kernel_8x8_zvl256b.c b/kernel/riscv64/dgemm_kernel_8x8_zvl256b.c index 613a756b84..aa107ac1be 100644 --- a/kernel/riscv64/dgemm_kernel_8x8_zvl256b.c +++ b/kernel/riscv64/dgemm_kernel_8x8_zvl256b.c @@ -1628,11 +1628,12 @@ static void NM_TAIL(BLASLONG K, BLASLONG M, const BLASLONG m_edge...
[ "kernel/riscv64/dgemm_kernel_8x8_zvl256b.c", "kernel/riscv64/sgemm_kernel_16x8_zvl256b.c" ]
[]
true
OpenMathLib/OpenBLAS
5,820
issue_to_patch
SIGILL on Apple silicon Has been reproduced on OS/CPU: macOS Tahoe 26.5, M4 and M2 CPU Compiler: GCC (gfortran) 15.2.0 OpenBLAS 0.3.32 (installed via macports, [build formula](https://github.com/macports/macports-ports/blob/master/math/OpenBLAS/Portfile)) and OS/CPU: - / M2 CPU Compiler: GCC (gfortran) 15.2.0 OpenB...
Fix misoptimization of C/ZGETF2 by Clang on Apple M
fixes #5818
804a77cb1aaacccd02ccbba89099b857889f0fa2
1f2ae720af01e63299a5b26b8690f47fd994db5c
diff --git a/lapack/getf2/zgetf2_k.c b/lapack/getf2/zgetf2_k.c index 6a2137b3e7..e2c2f75f65 100644 --- a/lapack/getf2/zgetf2_k.c +++ b/lapack/getf2/zgetf2_k.c @@ -51,7 +51,8 @@ blasint CNAME(blas_arg_t *args, BLASLONG *range_m, BLASLONG *range_n, FLOAT *sa, blasint *ipiv; FLOAT *a; - FLOAT temp1, temp2, temp3,...
[ "lapack/getf2/zgetf2_k.c" ]
[]
true
OpenMathLib/OpenBLAS
5,803
issue_to_patch
Makefile.install: fix PKGFILE expression so it works with paths with spaces
Previously, running the make file with a PREFIX path which included spaces would write to the wrong path, now it will write to the correct path. Also note that the second setting of PKGFILE, at line 194 previously, was useless because that line was treated as a shell command which only assigned the variable for tha...
3da0ff7bc29243cf448ddf12c6766716f1530ea2
a4aae763829cd46c1b69a4895b89af364c0791af
diff --git a/Makefile.install b/Makefile.install index 5fc6b9560c..e6720ccf2d 100644 --- a/Makefile.install +++ b/Makefile.install @@ -32,7 +32,7 @@ PKG_EXTRALIB := $(EXTRALIB) ifeq ($(INTERFACE64),1) SUFFIX64=64 endif -PKGFILE="$(DESTDIR)$(OPENBLAS_PKGCONFIG_DIR)/$(LIBSONAMEBASE)$(SUFFIX64).pc" +PKGFILE := $(DESTD...
[ "Makefile.install" ]
[]
true
OpenMathLib/OpenBLAS
5,816
issue_to_patch
Fix gmake build of ARM64 DYNAMIC_ARCH on hosts lacking SVE
6506d703c91e400febc517babb9554ea4a30a5bf
68c65d8e58e4c3390faadc2e5727b3a3ef5a2a3e
diff --git a/kernel/Makefile b/kernel/Makefile index 014908c7eb..221836d185 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -97,11 +97,11 @@ else ifeq ($(TARGET_CORE), ZEN) override CFLAGS += -DBUILD_KERNEL -DTABLE_NAME=gotoblas_$(TARGET_CORE) $(AVX2OPT) else ifeq ($(TARGET_CORE), LOONGSON3R4) override CFLAG...
[ "kernel/Makefile" ]
[]
true
OpenMathLib/OpenBLAS
5,814
issue_to_patch
Bug: iparmq_ function crash due to incorrect name_len assignment (f2c string, s_copy macro, roots/Armadillo/Win10/MSVC2019) ### Summary A crash or undefined behavior occurs in the LAPACK auxiliary routine `iparmq_` due to `name_len` being set to 0 before calling `s_copy`, resulting in invalid string copying and uninit...
Replace dangerous usage of s_copy macro in C versions of LAPACK ILAENV and IPARMQ
and also fix various compiler warnings about unused functions and missing parentheses in these and the related 2stage functions. fixes #5809
55c72a934f2dbc6d73f34aa570ef6cee49c47ec7
029a05fa847ad56dc8151b954a2739b43cb1c828
diff --git a/lapack-netlib/SRC/ilaenv.c b/lapack-netlib/SRC/ilaenv.c index c262e5952f..e881fb3fc6 100644 --- a/lapack-netlib/SRC/ilaenv.c +++ b/lapack-netlib/SRC/ilaenv.c @@ -247,7 +247,6 @@ typedef struct Namelist Namelist; #define s_copy(A,B,C,D) { int __i,__m; for (__i=0, __m=f2cmin((C),(D)); __i<__m && (B)[__i] !=...
[ "lapack-netlib/SRC/ilaenv.c", "lapack-netlib/SRC/ilaenv2stage.c", "lapack-netlib/SRC/iparam2stage.c", "lapack-netlib/SRC/iparmq.c" ]
[]
true
OpenMathLib/OpenBLAS
5,813
issue_to_patch
Regression in 0.3.33: SIGBUS in strsm_kernel_RT_BARCELONA on x86_64 DYNAMIC_ARCH (regression from commit fd862d43b "Remove redundant quick return") ## Summary (bisec was done with Claude Code) Commit `fd862d43b` ("Remove redundant quick return", 2026-04-22) regresses single-precision `STRSM` on x86_64 `DYNAMIC_ARCH=...
Fix TRSM on Barcelona target (and possibly others)
Restores the quick return I had mistakenly removed as part of #5767 - what I mistook as redundant is actually the guard in common code, while the copy I had put above it was only guarding kernel calls from CBLAS. fixes #5810 as suggested there
3dc0ba50e25c822cb4aee8a2848c0069d3fa33e4
26c4eb65d1b60005d6556e432f4a8989efc5b6e6
diff --git a/interface/trsm.c b/interface/trsm.c index ae35d0d3b7..069df1aa5c 100644 --- a/interface/trsm.c +++ b/interface/trsm.c @@ -381,8 +381,12 @@ if (strcmp(gotoblas_corename(), "armv9sme") == 0 #endif #endif + + +//end of the ifndef CBLAS ... else ... section #endif + if ((args.m == 0) || (args.n == 0))...
[ "interface/trsm.c" ]
[]
true
OpenMathLib/OpenBLAS
5,812
issue_to_patch
Makefile.system: -lm is necessary on power as well
3da0ff7bc29243cf448ddf12c6766716f1530ea2
9cb7d3932f2f6ef83776e368151e96ad1cc225d9
diff --git a/Makefile.system b/Makefile.system index 11d7f2279e..9841a91dec 100644 --- a/Makefile.system +++ b/Makefile.system @@ -474,7 +474,7 @@ EXTRALIB += -lm endif ifeq ($(OSNAME), $(filter $(OSNAME),FreeBSD OpenBSD NetBSD DragonFly)) -ifeq ($(ARCH), $(filter $(ARCH),arm arm64)) +ifeq ($(ARCH), $(filter $(ARCH...
[ "Makefile.system" ]
[]
true
OpenMathLib/OpenBLAS
5,801
issue_to_patch
Makefile.system: when Clang is used, check if gfortran is used
At least on power, GCCVERSIONGT4 is checked for when gfortran is used, like at Makefile.power:59
45e5426e1cfcf797221439cb10184bd449c40e86
1dc25c14cd02122fe4afb202ffd14db733716999
diff --git a/Makefile.system b/Makefile.system index 11d7f2279e..10a5486295 100644 --- a/Makefile.system +++ b/Makefile.system @@ -422,6 +422,9 @@ endif ifeq ($(C_COMPILER), CLANG) CLANGVERSIONGTEQ9 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 9) CLANGVERSIONGTEQ12 := $(shell expr `$(CC) -dumpversion | cut...
[ "Makefile.system" ]
[]
true
OpenMathLib/OpenBLAS
5,804
issue_to_patch
Use -mpwr10 instead of -mpower10 to support AIX assembler
#5802 broke OpenBLAS build on AIX with the below error, ``` Assembler: line 1: 1252-162 Invalid -m flag assembly mode operand: POWER10. Valid values are:COM PWR PWR2 PPC 601 603 604 PPC64 620 A35 PWR4 PWR5 PWR5X 970 PPC970 PWR6 PWR6E PWR7 PWR8 PWR9 PWR10 ANY /tmp/scal-bfa82c.s: line 14: 1252-149 Instruction stdu ...
3da0ff7bc29243cf448ddf12c6766716f1530ea2
beed554ae5408ce7d87ccf458f5dc56242704396
diff --git a/Makefile.power b/Makefile.power index 6c5b556de1..418b784ac0 100644 --- a/Makefile.power +++ b/Makefile.power @@ -111,7 +111,7 @@ endif endif ifeq ($(C_COMPILER), CLANG) -CCOMMON_OPT += -fno-integrated-as -Wa,-mpower10 +CCOMMON_OPT += -fno-integrated-as -Wa,-mpwr10 endif # workaround for C->FORTRAN A...
[ "Makefile.power" ]
[]
true
OpenMathLib/OpenBLAS
5,797
issue_to_patch
Fix compiler check for ARM64 SME support in CMake builds
fixes runtime detection of Apple M4 as VORTEXM4 target, as noted in #5713
45e5426e1cfcf797221439cb10184bd449c40e86
d4d02fee71ed9f1d4200c9f15943592c74e73088
diff --git a/cmake/arch.cmake b/cmake/arch.cmake index 0337e16cda..b902937a05 100644 --- a/cmake/arch.cmake +++ b/cmake/arch.cmake @@ -48,9 +48,13 @@ if (DYNAMIC_ARCH) if (${CMAKE_C_COMPILER_VERSION} VERSION_GREATER_EQUAL 11) # SVE ACLE supported in LLVM >= 11 set(DYNAMIC_CORE ${DYNAMIC_CORE} NEOVERSEV1...
[ "cmake/arch.cmake", "cmake/system_check.cmake" ]
[]
true
OpenMathLib/OpenBLAS
5,805
issue_to_patch
SME kernel not getting hit due to incorrect conditioning on leading dimensions https://github.com/OpenMathLib/OpenBLAS/blob/8e57c8667da06cb55a777975b6c2435c9b304079/interface/gemm.c#L565 @martin-frbg, The correct conditioning is k==lda && n ==ldb && n==ldc.
Fix incorrect leading dimension check for SME SGEMM direct kernel path
For row-major matrices, the tight-packing condition should be k==lda (A is m×k), n==ldb (B is k×n), and n==ldc (C is m×n). The old check used m==lda and k==ldc, which prevented the SME/direct kernel from being invoked except when m==k==n (square matrices). Fixes https://github.com/OpenMathLib/OpenBLAS/issues/5794
3da0ff7bc29243cf448ddf12c6766716f1530ea2
c32eefd87f8c5b0de3372fef924767f1bd9c1039
diff --git a/interface/gemm.c b/interface/gemm.c index 60addbd2ca..79b076164c 100644 --- a/interface/gemm.c +++ b/interface/gemm.c @@ -562,12 +562,12 @@ if (strcmp(gotoblas_corename(), "armv9sme") == 0 ) // if (support_sme1()) #endif - if (order == CblasRowMajor && m==lda && n ==ldb && k==ldc && beta == 0 && alpha ...
[ "interface/gemm.c" ]
[]
true
OpenMathLib/OpenBLAS
4,425
issue_to_patch
finer control over the # of threads used by any given call to OpenBLAS I need finer control of the # of threads that each call to the BLAS uses. My packages are themselves multithreaded. Each of my threads can make its own calls to the BLAS, in parallel. Some of those calls will be for small matrices, or for other cas...
Add BLAS extension openblas_set_num_threads_local()
this complements the existing openblas_set_num_threads by - returning the previously used number of threads - overriding OpenMP environment variables and taking effect in OpenMP parallel regions as well fixes #2392 (and related #1192)
f9b2d7f2252ab5d47862c61d46605de392a2232b
152a6c43b6c61607cc91d5285f94dbef2575ff4f
diff --git a/cblas.h b/cblas.h index 8a5055cf83..ade2fca3a1 100644 --- a/cblas.h +++ b/cblas.h @@ -12,6 +12,7 @@ extern "C" { /*Set the number of threads on runtime.*/ void openblas_set_num_threads(int num_threads); void goto_set_num_threads(int num_threads); +int openblas_set_num_threads_local(int num_threads); ...
[ "cblas.h", "common_thread.h", "driver/others/blas_server.c", "driver/others/blas_server_omp.c", "driver/others/blas_server_win32.c", "driver/others/openblas_set_num_threads.c" ]
[]
true
OpenMathLib/OpenBLAS
5,802
issue_to_patch
Makefile.power: allow using power10 instructions
OpenBLAS uses various power9 and power10 instructions and they fail to build with errors like in https://github.com/OpenMathLib/OpenBLAS/issues/4793. Just allow the latest ISA, it will generate the same code, but actually allow the binaries to be assembled.
45e5426e1cfcf797221439cb10184bd449c40e86
627153fcdb2f9eac8ef23f765bdbbfe24502a3e7
diff --git a/Makefile.power b/Makefile.power index 97a466d138..6c5b556de1 100644 --- a/Makefile.power +++ b/Makefile.power @@ -111,7 +111,7 @@ endif endif ifeq ($(C_COMPILER), CLANG) -CCOMMON_OPT += -fno-integrated-as +CCOMMON_OPT += -fno-integrated-as -Wa,-mpower10 endif # workaround for C->FORTRAN ABI violation...
[ "Makefile.power" ]
[]
true
OpenMathLib/OpenBLAS
5,800
issue_to_patch
provide a NEON version of arm/sgemm
Surprisingly OpenBLAS lacks NEON optimized kernels for armv7, even though it auto-enables NEON during build by default (passes `-mfpu=neon` to the compiler, meaning the compiler will use NEON instructions wherever it can). The speedup on Cortex-A76 is significant, before: ``` M= 200, N= 200, K= 200 : 9262.97 ...
45e5426e1cfcf797221439cb10184bd449c40e86
fc9d7c7fe3db87bea9390eb62e25f281967e322e
diff --git a/kernel/arm/KERNEL.ARMV7 b/kernel/arm/KERNEL.ARMV7 index 5e0b4cfb81..82f06fe79a 100644 --- a/kernel/arm/KERNEL.ARMV7 +++ b/kernel/arm/KERNEL.ARMV7 @@ -8,7 +8,7 @@ ZNRM2KERNEL = nrm2_vfpv3.S SGEMVNKERNEL = gemv_n_vfpv3.S DGEMVNKERNEL = gemv_n_vfpv3.S -SGEMMKERNEL = sgemm_kernel_4x4_vfpv3.S +SGEMMKER...
[ "kernel/arm/KERNEL.ARMV7", "kernel/arm/sgemm_kernel_4x4_vfpv3_neon.S" ]
[]
true
OpenMathLib/OpenBLAS
5,799
issue_to_patch
Fix inclusion of ARMV9SME in OSX DYNAMIC_ARCH builds with CMake and gcc
fixes an inconsistency introduced with my #5793
7b7aaac822700696e5d3ad4fb22ad79c9a46250f
373fa9da05089f338a3abc92279b5b5637d0bb83
diff --git a/cmake/arch.cmake b/cmake/arch.cmake index c849b72f42..0337e16cda 100644 --- a/cmake/arch.cmake +++ b/cmake/arch.cmake @@ -58,7 +58,10 @@ if (DYNAMIC_ARCH) if (${CMAKE_SYSTEM_NAME} STREQUAL "Darwin" OR ${CMAKE_SYSTEM_NAME} STREQUAL "iOS") set(DYNAMIC_CORE ARMV8 NEOVERSEN1) if (${CMAKE_C_C...
[ "cmake/arch.cmake" ]
[]
true
OpenMathLib/OpenBLAS
5,798
issue_to_patch
Restore WoA compatibility fix in dynamic_arm64.c
inadvertently dropped in #5719 when reworking VORTEX support, noticed in #5713
8bc50c45acb2d5fbd1e4d3d543b28a87d7eddfc8
7324f370bf9c91a79445a0f4d9584297281eaf59
diff --git a/driver/others/dynamic_arm64.c b/driver/others/dynamic_arm64.c index 6e997eba8a..0fdf72d56a 100644 --- a/driver/others/dynamic_arm64.c +++ b/driver/others/dynamic_arm64.c @@ -38,7 +38,13 @@ /*********************************************************************/ #include "common.h" + +#ifndef _MSC_VER #...
[ "driver/others/dynamic_arm64.c" ]
[]
true
OpenMathLib/OpenBLAS
5,796
issue_to_patch
Use FEXTRALIB in test Makefile
See https://github.com/OpenMathLib/OpenBLAS/issues/5795. When the compiler toolchain is not the same for C/C++ and fortran, the linker can fail to resolve the `gfortran` library. Fix was found by Claude.
416008431f6f548ce771968e2943568efa868fc3
88705a932831c0de1ed136b461c6c239802828b2
[ "test/Makefile" ]
[]
diff --git a/test/Makefile b/test/Makefile index 230ee8ef23..73d763a2f5 100644 --- a/test/Makefile +++ b/test/Makefile @@ -473,24 +473,24 @@ endif ifeq ($(BUILD_BFLOAT16),1) test_bgemm : compare_sgemm_bgemm.c test_helpers.h ../$(LIBNAME) - $(CC) $(CLDFLAGS) -DIBFLOAT16 -DOBFLOAT16 -o test_bgemm compare_sgemm_bgemm....
true
OpenMathLib/OpenBLAS
5,793
issue_to_patch
macOS with CMake + Ninja unfortunately still doesn't work 100% Yesterday I reported #5768, indicating that building OpenBLAS on macOS with Ninja worked for me in the "out of the box" configuration, so the workaround would only be needed for the Makefile variant. A colleague of mine unfortunately ran into a problem (w...
Reduce the default list of DYNAMIC_ARCH targets for ARM64-based Apple systems
fixes #5775 by removing irrelevant kernels from the list of files to build and link
08a67c87e4754eac64f68d4c76bb45ece359594f
bd3cd916a5a5174595df9219058f1bba5d5d3437
diff --git a/Makefile.system b/Makefile.system index 4b1535f875..11d7f2279e 100644 --- a/Makefile.system +++ b/Makefile.system @@ -738,6 +738,20 @@ DYNAMIC_CORE += THUNDERX2T99 DYNAMIC_CORE += TSV110 DYNAMIC_CORE += EMAG8180 DYNAMIC_CORE += THUNDERX3T110 + +ifeq ($(OSNAME), Darwin) +DYNAMIC_CORE = ARMV8 +DYNAMIC_CO...
[ "Makefile.system", "cmake/arch.cmake", "driver/others/dynamic_arm64.c" ]
[]
true
OpenMathLib/OpenBLAS
5,791
issue_to_patch
Fix Apple platform detection and iOS cross-build
This PR fixes Apple platform detection and iOS cross-build instructions. The main issue is that Apple clang defines `TARGET_OS_IPHONE` on macOS as well, but with value `0`. The previous detection only checked whether the macro was defined, so macOS builds could be identified as iOS. This PR checks the macro value...
4e5c4bf567f2ecf51dd90bd273e194437d9bff0c
6419432e7d8d80ef7b1ec6036919bd743be6527d
diff --git a/.github/workflows/apple_m.yml b/.github/workflows/apple_m.yml index 54cdfb4e20..b50f9be5b5 100644 --- a/.github/workflows/apple_m.yml +++ b/.github/workflows/apple_m.yml @@ -244,15 +244,12 @@ jobs: - name: Crossbuild to iOS run: | - #brew install llvm - #export #PATH=/op...
[ ".github/workflows/apple_m.yml", "Makefile", "c_check", "c_check.pl", "ctest.c", "docs/install.md" ]
[]
true
OpenMathLib/OpenBLAS
5,792
issue_to_patch
0.3.33 test failure in cblat2 on x86-32 0.3.33 fails to build on Debian `i386` architecture (32-bit x86, which despite its name now corresponds to a minimal requirement of Pentium 4). The error is the following: ``` Program received signal SIGSEGV: Segmentation fault - invalid memory reference. Backtrace for this er...
Fix 32bit builds on AMD Ryzen by mapping to NEHALEM rather than BARCELONA
fixes #5787 - I cannot determine if there are actual errors in the Barcelona TRSM kernels as I do not have access to old AMD hardware from the pre-Ryzen era, but if so, they would have been silently broken since the days of GotoBLAS, which seems unlikely.
c8dbfd74e2aa40563b11989d16aeb9b3828c16f4
f90b0d5bc5caaacb5c23b73e618220af704008e0
diff --git a/.github/workflows/dynamic_arch.yml b/.github/workflows/dynamic_arch.yml index 610c8cc246..5c39a7d407 100644 --- a/.github/workflows/dynamic_arch.yml +++ b/.github/workflows/dynamic_arch.yml @@ -196,29 +196,29 @@ jobs: - msystem: UCRT64 idx: int32 target-prefix: mingw-w6...
[ ".github/workflows/dynamic_arch.yml", "Makefile.system", "cmake/system.cmake" ]
[]
true
OpenMathLib/OpenBLAS
5,789
issue_to_patch
Fix compilation with DYNAMIC_TARGET=1 and BUILD_BFLOAT16
coremsg isn't defined outside the BUILD_BFLOAT16 and BUILD_HFLOAT16 blocks, leading to the use of an undefined variable
1ecfee24b336b8c6a8dab9a9039d2ed4980ddd6c
43aa35c2ef4fe03e2d9111fc077d0553b17b7f31
diff --git a/driver/others/dynamic_riscv64.c b/driver/others/dynamic_riscv64.c index 321e0875f0..ec7fe8f55e 100644 --- a/driver/others/dynamic_riscv64.c +++ b/driver/others/dynamic_riscv64.c @@ -152,6 +152,7 @@ char* gotoblas_corename(void) { static gotoblas_t* get_coretype(void) { uint64_t vector_mask; unsigned v...
[ "driver/others/dynamic_riscv64.c" ]
[]
true
OpenMathLib/OpenBLAS
5,790
issue_to_patch
PPC970: 6954845d8 breaks build FreeBSD 15.0-RELEASE, powerpc64, PPC970 ``` TEST 41/123 zscal:i00_NAN_incx_2 [FAIL] ERR: test_zscal.c:639 should be true TEST 42/123 zscal:i00_NAN [FAIL] ERR: test_zscal.c:625 should be true TEST 53/123 cscal:i00_NAN_incx_2 [FAIL] ERR: test_zscal.c:466 should be true TEST 54/12...
Correct offsets in PowerPC SCAL assembly under FreeBSD and re-enable for PPC970
should fix #5627 for good
1ecfee24b336b8c6a8dab9a9039d2ed4980ddd6c
33c14c66c79f61e2b0b8ad9f2c0a9d2f8bfb80ff
diff --git a/kernel/power/KERNEL.PPC970 b/kernel/power/KERNEL.PPC970 index 597ed9e5f7..0c8b473320 100644 --- a/kernel/power/KERNEL.PPC970 +++ b/kernel/power/KERNEL.PPC970 @@ -90,9 +90,3 @@ CROTKERNEL = ../arm/zrot.c ZROTKERNEL = ../arm/zrot.c endif -ifeq ($(OSNAME), FreeBSD) -SSCALKERNEL = ../arm/scal.c -DSCAL...
[ "kernel/power/KERNEL.PPC970", "kernel/power/scal.S", "kernel/power/zscal.S" ]
[]
true
OpenMathLib/OpenBLAS
5,788
issue_to_patch
CI: Move NeoverseN1 jobs from deprecated Cirrus to gh workflows
d4824562d9eeb0ccf97727a742be881a91abc735
75791e4d0aaa7f12970256a8154773083c746220
diff --git a/.cirrus.yml b/.cirrus.yml index 7481d4bfd2..69ef300bb9 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,6 +1,6 @@ -macos_instance: - image: ghcr.io/cirruslabs/macos-monterey-xcode:latest - +#macos_instance: +# image: ghcr.io/cirruslabs/macos-monterey-xcode:latest +# #task: # name: AppleM1/LLVM # com...
[ ".cirrus.yml", ".github/workflows/dynamic_arch.yml" ]
[]
true
OpenMathLib/OpenBLAS
5,786
issue_to_patch
GH runner macos: Add cross-compilation to x86_64 based on the Cirrus CI job
10cf63eea44f53176444c3767c0a5a8843e91485
a8974e0f7a1dc903b563876664e1f4734453fbdd
diff --git a/.github/workflows/apple_m.yml b/.github/workflows/apple_m.yml index f64fe10216..54cdfb4e20 100644 --- a/.github/workflows/apple_m.yml +++ b/.github/workflows/apple_m.yml @@ -10,7 +10,7 @@ permissions: contents: read # to fetch code (actions/checkout) jobs: - build: + build-windows: if: "github...
[ ".github/workflows/apple_m.yml" ]
[]
true
OpenMathLib/OpenBLAS
5,784
issue_to_patch
Loongarch64: Incorrect LSX/LASX CPU feature detection These lines: https://github.com/OpenMathLib/OpenBLAS/blob/2347cdd77f4b8f4879f5c493de4e0e04f6a39bb3/cpuid_loongarch64.c#L398-L399 use the function itself instead of its call result to detect LSX/LASX features: https://github.com/OpenMathLib/OpenBLAS/blob/2347cdd7...
Fix printing of Loongarch LSX/LASX status to the config file
fixes #5783
2347cdd77f4b8f4879f5c493de4e0e04f6a39bb3
0a3e061977cc99ee60dd213729d5eb216e892911
diff --git a/cpuid_loongarch64.c b/cpuid_loongarch64.c index c6ce2bb731..71647fe922 100644 --- a/cpuid_loongarch64.c +++ b/cpuid_loongarch64.c @@ -395,8 +395,8 @@ void get_cpuconfig(void) { } } - if(os_support_lsx) printf("#define HAVE_LSX\n"); - if(os_support_lasx) printf("#define HAVE_LASX\n"); + if(os_...
[ "cpuid_loongarch64.c" ]
[]
true
OpenMathLib/OpenBLAS
5,781
issue_to_patch
Add AVX2 capability check to generic Zhaoxin cpu autodetection
05ecfc6d4724c203f70d02b39f500a17b9e836a6
feca8f994dcb97c8ae9e9d64b2b36dbb5b93a4f7
diff --git a/cpuid_x86.c b/cpuid_x86.c index 0daf2b3cc8..b68a5202c2 100644 --- a/cpuid_x86.c +++ b/cpuid_x86.c @@ -1843,9 +1843,11 @@ int get_cpuname(void) if (support_avx2()) return CPUTYPE_ZEN; else return CPUTYPE_DUNNINGTON; default: + if (support_avx2()) return CPUTYPE_ZEN; ...
[ "cpuid_x86.c", "driver/others/dynamic.c" ]
[]
true
OpenMathLib/OpenBLAS
5,780
issue_to_patch
Calculate LWORK in CUNMLQ K=0 case like ZUNMLQ (Reference-LAPACK PR 1225)
05ecfc6d4724c203f70d02b39f500a17b9e836a6
0b3b4866060cf64e166f3020709e03da8b14b5c6
diff --git a/lapack-netlib/SRC/cunmlq.f b/lapack-netlib/SRC/cunmlq.f index 4da1af1d5b..d80e31758a 100644 --- a/lapack-netlib/SRC/cunmlq.f +++ b/lapack-netlib/SRC/cunmlq.f @@ -5,7 +5,6 @@ * Online html documentation available at * http://www.netlib.org/lapack/explore-html/ * -*> \htmlonly *> Download CUNM...
[ "lapack-netlib/SRC/cunmlq.f" ]
[]
true
OpenMathLib/OpenBLAS
5,779
issue_to_patch
`make[1]: warning: -j256 forced in makefile: resetting jobserver mode.` OpenBLAS 0.3.33, GNU Make 4.4 $ make -j300 DYNAMIC_ARCH=1 NO_LAPACKE=1 PREFIX=/usr EPREFIX=/usr BINDIR=/usr/bin SBINDIR=/usr/sbin LIBEXECDIR=/usr/libexec SYSCONFDIR=/etc SHAREDSTATEDIR=/var LOCALSTATEDIR=/var LIBDIR=/usr/lib INCLUDEDIR=/usr/i...
Keep getarch from generating a conflicting -j argument for gmake
Automates the present kludge of setting MAKE_NB_JOBS=-1 to suppress the automatic generation of a MAKEFLAGS entry in Makefile.conf. Fixes #5778
a8469771b5452ef8e20549e1c1a0d56a850bcc4f
a90ffae6b239c1ebdfe456d36e9040b7f14495df
diff --git a/Makefile.system b/Makefile.system index ab463f53db..e7638755df 100644 --- a/Makefile.system +++ b/Makefile.system @@ -247,6 +247,11 @@ NO_PARALLEL_MAKE=0 endif GETARCH_FLAGS += -DNO_PARALLEL_MAKE=$(NO_PARALLEL_MAKE) +ifndef MAKE_NB_JOBS +ifneq (,$(patsubst -j%,%,$(filter -j%,$(MAKEFLAGS)))) +MAKE_NB_JO...
[ "Makefile.system" ]
[]
true
OpenMathLib/OpenBLAS
5,777
issue_to_patch
[ci] Update GitHub Actions to latest major release
Fixes deprecations warnings that Node20.js will stop working in June.
3c553ef70522d03b0f2acb21979036b4d40c07bb
91f83f00b95b24777e77a762c802141726da40a0
diff --git a/.github/workflows/apple_m.yml b/.github/workflows/apple_m.yml index 4f73e2bc0b..f64fe10216 100644 --- a/.github/workflows/apple_m.yml +++ b/.github/workflows/apple_m.yml @@ -24,7 +24,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: action...
[ ".github/workflows/apple_m.yml", ".github/workflows/arm64_graviton.yml", ".github/workflows/c910v.yml", ".github/workflows/codspeed-bench.yml", ".github/workflows/docs.yml", ".github/workflows/dynamic_arch.yml", ".github/workflows/harmonyos.yml", ".github/workflows/loongarch64.yml", ".github/workflo...
[]
true
OpenMathLib/OpenBLAS
5,712
issue_to_patch
Fix incorrect cast from BF16 to FP32 in SBGEMM
This change fixes a regression in SBGEMM where C is assumed to be BF16, and so unconditionally attempts to cast elements of C from BF16 to FP32 resulting in incorrect outputs when beta=1.
1f1fcd4927dc6d6e8a5ae3f151d4435fbe4c2143
f6d4fe703b0148c0ffe45eea7f9290be2ce32257
diff --git a/kernel/generic/gemmkernel_2x2.c b/kernel/generic/gemmkernel_2x2.c index 07da2cbc87..94dcaea5f3 100644 --- a/kernel/generic/gemmkernel_2x2.c +++ b/kernel/generic/gemmkernel_2x2.c @@ -30,6 +30,12 @@ #include "conversion_macros.h" +#ifdef BGEMM +#define C_TO_F32 TO_F32 +#else +#define C_TO_F32 +#endif + ...
[ "kernel/generic/gemmkernel_2x2.c" ]
[]
true
OpenMathLib/OpenBLAS
5,776
issue_to_patch
CMake: properly fix build on macOS with Ninja (cf. to response files)
On macOS several build-related programs (`cc`, `ar`) will not accept the linker line if too many files have been added to it in the DYNAMIC_ARCH case. (This now occurs on all platforms where macOS runs / used to run, as there are enough ARM variants that are build with DYNAMIC_ARCH that the number of files exceeds the ...
3c553ef70522d03b0f2acb21979036b4d40c07bb
ca4d867cbbc7896715ddceb142e7fef3945fd6ed
diff --git a/CMakeLists.txt b/CMakeLists.txt index 9d2d539b4c..5f5fffe43d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -243,6 +243,30 @@ if (${DYNAMIC_ARCH}) endforeach() endif () +# Work around Apple issue with "argument list too long" when linking. +# Seen for DYNAMIC_ARCH when there are a _LOT_ of varia...
[ "CMakeLists.txt" ]
[]
true
OpenMathLib/OpenBLAS
5,774
issue_to_patch
merge back from release branch to copy tag
b0a0364be74df03f0c4e5f52a856f05b8c0d1992
62bcfb0dc9f1cfa685fc04135c50e2780c303137
diff --git a/Makefile.rule b/Makefile.rule index ac22da851e..6d778ead2d 100644 --- a/Makefile.rule +++ b/Makefile.rule @@ -3,7 +3,7 @@ # # This library's version -VERSION = 0.3.32.dev +VERSION = 0.3.33 # If you set this prefix, the library name will be lib$(LIBNAMESUFFIX)openblas.a # and lib$(LIBNAMESUFFIX)open...
[ "Makefile.rule" ]
[]
true