repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
NousResearch/hermes-agent
42,480
issue_to_patch
feat(desktop): add curated completion cue for agent turn completion
## Summary Replaces the desktop turn-end haptic with a curated **Web Audio completion sound** and a Settings picker. All cues are synthesized at runtime (oscillator/noise voices → low-pass → short convolution reverb) — no shipped audio assets. - **Sound bank** (`lib/completion-sound.ts`): 14 presets (two-note comfort...
6b76284c7769e0ca80012a5a4b7e22b1cea05b6b
4c09e00feba593276959b9c278dec636a0e96d12
diff --git a/apps/desktop/src/app/session/hooks/use-message-stream.ts b/apps/desktop/src/app/session/hooks/use-message-stream.ts index 2ccf73aa41b0..447fc150d825 100644 --- a/apps/desktop/src/app/session/hooks/use-message-stream.ts +++ b/apps/desktop/src/app/session/hooks/use-message-stream.ts @@ -15,6 +15,7 @@ import ...
[ "apps/desktop/src/app/session/hooks/use-message-stream.ts", "apps/desktop/src/app/settings/appearance-settings.tsx", "apps/desktop/src/i18n/en.ts", "apps/desktop/src/i18n/ja.ts", "apps/desktop/src/i18n/types.ts", "apps/desktop/src/i18n/zh-hant.ts", "apps/desktop/src/i18n/zh.ts", "apps/desktop/src/lib/...
[]
true
NousResearch/hermes-agent
45,948
issue_to_patch
perf(execute-code): stop waiting on idle RPC accept
## Summary `execute_code` now exits promptly for no-tool scripts instead of waiting on the idle RPC listener accept timeout during cleanup. ## Changes - `tools/code_execution_tool.py`: add a `stop_event` to the RPC listener thread so cleanup can stop an idle `accept()` loop immediately after the child process exits. -...
7aaae7acd0d6f80aba9fbe15324a1c907ec70c55
8d73735629d44f12dce756c3d38e6ff75d653701
diff --git a/tools/code_execution_tool.py b/tools/code_execution_tool.py index 76deef2e5c1b..9c87488aa397 100644 --- a/tools/code_execution_tool.py +++ b/tools/code_execution_tool.py @@ -472,6 +472,7 @@ def _rpc_server_loop( tool_call_counter: list, # mutable [int] so the thread can increment max_tool_calls...
[ "tests/tools/test_code_execution.py", "tools/code_execution_tool.py" ]
[]
diff --git a/tests/tools/test_code_execution.py b/tests/tools/test_code_execution.py index bcb46136b7a2..3521d19ea191 100644 --- a/tests/tools/test_code_execution.py +++ b/tests/tools/test_code_execution.py @@ -17,6 +17,7 @@ import json import os +import time os.environ["TERMINAL_ENV"] = "local" @@ -199,6 +200...
true
NousResearch/hermes-agent
45,951
issue_to_patch
[Feature]: Add ability to remove provider accounts ### Problem or Use Case I can connect an account in the Accounts pane, but there seems to be no way to disconnect the account in the UI. <img width="1220" height="802" alt="Image" src="https://github.com/user-attachments/assets/2ce6a8ef-4510-40fd-af45-f11c10ccb6ba"...
fix: add safe provider account removal
## Summary Desktop Accounts can now remove Hermes-managed provider accounts without pretending to remove credentials owned by external CLIs or API-key settings. Fixes #45865. Salvages #45910, preserving @itsflownium's original account-removal UI commit. ## Changes - Accounts pane: shows the remove action only when th...
8d5d36d793583fbdc679d880674268178ed9b81b
33399fbc1e1a08f5c4a352b5e03425e8e8cd8a5b
diff --git a/apps/desktop/src/app/settings/providers-settings.tsx b/apps/desktop/src/app/settings/providers-settings.tsx index 7f803eff321a..f1132e6c33d3 100644 --- a/apps/desktop/src/app/settings/providers-settings.tsx +++ b/apps/desktop/src/app/settings/providers-settings.tsx @@ -1,18 +1,20 @@ import { useStore } fr...
[ "apps/desktop/src/app/settings/providers-settings.test.tsx", "apps/desktop/src/app/settings/providers-settings.tsx", "apps/desktop/src/components/desktop-onboarding-overlay.tsx", "apps/desktop/src/hermes.ts", "apps/desktop/src/i18n/en.ts", "apps/desktop/src/i18n/ja.ts", "apps/desktop/src/i18n/types.ts",...
[]
diff --git a/apps/desktop/src/app/settings/providers-settings.test.tsx b/apps/desktop/src/app/settings/providers-settings.test.tsx new file mode 100644 index 000000000000..8379d203f6c1 --- /dev/null +++ b/apps/desktop/src/app/settings/providers-settings.test.tsx @@ -0,0 +1,100 @@ +import { cleanup, fireEvent, render, s...
true
NousResearch/hermes-agent
45,953
issue_to_patch
feat(telegram): restore rich messages opt-out
## Summary Restores `telegram.extra.rich_messages` as a default-on opt-out for Telegram clients that cannot render Bot API rich messages. Salvages the client-compatibility behavior from #45840 while keeping the public knob in the old positive form: missing key / `true` uses rich messages, `false` forces legacy Markdow...
8d5d36d793583fbdc679d880674268178ed9b81b
10f6c5df0a2bb47bcfe7e52020178759f9baab81
diff --git a/cli-config.yaml.example b/cli-config.yaml.example index 8ce9ad8e19ac..b1e469479535 100644 --- a/cli-config.yaml.example +++ b/cli-config.yaml.example @@ -719,6 +719,7 @@ platform_toolsets: # # allowed_chats: ["-1001234567890"] # extra: # disable_link_previews: false # Set true to suppress...
[ "cli-config.yaml.example", "gateway/platforms/telegram.py", "hermes_cli/config.py", "tests/gateway/test_config.py", "tests/gateway/test_telegram_rich_messages.py", "website/docs/user-guide/messaging/telegram.md", "website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/user-guide/messaging/telegram....
[]
diff --git a/tests/gateway/test_config.py b/tests/gateway/test_config.py index 267e2a20214a..cae1d8e13e12 100644 --- a/tests/gateway/test_config.py +++ b/tests/gateway/test_config.py @@ -813,6 +813,37 @@ def test_bridges_telegram_disable_link_previews_from_config_yaml(self, tmp_path, assert config.platforms[...
true
NousResearch/hermes-agent
28,479
issue_to_patch
fix(dispatch): pass session_id into registry.dispatch
## Problem `handle_function_call` receives `session_id` as a parameter (line 746) and already passes `task_id` into `registry.dispatch`, but `session_id` is silently dropped at the two dispatch call sites (lines 836 and 842). Plugins and dispatch-layer hooks that need to correlate calls with the active session receive...
819def44c71e8b3ca163f79facdb4603a0cc6957
928932e6ec699dbeb91f131b60cac310e1677a70
diff --git a/model_tools.py b/model_tools.py index 22719a5daef0..0618138aa9a8 100644 --- a/model_tools.py +++ b/model_tools.py @@ -1115,6 +1115,7 @@ def _dispatch(next_args: Dict[str, Any]) -> Any: return registry.dispatch( function_name, next_args, ...
[ "model_tools.py", "tests/test_dispatch_session_id.py" ]
[]
diff --git a/tests/test_dispatch_session_id.py b/tests/test_dispatch_session_id.py new file mode 100644 index 000000000000..69a6e592f0a0 --- /dev/null +++ b/tests/test_dispatch_session_id.py @@ -0,0 +1,75 @@ +"""Tests that handle_function_call forwards session_id into registry.dispatch.""" + +import json +from unittest...
true
NousResearch/hermes-agent
45,681
issue_to_patch
fix(ssl): surface broken CA bundles before provider calls
## Summary Hermes now detects broken CA bundle paths before provider client creation, turning the opaque OpenAI/httpx `[Errno 2] No such file or directory` crash into a clear SSL repair message. ## Changes - `agent/ssl_guard.py`: validate explicit CA bundle env vars and certifi's bundled `cacert.pem`. - `agent/agent_i...
78c11d99e35b111dd6198d8bc6aa1f7f6f168232
56006119063e6b794bd31c95427ceae6c0c71715
diff --git a/agent/agent_init.py b/agent/agent_init.py index 4b57c82d4a15..e1594b4585d4 100644 --- a/agent/agent_init.py +++ b/agent/agent_init.py @@ -900,6 +900,9 @@ def init_agent( agent.api_key = client_kwargs.get("api_key", "") agent.base_url = client_kwargs.get("base_url", agent.base_url) ...
[ "agent/agent_init.py", "agent/errors.py", "agent/ssl_guard.py", "docs/rca-ssl-cacert-post-git-pull.md", "hermes_cli/doctor.py", "pyproject.toml", "scripts/release.py", "tests/agent/test_ssl_ca_guard.py", "uv.lock" ]
[ { "comment": "Do we want to add this file? We have no top-level docs in this directory so I think we should remove this", "path": "docs/rca-ssl-cacert-post-git-pull.md", "hunk": "", "resolving_sha": "56006119063e6b794bd31c95427ceae6c0c71715", "resolving_diff": "diff --git a/docs/rca-ssl-cacert-p...
diff --git a/tests/agent/test_ssl_ca_guard.py b/tests/agent/test_ssl_ca_guard.py new file mode 100644 index 000000000000..983a00a93b07 --- /dev/null +++ b/tests/agent/test_ssl_ca_guard.py @@ -0,0 +1,82 @@ +"""Tests for the preventive SSL CA bundle guard.""" + +from pathlib import Path + +import certifi +import pytest +...
true
NousResearch/hermes-agent
45,831
issue_to_patch
perf(process): wake waiters on background completion
## Summary `process(action="wait")` now wakes as soon as a background process is moved to finished instead of waiting for the next 1-second polling tick. ## Changes - `tools/process_registry.py`: add a per-session completion event, signal it from `_move_to_finished()`, and have `wait()` block on the event with the exi...
817f39231145bbb24eb57b8b2835cb00c91e87ed
ee0c24dad48e733d976cd6d6012a59501dd0c962
diff --git a/tools/process_registry.py b/tools/process_registry.py index 59fcf4a4462e..932669699832 100644 --- a/tools/process_registry.py +++ b/tools/process_registry.py @@ -129,6 +129,7 @@ class ProcessSession: _watch_cooldown_until: float = field(default=0.0, repr=False) _watch_strike_candidate: bool = fie...
[ "tests/tools/test_process_registry.py", "tools/process_registry.py" ]
[]
diff --git a/tests/tools/test_process_registry.py b/tests/tools/test_process_registry.py index 6a95e46b7e18..da48183d462c 100644 --- a/tests/tools/test_process_registry.py +++ b/tests/tools/test_process_registry.py @@ -5,6 +5,7 @@ import signal import subprocess import sys +import threading import time import pyte...
true
NousResearch/hermes-agent
45,853
issue_to_patch
fix(desktop): surface off-screen approvals via the jump-to-bottom control
## Summary Supersedes #45828. A blocked approval (dangerous `terminal` / `execute_code`) has exactly one response surface: the inline Run/Reject bar on the pending tool row. If the user scrolls that row out of view, the turn looks stalled with no visible way to act. This **morphs the existing scroll-to-bottom contro...
4026f526d5a6160b0c444de4030096f7c959116f
9f3722d35df54e759ae07f471c9fc3a924e4f3a5
diff --git a/apps/desktop/src/app/chat/scroll-to-bottom-button.tsx b/apps/desktop/src/app/chat/scroll-to-bottom-button.tsx index b5d947ac18cf..dfe8b4e4d0b7 100644 --- a/apps/desktop/src/app/chat/scroll-to-bottom-button.tsx +++ b/apps/desktop/src/app/chat/scroll-to-bottom-button.tsx @@ -5,6 +5,7 @@ import { Codicon } fr...
[ "apps/desktop/src/app/chat/scroll-to-bottom-button.test.tsx", "apps/desktop/src/app/chat/scroll-to-bottom-button.tsx", "apps/desktop/src/i18n/en.ts", "apps/desktop/src/i18n/ja.ts", "apps/desktop/src/i18n/types.ts", "apps/desktop/src/i18n/zh-hant.ts", "apps/desktop/src/i18n/zh.ts" ]
[]
diff --git a/apps/desktop/src/app/chat/scroll-to-bottom-button.test.tsx b/apps/desktop/src/app/chat/scroll-to-bottom-button.test.tsx new file mode 100644 index 000000000000..f163ec848194 --- /dev/null +++ b/apps/desktop/src/app/chat/scroll-to-bottom-button.test.tsx @@ -0,0 +1,67 @@ +import { cleanup, fireEvent, render,...
true
NousResearch/hermes-agent
45,837
issue_to_patch
[Bug]: skill-update backup handling can corrupt or silently lose skills (stale/orphaned .bak interactions) ### Bug Description Follow-up to #34860, and distinct from #35131. That issue covered the backup cleanup failing silently. These are three remaining defects in how the bundled-update path in `tools/skills_sync.p...
fix(skills): make bundled-update backup handling crash-safe
## Summary Bundled skill updates now recover safely from stale, orphaned, or partial `.bak` state instead of losing or wedging skills. Cherry-picks and preserves @MaxFreedomPollard's PR #44951, with one follow-up release author-map entry for `max@c60spaceship.com`. ## Changes - `tools/skills_sync.py`: recover orphane...
bf8effad023b275aca2ea4b674efc45f4ba7e88f
6e25188c1caa69fe0419f46c0dfade5c4c9a23ef
diff --git a/scripts/release.py b/scripts/release.py index 6395b776216f..d451e9413d48 100755 --- a/scripts/release.py +++ b/scripts/release.py @@ -81,6 +81,7 @@ "290859878+synapsesx@users.noreply.github.com": "synapsesx", "157689911+itsflownium@users.noreply.github.com": "itsflownium", "dirtyren@users.no...
[ "scripts/release.py", "tests/tools/test_skills_sync.py", "tools/skills_sync.py" ]
[]
diff --git a/tests/tools/test_skills_sync.py b/tests/tools/test_skills_sync.py index 6711b3bb2f65..6be3e3705e82 100644 --- a/tests/tools/test_skills_sync.py +++ b/tests/tools/test_skills_sync.py @@ -1,5 +1,6 @@ """Tests for tools/skills_sync.py — manifest-based skill seeding and updating.""" +import shutil import j...
true
NousResearch/hermes-agent
43,852
issue_to_patch
fix(utils): EXDEV/EBUSY copy fallback in atomic_replace (port from gemini-cli#21541)
## Summary `atomic_replace()` now falls back to copy + fsync + unlink when `os.replace()` fails with EXDEV (cross-device link) or EBUSY (busy bind mount), instead of crashing every atomic write site. Port of the rename-fallback pattern from google-gemini/gemini-cli#21541 (their policy-file persistence hit the same fai...
4373e802a1b90150b131b459c52e84ada2e70d06
3cc8909908bac98aee7e40204559eed5be0a47df
diff --git a/utils.py b/utils.py index 4ab94f18612a..ad7f28f8dba7 100644 --- a/utils.py +++ b/utils.py @@ -1,8 +1,10 @@ """Shared utility functions for hermes-agent.""" +import errno import json import logging import os +import shutil import stat import tempfile from pathlib import Path @@ -71,14 +73,38 @@ def...
[ "tests/test_atomic_replace_symlinks.py", "utils.py" ]
[]
diff --git a/tests/test_atomic_replace_symlinks.py b/tests/test_atomic_replace_symlinks.py index f6b849183294..594401d05654 100644 --- a/tests/test_atomic_replace_symlinks.py +++ b/tests/test_atomic_replace_symlinks.py @@ -12,6 +12,7 @@ """ from __future__ import annotations +import errno import json import os i...
true
NousResearch/hermes-agent
37,082
issue_to_patch
feat(read): extract .ipynb/.docx/.xlsx to text in read_file
## Summary `read_file` can now read Jupyter notebooks, Word documents, and Excel workbooks directly — they're auto-extracted to plain text instead of being rejected as binary (`.docx`/`.xlsx`) or dumping raw JSON with output payloads (`.ipynb`). Ports the structured-document reading Kilo Code added in [Kilo-Org/kiloco...
4373e802a1b90150b131b459c52e84ada2e70d06
b7ab168fa7dc6348a09f958a848c7685f17d8387
diff --git a/tools/file_tools.py b/tools/file_tools.py index 4703cb4e5f79..c0b2fd066287 100644 --- a/tools/file_tools.py +++ b/tools/file_tools.py @@ -760,6 +760,52 @@ def read_file_tool(path: str, offset: int = 1, limit: int = 500, task_id: str = _resolved = _resolve_path_for_task(path, task_id) + ...
[ "tests/tools/test_read_extract.py", "tools/file_tools.py", "tools/read_extract.py" ]
[]
diff --git a/tests/tools/test_read_extract.py b/tests/tools/test_read_extract.py new file mode 100644 index 000000000000..3757e03c43b5 --- /dev/null +++ b/tests/tools/test_read_extract.py @@ -0,0 +1,295 @@ +#!/usr/bin/env python3 +""" +Tests for structured-document extraction in the read_file tool. + +Covers .ipynb / ....
true
NousResearch/hermes-agent
45,821
issue_to_patch
fix(approval): gate sensitive user-file terminal writes
## Summary Terminal approvals now catch sensitive user-file writes across absolute-home paths, copy/move/install targets, and in-place edits. This consolidates and extends PR #38075 and PR #45816 while preserving contributor authorship for @briandevans and @helix4u. ## Changes - `tools/approval.py`: rewrite the curre...
0a865e5948cb836eba93620e365703ec38cf76e3
322a508cfc9458bb6290d3cfc0929b2db969c2b1
diff --git a/tools/approval.py b/tools/approval.py index 3baf1fd10d5c..6ed1fb9cbcd9 100644 --- a/tools/approval.py +++ b/tools/approval.py @@ -208,6 +208,11 @@ def _is_gateway_approval_context() -> bool: rf'{_SHELL_RC_FILES}|' rf'{_CREDENTIAL_FILES})' ) +_USER_SENSITIVE_WRITE_TARGET = ( + rf'(?:{_SSH_SENS...
[ "tests/tools/test_approval.py", "tools/approval.py" ]
[]
diff --git a/tests/tools/test_approval.py b/tests/tools/test_approval.py index b75983807089..b37d57555fb9 100644 --- a/tests/tools/test_approval.py +++ b/tests/tools/test_approval.py @@ -369,6 +369,12 @@ def test_tee_hermes_env(self): assert dangerous is True assert key is not None + def test_tee...
true
NousResearch/hermes-agent
36,142
issue_to_patch
Port from nearai/ironclaw#4211: search budget hits become soft truncation
## Summary File/content searches that hit their time budget on a huge tree now return the partial results collected so far flagged as truncated, instead of failing hard or leaking the backend's timeout marker into the result. Ported in spirit from [nearai/ironclaw#4211](https://github.com/nearai/ironclaw/pull/4211), w...
4373e802a1b90150b131b459c52e84ada2e70d06
918119300f43cf06e4146a43f3e087a152a99afa
diff --git a/tools/file_operations.py b/tools/file_operations.py index 9815673eec17..1d523d703127 100644 --- a/tools/file_operations.py +++ b/tools/file_operations.py @@ -241,10 +241,11 @@ class SearchResult: counts: Dict[str, int] = field(default_factory=dict) total_count: int = 0 truncated: bool = Fals...
[ "tests/tools/test_search_budget_truncation.py", "tools/file_operations.py" ]
[]
diff --git a/tests/tools/test_search_budget_truncation.py b/tests/tools/test_search_budget_truncation.py new file mode 100644 index 000000000000..ee614285087b --- /dev/null +++ b/tests/tools/test_search_budget_truncation.py @@ -0,0 +1,133 @@ +from unittest.mock import MagicMock + +import pytest + +from tools.file_opera...
true
NousResearch/hermes-agent
45,822
issue_to_patch
Anthropic fallback can fail after Codex reasoning-only empty turns due to trailing assistant prefill ## Summary When a session starts on the Codex Responses API and then falls back to native Anthropic after repeated empty visible responses, Hermes can send Anthropic a message list ending in an assistant turn. Anthrop...
fix(agent): treat Codex reasoning items as thinking-only
## Summary Codex reasoning-only assistant turns are now recognized by the thinking-only sanitizer for non-Codex handoffs, while native Codex Responses turns still preserve encrypted reasoning replay. ## Changes - Treat non-empty `codex_reasoning_items` lists containing reasoning items as thinking-only when visible con...
0a865e5948cb836eba93620e365703ec38cf76e3
9a856fc64e4bc1a80a0ecb7c1e4b6ba92a3ba540
diff --git a/agent/agent_runtime_helpers.py b/agent/agent_runtime_helpers.py index ea71cb939461..cae1a685a537 100644 --- a/agent/agent_runtime_helpers.py +++ b/agent/agent_runtime_helpers.py @@ -881,6 +881,8 @@ def try_recover_primary_transport( def drop_thinking_only_and_merge_users( messages: List[Dict[str, A...
[ "agent/agent_runtime_helpers.py", "agent/conversation_loop.py", "run_agent.py", "tests/run_agent/test_thinking_only_sanitizer.py" ]
[]
diff --git a/tests/run_agent/test_thinking_only_sanitizer.py b/tests/run_agent/test_thinking_only_sanitizer.py index 83cf35f6d1a1..23184d0186db 100644 --- a/tests/run_agent/test_thinking_only_sanitizer.py +++ b/tests/run_agent/test_thinking_only_sanitizer.py @@ -104,6 +104,38 @@ def test_reasoning_details_list_form_det...
true
NousResearch/hermes-agent
45,824
issue_to_patch
fix(telegram): harden rich message fallback handling
## Summary Telegram rich sends now keep Bot API 10.1 fallback behavior safe across raw PTB responses, missing-endpoint errors, link preview settings, and non-ASCII rich-message lengths. Salvages the focused hardening pieces from #45741 on top of current main, without reintroducing the stale `rich_messages` opt-out or ...
0a865e5948cb836eba93620e365703ec38cf76e3
ae5836fa50c899484e7bff9876a9ffd50916690c
diff --git a/gateway/platforms/telegram.py b/gateway/platforms/telegram.py index 5bb4d5bbcbea..b8741edab998 100644 --- a/gateway/platforms/telegram.py +++ b/gateway/platforms/telegram.py @@ -1022,16 +1022,19 @@ def _is_rich_capability_error(self, exc: Exception) -> bool: rejections (BadRequest from a parser/li...
[ "gateway/platforms/telegram.py", "tests/gateway/test_telegram_rich_messages.py" ]
[]
diff --git a/tests/gateway/test_telegram_rich_messages.py b/tests/gateway/test_telegram_rich_messages.py index 70893bbd7a4f..0e2efe45cafb 100644 --- a/tests/gateway/test_telegram_rich_messages.py +++ b/tests/gateway/test_telegram_rich_messages.py @@ -25,6 +25,20 @@ # and a task list. Pipes / brackets must survive unto...
true
NousResearch/hermes-agent
45,812
issue_to_patch
fix(desktop): bypass Chromium editing pipeline for large paste & select-delete
## Summary Large paste and Ctrl+A → Delete froze the composer for seconds. Both hit Chromium's contenteditable editing pipeline (~O(n²) on multiline DOM) — a browser cost, same in prod. Fix lives in `rich-editor.ts`: - **`insertPlainTextAtCaret`** — Range + `text`/`<br>` fragment (paste) - **`deleteSelectionInEditor`*...
7c0605bf224c27dda466a1e877161da319224da6
18015591cc6c1e814f64ac407038d79e29ea3e91
diff --git a/apps/desktop/src/app/chat/composer/index.tsx b/apps/desktop/src/app/chat/composer/index.tsx index 96b8be61ef14..dc3f0a490cbc 100644 --- a/apps/desktop/src/app/chat/composer/index.tsx +++ b/apps/desktop/src/app/chat/composer/index.tsx @@ -85,6 +85,8 @@ import { import { QueuePanel } from './queue-panel' i...
[ "apps/desktop/src/app/chat/composer/index.tsx", "apps/desktop/src/app/chat/composer/rich-editor.test.ts", "apps/desktop/src/app/chat/composer/rich-editor.ts" ]
[]
diff --git a/apps/desktop/src/app/chat/composer/rich-editor.test.ts b/apps/desktop/src/app/chat/composer/rich-editor.test.ts index 45204fb34a5d..12e3e9613eff 100644 --- a/apps/desktop/src/app/chat/composer/rich-editor.test.ts +++ b/apps/desktop/src/app/chat/composer/rich-editor.test.ts @@ -3,12 +3,24 @@ import { descri...
true
NousResearch/hermes-agent
36,141
issue_to_patch
fix(gemini): strip self provider prefix before native generateContent
## Summary Self-prefixed model ids now resolve to bare native ids before the Gemini/xAI native call, so `google/gemini-2.0-flash` no longer 404s. Ported from [openclaw/openclaw#88781](https://github.com/openclaw/openclaw/pull/88781) ("strip remaining provider self prefixes"). **Root cause:** the native Gemini adapter ...
4373e802a1b90150b131b459c52e84ada2e70d06
c6f4ebca4cda5991a9a2af6daddcc8105c3189fb
diff --git a/agent/gemini_native_adapter.py b/agent/gemini_native_adapter.py index d8e6c63c48eb..a79effebba46 100644 --- a/agent/gemini_native_adapter.py +++ b/agent/gemini_native_adapter.py @@ -41,6 +41,16 @@ GEMINI_DEFAULT_MAX_OUTPUT_TOKENS = 65535 +def bare_gemini_model_id(model: str) -> str: + """Strip Gemi...
[ "agent/gemini_native_adapter.py", "hermes_cli/model_normalize.py", "tests/agent/test_gemini_native_adapter.py", "tests/hermes_cli/test_gemini_provider.py", "tests/hermes_cli/test_model_normalize.py" ]
[]
diff --git a/tests/agent/test_gemini_native_adapter.py b/tests/agent/test_gemini_native_adapter.py index 703428d4eb7c..aa9b2a38a521 100644 --- a/tests/agent/test_gemini_native_adapter.py +++ b/tests/agent/test_gemini_native_adapter.py @@ -198,6 +198,45 @@ def close(self): assert response.choices[0].message.content...
true
NousResearch/hermes-agent
45,814
issue_to_patch
Codex Responses adapter maps complete final_answer to finish_reason=incomplete when top-level response.status is incomplete on Azure Foundry # Codex Responses adapter incorrectly maps complete `final_answer` message to `finish_reason="incomplete"` when top-level response status is `incomplete` on Azure Foundry ## Sum...
fix(codex-responses): let final_answer complete top-level incomplete responses
## Summary Codex Responses normalization now treats a completed `phase=final_answer` message as complete when the only incomplete signal is the top-level `response.status == "incomplete"` artifact. ## Changes - Separate genuinely still-streaming signals (`queued` / `in_progress` top-level status or queued/in-progress/...
819def44c71e8b3ca163f79facdb4603a0cc6957
c304a6b0dd2b88995808447394e480aab637feed
diff --git a/agent/codex_responses_adapter.py b/agent/codex_responses_adapter.py index a2678a6da362..b8479141db10 100644 --- a/agent/codex_responses_adapter.py +++ b/agent/codex_responses_adapter.py @@ -1081,6 +1081,7 @@ def _normalize_codex_response( message_items_raw: List[Dict[str, Any]] = [] tool_calls: L...
[ "agent/codex_responses_adapter.py", "tests/run_agent/test_run_agent_codex_responses.py" ]
[]
diff --git a/tests/run_agent/test_run_agent_codex_responses.py b/tests/run_agent/test_run_agent_codex_responses.py index 7f899c601d19..a031907611c3 100644 --- a/tests/run_agent/test_run_agent_codex_responses.py +++ b/tests/run_agent/test_run_agent_codex_responses.py @@ -154,6 +154,22 @@ def _codex_ack_message_response(...
true
NousResearch/hermes-agent
45,747
issue_to_patch
fix(telegram): preserve rich formatting on stream final
## Summary Telegram streamed replies now keep rich Markdown at final delivery instead of downgrading through the MarkdownV2 edit path. Cherry-picked and updated the focused streaming fix from #45741 by @ITheEqualizer onto current main, preserving authorship. ## Changes - `gateway/stream_consumer.py`: lets adapters op...
819def44c71e8b3ca163f79facdb4603a0cc6957
c2676cd3210811ee43dfb6e198d793805c141371
diff --git a/agent/prompt_builder.py b/agent/prompt_builder.py index 1cc0c4a71e45..080a3525e33b 100644 --- a/agent/prompt_builder.py +++ b/agent/prompt_builder.py @@ -511,13 +511,19 @@ def format_steer_marker(steer_text: str) -> str: "Standard Markdown is automatically converted to Telegram formatting. " ...
[ "agent/prompt_builder.py", "gateway/platforms/base.py", "gateway/platforms/telegram.py", "gateway/stream_consumer.py", "tests/agent/test_prompt_builder.py", "tests/gateway/test_stream_consumer_draft.py", "tests/gateway/test_stream_consumer_thread_routing.py", "tests/gateway/test_telegram_rich_messages...
[]
diff --git a/tests/agent/test_prompt_builder.py b/tests/agent/test_prompt_builder.py index 998f9ddbac8e..e6c302fdb92d 100644 --- a/tests/agent/test_prompt_builder.py +++ b/tests/agent/test_prompt_builder.py @@ -887,6 +887,11 @@ def test_telegram_hint_encourages_rich_markdown(self): assert "table" in lowered ...
true
NousResearch/hermes-agent
45,801
issue_to_patch
Bug: Vision tool sends Nous-specific 'tags' field to non-Nous providers (e.g. Gemini), causing 400 error ## Description When the main provider is Nous Portal, the `auxiliary_is_nous` global flag is set to True. This causes `_build_call_kwargs()` to inject the Nous-specific `{"tags": ["product=hermes-agent"]}` extra_b...
fix(agent): scope Nous tags to Nous auxiliary calls
## Summary Auxiliary calls now add Nous Portal tags only when that specific call is routed to Nous, preventing Nous main-provider state from leaking Nous-only `tags` into Gemini/OpenRouter/custom auxiliary requests. ## Changes - Scope auxiliary `tags` injection to `provider == "nous"` in `_build_call_kwargs()`. - Add ...
425e777f54b810b7d762b0a5bbe8372dcf782def
f0db077abb835864a51e1e8060b05e9faeeba51c
diff --git a/agent/auxiliary_client.py b/agent/auxiliary_client.py index 60b335f804b5..f3dbe8d9dfdf 100644 --- a/agent/auxiliary_client.py +++ b/agent/auxiliary_client.py @@ -5004,7 +5004,7 @@ def _build_call_kwargs( # Provider-specific extra_body merged_extra = dict(extra_body or {}) - if provider == "n...
[ "agent/auxiliary_client.py", "scripts/release.py", "tests/agent/test_auxiliary_client.py" ]
[]
diff --git a/tests/agent/test_auxiliary_client.py b/tests/agent/test_auxiliary_client.py index 86b310ac82c3..7770b2e8c887 100644 --- a/tests/agent/test_auxiliary_client.py +++ b/tests/agent/test_auxiliary_client.py @@ -146,6 +146,47 @@ def test_keeps_max_tokens_on_anthropic_wire(self, provider, model, base_url): ...
true
NousResearch/hermes-agent
33,539
issue_to_patch
Port from cline/cline#10945: accept browser-pasted GitHub URLs in `hermes plugins install`
Cline-Port Weekly Scout (cron): port of cline/cline#10945 UX concept. `hermes plugins install` now accepts browser-pasted GitHub URLs. ## The bug `git clone` only accepts the bare repo URL. Users routinely paste URLs they copied from a browser tab — `tree/`, `blob/`, `pull/`, `commit/`, `releases/`, `issues/`, etc. P...
3380563d946b26cb5ae630811f95d2833ba5254b
7510e419fde2f4e598afca5a9f15c11df0e82769
diff --git a/hermes_cli/plugins_cmd.py b/hermes_cli/plugins_cmd.py index 71690ff21c12..0a5aa8c0fd03 100644 --- a/hermes_cli/plugins_cmd.py +++ b/hermes_cli/plugins_cmd.py @@ -135,6 +135,20 @@ def _sanitize_plugin_name( return target +_GITHUB_BROWSER_SEGMENTS = { + "actions", + "blob", + "commit", + ...
[ "hermes_cli/plugins_cmd.py", "tests/hermes_cli/test_plugins_cmd.py" ]
[]
diff --git a/tests/hermes_cli/test_plugins_cmd.py b/tests/hermes_cli/test_plugins_cmd.py index 75a84db428d5..8353324e9b76 100644 --- a/tests/hermes_cli/test_plugins_cmd.py +++ b/tests/hermes_cli/test_plugins_cmd.py @@ -173,6 +173,54 @@ def test_ssh_url_with_fragment_subdir(self): assert url == "git@github.com:...
true
NousResearch/hermes-agent
45,760
issue_to_patch
fix(desktop): polish slash command completion (space/tab/click + typed args)
## Summary Makes the desktop composer's slash-command completion behave consistently across every way you can pick a command/arg. Previously, pressing **space** on a complete command dead-ended on a "No matches" popover, and typing an arg out in full (e.g. `/personality creative`) also showed "No matches" because the ...
7be22e37e1c36c04b5878ffa3176237fb1438490
6369bfeaba3ecd890e2296fc1324322786232cda
diff --git a/apps/desktop/src/app/chat/composer/index.tsx b/apps/desktop/src/app/chat/composer/index.tsx index 595df800805f..96b8be61ef14 100644 --- a/apps/desktop/src/app/chat/composer/index.tsx +++ b/apps/desktop/src/app/chat/composer/index.tsx @@ -135,6 +135,12 @@ function slashChipKindForItem(item: Unstable_Trigger...
[ "apps/desktop/src/app/chat/composer/index.tsx" ]
[]
true
OpenAPITools/openapi-generator
24,022
issue_to_patch
[BUG][kotlin] `const: true` on boolean property generates uncompilable enum (Boolean vs String mismatch) #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x] Have you tested with the latest master to confirm ...
[kotlin] Fix boolean const enum literal generation
Fixes #23550. This keeps Kotlin boolean enum/const values as boolean literals when rendering enum values. Before this change, `const: true` could generate a Kotlin enum entry with `"true"` even though the enum value type is `kotlin.Boolean`. I added a focused `toEnumValue` assertion and a generated-output regression ...
6e30ad0c26ca2d2abe8fa98bda7e972d9070a94e
a9e10a142d44ff3af29f7b1332c357e2ff81e315
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java index de2b05c6be3d..8036919680b8 100644 --- a/modules/openapi-generator/src/main/java/org/openapitool...
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/AbstractKotlinCodegenTest.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/KotlinClientCodegenModelTest...
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/AbstractKotlinCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/AbstractKotlinCodegenTest.java index 2f249b43bdf4..e155b0b00ff0 100644 --- a/modules/openapi-generator/src/test/java/org/openapito...
true
OpenAPITools/openapi-generator
24,020
issue_to_patch
build(deps-dev): bump shell-quote from 1.8.1 to 1.8.4 in /samples/client/petstore/typescript-angular-v17-provided-in-root
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.1 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
eec44d718a693b1a543f53d618f71f68a9f87fd0
74e668ed5896c07057d6748b23ecb10d17ee12f4
diff --git a/samples/client/petstore/typescript-angular-v17-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v17-provided-in-root/package-lock.json index 32c78d7c593d..0f8be51e1963 100644 --- a/samples/client/petstore/typescript-angular-v17-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v17-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
24,006
issue_to_patch
[BUG][typescript-fetch] api model imports not using correct filename #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x] Have you [tested with the latest master](https://github.com/OpenAPITools/openapi-gener...
fix(typescript-fetch): support non-default file names
files generated with non-default (e.g. "fileNaming": "kebab-case") have their import path set with the default file name. this PR fixes the non-barrel imports by using the parsed file name instead of simply the class name. (fixes https://github.com/OpenAPITools/openapi-generator/issues/23840) <!-- Please check th...
5cdc493ed45468264b97ec6f849df42b0e3f8208
80e549669c8f494f6809d21269da15aab3f5cd33
diff --git a/bin/configs/typescript-fetch-kebab-case.yaml b/bin/configs/typescript-fetch-kebab-case.yaml new file mode 100644 index 000000000000..cb1922693ec4 --- /dev/null +++ b/bin/configs/typescript-fetch-kebab-case.yaml @@ -0,0 +1,6 @@ +generatorName: typescript-fetch +outputDir: samples/client/petstore/typescript-...
[ "bin/configs/typescript-fetch-kebab-case.yaml", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptFetchClientCodegen.java", "modules/openapi-generator/src/main/resources/typescript-fetch/apis.mustache", "modules/openapi-generator/src/main/resources/typescript-fetch/sagas.mu...
[ { "comment": "<!-- cubic:v=41a1678b-1657-44e1-a227-0d6733f698d9 -->\n<!-- cubic:review-run=39bbccbc-6dbe-4da3-9041-6fd18df884ec -->\n<!-- metadata:{\"confidence\":9} -->\nP2: EnumClass doc example uses object literal for a string union enum type, producing non-compilable TypeScript\n\n<details>\n<summary>Prompt...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/fetch/TypeScriptFetchClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/fetch/TypeScriptFetchClientCodegenTest.java index 094929f2fe53..c21cce633eae 100644 --- a/modules/openapi-gen...
true
OpenAPITools/openapi-generator
24,017
issue_to_patch
[BUG][JAVA][vertx] useVertx5: first API call throws NPE — `buildWebClient` constructs `PoolOptions` from empty JSON, leaving all pool defaults uninitialized #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x...
[Java][vertx] Apply Vert.x pool defaults in buildWebClient for useVertx5 (#24015)
Fixes #24015 ### Problem With \`library=vertx\` and \`useVertx5=true\`, the generated client throws a \`NullPointerException\` on the **first API call** when the \`ApiClient\` is built with the documented two-arg constructor: ```java ApiClient client = new ApiClient(vertx, new JsonObject()); // 2-arg ctor new Default...
100bf01d1e01d67f5cbf89c5594b4cc7a2e2f140
4e7eaac424720ba9b9fa4afb18fb01513d3d0876
diff --git a/modules/openapi-generator/src/main/resources/Java/libraries/vertx/ApiClient.mustache b/modules/openapi-generator/src/main/resources/Java/libraries/vertx/ApiClient.mustache index b2e7f289bd3e..9f3101629179 100644 --- a/modules/openapi-generator/src/main/resources/Java/libraries/vertx/ApiClient.mustache +++ ...
[ "modules/openapi-generator/src/main/resources/Java/libraries/vertx/ApiClient.mustache", "samples/client/petstore/java/vertx5-supportVertxFuture/src/main/java/org/openapitools/client/ApiClient.java", "samples/client/petstore/java/vertx5/src/main/java/org/openapitools/client/ApiClient.java" ]
[]
true
OpenAPITools/openapi-generator
24,019
issue_to_patch
build(deps-dev): bump shell-quote from 1.8.2 to 1.8.4 in /samples/client/petstore/typescript-angular-v19
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
6ce9799c5baa44fb2808e37a2abb11e7ee58b8ad
b0c16c191e47e6debd6586be64e6e0132fa86e42
diff --git a/samples/client/petstore/typescript-angular-v19/package-lock.json b/samples/client/petstore/typescript-angular-v19/package-lock.json index bd4627e48d51..21097e4e0325 100644 --- a/samples/client/petstore/typescript-angular-v19/package-lock.json +++ b/samples/client/petstore/typescript-angular-v19/package-loc...
[ "samples/client/petstore/typescript-angular-v19/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
24,018
issue_to_patch
build(deps-dev): bump shell-quote from 1.8.3 to 1.8.4 in /samples/client/petstore/typescript-angular-v20-provided-in-root
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.3 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
fc85a806f3d5770c21bb194147724fc8de1b1191
65d20a7635096515f0432bfa3ed85b029d7d9ac5
diff --git a/samples/client/petstore/typescript-angular-v20-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v20-provided-in-root/package-lock.json index bbf4d8ab92a4..3878f106d1f5 100644 --- a/samples/client/petstore/typescript-angular-v20-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v20-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
24,016
issue_to_patch
build(deps): bump joi from 17.7.0 to 17.13.4 in /website
Bumps [joi](https://github.com/hapijs/joi) from 17.7.0 to 17.13.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/hapijs/joi/commit/3d3ab76fad0170e97bdd72e96be7ce32330cde8f"><code>3d3ab76</code></a> 17.13.4</li> <li><a href="https://github.com/hapijs/joi/commit/4bcdf3602279c705a5d9944d29f897c...
100bf01d1e01d67f5cbf89c5594b4cc7a2e2f140
1fe0d2d47a6576371be1c99167c0f308a6a8297d
diff --git a/website/yarn.lock b/website/yarn.lock index 0c12a5c7b0bb..0904285ba686 100644 --- a/website/yarn.lock +++ b/website/yarn.lock @@ -1745,12 +1745,12 @@ url-loader "^4.1.1" webpack "^5.73.0" -"@hapi/hoek@^9.0.0": +"@hapi/hoek@^9.0.0", "@hapi/hoek@^9.3.0": version "9.3.0" resolved "https://re...
[ "website/yarn.lock" ]
[]
true
OpenAPITools/openapi-generator
23,985
issue_to_patch
[php-nextgen] oneof polymorphism
- Javas `collectOneOfTypeHint` builds a oneOf-classname `A|B` union map. Applied to property, parameter, and return type hints. - A makeNullable helper emits `A|B|null` instead of `?A|B`. - `model.mustache` branches to `model_oneof` when `oneOf` is present (otherwise `model_generic`). - new `model_oneof.mustache`:...
c4dfcf7fda4879dc9a58734cb3f0adf56ee6c383
918ac70fa0f54eca0b6c6332d47ce7bd04ae26b3
diff --git a/docs/generators/php-nextgen.md b/docs/generators/php-nextgen.md index 8691f4f2bc23..e5f57d1487ea 100644 --- a/docs/generators/php-nextgen.md +++ b/docs/generators/php-nextgen.md @@ -241,7 +241,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl | ---- | --------- | ------...
[ "docs/generators/php-nextgen.md", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java", "modules/openapi-generator/src/main/resources/php-nextgen/ObjectSerializer.mustache", "modules/openapi-generator/src/main/resources/php-nextgen/OneOfInterface.mustache",...
[ { "comment": "<!-- cubic:v=925e5e6c-9bda-4094-94e4-c8cbbdc97524 -->\n<!-- cubic:review-run=dee74da8-0337-4637-9ad2-e1d0a7fbd2e1 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: PHPDoc and PHP type hints are inconsistent for oneOf parameter and return types\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java index 88ad980ac167..78c150b7af97 100644 --- a/modules/openapi-generator/src/test/java/org/openapitool...
true
OpenAPITools/openapi-generator
23,985
comment_to_fix
[php-nextgen] oneof polymorphism
<!-- cubic:v=925e5e6c-9bda-4094-94e4-c8cbbdc97524 --> <!-- cubic:review-run=dee74da8-0337-4637-9ad2-e1d0a7fbd2e1 --> <!-- metadata:{"confidence":9} --> P1: PHPDoc and PHP type hints are inconsistent for oneOf parameter and return types <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is v...
c4dfcf7fda4879dc9a58734cb3f0adf56ee6c383
918ac70fa0f54eca0b6c6332d47ce7bd04ae26b3
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/src/Api/FakeApi.php b/samples/client/petstore/php-nextgen/OpenAPIClient-php/src/Api/FakeApi.php index ea9cf90967db..6390c69ab8c8 100644 --- a/samples/client/petstore/php-nextgen/OpenAPIClient-php/src/Api/FakeApi.php +++ b/samples/client/petstore/php-nex...
[ "samples/client/petstore/php-nextgen/OpenAPIClient-php/src/Api/FakeApi.php" ]
[ { "comment": "<!-- cubic:v=925e5e6c-9bda-4094-94e4-c8cbbdc97524 -->\n<!-- cubic:review-run=dee74da8-0337-4637-9ad2-e1d0a7fbd2e1 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: PHPDoc and PHP type hints are inconsistent for oneOf parameter and return types\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n...
true
OpenAPITools/openapi-generator
23,985
comment_to_fix
[php-nextgen] oneof polymorphism
<!-- cubic:v=0dce4858-08bb-4bac-b80d-219180f4471a --> <!-- cubic:review-run=cf9a3f06-5ab7-41f8-816e-438634703b4c --> <!-- metadata:{"confidence":9} --> P1: Generated docs example for testOneOf incorrectly uses `new \OpenAPI\Client\Model\Mammal()` as the parameter. The actual API method accepts `Whale|Zebra`, and `Mamma...
c4dfcf7fda4879dc9a58734cb3f0adf56ee6c383
918ac70fa0f54eca0b6c6332d47ce7bd04ae26b3
diff --git a/samples/client/petstore/php-nextgen/OpenAPIClient-php/docs/Api/FakeApi.md b/samples/client/petstore/php-nextgen/OpenAPIClient-php/docs/Api/FakeApi.md index 9e3a212955f2..162833ea1d52 100644 --- a/samples/client/petstore/php-nextgen/OpenAPIClient-php/docs/Api/FakeApi.md +++ b/samples/client/petstore/php-nex...
[ "samples/client/petstore/php-nextgen/OpenAPIClient-php/docs/Api/FakeApi.md" ]
[ { "comment": "<!-- cubic:v=0dce4858-08bb-4bac-b80d-219180f4471a -->\n<!-- cubic:review-run=cf9a3f06-5ab7-41f8-816e-438634703b4c -->\n<!-- metadata:{\"confidence\":9} -->\nP1: Generated docs example for testOneOf incorrectly uses `new \\OpenAPI\\Client\\Model\\Mammal()` as the parameter. The actual API method ac...
true
OpenAPITools/openapi-generator
23,985
comment_to_fix
[php-nextgen] oneof polymorphism
It might be a good idea to add this description (or a reference to it) to the other `oneOfDocType` and the `docTypeOf` method
c4dfcf7fda4879dc9a58734cb3f0adf56ee6c383
918ac70fa0f54eca0b6c6332d47ce7bd04ae26b3
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java index 46975b5d922a..4986432cb624 100644 --- a/modules/openapi-generator/src/main/java/org/openapi...
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java" ]
[ { "comment": "It might be a good idea to add this description (or a reference to it) to the other `oneOfDocType` and the `docTypeOf` method", "path": "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java", "hunk": "@@ -187,23 +187,91 @@ private static S...
true
OpenAPITools/openapi-generator
24,000
issue_to_patch
[BUG][TYPESCRIPT-FETCH] Form data requests with mime type parameters use URLSearchParams instead of FormData #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x] Have you [tested with the latest master](https...
[BUG][TYPESCRIPT-FETCH] Fix #23998: Form data requests with mime type parameters use URLSearchParams instead of FormData
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING....
8bbf0d4af916f693b4a87fafae030d679b1cd97e
9a9ca47dbd79d41d7116d0417dd63938ca87b8dc
diff --git a/modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache b/modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache index 00ca3b3ee0ac..88574cad021d 100644 --- a/modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache +++ b/modules/openapi-...
[ "modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache", "samples/client/others/typescript-fetch/additional-properties-in-multipart-issue/runtime.ts", "samples/client/others/typescript-fetch/infinite-recursion-issue/runtime.ts", "samples/client/others/typescript-fetch/self-import-issu...
[ { "comment": "<!-- cubic:v=0fd04aa0-b59e-4600-a411-98d3da99e5df -->\n<!-- cubic:review-run=fa38c18e-7285-4c98-98af-214ea4405685 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: MIME type detection in `canConsumeForm` is case-sensitive, which violates RFC 2045/7231 case-insensitivity rules for media types. Mixed-c...
true
OpenAPITools/openapi-generator
23,911
issue_to_patch
Add validate Mojo to Maven Plugin
### Description This PR introduces a new `validate` Mojo to the `openapi-generator-maven-plugin`. Historically, validating an OpenAPI specification within a Maven workflow required running the full `generate` goal, or relying on external plugins. As teams move toward centralized "API Contract" design modules (where...
f00a7df3f71fc850305108c61d743b111d0b3d44
5629dd31494ed7b71b0b1060ee777c298f57076e
diff --git a/modules/openapi-generator-maven-plugin/README.md b/modules/openapi-generator-maven-plugin/README.md index 4119b1c615ce..7484ef65a781 100644 --- a/modules/openapi-generator-maven-plugin/README.md +++ b/modules/openapi-generator-maven-plugin/README.md @@ -41,80 +41,143 @@ mvn clean compile :bulb: These **...
[ "modules/openapi-generator-maven-plugin/README.md", "modules/openapi-generator-maven-plugin/pom.xml", "modules/openapi-generator-maven-plugin/src/it/validate-harness/cli-comma-separated-override/invoker.properties", "modules/openapi-generator-maven-plugin/src/it/validate-harness/cli-comma-separated-override/p...
[ { "comment": "<!-- cubic:v=ce73aac6-e92d-4333-a59a-25da8ff98b25 -->\n<!-- metadata:{\"confidence\":8} -->\nP1: `inputSpec` emptiness check inspects only the first array element (`inputSpec[0]`), incorrectly rejecting valid multi-spec configurations where later elements are non-empty.\n\n<details>\n<summary>Prom...
diff --git a/modules/openapi-generator-maven-plugin/src/it/validate-harness/input-directory-merge/specs/part1.yaml b/modules/openapi-generator-maven-plugin/src/it/validate-harness/input-directory-merge/specs/part1.yaml new file mode 100644 index 000000000000..0296f17c14b5 --- /dev/null +++ b/modules/openapi-generator-m...
true
OpenAPITools/openapi-generator
23,911
comment_to_fix
Add validate Mojo to Maven Plugin
<!-- cubic:v=ce73aac6-e92d-4333-a59a-25da8ff98b25 --> <!-- metadata:{"confidence":8} --> P1: `inputSpec` emptiness check inspects only the first array element (`inputSpec[0]`), incorrectly rejecting valid multi-spec configurations where later elements are non-empty. <details> <summary>Prompt for AI agents</summary> `...
f00a7df3f71fc850305108c61d743b111d0b3d44
5629dd31494ed7b71b0b1060ee777c298f57076e
diff --git a/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/ValidateMojo.java b/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/ValidateMojo.java new file mode 100644 index 000000000000..27a44219edf4 --- /dev/null +++ b/modules/openapi-generator...
[ "modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/ValidateMojo.java" ]
[ { "comment": "<!-- cubic:v=ce73aac6-e92d-4333-a59a-25da8ff98b25 -->\n<!-- metadata:{\"confidence\":8} -->\nP1: `inputSpec` emptiness check inspects only the first array element (`inputSpec[0]`), incorrectly rejecting valid multi-spec configurations where later elements are non-empty.\n\n<details>\n<summary>Prom...
true
OpenAPITools/openapi-generator
23,911
comment_to_fix
Add validate Mojo to Maven Plugin
<!-- metadata:{"confidence":9} --> P2: Skip flags are checked too late; input validation should come after the skip check. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator-maven-plugin/src/main/java/org/o...
f00a7df3f71fc850305108c61d743b111d0b3d44
5629dd31494ed7b71b0b1060ee777c298f57076e
diff --git a/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/ValidateMojo.java b/modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/ValidateMojo.java new file mode 100644 index 000000000000..27a44219edf4 --- /dev/null +++ b/modules/openapi-generator...
[ "modules/openapi-generator-maven-plugin/src/main/java/org/openapitools/codegen/plugin/ValidateMojo.java" ]
[ { "comment": "<!-- metadata:{\"confidence\":9} -->\nP2: Skip flags are checked too late; input validation should come after the skip check.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator-m...
true
OpenAPITools/openapi-generator
23,995
issue_to_patch
[php-nextgen] Remove request body handling if no request body exists
- Remove request processing if there is no body (unused code) - Change imports of FormProcessor and MultipartStream so no unused imports exist <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/...
acd0bdd41204e8e81d001fdeaaa6eb4babd3027f
c8962bda000e6230b9da318dcb7562b905e356bf
diff --git a/modules/openapi-generator/src/main/resources/php-nextgen/api.mustache b/modules/openapi-generator/src/main/resources/php-nextgen/api.mustache index a16f59353e01..b25a293e68c8 100644 --- a/modules/openapi-generator/src/main/resources/php-nextgen/api.mustache +++ b/modules/openapi-generator/src/main/resource...
[ "modules/openapi-generator/src/main/resources/php-nextgen/api.mustache", "modules/openapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java", "modules/openapi-generator/src/test/resources/3_0/php-nextgen/form-body-params.yaml", "samples/client/echo_api/php-nextgen-streaming...
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java index 88ad980ac167..17c85a2ab68b 100644 --- a/modules/openapi-generator/src/test/java/org/openapitool...
true
OpenAPITools/openapi-generator
24,001
issue_to_patch
build(deps-dev): bump shell-quote from 1.8.3 to 1.8.4 in /samples/client/petstore/typescript-angular-v21-provided-in-root
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.3 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
5e25b2beb17b6a6973339ee3ee6b938671aaceb8
71e59816f7fdfe5588c8a90b3ca166b8e1d6ce37
diff --git a/samples/client/petstore/typescript-angular-v21-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v21-provided-in-root/package-lock.json index f5c3fd8368ca..fa7f52a019fa 100644 --- a/samples/client/petstore/typescript-angular-v21-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v21-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
23,989
issue_to_patch
build(deps-dev): bump shell-quote from 1.8.3 to 1.8.4 in /samples/client/petstore/typescript-angular-v19-provided-in-root
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.3 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
8bbf0d4af916f693b4a87fafae030d679b1cd97e
031bbe10e9418ca7e1d2dee49f8c43bc08412f5c
diff --git a/samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json index 436bfe371ae3..dc0b4d73a081 100644 --- a/samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
23,999
issue_to_patch
Update parser to 2.1.43
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> <!-- Please check the completed items below --> ### PR checklist - [ ] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING....
8bbf0d4af916f693b4a87fafae030d679b1cd97e
16b3b0ce13962489f3e66ecc0ab8e24e22bb4268
diff --git a/pom.xml b/pom.xml index f73ed9b93458..506e30f561ce 100644 --- a/pom.xml +++ b/pom.xml @@ -1287,7 +1287,7 @@ <snakeyaml.version>2.4</snakeyaml.version> <spotbugs-plugin.version>3.1.12.2</spotbugs-plugin.version> <swagger-parser-groupid.version>io.swagger.parser.v3</swagger-parser-...
[ "pom.xml" ]
[]
true
OpenAPITools/openapi-generator
23,996
issue_to_patch
build(deps): bump shell-quote from 1.8.1 to 1.8.4 in /samples/client/petstore/typescript-fetch/tests/default
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.1 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
0836970f0f1d81b9edb57381ef83650d6527495e
e01a14d914c01fa9777be296865bd29f4b7df74a
[ "samples/client/petstore/typescript-fetch/tests/default/package-lock.json" ]
[]
diff --git a/samples/client/petstore/typescript-fetch/tests/default/package-lock.json b/samples/client/petstore/typescript-fetch/tests/default/package-lock.json index 063e31264652..9d1090e72bca 100644 --- a/samples/client/petstore/typescript-fetch/tests/default/package-lock.json +++ b/samples/client/petstore/typescript...
true
OpenAPITools/openapi-generator
23,852
issue_to_patch
build(deps): bump qs, body-parser and express in /samples/client/petstore/typescript-angular-v19-provided-in-root
Bumps [qs](https://github.com/ljharb/qs), [body-parser](https://github.com/expressjs/body-parser) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `qs` from 6.14.1 to 6.15.2 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.c...
803885f11fadb982c15d2e452f15ff59f0ff6313
dd2b783bcf4b1efcb9daca78d70eeebaf0a40a5b
diff --git a/samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json index 0ab39ccc10d4..436bfe371ae3 100644 --- a/samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v19-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
23,994
issue_to_patch
[Rust-Axum] Fix generating error upon special model name
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> Kindly ping @wing328 to review and merge. Thank you <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/o...
acd0bdd41204e8e81d001fdeaaa6eb4babd3027f
8348a21a4dec8662e00c9ddb133c69d60ad503b6
diff --git a/modules/openapi-generator/src/main/resources/rust-axum/lib.mustache b/modules/openapi-generator/src/main/resources/rust-axum/lib.mustache index 7f197ef5f0ff..153ffa6d00bd 100644 --- a/modules/openapi-generator/src/main/resources/rust-axum/lib.mustache +++ b/modules/openapi-generator/src/main/resources/rust...
[ "modules/openapi-generator/src/main/resources/rust-axum/lib.mustache", "modules/openapi-generator/src/main/resources/rust-axum/models.mustache", "samples/server/petstore/rust-axum/output/apikey-authorization/src/lib.rs", "samples/server/petstore/rust-axum/output/apikey-authorization/src/models.rs", "samples...
[ { "comment": "Error when model name is Box/Result/Send/Sync. This PR fix that", "path": "modules/openapi-generator/src/main/resources/rust-axum/models.mustache", "hunk": "@@ -8,7 +8,7 @@ use crate::header;\n use crate::{models, types::*};\n \n #[allow(dead_code)]\n-pub type SSE = std::pin::Pin<Box<dyn f...
true
OpenAPITools/openapi-generator
23,977
issue_to_patch
[Rust-Axum] Support Server-Sent Events (SSE)
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> Support Server-Sent Events (SSE). Relates PR: https://github.com/OpenAPITools/openapi-generator/pull/22095 cc @wing328 @jacob-mink-1996 @sombrerosheep for review. So sorry that I hav...
9fe1812f896af3f5c58985fe124e6c4815bdfb25
1bb8c114f7ad0d8820690a250d4d964c440652f1
diff --git a/bin/configs/manual/rust-axum-sse.yaml b/bin/configs/manual/rust-axum-sse.yaml new file mode 100644 index 000000000000..a472996e7a1b --- /dev/null +++ b/bin/configs/manual/rust-axum-sse.yaml @@ -0,0 +1,12 @@ +generatorName: rust-axum +outputDir: samples/server/petstore/rust-axum/output/rust-axum-sse +inputS...
[ "bin/configs/manual/rust-axum-sse.yaml", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustAxumServerCodegen.java", "modules/openapi-generator/src/main/resources/rust-axum/Cargo.mustache", "modules/openapi-generator/src/main/resources/rust-axum/models.mustache", "modules/openap...
[ { "comment": "<!-- cubic:v=e15299ed-5d4e-48ef-b725-0d82e442cbf6 -->\n<!-- cubic:review-run=cbd5812a-c96a-480e-b4a3-0dfbdc1e3e98 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `futures-util` dependency is added unconditionally but is only used for the SSE type alias, creating unused dependency bloat for non-SSE ...
diff --git a/modules/openapi-generator/src/test/resources/3_0/rust-axum/rust-axum-sse.yaml b/modules/openapi-generator/src/test/resources/3_0/rust-axum/rust-axum-sse.yaml new file mode 100644 index 000000000000..d410fab32352 --- /dev/null +++ b/modules/openapi-generator/src/test/resources/3_0/rust-axum/rust-axum-sse.ya...
true
OpenAPITools/openapi-generator
23,986
issue_to_patch
[php-nextgen] Code improvements
- Remove extra line with spaces - Fix the `contentTypes` type. - Removed: Use types with package in phpdocs, was 4b680ebfb3d5511e797a4f466a70a84d1091a210 <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generato...
85ff71d04aa9d9aca9b2db604b0014a053a788e7
d78cd9c5b3842ecec12c8e39df56e479ed80f57d
diff --git a/modules/openapi-generator/src/main/resources/php-nextgen/api.mustache b/modules/openapi-generator/src/main/resources/php-nextgen/api.mustache index a16f59353e01..f81d2933b3a5 100644 --- a/modules/openapi-generator/src/main/resources/php-nextgen/api.mustache +++ b/modules/openapi-generator/src/main/resource...
[ "modules/openapi-generator/src/main/resources/php-nextgen/api.mustache", "samples/client/echo_api/php-nextgen-streaming/src/Api/AuthApi.php", "samples/client/echo_api/php-nextgen-streaming/src/Api/BodyApi.php", "samples/client/echo_api/php-nextgen-streaming/src/Api/FormApi.php", "samples/client/echo_api/php...
[]
true
OpenAPITools/openapi-generator
23,871
issue_to_patch
[BUG][kotlin-server] Common path prefix extraction breaks cross-tag JAX-RS routing #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x] Have you [tested with the latest master](https://github.com/OpenAPITools...
[kotlin-server][Java][JAX-RS] Fix path shadowing (#23414)
Fixes https://github.com/OpenAPITools/openapi-generator/issues/23414. The generator now tracks all resource paths across tags during code generation. Before applying a common `@Path` prefix to an API class, it checks if that prefix would "shadow" (intercept) routes belonging to other tags - if so, it keeps the full ...
74f7b0731e9e592dd35f0979391134be9b85d6dd
0986dc716c176548042b1d7c9234eca8c97d1706
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaJAXRSServerCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaJAXRSServerCodegen.java index e1c3a1759fc2..224ac1f36077 100644 --- a/modules/openapi-generator/src/main/ja...
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaJAXRSServerCodegen.java", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/java/jaxrs/JavaJaxrsBaseTest....
[ { "comment": "Global path registry.", "path": "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaJAXRSServerCodegen.java", "hunk": "@@ -70,6 +81,15 @@ public abstract class AbstractJavaJAXRSServerCodegen extends AbstractJavaCodegen\n \n protected boolean useTags ...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/jaxrs/JavaJaxrsBaseTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/jaxrs/JavaJaxrsBaseTest.java index e1e77d5a53f8..7b7b8d5d7e59 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/code...
true
OpenAPITools/openapi-generator
23,983
issue_to_patch
build(deps): bump shell-quote from 1.8.0 to 1.8.4 in /website
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.0 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
c4dfcf7fda4879dc9a58734cb3f0adf56ee6c383
5f3b91deb8c24e1aade85ff185a7fc7f08fad953
diff --git a/website/yarn.lock b/website/yarn.lock index 23817076b51a..0c12a5c7b0bb 100644 --- a/website/yarn.lock +++ b/website/yarn.lock @@ -7054,9 +7054,9 @@ shebang-regex@^3.0.0: integrity sha512-7++dFhtcx3353uBaq8DDR4NuxBetBzC7ZQOhmTQInHEd6bSrXdiEyzCvG07Z44UYdLShWUyXt5M/yhz8ekcb1A== shell-quote@^1.7.3: - ve...
[ "website/yarn.lock" ]
[]
true
OpenAPITools/openapi-generator
23,984
issue_to_patch
build(deps-dev): bump shell-quote from 1.7.2 to 1.8.4 in /samples/client/petstore/typescript-axios/tests/default
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.7.2 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...
c4dfcf7fda4879dc9a58734cb3f0adf56ee6c383
98985452f7e87e9af3ce1a7f275621fd81bc212b
[ "samples/client/petstore/typescript-axios/tests/default/package-lock.json" ]
[]
diff --git a/samples/client/petstore/typescript-axios/tests/default/package-lock.json b/samples/client/petstore/typescript-axios/tests/default/package-lock.json index 195a742e5eb3..9fcf25428bdd 100644 --- a/samples/client/petstore/typescript-axios/tests/default/package-lock.json +++ b/samples/client/petstore/typescript...
true
OpenAPITools/openapi-generator
23,981
issue_to_patch
[haskell-http-client] update stack resolver to lts-24.42
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING....
06d84df4955e2d8092d175070faaa703599bfdc4
c192a5225355e5e2639867d38f8ea56f255e2c04
diff --git a/modules/openapi-generator/src/main/resources/haskell-http-client/Client.mustache b/modules/openapi-generator/src/main/resources/haskell-http-client/Client.mustache index cbdb465a2b2c..1c41e5c1295a 100644 --- a/modules/openapi-generator/src/main/resources/haskell-http-client/Client.mustache +++ b/modules/op...
[ "modules/openapi-generator/src/main/resources/haskell-http-client/Client.mustache", "modules/openapi-generator/src/main/resources/haskell-http-client/Core.mustache", "modules/openapi-generator/src/main/resources/haskell-http-client/haskell-http-client.cabal.mustache", "modules/openapi-generator/src/main/resou...
[]
true
OpenAPITools/openapi-generator
23,958
issue_to_patch
fix(python): remove redundant debug setter call in __deepcopy__
Hi! It seems I'm hitting an extremely pathological case during the creation of many openapi-generated objects in a very large (many registered loggers) codebase. The `__deepcopy__` method on the `Configuration` copies all `__dict__` items (including `_Configuration__debug`) and then loggers are shallow-copied over. ...
3272a732263c7d1d11fb0506922dcd8a38f7a691
b83efd1e6ca100c1eb3e7c393b34529d0982b66f
diff --git a/modules/openapi-generator/src/main/resources/python-pydantic-v1/configuration.mustache b/modules/openapi-generator/src/main/resources/python-pydantic-v1/configuration.mustache index 70d24e10f414..b69d90153301 100644 --- a/modules/openapi-generator/src/main/resources/python-pydantic-v1/configuration.mustach...
[ "modules/openapi-generator/src/main/resources/python-pydantic-v1/configuration.mustache", "modules/openapi-generator/src/main/resources/python/configuration.mustache", "samples/client/echo_api/python-disallowAdditionalPropertiesIfNotPresent/openapi_client/configuration.py", "samples/client/echo_api/python-pyd...
[]
diff --git a/samples/openapi3/client/petstore/python-pydantic-v1/tests/test_configuration.py b/samples/openapi3/client/petstore/python-pydantic-v1/tests/test_configuration.py index 571c79ed034b..9b310a4b06ec 100644 --- a/samples/openapi3/client/petstore/python-pydantic-v1/tests/test_configuration.py +++ b/samples/opena...
true
OpenAPITools/openapi-generator
23,970
issue_to_patch
v7.23.0 release
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> <!-- Please check the completed items below --> ### PR checklist - [ ] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING....
153d80fc1871a3d32e1792d99777fd47e3644fa8
95095081cf762041bfde7937c27be93c8aa11111
diff --git a/bin/utils/release/release_version_update.sh b/bin/utils/release/release_version_update.sh index 1920a2339edb..45556ded397c 100755 --- a/bin/utils/release/release_version_update.sh +++ b/bin/utils/release/release_version_update.sh @@ -78,6 +78,7 @@ declare -a xml_files=( "${root}/modules/openapi-genera...
[ "bin/utils/release/release_version_update.sh", "modules/openapi-generator-cli/pom.xml", "modules/openapi-generator-core/pom.xml", "modules/openapi-generator-gradle-plugin/gradle.properties", "modules/openapi-generator-gradle-plugin/pom.xml", "modules/openapi-generator-gradle-plugin/samples/local-spec/grad...
[]
true
OpenAPITools/openapi-generator
22,570
issue_to_patch
[BUG][typescript-fetch] Additional-Properties/Collections in Multipart-Requests #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x] Have you [tested with the latest master](https://github.com/OpenAPITools/op...
[typescript-fetch] Bugfix additional properties in multipart requests
Fixes #22568 by adding a check to the template which handles containers seperately on multipart requests. <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md). - [ x Pull Request ti...
23eff6672fea3ffaeddbf4f04638b7e430c9572c
39a2c8b43508aa2e7ab997808f892f0f9b0592ff
diff --git a/bin/configs/typescript-fetch-additional-properties-in-multipart-issue.yaml b/bin/configs/typescript-fetch-additional-properties-in-multipart-issue.yaml new file mode 100644 index 000000000000..3c4a45f10e07 --- /dev/null +++ b/bin/configs/typescript-fetch-additional-properties-in-multipart-issue.yaml @@ -0,...
[ "bin/configs/typescript-fetch-additional-properties-in-multipart-issue.yaml", "modules/openapi-generator/src/main/resources/typescript-fetch/apis.mustache", "modules/openapi-generator/src/test/resources/3_0/typescript-fetch/additional-properties-in-multipart-issue.yaml", "samples/client/others/typescript-fetc...
[]
diff --git a/modules/openapi-generator/src/test/resources/3_0/typescript-fetch/additional-properties-in-multipart-issue.yaml b/modules/openapi-generator/src/test/resources/3_0/typescript-fetch/additional-properties-in-multipart-issue.yaml new file mode 100644 index 000000000000..3a6650e0aaff --- /dev/null +++ b/modules...
true
OpenAPITools/openapi-generator
23,811
issue_to_patch
fix(dart): Optional<T> fromJson wrapping
## Summary When `useOptional=true` (added in #22257) is enabled, the `x-is-optional` vendor extension correctly wraps scalar fields in `Optional.present()` / `Optional.absent()` during `fromJson` deserialization. However, six collection branches and the numeric branch in `native_class.mustache` are missing this ch...
fd651513978c5f2ac7028caee9c5caa841d0b6c1
37a5774a74b72410bc5491d447191bbf7697d040
diff --git a/modules/openapi-generator/src/main/resources/dart2/serialization/native/native_class.mustache b/modules/openapi-generator/src/main/resources/dart2/serialization/native/native_class.mustache index 07c0b5b9b411..01462d445a11 100644 --- a/modules/openapi-generator/src/main/resources/dart2/serialization/native...
[ "modules/openapi-generator/src/main/resources/dart2/serialization/native/native_class.mustache", "modules/openapi-generator/src/test/resources/3_0/kotlin/reserved_words.yaml" ]
[ { "comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Optional array deserialization collapses explicit JSON null into an empty list. When `json[r'baseName']` is `null`, `null is Iterable` is false and the fallback `const []` is wrapped in `Optional.present([])` instead of `Optional.present(null)`, breaking t...
diff --git a/modules/openapi-generator/src/test/resources/3_0/kotlin/reserved_words.yaml b/modules/openapi-generator/src/test/resources/3_0/kotlin/reserved_words.yaml index 38356d3aacda..4c2c3ee996ee 100644 --- a/modules/openapi-generator/src/test/resources/3_0/kotlin/reserved_words.yaml +++ b/modules/openapi-generator...
true
OpenAPITools/openapi-generator
23,811
comment_to_fix
fix(dart): Optional<T> fromJson wrapping
<!-- metadata:{"confidence":8} --> P2: Optional array deserialization collapses explicit JSON null into an empty list. When `json[r'baseName']` is `null`, `null is Iterable` is false and the fallback `const []` is wrapped in `Optional.present([])` instead of `Optional.present(null)`, breaking the absent/null/present co...
fd651513978c5f2ac7028caee9c5caa841d0b6c1
37a5774a74b72410bc5491d447191bbf7697d040
diff --git a/modules/openapi-generator/src/main/resources/dart2/serialization/native/native_class.mustache b/modules/openapi-generator/src/main/resources/dart2/serialization/native/native_class.mustache index 07c0b5b9b411..01462d445a11 100644 --- a/modules/openapi-generator/src/main/resources/dart2/serialization/native...
[ "modules/openapi-generator/src/main/resources/dart2/serialization/native/native_class.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Optional array deserialization collapses explicit JSON null into an empty list. When `json[r'baseName']` is `null`, `null is Iterable` is false and the fallback `const []` is wrapped in `Optional.present([])` instead of `Optional.present(null)`, breaking t...
true
OpenAPITools/openapi-generator
23,680
issue_to_patch
[jaxrs-spec][quarkus] Emit @RolesAllowed({"**"}) for HTTP Basic, Bearer, api-key and OAuth2 or OpenID with empty scopes and rename "useQuarkusSecurityAnnotations" to "useJakartaSecurityAnnotations"
This is part 2 of #23691 to improve authentication and authorisation support in the `jaxrs-spec/quarkus` server generator. ## What this PR does When the new `useJakartaSecurityAnnotations` flag is enabled (Quarkus library only, requires `useJakartaEe=true`), the generator emits `@jakarta.annotation.security.RolesAllo...
7a14a434f9cf0f2267b33d5a7b57abac3759b247
c1a7cd56dffc2edd1c89a434578e965b7be92212
diff --git a/docs/generators/jaxrs-cxf-cdi.md b/docs/generators/jaxrs-cxf-cdi.md index 607c3b00d25d..54e88fd00a53 100644 --- a/docs/generators/jaxrs-cxf-cdi.md +++ b/docs/generators/jaxrs-cxf-cdi.md @@ -82,10 +82,10 @@ These options may be applied as additional-properties (cli) or configOptions (pl |title|a title desc...
[ "docs/generators/jaxrs-cxf-cdi.md", "docs/generators/jaxrs-spec.md", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JakartaSecurityAnnotationProcessor.java", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaJAXRSSpecServerCodegen.java", "modules/op...
[ { "comment": "<!-- metadata:{\"confidence\":10} -->\nP1: OpenAPI scope requirements are conjunctive, but this mapping uses `@RolesAllowed` OR semantics and can under-enforce multi-scope authorization.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, underst...
diff --git a/modules/openapi-generator/src/main/resources/JavaJaxRS/spec/libraries/quarkus/apiInterface.mustache b/modules/openapi-generator/src/main/resources/JavaJaxRS/spec/libraries/quarkus/apiInterface.mustache index b79a56fa34e0..735769ce8c22 100644 --- a/modules/openapi-generator/src/main/resources/JavaJaxRS/spec...
true
OpenAPITools/openapi-generator
23,708
issue_to_patch
[BUG][JAVA] Generating native Java models with AllOf/OneOf definitions without creating client creates a model with unused imports #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator? - [x] Have you [tested with t...
Do not import ApiClient when supportUrlQuery is false
Fixes #23700 When generating only models and JSON related supporting file with the supportUrlQuery as false, invalid unused import for ApiClient is included for generated Java classes that are defined as OneOf or AnyOf in the OpenAPI specification. PR does not include the ApiClient import in these classes if support...
ba67ed777668dfb8aff6db33aa7b9a4ec196c0a5
77c3431d7a96ccdfe01dba2926aadd5847abbc9f
diff --git a/modules/openapi-generator/src/main/resources/Java/libraries/native/anyof_model.mustache b/modules/openapi-generator/src/main/resources/Java/libraries/native/anyof_model.mustache index b34e4f63e7ac..c977cbf355d2 100644 --- a/modules/openapi-generator/src/main/resources/Java/libraries/native/anyof_model.must...
[ "modules/openapi-generator/src/main/resources/Java/libraries/native/anyof_model.mustache", "modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.mustache" ]
[ { "comment": "don't think this is needed. can you remove this please", "path": "modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.mustache", "hunk": "@@ -428,6 +430,7 @@ public class {{classname}} extends AbstractOpenApiSchema{{#vendorExtensions.x-im\n {{/isPrimitive...
true
OpenAPITools/openapi-generator
23,708
comment_to_fix
Do not import ApiClient when supportUrlQuery is false
don't think this is needed. can you remove this please
ba67ed777668dfb8aff6db33aa7b9a4ec196c0a5
77c3431d7a96ccdfe01dba2926aadd5847abbc9f
diff --git a/modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.mustache b/modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.mustache index 2b28229f94d9..1ecfc5679a64 100644 --- a/modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.must...
[ "modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.mustache" ]
[ { "comment": "don't think this is needed. can you remove this please", "path": "modules/openapi-generator/src/main/resources/Java/libraries/native/oneof_model.mustache", "hunk": "@@ -428,6 +430,7 @@ public class {{classname}} extends AbstractOpenApiSchema{{#vendorExtensions.x-im\n {{/isPrimitive...
true
OpenAPITools/openapi-generator
22,500
issue_to_patch
[csharp] Extend HostConfiguration with additional AddApiHttpClients signatures
This change adds new Method signatures to the `HostConfiguration` in regards of `AddApiHttpClients` to support also the `AddHttpClient(Action<IServiceProvider, HttpClient> configureClient)` variant. This allows to access the `ServiceProvider` during configuration which can be very benefitial. ### PR checklist - ...
4f9f14a7d8bef5e6ea8209551cdb89af2fb17d8e
132cc6d810aa842c2a43b790dc6aa15776d31edd
diff --git a/modules/openapi-generator/src/main/resources/csharp/libraries/generichost/HostConfiguration.mustache b/modules/openapi-generator/src/main/resources/csharp/libraries/generichost/HostConfiguration.mustache index 03dd95e59a51..02a30813c546 100644 --- a/modules/openapi-generator/src/main/resources/csharp/libra...
[ "modules/openapi-generator/src/main/resources/csharp/libraries/generichost/HostConfiguration.mustache", "samples/client/petstore/csharp/generichost/latest/ComposedEnum/src/Org.OpenAPITools/Client/HostConfiguration.cs", "samples/client/petstore/csharp/generichost/latest/HelloWorld/src/Org.OpenAPITools/Client/Hos...
[]
true
OpenAPITools/openapi-generator
23,833
issue_to_patch
[Kotlin][Spring] Response code 200 generated for default responses #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator ([example](https://apidevtools.org/swagger-parser/online/))? - [x] Have you [tested with th...
fix(kotlin-spring): preserve 'default' response code in postProcessOperationsWithModels
## Description Fixes #17445 When an OpenAPI spec defines a `default` response (a catch-all with no specific HTTP status code), the generator internally represents it with `code = "0"`. The existing logic in `KotlinSpringServerCodegen.postProcessOperationsWithModels` unconditionally mapped `"0"` → `"200"`, causing eve...
fd651513978c5f2ac7028caee9c5caa841d0b6c1
aabbc520c8af994bd4fb7a21853960eff78e3f1d
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/api.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/api.mustache index 2b7662531379..dcc950cdeb75 100644 --- a/modules/openapi-generator/src/main/resources/kotlin-spring/api.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/kotlin-spring/api.mustache", "modules/openapi-generator/src/main/resources/kotlin-spring/apiInterface.mustache", "modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java", "samples/server/petstore/kotlin-sp...
[ { "comment": "Changing default responses from code \"0\" to \"default\" mutates `resp.code` globally, which is also used by kotlin-spring templates to render `@ResponseStatus` via `springHttpStatus`. `SpringHttpStatusLambda` does not accept \"default\" and will throw during generation when `useResponseEntity=fa...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java index 0e83e957927d..d375c88d01a2 100644 --- a/modules/openapi-generator/src/t...
true
OpenAPITools/openapi-generator
23,940
issue_to_patch
build(deps-dev): bump launch-editor from 2.6.0 to 2.14.1 in /samples/client/petstore/typescript-angular-v16-provided-in-root
Bumps [launch-editor](https://github.com/vitejs/launch-editor) from 2.6.0 to 2.14.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/launch-editor/commit/3f97c648307a70e7c930ba63f040e6ba8e72bc16"><code>3f97c64</code></a> v2.14.1</li> <li><a href="https://github.com/vitejs/launch-editor/...
91fa74a391307aa9e2d682ba3d18462884e2561b
256b7b8c05e3294389f2da5bae89b52506d865d3
diff --git a/samples/client/petstore/typescript-angular-v16-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v16-provided-in-root/package-lock.json index 879068815b2b..8a5aea9cc85b 100644 --- a/samples/client/petstore/typescript-angular-v16-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v16-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
23,939
issue_to_patch
build(deps-dev): bump launch-editor from 2.6.0 to 2.14.1 in /samples/client/petstore/typescript-angular-v18-provided-in-root
Bumps [launch-editor](https://github.com/vitejs/launch-editor) from 2.6.0 to 2.14.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/launch-editor/commit/3f97c648307a70e7c930ba63f040e6ba8e72bc16"><code>3f97c64</code></a> v2.14.1</li> <li><a href="https://github.com/vitejs/launch-editor/...
91fa74a391307aa9e2d682ba3d18462884e2561b
30ce97d7a52de048f7e4a3aa613adafe1eff0a1d
diff --git a/samples/client/petstore/typescript-angular-v18-provided-in-root/package-lock.json b/samples/client/petstore/typescript-angular-v18-provided-in-root/package-lock.json index 17eb09a00857..d26207e443e5 100644 --- a/samples/client/petstore/typescript-angular-v18-provided-in-root/package-lock.json +++ b/samples...
[ "samples/client/petstore/typescript-angular-v18-provided-in-root/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
23,938
issue_to_patch
build(deps-dev): bump launch-editor from 2.6.1 to 2.14.1 in /samples/client/others/typescript-angular
Bumps [launch-editor](https://github.com/vitejs/launch-editor) from 2.6.1 to 2.14.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/launch-editor/commit/3f97c648307a70e7c930ba63f040e6ba8e72bc16"><code>3f97c64</code></a> v2.14.1</li> <li><a href="https://github.com/vitejs/launch-editor/...
91fa74a391307aa9e2d682ba3d18462884e2561b
6e91ce94c9993a3970780884cec81f972daf16d6
diff --git a/samples/client/others/typescript-angular/package-lock.json b/samples/client/others/typescript-angular/package-lock.json index 1b0c1dd5ad4b..11e8ae463d43 100644 --- a/samples/client/others/typescript-angular/package-lock.json +++ b/samples/client/others/typescript-angular/package-lock.json @@ -8922,13 +8922...
[ "samples/client/others/typescript-angular/package-lock.json" ]
[]
true
OpenAPITools/openapi-generator
23,912
issue_to_patch
[csharp][generichost] Deserialize present-but-null nullable enums
For a property that is both `required` and `nullable` with an **enum** type, the `generichost` `JsonConverter.Read(...)` only assigned the backing `Option` when the raw JSON string was non-null. An explicit `null` therefore left the `Option` unset, and the required-property check then threw `ArgumentException: Property...
248e917c6f26e5ddc978aebf8e1cd3097dc0abdf
14589964e304f6eded5589825794c93874c92dc6
diff --git a/modules/openapi-generator/src/main/resources/csharp/libraries/generichost/JsonConverter.mustache b/modules/openapi-generator/src/main/resources/csharp/libraries/generichost/JsonConverter.mustache index 469a22eabec3..d8e203b3f1ee 100644 --- a/modules/openapi-generator/src/main/resources/csharp/libraries/gen...
[ "modules/openapi-generator/src/main/resources/csharp/libraries/generichost/JsonConverter.mustache", "modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpClientCodegenTest.java", "samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/src/Org.OpenAPITools/Model/EnumT...
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpClientCodegenTest.java index 86ae543e259e..a8c077a010e9 100644 --- a/modules/openapi-generator/src/test/java/org...
true
OpenAPITools/openapi-generator
22,916
issue_to_patch
[BUG][Scala] OneOf generates incorrect classes. #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [x] Have you validated the input using an OpenAPI validator ([example](https://apidevtools.org/swagger-parser/online/))? - [x] Have you [tested with the latest master](ht...
feat: add support for `oneOf` in sttp4 client
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> Address #19891 for sttp4 clients. @fish86 <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapit...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/.github/workflows/samples-scala-client.yaml b/.github/workflows/samples-scala-client.yaml index c4f4ba939fb9..04e311456c51 100644 --- a/.github/workflows/samples-scala-client.yaml +++ b/.github/workflows/samples-scala-client.yaml @@ -11,6 +11,7 @@ on: - samples/client/petstore/scala-sttp/** -...
[ ".github/workflows/samples-scala-client.yaml", "bin/configs/scala-sttp4-circe.yaml", "docs/generators/scala-sttp4.md", "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ScalaSttp4ClientCodegen.java", "modules/openapi-generator/src/main/resources/scala-sttp4/api.mustache", "module...
[ { "comment": "<!-- metadata:{\"confidence\":0.62} -->\nP2: Request bodies are now always JSON‑serialized with `asJson(...)`, which breaks operations that consume non‑JSON media types by sending JSON instead of the raw body.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/scala/Sttp4CodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/scala/Sttp4CodegenTest.java index 2e74ec6de7eb..9b44ed0a3019 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/scala/St...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":0.62} --> P2: Request bodies are now always JSON‑serialized with `asJson(...)`, which breaks operations that consume non‑JSON media types by sending JSON instead of the raw body. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the ...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/api.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/api.mustache index db73b440585a..1afd073d825e 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/api.mustache +++ b/modules/openapi-generator/src/main/resource...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/api.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":0.62} -->\nP2: Request bodies are now always JSON‑serialized with `asJson(...)`, which breaks operations that consume non‑JSON media types by sending JSON instead of the raw body.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":0.58} --> P2: Inline oneOf member case classes are generated inside the parent model file, but the parent model’s import list isn’t augmented with the child models’ imports. If a oneOf member uses a type not referenced by the parent, the inline case class will compile without the necessary i...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache index ecece27a59a5..d26af861beaa 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":0.58} -->\nP2: Inline oneOf member case classes are generated inside the parent model file, but the parent model’s import list isn’t augmented with the child models’ imports. If a oneOf member uses a type not referenced by the parent, the inline case class will compil...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":7} --> P2: Discriminator handling hardcodes the Scala class name as the wire value, ignoring OpenAPI discriminator mappings, so specs with mapped discriminator values will fail to deserialize/serialize correctly. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache index ecece27a59a5..d26af861beaa 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":7} -->\nP2: Discriminator handling hardcodes the Scala class name as the wire value, ignoring OpenAPI discriminator mappings, so specs with mapped discriminator values will fail to deserialize/serialize correctly.\n\n<details>\n<summary>Prompt for AI agents</summary>\...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":0.55} --> P2: json4s oneOf deserialization aborts on first mismatch because `Extraction.extract` throws, so later oneOf types are never tried. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the root cause and fix it. At modules/op...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache index ecece27a59a5..d26af861beaa 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":0.55} -->\nP2: json4s oneOf deserialization aborts on first mismatch because `Extraction.extract` throws, so later oneOf types are never tried.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root ...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":6} --> P2: `transformConstructorNames` is defined as a partial match over only `x-oneOfMembers`. Because `x-oneOfMembers` excludes shared oneOf subtypes, the function is not total and will throw `MatchError` when encoding/decoding those subtypes. Add a default case (identity) so unmapped con...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache index ecece27a59a5..d26af861beaa 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":6} -->\nP2: `transformConstructorNames` is defined as a partial match over only `x-oneOfMembers`. Because `x-oneOfMembers` excludes shared oneOf subtypes, the function is not total and will throw `MatchError` when encoding/decoding those subtypes. Add a default case (...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":8} --> P2: Wildcard `case other` is emitted inside the oneOfMembers loop, so the first wildcard matches everything and makes subsequent member cases unreachable; only the first oneOf member can be encoded/decoded. <details> <summary>Prompt for AI agents</summary> ```text Check if this issu...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache index ecece27a59a5..d26af861beaa 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Wildcard `case other` is emitted inside the oneOfMembers loop, so the first wildcard matches everything and makes subsequent member cases unreachable; only the first oneOf member can be encoded/decoded.\n\n<details>\n<summary>Prompt for AI agents</summary>...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
please add the new folder to the github workflow: `.github/workflows/samples-scala-client.yaml`
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/bin/configs/scala-sttp4-circe.yaml b/bin/configs/scala-sttp4-circe.yaml new file mode 100644 index 000000000000..330a9ae1803d --- /dev/null +++ b/bin/configs/scala-sttp4-circe.yaml @@ -0,0 +1,7 @@ +generatorName: scala-sttp4 +outputDir: samples/client/petstore/scala-sttp4-circe +inputSpec: modules/openapi-...
[ "bin/configs/scala-sttp4-circe.yaml" ]
[ { "comment": "please add the new folder to the github workflow:\n\n`.github/workflows/samples-scala-client.yaml`", "path": "bin/configs/scala-sttp4-circe.yaml", "hunk": "@@ -0,0 +1,7 @@\n+generatorName: scala-sttp4\n+outputDir: samples/client/petstore/scala-sttp4-circe", "resolving_sha": "21efd98e5b...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
do we need to update this in the template as well? build failure: ``` [info] set current project to openapi-client (in build file:/home/runner/work/openapi-generator/openapi-generator/samples/client/petstore/scala-sttp4/) [error] java.lang.RuntimeException: Expected `scala-sttp4 / scalaVersion` to be 2.13.18 or late...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/samples/client/petstore/scala-sttp4/build.sbt b/samples/client/petstore/scala-sttp4/build.sbt index 9ad901170074..47e47be09c4e 100644 --- a/samples/client/petstore/scala-sttp4/build.sbt +++ b/samples/client/petstore/scala-sttp4/build.sbt @@ -2,12 +2,12 @@ version := "1.0.0" name := "openapi-client" organ...
[ "samples/client/petstore/scala-sttp4/build.sbt" ]
[ { "comment": "do we need to update this in the template as well?\n\nbuild failure: \n\n```\n[info] set current project to openapi-client (in build file:/home/runner/work/openapi-generator/openapi-generator/samples/client/petstore/scala-sttp4/)\n[error] java.lang.RuntimeException: Expected `scala-sttp4 / scalaVe...
true
OpenAPITools/openapi-generator
22,916
comment_to_fix
feat: add support for `oneOf` in sttp4 client
<!-- metadata:{"confidence":9} --> P1: Circe oneOf encoder with wrapper composition does not add discriminator in discriminator mode, causing mismatch with decoder that requires discriminator. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the root cause and...
4e4cace6a6fafcd94d267ce123c08b01e38b3d59
21efd98e5b4cebbf0af0aa10cdaafcdb81a52b04
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache index ecece27a59a5..d26af861beaa 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache +++ b/modules/openapi-generator/src/main/re...
[ "modules/openapi-generator/src/main/resources/scala-sttp4/model.mustache" ]
[ { "comment": "<!-- metadata:{\"confidence\":9} -->\nP1: Circe oneOf encoder with wrapper composition does not add discriminator in discriminator mode, causing mismatch with decoder that requires discriminator.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so...
true
OpenAPITools/openapi-generator
23,930
issue_to_patch
feat(dart): make requests abortable
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> allows using the standard http.Client mechanism to abort requests, which is useful for both teardown and overall responsiveness. port of https://github.com/immich-app/immich/pull/2869...
1dc89bd3d9081a4b2eff6baa8f7866109eb88a15
2bac5692e96b0aa1c738baed22db4aa4b58055dc
diff --git a/modules/openapi-generator/src/main/resources/dart2/api.mustache b/modules/openapi-generator/src/main/resources/dart2/api.mustache index 219b85dc56a1..1c995009e018 100644 --- a/modules/openapi-generator/src/main/resources/dart2/api.mustache +++ b/modules/openapi-generator/src/main/resources/dart2/api.mustac...
[ "modules/openapi-generator/src/main/resources/dart2/api.mustache", "modules/openapi-generator/src/main/resources/dart2/api_client.mustache", "samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/pet_api.dart", "samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/store_api.dart", ...
[ { "comment": "<!-- cubic:v=9862f3fc-272f-4a5b-b66f-e3c381b71003 -->\n<!-- cubic:review-run=2767c1be-6e71-4e3f-81b5-cf4ebea7b969 -->\n<!-- metadata:{\"confidence\":9} -->\nP2: GET/HEAD requests now unintentionally include an empty body due to unconditional body assignment. The unified AbortableRequest path compu...
true
OpenAPITools/openapi-generator
23,930
comment_to_fix
feat(dart): make requests abortable
<!-- cubic:v=9862f3fc-272f-4a5b-b66f-e3c381b71003 --> <!-- cubic:review-run=2767c1be-6e71-4e3f-81b5-cf4ebea7b969 --> <!-- metadata:{"confidence":9} --> P2: GET/HEAD requests now unintentionally include an empty body due to unconditional body assignment. The unified AbortableRequest path computes msgBody via serializeAs...
1dc89bd3d9081a4b2eff6baa8f7866109eb88a15
2bac5692e96b0aa1c738baed22db4aa4b58055dc
diff --git a/samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api_client.dart b/samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api_client.dart index 94edfa501db0..c95c46ef3b81 100644 --- a/samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api_client.dart +++ b/samples/openapi3...
[ "samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api_client.dart" ]
[ { "comment": "<!-- cubic:v=9862f3fc-272f-4a5b-b66f-e3c381b71003 -->\n<!-- cubic:review-run=2767c1be-6e71-4e3f-81b5-cf4ebea7b969 -->\n<!-- metadata:{\"confidence\":9} -->\nP2: GET/HEAD requests now unintentionally include an empty body due to unconditional body assignment. The unified AbortableRequest path compu...
true
OpenAPITools/openapi-generator
23,930
comment_to_fix
feat(dart): make requests abortable
thanks for the PR is this PR backward compatible given the change (above) in method signature?
1dc89bd3d9081a4b2eff6baa8f7866109eb88a15
2bac5692e96b0aa1c738baed22db4aa4b58055dc
diff --git a/samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/pet_api.dart b/samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/pet_api.dart index f6cb28f6cc2a..65bd7ec0d8d2 100644 --- a/samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/pet_api.dart +++ b/samples/opena...
[ "samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/pet_api.dart" ]
[ { "comment": "thanks for the PR\n\nis this PR backward compatible given the change (above) in method signature?", "path": "samples/openapi3/client/petstore/dart2/petstore_client_lib/lib/api/pet_api.dart", "hunk": "@@ -26,7 +26,7 @@ class PetApi {\n ///\n /// * [Pet] pet (required):\n /// Pet obj...
true
OpenAPITools/openapi-generator
23,856
issue_to_patch
[BUG][rust-axum][python-fastapi] Duplicate model generated when same external schema is referenced via allOf chains across multiple files #### Bug Report Checklist - [x] Have you provided a full/minimal spec to reproduce the issue? - [ ] Have you validated the input using an OpenAPI validator? - [x] Have you tested w...
fix(InlineModelResolver): prevent numbered duplicate models from multi-file OAS 3.1 specs
fix #23854 ## Problem Multi-file OAS 3.1 specs produce numbered duplicate models (e.g. `DeletionRequest1`, `FlowSegmentPost1`, `ContainerMapping1`) due to three related bugs in `InlineModelResolver`: 1. Pre-existing `components/schemas` entries were not seeded into the deduplication map before flattening, ...
f085d85a494b176f4afceed22682ff4aefc9cebf
8f02aab7ebc938ee545168291e71a6ef771525c2
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java index b4d64849060c..b9ed1c9eba38 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelRes...
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/InlineModelResolver.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java", "modules/openapi-generator/src/test/resources/3_0/inline-model-resolver-dedup/collection-item.yaml", "modules/openapi-ge...
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/InlineModelResolverTest.java index 0670942f8fd0..61bf18b51b11 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/Inline...
true
OpenAPITools/openapi-generator
23,946
issue_to_patch
[BUG] [JAVA] @Tag import is not being added while using annotationLibrary=swagger2 ##### Description Using <annotationLibrary>swagger2</annotationLibrary> with java generator does not compile. Import for `@Tag `annotation is missing. <img width="451" height="353" alt="Image" src="https://github.com/user-attachments...
fix: [JAVA][rest-assured] missing swagger2 tags package import in generated API class
to fix #23285 <!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/mas...
2b76ca1062dd32bd5fa0a7c1d9fe7201bc0389b0
2cfb048b346bb88bc9345d19d3ff81d0c2f8eb66
diff --git a/modules/openapi-generator/src/main/resources/Java/libraries/rest-assured/api.mustache b/modules/openapi-generator/src/main/resources/Java/libraries/rest-assured/api.mustache index e6da4fceea08..fb5fc0471f5c 100644 --- a/modules/openapi-generator/src/main/resources/Java/libraries/rest-assured/api.mustache +...
[ "modules/openapi-generator/src/main/resources/Java/libraries/rest-assured/api.mustache", "modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java", "modules/openapi-generator/src/test/resources/3_0/java/petstore.yaml" ]
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java index 2fc1135296a5..606302bd0521 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/...
true
OpenAPITools/openapi-generator
23,915
issue_to_patch
[java][restclient][webclient] add localVar prefix to queryParams variables
add localVar prefix to avoid compilation errors due to name collisions. another workaround is to use parameterNameMapping option: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#name-mapping cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbo...
3ca56a98a525910205b0491413fd9d2536739f18
8c1712daace769987903bdf419086fd91f18fd88
diff --git a/modules/openapi-generator/src/main/resources/Java/libraries/restclient/api.mustache b/modules/openapi-generator/src/main/resources/Java/libraries/restclient/api.mustache index 48f7beb1ea4b..a56461f5f0a2 100644 --- a/modules/openapi-generator/src/main/resources/Java/libraries/restclient/api.mustache +++ b/m...
[ "modules/openapi-generator/src/main/resources/Java/libraries/restclient/api.mustache", "modules/openapi-generator/src/main/resources/Java/libraries/webclient/api.mustache", "modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java", "samples/client/echo_api/java/restcli...
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/JavaClientCodegenTest.java index 2fc1135296a5..66e59ffbbcf8 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/...
true
OpenAPITools/openapi-generator
23,801
issue_to_patch
[scala-sttp4-jsoniter] extend Primitive type with UUID, LocalDate and OffsetDateTime
Extend the `Primitive` union type in `helpers.mustache` with `UUID`, `LocalDate`, and `OffsetDateTime` so that path, query, header, cookie, and form parameters typed with these formats serialize via `.toString()` on the fast primitive path. Without this, fields generated from `format: uuid`, `format: date`, and `fo...
91fa74a391307aa9e2d682ba3d18462884e2561b
03a7f9bd59260ea6e19761f6cbe4f88ac3e2e3e2
diff --git a/modules/openapi-generator/src/main/resources/scala-sttp4-jsoniter/helpers.mustache b/modules/openapi-generator/src/main/resources/scala-sttp4-jsoniter/helpers.mustache index 48967ba5b3d2..67b12557e73a 100644 --- a/modules/openapi-generator/src/main/resources/scala-sttp4-jsoniter/helpers.mustache +++ b/modu...
[ "modules/openapi-generator/src/main/resources/scala-sttp4-jsoniter/helpers.mustache", "samples/client/petstore/scala-sttp4-jsoniter/src/main/scala/org/openapitools/client/core/Helpers.scala" ]
[]
true
OpenAPITools/openapi-generator
23,947
issue_to_patch
Add tests for scala-sttp4-jsoniter client generator
a follow up PR to https://github.com/OpenAPITools/openapi-generator/pull/23801#top <!-- Please check the completed items below --> ### PR checklist - [ ] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md). - [ ] Run the following to [build the proj...
e12fd07d2ad145a3ed14481cd82ff389474c53c9
d09bde2bbbf14fd003677f82ec8494104f24392c
diff --git a/samples/client/petstore/scala-sttp4-jsoniter/.openapi-generator/FILES b/samples/client/petstore/scala-sttp4-jsoniter/.openapi-generator/FILES index 513420c86ce1..be5eb33ec06b 100644 --- a/samples/client/petstore/scala-sttp4-jsoniter/.openapi-generator/FILES +++ b/samples/client/petstore/scala-sttp4-jsonite...
[ "modules/openapi-generator/src/test/resources/3_0/scala/scala-sttp4-jsoniter/petstore.yaml", "samples/client/petstore/scala-sttp4-jsoniter/.openapi-generator/FILES", "samples/client/petstore/scala-sttp4-jsoniter/README.md", "samples/client/petstore/scala-sttp4-jsoniter/src/main/scala/org/openapitools/client/a...
[]
diff --git a/modules/openapi-generator/src/test/resources/3_0/scala/scala-sttp4-jsoniter/petstore.yaml b/modules/openapi-generator/src/test/resources/3_0/scala/scala-sttp4-jsoniter/petstore.yaml index a8f9809a1249..6b4e73e18d47 100644 --- a/modules/openapi-generator/src/test/resources/3_0/scala/scala-sttp4-jsoniter/pet...
true
OpenAPITools/openapi-generator
23,851
issue_to_patch
fix(core): normalize OAS 3.1 content media schemas
Refs #23095 Refs #13083, #9083 OpenAPI 3.1 allows a binary string payload to be represented with JSON Schema content keywords, for example: ```yaml type: string contentMediaType: application/octet-stream ``` OpenAPI Generator already has binary/file handling around the normalized `type: string` + `format: binary` sh...
74f7b0731e9e592dd35f0979391134be9b85d6dd
a203ae825b1ce2a8f3cdb0b5d7780317c0cf070e
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java index 68750b1bdefc..3ef8e0912bb9 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer....
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/OpenAPINormalizerTest.java", "modules/openapi-generator/src/t...
[ { "comment": "please add docstring to newly created functions below. thanks", "path": "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java", "hunk": "@@ -2310,6 +2315,50 @@ protected Schema processNormalize31Spec(Schema schema, Set<Schema> visitedSchema\n retu...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java index 86225e43ea54..afd75b3f16f6 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTe...
true
OpenAPITools/openapi-generator
23,851
comment_to_fix
fix(core): normalize OAS 3.1 content media schemas
please add docstring to newly created functions below. thanks
74f7b0731e9e592dd35f0979391134be9b85d6dd
a203ae825b1ce2a8f3cdb0b5d7780317c0cf070e
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java index 68750b1bdefc..3ef8e0912bb9 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer....
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java" ]
[ { "comment": "please add docstring to newly created functions below. thanks", "path": "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java", "hunk": "@@ -2310,6 +2315,50 @@ protected Schema processNormalize31Spec(Schema schema, Set<Schema> visitedSchema\n retu...
true
OpenAPITools/openapi-generator
23,937
issue_to_patch
[php-nextgen] Check for $openApiType === "string" instead of "\DateTime" in ObjectSerializer
ObjectSerializer incorretly validates the `$openApiType` equals `\DateTime`. This is not a valid OpenAPI type, instead, it should validate the type to be `string`. <!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> <!-- Please check t...
91fa74a391307aa9e2d682ba3d18462884e2561b
69cbd927accaf8aba06609b93cd2d3caa7452004
diff --git a/modules/openapi-generator/src/main/resources/php-nextgen/ObjectSerializer.mustache b/modules/openapi-generator/src/main/resources/php-nextgen/ObjectSerializer.mustache index 401561cfc353..4eca3417e7d2 100644 --- a/modules/openapi-generator/src/main/resources/php-nextgen/ObjectSerializer.mustache +++ b/modu...
[ "modules/openapi-generator/src/main/resources/php-nextgen/ObjectSerializer.mustache", "samples/client/echo_api/php-nextgen-streaming/src/ObjectSerializer.php", "samples/client/echo_api/php-nextgen/src/ObjectSerializer.php", "samples/client/petstore/php-nextgen/OpenAPIClient-php/src/ObjectSerializer.php" ]
[]
true
OpenAPITools/openapi-generator
23,928
issue_to_patch
[Python] fix constraint settings for decimalType
<!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> Fixes Python constraints where `less than` and `greater than` were inverted. <!-- Please check the completed items below --> ### PR checklist - [x] Read the [contribution guideli...
1dc89bd3d9081a4b2eff6baa8f7866109eb88a15
29d63a20230231c192366be22886dd67ea4ca021
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java index 4809bf64f156..510cf09b44c7 100644 --- a/modules/openapi-generator/src/main/java/org/openapitool...
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonCodegen.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonClientCodegenTest.java", "modules/openapi-generator/src/test/resources/3_0/unit_test_spec/format.yaml" ]
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonClientCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonClientCodegenTest.java index f5bc24393993..bd97269b4e36 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/...
true
OpenAPITools/openapi-generator
23,694
issue_to_patch
[JAVA-SPRING,KOTLIN-SPRING] - Enhance pageable validation by adding minSize and minPage constraints; Search also allOf references for constraints; fix PagedModel<T> substitution with 'modelNameSuffix' or 'modelNamePrefix'; add ValuedEnum<T> interface
Functionality implemented in #23575 is a bit incomplete (it is fully functional, but can miss some edge cases). In cases when the `minimum/maximum/default` values live on a schema referenced via `allOf`, the validations/defaults fail to generate.This PR fixes the behavior to properly discover the validation `minimum/ma...
4e31e4da8a8cefca5e3152c31ebdc37492942542
328d83fb8586694a81196dd772f22de2811d0b0a
diff --git a/bin/configs/kotlin-spring-boot-integer-enum.yaml b/bin/configs/kotlin-spring-boot-integer-enum.yaml index 8298ce6be08a..0b23e72b5bf6 100644 --- a/bin/configs/kotlin-spring-boot-integer-enum.yaml +++ b/bin/configs/kotlin-spring-boot-integer-enum.yaml @@ -11,3 +11,4 @@ additionalProperties: annotationLibr...
[ "bin/configs/kotlin-spring-boot-integer-enum.yaml", "bin/configs/kotlin-spring-boot.yaml", "bin/configs/spring-boot-3-include-http-request-context.yaml", "bin/configs/spring-boot-4.yaml", "bin/configs/spring-boot-sort-validation.yaml", "bin/configs/spring-boot.yaml", "docs/generators/java-camel.md", "...
[ { "comment": "<!-- metadata:{\"confidence\":9} -->\nP2: Array schemas without `items` can now NPE here because `ModelUtils.isArraySchema()` does not guarantee `schema.getItems()` is non-null.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the r...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java index 920b2f6129f8..14b541cf9f0c 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/co...
true
OpenAPITools/openapi-generator
23,694
comment_to_fix
[JAVA-SPRING,KOTLIN-SPRING] - Enhance pageable validation by adding minSize and minPage constraints; Search also allOf references for constraints; fix PagedModel<T> substitution with 'modelNameSuffix' or 'modelNamePrefix'; add ValuedEnum<T> interface
<!-- metadata:{"confidence":9} --> P2: Array schemas without `items` can now NPE here because `ModelUtils.isArraySchema()` does not guarantee `schema.getItems()` is non-null. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the root cause and fix it. At module...
4e31e4da8a8cefca5e3152c31ebdc37492942542
328d83fb8586694a81196dd772f22de2811d0b0a
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringPageableScanUtils.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringPageableScanUtils.java index 17ceb3757fdb..c4f44ee9832c 100644 --- a/modules/openapi-generator/src/main/java/org/openapi...
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringPageableScanUtils.java" ]
[ { "comment": "<!-- metadata:{\"confidence\":9} -->\nP2: Array schemas without `items` can now NPE here because `ModelUtils.isArraySchema()` does not guarantee `schema.getItems()` is non-null.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the r...
true
OpenAPITools/openapi-generator
23,694
comment_to_fix
[JAVA-SPRING,KOTLIN-SPRING] - Enhance pageable validation by adding minSize and minPage constraints; Search also allOf references for constraints; fix PagedModel<T> substitution with 'modelNameSuffix' or 'modelNamePrefix'; add ValuedEnum<T> interface
<!-- metadata:{"confidence":10} --> P2: Removing @Test orphaned this regression test, so JUnit will no longer execute it. <details> <summary>Prompt for AI agents</summary> ```text Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/test/java/org/openapitools/co...
4e31e4da8a8cefca5e3152c31ebdc37492942542
328d83fb8586694a81196dd772f22de2811d0b0a
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java index 0e83e957927d..4ac2f195bb74 100644 --- a/modules/openapi-generator/src/t...
[ "modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java" ]
[ { "comment": "<!-- metadata:{\"confidence\":10} -->\nP2: Removing @Test orphaned this regression test, so JUnit will no longer execute it.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/sr...
true
OpenAPITools/openapi-generator
23,694
comment_to_fix
[JAVA-SPRING,KOTLIN-SPRING] - Enhance pageable validation by adding minSize and minPage constraints; Search also allOf references for constraints; fix PagedModel<T> substitution with 'modelNameSuffix' or 'modelNamePrefix'; add ValuedEnum<T> interface
FYI. I'll file some PRs later to drop spring boot 2.x support.
4e31e4da8a8cefca5e3152c31ebdc37492942542
328d83fb8586694a81196dd772f22de2811d0b0a
diff --git a/samples/server/petstore/springboot/pom.xml b/samples/server/petstore/springboot/pom.xml index c2f2c637d7ba..84658573bdf6 100644 --- a/samples/server/petstore/springboot/pom.xml +++ b/samples/server/petstore/springboot/pom.xml @@ -6,19 +6,19 @@ <name>springboot</name> <version>1.0.0-SNAPSHOT</vers...
[ "samples/server/petstore/springboot/pom.xml" ]
[ { "comment": "FYI. I'll file some PRs later to drop spring boot 2.x support.\n", "path": "samples/server/petstore/springboot/pom.xml", "hunk": "@@ -6,19 +6,19 @@\n <name>springboot</name>\n <version>1.0.0-SNAPSHOT</version>\n <properties>\n- <java.version>17</java.version>\n- <...
true
OpenAPITools/openapi-generator
23,932
issue_to_patch
Normalizer: new rule LOOSE_NULL_DEFINITIONS to allow more `null` definitions in 3.0 spec.
Normalizer: new rule LOOSE_NULL_DEFINITIONS to allow more null definitions in 3.0 spec When set to true, `{type: object, nullable: true}` (in 3.0 spec) is considered as `null` type in 3.1 spec. based on https://github.com/OpenAPITools/openapi-generator/pull/23621 by @ericdriggs e.g. in CLI ``` java -jar modu...
4e31e4da8a8cefca5e3152c31ebdc37492942542
0e501ef5e6dd38ed35213babc8f2fa3d30ede79f
diff --git a/docs/customization.md b/docs/customization.md index e43a72893471..9cf7ee85f7c5 100644 --- a/docs/customization.md +++ b/docs/customization.md @@ -644,6 +644,13 @@ Example: java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g java -i modules/openapi-generator/src/test/resour...
[ "docs/customization.md", "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java", "modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java", "modules/openapi-generator/src/test/java/org/openapitools/codegen/OpenAPINormalizerTest.java", "module...
[ { "comment": "<!-- cubic:v=21859cdc-7d31-4348-af6a-8fc2df96b5e5 -->\n<!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 -->\n<!-- metadata:{\"confidence\":10} -->\nP0: Copy-paste bug: `rules.put(SECURITY_SCHEMES_FILTER, true)` should be `rules.put(LOOSE_NULL_DEFINITIONS, true)`. Enabling `LOOSE_NULL_DEF...
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/OpenAPINormalizerTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/OpenAPINormalizerTest.java index 294a38bff8fe..53cacea15650 100644 --- a/modules/openapi-generator/src/test/java/org/openapitools/codegen/OpenAPINor...
true
OpenAPITools/openapi-generator
23,932
comment_to_fix
Normalizer: new rule LOOSE_NULL_DEFINITIONS to allow more `null` definitions in 3.0 spec.
<!-- cubic:v=21859cdc-7d31-4348-af6a-8fc2df96b5e5 --> <!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 --> <!-- metadata:{"confidence":10} --> P0: Copy-paste bug: `rules.put(SECURITY_SCHEMES_FILTER, true)` should be `rules.put(LOOSE_NULL_DEFINITIONS, true)`. Enabling `LOOSE_NULL_DEFINITIONS` incorrectly also ...
4e31e4da8a8cefca5e3152c31ebdc37492942542
0e501ef5e6dd38ed35213babc8f2fa3d30ede79f
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java index 3ef8e0912bb9..f2909042bbba 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer....
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java" ]
[ { "comment": "<!-- cubic:v=21859cdc-7d31-4348-af6a-8fc2df96b5e5 -->\n<!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 -->\n<!-- metadata:{\"confidence\":10} -->\nP0: Copy-paste bug: `rules.put(SECURITY_SCHEMES_FILTER, true)` should be `rules.put(LOOSE_NULL_DEFINITIONS, true)`. Enabling `LOOSE_NULL_DEF...
true
OpenAPITools/openapi-generator
23,932
comment_to_fix
Normalizer: new rule LOOSE_NULL_DEFINITIONS to allow more `null` definitions in 3.0 spec.
<!-- cubic:v=4c168129-2bd7-4d2c-807d-b7d042a43a81 --> <!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 --> <!-- metadata:{"confidence":9} --> P1: `LOOSE_NULL_DEFINITIONS` mutates a static global flag one-way, so one run can leak null-handling behavior into later runs. <details> <summary>Prompt for AI agents<...
4e31e4da8a8cefca5e3152c31ebdc37492942542
0e501ef5e6dd38ed35213babc8f2fa3d30ede79f
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java index 3ef8e0912bb9..f2909042bbba 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer....
[ "modules/openapi-generator/src/main/java/org/openapitools/codegen/OpenAPINormalizer.java" ]
[ { "comment": "<!-- cubic:v=4c168129-2bd7-4d2c-807d-b7d042a43a81 -->\n<!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: `LOOSE_NULL_DEFINITIONS` mutates a static global flag one-way, so one run can leak null-handling behavior into later runs.\n\n<details>\n...
true
OpenAPITools/openapi-generator
23,932
comment_to_fix
Normalizer: new rule LOOSE_NULL_DEFINITIONS to allow more `null` definitions in 3.0 spec.
<!-- cubic:v=4ab4f336-4267-4699-a41a-69461bc4a507 --> <!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 --> <!-- metadata:{"confidence":9} --> P2: Documentation inaccurately states the feature affects "OpenAPI 3.1 spec" when it actually applies to OpenAPI 3.0.x specs only (behavior in 3.1 is unchanged). <deta...
4e31e4da8a8cefca5e3152c31ebdc37492942542
0e501ef5e6dd38ed35213babc8f2fa3d30ede79f
diff --git a/docs/customization.md b/docs/customization.md index e43a72893471..9cf7ee85f7c5 100644 --- a/docs/customization.md +++ b/docs/customization.md @@ -644,6 +644,13 @@ Example: java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g java -i modules/openapi-generator/src/test/resour...
[ "docs/customization.md" ]
[ { "comment": "<!-- cubic:v=4ab4f336-4267-4699-a41a-69461bc4a507 -->\n<!-- cubic:review-run=1be3a45c-9071-41c1-961a-ec0a31c587e3 -->\n<!-- metadata:{\"confidence\":9} -->\nP2: Documentation inaccurately states the feature affects \"OpenAPI 3.1 spec\" when it actually applies to OpenAPI 3.0.x specs only (behavior...
true
OpenAPITools/openapi-generator
23,926
issue_to_patch
fix(Kotlin): use the global apiNamePrefix and apiNameSuffix settings instead of apiSuffix (generator's option)
fixes (#23822) As discussed in #23834 opened PR for master aswell as the change has a fallback. <!-- Enter details of the change here. Include additional tests that have been done, reference to the issue for tracking, etc. --> Removes Kotlin specific apiSuffix additionalSetting. Adds support for global apiNam...
1dc89bd3d9081a4b2eff6baa8f7866109eb88a15
25a101af1e3d47671749845edb68acf5e0b1eb99
diff --git a/docs/generators/kotlin-misk.md b/docs/generators/kotlin-misk.md index 3832b9120655..1fe3d8cd2db2 100644 --- a/docs/generators/kotlin-misk.md +++ b/docs/generators/kotlin-misk.md @@ -26,7 +26,6 @@ These options may be applied as additional-properties (cli) or configOptions (pl |actionRequestContentTypePref...
[ "docs/generators/kotlin-misk.md", "docs/generators/kotlin-server.md", "docs/generators/kotlin-spring.md", "docs/generators/kotlin-vertx.md", "docs/generators/kotlin-wiremock.md", "docs/generators/kotlin.md", "modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenConstants.java", "mod...
[]
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/AbstractKotlinCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/AbstractKotlinCodegenTest.java index 91b7ed3af8fc..2f249b43bdf4 100644 --- a/modules/openapi-generator/src/test/java/org/openapito...
true
OpenAPITools/openapi-generator
23,931
issue_to_patch
[kotlin-server] Update vertx core to newer version
to close https://github.com/OpenAPITools/openapi-generator/pull/new/update-vertx-cor <!-- Please check the completed items below --> ### PR checklist - [ ] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md). - [ ] Run the following to [build the pr...
c4cd89a564c06843a706cf1c8947514aa59edbb4
b44a120d8567c82233ec1717bfe5ab4895948c42
diff --git a/modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache b/modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache index 49c2f542d47c..4744f9070659 100644 --- a/modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache +++ b/modules/openapi-gen...
[ "modules/openapi-generator/src/main/resources/kotlin-vertx-server/pom.mustache", "samples/server/petstore/kotlin-vertx-modelMutable/pom.xml", "samples/server/petstore/kotlin/vertx/pom.xml" ]
[]
true
OpenCut-app/OpenCut
756
issue_to_patch
Add support for basic SRT subtitle import to Captions panel
Phase one support for #749 ## Changelog - Splits Captions panel into two "tabs": Generate and Import - adds `.srt` import support for generating text elements - Presents warning when some subtitle cues are skipped - Improves default subtitle layout for captions by shrinking default text size, "pinning" to bottom...
d85566ab8db3c41981551ba968bf95e023a51189
7cb698329451b05e4c6ddafefe079df5ea9ebc42
diff --git a/apps/web/src/components/editor/panels/assets/views/captions.tsx b/apps/web/src/components/editor/panels/assets/views/captions.tsx index c89e587b1..488875a85 100644 --- a/apps/web/src/components/editor/panels/assets/views/captions.tsx +++ b/apps/web/src/components/editor/panels/assets/views/captions.tsx @@ ...
[ "apps/web/src/components/editor/panels/assets/views/captions.tsx", "apps/web/src/lib/subtitles/ass.ts", "apps/web/src/lib/subtitles/build-subtitle-text-element.ts", "apps/web/src/lib/subtitles/insert.ts", "apps/web/src/lib/subtitles/parse.ts", "apps/web/src/lib/subtitles/srt.ts", "apps/web/src/lib/subti...
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Keep transient status/error state scoped to each tab.**\n\n`isProcessing`, `processingStep`, `error`, and `warnings` are shared across both workflows, so an import failure or in-flight import can bleed into the Generate tab if the user switches views mid-oper...
true
OpenCut-app/OpenCut
756
comment_to_fix
Add support for basic SRT subtitle import to Captions panel
_⚠️ Potential issue_ | _🟡 Minor_ **Keep transient status/error state scoped to each tab.** `isProcessing`, `processingStep`, `error`, and `warnings` are shared across both workflows, so an import failure or in-flight import can bleed into the Generate tab if the user switches views mid-operation. Please either keep ...
d85566ab8db3c41981551ba968bf95e023a51189
7cb698329451b05e4c6ddafefe079df5ea9ebc42
diff --git a/apps/web/src/components/editor/panels/assets/views/captions.tsx b/apps/web/src/components/editor/panels/assets/views/captions.tsx index c89e587b1..488875a85 100644 --- a/apps/web/src/components/editor/panels/assets/views/captions.tsx +++ b/apps/web/src/components/editor/panels/assets/views/captions.tsx @@ ...
[ "apps/web/src/components/editor/panels/assets/views/captions.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Keep transient status/error state scoped to each tab.**\n\n`isProcessing`, `processingStep`, `error`, and `warnings` are shared across both workflows, so an import failure or in-flight import can bleed into the Generate tab if the user switches views mid-oper...
true
OpenCut-app/OpenCut
740
issue_to_patch
Fix transcription sample-rate handling
Fix for #703. Adds an optional sampleRate parameter to the decodeAudioToFloat32() function. The caption transcriber passes in a value of 16000 to prepare audio in the format Whisper expects. ⚠️ READ BEFORE SUBMITTING ⚠️ We are not currently accepting PRs except for critical bugs. If this is a bug fix: - [x...
f2eed05d36846cd771458b20e77840e907084bc5
7ce45c86b79c29789a12bb1072a2b75007b0710c
diff --git a/apps/web/src/components/editor/panels/assets/views/captions.tsx b/apps/web/src/components/editor/panels/assets/views/captions.tsx index 7a3b16bf3..a73fd693b 100644 --- a/apps/web/src/components/editor/panels/assets/views/captions.tsx +++ b/apps/web/src/components/editor/panels/assets/views/captions.tsx @@ ...
[ "apps/web/src/components/editor/panels/assets/views/captions.tsx", "apps/web/src/constants/transcription-constants.ts", "apps/web/src/lib/media/audio.ts" ]
[]
true
OpenCut-app/OpenCut
518
issue_to_patch
[BUG] Horizontal scrolling of timeline section ### Platform MacOS ### Browser Chrome 138.0.7204.93 ### Current Behavior The tracks section and time section in Timeline can be scrolled separately. The git commit hash for the recording below: c0651fec193bcea9a1764ca8435d7191c5d3980d https://github.com/user-attach...
restore horizontal scroll sync after Radix ScrollArea removal
## Description Restores horizontal scroll synchronization between the timeline ruler and the track section, which was broken after the removal of the Radix `ScrollArea`. This regression was introduced in commit `c0651fe`. The previous implementation relied on Radix-specific DOM selectors which no longer exist. ...
efbbc48bc5d20b8df3c1fe5feab3f6471263da4e
db79e53e67b361e424a62b41d3fa58a90b51c96d
diff --git a/apps/web/src/components/editor/timeline/index.tsx b/apps/web/src/components/editor/timeline/index.tsx index 7a2cc7f2c..6b93ea9d6 100644 --- a/apps/web/src/components/editor/timeline/index.tsx +++ b/apps/web/src/components/editor/timeline/index.tsx @@ -426,15 +426,9 @@ export function Timeline() { // -...
[ "apps/web/src/components/editor/timeline/index.tsx" ]
[]
true