repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Netflix/fast_jsonapi | 280 | issue_to_patch | Introduce the ability to add `meta` tag for every resource in the collection | Current behaviour:
We currently allow the use of `meta` tags, but this is limited for use only at a top/collection level, that has to be passed in along with the call to `serialized_json`, for eg:
```ruby
options = {}
options[:meta] = { total: 2 }
MovieSerializer.new([movie], options).serialized_json
```
P... | 40125072c5c1712d98ad6d7894c133926a2cd8d1 | 099eb606bd87c4e4a7d238472bcc77185447740e | diff --git a/README.md b/README.md
index a03e1a8c..b9fe2ba6 100644
--- a/README.md
+++ b/README.md
@@ -245,6 +245,23 @@ class MovieSerializer
end
```
+### Meta Per Resource
+
+For every resource in the collection, you can include a meta object containing non-standard meta-information about a resource that can not b... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_class_methods_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 3c477c34..b8a1eea3 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -249,6 +249,34 @@
end
end
+ describe '#meta' do
+ ... | true | |
Netflix/fast_jsonapi | 278 | issue_to_patch | Params are now passed to nested includes | Fixes https://github.com/Netflix/fast_jsonapi/issues/277 | 75c959af81e1d487f1e69529430150f83cf93560 | dfcbe263fb05a5be860facb2f7e9090edf9b63f9 | diff --git a/lib/fast_jsonapi/serialization_core.rb b/lib/fast_jsonapi/serialization_core.rb
index 6ec069a9..8d2950a1 100644
--- a/lib/fast_jsonapi/serialization_core.rb
+++ b/lib/fast_jsonapi/serialization_core.rb
@@ -123,7 +123,7 @@ def get_included_records(record, includes_list, known_included_objects, fieldset
... | [
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 07cbbef4..06aac377 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -310,6 +310,23 @@ class BlahSerializer
end
end
+ context 'when serializing included, params should be avail... | true | |
Netflix/fast_jsonapi | 274 | issue_to_patch | Evaluate ids via the specified 'id_method_name' when relationships are evaluated via a block | Current behaviour:
Currently, we are able to use the `id_method_name` argument to specify the method which has to be used to evaluate the id of an object.
Eg:
```ruby
class Movie
include FastJsonapi::ObjectSerializer
has_many :actors, id_method_name: :actor_uuids
end
```
This works as expected.
Howe... | 40125072c5c1712d98ad6d7894c133926a2cd8d1 | 6d03db3a0c4eeeefc1d79213c3bc653b89013889 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 7f740c8e..d6015c52 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -232,7 +232,11 @@ def create_relationship(base_key, relationship_type, options, block)
Relationsh... | [
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [
{
"comment": "from the test specification it is not clear that [or why] the hash is actually *correct*\r\n\r\nis it possible to compare `hash[:data][:relationships][:awards][:data]` to a full hash where it will be visible that exactly `imdb_award_id` was used to serialize `id`",
"path": "spec/lib/object_ser... | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 3c477c34..33138d59 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -87,6 +87,31 @@
end
end
+ describe '#has_many with ... | true | |
Netflix/fast_jsonapi | 320 | issue_to_patch | Release 1.4 | 4afa5b81d83e78afc2c4c261dff9a204c57e7eb5 | 90e0feef3ce2c7ae4914cf5ca18be3b71cfa5434 | diff --git a/README.md b/README.md
index 53cec7b8..0038b67c 100644
--- a/README.md
+++ b/README.md
@@ -245,6 +245,23 @@ class MovieSerializer
end
```
+### Meta Per Resource
+
+For every resource in the collection, you can include a meta object containing non-standard meta-information about a resource that can not b... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"lib/fast_jsonapi/version.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/lib/object_serializer_polymorphic_spec.rb",
"spec/lib/object_serializer_spec.rb",... | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 3c477c34..397ace5a 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -87,6 +87,31 @@
end
end
+ describe '#has_many with ... | true | ||
Netflix/fast_jsonapi | 311 | issue_to_patch | Dev | 4afa5b81d83e78afc2c4c261dff9a204c57e7eb5 | fced516356fd4ccb07b1bf17810c71f2bd0cc36e | diff --git a/README.md b/README.md
index a03e1a8c..0038b67c 100644
--- a/README.md
+++ b/README.md
@@ -221,7 +221,7 @@ end
```
### Links Per Object
-Links are defined in FastJsonapi using the `link` method. By default, link are read directly from the model property of the same name.In this example, `public_url` is ... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/lib/object_serializer_polymorphic_spec.rb",
"spec/lib/object_serializer_spec.rb",
"spec/shared/contexts/movie_co... | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 3c477c34..397ace5a 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -87,6 +87,31 @@
end
end
+ describe '#has_many with ... | true | ||
Netflix/fast_jsonapi | 319 | issue_to_patch | transforms type for polymorphic relationships too | 5a70b1a686d6e7c103030be02baf81c27fb01417 | 7f618b6c0b41ce3d3321604071f6322495387d9c | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 183d622c..a5436f48 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -195,7 +195,7 @@ def add_relationship(relationship)
self.relationships_to_serialize = {} if relat... | [
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"spec/lib/object_serializer_polymorphic_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_polymorphic_spec.rb b/spec/lib/object_serializer_polymorphic_spec.rb
new file mode 100644
index 00000000..f889141f
--- /dev/null
+++ b/spec/lib/object_serializer_polymorphic_spec.rb
@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe FastJsonapi::ObjectSerializer do
+ class List... | true | ||
Netflix/fast_jsonapi | 271 | issue_to_patch | Allow the serializer to return sparse fieldsets | I also need sparse fieldset support from Fast JSON API. After reading through and seeing that there's no recent activity on #57, #63, and #254, I'd like to take a stab at this.
A client should be able to request only a subset of attributes and relationships using the `fields` option. Here's an example using the movi... | dc2b78bbe4c6161be021899b529a5675223ebd27 | e28ecdbe3674103da2496ee121fa80c4f6b22ba7 | diff --git a/README.md b/README.md
index f4333d19..a7cb3055 100644
--- a/README.md
+++ b/README.md
@@ -32,6 +32,7 @@ Fast JSON API serialized 250 records in 3.01 ms
* [Params](#params)
* [Conditional Attributes](#conditional-attributes)
* [Conditional Relationships](#conditional-relationships)
+ * [Sparse Fie... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_fields_spec.rb",
"spec/lib/object_serializer_inheritance_spec.rb",
"spec/lib/serialization_core_spec.rb"
] | [
{
"comment": " could we run define and run deep_symbolize method here? I think it makes sense for it to be transparent to the rest of the code.",
"path": "lib/fast_jsonapi/fieldset.rb",
"hunk": "@@ -0,0 +1,7 @@\n+module FastJsonapi\n+ class Fieldset\n+ def initialize(fields)\n+ @fields = fields... | diff --git a/spec/lib/object_serializer_fields_spec.rb b/spec/lib/object_serializer_fields_spec.rb
new file mode 100644
index 00000000..913ba83b
--- /dev/null
+++ b/spec/lib/object_serializer_fields_spec.rb
@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe FastJsonapi::ObjectSerializer do
+ include_context 'movie cl... | true | |
Netflix/fast_jsonapi | 273 | issue_to_patch | Release 1.3 | - Conditional attributes
- Conditional relationships
- Sparse fieldsets support ⭐
- Better Control Over Collection Serialization | 81375cfcf751a76bcd7da4927a58375b03772144 | 115a01a7c22564625c9fbbbc181715a7239f1eb4 | diff --git a/README.md b/README.md
index 2cbaa51b..a03e1a8c 100644
--- a/README.md
+++ b/README.md
@@ -30,6 +30,9 @@ Fast JSON API serialized 250 records in 3.01 ms
* [Collection Serialization](#collection-serialization)
* [Caching](#caching)
* [Params](#params)
+ * [Conditional Attributes](#conditional-attri... | [
"README.md",
"lib/extensions/has_one.rb",
"lib/fast_jsonapi.rb",
"lib/fast_jsonapi/attribute.rb",
"lib/fast_jsonapi/link.rb",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/railtie.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"lib/fast_jsonapi/vers... | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 55e351af..3c477c34 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -230,6 +230,23 @@
expect(serializable_hash[:data][:at... | true | |
Netflix/fast_jsonapi | 272 | issue_to_patch | Dev | 49193ab8f3d27de0a785b9c1f2cc7ac2559eefd8 | 3df48cd4cb7bdaf127b3eb8eee7a2b25d93d75ad | diff --git a/README.md b/README.md
index f4333d19..a03e1a8c 100644
--- a/README.md
+++ b/README.md
@@ -32,6 +32,7 @@ Fast JSON API serialized 250 records in 3.01 ms
* [Params](#params)
* [Conditional Attributes](#conditional-attributes)
* [Conditional Relationships](#conditional-relationships)
+ * [Sparse Fie... | [
"README.md",
"lib/fast_jsonapi/attribute.rb",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/lib/object_serializer_fields_spec.rb",
"spec/lib/object_serializer_inheritance_spec.rb",
"spec/lib/serialization_co... | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 85346f09..3c477c34 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -230,6 +230,23 @@
expect(serializable_hash[:data][:at... | true | ||
Netflix/fast_jsonapi | 269 | issue_to_patch | Allow passing procs with variable arguments when declaring an attribute | Allows procs with variable arguments to be used in an attribute declaration, which will also allow the usage of `&:proc`. Instead of having to write something like:
```
class MovieSerializer
attribute :released_in_year do |object|
object.release_year
end
end
```
We can instead write:
```
class M... | dc2b78bbe4c6161be021899b529a5675223ebd27 | aa528e0f05d6d4de69deadbca6436dea09ba367a | diff --git a/README.md b/README.md
index f4333d19..c812eac9 100644
--- a/README.md
+++ b/README.md
@@ -207,6 +207,18 @@ class MovieSerializer
end
```
+Attributes can also use a different name by passing the original method or accessor with a proc shortcut:
+
+```ruby
+class MovieSerializer
+ include FastJsonapi::O... | [
"README.md",
"lib/fast_jsonapi/attribute.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 85346f09..3c477c34 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -230,6 +230,23 @@
expect(serializable_hash[:data][:at... | true | |
Netflix/fast_jsonapi | 267 | issue_to_patch | Remove duplicated MovieSerializer in README | There was just a typo in an example. | dc2b78bbe4c6161be021899b529a5675223ebd27 | d43ddd5cea53f37f01c6047a134f13a2bbab5ebb | diff --git a/README.md b/README.md
index 2cbaa51b..4e7eaa47 100644
--- a/README.md
+++ b/README.md
@@ -284,7 +284,6 @@ block you opt-in to using params by adding it as a block parameter.
```ruby
class MovieSerializer
- class MovieSerializer
include FastJsonapi::ObjectSerializer
attributes :name, :year
| [
"README.md"
] | [] | true | ||
Netflix/fast_jsonapi | 152 | issue_to_patch | Serialize nested includes | - Dish off to associated serializers when required
includes syntax is:
```
options[:include] = [:actors, :'actors.agency']
serializable_hash = MovieSerializer.new([movie], options).serializable_hash
``` | 966b3509a4999ec4a1905f999c81d99df8fe5d16 | 716c9778ee089edce5a8b5fd30c65a9c1fe9a766 | diff --git a/README.md b/README.md
index 4635549b..3e6a71aa 100644
--- a/README.md
+++ b/README.md
@@ -207,7 +207,7 @@ end
### Compound Document
-Support for top-level included member through ` options[:include] `.
+Support for top-level and nested included associations through ` options[:include] `.
```ruby
o... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_inheritance_spec.rb",
"spec/lib/object_serializer_spec.rb",
"spec/lib/object_serializer_struct_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [
{
"comment": "I think the `<<` operator should be replaced by `.concat`. Since `serializer_records` is an array, this creates a nested array when you really want to append the contents of `serializer_records` to the `included_records` array.\r\n\r\nI tested the change and was seeing the nested included record... | diff --git a/spec/lib/object_serializer_inheritance_spec.rb b/spec/lib/object_serializer_inheritance_spec.rb
index ee0c559d..b8ba19e4 100644
--- a/spec/lib/object_serializer_inheritance_spec.rb
+++ b/spec/lib/object_serializer_inheritance_spec.rb
@@ -10,6 +10,9 @@
CountrySerializer
Employee
Employe... | true | |
Netflix/fast_jsonapi | 260 | issue_to_patch | Conditional relationships | Just like conditional attributes, conditional relationships can be defined by passing a Proc to the `if` key.
```
class MovieSerializer
include FastJsonapi::ObjectSerializer
# Actors will only be serialized if the record has any associated actors
has_many :actors, if: Proc.new { |record| record.actors.an... | 2b01d8ce708afd377905975e0438b45bffe126c4 | 3987d1881bc4538f8a724e70564c04bb39fd6b74 | diff --git a/README.md b/README.md
index 85926e87..af57e7a9 100644
--- a/README.md
+++ b/README.md
@@ -30,6 +30,8 @@ Fast JSON API serialized 250 records in 3.01 ms
* [Collection Serialization](#collection-serialization)
* [Caching](#caching)
* [Params](#params)
+ * [Conditional Attributes](#conditional-attri... | [
"README.md",
"lib/fast_jsonapi/link.rb",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_spec.rb",
"spec/lib/serialization_core_spec.rb",
"spec/shared/contexts/movie_context.rb",
"spec/shared/examples/... | [
{
"comment": "In a separate set of local changes that I'm working on, I'm trying to abstract the relationship hash out into its own class, much like we did in #256, but I'm having a hard time figuring out how to extract some of the methods. For instance, `id_hash` would be used inside the `Relationship` class d... | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 46d0cea6..ed770afb 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -341,4 +341,64 @@ class BlahSerializer
expect(serializable_hash['data']['attributes'].has_key?('director')).to ... | true | |
Netflix/fast_jsonapi | 265 | issue_to_patch | Dev | Conditional attributes, Conditional relationships and Control Over Collection Serialization | 75229fdfbf220b8daadcae729427b273c83edd7f | dc2b78bbe4c6161be021899b529a5675223ebd27 | diff --git a/README.md b/README.md
index 4e7eaa47..f4333d19 100644
--- a/README.md
+++ b/README.md
@@ -30,6 +30,8 @@ Fast JSON API serialized 250 records in 3.01 ms
* [Collection Serialization](#collection-serialization)
* [Caching](#caching)
* [Params](#params)
+ * [Conditional Attributes](#conditional-attri... | [
"README.md",
"lib/extensions/has_one.rb",
"lib/fast_jsonapi.rb",
"lib/fast_jsonapi/attribute.rb",
"lib/fast_jsonapi/link.rb",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/railtie.rb",
"lib/fast_jsonapi/relationship.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_seria... | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 55e351af..85346f09 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -312,7 +312,6 @@
movie_type_serializer_class.instance... | true | |
Netflix/fast_jsonapi | 239 | issue_to_patch | add is_collection parameter to force corresponding serialization | This PR addresses #229 and generalize `is_collection` handling for different DB toolkits
Also, supports and includes improvement similar to https://github.com/Netflix/fast_jsonapi/pull/234
for autodetection | 2b01d8ce708afd377905975e0438b45bffe126c4 | 7f9940fe9148f0c3b031fe10284132074e3f762a | diff --git a/README.md b/README.md
index 85926e87..ac8be1ea 100644
--- a/README.md
+++ b/README.md
@@ -259,6 +259,26 @@ hash = MovieSerializer.new([movie, movie], options).serializable_hash
json_string = MovieSerializer.new([movie, movie], options).serialized_json
```
+#### Control Over Collection Serialization
+
+... | [
"README.md",
"lib/fast_jsonapi/object_serializer.rb",
"spec/lib/object_serializer_spec.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 46d0cea6..d181a837 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -310,6 +310,52 @@ class BlahSerializer
end
end
+ context 'when is_collection option present' do
+ subjec... | true | |
Netflix/fast_jsonapi | 256 | issue_to_patch | Conditional attributes | _This is mostly code from #66 by @andyjeffries, but the changes were cherry picked and put on top of the current dev branch to fix some tests that were failing._
```ruby
class MovieSerializer
include FastJsonapi::ObjectSerializer
attributes :name, :year
attribute :release_year, if: Proc.new do |record|
... | 44d5e0f9c5bd54a5fbfd265b805c55e65d95af11 | d527dd86cdad79f6d86f1a012e59072f4828979a | diff --git a/README.md b/README.md
index 4e7eaa47..85926e87 100644
--- a/README.md
+++ b/README.md
@@ -307,6 +307,32 @@ serializer.serializable_hash
Custom attributes and relationships that only receive the resource are still possible by defining
the block to only receive one argument.
+### Conditional Attributes
+... | [
"README.md",
"lib/fast_jsonapi/attribute.rb",
"lib/fast_jsonapi/object_serializer.rb",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_inheritance_spec.rb",
"spec/lib/object_serializer_spec.rb",
"spec/lib/serialization_core_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [
{
"comment": "Is there any chance that the instantiation of `Attribute` could slow things down? Obviously, the performance tests are passing, but what if there's tons of attributes? I'm ignorant to whether the instantiation/GC issues in AMS (issues that this library aims to solve) are related to actual class in... | diff --git a/spec/lib/object_serializer_inheritance_spec.rb b/spec/lib/object_serializer_inheritance_spec.rb
index 06dba256..8cf5b53d 100644
--- a/spec/lib/object_serializer_inheritance_spec.rb
+++ b/spec/lib/object_serializer_inheritance_spec.rb
@@ -113,7 +113,7 @@ class EmployeeSerializer < UserSerializer
end
... | true | |
Netflix/fast_jsonapi | 249 | issue_to_patch | Set type value when setting key transform | This simply adds a call to the `set_type` method from `set_key_transform`, which will ensure that the `record_type` is transformed as is expected.
This fixes #248
| 44d5e0f9c5bd54a5fbfd265b805c55e65d95af11 | 124fe5eb238f7df44390d441cd31a30d741ef938 | diff --git a/lib/fast_jsonapi/object_serializer.rb b/lib/fast_jsonapi/object_serializer.rb
index 4dea074f..c811ef6f 100644
--- a/lib/fast_jsonapi/object_serializer.rb
+++ b/lib/fast_jsonapi/object_serializer.rb
@@ -118,6 +118,9 @@ def set_key_transform(transform_name)
underscore: :underscore
}
... | [
"lib/fast_jsonapi/object_serializer.rb",
"spec/lib/object_serializer_class_methods_spec.rb",
"spec/shared/examples/object_serializer_class_methods_examples.rb"
] | [] | diff --git a/spec/lib/object_serializer_class_methods_spec.rb b/spec/lib/object_serializer_class_methods_spec.rb
index 55e351af..85346f09 100644
--- a/spec/lib/object_serializer_class_methods_spec.rb
+++ b/spec/lib/object_serializer_class_methods_spec.rb
@@ -312,7 +312,6 @@
movie_type_serializer_class.instance... | true | |
Netflix/fast_jsonapi | 232 | issue_to_patch | Dev | 81375cfcf751a76bcd7da4927a58375b03772144 | 44d5e0f9c5bd54a5fbfd265b805c55e65d95af11 | diff --git a/README.md b/README.md
index 2cbaa51b..4e7eaa47 100644
--- a/README.md
+++ b/README.md
@@ -284,7 +284,6 @@ block you opt-in to using params by adding it as a block parameter.
```ruby
class MovieSerializer
- class MovieSerializer
include FastJsonapi::ObjectSerializer
attributes :name, :year
diff... | [
"README.md",
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 2d8c99ea..7941f660 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -97,6 +97,13 @@
expect(serializable_hash['data']['relationships']['owner']['data']).to be nil
end
+ i... | true | ||
Netflix/fast_jsonapi | 230 | issue_to_patch | Fix serialization for nested nil includes with block | Optional belongs_to association throws `NoMethodError: undefined method 'id' for nil:NilClass`
```
class Foo < ApplicationRecord
belongs_to :bar, optional: true
end
```
```
class FooSerializer
include FastJsonapi::ObjectSerializer
belongs_to :bar do |object, params|
params[:authorized] ? object... | 39fdc6f66c73bdfdb93316c7d0b520a436cca597 | d6b6b37486f8fd0dfbf83a95abf3dd933bfb2383 | diff --git a/lib/fast_jsonapi/serialization_core.rb b/lib/fast_jsonapi/serialization_core.rb
index de138cd7..668aebee 100644
--- a/lib/fast_jsonapi/serialization_core.rb
+++ b/lib/fast_jsonapi/serialization_core.rb
@@ -182,7 +182,7 @@ def fetch_id(record, relationship, params)
object = relationship[:object_b... | [
"lib/fast_jsonapi/serialization_core.rb",
"spec/lib/object_serializer_spec.rb",
"spec/shared/contexts/movie_context.rb"
] | [] | diff --git a/spec/lib/object_serializer_spec.rb b/spec/lib/object_serializer_spec.rb
index 2d8c99ea..7941f660 100644
--- a/spec/lib/object_serializer_spec.rb
+++ b/spec/lib/object_serializer_spec.rb
@@ -97,6 +97,13 @@
expect(serializable_hash['data']['relationships']['owner']['data']).to be nil
end
+ i... | true | |
Netflix/zuul | 2,145 | issue_to_patch | Ensure `SslExceptionsHandler` swallows all client SSL exceptions, not just handshake failures | `SslExceptionsHandler` only swallows TLS handshake failures, and only when wrapped exactly one level deep (`cause.getCause() instanceof SSLHandshakeException`). Other client-induced TLS decode errors - `BAD_DECRYPT`, `WRONG_VERSION_NUMBER` and friends, typically a client speaking plaintext to the TLS port or sending a ... | 3eb01598ba31f04673d44c01e0ec9289a799446d | 701bb66130cfc29758d5dad10f813490255c17ac | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/SslExceptionsHandler.java b/zuul-core/src/main/java/com/netflix/netty/common/SslExceptionsHandler.java
index 9471ae01c7..be3fefba37 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/SslExceptionsHandler.java
+++ b/zuul-core/src/main/java/com/netf... | [
"zuul-core/src/main/java/com/netflix/netty/common/SslExceptionsHandler.java",
"zuul-core/src/test/java/com/netflix/netty/common/SslExceptionsHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/SslExceptionsHandlerTest.java b/zuul-core/src/test/java/com/netflix/netty/common/SslExceptionsHandlerTest.java
new file mode 100644
index 0000000000..acf6a25774
--- /dev/null
+++ b/zuul-core/src/test/java/com/netflix/netty/common/SslExceptionsHandlerTest.jav... | true | |
Netflix/zuul | 2,137 | issue_to_patch | Fix for connection leak issue with HTTP 1xx responses | We were returning the origin connection to the pool after getting a 1xx HTTP response, which was incorrect – those are responses that indicate a further response was coming. In some cases, the origin's eventual (real) response could actually go to the wrong client in these cases.
This also fixes an issue where the c... | 9e86f8a0dd6333baff3e971390598bf0b98988e2 | d0882c35c4ae79f2cc1fb163c0d26ae7a11ec06f | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java b/zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java
index ff33b6c03b..49bb65e49a 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java... | [
"zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java",
"zuul-core/src/main/java/com/netflix/netty/common/HttpServerLifecycleChannelHandler.java",
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/... | [
{
"comment": "nit: can tighten this comment more around the first line - other pieces are related to the underlying fix rather than why this code exists for the future. Something more along the lines of:\n\n```\n /**\n * Swallows 1xx interim responses (100 Continue, 102 Processing, 103 Early Hints) rathe... | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/HttpClientLifecycleChannelHandlerTest.java b/zuul-core/src/test/java/com/netflix/netty/common/HttpClientLifecycleChannelHandlerTest.java
index 963b257fcd..d5c7815eca 100644
--- a/zuul-core/src/test/java/com/netflix/netty/common/HttpClientLifecycleChannelHand... | true | |
Netflix/zuul | 2,137 | comment_to_fix | Fix for connection leak issue with HTTP 1xx responses | nit: can tighten this comment more around the first line - other pieces are related to the underlying fix rather than why this code exists for the future. Something more along the lines of:
```
/**
* Swallows 1xx interim responses (100 Continue, 102 Processing, 103 Early Hints) rather than relaying
* the... | 9e86f8a0dd6333baff3e971390598bf0b98988e2 | d0882c35c4ae79f2cc1fb163c0d26ae7a11ec06f | diff --git a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
index 2ae3c69f74..f0fb6c80fb 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
+++ b/zuul-core/src/main/java/co... | [
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java"
] | [
{
"comment": "nit: can tighten this comment more around the first line - other pieces are related to the underlying fix rather than why this code exists for the future. Something more along the lines of:\n\n```\n /**\n * Swallows 1xx interim responses (100 Continue, 102 Processing, 103 Early Hints) rathe... | true | ||
Netflix/zuul | 2,143 | issue_to_patch | Add `getServers` to `Resolver` and `ClientChannelManager` to expose the origin pool | `Resolver` and `ClientChannelManager` only expose `resolve`, which load-balances and hands back a single server - there's no way to read the full set of origins they currently know about without picking one. That's fine for routing, but not for callers that want to inspect per-server discovery metadata across the whole... | 9e86f8a0dd6333baff3e971390598bf0b98988e2 | 27a46241e50de1a303cf314b038adba174490268 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ClientChannelManager.java b/zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ClientChannelManager.java
index b109776d16..c50674baed 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ClientChannelManager.java... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ClientChannelManager.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/DefaultClientChannelManager.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/DefaultClientChannelManagerTest.java",
"zuul-discovery/src... | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/DefaultClientChannelManagerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/DefaultClientChannelManagerTest.java
index 63468a6374..8a26b02cda 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/Def... | true | |
Netflix/zuul | 2,139 | issue_to_patch | Fix reentrant double responses on origin errors | When an origin read times out while a response is still buffered inside a body-buffering response filter, `ClientResponseWriter.exceptionCaught` writes an error response and flushes it. That flush can complete synchronously and fire a `CompleteEvent`, which causes `ZuulFilterChainHandler.finishResponseFilters` to re-d... | 0715b0ce23325d526b9b11944c28859cf8352a4b | 09a1360546226300df3b7ca728429053bac04d43 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientResponseWriter.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientResponseWriter.java
index 85a8606df6..a6acda6336 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientResponseWriter.java
+++ b/zuul-core/src/mai... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientResponseWriter.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientResponseWriterTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientResponseWriterTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientResponseWriterTest.java
index 897e971fa2..9b9f525bd4 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientResponseWriterTest.java
+++ b/zuul-... | true | |
Netflix/zuul | 2,142 | issue_to_patch | update netty to v4.2.15 | v4.2.14 has a number of bugfixes: https://netty.io/news/2026/05/20/4-2-14-Final.html
v4.2.15 has a whole lot of security fixes: https://netty.io/news/2026/06/01/4-2-15-Final.html
This also brought along a minor version update to spectator-api (1.9.6 -> 1.9.8). | 0715b0ce23325d526b9b11944c28859cf8352a4b | 8d3b79a740dd700ae219926b3e58d9eca4460bcd | diff --git a/gradle.properties b/gradle.properties
index 09cd2468cb..fa6b59e75c 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,5 +1,5 @@
versions_ribbon=2.4.4
-versions_netty=4.2.13.Final
+versions_netty=4.2.15.Final
versions_brotli4j=1.16.0
release.scope=patch
release.version=3.3.0-SNAPSHOT
diff --gi... | [
"gradle.properties",
"zuul-core/dependencies.lock",
"zuul-integration-test/dependencies.lock",
"zuul-processor/dependencies.lock",
"zuul-sample/dependencies.lock"
] | [] | true | ||
Netflix/zuul | 2,138 | issue_to_patch | Enabling header validation via fast property | Enabling header validation, configurable by FP | 05d52953a66a922ab573e35093e8457488949f60 | b9422e1b005440304ec91bfbcd24742837ee1613 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java
index 2c1121aedf..9cb788a13a 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java
+++ b... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1DecoderFailureRejectingHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTest.java",
"zuul-core/src/test/java/com/n... | [
{
"comment": "Is there another handler we can use here? The `Http1FramingEnforcingHandler` itself is conditional and feels like this decoder check/failure should live outside the framing checks",
"path": "zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandler.java",
"hunk": "... | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTest.java
index 233fae477d..1c3647e175 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTes... | true | |
Netflix/zuul | 2,127 | issue_to_patch | Return bad request for invalid URI | - Decode %2E before normalization: per RFC 3986 §2.4, percent-encoded unreserved characters (like .) should be decoded before processing, so dot-segments like %2E%2E are properly collapsed by normalize()
- Propagate URISyntaxException from parsePath: instead of silently swallowing parse errors and falling back to ... | 515d5b339d8c09ee3f969adda3cb7a19fbf8dc6e | 6fa096c494e19454002034b4dd208c8e0e500e22 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java b/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
index d544e248b9..3dcc5a408a 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/... | [
"zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java"
] | [
{
"comment": "can you switch this to the type safe variety (SessionContext.Key)",
"path": "zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java",
"hunk": "@@ -95,10 +94,7 @@ public class ClientRequestReceiver extends ChannelDuplexHandler {\n private static final Logger LO... | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
index 77f42167f6..4660f4fff7 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
+++ b/zu... | true | |
Netflix/zuul | 2,136 | issue_to_patch | Path normalization | Follow up to https://github.com/Netflix/zuul/pull/2127 | 078bda34fccda1434a6cc04d1241f88c1daff2a4 | 59e7b83b331c0aee32bdd7054dfc8b157e6b7709 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java b/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
index d544e248b9..3dcc5a408a 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/... | [
"zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
index 77f42167f6..a89b111b02 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
+++ b/zu... | true | |
Netflix/zuul | 2,135 | issue_to_patch | Update readme to reflect better release process | 174a26032474c84595de7e5e36758cc8a4fefd95 | 11ff76df3899847985d45eb495b4afddf74f2bf9 | diff --git a/README.md b/README.md
index 29ca994a0e..470352ff4f 100644
--- a/README.md
+++ b/README.md
@@ -80,11 +80,10 @@ http://instea.sk/2015/04/netflix-zuul-vs-nginx-performance/
# How to release Zuul
This project uses a GitHub Action workflow for publishing a new release.
-The workflow is triggered by a Git ta... | [
"README.md"
] | [] | true | |||
Netflix/zuul | 2,131 | issue_to_patch | Preserve failure nf status set by recordFinalError in buildZuulHttpResponse | When origin.recordFinalError() sets a specific failure StatusCategory (e.g. from an origin subclass override), the subsequent unconditional setStatusCategory call was overwriting it with the generic status derived from the response code.
This PR switches to use storeStatusCategoryIfNotAlreadyFailure so that a failu... | 515d5b339d8c09ee3f969adda3cb7a19fbf8dc6e | 687c75b1715cf85a1398e5446735fe577881220f | diff --git a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
index 0391437546..81416cb7cb 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
+++ b/zuul-core/src/main/java/co... | [
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java"
] | [
{
"comment": "I wonder if this handles retries correctly? Since I think this block is called twice for a retry scenario, first time through sets it to error X, second time through the error might be Y now?",
"path": "zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java",
"hunk": ... | true | ||
Netflix/zuul | 2,134 | issue_to_patch | Revert "Return bad request for invalid URI" | Reverts Netflix/zuul#2127 | 05e8df6f4820bba2dd254a31dabdeb07b1cc3191 | 98d508ba74d69cffc5f9fb1a3d56596fb3f06745 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java b/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
index 3dcc5a408a..d544e248b9 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/... | [
"zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
index 4660f4fff7..77f42167f6 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
+++ b/zu... | true | |
Netflix/zuul | 2,115 | issue_to_patch | Remove decoded path in HttpRequestMessageImpl | Remove the usage of decoded path in Zuul | c1d9cef2012fae1b12779b5e7a8285b278d28321 | 4b75039ac4d84eec8f6d4b3ac4557b14cfbe04e9 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java b/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
index bd4aa94bd9..d544e248b9 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/... | [
"zuul-core/src/main/java/com/netflix/zuul/context/CommonContextKeys.java",
"zuul-core/src/main/java/com/netflix/zuul/message/http/HttpRequestMessageImpl.java",
"zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java b/zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java
index c35a1a05fd..54b0106ba9 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java
+++ b... | true | |
Netflix/zuul | 2,043 | issue_to_patch | Update netty to 4.2.9.Final | 1. Update netty to 4.2.9.Final: https://netty.io/news/2025/12/15/4-2-9.html
2. Fix deprecated WebSocketServerCompressionHandler(): https://netty.io/4.1/api/io/netty/handler/codec/http/websocketx/extensions/compression/WebSocketServerCompressionHandler.html#WebSocketServerCompressionHandler-- | b2d206e83e134addaa2712ba6a7561b2a72a45dd | 22f1d3bea84dd214fabcb2efc7995c8b25786cd6 | diff --git a/gradle.properties b/gradle.properties
index 1ce9858695..64ae835047 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,5 +1,5 @@
versions_ribbon=2.4.4
-versions_netty=4.2.6.Final
+versions_netty=4.2.9.Final
versions_brotli4j=1.16.0
release.scope=patch
release.version=3.1.0-SNAPSHOT
diff --git ... | [
"gradle.properties",
"zuul-core/dependencies.lock",
"zuul-discovery/dependencies.lock",
"zuul-integration-test/dependencies.lock",
"zuul-processor/dependencies.lock",
"zuul-sample/dependencies.lock",
"zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSocketPushChannelInitializer.java"
] | [
{
"comment": "nit: since you're cleaning this up, could you switch to a non-zero number (perhaps 1 MB or something). The idea being it would encourage better behavior for anyone looking at the code (0 is unbounded)",
"path": "zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSocketPushChannelI... | true | ||
Netflix/zuul | 2,043 | comment_to_fix | Update netty to 4.2.9.Final | nit: since you're cleaning this up, could you switch to a non-zero number (perhaps 1 MB or something). The idea being it would encourage better behavior for anyone looking at the code (0 is unbounded) | b2d206e83e134addaa2712ba6a7561b2a72a45dd | 22f1d3bea84dd214fabcb2efc7995c8b25786cd6 | diff --git a/zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSocketPushChannelInitializer.java b/zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSocketPushChannelInitializer.java
index 0b7b8edea1..175a8466f6 100644
--- a/zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSoc... | [
"zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSocketPushChannelInitializer.java"
] | [
{
"comment": "nit: since you're cleaning this up, could you switch to a non-zero number (perhaps 1 MB or something). The idea being it would encourage better behavior for anyone looking at the code (0 is unbounded)",
"path": "zuul-sample/src/main/java/com/netflix/zuul/sample/push/SampleWebSocketPushChannelI... | true | ||
Netflix/zuul | 2,044 | issue_to_patch | Bump release.version to 3.3.1-SNAPSHOT | 94a2af30eace9bfbb58c5fe13b74c6bfbab8e441 | 51012bcc4411c071a2244c079848386532ce6516 | diff --git a/gradle.properties b/gradle.properties
index 64ae835047..da7ccb5d0b 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -2,7 +2,7 @@ versions_ribbon=2.4.4
versions_netty=4.2.9.Final
versions_brotli4j=1.16.0
release.scope=patch
-release.version=3.1.0-SNAPSHOT
+release.version=3.3.1-SNAPSHOT
org.gra... | [
"gradle.properties"
] | [] | true | |||
Netflix/zuul | 2,100 | issue_to_patch | Enable TCP_NODELAY as default | https://brooker.co.za/blog/2024/05/09/nagle.html | 3fdaacfc7328abe4ea84605c742ed6765c0aa79e | 39278f23d6f030d821b9ee7962762b479a4c8811 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolConfigImpl.java b/zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolConfigImpl.java
index 3d417d2559..12373202f7 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolCon... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolConfigImpl.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolConfigImplTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolConfigImplTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolConfigImplTest.java
index 22de4008a9..b360080fbf 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/connectionpool/Connectio... | true | |
Netflix/zuul | 2,130 | issue_to_patch | Update netty to 4.2.13.Final | https://netty.io/news/2026/05/04/4-2-13-Final.html | 2eb6aac01883b9fdbce8c0f9dff1b3d1c4b2ee97 | 8c3f931dca1494ee9080f67ab985101944f53cbd | diff --git a/gradle.properties b/gradle.properties
index d533e2a6f4..09cd2468cb 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,5 +1,5 @@
versions_ribbon=2.4.4
-versions_netty=4.2.12.Final
+versions_netty=4.2.13.Final
versions_brotli4j=1.16.0
release.scope=patch
release.version=3.3.0-SNAPSHOT
diff --gi... | [
"gradle.properties",
"zuul-core/dependencies.lock",
"zuul-integration-test/dependencies.lock",
"zuul-processor/dependencies.lock",
"zuul-sample/dependencies.lock"
] | [] | true | ||
Netflix/zuul | 2,129 | issue_to_patch | Correctly handle http conn state when origin responds before `LastHttpContent` is sent | This PR ensures we close the origin connection (rather than returning it to the pool) when an HTTP/1.1 origin sends a response before zuul finishes streaming the request body to it.
If an origin responds before zuul finishes sending the request body without signally to close the connection, the outbound `HttpClientC... | 3b98e3a9a251a223586abc1f4627284c5f7a2c04 | bae443987bb099dec126ae60908990245b3d89df | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java b/zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java
index bd5971cc41..ff33b6c03b 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java... | [
"zuul-core/src/main/java/com/netflix/netty/common/HttpClientLifecycleChannelHandler.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolHandler.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/connectionpool/ConnectionPoolMetrics.java",
"zuul-core/src/test/java/com/netfli... | [
{
"comment": "👍 ",
"path": "zuul-integration-test/src/test/java/com/netflix/zuul/integration/EarlyOriginResponseConnectionReuseTest.java",
"hunk": "@@ -0,0 +1,223 @@\n+/*\n+ * Copyright 2026 Netflix, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may... | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/HttpClientLifecycleChannelHandlerTest.java b/zuul-core/src/test/java/com/netflix/netty/common/HttpClientLifecycleChannelHandlerTest.java
new file mode 100644
index 0000000000..963b257fcd
--- /dev/null
+++ b/zuul-core/src/test/java/com/netflix/netty/common/Ht... | true | |
Netflix/zuul | 2,125 | issue_to_patch | Ensure Transfer-Encoding is not allowed on HTTP/1.0 requests | `Transfer-Encoding` was added in HTTP1.1, as per [RFC 9112 section 6.1](https://www.rfc-editor.org/rfc/rfc9112.html#name-transfer-encoding), so we should treat it as an invalid request on HTTP/1.0 requests. | f5d4f212d7c06f4173223bd3631ae3ff1761d340 | 059546e08281fbb3778d0df9a36c54f21d337be1 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandler.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandler.java
index 9217f78274..9a67548ab0 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandler.java... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandlerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandlerTest.java
index 02ff154387..ba3182fbf9 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHand... | true | |
Netflix/zuul | 2,124 | issue_to_patch | Add HTTP/1.1 request framing enforcer | This adds a `Http1FramingEnforcingHandler`, immediately after `HttpServerCodec` in the HTTP/1.1 pipeline, which rejects requests with ambiguous message framing per [RFC 9112 section 6.3](https://www.rfc-editor.org/rfc/rfc9112.html#name-message-body-length):
- `Transfer-Encoding` and `Content-Length` both present
- `C... | 2708d36e892c2d071834f02932b5ff73bb3c8f89 | e8e0c8a5da451aa2045f97d2ba279ddd319cc5c9 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java
index ebe40e506f..2c1121aedf 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java
+++ b... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/Http1FramingEnforcingHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTest.java",
"zuul-core/src/test/java/com/netflix/... | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTest.java
index 4a51cf8e9d..233fae477d 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializerTes... | true | |
Netflix/zuul | 2,126 | issue_to_patch | Remove unused methods from ProxyUtils | Remove some unused `isValidRequestHeader` and `isValidResponseHeader` methods | 2708d36e892c2d071834f02932b5ff73bb3c8f89 | 8001d86bc8fd46c93ddd540bb39c80691ddc3de5 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/util/ProxyUtils.java b/zuul-core/src/main/java/com/netflix/zuul/util/ProxyUtils.java
index 4e7b422984..0b33e06d75 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/util/ProxyUtils.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/util/ProxyUtils.java
@@ -21,8 ... | [
"zuul-core/src/main/java/com/netflix/zuul/util/ProxyUtils.java"
] | [] | true | ||
Netflix/zuul | 2,114 | issue_to_patch | Configure Continuation default to netty default | 0cf10cfa8ae05ddf8be83d1a8393d35e46a88fdd | 1a608acb89665e2e8913e92d9e8640cc414d91d3 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java b/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java
index 6c6c3069b4..97e089375e 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannel... | [
"zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java"
] | [] | true | |||
Netflix/zuul | 2,112 | issue_to_patch | maxConsecutiveContinuationFrames configuration | Exposes the configurable value added in https://github.com/netty/netty/pull/16536 | 13f502ab2052940ae83004c59d0fbbd22ce23f8a | e802544daa7bc983f0de90db4b4207e401136780 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java b/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java
index 97fbd65705..6c6c3069b4 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannel... | [
"zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/http2/Http2OrHttpHandler.java"
] | [] | true | ||
Netflix/zuul | 2,109 | issue_to_patch | Upgrade bouncycastle to v1.83 | Upgrade bouncycastle to latest & added additional tests for PSK handling to ensure BC upgrade works as expected. | 49cae6759982c2c99bae58a687860f22fc8eae46 | fea1646adb3e38ba72bda2929322c44feaca18c9 | diff --git a/zuul-core/build.gradle b/zuul-core/build.gradle
index 7eb871fc73..a7c330c8b1 100644
--- a/zuul-core/build.gradle
+++ b/zuul-core/build.gradle
@@ -11,9 +11,9 @@ dependencies {
// TODO(carl-mastrangelo): this can be implementation; remove Logger from public api points.
api libraries.slf4j
- im... | [
"zuul-core/build.gradle",
"zuul-core/dependencies.lock",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/psk/TlsPskHandlerTest.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/psk/ZuulPskServerTest.java",
"zuul-integration-test/dependencies.lock",
"zuul-processor/dependencies.lock",
... | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/psk/TlsPskHandlerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/psk/TlsPskHandlerTest.java
new file mode 100644
index 0000000000..06191f12e3
--- /dev/null
+++ b/zuul-core/src/test/java/com/netflix/zuul/netty/server/psk/TlsPskHandlerTe... | true | |
Netflix/zuul | 2,110 | issue_to_patch | RejectionUtils Switch Block fix | Recent static analysis fixes removed the return of cases in a RejectionUtils switch block:
https://github.com/Netflix/zuul/pull/2108/changes#diff-568881acedb588ae0be0a51a8a48f56eeb360b28c80532260270e720d396c682
Requests would fall through and throw an assertion error. This restores the prior behavior | 49cae6759982c2c99bae58a687860f22fc8eae46 | ac4509cb2e8a3dd0a47e2ee939dea1fd2646a94e | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/throttle/RejectionUtils.java b/zuul-core/src/main/java/com/netflix/netty/common/throttle/RejectionUtils.java
index 77fb72e98a..2a9f599e6c 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/throttle/RejectionUtils.java
+++ b/zuul-core/src/main/java... | [
"zuul-core/src/main/java/com/netflix/netty/common/throttle/RejectionUtils.java"
] | [] | true | ||
Netflix/zuul | 2,108 | issue_to_patch | Static Analysis Fixes | The followup to https://github.com/Netflix/zuul/pull/2107
This removes the previously-added error prone flags and addresses the build errors | 977a11ce4af256a070f9eb657f90f44f83791692 | 4ffa9b55af21f9e5990a40bd157c9cf6c989af31 | diff --git a/build.gradle b/build.gradle
index 5e5288154d..fdec229ca9 100644
--- a/build.gradle
+++ b/build.gradle
@@ -97,13 +97,8 @@ subprojects {
"-Xep:FutureReturnValueIgnored:OFF",
"-Xep:InlineMeSuggester:OFF",
"-Xep:MissingSummary:OFF",
- "-Xep:Bool... | [
"build.gradle",
"zuul-core/src/main/java/com/netflix/netty/common/ByteBufUtil.java",
"zuul-core/src/main/java/com/netflix/netty/common/Http1ConnectionCloseHandler.java",
"zuul-core/src/main/java/com/netflix/netty/common/Http2ConnectionCloseHandler.java",
"zuul-core/src/main/java/com/netflix/netty/common/Htt... | [
{
"comment": "this is a behavior change - can you revert to the old behavior and suppress the warning if needed?",
"path": "zuul-core/src/main/java/com/netflix/zuul/passport/CurrentPassport.java",
"hunk": "@@ -84,8 +84,8 @@ protected Thread getOwner() {\n }\n \n private Unlocker lock() {\n- ... | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/HttpServerLifecycleChannelHandlerTest.java b/zuul-core/src/test/java/com/netflix/netty/common/HttpServerLifecycleChannelHandlerTest.java
index db014a7c6d..2fc84063d6 100644
--- a/zuul-core/src/test/java/com/netflix/netty/common/HttpServerLifecycleChannelHand... | true | |
Netflix/zuul | 2,108 | comment_to_fix | Static Analysis Fixes | this is a behavior change - can you revert to the old behavior and suppress the warning if needed? | 977a11ce4af256a070f9eb657f90f44f83791692 | 4ffa9b55af21f9e5990a40bd157c9cf6c989af31 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/passport/CurrentPassport.java b/zuul-core/src/main/java/com/netflix/zuul/passport/CurrentPassport.java
index 465af6ce30..94d9b23a06 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/passport/CurrentPassport.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/pas... | [
"zuul-core/src/main/java/com/netflix/zuul/passport/CurrentPassport.java"
] | [
{
"comment": "this is a behavior change - can you revert to the old behavior and suppress the warning if needed?",
"path": "zuul-core/src/main/java/com/netflix/zuul/passport/CurrentPassport.java",
"hunk": "@@ -84,8 +84,8 @@ protected Thread getOwner() {\n }\n \n private Unlocker lock() {\n- ... | true | ||
Netflix/zuul | 2,107 | issue_to_patch | Upgrade netty to v4.2.12 | https://netty.io/news/2026/03/24/4-2-12-Final.html
Includes dependency bump and related linter fixes | 60ee887d901a9f134a258e0375eaf14a38034ec0 | 81da64b2257d5255c093652da50a00aae3b63626 | diff --git a/build.gradle b/build.gradle
index 99520dae4d..5e5288154d 100644
--- a/build.gradle
+++ b/build.gradle
@@ -97,6 +97,13 @@ subprojects {
"-Xep:FutureReturnValueIgnored:OFF",
"-Xep:InlineMeSuggester:OFF",
"-Xep:MissingSummary:OFF",
+ "-Xep:Bool... | [
"build.gradle",
"gradle.properties",
"zuul-core/dependencies.lock",
"zuul-discovery/dependencies.lock",
"zuul-integration-test/dependencies.lock",
"zuul-processor/dependencies.lock",
"zuul-sample/dependencies.lock"
] | [
{
"comment": "To be reverted and static analysis/build issues addressed in a followup",
"path": "build.gradle",
"hunk": "@@ -97,6 +97,13 @@ subprojects {\n \"-Xep:FutureReturnValueIgnored:OFF\",\n \"-Xep:InlineMeSuggester:OFF\",\n \"-Xep:MissingSummary:OFF... | true | ||
Netflix/zuul | 2,106 | issue_to_patch | Add `listener` tag to ssl handshake metrics | This PR adds a `listener` tag to the `server.ssl.handshake` metric making it possible to distinguish handshake metrics across different listeners. | 0f4e354d1dd8607e41614b8dac497f9bf2b244e7 | fe2edf3b5998739baff01158022cbebed288737b | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java
index 9466a44253..ebe40e506f 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java
+++ b... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/BaseZuulChannelInitializer.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandlerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandlerTest.java
index bb062491d1..95d29c6e69 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandler... | true | |
Netflix/zuul | 2,102 | issue_to_patch | build(deps): bump gradle/actions from 5 to 6 | Bumps [gradle/actions](https://github.com/gradle/actions) from 5 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gradle/actions/releases">gradle/actions's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>Summary</h2>
<ul>
<li>Caching functionality of 'gradle-actio... | 1cb3810371ac568bf65322161b00de9a6b6b976c | e9d444a92df7816bad087579ab31c05ae836924d | diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml
index 66c641b138..eeec03e64a 100644
--- a/.github/workflows/gradle-wrapper-validation.yml
+++ b/.github/workflows/gradle-wrapper-validation.yml
@@ -7,4 +7,4 @@ jobs:
runs-on: ubuntu-latest
steps:
... | [
".github/workflows/gradle-wrapper-validation.yml",
".github/workflows/pr.yml",
".github/workflows/release.yml"
] | [] | true | ||
Netflix/zuul | 2,104 | issue_to_patch | Switch nullaway to enforce nullmarked | 1cb3810371ac568bf65322161b00de9a6b6b976c | bb9f97aca1934f309e9c05fddf12c39c1c04e59e | diff --git a/build.gradle b/build.gradle
index 12cadfc366..99520dae4d 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,5 @@
+import net.ltgt.gradle.errorprone.CheckSeverity
+
buildscript {
dependencies {
classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.83.0'
@@ -75,15 +77,16 @@ sub... | [
"build.gradle"
] | [] | true | |||
Netflix/zuul | 2,103 | issue_to_patch | Remove SourceAddressChannelHandler after use | SourceAddressChannelHandler is only needed for channelActive, so we can remove it from the pipeline afterwards.
While writing the unit tests I ran into some null issues so I added some more annotations + null checking as well | 1cb3810371ac568bf65322161b00de9a6b6b976c | 26c5619b07ef01bee31cc3a4331b7cd35cfbf280 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/SourceAddressChannelHandler.java b/zuul-core/src/main/java/com/netflix/netty/common/SourceAddressChannelHandler.java
index 492e7b80cf..5ef7b0c893 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/SourceAddressChannelHandler.java
+++ b/zuul-core/s... | [
"zuul-core/src/main/java/com/netflix/netty/common/SourceAddressChannelHandler.java",
"zuul-core/src/test/java/com/netflix/netty/common/SourceAddressChannelHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/SourceAddressChannelHandlerTest.java b/zuul-core/src/test/java/com/netflix/netty/common/SourceAddressChannelHandlerTest.java
index 5177989a93..e3b07b3687 100644
--- a/zuul-core/src/test/java/com/netflix/netty/common/SourceAddressChannelHandlerTest.java
+++ b... | true | |
Netflix/zuul | 2,101 | issue_to_patch | Close the context instead of the pipeline | Upon reaching connections limits, immediately close the connection instead of sending it to the end of the pipeline for closing | 658eb26797dfc403d3c3d3490890131727337fe3 | 3bc6d96cf67c82f83d7316b24f30726a32f4c2be | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/throttle/MaxInboundConnectionsHandler.java b/zuul-core/src/main/java/com/netflix/netty/common/throttle/MaxInboundConnectionsHandler.java
index 2f64e93b01..332c3a9745 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/throttle/MaxInboundConnections... | [
"zuul-core/src/main/java/com/netflix/netty/common/throttle/MaxInboundConnectionsHandler.java",
"zuul-core/src/test/java/com/netflix/netty/common/throttle/MaxInboundConnectionsHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/throttle/MaxInboundConnectionsHandlerTest.java b/zuul-core/src/test/java/com/netflix/netty/common/throttle/MaxInboundConnectionsHandlerTest.java
index 31f8b69df6..e2b5dd8d7f 100644
--- a/zuul-core/src/test/java/com/netflix/netty/common/throttle/MaxInboundCon... | true | |
Netflix/zuul | 2,099 | issue_to_patch | Update instanceof to use EndpointLifecycle instead of ProxyEndpoint | This is also needed for the mesh egress integration. | 40a421d5318f6e13aa8d58e0ca4037c9c54b4836 | 07b42629a9f78586835c382bd73a28c5e718fb69 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/filter/ZuulEndPointRunner.java b/zuul-core/src/main/java/com/netflix/zuul/netty/filter/ZuulEndPointRunner.java
index 0405a56ee3..357b9bf618 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/filter/ZuulEndPointRunner.java
+++ b/zuul-core/src/main/java... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/filter/ZuulEndPointRunner.java"
] | [] | true | ||
Netflix/zuul | 1,878 | issue_to_patch | Upgrade netty version | 63ff48e8f590e5a275506d9c32981090e5fe9981 | a2144b5994d1f6b3bbfb15b6fcd48271962d69ac | diff --git a/dependencies.lock b/dependencies.lock
index fdcb1ffc68..bf938ade5c 100644
--- a/dependencies.lock
+++ b/dependencies.lock
@@ -273,16 +273,12 @@
"com.fasterxml.jackson.dataformat:jackson-dataformat-xml",
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310",
... | [
"dependencies.lock",
"gradle.properties",
"zuul-core/dependencies.lock",
"zuul-discovery/dependencies.lock",
"zuul-groovy/dependencies.lock",
"zuul-guice/dependencies.lock",
"zuul-integration-test/dependencies.lock",
"zuul-processor/dependencies.lock",
"zuul-sample/dependencies.lock"
] | [] | true | |||
Netflix/zuul | 1,929 | issue_to_patch | Extract client ip method | There are cases where the client ip set in the http request object is not correct. We should use the ATTR_CLIENT_IP value set in ClientIpChannelHandler instead, which takes into account ppv2 and XFF headers.
The only issue is that this value is scoped to edgezuul-netty, but the http request is created in zuul oss in... | 1ad784b14a746f5adc45dd69e3fcc36d702440ee | 746656ddf62c27e751e979d3393396ba90703efc | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java
index e831350530..4f65bd2adf 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java
+++ b/zuul-core/src/... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
index eac9f7898c..a33b7bfacb 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ClientRequestReceiverTest.java
+++ b/zu... | true | |
Netflix/zuul | 2,018 | issue_to_patch | Fix query parsing in massageRequestURI | Currently, if query param values are encoded, this method decodes them and pulls out any hidden query params before sending them off to the origin.
Example:
- A request arrives with this query param: `param=123%26hidden%3Dvalue`
- ProxyEndpoint decodes this query param and converts it to `param=123` and `hidden=v... | f62955db0850e89a4668e908d384117be1ee9ae8 | e38ed8f8b5a8dfc9f0f86e3356ca79ff9a71b602 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
index 3cd608f06f..2a2ec39fe7 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
+++ b/zuul-core/src/main/java/co... | [
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java",
"zuul-core/src/test/java/com/netflix/zuul/filters/endpoint/ProxyEndpointTest.java"
] | [
{
"comment": "can you make this package-private instead of protected?",
"path": "zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java",
"hunk": "@@ -1047,7 +1051,8 @@ protected void addCustomRequestHeaders(Headers headers) {\n // override to add custom headers\n }\n \... | diff --git a/zuul-core/src/test/java/com/netflix/zuul/filters/endpoint/ProxyEndpointTest.java b/zuul-core/src/test/java/com/netflix/zuul/filters/endpoint/ProxyEndpointTest.java
index f04a374fa3..f88594b2fa 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/filters/endpoint/ProxyEndpointTest.java
+++ b/zuul-core/src/... | true | |
Netflix/zuul | 2,019 | issue_to_patch | Make prop name follow naming convention | I misunderstood the comment [here](https://github.com/Netflix/zuul/pull/2018#discussion_r2455337695) and went too quickly without double checking my assumption.
We should use the common naming convention for consistency. | 6580de7d38ceed6d10508e71fb1a3ce358604b11 | 0b7d3a14f8ea02adf1c2b50adf14ce562205a63e | diff --git a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
index 2a2ec39fe7..8154e6ce19 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
+++ b/zuul-core/src/main/java/co... | [
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java"
] | [] | true | ||
Netflix/zuul | 2,069 | issue_to_patch | Remove old query parsing code | I updated the way we did query parsing in [this PR](https://github.com/Netflix/zuul/pull/2018), but left the old code path around, gated by an FP, just in case. It has officially been long enough that if someone had an issue with this change, they would have surfaced it by now. | 9be79288eb694e2886a8b56ad3ef762b808a7d46 | 191a9a2c617da77d4f78892d6eb286fbd7bf8900 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
index ce3ce232d9..b533be6aa9 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java
+++ b/zuul-core/src/main/java/co... | [
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java"
] | [] | true | ||
Netflix/zuul | 2,098 | issue_to_patch | CGW-3113: Add EndpointLifecycle interface to enable us to create more Endpoint classes | Create `EndpointLifecycle` interface so that any future Endpoint classes can use the same `finish()` method, which is called in `ZuulFilterChainHandler`, not just `ProxyEndpoint` subclasses.
`ZuulFilterChainHandler.fireEndpointFinish()` now checks for `EndpointLifecycle` instead of hardcoding `instanceof ProxyEndpoi... | 69e59d234e5808819a2d64b7dbcc2eb67fbe2479 | dd78bc9076b0cd38f0e9f908e004bc377665b0b5 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/EndpointLifecycle.java b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/EndpointLifecycle.java
new file mode 100644
index 0000000000..12cf9bf837
--- /dev/null
+++ b/zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/EndpointLifecyc... | [
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/EndpointLifecycle.java",
"zuul-core/src/main/java/com/netflix/zuul/filters/endpoint/ProxyEndpoint.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/filter/ZuulFilterChainHandler.java"
] | [] | true | ||
Netflix/zuul | 2,097 | issue_to_patch | Reduce log level | 47d31c5456d3014d701194b4ef2b0694b466c859 | f63517bed46598e87b95440f884838d9973de91f | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java
index e4110e42ad..2bb26f64e0 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java"
] | [] | true | |||
Netflix/zuul | 2,096 | issue_to_patch | Add a Builder to `ServerSslConfig` and tidy usage of default ciphers to be a list | The `ServerSslConfig` has a lot of overloaded constructors has ends up with some bad side effects where you end up having to cast null to make sure it calls the correct File vs String overloads for `certChainFile` etc.
This replaces it with a builder pattern and switches the return type of `getDefaultCiphers` to be ... | e4de3acfeb076d1ee7b40200ed25602cfec5a1c6 | 3b91b9cd59eaee81a165e5849ea0042e5312a984 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/ssl/ServerSslConfig.java b/zuul-core/src/main/java/com/netflix/netty/common/ssl/ServerSslConfig.java
index 3e9d9cb350..e7489e1c8e 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/ssl/ServerSslConfig.java
+++ b/zuul-core/src/main/java/com/netflix... | [
"zuul-core/src/main/java/com/netflix/netty/common/ssl/ServerSslConfig.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/ssl/ClientSslContextFactory.java",
"zuul-core/src/test/java/com/netflix/netty/common/ssl/ServerSslConfigTest.java",
"zuul-integration-test/src/test/java/com/netflix/zuul/integration/ser... | [] | diff --git a/zuul-core/src/test/java/com/netflix/netty/common/ssl/ServerSslConfigTest.java b/zuul-core/src/test/java/com/netflix/netty/common/ssl/ServerSslConfigTest.java
new file mode 100644
index 0000000000..5b4f877493
--- /dev/null
+++ b/zuul-core/src/test/java/com/netflix/netty/common/ssl/ServerSslConfigTest.java
@... | true | |
Netflix/zuul | 2,095 | issue_to_patch | Change visibility of auth event | b0f3bb59c425625b81ddba464f0a2e9990b83cff | 703fc75d26d055c613be08f74bd3335211576d3c | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java
index 8500a41787..e4110e42ad 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/push/PushRegistrationHandler.java"
] | [] | true | |||
Netflix/zuul | 2,091 | issue_to_patch | Add configuration for enabling SETTINGS_ENABLE_CONNECT_PROTOCOL | Part of rfc8441 | 84e1a5f38144bfa3ef0dc78b35c94eee1551ca6a | f91eb341f98c1f88529f50e5a8373847d43deb34 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java b/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java
index beff60704d..97fbd65705 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannel... | [
"zuul-core/src/main/java/com/netflix/netty/common/channel/config/CommonChannelConfigKeys.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/http2/Http2OrHttpHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2OrHttpHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2OrHttpHandlerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2OrHttpHandlerTest.java
index 1171df7e5f..abcd5bd6a8 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2OrHttpHandlerTest.java... | true | |
Netflix/zuul | 2,090 | issue_to_patch | Prefer Objects.requireNonNull or @NonNull | `com.netflix.spectator.impl.Preconditions` isn't recognized by intellij, and resulted in null warnings. I replaced that version of Preconditions and Guava's with either lombok or the Objects equivalent | c31ebb9386918b47b100754195cd55d2f7abbbf2 | 0404ba2da5dded41b439c8599ea36eb247800d91 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/proxyprotocol/ElbProxyProtocolChannelHandler.java b/zuul-core/src/main/java/com/netflix/netty/common/proxyprotocol/ElbProxyProtocolChannelHandler.java
index 1462ce7ccb..c23affea7b 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/proxyprotocol/El... | [
"zuul-core/src/main/java/com/netflix/netty/common/proxyprotocol/ElbProxyProtocolChannelHandler.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/filter/BaseZuulFilterRunner.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/filter/ZuulEndPointRunner.java",
"zuul-core/src/main/java/com/netflix/zuul/ne... | [] | true | ||
Netflix/zuul | 2,089 | issue_to_patch | Restore EventExecutorScheduler | Keep these around until we can fully delete RX | 368cba184766e94b643e4cdca55adca79fb35387 | d24e6efc58018704d87f5dd03db097df4d1206b8 | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/filter/EventExecutorScheduler.java b/zuul-core/src/main/java/com/netflix/zuul/netty/filter/EventExecutorScheduler.java
new file mode 100644
index 0000000000..9db56acccf
--- /dev/null
+++ b/zuul-core/src/main/java/com/netflix/zuul/netty/filter/EventExecutorSche... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/filter/EventExecutorScheduler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/filter/EventExecutorSchedulerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/filter/EventExecutorSchedulerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/filter/EventExecutorSchedulerTest.java
new file mode 100644
index 0000000000..74492d9604
--- /dev/null
+++ b/zuul-core/src/test/java/com/netflix/zuul/netty/filter/EventExec... | true | |
Netflix/zuul | 2,088 | issue_to_patch | Improve logging on decode failures | Switch to logging the clientIp instead of the duplicate uri. Also updated the logging in ChannelUtils to use a StringBuilder and removed the redundant inclusion of id | 9311f56e8f9b22aa794e6926ef4d6f2471c86d0d | 6ee36582acc54b7bddfdda7f83636e831e711d5b | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/ChannelUtils.java b/zuul-core/src/main/java/com/netflix/zuul/netty/ChannelUtils.java
index 5831970d88..d7dfe13759 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/ChannelUtils.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/netty/ChannelUtils.ja... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/ChannelUtils.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java"
] | [] | true | ||
Netflix/zuul | 2,087 | issue_to_patch | Allow configuring of TLS named groups | Add a `getNamedGroups()` override in `BaseSslContextFactory` to apply when building SSL contexts. The OSS default matches Netty's built-in set (`x25519`, `secp256r1`, `secp384r1`, `secp521r1`); subclasses can override to customize. | fc36578a14edb49e0247b7bc71898242cb4343f7 | 4b9671a5c8279f3deb3de76e20c377ec0a972bef | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/ssl/BaseSslContextFactory.java b/zuul-core/src/main/java/com/netflix/zuul/netty/ssl/BaseSslContextFactory.java
index 1d21545630..23ea179dab 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/ssl/BaseSslContextFactory.java
+++ b/zuul-core/src/main/java... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/ssl/BaseSslContextFactory.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/ssl/BaseSslContextFactoryTest.java"
] | [
{
"comment": "Tricky!",
"path": "zuul-core/src/test/java/com/netflix/zuul/netty/ssl/BaseSslContextFactoryTest.java",
"hunk": "@@ -29,4 +31,17 @@ class BaseSslContextFactoryTest {\n void testDefaultSslProviderIsOpenSsl() {\n assertThat(BaseSslContextFactory.chooseSslProvider()).isEqualTo(SslP... | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/ssl/BaseSslContextFactoryTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/ssl/BaseSslContextFactoryTest.java
index 08461aba99..a3823cd2a6 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/ssl/BaseSslContextFactoryTest.java
+++ b/zuul-core/s... | true | |
Netflix/zuul | 2,086 | issue_to_patch | Add `namedGroup` to `SslHandlerInfo` and add Builder pattern | Add a `namedGroup` field to `SslHandshakeInfo` to capture the TLS named group (e.g. `x25519`, `secp256r1`, `secp521r1`) negotiated during the handshake, and emit it as a metric. This is populated via a channel attribute `ATTR_SSL_NAMED_GROUP` that can be set by an outbound handler parsing the `ServerHello`.
Refactor... | 1899931b8d744e9772847c072ae2ae5adf5a683b | fc36578a14edb49e0247b7bc71898242cb4343f7 | diff --git a/zuul-core/src/main/java/com/netflix/netty/common/ssl/SslHandshakeInfo.java b/zuul-core/src/main/java/com/netflix/netty/common/ssl/SslHandshakeInfo.java
index 257daeb853..a41bad98c6 100644
--- a/zuul-core/src/main/java/com/netflix/netty/common/ssl/SslHandshakeInfo.java
+++ b/zuul-core/src/main/java/com/netf... | [
"zuul-core/src/main/java/com/netflix/netty/common/ssl/SslHandshakeInfo.java",
"zuul-core/src/main/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandlerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandlerTest.java
index 3d6c6fafae..bb062491d1 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/ssl/SslHandshakeInfoHandler... | true | |
Netflix/zuul | 2,085 | issue_to_patch | Rely on jvm's lazy hashCode caching | There isn't any reason to eagerly compute and cache the hashcode of a string, as the jvm lazily caches it already. By relying on string's hashcode we may be able to benefit from some jvm optimizations derived string's hash being `@Stable` | b72bc112e20942cfec62214003093f8f1fadd307 | beb770e30bb08e4c6ec0391c5058bf008966fbcf | diff --git a/zuul-core/src/main/java/com/netflix/zuul/message/HeaderName.java b/zuul-core/src/main/java/com/netflix/zuul/message/HeaderName.java
index 8728c0bff1..f7c2bcde15 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/message/HeaderName.java
+++ b/zuul-core/src/main/java/com/netflix/zuul/message/HeaderName.ja... | [
"zuul-core/src/main/java/com/netflix/zuul/message/HeaderName.java",
"zuul-core/src/test/java/com/netflix/zuul/message/HeaderNameTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/message/HeaderNameTest.java b/zuul-core/src/test/java/com/netflix/zuul/message/HeaderNameTest.java
new file mode 100644
index 0000000000..70cb467d9e
--- /dev/null
+++ b/zuul-core/src/test/java/com/netflix/zuul/message/HeaderNameTest.java
@@ -0,0 +1,42 @@
+/*
+ * Cop... | true | |
Netflix/zuul | 2,084 | issue_to_patch | Skip invalid `X-Forwarded-Port` header in `getOriginalPort` | Gracefully handle non-numeric `X-Forwarded-Port` headers in `getOriginalPort` | 55b8fa262e9f2b1733678e26e517375e1291cc84 | 09536ca3e553904ae3f7832c1b4f2b996a4c468e | diff --git a/zuul-core/src/main/java/com/netflix/zuul/message/http/HttpRequestMessageImpl.java b/zuul-core/src/main/java/com/netflix/zuul/message/http/HttpRequestMessageImpl.java
index e2114e14a8..3f5f1e2820 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/message/http/HttpRequestMessageImpl.java
+++ b/zuul-core/s... | [
"zuul-core/src/main/java/com/netflix/zuul/message/http/HttpRequestMessageImpl.java",
"zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java b/zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java
index c35a1a05fd..54d3ce63b1 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/message/http/HttpRequestMessageImplTest.java
+++ b... | true | |
Netflix/zuul | 2,082 | issue_to_patch | Fix ByteBuf leak on invalid Content-Length in Http2ContentLengthEnforcingHandler | This fixes a leak when a non-numeric `Content-Length` is supplied and attempted to be parsed by `Http2ContentLengthEnforcingHandler` throws a `NumberFormatException`. The handler now correctly releases the bytebuf and sends a reset frame. | 9c994f68460c6197d1de84e68ee328da60a6ae9a | 47a576214965b174c2e071d49f2be9ee3c27140d | diff --git a/zuul-core/src/main/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandler.java b/zuul-core/src/main/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandler.java
index 226e20d3e0..5aaee2c383 100644
--- a/zuul-core/src/main/java/com/netflix/zuul/netty/server/http2/Htt... | [
"zuul-core/src/main/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandler.java",
"zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandlerTest.java"
] | [] | diff --git a/zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandlerTest.java b/zuul-core/src/test/java/com/netflix/zuul/netty/server/http2/Http2ContentLengthEnforcingHandlerTest.java
index 9d3b104f8e..2465e007b3 100644
--- a/zuul-core/src/test/java/com/netflix/zuul/netty/server/h... | true | |
NousResearch/hermes-agent | 46,111 | issue_to_patch | fix(gateway): stop replaying interrupted tool-call tails and auto-continue notes — prevents infinite re-execution loops
## Problem
When a user sends a new message while a long-running tool is executing
(e.g. terminal running yt-dlp + whisper on a 53 min video), the gateway
interrupts the API call and queues the new m... | fix(gateway): stop interrupted tool replay loops | ## Summary
Gateway replay now removes interrupted tool-call tails and keeps auto-continue recovery guidance out of persisted user history, so a fresh user message does not revive old long-running tool loops.
## Changes
- `gateway/run.py`: strips interrupted assistant→tool tails from replay history before the model see... | 0f3670ba7920152127a11da6a4be972cbc26dbae | 2560e0d5eb3e13b12e2c0ab53933804c290b36f4 | diff --git a/gateway/run.py b/gateway/run.py
index cd0834301d5..b81cd32ff4d 100644
--- a/gateway/run.py
+++ b/gateway/run.py
@@ -677,6 +677,15 @@ def _build_gateway_agent_history(
clean_msg = {k: v for k, v in msg.items() if k not in {"timestamp", "observed"}}
agent_history.append(clean_msg)
... | [
"gateway/run.py",
"scripts/release.py",
"tests/gateway/test_auto_continue.py",
"tests/gateway/test_restart_resume_pending.py"
] | [] | diff --git a/tests/gateway/test_auto_continue.py b/tests/gateway/test_auto_continue.py
index eb20abf55df..de3b738944b 100644
--- a/tests/gateway/test_auto_continue.py
+++ b/tests/gateway/test_auto_continue.py
@@ -1,9 +1,9 @@
-"""Tests for the auto-continue feature (#4493).
+"""Tests for the auto-continue feature (#4493... | true |
NousResearch/hermes-agent | 46,110 | issue_to_patch | Desktop UI mislabels Weixin (personal WeChat / iLink) adapter as 'WeChat (Official Account)'
## Summary
The desktop UI (Vite/React frontend served by `hermes_cli/web_server.py`) **mislabels the `weixin` platform as "WeChat (Official Account)"**, but the underlying adapter (`gateway/platforms/weixin.py`) actually conn... | fix(messaging): correct Weixin personal setup copy | ## Summary
Weixin setup copy now consistently describes the supported integration: personal WeChat/Weixin via Tencent iLink Bot API and QR login.
Cherry-picks #46096 from @Diyoncrz18. This covers the backend messaging metadata plus desktop English and Simplified Chinese onboarding copy, and adds a focused regression t... | 972a9885ee207e732bba1e0b7c1a65716df322c1 | 2644f7102bd1f38148d4bd63363a4590d0d05237 | diff --git a/apps/desktop/src/app/messaging/index.tsx b/apps/desktop/src/app/messaging/index.tsx
index 158360aea88f..7fc6ce212ef0 100644
--- a/apps/desktop/src/app/messaging/index.tsx
+++ b/apps/desktop/src/app/messaging/index.tsx
@@ -527,7 +527,7 @@ const PLATFORM_INTRO: Record<string, string> = {
wecom_callback:
... | [
"apps/desktop/src/app/messaging/index.tsx",
"apps/desktop/src/i18n/zh.ts",
"hermes_cli/web_server.py",
"scripts/release.py",
"tests/hermes_cli/test_web_server.py"
] | [] | diff --git a/tests/hermes_cli/test_web_server.py b/tests/hermes_cli/test_web_server.py
index ea3091ed95cb..b042c76210e6 100644
--- a/tests/hermes_cli/test_web_server.py
+++ b/tests/hermes_cli/test_web_server.py
@@ -1386,6 +1386,28 @@ def test_get_messaging_platforms(self):
assert telegram["enabled"] is False
... | true |
NousResearch/hermes-agent | 46,107 | issue_to_patch | fix(gateway): include replied-to media attachments | ## Summary
Replies to media-bearing Discord and Telegram messages now pass the referenced attachment into the gateway media pipeline so the agent can inspect it.
## Changes
- Discord: merge `message.reference.resolved.attachments` with current/snapshot attachments before caching.
- Telegram: cache media from `reply_to... | 972a9885ee207e732bba1e0b7c1a65716df322c1 | 3972dfaea65f2dd3a3a5b7713cfacec62ba416be | diff --git a/gateway/platforms/telegram.py b/gateway/platforms/telegram.py
index 381535ab8ac3..06a231f092b8 100644
--- a/gateway/platforms/telegram.py
+++ b/gateway/platforms/telegram.py
@@ -5560,6 +5560,52 @@ async def _cache_observed_media(self, msg: Message, event: MessageEvent) -> None
event.text = self._a... | [
"gateway/platforms/telegram.py",
"plugins/platforms/discord/adapter.py",
"tests/e2e/test_discord_adapter.py",
"tests/gateway/test_telegram_group_gating.py"
] | [] | diff --git a/tests/e2e/test_discord_adapter.py b/tests/e2e/test_discord_adapter.py
index 891d4806821c..412163f43cbe 100644
--- a/tests/e2e/test_discord_adapter.py
+++ b/tests/e2e/test_discord_adapter.py
@@ -5,6 +5,7 @@
"""
import asyncio
+from types import SimpleNamespace
from unittest.mock import AsyncMock
imp... | true | |
NousResearch/hermes-agent | 46,112 | issue_to_patch | fix(mcp): block suspicious stdio configs before probe | ## Summary
MCP stdio configs now reject exfil-shaped commands before any probe/connect path can spawn them.
PR #46083 blocked persistence and config-loaded runtime startup, but `hermes mcp add` still probed a suspicious stdio command before the save-time rejection. This follow-up moves the guard ahead of probe/connect... | 972a9885ee207e732bba1e0b7c1a65716df322c1 | 87e8c0444e18fac100d34813c7f8e22ec99c141e | diff --git a/hermes_cli/config.py b/hermes_cli/config.py
index 204e29d5faab..7bb0b283035b 100644
--- a/hermes_cli/config.py
+++ b/hermes_cli/config.py
@@ -4837,15 +4837,15 @@ def migrate_config(interactive: bool = True, quiet: bool = False) -> Dict[str, A
raw_mcp_servers = config.get("mcp_servers")
if isinsta... | [
"hermes_cli/config.py",
"hermes_cli/mcp_config.py",
"tests/hermes_cli/test_mcp_security.py",
"tools/mcp_tool.py"
] | [] | diff --git a/tests/hermes_cli/test_mcp_security.py b/tests/hermes_cli/test_mcp_security.py
index 2b0170847c6e..a50d7e04ab0e 100644
--- a/tests/hermes_cli/test_mcp_security.py
+++ b/tests/hermes_cli/test_mcp_security.py
@@ -2,6 +2,7 @@
from __future__ import annotations
+from argparse import Namespace
from pathlib... | true | |
NousResearch/hermes-agent | 46,114 | issue_to_patch | perf(model-metadata): persist OpenRouter metadata cache | ## Summary
OpenRouter model metadata now has a disk-backed cache so cold Hermes processes can reuse recently fetched context/pricing metadata without hitting the network again.
## Changes
- `agent/model_metadata.py`: add an OpenRouter metadata disk cache under Hermes cache storage.
- `agent/model_metadata.py`: resolve... | 972a9885ee207e732bba1e0b7c1a65716df322c1 | cf5ef4c2f71446ee2833adede0ff678cb7b224d8 | diff --git a/agent/model_metadata.py b/agent/model_metadata.py
index 3a71e974fdb7..8cfec23fe1f7 100644
--- a/agent/model_metadata.py
+++ b/agent/model_metadata.py
@@ -5,6 +5,7 @@
"""
import ipaddress
+import json
import logging
import os
import re
@@ -16,7 +17,7 @@
import requests
import yaml
-from utils imp... | [
"agent/model_metadata.py",
"tests/agent/test_model_metadata.py"
] | [] | diff --git a/tests/agent/test_model_metadata.py b/tests/agent/test_model_metadata.py
index ba5fa30886f3..35651a00b66f 100644
--- a/tests/agent/test_model_metadata.py
+++ b/tests/agent/test_model_metadata.py
@@ -1083,6 +1083,78 @@ def _reset_cache(self):
mm._model_metadata_cache = {}
mm._model_metadata... | true | |
NousResearch/hermes-agent | 46,105 | issue_to_patch | docs(gateway): document exact silence tokens | ## Summary
Docs now describe the gateway exact silence-token contract and update cron/hook examples so users know when `[SILENT]` suppresses delivery.
## Changes
- Messaging gateway overview: add exact whole-response silence-token behavior, supported tokens, transcript preservation, and failed-turn behavior.
- Cron gu... | 972a9885ee207e732bba1e0b7c1a65716df322c1 | 2e621d1d9183df63c906b7819363f53bd2baf800 | diff --git a/website/docs/guides/automate-with-cron.md b/website/docs/guides/automate-with-cron.md
index 7c4a2c2eca2c..dec05e43fd46 100644
--- a/website/docs/guides/automate-with-cron.md
+++ b/website/docs/guides/automate-with-cron.md
@@ -71,7 +71,7 @@ Set up the cron job:
```
:::tip The [SILENT] Trick
-When the ag... | [
"website/docs/guides/automate-with-cron.md",
"website/docs/guides/cron-troubleshooting.md",
"website/docs/user-guide/features/cron.md",
"website/docs/user-guide/features/hooks.md",
"website/docs/user-guide/messaging/index.md"
] | [] | true | ||
NousResearch/hermes-agent | 46,084 | issue_to_patch | fix: Email adapter fails on port 465 (SMTP_SSL) and hangs on IPv6
## Bug Description
The Email gateway adapter has two issues that prevent SMTP from working with providers that use port 465 (implicit TLS / SMTPS):
1. **Wrong SMTP class for port 465** — The adapter always uses `smtplib.SMTP()` + `starttls()`, which i... | fix(email): use implicit TLS for port 465 | ## Summary
Email gateway SMTP connections now use the correct TLS mode for port 465 and a thread-safe IPv4 fallback for broken IPv6 routes.
Cherry-picks #46061 from @liuhao1024, then fixes the fallback path so it uses supported `smtplib` extension points instead of unsupported `sock=` kwargs. Also adds security-focuse... | 0428945b5b07f430e23b4fc28b2bff6887477463 | 776851a43a3227713e5ae83ae445518422d8e566 | diff --git a/gateway/platforms/email.py b/gateway/platforms/email.py
index 4eb4972b24ec..7b247cdda278 100644
--- a/gateway/platforms/email.py
+++ b/gateway/platforms/email.py
@@ -22,6 +22,7 @@
import os
import re
import smtplib
+import socket
import ssl
import uuid
from email.header import decode_header
@@ -62,6 ... | [
"gateway/platforms/email.py",
"tests/gateway/test_email.py"
] | [] | diff --git a/tests/gateway/test_email.py b/tests/gateway/test_email.py
index 79b8bf4bc85c..8cfaa22c5d32 100644
--- a/tests/gateway/test_email.py
+++ b/tests/gateway/test_email.py
@@ -18,7 +18,7 @@
from email.mime.multipart import MIMEMultipart
from email.mime.base import MIMEBase
from email import encoders
-from uni... | true |
NousResearch/hermes-agent | 46,083 | issue_to_patch | Security: config v27→v28 migration injected credential-exfiltration MCP server entry
## Summary
The config migration from v27 to v28 (shipped in the Jun 9 2026 update, main HEAD `c6dc2fcd2`) injected a malicious `mcp_servers` entry into `/root/.hermes/config.yaml` that attempts to exfiltrate the contents of `~/.herme... | fix(mcp): block exfil-shaped stdio server configs | ## Summary
MCP stdio config now rejects the #45620 exfiltration shape before it can be saved or spawned.
## Changes
- `hermes_cli/mcp_security.py`: shared narrow validator for shell interpreter + network egress/exfil-shaped args.
- MCP config write paths: reject suspicious entries from `hermes mcp add`, dashboard `/ap... | 0428945b5b07f430e23b4fc28b2bff6887477463 | 4e9477e3124b7a65953a211e755b8a4f12456f73 | diff --git a/.github/workflows/supply-chain-audit.yml b/.github/workflows/supply-chain-audit.yml
index 3309de78daef..4bee46a95cd0 100644
--- a/.github/workflows/supply-chain-audit.yml
+++ b/.github/workflows/supply-chain-audit.yml
@@ -29,6 +29,8 @@ jobs:
scan: ${{ steps.filter.outputs.scan }}
# True when ... | [
".github/workflows/supply-chain-audit.yml",
"hermes_cli/config.py",
"hermes_cli/doctor.py",
"hermes_cli/mcp_catalog.py",
"hermes_cli/mcp_config.py",
"hermes_cli/mcp_security.py",
"hermes_cli/web_server.py",
"tests/hermes_cli/test_mcp_catalog.py",
"tests/hermes_cli/test_mcp_security.py",
"tools/mcp... | [] | diff --git a/tests/hermes_cli/test_mcp_catalog.py b/tests/hermes_cli/test_mcp_catalog.py
index bb15c48ce8c1..b86cb5ea14e2 100644
--- a/tests/hermes_cli/test_mcp_catalog.py
+++ b/tests/hermes_cli/test_mcp_catalog.py
@@ -218,6 +218,27 @@ def test_install_simple_stdio_writes_config(self, catalog_dir):
assert serv... | true |
NousResearch/hermes-agent | 46,102 | issue_to_patch | fix(telegram): guard rich details math crash | ## Summary
Telegram rich messages now fall back to MarkdownV2 for the specific details+math payload shape that can crash Telegram Desktop 6.9.1.
## Changes
- `gateway/platforms/telegram.py`: detect `<details>...</details>` blocks containing LaTeX-style math and skip `sendRichMessage` / `sendRichMessageDraft` for that ... | 5105c3651a8f1b153a9ce7c1ac327f6933283be3 | 8938d52f4096381c7663ab4265429a45792b7181 | diff --git a/gateway/platforms/telegram.py b/gateway/platforms/telegram.py
index 314f7249e8a4..381535ab8ac3 100644
--- a/gateway/platforms/telegram.py
+++ b/gateway/platforms/telegram.py
@@ -953,6 +953,32 @@ def _bot_supports_rich(self) -> bool:
"""
return inspect.iscoroutinefunction(getattr(self._bot... | [
"gateway/platforms/telegram.py",
"tests/gateway/test_telegram_rich_messages.py"
] | [] | diff --git a/tests/gateway/test_telegram_rich_messages.py b/tests/gateway/test_telegram_rich_messages.py
index 54827111a759..d13dc43ef035 100644
--- a/tests/gateway/test_telegram_rich_messages.py
+++ b/tests/gateway/test_telegram_rich_messages.py
@@ -24,6 +24,12 @@
# Content exercising rich-only constructs: a heading,... | true | |
NousResearch/hermes-agent | 46,079 | issue_to_patch | perf(api-server): normalize chat content linearly | ## Summary
API-server text content normalization now tracks accumulated length with a running counter instead of rescanning every collected part on each loop iteration.
## Changes
- `gateway/platforms/api_server.py`: replace repeated `sum(len(part) for part in parts)` with `total_len` updates for strings, text parts, ... | afc86155094c75266b03eb4dd7344f3509bede52 | 431c3dc887184c27a1e3dba5f3953b908656bf53 | diff --git a/gateway/platforms/api_server.py b/gateway/platforms/api_server.py
index 1599eda9e6da..da86952a09d2 100644
--- a/gateway/platforms/api_server.py
+++ b/gateway/platforms/api_server.py
@@ -156,18 +156,23 @@ def _normalize_chat_content(
if isinstance(content, list):
parts: List[str] = []
+ ... | [
"gateway/platforms/api_server.py",
"tests/gateway/test_api_server_normalize.py"
] | [] | diff --git a/tests/gateway/test_api_server_normalize.py b/tests/gateway/test_api_server_normalize.py
index 2dd2c70f72df..1f943ced01b6 100644
--- a/tests/gateway/test_api_server_normalize.py
+++ b/tests/gateway/test_api_server_normalize.py
@@ -1,5 +1,6 @@
"""Tests for _normalize_chat_content in the API server adapter."... | true | |
NousResearch/hermes-agent | 46,080 | issue_to_patch | Empty-response retry loop on claude-opus-4-7 in Slack group threads (non-@mention discussion messages)
## Summary
On `claude-opus-4-7` (Anthropic provider) in Slack group threads, a genuine discussion message that is **not** an @mention of the bot can cause the model to reason into "don't reply" and emit no visible t... | fix(gateway): suppress exact silence tokens without mutating history | ## Summary
Gateway final-response delivery now treats exact whole-response silence tokens as an intentional no-op: the assistant turn stays in history, but no chat message is sent.
## Changes
- Add `gateway.response_filters` with the exact-token silence contract.
- Recognize only whole-response markers: `[SILENT]`, `S... | 0428945b5b07f430e23b4fc28b2bff6887477463 | 7e91fa07ba6e3049761759ab1c51d879c46e1719 | diff --git a/gateway/response_filters.py b/gateway/response_filters.py
new file mode 100644
index 000000000000..cc4b5c4f5d6b
--- /dev/null
+++ b/gateway/response_filters.py
@@ -0,0 +1,53 @@
+"""Gateway response filtering helpers.
+
+These helpers operate at the gateway boundary: they decide whether a completed
+agent t... | [
"gateway/response_filters.py",
"gateway/run.py",
"scripts/release.py",
"tests/gateway/test_gateway_silence_tokens.py",
"tests/gateway/test_response_filters.py"
] | [] | diff --git a/tests/gateway/test_gateway_silence_tokens.py b/tests/gateway/test_gateway_silence_tokens.py
new file mode 100644
index 000000000000..df15f6a15b0d
--- /dev/null
+++ b/tests/gateway/test_gateway_silence_tokens.py
@@ -0,0 +1,165 @@
+"""Gateway intentional-silence token behavior."""
+
+from datetime import dat... | true |
NousResearch/hermes-agent | 46,074 | issue_to_patch | Gateway restart should serialize auto-resume before accepting inbound messages
## Bug Description
When the gateway restarts, `auto-resume` restores interrupted sessions concurrently with inbound message processing. Even with the sentinel-based fix proposed in PRs #45494 and #45534, this remains a **structural race** ... | fix(gateway): serialize startup auto-resume before inbound | ## Summary
Gateway startup now queues real inbound messages until restart-interrupted auto-resume turns have been scheduled and completed, preventing duplicate agents for the same session after a restart.
## Changes
- `gateway/run.py`: adds a startup restore gate, tracks startup auto-resume tasks, waits for their adap... | afc86155094c75266b03eb4dd7344f3509bede52 | 9dc6804e5adf6597f84591f76222e656f48ef21e | diff --git a/gateway/run.py b/gateway/run.py
index f95a535bede2..5d38fcfcb415 100644
--- a/gateway/run.py
+++ b/gateway/run.py
@@ -2000,6 +2000,7 @@ class GatewayRunner(GatewayAuthorizationMixin, GatewayKanbanWatchersMixin, Gatew
_stop_task: Optional[asyncio.Task] = None
_session_model_overrides: Dict[str, Di... | [
"gateway/run.py",
"tests/gateway/test_restart_resume_pending.py"
] | [] | diff --git a/tests/gateway/test_restart_resume_pending.py b/tests/gateway/test_restart_resume_pending.py
index 60f733265da3..3ccaf801d52a 100644
--- a/tests/gateway/test_restart_resume_pending.py
+++ b/tests/gateway/test_restart_resume_pending.py
@@ -1189,6 +1189,86 @@ async def test_auto_resume_skips_sessions_with_run... | true |
NousResearch/hermes-agent | 46,071 | issue_to_patch | Bug: assistant responses silently dropped after repair_message_sequence (conversation_history vs messages mismatch)
## Description
In long-running sessions, assistant responses are generated by the model (`response_len > 0`, `finish_reason=stop`) but **never persisted** to `state.db`. User messages are persisted (by ... | fix(agent): persist repaired-turn responses | ## Summary
SessionDB flushing now persists newly appended assistant responses even when message-sequence repair has shortened the live `messages` list below `conversation_history` length.
## Changes
- `run_agent.py`: replace positional flush slicing with per-session message identity tracking, so history dicts are skip... | afc86155094c75266b03eb4dd7344f3509bede52 | 5f4a0540295e0c8990d70d60afb3d466e29d2b49 | diff --git a/run_agent.py b/run_agent.py
index 63c06e445829..2bf27d575101 100644
--- a/run_agent.py
+++ b/run_agent.py
@@ -1548,9 +1548,10 @@ def _repair_message_sequence(self, messages: List[Dict]) -> int:
def _flush_messages_to_session_db(self, messages: List[Dict], conversation_history: List[Dict] = None):
... | [
"run_agent.py",
"tests/run_agent/test_compression_persistence.py",
"tests/run_agent/test_identity_flush.py"
] | [] | diff --git a/tests/run_agent/test_compression_persistence.py b/tests/run_agent/test_compression_persistence.py
index e8b20487cd46..b3f42961a070 100644
--- a/tests/run_agent/test_compression_persistence.py
+++ b/tests/run_agent/test_compression_persistence.py
@@ -101,7 +101,7 @@ def test_flush_after_compression_with_lon... | true |
NousResearch/hermes-agent | 46,075 | issue_to_patch | Bug: HOME env corrupted inside Hermes profile runtime context — Path.home() resolves to wrong directory
# Bug Report: `$HOME` environment variable corrupted inside Hermes profile runtime context
## Description
When a Python script (or child process) runs inside a Hermes profile's session context, the `$HOME` environm... | fix: make profile subprocess HOME policy explicit | ## Summary
Profile subprocesses now keep the real OS-user `HOME` on host installs by default, while profile state remains scoped by `HERMES_HOME` and containers keep persistent profile-home behavior.
This salvages #25151's `HERMES_REAL_HOME` idea, but fixes the larger CLI side effect: opaque tools like `git`, `ssh`, `... | 0428945b5b07f430e23b4fc28b2bff6887477463 | 75de214f883acd118a0ebc2e5989a97ec27baea7 | diff --git a/agent/copilot_acp_client.py b/agent/copilot_acp_client.py
index b24ddbef5da3..e3c03938af40 100644
--- a/agent/copilot_acp_client.py
+++ b/agent/copilot_acp_client.py
@@ -70,16 +70,6 @@ def _resolve_args() -> list[str]:
def _resolve_home_dir() -> str:
"""Return a stable HOME for child ACP processes.... | [
"agent/copilot_acp_client.py",
"cli-config.yaml.example",
"cli.py",
"gateway/run.py",
"hermes_cli/config.py",
"hermes_cli/profiles.py",
"hermes_cli/tips.py",
"hermes_constants.py",
"tests/agent/test_copilot_acp_client.py",
"tests/gateway/test_config_cwd_bridge.py",
"tests/test_subprocess_home_is... | [] | diff --git a/tests/agent/test_copilot_acp_client.py b/tests/agent/test_copilot_acp_client.py
index dfc336b41cec..d8188d8604ee 100644
--- a/tests/agent/test_copilot_acp_client.py
+++ b/tests/agent/test_copilot_acp_client.py
@@ -174,12 +174,13 @@ def _fake(cmd, **kwargs):
return _fake
-def test_run_prompt_prefer... | true |
NousResearch/hermes-agent | 46,073 | issue_to_patch | crash on Hermes additional Agents
# Desktop app crash resets profile config.yaml and deletes .env for non-default profiles
## Bug Report
**Hermes Agent version:** v0.16.0 (2026.6.5) upstream cc14b747
**OS:** Windows 10
**Desktop app:** Hermes Desktop GUI
### Problem
When the Hermes desktop app crashes or is restar... | fix(desktop): keep profile homes out of bootstrap | ## Summary
Desktop startup now treats an inherited profile-scoped `HERMES_HOME` as the machine Hermes root, so a crash/restart cannot bootstrap into `profiles/<name>` and overwrite that profile's config/env files.
Fixes #45758. Builds on the root-cause analysis in #45793, with the normalization in a tested Electron he... | afc86155094c75266b03eb4dd7344f3509bede52 | 1ecad8c3c5ff4b2659952a44cd8d0a485ca6c3e0 | diff --git a/apps/desktop/electron/backend-env.cjs b/apps/desktop/electron/backend-env.cjs
index d3b65f4f781c..76329785be44 100644
--- a/apps/desktop/electron/backend-env.cjs
+++ b/apps/desktop/electron/backend-env.cjs
@@ -67,6 +67,16 @@ function buildDesktopBackendPath({
)
}
+function normalizeHermesHomeRoot(her... | [
"apps/desktop/electron/backend-env.cjs",
"apps/desktop/electron/backend-env.test.cjs",
"apps/desktop/electron/main.cjs",
"hermes_cli/setup.py",
"tests/hermes_cli/test_telegram_managed_bot.py"
] | [] | diff --git a/apps/desktop/electron/backend-env.test.cjs b/apps/desktop/electron/backend-env.test.cjs
index 1011161917aa..75e0c79d5d64 100644
--- a/apps/desktop/electron/backend-env.test.cjs
+++ b/apps/desktop/electron/backend-env.test.cjs
@@ -7,6 +7,7 @@ const {
appendUniquePathEntries,
buildDesktopBackendEnv,
... | true |
NousResearch/hermes-agent | 46,065 | issue_to_patch | perf(webhook): prune request caches incrementally | ## Summary
Webhook POST handling now prunes request caches incrementally instead of rebuilding TTL lists/dicts on every accepted request.
## Changes
- `gateway/platforms/webhook.py`: store per-route rate-limit windows as deques and prune expired timestamps from the left.
- `gateway/platforms/webhook.py`: check idempot... | 1f5eef809377a85a356ef9eeb6133e78fb380ae3 | dd5ebc9387363ab89c2ea5acbc070a092c7a7c1f | diff --git a/gateway/platforms/webhook.py b/gateway/platforms/webhook.py
index d4ad1826e5e8..222adf4c2ea1 100644
--- a/gateway/platforms/webhook.py
+++ b/gateway/platforms/webhook.py
@@ -36,7 +36,8 @@
import re
import subprocess
import time
-from typing import Any, Dict, List, Optional
+from collections import deque... | [
"gateway/platforms/webhook.py",
"tests/gateway/test_webhook_adapter.py"
] | [] | diff --git a/tests/gateway/test_webhook_adapter.py b/tests/gateway/test_webhook_adapter.py
index 606bd80e46e8..6e5291ca472a 100644
--- a/tests/gateway/test_webhook_adapter.py
+++ b/tests/gateway/test_webhook_adapter.py
@@ -20,6 +20,7 @@
import hmac
import json
import time
+from collections import deque
from unittes... | true | |
NousResearch/hermes-agent | 45,937 | issue_to_patch | [Bug]消息网关 启动不了 咋解决?
[hermes] UnicodeDecodeError: 'gbk' codec can't decode byte 0x94 in position 795: illegal multibyte sequence
[hermes] [boot] could not read served dashboard token (Hermes backend): 500: Internal Server Error
[hermes] [boot] Hermes backend is ready. Finalizing desktop startup
[hermes] [boot] Resolvin... | fix: read dashboard spa assets as utf-8 | ## Summary
- read dashboard `index.html` and proxied CSS assets with explicit UTF-8 decoding
- keep the SPA startup path locale-independent on Windows code pages like GBK
- add a regression test that asserts the SPA asset reads pass `encoding="utf-8"`
## Problem
The desktop dashboard startup path still used bare `Path... | 6b76284c7769e0ca80012a5a4b7e22b1cea05b6b | d3a547c322a3a3aff47e319889875e3aa6161b6d | diff --git a/hermes_cli/web_server.py b/hermes_cli/web_server.py
index 78a327a4767d..4f4bd1ccebf0 100644
--- a/hermes_cli/web_server.py
+++ b/hermes_cli/web_server.py
@@ -10625,7 +10625,7 @@ def _serve_index(prefix: str = ""):
``__HERMES_AUTH_REQUIRED__`` flag lets the SPA pick the right
auth scheme f... | [
"hermes_cli/web_server.py",
"tests/hermes_cli/test_web_server.py"
] | [] | diff --git a/tests/hermes_cli/test_web_server.py b/tests/hermes_cli/test_web_server.py
index 01a76b928168..484e9d2fb265 100644
--- a/tests/hermes_cli/test_web_server.py
+++ b/tests/hermes_cli/test_web_server.py
@@ -1857,6 +1857,45 @@ def test_path_traversal_dotdot_blocked(self):
if resp.status_code == 200:
... | true |
NousResearch/hermes-agent | 45,830 | issue_to_patch | fix(gateway): resolve sudo profile system installs | ## What does this PR do?
Fixes profile gateway system-service installs under sudo.
There were three related failure points:
- POSIX profile wrappers used `exec hermes -p <profile> "$@"`, so `sudo elias ...` could find the `elias` wrapper but then fail inside the wrapper because sudo's PATH did not contain `hermes`.
... | 2b67e96aec2aa2abd5e94b544cda8e564c75f9f5 | 08921844d91da6e8892bfefed318539bf5a28df5 | diff --git a/hermes_cli/gateway.py b/hermes_cli/gateway.py
index c1f7c04d7f23..69bf4ca6b250 100644
--- a/hermes_cli/gateway.py
+++ b/hermes_cli/gateway.py
@@ -1430,7 +1430,7 @@ def _profile_suffix() -> str:
return hashlib.sha256(str(home).encode()).hexdigest()[:8]
-def _profile_arg(hermes_home: str | None = No... | [
"hermes_cli/gateway.py",
"hermes_cli/main.py",
"hermes_cli/profiles.py",
"tests/hermes_cli/test_apply_profile_override.py",
"tests/hermes_cli/test_gateway_service.py",
"tests/hermes_cli/test_profiles.py",
"tests/hermes_cli/test_web_server.py"
] | [] | diff --git a/tests/hermes_cli/test_apply_profile_override.py b/tests/hermes_cli/test_apply_profile_override.py
index 9159969d3b56..0d3c2956a40b 100644
--- a/tests/hermes_cli/test_apply_profile_override.py
+++ b/tests/hermes_cli/test_apply_profile_override.py
@@ -14,6 +14,7 @@
import os
import sys
from pathlib import... | true | |
NousResearch/hermes-agent | 45,950 | issue_to_patch | fix(tui): scope resumed profile cwd to profile db | ## Summary
Resumed TUI/Desktop profile sessions now keep cwd reads and writes scoped to the profile that owns the stored session.
Cherry-picks #45898 from @necoweb3, then widens the fix so explicit workspace changes also persist through the profile-owned `SessionDB` instead of the launch profile DB.
## Changes
- `tui... | 7aaae7acd0d6f80aba9fbe15324a1c907ec70c55 | 65e9454f7033bbd7c03e223c399a5c6221b6196c | diff --git a/scripts/release.py b/scripts/release.py
index 313e71b75a70..760653bd2434 100755
--- a/scripts/release.py
+++ b/scripts/release.py
@@ -46,6 +46,7 @@
# Auto-extracted from noreply emails + manual overrides
AUTHOR_MAP = {
"kenmege@yahoo.com": "Kenmege",
+ "sswdarius@gmail.com": "necoweb3",
"pet... | [
"scripts/release.py",
"tests/test_tui_gateway_server.py",
"tests/tui_gateway/test_protocol.py",
"tui_gateway/server.py"
] | [] | diff --git a/tests/test_tui_gateway_server.py b/tests/test_tui_gateway_server.py
index 47c476b01579..4379d80aeb30 100644
--- a/tests/test_tui_gateway_server.py
+++ b/tests/test_tui_gateway_server.py
@@ -940,7 +940,7 @@ def get_messages_as_conversation(self, target, include_ancestors=False):
lambda agent, *a: {... | true | |
NousResearch/hermes-agent | 45,852 | issue_to_patch | fix(mcp): preserve event loop during probes | ## What does this PR do?
Prevents MCP probe/test cleanup from stopping the process-global MCP event loop while registered or connecting MCP servers still own it.
A support report showed runtime tool calls failing with `RuntimeError: MCP event loop is not running` even though `hermes mcp test <server>` passed and the ... | 4026f526d5a6160b0c444de4030096f7c959116f | 5f4a84b54c47a4e2648c7e9eba75aea5be7b4ad6 | diff --git a/hermes_cli/mcp_config.py b/hermes_cli/mcp_config.py
index 17b6c0329e5f..575d5f9b5ee2 100644
--- a/hermes_cli/mcp_config.py
+++ b/hermes_cli/mcp_config.py
@@ -212,7 +212,7 @@ def _probe_single_server(
_ensure_mcp_loop,
_run_on_mcp_loop,
_connect_server,
- _stop_mcp_loop,
+ ... | [
"hermes_cli/mcp_config.py",
"tests/tools/test_mcp_probe.py",
"tests/tools/test_mcp_stability.py",
"tools/mcp_tool.py"
] | [] | diff --git a/tests/tools/test_mcp_probe.py b/tests/tools/test_mcp_probe.py
index 89d4d1478d18..92656a441b30 100644
--- a/tests/tools/test_mcp_probe.py
+++ b/tests/tools/test_mcp_probe.py
@@ -162,14 +162,14 @@ def run_coro(coro_or_factory, timeout=120):
assert result["github"][0] == ("my_tool", "")
def t... | true | |
NousResearch/hermes-agent | 45,842 | issue_to_patch | fix(providers): support Anthropic proxy v1 endpoints | ## What does this PR do?
Supports Anthropic-compatible proxy base URLs that already include the version segment, such as `http://localhost:6655/anthropic/v1`.
Hermes already supports custom/proxy endpoints and Anthropic Messages transport, but auto-detection only recognized URLs whose path ended exactly in `/anthropi... | 4026f526d5a6160b0c444de4030096f7c959116f | 22eb35de4aad199b7a2686db2a339b44f84bca97 | diff --git a/agent/anthropic_adapter.py b/agent/anthropic_adapter.py
index 8476ef67f57f..3a2d3f68e17f 100644
--- a/agent/anthropic_adapter.py
+++ b/agent/anthropic_adapter.py
@@ -751,6 +751,9 @@ def build_anthropic_client(
from httpx import Timeout
normalized_base_url = _normalize_base_url_text(base_url)
+ ... | [
"agent/anthropic_adapter.py",
"agent/auxiliary_client.py",
"hermes_cli/models.py",
"hermes_cli/runtime_provider.py",
"tests/agent/test_anthropic_adapter.py",
"tests/agent/test_auxiliary_transport_autodetect.py",
"tests/hermes_cli/test_detect_api_mode_for_url.py",
"tests/hermes_cli/test_model_validatio... | [] | diff --git a/tests/agent/test_anthropic_adapter.py b/tests/agent/test_anthropic_adapter.py
index 79c9c286ecfb..2a2f236b9a36 100644
--- a/tests/agent/test_anthropic_adapter.py
+++ b/tests/agent/test_anthropic_adapter.py
@@ -113,6 +113,15 @@ def test_custom_base_url(self):
"anthropic-beta": "interleaved-... | true | |
NousResearch/hermes-agent | 45,947 | issue_to_patch | fix(file-safety): relax user-write deny policy | ## Summary
File tools can edit user-owned shell startup files, package-manager configs, and Hermes control files again; true containment belongs in Docker/remote backends and OS permissions, not an expanding hardcoded denylist.
## Changes
- Remove write-deny entries for `~/.bashrc`, `~/.zshrc`, `~/.profile`, `~/.bash_... | 12682d96b9c85f1373f1d61e953eb4a20feb661b | 168caa1a8cff2566c7dc47d5730411a8b2a4b17e | diff --git a/agent/file_safety.py b/agent/file_safety.py
index e9fa487e834f..7a70f9641250 100644
--- a/agent/file_safety.py
+++ b/agent/file_safety.py
@@ -46,11 +46,6 @@ def build_write_denied_paths(home: str) -> set[str]:
# Top-level Anthropic PKCE credential store remains sensitive even
# wh... | [
"agent/file_safety.py",
"tests/tools/test_file_operations.py",
"tests/tools/test_write_deny.py"
] | [] | diff --git a/tests/tools/test_file_operations.py b/tests/tools/test_file_operations.py
index a66a818286ba..fb8ae552a878 100644
--- a/tests/tools/test_file_operations.py
+++ b/tests/tools/test_file_operations.py
@@ -38,6 +38,11 @@ def test_netrc_denied(self):
path = os.path.join(str(Path.home()), ".netrc")
... | true | |
NousResearch/hermes-agent | 46,029 | issue_to_patch | fix(desktop): show summarizing indicator during auto-compaction | ## Summary
- Auto-compaction on long threads rewrites history mid-turn; without feedback the desktop looked like the transcript silently reset
- Gateway re-tags the agent compaction lifecycle status as `kind: "compacting"`; desktop shows a shimmering **Summarizing thread** indicator during the turn
- After compaction, ... | 9cbb91abd3a8667dc65c3677464e5d7847a49995 | 1eb13744b4ab73721e66ddf90d57e754d64e4846 | diff --git a/agent/conversation_compression.py b/agent/conversation_compression.py
index a5f0f9e3fba7..d5469a1b344f 100644
--- a/agent/conversation_compression.py
+++ b/agent/conversation_compression.py
@@ -40,6 +40,16 @@
logger = logging.getLogger(__name__)
+# Stable marker the gateway matches on to re-tag the au... | [
"agent/conversation_compression.py",
"apps/desktop/src/app/session/hooks/use-message-stream.ts",
"apps/desktop/src/components/assistant-ui/thread.tsx",
"apps/desktop/src/store/compaction.test.ts",
"apps/desktop/src/store/compaction.ts",
"tests/tui_gateway/test_compaction_status.py",
"tui_gateway/server.... | [] | diff --git a/apps/desktop/src/store/compaction.test.ts b/apps/desktop/src/store/compaction.test.ts
new file mode 100644
index 000000000000..f8388a3afc08
--- /dev/null
+++ b/apps/desktop/src/store/compaction.test.ts
@@ -0,0 +1,53 @@
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+
+import { $compa... | true | |
NousResearch/hermes-agent | 46,030 | issue_to_patch | fix(desktop): show copied checkmark on session Copy ID | ## Summary
- Route session sidebar **Copy ID** through shared `CopyButton` instead of raw `writeClipboardText`
- Add `context-menu-item` appearance so right-click menus get the same ✓ / "Copied" flash as the ⋮ dropdown
## Test plan
- [ ] Open session ⋮ menu → Copy ID → icon flips to checkmark, label shows "Copied", re... | 9cbb91abd3a8667dc65c3677464e5d7847a49995 | df69c3cee473ae5bc76f8732bc389bd70f39471b | diff --git a/apps/desktop/src/app/chat/sidebar/session-actions-menu.tsx b/apps/desktop/src/app/chat/sidebar/session-actions-menu.tsx
index 3d51ab8f8bb3..abff74dcfc5c 100644
--- a/apps/desktop/src/app/chat/sidebar/session-actions-menu.tsx
+++ b/apps/desktop/src/app/chat/sidebar/session-actions-menu.tsx
@@ -4,7 +4,7 @@ i... | [
"apps/desktop/src/app/chat/sidebar/session-actions-menu.tsx",
"apps/desktop/src/components/ui/copy-button.tsx"
] | [] | true | ||
NousResearch/hermes-agent | 46,014 | issue_to_patch | fix(desktop): clarify UX — loading, enter-to-send, radio align | ## Summary
- Hold the clarify panel on a centered spinner until `clarify.request` arrives — no disabled choices or loading-question stub.
- Send freeform clarify answers on Enter; Shift+Enter inserts a newline (composer parity, IME-safe).
- Top-align choice-row radio dots and checkmarks when labels wrap.
## Test plan
... | 4b5ba112adbfdfe588b015b288bc91f873ca602b | db163275d64d36abf2ce062d579be458ee1fbc01 | diff --git a/apps/desktop/src/components/assistant-ui/clarify-tool.tsx b/apps/desktop/src/components/assistant-ui/clarify-tool.tsx
index ce72a8179fb7..655ff389ec24 100644
--- a/apps/desktop/src/components/assistant-ui/clarify-tool.tsx
+++ b/apps/desktop/src/components/assistant-ui/clarify-tool.tsx
@@ -2,7 +2,7 @@
im... | [
"apps/desktop/src/components/assistant-ui/clarify-tool.tsx"
] | [] | true | ||
NousResearch/hermes-agent | 46,013 | issue_to_patch | fix(agent): surface model refusals as content_filter (salvage #43108 + edge-case fix) | ## Summary
Salvages @SHL0MS's refusal-handling fix from #43108 onto current `main`, with two follow-up commits that fix an edge case and apply a reuse cleanup. Authorship on the original work is preserved in git history.
A Claude model can return **HTTP 200 with a refusal** — a deterministic, server-side safety halt.... | 4b5ba112adbfdfe588b015b288bc91f873ca602b | 10bd01972b03659db25ad9365170f179d05aebe2 | diff --git a/agent/conversation_loop.py b/agent/conversation_loop.py
index 0b31dba9dfb8..379a038a9e09 100644
--- a/agent/conversation_loop.py
+++ b/agent/conversation_loop.py
@@ -397,6 +397,42 @@ def _get_continuation_prompt(is_partial_stub: bool, dropped_tools: Optional[List
)
+# Shared recovery hint appe... | [
"agent/conversation_loop.py",
"agent/transports/anthropic.py",
"agent/transports/chat_completions.py",
"tests/agent/transports/test_chat_completions.py",
"tests/agent/transports/test_transport.py",
"tests/run_agent/test_run_agent.py"
] | [] | diff --git a/tests/agent/transports/test_chat_completions.py b/tests/agent/transports/test_chat_completions.py
index 0b54fe470599..da642e2ae17c 100644
--- a/tests/agent/transports/test_chat_completions.py
+++ b/tests/agent/transports/test_chat_completions.py
@@ -843,6 +843,130 @@ def test_reasoning_content_preserved_fr... | true | |
NousResearch/hermes-agent | 45,979 | issue_to_patch | fix: shrink images to provider dimension limit | ## Summary
- Parse provider-reported image dimension ceilings from image-too-large errors.
- Pass the parsed ceiling into image shrink recovery so many-image Anthropic requests can downscale Retina screenshots below 2000px before retrying.
- Add regression coverage for the OpenRouter-wrapped Anthropic many-image reject... | cdf30a7ac6a6338959247795029ae3cff7e43824 | 69b469a3d3f73cc3e4b8af871cf8d173d402bcc0 | diff --git a/agent/conversation_compression.py b/agent/conversation_compression.py
index 913c0e25d914..a5f0f9e3fba7 100644
--- a/agent/conversation_compression.py
+++ b/agent/conversation_compression.py
@@ -631,7 +631,11 @@ def _release_lock() -> None:
return compressed, new_system_prompt
-def try_shrink_image... | [
"agent/conversation_compression.py",
"agent/conversation_loop.py",
"run_agent.py",
"tests/run_agent/test_image_shrink_recovery.py"
] | [] | diff --git a/tests/run_agent/test_image_shrink_recovery.py b/tests/run_agent/test_image_shrink_recovery.py
index b707f1d9235c..240546ea14ca 100644
--- a/tests/run_agent/test_image_shrink_recovery.py
+++ b/tests/run_agent/test_image_shrink_recovery.py
@@ -18,8 +18,11 @@
from __future__ import annotations
import base... | true | |
NousResearch/hermes-agent | 45,866 | issue_to_patch | feat(desktop): native OS notifications with per-type toggles | ## Summary
Adds a real **native OS notification** system to the desktop app (Electron `Notification`, routed cross-OS), distinct from the existing in-app toast feed. Before this, exactly one hardcoded notification existed (`message.complete` while `document.hidden`, active session only) with no settings, no other even... | b4ba3f5e3b3791f78e0861aa5a0c26a496ad6505 | b0288ae9b6ea75cb6b9aa5b9c021f95f7c37216f | diff --git a/apps/desktop/electron/main.cjs b/apps/desktop/electron/main.cjs
index 1d04aca9555f..64008d06e79a 100644
--- a/apps/desktop/electron/main.cjs
+++ b/apps/desktop/electron/main.cjs
@@ -5609,11 +5609,30 @@ ipcMain.handle('hermes:api', async (_event, request) => {
ipcMain.handle('hermes:notify', (_event, pay... | [
"apps/desktop/electron/main.cjs",
"apps/desktop/electron/preload.cjs",
"apps/desktop/src/app/desktop-controller.tsx",
"apps/desktop/src/app/session/hooks/use-message-stream.ts",
"apps/desktop/src/app/settings/appearance-settings.tsx",
"apps/desktop/src/app/settings/index.tsx",
"apps/desktop/src/app/sett... | [] | diff --git a/apps/desktop/src/store/native-notifications.test.ts b/apps/desktop/src/store/native-notifications.test.ts
new file mode 100644
index 000000000000..48650df12178
--- /dev/null
+++ b/apps/desktop/src/store/native-notifications.test.ts
@@ -0,0 +1,192 @@
+import { afterEach, beforeEach, describe, expect, it, vi... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.