repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
OtterMind/Chat2DB
1,500
issue_to_patch
Fix Issue:#1490
#1490 Bug: When copying rows as insert statements, all the values ​​in the generated SQL statements are null
cc5668fab949ce62fa2057d94a26ee027eab19ba
30d25c660971b11638b889eb5a111f8b196f4db1
diff --git a/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/jdbc/DefaultSqlBuilder.java b/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/jdbc/DefaultSqlBuilder.java index cfffd4521..04d2f7928 100644 --- a/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/jdbc/DefaultSqlBuilder.java +++ b/chat2db...
[ "chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/jdbc/DefaultSqlBuilder.java" ]
[]
true
OtterMind/Chat2DB
1,499
issue_to_patch
unit test
cc00466c8e4750cb43da6409be6933ca440b52f8
d1415f09d586276f2efa5e8965a4f16dc7e632d9
[ "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/TableServiceTest.java" ]
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/TableServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/TableServiceTest.java new file mode 100644 index 000000000..977dc51c2 --- /dev/null +++ b/chat2db-server/chat2db-se...
true
OtterMind/Chat2DB
1,483
issue_to_patch
unit test
ea2894a19c93ac72209ad6ae16c2873a65766118
3a4cc4bd17e9b3ce703f5333afb78c17db1a6cd1
diff --git a/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/model/Procedure.java b/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/model/Procedure.java index 6cb56418d..90cd8fb87 100644 --- a/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/model/Procedure.java +++ b/chat2db-server/chat2db-spi/s...
[ "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/PinServiceTest.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ProcedureServiceTest.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/dialect/Test...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/PinServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/PinServiceTest.java new file mode 100644 index 000000000..371299033 --- /dev/null +++ b/chat2db-server/chat2db-server...
true
OtterMind/Chat2DB
1,478
issue_to_patch
unit test
2173b050e24f29b93fe53757c9309057de5f53bb
052512e9b4ee2dc59b8558e29867e0cf73887d55
[ "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/OperationLogServiceTest.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/OperationServiceTest.java" ]
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/OperationLogServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/OperationLogServiceTest.java index 30f3490a1..8c0ecb778 100644 --- a/chat2db-server/chat2db-server-start/src...
true
OtterMind/Chat2DB
1,474
issue_to_patch
Dev
9b1bfade0731ee0876ff366ae5ac0b346c7056de
2173b050e24f29b93fe53757c9309057de5f53bb
diff --git a/chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseDBManage.java b/chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseDBManage.java index 75d782d2d..1af8b6390 100644 --- a/chat2db-server/chat2db-plugins/...
[ "chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseDBManage.java", "chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseMetaData.java", "chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java new file mode 100644 index 000000000..a61fa2f1a --- /dev/null +++ b/chat2db-server/chat2db-se...
true
OtterMind/Chat2DB
1,465
issue_to_patch
Add Webhook
b332bd2d67d50533eca53cc2dd33f80cf4201cc3
cd68edc8af139086c9c93be92bc232106b7f1a8d
diff --git a/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/message/MessageCreateParam.java b/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/message/MessageCreateParam.java new file mode 100...
[ "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/message/MessageCreateParam.java", "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/service/WebhookSender.java", "chat2db-server/chat2db-serve...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/WebhookServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/WebhookServiceTest.java new file mode 100644 index 000000000..930667e1b --- /dev/null +++ b/chat2db-server/chat2d...
true
OtterMind/Chat2DB
1,470
issue_to_patch
unit test
60e47c2132664c29d388c9ecb1948cb9dac66c6a
82bb7c24026ffbc21a0c5a96bfebdd7b81ebf83d
[ "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DataSourceServiceTest.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DlTemplateServiceTest.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DataSourceServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DataSourceServiceTest.java index 8adbfdb87..5ab3fa7c1 100644 --- a/chat2db-server/chat2db-server-start/src/tes...
true
OtterMind/Chat2DB
1,161
issue_to_patch
Fix Issue #974:Unable to modify column name
de4aa388844f1b236fdc5b222179977765498936
cc9068850e013951b94272acb4626b806165814e
diff --git a/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java b/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java index 1a97c843b..7a2c38301 100644 --- a/chat2db-server/chat2db-plugins/chat2db-my...
[ "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java" ]
[]
true
OtterMind/Chat2DB
1,463
issue_to_patch
Some typos and unit tests.
57bc5817e6598926651ec3512dbf6301a3c23994
6552f2dc5005ee9d9b382521809fc69201655c66
[ "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/dialect/MariadbDialectProperties.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/dialect/MongodbDialectProperties.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/sta...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/dialect/MariadbDialectProperties.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/dialect/MariadbDialectProperties.java index f4eedd53a..bb2a6a9b3 100644 --- a/chat2db-server/chat2db-server-s...
true
OtterMind/Chat2DB
1,462
issue_to_patch
Some typos and unit tests.
874914d689c8fd2f7254eb7807647425d75bb155
19a9060b1e6ff383e986b272bc26763f48f2d449
diff --git a/chat2db-server/chat2db-server-domain/chat2db-server-domain-core/src/main/java/ai/chat2db/server/domain/core/impl/ConfigServiceImpl.java b/chat2db-server/chat2db-server-domain/chat2db-server-domain-core/src/main/java/ai/chat2db/server/domain/core/impl/ConfigServiceImpl.java index a7d383008..1ebe3757e 100644...
[ "chat2db-server/chat2db-server-domain/chat2db-server-domain-core/src/main/java/ai/chat2db/server/domain/core/impl/ConfigServiceImpl.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DataSourceAccessBusinessServiceTest.java", "chat2db-server/chat2db-server-start/src/test...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DataSourceAccessBusinessServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/DataSourceAccessBusinessServiceTest.java new file mode 100644 index 000000000..4c0643bba --- /de...
true
OtterMind/Chat2DB
1,460
issue_to_patch
Oracle value processor
cfffc0a816797610b591b8e22fec36afb9ba09ab
615c1bfcd503525232bed4c9cb5fc80a7709d558
diff --git a/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java b/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java index 6cec12e5b..21ef1cd7a 100644 --- a/chat2db-server/chat2db-plugins/chat2db-my...
[ "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java", "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/value/MysqlValueProcessor.java", "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/my...
[]
true
OtterMind/Chat2DB
1,456
issue_to_patch
fix issue:#1390
fix issue:#1390
b66d77a21c28d5c44d93bd328860374aa8d1e699
c007d0dbcd603c980713fba659db3b86de8bb238
diff --git a/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/enums/RoleCodeEnum.java b/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/enums/RoleCodeEnum.java index 11cfebd29..37b7c14c3 100644 --- a/chat2...
[ "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/enums/RoleCodeEnum.java" ]
[]
true
OtterMind/Chat2DB
1,455
issue_to_patch
Some typos and unit tests.
Unit tests for three classes: ConsoleServiceImpl、DashboardServiceImpl、DatabaseServiceImpl
12b618e793e0c45751e1a6a89ffb949b3e2ec1a4
50c6d17c72510cb48e9b6cb38584937868462698
diff --git a/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/dashboard/DashboardCreateParam.java b/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/dashboard/DashboardCreateParam.java index c08...
[ "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/dashboard/DashboardCreateParam.java", "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/param/datasource/DatabaseCreateParam.java", "chat2db-s...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java index 1593d802e..a61fa2f1a 100644 --- a/chat2db-server/chat2db-server-start/src/test/java/ai/...
true
OtterMind/Chat2DB
1,451
issue_to_patch
Some typos and unit tests.
Unit tests for two classes: ChartServiceImpl and ConfigServiceImpl
f4b039e683d56072e7405af2f38a50fe76832224
f152df2ae73039d1e0cee074ff03518719ddd882
[ "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java", "chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ConfigServiceTest.java" ]
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java index eb179c20b..1593d802e 100644 --- a/chat2db-server/chat2db-server-start/src/test/java/ai/...
true
OtterMind/Chat2DB
1,450
issue_to_patch
Some typos and unit tests.
Unit tests for two classes: ChartServiceImpl and ConfigServiceImpl
debbf3ab829c45f5a6e97ce2afd433238040984d
820e2d51861a02b8460e2f0cac357e0d609c5714
diff --git a/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/service/ChartService.java b/chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/service/ChartService.java index dd579e0c7..d8d0956ea 100644 --- a/c...
[ "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/service/ChartService.java", "chat2db-server/chat2db-server-domain/chat2db-server-domain-core/src/main/java/ai/chat2db/server/domain/core/util/PermissionUtils.java", "chat2db-server/chat2db-server-domain/ch...
[]
diff --git a/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java b/chat2db-server/chat2db-server-start/src/test/java/ai/chat2db/server/start/test/core/ChartServiceTest.java new file mode 100644 index 000000000..eb179c20b --- /dev/null +++ b/chat2db-server/chat2db-se...
true
OtterMind/Chat2DB
1,436
issue_to_patch
fix-exportTableData
9421c3d3f4ffb84939149ea36e8346e80204c84e
2bfbbaeb87f54a1e758989317660da18e51f70f0
diff --git a/chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseDBManage.java b/chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseDBManage.java index 745ab65e6..d05b760b2 100644 --- a/chat2db-server/chat2db-plugins/...
[ "chat2db-server/chat2db-plugins/chat2db-clickhouse/src/main/java/ai/chat2db/plugin/clickhouse/ClickHouseDBManage.java", "chat2db-server/chat2db-plugins/chat2db-db2/src/main/java/ai/chat2db/plugin/db2/DB2DBManage.java", "chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMDBManage.java...
[]
true
OtterMind/Chat2DB
1,432
issue_to_patch
data export
b215bb67172e840d613afead7e10efe6057401e5
cd16555c45afb948e27663fba68e91935a05d21a
diff --git a/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java b/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java index 06a2ad37a..9a2ad6c7c 100644 --- a/chat2db-server/chat2db-plugins/chat2db-my...
[ "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java", "chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/enums/ExportFileSuffix.java", "chat2db-server/chat2db-server-domain/chat2db-server-domain-...
[]
true
OtterMind/Chat2DB
1,431
issue_to_patch
9c8fbf7f0afcc6a0ece408e02bbde4087da11477
2fcf18d0d94ae272a321feac78ac34b88290cb15
diff --git a/chat2db-server/chat2db-plugins/chat2db-postgresql/src/main/java/ai/chat2db/plugin/postgresql/PostgreSQLMetaData.java b/chat2db-server/chat2db-plugins/chat2db-postgresql/src/main/java/ai/chat2db/plugin/postgresql/PostgreSQLMetaData.java index 4a05533ab..6b2e719f2 100644 --- a/chat2db-server/chat2db-plugins/...
[ "chat2db-server/chat2db-plugins/chat2db-postgresql/src/main/java/ai/chat2db/plugin/postgresql/PostgreSQLMetaData.java" ]
[]
true
OtterMind/Chat2DB
1,404
issue_to_patch
SQLValueProcessor
cd58f82f393e1426c187afc3c52f7af2439f722d
5ac52afc80117179b31ff3141a73613244093852
diff --git a/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/MysqlMetaData.java b/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/MysqlMetaData.java index 50e7322f4..b241197db 100644 --- a/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai...
[ "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/MysqlMetaData.java", "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.java", "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/value/My...
[]
true
OtterMind/Chat2DB
1,423
issue_to_patch
fix(chat2db-dm): correct spelling of NUMERIC in DMColumnTypeEnum
c560f7ed0bac1b1c9cf1fa8ddfcc980e826ef851
153ea3aecbe1c43a3378ee6896232706e3e15d34
diff --git a/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/type/DMColumnTypeEnum.java b/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/type/DMColumnTypeEnum.java index ea9876c92..cd422fbde 100644 --- a/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/a...
[ "chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/type/DMColumnTypeEnum.java" ]
[]
true
OtterMind/Chat2DB
1,422
issue_to_patch
Dev
e12facebe846d12a7bd71e86eb520421c180a7c5
c560f7ed0bac1b1c9cf1fa8ddfcc980e826ef851
diff --git a/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMMetaData.java b/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMMetaData.java index ec0275c12..ccd5764f4 100644 --- a/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DM...
[ "chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMMetaData.java", "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/MysqlDBManage.java", "chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/builder/MysqlSqlBuilder.jav...
[]
true
OtterMind/Chat2DB
1,421
issue_to_patch
Fix dm ddl
4ea4c745f0d5a6692253c597386fbb73a7fe7715
4e1f21b461f8286206a8003e77bb1aa2986301f2
diff --git a/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMMetaData.java b/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMMetaData.java index ec0275c12..ccd5764f4 100644 --- a/chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DM...
[ "chat2db-server/chat2db-plugins/chat2db-dm/src/main/java/ai/chat2db/plugin/dm/DMMetaData.java" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,686
issue_to_patch
Rule class_reference_name_casing changes case of typed constants ### Problem description The rule `class_reference_name_casing` seem to apply names of typed class constants. ### Minimal reproducer CLI command `php-cs-fixer fix file.php --rules=class_reference_name_casing --diff --dry-run -vvv` ### Minimal reproduc...
fix: `ClassReferenceNameCasingFixer` - do not change case of typed class constant names
Fixes https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9685
cb89a76ec1eb23abb1a22e0d5a1aa0f97c3c0066
d5f685b9399f07917b065b77e584c27caf3ff895
diff --git a/src/Fixer/Casing/ClassReferenceNameCasingFixer.php b/src/Fixer/Casing/ClassReferenceNameCasingFixer.php index f58b9fdd5e6..ddc5b3819fb 100644 --- a/src/Fixer/Casing/ClassReferenceNameCasingFixer.php +++ b/src/Fixer/Casing/ClassReferenceNameCasingFixer.php @@ -136,7 +136,7 @@ private function getClassRefere...
[ "src/Fixer/Casing/ClassReferenceNameCasingFixer.php", "tests/Fixer/Casing/ClassReferenceNameCasingFixerTest.php" ]
[]
diff --git a/tests/Fixer/Casing/ClassReferenceNameCasingFixerTest.php b/tests/Fixer/Casing/ClassReferenceNameCasingFixerTest.php index 77e61ff1270..1c81b4c263d 100644 --- a/tests/Fixer/Casing/ClassReferenceNameCasingFixerTest.php +++ b/tests/Fixer/Casing/ClassReferenceNameCasingFixerTest.php @@ -134,6 +134,10 @@ public...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,678
issue_to_patch
UX: Cache - explicit deprecation for usage of non-handled objects in rules configuration, as they silently fail now; add support for JsonSerializable config values
8ea94f8f3f919d8b4dd57a65a97e835446640dc6
995faa338aea1d985f24196cdd1fed2ffc85e032
diff --git a/src/Cache/Signature.php b/src/Cache/Signature.php index 0b5871087db..a33efa13f29 100644 --- a/src/Cache/Signature.php +++ b/src/Cache/Signature.php @@ -14,6 +14,8 @@ namespace PhpCsFixer\Cache; +use PhpCsFixer\Future; + /** * @author Andreas Möller <am@localheinz.com> * @@ -100,9 +102,20 @@ publi...
[ "src/Cache/Signature.php" ]
[ { "comment": "```suggestion\n $item = get_class($item) . '#' . json_encode($item, \\JSON_THROW_ON_ERROR);\n```", "path": "src/Cache/Signature.php", "hunk": "@@ -100,9 +100,20 @@ public function equals(SignatureInterface $signature): bool\n */\n private static function makeJso...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,678
comment_to_fix
UX: Cache - explicit deprecation for usage of non-handled objects in rules configuration, as they silently fail now; add support for JsonSerializable config values
```suggestion $item = get_class($item) . '#' . json_encode($item, \JSON_THROW_ON_ERROR); ```
8ea94f8f3f919d8b4dd57a65a97e835446640dc6
995faa338aea1d985f24196cdd1fed2ffc85e032
diff --git a/src/Cache/Signature.php b/src/Cache/Signature.php index 0b5871087db..a33efa13f29 100644 --- a/src/Cache/Signature.php +++ b/src/Cache/Signature.php @@ -14,6 +14,8 @@ namespace PhpCsFixer\Cache; +use PhpCsFixer\Future; + /** * @author Andreas Möller <am@localheinz.com> * @@ -100,9 +102,20 @@ publi...
[ "src/Cache/Signature.php" ]
[ { "comment": "```suggestion\n $item = get_class($item) . '#' . json_encode($item, \\JSON_THROW_ON_ERROR);\n```", "path": "src/Cache/Signature.php", "hunk": "@@ -100,9 +100,20 @@ public function equals(SignatureInterface $signature): bool\n */\n private static function makeJso...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,684
issue_to_patch
fix: `PhpUnitAttributesFixer` - correctly handle `@requires` PHPUnit with space-separated version constraint
58877cae1880464031c868a96eaeee05c3e00cd6
866c5c5192fc2955d6088ab1613381daea3e57cf
diff --git a/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php b/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php index 88a897a4851..35eda13a4da 100644 --- a/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php +++ b/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php @@ -501,13 +501,13 @@ private static function fixRequires(Tokens $tokens, i...
[ "src/Fixer/PhpUnit/PhpUnitAttributesFixer.php", "tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php" ]
[]
diff --git a/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php b/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php index 0bc23bdfa2e..24d555d2e61 100644 --- a/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php +++ b/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php @@ -611,6 +611,12 @@ public function testBaz() { se...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,681
issue_to_patch
deps: bump codecov/codecov-action from 6 to 7 in /.github/workflows in the all group across 1 directory
Bumps the all group with 1 update in the /.github/workflows directory: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 6 to 7 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/co...
58877cae1880464031c868a96eaeee05c3e00cd6
b45ea757e11f0e83f289c499632c45cfcabc7b98
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0a589cddcaf..f71b3329909 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -306,7 +306,7 @@ jobs: - name: Upload coverage results to Codecov if: matrix.run-tests == 'yes' && matrix.collect-code-coverage == 'ye...
[ ".github/workflows/ci.yml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,682
issue_to_patch
chore: Docker - ignore root-user warning for pip
849f0e7046ee33fe60508e49a27fbfb90b17ae25
44e7508a46c3ae1235d67af5d8f583143b3fd189
diff --git a/Dockerfile b/Dockerfile index 23eaa630f2e..ef4c7cc5b34 100644 --- a/Dockerfile +++ b/Dockerfile @@ -4,7 +4,7 @@ ARG ALPINE_VERSION=3.24 FROM alpine:3.24 AS sphinx-lint RUN apk add python3 py3-pip git \ - && pip install --break-system-packages sphinx-lint + && PIP_ROOT_USER_ACTION=ignore pip insta...
[ "Dockerfile" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,683
issue_to_patch
deps: update dev-deps
849f0e7046ee33fe60508e49a27fbfb90b17ae25
482689c3751e94721413d50febeaa901dee085e7
diff --git a/composer.json b/composer.json index 5013a980f72..8525133479d 100644 --- a/composer.json +++ b/composer.json @@ -50,16 +50,16 @@ "require-dev": { "facile-it/paraunit": "^1.3.1 || ^2.11.0", "infection/infection": "^0.32.7", - "justinrainbow/json-schema": "^6.8.0", + "just...
[ "composer.json", "dev-tools/composer.json", "dev-tools/composer.lock", "dev-tools/install.sh" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,679
issue_to_patch
deps: bump alpine from 3.23 to 3.24 in the all group
Bumps the all group with 1 update: alpine. Updates `alpine` from 3.23 to 3.24 [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=alpine&package-manager=docker&previous-version=3.23&new-version=3.24)](https://docs.github.com/en/github/managing-securit...
8ea94f8f3f919d8b4dd57a65a97e835446640dc6
882f6e952135fb38a239127038e68a6738bccf50
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 05025e1dee2..286b2de3b86 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -24,13 +24,13 @@ jobs: - php-version: '8.1' alpine-version: '3.22' - php-version: '8.2' - ...
[ ".github/workflows/release.yml", "Dockerfile", "compose.yaml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,668
issue_to_patch
chore: narrow `Preg::match`/`Preg::matchAll` subject string type when match is truthy
requires https://github.com/phpstan/phpstan-src/pull/5777
a686bc3323b3f82a07d9cf8fbfd72f834555110c
a9b06dac4678d20108b70d7425bad87b840664e3
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index 878dbf4a012..d6cc2701467 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -9,7 +9,7 @@ "phpcompatibility/phpcompatibility-symfony": "^2-alpha1", "phpmd/phpmd": "dev-master as 2.16.0", "phpstan/extension-...
[ "dev-tools/composer.json", "dev-tools/composer.lock", "dev-tools/phpstan/baseline/_loader.php", "dev-tools/phpstan/baseline/argument.type.php", "dev-tools/phpstan/baseline/booleanNot.alwaysTrue.php", "dev-tools/phpstan/baseline/ternary.alwaysFalse.php", "dev-tools/phpstan/src/Extension/PregMatchTypeSpec...
[ { "comment": "these newly detected errors looks like false-positives to me and need to be investigated at phpstan-src end.\r\n\r\nI verified this will be fixed on 2.2.3", "path": "dev-tools/phpstan/baseline/ternary.alwaysFalse.php", "hunk": "@@ -0,0 +1,10 @@\n+<?php declare(strict_types = 1);\n+\n+$igno...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,677
issue_to_patch
deps: upgrade deep-deps for dev-tools
5580290f298bb35a32a41e6bac96f862e12ad205
8f65f01a38dd7f4c747299a7375918d4a0ab1a95
diff --git a/dev-tools/composer.lock b/dev-tools/composer.lock index 0d3a2fe4164..03c75bc0535 100644 --- a/dev-tools/composer.lock +++ b/dev-tools/composer.lock @@ -344,16 +344,16 @@ }, { "name": "justinrainbow/json-schema", - "version": "6.8.2", + "version": "6.9.0"...
[ "dev-tools/composer.lock" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,661
issue_to_patch
deps: bump shipmonk/dead-code-detector from 1.1.3 to 1.2.0 in /dev-tools in the shipmonk group across 1 directory
Bumps the shipmonk group with 1 update in the /dev-tools directory: [shipmonk/dead-code-detector](https://github.com/shipmonk-rnd/dead-code-detector). Updates `shipmonk/dead-code-detector` from 1.1.3 to 1.2.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/shipmonk-rnd/dead-c...
efdc283e480c55840e118f1f168b9654f6670a0e
718b0537954876960328fe8386b2ce796affd44d
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index 942f907991b..878dbf4a012 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -15,7 +15,7 @@ "phpstan/phpstan-strict-rules": "^2.0.11", "phpstan/phpstan-symfony": "^2.0.19", "shipmonk/composer-dependency-ana...
[ "dev-tools/composer.json", "dev-tools/composer.lock" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,670
issue_to_patch
refactor: `simplified_if_return` - applyFix to use slices for token insertion
Batching these inserts cuts the execution time by half. Was 4s. Now 2s.
f09b8848ea4e4073de474d2bdeb3c0a24a37ffd8
deb88953e4f5b31f4bdcda8afb4cba112967266d
diff --git a/src/Fixer/ControlStructure/SimplifiedIfReturnFixer.php b/src/Fixer/ControlStructure/SimplifiedIfReturnFixer.php index d0d0e1bbc73..57c28f21392 100644 --- a/src/Fixer/ControlStructure/SimplifiedIfReturnFixer.php +++ b/src/Fixer/ControlStructure/SimplifiedIfReturnFixer.php @@ -90,6 +90,8 @@ public function i...
[ "src/Fixer/ControlStructure/SimplifiedIfReturnFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,675
issue_to_patch
chore: fix typo in comment about fixer configuration
6226794470bb2c243f5c863666b674d8b75dc282
6bfd215aa8daf1563c42efa12ffd75a9a02ab429
[ "tests/Test/AbstractFixerTestCase.php" ]
[]
diff --git a/tests/Test/AbstractFixerTestCase.php b/tests/Test/AbstractFixerTestCase.php index b346c00d565..f25b05749f7 100644 --- a/tests/Test/AbstractFixerTestCase.php +++ b/tests/Test/AbstractFixerTestCase.php @@ -189,7 +189,7 @@ final public function testFixerDefinitions(): void } if ($t...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,598
issue_to_patch
StaticPrivateMethodFixer fails with private constructor and abstract static method ### Problem description I have an error when trying to format a file with a certain set of rules, which throws this type error: ``` [TypeError] ...
fix: `StaticPrivateMethodFixer` - fix for private constructor and abstract static method
Fixes https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9568
880b49daa939428cf4298756cafd5181c1a70311
4a49abf066db0de12bf5ab84e7fda206eba922a2
diff --git a/src/Fixer/ClassNotation/StaticPrivateMethodFixer.php b/src/Fixer/ClassNotation/StaticPrivateMethodFixer.php index 943d4fb02f4..176f63bae36 100644 --- a/src/Fixer/ClassNotation/StaticPrivateMethodFixer.php +++ b/src/Fixer/ClassNotation/StaticPrivateMethodFixer.php @@ -251,11 +251,12 @@ private function fixR...
[ "src/Fixer/ClassNotation/StaticPrivateMethodFixer.php", "tests/Fixer/ClassNotation/StaticPrivateMethodFixerTest.php" ]
[]
diff --git a/tests/Fixer/ClassNotation/StaticPrivateMethodFixerTest.php b/tests/Fixer/ClassNotation/StaticPrivateMethodFixerTest.php index 1065d783618..1aad514de1e 100644 --- a/tests/Fixer/ClassNotation/StaticPrivateMethodFixerTest.php +++ b/tests/Fixer/ClassNotation/StaticPrivateMethodFixerTest.php @@ -539,6 +539,18 @...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,634
issue_to_patch
`phpdoc_add_missing_param_annotation` includes attribute tokens in the `@param` type for promoted constructor properties ### Problem description When a promoted constructor property carries a PHP attribute (e.g. a validation constraint), `phpdoc_add_missing_param_annotation` with `only_untyped: false` generates a `@p...
fix: `PhpdocAddMissingParamAnnotationFixer` - skip attribute tokens when extracting parameter type
Attributes on parameters (e.g. on promoted constructor properties) leaked into the generated `@param` type, producing invalid PHPDoc like `@param #[Assert\NotBlank]string $x`. fixes #9633
9a38a9046893ff8ed61205734c94ca66f8c1ef5a
84c5f6b57d21f516ae159d88c366513d8012188c
diff --git a/src/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixer.php b/src/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixer.php index 6131598bf06..a826dc6664d 100644 --- a/src/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixer.php +++ b/src/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixer.php @@ -254,6 +254,12 @@ pr...
[ "src/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixer.php", "tests/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixerTest.php" ]
[]
diff --git a/tests/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixerTest.php b/tests/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixerTest.php index eb8e22335c6..6e26c474ebe 100644 --- a/tests/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixerTest.php +++ b/tests/Fixer/Phpdoc/PhpdocAddMissingParamAnnotationFixerTest.php...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,663
issue_to_patch
deps: Allow installation of `sebastian/diff:^9.0`
This pull request - [x] allows installation of `sebastian/diff:^9.0` Follows #9664.
d6c030462730541644c9c3a08a5cd9b5e28d6e91
fa2cfd62c01752f04cc098349656d34e291a096c
diff --git a/composer.json b/composer.json index c080b280a2c..5013a980f72 100644 --- a/composer.json +++ b/composer.json @@ -34,7 +34,7 @@ "react/event-loop": "^1.5", "react/socket": "^1.16", "react/stream": "^1.4", - "sebastian/diff": "^4.0.6 || ^5.1.1 || ^6.0.2 || ^7.0 || ^8.0", + ...
[ "composer.json" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,658
issue_to_patch
fix: Use `AgentDetector` to detect presence of AI agent only when `@auto` format has been selected
This pull request - [x] uses `AgentDetector` to detect the presence of AI agent only when `@auto` format has been selected Related to #9655.
32998042b4d1dff9fdedcd2c15048eb87d566486
69230e5696e27bd9f2d5a75b72463d183c461918
diff --git a/doc/usage.rst b/doc/usage.rst index 2ecef5980f3..84c711fef84 100644 --- a/doc/usage.rst +++ b/doc/usage.rst @@ -62,11 +62,12 @@ The ``--format`` option for the output format. Supported formats are ``@auto`` ( * ``@auto`` aims to auto-select best reporter for given CI or local execution (resolution into ...
[ "doc/usage.rst", "src/Console/ConfigurationResolver.php", "tests/Console/ConfigurationResolverTest.php" ]
[ { "comment": "while wondering to move this logic behind `@auto` was coming from me, let's give some time for discussion before concluding. maybe we come up with even better idea.", "path": "src/Console/ConfigurationResolver.php", "hunk": "@@ -689,11 +680,21 @@ private function resolveFormat(): string\n ...
diff --git a/tests/Console/ConfigurationResolverTest.php b/tests/Console/ConfigurationResolverTest.php index 7dfa6f23ea1..513679beaf4 100644 --- a/tests/Console/ConfigurationResolverTest.php +++ b/tests/Console/ConfigurationResolverTest.php @@ -1525,7 +1525,7 @@ public static function provideGetReporterCases(): iterabl...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,658
comment_to_fix
fix: Use `AgentDetector` to detect presence of AI agent only when `@auto` format has been selected
```suggestion * best fit for the AI agent (currently: ``json``) when running in an AI agent (for example, when the ``AI_AGENT`` environment variable, or another popular one, is set), unless running in GitLab CI ```
32998042b4d1dff9fdedcd2c15048eb87d566486
69230e5696e27bd9f2d5a75b72463d183c461918
diff --git a/doc/usage.rst b/doc/usage.rst index 2ecef5980f3..84c711fef84 100644 --- a/doc/usage.rst +++ b/doc/usage.rst @@ -62,11 +62,12 @@ The ``--format`` option for the output format. Supported formats are ``@auto`` ( * ``@auto`` aims to auto-select best reporter for given CI or local execution (resolution into ...
[ "doc/usage.rst" ]
[ { "comment": "```suggestion\n * best fit for the AI agent (currently: ``json``) when running in an AI agent (for example, when the ``AI_AGENT`` environment variable, or another popular one, is set), unless running in GitLab CI\n```", "path": "doc/usage.rst", "hunk": "@@ -62,11 +62,12 @@ The ``--format`...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,659
issue_to_patch
chore: please markdown-lint
8de45b8fc86bb96b24e206be7d0373c13f3dd118
8035304a29f483135559e88018d9b9711b2feae3
diff --git a/CHANGELOG.md b/CHANGELOG.md index a30e381a41d..4f379be5e45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -65,7 +65,7 @@ Changelog for v3.95.2 * chore: cleanup `OrderedImportsFixer` (#9603) * chore: cleanup `PhpdocSingleLineVarSpacingFixer` (#9591) * chore: cleanup `PhpdocToReturnTypeFixer` (#9558) -* ...
[ "CHANGELOG.md" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,671
issue_to_patch
chore: cleanup `GroupImportFixer`
2c5752e067097d645837dc6fd7d4d5d4d352b433
5ac2738fe3afd5543fe6a1f287a8f2cc25e79371
diff --git a/dev-tools/phpstan/baseline/offsetAccess.notFound.php b/dev-tools/phpstan/baseline/offsetAccess.notFound.php index 72abe83a45b..8b1b96069c6 100644 --- a/dev-tools/phpstan/baseline/offsetAccess.notFound.php +++ b/dev-tools/phpstan/baseline/offsetAccess.notFound.php @@ -61,11 +61,6 @@ 'count' => 1, ...
[ "dev-tools/phpstan/baseline/offsetAccess.notFound.php", "src/Fixer/Import/GroupImportFixer.php", "tests/Fixer/Import/GroupImportFixerTest.php" ]
[]
diff --git a/tests/Fixer/Import/GroupImportFixerTest.php b/tests/Fixer/Import/GroupImportFixerTest.php index 6f39d9ee1e6..88f7a4bdc4a 100644 --- a/tests/Fixer/Import/GroupImportFixerTest.php +++ b/tests/Fixer/Import/GroupImportFixerTest.php @@ -14,6 +14,7 @@ namespace PhpCsFixer\Tests\Fixer\Import; +use PhpCsFixer...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,667
issue_to_patch
chore: Cleanup `assert()` and add more precise `Preg::matchAll()` return type
61a53c9e76c91dacdad416028228e83b1bebbc4b
f3e406fcdbb27d0176fa3bdb5b0f0ad5195c81a9
diff --git a/src/Console/Command/SelfUpdateCommand.php b/src/Console/Command/SelfUpdateCommand.php index 885f5184c2f..3e71cbbd6f6 100644 --- a/src/Console/Command/SelfUpdateCommand.php +++ b/src/Console/Command/SelfUpdateCommand.php @@ -101,11 +101,14 @@ protected function execute(InputInterface $input, OutputInterface...
[ "src/Console/Command/SelfUpdateCommand.php", "src/Preg.php" ]
[ { "comment": "when using `Preg::match` and checking its return type properly, PHPStan can infer the `$matches` types statically, and we don't need manual `asserts` like `\\assert(isset($matches['major']))`", "path": "src/Console/Command/SelfUpdateCommand.php", "hunk": "@@ -101,11 +101,14 @@ protected fu...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,666
issue_to_patch
chore: use more `assert` calls
e75672cdcd09ca68d740de63c9aa6369777f3780
49551543d2b90ba50ec045c9c449478c38338139
diff --git a/dev-tools/phpstan/baseline/argument.type.php b/dev-tools/phpstan/baseline/argument.type.php index e26bc35020e..a0ac0d52404 100644 --- a/dev-tools/phpstan/baseline/argument.type.php +++ b/dev-tools/phpstan/baseline/argument.type.php @@ -16,26 +16,6 @@ 'count' => 1, 'path' => __DIR__ . '/../../../s...
[ "dev-tools/phpstan/baseline/argument.type.php", "dev-tools/phpstan/baseline/offsetAccess.notFound.php", "dev-tools/phpstan/baseline/return.type.php", "src/AbstractFunctionReferenceFixer.php", "src/Console/Command/DescribeCommand.php", "src/Console/Command/SelfUpdateCommand.php", "src/Console/SelfUpdate/...
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,665
issue_to_patch
chore: improve `TypeExpression`
a0e8646d3c2c5acb7870470936895bfcc8eef4d8
1b4354e54aaa0f6dcf59ed645ed43f63b5fe9487
diff --git a/dev-tools/phpstan/baseline/offsetAccess.notFound.php b/dev-tools/phpstan/baseline/offsetAccess.notFound.php index 309456e1d12..b6cdf846156 100644 --- a/dev-tools/phpstan/baseline/offsetAccess.notFound.php +++ b/dev-tools/phpstan/baseline/offsetAccess.notFound.php @@ -61,216 +61,6 @@ 'count' => 1, ...
[ "dev-tools/phpstan/baseline/offsetAccess.notFound.php", "src/DocBlock/TypeExpression.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,662
issue_to_patch
deps: bump crate-ci/typos from 1.47.0 to 1.47.2 in /.github/workflows in the all group across 1 directory
Bumps the all group with 1 update in the /.github/workflows directory: [crate-ci/typos](https://github.com/crate-ci/typos). Updates `crate-ci/typos` from 1.47.0 to 1.47.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</...
9d3553d12e2b4e7c7bf61bc3cc379206867a373a
aa59d3eef98feb2b76ac8a6d0a053acd28b00db3
diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml index a4ad42c0d19..ce6f2616c0f 100644 --- a/.github/workflows/spelling.yml +++ b/.github/workflows/spelling.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@v6 - name: Check typos - uses: crate-ci/typos@v1.47.0 + ...
[ ".github/workflows/spelling.yml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,664
issue_to_patch
fix: Add support for `phpunit/phpunit:^13.2` in `PhpUnitTestCaseStaticMethodCallsFixer`
This pull request - [x] adds support for `phpunit/phpunit:^13.2` in `PhpUnitTestCaseStaticMethodCallsFixer` ❗️ Blocks #9663.
8ae2eef25162df9abb52178fabc34e2f21c1d30b
bbcb5421bc64faf924b15205a46fed1c5156a35b
diff --git a/src/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixer.php b/src/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixer.php index 34bbf18d751..19d4e80684e 100644 --- a/src/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixer.php +++ b/src/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixer.php @@ -171,6 +171,...
[ "src/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
5,915
issue_to_patch
Consider renaming `new_with_braces` to `new_with_parentheses` ## Feature request Following the merge of #7284, I wondered whether it would make sense to rename the `new_with_braces` fixer to `new_with_parentheses`: - brackets: `[`, `]` - braces: `{`, `}` - parentheses: `(`, `)` Also see https://practicaltyp...
docs/refactor: clarify bracket types naming
if we decide to go that path, we need to update some namings too, eg `new_with_braces`
43e87d460424ad8b94eb11ee2450894ec9a03e5c
0d13630242b683c46ba5b044850101035c3162e4
diff --git a/doc/nomenclature.rst b/doc/nomenclature.rst new file mode 100644 index 00000000000..06d930c4777 --- /dev/null +++ b/doc/nomenclature.rst @@ -0,0 +1,16 @@ +============ +Nomenclature +============ + +Brackets +-------- + +ref https://en.wikipedia.org/wiki/Bracket + ++------------+-------------+----------+--...
[ "doc/nomenclature.rst", "src/AbstractFunctionReferenceFixer.php", "src/AbstractNoUselessElseFixer.php", "src/Fixer/AbstractPhpUnitFixer.php", "src/Fixer/AbstractShortOperatorFixer.php", "src/Fixer/Alias/ArrayPushFixer.php", "src/Fixer/Alias/MbStrFunctionsFixer.php", "src/Fixer/Alias/ModernizeStrposFix...
[ { "comment": "would it make sense for you, @localheinz @julienfalque @kubawerlos @SpacePossum ?\r\ni see that sometimes we mix braces/brackets/parentheses, maybe it's worth to unify?", "path": "doc/nomenclature.rst", "hunk": "@@ -0,0 +1,12 @@\n+============\n+Nomenclature\n+============\n+\n+Brackets", ...
diff --git a/tests/AutoReview/ProjectCodeTest.php b/tests/AutoReview/ProjectCodeTest.php index 259905264d7..5002a02cbb6 100644 --- a/tests/AutoReview/ProjectCodeTest.php +++ b/tests/AutoReview/ProjectCodeTest.php @@ -225,7 +225,7 @@ public function testThatSrcClassesAreReadonlyWhenPossible(string $className): vo ...
true
PHP-CS-Fixer/PHP-CS-Fixer
5,915
comment_to_fix
docs/refactor: clarify bracket types naming
```suggestion /** @deprecated use BLOCK_TYPE_PARENTHESIS, will be removed in 4.0 */ ```
43e87d460424ad8b94eb11ee2450894ec9a03e5c
0d13630242b683c46ba5b044850101035c3162e4
diff --git a/src/Tokenizer/Tokens.php b/src/Tokenizer/Tokens.php index 173892f9ec9..33ac9767b11 100644 --- a/src/Tokenizer/Tokens.php +++ b/src/Tokenizer/Tokens.php @@ -53,20 +53,50 @@ */ class Tokens extends \SplFixedArray { - public const BLOCK_TYPE_PARENTHESIS_BRACE = 1; - public const BLOCK_TYPE_CURLY_BRA...
[ "src/Tokenizer/Tokens.php" ]
[ { "comment": "```suggestion\r\n /** @deprecated use BLOCK_TYPE_PARENTHESIS, will be removed in 4.0 */\r\n```", "path": "src/Tokenizer/Tokens.php", "hunk": "@@ -31,16 +31,28 @@\n */\n class Tokens extends \\SplFixedArray\n {\n+ /** @deprecated use BLOCK_TYPE_PARENTHESIS_BRACE, will be removed in 4...
true
PHP-CS-Fixer/PHP-CS-Fixer
5,915
comment_to_fix
docs/refactor: clarify bracket types naming
i think just calling square brackets, brackets will be confusing
43e87d460424ad8b94eb11ee2450894ec9a03e5c
0d13630242b683c46ba5b044850101035c3162e4
diff --git a/doc/nomenclature.rst b/doc/nomenclature.rst new file mode 100644 index 00000000000..06d930c4777 --- /dev/null +++ b/doc/nomenclature.rst @@ -0,0 +1,16 @@ +============ +Nomenclature +============ + +Brackets +-------- + +ref https://en.wikipedia.org/wiki/Bracket + ++------------+-------------+----------+--...
[ "doc/nomenclature.rst" ]
[ { "comment": "i think just calling square brackets, brackets will be confusing", "path": "doc/nomenclature.rst", "hunk": "@@ -0,0 +1,14 @@\n+============\n+Nomenclature\n+============\n+\n+Brackets\n+--------\n+\n+ref https://en.wikipedia.org/wiki/Bracket\n+\n++-------------+----------+--------+\n+| ( )...
true
PHP-CS-Fixer/PHP-CS-Fixer
5,915
comment_to_fix
docs/refactor: clarify bracket types naming
@keradus what about custom tokens? Some of them could possibly be renamed just like block types (like `CT::T_ARRAY_INDEX_BRACE_[OPEN|CLOSE]`), but some are the missing pieces of built-in tokens (like `CT::T_CURLY_CLOSE`, where `T_CURLY_OPEN` is a native one), and it would lead to inconsistency 🤔. And what about tok...
43e87d460424ad8b94eb11ee2450894ec9a03e5c
0d13630242b683c46ba5b044850101035c3162e4
diff --git a/src/Tokenizer/Tokens.php b/src/Tokenizer/Tokens.php index 173892f9ec9..33ac9767b11 100644 --- a/src/Tokenizer/Tokens.php +++ b/src/Tokenizer/Tokens.php @@ -53,20 +53,50 @@ */ class Tokens extends \SplFixedArray { - public const BLOCK_TYPE_PARENTHESIS_BRACE = 1; - public const BLOCK_TYPE_CURLY_BRA...
[ "src/Tokenizer/Tokens.php" ]
[ { "comment": "@keradus what about custom tokens? Some of them could possibly be renamed just like block types (like `CT::T_ARRAY_INDEX_BRACE_[OPEN|CLOSE]`), but some are the missing pieces of built-in tokens (like `CT::T_CURLY_CLOSE`, where `T_CURLY_OPEN` is a native one), and it would lead to inconsistency 🤔....
true
PHP-CS-Fixer/PHP-CS-Fixer
9,656
issue_to_patch
fix: Address credential exposure concern related to using `ergebnis/agent-detector` for detecting the presence of an AI agent
This pull request - [x] addresses the credential exposure concern related to using `ergebnis/agent-detector` for detecting the presence of an AI agent Related to #9655.
43e87d460424ad8b94eb11ee2450894ec9a03e5c
4669ce0d5e0644023a3f4887ff3c8ad9a8f6df95
diff --git a/src/Console/ConfigurationResolver.php b/src/Console/ConfigurationResolver.php index 4bc5d276ca1..96d6a49f21a 100644 --- a/src/Console/ConfigurationResolver.php +++ b/src/Console/ConfigurationResolver.php @@ -673,7 +673,7 @@ private function resolveFormat(): string $agentDetector = new AgentDet...
[ "src/Console/ConfigurationResolver.php" ]
[ { "comment": "i see some improvement and no harm, so let's merge.\n\nwondering if this logic can be behind agentDetector, to auto-discover presence of env key instead of expecting it from outside", "path": "src/Console/ConfigurationResolver.php", "hunk": "@@ -673,7 +673,7 @@ private function resolveForm...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,653
issue_to_patch
deps: minor upgrades of dev-tools
43a55d37d8cb0f7351ee9fb1bb86382f764d126e
93267173fa7e33632c591d7e86fd2b493f9e562e
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index aadb878ab97..942f907991b 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -13,9 +13,9 @@ "phpstan/phpstan-deprecation-rules": "^2.0.4", "phpstan/phpstan-phpunit": "^2.0.16", "phpstan/phpstan-strict-rules...
[ "dev-tools/composer.json", "dev-tools/composer.lock" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,651
issue_to_patch
chore: minor updates around PHPStan
572faf80107917b79db9a5c5df81414583265246
a2c3ee9e5769d476bb87cd04486ec12b9d35e949
diff --git a/src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php b/src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php index bed6e8f4be8..86402a61dfd 100644 --- a/src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php +++ b/src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php @@ -207,7 +207,7 @@ public ...
[ "src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php", "src/Tokenizer/Token.php", "tests/Tokenizer/TokenTest.php", "tests/Tokenizer/TokensTest.php" ]
[]
diff --git a/tests/Tokenizer/TokenTest.php b/tests/Tokenizer/TokenTest.php index 50fc8af8a95..9cb5cf20606 100644 --- a/tests/Tokenizer/TokenTest.php +++ b/tests/Tokenizer/TokenTest.php @@ -426,18 +426,18 @@ public function testEqualsDefaultIsCaseSensitive(): void } /** - * @param _PhpTokenPrototypeParti...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,644
issue_to_patch
chore: improve `ControlCaseStructuresAnalyzer`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
cbd2c1c5afc75a1c35f7055d10969ed53eee197b
46cc72af8de5676566878f8978c965d261ec8fd3
diff --git a/dev-tools/phpstan/baseline/argument.type.php b/dev-tools/phpstan/baseline/argument.type.php index a54a707577d..e62c4bb6d43 100644 --- a/dev-tools/phpstan/baseline/argument.type.php +++ b/dev-tools/phpstan/baseline/argument.type.php @@ -111,11 +111,6 @@ 'count' => 1, 'path' => __DIR__ . '/../../.....
[ "dev-tools/phpstan/baseline/argument.type.php", "dev-tools/phpstan/baseline/offsetAccess.notFound.php", "src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php" ]
[ { "comment": "not sure -> https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9651/changes/b82a7d2f2def8a273257ce54e8de016802710ff2 in #9651 ", "path": "src/Tokenizer/Analyzer/ControlCaseStructuresAnalyzer.php", "hunk": "@@ -195,12 +207,14 @@ public static function findControlStructures(Tokens $tokens, ar...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,635
issue_to_patch
deps: bump PHPStan to 2.2.1
| |number of errors| |---|--:| |initial|197| |after [test: improve data providers return types](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9642)|124| |after [chore: improve `ArrayIndentationFixer`](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9643)|111| |after [chore: improve `ControlCaseStructuresAn...
37075462019e293450009ae4ed8ddd33fb78c060
f21bc984baa628248e50fa17f611cafa8fb449e6
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index fb06722cb1c..aadb878ab97 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -9,7 +9,7 @@ "phpcompatibility/phpcompatibility-symfony": "^2-alpha1", "phpmd/phpmd": "dev-master as 2.16.0", "phpstan/extension-...
[ "dev-tools/composer.json", "dev-tools/composer.lock", "tests/AbstractDoctrineAnnotationFixerTestCase.php", "tests/Fixer/Alias/ModernizeStrposFixerTest.php", "tests/Fixer/Alias/NoMixedEchoPrintFixerTest.php", "tests/Fixer/Alias/RandomApiMigrationFixerTest.php", "tests/Fixer/ArrayNotation/ArraySyntaxFixer...
[]
diff --git a/tests/AbstractDoctrineAnnotationFixerTestCase.php b/tests/AbstractDoctrineAnnotationFixerTestCase.php index c80aefe363a..0d5cf16345f 100644 --- a/tests/AbstractDoctrineAnnotationFixerTestCase.php +++ b/tests/AbstractDoctrineAnnotationFixerTestCase.php @@ -41,7 +41,7 @@ public function testConfigureWithInva...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,642
issue_to_patch
test: improve data providers return types
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
745f4e50259ff2b1b47e1f871101b5cf3b4d55cf
0ec49c66259be2441fedb5402fe482afd80bd38f
[ "tests/AutoReview/DescribeCommandTest.php", "tests/Fixer/Basic/NumericLiteralSeparatorFixerTest.php", "tests/Fixer/Casing/MagicConstantCasingFixerTest.php", "tests/Fixer/CastNotation/CastSpacesFixerTest.php", "tests/Fixer/CastNotation/ShortScalarCastFixerTest.php", "tests/Fixer/ClassNotation/ClassDefiniti...
[]
diff --git a/tests/AutoReview/DescribeCommandTest.php b/tests/AutoReview/DescribeCommandTest.php index 0ca790205ca..620e2c6566b 100644 --- a/tests/AutoReview/DescribeCommandTest.php +++ b/tests/AutoReview/DescribeCommandTest.php @@ -99,7 +99,7 @@ public function testDescribeCommand(string $fixerName, ?array $successors...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,643
issue_to_patch
chore: improve `ArrayIndentationFixer`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
623415bae02b41c0df4d1d2f0ad69719f96479a9
65d94eaccf980b7cb67dd6e626e750e7c77bb77f
diff --git a/dev-tools/phpstan/baseline/argument.type.php b/dev-tools/phpstan/baseline/argument.type.php index 3f00e070038..a54a707577d 100644 --- a/dev-tools/phpstan/baseline/argument.type.php +++ b/dev-tools/phpstan/baseline/argument.type.php @@ -101,16 +101,6 @@ 'count' => 1, 'path' => __DIR__ . '/../../.....
[ "dev-tools/phpstan/baseline/argument.type.php", "dev-tools/phpstan/baseline/offsetAccess.notFound.php", "src/Fixer/Whitespace/ArrayIndentationFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,645
issue_to_patch
chore: improve `ClassDefinitionFixer`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
5a9903ce9d794e54a40e737dbf31d49e9a3ca982
2cefe79709e9b7a6ffac5d3a6de02eba5b808fe7
diff --git a/src/Fixer/ClassNotation/ClassDefinitionFixer.php b/src/Fixer/ClassNotation/ClassDefinitionFixer.php index b4d30fb2e71..2c7b7306d81 100644 --- a/src/Fixer/ClassNotation/ClassDefinitionFixer.php +++ b/src/Fixer/ClassNotation/ClassDefinitionFixer.php @@ -535,11 +535,7 @@ private function makeClassyInheritance...
[ "src/Fixer/ClassNotation/ClassDefinitionFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,646
issue_to_patch
chore: improve `NoSuperfluousPhpdocTagsFixer`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
a2c3a4317bee5041abf0e5cc49cea87f98e9319a
dc902047cab547e446c7f02dea28db096a7acf5f
diff --git a/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php b/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php index 2056cb09c43..2a949ea609a 100644 --- a/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php +++ b/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php @@ -356,9 +356,9 @@ private function findDocumentedElem...
[ "src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,649
issue_to_patch
chore: improve `PhpUnitTestCaseStaticMethodCallsFixer`
a46940c98284d5db8b9af14ce9896788e9bc4e42
dd35071366f6b24f25f16c31bdddbbe1392b136c
diff --git a/dev-tools/phpstan/baseline/offsetAccess.notFound.php b/dev-tools/phpstan/baseline/offsetAccess.notFound.php index 4074aa6eca0..309456e1d12 100644 --- a/dev-tools/phpstan/baseline/offsetAccess.notFound.php +++ b/dev-tools/phpstan/baseline/offsetAccess.notFound.php @@ -516,16 +516,6 @@ 'count' => 1, ...
[ "dev-tools/phpstan/baseline/offsetAccess.notFound.php", "src/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,648
issue_to_patch
chore: improve `WorkerException`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
67a6eea5dc5416e80400240c889eb543fa86ae72
8ed1a82438fe7099311b29bcbffcca22af834085
diff --git a/src/Runner/Parallel/WorkerException.php b/src/Runner/Parallel/WorkerException.php index afd56122ab2..4b88e682a9a 100644 --- a/src/Runner/Parallel/WorkerException.php +++ b/src/Runner/Parallel/WorkerException.php @@ -37,7 +37,8 @@ private function __construct(string $message, int $code) * file: st...
[ "src/Runner/Parallel/WorkerException.php" ]
[ { "comment": "tbh, most of those recent chores could be a single PR ;) ", "path": "src/Runner/Parallel/WorkerException.php", "hunk": "@@ -37,7 +37,8 @@ private function __construct(string $message, int $code)\n * file: string,\n * line: int,\n * code: int,\n- * trace: ...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,650
issue_to_patch
chore: improve `Token`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
4b1c35df94c6626e329cbd04303532bcd763e3a8
e007c14c65a928b40b676d5789112d7916a8fc08
diff --git a/dev-tools/phpstan/baseline/argument.type.php b/dev-tools/phpstan/baseline/argument.type.php index e62c4bb6d43..e26bc35020e 100644 --- a/dev-tools/phpstan/baseline/argument.type.php +++ b/dev-tools/phpstan/baseline/argument.type.php @@ -351,11 +351,6 @@ 'count' => 1, 'path' => __DIR__ . '/../../.....
[ "dev-tools/phpstan/baseline/argument.type.php", "src/Tokenizer/Token.php", "tests/Tokenizer/TokenTest.php", "tests/Tokenizer/TokensTest.php" ]
[]
diff --git a/tests/Tokenizer/TokenTest.php b/tests/Tokenizer/TokenTest.php index 7a6a12c9efb..50fc8af8a95 100644 --- a/tests/Tokenizer/TokenTest.php +++ b/tests/Tokenizer/TokenTest.php @@ -426,18 +426,18 @@ public function testEqualsDefaultIsCaseSensitive(): void } /** - * @param _PhpTokenPrototypeParti...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,647
issue_to_patch
chore: improve `NoAliasFunctionsFixer`
Changes for https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/9635
35da246457670d1aef3c4d145f37fb79cf75853d
497a1e67e3d5ef01601fc610f93d28e38bff1dda
diff --git a/src/Fixer/Alias/NoAliasFunctionsFixer.php b/src/Fixer/Alias/NoAliasFunctionsFixer.php index 58824a9d6bd..9cde4c864df 100644 --- a/src/Fixer/Alias/NoAliasFunctionsFixer.php +++ b/src/Fixer/Alias/NoAliasFunctionsFixer.php @@ -248,7 +248,7 @@ protected function configurePostNormalisation(): void fo...
[ "src/Fixer/Alias/NoAliasFunctionsFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,639
issue_to_patch
deps: bump crate-ci/typos from 1.46.2 to 1.47.0 in /.github/workflows in the all group across 1 directory
Bumps the all group with 1 update in the /.github/workflows directory: [crate-ci/typos](https://github.com/crate-ci/typos). Updates `crate-ci/typos` from 1.46.2 to 1.47.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</...
47aaca6469b94f357ac0821d29254485df0bc420
82f32871659a7223e4744ede74dd7732f9f1716c
diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml index f662ed5fafa..a4ad42c0d19 100644 --- a/.github/workflows/spelling.yml +++ b/.github/workflows/spelling.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@v6 - name: Check typos - uses: crate-ci/typos@v1.46.2 + ...
[ ".github/workflows/spelling.yml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,636
issue_to_patch
CI: add generic phpstan/phpstan-deprecation-rules, so usage of old deprecated constants is detected
extracted from #5915
9a38a9046893ff8ed61205734c94ca66f8c1ef5a
ed957ef7e8d93d3ced40dff2ce1ddb2495cef483
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index ebe0b007da3..fb06722cb1c 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -10,6 +10,7 @@ "phpmd/phpmd": "dev-master as 2.16.0", "phpstan/extension-installer": "^1.4.3", "phpstan/phpstan": "^2.1.55", + ...
[ "dev-tools/composer.json", "dev-tools/composer.lock", "phpstan.dist.neon", "src/Error/SourceExceptionFactory.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,631
issue_to_patch
deps: bump crate-ci/typos from 1.46.1 to 1.46.2 in /.github/workflows in the all group across 1 directory
Bumps the all group with 1 update in the /.github/workflows directory: [crate-ci/typos](https://github.com/crate-ci/typos). Updates `crate-ci/typos` from 1.46.1 to 1.46.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</...
ebae9f6c223ba9cf82d2357fca1044a55eb9d0fc
90cc7514d3e37aa73a9c2ca5cc5fb51c49765f7f
diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml index bd2f39ce804..f662ed5fafa 100644 --- a/.github/workflows/spelling.yml +++ b/.github/workflows/spelling.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@v6 - name: Check typos - uses: crate-ci/typos@v1.46.1 + ...
[ ".github/workflows/spelling.yml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,446
issue_to_patch
refactor: `AttributeBlockNoSpacesFixer` - no need for loop when we already know bracket indices
as i was already around it #9445 best to review with hidden whitespaces
78212cb14be39789f857a7bc246b87a392bf7e6f
3057fcc1c55a5be7bff09737af7642a0d1e402c5
diff --git a/src/Fixer/AttributeNotation/AttributeBlockNoSpacesFixer.php b/src/Fixer/AttributeNotation/AttributeBlockNoSpacesFixer.php index 178bf0944ca..8c62b84cadc 100644 --- a/src/Fixer/AttributeNotation/AttributeBlockNoSpacesFixer.php +++ b/src/Fixer/AttributeNotation/AttributeBlockNoSpacesFixer.php @@ -64,43 +64,4...
[ "src/Fixer/AttributeNotation/AttributeBlockNoSpacesFixer.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,627
issue_to_patch
deps: bump ergebnis/composer-normalize from 2.51.0 to 2.52.0 in /dev-tools
Bumps [ergebnis/composer-normalize](https://github.com/ergebnis/composer-normalize) from 2.51.0 to 2.52.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ergebnis/composer-normalize/releases">ergebnis/composer-normalize's releases</a>.</em></p> <blockquote> <h2>2.52.0</h2> <!...
bdfe29e40250fdec77a719b7006056addc578211
513f6c1f93f78a6bb5bba211358048c782657f49
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index cfa734e9195..ebe0b007da3 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -2,7 +2,7 @@ "type": "project", "require": { "php": "^8.5", - "ergebnis/composer-normalize": "^2.51.0", + "ergebnis/compose...
[ "dev-tools/composer.json", "dev-tools/composer.lock" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,626
issue_to_patch
deps: bump the phpstan group in /dev-tools with 2 updates
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You ...
2af6d2cf630b46fe4d7b7565aa57130e9d4b6dce
96cb35da629080521dc1d183708786d0f294a5f0
diff --git a/dev-tools/composer.json b/dev-tools/composer.json index c9d46efcb6d..cfa734e9195 100644 --- a/dev-tools/composer.json +++ b/dev-tools/composer.json @@ -9,10 +9,10 @@ "phpcompatibility/phpcompatibility-symfony": "^2-alpha1", "phpmd/phpmd": "dev-master as 2.16.0", "phpstan/extensio...
[ "dev-tools/composer.json", "dev-tools/composer.lock", "dev-tools/phpstan/baseline/argument.type.php" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,628
issue_to_patch
CI: replace PHP `8.6snapshot` with `nightly` in matrix
c909a21f98a130940de91875126cb17b86fe497b
7993574e404149a546e73408958f253e3f1924e7
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 600fcedf62a..0a589cddcaf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -135,13 +135,13 @@ jobs: PHP_CS_FIXER_FAST_LINT_TEST_CASES: 0 # run full linting on highest supported PHP version to be sure that all cases...
[ ".github/workflows/ci.yml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,619
issue_to_patch
MultilinePromotedProperties breaks new in initializers ### Problem description Using this snippet: ```php // reproducer.php <?php declare(strict_types=1); namespace Reproducer; final class Foo {} final class Bar {} final class Reproducer { public function __construct(public readonly Foo $foo = new Foo(), pub...
fix: `MultilinePromotedPropertiesFixer` - fix for `new` in initializers
Fixes https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9618
f0f2d4eee321e4f93e6e7d9deccd6c236fbb08db
9352d4de68a1199a29dcbf38dd5c035ef768c713
diff --git a/src/Fixer/FunctionNotation/MultilinePromotedPropertiesFixer.php b/src/Fixer/FunctionNotation/MultilinePromotedPropertiesFixer.php index 311b624a7ea..55cc759c517 100644 --- a/src/Fixer/FunctionNotation/MultilinePromotedPropertiesFixer.php +++ b/src/Fixer/FunctionNotation/MultilinePromotedPropertiesFixer.php...
[ "src/Fixer/FunctionNotation/MultilinePromotedPropertiesFixer.php", "tests/Fixer/FunctionNotation/MultilinePromotedPropertiesFixerTest.php" ]
[]
diff --git a/tests/Fixer/FunctionNotation/MultilinePromotedPropertiesFixerTest.php b/tests/Fixer/FunctionNotation/MultilinePromotedPropertiesFixerTest.php index 4c5584423b8..58d735d712b 100644 --- a/tests/Fixer/FunctionNotation/MultilinePromotedPropertiesFixerTest.php +++ b/tests/Fixer/FunctionNotation/MultilinePromote...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,615
issue_to_patch
fix: `PhpdocLineSpanFixer` - run after `NoSuperfluousPhpdocTagsFixer`
## Summary When using `no_superfluous_phpdoc_tags` together with `phpdoc_line_span` (e.g. `{"method": "single"}`), the line-span fixer ran *before* superfluous tags were removed. So a multi-line PHPDoc that ended up with only one remaining tag after cleanup was never collapsed to single-line form. Example with `{"no_...
bb6a12ab9eedadf9b46979f1e2611274f16ec681
f0e38ab60dc8b89c48eec20ab2414bc99a986bad
diff --git a/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php b/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php index 45eb8245f3f..2056cb09c43 100644 --- a/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php +++ b/src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php @@ -176,8 +176,8 @@ public function doFoo(Bar $bar, $ba...
[ "src/Fixer/Phpdoc/NoSuperfluousPhpdocTagsFixer.php", "src/Fixer/Phpdoc/PhpdocLineSpanFixer.php", "tests/AutoReview/FixerFactoryTest.php", "tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span.test", "tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span_2...
[ { "comment": "can we still have a (separate) test for config test originally - `{\"phpdoc_line_span\": true, \"no_superfluous_phpdoc_tags\": true}` ?", "path": "tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span.test", "hunk": "@@ -0,0 +1,40 @@\n+--TEST--\n+Integration of fi...
diff --git a/tests/AutoReview/FixerFactoryTest.php b/tests/AutoReview/FixerFactoryTest.php index f2f7c427514..eb38250beff 100644 --- a/tests/AutoReview/FixerFactoryTest.php +++ b/tests/AutoReview/FixerFactoryTest.php @@ -678,6 +678,7 @@ private static function getFixersPriorityGraph(): array ], ...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,615
comment_to_fix
fix: `PhpdocLineSpanFixer` - run after `NoSuperfluousPhpdocTagsFixer`
can we still have a (separate) test for config test originally - `{"phpdoc_line_span": true, "no_superfluous_phpdoc_tags": true}` ?
bb6a12ab9eedadf9b46979f1e2611274f16ec681
f0e38ab60dc8b89c48eec20ab2414bc99a986bad
diff --git a/tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span.test b/tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span.test new file mode 100644 index 00000000000..fd5519effe1 --- /dev/null +++ b/tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,...
[ "tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span.test" ]
[ { "comment": "can we still have a (separate) test for config test originally - `{\"phpdoc_line_span\": true, \"no_superfluous_phpdoc_tags\": true}` ?", "path": "tests/Fixtures/Integration/priority/no_superfluous_phpdoc_tags,phpdoc_line_span.test", "hunk": "@@ -0,0 +1,40 @@\n+--TEST--\n+Integration of fi...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,621
issue_to_patch
deps: upgrade misc deps
072f462b72afcb1250a6d8dadc4595b3edb3b35a
2804583936a3c568a5eaf6200ea6bf37d9940197
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ef9496bc4b1..600fcedf62a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -220,14 +220,14 @@ jobs: - name: Install PHPUnit 12 if: matrix.run-tests == 'yes' && matrix.install-phpunit-12 == 'yes' run: | ...
[ ".github/workflows/ci.yml", "composer.json", "dev-tools/composer.json", "dev-tools/composer.lock" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,624
issue_to_patch
deps: bump crate-ci/typos from 1.46.0 to 1.46.1 in /.github/workflows in the all group across 1 directory
Bumps the all group with 1 update in the /.github/workflows directory: [crate-ci/typos](https://github.com/crate-ci/typos). Updates `crate-ci/typos` from 1.46.0 to 1.46.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</...
072f462b72afcb1250a6d8dadc4595b3edb3b35a
3fa69b5e10dc3a3c969ef6ae33434c6fdd782cb1
diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml index f7d9ddadc55..bd2f39ce804 100644 --- a/.github/workflows/spelling.yml +++ b/.github/workflows/spelling.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@v6 - name: Check typos - uses: crate-ci/typos@v1.46.0 + ...
[ ".github/workflows/spelling.yml" ]
[]
true
PHP-CS-Fixer/PHP-CS-Fixer
9,596
issue_to_patch
Parse error with PHP8.5 and closures as consts ### Problem description Hello, I noticed that php-cs-fixer is failing on two of my classes which use some php8.5 stuff. Snipped visible below. Config available at https://github.com/dualmediaspzoo/symfony-request-dto-bundle/blob/master/.php-cs-fixer.dist.php Happens a...
fix: `ModifierKeywordsFixer` - do not break PHP syntax for closures in constant expressions
Fixes https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9576
1d0183835ec6ce46f37e41863ef2140197d51b90
7834632006998447dd27d15c839df3f430abc96e
diff --git a/src/Tokenizer/TokensAnalyzer.php b/src/Tokenizer/TokensAnalyzer.php index ee3e501aebc..fb8ad0d2666 100644 --- a/src/Tokenizer/TokensAnalyzer.php +++ b/src/Tokenizer/TokensAnalyzer.php @@ -828,12 +828,15 @@ private function findClassyElements(int $classIndex, int $index): array } ...
[ "src/Tokenizer/TokensAnalyzer.php", "tests/Fixer/ClassNotation/ClassAttributesSeparationFixerTest.php", "tests/Fixer/ClassNotation/ModifierKeywordsFixerTest.php", "tests/Tokenizer/TokensAnalyzerTest.php" ]
[]
diff --git a/tests/Fixer/ClassNotation/ClassAttributesSeparationFixerTest.php b/tests/Fixer/ClassNotation/ClassAttributesSeparationFixerTest.php index ea5338606eb..626e7c82372 100644 --- a/tests/Fixer/ClassNotation/ClassAttributesSeparationFixerTest.php +++ b/tests/Fixer/ClassNotation/ClassAttributesSeparationFixerTest...
true
PHP-CS-Fixer/PHP-CS-Fixer
9,589
issue_to_patch
deps: update `facile-it/paraunit` to ^2.11
due to https://github.com/facile-it/paraunit/issues/380
7f68fc3d0a992a8534c2305997bd54bee31ea453
1fa2451c2643ef5cbd80d8b392ae28531864b78e
diff --git a/composer.json b/composer.json index 30eb1757033..38fb771903d 100644 --- a/composer.json +++ b/composer.json @@ -48,7 +48,7 @@ "symfony/stopwatch": "^5.4.45 || ^6.4.24 || ^7.0 || ^8.0" }, "require-dev": { - "facile-it/paraunit": "^1.3.1 || ^2.8.0", + "facile-it/paraunit": "^...
[ "composer.json" ]
[ { "comment": "hm @kubawerlos , maybe a comment why (in file).\nin 1 year, i will have no clue why we do this", "path": ".github/workflows/ci.yml", "hunk": "@@ -162,11 +162,13 @@ jobs:\n - operating-system: windows-latest\n php-version: ${{ needs.setup.outputs.PHP_MAX }}\n ...
true
PHPOffice/PhpSpreadsheet
4,913
issue_to_patch
Update Changelog
This is: - [ ] a bugfix - [ ] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [ ] Changes are covered by unit tests - [ ] Changes are covered by existing unit tests - [ ] New unit tests have been added - [ ] Code style is respected - [ ] Commit message explains **why** the c...
fd5f72edd76d0cfea2a8790c252f9f6b65268aa4
99b0d93026854d1160504cbb10bf9bdad568d957
diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a20ac200e..793174876c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a ### Added -- Nothing yet. +- Navigate Cell as Cursor. [Issue #863](https://github.com/PHPOffice/PhpSpre...
[ "CHANGELOG.md" ]
[]
true
PHPOffice/PhpSpreadsheet
4,912
issue_to_patch
Fatal Error in Writer/Html.php This is: ``` - [ ] a bug report ``` I have valid xls document which after opening and saving using HTML writer leads to Fatal Error: PHP Fatal error: Uncaught Error: Call to a member function getNumberFormat() on null in vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Writer...
Tighten Up Writer Html Logic
Fix #434, which went stale in 2018 and is now reopened. User reported a fatal error in Writer/Html. Regrettably, there is no example code/spreadsheet to illustrate the error. However, the area of code where the error happened is identified. Studying that, it was clear that the error could be avoided through the use of ...
fd5f72edd76d0cfea2a8790c252f9f6b65268aa4
db8917cd4b6f008c5b138ac2cc3e23369c8b96ee
diff --git a/src/PhpSpreadsheet/Writer/Html.php b/src/PhpSpreadsheet/Writer/Html.php index 3678cf67b7..fcb8a8ddb9 100644 --- a/src/PhpSpreadsheet/Writer/Html.php +++ b/src/PhpSpreadsheet/Writer/Html.php @@ -1595,7 +1595,13 @@ private function generateRowCellDataValue(Worksheet $worksheet, Cell $cell, stri ...
[ "src/PhpSpreadsheet/Writer/Html.php" ]
[]
true
PHPOffice/PhpSpreadsheet
4,911
issue_to_patch
PlotArea: Datatable ### This is: ``` - [ ] a bug report - [X] a feature request - [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet) ``` ### What is the expected behavior? Allow option to insert "Data Table" whic...
Chart DataTable
Fix #413, which went stale in 2018 and is now reopened. A DataTable can be used on a chart in place of a Legend (or in addition to one, but it doesn't really make sense to have both). The fix was substantially developed by @topaDev before the issue went stale. This PR provides basic support for reading and writing Data...
fd5f72edd76d0cfea2a8790c252f9f6b65268aa4
dbea64cb03300abdc236a0b9f4a779ec1a80c2f6
diff --git a/samples/Chart33a/33_Chart_create_area_3.php b/samples/Chart33a/33_Chart_create_area_3.php new file mode 100644 index 0000000000..5e5a3f802d --- /dev/null +++ b/samples/Chart33a/33_Chart_create_area_3.php @@ -0,0 +1,108 @@ +<?php + +use PhpOffice\PhpSpreadsheet\Chart\Chart; +use PhpOffice\PhpSpreadsheet\Cha...
[ "samples/Chart33a/33_Chart_create_area_3.php", "src/PhpSpreadsheet/Chart/DataTable.php", "src/PhpSpreadsheet/Chart/PlotArea.php", "src/PhpSpreadsheet/Reader/Xlsx/Chart.php", "src/PhpSpreadsheet/Writer/Xlsx/Chart.php", "tests/PhpSpreadsheetTests/Chart/DataTableTest.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Chart/DataTableTest.php b/tests/PhpSpreadsheetTests/Chart/DataTableTest.php new file mode 100644 index 0000000000..f9448a8662 --- /dev/null +++ b/tests/PhpSpreadsheetTests/Chart/DataTableTest.php @@ -0,0 +1,173 @@ +<?php + +declare(strict_types=1); + +namespace PhpOffice\PhpSpread...
true
PHPOffice/PhpSpreadsheet
4,910
issue_to_patch
Applying styles to multiple ranges with applyFromArray() throws Exception This is: ``` - [x] a bug report ``` ### What is the expected behavior? To be able to apply an array of styles to multiple ranges, like `A2:A4,K12:G20`. Since you are capable of selecting multiple ranges of cells with `getStyle()` from a...
Allow Use of Multiple Ranges When Setting Style
Fix #411, which went stale in 2018 and is now reopened. You can get a style for a set of cells which uses multiple ranges, e.g. `A1:B2,C5:H10`, but we throw an exception if you try to change the style. I don't know how useful that is, but it's been requested and it's pretty easy to implement with recursion. The comm...
fd5f72edd76d0cfea2a8790c252f9f6b65268aa4
a028eea3141f4a7ca4dc998613417f1c18b2172a
diff --git a/src/PhpSpreadsheet/Style/Style.php b/src/PhpSpreadsheet/Style/Style.php index 9956c358d5..9df62897a3 100644 --- a/src/PhpSpreadsheet/Style/Style.php +++ b/src/PhpSpreadsheet/Style/Style.php @@ -201,6 +201,18 @@ public function applyFromArray(array $styleArray, bool $advancedBorders = true): { ...
[ "src/PhpSpreadsheet/Style/Style.php", "tests/PhpSpreadsheetTests/Style/MultipleRangeTest.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Style/MultipleRangeTest.php b/tests/PhpSpreadsheetTests/Style/MultipleRangeTest.php new file mode 100644 index 0000000000..c07161bebb --- /dev/null +++ b/tests/PhpSpreadsheetTests/Style/MultipleRangeTest.php @@ -0,0 +1,84 @@ +<?php + +declare(strict_types=1); + +namespace PhpOffic...
true
PHPOffice/PhpSpreadsheet
4,909
issue_to_patch
Feature Request: Navigate cell as cursor This is: ``` [ ] a bug report [x] a feature request [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet) ``` ### What is the expected behavior? `$sheet->getCell('A1')->curso...
Navigate Cell as Cursor
Fix #863, which went stale in 2019 and is now reopened. Add methods to `Cell` which operate in a cursor-like manner, allowing you to change to cells on the right, left, down, or up. This is: - [ ] a bugfix - [x] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [x] Changes are cove...
fd5f72edd76d0cfea2a8790c252f9f6b65268aa4
46f4b8995a5e8e17f900019168dfb198986ef1de
diff --git a/src/PhpSpreadsheet/Cell/Cell.php b/src/PhpSpreadsheet/Cell/Cell.php index 2b0da2fa5f..ca13e824f2 100644 --- a/src/PhpSpreadsheet/Cell/Cell.php +++ b/src/PhpSpreadsheet/Cell/Cell.php @@ -1071,4 +1071,96 @@ public function isHiddenOnFormulaBar(): bool return $hidden !== Protection::PROTECTION_UNPR...
[ "src/PhpSpreadsheet/Cell/Cell.php", "tests/PhpSpreadsheetTests/Cell/CursorTest.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Cell/CursorTest.php b/tests/PhpSpreadsheetTests/Cell/CursorTest.php new file mode 100644 index 0000000000..61ca3c61ad --- /dev/null +++ b/tests/PhpSpreadsheetTests/Cell/CursorTest.php @@ -0,0 +1,67 @@ +<?php + +declare(strict_types=1); + +namespace PhpOffice\PhpSpreadsheetTests\Ce...
true
PHPOffice/PhpSpreadsheet
4,908
issue_to_patch
Not keeping chart styling when reading from template This is: ``` - [x] a bug report - [ ] a feature request - [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet) ``` ### What is the expected behavior? I have a ...
No lumOff for Radar Charts
Fix #661 (marked stale in 2018, but now reopened). That issue was already mostly resolved by many changes to Xlsx Chart Writer logic some time ago. However, a new problem popped up. PR #2950 added `brightness` logic to Xlsx Reader and Writer. That was done primarily for the benefit of scatter charts. Xlsx Writer writes...
fd5f72edd76d0cfea2a8790c252f9f6b65268aa4
6a0d4ff52765ec81b4a50e660a9436c5851f5003
diff --git a/samples/templates/32readwriteRadarChart4.xlsx b/samples/templates/32readwriteRadarChart4.xlsx new file mode 100644 index 0000000000..d752fb8b64 Binary files /dev/null and b/samples/templates/32readwriteRadarChart4.xlsx differ diff --git a/src/PhpSpreadsheet/Writer/Xlsx/Chart.php b/src/PhpSpreadsheet/Writer...
[ "samples/templates/32readwriteRadarChart4.xlsx", "src/PhpSpreadsheet/Writer/Xlsx/Chart.php", "tests/PhpSpreadsheetTests/Chart/Charts32Radar4Test.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Chart/Charts32Radar4Test.php b/tests/PhpSpreadsheetTests/Chart/Charts32Radar4Test.php new file mode 100644 index 0000000000..81af8e6f78 --- /dev/null +++ b/tests/PhpSpreadsheetTests/Chart/Charts32Radar4Test.php @@ -0,0 +1,48 @@ +<?php + +declare(strict_types=1); + +namespace PhpOf...
true
PHPOffice/PhpSpreadsheet
4,906
issue_to_patch
Minor Coverage Improvement Reader/Xlsx
This is: - [ ] a bugfix - [ ] a new feature - [ ] refactoring - [ ] additional unit tests - [x] code coverage Checklist: - [ ] Changes are covered by unit tests - [ ] Changes are covered by existing unit tests - [x] New unit tests have been added - [x] Code style is respected - [x] Commit message e...
4f920ccc57a1bd02350b6da8ff42fab8a308b83f
1f7dd42482027cd465f0cf09f93b48f983ba54a1
[ "tests/PhpSpreadsheetTests/Reader/Xlsx/RichText2Test.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Reader/Xlsx/RichText2Test.php b/tests/PhpSpreadsheetTests/Reader/Xlsx/RichText2Test.php new file mode 100644 index 0000000000..ac7128315e --- /dev/null +++ b/tests/PhpSpreadsheetTests/Reader/Xlsx/RichText2Test.php @@ -0,0 +1,107 @@ +<?php + +declare(strict_types=1); + +namespace P...
true
PHPOffice/PhpSpreadsheet
4,830
issue_to_patch
Restructure Xlsx Reader Parser Allowing Experimental Streaming Mode
## Summary - Adds an opt-in `$useStreamingReader` flag (default `false`) to the XLSX reader - When enabled, uses `XMLReader` instead of `SimpleXML` for the main cell data parsing loop, processing rows one at a time instead of loading the entire sheet XML into memory - Handles all core data types: shared strings, number...
54e28ff8ca8008a3a7109e58dcd105907975a775
a4346ec6002385df2e6d02a7013367471c532150
diff --git a/CHANGELOG.md b/CHANGELOG.md index 148625aa20..6a20ac200e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a ### Changed -- Nothing yet. +- Restructure parsing logic in Reader/Xlsx. [PR #4830](https://github.co...
[ "CHANGELOG.md", "src/PhpSpreadsheet/Reader/Xlsx.php", "tests/Benchmark/XlsxStreamingReadClass.php", "tests/Benchmark/XlsxStreamingReadTest.php", "tests/Benchmark/XlsxStreamingReaderBenchmarkTest.php" ]
[]
diff --git a/tests/Benchmark/XlsxStreamingReadClass.php b/tests/Benchmark/XlsxStreamingReadClass.php new file mode 100644 index 0000000000..2bdcc8c972 --- /dev/null +++ b/tests/Benchmark/XlsxStreamingReadClass.php @@ -0,0 +1,367 @@ +<?php + +namespace PhpOffice\PhpSpreadsheetBenchmarks; + +use PhpOffice\PhpSpreadsheet\...
true
PHPOffice/PhpSpreadsheet
4,827
issue_to_patch
Experimental Stream encoding conversion in CSV reader to reduce peak memory
## Summary - Replaces `file_get_contents()` + full-string encoding conversion with chunk-based streaming (64KB chunks) - Handles multi-byte character boundaries for UTF-16 and UTF-32 encodings by carrying leftover bytes between chunks - Uses `php://temp` stream which spills to disk if memory threshold is exceeded - Red...
e7067ecf9aa7e914694a6027ccb3ccf269415b9f
fd773844c21076d73b5b14c3f39c8b1cee7e6c04
[ "tests/Benchmark/CsvChunk.php", "tests/Benchmark/CsvStreamingEncodingBenchmarkTest.php", "tests/Benchmark/CsvStreamingEncodingTest.php" ]
[]
diff --git a/tests/Benchmark/CsvChunk.php b/tests/Benchmark/CsvChunk.php new file mode 100644 index 0000000000..49643330b3 --- /dev/null +++ b/tests/Benchmark/CsvChunk.php @@ -0,0 +1,165 @@ +<?php + +namespace PhpOffice\PhpSpreadsheetBenchmarks; + +use PhpOffice\PhpSpreadsheet\Reader\Csv; +use PhpOffice\PhpSpreadsheet\...
true
PHPOffice/PhpSpreadsheet
4,905
issue_to_patch
Update Phpstan
This is: - [ ] a bugfix - [ ] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [ ] Changes are covered by unit tests - [ ] Changes are covered by existing unit tests - [ ] New unit tests have been added - [ ] Code style is respected - [ ] Commit message explains **why** the c...
01964d92536edf1a3a874b9580a52824bebf6fbb
1571b81ab8fb9489dcf9de920386ee6bf1272984
diff --git a/.github/dependabot.yml b/.github/dependabot.yml index aaf86966ca..54892f3174 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -3,9 +3,12 @@ updates: - package-ecosystem: "composer" directory: "/" schedule: - interval: "daily" + interval: "monthly" + ...
[ ".github/dependabot.yml", "composer.lock", "src/PhpSpreadsheet/Calculation/Calculation.php", "src/PhpSpreadsheet/Calculation/Information/Value.php", "src/PhpSpreadsheet/Reader/Gnumeric/Styles.php", "src/PhpSpreadsheet/Reader/Xls.php" ]
[]
true
PHPOffice/PhpSpreadsheet
4,904
issue_to_patch
Update Changelog for New Release
This is: - [ ] a bugfix - [ ] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [ ] Changes are covered by unit tests - [ ] Changes are covered by existing unit tests - [ ] New unit tests have been added - [ ] Code style is respected - [ ] Commit message explains **why** the c...
bab9199ea15a859aa592fb3ac9aac54a0dbffdf7
2a4a2967f2e84528b36264755151eb5c8739a2d2
diff --git a/CHANGELOG.md b/CHANGELOG.md index 46bf3907bf..148625aa20 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,17 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com) and this project adheres to [Semantic Versioni...
[ "CHANGELOG.md" ]
[]
true
PHPOffice/PhpSpreadsheet
4,903
issue_to_patch
Bump peaceiris/actions-gh-pages from 3 to 4
Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peaceiris/actions-gh-pages/releases">peaceiris/actions-gh-pages's releases</a>.</em></p> <blockquote> <h2>actions-github-pages v4.0.0<...
649afb933906112cf5cbc83e80655f0e27b74d34
d6baecae4dd5a25046ecde0d8219ca4bb9d472b7
diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml index bfedc2fbf9..b76e5ea557 100644 --- a/.github/workflows/github-pages.yml +++ b/.github/workflows/github-pages.yml @@ -27,7 +27,7 @@ jobs: php phpDocumentor.phar --directory src/ --target docs/api --visibility=public,prot...
[ ".github/workflows/github-pages.yml" ]
[]
true
PHPOffice/PhpSpreadsheet
4,902
issue_to_patch
Bump actions/checkout from 4 to 6
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update README to includ...
649afb933906112cf5cbc83e80655f0e27b74d34
e22244932b1ece06bd73f4c073fb46678dbfcc77
diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml index bfedc2fbf9..cecada452f 100644 --- a/.github/workflows/github-pages.yml +++ b/.github/workflows/github-pages.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checko...
[ ".github/workflows/github-pages.yml" ]
[]
true
PHPOffice/PhpSpreadsheet
4,900
issue_to_patch
Bump friendsofphp/php-cs-fixer from 3.95.3 to 3.95.4
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.95.3 to 3.95.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases">friendsofphp/php-cs-fixer's releases</a>.</em></p> <blockquote> <h2>v3.95.4 Adalbertus</h2...
649afb933906112cf5cbc83e80655f0e27b74d34
aea5b934fe2ac4d712eb0e7dd607e91785a089d0
diff --git a/composer.lock b/composer.lock index 8fe196d5d5..2c4c8ab9c6 100644 --- a/composer.lock +++ b/composer.lock @@ -960,16 +960,16 @@ }, { "name": "friendsofphp/php-cs-fixer", - "version": "v3.95.3", + "version": "v3.95.4", "source": { ...
[ "composer.lock" ]
[]
true
PHPOffice/PhpSpreadsheet
4,895
issue_to_patch
Make Helper/Handler Internal and Final
Needed for testing purposes, but no reason why anyone should use or extend it. This is: - [ ] a bugfix - [ ] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [ ] Changes are covered by unit tests - [ ] Changes are covered by existing unit tests - [ ] New unit tests have been...
89c3b39d35f1371d3022115abf25eccf83542e3f
fdbe4b538af8389d3e56b5763190f7592b0fde4b
diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 68ac78ad4c..aaf86966ca 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,8 +1,11 @@ version: 2 updates: -- package-ecosystem: composer - directory: "/" - schedule: - interval: monthly - time: "11:00" - open-pull-requests-...
[ ".github/dependabot.yml", "CHANGELOG.md", "docs/topics/reading-files.md", "src/PhpSpreadsheet/Helper/Handler.php" ]
[]
true
PHPOffice/PhpSpreadsheet
4,896
issue_to_patch
getChartIndex
It requires an index to an array which needs to be supplied as a string, even though the array is indexed exclusively by int. It is called only once in the code base, by some inefficient code which becomes much simpler when restructured and eliminates the call altogether. It is not independently tested. The use case fo...
89c3b39d35f1371d3022115abf25eccf83542e3f
9698573e328e8a1e983c2aa7ac82b80204fc6a38
diff --git a/src/PhpSpreadsheet/Worksheet/Worksheet.php b/src/PhpSpreadsheet/Worksheet/Worksheet.php index 9bd4c477be..5c26e2dd82 100644 --- a/src/PhpSpreadsheet/Worksheet/Worksheet.php +++ b/src/PhpSpreadsheet/Worksheet/Worksheet.php @@ -569,14 +569,14 @@ public function getChartCount(): int /** * Get a cha...
[ "src/PhpSpreadsheet/Worksheet/Worksheet.php", "src/PhpSpreadsheet/Writer/Xlsx/Drawing.php", "tests/PhpSpreadsheetTests/Chart/ChartsByNameTest.php", "tests/PhpSpreadsheetTests/Worksheet/CloneTest.php", "tests/PhpSpreadsheetTests/Worksheet/ShrinkRangeToFitTest.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Chart/ChartsByNameTest.php b/tests/PhpSpreadsheetTests/Chart/ChartsByNameTest.php index a3583672f8..e6d7923789 100644 --- a/tests/PhpSpreadsheetTests/Chart/ChartsByNameTest.php +++ b/tests/PhpSpreadsheetTests/Chart/ChartsByNameTest.php @@ -19,6 +19,7 @@ public function testChartBy...
true
PHPOffice/PhpSpreadsheet
4,899
issue_to_patch
Document exception in IOFactory.php
### Why this change is needed? It lets down stream be more strict about there exception handeling and enables tools to notify them if the behavior changes in the future.
89c3b39d35f1371d3022115abf25eccf83542e3f
c66fe743034274565c6a7a8c13079e29dd1161e0
diff --git a/src/PhpSpreadsheet/IOFactory.php b/src/PhpSpreadsheet/IOFactory.php index 71783b098b..7444aa879a 100644 --- a/src/PhpSpreadsheet/IOFactory.php +++ b/src/PhpSpreadsheet/IOFactory.php @@ -175,6 +175,8 @@ public static function identify(string $filename, ?array $readers = null, bool $ * ...
[ "src/PhpSpreadsheet/IOFactory.php" ]
[]
true
PHPOffice/PhpSpreadsheet
4,886
issue_to_patch
listWorksheetInfo() not in IReader listWorksheetInfo() is not declared in the IReader interface, this seems an oversight, but is it intentional? Is it recommended to depend on BaseReader, or is there another interface that could be relied on for this?
Add IReader2 Interface with listWorksheetInfo/Names
Fix #4883, hopefully in a non-breaking manner. This is: - [x] a bugfix, sort of - [ ] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [x] Changes are covered by unit tests - [x] Changes are covered by existing unit tests - [x] New unit tests have been added - [x] Code styl...
8d0754e60abc2b40c6bf81e34b87ade37062fcd3
668106c685ec08ed6aa87e17f544d2b7537ff754
diff --git a/CHANGELOG.md b/CHANGELOG.md index c860676b60..0da6b00a1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a ### Added - Optional method to increase Calculation Engine's parsing speed. [PR #4829](https://github....
[ "CHANGELOG.md", "src/PhpSpreadsheet/IOFactory.php", "src/PhpSpreadsheet/Reader/BaseReader.php", "src/PhpSpreadsheet/Reader/EmptyWorksheetInfo.php", "src/PhpSpreadsheet/Reader/IReader2.php", "tests/PhpSpreadsheetTests/CustomReader2.php", "tests/PhpSpreadsheetTests/CustomReaderNot2.php", "tests/PhpSprea...
[]
diff --git a/tests/PhpSpreadsheetTests/CustomReader2.php b/tests/PhpSpreadsheetTests/CustomReader2.php new file mode 100644 index 0000000000..5efb8a56db --- /dev/null +++ b/tests/PhpSpreadsheetTests/CustomReader2.php @@ -0,0 +1,140 @@ +<?php + +declare(strict_types=1); + +namespace PhpOffice\PhpSpreadsheetTests; + +use...
true
PHPOffice/PhpSpreadsheet
4,736
issue_to_patch
Removed duplicate try-catch statements
This is: - [ ] a bugfix - [ ] a new feature - [x] refactoring - [ ] additional unit tests Checklist: - [ ] Changes are covered by unit tests - [ ] Changes are covered by existing unit tests - [ ] New unit tests have been added - [x] Code style is respected - [x] Commit message explains **why** the c...
dde7fe180bbe9c924302003eb30715df8f045753
c0e7bfdcb55fc3c2f2648fcd42a1c2e3bef6d4ff
[ "tests/PhpSpreadsheetTests/Helper/HandlerTest.php" ]
[]
diff --git a/tests/PhpSpreadsheetTests/Helper/HandlerTest.php b/tests/PhpSpreadsheetTests/Helper/HandlerTest.php index bb8bf751f4..b3e77cced5 100644 --- a/tests/PhpSpreadsheetTests/Helper/HandlerTest.php +++ b/tests/PhpSpreadsheetTests/Helper/HandlerTest.php @@ -4,9 +4,9 @@ namespace PhpOffice\PhpSpreadsheetTests\He...
true
PHPOffice/PhpSpreadsheet
4,891
issue_to_patch
`FIXED` function is not properly formatting `Decimals` when `No_commas` is true The [`FIXED` function](https://github.com/PHPOffice/PhpSpreadsheet/blob/5.7.0/src/PhpSpreadsheet/Calculation/TextData/Format.php#L69-L109) is not properly taking into account the `$decimals` parameter if `$noCommas` is `true`. In Excel (a...
Bug in FIXED Function
Fix #4889. Function was not outputting correct number of decimals when thousands separator was omitted. This is: - [x] a bugfix - [ ] a new feature - [ ] refactoring - [ ] additional unit tests Checklist: - [x] Changes are covered by unit tests - [x] Changes are covered by existing unit tests - [x]...
ad2285dac7e298bd5fb7845828cce169bd468dd6
d80d762af1ef28d3e3979b83b8aef625c57cae40
diff --git a/src/PhpSpreadsheet/Calculation/TextData/Format.php b/src/PhpSpreadsheet/Calculation/TextData/Format.php index 23bf74f034..ff5c83fedc 100644 --- a/src/PhpSpreadsheet/Calculation/TextData/Format.php +++ b/src/PhpSpreadsheet/Calculation/TextData/Format.php @@ -96,16 +96,13 @@ public static function FIXEDFORMA...
[ "src/PhpSpreadsheet/Calculation/TextData/Format.php", "tests/data/Calculation/TextData/FIXED.php" ]
[ { "comment": "How about shortening the full `if` block to\n```php\n$valueResult = number_format(\n $valueResult,\n $decimals,\n StringHelper::getDecimalSeparator(),\n ($noCommas === false) ? StringHelper::getThousandsSeparator() : ''\n);\n```\n?", "path": "src/PhpSpreadsheet/Calculation/TextData/Format....
diff --git a/tests/data/Calculation/TextData/FIXED.php b/tests/data/Calculation/TextData/FIXED.php index e13b8110e2..f82b91fb96 100644 --- a/tests/data/Calculation/TextData/FIXED.php +++ b/tests/data/Calculation/TextData/FIXED.php @@ -66,4 +66,6 @@ 'null second argument' => ['123', 123, null], 'false second a...
true
PHPOffice/PhpSpreadsheet
4,891
comment_to_fix
Bug in FIXED Function
How about shortening the full `if` block to ```php $valueResult = number_format( $valueResult, $decimals, StringHelper::getDecimalSeparator(), ($noCommas === false) ? StringHelper::getThousandsSeparator() : '' ); ``` ?
ad2285dac7e298bd5fb7845828cce169bd468dd6
d80d762af1ef28d3e3979b83b8aef625c57cae40
diff --git a/src/PhpSpreadsheet/Calculation/TextData/Format.php b/src/PhpSpreadsheet/Calculation/TextData/Format.php index 23bf74f034..ff5c83fedc 100644 --- a/src/PhpSpreadsheet/Calculation/TextData/Format.php +++ b/src/PhpSpreadsheet/Calculation/TextData/Format.php @@ -96,16 +96,13 @@ public static function FIXEDFORMA...
[ "src/PhpSpreadsheet/Calculation/TextData/Format.php" ]
[ { "comment": "How about shortening the full `if` block to\n```php\n$valueResult = number_format(\n $valueResult,\n $decimals,\n StringHelper::getDecimalSeparator(),\n ($noCommas === false) ? StringHelper::getThousandsSeparator() : ''\n);\n```\n?", "path": "src/PhpSpreadsheet/Calculation/TextData/Format....
true
PHPOffice/PhpSpreadsheet
4,892
issue_to_patch
Phpstan Changes
A large volume of changes due to "sealed" arrays. Some are sensible; some are very confusing and are handled with `ignore` annotations. Modules in src with changed code (as opposed to doc-blocks or annotations) are: - DateTimeExcelDays - Reader/Xlsx - Reader/Xlsx/AutoFilter - Reader/Xlsx/Chart - Reader/Xlsx/C...
9260bd841feae60393069ebbaee39471d1173d1c
14a641f924d38a56fa92983e614447ea8ad44f19
diff --git a/composer.lock b/composer.lock index 8850a7ecc3..1e1dfce8fc 100644 --- a/composer.lock +++ b/composer.lock @@ -535,12 +535,12 @@ "source": { "type": "git", "url": "https://github.com/PHPCSStandards/composer-installer.git", - "reference": "7e6a7a3...
[ "composer.lock", "src/PhpSpreadsheet/Calculation/Calculation.php", "src/PhpSpreadsheet/Calculation/DateTimeExcel/Days.php", "src/PhpSpreadsheet/Calculation/FunctionArray.php", "src/PhpSpreadsheet/Calculation/MathTrig/Round.php", "src/PhpSpreadsheet/Chart/Properties.php", "src/PhpSpreadsheet/Reader/Ods.p...
[]
diff --git a/tests/PhpSpreadsheetTests/Style/ConditionalFormatting/Wizard/DateValueWizardTest.php b/tests/PhpSpreadsheetTests/Style/ConditionalFormatting/Wizard/DateValueWizardTest.php index 8350565cf7..55c37ebfef 100644 --- a/tests/PhpSpreadsheetTests/Style/ConditionalFormatting/Wizard/DateValueWizardTest.php +++ b/te...
true