repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
PHPOffice/PhpSpreadsheet | 4,877 | issue_to_patch | 用Drawing来添加图片，并生成html，setRotation()未生效
```php
$drawing = new Drawing();
$drawing->setName($name);
$drawing->setDescription($name);
$drawing->setPath($sealPath);
$drawing->setCoordinates($coordinate);
$drawing->setOffsetX($isPartyA ? random_int(84, 138) : random_int(92, 1... | Html Writer Apply Rotation To Images | Fix #4875. If rotation is applied to a Drawing, Html Writer will now generate the appropriate Css. This will cause the image to be rotated for Html, Dompdf, and Mpdf; Tcpdf does not recognize the rotation Css.
This is:
- [ ] a bugfix
- [x] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklis... | 7cc6e4e580b1d92c1bba97ca9f00dbe3e3072107 | 6762ce0cbf58bc783e4f13808aced0e8c1d01875 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c860676b60..cc2e1a4aad 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,9 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Fixed
- Html Writer handle text colors a bit better. [PR #4855](https://github.com/PHPOffice/PhpSp... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/Html.php",
"src/PhpSpreadsheet/Writer/Html.php",
"tests/PhpSpreadsheetTests/Writer/Html/ImageRotateTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetTests/Writer/Html/ImageRotateTest.php b/tests/PhpSpreadsheetTests/Writer/Html/ImageRotateTest.php
new file mode 100644
index 0000000000..f8149245ce
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Writer/Html/ImageRotateTest.php
@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namesp... | true |
PHPOffice/PhpSpreadsheet | 4,880 | issue_to_patch | Reusing Disconnected Spreadsheet | Throws exception if you subsequently attempt `createSheet(0)`. Fix that.
This is:
- [x] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [x] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [x] New unit tests have been added... | 8d0754e60abc2b40c6bf81e34b87ade37062fcd3 | 37b41a16b70711283b8a098264a9da1fbf8ad860 | diff --git a/src/PhpSpreadsheet/Spreadsheet.php b/src/PhpSpreadsheet/Spreadsheet.php
index 4c7417a55c..3fe6d044c1 100644
--- a/src/PhpSpreadsheet/Spreadsheet.php
+++ b/src/PhpSpreadsheet/Spreadsheet.php
@@ -510,6 +510,7 @@ public function disconnectWorksheets(): void
unset($worksheet);
}
... | [
"src/PhpSpreadsheet/Spreadsheet.php",
"tests/PhpSpreadsheetTests/ReuseDisconnectTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetTests/ReuseDisconnectTest.php b/tests/PhpSpreadsheetTests/ReuseDisconnectTest.php
new file mode 100644
index 0000000000..86ee8c0519
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/ReuseDisconnectTest.php
@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpOffice\PhpSpreads... | true | |
PHPOffice/PhpSpreadsheet | 4,878 | issue_to_patch | First Php8.6 Deprecation | Mpdf uses soon-to-be-deprecated `mb_regex_encoding`.
https://wiki.php.net/rfc/eol-oniguruma
This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
- [x] third-party deprecation
Checklist:
- [x] Changes are covered by unit tests
- [x] Changes are covered by existing... | 7cc6e4e580b1d92c1bba97ca9f00dbe3e3072107 | 45bfd9121eb710cd61a7d104108ee8338674d197 | diff --git a/src/PhpSpreadsheet/Writer/Pdf/Mpdf.php b/src/PhpSpreadsheet/Writer/Pdf/Mpdf.php
index 1c6ee30a09..ceb8285b3f 100644
--- a/src/PhpSpreadsheet/Writer/Pdf/Mpdf.php
+++ b/src/PhpSpreadsheet/Writer/Pdf/Mpdf.php
@@ -40,6 +40,13 @@ public function save($filename, int $flags = 0): void
// Create PDF
... | [
"src/PhpSpreadsheet/Writer/Pdf/Mpdf.php"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,888 | issue_to_patch | Update Samples | ... demonstrating how Excel sorts.
This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ]... | da4ea0540c2d63903d244a999e7133aeea53d923 | 3d86f3d13c2b0750705f52c2b4e937b263958b7d | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index a29e2d2bec..932d052ee5 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -44,7 +44,7 @@ jobs:
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
- name: Cache composer dependencies
- ... | [
".github/workflows/main.yml",
"docs/topics/Excel Anomalies.md",
"samples/LookupRef/SortExcelArray.php",
"samples/LookupRef/SortExcelCols.php",
"samples/templates/SortExcel.php"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,876 | issue_to_patch | Reject phar Protocol in Unexpected Format | Reject `phar:///whatever` as input filename.
This is:
- [x] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [x] New unit tests have been added
- [x] Code style is respec... | 7cc6e4e580b1d92c1bba97ca9f00dbe3e3072107 | ee67357682796f9475eb710394a0554c59d80eb8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c860676b60..aee6d87426 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
## TBD - 5.8.0
+### Security Note
+
+- File::prohibitWrappers and Drawing::setPath now reject phar pat... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Shared/File.php",
"src/PhpSpreadsheet/Worksheet/Drawing.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php",
"tests/PhpSpreadsheetTests/Reader/NoPharTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php
index baec78daaa..94b95342ac 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php
@@ -157,7 +157,12 @@ public s... | true | |
PHPOffice/PhpSpreadsheet | 4,879 | issue_to_patch | Bump setasign/fpdi from 2.6.6 to 2.6.7 | Bumps [setasign/fpdi](https://github.com/Setasign/FPDI) from 2.6.6 to 2.6.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Setasign/FPDI/releases">setasign/fpdi's releases</a>.</em></p>
<blockquote>
<h2>FPDI 2.6.7</h2>
<h1>Fixes</h1>
<ul>
<li>Fixed handling of <code>/Prev</c... | 7cc6e4e580b1d92c1bba97ca9f00dbe3e3072107 | 24f8d4983e1e5f392474e288a8002e9abfa67509 | diff --git a/composer.lock b/composer.lock
index 8850a7ecc3..beec41cb71 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4063,16 +4063,16 @@
},
{
"name": "setasign/fpdi",
- "version": "v2.6.6",
+ "version": "v2.6.7",
"source": {
"type"... | [
"composer.lock"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,872 | issue_to_patch | Combine Dependabot Changes | Someting seemed to be wrong with push setup. We'll see if it's fixed.
This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
- [x] update dependencies
Checklist:
- [x] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New un... | d5cdc29a3eb1eb61c795065a03517009c6647955 | 5c8c20686fe0c7c8ccb255702ee46979c75abeff | diff --git a/composer.lock b/composer.lock
index feccad59d2..8850a7ecc3 100644
--- a/composer.lock
+++ b/composer.lock
@@ -781,6 +781,75 @@
},
"time": "2026-01-02T16:01:13+00:00"
},
+ {
+ "name": "ergebnis/agent-detector",
+ "version": "1.1.1",
+ ... | [
"composer.lock",
"samples/Engineering/Convert-Online.php",
"src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/CellValue.php",
"src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/TextValue.php",
"src/PhpSpreadsheet/Worksheet/Worksheet.php",
"tests/PhpSpreadsheetTests/Chart/ChartCloneTest.php",
"te... | [] | diff --git a/tests/PhpSpreadsheetTests/Chart/ChartCloneTest.php b/tests/PhpSpreadsheetTests/Chart/ChartCloneTest.php
index 63b076c3ef..cf51b25ad4 100644
--- a/tests/PhpSpreadsheetTests/Chart/ChartCloneTest.php
+++ b/tests/PhpSpreadsheetTests/Chart/ChartCloneTest.php
@@ -154,8 +154,7 @@ public function testCloneSheetWit... | true | |
PHPOffice/PhpSpreadsheet | 4,864 | issue_to_patch | Don't infer cell t attribute from formula source when pre-calc is off | # Don't infer cell `t` attribute from formula source when pre-calc is off
## What
When `setPreCalculateFormulas(false)` is set on the Xlsx writer, every formula cell is written with `t="str"` — even when the formula evaluates to a number or boolean. This PR removes that spurious type attribute.
## Why this mat... | c0e328482ab5f88ebf299131dfde7303ef7f86fc | 5eb433e08be5b0467daab89d7665317060756c40 | diff --git a/src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php b/src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php
index aad76000a2..3a21c41542 100644
--- a/src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php
+++ b/src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php
@@ -1576,7 +1576,13 @@ private function writeCellFormula(XMLWriter $objWriter... | [
"src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php",
"tests/PhpSpreadsheetTests/Writer/PreCalcTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetTests/Writer/PreCalcTest.php b/tests/PhpSpreadsheetTests/Writer/PreCalcTest.php
index dfadeab1f2..f69c0407c0 100644
--- a/tests/PhpSpreadsheetTests/Writer/PreCalcTest.php
+++ b/tests/PhpSpreadsheetTests/Writer/PreCalcTest.php
@@ -108,7 +108,10 @@ private function verifyXlsx(?bool $preCa... | true | |
PHPOffice/PhpSpreadsheet | 4,861 | issue_to_patch | Documentation of "Memory saving" (APCu section) outdated
This is:
```
- [x] an outdated part of the documentation
- [ ] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)
```
... | Update APCu cache documentation example | This PR updates the APCu example in the memory saving documentation.
The current documentation recommends `cache/simple-cache-bridge` and `cache/apcu-adapter`. This PR updates the APCu example to use Symfony Cache with `ApcuAdapter` and `Psr16Cache`.
## Changes
- Replaced the old APCu package recommendation
-... | 5483cf930d0c39cb5a89a914c3f4a73cff9fb078 | 7db28981458fd56e3f8ce3db1d7c6f06c9e6fbf4 | diff --git a/docs/topics/memory_saving.md b/docs/topics/memory_saving.md
index e52a83e414..f44b308eb6 100644
--- a/docs/topics/memory_saving.md
+++ b/docs/topics/memory_saving.md
@@ -53,19 +53,24 @@ details, but here are a few suggestions that should get you started.
### APCu
-Require the packages into your projec... | [
"docs/topics/memory_saving.md"
] | [] | true | |
PHPOffice/PhpSpreadsheet | 4,858 | issue_to_patch | Html Writer/Reader New `data` Attributes | Html Reader recognizes a `data-format` attribute for storing the number format associated with a cell. However, Html Writer does not set this attribute. This PR offers a new Writer property `preserveFormatAndValue` and setter; when `true`, for any cell which uses a number format other than the default `General` the wri... | d6a4e397995fda089ef9cba34e02ab70fbca9a66 | 381bdacb8ef503d66edf71d98dfb287a532197f6 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d0848dd2ad..c860676b60 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Added
- Optional method to increase Calculation Engine's parsing speed. [PR #4829](https://github.... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/Html.php",
"src/PhpSpreadsheet/Writer/Html.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlTest.php",
"tests/PhpSpreadsheetTests/Reader/Html/PreserveFormatTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlTest.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlTest.php
index 4ae0b590ba..aaa43494cc 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlTest.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlTest.php
@@ -210,27 +210,6 @@ public function testCanApplyAlig... | true | |
PHPOffice/PhpSpreadsheet | 4,829 | issue_to_patch | Add formula token cache to reduce repeated parsing overhead | ## Summary
- Adds a static bounded formula token cache (max 1000 entries) to the Calculation engine
- Before parsing a formula, `parseFormula()` checks the cache — on hit, returns cached tokens immediately, skipping all regex operations
- When the cache reaches capacity, it is fully cleared (simple eviction)
- Provides... | 9f55d3b9b7bcb1084fda8340e4b7ce4ed10cd0c8 | e02c7918dee89d1bd41ecefbc2068aee3435a746 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3f1940e32f..2f0183cb23 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Added
-- Nothing yet.
+- Optional method to increase Calculation Engine's parsing speed. [PR #4829]... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Calculation/Calculation.php",
"tests/Benchmark/FormulaTokenCacheBenchmarkTest.php",
"tests/PhpSpreadsheetTests/Calculation/FormulaTokenCacheTest.php"
] | [] | diff --git a/tests/Benchmark/FormulaTokenCacheBenchmarkTest.php b/tests/Benchmark/FormulaTokenCacheBenchmarkTest.php
new file mode 100644
index 0000000000..fca4353459
--- /dev/null
+++ b/tests/Benchmark/FormulaTokenCacheBenchmarkTest.php
@@ -0,0 +1,194 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpOffice\PhpSpr... | true | |
PHPOffice/PhpSpreadsheet | 4,855 | issue_to_patch | Html Writer Handle Text Colors a Bit Better | Researching a security advisory, the code for handling text colors in Html Writer when the cell is non-numeric and the color is hard-coded in the Number Format looked a bit suspicious. As it turns out, the code was *not* subject to a security exploit. However, the color for the Number Format was ignored. This PR correc... | 9f55d3b9b7bcb1084fda8340e4b7ce4ed10cd0c8 | 4ef51eece5fd7d409d8b0512de6e15ccef2c2358 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3f1940e32f..ab891dda99 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -29,7 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Fixed
-- Nothing yet.
+- Html Writer handle text colors a bit better. [PR #4855](https://github.c... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/BaseReader.php",
"src/PhpSpreadsheet/Reader/Ods.php",
"src/PhpSpreadsheet/Style/NumberFormat/Formatter.php",
"src/PhpSpreadsheet/Writer/Html.php",
"tests/PhpSpreadsheetTests/Reader/Html/DataFormulaTest.php",
"tests/PhpSpreadsheetTests/Writer/Html/HtmlNumberForm... | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/DataFormulaTest.php b/tests/PhpSpreadsheetTests/Reader/Html/DataFormulaTest.php
index e89e600bd3..e6f6b30bbd 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/DataFormulaTest.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/DataFormulaTest.php
@@ -144,7 +144,7 @@ publi... | true | |
PHPOffice/PhpSpreadsheet | 4,856 | issue_to_patch | Improve Coverage | Take on some low-hanging fruit, mostly in Conditional Formatting Wizard.
This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
- [x] coverage
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [x] New unit tests... | 9f55d3b9b7bcb1084fda8340e4b7ce4ed10cd0c8 | f4fc8c974a15e57d642726d47e43a0592e4afe1d | diff --git a/src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/CellValue.php b/src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/CellValue.php
index 032bb98ac7..6d23b9d923 100644
--- a/src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/CellValue.php
+++ b/src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard... | [
"src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/CellValue.php",
"src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/Duplicates.php",
"src/PhpSpreadsheet/Style/ConditionalFormatting/Wizard/TextValue.php",
"src/PhpSpreadsheet/Writer/Xls/Style/CellBorder.php",
"src/PhpSpreadsheet/Writer/Xls/Style/Cel... | [] | diff --git a/tests/PhpSpreadsheetTests/Style/ConditionalFormatting/Wizard/BlankWizardTest.php b/tests/PhpSpreadsheetTests/Style/ConditionalFormatting/Wizard/BlankWizardTest.php
index 3d36c896b8..1cd02ac1e7 100644
--- a/tests/PhpSpreadsheetTests/Style/ConditionalFormatting/Wizard/BlankWizardTest.php
+++ b/tests/PhpSprea... | true | |
PHPOffice/PhpSpreadsheet | 4,859 | issue_to_patch | Update Changelog for New Release | This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ] Commit message explains **why** the c... | 9019a9c9da1daee02d55c40f45f23a3c7eba5b62 | 2e35213f2a5c8430f8f46294e7d472c30cf123be | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d8d58bcec6..3f1940e32f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com)
and this project adheres to [Semantic Versioning... | [
"CHANGELOG.md"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,857 | issue_to_patch | Prepare Changelog For New Release | This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ] Commit message explains **why** the c... | 4a476071b3e0d633906251d95e73ad7464a32337 | f302b3265a3c471438192eea5a8cca26c1d52e88 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 28163b307a..d8d58bcec6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,7 +5,33 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com)
and this project adheres to [Semantic Versionin... | [
"CHANGELOG.md"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,850 | issue_to_patch | Update PhpStan | Too many errors when Dependabot tried. These seem mostly to involve `implode`, whose use is often embedded in other function calls. For that reason, these changes include a higher proportion than usual of `// @phpstan-ignore-line`.
This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional ... | 36013a3db550618f331c5ae5a64c5e555428bf24 | b45c4f7ee0d2160883d58d896cb2f51ad3a49272 | diff --git a/composer.lock b/composer.lock
index ec66add442..1709886255 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1638,11 +1638,11 @@
},
{
"name": "phpstan/phpstan",
- "version": "2.1.40",
+ "version": "2.1.46",
"dist": {
"type"... | [
"composer.lock",
"src/PhpSpreadsheet/Calculation/Calculation.php",
"src/PhpSpreadsheet/Calculation/DateTimeExcel/DateValue.php",
"src/PhpSpreadsheet/Calculation/Engine/Logger.php",
"src/PhpSpreadsheet/Calculation/Statistical/Percentiles.php",
"src/PhpSpreadsheet/Calculation/TextData/Concatenate.php",
"s... | [] | diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/ChooseTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/ChooseTest.php
index 857495079e..a05854496f 100644
--- a/tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/ChooseTest.php
+++ b/tests/PhpSpreadsheetTests/Calculation/... | true | |
PHPOffice/PhpSpreadsheet | 4,845 | issue_to_patch | More Extendability for CSV Reader | A follow-up to PR #4837. PR #4827, to which I am not necessarily committed, shows that there could be a use case for letting a user perform customized logic to convert a non-UTF8-encoded CSV. In addition, several other CSV Reader properties require the use of static or locale properties, which is somewhat problematic; ... | 6f23fe3d8c3b2604360bbc4d1778a1f41d6c1d52 | 5d6d7d537f941ecfff5990f33558bad74d075be5 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7418e41927..28163b307a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,9 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Added
+- Make Reader/Csv Extendable, add new preferred Reader/CsvNoEscape class. [Issue #4836](http... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Cell/Cell.php",
"src/PhpSpreadsheet/Reader/BaseReader.php",
"src/PhpSpreadsheet/Reader/Csv.php",
"src/PhpSpreadsheet/Writer/Xls/Worksheet.php",
"tests/PhpSpreadsheetTests/Reader/Csv/CsvIconv2.php",
"tests/PhpSpreadsheetTests/Reader/Csv/CsvNumberFormatInstanceTest.php"... | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Csv/CsvIconv2.php b/tests/PhpSpreadsheetTests/Reader/Csv/CsvIconv2.php
new file mode 100644
index 0000000000..7ee9827df9
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Reader/Csv/CsvIconv2.php
@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpOffice\PhpSpre... | true | |
PHPOffice/PhpSpreadsheet | 4,844 | issue_to_patch | XLOOKUP
This is:
- [ ] a bug report
- [X] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)
```
### What is the expected behavior?
Is the new formula "XLOOKUP" recently introduced on Office ... | XLOOKUP | Fix #1453, which went stale in 2000, which I unstaled in 2024, and which I finally got to. The code, and several unit tests, was substantially generated by AI, my first foray into that frontier.
Trait `ArrayEnabled` is not able to handle this function because it has too many array parameters. I would have liked to u... | e2927cfa715e9dfd0a717ab8a901095a79292a07 | 78a151d340b239eb8b432b0ace09c02af4499095 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce0059bc74..7418e41927 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Added
+- XLOOKUP function. [Issue #1453](https://github.com/PHPOffice/PhpSpreadsheet/issues/1453) [... | [
"CHANGELOG.md",
"docs/references/function-list-by-category.md",
"docs/references/function-list-by-name-compact.md",
"docs/references/function-list-by-name.md",
"src/PhpSpreadsheet/Calculation/FunctionArray.php",
"src/PhpSpreadsheet/Calculation/LookupRef/XLookup.php",
"tests/PhpSpreadsheetTests/Calculati... | [] | diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/XLookupTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/XLookupTest.php
new file mode 100644
index 0000000000..0dd51e680b
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/XLookupTest.php
@@ -0,0 +1,16... | true |
PHPOffice/PhpSpreadsheet | 4,854 | issue_to_patch | Option to Whitelist External Images r129 | This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ] Commit message explains **why** the c... | b6c44a4ce907c4a861db040999eb58fb59570c14 | d1109c985802b121c1c105f66cbb4343e0604921 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e254ddc3ec..5bf118bf6c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com)
and this project adheres to [Semantic Versionin... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/BaseReader.php",
"src/PhpSpreadsheet/Reader/Html.php",
"src/PhpSpreadsheet/Reader/Xlsx.php",
"src/PhpSpreadsheet/Worksheet/Drawing.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php",
"tests... | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
index d703f2bf79..cf21554b56 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
@@ -1,5 +1,7 @@
<?php
+declare(strict_type... | true | |
PHPOffice/PhpSpreadsheet | 4,853 | issue_to_patch | Option to Whitelist External Images 3.10.x | This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ] Commit message explains **why** the c... | 1eb5deca30b529393da75ab05ae00e5069b5c277 | f2ddd62655157b265e34b46c43f9a00acf4f624d | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9012d8ce0f..8a960662d0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com)
and this project adheres to [Semantic Versionin... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/BaseReader.php",
"src/PhpSpreadsheet/Reader/Html.php",
"src/PhpSpreadsheet/Reader/Xlsx.php",
"src/PhpSpreadsheet/Worksheet/Drawing.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php",
"tests... | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
index 0a8dfeb339..cf21554b56 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
@@ -31,4 +31,15 @@ public static function loa... | true | |
PHPOffice/PhpSpreadsheet | 4,852 | issue_to_patch | Option to Whitelist External Images 2.4.x | This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ] Commit message explains **why** the c... | 1f8d2fd7f2709fb63c495c3b30d601796fded029 | bf718cb6326fe769d2512e2c58f153071ed307eb | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd95b7db2b..e44f7f1c60 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com)
and this project adheres to [Semantic Versionin... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/BaseReader.php",
"src/PhpSpreadsheet/Reader/Html.php",
"src/PhpSpreadsheet/Reader/Xlsx.php",
"src/PhpSpreadsheet/Worksheet/Drawing.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php",
"tests... | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
index 0a8dfeb339..cf21554b56 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
@@ -31,4 +31,15 @@ public static function loa... | true | |
PHPOffice/PhpSpreadsheet | 4,851 | issue_to_patch | Option to Whitelist External Images | This is:
- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
- [ ] Code style is respected
- [ ] Commit message explains **why** the c... | 4331d3af1b276b1e40b85a349f57134e81d7d6a5 | 4e2826bd331687589895f32650e838765601d37e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e089d8795d..43658c4462 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com)
and this project adheres to [Semantic Versionin... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/BaseReader.php",
"src/PhpSpreadsheet/Reader/Html.php",
"src/PhpSpreadsheet/Reader/Xlsx.php",
"src/PhpSpreadsheet/Worksheet/Drawing.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php",
"tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php",
"tests... | [] | diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
index 0a8dfeb339..cf21554b56 100644
--- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
+++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlHelper.php
@@ -31,4 +31,15 @@ public static function loa... | true | |
PHPOffice/PhpSpreadsheet | 4,849 | issue_to_patch | Bump tecnickcom/tcpdf from 6.11.0 to 6.11.2 | Bumps [tecnickcom/tcpdf](https://github.com/tecnickcom/TCPDF) from 6.11.0 to 6.11.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tecnickcom/TCPDF/blob/main/CHANGELOG.TXT">tecnickcom/tcpdf's changelog</a>.</em></p>
<blockquote>
<p>6.11.2 (2026-03-03)</p>
<ul>
<li>Refactor setCo... | d16e20d915b28b106489906ab60f75314b52cf54 | f7de90492b63c48071a9849df7b3652d0503fe73 | diff --git a/composer.lock b/composer.lock
index ec66add442..acc34b0357 100644
--- a/composer.lock
+++ b/composer.lock
@@ -5563,16 +5563,16 @@
},
{
"name": "tecnickcom/tcpdf",
- "version": "6.11.0",
+ "version": "6.11.2",
"source": {
"ty... | [
"composer.lock"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,848 | issue_to_patch | Bump dompdf/dompdf from 3.1.4 to 3.1.5 | Bumps [dompdf/dompdf](https://github.com/dompdf/dompdf) from 3.1.4 to 3.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dompdf/dompdf/releases">dompdf/dompdf's releases</a>.</em></p>
<blockquote>
<h2>Dompdf 3.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Fixes issue with init... | d16e20d915b28b106489906ab60f75314b52cf54 | 6c0e8188451590b1f71e3fa3909b9c121ec63e62 | diff --git a/composer.lock b/composer.lock
index ec66add442..27da7c8c35 100644
--- a/composer.lock
+++ b/composer.lock
@@ -628,16 +628,16 @@
},
{
"name": "dompdf/dompdf",
- "version": "v3.1.4",
+ "version": "v3.1.5",
"source": {
"type": ... | [
"composer.lock"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,846 | issue_to_patch | Bump mpdf/mpdf from 8.2.7 to 8.3.1 | Bumps [mpdf/mpdf](https://github.com/mpdf/mpdf) from 8.2.7 to 8.3.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/mpdf/mpdf/blob/development/CHANGELOG.md">mpdf/mpdf's changelog</a>.</em></p>
<blockquote>
<h1>mPDF 8.3.x</h1>
<h2>New features</h2>
<ul>
<li>Refactored CssManager (... | d16e20d915b28b106489906ab60f75314b52cf54 | 989a4d25a592076052db62f2037ab19f05b6a249 | diff --git a/composer.lock b/composer.lock
index ec66add442..087ee7fef1 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1117,16 +1117,16 @@
},
{
"name": "mpdf/mpdf",
- "version": "v8.2.7",
+ "version": "v8.3.1",
"source": {
"type": "g... | [
"composer.lock"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 2,326 | issue_to_patch | [FEATURE] Ability to stream to an Amazon S3 bucket | Related #2249
This is:
```
- [ ] a bugfix
- [x] a new feature
```
**Requirements**
`composer required aws/aws-sdk-php`
**Example**
```
require '../vendor/autoload.php';
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Xlsx;
$client = new Aws\S3\S3Client([
'cr... | 86a8bbdd635e3768e561321d46b72a900bdb7c2e | 17d54d27d698a7b52a916d8e327e11de78ec08b5 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 96cb58d8c5..eeb235d99b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -28,6 +28,8 @@ and this project adheres to [Semantic Versioning](https://semver.org).
- More flexibility in the StringValueBinder to determine what datatypes should be treated as strings [PR #2138](htt... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Writer/BaseWriter.php"
] | [] | true | ||
PHPOffice/PhpSpreadsheet | 4,843 | issue_to_patch | Refactor hyperlink URL assignment logic | Properly detect URLs with an anchor, like `https://example.com/#anchor` and don't convert them into an "internal" URL.
This is:
- [x] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests
Checklist:
- [ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit... | eb391d1f2218905212fd9ba867c36f53f4f24d64 | eeabef74a4d61b803b900e63e94deea2f1e3b2a0 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f71b482117..765b86b5af 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
- Ods Reader/Writer Integer Styles with Leading Zeros. [Issue #1606](https://github.com/PHPOffice/PhpSpre... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php",
"tests/PhpSpreadsheetTests/Reader/Xlsx/HyperlinkTest.php",
"tests/data/Reader/XLSX/issue.4842.xlsx"
] | [
{
"comment": "Indentation in this block uses tabs and includes trailing whitespace, which is inconsistent with the surrounding 4-space indentation in this file and may fail linters/CS checks. Reformat lines 49-60 to use spaces and remove trailing whitespace.\n```suggestion\n if (isset($linkRel['id'])... | diff --git a/tests/PhpSpreadsheetTests/Reader/Xlsx/HyperlinkTest.php b/tests/PhpSpreadsheetTests/Reader/Xlsx/HyperlinkTest.php
index 11f11ed3a1..e7b26f964c 100644
--- a/tests/PhpSpreadsheetTests/Reader/Xlsx/HyperlinkTest.php
+++ b/tests/PhpSpreadsheetTests/Reader/Xlsx/HyperlinkTest.php
@@ -5,6 +5,7 @@
namespace PhpOff... | true | |
PHPOffice/PhpSpreadsheet | 4,843 | comment_to_fix | Refactor hyperlink URL assignment logic | Indentation in this block uses tabs and includes trailing whitespace, which is inconsistent with the surrounding 4-space indentation in this file and may fail linters/CS checks. Reformat lines 49-60 to use spaces and remove trailing whitespace.
```suggestion
if (isset($linkRel['id'])) {
$hyp... | eb391d1f2218905212fd9ba867c36f53f4f24d64 | eeabef74a4d61b803b900e63e94deea2f1e3b2a0 | diff --git a/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php b/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php
index 87c00a4a30..f9d7218059 100644
--- a/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php
+++ b/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php
@@ -44,13 +44,19 @@ private function setHyperlink(SimpleXMLElement $hyper... | [
"src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php"
] | [
{
"comment": "Indentation in this block uses tabs and includes trailing whitespace, which is inconsistent with the surrounding 4-space indentation in this file and may fail linters/CS checks. Reformat lines 49-60 to use spaces and remove trailing whitespace.\n```suggestion\n if (isset($linkRel['id'])... | true | ||
PHPOffice/PhpSpreadsheet | 4,843 | comment_to_fix | Refactor hyperlink URL assignment logic | This change fixes a real-world XLSX structure where Excel splits external hyperlinks with fragments into a relationship target plus a separate `location` attribute. The existing Xlsx Hyperlink test only covers write->reload for `https://...#anchor` (which PhpSpreadsheet itself writes without `location`), so it won’t ca... | eb391d1f2218905212fd9ba867c36f53f4f24d64 | eeabef74a4d61b803b900e63e94deea2f1e3b2a0 | diff --git a/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php b/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php
index 87c00a4a30..f9d7218059 100644
--- a/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php
+++ b/src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php
@@ -44,13 +44,19 @@ private function setHyperlink(SimpleXMLElement $hyper... | [
"src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php"
] | [
{
"comment": "This change fixes a real-world XLSX structure where Excel splits external hyperlinks with fragments into a relationship target plus a separate `location` attribute. The existing Xlsx Hyperlink test only covers write->reload for `https://...#anchor` (which PhpSpreadsheet itself writes without `loca... | true | ||
PHPOffice/PhpSpreadsheet | 4,824 | issue_to_patch | Examine Performance of Clone vs Serialize/Unserialize | ## Summary
- Replaces `unserialize(serialize($this))` in `Spreadsheet::copy()` with `clone $this`, leveraging the existing `__clone()` method
- The existing `__clone()` already handles deep cloning of worksheets, calculation engine, styles, defined names, and re-wiring parent references
- Significantly reduces memory s... | eb391d1f2218905212fd9ba867c36f53f4f24d64 | e750f1a472456cd66af904f3cfb3f7e9bf9a7925 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f71b482117..7bd2663b64 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Added
+- Introduction of a benchmark test suite, independent of the default unit test suite. Users ... | [
"CHANGELOG.md",
"composer.json",
"phpunit.xml.dist",
"src/PhpSpreadsheet/Spreadsheet.php",
"tests/Benchmark/SpreadsheetCopyBenchmarkTest.php",
"tests/PhpSpreadsheetTests/SpreadsheetCopyCloneTest.php"
] | [] | diff --git a/tests/Benchmark/SpreadsheetCopyBenchmarkTest.php b/tests/Benchmark/SpreadsheetCopyBenchmarkTest.php
new file mode 100644
index 0000000000..8a39cef934
--- /dev/null
+++ b/tests/Benchmark/SpreadsheetCopyBenchmarkTest.php
@@ -0,0 +1,205 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpOffice\PhpSpreadshe... | true | |
PHPOffice/PhpSpreadsheet | 4,839 | issue_to_patch | Color Scale Broken >= 5.4.0
PHPSpreadsheet color scales are broken under certain conditions since PHPSpreadsheet 5.4.0. The example below works in PHPSpreadsheet 5.3.0, but does not in 5.4.0. It seems like you need a lot of decimal places in order to trigger the bug.
```php
<?php
require 'vendor/autoload.php';
use ... | Some Problems with Conditional Colorscale for Html | Fix #4838. Some processing of Html Conditional Formatting which worked with PhpSpreadsheet 5.3 does not work with 5.4. There are 2 problems. The first was caused by PR 4763, which moved some code out of Html Writer to an easier-to-access location. One of the intermediate variables in Html Writer was not available in th... | 2d644e9ac3b83a57148f0d30cb8c450b1157ce78 | 0c1ad4ef03aa74f175adf1d38656289b375bb126 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0cfac70fd3..f71b482117 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org). Thia is a
### Fixed
- Consistent handling of row and column limits. [PR #4820](https://github.com/PHPOffice/PhpS... | [
"CHANGELOG.md",
"src/PhpSpreadsheet/Style/ConditionalFormatting/ConditionalColorScale.php",
"tests/PhpSpreadsheetTests/Writer/Html/HtmlConditionalFormattingTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetTests/Writer/Html/HtmlConditionalFormattingTest.php b/tests/PhpSpreadsheetTests/Writer/Html/HtmlConditionalFormattingTest.php
index c5a31e415c..e258d69d2d 100644
--- a/tests/PhpSpreadsheetTests/Writer/Html/HtmlConditionalFormattingTest.php
+++ b/tests/PhpSpreadsheetTests/Writer/Html/Htm... | true |
PX4/PX4-Autopilot | 27,642 | issue_to_patch | fix(bootloader): scrub uncorrectable flash ECC errors on STM32H7 before boot | ## Summary
Adds a bootloader ECC scrub for STM32H7: before booting the app, DMA-scan the application and parameter flash and erase any sector holding an uncorrectable ECC error. Includes a bench tool (`Tools/flash_fault_injection/`) that plants the fault to validate the scrub and recovery on hardware.
## Problem
A... | 6fddba4037a095371534d4cca8f22b096d5e1f54 | 2d92399f504d7cd5a72e68b492174d749ac117e5 | diff --git a/Tools/flash_fault_injection/.gitignore b/Tools/flash_fault_injection/.gitignore
new file mode 100644
index 000000000000..53719a3a52a8
--- /dev/null
+++ b/Tools/flash_fault_injection/.gitignore
@@ -0,0 +1,3 @@
+# Build artifacts from brick_ecc.sh
+*.elf
+*.bin
diff --git a/Tools/flash_fault_injection/README... | [
"Tools/flash_fault_injection/.gitignore",
"Tools/flash_fault_injection/README.md",
"Tools/flash_fault_injection/brick_ecc.c",
"Tools/flash_fault_injection/brick_ecc.sh",
"platforms/nuttx/src/bootloader/stm/stm32_common/main.c",
"platforms/nuttx/src/bootloader/stm/stm32h7/CMakeLists.txt",
"platforms/nutt... | [
{
"comment": "out of curiosity: why this \"no-op\", did the compiler complain?",
"path": "platforms/nuttx/src/bootloader/stm/stm32h7/ecc_scrub.c",
"hunk": "@@ -0,0 +1,155 @@\n+/*\n+ * STM32H7 flash ECC scrub.\n+ *\n+ * A torn write to a flash row (power lost mid program/erase) can leave it with\n+ * inc... | true | ||
PX4/PX4-Autopilot | 27,642 | comment_to_fix | fix(bootloader): scrub uncorrectable flash ECC errors on STM32H7 before boot | out of curiosity: why this "no-op", did the compiler complain? | 6fddba4037a095371534d4cca8f22b096d5e1f54 | 2d92399f504d7cd5a72e68b492174d749ac117e5 | diff --git a/platforms/nuttx/src/bootloader/stm/stm32h7/ecc_scrub.c b/platforms/nuttx/src/bootloader/stm/stm32h7/ecc_scrub.c
new file mode 100644
index 000000000000..d795718bcd1c
--- /dev/null
+++ b/platforms/nuttx/src/bootloader/stm/stm32h7/ecc_scrub.c
@@ -0,0 +1,155 @@
+/*
+ * STM32H7 flash ECC scrub.
+ *
+ * A torn ... | [
"platforms/nuttx/src/bootloader/stm/stm32h7/ecc_scrub.c"
] | [
{
"comment": "out of curiosity: why this \"no-op\", did the compiler complain?",
"path": "platforms/nuttx/src/bootloader/stm/stm32h7/ecc_scrub.c",
"hunk": "@@ -0,0 +1,155 @@\n+/*\n+ * STM32H7 flash ECC scrub.\n+ *\n+ * A torn write to a flash row (power lost mid program/erase) can leave it with\n+ * inc... | true | ||
PX4/PX4-Autopilot | 27,659 | issue_to_patch | fix(sensors): disable SENS_MAG_AUTOCAL by default, keep for CAN nodes | With `SENS_MAG_AUTOCAL=1`, an uncalibrated mag saves an "initial calibration" — including `CAL_MAGn_ID` — about 30 s after the disarmed bias estimator stabilizes. A brand-new board marks itself compass-calibrated just from being handled on the bench, so ground stations that detect "compass calibration required" from `C... | f029c5df26bbf5cad0e6b17cae6f9deee7b7705c | 1a5615951f2844faa95d8d5a8e1a973497a83b62 | diff --git a/ROMFS/cannode/init.d/rcS b/ROMFS/cannode/init.d/rcS
index 0f88c7a70ad4..73fc7d0c5956 100644
--- a/ROMFS/cannode/init.d/rcS
+++ b/ROMFS/cannode/init.d/rcS
@@ -107,6 +107,8 @@ then
# conservative mag bias estimation
param set-default MBE_LEARN_GAIN 5
param set-default IMU_GYRO_CUTOFF 20
+ # nodes have ... | [
"ROMFS/cannode/init.d/rcS",
"src/modules/sensors/sensor_params_mag.yaml"
] | [] | true | ||
PX4/PX4-Autopilot | 27,655 | issue_to_patch | fix(parameters): fix param_value_is_default float comparisoin | ### Solved Problem
Approximate float equality was evaluated without wrapping in `fabsf`, so effectively it becomes `lhs < rhs`, completely the wrong semantics for comparing parameters to defaults.
This went unnoticed for quite long because it affects only display: `param_value_is_default` is only used in a handf... | add48c25a6faf15fd8149238870989de37fd1504 | 1f0b71f40cf8de3de02b71411aa2d31353d7a7d1 | diff --git a/src/lib/parameters/parameters.cpp b/src/lib/parameters/parameters.cpp
index 3aa317fdcfc0..096b27fa76e0 100644
--- a/src/lib/parameters/parameters.cpp
+++ b/src/lib/parameters/parameters.cpp
@@ -377,7 +377,7 @@ bool param_value_is_default(param_t param)
}
case PARAM_TYPE_FLOAT: {
- return user_c... | [
"src/lib/parameters/parameters.cpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,566 | issue_to_patch | docs(docs): fix yarn linkcheck command adding required dependecies | <!--
### Solved Problem
Fixes #{Github issue ID}
### Solution
### Changelog Entry
For release notes:
```
Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...
```
### Alternatives
### Test coverage
### Context
Related links, screenshot bef... | 96e6fd0a46624449baae03246b65d2efb80fbccd | c1261e113954b3866efcf6c0bc6bb95eab41303f | diff --git a/docs/package.json b/docs/package.json
index a985019a0c8c..dc6d4843b3a5 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -27,7 +27,8 @@
"vue3-tabs-component": "^1.3.7"
},
"devDependencies": {
- "prettier": "^3.8.3"
+ "prettier": "^3.8.3",
+ "markdown_link_checker_sc": "^0.0.144"... | [
"docs/package.json",
"docs/yarn.lock"
] | [
{
"comment": "FYI only (note to self) I'm hoping to get prettier as a pre-commit hook. Isn't needed for linkcheck.",
"path": "docs/package.json",
"hunk": "@@ -27,7 +27,8 @@\n \"vue3-tabs-component\": \"^1.3.7\"\n },\n \"devDependencies\": {\n- \"prettier\": \"^3.8.3\"\n+ \"prettier\": \"^3... | true | ||
PX4/PX4-Autopilot | 27,566 | comment_to_fix | docs(docs): fix yarn linkcheck command adding required dependecies | FYI only (note to self) I'm hoping to get prettier as a pre-commit hook. Isn't needed for linkcheck. | 96e6fd0a46624449baae03246b65d2efb80fbccd | c1261e113954b3866efcf6c0bc6bb95eab41303f | diff --git a/docs/package.json b/docs/package.json
index a985019a0c8c..dc6d4843b3a5 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -27,7 +27,8 @@
"vue3-tabs-component": "^1.3.7"
},
"devDependencies": {
- "prettier": "^3.8.3"
+ "prettier": "^3.8.3",
+ "markdown_link_checker_sc": "^0.0.144"... | [
"docs/package.json"
] | [
{
"comment": "FYI only (note to self) I'm hoping to get prettier as a pre-commit hook. Isn't needed for linkcheck.",
"path": "docs/package.json",
"hunk": "@@ -27,7 +27,8 @@\n \"vue3-tabs-component\": \"^1.3.7\"\n },\n \"devDependencies\": {\n- \"prettier\": \"^3.8.3\"\n+ \"prettier\": \"^3... | true | ||
PX4/PX4-Autopilot | 27,566 | comment_to_fix | docs(docs): fix yarn linkcheck command adding required dependecies | These changes aren't needed - the current version should work just fine. | 96e6fd0a46624449baae03246b65d2efb80fbccd | c1261e113954b3866efcf6c0bc6bb95eab41303f | diff --git a/docs/package.json b/docs/package.json
index a985019a0c8c..dc6d4843b3a5 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -27,7 +27,8 @@
"vue3-tabs-component": "^1.3.7"
},
"devDependencies": {
- "prettier": "^3.8.3"
+ "prettier": "^3.8.3",
+ "markdown_link_checker_sc": "^0.0.144"... | [
"docs/package.json"
] | [
{
"comment": "These changes aren't needed - the current version should work just fine.",
"path": "docs/package.json",
"hunk": "@@ -13,7 +13,7 @@\n \"docs:gen_alt_sidebar_ubuntu\": \"python3 ./scripts/gen_alt_sidebar.py\",\n \"docs:get_alt_sidebar_windows\": \"python ./scripts/gen_alt_sidebar.py\... | true | ||
PX4/PX4-Autopilot | 27,660 | issue_to_patch | ci(flash-analysis): skip PR comment when flash delta is zero | #27473 made the flash-analysis workflow always post a PR comment because the ±50 byte threshold was hiding small-but-real deltas. That swung too far the other way: PRs with zero flash impact now get a comment too. This restores the suppression, but only when the VM diff is exactly 0 bytes on all targets — any non-zero ... | f029c5df26bbf5cad0e6b17cae6f9deee7b7705c | e58c67105f34edb92deff69a548605cd5c1a231e | diff --git a/.github/workflows/flash_analysis.yml b/.github/workflows/flash_analysis.yml
index 2b0f9784f2c1..0798bd4d08b2 100644
--- a/.github/workflows/flash_analysis.yml
+++ b/.github/workflows/flash_analysis.yml
@@ -155,12 +155,26 @@ jobs:
V6X-SUMMARY-MAP-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.output... | [
".github/workflows/flash_analysis.yml"
] | [] | true | ||
PX4/PX4-Autopilot | 27,657 | issue_to_patch | fix(boards): canhubk3 SD card config & initialization on LPSPI2 instead of LPSPI1 |
### Solved Problem
SD card not detected on the MR-CANHUBK3 with ADAP board (connected the SPI port on the ADAP to [P1B -SPI2 ](https://nxp.gitbook.io/mobilerobotics/flashing-guide/mr-canhubk3/connectors)on the MR-CANHUBK3)
<img width="768" height="276" alt="image" src="https://github.com/user-attachments/assets/5... | 920297e20b4a92c0db8eeacf398d3f15fb41efeb | f7bb9e351524174a10d04c32184da24434155ed2 | diff --git a/boards/nxp/mr-canhubk3/src/init.c b/boards/nxp/mr-canhubk3/src/init.c
index 15148c7845bc..2df6f8ecb5f7 100644
--- a/boards/nxp/mr-canhubk3/src/init.c
+++ b/boards/nxp/mr-canhubk3/src/init.c
@@ -46,7 +46,7 @@
#include <px4_platform_common/init.h>
#include <px4_platform/board_determine_hw_info.h>
-#if de... | [
"boards/nxp/mr-canhubk3/src/init.c"
] | [] | true | ||
PX4/PX4-Autopilot | 27,527 | issue_to_patch | fix(drvers/ins): InertialLabs. Bugfix and improvements | ### Solved Problem
Bugs are fixed. Now Mission-mode with InertialLabs-EAHRS with no EKF2-filter works good.
### Solution
- Errors in height measurement, local and global position have been fixed.
- Fixed timestamp in the sensor_selection message.
- Added estimator_status_flags message.
- Parse-algorithm was opt... | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/ILabs.cpp b/src/drivers/ins/ilabs/ILabs.cpp
index c994f4f3d30e..144c58f59bfb 100644
--- a/src/drivers/ins/ilabs/ILabs.cpp
+++ b/src/drivers/ins/ilabs/ILabs.cpp
@@ -51,7 +51,8 @@ constexpr uint64_t GPS_EPOCH_SECS = 315964800ULL;
constexpr uint8_t DECIMATION_VALUE = 20;
-uint64_t T... | [
"src/drivers/ins/ilabs/ILabs.cpp",
"src/drivers/ins/ilabs/ILabs.h",
"src/drivers/ins/ilabs/libilabs/include/data.h",
"src/drivers/ins/ilabs/libilabs/include/sensor.h",
"src/drivers/ins/ilabs/libilabs/src/sensor.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\nuse of undeclared identifier `` MODULE_NAME ``",
"path": "src/drivers/ins/ilabs/libilabs/include/sensor.h",
"hunk": "@@ -93,6 +98,10 @@ class Sensor {\n \tu... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
use of undeclared identifier `` MODULE_NAME `` | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/libilabs/include/sensor.h b/src/drivers/ins/ilabs/libilabs/include/sensor.h
index 504cabbc5317..74a8eec66af6 100644
--- a/src/drivers/ins/ilabs/libilabs/include/sensor.h
+++ b/src/drivers/ins/ilabs/libilabs/include/sensor.h
@@ -34,22 +34,26 @@
#pragma once
#include <pthread.h>
+#i... | [
"src/drivers/ins/ilabs/libilabs/include/sensor.h"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\nuse of undeclared identifier `` MODULE_NAME ``",
"path": "src/drivers/ins/ilabs/libilabs/include/sensor.h",
"hunk": "@@ -93,6 +98,10 @@ class Sensor {\n \tu... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | double → float → double loses 3 decimal places approx. maybe keep them double? You are introducing like a meter of error for logs and QGC. | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/ILabs.h b/src/drivers/ins/ilabs/ILabs.h
index df485c11f0db..8d21529c8916 100644
--- a/src/drivers/ins/ilabs/ILabs.h
+++ b/src/drivers/ins/ilabs/ILabs.h
@@ -50,6 +50,7 @@
#include <px4_platform_common/px4_work_queue/ScheduledWorkItem.hpp>
#include <uORB/Publication.hpp>
#include <uO... | [
"src/drivers/ins/ilabs/ILabs.h"
] | [
{
"comment": " double → float → double loses 3 decimal places approx. maybe keep them double? You are introducing like a meter of error for logs and QGC. ",
"path": "src/drivers/ins/ilabs/ILabs.h",
"hunk": "@@ -106,6 +107,11 @@ class ILabs : public ModuleBase, public ModuleParams, public px4::Scheduled... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | am very confused where this 7 secs came from. I dont think we can just throw a random number.
```suggestion
// wait 7 sec of good results to be sure pos is stable
const bool isOriginReady = (_origin_ready_since != 0) &&
hrt_elapsed_time(&_origin_ready_since) > 7_s;
``` | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/ILabs.cpp b/src/drivers/ins/ilabs/ILabs.cpp
index c994f4f3d30e..144c58f59bfb 100644
--- a/src/drivers/ins/ilabs/ILabs.cpp
+++ b/src/drivers/ins/ilabs/ILabs.cpp
@@ -51,7 +51,8 @@ constexpr uint64_t GPS_EPOCH_SECS = 315964800ULL;
constexpr uint8_t DECIMATION_VALUE = 20;
-uint64_t T... | [
"src/drivers/ins/ilabs/ILabs.cpp"
] | [
{
"comment": "am very confused where this 7 secs came from. I dont think we can just throw a random number. \n```suggestion\n\t\t\t// wait 7 sec of good results to be sure pos is stable\n\t\t\tconst bool isOriginReady = (_origin_ready_since != 0) &&\n\t\t\t\t\t\t hrt_elapsed_time(&_origin_ready_since) > 7_s;... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | nah. Please use math::min<uint16_t>(a, b) | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/libilabs/src/sensor.cpp b/src/drivers/ins/ilabs/libilabs/src/sensor.cpp
index ba6427536c9a..4286407507ed 100644
--- a/src/drivers/ins/ilabs/libilabs/src/sensor.cpp
+++ b/src/drivers/ins/ilabs/libilabs/src/sensor.cpp
@@ -33,6 +33,8 @@
#include "sensor.h"
+#include <mathlib/math/Li... | [
"src/drivers/ins/ilabs/libilabs/src/sensor.cpp"
] | [
{
"comment": "nah. Please use math::min<uint16_t>(a, b) ",
"path": "src/drivers/ins/ilabs/libilabs/src/sensor.cpp",
"hunk": "@@ -42,21 +42,49 @@\n #define MODULE_NAME \"ilabs_ins_driver\" // NOLINT(cppcoreguidelines-macro-usage)\n #endif\n \n+#ifndef MIN\n+#define MIN(a,b) ((a) < (b) ? (a) : (b))",
... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | mmm, cs_ev_* means "external vision fusing" (camera/VIO). Using these flags for a GNSS-aided INS may confuse log analysis tooling and QGC. | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/ILabs.cpp b/src/drivers/ins/ilabs/ILabs.cpp
index c994f4f3d30e..144c58f59bfb 100644
--- a/src/drivers/ins/ilabs/ILabs.cpp
+++ b/src/drivers/ins/ilabs/ILabs.cpp
@@ -51,7 +51,8 @@ constexpr uint64_t GPS_EPOCH_SECS = 315964800ULL;
constexpr uint8_t DECIMATION_VALUE = 20;
-uint64_t T... | [
"src/drivers/ins/ilabs/ILabs.cpp"
] | [
{
"comment": "mmm, cs_ev_* means \"external vision fusing\" (camera/VIO). Using these flags for a GNSS-aided INS may confuse log analysis tooling and QGC.",
"path": "src/drivers/ins/ilabs/ILabs.cpp",
"hunk": "@@ -530,6 +583,26 @@ void ILabs::processData(InertialLabs::SensorsData *data) {\n \t\testimator... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | What happened here? You are resetting to zero? | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/ILabs.cpp b/src/drivers/ins/ilabs/ILabs.cpp
index c994f4f3d30e..144c58f59bfb 100644
--- a/src/drivers/ins/ilabs/ILabs.cpp
+++ b/src/drivers/ins/ilabs/ILabs.cpp
@@ -51,7 +51,8 @@ constexpr uint64_t GPS_EPOCH_SECS = 315964800ULL;
constexpr uint8_t DECIMATION_VALUE = 20;
-uint64_t T... | [
"src/drivers/ins/ilabs/ILabs.cpp"
] | [
{
"comment": "What happened here? You are resetting to zero?",
"path": "src/drivers/ins/ilabs/ILabs.cpp",
"hunk": "@@ -498,20 +528,19 @@ void ILabs::processData(InertialLabs::SensorsData *data) {\n \t\tsensor_gps.vel_ned_valid = true;\n \n \t\tsensor_gps.time_utc_usec = ToUtcMicroseconds(data->gps.gpsWe... | true | ||
PX4/PX4-Autopilot | 27,527 | comment_to_fix | fix(drvers/ins): InertialLabs. Bugfix and improvements | So these are recommended by the manufacturer?? | 6fddba4037a095371534d4cca8f22b096d5e1f54 | ff316fa20c0e5dddf2df36eef0331ba4be6bd383 | diff --git a/src/drivers/ins/ilabs/ILabs.cpp b/src/drivers/ins/ilabs/ILabs.cpp
index c994f4f3d30e..144c58f59bfb 100644
--- a/src/drivers/ins/ilabs/ILabs.cpp
+++ b/src/drivers/ins/ilabs/ILabs.cpp
@@ -51,7 +51,8 @@ constexpr uint64_t GPS_EPOCH_SECS = 315964800ULL;
constexpr uint8_t DECIMATION_VALUE = 20;
-uint64_t T... | [
"src/drivers/ins/ilabs/ILabs.cpp"
] | [
{
"comment": "So these are recommended by the manufacturer??",
"path": "src/drivers/ins/ilabs/ILabs.cpp",
"hunk": "@@ -235,6 +248,9 @@ void ILabs::Run() {\n \t\treturn;\n \t}\n \n+\tconst hrt_abstime no_data_timeout = 3_s;\n+\tconst hrt_abstime after_error_timeout = 3_s;",
"resolving_sha": "ff316fa2... | true | ||
PX4/PX4-Autopilot | 27,605 | issue_to_patch | feat(drivers): implemented serial passthrough | ### Solved Problem
MAVLink `SERIAL_CONTROL` messages can be used to tunnel raw bytes to a specific UART
or ESC signal line for firmware flashing and configuration. PX4 had no
support for this — `SERIAL_CONTROL` messages were only handled for the
MAVLink shell, so ESC passthrough from a GCS was impossible.
### So... | add48c25a6faf15fd8149238870989de37fd1504 | dc30b32d493ad2d2803e16299ff712dd7c4aa913 | diff --git a/ROMFS/px4fmu_common/init.d/rcS b/ROMFS/px4fmu_common/init.d/rcS
index 8e44fecca3de..2d655e1208fc 100644
--- a/ROMFS/px4fmu_common/init.d/rcS
+++ b/ROMFS/px4fmu_common/init.d/rcS
@@ -539,8 +539,13 @@ else
else
commander start
- dshot start
- pwm_out start
+ if param compare -s PASSTHRU_EN 0
+ the... | [
"ROMFS/px4fmu_common/init.d/rcS",
"Tools/kconfig/allyesconfig.py",
"boards/auterion/fmu-v6s/default.px4board",
"boards/auterion/fmu-v6s/nuttx-config/nsh/defconfig",
"boards/auterion/fmu-v6x/default.px4board",
"boards/auterion/fmu-v6x/nuttx-config/nsh/defconfig",
"platforms/nuttx/src/px4/stm/stm32_common... | [
{
"comment": "Put the CTOR/DTOR at the top. Check how other drivers organize functions. It's usually in roughly this order: ctor, dtor, init, run, and then descending based on complexity (small helpers near the bottom). And then at the very bottom is all of the instantiate/print_status/main code.",
"path": ... | true | ||
PX4/PX4-Autopilot | 27,605 | comment_to_fix | feat(drivers): implemented serial passthrough | Put the CTOR/DTOR at the top. Check how other drivers organize functions. It's usually in roughly this order: ctor, dtor, init, run, and then descending based on complexity (small helpers near the bottom). And then at the very bottom is all of the instantiate/print_status/main code. | add48c25a6faf15fd8149238870989de37fd1504 | dc30b32d493ad2d2803e16299ff712dd7c4aa913 | diff --git a/src/drivers/serialpassthrough/serialpassthrough.cpp b/src/drivers/serialpassthrough/serialpassthrough.cpp
new file mode 100644
index 000000000000..eb0c4d7a314d
--- /dev/null
+++ b/src/drivers/serialpassthrough/serialpassthrough.cpp
@@ -0,0 +1,729 @@
+/*******************************************************... | [
"src/drivers/serialpassthrough/serialpassthrough.cpp"
] | [
{
"comment": "Put the CTOR/DTOR at the top. Check how other drivers organize functions. It's usually in roughly this order: ctor, dtor, init, run, and then descending based on complexity (small helpers near the bottom). And then at the very bottom is all of the instantiate/print_status/main code.",
"path": ... | true | ||
PX4/PX4-Autopilot | 27,605 | comment_to_fix | feat(drivers): implemented serial passthrough | I would not make this method part of the public API, especially as calling this alone does not do the spin on tx_busy until TX is finished, which does enable a race. | add48c25a6faf15fd8149238870989de37fd1504 | dc30b32d493ad2d2803e16299ff712dd7c4aa913 | diff --git a/src/drivers/drv_bitbang_uart.h b/src/drivers/drv_bitbang_uart.h
new file mode 100644
index 000000000000..e60ac16f973e
--- /dev/null
+++ b/src/drivers/drv_bitbang_uart.h
@@ -0,0 +1,95 @@
+/****************************************************************************
+ *
+ * Copyright (c) 2026 PX4 Developme... | [
"src/drivers/drv_bitbang_uart.h"
] | [
{
"comment": "I would not make this method part of the public API, especially as calling this alone does not do the spin on tx_busy until TX is finished, which does enable a race.",
"path": "src/drivers/drv_bitbang_uart.h",
"hunk": "@@ -0,0 +1,104 @@\n+/**************************************************... | true | ||
PX4/PX4-Autopilot | 27,605 | comment_to_fix | feat(drivers): implemented serial passthrough | After the `while` loop I would add this
```
STM32_TIM_SETMODE(uart.timer, STM32_TIM_MODE_DISABLED);
STM32_TIM_ACKINT(uart.timer, GTIM_SR_UIF);
```
otherwise in theory after line 339 a remaining RX transfer could still kick in and overwrite these values again. | add48c25a6faf15fd8149238870989de37fd1504 | dc30b32d493ad2d2803e16299ff712dd7c4aa913 | diff --git a/platforms/nuttx/src/px4/stm/stm32_common/bitbang_uart/bitbang_uart.cpp b/platforms/nuttx/src/px4/stm/stm32_common/bitbang_uart/bitbang_uart.cpp
new file mode 100644
index 000000000000..a783111c94b2
--- /dev/null
+++ b/platforms/nuttx/src/px4/stm/stm32_common/bitbang_uart/bitbang_uart.cpp
@@ -0,0 +1,534 @@
... | [
"platforms/nuttx/src/px4/stm/stm32_common/bitbang_uart/bitbang_uart.cpp"
] | [
{
"comment": "After the `while` loop I would add this\n```\nSTM32_TIM_SETMODE(uart.timer, STM32_TIM_MODE_DISABLED);\nSTM32_TIM_ACKINT(uart.timer, GTIM_SR_UIF);\n```\notherwise in theory after line 339 a remaining RX transfer could still kick in and overwrite these values again.",
"path": "platforms/nuttx/sr... | true | ||
PX4/PX4-Autopilot | 27,651 | issue_to_patch | fix(autotune): add missing state in ack progress feedback | ### Solved Problem
Ground station is displaying "Initializing" when amplitude detection is running as progress feedback goes back to 0.
### Solution
Add the missing enum states to send the correct progress. | f3f546cdd5d65359ab06685cf45f05b35407d7a6 | 65bcc1eec2c8da831291d532dde87fdf5da9719e | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index 9d271f25145d..c533772eaa83 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -764,16 +764,19 @@ void MavlinkReceiver::handle_message_command_both(mavlink_message_t... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,623 | issue_to_patch | fix(parameters): self-initialize blank parameter storage at boot | ## Summary
Blank parameter storage (first boot, or after switching firmware, e.g. ArduPilot → PX4 on an ARK FPV) now self-initializes silently at boot: it is detected as "not yet stored" rather than corruption, seeded from the SD backup or firmware defaults, and persisted. Only a genuinely corrupt store, a backup that ... | 6fddba4037a095371534d4cca8f22b096d5e1f54 | 028177a255c74018a3d1d4d03cbdd858c6f65ae7 | diff --git a/ROMFS/px4fmu_common/init.d/rcS b/ROMFS/px4fmu_common/init.d/rcS
index b6d517b45c2e..8e44fecca3de 100644
--- a/ROMFS/px4fmu_common/init.d/rcS
+++ b/ROMFS/px4fmu_common/init.d/rcS
@@ -195,10 +195,15 @@ else
param load /fs/mtd_caldata
fi
+ # Load parameters from storage. A blank store (first boot, or a... | [
"ROMFS/px4fmu_common/init.d/rcS",
"src/lib/parameters/flashparams/flashfs.c",
"src/lib/parameters/flashparams/flashfs.h",
"src/lib/parameters/flashparams/flashfs32.c",
"src/lib/parameters/flashparams/flashparams.cpp",
"src/lib/parameters/param.h",
"src/lib/parameters/parameters.cpp",
"src/modules/comm... | [] | diff --git a/src/systemcmds/tests/test_parameters.cpp b/src/systemcmds/tests/test_parameters.cpp
index 77b45ce55e8c..d223f8eb95a2 100644
--- a/src/systemcmds/tests/test_parameters.cpp
+++ b/src/systemcmds/tests/test_parameters.cpp
@@ -82,6 +82,8 @@ class ParameterTest : public UnitTest
bool ResetAllExcludesWildcard()... | true | |
PX4/PX4-Autopilot | 27,600 | issue_to_patch | feat(gz): update submodule, and add ridge docs | This adds the ridge world to test terrain following, and adds a doc entry with screenshot as well. | c94a06eba3eb34da305404210a748bd96315c19b | aaac46e9a53f943896456d0d6e5eee4c0ffb1bfe | diff --git a/Tools/simulation/gz b/Tools/simulation/gz
index 3eb05f716a81..bb0b9cf974ac 160000
--- a/Tools/simulation/gz
+++ b/Tools/simulation/gz
@@ -1,1 +1,1 @@
-Subproject commit 3eb05f716a81bca316ab5771f53e509a07dce3a6
+Subproject commit bb0b9cf974acf4f1bcb5f5fcf80b88841562dea9
diff --git a/docs/assets/simulation/g... | [
"Tools/simulation/gz",
"docs/assets/simulation/gazebo/worlds/ridge.png",
"docs/en/releases/1.18.md",
"docs/en/sim_gazebo_gz/index.md",
"docs/en/sim_gazebo_gz/worlds.md"
] | [] | true | ||
PX4/PX4-Autopilot | 27,523 | issue_to_patch | feat(drivers/imu/st/lsm6dsv): add LSM6DSV32X and LSM6DSK320X support | ### Solved Problem
The current lsm6dsv driver only supports `LSM6DSV16X`. `LSM6DSV32X` and `LSM6DSK320X` are compatible variants with the same FIFO/register architecture, but they need variant-specific identification and full-scale register encoding.
### Solution
Add `LSM6DSV32X` and `LSM6DSK320X` support to the... | 8100ba9045be58f79358d5d985ad62862e3e553c | 42a7fb3f8b0c38d605d74b06e2c86e05a4e9c38f | diff --git a/src/drivers/drv_sensor.h b/src/drivers/drv_sensor.h
index c14ea821fc38..729c41b7fbd1 100644
--- a/src/drivers/drv_sensor.h
+++ b/src/drivers/drv_sensor.h
@@ -70,12 +70,15 @@
#define DRV_MAG_DEVTYPE_AF9838 0x10
#define DRV_IMU_DEVTYPE_LSM303D 0x11
-#define DRV_IMU_DEVTYPE_ST_LSM6DSV 0x12
+#define DRV_... | [
"src/drivers/drv_sensor.h",
"src/drivers/imu/st/lsm6dsv/LSM6DSV.cpp",
"src/drivers/imu/st/lsm6dsv/LSM6DSV.hpp",
"src/drivers/imu/st/lsm6dsv/ST_LSM6DSV_Registers.hpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,634 | issue_to_patch | build(nuttx): include MX25L1606E NOR | To include this NuttX change: https://github.com/PX4/NuttX/pull/382.
This adds support for the mx25l1606e NOR FLASH which will be used on some boards. | d018063b19e593914249635135ebb2e3e8472817 | fb35dac77d209a0cce5248a3b167e822f011697e | diff --git a/platforms/nuttx/NuttX/nuttx b/platforms/nuttx/NuttX/nuttx
index d147b76c86af..3a6fcac51346 160000
--- a/platforms/nuttx/NuttX/nuttx
+++ b/platforms/nuttx/NuttX/nuttx
@@ -1,1 +1,1 @@
-Subproject commit d147b76c86af9f334756434af1f17630c1d4d296
+Subproject commit 3a6fcac5134642a82962491751bdc7b8f59667b2
| [
"platforms/nuttx/NuttX/nuttx"
] | [] | true | ||
PX4/PX4-Autopilot | 27,636 | issue_to_patch | docs(failsafe): clarify Offboard proof-of-life and COM_OBL_RC_ACT docs | ### Solved Problem
The Offboard documentation has two inconsistencies:
1. The proof-of-life text describes Offboard handling using fixed `2Hz` and `1 second` thresholds, which can be read as a strict runtime frequency check and accumulated pre-stream gate.
2. The documented `COM_OBL_RC_ACT` values are outdated: ... | 09eec8f9ae16e98caf6609e5e43a1ea799a6263e | 171e5a97b75cf7e00cb68d61ada6c072c9c1c2c4 | diff --git a/docs/en/config/safety.md b/docs/en/config/safety.md
index a103f740b38c..da15707ab52f 100644
--- a/docs/en/config/safety.md
+++ b/docs/en/config/safety.md
@@ -257,14 +257,13 @@ Loss of a single GPS when none are required is handled by other GPS health check
## Offboard Loss Failsafe
The _Offboard Loss F... | [
"docs/en/config/safety.md",
"docs/en/flight_modes/offboard.md"
] | [] | true | ||
PX4/PX4-Autopilot | 27,609 | issue_to_patch | Revert "fix(commander): refuse stale config_overrides on activation" | Reverts PX4/PX4-Autopilot#27520 | 9b25e6df339104bbcd666bd21007215376ca5d3b | b5dd53c89e00dd5ff4b06edd00c5bb981fcc14ed | diff --git a/src/modules/commander/Commander.cpp b/src/modules/commander/Commander.cpp
index a737191788dc..39ffa526e77a 100644
--- a/src/modules/commander/Commander.cpp
+++ b/src/modules/commander/Commander.cpp
@@ -2493,7 +2493,6 @@ void Commander::handleAutoDisarm()
bool Commander::handleModeIntentionAndFailsafe()
{... | [
"src/modules/commander/Commander.cpp",
"src/modules/commander/ModeManagement.cpp",
"src/modules/commander/ModeManagement.hpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,004 | issue_to_patch | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | As a first step for: https://github.com/PX4/PX4-Autopilot/pull/26973 (fyi @mrpollo).
VTOL rally-point land approaches are defined around the rally-point land location, but RTL was choosing between them using the bearing from home. That works only when the landing point is effectively home. For remote safe points it... | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/docs/en/flight_modes/return.md b/docs/en/flight_modes/return.md
index 3af824f93866..7c8ed45ca784 100644
--- a/docs/en/flight_modes/return.md
+++ b/docs/en/flight_modes/return.md
@@ -92,7 +92,11 @@ In this return type the vehicle:
- If the destination is a mission landing pattern it will follow the pattern... | [
"docs/en/flight_modes/return.md",
"docs/en/flight_modes_vtol/return.md",
"docs/en/releases/1.18.md",
"docs/en/releases/main.md",
"src/modules/navigator/rtl.cpp",
"src/modules/navigator/rtl.h",
"src/modules/navigator/rtl_params.yaml",
"src/modules/navigator/safe_point_land.hpp",
"src/modules/navigato... | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | diff --git a/src/modules/navigator/test/CMakeLists.txt b/src/modules/navigator/test/CMakeLists.txt
index a1e678f018ad..77a16a4331ed 100644
--- a/src/modules/navigator/test/CMakeLists.txt
+++ b/src/modules/navigator/test/CMakeLists.txt
@@ -34,3 +34,4 @@
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
px4_add_fun... | true | |
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Note that this check is now inside of `selectLandingApproach` to simplify `setRtlTypeAndDestination` and to avoid checking all approaches if we know we won't use them. | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "Note that this check is now inside of `selectLandingApproach` to simplify `setRtlTypeAndDestination` and to avoid checking all approaches if we know we won't use them. ",
"path": "src/modules/navigator/rtl.cpp",
"hunk": "@@ -378,18 +389,12 @@ void RTL::setRtlTypeAndDestination()\n \t\t} el... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Note that `setSafepointAsDestination` was replaced by `extractValidSafePointPosition` which returns false if the altitude frame is not valid or if the position is not valid. This change ensures we do not fly to an invalid approach. Especially important if we had other valid approaches. | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "Note that `setSafepointAsDestination` was replaced by `extractValidSafePointPosition` which returns false if the altitude frame is not valid or if the position is not valid. This change ensures we do not fly to an invalid approach. Especially important if we had other valid approaches. ",
"pat... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Note that instead of calling `hasVtolLandApproach(safepoint_position)` we now call `hasVtolLandApproach(current_seq, _home_pos_sub.get().alt)`. The important change here is the `current_seq`.
The old code would go through all land approahces starting from index zero (which is not efficient) meaning that if two rally ... | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "Note that instead of calling `hasVtolLandApproach(safepoint_position)` we now call `hasVtolLandApproach(current_seq, _home_pos_sub.get().alt)`. The important change here is the `current_seq`. \n\nThe old code would go through all land approahces starting from index zero (which is not efficient) me... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Note that the `loadWait` call was updated to include the standard `500_ms` timeout | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "Note that the `loadWait` call was updated to include the standard `500_ms` timeout",
"path": "src/modules/navigator/rtl.cpp",
"hunk": "@@ -693,94 +704,181 @@ bool RTL::reverseIsFurther() const\n }\n \n \n-bool RTL::hasVtolLandApproach(const PositionYawSetpoint &rtl_position) const\n+bool R... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,146 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,960 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` gtest/gtest.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` gtest/gtest.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,960 @@\n+/**************************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | What exactly does this null island check protect against, is there a case where we have lat/lon of exactly zero which needs to be considered invalid? As far as I can see this was not checked before. Could you add a comment explaining why this is done (or remove if unnecessary)?
Also, if exact zero is the invalid case... | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "What exactly does this null island check protect against, is there a case where we have lat/lon of exactly zero which needs to be considered invalid? As far as I can see this was not checked before. Could you add a comment explaining why this is done (or remove if unnecessary)? \n\nAlso, if exact ... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | This is not very related to your changes but more a general question - does an altitude relative to home make sense if rally points can be arbitrarily far away? I guess we have NAV_MIN_GND_DIST to protect against the worst but it could still be confusing for users | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "This is not very related to your changes but more a general question - does an altitude relative to home make sense if rally points can be arbitrarily far away? I guess we have NAV_MIN_GND_DIST to protect against the worst but it could still be confusing for users",
"path": "src/modules/naviga... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Double checking: Is the removal of this error intentional? As far as I can see in the caller we fall back to just not using the rally point | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/rtl.cpp b/src/modules/navigator/rtl.cpp
index d2dc738f6ba5..17127d1440b3 100644
--- a/src/modules/navigator/rtl.cpp
+++ b/src/modules/navigator/rtl.cpp
@@ -53,6 +53,7 @@ using matrix::wrap_pi;
static constexpr float MAX_DIST_FROM_HOME_FOR_LAND_APPROACHES{10.0f}; // [m] We don't con... | [
"src/modules/navigator/rtl.cpp"
] | [
{
"comment": "Double checking: Is the removal of this error intentional? As far as I can see in the caller we fall back to just not using the rally point",
"path": "src/modules/navigator/rtl.cpp",
"hunk": "@@ -552,31 +555,40 @@ void RTL::setLandPosAsDestination(PositionYawSetpoint &rtl_position, mission... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/home_position.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/home_position.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,960 @@\n+/************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/home_position.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/home_position.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,960 @@\n+/************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/home_position.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/home_position.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,937 @@\n+/************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/home_position.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/home_position.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,937 @@\n+/************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/vehicle_status.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/vehicle_status.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,936 @@\n+/***********************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/wind.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/wind.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,935 @@\n+/*********************************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/vehicle_status.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/vehicle_status.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,937 @@\n+/***********************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/vehicle_status.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/vehicle_status.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,937 @@\n+/***********************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/vehicle_status.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/vehicle_status.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,937 @@\n+/***********************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | **[error]** [**clang\-diagnostic\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**
`` uORB/topics/vehicle_status.h `` file not found | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/src/modules/navigator/test/test_RTL.cpp b/src/modules/navigator/test/test_RTL.cpp
new file mode 100644
index 000000000000..c3128fa0c702
--- /dev/null
+++ b/src/modules/navigator/test/test_RTL.cpp
@@ -0,0 +1,937 @@
+/****************************************************************************
+ *
+ * Copy... | [
"src/modules/navigator/test/test_RTL.cpp"
] | [
{
"comment": "**[error]** [**clang\\-diagnostic\\-error**](https://clang.llvm.org/extra/clang-tidy/checks/clang/diagnostic-error.html) **[error]**\n`` uORB/topics/vehicle_status.h `` file not found",
"path": "src/modules/navigator/test/test_RTL.cpp",
"hunk": "@@ -0,0 +1,937 @@\n+/***********************... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Is RTL_MISSION_FAST (and so on) an actual identifier? If you mean RTL_TYPE then link to those please. | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/docs/en/releases/main.md b/docs/en/releases/main.md
index 26a8dbdab8c0..c215bf157b45 100644
--- a/docs/en/releases/main.md
+++ b/docs/en/releases/main.md
@@ -34,6 +34,8 @@ Please continue reading for [upgrade instructions](#upgrade-guide).
## Other changes
+- Fast mission Return modes ([RTL_TYPE](../a... | [
"docs/en/releases/main.md"
] | [
{
"comment": "Is RTL_MISSION_FAST (and so on) an actual identifier? If you mean RTL_TYPE then link to those please.",
"path": "docs/en/releases/main.md",
"hunk": "@@ -34,6 +34,8 @@ Please continue reading for [upgrade instructions](#upgrade-guide).\n \n ## Other changes\n \n+- RTL_MISSION_FAST and RTL_M... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | This is cool. Just to be clear, if you had 2 rally points and all the other conditions said you had to land at one, it would pick the one that ws best to land at based on the wind?
If so, that's what this says so no change needed. | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/docs/en/flight_modes/return.md b/docs/en/flight_modes/return.md
index 3af824f93866..7c8ed45ca784 100644
--- a/docs/en/flight_modes/return.md
+++ b/docs/en/flight_modes/return.md
@@ -92,7 +92,11 @@ In this return type the vehicle:
- If the destination is a mission landing pattern it will follow the pattern... | [
"docs/en/flight_modes/return.md"
] | [
{
"comment": "This is cool. Just to be clear, if you had 2 rally points and all the other conditions said you had to land at one, it would pick the one that ws best to land at based on the wind?\n\nIf so, that's what this says so no change needed.",
"path": "docs/en/flight_modes/return.md",
"hunk": "@@ ... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | "[VTOL FW only] If set, home or rally-point RTL destinations are only considered when a valid VTOL approach loiter is defined for that landing location." - what does the term "valid VTOL approach loiter is define for ..." mean?
Note, this might be provided by other context in this page - I'm only seeing the changes r... | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/docs/en/flight_modes/return.md b/docs/en/flight_modes/return.md
index 3af824f93866..7c8ed45ca784 100644
--- a/docs/en/flight_modes/return.md
+++ b/docs/en/flight_modes/return.md
@@ -92,7 +92,11 @@ In this return type the vehicle:
- If the destination is a mission landing pattern it will follow the pattern... | [
"docs/en/flight_modes/return.md"
] | [
{
"comment": "\"[VTOL FW only] If set, home or rally-point RTL destinations are only considered when a valid VTOL approach loiter is defined for that landing location.\" - what does the term \"valid VTOL approach loiter is define for ...\" mean? \n\nNote, this might be provided by other context in this page - I... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | FYI moved from main to here, because we should get this in today. | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/docs/en/releases/1.18.md b/docs/en/releases/1.18.md
index c13bdaf15013..77a8579e191f 100644
--- a/docs/en/releases/1.18.md
+++ b/docs/en/releases/1.18.md
@@ -120,7 +120,7 @@ Please continue reading for [upgrade instructions](#upgrade-guide).
### VTOL
-- TBD
+- [Return mode VTOL Rally Point Approach Lo... | [
"docs/en/releases/1.18.md"
] | [
{
"comment": "FYI moved from main to here, because we should get this in today.",
"path": "docs/en/releases/1.18.md",
"hunk": "@@ -120,7 +120,7 @@ Please continue reading for [upgrade instructions](#upgrade-guide).\n \n ### VTOL\n \n-- TBD\n+- [Return mode VTOL Rally Point Approach Loiters](../flight_mo... | true | ||
PX4/PX4-Autopilot | 27,004 | comment_to_fix | fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location | Do you set the heading and xtrack fields? I imagine you specify that it should head to the next point (the rally point) following the direct xtrack (or does it try for the centre xtrack?).
Below I added a tip that this is not defined in the MAVLink specification. I think this feature is cool but the fact we've just g... | a2be9197b57b2d065e4c47ca7fc5b7565ee07282 | b6a9c6c287b7b5c74d86fff897827b5af17759c6 | diff --git a/docs/en/flight_modes_vtol/return.md b/docs/en/flight_modes_vtol/return.md
index 46ec8ec1e41d..655114a29b64 100644
--- a/docs/en/flight_modes_vtol/return.md
+++ b/docs/en/flight_modes_vtol/return.md
@@ -7,7 +7,7 @@ The _Return_ flight mode is used to _fly a vehicle to safety_ on an unobstructed
VTOL vehicl... | [
"docs/en/flight_modes_vtol/return.md"
] | [
{
"comment": "Do you set the heading and xtrack fields? I imagine you specify that it should head to the next point (the rally point) following the direct xtrack (or does it try for the centre xtrack?). \n\nBelow I added a tip that this is not defined in the MAVLink specification. I think this feature is cool b... | true | ||
PX4/PX4-Autopilot | 27,635 | issue_to_patch | fix(tools/uploader): handle device re-enumeration on reboot | ## Summary
Make the firmware uploader survive the USB CDC device re-enumerating when a board reboots into or out of its bootloader, and actually confirm the post-upload reboot instead of assuming it succeeded.
## Problem
Both issues reproduce reliably when flashing PX4 onto a board running ArduPilot, where the MAVLi... | 5e6785b4f8a7532609f5806e5d3f3457b5b601b4 | c7d3c94328929b9a6856ff34f6c08039b34d605e | diff --git a/Tools/px4_uploader.py b/Tools/px4_uploader.py
index 0301280cfb79..a00d34a0207e 100755
--- a/Tools/px4_uploader.py
+++ b/Tools/px4_uploader.py
@@ -78,6 +78,21 @@
print("\nInstall it with: python -m pip install pyserial", file=sys.stderr)
sys.exit(1)
+# pyserial's POSIX backend implements flush()... | [
"Tools/px4_uploader.py"
] | [] | true | ||
PX4/PX4-Autopilot | 27,632 | issue_to_patch | submodule(drivers/gps): update PX4-GPSDrivers submodule to latest | Updates the `src/drivers/gps/devices` submodule (PX4-GPSDrivers) to the latest `main` (`52bc6ec`), pulling in two upstream changes:
- fix(ubx): tolerate CFG-ODO-* removal on ZED-X20P (HPG 2.10+) ([PX4-GPSDrivers#213](https://github.com/PX4/PX4-GPSDrivers/pull/213))
- feat: add `GPSHelper::isMovingBase()` virtual ([PX4... | 0e51d246863b1da7fc07517468da8f09618a486c | 1fc34f291b185472fe82ae72083cfcdff8f00b1a | diff --git a/src/drivers/gps/devices b/src/drivers/gps/devices
index 6d68aa435ef5..52bc6ecef4fb 160000
--- a/src/drivers/gps/devices
+++ b/src/drivers/gps/devices
@@ -1,1 +1,1 @@
-Subproject commit 6d68aa435ef57eae138c7ef0e77c65c32a5d21c6
+Subproject commit 52bc6ecef4fb80cc5b7fef12095f65dd3cbe957e
| [
"src/drivers/gps/devices"
] | [] | true | ||
PX4/PX4-Autopilot | 27,633 | issue_to_patch | submodule(nuttx): update NuttX submodule to latest | Updates the `platforms/nuttx/NuttX/nuttx` submodule to the latest `px4_firmware_nuttx-10.3.0+` (`d147b76c86`):
- [BACKPORT] arch/arm/stm32h7: Invalidate DCACHE after flash erase ([PX4/NuttX#381](https://github.com/PX4/NuttX/pull/381))
The `NuttX/apps` submodule is already at the latest tracked commit, so only `nuttx`... | 0e51d246863b1da7fc07517468da8f09618a486c | 23f145ae28a42cfedcf500615b2aa0c71f4dc7d2 | diff --git a/platforms/nuttx/NuttX/nuttx b/platforms/nuttx/NuttX/nuttx
index 9304289d9f2b..d147b76c86af 160000
--- a/platforms/nuttx/NuttX/nuttx
+++ b/platforms/nuttx/NuttX/nuttx
@@ -1,1 +1,1 @@
-Subproject commit 9304289d9f2b304c6835c9d39c131648c5f804c2
+Subproject commit d147b76c86af9f334756434af1f17630c1d4d296
| [
"platforms/nuttx/NuttX/nuttx"
] | [] | true | ||
PX4/PX4-Autopilot | 27,616 | issue_to_patch | docs(releases): add list of removed parameters with notes | ### Solved Problem
I had removed quite some parameters to safe user confusion, resources and testing complexity. I forgot to mention them in an adequate way in the release notes.
### Solution
List them consistently in the right release's notes. | fe35de71955193659de4c230a616056c3578860d | 969fbbbc7d706ffea6080acc8d77a36241df9c54 | diff --git a/docs/en/releases/1.17.md b/docs/en/releases/1.17.md
index 07266225b8e4..e681e9bb7bd9 100644
--- a/docs/en/releases/1.17.md
+++ b/docs/en/releases/1.17.md
@@ -147,6 +147,7 @@ For users upgrading from v1.16, please take a moment to review the following bef
- UAVCAN battery: better remaining-time calculation... | [
"docs/en/releases/1.17.md",
"docs/en/releases/1.18.md"
] | [] | true | ||
PX4/PX4-Autopilot | 27,631 | issue_to_patch | fix(tools/uploader): only verify signature for signed firmware | PR #27237 added an unconditional `verify_signature()` step between verify and reboot, sending the `VERIFY_SIG` (`0x39`) opcode on every upload. For unsigned firmware this injects an unknown opcode into the bootloader command stream immediately before `BOOT`; bootloaders that do not silently ignore it are left out of ph... | 1ab0f5d2cd7fc4ed9a5fdc628454746326288243 | bdc66b0809afc49e04a3f6fb7e8053e8c686c6c5 | diff --git a/Tools/px4_uploader.py b/Tools/px4_uploader.py
index 47d902a68ec3..0301280cfb79 100755
--- a/Tools/px4_uploader.py
+++ b/Tools/px4_uploader.py
@@ -1171,11 +1171,13 @@ def verify(
def verify_signature(self, image_signed: bool) -> None:
"""Ask the bootloader to verify the signature of the progra... | [
"Tools/px4_uploader.py"
] | [] | true | ||
PX4/PX4-Autopilot | 27,630 | issue_to_patch | fix(astyle): ignore Micro-XRCE-DDS-Client-v3 submodule in format checks | ## Summary
Add the `Micro-XRCE-DDS-Client-v3` submodule to the astyle exclusion list so `make format` and `make check_format` no longer touch its vendored sources.
## Problem
The `Micro-XRCE-DDS-Client-v3` submodule was added without a matching prune entry in `Tools/astyle/files_to_check_code_style.sh`. The existing... | 709dfec6ff7a6c3f698278831256871dac7690fd | b3a697561cbe1806ac831a1af02cc92b6d502b54 | diff --git a/Tools/astyle/files_to_check_code_style.sh b/Tools/astyle/files_to_check_code_style.sh
index ca6b28b37f9b..dc0f3c67ca42 100755
--- a/Tools/astyle/files_to_check_code_style.sh
+++ b/Tools/astyle/files_to_check_code_style.sh
@@ -36,6 +36,7 @@ exec find boards msg src platforms test \
-path src/lib/crypto... | [
"Tools/astyle/files_to_check_code_style.sh"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.