repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
PX4/PX4-Autopilot | 27,580 | issue_to_patch | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | ## Summary
Introduces a `PX4Barometer` driver wrapper (mirroring `PX4Accelerometer`/`PX4Gyroscope`/`PX4Magnetometer`/`PX4Rangefinder`) and migrates every barometer publisher onto it — all 16 hardware drivers under `src/drivers/barometer/` plus the simulation publishers (gz_bridge, sensor_baro_sim, simulator_mavlin... | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/drivers/barometer/bmp280/BMP280.cpp b/src/drivers/barometer/bmp280/BMP280.cpp
index 82772eba20c3..fc030d015be5 100644
--- a/src/drivers/barometer/bmp280/BMP280.cpp
+++ b/src/drivers/barometer/bmp280/BMP280.cpp
@@ -35,6 +35,7 @@
BMP280::BMP280(const I2CSPIDriverConfig &config, bmp280::IBMP280 *interf... | [
"src/drivers/barometer/bmp280/BMP280.cpp",
"src/drivers/barometer/bmp280/BMP280.hpp",
"src/drivers/barometer/bmp280/CMakeLists.txt",
"src/drivers/barometer/bmp388/CMakeLists.txt",
"src/drivers/barometer/bmp388/bmp388.cpp",
"src/drivers/barometer/bmp388/bmp388.h",
"src/drivers/barometer/bmp581/CMakeLists... | [
{
"comment": "```suggestion\n```\nThis isn't called anywhere and it's confusing to have both `set_device_id` and `set_device_type`",
"path": "src/lib/drivers/barometer/PX4Barometer.hpp",
"hunk": "@@ -0,0 +1,65 @@\n+/****************************************************************************\n+ *\n+ * ... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | ```suggestion
```
This isn't called anywhere and it's confusing to have both `set_device_id` and `set_device_type` | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.hpp b/src/lib/drivers/barometer/PX4Barometer.hpp
new file mode 100644
index 000000000000..b8a0cbf41162
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.hpp
@@ -0,0 +1,60 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.hpp"
] | [
{
"comment": "```suggestion\n```\nThis isn't called anywhere and it's confusing to have both `set_device_id` and `set_device_type`",
"path": "src/lib/drivers/barometer/PX4Barometer.hpp",
"hunk": "@@ -0,0 +1,65 @@\n+/****************************************************************************\n+ *\n+ * ... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | this is the only instance where the CTOR is used | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/modules/simulation/sensor_baro_sim/SensorBaroSim.hpp b/src/modules/simulation/sensor_baro_sim/SensorBaroSim.hpp
index bcde38852eec..c46d7fab1f67 100644
--- a/src/modules/simulation/sensor_baro_sim/SensorBaroSim.hpp
+++ b/src/modules/simulation/sensor_baro_sim/SensorBaroSim.hpp
@@ -38,12 +38,11 @@
#inc... | [
"src/modules/simulation/sensor_baro_sim/SensorBaroSim.hpp"
] | [
{
"comment": "this is the only instance where the CTOR is used",
"path": "src/modules/simulation/sensor_baro_sim/SensorBaroSim.hpp",
"hunk": "@@ -83,7 +82,7 @@ class SensorBaroSim : public ModuleBase, public ModuleParams, public px4::Schedu\n \n \thrt_abstime _last_update_time{0};\n \n-\tuORB::Publicati... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | is there any point in having a CTOR at all if it's just always 0 initialized? The `_device_id` member is already default initialized to 0. I'd remove. | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/drivers/barometer/dps310/DPS310.hpp b/src/drivers/barometer/dps310/DPS310.hpp
index 498fa01a635b..96711c927a27 100644
--- a/src/drivers/barometer/dps310/DPS310.hpp
+++ b/src/drivers/barometer/dps310/DPS310.hpp
@@ -40,6 +40,7 @@
#pragma once
#include <drivers/device/Device.hpp>
+#include <lib/driver... | [
"src/drivers/barometer/dps310/DPS310.hpp"
] | [
{
"comment": "is there any point in having a CTOR at all if it's just always 0 initialized? The `_device_id` member is already default initialized to 0. I'd remove.",
"path": "src/drivers/barometer/dps310/DPS310.hpp",
"hunk": "@@ -80,7 +81,7 @@ class DPS310 : public I2CSPIDriver<DPS310>\n \n \tstatic co... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | ` ~PublicationBase()` unadvertises if the topics queue size is 1... which is weird. I was going to suggest we push the `unadvertise()` into the publication base class since this object is destroyed when the owning class is destroyed. RAII and Single Responsibility. | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.cpp b/src/lib/drivers/barometer/PX4Barometer.cpp
new file mode 100644
index 000000000000..84273ff3e0df
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.cpp
@@ -0,0 +1,54 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.cpp"
] | [
{
"comment": "` ~PublicationBase()` unadvertises if the topics queue size is 1... which is weird. I was going to suggest we push the `unadvertise()` into the publication base class since this object is destroyed when the owning class is destroyed. RAII and Single Responsibility.",
"path": "src/lib/drivers/b... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | ```suggestion
``` | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.cpp b/src/lib/drivers/barometer/PX4Barometer.cpp
new file mode 100644
index 000000000000..84273ff3e0df
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.cpp
@@ -0,0 +1,54 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.cpp"
] | [
{
"comment": "```suggestion\n```",
"path": "src/lib/drivers/barometer/PX4Barometer.cpp",
"hunk": "@@ -0,0 +1,77 @@\n+/****************************************************************************\n+ *\n+ * Copyright (c) 2026 PX4 Development Team. All rights reserved.\n+ *\n+ * Redistribution and use in... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | What if the `PX4Barometer` class just carried around the `sensor_baro_s` directly? Seems slightly odd to mirror all of the fields from `SensorBaro.msg` as member variables. It would potentially save stack although it's hard to say without looking at the machine code. | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.cpp b/src/lib/drivers/barometer/PX4Barometer.cpp
new file mode 100644
index 000000000000..84273ff3e0df
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.cpp
@@ -0,0 +1,54 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.cpp"
] | [
{
"comment": "What if the `PX4Barometer` class just carried around the `sensor_baro_s` directly? Seems slightly odd to mirror all of the fields from `SensorBaro.msg` as member variables. It would potentially save stack although it's hard to say without looking at the machine code.",
"path": "src/lib/drivers... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | I'd drop the indentation and drop the 0 init, default init for primitives is 0 | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.hpp b/src/lib/drivers/barometer/PX4Barometer.hpp
new file mode 100644
index 000000000000..b8a0cbf41162
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.hpp
@@ -0,0 +1,60 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.hpp"
] | [
{
"comment": "I'd drop the indentation and drop the 0 init, default init for primitives is 0",
"path": "src/lib/drivers/barometer/PX4Barometer.hpp",
"hunk": "@@ -0,0 +1,65 @@\n+/****************************************************************************\n+ *\n+ * Copyright (c) 2026 PX4 Development Te... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | maybe at some point in the future we would actually care about the "sample" time. Probably doesn't matter here. | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/modules/simulation/gz_bridge/GZBridge.cpp b/src/modules/simulation/gz_bridge/GZBridge.cpp
index 2818d6eb0a37..a3878b89b3f8 100644
--- a/src/modules/simulation/gz_bridge/GZBridge.cpp
+++ b/src/modules/simulation/gz_bridge/GZBridge.cpp
@@ -400,21 +400,8 @@ void GZBridge::magnetometerCallback(const gz::ms... | [
"src/modules/simulation/gz_bridge/GZBridge.cpp"
] | [
{
"comment": "maybe at some point in the future we would actually care about the \"sample\" time. Probably doesn't matter here.",
"path": "src/modules/simulation/gz_bridge/GZBridge.cpp",
"hunk": "@@ -417,21 +417,7 @@ void GZBridge::magnetometerCallback(const gz::msgs::Magnetometer &msg)\n \n void GZBrid... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | yuck, I'd just build this with the DeviceId helper in the CTOR | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/modules/simulation/gz_bridge/GZBridge.hpp b/src/modules/simulation/gz_bridge/GZBridge.hpp
index d03df89f3f92..6a108dbe7301 100644
--- a/src/modules/simulation/gz_bridge/GZBridge.hpp
+++ b/src/modules/simulation/gz_bridge/GZBridge.hpp
@@ -49,6 +49,7 @@
#include <lib/drivers/gyroscope/PX4Gyroscope.hpp>
... | [
"src/modules/simulation/gz_bridge/GZBridge.hpp"
] | [
{
"comment": "yuck, I'd just build this with the DeviceId helper in the CTOR",
"path": "src/modules/simulation/gz_bridge/GZBridge.hpp",
"hunk": "@@ -144,14 +145,16 @@ class GZBridge : public ModuleBase, public ModuleParams, public px4::ScheduledWo\n \tuORB::SubscriptionInterval _param... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | same comment about the CTOR and using devid helper | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/modules/simulation/simulator_mavlink/SimulatorMavlink.hpp b/src/modules/simulation/simulator_mavlink/SimulatorMavlink.hpp
index 605b68ffbb20..35964a5a723c 100644
--- a/src/modules/simulation/simulator_mavlink/SimulatorMavlink.hpp
+++ b/src/modules/simulation/simulator_mavlink/SimulatorMavlink.hpp
@@ -4... | [
"src/modules/simulation/simulator_mavlink/SimulatorMavlink.hpp"
] | [
{
"comment": "same comment about the CTOR and using devid helper",
"path": "src/modules/simulation/simulator_mavlink/SimulatorMavlink.hpp",
"hunk": "@@ -199,7 +199,11 @@ class SimulatorMavlink : public ModuleParams\n \t\t{197644, ROTATION_NONE},\n \t};\n \n-\tuORB::PublicationMulti<sensor_baro_s> _senso... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | I am not an expert on the `GZBridge`, but why was the temperature part dropped? The commit says only worked when airspeed sensor was connected, but isn't this a regression anyway? Because now it does never work. | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/modules/simulation/gz_bridge/GZBridge.cpp b/src/modules/simulation/gz_bridge/GZBridge.cpp
index 2818d6eb0a37..a3878b89b3f8 100644
--- a/src/modules/simulation/gz_bridge/GZBridge.cpp
+++ b/src/modules/simulation/gz_bridge/GZBridge.cpp
@@ -400,21 +400,8 @@ void GZBridge::magnetometerCallback(const gz::ms... | [
"src/modules/simulation/gz_bridge/GZBridge.cpp"
] | [
{
"comment": "I am not an expert on the `GZBridge`, but why was the temperature part dropped? The commit says only worked when airspeed sensor was connected, but isn't this a regression anyway? Because now it does never work.",
"path": "src/modules/simulation/gz_bridge/GZBridge.cpp",
"hunk": "@@ -417,21... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | All the other general drivers like `PX4Gyroscope` allow setting the device Id in the constructor, which allows using it like this `_px4_gyro(get_device_id(), config.rotation),`. Its not a lot but it is a waste to set the device id again and again in each `update` call when for nearly all of them its already known durin... | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.hpp b/src/lib/drivers/barometer/PX4Barometer.hpp
new file mode 100644
index 000000000000..b8a0cbf41162
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.hpp
@@ -0,0 +1,60 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.hpp"
] | [
{
"comment": "All the other general drivers like `PX4Gyroscope` allow setting the device Id in the constructor, which allows using it like this `_px4_gyro(get_device_id(), config.rotation),`. Its not a lot but it is a waste to set the device id again and again in each `update` call when for nearly all of them i... | true | ||
PX4/PX4-Autopilot | 27,580 | comment_to_fix | feat(baro): add PX4Barometer wrapper and migrate barometer drivers | Could you add a short comment here that 15 is sea-level standard, so its not as magic. | d5f5c503309c14321934602b037148cd3756c465 | efa094d97eaafb94f83064b4ced021c6c7bca7da | diff --git a/src/lib/drivers/barometer/PX4Barometer.cpp b/src/lib/drivers/barometer/PX4Barometer.cpp
new file mode 100644
index 000000000000..84273ff3e0df
--- /dev/null
+++ b/src/lib/drivers/barometer/PX4Barometer.cpp
@@ -0,0 +1,54 @@
+/****************************************************************************
+ *
+ ... | [
"src/lib/drivers/barometer/PX4Barometer.cpp"
] | [
{
"comment": "Could you add a short comment here that 15 is sea-level standard, so its not as magic.",
"path": "src/lib/drivers/barometer/PX4Barometer.cpp",
"hunk": "@@ -0,0 +1,54 @@\n+/****************************************************************************\n+ *\n+ * Copyright (c) 2026 PX4 Develo... | true | ||
PX4/PX4-Autopilot | 27,598 | issue_to_patch | [BACKPORT v1.17] fix(zenoh): default config topic type to use actual uORB topic name | Backport of https://github.com/PX4/PX4-Autopilot/pull/26564
Closes #26183
| 5d0378797a7981b5acdcf69eba6b509e15b1cf94 | 9ab9daa4476d6ec5a443cb41883379db56fcee74 | diff --git a/src/modules/zenoh/default_topics.c.em b/src/modules/zenoh/default_topics.c.em
index 9979ede692ea..f80b18dff68f 100644
--- a/src/modules/zenoh/default_topics.c.em
+++ b/src/modules/zenoh/default_topics.c.em
@@ -18,15 +18,15 @@ import os
const char* default_pub_config =
@[ for pub in publications]@
- ... | [
"src/modules/zenoh/default_topics.c.em"
] | [] | true | ||
PX4/PX4-Autopilot | 27,610 | issue_to_patch | docs(navigator): clarify multicopter Return behavior | ### Solved Problem
The multicopter Return mode page had several descriptions that could be read more strictly than the current implementation.
1. **Prevent-arming wording**
The page said that the vehicle "must be armed when switching to this mode". This could be read as meaning that PX4 rejects selecting Re... | 9b25e6df339104bbcd666bd21007215376ca5d3b | 3dca58d057fee46bc0a88971dd5dcd818ba485f7 | diff --git a/docs/en/flight_modes/return.md b/docs/en/flight_modes/return.md
index 7c8ed45ca784..9c97a5e00887 100644
--- a/docs/en/flight_modes/return.md
+++ b/docs/en/flight_modes/return.md
@@ -17,9 +17,9 @@ The following topics should be read first if you're using these vehicle types:
- Flying vehicles can't switc... | [
"docs/en/flight_modes/return.md",
"docs/en/flight_modes_fw/land.md",
"docs/en/flight_modes_fw/return.md",
"docs/en/flight_modes_mc/follow_me.md",
"docs/en/flight_modes_mc/hold.md",
"docs/en/flight_modes_mc/land.md",
"docs/en/flight_modes_mc/mission.md",
"docs/en/flight_modes_mc/orbit.md",
"docs/en/f... | [
{
"comment": "Change is redundant - \"for this return type\" means the \"home/rally point return type\". I'll fix in subedit.\n\n",
"path": "docs/en/flight_modes_mc/return.md",
"hunk": "@@ -29,7 +29,7 @@ The default type is recommended.\n ## Technical Summary\n \n Multicopters use the [home/rally point ... | true | ||
PX4/PX4-Autopilot | 27,610 | comment_to_fix | docs(navigator): clarify multicopter Return behavior | Change is redundant - "for this return type" means the "home/rally point return type". I'll fix in subedit.
| 9b25e6df339104bbcd666bd21007215376ca5d3b | 3dca58d057fee46bc0a88971dd5dcd818ba485f7 | diff --git a/docs/en/flight_modes_mc/return.md b/docs/en/flight_modes_mc/return.md
index c3b45ccb5986..d41b369c08fb 100644
--- a/docs/en/flight_modes_mc/return.md
+++ b/docs/en/flight_modes_mc/return.md
@@ -18,9 +18,9 @@ The default type is recommended.
- Flying vehicles can't switch to this mode without global posi... | [
"docs/en/flight_modes_mc/return.md"
] | [
{
"comment": "Change is redundant - \"for this return type\" means the \"home/rally point return type\". I'll fix in subedit.\n\n",
"path": "docs/en/flight_modes_mc/return.md",
"hunk": "@@ -29,7 +29,7 @@ The default type is recommended.\n ## Technical Summary\n \n Multicopters use the [home/rally point ... | true | ||
PX4/PX4-Autopilot | 27,610 | comment_to_fix | docs(navigator): clarify multicopter Return behavior | This could be kept consistent with the note above, which now says "unless prevented by the active failsafe state".
```suggestion
| <a id="COM_RC_OVERRIDE"></a>[COM_RC_OVERRIDE](../advanced_config/parameter_reference.md#COM_RC_OVERRIDE) | Controls whether stick movement on a multicopter (or VTOL in MC mode) causes a... | 9b25e6df339104bbcd666bd21007215376ca5d3b | 3dca58d057fee46bc0a88971dd5dcd818ba485f7 | diff --git a/docs/en/flight_modes/return.md b/docs/en/flight_modes/return.md
index 7c8ed45ca784..9c97a5e00887 100644
--- a/docs/en/flight_modes/return.md
+++ b/docs/en/flight_modes/return.md
@@ -17,9 +17,9 @@ The following topics should be read first if you're using these vehicle types:
- Flying vehicles can't switc... | [
"docs/en/flight_modes/return.md"
] | [
{
"comment": "This could be kept consistent with the note above, which now says \"unless prevented by the active failsafe state\".\n\n```suggestion\n| <a id=\"COM_RC_OVERRIDE\"></a>[COM_RC_OVERRIDE](../advanced_config/parameter_reference.md#COM_RC_OVERRIDE) | Controls whether stick movement on a multicopter ... | true | ||
PX4/PX4-Autopilot | 27,610 | comment_to_fix | docs(navigator): clarify multicopter Return behavior | This could be kept consistent with the note above, which now says "unless prevented by the active failsafe state".
```suggestion
| <a id="COM_RC_OVERRIDE"></a>[COM_RC_OVERRIDE](../advanced_config/parameter_reference.md#COM_RC_OVERRIDE) | Controls whether stick movement on a multicopter (or VTOL in MC mode) causes a mo... | 9b25e6df339104bbcd666bd21007215376ca5d3b | 3dca58d057fee46bc0a88971dd5dcd818ba485f7 | diff --git a/docs/en/flight_modes_mc/return.md b/docs/en/flight_modes_mc/return.md
index c3b45ccb5986..d41b369c08fb 100644
--- a/docs/en/flight_modes_mc/return.md
+++ b/docs/en/flight_modes_mc/return.md
@@ -18,9 +18,9 @@ The default type is recommended.
- Flying vehicles can't switch to this mode without global posi... | [
"docs/en/flight_modes_mc/return.md"
] | [
{
"comment": "This could be kept consistent with the note above, which now says \"unless prevented by the active failsafe state\".\n\n```suggestion\n| <a id=\"COM_RC_OVERRIDE\"></a>[COM_RC_OVERRIDE](../advanced_config/parameter_reference.md#COM_RC_OVERRIDE) | Controls whether stick movement on a multicopter (or... | true | ||
PX4/PX4-Autopilot | 27,610 | comment_to_fix | docs(navigator): clarify multicopter Return behavior | Maybe use "return destination" instead of "home position", since the selected RTL destination may be home or a rally/safe point.
```suggestion
| <a id="RTL_MIN_DIST"></a>[RTL_MIN_DIST](../advanced_config/parameter_reference.md#RTL_MIN_DIST) | Within this distance from the return destination, the return alt... | 9b25e6df339104bbcd666bd21007215376ca5d3b | 3dca58d057fee46bc0a88971dd5dcd818ba485f7 | diff --git a/docs/en/flight_modes/return.md b/docs/en/flight_modes/return.md
index 7c8ed45ca784..9c97a5e00887 100644
--- a/docs/en/flight_modes/return.md
+++ b/docs/en/flight_modes/return.md
@@ -17,9 +17,9 @@ The following topics should be read first if you're using these vehicle types:
- Flying vehicles can't switc... | [
"docs/en/flight_modes/return.md"
] | [
{
"comment": "Maybe use \"return destination\" instead of \"home position\", since the selected RTL destination may be home or a rally/safe point.\n\n```suggestion\n| <a id=\"RTL_MIN_DIST\"></a>[RTL_MIN_DIST](../advanced_config/parameter_reference.md#RTL_MIN_DIST) | Within this distance from the ret... | true | ||
PX4/PX4-Autopilot | 27,585 | issue_to_patch | docs(flight_modes_mc): clarify hold mode position and stick override behavior | ### Solved Problem
The Hold mode page had two slightly misleading descriptions:
- "current position and altitude" could be interpreted as the exact position where Hold was entered.
- The RC stick override note only mentioned critical battery failsafe, although stick override can also be blocked during other fail... | 77edb0dda6dc69566bad65d909b556824c549320 | 4b96983d4dcf20b95512cf2b93b9ff5a7cc3c4be | diff --git a/docs/en/flight_modes_mc/hold.md b/docs/en/flight_modes_mc/hold.md
index d97390ecd68a..3d5dd9ac2677 100644
--- a/docs/en/flight_modes_mc/hold.md
+++ b/docs/en/flight_modes_mc/hold.md
@@ -2,7 +2,7 @@
<img src="../../assets/site/position_fixed.svg" title="Position fix required (e.g. GPS)" width="30px" />
... | [
"docs/en/flight_modes_mc/hold.md"
] | [
{
"comment": "I probably fixed this in the other PR, but yes :-)",
"path": "docs/en/flight_modes_mc/hold.md",
"hunk": "@@ -18,15 +18,15 @@ It is usually activated with a pre-programmed switch.\n - Disarmed vehicles can switch to mode without valid position estimate but can't arm.\n - Mode requires win... | true | ||
PX4/PX4-Autopilot | 27,585 | comment_to_fix | docs(flight_modes_mc): clarify hold mode position and stick override behavior | I probably fixed this in the other PR, but yes :-) | 77edb0dda6dc69566bad65d909b556824c549320 | 4b96983d4dcf20b95512cf2b93b9ff5a7cc3c4be | diff --git a/docs/en/flight_modes_mc/hold.md b/docs/en/flight_modes_mc/hold.md
index d97390ecd68a..3d5dd9ac2677 100644
--- a/docs/en/flight_modes_mc/hold.md
+++ b/docs/en/flight_modes_mc/hold.md
@@ -2,7 +2,7 @@
<img src="../../assets/site/position_fixed.svg" title="Position fix required (e.g. GPS)" width="30px" />
... | [
"docs/en/flight_modes_mc/hold.md"
] | [
{
"comment": "I probably fixed this in the other PR, but yes :-)",
"path": "docs/en/flight_modes_mc/hold.md",
"hunk": "@@ -18,15 +18,15 @@ It is usually activated with a pre-programmed switch.\n - Disarmed vehicles can switch to mode without valid position estimate but can't arm.\n - Mode requires win... | true | ||
PX4/PX4-Autopilot | 27,583 | issue_to_patch | fix(ci): repair broken ccache in docs metadata jobs | ## Summary
The docs pipeline's metadata jobs never reused ccache — every run rebuilt `px4_sitl_default` from scratch. This switches them to the shared ccache actions so the compiler cache actually persists.
## Problem
`pr-metadata-regen` and `metadata-regen` set `CCACHE_DIR: ~/.ccache` through the job `env`. GitHub Ac... | 77edb0dda6dc69566bad65d909b556824c549320 | 4d729fec1e19595e1954e76ba9568b5e3ca98c6c | diff --git a/.github/workflows/docs-orchestrator.yml b/.github/workflows/docs-orchestrator.yml
index c725fa97ca0f..0cf4682d1979 100644
--- a/.github/workflows/docs-orchestrator.yml
+++ b/.github/workflows/docs-orchestrator.yml
@@ -80,37 +80,22 @@ jobs:
- name: Configure Git Safe Directory
run: git confi... | [
".github/workflows/docs-orchestrator.yml"
] | [] | true | ||
PX4/PX4-Autopilot | 27,565 | issue_to_patch | fix: replace deprecated Protobuf Resize() API in gz_bridge | …cOS compatibility
Homebrew now ships Protobuf 35.x, which marks RepeatedField::Resize() as [[deprecated]]. PX4 builds with -Werror, so SITL builds fail on macOS ARM when Gazebo Harmonic is installed.
This patch replaces the deprecated Resize() + Set() pattern with the recommended Clear() + Reserve() + Add() sequ... | c4f39d8011b025a04a2d07ee6d40508079e74f81 | 6779be44d128280d0e2c4ff66c49b236a4ac8494 | diff --git a/src/modules/simulation/gz_bridge/GZMixingInterfaceESC.cpp b/src/modules/simulation/gz_bridge/GZMixingInterfaceESC.cpp
index 9b53315a0dbb..8b8e27f01a2b 100644
--- a/src/modules/simulation/gz_bridge/GZMixingInterfaceESC.cpp
+++ b/src/modules/simulation/gz_bridge/GZMixingInterfaceESC.cpp
@@ -77,10 +77,13 @@ b... | [
"src/modules/simulation/gz_bridge/GZMixingInterfaceESC.cpp",
"src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp"
] | [
{
"comment": "Could you mention why this part was removed? This doesnt follow our mixer convention. ",
"path": "src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp",
"hunk": "@@ -75,16 +75,15 @@ bool GZMixingInterfaceWheel::updateOutputs(float outputs[MAX_ACTUATORS], unsigne\n \n \tif (active_o... | true | ||
PX4/PX4-Autopilot | 27,565 | comment_to_fix | fix: replace deprecated Protobuf Resize() API in gz_bridge | Could you mention why this part was removed? This doesnt follow our mixer convention. | c4f39d8011b025a04a2d07ee6d40508079e74f81 | 6779be44d128280d0e2c4ff66c49b236a4ac8494 | diff --git a/src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp b/src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp
index 8cef805c5365..3c1af2633c44 100644
--- a/src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp
+++ b/src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp
@@ -60,7 +60,... | [
"src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp"
] | [
{
"comment": "Could you mention why this part was removed? This doesnt follow our mixer convention. ",
"path": "src/modules/simulation/gz_bridge/GZMixingInterfaceWheel.cpp",
"hunk": "@@ -75,16 +75,15 @@ bool GZMixingInterfaceWheel::updateOutputs(float outputs[MAX_ACTUATORS], unsigne\n \n \tif (active_o... | true | ||
PX4/PX4-Autopilot | 27,621 | issue_to_patch | feat(boards/modalai/voxl2): run navigator on VOXL2 DSP | ### Solved Problem
The navigator running on the applications processor is problematic if the link to the DSP goes down. The DSP won't be able to run any failsafes like return to home.
### Solution
Move the navigator module from the apps processor to the DSP.
### Test coverage
Tested on VOXL2 | 51c2cf254b56478d6a286d86fdb4635d05fbae3a | 88a227a5ab9f1da845863630f8051a183505364e | diff --git a/boards/modalai/voxl2/default.px4board b/boards/modalai/voxl2/default.px4board
index ab95da688dc8..cbe1f8e76b91 100644
--- a/boards/modalai/voxl2/default.px4board
+++ b/boards/modalai/voxl2/default.px4board
@@ -17,7 +17,6 @@ CONFIG_MODULES_DATAMAN=y
CONFIG_MODULES_LOGGER=y
CONFIG_MODULES_MAVLINK=y
CONFIG... | [
"boards/modalai/voxl2/default.px4board",
"boards/modalai/voxl2/slpi.px4board",
"boards/modalai/voxl2/target/voxl-px4-hitl-start",
"boards/modalai/voxl2/target/voxl-px4-sih-start",
"boards/modalai/voxl2/target/voxl-px4-start"
] | [] | true | ||
PX4/PX4-Autopilot | 27,373 | issue_to_patch | feat(docs): ufw-firmware flashing | ### Solved Problem
The Firmware Update section of the DroneCAN docs did not reflect the firmware upload and flashing pipeline added in this PR: https://github.com/PX4/PX4-Autopilot/pull/27043
### Solution
Expanded the ## Firmware Update section in [index.md](vscode-file://vscode-app/snap/code/238/usr/share/code/... | 7261e064c7e2019702b5e163c7f46b776a4ee853 | 0cce7b56b107d8307c2107f300868ba7e389ba90 | diff --git a/docs/en/dronecan/index.md b/docs/en/dronecan/index.md
index 5198db327e13..6bcdf313533f 100644
--- a/docs/en/dronecan/index.md
+++ b/docs/en/dronecan/index.md
@@ -6,7 +6,7 @@
- DroneCAN is not enabled by default, and nor are specific sensors and features that use it.
For setup information see [PX4 Con... | [
"docs/en/dronecan/index.md"
] | [
{
"comment": "`on the target` sounds like it is extracted on the PX4 side, yet this is normally done on the host PC / SOM.",
"path": "docs/en/dronecan/index.md",
"hunk": "@@ -310,10 +310,37 @@ Most DroneCAN nodes require no further setup, unless specifically noted in their\n ## Firmware Update\n \n PX4 ... | true | ||
PX4/PX4-Autopilot | 27,373 | comment_to_fix | feat(docs): ufw-firmware flashing | `on the target` sounds like it is extracted on the PX4 side, yet this is normally done on the host PC / SOM. | 7261e064c7e2019702b5e163c7f46b776a4ee853 | 0cce7b56b107d8307c2107f300868ba7e389ba90 | diff --git a/docs/en/dronecan/index.md b/docs/en/dronecan/index.md
index 5198db327e13..6bcdf313533f 100644
--- a/docs/en/dronecan/index.md
+++ b/docs/en/dronecan/index.md
@@ -6,7 +6,7 @@
- DroneCAN is not enabled by default, and nor are specific sensors and features that use it.
For setup information see [PX4 Con... | [
"docs/en/dronecan/index.md"
] | [
{
"comment": "`on the target` sounds like it is extracted on the PX4 side, yet this is normally done on the host PC / SOM.",
"path": "docs/en/dronecan/index.md",
"hunk": "@@ -310,10 +310,37 @@ Most DroneCAN nodes require no further setup, unless specifically noted in their\n ## Firmware Update\n \n PX4 ... | true | ||
PX4/PX4-Autopilot | 27,373 | comment_to_fix | feat(docs): ufw-firmware flashing | It is a bit unclear what an update archive should be. Maybe link to `upload_skynode.sh` as an example of a working implementation. | 7261e064c7e2019702b5e163c7f46b776a4ee853 | 0cce7b56b107d8307c2107f300868ba7e389ba90 | diff --git a/docs/en/dronecan/index.md b/docs/en/dronecan/index.md
index 5198db327e13..6bcdf313533f 100644
--- a/docs/en/dronecan/index.md
+++ b/docs/en/dronecan/index.md
@@ -6,7 +6,7 @@
- DroneCAN is not enabled by default, and nor are specific sensors and features that use it.
For setup information see [PX4 Con... | [
"docs/en/dronecan/index.md"
] | [
{
"comment": "It is a bit unclear what an update archive should be. Maybe link to `upload_skynode.sh` as an example of a working implementation.",
"path": "docs/en/dronecan/index.md",
"hunk": "@@ -310,10 +310,37 @@ Most DroneCAN nodes require no further setup, unless specifically noted in their\n ## Fir... | true | ||
PX4/PX4-Autopilot | 27,373 | comment_to_fix | feat(docs): ufw-firmware flashing | `nodes` is a bit hard to understand here. I would rather say (repeatable for multiple firmware files). | 7261e064c7e2019702b5e163c7f46b776a4ee853 | 0cce7b56b107d8307c2107f300868ba7e389ba90 | diff --git a/docs/en/dronecan/index.md b/docs/en/dronecan/index.md
index 5198db327e13..6bcdf313533f 100644
--- a/docs/en/dronecan/index.md
+++ b/docs/en/dronecan/index.md
@@ -6,7 +6,7 @@
- DroneCAN is not enabled by default, and nor are specific sensors and features that use it.
For setup information see [PX4 Con... | [
"docs/en/dronecan/index.md"
] | [
{
"comment": "`nodes` is a bit hard to understand here. I would rather say (repeatable for multiple firmware files).",
"path": "docs/en/dronecan/index.md",
"hunk": "@@ -310,10 +310,37 @@ Most DroneCAN nodes require no further setup, unless specifically noted in their\n ## Firmware Update\n \n PX4 can up... | true | ||
PX4/PX4-Autopilot | 27,373 | comment_to_fix | feat(docs): ufw-firmware flashing | I'm trying to work out the workflow.
- Does PX4 use this database to decide if it should install new firmware, or is this intended for the external tool?
- You say "Stale entries are removed automatically on every boot." - when is it stale - every boot? Or if you update the firmware with some new file name, or somethi... | 7261e064c7e2019702b5e163c7f46b776a4ee853 | 0cce7b56b107d8307c2107f300868ba7e389ba90 | diff --git a/docs/en/dronecan/index.md b/docs/en/dronecan/index.md
index 5198db327e13..6bcdf313533f 100644
--- a/docs/en/dronecan/index.md
+++ b/docs/en/dronecan/index.md
@@ -6,7 +6,7 @@
- DroneCAN is not enabled by default, and nor are specific sensors and features that use it.
For setup information see [PX4 Con... | [
"docs/en/dronecan/index.md"
] | [
{
"comment": "I'm trying to work out the workflow. \n- Does PX4 use this database to decide if it should install new firmware, or is this intended for the external tool?\n- You say \"Stale entries are removed automatically on every boot.\" - when is it stale - every boot? Or if you update the firmware with some... | true | ||
PX4/PX4-Autopilot | 27,373 | comment_to_fix | feat(docs): ufw-firmware flashing | @Phil-Engljaehringer I have subedited the sections above to remove some of the repetition in the intro and add a definition of what we consider a valid binary and APDescriptor (since I didn't know). Please check that.
I wasn't sure how to update this part of the doc because I wasn't clear what you were saying.
I thi... | 7261e064c7e2019702b5e163c7f46b776a4ee853 | 0cce7b56b107d8307c2107f300868ba7e389ba90 | diff --git a/docs/en/dronecan/index.md b/docs/en/dronecan/index.md
index 5198db327e13..6bcdf313533f 100644
--- a/docs/en/dronecan/index.md
+++ b/docs/en/dronecan/index.md
@@ -6,7 +6,7 @@
- DroneCAN is not enabled by default, and nor are specific sensors and features that use it.
For setup information see [PX4 Con... | [
"docs/en/dronecan/index.md"
] | [
{
"comment": "@Phil-Engljaehringer I have subedited the sections above to remove some of the repetition in the intro and add a definition of what we consider a valid binary and APDescriptor (since I didn't know). Please check that.\n\nI wasn't sure how to update this part of the doc because I wasn't clear what ... | true | ||
PX4/PX4-Autopilot | 27,355 | issue_to_patch | fix(drivers/distance_sensor/vl53l0x): added quality field for vl53l0x | ### Solved Problem
Added quality field by reading from status register in vl53l0x sensor
### Solution
updated the collect() logic to report 100 quality when the status returns 0 or 11 (Range Complete) and adjusted the array indices to read the distance values accordingly.
### Changelog Entry
For release notes:
... | 3e0b939dd96ec582fed9b34cd523f462cee9da1a | 98868879b34fe43b0dc8009341d6021feb3bd200 | diff --git a/src/drivers/distance_sensor/vl53l0x/VL53L0X.cpp b/src/drivers/distance_sensor/vl53l0x/VL53L0X.cpp
index cb6b9a6e7287..60aa7285ae6a 100644
--- a/src/drivers/distance_sensor/vl53l0x/VL53L0X.cpp
+++ b/src/drivers/distance_sensor/vl53l0x/VL53L0X.cpp
@@ -59,6 +59,12 @@
#define VL53L0X_BUS_CLOCK ... | [
"src/drivers/distance_sensor/vl53l0x/VL53L0X.cpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,591 | issue_to_patch | fix(navigator): remove feasibility checker reverse dependencies | ### Solved Problem
The mission_feasibility_checker library linked back against modules__navigator and modules__dataman.
This creates an unnecessary reverse dependency: modules__navigator already depends on
mission_feasibility_checker, while the feasibility checker library itself does not depend on the
n... | 45dbb4b2ef8493ca8a02585fd542e090f9a92986 | 086af443e2680f145b5a16a8766656a6fd5274e1 | diff --git a/src/modules/navigator/MissionFeasibility/CMakeLists.txt b/src/modules/navigator/MissionFeasibility/CMakeLists.txt
index 72ee524a3dd3..ae6bf09e9516 100644
--- a/src/modules/navigator/MissionFeasibility/CMakeLists.txt
+++ b/src/modules/navigator/MissionFeasibility/CMakeLists.txt
@@ -2,6 +2,6 @@ px4_add_libra... | [
"src/modules/navigator/MissionFeasibility/CMakeLists.txt",
"src/modules/navigator/MissionFeasibility/FeasibilityChecker.cpp",
"src/modules/navigator/mission.cpp",
"src/modules/navigator/mission_base.cpp",
"src/modules/navigator/mission_block.cpp",
"src/modules/navigator/mission_block.h",
"src/modules/na... | [
{
"comment": "Is the mission feasibility checker lib only dependent on the geo lib?\n\n\n\nI'd be curious if we could just take the item_contains_position out of mission_block and into it's own header file in the navigator base directory. That would be the quick fix.\n\nAnother fix up for debate is pulling what... | diff --git a/src/modules/navigator/test/CMakeLists.txt b/src/modules/navigator/test/CMakeLists.txt
index 77a16a4331ed..fa795af72cf8 100644
--- a/src/modules/navigator/test/CMakeLists.txt
+++ b/src/modules/navigator/test/CMakeLists.txt
@@ -33,5 +33,5 @@
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
-px4_add_f... | true | |
PX4/PX4-Autopilot | 27,591 | comment_to_fix | fix(navigator): remove feasibility checker reverse dependencies | Is the mission feasibility checker lib only dependent on the geo lib?
I'd be curious if we could just take the item_contains_position out of mission_block and into it's own header file in the navigator base directory. That would be the quick fix.
Another fix up for debate is pulling whatever dependencies that missi... | 45dbb4b2ef8493ca8a02585fd542e090f9a92986 | 086af443e2680f145b5a16a8766656a6fd5274e1 | diff --git a/src/modules/navigator/MissionFeasibility/CMakeLists.txt b/src/modules/navigator/MissionFeasibility/CMakeLists.txt
index 72ee524a3dd3..ae6bf09e9516 100644
--- a/src/modules/navigator/MissionFeasibility/CMakeLists.txt
+++ b/src/modules/navigator/MissionFeasibility/CMakeLists.txt
@@ -2,6 +2,6 @@ px4_add_libra... | [
"src/modules/navigator/MissionFeasibility/CMakeLists.txt"
] | [
{
"comment": "Is the mission feasibility checker lib only dependent on the geo lib?\n\n\n\nI'd be curious if we could just take the item_contains_position out of mission_block and into it's own header file in the navigator base directory. That would be the quick fix.\n\nAnother fix up for debate is pulling what... | true | ||
PX4/PX4-Autopilot | 27,620 | issue_to_patch | feat(boards/modalai/voxl2): enable Lightware laser driver | ### Solved Problem
Adds the Lightware laser serial driver to the VOXL 2 board build to allow use of the Lightware laser serial distance sensors
### Test coverage
Tested on VOXL2 hardware with SF000 sensor
| 2dfeefd7b817e3b6ebe58c88d06e912afc0f9df9 | b9b8b171768ad54d5e03756ca6f35850c2033c5c | diff --git a/boards/modalai/voxl2/slpi.px4board b/boards/modalai/voxl2/slpi.px4board
index 62dfebe2ffbf..629ea944847a 100644
--- a/boards/modalai/voxl2/slpi.px4board
+++ b/boards/modalai/voxl2/slpi.px4board
@@ -26,6 +26,7 @@ CONFIG_DRIVERS_BAROMETER_BMP280=y
CONFIG_DRIVERS_BAROMETER_BMP388=y
CONFIG_DRIVERS_BAROMETER_... | [
"boards/modalai/voxl2/slpi.px4board"
] | [] | true | ||
PX4/PX4-Autopilot | 27,581 | issue_to_patch | refactor(uORB): save flash by splitting headers into header & implementation | ### Solved Problem
These methods are currently repeated for and inlined in every caller, wasting quite a bit of flash.
### Solution
By moving the type independent methods into a separate `.cpp` file, we only need one definition. Saves about 15K of flash in total.
### Changelog Entry
Not user facing.
### T... | 77edb0dda6dc69566bad65d909b556824c549320 | 0367185e3c0b5b8c7850aff0f6fc7cd1bc69e422 | diff --git a/platforms/common/uORB/CMakeLists.txt b/platforms/common/uORB/CMakeLists.txt
index 6e157af3c1f3..85c86aa311b4 100644
--- a/platforms/common/uORB/CMakeLists.txt
+++ b/platforms/common/uORB/CMakeLists.txt
@@ -42,10 +42,12 @@ set(SRCS)
set(SRCS_COMMON
ORBSet.hpp
+ Publication.cpp
Publication.hpp
Publi... | [
"platforms/common/uORB/CMakeLists.txt",
"platforms/common/uORB/Publication.cpp",
"platforms/common/uORB/Publication.hpp",
"platforms/common/uORB/Subscription.cpp",
"platforms/common/uORB/Subscription.hpp",
"platforms/common/uORB/SubscriptionCallback.cpp",
"platforms/common/uORB/SubscriptionCallback.hpp"... | [] | true | ||
PX4/PX4-Autopilot | 27,618 | issue_to_patch | refactor(esc_battery): remove average temperature tracking from batte… | ### Description
In [this commit](https://github.com/PX4/PX4-Autopilot/commit/98cba19f50b5e83c900b2fd48947705777f368a3) it was added in PX4 upstream the filling of battery_status.temperature with the temperature of the ESC power source.
This arose a false warning when ESC temperature was high even if battery tempera... | 45dbb4b2ef8493ca8a02585fd542e090f9a92986 | 0688901175398cefe5f1581274cdb1a4480d588d | diff --git a/src/modules/esc_battery/EscBattery.cpp b/src/modules/esc_battery/EscBattery.cpp
index e911445c108d..e15b9f7d833c 100644
--- a/src/modules/esc_battery/EscBattery.cpp
+++ b/src/modules/esc_battery/EscBattery.cpp
@@ -93,24 +93,17 @@ EscBattery::Run()
const uint8_t online_esc_count = math::countSetBits(esc_... | [
"src/modules/esc_battery/EscBattery.cpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,332 | issue_to_patch | fix(navigator): re-evaluate climb requirement on mission cursor change | ### Solved Problem
The mission navigator could command a diagonal takeoff trajectory when the mission cursor changed while the vehicle was still below the target altitude.
The trigger paths are:
- MAVLink `MISSION_SET_CURRENT` (msg id 41)
- `MAV_CMD_DO_SET_MISSION_CURRENT` (cmd 224)
- `MAV_CMD_MISSION_START`... | 92fa89d7d7656e148d3f046410eabfe1abef1227 | 466abb3ecc2eedffa6fb55bd697511ac7fbca78b | diff --git a/src/modules/navigator/mission_base.cpp b/src/modules/navigator/mission_base.cpp
index 8253c3b94992..a8ed01f269c7 100644
--- a/src/modules/navigator/mission_base.cpp
+++ b/src/modules/navigator/mission_base.cpp
@@ -450,6 +450,11 @@ void MissionBase::update_mission()
_navigator->reset_vroi();
if (_navi... | [
"src/modules/navigator/mission_base.cpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,619 | issue_to_patch | refactor(drivers/distance_sensor): use Serial in Lightware laser driver | ### Solved Problem
N/A - no linked issue.
The Lightware laser serial driver used direct POSIX serial APIs (`open`, `read`, `write`, `termios`) for UART setup
and communication. This makes the driver less portable across PX4 platform backends that already provide
`device::Serial`. This will allow it to be ... | 45dbb4b2ef8493ca8a02585fd542e090f9a92986 | 586035ed08241cee44879ed16a2bb28f9f9e10d7 | diff --git a/src/drivers/distance_sensor/lightware_laser_serial/lightware_laser_serial.cpp b/src/drivers/distance_sensor/lightware_laser_serial/lightware_laser_serial.cpp
index 648d5f649f9d..7bba405adb5b 100644
--- a/src/drivers/distance_sensor/lightware_laser_serial/lightware_laser_serial.cpp
+++ b/src/drivers/distanc... | [
"src/drivers/distance_sensor/lightware_laser_serial/lightware_laser_serial.cpp",
"src/drivers/distance_sensor/lightware_laser_serial/lightware_laser_serial.hpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,492 | issue_to_patch | fix(tecs): Ensure speed weight is continuous on fast descend and underspeed | ### Solved Problem
1. When entering or exiting fast descend, the speed weight is interpolated from 1 to 2. This changes the speed weight discontinuously to/from 1 when entering/exiting fast descend, specifically the start of the ramp. This is especially problematic if the vehicle has a narrow usable airspeed range ... | 6946cbfc2fc506d0ec9ed44a2deda091a948b924 | abd1b542049bdb378328e590caced295597d4646 | diff --git a/src/lib/tecs/TECS.cpp b/src/lib/tecs/TECS.cpp
index 1ed625e36ec2..b9833df295c4 100644
--- a/src/lib/tecs/TECS.cpp
+++ b/src/lib/tecs/TECS.cpp
@@ -386,16 +386,14 @@ TECSControl::SpecificEnergyWeighting TECSControl::_updateSpeedAltitudeWeights(co
// Calculate the weight applied to control of specific kinet... | [
"src/lib/tecs/TECS.cpp"
] | [
{
"comment": "The speed weight and the ratio above are quite redundant. We can remove one again, but i am unsure which is the better information to keep",
"path": "msg/TecsStatus.msg",
"hunk": "@@ -29,3 +29,5 @@ float32 throttle_trim\t\t\t# estimated throttle value [0,1] required to fly level a\n \n flo... | true | ||
PX4/PX4-Autopilot | 27,492 | comment_to_fix | fix(tecs): Ensure speed weight is continuous on fast descend and underspeed | nit, sorry. Just for consistent style
```suggestion
if (!flag.airspeed_enabled)
{ pitch_speed_weight = 0.0f; }
``` | 6946cbfc2fc506d0ec9ed44a2deda091a948b924 | abd1b542049bdb378328e590caced295597d4646 | diff --git a/src/lib/tecs/TECS.cpp b/src/lib/tecs/TECS.cpp
index 1ed625e36ec2..b9833df295c4 100644
--- a/src/lib/tecs/TECS.cpp
+++ b/src/lib/tecs/TECS.cpp
@@ -386,16 +386,14 @@ TECSControl::SpecificEnergyWeighting TECSControl::_updateSpeedAltitudeWeights(co
// Calculate the weight applied to control of specific kinet... | [
"src/lib/tecs/TECS.cpp"
] | [
{
"comment": "nit, sorry. Just for consistent style \n\n\n```suggestion\n\tif (!flag.airspeed_enabled) \n\t { pitch_speed_weight = 0.0f; }\n```",
"path": "src/lib/tecs/TECS.cpp",
"hunk": "@@ -386,17 +386,13 @@ TECSControl::SpecificEnergyWeighting TECSControl::_updateSpeedAltitudeWeights(co\n \t// Cal... | true | ||
PX4/PX4-Autopilot | 27,602 | issue_to_patch | feat(ekf2): use a latitude-dependent gravity model | ## Context
Jira: [APX4-4273](https://auterion.atlassian.net/browse/APX4-4273)
EKF2 assumed a constant gravity (`CONSTANTS_ONE_G` = 9.80665 m/s²) everywhere on
Earth. Real normal gravity varies with latitude from ~9.780 m/s² at the equator
to ~9.832 m/s² at the poles (~0.5%). That error feeds directly into the
ve... | 7f77f10828e1e1faf0d405edbff045953dfdd464 | 48bcc45ca83ab3dde82cf5fd67e5546cfae0db44 | diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index e96ffc02926a..7bc1b6d2ab51 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -85,7 +85,6 @@ jobs:
cache-primary-key: ${{ steps.ccache.outputs.cache-primary-key }}
- name: Auto-update EKF chan... | [
".github/workflows/checks.yml",
"boards/auterion/fmu-v6s/performance-test.px4board",
"src/lib/lat_lon_alt/lat_lon_alt.hpp",
"src/lib/lat_lon_alt/test_lat_lon_alt.cpp",
"src/modules/ekf2/EKF/ekf.cpp",
"src/modules/ekf2/EKF/ekf.h",
"src/modules/ekf2/EKF/output_predictor/output_predictor.cpp",
"src/modul... | [
{
"comment": "```suggestion\n\tconst Vector3f gravity_acceleration(0.f, 0.f, _gravity_mss);\n```\nNo need to specify the details here",
"path": "src/modules/ekf2/EKF/ekf.cpp",
"hunk": "@@ -259,7 +261,7 @@ void Ekf::predictState(const imuSample &imu_delayed)\n \t_state.vel += corrected_delta_vel_ef;\n \n... | diff --git a/src/lib/lat_lon_alt/test_lat_lon_alt.cpp b/src/lib/lat_lon_alt/test_lat_lon_alt.cpp
index f2419951d5b2..bf8fb06ad821 100644
--- a/src/lib/lat_lon_alt/test_lat_lon_alt.cpp
+++ b/src/lib/lat_lon_alt/test_lat_lon_alt.cpp
@@ -119,3 +119,18 @@ TEST(TestLatLonAlt, fromAndToECEF)
}
}
}
+
+TEST(TestLatLonAlt... | true | |
PX4/PX4-Autopilot | 27,602 | comment_to_fix | feat(ekf2): use a latitude-dependent gravity model | ```suggestion
const Vector3f gravity_acceleration(0.f, 0.f, _gravity_mss);
```
No need to specify the details here | 7f77f10828e1e1faf0d405edbff045953dfdd464 | 48bcc45ca83ab3dde82cf5fd67e5546cfae0db44 | diff --git a/src/modules/ekf2/EKF/ekf.cpp b/src/modules/ekf2/EKF/ekf.cpp
index da681aa1203f..74f4a3b5a886 100644
--- a/src/modules/ekf2/EKF/ekf.cpp
+++ b/src/modules/ekf2/EKF/ekf.cpp
@@ -232,6 +232,8 @@ void Ekf::predictState(const imuSample &imu_delayed)
if (std::fabs(_gpos.latitude_rad() - _earth_rate_lat_ref_rad) ... | [
"src/modules/ekf2/EKF/ekf.cpp"
] | [
{
"comment": "```suggestion\n\tconst Vector3f gravity_acceleration(0.f, 0.f, _gravity_mss);\n```\nNo need to specify the details here",
"path": "src/modules/ekf2/EKF/ekf.cpp",
"hunk": "@@ -259,7 +261,7 @@ void Ekf::predictState(const imuSample &imu_delayed)\n \t_state.vel += corrected_delta_vel_ef;\n \n... | true | ||
PX4/PX4-Autopilot | 27,602 | comment_to_fix | feat(ekf2): use a latitude-dependent gravity model | ```suggestion
float getGravity() const { return _gravity; }
```
no need to specify the units if it's what we expect (MKSA) | 7f77f10828e1e1faf0d405edbff045953dfdd464 | 48bcc45ca83ab3dde82cf5fd67e5546cfae0db44 | diff --git a/src/modules/ekf2/EKF/ekf.h b/src/modules/ekf2/EKF/ekf.h
index 6313f307dc38..0ab1ad975143 100644
--- a/src/modules/ekf2/EKF/ekf.h
+++ b/src/modules/ekf2/EKF/ekf.h
@@ -294,6 +294,9 @@ class Ekf final : public EstimatorInterface
Vector3f getAccelBiasVariance() const { return getStateVariance<State::accel_bi... | [
"src/modules/ekf2/EKF/ekf.h"
] | [
{
"comment": "```suggestion\n\tfloat getGravity() const { return _gravity; }\n```\nno need to specify the units if it's what we expect (MKSA)",
"path": "src/modules/ekf2/EKF/ekf.h",
"hunk": "@@ -294,6 +294,9 @@ class Ekf final : public EstimatorInterface\n \tVector3f getAccelBiasVariance() const { retur... | true | ||
PX4/PX4-Autopilot | 27,602 | comment_to_fix | feat(ekf2): use a latitude-dependent gravity model | ```suggestion
float _gravity{CONSTANTS_ONE_G};
```
Doesn't need a comment. And we don't measure acceleration :D | 7f77f10828e1e1faf0d405edbff045953dfdd464 | 48bcc45ca83ab3dde82cf5fd67e5546cfae0db44 | diff --git a/src/modules/ekf2/EKF/output_predictor/output_predictor.h b/src/modules/ekf2/EKF/output_predictor/output_predictor.h
index 2309fc795463..2b772239c713 100644
--- a/src/modules/ekf2/EKF/output_predictor/output_predictor.h
+++ b/src/modules/ekf2/EKF/output_predictor/output_predictor.h
@@ -126,6 +126,7 @@ class... | [
"src/modules/ekf2/EKF/output_predictor/output_predictor.h"
] | [
{
"comment": "```suggestion\n\tfloat _gravity{CONSTANTS_ONE_G};\n```\nDoesn't need a comment. And we don't measure acceleration :D ",
"path": "src/modules/ekf2/EKF/output_predictor/output_predictor.h",
"hunk": "@@ -201,6 +202,8 @@ class OutputPredictor\n \t// output complementary filter tuning\n \tfloat... | true | ||
PX4/PX4-Autopilot | 27,602 | comment_to_fix | feat(ekf2): use a latitude-dependent gravity model | ```suggestion
```
The caller doesn't need to know that it's used for state prediction. But you could say that it's latitude-dependent. | 7f77f10828e1e1faf0d405edbff045953dfdd464 | 48bcc45ca83ab3dde82cf5fd67e5546cfae0db44 | diff --git a/src/modules/ekf2/EKF/ekf.h b/src/modules/ekf2/EKF/ekf.h
index 6313f307dc38..0ab1ad975143 100644
--- a/src/modules/ekf2/EKF/ekf.h
+++ b/src/modules/ekf2/EKF/ekf.h
@@ -294,6 +294,9 @@ class Ekf final : public EstimatorInterface
Vector3f getAccelBiasVariance() const { return getStateVariance<State::accel_bi... | [
"src/modules/ekf2/EKF/ekf.h"
] | [
{
"comment": "```suggestion\n```\nThe caller doesn't need to know that it's used for state prediction. But you could say that it's latitude-dependent.",
"path": "src/modules/ekf2/EKF/ekf.h",
"hunk": "@@ -294,6 +294,9 @@ class Ekf final : public EstimatorInterface\n \tVector3f getAccelBiasVariance() cons... | true | ||
PX4/PX4-Autopilot | 27,602 | comment_to_fix | feat(ekf2): use a latitude-dependent gravity model | ```suggestion
float _gravity{CONSTANTS_ONE_G}; ///< latitude-dependent gravity magnitude (m/s^2)
``` | 7f77f10828e1e1faf0d405edbff045953dfdd464 | 48bcc45ca83ab3dde82cf5fd67e5546cfae0db44 | diff --git a/src/modules/ekf2/EKF/ekf.h b/src/modules/ekf2/EKF/ekf.h
index 6313f307dc38..0ab1ad975143 100644
--- a/src/modules/ekf2/EKF/ekf.h
+++ b/src/modules/ekf2/EKF/ekf.h
@@ -294,6 +294,9 @@ class Ekf final : public EstimatorInterface
Vector3f getAccelBiasVariance() const { return getStateVariance<State::accel_bi... | [
"src/modules/ekf2/EKF/ekf.h"
] | [
{
"comment": "```suggestion\n\tfloat _gravity{CONSTANTS_ONE_G}; ///< latitude-dependent gravity magnitude (m/s^2)\n```",
"path": "src/modules/ekf2/EKF/ekf.h",
"hunk": "@@ -536,6 +539,8 @@ class Ekf final : public EstimatorInterface\n \tVector3f _earth_rate_NED{}; ///< earth rotation vector (NED) in rad/... | true | ||
PX4/PX4-Autopilot | 27,577 | issue_to_patch | refactor(simulation): use PX4 sensor driver wrappers in SIH and gz_bridge | ## Summary
Route the SIH and Gazebo (gz_bridge) simulated sensors through the general-purpose PX4 driver
wrappers (`PX4Accelerometer`, `PX4Gyroscope`, `PX4Magnetometer`, `PX4Rangefinder`), matching the
pattern `SimulatorMavlink` already uses.
This is preliminary groundwork for ideas regarding senso... | 1f175fa15331de1310795a7d2e86c02c79d61049 | 4683799fcb08fe01793208dbbecb900afb97aef3 | diff --git a/msg/SensorBaro.msg b/msg/SensorBaro.msg
index f13096d9aa99..8329e7e8a9f7 100644
--- a/msg/SensorBaro.msg
+++ b/msg/SensorBaro.msg
@@ -1,5 +1,5 @@
# Barometer sensor
-#
+#
# This is populated by barometer drivers and used by the EKF2 estimator.
# The information is published in the `SCALED_PRESSURE_n` M... | [
"msg/SensorBaro.msg",
"msg/SensorMag.msg",
"src/modules/simulation/gz_bridge/CMakeLists.txt",
"src/modules/simulation/gz_bridge/GZBridge.cpp",
"src/modules/simulation/gz_bridge/GZBridge.hpp",
"src/modules/simulation/simulator_sih/CMakeLists.txt",
"src/modules/simulation/simulator_sih/sih.cpp",
"src/mo... | [
{
"comment": "```suggestion\n\t_px4_mag.set_temperature(_temperature);\n```",
"path": "src/modules/simulation/gz_bridge/GZBridge.cpp",
"hunk": "@@ -390,29 +390,12 @@ void GZBridge::magnetometerCallback(const gz::msgs::Magnetometer &msg)\n {\n \tconst uint64_t timestamp = hrt_absolute_time();\n \n-\tdevi... | true | ||
PX4/PX4-Autopilot | 27,577 | comment_to_fix | refactor(simulation): use PX4 sensor driver wrappers in SIH and gz_bridge | ```suggestion
_px4_mag.set_temperature(_temperature);
``` | 1f175fa15331de1310795a7d2e86c02c79d61049 | 4683799fcb08fe01793208dbbecb900afb97aef3 | diff --git a/src/modules/simulation/gz_bridge/GZBridge.cpp b/src/modules/simulation/gz_bridge/GZBridge.cpp
index 3bbd170282f2..2818d6eb0a37 100644
--- a/src/modules/simulation/gz_bridge/GZBridge.cpp
+++ b/src/modules/simulation/gz_bridge/GZBridge.cpp
@@ -390,29 +390,12 @@ void GZBridge::magnetometerCallback(const gz::m... | [
"src/modules/simulation/gz_bridge/GZBridge.cpp"
] | [
{
"comment": "```suggestion\n\t_px4_mag.set_temperature(_temperature);\n```",
"path": "src/modules/simulation/gz_bridge/GZBridge.cpp",
"hunk": "@@ -390,29 +390,12 @@ void GZBridge::magnetometerCallback(const gz::msgs::Magnetometer &msg)\n {\n \tconst uint64_t timestamp = hrt_absolute_time();\n \n-\tdevi... | true | ||
PX4/PX4-Autopilot | 27,577 | comment_to_fix | refactor(simulation): use PX4 sensor driver wrappers in SIH and gz_bridge | I kind want to use the member function since it exists and we can delete the CTOR of all these classes (maybe it will save some flash 😟 ) | 1f175fa15331de1310795a7d2e86c02c79d61049 | 4683799fcb08fe01793208dbbecb900afb97aef3 | diff --git a/src/modules/simulation/gz_bridge/GZBridge.hpp b/src/modules/simulation/gz_bridge/GZBridge.hpp
index f821372034b0..d03df89f3f92 100644
--- a/src/modules/simulation/gz_bridge/GZBridge.hpp
+++ b/src/modules/simulation/gz_bridge/GZBridge.hpp
@@ -45,6 +45,10 @@
#include <px4_platform_common/posix.h>
#include ... | [
"src/modules/simulation/gz_bridge/GZBridge.hpp"
] | [
{
"comment": "I kind want to use the member function since it exists and we can delete the CTOR of all these classes (maybe it will save some flash 😟 )",
"path": "src/modules/simulation/gz_bridge/GZBridge.hpp",
"hunk": "@@ -143,7 +144,12 @@ class GZBridge : public ModuleBase, public ModuleParams, publi... | true | ||
PX4/PX4-Autopilot | 27,577 | comment_to_fix | refactor(simulation): use PX4 sensor driver wrappers in SIH and gz_bridge | snsr 😆 | 1f175fa15331de1310795a7d2e86c02c79d61049 | 4683799fcb08fe01793208dbbecb900afb97aef3 | diff --git a/src/modules/simulation/simulator_sih/sih.cpp b/src/modules/simulation/simulator_sih/sih.cpp
index cb91df4dfd1a..96ec64e81138 100644
--- a/src/modules/simulation/simulator_sih/sih.cpp
+++ b/src/modules/simulation/simulator_sih/sih.cpp
@@ -318,6 +318,8 @@ void Sih::parameters_updated()
_distance_snsr_min =... | [
"src/modules/simulation/simulator_sih/sih.cpp"
] | [
{
"comment": "snsr 😆 ",
"path": "src/modules/simulation/simulator_sih/sih.cpp",
"hunk": "@@ -318,6 +318,8 @@ void Sih::parameters_updated()\n \t_distance_snsr_min = _sih_distance_snsr_min.get();\n \t_distance_snsr_max = _sih_distance_snsr_max.get();\n \t_distance_snsr_override = _sih_distance_snsr_over... | true | ||
PX4/PX4-Autopilot | 27,485 | issue_to_patch | docs(docs): PX4 v1.17 now stable changes | PX4 v1.17 is now stable. This add the changes that should have been made to the docs before cutting the v1.18 release.
- Fix up sidebar to mark v1.17 as stable and v1.16 as not stable.
- Fix up the site title so it is v1.17. This makes a whole lot of other pages get a warning that docs are on a branch.
- Create a v1... | 240908caea3278d89dab49e6d724dcbefc54556d | 568e07ef3373f18980fb40c5c3fc7a37b661429d | diff --git a/docs/.vitepress/config.mjs b/docs/.vitepress/config.mjs
index c12b4e27ef1f..4b8844b12295 100644
--- a/docs/.vitepress/config.mjs
+++ b/docs/.vitepress/config.mjs
@@ -198,7 +198,8 @@ export default defineConfig({
text: "Version",
items: [
{ text: "main", link: "https://docs.px4.... | [
"docs/.vitepress/config.mjs",
"docs/en/SUMMARY.md",
"docs/en/releases/1.12.md",
"docs/en/releases/1.13.md",
"docs/en/releases/1.14.md",
"docs/en/releases/1.15.md",
"docs/en/releases/1.16.md",
"docs/en/releases/1.17.md",
"docs/en/releases/1.18.md",
"docs/en/releases/index.md",
"docs/en/releases/m... | [
{
"comment": "These changes were for 1.17. I'll correct it in a pr also adding more adjustments I had forgotten 😇 ",
"path": "docs/en/releases/1.18.md",
"hunk": "@@ -0,0 +1,149 @@\n+# PX4-Autopilot v1.18.0 Release Notes\n+\n+<Badge type=\"danger\" text=\"Alpha\" />\n+\n+<script setup>\n+import { useDat... | true | ||
PX4/PX4-Autopilot | 27,520 | issue_to_patch | fix(commander): refuse stale config_overrides on activation | ### Solved Problem
Fixes stale `config_overrides` cache reuse across external mode activations.
### Solution
Stamp received `config_overrides_request` entries with the local PX4 receive time, and reject cached mode/executor overrides that predate the current activation. Stale mode overrides fall back to safe defau... | 8ddbedf8686550480b6d735d509b360e5abbed0c | 2a9b99677c8a51bacc8228fbb67eff427aa04dbf | diff --git a/src/modules/commander/Commander.cpp b/src/modules/commander/Commander.cpp
index 36569946b2da..10e6f46212f0 100644
--- a/src/modules/commander/Commander.cpp
+++ b/src/modules/commander/Commander.cpp
@@ -2490,6 +2490,7 @@ void Commander::handleAutoDisarm()
bool Commander::handleModeIntentionAndFailsafe()
{... | [
"src/modules/commander/Commander.cpp",
"src/modules/commander/ModeManagement.cpp",
"src/modules/commander/ModeManagement.hpp"
] | [] | true | ||
PX4/PX4-Autopilot | 27,488 | issue_to_patch | [Bug] gz SITL: setting PX4_SIM_SPEED_FACTOR zeros world gravity
### Describe the bug
When `PX4_SIM_SPEED_FACTOR` is set for gz SITL, the startup script
`px4-rc.gzsim` issues a `set_physics` request that silently zeros the
world's gravity in the Gazebo physics engine. The resulting flight is
uncontrollable.
**Trigger... | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | ### Solved Problem
When `PX4_SIM_SPEED_FACTOR` is set for gz SITL, `px4-rc.gzsim` issued a
`set_physics` request containing only `real_time_factor`. Because
`gz.msgs.Physics` is applied as a complete message, all other fields
(notably `gravity` and `max_step_size`) defaulted to **0** per protobuf
semantics, silently z... | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "This topic doesn't exist — gz-sim publishes no `Physics` message on any topic (there's a `set_physics` *service*, but `CreatePublisher<msgs::Physics>` → 0 hits in gz-sim). `gz topic -e` streams forever, so `timeout 1` blocks the full second and returns empty on every launch — these four `awk` pars... | true | |
PX4/PX4-Autopilot | 27,488 | comment_to_fix | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | This topic doesn't exist — gz-sim publishes no `Physics` message on any topic (there's a `set_physics` *service*, but `CreatePublisher<msgs::Physics>` → 0 hits in gz-sim). `gz topic -e` streams forever, so `timeout 1` blocks the full second and returns empty on every launch — these four `awk` parses never fire, and the... | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "This topic doesn't exist — gz-sim publishes no `Physics` message on any topic (there's a `set_physics` *service*, but `CreatePublisher<msgs::Physics>` → 0 hits in gz-sim). `gz topic -e` streams forever, so `timeout 1` blocks the full second and returns empty on every launch — these four `awk` pars... | true | ||
PX4/PX4-Autopilot | 27,488 | comment_to_fix | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | These defaults are wrong for custom-gravity worlds (`rover` 0.002, `kthspacelab` 0.006, `frictionless` -9.8066). Only hit when the SDF can't be found (standalone launch, `PX4_GZ_WORLDS` unset) — worth a comment noting the limitation. | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "These defaults are wrong for custom-gravity worlds (`rover` 0.002, `kthspacelab` 0.006, `frictionless` -9.8066). Only hit when the SDF can't be found (standalone launch, `PX4_GZ_WORLDS` unset) — worth a comment noting the limitation.",
"path": "ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim",
... | true | ||
PX4/PX4-Autopilot | 27,488 | comment_to_fix | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | PR description is out of date, it should call this out | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "PR description is out of date, it should call this out",
"path": "ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim",
"hunk": "@@ -64,8 +64,13 @@ else\n \techo \"INFO [init] Standalone PX4 launch, waiting for Gazebo\"\n fi\n \n-# Wait for Gazebo world to be ready before proceeding\n+# Wait fo... | true | ||
PX4/PX4-Autopilot | 27,488 | comment_to_fix | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | ```suggestion
``` | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "```suggestion\n```",
"path": "ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim",
"hunk": "@@ -150,12 +155,36 @@ if [ -n \"${PX4_SIM_MODEL#*gz_}\" ] && [ -z \"${PX4_GZ_MODEL_NAME}\" ]; then\n \t\texit 1\n \tfi\n \n-\t# Set physics parameters for faster-than-realtime simulation if needed\n+\t# ... | true | ||
PX4/PX4-Autopilot | 27,488 | comment_to_fix | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | is there any realistic case where we'd actually change the gravity in the SDF? @Pedro-Roque maybe in space? 😆 | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "is there any realistic case where we'd actually change the gravity in the SDF? @Pedro-Roque maybe in space? 😆 ",
"path": "ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim",
"hunk": "@@ -150,12 +155,36 @@ if [ -n \"${PX4_SIM_MODEL#*gz_}\" ] && [ -z \"${PX4_GZ_MODEL_NAME}\" ]; then\n \t\texit ... | true | ||
PX4/PX4-Autopilot | 27,488 | comment_to_fix | fix(simulation): preserve gravity and step_size in px4-rc.gzsim set_physics | ```suggestion
GZ_GRAVITY_Z=${GZ_GRAVITY_Z:--9.80665}
``` | 5f19d86074fcb571b48266071b74dfbd28a8c132 | 4277af344fc67c9398810f8040170e0592093606 | diff --git a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
index 5b4676e60e50..c5003d6db119 100644
--- a/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
+++ b/ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim
@@ -64,8 +64,13 @@ else
echo "INFO [init] Standalone PX4 launch, w... | [
"ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim"
] | [
{
"comment": "```suggestion\n\t\tGZ_GRAVITY_Z=${GZ_GRAVITY_Z:--9.80665}\n```",
"path": "ROMFS/px4fmu_common/init.d-posix/px4-rc.gzsim",
"hunk": "@@ -150,12 +155,36 @@ if [ -n \"${PX4_SIM_MODEL#*gz_}\" ] && [ -z \"${PX4_GZ_MODEL_NAME}\" ]; then\n \t\texit 1\n \tfi\n \n-\t# Set physics parameters for fast... | true | ||
PX4/PX4-Autopilot | 27,549 | issue_to_patch | [Bug] Action request lost when two MAVLink rc inputs are actuated simultaneously resulting in an input being dropped
### Describe the bug
**Background**
Offboard mode test flight. Drone was briefly spinning (between ~`T+1028` and `T+1032`after a offboard yaw setpoint was sent, but the vehicle recovered.
At `T+1037.... | fix(msg): Increase orb queue length for ActionRequest | Fixes #27535
Increase `ORB_QUEUE_LENGTH` to 4 in `ActionRequest.msg` so that multiple simultaneous actions from eg. MAVLink RC switches are processed.
I set the size to 4 as I thought it was feasible that there could be two or more actions at once - the linked issue has two. (`ACTION_SWITCH_MODE` and `ACTION_K... | 04af7db2285e7b5b68efa05d17389036b84f1047 | dda044d3ed45d21f95c08c72129fa4937f5f6cbc | diff --git a/msg/ActionRequest.msg b/msg/ActionRequest.msg
index 65d101759c88..6723412b5ff1 100644
--- a/msg/ActionRequest.msg
+++ b/msg/ActionRequest.msg
@@ -24,3 +24,5 @@ uint8 SOURCE_RC_BUTTON = 2 # Triggered by a momentary button on the RC being pre
uint8 SOURCE_RC_MODE_SLOT = 3 # Mode change through the RC mode s... | [
"msg/ActionRequest.msg"
] | [] | true | |
PX4/PX4-Autopilot | 27,569 | issue_to_patch | feat(boards): add corvon_743v2 flight controller | Dear PX4 Developers,
This PR adds initial PX4 support for the CORVON 743v2 flight controller.
The board has been validated on hardware (boot, sensor bring-up/calibration, RC, MAVLink), and test logs are available on request.
Thank you for your time and for maintaining PX4.
Best regards,
Vince | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/bootloader.px4board b/boards/corvon/743v2/bootloader.px4board
new file mode 100644
index 000000000000..19b6e662be69
--- /dev/null
+++ b/boards/corvon/743v2/bootloader.px4board
@@ -0,0 +1,3 @@
+CONFIG_BOARD_TOOLCHAIN="arm-none-eabi"
+CONFIG_BOARD_ARCHITECTURE="cortex-m7"
+CONFIG_BOARD_RO... | [
"boards/corvon/743v2/bootloader.px4board",
"boards/corvon/743v2/default.px4board",
"boards/corvon/743v2/extras/corvon_743v2_bootloader.bin",
"boards/corvon/743v2/firmware.prototype",
"boards/corvon/743v2/init/rc.board_defaults",
"boards/corvon/743v2/init/rc.board_extras",
"boards/corvon/743v2/init/rc.bo... | [
{
"comment": "**[error]** [**bugprone\\-macro\\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**\nmacro replacement list should be enclosed in parentheses\n```suggestion\n# define BOOT_DEVICES_SELECTION (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)\n```",
"pat... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | **[error]** [**bugprone\-macro\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**
macro replacement list should be enclosed in parentheses
```suggestion
# define BOOT_DEVICES_SELECTION (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)
``` | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/src/hw_config.h b/boards/corvon/743v2/src/hw_config.h
new file mode 100644
index 000000000000..93506b8f1e5f
--- /dev/null
+++ b/boards/corvon/743v2/src/hw_config.h
@@ -0,0 +1,105 @@
+/****************************************************************************
+ *
+ * Copyright (c) 20... | [
"boards/corvon/743v2/src/hw_config.h"
] | [
{
"comment": "**[error]** [**bugprone\\-macro\\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**\nmacro replacement list should be enclosed in parentheses\n```suggestion\n# define BOOT_DEVICES_SELECTION (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)\n```",
"pat... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | **[error]** [**bugprone\-macro\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**
macro replacement list should be enclosed in parentheses
```suggestion
# define BOOT_DEVICES_FILTER_ONUSB (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)
``` | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/src/hw_config.h b/boards/corvon/743v2/src/hw_config.h
new file mode 100644
index 000000000000..93506b8f1e5f
--- /dev/null
+++ b/boards/corvon/743v2/src/hw_config.h
@@ -0,0 +1,105 @@
+/****************************************************************************
+ *
+ * Copyright (c) 20... | [
"boards/corvon/743v2/src/hw_config.h"
] | [
{
"comment": "**[error]** [**bugprone\\-macro\\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**\nmacro replacement list should be enclosed in parentheses\n```suggestion\n# define BOOT_DEVICES_FILTER_ONUSB (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)\n```",
"... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | **[error]** [**bugprone\-macro\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**
macro replacement list should be enclosed in parentheses
```suggestion
# define BOOT_DEVICES_SELECTION (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)
``` | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/src/hw_config.h b/boards/corvon/743v2/src/hw_config.h
new file mode 100644
index 000000000000..93506b8f1e5f
--- /dev/null
+++ b/boards/corvon/743v2/src/hw_config.h
@@ -0,0 +1,105 @@
+/****************************************************************************
+ *
+ * Copyright (c) 20... | [
"boards/corvon/743v2/src/hw_config.h"
] | [
{
"comment": "**[error]** [**bugprone\\-macro\\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**\nmacro replacement list should be enclosed in parentheses\n```suggestion\n# define BOOT_DEVICES_SELECTION (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)\n```",
"pat... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | **[error]** [**bugprone\-macro\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**
macro replacement list should be enclosed in parentheses
```suggestion
# define BOOT_DEVICES_FILTER_ONUSB (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)
``` | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/src/hw_config.h b/boards/corvon/743v2/src/hw_config.h
new file mode 100644
index 000000000000..93506b8f1e5f
--- /dev/null
+++ b/boards/corvon/743v2/src/hw_config.h
@@ -0,0 +1,105 @@
+/****************************************************************************
+ *
+ * Copyright (c) 20... | [
"boards/corvon/743v2/src/hw_config.h"
] | [
{
"comment": "**[error]** [**bugprone\\-macro\\-parentheses**](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/macro-parentheses.html) **[error]**\nmacro replacement list should be enclosed in parentheses\n```suggestion\n# define BOOT_DEVICES_FILTER_ONUSB (USB0_DEV|SERIAL0_DEV|SERIAL1_DEV)\n```",
"... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | Is there any benefit keeping this? | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/default.px4board b/boards/corvon/743v2/default.px4board
new file mode 100644
index 000000000000..574402be248a
--- /dev/null
+++ b/boards/corvon/743v2/default.px4board
@@ -0,0 +1,111 @@
+# CORVON 743V2 default PX4 build configuration
+# Board path: boards/corvon/743v2/
+# Build target: m... | [
"boards/corvon/743v2/default.px4board"
] | [
{
"comment": "Is there any benefit keeping this? ",
"path": "boards/corvon/743v2/default.px4board",
"hunk": "@@ -0,0 +1,114 @@\n+# CORVON 743V2 default PX4 build configuration\n+# Board path: boards/corvon/743v2/\n+# Build target: make corvon_743v2_default\n+# Board ID: 1229\n+# MCU: STM32H743V... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | Maybe this could also be mentioned somewhere in the docs? | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/init/rc.board_defaults b/boards/corvon/743v2/init/rc.board_defaults
new file mode 100755
index 000000000000..440ea61aa961
--- /dev/null
+++ b/boards/corvon/743v2/init/rc.board_defaults
@@ -0,0 +1,67 @@
+#!/bin/sh
+#
+# CORVON 743V2 board-specific default parameters.
+# Sourced by rcS du... | [
"boards/corvon/743v2/init/rc.board_defaults"
] | [
{
"comment": "Maybe this could also be mentioned somewhere in the docs?",
"path": "boards/corvon/743v2/init/rc.board_defaults",
"hunk": "@@ -0,0 +1,67 @@\n+#!/bin/sh\n+#\n+# CORVON 743V2 board-specific default parameters.\n+# Sourced by rcS during boot; values become defaults the user can override.\n+#\... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | @julianoes this is Kakute I think? I assume it is ok then? | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/nuttx-config/bootloader/defconfig b/boards/corvon/743v2/nuttx-config/bootloader/defconfig
new file mode 100644
index 000000000000..690e82a15212
--- /dev/null
+++ b/boards/corvon/743v2/nuttx-config/bootloader/defconfig
@@ -0,0 +1,85 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT... | [
"boards/corvon/743v2/nuttx-config/bootloader/defconfig"
] | [
{
"comment": "@julianoes this is Kakute I think? I assume it is ok then? ",
"path": "boards/corvon/743v2/nuttx-config/bootloader/defconfig",
"hunk": "@@ -0,0 +1,85 @@\n+#\n+# This file is autogenerated: PLEASE DO NOT EDIT IT.\n+#\n+# You can use \"make menuconfig\" to make any modifications to the insta... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | How do we contact you - can you add a contact link> | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/docs/en/flight_controller/corvon_743v2.md b/docs/en/flight_controller/corvon_743v2.md
new file mode 100644
index 000000000000..902f99cad6da
--- /dev/null
+++ b/docs/en/flight_controller/corvon_743v2.md
@@ -0,0 +1,173 @@
+# CORVON 743v2
+
+<Badge type="tip" text="PX4 v1.18" />
+
+:::warning
+PX4 does not ma... | [
"docs/en/flight_controller/corvon_743v2.md"
] | [
{
"comment": "How do we contact you - can you add a contact link>",
"path": "docs/en/flight_controller/corvon_743v2.md",
"hunk": "@@ -0,0 +1,153 @@\n+# CORVON 743v2\n+\n+<Badge type=\"tip\" text=\"PX4 v1.18\" />\n+\n+:::warning\n+PX4 does not manufacture this (or any) autopilot.\n+Contact the manufactur... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | Are all the outputs in the same groups? | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/docs/en/flight_controller/corvon_743v2.md b/docs/en/flight_controller/corvon_743v2.md
new file mode 100644
index 000000000000..902f99cad6da
--- /dev/null
+++ b/docs/en/flight_controller/corvon_743v2.md
@@ -0,0 +1,173 @@
+# CORVON 743v2
+
+<Badge type="tip" text="PX4 v1.18" />
+
+:::warning
+PX4 does not ma... | [
"docs/en/flight_controller/corvon_743v2.md"
] | [
{
"comment": "Are all the outputs in the same groups?",
"path": "docs/en/flight_controller/corvon_743v2.md",
"hunk": "@@ -0,0 +1,153 @@\n+# CORVON 743v2\n+\n+<Badge type=\"tip\" text=\"PX4 v1.18\" />\n+\n+:::warning\n+PX4 does not manufacture this (or any) autopilot.\n+Contact the manufacturer for hardw... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | Only if it is accepted in the very near future will it go into v1.18 | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/docs/en/flight_controller/corvon_743v2.md b/docs/en/flight_controller/corvon_743v2.md
new file mode 100644
index 000000000000..902f99cad6da
--- /dev/null
+++ b/docs/en/flight_controller/corvon_743v2.md
@@ -0,0 +1,173 @@
+# CORVON 743v2
+
+<Badge type="tip" text="PX4 v1.18" />
+
+:::warning
+PX4 does not ma... | [
"docs/en/flight_controller/corvon_743v2.md"
] | [
{
"comment": "Only if it is accepted in the very near future will it go into v1.18",
"path": "docs/en/flight_controller/corvon_743v2.md",
"hunk": "@@ -0,0 +1,153 @@\n+# CORVON 743v2\n+\n+<Badge type=\"tip\" text=\"PX4 v1.18\" />",
"resolving_sha": "e659507bfa3f028f2422c5748994990bb4bc62fa",
"res... | true | ||
PX4/PX4-Autopilot | 27,569 | comment_to_fix | feat(boards): add corvon_743v2 flight controller | This checks out:
https://github.com/ArduPilot/ardupilot/blob/e70d892e2c736289c2633f59165784a71dab443c/Tools/AP_Bootloader/board_types.txt#L345 | 2b2c506a95cbe1e419857059b4dd66e58f798f15 | e659507bfa3f028f2422c5748994990bb4bc62fa | diff --git a/boards/corvon/743v2/firmware.prototype b/boards/corvon/743v2/firmware.prototype
new file mode 100644
index 000000000000..eb7f3a225e5c
--- /dev/null
+++ b/boards/corvon/743v2/firmware.prototype
@@ -0,0 +1,13 @@
+{
+ "board_id": 1229,
+ "magic": "PX4FWv1",
+ "description": "Firmware file for Corvon ... | [
"boards/corvon/743v2/firmware.prototype"
] | [
{
"comment": "This checks out:\nhttps://github.com/ArduPilot/ardupilot/blob/e70d892e2c736289c2633f59165784a71dab443c/Tools/AP_Bootloader/board_types.txt#L345",
"path": "boards/corvon/743v2/firmware.prototype",
"hunk": "@@ -0,0 +1,13 @@\n+{\n+ \"board_id\": 1229,",
"resolving_sha": "e659507bfa3f02... | true | ||
PX4/PX4-Autopilot | 27,151 | issue_to_patch | feat(mavlink): map @MAV_LOG virtual directory to log root | Implements the MAVLink FTP "Virtual Directory Entries" convention so that clients can access log files without knowing the flight-stack storage layout. Requests whose path starts with @MAV_LOG are remapped to CONFIG_BOARD_ROOT_PATH "/log", matching the logger's LOG_ROOT.
See https://github.com/mavlink/mavlink-devgui... | c94a06eba3eb34da305404210a748bd96315c19b | 56eda1f886bd413750b1d91ebc2c2510c2fc4073 | diff --git a/src/modules/mavlink/mavlink_ftp.cpp b/src/modules/mavlink/mavlink_ftp.cpp
index 3809847f9025..6ee90602259e 100644
--- a/src/modules/mavlink/mavlink_ftp.cpp
+++ b/src/modules/mavlink/mavlink_ftp.cpp
@@ -48,6 +48,8 @@
using namespace time_literals;
constexpr const char MavlinkFTP::_root_dir[];
+constexpr... | [
"src/modules/mavlink/mavlink_ftp.cpp",
"src/modules/mavlink/mavlink_ftp.h"
] | [
{
"comment": "It's not up to me but I would make sure the spec either requires a prefix `/` or forbids it instead of having this ambiguity.",
"path": "src/modules/mavlink/mavlink_ftp.cpp",
"hunk": "@@ -306,6 +308,24 @@ MavlinkFTP::_reply(mavlink_file_transfer_protocol_t *ftp_req)\n }\n void MavlinkFTP::... | true | ||
PX4/PX4-Autopilot | 27,151 | comment_to_fix | feat(mavlink): map @MAV_LOG virtual directory to log root | It's not up to me but I would make sure the spec either requires a prefix `/` or forbids it instead of having this ambiguity. | c94a06eba3eb34da305404210a748bd96315c19b | 56eda1f886bd413750b1d91ebc2c2510c2fc4073 | diff --git a/src/modules/mavlink/mavlink_ftp.cpp b/src/modules/mavlink/mavlink_ftp.cpp
index 3809847f9025..6ee90602259e 100644
--- a/src/modules/mavlink/mavlink_ftp.cpp
+++ b/src/modules/mavlink/mavlink_ftp.cpp
@@ -48,6 +48,8 @@
using namespace time_literals;
constexpr const char MavlinkFTP::_root_dir[];
+constexpr... | [
"src/modules/mavlink/mavlink_ftp.cpp"
] | [
{
"comment": "It's not up to me but I would make sure the spec either requires a prefix `/` or forbids it instead of having this ambiguity.",
"path": "src/modules/mavlink/mavlink_ftp.cpp",
"hunk": "@@ -306,6 +308,24 @@ MavlinkFTP::_reply(mavlink_file_transfer_protocol_t *ftp_req)\n }\n void MavlinkFTP::... | true | ||
PX4/PX4-Autopilot | 27,112 | issue_to_patch | [BACKPORT v1.17] feat(boards/px4_fmu-v6c): add support for LSM6DSV16X (#26951) | **Backporting #26951 to v1.17**
* feat(drivers): add ST LSM6DSV16X IMU driver
Add a new SPI driver for the ST LSM6DSV16X 6-axis IMU with FIFO-based accel, gyro, and temperature acquisition.
The driver supports continuous FIFO mode with tagged sample parsing, DRDY interrupt triggering via FIFO threshold, and dy... | 5d0378797a7981b5acdcf69eba6b509e15b1cf94 | 3fc641e590a255f6027a396bf6bf89570ef06bce | diff --git a/boards/px4/fmu-v6c/default.px4board b/boards/px4/fmu-v6c/default.px4board
index a60c2f65eb5a..0702a6474c9c 100644
--- a/boards/px4/fmu-v6c/default.px4board
+++ b/boards/px4/fmu-v6c/default.px4board
@@ -22,6 +22,7 @@ CONFIG_DRIVERS_HEATER=y
CONFIG_DRIVERS_IMU_BOSCH_BMI055=y
CONFIG_DRIVERS_IMU_BOSCH_BMI088... | [
"boards/px4/fmu-v6c/default.px4board",
"boards/px4/fmu-v6c/init/rc.board_sensors",
"boards/px4/fmu-v6c/src/spi.cpp",
"src/drivers/drv_sensor.h",
"src/drivers/imu/st/lsm6dsv/CMakeLists.txt",
"src/drivers/imu/st/lsm6dsv/Kconfig",
"src/drivers/imu/st/lsm6dsv/LSM6DSV.cpp",
"src/drivers/imu/st/lsm6dsv/LSM6... | [] | true | ||
PX4/PX4-Autopilot | 27,274 | issue_to_patch | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | This PR wires the OpenDroneID Basic ID data path from MAVLink to DroneCAN
Remote ID:
- receives OPEN_DRONE_ID_BASIC_ID in MavlinkReceiver
- publishes the Basic ID fields to uORB
- consumes the uORB data in the DroneCAN Remote ID backend
- broadcasts DroneCAN BasicID using the ground-station-provided id_type,
... | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/msg/CMakeLists.txt b/msg/CMakeLists.txt
index 1d7dae1bd75d..d2d4dcb1b7c0 100644
--- a/msg/CMakeLists.txt
+++ b/msg/CMakeLists.txt
@@ -152,6 +152,7 @@ set(msg_files
OffboardControlMode.msg
OnboardComputerStatus.msg
OpenDroneIdArmStatus.msg
+ OpenDroneIdBasicId.msg
OpenDroneIdOperatorId.msg
OpenDro... | [
"msg/CMakeLists.txt",
"msg/OpenDroneIdBasicId.msg",
"src/drivers/uavcan/remoteid.cpp",
"src/drivers/uavcan/remoteid.hpp",
"src/modules/mavlink/mavlink_receiver.cpp",
"src/modules/mavlink/mavlink_receiver.h"
] | [
{
"comment": "```suggestion\n```",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -69,6 +72,7 @@ int UavcanRemoteIDController::init()\n \n void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n {\n+",
"resolving_sha": "a4e315f8447edd3459f76f942d31e65c765049f7",
"res... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "```suggestion\n```",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -69,6 +72,7 @@ int UavcanRemoteIDController::init()\n \n void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n {\n+",
"resolving_sha": "a4e315f8447edd3459f76f942d31e65c765049f7",
"res... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
int _odid_bid_src{0};
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.hpp b/src/drivers/uavcan/remoteid.hpp
index 1d1fcaa83cef..3c2916bd0662 100644
--- a/src/drivers/uavcan/remoteid.hpp
+++ b/src/drivers/uavcan/remoteid.hpp
@@ -41,6 +41,7 @@
#include <uORB/topics/vehicle_air_data.h>
#include <uORB/topics/vehicle_local_position.h>
#include <uORB... | [
"src/drivers/uavcan/remoteid.hpp"
] | [
{
"comment": "```suggestion\n\tint _odid_bid_src{0};\n```",
"path": "src/drivers/uavcan/remoteid.hpp",
"hunk": "@@ -104,4 +109,11 @@ class UavcanRemoteIDController : public ModuleParams\n \t void (UavcanRemoteIDController::*)(const uavcan::ReceivedDataStructure<dronecan::remoteid::ArmStatus> &) >;\... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
dronecan::remoteid::BasicID msg {};
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "```suggestion\n\tdronecan::remoteid::BasicID msg {};\n```",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -80,20 +84,48 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n \n void UavcanRemoteIDController::send_basic_id()\n {\n-\tdronecan::remoteid::Bas... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | single line | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "single line",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -80,20 +84,48 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n \n void UavcanRemoteIDController::send_basic_id()\n {\n-\tdronecan::remoteid::BasicID basic_id {};\n-\t// basic_id.id_or_mac //... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | board UID is never going to be a valid serial, so we need to re-work where it comes from if not over mavlink (eg onboard immutable file in flash) | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.hpp b/src/drivers/uavcan/remoteid.hpp
index 1d1fcaa83cef..3c2916bd0662 100644
--- a/src/drivers/uavcan/remoteid.hpp
+++ b/src/drivers/uavcan/remoteid.hpp
@@ -41,6 +41,7 @@
#include <uORB/topics/vehicle_air_data.h>
#include <uORB/topics/vehicle_local_position.h>
#include <uORB... | [
"src/drivers/uavcan/remoteid.hpp"
] | [
{
"comment": "board UID is never going to be a valid serial, so we need to re-work where it comes from if not over mavlink (eg onboard immutable file in flash)",
"path": "src/drivers/uavcan/remoteid.hpp",
"hunk": "@@ -69,6 +70,9 @@ class UavcanRemoteIDController : public ModuleParams\n \tTimerCbBinder;\... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | one line | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index cb330bb9d85f..c46017e53a09 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -273,6 +273,10 @@ MavlinkReceiver::handle_message(mavlink_message_t *msg)
handle_me... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [
{
"comment": "one line",
"path": "src/modules/mavlink/mavlink_receiver.cpp",
"hunk": "@@ -3176,6 +3180,24 @@ MavlinkReceiver::handle_message_gimbal_device_attitude_status(mavlink_message_t\n \t_gimbal_device_attitude_status_pub.publish(gimbal_attitude_status);\n }\n \n+void MavlinkReceiver::handle_messa... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
mavlink_open_drone_id_basic_id_t bdid_module {};
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index cb330bb9d85f..c46017e53a09 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -273,6 +273,10 @@ MavlinkReceiver::handle_message(mavlink_message_t *msg)
handle_me... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [
{
"comment": "```suggestion\n\tmavlink_open_drone_id_basic_id_t bdid_module {};\n```",
"path": "src/modules/mavlink/mavlink_receiver.cpp",
"hunk": "@@ -3176,6 +3180,24 @@ MavlinkReceiver::handle_message_gimbal_device_attitude_status(mavlink_message_t\n \t_gimbal_device_attitude_status_pub.publish(gimbal... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
open_drone_id_basic_id_s basic_id {};
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index cb330bb9d85f..c46017e53a09 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -273,6 +273,10 @@ MavlinkReceiver::handle_message(mavlink_message_t *msg)
handle_me... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [
{
"comment": "```suggestion\n\topen_drone_id_basic_id_s basic_id {};\n```",
"path": "src/modules/mavlink/mavlink_receiver.cpp",
"hunk": "@@ -3176,6 +3180,24 @@ MavlinkReceiver::handle_message_gimbal_device_attitude_status(mavlink_message_t\n \t_gimbal_device_attitude_status_pub.publish(gimbal_attitude_s... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
```
unnecessary | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index cb330bb9d85f..c46017e53a09 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -273,6 +273,10 @@ MavlinkReceiver::handle_message(mavlink_message_t *msg)
handle_me... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [
{
"comment": "```suggestion\n```\nunnecessary",
"path": "src/modules/mavlink/mavlink_receiver.cpp",
"hunk": "@@ -3176,6 +3180,24 @@ MavlinkReceiver::handle_message_gimbal_device_attitude_status(mavlink_message_t\n \t_gimbal_device_attitude_status_pub.publish(gimbal_attitude_status);\n }\n \n+void Mavlin... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
open_drone_id_basic_id_s basic_id {};
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "```suggestion\n\t\t\topen_drone_id_basic_id_s basic_id {};\n```",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -80,20 +84,48 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n \n void UavcanRemoteIDController::send_basic_id()\n {\n-\tdronecan::remotei... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | use sizeof the target buffer not the source buffer | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "use sizeof the target buffer not the source buffer",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -80,20 +84,48 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n \n void UavcanRemoteIDController::send_basic_id()\n {\n-\tdronecan::remoteid::BasicID ba... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | Can you add comments here per the message spec? You can look at some of the others as an example. @hamishwillee might be able to help out here | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/msg/OpenDroneIdBasicId.msg b/msg/OpenDroneIdBasicId.msg
new file mode 100644
index 000000000000..4811fd27ce9a
--- /dev/null
+++ b/msg/OpenDroneIdBasicId.msg
@@ -0,0 +1,5 @@
+uint64 timestamp
+uint8[20] id_or_mac # Only used for drone ID data received from other UAs, no null termination, null filled if shor... | [
"msg/OpenDroneIdBasicId.msg"
] | [
{
"comment": "Can you add comments here per the message spec? You can look at some of the others as an example. @hamishwillee might be able to help out here",
"path": "msg/OpenDroneIdBasicId.msg",
"hunk": "@@ -0,0 +1,5 @@\n+uint64 timestamp",
"resolving_sha": "a4e315f8447edd3459f76f942d31e65c765049f... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | I wouldn't even have a parameter for it. If no mavlink message has been received just fallback to the board uuid | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "I wouldn't even have a parameter for it. If no mavlink message has been received just fallback to the board uuid",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -53,6 +53,9 @@ UavcanRemoteIDController::UavcanRemoteIDController(uavcan::INode &node) :\n \n int UavcanRemoteIDControll... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
uint8[20] id_or_mac # Only used for drone ID data received from other UAs, no null termination, null filled if shorter
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/msg/OpenDroneIdBasicId.msg b/msg/OpenDroneIdBasicId.msg
new file mode 100644
index 000000000000..4811fd27ce9a
--- /dev/null
+++ b/msg/OpenDroneIdBasicId.msg
@@ -0,0 +1,5 @@
+uint64 timestamp
+uint8[20] id_or_mac # Only used for drone ID data received from other UAs, no null termination, null filled if shor... | [
"msg/OpenDroneIdBasicId.msg"
] | [
{
"comment": "```suggestion\nuint8[20] id_or_mac\t# Only used for drone ID data received from other UAs, no null termination, null filled if shorter\n```",
"path": "msg/OpenDroneIdBasicId.msg",
"hunk": "@@ -0,0 +1,5 @@\n+uint64 timestamp\n+uint8[20] id_or_mac\t# Only used for drone ID data received from... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
uint8[20] uas_id # UAS (Unmanned Aircraft System) ID following the format specified by id_type, no null termination, null filled if shorter
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/msg/OpenDroneIdBasicId.msg b/msg/OpenDroneIdBasicId.msg
new file mode 100644
index 000000000000..4811fd27ce9a
--- /dev/null
+++ b/msg/OpenDroneIdBasicId.msg
@@ -0,0 +1,5 @@
+uint64 timestamp
+uint8[20] id_or_mac # Only used for drone ID data received from other UAs, no null termination, null filled if shor... | [
"msg/OpenDroneIdBasicId.msg"
] | [
{
"comment": "```suggestion\nuint8[20] uas_id\t# UAS (Unmanned Aircraft System) ID following the format specified by id_type, no null termination, null filled if shorter\n```",
"path": "msg/OpenDroneIdBasicId.msg",
"hunk": "@@ -0,0 +1,5 @@\n+uint64 timestamp\n+uint8[20] id_or_mac\t# Only used for drone ... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
memcpy(msg.uas_id, basic_id.uas_id, sizeof(msg.uas_id));
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "```suggestion\n\t\t\tmemcpy(msg.uas_id, basic_id.uas_id, sizeof(msg.uas_id));\n```",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n \n void UavcanRemoteIDController::send_basic_id()\n {\n-... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | ```suggestion
memcpy(msg.uas_id, basic_id.uas_id, sizeof(msg.uas_id));
``` | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/drivers/uavcan/remoteid.cpp b/src/drivers/uavcan/remoteid.cpp
index a2f373b767b0..4e76e71134a8 100644
--- a/src/drivers/uavcan/remoteid.cpp
+++ b/src/drivers/uavcan/remoteid.cpp
@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)
void UavcanRemoteIDControll... | [
"src/drivers/uavcan/remoteid.cpp"
] | [
{
"comment": "```suggestion\n\t\tmemcpy(msg.uas_id, basic_id.uas_id, sizeof(msg.uas_id));\n```",
"path": "src/drivers/uavcan/remoteid.cpp",
"hunk": "@@ -80,20 +80,41 @@ void UavcanRemoteIDController::periodic_update(const uavcan::TimerEvent &)\n \n void UavcanRemoteIDController::send_basic_id()\n {\n-\t... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | I think we need to check the `target_system` and `target_component` here. If it is set with 0/0, it's clearly just an information and meant to be forwarded and not applied. If they are specifically targeted at us, we should probably set it.
In other words, I'm worried that we end up with a circular logic where a MAVLi... | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index cb330bb9d85f..c46017e53a09 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -273,6 +273,10 @@ MavlinkReceiver::handle_message(mavlink_message_t *msg)
handle_me... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [
{
"comment": "I think we need to check the `target_system` and `target_component` here. If it is set with 0/0, it's clearly just an information and meant to be forwarded and not applied. If they are specifically targeted at us, we should probably set it.\n\nIn other words, I'm worried that we end up with a circ... | true | ||
PX4/PX4-Autopilot | 27,274 | comment_to_fix | fix(dronecan): forward MAVLink OpenDroneID Basic ID to Remote ID | Ok, so we will accept 1/0, I suppose that's ok? | 96e6fd0a46624449baae03246b65d2efb80fbccd | a4e315f8447edd3459f76f942d31e65c765049f7 | diff --git a/src/modules/mavlink/mavlink_receiver.cpp b/src/modules/mavlink/mavlink_receiver.cpp
index cb330bb9d85f..c46017e53a09 100644
--- a/src/modules/mavlink/mavlink_receiver.cpp
+++ b/src/modules/mavlink/mavlink_receiver.cpp
@@ -273,6 +273,10 @@ MavlinkReceiver::handle_message(mavlink_message_t *msg)
handle_me... | [
"src/modules/mavlink/mavlink_receiver.cpp"
] | [
{
"comment": "Ok, so we will accept 1/0, I suppose that's ok?",
"path": "src/modules/mavlink/mavlink_receiver.cpp",
"hunk": "@@ -3536,6 +3180,27 @@ MavlinkReceiver::handle_message_gimbal_device_attitude_status(mavlink_message_t\n \t_gimbal_device_attitude_status_pub.publish(gimbal_attitude_status);\n }\... | true | ||
PX4/PX4-Autopilot | 27,590 | issue_to_patch | fix(dataman): expose mission item limit to clients | ### Solved Problem
CONFIG_NUM_MISSION_ITMES_SUPPORTED is used by dataman.h to size dataman mission storage constants. That
header is also used by dataman clients, not only by the dataman module itself.
When CONFIG_MODULES_DATAMAN=n, the Kconfig symbol was hidden by depends on MODULES_DATAMAN, so dataman-
... | 77edb0dda6dc69566bad65d909b556824c549320 | 88f6bfc312045ef153079d1ab0ecc8f54abd8ee9 | diff --git a/src/modules/dataman/Kconfig b/src/modules/dataman/Kconfig
index 9e82a5425e87..fa8dac2db8b0 100644
--- a/src/modules/dataman/Kconfig
+++ b/src/modules/dataman/Kconfig
@@ -23,8 +23,9 @@ menuconfig DATAMAN_PERSISTENT_STORAGE
menuconfig NUM_MISSION_ITMES_SUPPORTED
int "Maximum number of mission items"
def... | [
"src/modules/dataman/Kconfig"
] | [
{
"comment": "we should fix the name while we're here",
"path": "src/modules/dataman/Kconfig",
"hunk": "@@ -23,8 +23,9 @@ menuconfig DATAMAN_PERSISTENT_STORAGE\n menuconfig NUM_MISSION_ITMES_SUPPORTED",
"resolving_sha": "88f6bfc312045ef153079d1ab0ecc8f54abd8ee9",
"resolving_diff": "diff --git a/... | true | ||
PX4/PX4-Autopilot | 27,582 | issue_to_patch | fix(fw_mode_manager): correct loiter direction in trajectory setpoint interface | ### Solved Problem
The trajectory setpoint interface for fixed-wings is currently passing an incorrect loiter direction to the NPFG controller.
### Solution
Corrected the loiter direction sign to comply with the NED (North-East-Down) right-hand rule convention.
By convention, a positive loiter radius corres... | 77edb0dda6dc69566bad65d909b556824c549320 | d16d696de5e398dcb7f90054017f0d7e123fe822 | diff --git a/src/modules/fw_mode_manager/FixedWingModeManager.cpp b/src/modules/fw_mode_manager/FixedWingModeManager.cpp
index 2b92faae33c5..470fd387c8ff 100644
--- a/src/modules/fw_mode_manager/FixedWingModeManager.cpp
+++ b/src/modules/fw_mode_manager/FixedWingModeManager.cpp
@@ -2151,7 +2151,7 @@ FixedWingModeManage... | [
"src/modules/fw_mode_manager/FixedWingModeManager.cpp"
] | [] | true | ||
PaddlePaddle/Paddle | 79,313 | issue_to_patch | [Typing] Clean up invalid `python.paddle` imports | ### PR Category
Environment Adaptation
### PR Types
Improvements
### Description
This PR cleans up the remaining invalid `python.paddle` import found on latest `develop`.
- Replace the type-checking-only import in `python/paddle/amp/grad_scaler.py` with the public `paddle.optimizer.optimizer` path.
- Verified no r... | 886db26b5740bdfbd8b75c4ba3dfd833e77d6845 | 0a47ed6b7cac4714632382e67c3709c3171ee19f | diff --git a/python/paddle/amp/grad_scaler.py b/python/paddle/amp/grad_scaler.py
index d7f99f1a90563..5fd8ff20a2041 100644
--- a/python/paddle/amp/grad_scaler.py
+++ b/python/paddle/amp/grad_scaler.py
@@ -37,8 +37,8 @@
if TYPE_CHECKING:
from paddle import Tensor
+ from paddle.optimizer.optimizer import Optim... | [
"python/paddle/amp/grad_scaler.py"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.