repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
ReactiveX/RxAndroid
410
issue_to_patch
Update project dependencies
83d942353340a63b3f6529e1c5a469c1101786d5
b8036e97d0bba63fe315312daabad9dc61dcc7b7
diff --git a/README.md b/README.md index e80037e6..ee7a04ca 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ Since RxAndroid is part of the RxJava family the communication channels are simi compile 'io.reactivex.rxjava2:rxandroid:2.0.1' // Because RxAndroid releases are few and far between, it is recommended ...
[ "README.md", "build.gradle", "rxandroid/build.gradle", "rxandroid/src/test/java/io/reactivex/android/schedulers/HandlerSchedulerTest.java" ]
[]
diff --git a/rxandroid/src/test/java/io/reactivex/android/schedulers/HandlerSchedulerTest.java b/rxandroid/src/test/java/io/reactivex/android/schedulers/HandlerSchedulerTest.java index 8aa3c2bd..e61ce1e1 100644 --- a/rxandroid/src/test/java/io/reactivex/android/schedulers/HandlerSchedulerTest.java +++ b/rxandroid/src/t...
true
ReactiveX/RxAndroid
403
issue_to_patch
Update AGP 2.3.3 → 3.0.0, Android Maven Gradle Plugin 1.4.1 → 2.0.
Related to #399. - AGP 3.x https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html - Android Maven Gradle Plugin https://github.com/dcendents/android-maven-gradle-plugin/releases/tag/2.0 Previous [RxAndroid 2.0.1 pom](https://search.maven.org/remotecontent?filepath=io/reactivex/rxjava2/rxan...
be4561837f898eb8810f9cec6d458a50162bc8b0
f876b9bf13f0732484b1e838e656eb266c5d609e
diff --git a/.travis.yml b/.travis.yml index c99ad575..8ef02144 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,7 +8,7 @@ android: - tools - platform-tools - android-26 - - build-tools-26.0.1 + - build-tools-26.0.2 # as per http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based...
[ ".travis.yml", "build.gradle", "rxandroid/build.gradle", "sample-app/build.gradle" ]
[ { "comment": "Had to move to root `build.gradle` https://d.android.com/r/tools/buildscript-classpath-check.html", "path": "rxandroid/build.gradle", "hunk": "@@ -1,11 +1,3 @@\n-buildscript {", "resolving_sha": "f876b9bf13f0732484b1e838e656eb266c5d609e", "resolving_diff": "diff --git a/rxandroid/b...
true
ReactiveX/RxJava
8,117
issue_to_patch
chore(deps): bump jupiterVersion from 6.0.3 to 6.1.0
Bumps `jupiterVersion` from 6.0.3 to 6.1.0. Updates `org.junit.jupiter:junit-jupiter` from 6.0.3 to 6.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit-framework/releases">org.junit.jupiter:junit-jupiter's releases</a>.</em></p> <blockquote> <p>JUnit 6.1.0 =...
968643821ebb959867da8e3de8aea14ba3280f22
0bf424a4c1f4c2aad5e3cac7212f14d485eb2d0c
diff --git a/build.gradle b/build.gradle index 640f7e7f60..f530cc1357 100644 --- a/build.gradle +++ b/build.gradle @@ -19,7 +19,7 @@ ext { mockitoVersion = "4.11.0" jmhLibVersion = "1.37" guavaVersion = "33.6.0-jre" - jupiterVersion = "6.0.3" + jupiterVersion = "6.1.0" jupiterLauncherVersion =...
[ "build.gradle" ]
[]
true
ReactiveX/RxJava
8,116
issue_to_patch
chore(deps): bump jupiterLauncherVersion from 6.0.3 to 6.1.0
Bumps `jupiterLauncherVersion` from 6.0.3 to 6.1.0. Updates `org.junit.platform:junit-platform-commons` from 6.0.3 to 6.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit-framework/releases">org.junit.platform:junit-platform-commons's releases</a>.</em></p> <...
3bda03c26cc5dd6e136388d1dee76a593b4234ab
1202858469ca1e31aac122378ccf2dfd7cc852ff
diff --git a/build.gradle b/build.gradle index 56fbe5e1b4..3d56a753b2 100644 --- a/build.gradle +++ b/build.gradle @@ -20,7 +20,7 @@ ext { jmhLibVersion = "1.37" guavaVersion = "33.6.0-jre" jupiterVersion = "6.0.3" - jupiterLauncherVersion = "6.0.3" + jupiterLauncherVersion = "6.1.0" } def rele...
[ "build.gradle" ]
[]
true
ReactiveX/RxJava
8,130
issue_to_patch
chore(deps): bump gradle/actions from 6.1.0 to 6.1.1
Bumps [gradle/actions](https://github.com/gradle/actions) from 6.1.0 to 6.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gradle/actions/releases">gradle/actions's releases</a>.</em></p> <blockquote> <h2>v6.1.1</h2> <p>This release updates various dependency versions, res...
4136d3c39033b274e0c2e26f5d6a9b7df72de438
ab49d947b195e8c6fe70bc5198c17a05429f3639
diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml index 97d1c63bc7..db5bbaa884 100644 --- a/.github/workflows/gradle-wrapper-validation.yml +++ b/.github/workflows/gradle-wrapper-validation.yml @@ -10,6 +10,6 @@ jobs: runs-on: ubuntu-latest steps: ...
[ ".github/workflows/gradle-wrapper-validation.yml" ]
[]
true
ReactiveX/RxJava
8,129
issue_to_patch
chore(deps): bump codecov/codecov-action from 6.0.1 to 7.0.0
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6.0.1 to 7.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v7.0.0</h2> <p>⚠️ Due to migration i...
ce0c2330ec254ba4ba217ed8663b18ac9d8114d1
446d8715ee7be80ff05525986e7573eb3182c174
diff --git a/.github/workflows/gradle_branch.yml b/.github/workflows/gradle_branch.yml index 6f646e9520..6fcfa0de82 100644 --- a/.github/workflows/gradle_branch.yml +++ b/.github/workflows/gradle_branch.yml @@ -34,7 +34,7 @@ jobs: - name: Build RxJava run: ./gradlew build --stacktrace - name: Upload to...
[ ".github/workflows/gradle_branch.yml", ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,127
issue_to_patch
chore(deps): bump github/codeql-action from 4.36.1 to 4.36.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.36.1 to 4.36.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.36.2</h2> <ul> <li>Cache CodeQL CLI ver...
6beb0e3913a9003045161cb27fa048ecee21f389
6912104881199bf7a2e4ec2bf4a013106a6270f2
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index f494fa7ab9..73893a704a 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,123
issue_to_patch
chore(deps): bump github/codeql-action from 4.36.0 to 4.36.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.36.0 to 4.36.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.36.1</h2> <p>No user facing changes.</p...
17e6f21c87f5d75b832b6f6fc0448603ae959b58
0bf2d92e93a9901e003489ab4737e9fa11ac7e05
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index cc033bcdee..c874687ead 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,124
issue_to_patch
chore(deps): bump actions/checkout from 6.0.2 to 6.0.3
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v6.0.3</h2> <h2>What's Changed</h2> <ul> <li>Update changelo...
17e6f21c87f5d75b832b6f6fc0448603ae959b58
6155edc024d48d1446bb31a5858efe077d69a20d
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index 5e39ef3dd7..4e0e25f4a2 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout c...
[ ".github/workflows/entropy-beauty-scan.yml", ".github/workflows/gradle-wrapper-validation.yml", ".github/workflows/gradle_branch.yml", ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_preview_jdks.yml", ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml", ".gith...
[]
true
ReactiveX/RxJava
8,125
issue_to_patch
chore(deps): bump trufflesecurity/trufflehog from 3.95.3 to 3.95.5
Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.95.3 to 3.95.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/trufflesecurity/trufflehog/releases">trufflesecurity/trufflehog's releases</a>.</em></p> <blockquote> <h2>v3.95.5</h2> <h2>W...
17e6f21c87f5d75b832b6f6fc0448603ae959b58
12878a75228a76d71ca4259c5b28a9b3bee3feff
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index 5e39ef3dd7..42aae324ee 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -37,7 +37,7 @@ jobs: # No extra packages needed — compute-entropy.py uses o...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,126
issue_to_patch
chore(deps): bump biz.aQute.bnd.builder from 7.2.3 to 7.3.0
Bumps [biz.aQute.bnd.builder](https://github.com/bndtools/bnd) from 7.2.3 to 7.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bndtools/bnd/releases">biz.aQute.bnd.builder's releases</a>.</em></p> <blockquote> <h2>Bnd/Bndtools 7.3.0</h2> <p>See <a href="https://github.com...
17e6f21c87f5d75b832b6f6fc0448603ae959b58
b231cae462b52de3223af128ede7be85b3fd5b77
diff --git a/build.gradle b/build.gradle index 56fbe5e1b4..d21868841d 100644 --- a/build.gradle +++ b/build.gradle @@ -6,7 +6,7 @@ plugins { id("maven-publish") id("me.champeau.jmh") version "0.7.3" id("com.github.hierynomus.license") version "0.16.1" - id("biz.aQute.bnd.builder") version "7.2.3" + ...
[ "build.gradle" ]
[]
true
ReactiveX/RxJava
8,121
issue_to_patch
chore(deps): bump github/codeql-action from 4.35.5 to 4.36.0
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.5 to 4.36.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.36.0</h2> <ul> <li><em>Breaking change<...
fc0fca7e70ef997ce573b0a652a0fde7689422a1
f4f542a9c3adf971b0771df4983304bbfcfa31cc
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 2b08fdf7fe..cc033bcdee 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,120
issue_to_patch
test: simplify SingleRetryTest callables
Part of #8080. This updates `SingleRetryTest` as one small cleanup chunk by replacing old anonymous `Callable` and `Predicate` implementations with lambdas. The test behavior is unchanged, and the now-unused imports are removed. Tests run: - `JAVA_HOME=/tmp/rxjava-jdk26/Contents/Home ./gradlew --no-daemon test --test...
3bda03c26cc5dd6e136388d1dee76a593b4234ab
e6cef1305184acfad0ce493031addf0b174027e6
[ "src/test/java/io/reactivex/rxjava4/single/SingleRetryTest.java" ]
[]
diff --git a/src/test/java/io/reactivex/rxjava4/single/SingleRetryTest.java b/src/test/java/io/reactivex/rxjava4/single/SingleRetryTest.java index 1c86e6a3da..d682e7d1f7 100644 --- a/src/test/java/io/reactivex/rxjava4/single/SingleRetryTest.java +++ b/src/test/java/io/reactivex/rxjava4/single/SingleRetryTest.java @@ -1...
true
ReactiveX/RxJava
8,115
issue_to_patch
chore(deps): bump codecov/codecov-action from 6.0.0 to 6.0.1
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6.0.0 to 6.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v6.0.1</h2> <h2>What's Changed</h2> ...
d4240481d91b5de3046ea91063e9077eda5fb130
5ff3c4e3b6be22aba4200c7fd5dad30b60cf35cc
diff --git a/.github/workflows/gradle_branch.yml b/.github/workflows/gradle_branch.yml index cc87f6d457..72b0ba9d6e 100644 --- a/.github/workflows/gradle_branch.yml +++ b/.github/workflows/gradle_branch.yml @@ -34,7 +34,7 @@ jobs: - name: Build RxJava run: ./gradlew build --stacktrace - name: Upload to...
[ ".github/workflows/gradle_branch.yml", ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,114
issue_to_patch
chore(deps): bump github/codeql-action from 4.35.4 to 4.35.5
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.4 to 4.35.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.35.5</h2> <ul> <li>We have improved how...
822f243c3564a6e76e5829f964983d50c695e2ca
b582f759085c49131c466a757fc4ef18a9e9410e
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index b3fde7c08c..2b08fdf7fe 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,112
issue_to_patch
chore(deps): bump trufflesecurity/trufflehog from 3.95.2 to 3.95.3
Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.95.2 to 3.95.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/trufflesecurity/trufflehog/releases">trufflesecurity/trufflehog's releases</a>.</em></p> <blockquote> <h2>v3.95.3</h2> <h2>W...
dfee2ee8c62a74bfa89908e887a18eb9f9bb4d01
214d8f0f43b285df9361882cb7f734fe906e4f8c
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index cc976ef3a3..5e39ef3dd7 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -37,7 +37,7 @@ jobs: # No extra packages needed — compute-entropy.py uses o...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,113
issue_to_patch
chore(deps): bump gradle-wrapper from 9.5.0 to 9.5.1
Bumps [gradle-wrapper](https://github.com/gradle/gradle) from 9.5.0 to 9.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gradle/gradle/releases">gradle-wrapper's releases</a>.</em></p> <blockquote> <h2>9.5.1</h2> <p>The Gradle team is excited to announce Gradle 9.5.1.</p>...
dfee2ee8c62a74bfa89908e887a18eb9f9bb4d01
954d0630676034b4f04934d0cb9304af14ece4ff
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index b52fb7e713..df6a6ad763 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,6 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distribut...
[ "gradle/wrapper/gradle-wrapper.properties" ]
[]
true
ReactiveX/RxJava
8,111
issue_to_patch
chore(deps): bump github/codeql-action from 4.35.3 to 4.35.4
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.3 to 4.35.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.35.4</h2> <ul> <li>Update default CodeQ...
22f6ebaa7a4b5a4958e68ae1596b365c2224b888
6e744419e65dd28ebb385e389304e8c433df11b4
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index a59652a22b..b3fde7c08c 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,110
issue_to_patch
4.x: Add task coordination primitives, implement a basic concat() operator
Building blocks for more advanced coordination-heavy operators.
e30543c46ecb453bb686e94f80d8bda97f9e14a9
0f76972a8d44e5ba03c7b3e1e515fe6b82eda2d5
diff --git a/build.gradle b/build.gradle index 276a28e114..8bf8616439 100644 --- a/build.gradle +++ b/build.gradle @@ -47,10 +47,13 @@ dependencies { testImplementation "org.reactivestreams:reactive-streams-tck-flow:$reactiveStreamsVersion" testImplementation "org.junit.jupiter:junit-jupiter:$jupiterVersion...
[ "build.gradle", "src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java", "src/main/java/io/reactivex/rxjava4/core/Streamable.java", "src/main/java/io/reactivex/rxjava4/core/Streamer.java", "src/main/java/io/reactivex/rxjava4/disposables/CompositeDisposable.java", "src/main/java/io/reactiv...
[]
diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableTest.java index 126ee906f7..14b5d810e8 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableTest.java +++ b/sr...
true
ReactiveX/RxJava
8,109
issue_to_patch
chore(deps): bump github/codeql-action from 4.35.2 to 4.35.3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.2 to 4.35.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.35.3</h2> <ul> <li><em>Upcoming breakin...
5507fbc2915dbe69e94bb097e9712b26d6547aae
e8e6554d02fc3768f70fa019413d4e63cf6f35ea
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index fd75543f13..a59652a22b 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,106
issue_to_patch
chore(deps): bump gradle-wrapper from 9.4.1 to 9.5.0
Bumps [gradle-wrapper](https://github.com/gradle/gradle) from 9.4.1 to 9.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gradle/gradle/releases">gradle-wrapper's releases</a>.</em></p> <blockquote> <h2>9.5.0</h2> <p>The Gradle team is excited to announce Gradle 9.5.0.</p>...
3ee54e2e3443a8f7d6f51324e944cd7c192b4b92
e28b96623483493fcd44d876d9e591ec7cce30a1
diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index d997cfc60f..b1b8ef56b4 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index c6...
[ "gradle/wrapper/gradle-wrapper.jar", "gradle/wrapper/gradle-wrapper.properties", "gradlew", "gradlew.bat" ]
[]
true
ReactiveX/RxJava
8,105
issue_to_patch
chore(deps): bump trufflesecurity/trufflehog from 3.94.3 to 3.95.2
Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.94.3 to 3.95.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/trufflesecurity/trufflehog/releases">trufflesecurity/trufflehog's releases</a>.</em></p> <blockquote> <h2>v3.95.2</h2> <h2>W...
6efc2a12aed04cbae3a3a55d1e0483fcfdddbee1
8ebc753017f6265e470262cb00d447360b2f855f
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index faeb5f406c..cc976ef3a3 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -37,7 +37,7 @@ jobs: # No extra packages needed — compute-entropy.py uses o...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,104
issue_to_patch
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.1 to 4.35.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.35.2</h2> <ul> <li>The undocumented TRA...
de6cf50151ccdcb3d5b9fdaf5f8f54345be3b831
6eefe62ce9918f4220fa25538d38c29ecd904fa6
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 14e89502db..fd75543f13 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,101
issue_to_patch
chore(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 7.0.0 to 7.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v7.0.1</h2> <h2>What's Changed</...
16a2244748a62aa1ce4feffc0b6863ba44c6c5f2
9d40b701de0e6f754d75d5bdbb5fb1d9a421a410
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index f9b7227718..14e89502db 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -47,7 +47,7 @@ jobs: # Upload the results as artifacts (optional). Commenting out will disable uploads of run results i...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,103
issue_to_patch
chore(deps): bump com.google.guava:guava from 33.5.0-jre to 33.6.0-jre
Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.5.0-jre to 33.6.0-jre. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/guava/releases">com.google.guava:guava's releases</a>.</em></p> <blockquote> <h2>33.6.0</h2> <h3>Maven</h3> <pre lang="xml"><co...
ad3dc9146dc6492cf43c7a6604f749fa338ab96f
c95c97585b2d1f0eb44de43dfadeddf91a3f9dfb
diff --git a/build.gradle b/build.gradle index 276a28e114..bda04d745e 100644 --- a/build.gradle +++ b/build.gradle @@ -18,7 +18,7 @@ ext { testNgVersion = "7.12.0" mockitoVersion = "4.11.0" jmhLibVersion = "1.37" - guavaVersion = "33.5.0-jre" + guavaVersion = "33.6.0-jre" jupiterVersion = "6.0...
[ "build.gradle" ]
[]
true
ReactiveX/RxJava
8,102
issue_to_patch
chore(deps): bump actions/cache from 5.0.4 to 5.0.5
Bumps [actions/cache](https://github.com/actions/cache) from 5.0.4 to 5.0.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v5.0.5</h2> <h2>What's Changed</h2> <ul> <li>Update ts-http-runtime depe...
16a2244748a62aa1ce4feffc0b6863ba44c6c5f2
0feb93602390be01fec0f06e664c7c35a8eac980
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index a6c2036f22..faeb5f406c 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -19,7 +19,7 @@ jobs: fetch-depth: ${{ github.event_name == 'pull_request_ta...
[ ".github/workflows/entropy-beauty-scan.yml", ".github/workflows/gradle_branch.yml", ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_preview_jdks.yml", ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,096
issue_to_patch
chore(deps): bump SethCohen/github-releases-to-discord from 1.19.0 to 1.20.0
Bumps [SethCohen/github-releases-to-discord](https://github.com/sethcohen/github-releases-to-discord) from 1.19.0 to 1.20.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sethcohen/github-releases-to-discord/releases">SethCohen/github-releases-to-discord's releases</a>.</em>...
d9d985c353418649d7b74272a54406a36ac3030d
16229f485695088011c2c470c7282031688e0d70
diff --git a/.github/workflows/discord-release-announce.yml b/.github/workflows/discord-release-announce.yml index 5d76b2c481..b57a59e98a 100644 --- a/.github/workflows/discord-release-announce.yml +++ b/.github/workflows/discord-release-announce.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: ...
[ ".github/workflows/discord-release-announce.yml" ]
[]
true
ReactiveX/RxJava
8,098
issue_to_patch
chore(deps): bump trufflesecurity/trufflehog from 3.94.2 to 3.94.3
Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.94.2 to 3.94.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/trufflesecurity/trufflehog/releases">trufflesecurity/trufflehog's releases</a>.</em></p> <blockquote> <h2>v3.94.3</h2> <h2>W...
fb3d278ef76c26578efa646f877ead348a7d43f6
ddc1b998f40d92ad592b09ab1234b4fd3995431c
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index 2e4ff75e80..2ef608933e 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -37,7 +37,7 @@ jobs: # No extra packages needed — compute-entropy.py uses o...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,099
issue_to_patch
chore(deps): bump actions/github-script from 8 to 9
Bumps [actions/github-script](https://github.com/actions/github-script) from 8 to 9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/github-script/releases">actions/github-script's releases</a>.</em></p> <blockquote> <h2>v9.0.0</h2> <p><strong>New features:</strong></p...
fb3d278ef76c26578efa646f877ead348a7d43f6
907a08adaea28a4846c870c1532895a1b73e8565
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index 2e4ff75e80..c5423ea815 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -47,7 +47,7 @@ jobs: - name: Post summary comment (PR only) if: gith...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,095
issue_to_patch
chore(deps): bump gradle/actions from 6.0.1 to 6.1.0
Bumps [gradle/actions](https://github.com/gradle/actions) from 6.0.1 to 6.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gradle/actions/releases">gradle/actions's releases</a>.</em></p> <blockquote> <h2>v6.1.0</h2> <h2>New: Basic Cache Provider</h2> <p>A new MIT-licensed...
d9d985c353418649d7b74272a54406a36ac3030d
99e007207f2503ad15be2a378944bde0727ccec5
diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml index 54846a199a..b8a745626b 100644 --- a/.github/workflows/gradle-wrapper-validation.yml +++ b/.github/workflows/gradle-wrapper-validation.yml @@ -10,6 +10,6 @@ jobs: runs-on: ubuntu-latest steps: ...
[ ".github/workflows/gradle-wrapper-validation.yml" ]
[]
true
ReactiveX/RxJava
8,093
issue_to_patch
4.x: Detect un-awaited CompletionStageDisposables during tests
Adds a tracking mechanism to track `CompositeStageDisposable`s which are never `await()` 'd or `ignore()`'d or `close()`'d. Mainly test time verification. The trouble is that if they escape the executorservice scope, it can interrupt the unit test unexpectedly and result in failed tests due to operator bugs. T...
73241eb4cd6672e6e3a91e8c276c83159efca177
aedc4b3ffd762b325a90d54c4920fbcbc1ca0cf0
diff --git a/README.md b/README.md index 33c42ab63a..7f441940d1 100644 --- a/README.md +++ b/README.md @@ -19,12 +19,12 @@ It extends the [observer pattern](http://en.wikipedia.org/wiki/Observer_pattern) - :+1: `java.util.concurrent.Flow`-based implementation. - :+1: Virtual Thread support; `virtualCreate()`, `virtua...
[ "README.md", "src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java", "src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableBaseTest.java", "src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableTest.java" ]
[]
diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableBaseTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableBaseTest.java new file mode 100644 index 0000000000..042f18d396 --- /dev/null +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/str...
true
ReactiveX/RxJava
8,092
issue_to_patch
4.x: Enhance Streamable/Streamer and DisposableContainer APIs
- Establish an optional channel for per `next()` efficient cancellation for `Streamable`. - Enhance `DisposableContainer` for supporting better lifecycle management, recursively. - Enhance various types. - Add `test()` operator - Add `create` - Add `transform` - Add `toFlowable` & `toStreamable` - Fix many flaky...
377194b7b7b82408bc7ce2c82da40ec5de30321e
3ff3dd8dccb100fdba906cbfcf27ce223fa8c4ca
diff --git a/src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java b/src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java index 94413fec39..616d021e5a 100644 --- a/src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java +++ b/src/main/java/io/reactivex/rxjava4/core/Comp...
[ "src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java", "src/main/java/io/reactivex/rxjava4/core/Flowable.java", "src/main/java/io/reactivex/rxjava4/core/Scheduler.java", "src/main/java/io/reactivex/rxjava4/core/Streamable.java", "src/main/java/io/reactivex/rxjava4/core/Streamer.java", "...
[]
diff --git a/src/test/java/io/reactivex/rxjava4/completable/CompletableIsolatedTest.java b/src/test/java/io/reactivex/rxjava4/completable/CompletableIsolatedTest.java new file mode 100644 index 0000000000..9373ec659f --- /dev/null +++ b/src/test/java/io/reactivex/rxjava4/completable/CompletableIsolatedTest.java @@ -0,0...
true
ReactiveX/RxJava
8,091
issue_to_patch
chore(deps): bump trufflesecurity/trufflehog from 3.94.1 to 3.94.2
Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.94.1 to 3.94.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/trufflesecurity/trufflehog/releases">trufflesecurity/trufflehog's releases</a>.</em></p> <blockquote> <h2>v3.94.2</h2> <h2>W...
2e84b74aca706fa0f8beb89b75a4980bf286261e
e7d091c3e5fd4c2b32a93cc075287e3569952c7a
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index 782cb27871..2e4ff75e80 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -37,7 +37,7 @@ jobs: # No extra packages needed — compute-entropy.py uses o...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,088
issue_to_patch
chore(deps): bump github/codeql-action from 4.34.1 to 4.35.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.34.1 to 4.35.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v4.35.1</h2> <ul> <li>Fix incorrect minimu...
1d3d5292e018f0d09520adf4524ba7ef6578bb2f
2e86048f73c91b0bc4ccf4aa850fe9ff02b070fd
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 5bb61bdf5a..f9b7227718 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -55,6 +55,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scannin...
[ ".github/workflows/scorecard.yml" ]
[]
true
ReactiveX/RxJava
8,087
issue_to_patch
4.x: ObservableWindowWithSizeTest > windowUnsubscribeNonOverlappingAsyncSource failed Probably fixable with looser timings or via `@Isolated` JUnit 6 conversion. https://github.com/ReactiveX/RxJava/actions/runs/23631767713/job/68832611207#step:8:1277 ``` ObservableWindowWithSizeTest > windowUnsubscribeNonOverlapping...
Fix #8086: Isolate windowUnsubscribeNonOverlappingAsyncSource to JUnit 5
Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points: - [x] Please give a description about what and why you are contributing, even if it's trivial. **What & Why:** This PR addresses the flaky test issue reported in #8086. I extracted `win...
e54d3ee5fb5b8334ebf336c3f36e2577967795b8
0e25b30b5d78e7296131098ec7108d053dc329fc
[ "src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithSizeIsolatedTest.java", "src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithSizeTest.java" ]
[]
diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithSizeIsolatedTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableWindowWithSizeIsolatedTest.java new file mode 100644 index 0000000000..1d82a8cf5f --- /dev/null +++ b/src/test/java/io/reac...
true
ReactiveX/RxJava
8,085
issue_to_patch
chore(deps): bump codecov/codecov-action from 5.5.3 to 6.0.0
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.3 to 6.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <h2>⚠️ This version intr...
45d1b603109136e344e8cb7da95063655a0b1331
83fb0bf42b79987eb8529b8cc0389dafc915189d
diff --git a/.github/workflows/gradle_branch.yml b/.github/workflows/gradle_branch.yml index 5512915105..7695a9538f 100644 --- a/.github/workflows/gradle_branch.yml +++ b/.github/workflows/gradle_branch.yml @@ -34,7 +34,7 @@ jobs: - name: Build RxJava run: ./gradlew build --stacktrace - name: Upload to...
[ ".github/workflows/gradle_branch.yml", ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,077
issue_to_patch
4.x: Add optional build/test for future JDKs
We'll use RxJava 4 now on to respond to the Java Outreach Program.
7603054245a717a54517bb80bb25e0d5beefc982
ea55e55a942a4a79ccdb89577842214e44828a77
diff --git a/.github/workflows/gradle_preview_jdks.yml b/.github/workflows/gradle_preview_jdks.yml new file mode 100644 index 0000000000..b65727eecf --- /dev/null +++ b/.github/workflows/gradle_preview_jdks.yml @@ -0,0 +1,63 @@ +# This workflow will build a Java project with Gradle +# For more information see: https://...
[ ".github/workflows/gradle_preview_jdks.yml", "build.gradle" ]
[ { "comment": "10", "path": "build.gradle", "hunk": "@@ -256,18 +262,23 @@ tasks.withType(Test) {\n }\n }\n \n-jacocoTestReport {\n- dependsOn test\n- dependsOn testNG\n-\n- reports {\n- xml.required.set(true)\n- csv.required.set(false)\n- html.required.set(true)\n+if (e...
true
ReactiveX/RxJava
8,077
comment_to_fix
4.x: Add optional build/test for future JDKs
10
7603054245a717a54517bb80bb25e0d5beefc982
ea55e55a942a4a79ccdb89577842214e44828a77
diff --git a/build.gradle b/build.gradle index 13288c9b07..276a28e114 100644 --- a/build.gradle +++ b/build.gradle @@ -3,7 +3,6 @@ plugins { id("java-library") id("checkstyle") id("eclipse") - id("jacoco") id("maven-publish") id("me.champeau.jmh") version "0.7.3" id("com.github.hierynom...
[ "build.gradle" ]
[ { "comment": "10", "path": "build.gradle", "hunk": "@@ -256,18 +262,23 @@ tasks.withType(Test) {\n }\n }\n \n-jacocoTestReport {\n- dependsOn test\n- dependsOn testNG\n-\n- reports {\n- xml.required.set(true)\n- csv.required.set(false)\n- html.required.set(true)\n+if (e...
true
ReactiveX/RxJava
8,078
issue_to_patch
4.x: Isolate FlowableMergeTest.synchronizationOfMultipleSequencesLoop
Isolate test to reduce failure likelihood: https://github.com/ReactiveX/RxJava/actions/runs/23565074631/job/68614485800
e81cfafda1c709ce41fb6c8a1e0a4363378b4c22
4eed3de9907dcd3c9aaa21ae341b5490b8c65606
[ "src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java" ]
[]
diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java index f977662af6..4949d05c30 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableMergeTest.java +++ b...
true
ReactiveX/RxJava
8,074
issue_to_patch
4.x: Upgrade to Java 26 baseline compilation, test isolation
I installed Oracle JDK 26 locally for now. Also hopefully fixes a failing test via `@Isolated` running: `CompletableTest.repeatNormal`.
7b0fddfbff2ac6f18a1b5105f86a715792084ff3
db92e7e9910296d7bacb8b7b138cb46937ee839f
diff --git a/.github/workflows/gradle_branch.yml b/.github/workflows/gradle_branch.yml index ac96decfb1..aa6931db6d 100644 --- a/.github/workflows/gradle_branch.yml +++ b/.github/workflows/gradle_branch.yml @@ -16,11 +16,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@de0fac2e4500dabe0...
[ ".github/workflows/gradle_branch.yml", ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml", "README.md", "build.gradle", "src/test/java/io/reactivex/rxjava4/completable/CompletableTest.java" ]
[]
diff --git a/src/test/java/io/reactivex/rxjava4/completable/CompletableTest.java b/src/test/java/io/reactivex/rxjava4/completable/CompletableTest.java index 8479d9e5ab..bcc49b3f04 100644 --- a/src/test/java/io/reactivex/rxjava4/completable/CompletableTest.java +++ b/src/test/java/io/reactivex/rxjava4/completable/Comple...
true
ReactiveX/RxJava
8,069
issue_to_patch
chore(deps): bump captradeoff/x-post-action from d643d2bb835a1c915a056b2241cbda3c444d016d to 3538d7eeb4e7d50013ed06127f352967967da8c9
Bumps [captradeoff/x-post-action](https://github.com/captradeoff/x-post-action) from d643d2bb835a1c915a056b2241cbda3c444d016d to 3538d7eeb4e7d50013ed06127f352967967da8c9. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/captradeoff/x-post-action/compare/d643d2bb835a1c915a056b22...
3d26a70ad7d4db05419a9242b64942a442f998dc
0c11d1c0bd7dfaac1fe0f9fe2e19ec3e44609331
diff --git a/.github/workflows/release-notify-x.yml b/.github/workflows/release-notify-x.yml index df25d80c5d..1fcba3cbb6 100644 --- a/.github/workflows/release-notify-x.yml +++ b/.github/workflows/release-notify-x.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Post to @RxJava - ...
[ ".github/workflows/release-notify-x.yml" ]
[]
true
ReactiveX/RxJava
8,070
issue_to_patch
chore(deps): bump SethCohen/github-releases-to-discord from 1b3dde6c63d699e660bf6e1b5605217b84d700fe to b96a33520f8ad5e6dcdecee6f1212bdf88b16550
Bumps [SethCohen/github-releases-to-discord](https://github.com/sethcohen/github-releases-to-discord) from 1b3dde6c63d699e660bf6e1b5605217b84d700fe to b96a33520f8ad5e6dcdecee6f1212bdf88b16550. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/SethCohen/github-releases-to-discord/blo...
3d26a70ad7d4db05419a9242b64942a442f998dc
c2b2f66fa9dfe87fae54e9cd41165542ed1939d3
diff --git a/.github/workflows/discord-release-announce.yml b/.github/workflows/discord-release-announce.yml index 7ac1bb592e..5d76b2c481 100644 --- a/.github/workflows/discord-release-announce.yml +++ b/.github/workflows/discord-release-announce.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: ...
[ ".github/workflows/discord-release-announce.yml" ]
[]
true
ReactiveX/RxJava
8,068
issue_to_patch
chore(deps): bump gradle/actions from 205054a7257716ec64af10a2e2ff1ac5d3b132db to 39e147cb9de83bb9910b8ef8bd7fff0ee20fcd6f
Bumps [gradle/actions](https://github.com/gradle/actions) from 205054a7257716ec64af10a2e2ff1ac5d3b132db to 39e147cb9de83bb9910b8ef8bd7fff0ee20fcd6f. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/gradle/actions/compare/205054a7257716ec64af10a2e2ff1ac5d3b132db...39e147cb9de83b...
8800ece59d8bf4af8fbb90639250b103a36c9ad1
a6efcfd9e39325d60e5be7bad2a80dc6b04d7aa6
diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml index 58dc8a8ee9..54846a199a 100644 --- a/.github/workflows/gradle-wrapper-validation.yml +++ b/.github/workflows/gradle-wrapper-validation.yml @@ -10,6 +10,6 @@ jobs: runs-on: ubuntu-latest steps: ...
[ ".github/workflows/gradle-wrapper-validation.yml" ]
[]
true
ReactiveX/RxJava
8,071
issue_to_patch
chore(deps): bump actions/cache from 4.2.4 to 5.0.4
Bumps [actions/cache](https://github.com/actions/cache) from 4.2.4 to 5.0.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v5.0.4</h2> <h2>What's Changed</h2> <ul> <li>Add release instructions an...
8800ece59d8bf4af8fbb90639250b103a36c9ad1
b9ef7b5d71ec17e90395b3d37aa313ed504f5c75
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index afea3f607e..a68fd53d62 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -19,7 +19,7 @@ jobs: fetch-depth: ${{ github.event_name == 'pull_request_ta...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,072
issue_to_patch
chore(deps): bump actions/setup-python from 5.6.0 to 6.2.0
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p> <blockquote> <h2>v6.2.0</h2> <h2>What's Changed</h2> <h3>Depe...
8800ece59d8bf4af8fbb90639250b103a36c9ad1
25cb04a1fdbe25f09b639a834aeb341019763e42
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index afea3f607e..ca436edfea 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -27,7 +27,7 @@ jobs: ${{ runner.os }}-pip-entropy- - name: Setup...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,073
issue_to_patch
chore(deps): bump biz.aQute.bnd.builder from 7.2.1 to 7.2.3
Bumps [biz.aQute.bnd.builder](https://github.com/bndtools/bnd) from 7.2.1 to 7.2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bndtools/bnd/releases">biz.aQute.bnd.builder's releases</a>.</em></p> <blockquote> <h2>Bnd/Bndtools 7.2.3</h2> <p>This release fixes a mistake of...
48bfc082c46ad09d93c9625f36e6deae20b80100
4b5c2e2d2468a69f792bba8f4db57d6c0839977c
diff --git a/build.gradle b/build.gradle index fbfc0e6709..d137545f3b 100644 --- a/build.gradle +++ b/build.gradle @@ -7,7 +7,7 @@ plugins { id("maven-publish") id("me.champeau.jmh") version "0.7.3" id("com.github.hierynomus.license") version "0.16.1" - id("biz.aQute.bnd.builder") version "7.2.1" + ...
[ "build.gradle" ]
[]
true
ReactiveX/RxJava
8,067
issue_to_patch
TCK can't run in parallel because of a Java common pool bug/feature When I enable parallel testing in the TCK testng runnable, random TCK tests fail with subscribe timeout mostly. My guess is that the TCK's use of the `ForkJoinPool.commonPool()` sometimes deadlocks itself because it wants to run on the same thread as...
4.x: Try to fix parallel testng failures
Sometimes they fail locally with a timeout on subscribe() which I don't understand as we don't delay subscribe, especially not for 50ms. Resolves #8036
4151bfa234bf6b5667eb22ee873e75966247d7a8
3bade61714a5cf51a76ba892d3fb9fceed193476
diff --git a/build.gradle b/build.gradle index b0fc0a7348..fbfc0e6709 100644 --- a/build.gradle +++ b/build.gradle @@ -192,7 +192,16 @@ tasks.register('testNG', Test) { // Tell it to use TestNG explicitly useTestNG() - maxParallelForks = 1 + maxHeapSize = "1200m" + maxParallelForks = Runtime.runtim...
[ "build.gradle" ]
[]
true
ReactiveX/RxJava
8,066
issue_to_patch
4.x: Report back test failures in a readable manner for PRs/Snaps
I don't want to dig through GitHub Action logs anymore.
61326567ac61879b1b422fbf313222a92c7077ce
c50c33f49329900bb4b03c820f68c93aba0e7ec6
diff --git a/.github/workflows/gradle_pr.yml b/.github/workflows/gradle_pr.yml index cd13099f6e..4ae241fd3e 100644 --- a/.github/workflows/gradle_pr.yml +++ b/.github/workflows/gradle_pr.yml @@ -33,6 +33,20 @@ jobs: run: ./gradlew test --tests "io.reactivex.rxjava4.validators.*" --stacktrace --no-daemon - n...
[ ".github/workflows/gradle_pr.yml", ".github/workflows/gradle_snapshot.yml", "build.gradle" ]
[]
true
ReactiveX/RxJava
8,064
issue_to_patch
Cache things with entropy-beauty-scan.yml
Everything is soo slow without caching.
0892c6f4481cf6415a8ad50e58ba71b6f41efce1
b3632e6f3609cf5aff0903b09211b02f3971a0ab
diff --git a/.github/workflows/entropy-beauty-scan.yml b/.github/workflows/entropy-beauty-scan.yml index 619d1921ca..afea3f607e 100644 --- a/.github/workflows/entropy-beauty-scan.yml +++ b/.github/workflows/entropy-beauty-scan.yml @@ -14,7 +14,27 @@ jobs: - name: Checkout code (full history) uses: actio...
[ ".github/workflows/entropy-beauty-scan.yml" ]
[]
true
ReactiveX/RxJava
8,062
issue_to_patch
gradle_snapshot.yml run build -> prerelease sequentially
Fix the default behavior running build and *release in parallel.
0892c6f4481cf6415a8ad50e58ba71b6f41efce1
99ebc7a00038a71c8ae08113592aae4164749828
diff --git a/.github/workflows/gradle_release.yml b/.github/workflows/gradle_release.yml index 922c40def3..1a3c11d698 100644 --- a/.github/workflows/gradle_release.yml +++ b/.github/workflows/gradle_release.yml @@ -15,7 +15,6 @@ permissions: jobs: build: - runs-on: ubuntu-latest env: CI_BUILD_NUM...
[ ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,059
issue_to_patch
Fix gradle_snapshot.yml - need to checkout/gradle at push too
Because it is never *that* easy.
d15f4a3d7d931b4a7eafa9f78dfa623582199256
ace64eb1b4216865f2918ac8754e3695e56f7910
diff --git a/.github/workflows/gradle_release.yml b/.github/workflows/gradle_release.yml index 7151781e63..922c40def3 100644 --- a/.github/workflows/gradle_release.yml +++ b/.github/workflows/gradle_release.yml @@ -21,7 +21,7 @@ jobs: CI_BUILD_NUMBER: ${{ github.run_number }} steps: - uses: actions/che...
[ ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,056
issue_to_patch
Update gradle_release.yml, limit write capabilities of tools
Improving our scorecard
00f87845cd9f682c6e575e1fa51a66f49ee84e04
f77d0929be9e31298a0fdbf021dc886ea17bfa70
diff --git a/.github/workflows/gradle_release.yml b/.github/workflows/gradle_release.yml index a1988de1a4..7151781e63 100644 --- a/.github/workflows/gradle_release.yml +++ b/.github/workflows/gradle_release.yml @@ -17,8 +17,6 @@ jobs: build: runs-on: ubuntu-latest - permissions: - contents: write ...
[ ".github/workflows/gradle_release.yml", ".github/workflows/gradle_snapshot.yml" ]
[]
true
ReactiveX/RxJava
8,055
issue_to_patch
Harden RxJava CI toolchain
Replaces all the @v111 with proper hash-pinned-versions.
de9fd552472006637c62c7e70f8eaa7faf59bb5c
1b72f8df7318e6c2cf9f2e871af652e1a1deff33
diff --git a/.github/workflows/discord-release-announce.yml b/.github/workflows/discord-release-announce.yml index 1c4bc19867..7ac1bb592e 100644 --- a/.github/workflows/discord-release-announce.yml +++ b/.github/workflows/discord-release-announce.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: ...
[ ".github/workflows/discord-release-announce.yml", ".github/workflows/entropy-beauty-scan.yml", ".github/workflows/gradle-wrapper-validation.yml", ".github/workflows/release-notify-x.yml" ]
[]
true
RicoSuter/NSwag
5,283
issue_to_patch
BUG: "[object Object]" is not valid JSON - the processor try to run json.parse on axios response data object On version v14.1.0. When choose generate typescript(v4.3) DTO interfaces with axios. The response processor will throw exception. I'm using the debugger, found that the generated client try to use JSON.parse on...
fix axios template: [object Object] is not valid JSON.
Fixes #4973 Added condition to check if template is `Framework.IsAxios` then return data without parse, cause axios convert json string to data object by default.
b595e3bc1176d6ec7667fa178e664926ef211106
ef4b0fd32d6c6a518a31c87af4c536c660af3844
diff --git a/src/NSwag.CodeGeneration.TypeScript/Templates/Client.ProcessResponse.HandleStatusCode.liquid b/src/NSwag.CodeGeneration.TypeScript/Templates/Client.ProcessResponse.HandleStatusCode.liquid index 58e545ed6..f241e324a 100644 --- a/src/NSwag.CodeGeneration.TypeScript/Templates/Client.ProcessResponse.HandleStat...
[ "src/NSwag.CodeGeneration.TypeScript/Templates/Client.ProcessResponse.HandleStatusCode.liquid" ]
[]
true
RicoSuter/NSwag
5,370
issue_to_patch
Set up v15 integration branch
## Summary Starter PR for the NSwag v15 major release. Establishes plan + changelog docs and makes CI actually run against `v15`, including the temporary sibling NJsonSchema v12 checkout needed while `UseLocalNJsonSchemaProjects=true` is the default. - **`docs/plan_v15.md`** — v15 scope (STJ migration #5355, absorbin...
2389c0721d069fa8ea07e35b925b66121e577c81
e11f184c192e3e7370dd8241d2471610b58ec28d
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0242d0da7..7b79990f5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,6 +21,7 @@ on: branches: - master - main + - v15 tags: - 'v*.*.*' paths: @@ -45,6 +46,11 @@ jobs: ...
[ ".github/workflows/build.yml", ".github/workflows/pr.yml", "CLAUDE.md", "Directory.Build.props", "build/Build.CI.GitHubActions.cs", "docs/changelog_v15.md", "docs/plan_v15.md", "src/NSwag.AspNet.WebApi/NSwag.AspNet.WebApi.csproj", "src/NSwag.CodeGeneration.CSharp/NSwag.CodeGeneration.CSharp.csproj",...
[]
true
RicoSuter/NSwag
5,367
issue_to_patch
Missing NSwagDir_Net100 entry I noticed that [NSwag.MSBuild.props](https://github.com/RicoSuter/NSwag/blob/master/src/NSwag.MSBuild/NSwag.MSBuild.props) defines the following properties: ```xml <NSwagDir_Net80>$(MSBuildThisFileDirectory)../tools/Net80/</NSwagDir_Net80> <NSwagDir_Net90>$(MSBuildThisFileDirectory)../too...
Upgrade to NJsonSchema v11.6.1 (NSwag v14.7.1)
Upgrades NJsonSchema to [v11.6.1](https://github.com/RicoSuter/NJsonSchema/releases/tag/v11.6.1), which corrects the regression introduced in v11.6.0 around the C# `required` keyword and `[JsonRequired]` handling. ## What this fixes downstream Closes [#5359](https://github.com/RicoSuter/NSwag/issues/5359): `requi...
b108f11e8cc258971edf06a5292cf6197e649c19
caf0d059cf2f6eb5d474ee6f7624b657076fbadd
diff --git a/Directory.Build.props b/Directory.Build.props index f54f3367d..8adba07b7 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,9 +1,9 @@ <Project> <PropertyGroup> - <VersionPrefix>14.7.0</VersionPrefix> + <VersionPrefix>14.7.1</VersionPrefix> <Authors>Rico Suter</Authors> - ...
[ "Directory.Build.props", "Directory.Packages.props", "build/_build.csproj", "src/NSwag.ApiDescription.Client/NSwag.ApiDescription.Client.targets", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/UseRequiredKeywordNewtonsoftJsonSchemaGeneratorTests.When_setting_is_disabled_properties_with_required_attribute...
[]
true
RicoSuter/NSwag
5,357
issue_to_patch
Update to NJsonSchema v11.6.0 and Namotion.Reflection v3.5.0 (v14.7.0)
- Use latest NJsonSchema v11.6.0, https://github.com/RicoSuter/NJsonSchema/releases/tag/v11.6.0 - Use latest Namotion.Reflection v3.5.0, https://github.com/RicoSuter/Namotion.Reflection/commits/master/ - Prepare v14.7.0 release
eac9c1fbb05448c64c45b7dffb65128338744642
f85e085e25e85f84dc605347f7edc4d3f00aee50
diff --git a/Directory.Build.props b/Directory.Build.props index 4c9436cab..f54f3367d 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,6 +1,6 @@ <Project> <PropertyGroup> - <VersionPrefix>14.6.3</VersionPrefix> + <VersionPrefix>14.7.0</VersionPrefix> <Authors>Rico Suter</Authors> ...
[ "Directory.Build.props", "Directory.Packages.props", "src/NSwag.CodeGeneration.CSharp.Tests/Controllers/Snapshots/ControllerGenerationBasePathTests.When_custom_BasePath_is_not_specified_then_the_BasePath_from_document_is_used_as_Route.verified.txt", "src/NSwag.CodeGeneration.CSharp.Tests/Controllers/Snapshots...
[]
true
RicoSuter/NSwag
5,348
issue_to_patch
Underscores - the source of all evil when used, but should work out of the box. We have a customer openapi.json which we query at runtime to generate our bindings. In our case we are getting duplicate classes, due to the standard implementation using the underscore as separator, and only giving back the last chunk, w...
Fix duplicate client/operation names when operation IDs contain multiple underscores
`MultipleClientsFromOperationIdOperationNameGenerator` used the **second-to-last** underscore segment as client name and **last** segment as operation name. Any two operation IDs sharing the same suffix (e.g. `Orders_items_get` and `Products_items_get`) mapped to the same `(client="items", operation="get")` pair, produ...
c93797fd3adbca819db486aed91e7509a1db3b94
ed944bc1876bccb86ec504346419d4691581c685
diff --git a/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs b/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs index e01227b81..b1f682aab 100644 --- a/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs +++ b/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs @@ -84,8 +84,8 @@ public void When_using_Mu...
[ "src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs", "src/NSwag.CodeGeneration/OperationNameGenerators/MultipleClientsFromOperationIdOperationNameGenerator.cs" ]
[]
true
RicoSuter/NSwag
5,345
issue_to_patch
Compile error if double quotes in media type **Describe the bug** Using the C# client generator on an OpenAPI document that contains a media type whose value has double quotes fails to compile. The [JSON:API specification](https://jsonapi.org/format/) requires extensions and profiles to be surrounded by double quote...
Fix compile error in generated C# client when media type contains quotes
Fixes #5344.
c5fcfd455f78e8b7342454f2123f18f3e256b453
655ac3990e3168d5ef75047605f2a6b3dd0ebc40
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs b/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs index 57f1c24cf..926a00521 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs +++ b/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs @@ -354,6 +354,...
[ "src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/ControllerGenerationFormatTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/CodeGenerationTests.When_media_type_contains_quotes_can_generate_client.verified.txt", "src/NSwag.CodeGeneration/Models/O...
[]
true
RicoSuter/NSwag
5,315
issue_to_patch
nswag config overwritten by aspNetCoreToSwagger for project I use this config for C# client generation for Asp.NET Core Web API ```json { "runtime": "default", "defaultVariables": "Configuration=Debug", "swaggerGenerator": { "AspNetCoreToSwagger": { "project": "../Server/Server.csproj", ...
Fix legacy document transformation
Remove the unused requireParametersWithoutDefault property from TransformLegacyDocument, fixes #5303. Remove code that overwrites documents when legacy transformations are necessary, fixes #1886.
75d8a4a4bf245710a6123ed65f3a7ebfd8adacac
971f973415854ae787dc5bd092830b0447f2a678
diff --git a/src/NSwag.Commands/NSwagDocumentBase.cs b/src/NSwag.Commands/NSwagDocumentBase.cs index 613e24710..7606f6401 100644 --- a/src/NSwag.Commands/NSwagDocumentBase.cs +++ b/src/NSwag.Commands/NSwagDocumentBase.cs @@ -167,14 +167,7 @@ protected static async Task<TDocument> LoadAsync<TDocument>( wher...
[ "src/NSwag.Commands/NSwagDocumentBase.cs" ]
[]
true
RicoSuter/NSwag
5,337
issue_to_patch
fix: nullpointer
I'm trying to add endpoint definitions manually via `IApiDescriptionProvider` but as soon as I add `ApiDescription.SupportedResponseTypes` the swagger generator crashes due to a simple nullpointer. The compiler and IDE even warns about this issue but it is ignored and this exception is expected to happen when `Metho...
2a5ca6e199035833984aa270f059a93e3f513bfe
5f1cdd3a6587cfb9080db4b5171926c165c797b2
diff --git a/src/NSwag.Generation.AspNetCore/Processors/OperationResponseProcessor.cs b/src/NSwag.Generation.AspNetCore/Processors/OperationResponseProcessor.cs index d2e757388..61c9e5fba 100644 --- a/src/NSwag.Generation.AspNetCore/Processors/OperationResponseProcessor.cs +++ b/src/NSwag.Generation.AspNetCore/Processo...
[ "src/NSwag.Generation.AspNetCore/Processors/OperationResponseProcessor.cs" ]
[]
true
RicoSuter/NSwag
5,271
issue_to_patch
Add .NET 10 support
Ref #5216
6db16d724bc8bac77d18437f5755923eb25b7030
6013659be7558652333d6fd8cb447e0bd69d9be9
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 78a245a6db..957b359b33 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,6 +40,10 @@ jobs: run: | echo "Adding GNU tar to PATH" echo C:\Program Files\Git\usr\bin>>"%GITHUB_PATH%" +...
[ ".github/workflows/build.yml", ".github/workflows/pr.yml", "Directory.Packages.props", "build/Build.CI.GitHubActions.cs", "build/Build.cs", "global.json", "src/NSwag.AspNetCore/NSwag.AspNetCore.csproj", "src/NSwag.Commands/HostApplication.cs", "src/NSwag.Commands/NSwag.Commands.csproj", "src/NSwag...
[]
true
RicoSuter/NSwag
4,143
issue_to_patch
add new MultipleClientsFromFirstTagAndOperationNameGenerator
Added a new OperationNameGenerator which takes first tag for clientName and the operationName (underscore separated from the operationId). Inherits from the already existing MultipleClientsFromOperationIdOperationNameGenerator. This allows to have several small controllers that are tagged the same, to be generated i...
cfaaec0bae7d0a83b2d7cb093dc96b57c5ebd499
fd4c6d5b35cdf1c0f510df2674ef1ac119c72512
diff --git a/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs b/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs index 190ef8bbca..8d406a86d1 100644 --- a/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs +++ b/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs @@ -1,5 +1,7 @@ using System; +using S...
[ "src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs", "src/NSwag.CodeGeneration/OperationNameGenerators/MultipleClientsFromFirstTagAndOperationNameGenerator.cs", "src/NSwag.Commands/Commands/CodeGeneration/OperationGenerationMode.cs", "src/NSwag.Commands/OperationGenerationModeConverter.cs" ]
[]
true
RicoSuter/NSwag
5,320
issue_to_patch
Fix specifying runtime for `NSwag.Npm` resulting in a `NConsole.UnusedArgumentException`
Running the following command results in the following exception: `nswag openapi2tsclient /runtime:Net100 /input:../openapi.json /template:angular /InjectionTokenType:InjectionToken /HttpClass:HttpClient /RxJsVersion:6.0 /operationGenerationMode:MultipleClientsFromFirstTagAndOperationId /output:src/service.ts` ``...
75d8a4a4bf245710a6123ed65f3a7ebfd8adacac
3fa50291292abffc2a53572481b2d779337ab306
diff --git a/src/NSwag.Npm/bin/nswag.js b/src/NSwag.Npm/bin/nswag.js index a9bb36cad..573d8895d 100644 --- a/src/NSwag.Npm/bin/nswag.js +++ b/src/NSwag.Npm/bin/nswag.js @@ -75,6 +75,9 @@ if (runtimeIndices.length > 1) { console.error("Error: Multiple /runtime:* arguments detected. Please specify only one. Maybe re...
[ "src/NSwag.Npm/bin/nswag.js" ]
[]
true
RicoSuter/NSwag
5,314
issue_to_patch
Upgrade to NUKE 10.1.0
52fc6cd7ace47eb646cf21c3c93b12fb815f4835
2d07fe7e97505bc6714007cfd6240b903bdb3804
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 03a69883f..0242d0da7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,7 +44,7 @@ jobs: with: dotnet-version: | 10.0 - - uses: actions/checkout@v4 + - uses: actions/che...
[ ".github/workflows/build.yml", ".github/workflows/pr.yml", "build/_build.csproj" ]
[]
true
RicoSuter/NSwag
5,310
issue_to_patch
Upgrade to NUKE 10
b595e3bc1176d6ec7667fa178e664926ef211106
ea6d54d774e85462e9eb40800720c73faecd0958
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 957b359b3..03a69883f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,7 +40,7 @@ jobs: run: | echo "Adding GNU tar to PATH" echo C:\Program Files\Git\usr\bin>>"%GITHUB_PATH%" - ...
[ ".github/workflows/build.yml", ".github/workflows/pr.yml", "build/Build.CI.GitHubActions.cs", "build/_build.csproj", "global.json" ]
[]
true
RicoSuter/NSwag
5,307
issue_to_patch
Minor .NET 10 fixes (v14.6.3)
- Fix "field" keyword conflict - Use .NET 10 final packages / SDK
2d3437d7bbab0f923aa9f5291b0dfdcde1700904
3d45ca608c384e19813760b63781846ee3f8b8d1
diff --git a/Directory.Packages.props b/Directory.Packages.props index 79596c9e6..bd91ee6bd 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -49,7 +49,7 @@ <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="9.0.10" /> </ItemGroup> <ItemGroup Condition="'$(TargetFramework)...
[ "Directory.Packages.props", "global.json", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/AllowNullableBodyParametersTests.TestNoGuardForOptionalBodyParameter.verified.txt", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/AllowNullableBodyParametersTests.TestNullableBodyWithAllowNullableBodyParameters.veri...
[]
true
RicoSuter/NSwag
5,302
issue_to_patch
fix: nswag.js try detect the runtime version from config file
Often we have issues where the nswag.json file will specify the "runtime" to something other than "net80". In my case "net90" and now going forward "net100". With NSwag installed with NPM, either as a global package or as a devDependencies in package.json. In my case "nswag" is listed as a devDependency in package....
e4e30bfe7c9dd92148dc275b9f4ab1415efdf103
8f745db253bc371669873e1567fd32ab1caee8f8
diff --git a/src/NSwag.Npm/bin/nswag.js b/src/NSwag.Npm/bin/nswag.js index b1e609265..a9bb36cad 100644 --- a/src/NSwag.Npm/bin/nswag.js +++ b/src/NSwag.Npm/bin/nswag.js @@ -10,11 +10,47 @@ var supportedCoreVersions = [ const path = require('path'); var c = require('child_process'); +var fs = require('fs'); // In...
[ "src/NSwag.Npm/bin/nswag.js" ]
[]
true
RicoSuter/NSwag
5,299
issue_to_patch
Updated packages for CVE-2025-55315
See https://github.com/dotnet/announcements/issues/371 for more information I believe this will handle the security vulnerability being reported transitively for this package; however, if the reported vulnerability is not resolved, I could see us also needing to potentially add a direct reference to https://www.nuge...
e4e30bfe7c9dd92148dc275b9f4ab1415efdf103
9cbedf54d0e2e8be63b654726e9e163acf96064f
diff --git a/Directory.Build.props b/Directory.Build.props index 8c91ad85d..4c9436cab 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,6 +1,6 @@ <Project> <PropertyGroup> - <VersionPrefix>14.6.2</VersionPrefix> + <VersionPrefix>14.6.3</VersionPrefix> <Authors>Rico Suter</Authors> ...
[ "Directory.Build.props", "Directory.Packages.props", "src/NSwag.Npm/package-lock.json", "src/NSwag.Npm/package.json" ]
[]
true
RicoSuter/NSwag
5,245
issue_to_patch
Not reading CLI variables (v14.5.0) **Describe the bug** Nswag run command line not reading variables correctly anymore with version 14.5 **To Reproduce** nswag run /runtime:Net80 /variables:Configuration=Release now producing this error: NConsole.UnusedArgumentException: Unrecognised arguments are present: [] ...
Fix NPM CLI argument handling
NConsole seems to have a bug which makes it a requirement that there needs to be one unused argument. This restores the old behavior and runtime parameter is passed to actual NET CLI. fixes #5238
231b0b729cb06d4df63632c68aabeb5a53ce4930
d86f91e53e6a6f6544b2c2aeab55eee6ccbdbffd
diff --git a/src/NSwag.Npm/bin/nswag.js b/src/NSwag.Npm/bin/nswag.js index a83e85b78..7c0e8879e 100644 --- a/src/NSwag.Npm/bin/nswag.js +++ b/src/NSwag.Npm/bin/nswag.js @@ -36,8 +36,6 @@ args.forEach((arg, idx) => { if (runtimeIndices.length > 1) { console.error("Error: Multiple /runtime:* arguments detected. Ple...
[ "src/NSwag.Npm/bin/nswag.js" ]
[]
true
RicoSuter/NSwag
5,298
issue_to_patch
v14.6.2: Update NJS and update commands/UI & update .NET 10 SDK (RC2)
<img width="1669" height="799" alt="image" src="https://github.com/user-attachments/assets/10527443-2956-4d10-a3e9-ae5eaca6bd0c" />
3bf55b162311566c87f51d282105867d057777de
c9adbdc0dbdbbbacd925106218a2285fc39d1653
diff --git a/Directory.Build.props b/Directory.Build.props index 02895cf7d..8c91ad85d 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,6 +1,6 @@ <Project> <PropertyGroup> - <VersionPrefix>14.6.1</VersionPrefix> + <VersionPrefix>14.6.2</VersionPrefix> <Authors>Rico Suter</Authors> ...
[ "Directory.Build.props", "Directory.Packages.props", "global.json", "src/NSwag.Commands/Commands/CodeGeneration/JsonSchemaToCSharpCommand.cs", "src/NSwag.Commands/Commands/CodeGeneration/OpenApiToCSharpClientCommand.cs", "src/NSwag.Commands/Commands/CodeGeneration/OpenApiToCSharpCommandBase.cs", "src/NS...
[]
true
RicoSuter/NSwag
5,278
issue_to_patch
Undocumented breaking change for IWebHostBuilder in HostApplication.cs This [commit](https://github.com/RicoSuter/NSwag/commit/203378137f4081a2ce01f6a8f810af8171ff41c5#diff-049a21224f297481c1555c43c345e888a444c10eb1d5b731c3cc710c9871c024) has introduced a breaking change. The type changed from `IWebHostBuilder` to `I...
fix: Support web host (legacy) in ServiceProviderResolver
Closes #5277
98acdf82bddda6c5ecaca272e8a00f6ed5f3404e
257b8175eb1e804b26aae1e1f25f03d170f18d66
diff --git a/src/NSwag.Commands/HostApplication.cs b/src/NSwag.Commands/HostApplication.cs index 1a62e566d..9a74594d5 100644 --- a/src/NSwag.Commands/HostApplication.cs +++ b/src/NSwag.Commands/HostApplication.cs @@ -1,4 +1,5 @@ #pragma warning disable IDE0005 +#pragma warning disable ASPDEPR008 using System.Refle...
[ "src/NSwag.Commands/HostApplication.cs" ]
[]
true
RicoSuter/NSwag
5,279
issue_to_patch
Update NJsonSchema to v11.5.1
98acdf82bddda6c5ecaca272e8a00f6ed5f3404e
a17da81fb1b246461596bdf18407fe249281d666
diff --git a/Directory.Packages.props b/Directory.Packages.props index 81be289d8..885163b19 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -23,12 +23,12 @@ <PackageVersion Include="MyToolkit.Extended" Version="2.5.16" /> <PackageVersion Include="Namotion.Reflection" Version="3.4.3" />...
[ "Directory.Packages.props" ]
[]
true
RicoSuter/NSwag
5,255
issue_to_patch
openApiToCSharpController: incorrect return type for files when useActionResultType=true **Describe the bug** When generating a controller stub that returns a file, and the generator is configured with `useActionResultType: true`, the return type should be `Task<FileResult>`, but instead we get a `Task<Actionresult<F...
Fix binary operation result type generation for AspNetCore CSharp
Fix generation ActionResult<FileResult> insead of IActionResult fixes #5247
9998913062e12ace779ad5ce0ad5fa5cbf2c1153
ada7af0bd33441020e5717cc891f38f362a85bc8
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/BinaryTests.cs b/src/NSwag.CodeGeneration.CSharp.Tests/BinaryTests.cs index fcb5b8b53..16e3e4860 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/BinaryTests.cs +++ b/src/NSwag.CodeGeneration.CSharp.Tests/BinaryTests.cs @@ -500,5 +500,51 @@ public async Task When_mul...
[ "src/NSwag.CodeGeneration.CSharp.Tests/BinaryTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/BinaryTests.When_response_body_is_binary_then_IActionResult_is_used_as_return_type_in_CSharp_ASPNETCore.verified.txt", "src/NSwag.CodeGeneration.CSharp/Models/CSharpControllerOperationModel.cs" ]
[]
true
RicoSuter/NSwag
4,888
issue_to_patch
Please revert static UpdateJsonSerializerSettings When trying to update to v14-preview, I found that our code no longer compiles because the generated `UpdateJsonSerializerSettings` partial method has been changed to become static. This doesn't work for us, because we provide a NuGet package that contains a base class...
Restores support for instance-based JSON serializer settings in a non-breaking way
This PR adds an instance-based field for serializer settings in generated clients, which is `null` by default. Consumers can implement the `Initialize()` partial method and assign the `_instanceSettings` field from there, which takes precedence over static settings. Example usage to change serializer settings at run...
8af0c7106bd74ce0e3bb8c67df30eea933b57b45
fa2cf48cf5c7c16b90dfc123178a7205eae2c019
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/ObjectParameterTests.cs b/src/NSwag.CodeGeneration.CSharp.Tests/ObjectParameterTests.cs index efdb7fc630..fab28efccd 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/ObjectParameterTests.cs +++ b/src/NSwag.CodeGeneration.CSharp.Tests/ObjectParameterTests.cs @@ -72,7 ...
[ "src/NSwag.CodeGeneration.CSharp.Tests/ObjectParameterTests.cs", "src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid", "src/NSwag.CodeGeneration.CSharp/Templates/File.Header.liquid", "src/NSwag.ConsoleCore.Tests/GenerateSampleSpecificationTests.CheckCSharpClientsAsync_projectName=NSwag.Sample.NET70...
[]
true
RicoSuter/NSwag
5,272
issue_to_patch
Numbers on the CLI are parsed with locale, breaking scripts for certain regional configurations **Describe the bug** On my work Windows machine, NSwag expects my to write numbers as `X,X`. Which breaks all existing scripts. For example: `nswag openapi2tsclient /typeScriptVersion:4.3 [...]` results in: ``` System.Form...
feature: Inline NConsole with fixes
NConsole is super old and not maintained anymore. This PR copies it's sources with latest changes plus some bug fixes so that it can later be fully removed and replaced. https://github.com/RicoSuter/NConsole Closes https://github.com/RicoSuter/NSwag/issues/5270
6db16d724bc8bac77d18437f5755923eb25b7030
e62ce88ebb0e36f52feca91fda3928cc5f774d7c
diff --git a/Directory.Packages.props b/Directory.Packages.props index 30c646e0f..477c91e10 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -22,7 +22,6 @@ <PackageVersion Include="MyToolkit" Version="2.5.16" /> <PackageVersion Include="MyToolkit.Extended" Version="2.5.16" /> <Pack...
[ "Directory.Packages.props", "src/NSwag.Commands/NConsole/ArgumentAttribute.cs", "src/NSwag.Commands/NConsole/ArgumentAttributeBase.cs", "src/NSwag.Commands/NConsole/CommandAttribute.cs", "src/NSwag.Commands/NConsole/CommandLineProcessor.cs", "src/NSwag.Commands/NConsole/CommandResult.cs", "src/NSwag.Com...
[]
true
RicoSuter/NSwag
5,196
issue_to_patch
Fix for Reusable request bodies are not handled correctly #2747
Generating a (csharp) client did not type the body parameter if the body contains a $ref to a reusable request body. This pullrequest fixes the bug #2747 "Reusable request bodies are not handled correctly". sidenote; the class name of the typed body will saidly be called "Body" (or with a number if there are multip...
56167657c5b7dba9e4a1e4672593f5874e795884
d1c6cbd940c805a72d4b2257d3bfbaff9bd4baa7
diff --git a/src/NSwag.Core.Tests/Serialization/ExternalReferenceTests.cs b/src/NSwag.Core.Tests/Serialization/ExternalReferenceTests.cs index 0f5f3e896..8d31e3272 100644 --- a/src/NSwag.Core.Tests/Serialization/ExternalReferenceTests.cs +++ b/src/NSwag.Core.Tests/Serialization/ExternalReferenceTests.cs @@ -28,8 +28,9 ...
[ "src/NSwag.Core.Tests/Serialization/ExternalReferenceTests.cs", "src/NSwag.Core/OpenApiOperation.cs", "src/NSwag.Core/OpenApiRequestBody.cs" ]
[]
true
RicoSuter/NSwag
5,248
issue_to_patch
Add option to generate code only for selected operation IDs
## 🌟 Why this feature is needed This feature addresses a key pain point for users dealing with large OpenAPI/Swagger specifications. Previously, when generating C# or TypeScript clients, all operations within the specification were included by default. This led to unnecessarily large generated files and increased c...
4d95911f1aa1e3ab57098aa9b801785bd669a542
c974590f31de928dd96f170cbd842b4b2c12477b
diff --git a/docs/tutorials/GenerateProxyClientWithCLI/generate-proxy-client.md b/docs/tutorials/GenerateProxyClientWithCLI/generate-proxy-client.md index f4acff2de1..de1e8b58e4 100644 --- a/docs/tutorials/GenerateProxyClientWithCLI/generate-proxy-client.md +++ b/docs/tutorials/GenerateProxyClientWithCLI/generate-proxy...
[ "docs/tutorials/GenerateProxyClientWithCLI/generate-proxy-client.md", "docs/tutorials/GenerateProxyClientWithCLI/sample.nswag", "src/NSwag.ApiDescription.Client/NSwag.ApiDescription.Client.props", "src/NSwag.ApiDescription.Client/NSwag.ApiDescription.Client.targets", "src/NSwag.CodeGeneration.CSharp.Tests/C...
[]
true
RicoSuter/NSwag
5,268
issue_to_patch
feature: Update NJS v11.5.0, require TypeScript >= 4.3
9998913062e12ace779ad5ce0ad5fa5cbf2c1153
59a70415753a49463e7a16d2adbdb33e37239cca
diff --git a/Directory.Packages.props b/Directory.Packages.props index 5720399ff..30c646e0f 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -21,15 +21,15 @@ <PackageVersion Include="Moq" Version="4.20.72" /> <PackageVersion Include="MyToolkit" Version="2.5.16" /> <PackageVersion I...
[ "Directory.Packages.props", "src/NSwag.CodeGeneration.TypeScript.Tests/OperationParameterTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/ArrayParameterTests.When_parameter_is_array_then_TypeScript_is_correct.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/ArrayParameterTest...
[]
true
RicoSuter/NSwag
2,972
issue_to_patch
Typescript generated client does not include FileParameter when its in an Array When generating typescript clients for endpoints with file arrays as input FileParameter interface will be used but not included in the client
Fix for File Parameter interface not generated in some instances
- Split the Binary tests into 3 so each endpoint can be generated properly without missing the FileParameter interface - changed RequiresFileParameterInterface logic so it checks isBinary on arrays and nested objects Fixes [#2973](https://github.com/RicoSuter/NSwag/issues/2973)
baf4fe807d2a3d0d23f3388bebe8ca49c68e175b
2839dc9d5c7678fed6e50b13b454216ff6c1b52f
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/BinaryTests.cs b/src/NSwag.CodeGeneration.TypeScript.Tests/BinaryTests.cs index b6660efdd8..05a530b2b0 100644 --- a/src/NSwag.CodeGeneration.TypeScript.Tests/BinaryTests.cs +++ b/src/NSwag.CodeGeneration.TypeScript.Tests/BinaryTests.cs @@ -58,7 +58,7 @@ public asyn...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/BinaryTests.cs", "src/NSwag.CodeGeneration.TypeScript/Models/TypeScriptFileTemplateModel.cs" ]
[]
true
RicoSuter/NSwag
5,235
issue_to_patch
Add credentials and mode attributes to fetch template generation
Haven't tested yet but just attempting to get this started.
61d4af575015337c03cfdb0288735137ff001b9a
dd6ba2b9c32eaf96a52736e90420170d897d64fd
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs b/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs index 23f44a650..309c08a87 100644 --- a/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs +++ b/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs @@ -282,5 +282,57 @@ public async T...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/FetchTests.When_include_RequestCredentialsType_Include.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/FetchTests.When_include_RequestModeType_Cors.verified.txt", "src/NSwag.Code...
[ { "comment": "because there are four possible values: https://developer.mozilla.org/en-US/docs/Web/API/RequestInit#mode should this be an enum on settings side? I don't know about other clients if they support same options, but then it would be `public enum CorsMode` or `FetchCorsMode` with default of `None`, c...
true
RicoSuter/NSwag
5,251
issue_to_patch
K6 template for Typescript has error when void is return type **Describe the bug** K6 Template for typescript adds an extra `,` when a return type of void in the client. **Version of NSwag toolchain, computer and .NET runtime used** latest main (unreleased) **To Reproduce** npm run nswag with k6 as template typ...
#5250 - K6 template for Typescript has errors when void is return type
Fixes #5250 - Fixing errors by handling for void by having k6 http.Response as a return type so k6 checks can check status codes to identify success or failure.
4d95911f1aa1e3ab57098aa9b801785bd669a542
324dcb886bf685e02a84214435be74a1b4f8e415
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_consumes_is_url_encoded_then_construct_url_encoded_request.verified.txt b/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_consumes_is_url_encoded_then_construct_url_encoded_request.verified.txt index fdf55871d..5b03a1622 1006...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_consumes_is_url_encoded_then_construct_url_encoded_request.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_export_types_is_false_then_dont_add_export_before_classes.verified.txt", "src/NSwag.CodeGeneration.TypeScr...
[]
true
RicoSuter/NSwag
5,240
issue_to_patch
Add Template for TypeScript Client Generation for K6 **Is your feature request related to a problem? Please describe.** The TypeScript Client generation does not have an option for k6 client **Describe the solution you'd like** Add a template to the TypeScript Client generations for k6 **Describe alternatives you'...
Issue-5239 - Adding K6 template to TypeScript Code Generator
* Adding K6 template to TypeScript Code Generator * Resolves #5239
bc75a1eea28534dbe4ea8944f413bd776108b03c
a82ca771f8e92a600d1d314ff475cf4ac4ad5fd7
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/K6Tests.cs b/src/NSwag.CodeGeneration.TypeScript.Tests/K6Tests.cs new file mode 100644 index 000000000..8e4bf22e1 --- /dev/null +++ b/src/NSwag.CodeGeneration.TypeScript.Tests/K6Tests.cs @@ -0,0 +1,220 @@ +using NSwag.Generation.WebApi; +using Microsoft.AspNetCore...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/K6Tests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_abort_signal.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_abort_signal_and_generate_client_interfaces_interface_contains_signal_param.verified.txt", "sr...
[]
true
RicoSuter/NSwag
5,244
issue_to_patch
Add test coverage for some APIs
contributes to #4188
7ad4346341b1ad332b7b4044e0c2dbeed1ad1aea
27e32dff9ee881ad916ee92245c589c2a09ea2cf
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/ClientGenerationTests.cs b/src/NSwag.CodeGeneration.CSharp.Tests/ClientGenerationTests.cs index 5aa46fb3f..d309bdb3c 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/ClientGenerationTests.cs +++ b/src/NSwag.CodeGeneration.CSharp.Tests/ClientGenerationTests.cs @@ -8,1...
[ "src/NSwag.CodeGeneration.CSharp.Tests/ClientGenerationTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/NHS_SpineServices_OpenAPI.verified.txt", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/ShipBob_OpenAPI.verified.txt", "src/NSwag.CodeGeneration.CSharp.Tests/TestData/nhs-spineservices.json", ...
[]
true
RicoSuter/NSwag
5,243
issue_to_patch
Fix generating typescript fetch client interfaces when useAbortSignal is false
- Fix Fetch template to not create CancelToken on the interface - Restore two Fetch test cases to check that generated typescript code compiles
23cafb7fb80108eae5298274fccc20e6fc809803
68447604c359d398d62d223c0cb34cec27986efe
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs b/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs index 23f44a650..b22a5bcca 100644 --- a/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs +++ b/src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs @@ -65,9 +65,7 @@ public async Task...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/FetchTests.When_export_types_is_false_then_dont_add_export_before_classes.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/FetchTests.When_export_types_is_true_then_add_export_befor...
[]
true
RicoSuter/NSwag
5,177
issue_to_patch
Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation
NJsonSchema pull request https://github.com/RicoSuter/NJsonSchema/pull/1828 fixes a problem in class name generating that could result in lower case class names. This commit updates the expected code to match the one that is generated by my NJsonSchema pull request. If the NJsonSchema pull request is merged and the...
b295a2dc9badb2943bbde9b5bffb69fd0a1c117d
b907a688b63d31c1deacc54c8e7831faf6461754
diff --git a/Directory.Packages.props b/Directory.Packages.props index 18d498fb2..5720399ff 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -24,12 +24,12 @@ <PackageVersion Include="Namotion.Reflection" Version="3.4.2" /> <PackageVersion Include="NConsole" Version="3.12.6605.26941" /> ...
[ "Directory.Packages.props", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/BinaryTests.When_body_is_binary_array_then_IFormFile_Collection_is_used_as_parameter_in_CSharp_ASPNETCore.verified.txt", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/BinaryTests.When_body_is_binary_then_IFormFile_is_used_as_paramet...
[]
true
RicoSuter/NSwag
5,236
issue_to_patch
v14.5.0
61d4af575015337c03cfdb0288735137ff001b9a
effc01f2086271f32845927d1e80fd87cf570767
diff --git a/Directory.Build.props b/Directory.Build.props index ce42206fd..84cfeb9ea 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,6 +1,6 @@ <Project> <PropertyGroup> - <VersionPrefix>14.4.1</VersionPrefix> + <VersionPrefix>14.5.0</VersionPrefix> <Authors>Rico Suter</Authors> ...
[ "Directory.Build.props" ]
[]
true
RicoSuter/NSwag
5,234
issue_to_patch
Use TypeScript 4.3 as default testing version
* enable Angular compilation
4bdddbccf1290c5e1447a6676e9db4bb404e7fa6
da38210de92e05018071018404b8b3fada67fcee
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs b/src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs index 3be32f5ec..adf9d1663 100644 --- a/src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs +++ b/src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs @@ -50,7 +50,7 @@ p...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/AngularTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/AxiosTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/JQueryCallbacksTests.cs...
[]
true
RicoSuter/NSwag
5,232
issue_to_patch
Optimize NSwag NPM Script nswag.js The nswag.js logic passes the argument /runtime:* to the executable or dll which causes an errormessage like that: "Unrecognised arguments are present: [/runtime:Net80]" NSwag NPM Version 11.5.1 is installed and used in VS Code on Windows 11 .Net Runtime 8 und 9 are present, al...
Improve nswag.js parameter handling
prevent passing through the /runtime arguments to the executable of nswag, because that causes errors in the actual tool. completly restructured. should now do what was expected from this script closes #5231
b295a2dc9badb2943bbde9b5bffb69fd0a1c117d
f1880b2c12d51094376cba1e9ff688e32a9da4eb
diff --git a/src/NSwag.Npm/bin/nswag.js b/src/NSwag.Npm/bin/nswag.js index c1446d91fe..a83e85b78b 100644 --- a/src/NSwag.Npm/bin/nswag.js +++ b/src/NSwag.Npm/bin/nswag.js @@ -7,65 +7,149 @@ var supportedCoreVersions = [ { ver: '9.0', dir: "Net90", }, ]; +const path = require('path'); +var c = require('child_pro...
[ "src/NSwag.Npm/bin/nswag.js" ]
[]
true
RicoSuter/NSwag
5,057
issue_to_patch
Show DisplayName for conflicting actions
Just like in Swashbuckle (https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs#L290). Reduce some code differences between AspNetCore and NSwag.Generation.WebApi projects. ## Before ![image](https://github.com/user-atta...
3c03ff04ba18fbd4ac26eb62ba3443bff95377ee
d691745f341ed378756d675add94397fcbdc3d52
diff --git a/src/NSwag.Generation.AspNetCore/AspNetCoreOpenApiDocumentGenerator.cs b/src/NSwag.Generation.AspNetCore/AspNetCoreOpenApiDocumentGenerator.cs index 7922e9856..3b0d21548 100644 --- a/src/NSwag.Generation.AspNetCore/AspNetCoreOpenApiDocumentGenerator.cs +++ b/src/NSwag.Generation.AspNetCore/AspNetCoreOpenApi...
[ "src/NSwag.Generation.AspNetCore/AspNetCoreOpenApiDocumentGenerator.cs", "src/NSwag.Generation.WebApi/Processors/OperationParameterProcessor.cs", "src/NSwag.Generation.WebApi/WebApiOpenApiDocumentGenerator.cs" ]
[]
true
RicoSuter/NSwag
5,032
issue_to_patch
Fix: When generated TS class name is "Error", it is conflicting with TS Error class
Where one of the generated class name is "Error" it cause confusion to `throw new Error(...)` operations and causing the build to fail. Following is example build failure message: ``` ERROR in ./src/api/index.ts:3008:29 TS2559: Type '"The parameter 'foo' must be defined."' has no properties in common with type...
4d7afdace8c25f97d6adff064a1812666eba1136
e416eef2367854abf35358d7d3928dc28972343b
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/ArrayParameterTests.when_content_is_formdata_with_property_array_then_content_should_be_added_in_foreach_in_typescript.verified.txt b/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/ArrayParameterTests.when_content_is_formdata_with_property_array_then...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/ArrayParameterTests.when_content_is_formdata_with_property_array_then_content_should_be_added_in_foreach_in_typescript.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/AxiosTests.Add_cancel_token_to_every_call.verified.txt", "src/NSwag.Code...
[]
true
RicoSuter/NSwag
5,227
issue_to_patch
Invalid code generated for paths starting with number Have one of the methods in your open api be the following, which is one of the default identity api names provided by Microsoft and sadly trying to change this *also* creates issues on Microsoft's end. I've logged an issue for that (https://github.com/dotnet/aspnet...
Ensure operation names start with alphanumeric character
fixes #5226
29b77f18c8f8c2573278416ad67507af1604c686
a06f50d686b9110fe291380785d173034bf29e0e
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs b/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs index ba62c1456..57f1c24cf 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs +++ b/src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs @@ -182,6 +182,...
[ "src/NSwag.CodeGeneration.CSharp.Tests/CodeGenerationTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/CodeGenerationTests.When_path_starts_with_numeric_can_generate_client.verified.txt", "src/NSwag.CodeGeneration.CSharp/Models/CSharpOperationModel.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/Cod...
[]
true
RicoSuter/NSwag
5,228
issue_to_patch
Change GenerateSampleSpecificationTests to auto verify mode
c9a4c3c8a52fe01f1fa527b7693c30182040cf68
dbc38f9d3670e312aebd190b2d52aeeb584416bb
diff --git a/src/NSwag.CodeGeneration.Tests/VerifyHelper.cs b/src/NSwag.CodeGeneration.Tests/VerifyHelper.cs index 210548f19..d84fb4764 100644 --- a/src/NSwag.CodeGeneration.Tests/VerifyHelper.cs +++ b/src/NSwag.CodeGeneration.Tests/VerifyHelper.cs @@ -17,6 +17,7 @@ public static SettingsTask Verify(string output, bool...
[ "src/NSwag.CodeGeneration.Tests/VerifyHelper.cs", "src/NSwag.ConsoleCore.Tests/GenerateSampleSpecificationTests.Should_generate_openapi_for_project_projectName=NSwag.Sample.NET80Minimal_targetFramework=net8.0_generatesCode=True.verified.txt", "src/NSwag.ConsoleCore.Tests/GenerateSampleSpecificationTests.Should_...
[]
true
RicoSuter/NSwag
5,225
issue_to_patch
Convert to xUnit v3
8003d75b826a919fc8926c8bc1163e6cd6d2c4c3
3510764517e7ecb2bd5db2b14fb30788be659a45
diff --git a/.gitattributes b/.gitattributes index 511db4216..d6acc28d3 100644 --- a/.gitattributes +++ b/.gitattributes @@ -155,4 +155,7 @@ makefile text src/NSwag.AspNetCore/SwaggerUi/**/* linguist-vendored src/NSwag.AspNet.Owin/SwaggerUi/**/* linguist-vendored -src/NSwag.Integration.*/**/* linguist-vendored \ No...
[ ".gitattributes", ".gitignore", "Directory.Build.props", "Directory.Packages.props", "src/NSwag.CodeGeneration.CSharp.Tests/CSharpCompiler.cs", "src/NSwag.CodeGeneration.CSharp.Tests/NSwag.CodeGeneration.CSharp.Tests.csproj", "src/NSwag.CodeGeneration.Tests/NSwag.CodeGeneration.Tests.csproj", "src/NSw...
[]
true
RicoSuter/NSwag
5,224
issue_to_patch
Convert more tests to use verify
d25e97c98f46f759167809c8dd2199eeb78d7ecf
d619087c81a5def9e0375b879fdd944104b0e998
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/AllowNullableBodyParametersTests.cs b/src/NSwag.CodeGeneration.CSharp.Tests/AllowNullableBodyParametersTests.cs index 09e032a3e..ae34b0c38 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/AllowNullableBodyParametersTests.cs +++ b/src/NSwag.CodeGeneration.CSharp.Tests...
[ "src/NSwag.CodeGeneration.CSharp.Tests/AllowNullableBodyParametersTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/ArrayParameterTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/BinaryTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/CSharpClientSettingsTests.cs", "src/NSwag.CodeGeneration.CSharp.Tests/CS...
[]
true
RicoSuter/NSwag
5,223
issue_to_patch
Parameter with a colon in its name generates invalid C# client I am trying to generate a client from the OpenAPI document at https://directory.spineservices.nhs.uk/apidocs/ . Some of the parameters (for example, `/STU3/Organization` has a parameter `address-postalcode:contains` ) have names that contain colons. Whe...
Optimize DefaultParameterNameGenerator and add some more char cleanup
Fixes #4188
9e570292bb9a838777b3305776949359f8ecfe3e
8c8670f52f715617ea1aca9ccb82b58450ef4272
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt b/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt index da9d9ab5f..e1d4c7c30 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt +++ b/src/NSwag.CodeGeneration.CSharp.Tests...
[ "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_Angular.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_AngularJS.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/...
[]
true
RicoSuter/NSwag
4,826
issue_to_patch
C# Code Generation generates method with return default(void) The C# generator generated client method with the following signature: `public async System.Threading.Tasks.Task AttachmentsPatchAsync(int attachmentId, AttachmentRename body, System.Threading.CancellationToken cancellationToken)` Problem is that the ...
Fix: C# Code Generation generates method with return default(void)
This PR is made to avoid generation of C# code like this one (which leads to compilation error of course): ``` if (status_ == 204) { return default(void); } ``` fixes #3912 fixes #3996
84997dd1b32e185de13f849054794352062e8da3
3ce6b16fcb656d529e083665974b36be75524b5a
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt b/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt index 151ef08d9..da9d9ab5f 100644 --- a/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt +++ b/src/NSwag.CodeGeneration.CSharp.Tests...
[ "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/JIRA_OpenAPI.verified.txt", "src/NSwag.CodeGeneration.CSharp/Models/CSharpOperationModel.cs", "src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.ProcessResponse.liquid", "src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid" ]
[]
true
RicoSuter/NSwag
5,020
issue_to_patch
Remove deprecated tslint suppression
TSLint is [deprecated since 2019](https://palantir.github.io/tslint/) and the de-factor successor `typescript-eslint` has [a rule banning the tslint comment](https://typescript-eslint.io/rules/ban-tslint-comment/). For new users the default should work out-of-the box. Existing users still using tslint can add NSwag...
8da845a0b948c9c2d47b68cdb499ff6cba6f0cc9
f91a0f85042cd36289ca9cbf29d8184503a468f4
diff --git a/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_Angular.verified.txt b/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_Angular.verified.txt index 4537e485b..b2a62d71f 100644 --- a/src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_Angular.verified.txt +++ b/s...
[ "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_Angular.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_AngularJS.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Tests/Snapshots/JIRA_OpenAPI_Aurelia.verified.txt", "src/NSwag.CodeGeneration.TypeScript.Test...
[]
true
RicoSuter/NSwag
5,222
issue_to_patch
Client Query String empty IEnumerable error **Query string is invalid** Previous versions of NSwag have generated valid query string parameters where the IEnumerable contains no elements. **Version 14.4.0 .NET 8** Previous working Version 14.2.0 **To Reproduce** With version 14.2.0 ```c# if (orderStatus != null)...
Fix empty enumerable parameter handling in C# client
fixes #5194
fd47538bb8434db2b4d1ece0d9d194029448a315
cc60e919960611560013981b8b5014ff74e48687
diff --git a/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/ArrayParameterTests.When_CollectionFormat_is_csv_then_do_not_explode.verified.txt b/src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/ArrayParameterTests.When_CollectionFormat_is_csv_then_do_not_explode.verified.txt index b032a05b7..de68520fe 100644 --- a/src/N...
[ "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/ArrayParameterTests.When_CollectionFormat_is_csv_then_do_not_explode.verified.txt", "src/NSwag.CodeGeneration.CSharp.Tests/Snapshots/ArrayParameterTests.When_explode_is_false_then_do_not_explode_explode=-explode-- false,.verified.txt", "src/NSwag.CodeGeneration.C...
[]
true
RicoSuter/NSwag
5,220
issue_to_patch
Replace TypeScript string contain asserts with Verify tests
4cf8fa9f205ab142d857a82360d89d3c5b02ba48
77edef655237a775cbe5431a245ab39552de0fa2
diff --git a/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs b/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs index 4f13b0579..8a6993974 100644 --- a/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs +++ b/src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs @@ -7,7 +7,6 @@ using NSwag.CodeGeneration...
[ "src/NSwag.CodeGeneration.Tests/CodeGenerationTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/AngularTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/ArrayParameterTests.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/AxiosTests.cs", ...
[]
true