Split (1)

train · 87.9k rows

repo stringlengths 5 53	pr_number int32 1 321k	task_type stringclasses 2 values	issue_text stringlengths 0 81.2k	pr_title stringlengths 1 319	pr_body stringlengths 0 105k	base_sha stringlengths 40 40	head_sha stringlengths 40 40	gold_diff stringlengths 0 202M	changed_files listlengths 0 100	review_threads listlengths 0 100	test_patch stringlengths 0 23.4M	merged bool 1 class
RightNow-AI/openfang	1,017	issue_to_patch	Copilot driver auth is broken - requires OAuth device flow token, not PAT ## Description The GitHub Copilot LLM driver does not work with any standard GitHub token type. The code says it exchanges a GitHub PAT for a Copilot API token, but the copilot_internal/v2/token endpoint rejects all standard token types: - Cla...	fix: rewrite Copilot driver with OAuth device flow authentication	## Summary Complete rewrite of the GitHub Copilot LLM driver to fix broken authentication and add proper OAuth device flow support. Before: The driver expected a `GITHUB_TOKEN` env var, but no standard token type (PAT, fine-grained PAT, `gh` CLI token) works with the Copilot token exchange endpoint. Users couldn'...	a26f7626359fe50480244c2304cec533b7df2363	be1c4dba479bdb81ad136e0214a6d0760c07a4d1	diff --git a/crates/openfang-cli/src/main.rs b/crates/openfang-cli/src/main.rs index 64cffd0670..553b8c25e3 100644 --- a/crates/openfang-cli/src/main.rs +++ b/crates/openfang-cli/src/main.rs @@ -2457,6 +2457,18 @@ decay_rate = 0.05 } } + // Check GitHub Copilot auth (separate from env var checks) + ...	[ "crates/openfang-cli/src/main.rs", "crates/openfang-cli/src/tui/screens/init_wizard.rs", "crates/openfang-kernel/src/kernel.rs", "crates/openfang-runtime/src/drivers/copilot.rs", "crates/openfang-runtime/src/drivers/mod.rs", "crates/openfang-runtime/src/drivers/openai.rs", "crates/openfang-runtime/src/m...	[]		true
RightNow-AI/openfang	922	issue_to_patch		Add armv7-unknown-linux-gnueabihf target	## Summary This PR adds cross-compilation support for the armv7-unknown-linux-gnueabihf target to enable running OpenFang on 32-bit ARM devices (such as Raspberry Pi 2/3/4 running 32-bit ARM Linux distributions). ## Changes The armv7 target support has been implemented across the following files: 1. [Cross....	618e83714c353f51707c8daeb1e5bfbc4e65e047	e42159418589fec91014473249a7e2ee8392e86c	diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cd40328938..9aa2b11169 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -134,7 +134,7 @@ jobs: projectPath: crates/openfang-desktop args: ${{ matrix.platform.args }} - # ── CLI Bina...	[ ".github/workflows/release.yml", "Cross.toml" ]	[]		true
RightNow-AI/openfang	957	issue_to_patch		build(deps): bump prost from 0.13.5 to 0.14.3	Bumps [prost](https://github.com/tokio-rs/prost) from 0.13.5 to 0.14.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md">prost's changelog</a>.</em></p> <blockquote> <h1>Prost version 0.14.2</h1> <p><em>PROST!</em> is a <a href="https://prot...	a78299ed3d59c45f694365334f8d69811c65c522	d1bb8f30e4e569b40e492fd0fb0a36ba19ae3fde	diff --git a/Cargo.lock b/Cargo.lock index 8d84ca7e84..74bfef5676 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5025,9 +5025,9 @@ dependencies = [ [[package]] name = "prost" -version = "0.13.5" +version = "0.14.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "2796faa41db3ec313a31f762...	[ "Cargo.lock", "Cargo.toml" ]	[]		true
RightNow-AI/openfang	955	issue_to_patch		build(deps): bump lettre from 0.11.19 to 0.11.20	Bumps [lettre](https://github.com/lettre/lettre) from 0.11.19 to 0.11.20. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lettre/lettre/releases">lettre's releases</a>.</em></p> <blockquote> <h2>v0.11.20</h2> <h4>Upgrade notes</h4> <ul> <li>MSRV is now 1.85 <a href="https://re...	a78299ed3d59c45f694365334f8d69811c65c522	6ce95450338b568e82ddae1580df4af7ed8b9510	diff --git a/Cargo.lock b/Cargo.lock index 8d84ca7e84..fef19415bf 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -139,7 +139,7 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc" dependencies = [ - "windows-s...	[ "Cargo.lock" ]	[]		true
RightNow-AI/openfang	966	issue_to_patch	[Bug] nix build fails on v0.5.4+: native-tls vendored feature requires perl missing from flake buildInputs ### Description: nix build from the flake fails at the openssl-sys crate with Command 'perl' not found when building openfang-cli from source in a sandboxed Nix environment. The build succeeds on v0.5.3 and ...	fix(nix): add perl to buildInputs for openssl-sys vendored build	## Summary Since v0.5.4, native-tls uses features = ["vendored"], which compiles OpenSSL from source via openssl-sys. This requires perl for the OpenSSL Configure script, but perl was missing from the flake's buildInputs. Mirrors the Dockerfile fix in #952. Fixes #894. ## Changes - Added perl to rust-projec...	a78299ed3d59c45f694365334f8d69811c65c522	28d01acf91a700d5f53068571ab8a86d32137b56	diff --git a/flake.nix b/flake.nix index f172a0a056..999cc5c66a 100644 --- a/flake.nix +++ b/flake.nix @@ -25,6 +25,7 @@ rust-project.defaults.perCrate.crane.args.buildInputs = with pkgs; [ clang openssl + perl pkg-config ]; rust-project.crates.openfa...	[ "flake.nix" ]	[]		true
RustPython/RustPython	7,947	issue_to_patch		Fix most of `unicodedata`, unmask multiple tests, and remove `ucd`	Python bundles an old version of Unicode for compatibility. RustPython tries to mimic supporting that old version by checking the version of individual chars. This is a problem for a few reasons. The first is that the age check adds an additional hit per each char lookup in Unicode data. The check is outdated because t...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	3cf603916206965677c889ca83e14364a4cbac7f	diff --git a/Cargo.lock b/Cargo.lock index 3fd14cb53df..9070e2e203f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3814,8 +3814,6 @@ dependencies = [ "system-configuration", "tcl-sys", "tk-sys", - "ucd", - "unic-ucd-age", "unicode_names2 2.0.0", "uuid", "webpki-roots", @@ -4578,53 +4576,6 @@ version = "1.20.0...	[ "Cargo.lock", "Cargo.toml", "Lib/test/test_str.py", "Lib/test/test_unicodedata.py", "crates/stdlib/Cargo.toml", "crates/stdlib/build.rs", "crates/stdlib/src/unicodedata.rs", "crates/stdlib/unicode/README.md", "crates/stdlib/unicode/latest/DerivedNumericValues.txt", "crates/stdlib/unicode/latest/No...	[ { "comment": "Probably worth trying to get this patch to ruff as well.\n\nhttps://github.com/astral-sh/ruff/blob/ceca6028373d31f3a7d44a5e3e00d7c0b2dd8614/crates/ruff_python_literal/src/char.rs", "path": "crates/literal/src/char.rs", "hunk": "@@ -10,17 +10,11 @@ use icu_properties::props::{EnumeratedProp...	diff --git a/Lib/test/test_str.py b/Lib/test/test_str.py index baef294285f..5135564284e 100644 --- a/Lib/test/test_str.py +++ b/Lib/test/test_str.py @@ -853,7 +853,6 @@ def test_isprintable(self): self.assertTrue('\U0001F46F'.isprintable()) self.assertFalse('\U000E0020'.isprintable()) - @unittest...	true
RustPython/RustPython	7,947	comment_to_fix		Fix most of `unicodedata`, unmask multiple tests, and remove `ucd`	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Field selection in `parse_unicode_3_2` is ambiguous and can silently parse the wrong column. Line 439 uses `field.saturating_sub(1)`, which makes `field = 0` and `field = 1` behave identically. That creates a fragile API contract and can produce wrong generated ta...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	3cf603916206965677c889ca83e14364a4cbac7f	diff --git a/crates/stdlib/build.rs b/crates/stdlib/build.rs index 5a06d24a269..4cf7b21d4b7 100644 --- a/crates/stdlib/build.rs +++ b/crates/stdlib/build.rs @@ -3,7 +3,604 @@ reason = "build scripts cannot use rustpython-host_env" )] -// spell-checker:ignore ossl osslconf +// spell-checker:ignore decomp DECOMP ...	[ "crates/stdlib/build.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nField selection in `parse_unicode_3_2` is ambiguous and can silently parse the wrong column.\n\nLine 439 uses `field.saturating_sub(1)`, which makes `field = 0` and `field = 1` behave identically. That creates a fragile API contract and can ...		true
RustPython/RustPython	8,094	issue_to_patch		Bump pyo3 from 0.28.3 to 0.29.0	Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.28.3 to 0.29.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pyo3/pyo3/releases">pyo3's releases</a>.</em></p> <blockquote> <h2>PyO3 0.29.0</h2> <p>This release is a relatively large release with improvements across many are...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	1865bdb0c714e7ab2755640ecfea47351ce6c591	diff --git a/Cargo.lock b/Cargo.lock index 3fd14cb53d..b4f22820d7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -100,7 +100,7 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc" dependencies = [ - "windows-s...	[ "Cargo.lock", "Cargo.toml" ]	[]		true
RustPython/RustPython	8,093	issue_to_patch		Bump log from 0.4.31 to 0.4.32	Bumps [log](https://github.com/rust-lang/log) from 0.4.31 to 0.4.32. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/log/releases">log's releases</a>.</em></p> <blockquote> <h2>0.4.32</h2> <h2>What's Changed</h2> <ul> <li>Support <code>Value</code> -> string conve...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	d35ef3b5e08aa8054d66472325febe561ede2d42	diff --git a/Cargo.lock b/Cargo.lock index 3fd14cb53d..20adec0daa 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2206,9 +2206,9 @@ dependencies = [ [[package]] name = "log" -version = "0.4.31" +version = "0.4.32" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "113b30b4cd05f7c06868fdb285...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,092	issue_to_patch		Bump which from 8.0.2 to 8.0.3	Bumps [which](https://github.com/harryfei/which-rs) from 8.0.2 to 8.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/harryfei/which-rs/releases">which's releases</a>.</em></p> <blockquote> <h2>8.0.3</h2> <h2>What's Changed</h2> <ul> <li>feat: use catch-all cfg for <code>is...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	2f49887fb6330f0deaf72643a1d717d0bf57d50b	diff --git a/Cargo.lock b/Cargo.lock index 3fd14cb53d..e7ec080d76 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4923,9 +4923,9 @@ dependencies = [ [[package]] name = "which" -version = "8.0.2" +version = "8.0.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "81995fafaaaf6ae47a7d0cc83c...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,091	issue_to_patch		Bump uuid from 1.23.2 to 1.23.3	Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.23.2 to 1.23.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uuid-rs/uuid/releases">uuid's releases</a>.</em></p> <blockquote> <h2>v1.23.3</h2> <h2>What's Changed</h2> <ul> <li>Fix up parser panic on empty input by <a hre...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	a06016dbfd8b0adb0e7359f26c1e56d0505bb65f	diff --git a/Cargo.lock b/Cargo.lock index 3fd14cb53d..f3e02b4019 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4372,7 +4372,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "32497e9a4c7b38532efcdebeef879707aa9f794296a4f0244f6f69e9bc8574bd" dependencies = [ "fastrand", - "getrandom 0....	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,090	issue_to_patch		Bump cranelift from 0.132.0 to 0.132.1 in the wasmtime group across 1 directory	Bumps the wasmtime group with 1 update in the / directory: [cranelift](https://github.com/bytecodealliance/wasmtime). Updates `cranelift` from 0.132.0 to 0.132.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bytecodealliance/wasmtime/releases">cranelift's releases</a>.</em>...	be6017cbc8d1fa2b11fda5d6014d706ceac7b1a9	ff99b3925d3f2cd2e46b9523b1a1a3ca26af6a19	diff --git a/Cargo.lock b/Cargo.lock index 3fd14cb53d..582d09c60c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -741,9 +741,9 @@ dependencies = [ [[package]] name = "cranelift" -version = "0.132.0" +version = "0.132.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f2948a18918ec81f4701...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,089	issue_to_patch		Newtype SignalHandlers	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	d18d35faba752dc9eca58d18515c5e6adca795d2	9198c2639a7821b5c4d831b18c0fadbd4ac47fad	diff --git a/crates/vm/src/signal.rs b/crates/vm/src/signal.rs index 50a887c143..11fe4f2127 100644 --- a/crates/vm/src/signal.rs +++ b/crates/vm/src/signal.rs @@ -1,7 +1,10 @@ use crate::{PyObjectRef, PyResult, VirtualMachine}; -use alloc::fmt; -use core::cell::{Cell, RefCell}; -use core::sync::atomic::{AtomicBool, Or...	[ "crates/vm/src/signal.rs", "crates/vm/src/stdlib/_signal.rs", "crates/vm/src/stdlib/posix.rs", "crates/vm/src/vm/mod.rs" ]	[]		true
RustPython/RustPython	8,088	issue_to_patch		Update doc DB for CPython 3.14.6	Auto-generated by update-doc-db workflow.	d18d35faba752dc9eca58d18515c5e6adca795d2	7ee91487de8728fc6aa66592f01810b808d2bc3b	diff --git a/crates/doc/src/data.inc.rs b/crates/doc/src/data.inc.rs index 32b4872238d..73246d65077 100644 --- a/crates/doc/src/data.inc.rs +++ b/crates/doc/src/data.inc.rs @@ -1,5 +1,5 @@ // This file was auto-generated by `.github/workflows/update-doc-db.yml`. -// CPython version: 3.14.5 +// CPython version: 3.14.6 ...	[ "crates/doc/src/data.inc.rs" ]	[]		true
RustPython/RustPython	8,086	issue_to_patch		Update some of changed libs and tests from `3.14.5` -> `3.14.6` (part 3)	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	d18d35faba752dc9eca58d18515c5e6adca795d2	02bbc53ff9a3f1cc13993848baeffe54241f54e6		[ "Lib/test/support/__init__.py", "Lib/test/test_bytes.py", "Lib/test/test_bz2.py", "Lib/test/test_cmd_line.py", "Lib/test/test_deque.py", "Lib/test/test_genericalias.py", "Lib/test/test_grp.py", "Lib/test/test_imaplib.py", "Lib/test/test_import/__init__.py", "Lib/test/test_listcomps.py", "Lib/tes...	[]	diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py index 6635ec3474e..701d34bba2d 100644 --- a/Lib/test/support/__init__.py +++ b/Lib/test/support/__init__.py @@ -3227,3 +3227,18 @@ def control_characters_c0() -> list[str]: C0 control characters defined as the byte range 0x00-0x1F, and 0x7F. ...	true
RustPython/RustPython	8,085	issue_to_patch		Update some of changed libs and tests from `3.14.5` -> `3.14.6` (part 2)	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	ac3d442b45657c58b7fa4e85ce71340d36995a56	59607bccb652fa8f2e3caab12b7e1cc944912039	diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py index 5c5b14788dc..abebb4b69fd 100644 --- a/Lib/http/cookies.py +++ b/Lib/http/cookies.py @@ -391,18 +391,18 @@ def __repr__(self): return '<%s: %s>' % (self.__class__.__name__, self.OutputString()) def js_output(self, attrs=None): - import b...	[ "Lib/http/cookies.py", "Lib/imaplib.py", "Lib/json/__init__.py", "Lib/json/tool.py", "Lib/locale.py", "Lib/ntpath.py", "Lib/os.py", "Lib/pydoc_data/module_docs.py", "Lib/pydoc_data/topics.py", "Lib/rlcompleter.py", "Lib/shutil.py", "Lib/tarfile.py", "Lib/test/datetimetester.py", "Lib/test/...	[]	diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py index c6534adb1fc..c1bb6138a1b 100644 --- a/Lib/test/datetimetester.py +++ b/Lib/test/datetimetester.py @@ -7313,6 +7313,36 @@ def func(): self.assertEqual(out, b"a" * 8) self.assertEqual(err, b"") + @support.cpython_only + @...	true
RustPython/RustPython	8,084	issue_to_patch		Update some of changed libs and tests from `3.14.5` -> `3.14.6` (part 1)	If I'll see problematic libs, I'll extract them to thier own PR. most of the changes are docstring related	ac3d442b45657c58b7fa4e85ce71340d36995a56	9406206ace5408d695f02fb18a57f4bfc3ea2305	diff --git a/Lib/_collections_abc.py b/Lib/_collections_abc.py index 241d40d5740..996b094377a 100644 --- a/Lib/_collections_abc.py +++ b/Lib/_collections_abc.py @@ -461,8 +461,8 @@ def __subclasshook__(cls, C): class _CallableGenericAlias(GenericAlias): """ Represent `Callable[argtypes, resulttype]`. - This ...	[ "Lib/_collections_abc.py", "Lib/_pydecimal.py", "Lib/_pyio.py", "Lib/asyncio/base_events.py", "Lib/asyncio/coroutines.py", "Lib/asyncio/events.py", "Lib/asyncio/graph.py", "Lib/asyncio/locks.py", "Lib/asyncio/proactor_events.py", "Lib/asyncio/queues.py", "Lib/asyncio/runners.py", "Lib/asyncio/...	[]	diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py index 766e6f49984..6c198addbc6 100644 --- a/Lib/test/test_asyncio/test_sendfile.py +++ b/Lib/test/test_asyncio/test_sendfile.py @@ -228,6 +228,61 @@ def test_sock_sendfile_zero_size(self): self.assertEqual(ret, 0) ...	true
RustPython/RustPython	8,076	issue_to_patch		cleanup the signals module	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	ac3d442b45657c58b7fa4e85ce71340d36995a56	b44f3d88e1f8bafcb76148e27b01785489573f66	diff --git a/crates/vm/src/signal.rs b/crates/vm/src/signal.rs index 6c8e9cb6d3..50a887c143 100644 --- a/crates/vm/src/signal.rs +++ b/crates/vm/src/signal.rs @@ -1,29 +1,31 @@ -#![cfg_attr(target_os = "wasi", allow(dead_code))] use crate::{PyObjectRef, PyResult, VirtualMachine}; use alloc::fmt; use core::cell::{Cel...	[ "crates/vm/src/signal.rs", "crates/vm/src/stdlib/_signal.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nDon't reuse delivery-only bounds for `strsignal()`.\n\nLine 422 now rejects `0` up front, but `strsignal()` is just a name lookup and `host_signal::strsignal(signalnum)` can validly describe signal `0` on Unix-like platforms. This refactor m...		true
RustPython/RustPython	8,076	comment_to_fix		cleanup the signals module	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Don't reuse delivery-only bounds for `strsignal()`. Line 422 now rejects `0` up front, but `strsignal()` is just a name lookup and `host_signal::strsignal(signalnum)` can validly describe signal `0` on Unix-like platforms. This refactor makes `signal.strsignal(0)`...	ac3d442b45657c58b7fa4e85ce71340d36995a56	b44f3d88e1f8bafcb76148e27b01785489573f66	diff --git a/crates/vm/src/stdlib/_signal.rs b/crates/vm/src/stdlib/_signal.rs index 05bab5e112..191f67d090 100644 --- a/crates/vm/src/stdlib/_signal.rs +++ b/crates/vm/src/stdlib/_signal.rs @@ -6,21 +6,32 @@ pub(crate) use _signal::module_def; pub(crate) mod _signal { #![allow(unreachable_pub)] - #[cfg(any(...	[ "crates/vm/src/stdlib/_signal.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nDon't reuse delivery-only bounds for `strsignal()`.\n\nLine 422 now rejects `0` up front, but `strsignal()` is just a name lookup and `host_signal::strsignal(signalnum)` can validly describe signal `0` on Unix-like platforms. This refactor m...		true
RustPython/RustPython	8,076	comment_to_fix		cleanup the signals module	_⚠️ Potential issue_ \| _🟡 Minor_ \| _⚡ Quick win_ Fix the upper-bound text in the `ValueError`. `SIGNUM_RANGE` is half-open, but this message advertises a closed interval `[1, {SIGNUM_RANGE.end}]`. That tells callers the upper bound is accepted even though `SIGNUM_RANGE.contains()` rejects it. Please format the m...	ac3d442b45657c58b7fa4e85ce71340d36995a56	b44f3d88e1f8bafcb76148e27b01785489573f66	diff --git a/crates/vm/src/stdlib/_signal.rs b/crates/vm/src/stdlib/_signal.rs index 05bab5e112..191f67d090 100644 --- a/crates/vm/src/stdlib/_signal.rs +++ b/crates/vm/src/stdlib/_signal.rs @@ -6,21 +6,32 @@ pub(crate) use _signal::module_def; pub(crate) mod _signal { #![allow(unreachable_pub)] - #[cfg(any(...	[ "crates/vm/src/stdlib/_signal.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟡 Minor_ \| _⚡ Quick win_\n\nFix the upper-bound text in the `ValueError`.\n\n`SIGNUM_RANGE` is half-open, but this message advertises a closed interval `[1, {SIGNUM_RANGE.end}]`. That tells callers the upper bound is accepted even though `SIGNUM_RANGE.contains()` rejec...		true
RustPython/RustPython	7,823	issue_to_patch		Update `pyrepl` to 3.14.5	<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * New Features * Added input hook detection capability across multiple platforms (Windows and POSIX-based systems), enabling improved support for interactive shell and IDE environments. <!-- end of auto-genera...	9259d22f811b174e732b6b057b19eb5a758f92a3	e50501e3317cdd600fec24f51e46693a6875c100	diff --git a/Lib/_pyrepl/__main__.py b/Lib/_pyrepl/__main__.py index 3fa992eee8e..9c66812e13a 100644 --- a/Lib/_pyrepl/__main__.py +++ b/Lib/_pyrepl/__main__.py @@ -1,6 +1,10 @@ # Important: don't add things to this module, as they will end up in the REPL's # default globals. Use _pyrepl.main instead. +# Avoid cac...	[ "Lib/_pyrepl/__main__.py", "Lib/_pyrepl/_minimal_curses.py", "Lib/_pyrepl/_module_completer.py", "Lib/_pyrepl/base_eventqueue.py", "Lib/_pyrepl/commands.py", "Lib/_pyrepl/completing_reader.py", "Lib/_pyrepl/console.py", "Lib/_pyrepl/curses.py", "Lib/_pyrepl/fancy_termios.py", "Lib/_pyrepl/keymap.p...	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _🏗️ Heavy lift_\n\nRoot cause: both platform stubs hardcode `false` instead of checking installed hook state. \nBecause both implementations ignore actual `PyOS_CallInputHook` state, Windows and POSIX REPLs both permanently disable their `*_inputhook` path...	diff --git a/Lib/test/test_pyrepl/__init__.py b/Lib/test/test_pyrepl/__init__.py new file mode 100644 index 00000000000..2f37bff6df8 --- /dev/null +++ b/Lib/test/test_pyrepl/__init__.py @@ -0,0 +1,11 @@ +import os +import sys +from test.support import import_helper, load_package_tests + + +if sys.platform != "win32": +...	true
RustPython/RustPython	8,082	issue_to_patch		Bump bitflags from 2.11.1 to 2.12.1	Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.11.1 to 2.12.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bitflags/bitflags/releases">bitflags's releases</a>.</em></p> <blockquote> <h2>2.12.1</h2> <h2>What's Changed</h2> <ul> <li>Rework the <code>#[flag_nam...	65dee6c55cda8606be7dcdca7ed1f95ed2773bbc	f43169f4c0731d1119ab5822afe5f9678c95b7c6	diff --git a/Cargo.lock b/Cargo.lock index 4722e56148..a8b6ef1fee 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -289,7 +289,7 @@ version = "0.71.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "5f58bf3d7db68cfbac37cfc485a8d711e87e064c3d0fe0435b92f7a407f9d6b3" dependencies = [ - "bitflags...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,081	issue_to_patch		Bump libsqlite3-sys from 0.38.0 to 0.38.1	Bumps [libsqlite3-sys](https://github.com/rusqlite/rusqlite) from 0.38.0 to 0.38.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/rusqlite/rusqlite/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp...	65dee6c55cda8606be7dcdca7ed1f95ed2773bbc	cf5ad3664513588950f62a1bd9ee0cac26b71640	diff --git a/Cargo.lock b/Cargo.lock index 4722e56148..5a1645793e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2165,9 +2165,9 @@ dependencies = [ [[package]] name = "libsqlite3-sys" -version = "0.38.0" +version = "0.38.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "a76001fb4daed01...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,080	issue_to_patch		Bump chrono from 0.4.44 to 0.4.45	Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.44 to 0.4.45. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/chronotope/chrono/releases">chrono's releases</a>.</em></p> <blockquote> <h2>0.4.45</h2> <h2>What's Changed</h2> <ul> <li>fix(tz): reject TZ offset hour ...	65dee6c55cda8606be7dcdca7ed1f95ed2773bbc	eef88accd9f5d49edd23595fd06dc778b1588f80	diff --git a/Cargo.lock b/Cargo.lock index 4722e56148..15e323bb53 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -494,9 +494,9 @@ dependencies = [ [[package]] name = "chrono" -version = "0.4.44" +version = "0.4.45" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c673075a2e0e5f4a1dde27ce9...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,079	issue_to_patch		Bump the wasmtime group across 1 directory with 2 updates	Bumps the wasmtime group with 1 update in the / directory: [cranelift-jit](https://github.com/bytecodealliance/wasmtime). Updates `cranelift-jit` from 0.132.0 to 0.132.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bytecodealliance/wasmtime/releases">cranelift-jit's releas...	65dee6c55cda8606be7dcdca7ed1f95ed2773bbc	daf07f87022ad18423c5f2f6aff7f9a5e79db8a3	diff --git a/Cargo.lock b/Cargo.lock index 4722e56148..7db869cefe 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -752,27 +752,27 @@ dependencies = [ [[package]] name = "cranelift-assembler-x64" -version = "0.132.0" +version = "0.132.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8c80...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,078	issue_to_patch		`TODO: Flaky test` -> `TODO: RUSTPYTHON; Flaky test`	https://github.com/RustPython/RustPython/pull/8075/changes#r3396808078	65dee6c55cda8606be7dcdca7ed1f95ed2773bbc	622d638c6aabdf5eb72e6af422dbcb98fae741ac		[ "Lib/test/test_asyncio/test_events.py" ]	[]	diff --git a/Lib/test/test_asyncio/test_events.py b/Lib/test/test_asyncio/test_events.py index 3d6d1825aa..f373483066 100644 --- a/Lib/test/test_asyncio/test_events.py +++ b/Lib/test/test_asyncio/test_events.py @@ -791,7 +791,7 @@ def test_create_connection_local_addr(self): self.assertEqual(port, expected...	true
RustPython/RustPython	8,077	issue_to_patch		Remove redundant `to_owned()` calls	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	65dee6c55cda8606be7dcdca7ed1f95ed2773bbc	2da451393a0f7ca6f6e7073b2d5b1d099a043b3b	diff --git a/crates/capi/src/abstract_.rs b/crates/capi/src/abstract_.rs index 01a3964f728..d01e31e9626 100644 --- a/crates/capi/src/abstract_.rs +++ b/crates/capi/src/abstract_.rs @@ -100,9 +100,7 @@ pub unsafe extern "C" fn PyObject_VectorcallMethod( let args_len = nargsf & !PY_VECTORCALL_ARGUMENTS_OFFSET; ...	[ "crates/capi/src/abstract_.rs", "crates/capi/src/unicodeobject.rs", "crates/stdlib/src/multiprocessing.rs", "crates/stdlib/src/select.rs", "crates/stdlib/src/socket.rs", "crates/stdlib/src/ssl.rs", "crates/vm/src/builtins/code.rs", "crates/vm/src/builtins/function.rs", "crates/vm/src/builtins/list.r...	[]		true
RustPython/RustPython	8,074	issue_to_patch		Bump targeted CPython version to 3.14.6	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	9259d22f811b174e732b6b057b19eb5a758f92a3	dce1b1ecbf7987060db5a1e1793cc71935fe79a1	diff --git a/.github/workflows/upgrade-pylib.md b/.github/workflows/upgrade-pylib.md index 058fc06749..ac71f3d724 100644 --- a/.github/workflows/upgrade-pylib.md +++ b/.github/workflows/upgrade-pylib.md @@ -52,7 +52,7 @@ cache: - cpython-lib- env: - PYTHON_VERSION: "v3.14.4" + PYTHON_VERSION: "v3.14.6" ISS...	[ ".github/workflows/upgrade-pylib.md", ".python-version" ]	[]		true
RustPython/RustPython	8,075	issue_to_patch		Skip flaky asyncio tests	Seen at https://github.com/RustPython/RustPython/actions/runs/27328898631/job/80736214424	9259d22f811b174e732b6b057b19eb5a758f92a3	e93afe344d58535633dd3ac6683aab397516324b		[ "Lib/test/test_asyncio/test_events.py", "Lib/test/test_asyncio/test_subprocess.py" ]	[ { "comment": "Seen at https://github.com/RustPython/RustPython/actions/runs/27331458747/job/80744671194?pr=8075\n\n(this PR)", "path": "Lib/test/test_asyncio/test_events.py", "hunk": "@@ -791,6 +791,7 @@ def test_create_connection_local_addr(self):\n self.assertEqual(port, expected)\n ...	diff --git a/Lib/test/test_asyncio/test_events.py b/Lib/test/test_asyncio/test_events.py index b60c7452f3..3d6d1825aa 100644 --- a/Lib/test/test_asyncio/test_events.py +++ b/Lib/test/test_asyncio/test_events.py @@ -791,6 +791,7 @@ def test_create_connection_local_addr(self): self.assertEqual(port, expected...	true
RustPython/RustPython	8,067	issue_to_patch		Don't skip test in `test_tempfile.py` on all platforms	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	9259d22f811b174e732b6b057b19eb5a758f92a3	38c0a949681df159c9cde2e1ef34477a7844fc14		[ "Lib/test/test_tempfile.py" ]	[ { "comment": "Does this work?\n```suggestion\n @unittest.expectedFailureIf(sys.platform == 'linux', \"TODO: RUSTPYTHON; FileNotFoundError: [Errno 2] No such file or directory: '<LONG_PATH>'\")\n```\n\n___\n\nThen you can add this test to the list of environment polluters on Windows.", "path": "Lib/test/t...	diff --git a/Lib/test/test_tempfile.py b/Lib/test/test_tempfile.py index 1ae8f6b3b2..0e6b9bced3 100644 --- a/Lib/test/test_tempfile.py +++ b/Lib/test/test_tempfile.py @@ -1746,7 +1746,8 @@ def test_cleanup_with_symlink_to_a_directory(self): "were deleted") d2.cleanup() - @unittes...	true
RustPython/RustPython	8,040	issue_to_patch	Deadlock in `iter(callable, sentinel)` when `__eq__` re-enters the same iterator ## Summary `iter(callable, sentinel)` can deadlock if the sentinel comparison executes Python-level `__eq__` code and that `__eq__` re-enters the same iterator. This seems related to #6589. The original reproducer there uses the same ob...	Avoid callable iterator deadlock during sentinel comparison (#8011)	<!-- Thanks for your contribution! --> - [x] Closes #8011 - [x] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary Fixes a deadlock in `iter(callable, sentinel)` when sentinel equality re-enters the same iterator. The comparison now runs outside the ite...	51c97b9311f426eebbfb2fd794aba8ae7835c927	ca61fe1c58dac406114bf28e0280793d8a1cc599	diff --git a/crates/vm/src/builtins/iter.rs b/crates/vm/src/builtins/iter.rs index 322eef15cd1..e9f1516b5bf 100644 --- a/crates/vm/src/builtins/iter.rs +++ b/crates/vm/src/builtins/iter.rs @@ -276,13 +276,22 @@ impl IterNext for PyCallableIterator { let ret = callable.invoke((), vm)?; - // Re-check:...	[ "crates/vm/src/builtins/iter.rs", "extra_tests/snippets/protocol_iternext.py", "extra_tests/snippets/stdlib_json.py" ]	[]		true
RustPython/RustPython	8,072	issue_to_patch		Update some tests to 3.14.5	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	7f75ef1c5572803614e14664f82e6986338254a3	7b04832966b2fbbb976d6842438b8b8cabb15093		[ "Lib/test/test_poll.py", "Lib/test/test_unpack.py", "Lib/test/test_utf8_mode.py" ]	[]	diff --git a/Lib/test/test_poll.py b/Lib/test/test_poll.py index a9bfb755c3..1001b63ec7 100644 --- a/Lib/test/test_poll.py +++ b/Lib/test/test_poll.py @@ -8,7 +8,7 @@ import time import unittest from test.support import ( - cpython_only, requires_subprocess, requires_working_socket + cpython_only, requires_sub...	true
RustPython/RustPython	8,073	issue_to_patch		Don't skip test in `test_typing.py`	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> ref: #7611	7f75ef1c5572803614e14664f82e6986338254a3	4382a79b006604510b252bfffa396306439ebe1a		[ "Lib/test/test_typing.py" ]	[]	diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 50e4912298..ec91f818c9 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -3265,7 +3265,6 @@ def meth2(self, x, y): return True self.assertIsSubclass(NotAProtocolButAnImplicitSubclass2, CallableMembersProto) self.a...	true
RustPython/RustPython	8,070	issue_to_patch		Update `pdb.py` to 3.14.5	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [x] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	7f75ef1c5572803614e14664f82e6986338254a3	1d9d441f3c80a853ad1faef03e4b809fe6f9ecd6	diff --git a/Lib/_pyrepl/types.py b/Lib/_pyrepl/types.py index f9d48b828c7..c5b7ebc1a40 100644 --- a/Lib/_pyrepl/types.py +++ b/Lib/_pyrepl/types.py @@ -1,8 +1,10 @@ from collections.abc import Callable, Iterator -Callback = Callable[[], object] -SimpleContextManager = Iterator[None] -KeySpec = str # like r"\C-c" -...	[ "Lib/_pyrepl/types.py", "Lib/_pyrepl/utils.py", "Lib/pdb.py", "Lib/test/test_pdb.py" ]	[]	diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py new file mode 100644 index 00000000000..8b2806781af --- /dev/null +++ b/Lib/test/test_pdb.py @@ -0,0 +1,5179 @@ +# A test suite for pdb; not very comprehensive at the moment. + +import _colorize +import doctest +import gc +import io +import os +import pdb +import...	true
RustPython/RustPython	8,069	issue_to_patch		Bump shell-quote from 1.8.2 to 1.8.4 in /wasm/demo	Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md">shell-quote's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ljharb/shell-quote/compare/...	9f05508c89f8ae2cdf57dd207980777460e58db6	a349b477931fa2d31b9250b742a2315b4277a55d	diff --git a/wasm/demo/package-lock.json b/wasm/demo/package-lock.json index 14744312ac0..c0ecfc83f18 100644 --- a/wasm/demo/package-lock.json +++ b/wasm/demo/package-lock.json @@ -4849,9 +4849,9 @@ } }, "node_modules/shell-quote": { - "version": "1.8.2", - "resolved...	[ "wasm/demo/package-lock.json" ]	[]		true
RustPython/RustPython	8,068	issue_to_patch		Remove stale patches from `test_traceback.py`	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [x] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	fb422da87ac0d068c3a27174a559d8f2a5e57e09	684b38303145c635ee1721f9c3f8df526a463125		[ "Lib/test/test_traceback.py" ]	[]	diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py index f872af157ca..ec56f26a735 100644 --- a/Lib/test/test_traceback.py +++ b/Lib/test/test_traceback.py @@ -1824,118 +1824,6 @@ class PurePythonTracebackErrorCaretTests( traceback printing in traceback.py. """ - @unittest.expectedFailur...	true
RustPython/RustPython	8,066	issue_to_patch		Conditionally skip `test_pty` tests	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	fb422da87ac0d068c3a27174a559d8f2a5e57e09	7f92d9b0725ed6378fefe95feb094dfd573f6eba		[ "Lib/test/test_pty.py" ]	[]	diff --git a/Lib/test/test_pty.py b/Lib/test/test_pty.py index c12209db555..1126404fee7 100644 --- a/Lib/test/test_pty.py +++ b/Lib/test/test_pty.py @@ -89,6 +89,7 @@ def write_all(fd, data): # Marginal testing of pty suite. Cannot do extensive 'do or fail' testing # because pty code is not too portable. +@unittest...	true
RustPython/RustPython	8,065	issue_to_patch		Fix `test_tty.py` tests	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	d450567f5c5c12cc41f91b8c5e0856c112927996	diff --git a/crates/stdlib/src/termios.rs b/crates/stdlib/src/termios.rs index 9731f33b39f..7a2c2472443 100644 --- a/crates/stdlib/src/termios.rs +++ b/crates/stdlib/src/termios.rs @@ -8,6 +8,7 @@ mod termios { PyObjectRef, PyResult, TryFromObject, VirtualMachine, builtins::{PyBaseExceptionRef, PyByte...	[ "Lib/test/test_termios.py", "Lib/test/test_tty.py", "crates/stdlib/src/termios.rs", "crates/vm/src/stdlib/_io.rs" ]	[]	diff --git a/Lib/test/test_termios.py b/Lib/test/test_termios.py index e7ebb20b120..216609719ac 100644 --- a/Lib/test/test_termios.py +++ b/Lib/test/test_termios.py @@ -32,7 +32,6 @@ def assertRaisesTermiosError(self, err, callable, args): callable(args) self.assertIn(cm.exception.args[0], errs)...	true
RustPython/RustPython	8,064	issue_to_patch		Convert claude skills to more generic agent skills	<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * Documentation * Added new skill-style guides for running tests, investigating test failures, and upgrading stdlib modules. * Removed older command-style documentation that previously covered those same workf...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	224060a3d05d79ebed3a861874e88eb066d6f338	diff --git a/.agents/skills/apple-container/SKILL.md b/.agents/skills/apple-container/SKILL.md new file mode 100644 index 00000000000..fed7ce1e260 --- /dev/null +++ b/.agents/skills/apple-container/SKILL.md @@ -0,0 +1,63 @@ +--- +name: apple-container +description: Run RustPython tests in Apple's `container` CLI Linux ...	[ ".agents/skills/apple-container/SKILL.md", ".agents/skills/investigate-test-failure/SKILL.md", ".agents/skills/upgrade-pylib-next/SKILL.md", ".agents/skills/upgrade-pylib/SKILL.md", ".claude/commands/apple-container.md", ".claude/commands/investigate-test-failure.md", ".claude/commands/upgrade-pylib-nex...	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nAvoid hardcoded host-specific workspace path in container mount.\n\n`source=/Users/al03219714/Projects/RustPython3` will fail on other machines and makes this skill non-reusable. Use a dynamic path (for example, current repo root) in the doc...		true
RustPython/RustPython	8,064	comment_to_fix		Convert claude skills to more generic agent skills	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Avoid hardcoded host-specific workspace path in container mount. `source=/Users/al03219714/Projects/RustPython3` will fail on other machines and makes this skill non-reusable. Use a dynamic path (for example, current repo root) in the documented command. <details...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	224060a3d05d79ebed3a861874e88eb066d6f338	diff --git a/.agents/skills/apple-container/SKILL.md b/.agents/skills/apple-container/SKILL.md new file mode 100644 index 00000000000..fed7ce1e260 --- /dev/null +++ b/.agents/skills/apple-container/SKILL.md @@ -0,0 +1,63 @@ +--- +name: apple-container +description: Run RustPython tests in Apple's `container` CLI Linux ...	[ ".agents/skills/apple-container/SKILL.md" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nAvoid hardcoded host-specific workspace path in container mount.\n\n`source=/Users/al03219714/Projects/RustPython3` will fail on other machines and makes this skill non-reusable. Use a dynamic path (for example, current repo root) in the doc...		true
RustPython/RustPython	8,064	comment_to_fix		Convert claude skills to more generic agent skills	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Do not interpolate test args through `sh -c`; this enables command injection. Using `sh -c "... <test-args>"` allows shell metacharacters in user-provided args. Because `/workspace` is bind-mounted, injected commands can alter host repo files. Document a shell-saf...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	224060a3d05d79ebed3a861874e88eb066d6f338	diff --git a/.agents/skills/apple-container/SKILL.md b/.agents/skills/apple-container/SKILL.md new file mode 100644 index 00000000000..fed7ce1e260 --- /dev/null +++ b/.agents/skills/apple-container/SKILL.md @@ -0,0 +1,63 @@ +--- +name: apple-container +description: Run RustPython tests in Apple's `container` CLI Linux ...	[ ".agents/skills/apple-container/SKILL.md" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nDo not interpolate test args through `sh -c`; this enables command injection.\n\nUsing `sh -c \"... <test-args>\"` allows shell metacharacters in user-provided args. Because `/workspace` is bind-mounted, injected commands can alter host repo...		true
RustPython/RustPython	8,064	comment_to_fix		Convert claude skills to more generic agent skills	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Permit `gh issue create` in `allowed-tools` (or remove the command from the workflow). The skill includes a concrete `gh issue create` command, but metadata does not allow it. Under tool gating, that step cannot run. <details> <summary>Suggested fix</summary> ``...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	224060a3d05d79ebed3a861874e88eb066d6f338	diff --git a/.agents/skills/investigate-test-failure/SKILL.md b/.agents/skills/investigate-test-failure/SKILL.md new file mode 100644 index 00000000000..e63dfeeec1b --- /dev/null +++ b/.agents/skills/investigate-test-failure/SKILL.md @@ -0,0 +1,53 @@ +--- +name: investigate-test-failure +description: Investigate a fail...	[ ".agents/skills/investigate-test-failure/SKILL.md" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nPermit `gh issue create` in `allowed-tools` (or remove the command from the workflow).\n\nThe skill includes a concrete `gh issue create` command, but metadata does not allow it. Under tool gating, that step cannot run.\n\n<details>\n<summar...		true
RustPython/RustPython	8,064	comment_to_fix		Convert claude skills to more generic agent skills	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Add `cargo run` to `allowed-tools` to match the documented workflow. The workflow uses `cargo run` (Line 16), but metadata does not permit it. This can block execution in tool-restricted runs. <details> <summary>Suggested fix</summary> ```diff -allowed-tools: Sk...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	224060a3d05d79ebed3a861874e88eb066d6f338	diff --git a/.agents/skills/upgrade-pylib-next/SKILL.md b/.agents/skills/upgrade-pylib-next/SKILL.md new file mode 100644 index 00000000000..e68e7316509 --- /dev/null +++ b/.agents/skills/upgrade-pylib-next/SKILL.md @@ -0,0 +1,34 @@ +--- +name: upgrade-pylib-next +description: Pick the next CPython stdlib module ready ...	[ ".agents/skills/upgrade-pylib-next/SKILL.md" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nAdd `cargo run` to `allowed-tools` to match the documented workflow.\n\nThe workflow uses `cargo run` (Line 16), but metadata does not permit it. This can block execution in tool-restricted runs.\n\n<details>\n<summary>Suggested fix</summary...		true
RustPython/RustPython	8,064	comment_to_fix		Convert claude skills to more generic agent skills	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ `allowed-tools` is missing commands required by the documented steps. The workflow requires `git diff` and `cargo run`, but they are not permitted in metadata. This can make core steps non-runnable under enforcement. <details> <summary>Suggested fix</summary> ``...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	224060a3d05d79ebed3a861874e88eb066d6f338	diff --git a/.agents/skills/upgrade-pylib/SKILL.md b/.agents/skills/upgrade-pylib/SKILL.md new file mode 100644 index 00000000000..84400e5b7a2 --- /dev/null +++ b/.agents/skills/upgrade-pylib/SKILL.md @@ -0,0 +1,102 @@ +--- +name: upgrade-pylib +description: Upgrade a Python standard library module from CPython into Ru...	[ ".agents/skills/upgrade-pylib/SKILL.md" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\n`allowed-tools` is missing commands required by the documented steps.\n\nThe workflow requires `git diff` and `cargo run`, but they are not permitted in metadata. This can make core steps non-runnable under enforcement.\n\n<details>\n<summar...		true
RustPython/RustPython	8,061	issue_to_patch		Bump https://github.com/astral-sh/ruff-pre-commit from v0.15.14 to 0.15.15	Bumps [https://github.com/astral-sh/ruff-pre-commit](https://github.com/astral-sh/ruff-pre-commit) from v0.15.14 to 0.15.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff-pre-commit/releases">https://github.com/astral-sh/ruff-pre-commit's releases</a>.</em></p...	51c97b9311f426eebbfb2fd794aba8ae7835c927	ef543193d2fa152eb5ccd07373d949eae3d1a0ea	diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index db3b9a58302..fd879f2ac56 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -10,7 +10,7 @@ repos: priority: 0 - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.15.14 + rev: v0.15.15 hooks: ...	[ ".pre-commit-config.yaml" ]	[]		true
RustPython/RustPython	8,063	issue_to_patch		Skip flakey windows test	Seen at: https://github.com/RustPython/RustPython/actions/runs/27190506865/job/80269325800	fb422da87ac0d068c3a27174a559d8f2a5e57e09	3233cb44ad7e302ba40cc629678ab7a8e5fc496c		[ "Lib/test/test_asyncio/test_sendfile.py" ]	[]	diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py index e266d57742a..766e6f49984 100644 --- a/Lib/test/test_asyncio/test_sendfile.py +++ b/Lib/test/test_asyncio/test_sendfile.py @@ -548,6 +548,10 @@ class ProactorEventLoopTests(SendfileTestsBase, def create_event_loop...	true
RustPython/RustPython	8,062	issue_to_patch		Bump github/gh-aw from 0.76.1 to 0.77.5	Bumps [github/gh-aw](https://github.com/github/gh-aw) from 0.76.1 to 0.77.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/gh-aw/releases">github/gh-aw's releases</a>.</em></p> <blockquote> <h2>v0.77.5</h2> <h2>🌟 Release Highlights</h2> <p>This release tightens the d...	51c97b9311f426eebbfb2fd794aba8ae7835c927	134c7fbf3eb63e7b64f29c07617828e018d6902e	diff --git a/.github/workflows/upgrade-pylib.lock.yml b/.github/workflows/upgrade-pylib.lock.yml index 23e6c7ac2de..aa1ec98e23f 100644 --- a/.github/workflows/upgrade-pylib.lock.yml +++ b/.github/workflows/upgrade-pylib.lock.yml @@ -58,7 +58,7 @@ jobs: comment_repo: "" steps: - name: Setup Scripts - ...	[ ".github/workflows/upgrade-pylib.lock.yml" ]	[]		true
RustPython/RustPython	8,060	issue_to_patch		Bump taiki-e/install-action from 2.79.10 to 2.81.1	Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.79.10 to 2.81.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p> <blockquote> <h2>2.81.1</h2> <ul> <li> <p>Update <...	51c97b9311f426eebbfb2fd794aba8ae7835c927	c377e8dee7eb49d008e493daf7296da05fe4d252	diff --git a/.github/workflows/cron-ci.yaml b/.github/workflows/cron-ci.yaml index 1bb2d66abb4..2c0e258821b 100644 --- a/.github/workflows/cron-ci.yaml +++ b/.github/workflows/cron-ci.yaml @@ -33,7 +33,7 @@ jobs: - uses: dtolnay/rust-toolchain@stable - - uses: taiki-e/install-action@60ae4ce63c7aeb6e96d7...	[ ".github/workflows/cron-ci.yaml" ]	[]		true
RustPython/RustPython	8,059	issue_to_patch		Add `_heapq` module	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	7ed324d12e639d886eff63f7ffef91224576df94	diff --git a/crates/stdlib/src/_heapq.rs b/crates/stdlib/src/_heapq.rs new file mode 100644 index 00000000000..1b416a47434 --- /dev/null +++ b/crates/stdlib/src/_heapq.rs @@ -0,0 +1,529 @@ +// cspell:ignore siftup siftdown mhalf +pub(crate) use _heapq::module_def; + +#[pymodule] +mod _heapq { + + use crate::vm::{ + ...	[ "crates/stdlib/src/_heapq.rs", "crates/stdlib/src/lib.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nMissing size change check after comparison.\n\nThe `rich_compare_bool` call (line 232) invokes user code that could modify the list. CPython's `heappushpop` checks for size change after comparison before proceeding:\n\n```c\nif (n != PyList_...		true
RustPython/RustPython	8,058	issue_to_patch		Code nitpicks	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	51c97b9311f426eebbfb2fd794aba8ae7835c927	11305fa12662069025c76b03afd71c9a706e2492	diff --git a/crates/stdlib/src/array.rs b/crates/stdlib/src/array.rs index f3cd601c771..e5f8e11a0a0 100644 --- a/crates/stdlib/src/array.rs +++ b/crates/stdlib/src/array.rs @@ -882,10 +882,7 @@ pub mod array { self._from_bytes(b.as_bytes(), itemsize, vm)?; if not_enough_bytes { - ...	[ "crates/stdlib/src/array.rs", "crates/stdlib/src/multiprocessing.rs", "crates/stdlib/src/ssl.rs", "crates/vm/src/builtins/int.rs", "crates/vm/src/builtins/interpolation.rs", "crates/vm/src/frame.rs", "crates/vm/src/protocol/buffer.rs", "crates/vm/src/protocol/callable.rs", "crates/vm/src/protocol/it...	[ { "comment": "_⚠️ Potential issue_ \| _🟡 Minor_ \| _⚡ Quick win_\n\nConsider aligning error message with CPython's wording.\n\nCPython's `functools.reduce` uses \"empty iterable\" rather than \"empty sequence\" in this error message. Using \"iterable\" would improve CPython compatibility and better m...		true
RustPython/RustPython	8,058	comment_to_fix		Code nitpicks	_⚠️ Potential issue_ \| _🟡 Minor_ \| _⚡ Quick win_ Consider aligning error message with CPython's wording. CPython's `functools.reduce` uses "empty iterable" rather than "empty sequence" in this error message. Using "iterable" would improve CPython compatibility and better match the parameter type (`PyIter...	51c97b9311f426eebbfb2fd794aba8ae7835c927	11305fa12662069025c76b03afd71c9a706e2492	diff --git a/crates/vm/src/stdlib/_functools.rs b/crates/vm/src/stdlib/_functools.rs index 3007a4d12a0..7c6914c2fb4 100644 --- a/crates/vm/src/stdlib/_functools.rs +++ b/crates/vm/src/stdlib/_functools.rs @@ -44,11 +44,7 @@ mod _functools { } else { // initial was not provided at all ...	[ "crates/vm/src/stdlib/_functools.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟡 Minor_ \| _⚡ Quick win_\n\nConsider aligning error message with CPython's wording.\n\nCPython's `functools.reduce` uses \"empty iterable\" rather than \"empty sequence\" in this error message. Using \"iterable\" would improve CPython compatibility and better m...		true
RustPython/RustPython	8,042	issue_to_patch		Add more object functions to c-api	<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * New Features * Expanded C-API for object introspection and operations: attribute access, type/module info, callable checks, rich comparisons, directory listing, weak-ref clearing, and generic dict get/set for ...	51c97b9311f426eebbfb2fd794aba8ae7835c927	93319633e431fdedafdcfd759caecd85d43904a6	diff --git a/crates/capi/src/object.rs b/crates/capi/src/object.rs index 9866d9041f9..5e601d3817d 100644 --- a/crates/capi/src/object.rs +++ b/crates/capi/src/object.rs @@ -1,9 +1,11 @@ use crate::PyObject; use crate::pystate::with_vm; -use core::ffi::{CStr, c_char, c_int, c_uint, c_ulong}; +use core::ffi::{CStr, c_c...	[ "crates/capi/src/object.rs", "crates/vm/src/builtins/mod.rs", "crates/vm/src/builtins/object.rs", "crates/vm/src/object/core.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🔴 Critical_ \| _⚡ Quick win_\n\nHandle `obj == NULL` in `PyObject_Dir`. \n`crates/capi/src/object.rs` (lines 273-279) dereferences `obj` unconditionally (`unsafe { &*obj }`), but CPython allows `PyObject_Dir(NULL)` and uses it to emulate `dir()`/locals behavior (return...		true
RustPython/RustPython	8,042	comment_to_fix		Add more object functions to c-api	_⚠️ Potential issue_ \| _🔴 Critical_ \| _⚡ Quick win_ Handle `obj == NULL` in `PyObject_Dir`. `crates/capi/src/object.rs` (lines 273-279) dereferences `obj` unconditionally (`unsafe { &*obj }`), but CPython allows `PyObject_Dir(NULL)` and uses it to emulate `dir()`/locals behavior (returning `NULL` without settin...	51c97b9311f426eebbfb2fd794aba8ae7835c927	93319633e431fdedafdcfd759caecd85d43904a6	diff --git a/crates/capi/src/object.rs b/crates/capi/src/object.rs index 9866d9041f9..5e601d3817d 100644 --- a/crates/capi/src/object.rs +++ b/crates/capi/src/object.rs @@ -1,9 +1,11 @@ use crate::PyObject; use crate::pystate::with_vm; -use core::ffi::{CStr, c_char, c_int, c_uint, c_ulong}; +use core::ffi::{CStr, c_c...	[ "crates/capi/src/object.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🔴 Critical_ \| _⚡ Quick win_\n\nHandle `obj == NULL` in `PyObject_Dir`. \n`crates/capi/src/object.rs` (lines 273-279) dereferences `obj` unconditionally (`unsafe { &*obj }`), but CPython allows `PyObject_Dir(NULL)` and uses it to emulate `dir()`/locals behavior (return...		true
RustPython/RustPython	8,042	comment_to_fix		Add more object functions to c-api	_⚠️ Potential issue_ \| _🔴 Critical_ \| _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell # Find the function definition for object_generic_set_dict rg -A 20 "fn object_generic_set_dict" --type rs ``` Repository: RustPython/RustPython Length of output: 92 --- 🏁 Script exec...	51c97b9311f426eebbfb2fd794aba8ae7835c927	93319633e431fdedafdcfd759caecd85d43904a6	diff --git a/crates/capi/src/object.rs b/crates/capi/src/object.rs index 9866d9041f9..5e601d3817d 100644 --- a/crates/capi/src/object.rs +++ b/crates/capi/src/object.rs @@ -1,9 +1,11 @@ use crate::PyObject; use crate::pystate::with_vm; -use core::ffi::{CStr, c_char, c_int, c_uint, c_ulong}; +use core::ffi::{CStr, c_c...	[ "crates/capi/src/object.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🔴 Critical_ \| _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# Find the function definition for object_generic_set_dict\nrg -A 20 \"fn object_generic_set_dict\" --type rs\n```\n\nRepository: RustPython/RustPython\n\nLen...		true
RustPython/RustPython	8,043	issue_to_patch		Add more dict functions to c-api	<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * New Features * Expanded Python C API compatibility with additional dictionary operations: membership testing, copying, item deletion, accessing keys/values/items, and flexible dictionary merging with configur...	51c97b9311f426eebbfb2fd794aba8ae7835c927	e7432546a2a7f5c258d2e1a73a9706706db8fd48	diff --git a/crates/capi/src/dictobject.rs b/crates/capi/src/dictobject.rs index dc5dd58485e..ebc4a827f36 100644 --- a/crates/capi/src/dictobject.rs +++ b/crates/capi/src/dictobject.rs @@ -4,6 +4,7 @@ use crate::pystate::with_vm; use core::ffi::c_int; use core::ptr::NonNull; use rustpython_vm::AsObject; +use rustpyt...	[ "crates/capi/src/dictobject.rs", "crates/vm/src/builtins/dict.rs" ]	[]		true
RustPython/RustPython	8,044	issue_to_patch		Add more unicode functions to c-api	<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * New Features * Added support for additional Python C-API Unicode entrypoints to improve UTF-8 handling, filesystem-encoding conversion, and encoded-object conversion for C extensions * Tests * Added tes...	51c97b9311f426eebbfb2fd794aba8ae7835c927	c832e32565564e08b36841dd1876bfa766d026c6	diff --git a/crates/capi/src/unicodeobject.rs b/crates/capi/src/unicodeobject.rs index 76e0fb0df58..3eb1e153558 100644 --- a/crates/capi/src/unicodeobject.rs +++ b/crates/capi/src/unicodeobject.rs @@ -1,6 +1,5 @@ -use crate::PyObject; use crate::object::define_py_check; -use crate::pystate::with_vm; +use crate::{PyObj...	[ "crates/capi/src/unicodeobject.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nPreserve `try_bytes_like()` errors instead of rewriting them as `\"not str\"`.\n\nThe explicit `PyStr` check at Lines 160-162 is fine, but Lines 189-191 currently remap every `try_bytes_like()` failure to the same `TypeError`. That makes n...		true
RustPython/RustPython	8,044	comment_to_fix		Add more unicode functions to c-api	_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_ Preserve `try_bytes_like()` errors instead of rewriting them as `"not str"`. The explicit `PyStr` check at Lines 160-162 is fine, but Lines 189-191 currently remap every `try_bytes_like()` failure to the same `TypeError`. That makes non-`str` inputs report the w...	51c97b9311f426eebbfb2fd794aba8ae7835c927	c832e32565564e08b36841dd1876bfa766d026c6	diff --git a/crates/capi/src/unicodeobject.rs b/crates/capi/src/unicodeobject.rs index 76e0fb0df58..3eb1e153558 100644 --- a/crates/capi/src/unicodeobject.rs +++ b/crates/capi/src/unicodeobject.rs @@ -1,6 +1,5 @@ -use crate::PyObject; use crate::object::define_py_check; -use crate::pystate::with_vm; +use crate::{PyObj...	[ "crates/capi/src/unicodeobject.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nPreserve `try_bytes_like()` errors instead of rewriting them as `\"not str\"`.\n\nThe explicit `PyStr` check at Lines 160-162 is fine, but Lines 189-191 currently remap every `try_bytes_like()` failure to the same `TypeError`. That makes n...		true
RustPython/RustPython	8,045	issue_to_patch		Add more list functions to the c-api	<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * New Features * Expanded list manipulation capabilities with four new C-API functions enabling list-to-tuple conversion, slice retrieval, slice modification, and list sorting. * Tests * Reorganized and ...	51c97b9311f426eebbfb2fd794aba8ae7835c927	073cd030e77d015fc5bfe3fd4ce4e301aa7af63a	diff --git a/crates/capi/src/listobject.rs b/crates/capi/src/listobject.rs index 1f70e37b651..796720f99d7 100644 --- a/crates/capi/src/listobject.rs +++ b/crates/capi/src/listobject.rs @@ -3,8 +3,10 @@ use crate::object::define_py_check; use crate::pystate::with_vm; use core::ffi::c_int; use core::ptr::NonNull; +use...	[ "crates/capi/src/listobject.rs" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Locate the implementation and inspect surrounding code\nFILE=\"crates/capi/src/listobject.rs\"\nnl -ba \"$FILE\" \| sed -n '13...		true
RustPython/RustPython	8,057	issue_to_patch		`scripts/update_lib migrate` to preserve patches on classes	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Previously, patc...	51c97b9311f426eebbfb2fd794aba8ae7835c927	2bf0b6ae23cbffff997f8f97e9daf891a4e819d6	diff --git a/scripts/update_lib/patch_spec.py b/scripts/update_lib/patch_spec.py index 565d01e3e00..996b78bfa18 100644 --- a/scripts/update_lib/patch_spec.py +++ b/scripts/update_lib/patch_spec.py @@ -6,9 +6,13 @@ - Applying patches to test files (JSON -> file) """ +from __future__ import annotations + import ast ...	[ "scripts/update_lib/patch_spec.py", "scripts/update_lib/tests/test_patch_spec.py" ]	[ { "comment": "_⚠️ Potential issue_ \| _🟠 Major_ \| _⚡ Quick win_\n\nHandle keyword-based conditional decorators without crashing.\n\nLine 142 assumes a positional condition (`node.args[0]`). Valid forms like `@unittest.skipIf(condition=..., reason=...)` make `node.args` empty and raise `IndexError` during ex...	diff --git a/scripts/update_lib/tests/test_patch_spec.py b/scripts/update_lib/tests/test_patch_spec.py index 2598d25b354..92a0a35a153 100644 --- a/scripts/update_lib/tests/test_patch_spec.py +++ b/scripts/update_lib/tests/test_patch_spec.py @@ -345,6 +345,32 @@ def test_one(self): self.assertIn("@unittest.expe...	true
RustPython/RustPython	8,054	issue_to_patch		Update `test_code.py` to 3.14.5	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? -->	51c97b9311f426eebbfb2fd794aba8ae7835c927	1ec2ff3b0e51455e28cb8e80734bdd0c7e8a60bf		[ "Lib/test/test_code.py", "Lib/test/test_thread.py" ]	[]	diff --git a/Lib/test/test_code.py b/Lib/test/test_code.py index 6602c24353f..6ce64109fba 100644 --- a/Lib/test/test_code.py +++ b/Lib/test/test_code.py @@ -215,7 +215,7 @@ from test.support import threading_helper, import_helper from test.support.bytecode_helper import instructions_with_positions from opcode import...	true
RustPython/RustPython	8,053	issue_to_patch		Add `_blake2` consts	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	51c97b9311f426eebbfb2fd794aba8ae7835c927	492a55eb9a10694cb3b08e9d1b767882f4c50f3f	diff --git a/crates/stdlib/src/blake2.rs b/crates/stdlib/src/blake2.rs index 53687c7027a..382aec826b1 100644 --- a/crates/stdlib/src/blake2.rs +++ b/crates/stdlib/src/blake2.rs @@ -7,6 +7,33 @@ mod _blake2 { use crate::hashlib::_hashlib::{BlakeHashArgs, local_blake2b, local_blake2s}; use crate::vm::{PyPayload...	[ "Lib/test/test_hashlib.py", "crates/stdlib/src/blake2.rs" ]	[]	diff --git a/Lib/test/test_hashlib.py b/Lib/test/test_hashlib.py index 5c38813f3f5..47e2079fe48 100644 --- a/Lib/test/test_hashlib.py +++ b/Lib/test/test_hashlib.py @@ -127,8 +127,11 @@ def __init__(self, args, *kwargs): algorithms.add(algorithm.lower()) _blake2 = self._conditional_import_modu...	true
RustPython/RustPython	8,050	issue_to_patch		more clippy rules	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	fb422da87ac0d068c3a27174a559d8f2a5e57e09	c882cffd036bcb4649b5d7cb78badc0df40acab8	diff --git a/Cargo.toml b/Cargo.toml index eda23858f3c..2cd468d07bd 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -368,6 +368,10 @@ tests_outside_test_module = "warn" debug_assert_with_mut_call = "warn" derive_partial_eq_without_eq = "warn" imprecise_flops = "warn" +iter_on_empty_collections = "warn" +iter_on_single_i...	[ "Cargo.toml", "crates/capi/src/traceback.rs", "crates/common/src/boxvec.rs", "crates/common/src/cformat.rs", "crates/derive-impl/src/pyclass.rs", "crates/jit/src/instructions.rs", "crates/sre_engine/src/string.rs", "crates/stdlib/src/_asyncio.rs", "crates/vm/src/builtins/dict.rs", "crates/vm/src/b...	[]		true
RustPython/RustPython	8,049	issue_to_patch		Bump rustls-native-certs from 0.8.3 to 0.8.4	Bumps [rustls-native-certs](https://github.com/rustls/rustls-native-certs) from 0.8.3 to 0.8.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rustls/rustls-native-certs/releases">rustls-native-certs's releases</a>.</em></p> <blockquote> <h2>0.8.4</h2> <h2>What's Changed</h2>...	51c97b9311f426eebbfb2fd794aba8ae7835c927	bd9a110cfc9c1affcc3704d5afe66610c1a5a82d	diff --git a/Cargo.lock b/Cargo.lock index 55afb99b02d..371be6f9d78 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -100,7 +100,7 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc" dependencies = [ - "windows...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,047	issue_to_patch		Bump lz4_flex from 0.13.0 to 0.13.1	Bumps [lz4_flex](https://github.com/pseitz/lz4_flex) from 0.13.0 to 0.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pseitz/lz4_flex/releases">lz4_flex's releases</a>.</em></p> <blockquote> <h2>0.13.1</h2> <h2>What's Changed</h2> <ul> <li>Fix panic in From<a href="io::E...	51c97b9311f426eebbfb2fd794aba8ae7835c927	1dc31c32842cd96b95b06003c940a82a4753d6f5	diff --git a/Cargo.lock b/Cargo.lock index 55afb99b02d..bd19334b5b0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2212,9 +2212,9 @@ checksum = "113b30b4cd05f7c06868fdb2854f66a7b9fece9a48425351cd532e810d74024f" [[package]] name = "lz4_flex" -version = "0.13.0" +version = "0.13.1" source = "registry+https://github.co...	[ "Cargo.lock" ]	[]		true
RustPython/RustPython	8,046	issue_to_patch		Bump uuid from 1.23.1 to 1.23.2	Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.23.1 to 1.23.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uuid-rs/uuid/releases">uuid's releases</a>.</em></p> <blockquote> <h2>v1.23.2</h2> <h2>What's Changed</h2> <ul> <li>Improve error messages for ambiguous formats...	51c97b9311f426eebbfb2fd794aba8ae7835c927	14c1e70687795ea8e6c9ecfd1d318b129301410e	diff --git a/Cargo.lock b/Cargo.lock index 55afb99b02d..767b575382e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4726,9 +4726,9 @@ checksum = "06abde3611657adf66d383f00b093d7faecc7fa57071cce2578660c9f1010821" [[package]] name = "uuid" -version = "1.23.1" +version = "1.23.2" source = "registry+https://github.com/ru...	[ "Cargo.lock", "Cargo.toml" ]	[]		true
RustPython/RustPython	8,041	issue_to_patch		General code nits	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	51c97b9311f426eebbfb2fd794aba8ae7835c927	9d02178a71f9a00f0868d8a1eb2c5cf5c2ff39ae	diff --git a/crates/stdlib/src/binascii.rs b/crates/stdlib/src/binascii.rs index 5deae90d5a1..bbeaa331e4c 100644 --- a/crates/stdlib/src/binascii.rs +++ b/crates/stdlib/src/binascii.rs @@ -2,6 +2,8 @@ pub(super) use decl::crc32; pub(crate) use decl::module_def; + +use rustpython_common::wtf8::Wtf8Buf; use rustpyth...	[ "crates/stdlib/src/binascii.rs", "crates/stdlib/src/unicodedata.rs", "crates/vm/src/builtins/dict.rs", "crates/vm/src/builtins/list.rs", "crates/vm/src/stdlib/_collections.rs", "crates/vm/src/stdlib/_io.rs", "crates/vm/src/stdlib/_thread.rs", "crates/vm/src/stdlib/_weakref.rs", "crates/vm/src/stdlib...	[ { "comment": "_⚠️ Potential issue_ \| _🟡 Minor_ \| _⚡ Quick win_\n\nPreserve exact CPython-readable/writable error text (trailing period).\n\nLine 366 and Lines 5588/5646/5681 use messages without the trailing `.` in some readable/writable UnsupportedOperation paths. That diverges from CPython’s `_pyio` text...		true
RustPython/RustPython	8,034	issue_to_patch		Add `set_attrs!` macro for setting multiple attributes on an object	<!-- Thanks for your contribution! --> - [ ] Closes #xxxx <!-- Replace xxxx with the GitHub issue number --> - [ ] This PR follows our [AI policy](https://github.com/RustPython/.github/blob/main/AI_POLICY.md) ## Summary <!-- What's the purpose of the change? What does it do, and why? --> <!-- This is an ...	51c97b9311f426eebbfb2fd794aba8ae7835c927	ae7770bae0688ba79c4fc4f966561ea177077d7b	diff --git a/crates/vm/src/exceptions.rs b/crates/vm/src/exceptions.rs index b91e567e731..cf83b416f99 100644 --- a/crates/vm/src/exceptions.rs +++ b/crates/vm/src/exceptions.rs @@ -1593,6 +1593,7 @@ pub(super) mod types { }, convert::ToPyResult, function::{ArgBytesLike, FuncArgs, KwArgs}, + ...	[ "crates/vm/src/exceptions.rs", "crates/vm/src/protocol/object.rs", "crates/vm/src/stdlib/_ctypes/simple.rs", "crates/vm/src/vm/vm_new.rs" ]	[ { "comment": "I like this macro, but `=>` is looking a bit awkward to me. is there other options that can show this is not a match flow?", "path": "crates/vm/src/stdlib/_ctypes/simple.rs", "hunk": "@@ -605,12 +607,11 @@ fn create_swapped_types(\n // c_char (c), c_byte (b), c_ubyte (B)\n let sing...		true
SAFE-Stack/SAFE-BookStore	453	issue_to_patch		Bump vite from 5.0.13 to 5.4.6	Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.4.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/releases">vite's releases</a>.</em></p> <blockquote> <h2>create-vite@5.4.0</h2> <p>Please refer to <a href="https://github.com...	9b47813bb75cf06c55efe47f557a08dbde594d2e	49a6ae300b732f18f80a67451049269aa934cade	diff --git a/package-lock.json b/package-lock.json index 9e2f25b0..13e46f43 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,7 +20,7 @@ "remotedev": "^0.2.9", "sass": "^1.69.5", "tailwindcss": "^3.3.5", - "vite": "^5.0.13" + "...	[ "package-lock.json", "package.json" ]	[]		true
SAFE-Stack/SAFE-BookStore	452	issue_to_patch		Bump vite from 5.0.12 to 5.0.13	Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.12 to 5.0.13. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v5.0.13/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- raw HTML omitted -->5.0.13 (2024-03...	2d3dddb944df0d0576bcee0ffe8d93c5522f91b1	1b0913c1643d3c767aabf658aa3cee780778bc0d	diff --git a/package-lock.json b/package-lock.json index 1947709b..9e2f25b0 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,7 +20,7 @@ "remotedev": "^0.2.9", "sass": "^1.69.5", "tailwindcss": "^3.3.5", - "vite": "^5.0.12" + "...	[ "package-lock.json", "package.json" ]	[]		true
SAFE-Stack/SAFE-BookStore	451	issue_to_patch		Use elmish	in response to #448: * Use UseElmish hook for pages instead of passing messages on from index	61b8777694bd7d6763af158d3b2a13a7df16e57e	04f6f5a6aefd35c89af823cabae4cf0eaec370f2	diff --git a/package-lock.json b/package-lock.json index ce1e6047..1947709b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7,7 +7,8 @@ "dependencies": { "react": "^18.2.0", "react-dom": "^18.2.0", - "sweetalert2": "^8.19.1" + "swee...	[ "package-lock.json", "package.json", "paket.dependencies", "paket.lock", "src/Client/Index.fs", "src/Client/pages/Home.fs", "src/Client/pages/Login.fs", "src/Client/pages/WishList.fs", "src/Client/paket.references" ]	[]		true
SAFE-Stack/SAFE-BookStore	440	issue_to_patch		updated readme for the v5 release		61b8777694bd7d6763af158d3b2a13a7df16e57e	bcd1fbbfd67adae1b3e0cc101a341522c32d920a	diff --git a/README.md b/README.md index 2cca3a3c..5bafffe4 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,21 @@ -# SAFE Template +# Introducing SAFE Bookstore -This template can be used to generate a full-stack web application using the [SAFE Stack](https://safe-stack.github.io/). It was created using the dotnet...	[ "README.md" ]	[]		true
SAFE-Stack/SAFE-BookStore	446	issue_to_patch		Bump vite from 5.0.5 to 5.0.12	Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.5 to 5.0.12. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v5.0.12/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- raw HTML omitted -->5.0.12 (2024-01-...	313a49f068d2ac58890b8a22806597815b4f2ff8	c8925d5177366604704dfac386b8e24f94346dc1	diff --git a/package-lock.json b/package-lock.json index e9af1b52..9841aa46 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19,7 +19,7 @@ "remotedev": "^0.2.9", "sass": "^1.69.5", "tailwindcss": "^3.3.5", - "vite": "^5.0.5" + "v...	[ "package-lock.json", "package.json" ]	[]		true
SAFE-Stack/SAFE-BookStore	447	issue_to_patch		Bump nanoid and mocha	Bumps [nanoid](https://github.com/ai/nanoid) to 3.3.7 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `nanoid` from 3.1.20 to 3.3.7 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ai/nanoid/blob/ma...	313a49f068d2ac58890b8a22806597815b4f2ff8	5d83d1e434e52c5733b102a533318405a330e298	diff --git a/package-lock.json b/package-lock.json index e9af1b52..f4123eac 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14,7 +14,7 @@ "@vitejs/plugin-react": "^4.2.0", "autoprefixer": "^10.4.16", "daisyui": "^4.6.0", - "mocha": "^8.3.2", +...	[ "package-lock.json", "package.json" ]	[]		true
SAFE-Stack/SAFE-BookStore	449	issue_to_patch		Point build and test at the correct directory		313a49f068d2ac58890b8a22806597815b4f2ff8	453aec91c36a797f4e08465cf3e92e6958199d80	diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index c6851e05..30625f68 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -12,20 +12,17 @@ jobs: steps: - uses: actions/checkout@v4 - + - name: Setup .NET uses: actions...	[ ".github/workflows/build-test.yml", ".paket/Paket.Restore.targets" ]	[]		true
SAFE-Stack/SAFE-BookStore	432	issue_to_patch		Safe v5 update	Created an update folder with a fresh SAFE stack v5 template inside. Have ported across the whole Client project and fixed references. Also have moved the Shared code that was in Server, across to its own Shared project. All view code in the Client needs updating as it is currently old school Fable.React.	1fee68b1bb0e2400215d3770b202f1db74719a28	be35cc94fb88421a597cd620fbc65808e1472251	diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json new file mode 100644 index 00000000..cb727877 --- /dev/null +++ b/.config/dotnet-tools.json @@ -0,0 +1,30 @@ +{ + "version": 1, + "isRoot": true, + "tools": { + "paket": { + "version": "8.0.0", + "commands": [ + "paket" + ] +...	[ ".config/dotnet-tools.json", ".editorconfig", ".fantomasignore", ".gitattributes", ".github/workflows/build-test.yml", ".github/workflows/deploy.yml", ".gitignore", ".npmrc", ".paket/Paket.Restore.targets", ".paket/paket.exe", ".vscode/extensions.json", ".vscode/launch.json", ".vscode/settin...	[]	diff --git a/test/ServerTests/Program.fs b/test/ServerTests/Program.fs deleted file mode 100644 index 0363fc3b..00000000 --- a/test/ServerTests/Program.fs +++ /dev/null @@ -1,7 +0,0 @@ -module ServerTests.TestsRunner - -open Expecto - -[<EntryPoint>] -let main args = - runTestsWithArgs { defaultConfig with ``paralle...	true
SAFE-Stack/SAFE-BookStore	400	issue_to_patch		#399	Don't serve the static index.html in development	ad1f99f83ed738aa6ab6ab93916051753678c73d	1e1c392e84649c12ab92842448446f77acbb664a	diff --git a/src/Client/index.html b/src/Client/index.html deleted file mode 100644 index 0043a717..00000000 --- a/src/Client/index.html +++ /dev/null @@ -1,16 +0,0 @@ -<!doctype html> -<html lang="en-US"> -<head> - <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> - <title>SAFE-Stack Bookstore</tit...	[ "src/Client/index.html", "src/Client/webpack.config.js" ]	[]		true
SAFE-Stack/SAFE-BookStore	398	issue_to_patch		Saving wishlist failed	The posts for adding or removing books went to `/api/wishlist/{username}`, but resulted in 404 since `post "/api/wishlist/%s"` doesn't take format string parameters. Since `WishList.postWishList` doesn't use user name from the URL parameter anyways, removing the user name feels the easiest fix.	2bf0e7c1e76286bed3e3c574dfaac928e0e18149	2ecbd278036629b1c2f509a00a9834342360a641	diff --git a/src/Client/pages/WishList.fs b/src/Client/pages/WishList.fs index 8ea2c79b..b8ab0302 100644 --- a/src/Client/pages/WishList.fs +++ b/src/Client/pages/WishList.fs @@ -61,7 +61,7 @@ let getResetTime () = let postWishList (token,wishList:WishList) = promise { - let url = sprintf "/api/wishlist/...	[ "src/Client/pages/WishList.fs", "src/Server/WebServer.fs" ]	[]		true
SAFE-Stack/SAFE-BookStore	397	issue_to_patch		ASP.NET Core 3 update		975408344e2eb1d8cf96179f496d147fe8d598fa	2be278945d77af94bc49428c997165992f61d359	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 952ad42f..a7955581 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -27,38 +27,7 @@ <PaketBootStrapperExePath Condition=" '$(PaketBootStrapperExePath)' == '' AND Exists('$(PaketRootPath)paket.bootstrapper....	[ ".paket/Paket.Restore.targets", "Dockerfile", "global.json", "package.json", "paket.dependencies", "paket.lock", "src/Server/Program.fs", "src/Server/Server.fsproj", "src/Server/paket.references", "test/ServerTests/ServerTests.fsproj", "yarn.lock" ]	[]	diff --git a/test/ServerTests/ServerTests.fsproj b/test/ServerTests/ServerTests.fsproj index b190985e..dce499a9 100644 --- a/test/ServerTests/ServerTests.fsproj +++ b/test/ServerTests/ServerTests.fsproj @@ -1,7 +1,7 @@ <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <OutputType>Exe</OutputType> - <TargetF...	true
SAFE-Stack/SAFE-BookStore	286	issue_to_patch		Use Saturn	Feedback welcomed.	86e76832c39a75e8b1628cf2348864384c64bf16	1f5755c367f5660ebf5948e5bb1583014669c33e	diff --git a/.gitignore b/.gitignore index 4fa800bb..fc307fd9 100644 --- a/.gitignore +++ b/.gitignore @@ -193,3 +193,4 @@ docs/tools/FSharp.Formatting.svclog node_modules src/Client/public/ deploy +/.ionide diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 830e5699..aed3c3fd 100644 --- ...	[ ".gitignore", ".paket/Paket.Restore.targets", ".paket/paket.exe", ".travis.yml", ".vscode/settings.json", "BookStore.sln", "Dockerfile", "README.md", "RELEASE_NOTES.md", "app.yaml", "appveyor.yml", "build.fsx", "global.json", "package.json", "paket.dependencies", "paket.lock", "src/A...	[ { "comment": "@Krzysztof-Cieslak From an educational point of view, what does the `Auth.useToken` get replaced with in Saturn?", "path": "src/Server/WishList.fs", "hunk": "@@ -2,35 +2,37 @@\n module ServerCode.WishList\n \n open Giraffe\n-open Giraffe.Tasks\n open RequestErrors\n open ServerErrors\n ope...	diff --git a/test/ServerTests/Program.fs b/test/ServerTests/Program.fs index fb4993b9..0363fc3b 100644 --- a/test/ServerTests/Program.fs +++ b/test/ServerTests/Program.fs @@ -4,4 +4,4 @@ open Expecto [<EntryPoint>] let main args = - runTestsWithArgs { defaultConfig with ``parallel`` = false } args ServerTest...	true
SAFE-Stack/SAFE-BookStore	369	issue_to_patch		Update Freya to 4.0.0		3ad128b194f6629e05d0504cec906fdf7382d3f4	ae434bcd6356638cee1d87a68596a606d2ce0099	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 55292f31..305e736c 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -72,6 +72,9 @@ <PaketRestoreRequired Condition=" '$(PaketRestoreLockFileHash)' == '' ">true</PaketRestoreRequired> </PropertyGroup...	[ ".paket/Paket.Restore.targets", "global.json", "paket.dependencies", "paket.lock" ]	[]		true
SAFE-Stack/SAFE-BookStore	396	issue_to_patch		Update deps		5a4893662d72df8388b67a5cbcf9273afaeec9c4	52566a330f7e540eda57a6a6fd08e5097991d7c1	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 0df24f94..aed3c3fd 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -5,6 +5,11 @@ <!-- make MSBuild track this file for incremental builds. --> <!-- ref https://blogs.msdn.microsoft.com/msbuild/2005/0...	[ ".paket/Paket.Restore.targets", ".travis.yml", "appveyor.yml", "package.json", "paket.lock", "test/UITests/App.config", "yarn.lock" ]	[]	diff --git a/test/UITests/App.config b/test/UITests/App.config index 60d91753..e57aca08 100644 --- a/test/UITests/App.config +++ b/test/UITests/App.config @@ -8,6 +8,6 @@ <dependentAssembly> <Paket>True</Paket> <assemblyIdentity name="FSharp.Core" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> - ...	true
SAFE-Stack/SAFE-BookStore	395	issue_to_patch		Update all elmish libs		23bdbeebf43e9749b74db1c56ec809e6b9a56477	812f676d846029f8c924c7e765157a6d9e012cd3	diff --git a/package.json b/package.json index 27bb49bd..5f750e08 100644 --- a/package.json +++ b/package.json @@ -13,13 +13,13 @@ "@babel/core": "^7.4.4", "@babel/plugin-transform-runtime": "^7.4.4", "@babel/preset-env": "^7.4.4", - "babel-loader": "^8.0.5", + "babel-loader": "^8.0.6", "concu...	[ "package.json", "paket.lock", "yarn.lock" ]	[]		true
SAFE-Stack/SAFE-BookStore	394	issue_to_patch		Update deps		4b1adf2f6dfdc3acebafdad4118da0d55a4a21c1	32ba04df37d2516279c612b9266a497939dba2a1	diff --git a/package.json b/package.json index db4a506c..27bb49bd 100644 --- a/package.json +++ b/package.json @@ -1,8 +1,8 @@ { "private": true, "dependencies": { - "@babel/polyfill": "^7.4.3", - "@babel/runtime": "^7.4.3", + "@babel/polyfill": "^7.4.4", + "@babel/runtime": "^7.4.4", "react": "...	[ "package.json", "paket.dependencies", "paket.lock", "src/Client/App.fs", "src/Client/Client.fsproj", "src/Client/Pages.fs", "src/Client/Styles.fs", "yarn.lock" ]	[]		true
SAFE-Stack/SAFE-BookStore	393	issue_to_patch		Use React.memo	This PR add a small `elmishView` helper to create views using `FunctionComponent.Of` with the new `equalsButFunctions` comparison now included in `Fable.React`. With these changes, editing a book doesn't re-render the book list : ![image](https://user-images.githubusercontent.com/131878/56319994-6b380200-6163-11e...	8e1f34adbdfd8b2ffe38a9be59551c1d55dc8e80	f4bb95bbcc53486d62065da6c3181c0a351d4357	diff --git a/src/Client/Client.fsproj b/src/Client/Client.fsproj index c7aced25..d36b627f 100644 --- a/src/Client/Client.fsproj +++ b/src/Client/Client.fsproj @@ -9,6 +9,7 @@ <Compile Include="LocalStorage.fs" /> <Compile Include="Pages.fs" /> <Compile Include="Styles.fs" /> + <Compile Include="views/...	[ "src/Client/Client.fsproj", "src/Client/Shared.fs", "src/Client/pages/Home.fs", "src/Client/pages/Login.fs", "src/Client/pages/NewBook.fs", "src/Client/pages/WishList.fs", "src/Client/views/Menu.fs", "src/Client/views/Utils.fs", "src/Server/Server.fsproj" ]	[]		true
SAFE-Stack/SAFE-BookStore	389	issue_to_patch		Update Fable 2.2 & Fable.Core v3	this includes https://github.com/SAFE-Stack/SAFE-BookStore/pull/388	224d00325f705075f55d04e25993aaf47f4eb00b	962112eb9e1f88c1ba91a1d3ebbe84ce04417fe2	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 6e9330d9..0df24f94 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -17,14 +17,35 @@ <PaketExeImage Condition=" '$(PaketBootstrapperStyle)' == 'proj' ">native</PaketExeImage> <MonoPath Condition="'$(M...	[ ".paket/Paket.Restore.targets", "README.md", "package.json", "paket.dependencies", "paket.lock", "src/AzureFunctions/RecurringJobs/paket.references", "src/Client/App.fs", "src/Client/Client.fsproj", "src/Client/LocalStorage.fs", "src/Client/Shared.fs", "src/Client/Styles.fs", "src/Client/pages...	[ { "comment": "urgs!? what's that?", "path": "src/Client/pages/WishList.fs", "hunk": "@@ -115,19 +114,19 @@ let update (msg:Msg) model : Model * Cmd<Msg> =\n \| Some err ->\n { model with ErrorMsg = Some err }, Cmd.none\n \| None ->\n- let wishList = \...	diff --git a/test/UITests/App.config b/test/UITests/App.config index 79b65997..60d91753 100644 --- a/test/UITests/App.config +++ b/test/UITests/App.config @@ -8,6 +8,6 @@ <dependentAssembly> <Paket>True</Paket> <assemblyIdentity name="FSharp.Core" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> - ...	true
SAFE-Stack/SAFE-BookStore	392	issue_to_patch		Use Fable.React 5	https://fable.io/blog/Announcing-Fable-React-5.html	2b778519de3812a330c42e3915a7266290e4c93c	6864e0e87ddf9f9c5947e7364aa1041f085aead4	diff --git a/.vscode/settings.json b/.vscode/settings.json index d55f5104..000461fe 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -24,5 +24,6 @@ "src//bin":true, "src//obj":true, "src/Client/out":true - } + }, + "FSharp.fsacRuntime": "netcore" } diff --git a/paket.dependencies b/paket.dep...	[ ".vscode/settings.json", "paket.dependencies", "paket.lock", "src/Client/LocalStorage.fs", "src/Client/Styles.fs" ]	[]		true
SAFE-Stack/SAFE-BookStore	391	issue_to_patch		Update all js packages		cfa4ed1d6dc2e40c7bbb9b77c21e4a426037bd0f	d8bc171524080acb2852f808b68ef03d94992105	diff --git a/package.json b/package.json index 6d423993..db4a506c 100644 --- a/package.json +++ b/package.json @@ -1,26 +1,26 @@ { "private": true, "dependencies": { - "@babel/polyfill": "^7.0.0", - "@babel/runtime": "^7.2.0", - "react": "16.6.3", - "react-bootstrap": "0.32.4", - "react-dom": "16....	[ "package.json", "yarn.lock" ]	[]		true
SAFE-Stack/SAFE-BookStore	379	issue_to_patch		Set dotnet to Path		9ec7bce93882bac6f5cd073280ab99fcb58fad8e	39f3df7d006fd339afb2fc62b6703e4b40d19506	diff --git a/build.fsx b/build.fsx index 6007e7bd..463a19a1 100644 --- a/build.fsx +++ b/build.fsx @@ -102,6 +102,12 @@ Target "Clean" (fun _ -> Target "InstallDotNetCore" (fun _ -> dotnetExePath <- DotNetCli.InstallDotNetSDK dotnetcliVersion + let fi = FileInfo dotnetExePath + let SEPARATOR = if isWindow...	[ "build.fsx", "test/UITests/Tests.fs" ]	[]	diff --git a/test/UITests/Tests.fs b/test/UITests/Tests.fs index 6c8ba167..46ba7de3 100644 --- a/test/UITests/Tests.fs +++ b/test/UITests/Tests.fs @@ -67,48 +67,50 @@ let tests = logout() ) - // testCase "create and remove book" (fun () -> - // startApp () - // login...	true
SAFE-Stack/SAFE-BookStore	390	issue_to_patch		Update Fable.React	This updates to latest Fable.React that makes it easier to create function components. I will publish the stable version soon, so you may want to wait until that before merging the PR.	5442606e17f9115bd9afdf03c395cb6ddc218851	d4794b1ecbd8c20f8879aad88f433c4a8ef8afd8	diff --git a/paket.lock b/paket.lock index f3c4a7c7..154b90cc 100644 --- a/paket.lock +++ b/paket.lock @@ -37,10 +37,10 @@ NUGET Fable.Elmish.Browser (>= 3.0.0-beta-3) - restriction: >= netstandard2.0 Fable.Elmish.React (>= 3.0.0-beta-4) - restriction: >= netstandard2.0 FSharp.Core (>= 4.6.2) - res...	[ "paket.lock", "src/Client/App.fs", "src/Client/pages/WishList.fs" ]	[ { "comment": "nice", "path": "src/Client/pages/WishList.fs", "hunk": "@@ -147,7 +147,8 @@ let bookComponent { book = book; removeBook = removeBook } =\n td [] [ buttonLink \"\" removeBook [ str \"Remove\" ] ]\n ]\n \n-let inline BookComponent props = (ofFunction bookComponent) props []\n+let...		true
SAFE-Stack/SAFE-BookStore	385	issue_to_patch		Tiny fix		224d00325f705075f55d04e25993aaf47f4eb00b	bb2f3958db4cb8d88bf876f9b9c1a633900d061e	diff --git a/src/Server/WebServer.fs b/src/Server/WebServer.fs index b44fe271..e3b43d93 100644 --- a/src/Server/WebServer.fs +++ b/src/Server/WebServer.fs @@ -1,4 +1,4 @@ -/// Functions for managing the Suave web server. +/// Functions for managing the Giraffe web server. module ServerCode.WebServer open ServerCode...	[ "src/Server/WebServer.fs" ]	[]		true
SAFE-Stack/SAFE-BookStore	384	issue_to_patch		Update README.md	Supply guidance for creating new applications via the SAFE template.	b2395bbf5149fe1679a63212ca58dfc81bc7828d	710dd6a3d73a7c08938e626f57c543b74fbfba18	diff --git a/README.md b/README.md index ec592c68..287be776 100644 --- a/README.md +++ b/README.md @@ -11,6 +11,10 @@ You can see it running on Microsoft Azure at https://safebookstore.azurewebsites [![Build status](https://ci.appveyor.com/api/projects/status/ak9gjjjp32ens0e2?svg=true)](https://ci.appveyor.com/project...	[ "README.md" ]	[]		true
SAFE-Stack/SAFE-BookStore	382	issue_to_patch		Update tutorial to match current code.	https://github.com/SAFE-Stack/SAFE-BookStore/issues/381	b21c0e3dc42034c946e993068f3ee822561479bc	9ce737c67f53a86322633776be03807ab8cf0d35	diff --git a/README.md b/README.md index 0bb6512e..ec592c68 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ This development stack is designed to be used with minimal tooling. An instance Start the development mode with: - > build.cmd run // on windows + > ./build.cmd run // on windows $ ./buil...	[ "README.md" ]	[]		true
SAFE-Stack/SAFE-BookStore	380	issue_to_patch		Update to ASP.NET 2.2		176c717806381a4064c9cc044c01136dd5267983	a0ed82aae3dc7777b85a6c27d9bd7756d168c279	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index d93abfef..6e9330d9 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -21,16 +21,16 @@ <PaketExePath Condition=" '$(PaketExePath)' == '' AND Exists('$(PaketToolsPath)paket')">$(PaketToolsPath)paket</PaketExe...	[ ".paket/Paket.Restore.targets", "global.json", "paket.lock", "src/Server/Server.fsproj", "test/ServerTests/ServerTests.fsproj" ]	[]	diff --git a/test/ServerTests/ServerTests.fsproj b/test/ServerTests/ServerTests.fsproj index 91b8c300..5969d8e8 100644 --- a/test/ServerTests/ServerTests.fsproj +++ b/test/ServerTests/ServerTests.fsproj @@ -1,7 +1,7 @@ <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <OutputType>Exe</OutputType> - <TargetF...	true
SAFE-Stack/SAFE-BookStore	378	issue_to_patch		Update to Fable 2.1		9ec7bce93882bac6f5cd073280ab99fcb58fad8e	b2acd814390cfaa80bb346ccacf8b2d46408417b	diff --git a/build.fsx b/build.fsx index 6007e7bd..6df85246 100644 --- a/build.fsx +++ b/build.fsx @@ -102,6 +102,12 @@ Target "Clean" (fun _ -> Target "InstallDotNetCore" (fun _ -> dotnetExePath <- DotNetCli.InstallDotNetSDK dotnetcliVersion + let fi = FileInfo dotnetExePath + let SEPARATOR = if isWindow...	[ "build.fsx", "package.json", "paket.dependencies", "paket.lock", "src/Client/paket.references", "yarn.lock" ]	[]		true
SAFE-Stack/SAFE-BookStore	376	issue_to_patch		Extract the book model		fea8772adfc9a712faa96261d4da97c4c396b02e	f74180b551f93387a02f1ee436a627da537477ef	diff --git a/src/Client/Shared.fs b/src/Client/Shared.fs index 8af7ffea..00bc31d8 100644 --- a/src/Client/Shared.fs +++ b/src/Client/Shared.fs @@ -1,6 +1,7 @@ module Client.Shared open ServerCode.Domain + /// The composed model for the different possible page states of the application type PageModel = \| Home...	[ "src/Client/Shared.fs", "src/Client/pages/NewBook.fs", "src/Client/pages/WishList.fs", "src/Client/paket.references", "src/Server/Pages.fs", "src/Shared/Client.props", "src/Shared/Shared.props", "test/UITests/Tests.fs" ]	[]	diff --git a/test/UITests/Tests.fs b/test/UITests/Tests.fs index 38c63ff5..e7c983fd 100644 --- a/test/UITests/Tests.fs +++ b/test/UITests/Tests.fs @@ -1,12 +1,7 @@ module UITests.Tests -open canopy open canopy.classic -open canopy.types -open System.IO open Expecto -open System -open System.Threading let server...	true
SAFE-Stack/SAFE-BookStore	375	issue_to_patch		Update webpack.config.js	pass babel configuration to fable-loader see https://github.com/SAFE-Stack/SAFE-template/issues/188	9658675434a7cbc53a61239422f0f47feddc0fac	84c1ecbd47059135aba376c6481d157a679f4d46	diff --git a/src/Client/webpack.config.js b/src/Client/webpack.config.js index 05304033..e08b996f 100644 --- a/src/Client/webpack.config.js +++ b/src/Client/webpack.config.js @@ -98,7 +98,13 @@ module.exports = { rules: [ { test: /\.fs(x\|proj)?$/, - use: "fable-load...	[ "src/Client/webpack.config.js" ]	[]		true
SAFE-Stack/SAFE-BookStore	374	issue_to_patch		Fix historyApiFallback setting in webpack.config.js	Fix #373	bc28c62c7deeaf3c847cbe0ce2d1854fa66f5fe3	375e88a8734055ce333e4787fac0f035db762faf	diff --git a/src/Client/webpack.config.js b/src/Client/webpack.config.js index 87d7758f..05304033 100644 --- a/src/Client/webpack.config.js +++ b/src/Client/webpack.config.js @@ -19,9 +19,6 @@ var CONFIG = { changeOrigin: true } }, - historyApiFallback: { - index: resolve("./index.h...	[ "src/Client/webpack.config.js" ]	[]		true
SAFE-Stack/SAFE-BookStore	349	issue_to_patch		Update to Fable 2 alpha	The project is now compiling and working but several things are needed before considering Fable 2 ready for booktstore. - [x] Release a new version of Fable.PowerPack that is using Thoth.Json - This is needed in order to fix `Fetch.fetchAs<'T>` which failed silently as it's now just using JavaScript `parse` - ...	1e4266c8357095b483475f738b056f17c0588420	33efc0fab24c8785e244c5966c54fce2ba03e65a	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 6be03acb..305e736c 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -144,11 +144,12 @@ <PackageName>$([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[0])</PackageName> ...	[ ".paket/Paket.Restore.targets", "build.fsx", "global.json", "package.json", "paket.dependencies", "paket.lock", "src/Client/App.fs", "src/Client/index.html", "src/Client/pages/Login.fs", "src/Client/pages/WishList.fs", "src/Client/paket.references", "src/Client/webpack.config.js", "src/Serve...	[ { "comment": "why do we need uglify?", "path": "package.json", "hunk": "@@ -14,9 +14,9 @@\n \"babel-plugin-transform-runtime\": \"6.23.0\",\n \"babel-preset-env\": \"1.7.0\",\n \"concurrently\": \"3.6.0\",\n- \"fable-loader\": \"1.1.6\",\n- \"fable-utils\": \"1.0.6\",\n- \"webpack\"...		true
SAFE-Stack/SAFE-BookStore	372	issue_to_patch		with debugger	/cc @MangelMaxime	777f8a0ed81534bd8a64a89d5e3696a238ade12c	83654ea34bf4a38c8e27a85f92eb945ba1dbaf91	diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets index 305e736c..7c610701 100644 --- a/.paket/Paket.Restore.targets +++ b/.paket/Paket.Restore.targets @@ -11,20 +11,26 @@ <PaketRootPath>$(MSBuildThisFileDirectory)..\</PaketRootPath> <PaketRestoreCacheFile>$(PaketRootPath)paket-files\pa...	[ ".paket/Paket.Restore.targets", "package.json", "paket.dependencies", "paket.lock", "src/Client/App.fs", "yarn.lock" ]	[ { "comment": "@forki This version is incorrect you are back to Fable 1", "path": "paket.lock", "hunk": "@@ -1,17 +1,25 @@\n STORAGE: NONE\n NUGET\n remote: https://www.nuget.org/api/v2\n- dotnet-fable (2.0.2) - clitool: true\n+ dotnet-fable (1.3.19) - clitool: true", "resolving_sha": "83654e...		true
SAFE-Stack/SAFE-BookStore	365	issue_to_patch		Added missing literal attribute	There was an attribute missing.	9deb3ca93ee3577ed640debe75523a1cf704ce4c	c3a189b2b840ccd02ba99396689fbfa0bb676d63	diff --git a/src/Server/Shared/ServerUrls.fs b/src/Server/Shared/ServerUrls.fs index a2f083ff..39418244 100644 --- a/src/Server/Shared/ServerUrls.fs +++ b/src/Server/Shared/ServerUrls.fs @@ -5,6 +5,7 @@ module ServerCode.ServerUrls module PageUrls = [<Literal>] let Home = "/" + [<Literal>] let Login = "/logi...	[ "src/Server/Shared/ServerUrls.fs" ]	[]		true

Subsets and Splits

No community queries yet

The top public SQL queries from the community will appear here once available.