repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
RicoSuter/NSwag
5,219
issue_to_patch
Add support for TypeScript compilation testing
92288b894d210a82ab6eff736bb82b83562fd7ea
9248e685ccc2c0122a327f0f90e8aea25f757f0e
diff --git a/.gitignore b/.gitignore index ae82a3cb09..af758e15e6 100644 --- a/.gitignore +++ b/.gitignore @@ -83,3 +83,5 @@ _ReSharper.Caches/ /artifacts *.binlog *.gen + +node_modules diff --git a/build/Build.cs b/build/Build.cs index 2707f74bb3..47e0aec17c 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -129,...
[ ".gitignore", "build/Build.cs", "src/NSwag.CodeGeneration.CSharp.Tests/CodeCompiler.cs", "src/NSwag.CodeGeneration.CSharp/CSharpGeneratorBase.cs", "src/NSwag.CodeGeneration.Tests/VerifyHelper.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/CodeCompiler.cs", "src/NSwag.CodeGeneration.TypeScript.Tests/pac...
[]
true
RicoSuter/NSwag
5,218
issue_to_patch
Convert NSwagStudio setup to use WiX 6
7bca4b6686297666a9707b588d6527e595f22df2
734815bb20f7014c1fa1d3620b7dc3fe60d49471
diff --git a/.nuke/build.schema.json b/.nuke/build.schema.json index 4aecb4ebff..df8f45c236 100644 --- a/.nuke/build.schema.json +++ b/.nuke/build.schema.json @@ -26,7 +26,6 @@ "enum": [ "Clean", "Compile", - "InstallDependencies", "Pack", "Publish", "Restore",...
[ ".nuke/build.schema.json", "Directory.Packages.props", "build/Build.Pack.cs", "build/Build.cs", "src/NSwagStudio.Installer/NSwagStudio.Installer.wixproj", "src/NSwagStudio.Installer/Product.wxs", "src/NSwagStudio/NSwagStudio.csproj" ]
[]
true
Rigellute/spotify-tui
133
issue_to_patch
Unable to scroll past first page of songs in playlist After selecting a playlist, I can only view the first 30 or so songs and can't scroll beyond that. Scrolling using vim keys or arrow keys brings me back to the top of the list, and ctl+d/u doesn't do anything (although I'm not too sure ctl+d/u should do). Hopefully...
Add support for page scrolling in Playlist
Fix #11 I tried to implement page scrolling in the Playlist and fixed `get_current_user_saved_tracks` that I pointed out in #128 . I added and changed filed and methods of `App` but I'm not sure whether these changes are matched to what you expected. I would like to hear your opinion.
91cbdac916723b33b04772923ffd356ef03c861f
0bab19c28f7103fd0995b735a1a31956f5e989e6
diff --git a/src/app.rs b/src/app.rs index 9042e094..0d331d29 100644 --- a/src/app.rs +++ b/src/app.rs @@ -219,7 +219,8 @@ pub struct App { pub large_search_limit: u32, pub library: Library, pub playback_params: PlaybackParams, - pub playlist_tracks: Vec<PlaylistTrack>, + pub playlist_tracks: Scrol...
[ "src/app.rs", "src/handlers/library.rs", "src/handlers/playlist.rs", "src/handlers/search_results.rs", "src/handlers/track_table.rs" ]
[ { "comment": "This is what I was thinking πŸ‘ ", "path": "src/app.rs", "hunk": "@@ -219,7 +219,8 @@ pub struct App {\n pub large_search_limit: u32,\n pub library: Library,\n pub playback_params: PlaybackParams,\n- pub playlist_tracks: Vec<PlaylistTrack>,\n+ pub playlist_tracks: Scrollab...
true
Rigellute/spotify-tui
910
issue_to_patch
"D" to delete playlist does not work Pressing `shift+D` according to the keybindings shown in the `?` menu does not successfully delete a playlist. To reproduce: 1. Start spt 2. Enter the `Playlists` section 3. Select a playlist 4. Press shift+D to delete the selected playlist 5. Observe that nothing happens...
Fix confirmation dialog handling on playlist delete.
Resolves #884. ### Observations I might not know the architecture of this application very well, but I believe I've narrowed down the root cause and drafted a quick solution. As of commit [ecddb5e](https://github.com/Rigellute/spotify-tui/commit/ecddb5eb4fb441bf46075d44cf12cd2294a251c7), the `push_navigation_stack...
ecddb5eb4fb441bf46075d44cf12cd2294a251c7
9dda55657f42a3ec95596fc65522c44266767582
diff --git a/src/app.rs b/src/app.rs index 4477c8b5..d7af0fc7 100644 --- a/src/app.rs +++ b/src/app.rs @@ -158,6 +158,7 @@ pub enum RouteId { Podcasts, PodcastEpisodes, Recommendations, + Dialog, } #[derive(Debug)] @@ -767,13 +768,8 @@ impl App { } None => { if let Some(saved_artist...
[ "src/app.rs", "src/handlers/common_key_events.rs", "src/handlers/playlist.rs", "src/handlers/search_results.rs", "src/ui/mod.rs" ]
[]
true
Rigellute/spotify-tui
916
issue_to_patch
docs: add majabojarska as a contributor for code
Add @majabojarska as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/910#issuecomment-971963296)
7550d6ebd51c20bc1188540698a38b112927391b
d13401fcaba7d0bb40f2c89b9b4fd5a1dd95c451
diff --git a/.all-contributorsrc b/.all-contributorsrc index 2005a95c..b25e946b 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -859,6 +859,15 @@ "contributions": [ "code" ] + }, + { + "login": "majabojarska", + "name": "Maja Bojarska", + "avatar_url": "https://...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
844
issue_to_patch
Add option to set window title to "spt - Spotify TUI" on startup
This adds an option to set the window title to "Spotify TUI" on startup. This is very handy when switching windows via something like dmenu, since it makes the terminal window where spotify-tui is running easy to find. There are a few choices that I wasn't sure about though: - I've added the configuration op...
1ef37e7551b05ffba8b0a1eed2132ff9b97a15a6
2d44ef68653aba47059342cc7ab1e4768562c82b
diff --git a/README.md b/README.md index adb8c711..a9bf783f 100644 --- a/README.md +++ b/README.md @@ -254,6 +254,8 @@ behavior: repeat_context_icon: πŸ” playing_icon: β–Ά paused_icon: ⏸ + # Sets the window title to "spt - Spotify TUI" via ANSI escape code. + set_window_title: true keybindings: # Key stro...
[ "README.md", "src/main.rs", "src/user_config.rs" ]
[ { "comment": "Very cool!", "path": "src/main.rs", "hunk": "@@ -268,7 +268,12 @@ async fn start_ui(user_config: UserConfig, app: &Arc<Mutex<App>>) -> Result<()>\n execute!(stdout, EnterAlternateScreen, EnableMouseCapture)?;\n enable_raw_mode()?;\n \n- let backend = CrosstermBackend::new(stdout);\n+ ...
true
Rigellute/spotify-tui
896
issue_to_patch
Bump serde_yaml from 0.8.20 to 0.8.21
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.8.20 to 0.8.21. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p> <blockquote> <h2>0.8.21</h2> <ul> <li>Avoid emitting surplus precision when seriali...
054b248c662b1bdccf387218b7cbfed02f9f10ef
7a06861cf7dfff1b8eb6b86bf4878ceb05fa8f5e
diff --git a/Cargo.lock b/Cargo.lock index a50e2f96..a6c08281 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1809,9 +1809,9 @@ dependencies = [ [[package]] name = "serde_yaml" -version = "0.8.20" +version = "0.8.21" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "ad104641f3c958dab30eb30...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
879
issue_to_patch
Bump backtrace from 0.3.56 to 0.3.57
Bumps [backtrace](https://github.com/rust-lang/backtrace-rs) from 0.3.56 to 0.3.57. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang/backtrace-rs/commit/221483ebaf45df5c956adffee2d4024e7c3b96b8"><code>221483e</code></a> Bump to 0.3.57</li> <li><a href="https://github.com/rust-lang/bac...
04de85343dfa3b1a5721a0871dae302821c364b8
31a63725f4848f8cfdc4bff8cced303dc2d4c7ca
diff --git a/Cargo.lock b/Cargo.lock index b5fd7195..44ea8cb6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -92,9 +92,9 @@ checksum = "f8aac770f1885fd7e387acedd76065302551364496e46b3dd00860b2f8359b9d" [[package]] name = "backtrace" -version = "0.3.56" +version = "0.3.57" source = "registry+https://github.com/rust-la...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
Rigellute/spotify-tui
878
issue_to_patch
Bump rand from 0.8.3 to 0.8.4
Bumps [rand](https://github.com/rust-random/rand) from 0.8.3 to 0.8.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-random/rand/blob/master/CHANGELOG.md">rand's changelog</a>.</em></p> <blockquote> <h2>[0.8.4] - 2021-06-15</h2> <h3>Additions</h3> <ul> <li>Use const-generic...
04de85343dfa3b1a5721a0871dae302821c364b8
a04fe9c0a8089d2506d9e4bfedf832c1512c9f1e
diff --git a/Cargo.lock b/Cargo.lock index b5fd7195..e5d5a348 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1425,9 +1425,9 @@ dependencies = [ [[package]] name = "rand" -version = "0.8.3" +version = "0.8.4" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0ef9e7e66b4468674bfcb0c81af8b7f...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
Rigellute/spotify-tui
897
issue_to_patch
docs: add diegov as a contributor for code
Add @diegov as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/844#issuecomment-932083267)
93fd30fa55accc3df6f1c1548de28c5465b97074
d6dcfd3ec90088e58b51b7155308851a748cb492
diff --git a/.all-contributorsrc b/.all-contributorsrc index 5e3863a6..2005a95c 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -850,6 +850,15 @@ "contributions": [ "infra" ] + }, + { + "login": "diegov", + "name": "Diego Veralli", + "avatar_url": "https://avata...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
877
issue_to_patch
Bump serde_yaml from 0.8.19 to 0.8.20
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.8.19 to 0.8.20. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p> <blockquote> <h2>0.8.20</h2> <ul> <li>Recognize tags on quotes scalars (<a href="ht...
9fa978e99518b144f2c45706af2e04401bac5972
06c391fc19c9f3676193d191a584385af4e1a71a
diff --git a/Cargo.lock b/Cargo.lock index fa129f0a..cbd06985 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1859,9 +1859,9 @@ dependencies = [ [[package]] name = "serde_yaml" -version = "0.8.19" +version = "0.8.20" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "6375dbd828ed6964c3748e4...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
876
issue_to_patch
Bump dirs from 3.0.1 to 3.0.2
Bumps [dirs](https://github.com/soc/dirs-rs) from 3.0.1 to 3.0.2. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/soc/dirs-rs/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibilit...
9fa978e99518b144f2c45706af2e04401bac5972
c6bb9f091115b3b8cf5cbd0c553f277c57de8699
diff --git a/Cargo.lock b/Cargo.lock index fa129f0a..4376070f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -67,18 +67,6 @@ dependencies = [ "x11rb", ] -[[package]] -name = "arrayref" -version = "0.3.6" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "a4c527152e37cf757a3f78aae5a06fbeefd...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
Rigellute/spotify-tui
875
issue_to_patch
Bump serde_json from 1.0.64 to 1.0.67
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.64 to 1.0.67. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.67</h2> <ul> <li>Fix inconsistency of deserialization of unknown fields...
9fa978e99518b144f2c45706af2e04401bac5972
801c66e65d92674eaf352f7999602d1c250c4f66
diff --git a/Cargo.lock b/Cargo.lock index fa129f0a..83ffa7d8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1836,9 +1836,9 @@ dependencies = [ [[package]] name = "serde_json" -version = "1.0.64" +version = "1.0.67" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "799e97dc9fdae36a5c8b8f2...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
895
issue_to_patch
docs: add Milo123459 as a contributor for infra
Add @Milo123459 as a contributor for infra. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/890#issuecomment-932081493)
b4fbbbf1a554e16dd249eab65051a1b01be771b3
4cf480f0d8d3dd609862ab037c6d65855d05e751
diff --git a/.all-contributorsrc b/.all-contributorsrc index 975f2e3b..5e3863a6 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -841,6 +841,15 @@ "contributions": [ "code" ] + }, + { + "login": "Milo123459", + "name": "Milo", + "avatar_url": "https://avatars.git...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
890
issue_to_patch
Add CI caching to make it faster
9fa978e99518b144f2c45706af2e04401bac5972
a9d438305f44453dc6896ba0ec8ba8c09bb027da
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a132cd56..ede9f5dc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -48,6 +48,7 @@ jobs: override: true # These dependencies are required for `clipboard` - run: sudo apt-get install -y -qq libxcb1-dev ...
[ ".github/workflows/ci.yml" ]
[]
true
Rigellute/spotify-tui
869
issue_to_patch
Show `album_type` in Album search panes The Album search panes current show: `<album> - <artist>`, but there is no way to distinguish an `album` vs `single` (like the Spotify WebUI/Client). Expect something like: `<album> - <artist> (<album_type>)`.
Feature/show album type in search panes
The Album search panes only showed: `<album> - <artist>`, so either required a User to know which item was an album/single/etc or select each item to see if the track list looks like an album/single. This PR updates the Album search panes to the format: `<album> - <artist> (<album_type>)`, so that it is easier to fi...
9fa978e99518b144f2c45706af2e04401bac5972
75f107f25fc71120e6586c6a511fa228947f845d
diff --git a/CHANGELOG.md b/CHANGELOG.md index c9b31f3a..5ef0d892 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## [Unreleased] +### Added + +- Show `album_type` in Search panes [#868](https://github.com/Rigellute/spotify-tui/pull/868) + ## [0.25.0] - 2021-08-24 ### Fixed diff --git a/src/ui/mo...
[ "CHANGELOG.md", "src/ui/mod.rs" ]
[ { "comment": "I don't think it's likely that an artist album has no type (I certainly haven't been able to find any), but I still don't love the naked `unwrap`. Can we change instead to something like `unwrap_or(\"unknown\")`", "path": "src/ui/mod.rs", "hunk": "@@ -470,9 +470,10 @@ where\n }...
true
Rigellute/spotify-tui
869
comment_to_fix
Feature/show album type in search panes
I don't think it's likely that an artist album has no type (I certainly haven't been able to find any), but I still don't love the naked `unwrap`. Can we change instead to something like `unwrap_or("unknown")`
9fa978e99518b144f2c45706af2e04401bac5972
75f107f25fc71120e6586c6a511fa228947f845d
diff --git a/src/ui/mod.rs b/src/ui/mod.rs index 02f26b4d..f679bfb8 100644 --- a/src/ui/mod.rs +++ b/src/ui/mod.rs @@ -470,9 +470,10 @@ where } } album_artist.push_str(&format!( - "{} - {}", + "{} - {} ({})", item.name.to_owned(), - create...
[ "src/ui/mod.rs" ]
[ { "comment": "I don't think it's likely that an artist album has no type (I certainly haven't been able to find any), but I still don't love the naked `unwrap`. Can we change instead to something like `unwrap_or(\"unknown\")`", "path": "src/ui/mod.rs", "hunk": "@@ -470,9 +470,10 @@ where\n }...
true
Rigellute/spotify-tui
869
comment_to_fix
Feature/show album type in search panes
Same here. Prefer `unwrap_or`
9fa978e99518b144f2c45706af2e04401bac5972
75f107f25fc71120e6586c6a511fa228947f845d
diff --git a/src/ui/mod.rs b/src/ui/mod.rs index 02f26b4d..f679bfb8 100644 --- a/src/ui/mod.rs +++ b/src/ui/mod.rs @@ -470,9 +470,10 @@ where } } album_artist.push_str(&format!( - "{} - {}", + "{} - {} ({})", item.name.to_owned(), - create...
[ "src/ui/mod.rs" ]
[ { "comment": "Same here. Prefer `unwrap_or`", "path": "src/ui/mod.rs", "hunk": "@@ -1237,9 +1238,10 @@ where\n }\n }\n album_artist.push_str(&format!(\n- \"{} - {}\",\n+ \"{} - {} ({})\",\n item.name.to_owned(),\n- create_artist_string(&item...
true
Rigellute/spotify-tui
867
issue_to_patch
Upgrade tui and crossterm deps
77f41dfc873e9e1070dbcc6adb3f778822ee573e
f6d14786a1df4e7af6f01f210a54ea5a232c5b0d
diff --git a/Cargo.lock b/Cargo.lock index 34b49674..6e24cbe7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1,5 +1,7 @@ # This file is automatically @generated by Cargo. # It is not intended for manual editing. +version = 3 + [[package]] name = "addr2line" version = "0.14.1" @@ -65,12 +67,6 @@ dependencies = [ "x...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
Rigellute/spotify-tui
863
issue_to_patch
Bump serde_yaml from 0.8.17 to 0.8.19
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.8.17 to 0.8.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p> <blockquote> <h2>0.8.19</h2> <ul> <li>Add an <code>Entry</code> API for serde_yaml:...
612656845ff996329120b409c55fe50bdca21517
467c652d73214aae31e4e55934ae5c80887a8dc0
diff --git a/Cargo.lock b/Cargo.lock index 7baa943e..7970cc92 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1866,12 +1866,12 @@ dependencies = [ [[package]] name = "serde_yaml" -version = "0.8.17" +version = "0.8.19" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "15654ed4ab61726bf918a...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
864
issue_to_patch
Bump serde from 1.0.127 to 1.0.128
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.127 to 1.0.128. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.128</h2> <ul> <li>Enable 128-bit integers on emscripten in Rust 1.40+ (<a hre...
612656845ff996329120b409c55fe50bdca21517
b70aacb23feececc4ac819af9c3cd0f673cce320
diff --git a/Cargo.lock b/Cargo.lock index 7baa943e..99c0a5a7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1823,18 +1823,18 @@ dependencies = [ [[package]] name = "serde" -version = "1.0.127" +version = "1.0.128" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f03b9878abf6d14e6779d3f2...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
865
issue_to_patch
Bump anyhow from 1.0.38 to 1.0.43
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.38 to 1.0.43. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p> <blockquote> <h2>1.0.43</h2> <ul> <li>Take -Zallow-features restrictions from Cargo configuration f...
612656845ff996329120b409c55fe50bdca21517
7334c2aa1f444521d7a5c13cc152622b0597707f
diff --git a/Cargo.lock b/Cargo.lock index 7baa943e..90171ecb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -41,9 +41,9 @@ dependencies = [ [[package]] name = "anyhow" -version = "1.0.38" +version = "1.0.43" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "afddf7f520a80dbf76e6f50a35bca42...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
Rigellute/spotify-tui
866
issue_to_patch
docs: add cobbinma as a contributor for code
Add @cobbinma as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/826#issuecomment-903674124)
eba6390e5be1c787434904432f1934aa4073491e
5d712b7264ff5c5ad9e1f4637b1b8db3b472acc7
diff --git a/.all-contributorsrc b/.all-contributorsrc index af7df57c..975f2e3b 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -832,6 +832,15 @@ "contributions": [ "doc" ] + }, + { + "login": "cobbinma", + "name": "Matthew Cobbing", + "avatar_url": "https://ava...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
826
issue_to_patch
Pressing `d` twice requires `q` twice to exit The device selector popup can be opened multiple times by pressing `d` more than once. To get back to the main menu, each of these needs to be closed separately by pressing `q` the same number of times. It would be nicer if pressing `q` only once always goes back to th...
Pressing `d` twice requires `q` twice to exit
Hi guys πŸ‘‹, First attempt at a PR here and attempted to resolve [issue](https://github.com/Rigellute/spotify-tui/issues/821) Did this by `dedup`ing any routes on the navigation stack with matching ids. --- The device selector popup can be opened multiple times by pressing `d` more than once. To get back to...
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
e8116ff52f22425a09cfb3bc8656aa79015d1ad5
diff --git a/src/app.rs b/src/app.rs index 15770c96..2a10df79 100644 --- a/src/app.rs +++ b/src/app.rs @@ -626,11 +626,18 @@ impl App { // The navigation_stack actually only controls the large block to the right of `library` and // `playlists` pub fn push_navigation_stack(&mut self, next_route_id: RouteId, nex...
[ "src/app.rs" ]
[ { "comment": "I think it would be just a bit nicer to do this in `push_navigation_stack`, assuming that that is the only place where the stack is stack is grown. In that case, it could possibly be just an `if` statement checking whether the current id is the same as the id at the top of the stack.", "path":...
true
Rigellute/spotify-tui
780
issue_to_patch
Bump arboard from 1.1.0 to 1.2.0
Bumps [arboard](https://github.com/ArturKovacs/arboard) from 1.1.0 to 1.2.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ArturKovacs/arboard/blob/master/CHANGELOG.md">arboard's changelog</a>.</em></p> <blockquote> <h2>v1.2.0 on 2021-04-06</h2> <h3>Added</h3> <ul> <li>Optional ...
d5c6411d33ea47d57f4759e82b8f4392b1412d79
029dcc932041d3e61c705460e5caf4d003bdd1a4
diff --git a/Cargo.lock b/Cargo.lock index 209754ff..05794fa6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -47,22 +47,22 @@ checksum = "afddf7f520a80dbf76e6f50a35bca42a2331ef227a28b3b6dc5c2e2338d114b1" [[package]] name = "arboard" -version = "1.1.0" +version = "1.2.0" source = "registry+https://github.com/rust-lang...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
Rigellute/spotify-tui
862
issue_to_patch
docs: add lejiati as a contributor for doc
Add @lejiati as a contributor for doc. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/834#issuecomment-903658448)
ddb2525a0c51b2c9c188ae8861f6653152636eaa
cc9afa1756d64d12a9be0233ab86feaf726b6675
diff --git a/.all-contributorsrc b/.all-contributorsrc index 357902cb..af7df57c 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -823,6 +823,15 @@ "contributions": [ "code" ] + }, + { + "login": "lejiati", + "name": "Jiati Le", + "avatar_url": "https://avatars.gi...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
834
issue_to_patch
Fix typo
Not sure if I was reading this incorrectly. I assumed author meant to say 'display'.
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
2ee56a1b642f6fac0011f2ba6e804e1b8927897e
diff --git a/src/main.rs b/src/main.rs index 177257c0..0c2622f5 100644 --- a/src/main.rs +++ b/src/main.rs @@ -302,7 +302,7 @@ async fn start_ui(user_config: UserConfig, app: &Arc<Mutex<App>>) -> Result<()> )); // Based on the size of the terminal, adjust how many lines are - // dislayed in t...
[ "src/main.rs" ]
[]
true
Rigellute/spotify-tui
861
issue_to_patch
docs: add JSextonn as a contributor for code
Add @JSextonn as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/850#issuecomment-903657938)
f77049a152b3a2e7d55d44ceaffaa49702b55a32
5804e10e37646822c435f38c481f6835318f0730
diff --git a/.all-contributorsrc b/.all-contributorsrc index 6e0b379e..357902cb 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -814,6 +814,15 @@ "contributions": [ "doc" ] + }, + { + "login": "JSextonn", + "name": "Justin Sexton", + "avatar_url": "https://avata...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
850
issue_to_patch
Fixed typo
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
b03c5664c80242702fe34dcd17671cb6293cb65c
diff --git a/src/event/key.rs b/src/event/key.rs index d8336b16..10de642a 100644 --- a/src/event/key.rs +++ b/src/event/key.rs @@ -64,7 +64,7 @@ pub enum Key { Char(char), Ctrl(char), Alt(char), - Unkown, + Unknown, } impl Key { @@ -199,7 +199,7 @@ impl From<event::KeyEvent> for Key { .. ...
[ "src/event/key.rs" ]
[]
true
Rigellute/spotify-tui
860
issue_to_patch
docs: add alejandro-angulo as a contributor for code
Add @alejandro-angulo as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/852#issuecomment-903647256)
c356a98c585f2c2c80843049bff765da9d221a7e
147a76bf8d76ea27351be83cf41dbe6d322dd483
diff --git a/.all-contributorsrc b/.all-contributorsrc index f4b789ad..52513e3b 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -797,6 +797,15 @@ "doc" ] }, + { + "login": "alejandro-angulo", + "name": "Alejandro Angulo", + "avatar_url": "https://avatars.githubuserco...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
847
issue_to_patch
Bump serde from 1.0.125 to 1.0.127
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.125 to 1.0.127. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.127</h2> <ul> <li>Resolve warning in rustc nightly-2021-07-31+ compiling serd...
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
8067a55c8cdeb5975a2c2c9eef5d448a9b65dfa8
diff --git a/Cargo.lock b/Cargo.lock index 209754ff..7baa943e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1823,18 +1823,18 @@ dependencies = [ [[package]] name = "serde" -version = "1.0.125" +version = "1.0.127" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "558dc50e1a5a5fa7112ca2ce...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
859
issue_to_patch
docs: add masguit42 as a contributor for doc
Add @masguit42 as a contributor for doc. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/856#issuecomment-903643956)
9179f3fbb9bb4f02e2cd0937e44a6528d85d63a7
19dff8801e01986fa92c2d1dbb0415e9c6fe9aa7
diff --git a/.all-contributorsrc b/.all-contributorsrc index 62556898..f4b789ad 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -796,6 +796,15 @@ "contributions": [ "doc" ] + }, + { + "login": "masguit42", + "name": "Anton Kostin", + "avatar_url": "https://avata...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
852
issue_to_patch
Fixed rate limiting issue
This change should resolve the issue with users being rate limited when leaving spotify-tui running without anything playing. This should solve #779 .
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
aafd9f3b852e71d2d3871c366b2ccf4ca3b13869
diff --git a/src/network.rs b/src/network.rs index 96a747f1..9ba27e40 100644 --- a/src/network.rs +++ b/src/network.rs @@ -346,21 +346,30 @@ impl<'a> Network<'a> { ) .await; - if let Ok(Some(c)) = context { - let mut app = self.app.lock().await; - app.current_playback_context = Some(c.clone...
[ "src/network.rs" ]
[ { "comment": "I set up logging in a local build and noticed that we weren't respecting the 5s interval when making requests if spotify returned a 204 (no content). This `Ok(None)` pattern matches the 204 response case.\r\n\r\n```\r\n[2021-08-02T13:36:30Z DEBUG reqwest::async_impl::client] response '204 No Conte...
true
Rigellute/spotify-tui
856
issue_to_patch
Update LICENSE year
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
b96617baedf649fd232fa540d655190adc77a92a
diff --git a/LICENSE b/LICENSE index 96ae81b0..60d21aa9 100644 --- a/LICENSE +++ b/LICENSE @@ -1,6 +1,6 @@ MIT License -Copyright (c) 2019 Alexander Keliris +Copyright (c) 2021 Alexander Keliris Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documenta...
[ "LICENSE" ]
[]
true
Rigellute/spotify-tui
858
issue_to_patch
Fix clippy warnings after Rust upgrade
6a999d81ee768b05fdaf1e2697b78cde2b8fd456
ffa5caf9bc4227613a853d1609752dbced5e24ca
diff --git a/.gitignore b/.gitignore index dcdf4a12..d242bf66 100644 --- a/.gitignore +++ b/.gitignore @@ -15,3 +15,5 @@ secrets.tar *.swp tags + +.idea \ No newline at end of file diff --git a/src/app.rs b/src/app.rs index 15770c96..ff7c08f2 100644 --- a/src/app.rs +++ b/src/app.rs @@ -779,7 +779,7 @@ impl App { ...
[ ".gitignore", "src/app.rs", "src/handlers/search_results.rs", "src/handlers/track_table.rs", "src/network.rs", "src/ui/mod.rs" ]
[]
true
Rigellute/spotify-tui
802
issue_to_patch
docs: add yktakaha4 as a contributor
Adds @yktakaha4 as a contributor for doc. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/778#issuecomment-826788742)
a86726ecb1b2a915290b9a476bdf6bea39540e2b
39fa2a2705ae3d607ef2efa3b49ef902743282b7
diff --git a/.all-contributorsrc b/.all-contributorsrc index 555e1340..62556898 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -787,6 +787,15 @@ "contributions": [ "doc" ] + }, + { + "login": "yktakaha4", + "name": "Yuuki Takahashi", + "avatar_url": "https://av...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
778
issue_to_patch
docs: client.yml file path in snap
Added description of client.yml file path when using snap.
c789a6a5b5a9940128b144927711a0bc9b852bc1
88d3657ae41a4d4a801c3dea4cef8273a9c6bb15
diff --git a/README.md b/README.md index 04e6e550..73d0dca9 100644 --- a/README.md +++ b/README.md @@ -181,7 +181,7 @@ But here they are again: And now you are ready to use the `spotify-tui` πŸŽ‰ -You can edit the config at anytime at `${HOME}/.config/spotify-tui/client.yml`. +You can edit the config at anytime at `...
[ "README.md" ]
[]
true
Rigellute/spotify-tui
771
issue_to_patch
Bump serde from 1.0.124 to 1.0.125
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.124 to 1.0.125. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.125</h2> <ul> <li>Improve performance of serializing <code>Ipv4Addr</code> (<...
5b2fe949386e7517a2ba3557410a76c23562ef70
4b8e71e98c09164cccfb1fa542d2dde7b1bde42a
diff --git a/Cargo.lock b/Cargo.lock index 067a11b5..9ec852b8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1823,18 +1823,18 @@ dependencies = [ [[package]] name = "serde" -version = "1.0.124" +version = "1.0.125" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bd761ff957cb2a45fbb9ab3d...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
585
issue_to_patch
Show actual keybindings in help page Currently, unless I'm mistaken, the help page shows hardcoded key bindings. It would be nice to show the actual ones, loaded from the config file.
Show active keybindings in Help
Closes #572 Makes the Help page display the active keybindings from config rather than the hard-coded defaults. Functionally tested by putting some keybindings in `~/.config/spotify-tui/config.yml` and observing they were displayed on the Help page. I tried to match the current Help page styling for key stri...
4a4006abc4d79ed824d8fc258e7d6cce354ef25f
8c8022a284a2e6a6d0643ffa9e49578a4182ae46
diff --git a/src/event/key.rs b/src/event/key.rs index 93336dfd..d8336b16 100644 --- a/src/event/key.rs +++ b/src/event/key.rs @@ -1,4 +1,5 @@ use crossterm::event; +use std::fmt; /// Represents an key. #[derive(PartialEq, Eq, Clone, Copy, Hash, Debug)] @@ -94,6 +95,31 @@ impl Key { } } +impl fmt::Display fo...
[ "src/event/key.rs", "src/main.rs", "src/ui/help.rs", "src/ui/mod.rs" ]
[ { "comment": "Very nice πŸ‘Œ", "path": "src/event/key.rs", "hunk": "@@ -94,6 +95,31 @@ impl Key {\n }\n }\n \n+impl fmt::Display for Key {\n+ fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {\n+ match *self {\n+ Key::Alt(' ') => write!(f, \"<Alt+Space>\"),\n+ Key::Ctrl(' ') => write!(...
true
Rigellute/spotify-tui
759
issue_to_patch
Default setting clashes "shuffle" command with "saving track in list or table" command Currently both the "shuffle" and the "saving track in list or table" are mapped to the `s` key. This prevents for the "saving track in list or table" command to be ran. It works fine if the "shuffle" command is mapped to a differen...
docs(README): fix default shortcut for shuffle config
Close #726 Implementations: - Minor update in README.md
915e43d5d1c4a3c58d4e1e37bed3d66c544c599d
32ae8b0e5bf4a69a7efd420c05f13f4c18ec1502
diff --git a/README.md b/README.md index 531a4d32..87eff8f4 100644 --- a/README.md +++ b/README.md @@ -278,7 +278,7 @@ keybindings: copy_song_url: "c" copy_album_url: "C" help: "?" - shuffle: "s" + shuffle: "ctrl-s" repeat: "r" search: "/" audio_analysis: "v"
[ "README.md" ]
[]
true
Rigellute/spotify-tui
764
issue_to_patch
docs: add hantatsang as a contributor
Adds @hantatsang as a contributor for doc. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/759#issuecomment-798997095)
e77060c58d5dfa638845ce97328d5e1dc3e9f6b5
b021caa7df8e78c17314e65fd6f6b77ff0551036
diff --git a/.all-contributorsrc b/.all-contributorsrc index 10228ff0..555e1340 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -778,6 +778,15 @@ "contributions": [ "code" ] + }, + { + "login": "hantatsang", + "name": "Sang", + "avatar_url": "https://avatars.git...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
755
issue_to_patch
Bump serde_json from 1.0.63 to 1.0.64
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.63 to 1.0.64. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.64</h2> <ul> <li>Fix deserialization panic on deserializing <code>RawVa...
915e43d5d1c4a3c58d4e1e37bed3d66c544c599d
63c022bb0356a92c04110ffe21873908dd77d48b
diff --git a/Cargo.lock b/Cargo.lock index 88f5072b..31f1bd3e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1843,9 +1843,9 @@ dependencies = [ [[package]] name = "serde_json" -version = "1.0.63" +version = "1.0.64" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "43535db9747a4ba938c0ce0...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
761
issue_to_patch
Bump serde from 1.0.123 to 1.0.124
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.123 to 1.0.124. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.124</h2> <ul> <li>Fix possible panic deserializing invalid data as <code>Syst...
915e43d5d1c4a3c58d4e1e37bed3d66c544c599d
c45cd3c78efd0abc0e84e0508848d6f1ae82b9c3
diff --git a/Cargo.lock b/Cargo.lock index 88f5072b..ee661eb8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1823,18 +1823,18 @@ dependencies = [ [[package]] name = "serde" -version = "1.0.123" +version = "1.0.124" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "92d5161132722baa40d802cc...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
753
issue_to_patch
docs: add Jesse-Bakker as a contributor
Adds @Jesse-Bakker as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/742#issuecomment-787105056)
7fa28899635b199501784cdeb50cb03de9389174
ebaa7debde11720be79f69bc8838626f1d0f134a
diff --git a/.all-contributorsrc b/.all-contributorsrc index 797cec78..10228ff0 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -769,6 +769,15 @@ "contributions": [ "code" ] + }, + { + "login": "Jesse-Bakker", + "name": "Jesse", + "avatar_url": "https://avatars....
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
742
issue_to_patch
Replace black and white default colors with reset.
Previously, text would be white, which is not visible on bright color schemes. The color for non-highlighted text now uses the default foreground color of the users terminal emulator, making it visible in any theme. The only visual change in dark color schemes is that the playbar text might go from black to white, ...
c5b340025f0b7e4129f5f4af9c01b7765af356a7
a49984d0fe7a9bbd79722c221f33e9c19203da0f
diff --git a/src/user_config.rs b/src/user_config.rs index 3873457d..cfbe4b1f 100644 --- a/src/user_config.rs +++ b/src/user_config.rs @@ -53,7 +53,7 @@ impl Default for Theme { fn default() -> Self { Theme { analysis_bar: Color::LightCyan, - analysis_bar_text: Color::Black, + analysis_bar_text...
[ "src/user_config.rs" ]
[ { "comment": "For dark themes, I think this needs to stay as Black otherwise the the text won't be visible when the track progress overlays the text\r\n# playbar_background: Color::Black,\r\n<img width=\"158\" alt=\"image\" src=\"https://user-images.githubusercontent.com/12150276/109384483-f3050080-78e4-11eb-8f...
true
Rigellute/spotify-tui
742
comment_to_fix
Replace black and white default colors with reset.
For dark themes, I think this needs to stay as Black otherwise the the text won't be visible when the track progress overlays the text # playbar_background: Color::Black, <img width="158" alt="image" src="https://user-images.githubusercontent.com/12150276/109384483-f3050080-78e4-11eb-8f8a-21c0c4e75180.png"> # play...
c5b340025f0b7e4129f5f4af9c01b7765af356a7
a49984d0fe7a9bbd79722c221f33e9c19203da0f
diff --git a/src/user_config.rs b/src/user_config.rs index 3873457d..cfbe4b1f 100644 --- a/src/user_config.rs +++ b/src/user_config.rs @@ -53,7 +53,7 @@ impl Default for Theme { fn default() -> Self { Theme { analysis_bar: Color::LightCyan, - analysis_bar_text: Color::Black, + analysis_bar_text...
[ "src/user_config.rs" ]
[ { "comment": "For dark themes, I think this needs to stay as Black otherwise the the text won't be visible when the track progress overlays the text\r\n# playbar_background: Color::Black,\r\n<img width=\"158\" alt=\"image\" src=\"https://user-images.githubusercontent.com/12150276/109384483-f3050080-78e4-11eb-8f...
true
Rigellute/spotify-tui
752
issue_to_patch
crossterm updated
crossterm bumped to 0.19
6dec94179ccbc5fdc7ad9c57c582664f80b5e84e
ecb24b5e296a21c5b2cfb957079d7b8cfd7f3c8e
diff --git a/Cargo.lock b/Cargo.lock index 20d35a41..88f5072b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -362,7 +362,23 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "4e86d73f2a0b407b5768d10a8c720cf5d2df49a9efc10ca09176d201ead4b7fb" dependencies = [ "bitflags", - "crossterm_winapi"...
[ "Cargo.lock", "Cargo.toml", "src/main.rs" ]
[]
true
Rigellute/spotify-tui
750
issue_to_patch
docs: add Hwatwasthat as a contributor
Adds @Hwatwasthat as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/749#issuecomment-787081570)
43452ca44f0d6eb6085673ac15400ff6bf1ef93d
b3347ce8c2ccc0b3552c094aabf305b251f61972
diff --git a/.all-contributorsrc b/.all-contributorsrc index c29eae97..797cec78 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -760,6 +760,15 @@ "contributions": [ "code" ] + }, + { + "login": "Hwatwasthat", + "name": "Hwatwasthat", + "avatar_url": "https://ava...
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
749
issue_to_patch
updated rand crate
Updated rand crate to 0.8.3
bb8a7640daa848c078894189e2fd5c887802b5f5
37dd827b3b95c0b86f56eb3969a26015b57d91be
diff --git a/Cargo.lock b/Cargo.lock index 398e20f7..8794a2e8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -693,7 +693,18 @@ checksum = "7abc8dd8451921606d809ba32e95b6111925cd2906060d2dcc29c070220503eb" dependencies = [ "cfg-if 0.1.10", "libc", - "wasi", + "wasi 0.9.0+wasi-snapshot-preview1", +] + +[[package]] +nam...
[ "Cargo.lock", "Cargo.toml", "src/cli/cli_app.rs", "src/handlers/track_table.rs" ]
[]
true
Rigellute/spotify-tui
728
issue_to_patch
Bump tokio from 0.2.24 to 0.2.25
Bumps [tokio](https://github.com/tokio-rs/tokio) from 0.2.24 to 0.2.25. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tokio-rs/tokio/commit/2afa276c8c31f7eeafa42f112a8b8507078ce15a"><code>2afa276</code></a> chore: prepare Tokio 0.2.25 (<a href="https://github-redirect.dependabot.com/tokio-rs...
8a9d8d3427984f6da457bcffe881ce18682f7072
05762b4546666e59de9f8ed0ec9a030faf2b0b98
diff --git a/Cargo.lock b/Cargo.lock index 398e20f7..81b1527c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1021,9 +1021,9 @@ dependencies = [ [[package]] name = "mio" -version = "0.6.22" +version = "0.6.23" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "fce347092656428bc8eaf6201042cb...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
748
issue_to_patch
Update tui lib to 0.14.0
Fix breaking changes
e6711f60d689d7f0eb6b946ebf29c65fddbd7b88
d219cdaa559025b1329475fc3fe32daeda9de9c1
diff --git a/Cargo.lock b/Cargo.lock index 398e20f7..3e7d2960 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2111,9 +2111,9 @@ checksum = "59547bce71d9c38b83d9c0e92b6066c4253371f15005def0c30d9657f50c7642" [[package]] name = "tui" -version = "0.13.0" +version = "0.14.0" source = "registry+https://github.com/rust-lang...
[ "Cargo.lock", "Cargo.toml", "src/ui/mod.rs" ]
[]
true
Rigellute/spotify-tui
746
issue_to_patch
Bump serde_json from 1.0.61 to 1.0.63
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.61 to 1.0.63. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.63</h2> <ul> <li>Provide <code>Entry::and_modify</code> method on <a hr...
38c095884919bebc6c592d3662ddd1f9a93131f1
9f68bfce80dbbe47432d30a2e2474828a01a68fa
diff --git a/Cargo.lock b/Cargo.lock index 398e20f7..71e2efca 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1767,9 +1767,9 @@ dependencies = [ [[package]] name = "serde_json" -version = "1.0.61" +version = "1.0.63" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4fceb2595057b6891a4ee80...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
735
issue_to_patch
Bump serde_yaml from 0.8.15 to 0.8.17
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.8.15 to 0.8.17. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p> <blockquote> <h2>0.8.17</h2> <ul> <li>Add IntoDeserializer implementation to Value ...
38c095884919bebc6c592d3662ddd1f9a93131f1
59108c321400cca59ac7f21bc8612f5065970f32
diff --git a/Cargo.lock b/Cargo.lock index 398e20f7..5ab8f1bb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1790,9 +1790,9 @@ dependencies = [ [[package]] name = "serde_yaml" -version = "0.8.15" +version = "0.8.17" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "971be8f6e4d4a47163b405a...
[ "Cargo.lock" ]
[]
true
Rigellute/spotify-tui
747
issue_to_patch
docs: add sheepwall as a contributor
Adds @sheepwall as a contributor for code. This was requested by Rigellute [in this comment](https://github.com/Rigellute/spotify-tui/pull/743#issuecomment-787050485)
42b3670b553557fbed96cdfc5c087d3f9d53da16
2379c83e3e7d0d56b736c5cade625c7bd94ad55a
diff --git a/.all-contributorsrc b/.all-contributorsrc index 8b4c0eef..c29eae97 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -751,6 +751,15 @@ "contributions": [ "doc" ] + }, + { + "login": "sheepwall", + "name": "sheepwall", + "avatar_url": "https://avatars....
[ ".all-contributorsrc", "README.md" ]
[]
true
Rigellute/spotify-tui
743
issue_to_patch
app: add Daily Drive to Made For You lists search.
I often use Daily Drive, so I added it to the other Made For You entries in `app.rs`.
38c095884919bebc6c592d3662ddd1f9a93131f1
36f48aa5e90d879c6ce3bfe519205efd10861007
diff --git a/src/app.rs b/src/app.rs index ffd1f531..15770c96 100644 --- a/src/app.rs +++ b/src/app.rs @@ -1113,6 +1113,7 @@ impl App { const RELEASE_RADAR: &str = "Release Radar"; const ON_REPEAT: &str = "On Repeat"; const REPEAT_REWIND: &str = "Repeat Rewind"; + const DAILY_DRIVE: &str = "Daily Driv...
[ "src/app.rs" ]
[]
true
RightNow-AI/openfang
1,054
issue_to_patch
feat(discord): smart auto-thread mode (true/false/smart)
## Summary - Adds `auto_thread` config field to `DiscordConfig` with three modes: - `"true"` β€” always create a thread from each message - `"false"` β€” never create a thread (default, opt-in) - `"smart"` β€” create a thread only when the bot is @mentioned - Thread name is derived from the message content (strips men...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
0227ff17904e3bd99d5cf3f0a87ae03929b283fe
diff --git a/crates/openfang-api/src/channel_bridge.rs b/crates/openfang-api/src/channel_bridge.rs index feac4c7ac8..48a5b18c42 100644 --- a/crates/openfang-api/src/channel_bridge.rs +++ b/crates/openfang-api/src/channel_bridge.rs @@ -1185,6 +1185,7 @@ pub async fn start_channel_bridge_with_config( dc_...
[ "crates/openfang-api/src/channel_bridge.rs", "crates/openfang-channels/src/bridge.rs", "crates/openfang-channels/src/discord.rs", "crates/openfang-channels/src/types.rs", "crates/openfang-types/src/config.rs" ]
[]
true
RightNow-AI/openfang
1,100
issue_to_patch
channels/telegram: propagate send failures and cache terminal reaction errors
## Summary The Telegram adapter currently masks two classes of real failures as success. 1. **Send path** β€” `api_send_message` and its five sibling helpers (`api_send_photo`, `api_send_document`, `api_send_document_upload`, `api_send_voice`, `api_send_location`) log a `warn!` on HTTP non-success and return `Ok(())`. ...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
9fee63d58c7a1d0530f7dc1cd25ebbc1b7444478
diff --git a/crates/openfang-channels/src/telegram.rs b/crates/openfang-channels/src/telegram.rs index 6435b55836..515233dfdd 100644 --- a/crates/openfang-channels/src/telegram.rs +++ b/crates/openfang-channels/src/telegram.rs @@ -11,9 +11,9 @@ use crate::types::{ use async_trait::async_trait; use futures::Stream; u...
[ "crates/openfang-channels/src/telegram.rs" ]
[]
true
RightNow-AI/openfang
1,095
issue_to_patch
fix(runtime): pass HOME/TMP/TEMP to stdio MCP servers on all platforms
## Problem stdio MCP servers launched via `npx` (Gmail, AgentMail, Exa, and community servers generally) fail or misbehave on Linux and macOS because `HOME`, `TMP`, and `TEMP` are not passed through to the child process. npm, node, and npx need a writable `HOME` for the npm cache and `TMP` for scratch files; without t...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
e97eb6fff37f8adb969264323980bf2dd6ee54bd
diff --git a/crates/openfang-runtime/src/mcp.rs b/crates/openfang-runtime/src/mcp.rs index 483ae7aaac..13f5902845 100644 --- a/crates/openfang-runtime/src/mcp.rs +++ b/crates/openfang-runtime/src/mcp.rs @@ -247,6 +247,13 @@ impl McpConnection { if let Ok(path) = std::env::var("PATH") { cmd...
[ "crates/openfang-runtime/src/mcp.rs" ]
[]
true
RightNow-AI/openfang
1,176
issue_to_patch
Add Shift+Enter to insert new line in chat input ### Description Currently, pressing Shift + Enter in the chat input sends the message immediately. There is no way to insert a line break without sending the message. ### Expected Behavior Support Shift + Enter to create a new line (line break) while Enter alone stil...
fix(chat): support Shift+Enter for multi-line input and proper newline display
## Summary Fixes #1141 - Add Shift+Enter to insert new line in chat input ## Changes - **Web UI textarea**: Modified @keydown.enter handler to only call preventDefault() when Shift is NOT held, allowing Shift+Enter to insert newlines naturally - **escapeHtml function**: Added .replace(/\n/g, '<br>') to conv...
3cce1eb3fb19ad590a0937e039a8bf8bc09aba13
5e228336e42bc7818f9fa73c27a047b64637c26a
diff --git a/crates/openfang-api/static/index_body.html b/crates/openfang-api/static/index_body.html index 0b86ef822c..5f52b4cf69 100644 --- a/crates/openfang-api/static/index_body.html +++ b/crates/openfang-api/static/index_body.html @@ -739,7 +739,7 @@ <h3 style="margin:0 0 8px;font-size:16px;font-weight:600">Select ...
[ "crates/openfang-api/static/index_body.html", "crates/openfang-api/static/js/app.js" ]
[]
true
RightNow-AI/openfang
1,045
issue_to_patch
fix: system prompt and identity handling, and config form hydration
## Summary Fix issues where `system_prompt` and identity fields were not properly returned from the agent detail API or correctly populated in the UI when editing an agent. ## Changes * Expose `system_prompt` and full `identity` fields in the agent detail API response (`routes.rs`) * Ensure agent detail modal fet...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
93b57bdd524804da54d0998e2faf0aa199f24e91
diff --git a/crates/openfang-api/src/routes.rs b/crates/openfang-api/src/routes.rs index 14a2debfe4..4875ed099d 100644 --- a/crates/openfang-api/src/routes.rs +++ b/crates/openfang-api/src/routes.rs @@ -1409,11 +1409,15 @@ pub async fn get_agent( "network": entry.manifest.capabilities.network, ...
[ "crates/openfang-api/src/routes.rs", "crates/openfang-api/static/js/pages/agents.js" ]
[]
true
RightNow-AI/openfang
1,143
issue_to_patch
Discord image attachments are silently dropped on text-only model providers ## Summary When a Discord user sends an image attachment to an OpenFang agent β€” either with a caption or bare β€” the attachment is silently discarded before it reaches the model on text-only providers (e.g. the `claude_code` driver). The model...
fix(channels/discord): surface image attachments to text-only providers
## Summary Fixes #1142. Discord image attachments were silently dropped before reaching the model on text-only providers. Captioned images had attachments discarded (caption-wins path); bare-image messages were dropped entirely (early `content.is_empty()` return). Result: hallucinated acknowledgements of unseen image...
3cce1eb3fb19ad590a0937e039a8bf8bc09aba13
701fcd8e2ee2af07bbef31d9dda8c41097bbe113
diff --git a/crates/openfang-channels/src/bridge.rs b/crates/openfang-channels/src/bridge.rs index a1aecae623..16271d6e7c 100644 --- a/crates/openfang-channels/src/bridge.rs +++ b/crates/openfang-channels/src/bridge.rs @@ -858,6 +858,93 @@ async fn dispatch_message( return; } + // Multipart: flatten ...
[ "crates/openfang-channels/src/bridge.rs", "crates/openfang-channels/src/discord.rs", "crates/openfang-channels/src/telegram.rs", "crates/openfang-channels/src/types.rs", "crates/openfang-channels/src/whatsapp.rs", "crates/openfang-kernel/src/kernel.rs", "crates/openfang-runtime/src/drivers/claude_code.r...
[]
true
RightNow-AI/openfang
1,168
issue_to_patch
LaTeX/Mathematical Equations Not Rendering in Chat in Openfang Web ### Description When markdown files containing LaTeX equations (enclosed in `$...$` or `$$...$$`) are viewed in OpenFang's web dashboard or embedded views, the mathematical notation does not render. The raw LaTeX code is displayed as plain text instea...
fix: render LaTeX math in chat messages
## Summary Fixes #1167 - LaTeX math not rendering in chat ## Changes - **webchat.rs**: CSP updated to allow `https://cdn.jsdelivr.net` for scripts, styles, fonts, and connect-src - **chat.js**: MutationObserver in `init()` watches for new `.message-bubble` elements and calls `renderLatex()` automatically ## Testing...
3cce1eb3fb19ad590a0937e039a8bf8bc09aba13
5c1b1508a253cae138dc6ab8c30597e37ff55615
diff --git a/crates/openfang-api/src/webchat.rs b/crates/openfang-api/src/webchat.rs index e0f6926f9f..14f44c62e1 100644 --- a/crates/openfang-api/src/webchat.rs +++ b/crates/openfang-api/src/webchat.rs @@ -90,11 +90,11 @@ pub async fn webchat_page() -> impl IntoResponse { let html = WEBCHAT_HTML.replace(NONCE_PLA...
[ "crates/openfang-api/src/webchat.rs", "crates/openfang-api/static/js/pages/chat.js" ]
[]
true
RightNow-AI/openfang
1,147
issue_to_patch
channels: harden channel_id binding β€” strict wrapper, explicit adapter allowlist, full guild+channel context ## Description `d336314` introduced `channel_id` matching on `BindingMatchRule` with `deny_unknown_fields` and a `sender_channel_id` heuristic in the bridge. In production use on a fork tracking `main`, three ...
feat(channels): harden channel_id binding β€” adapter allowlist, strict validation, single source of truth for routing
## Summary Fixes #1144. Layers richer config validation, an explicit adapter allowlist, and a stricter bridge routing path on top of upstream `d336314` ("binding rule"), which shipped the same `channel_id` field as PR #1127 in a parallel implementation. Replaces upstream's `sender_user_id`/`platform_id` heuristic wit...
15ed29c667c19db4af749a7a5ce096e85e09610a
913081143326157f210a3a65240d8cfc481ec55a
diff --git a/crates/openfang-channels/src/bridge.rs b/crates/openfang-channels/src/bridge.rs index a1aecae623..ecfaabd408 100644 --- a/crates/openfang-channels/src/bridge.rs +++ b/crates/openfang-channels/src/bridge.rs @@ -4,7 +4,7 @@ //! `BridgeManager` which owns running adapters and dispatches messages. use crat...
[ "crates/openfang-channels/src/bridge.rs", "crates/openfang-channels/src/types.rs", "crates/openfang-types/src/config.rs", "docs/channel-adapters.md" ]
[]
true
RightNow-AI/openfang
1,146
issue_to_patch
kernel: lenient binding parsing β€” one typo no longer drops the entire bindings table ## Description A single misspelled field anywhere in `[[bindings]]` currently causes the **entire** bindings table to fail parsing at config load. Because `KernelConfig` deliberately does not use `deny_unknown_fields` at the top leve...
fix(kernel): lenient binding parsing β€” one typo no longer drops the entire bindings table
## Summary Fixes #1145. A single misspelled field anywhere in `[[bindings]]` currently causes the entire bindings table to fail parsing at config load. Because `KernelConfig` deliberately does not use `deny_unknown_fields` at the top level (forward-compat with new sections), the failure surfaces as a silent default: ...
15ed29c667c19db4af749a7a5ce096e85e09610a
325734c6aa24c7f8de3ff4b48e5e434d8b42a75f
diff --git a/crates/openfang-kernel/src/config.rs b/crates/openfang-kernel/src/config.rs index c518d85b6c..8e1b66b036 100644 --- a/crates/openfang-kernel/src/config.rs +++ b/crates/openfang-kernel/src/config.rs @@ -69,12 +69,26 @@ pub fn load_config(path: Option<&Path>) -> KernelConfig { } ...
[ "crates/openfang-kernel/src/config.rs" ]
[]
true
RightNow-AI/openfang
1,175
issue_to_patch
Fix getting started documentation links
## Summary - add .md extensions to local documentation links in docs/getting-started.md so they resolve on GitHub and locally ## Verification - checked local Markdown links in docs/getting-started.md - git diff --check
3cce1eb3fb19ad590a0937e039a8bf8bc09aba13
8b10930e40ee1654038adadb71b35ffc240e7e75
diff --git a/docs/getting-started.md b/docs/getting-started.md index a06379f1da..0a2d1a23bb 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -326,11 +326,11 @@ The embedded WebChat UI allows you to: Now that you have OpenFang running: - **Explore agent templates**: Browse the `agents/` director...
[ "docs/getting-started.md" ]
[]
true
RightNow-AI/openfang
1,135
issue_to_patch
build(deps): bump open from 5.3.3 to 5.3.4
Bumps [open](https://github.com/Byron/open-rs) from 5.3.3 to 5.3.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Byron/open-rs/releases">open's releases</a>.</em></p> <blockquote> <h2>v5.3.4</h2> <h3>Bug Fixes</h3> <ul> <li>align with_detached() implementation with with() O...
3cce1eb3fb19ad590a0937e039a8bf8bc09aba13
24aca4e31d3e7b158768e857b61cca536142fd6d
diff --git a/Cargo.lock b/Cargo.lock index fb5aa5cc15..bf695f4b50 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3947,9 +3947,9 @@ checksum = "c08d65885ee38876c4f86fa503fb49d7b507c2b62552df7c70b2fce627e06381" [[package]] name = "open" -version = "5.3.3" +version = "5.3.4" source = "registry+https://github.com/rust-l...
[ "Cargo.lock" ]
[]
true
RightNow-AI/openfang
1,061
issue_to_patch
build(deps): bump softprops/action-gh-release from 2 to 3
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/softprops/action-gh-release/releases">softprops/action-gh-release's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <p><code>3.0...
6851bbab096993f0037deb97b9c27fe03593cbdc
c9701627a978f9f34951722edbc4c35ba08ee156
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 62d45a0432..cfd663dcf7 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -204,7 +204,7 @@ jobs: $hash = (Get-FileHash "openfang-${{ matrix.target }}.zip" -Algorithm SHA256).Hash.ToLower() ...
[ ".github/workflows/release.yml" ]
[]
true
RightNow-AI/openfang
1,091
issue_to_patch
fix(clippy): resolve upstream Clippy warnings breaking CI on main
## Summary Resolves 9 Clippy warnings currently breaking the Clippy CI job on \`main\` (confirmed failing as of v0.6.0). All fixes are in upstream code β€” no new features, no behaviour changes. ### Warnings fixed | File | Lint | Fix | |------|------|-----| | \`openfang-runtime/src/drivers/gemini.rs\` | \`collapsible...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
a8ada8f252743c01cb9a243f357029c3d8e3cd27
diff --git a/crates/openfang-api/src/routes.rs b/crates/openfang-api/src/routes.rs index 14a2debfe4..ba7690c3a3 100644 --- a/crates/openfang-api/src/routes.rs +++ b/crates/openfang-api/src/routes.rs @@ -6287,7 +6287,7 @@ pub async fn list_providers(State(state): State<Arc<AppState>>) -> impl IntoResp // Index prob...
[ "crates/openfang-api/src/routes.rs", "crates/openfang-channels/src/irc.rs", "crates/openfang-cli/src/tui/screens/agents.rs", "crates/openfang-cli/src/tui/screens/audit.rs", "crates/openfang-cli/src/tui/screens/comms.rs", "crates/openfang-cli/src/tui/screens/extensions.rs", "crates/openfang-cli/src/tui/s...
[]
true
RightNow-AI/openfang
1,112
issue_to_patch
build(deps): bump lettre from 0.11.20 to 0.11.21
[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [lettre](https://github.com/lettre/le...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
40bd7e2c1150a4113536b09abf176a86f939fded
diff --git a/Cargo.lock b/Cargo.lock index 2ca1a27262..ef5c4f7d7e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -139,7 +139,7 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc" dependencies = [ - "windows-s...
[ "Cargo.lock" ]
[]
true
RightNow-AI/openfang
1,111
issue_to_patch
build(deps): bump libc from 0.2.183 to 0.2.185
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.183 to 0.2.185. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/libc/releases">libc's releases</a>.</em></p> <blockquote> <h2>0.2.185</h2> <h3>Added</h3> <ul> <li>EspIDF: Add <code>espidf_picolibc</code> cfg fo...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
a7197d7b97509ad29e6ef658903f937d80195a18
diff --git a/Cargo.lock b/Cargo.lock index 2ca1a27262..f57bc5c7fd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -139,7 +139,7 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc" dependencies = [ - "windows-s...
[ "Cargo.lock" ]
[]
true
RightNow-AI/openfang
1,110
issue_to_patch
build(deps): bump rustls from 0.23.37 to 0.23.39
Bumps [rustls](https://github.com/rustls/rustls) from 0.23.37 to 0.23.39. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rustls/rustls/commit/05416057db6a08b70581c179f9fb32144e288b30"><code>0541605</code></a> Cargo: version 0.23.38 -&gt; 0.23.39</li> <li><a href="https://github.com/rustls/rus...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
bc26d5e8c33f08effb2f669a78466c8606d128a9
diff --git a/Cargo.lock b/Cargo.lock index 2ca1a27262..be673e811f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5709,9 +5709,9 @@ dependencies = [ [[package]] name = "rustls" -version = "0.23.37" +version = "0.23.39" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "758025cb5fccfd3bc2fd7...
[ "Cargo.lock" ]
[]
true
RightNow-AI/openfang
1,109
issue_to_patch
build(deps): bump uuid from 1.23.0 to 1.23.1
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.23.0 to 1.23.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uuid-rs/uuid/releases">uuid's releases</a>.</em></p> <blockquote> <h2>v1.23.1</h2> <h2>What's Changed</h2> <ul> <li>Remove deprecated <code>msrv</code> feature ...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
84d90ad34296e6f291689e13fe2f31b87a9d86d6
diff --git a/Cargo.lock b/Cargo.lock index 2ca1a27262..4f5d031203 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -7042,7 +7042,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "32497e9a4c7b38532efcdebeef879707aa9f794296a4f0244f6f69e9bc8574bd" dependencies = [ "fastrand", - "getrandom 0....
[ "Cargo.lock" ]
[]
true
RightNow-AI/openfang
1,060
issue_to_patch
fix(security): unify SSRF protection for WASM host calls
## Summary The WASM sandbox `host_net_fetch()` has its own SSRF implementation (`is_ssrf_target`) that diverged from the canonical `check_ssrf()` in `web_fetch.rs`. This creates a security gap where WASM agents can bypass protections that builtin tools correctly enforce. ### Issues found in `host_functions.rs::is_ssr...
d3d9fa842de608f863ca929ae1a7abd05d1f21a6
de8a692036a024eb52411d7e1ccdc3dbc0f29d43
diff --git a/crates/openfang-kernel/src/kernel.rs b/crates/openfang-kernel/src/kernel.rs index fc6c77f0e0..fad4707cf4 100644 --- a/crates/openfang-kernel/src/kernel.rs +++ b/crates/openfang-kernel/src/kernel.rs @@ -2253,6 +2253,7 @@ impl OpenFangKernel { max_memory_bytes: entry.manifest.resources.max_memor...
[ "crates/openfang-kernel/src/kernel.rs", "crates/openfang-runtime/src/host_functions.rs", "crates/openfang-runtime/src/sandbox.rs", "crates/openfang-runtime/src/web_fetch.rs" ]
[]
true
RightNow-AI/openfang
1,058
issue_to_patch
fix(hands): correct trader dashboard style
## Summary Fixed two styling issues in the Hands page of the trader dashboard: - **Content overlap**: The absolutely positioned `.trader-chart-empty` element was incorrectly positioned relative to `trader-dashboard`, blocking window content and preventing scrolling. - **Transparent background**: The window backg...
6851bbab096993f0037deb97b9c27fe03593cbdc
643a22b295208f10e02785dd4fc41fc429dab320
diff --git a/crates/openfang-api/static/css/components.css b/crates/openfang-api/static/css/components.css index ff8a74dfd8..74ba0d6dd4 100644 --- a/crates/openfang-api/static/css/components.css +++ b/crates/openfang-api/static/css/components.css @@ -3253,7 +3253,7 @@ mark.search-highlight { ═══════════════════════...
[ "crates/openfang-api/static/css/components.css" ]
[]
true
RightNow-AI/openfang
1,126
issue_to_patch
chore: add health stack and stabilize provider env tests
## Summary - add a `## Health Stack` section to `AGENTS.md` - stabilize provider driver tests that mutate process-wide environment variables - restore deterministic `cargo test --workspace` results for clean upstream checkouts ## Root cause Several tests in `crates/openfang-runtime/src/drivers/mod.rs` were using `st...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
e88896678e9cad06cfd740ca768b35b3c29f0c4b
diff --git a/AGENTS.md b/AGENTS.md new file mode 100644 index 0000000000..031acea41c --- /dev/null +++ b/AGENTS.md @@ -0,0 +1,6 @@ +## Health Stack + +- typecheck: cargo build --workspace --lib +- lint: cargo clippy --workspace --all-targets -- -D warnings +- test: cargo test --workspace +- shell: shellcheck scripts/in...
[ "AGENTS.md", "crates/openfang-runtime/src/drivers/mod.rs" ]
[]
true
RightNow-AI/openfang
1,130
issue_to_patch
claude-code driver: hardcoded per-message timeout with no operator-facing config knob ## Description The `claude-code` LLM driver hardcodes its per-message turn timeout inside `ClaudeCodeDriver` and exposes no operator-facing knob β€” neither through `DriverConfig` nor an environment variable. Long-running CC subproces...
fix(runtime): add subprocess timeout config for claude-code driver
## Summary The `claude-code` driver hardcoded its per-message turn timeout inside `ClaudeCodeDriver` and exposed no operator-facing knob, so long-running CC subprocess turns (large prompt-caches, deep tool chains) hit the internal default with no escape hatch. This PR adds a complete config surface β€” env var + `config...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
b1c4061247451d1c0af66740fa85e3d660e3ef3e
diff --git a/crates/openfang-api/src/routes.rs b/crates/openfang-api/src/routes.rs index 14a2debfe4..53dd259f08 100644 --- a/crates/openfang-api/src/routes.rs +++ b/crates/openfang-api/src/routes.rs @@ -7531,6 +7531,7 @@ pub async fn set_provider_key( model: model_id, api_key_e...
[ "crates/openfang-api/src/routes.rs", "crates/openfang-api/tests/api_integration_test.rs", "crates/openfang-api/tests/daemon_lifecycle_test.rs", "crates/openfang-api/tests/load_test.rs", "crates/openfang-api/tests/skill_config_api_test.rs", "crates/openfang-channels/src/bridge.rs", "crates/openfang-chann...
[]
diff --git a/crates/openfang-api/tests/api_integration_test.rs b/crates/openfang-api/tests/api_integration_test.rs index 2c0bce1d4a..48f5cb6497 100644 --- a/crates/openfang-api/tests/api_integration_test.rs +++ b/crates/openfang-api/tests/api_integration_test.rs @@ -61,6 +61,7 @@ async fn start_test_server_with_provide...
true
RightNow-AI/openfang
1,118
issue_to_patch
Agent configuration not updating in SQL database ### Description Upon change in the agent configuration in `agent.toml`, the changes are not being updated in the SQL database, unless the change happened to one of the parameters listed in the block in kernel.rs: [https://github.com/RightNow-AI/openfang/blob/e6bab993ae...
fix(kernel): sync all agent.toml fields to DB on restart
Fixes #1087 ## Problem The TOML-vs-DB change detection at boot time only compared a subset of `AgentManifest` fields (`name`, `description`, `model.*`, `capabilities.tools`, `tool_allowlist`, `tool_blocklist`, `skills`, `mcp_servers`). Key fields like `workspace`, `schedule`, `resources`, `autonomous`, and `exec_poli...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
31021719d3f23f36ce4ff479ecc1e085a7ff7d1b
diff --git a/crates/openfang-kernel/src/kernel.rs b/crates/openfang-kernel/src/kernel.rs index 7a39e7bafb..3c3b3d5c25 100644 --- a/crates/openfang-kernel/src/kernel.rs +++ b/crates/openfang-kernel/src/kernel.rs @@ -1196,7 +1196,11 @@ impl OpenFangKernel { &toml_str, ...
[ "crates/openfang-kernel/src/kernel.rs", "crates/openfang-types/src/agent.rs", "crates/openfang-types/src/config.rs" ]
[]
true
RightNow-AI/openfang
1,099
issue_to_patch
OpenFang v0.6.0 When you schedule a task, it reaches the agent, but the result isn't displayed in the CHAT!!!! When you schedule a task, it reaches the agent, but the result isn't displayed in the CHAT!!! If you schedule a simple 5-minute task, for example, "Notify me that I have a meeting with the developer on duty,...
fix(ws): broadcast cron job results to WebSocket clients in real-time
## Summary Fixes #1088 β€” Scheduled task results now appear in the web UI in real-time via WebSocket push, without requiring a page refresh. ## Problem When a cron job fires, the result was only delivered to configured channels (Telegram, etc.) via `cron_deliver_response`. WebSocket clients had no mechanism to receiv...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
5a86141677ef5bb49e563597c9c89128fcae4ecf
diff --git a/crates/openfang-api/src/server.rs b/crates/openfang-api/src/server.rs index ed773fcb7b..09118af2c7 100644 --- a/crates/openfang-api/src/server.rs +++ b/crates/openfang-api/src/server.rs @@ -54,6 +54,10 @@ pub async fn build_router( budget_config: Arc::new(tokio::sync::RwLock::new(kernel.config.bud...
[ "crates/openfang-api/src/server.rs", "crates/openfang-api/src/ws.rs", "crates/openfang-api/static/js/pages/chat.js", "crates/openfang-kernel/src/kernel.rs", "crates/openfang-kernel/src/triggers.rs", "crates/openfang-migrate/src/openclaw.rs", "crates/openfang-types/src/event.rs" ]
[]
true
RightNow-AI/openfang
1,114
issue_to_patch
Heartbeat marks idle reactive agents as `Crashed`, conflating silence with failure ### Description ### Title Heartbeat marks idle reactive agents as `Crashed`, conflating silence with failure ### Summary The kernel heartbeat monitor marks an agent `Unresponsive` after 60s of inactivity and `Crashed` after...
fix(kernel): avoid crashing idle reactive agents
Closes #1102 ## Summary - exempt idle reactive agents from heartbeat crash handling when they are not actively processing a turn - restore any incorrectly crashed idle reactive agent back to `Running` and reset its recovery tracker state - add focused heartbeat coverage for reactive-vs-periodic idle behavior ## Testi...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
356500bb1eca1032e4c9acf18267ed904225c333
diff --git a/crates/openfang-api/src/routes.rs b/crates/openfang-api/src/routes.rs index 14a2debfe4..b2e7355555 100644 --- a/crates/openfang-api/src/routes.rs +++ b/crates/openfang-api/src/routes.rs @@ -8030,7 +8030,9 @@ fn build_skill_config_snapshot( .read() .unwrap_or_else(|e| e.into_inner(...
[ "crates/openfang-api/src/routes.rs", "crates/openfang-api/tests/api_integration_test.rs", "crates/openfang-api/tests/skill_config_api_test.rs", "crates/openfang-cli/src/tui/mod.rs", "crates/openfang-cli/src/tui/screens/skills.rs", "crates/openfang-kernel/src/cron_delivery.rs", "crates/openfang-kernel/sr...
[]
diff --git a/crates/openfang-api/tests/api_integration_test.rs b/crates/openfang-api/tests/api_integration_test.rs index 2c0bce1d4a..5bed150c0f 100644 --- a/crates/openfang-api/tests/api_integration_test.rs +++ b/crates/openfang-api/tests/api_integration_test.rs @@ -1156,7 +1156,10 @@ async fn test_commands_invalid_sur...
true
RightNow-AI/openfang
1,123
issue_to_patch
Router default-agent state is keyed inconsistently β€” defaults bleed across channels and collide between users ### Description The Discord and Slack channel adapters store and look up "default agent per channel" using keys that don't include the invoking user. As a result, `/agent <name>` writes overwrite each other a...
fix(channels): key router default-agent map on user_id, not channel_id
## Summary Fixes #1120 The Discord and Slack adapters populate `ChannelMessage.sender.platform_id` with the channel/conversation ID (required by the send path). The router's default-agent map was keyed on `sender.platform_id` on both reads and writes, so every per-user default was effectively stored under the ...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
4ae2961b1c16304a5aff7d8d78c20a2cb22a3a3c
diff --git a/crates/openfang-channels/src/bridge.rs b/crates/openfang-channels/src/bridge.rs index 522f4b6773..29e702524f 100644 --- a/crates/openfang-channels/src/bridge.rs +++ b/crates/openfang-channels/src/bridge.rs @@ -421,6 +421,26 @@ impl BridgeManager { adapter: Arc<dyn ChannelAdapter>, ) -> Result...
[ "crates/openfang-channels/src/bridge.rs", "crates/openfang-channels/src/discord.rs", "crates/openfang-channels/src/slack.rs" ]
[]
true
RightNow-AI/openfang
1,090
issue_to_patch
Streaming agent loop missing touch_agent β†’ heartbeat false-positives on selected local LLMs ## Description When multiple agents are active and using a local Ollama backend, their LLM requests queue behind each other. Each queued agent waits silently β€” no tokens flowing, no activity the heartbeat monitor can see β€” an...
Stamp last_active in streaming agent loop to prevent heartbeat false-positives
Fixes #1089 ## What `run_agent_loop_streaming` was missing the `touch_agent()` call that the non-streaming `run_agent_loop` performs before every LLM request. This causes `last_active` to go stale during slow streaming generations, and the heartbeat monitor flags the agent as unresponsive mid-stream β€” triggering a cr...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
f2587995a2c0b9e75f9aebaf00e4e42b51a19e68
diff --git a/crates/openfang-runtime/src/agent_loop.rs b/crates/openfang-runtime/src/agent_loop.rs index 0ac10ae43e..e8fe616565 100644 --- a/crates/openfang-runtime/src/agent_loop.rs +++ b/crates/openfang-runtime/src/agent_loop.rs @@ -1657,6 +1657,12 @@ pub async fn run_agent_loop_streaming( } } ...
[ "crates/openfang-runtime/src/agent_loop.rs" ]
[]
true
RightNow-AI/openfang
1,082
issue_to_patch
Lark websocket error I use Lark, have error when config [channels.feishu] -> mode = "websocket" 2026-04-18T16:15:55.219540Z ERROR openfang_channels::feishu: Feishu WebSocket error: Feishu WebSocket endpoint error: 2026-04-18T16:15:55.219603Z WARN openfang_channels::feishu: Feishu WebSocket reconnecting in 1s
fix(feishu): respect region setting for WebSocket endpoint URL
Fixes #1081 ## Problem When a user configures the Feishu/Lark channel with `mode = "websocket"` and `region = "lark"` (international), the WebSocket connection fails with: ``` ERROR openfang_channels::feishu: Feishu WebSocket error: Feishu WebSocket endpoint error: WARN openfang_channels::feishu: Feishu WebSocket r...
d3d9fa842de608f863ca929ae1a7abd05d1f21a6
45e7ea794888e58e9a44010107f8899caa620c2d
diff --git a/crates/openfang-api/src/channel_bridge.rs b/crates/openfang-api/src/channel_bridge.rs index 325c5e6364..853493815b 100644 --- a/crates/openfang-api/src/channel_bridge.rs +++ b/crates/openfang-api/src/channel_bridge.rs @@ -1458,9 +1458,10 @@ pub async fn start_channel_bridge_with_config( ...
[ "crates/openfang-api/src/channel_bridge.rs", "crates/openfang-channels/src/feishu.rs" ]
[]
true
RightNow-AI/openfang
1,080
issue_to_patch
MiniMax provider not available in openfang init ### Description Main readme at https://github.com/RightNow-AI/openfang claims that MiniMax provider is available - but it is not possible to select it in "openfang init" command. Thus it is impossible to complete the onboarding process and actually use openfang. ### Ex...
fix: expose MiniMax in openfang init
## Summary - add MiniMax to the `openfang init` provider picker - add MiniMax to the legacy setup wizard provider list - expose MiniMax in the quick provider list and cover all three paths with regression tests ## Validation - `cargo test -p openfang-cli minimax -- --nocapture` - `cargo clippy -p openfang-cli --all-ta...
d3d9fa842de608f863ca929ae1a7abd05d1f21a6
8d3d77dd99344de91fc4031e312b99eccaf4edd1
diff --git a/crates/openfang-cli/src/main.rs b/crates/openfang-cli/src/main.rs index a60f4725fe..62e728ba97 100644 --- a/crates/openfang-cli/src/main.rs +++ b/crates/openfang-cli/src/main.rs @@ -1476,9 +1476,30 @@ fn provider_list() -> Vec<(&'static str, &'static str, &'static str, &'static st "openrouter/...
[ "crates/openfang-cli/src/main.rs", "crates/openfang-cli/src/tui/screens/init_wizard.rs", "crates/openfang-cli/src/tui/screens/wizard.rs" ]
[]
true
RightNow-AI/openfang
1,063
issue_to_patch
Fix NixOS build: nativeBuildInputs, wrapGAppsHook3, libayatana-appindicator runtime closure
## Summary Four independent fixes to `flake.nix` that together make a clean `nix build .#openfang-cli` and `nix build .#openfang-desktop` work on NixOS. Each is a real upstream bug, not a NixOS-only quirk β€” NixOS just surfaces them because it doesn't have system-wide `/usr/lib` as a fallback. Tested on: - NixOS 26.05...
6851bbab096993f0037deb97b9c27fe03593cbdc
72fe28f3f2cba3efe11e7be23bfa393277a0f5f6
diff --git a/flake.nix b/flake.nix index 999cc5c66a..1600ae943c 100644 --- a/flake.nix +++ b/flake.nix @@ -22,20 +22,35 @@ ... }: { rust-project.src = lib.sources.cleanSource ./.; + rust-project.defaults.perCrate.crane.args.nativeBuildInputs = with pkgs; [ + clang + per...
[ "flake.nix" ]
[]
true
RightNow-AI/openfang
1,124
issue_to_patch
Feature request: Configurable STT, TTS and image generation URL and local backends ### Description # Feature Request: Configurable STT/TTS and image generation API Endpoints Currently the OpenFang partially supports tools for speech-to text, text-to-speech and image generation (all are mentioned in project roadmap)....
feat(media): add audio_base_url override for local OpenAI-compat Whisper (closes #1051)
Adds optional `audio_base_url` to `MediaConfig` that overrides the hardcoded provider URLs in `media_understanding::transcribe_audio`, allowing the same OpenAI-compatible multipart wire format to be sent to a local Whisper service (Speaches, faster-whisper-server, LM Studio, etc.). **Closes #1051.** ## Wire format un...
e6bab993aebd0081e2a1f9a7b7a8968939a6d831
e0310d33615f1f45d34478f39824f5303a5c7176
diff --git a/crates/openfang-runtime/src/media_understanding.rs b/crates/openfang-runtime/src/media_understanding.rs index 452db86cdb..7f014011ba 100644 --- a/crates/openfang-runtime/src/media_understanding.rs +++ b/crates/openfang-runtime/src/media_understanding.rs @@ -114,16 +114,54 @@ impl MediaEngine { l...
[ "crates/openfang-runtime/src/media_understanding.rs", "crates/openfang-types/src/media.rs" ]
[]
true
RightNow-AI/openfang
1,041
issue_to_patch
fix(deps): upgrade wasmtime 41->43 and rumqttc 0.24->0.25 to resolve active CVEs
Fixes RUSTSEC-2026-0095/0096 (critical wasmtime sandbox escapes) and RUSTSEC-2026-0049 (rustls-webpki via rumqttc). Cargo.toml + Cargo.lock + sandbox.rs wasmtime 43 API fix.
6851bbab096993f0037deb97b9c27fe03593cbdc
890ab8c1776bb45a1e85166cc8f719c1341a3b4e
diff --git a/Cargo.lock b/Cargo.lock index 55e1647fe9..3e51ea7da9 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4,9 +4,9 @@ version = 4 [[package]] name = "addr2line" -version = "0.25.1" +version = "0.26.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "1b5d307320b3181d6d7954e663bd7c7...
[ "Cargo.lock", "Cargo.toml", "crates/openfang-api/src/lib.rs", "crates/openfang-api/src/ws.rs", "crates/openfang-cli/src/main.rs", "crates/openfang-cli/src/tui/screens/init_wizard.rs", "crates/openfang-kernel/src/kernel.rs", "crates/openfang-runtime/src/compactor.rs", "crates/openfang-runtime/src/dri...
[]
true
RightNow-AI/openfang
1,077
issue_to_patch
schedule_create tool registers schedules that never fire β€” two disconnected scheduler systems ## Description The `schedule_create` tool exposed to Hands (see `tool_runner.rs:2096`) appears to register a recurring task, but the registered schedule never fires. This silently breaks every Hand that relies on the Phase 1...
fix(scheduler): route schedule_* tools and /api/schedules through kernel cron scheduler (#1069)
Fixes #1069. ## What Route the `schedule_create`, `schedule_list`, `schedule_delete` tools and the `/api/schedules*` HTTP endpoints through the kernel cron scheduler (`openfang-kernel::CronScheduler`) so scheduled jobs actually fire. ## Why Before this change there were two unrelated "scheduler" subsystems: 1. The...
983519c8e8602a5d0951567aedbff2ee17d4f7f1
511eb1d4594a2ad6ed1d98bc3492972b0632cfcf
diff --git a/crates/openfang-api/src/routes.rs b/crates/openfang-api/src/routes.rs index 6876bbf291..952fc93263 100644 --- a/crates/openfang-api/src/routes.rs +++ b/crates/openfang-api/src/routes.rs @@ -8321,40 +8321,66 @@ pub async fn reload_integrations(State(state): State<Arc<AppState>>) -> impl Int // ------------...
[ "crates/openfang-api/src/routes.rs", "crates/openfang-kernel/src/kernel.rs", "crates/openfang-runtime/src/tool_runner.rs" ]
[]
true
RightNow-AI/openfang
1,073
issue_to_patch
Multimodal messages drop user text when image attachments are present ## Bug Description When a user sends a message with image attachments via the upload API (`POST /api/agents/{id}/upload` followed by `POST /api/agents/{id}/message` with `attachments`), the user's text message is silently dropped. The LLM receives ...
fix(runtime): combine text and image blocks in multimodal user messages (#1043)
## What Combine the user's text and any attached image content blocks into a single multimodal `Message::user_with_blocks` when both are present. Keeps existing behavior when only text or only images are supplied. ## Why Fixes #1043. When a client called `POST /api/agents/{id}/upload` followed by `POST /api/agents/{...
983519c8e8602a5d0951567aedbff2ee17d4f7f1
bfd056588ff861e204cc31bae5b96fad61c837b1
diff --git a/crates/openfang-runtime/src/agent_loop.rs b/crates/openfang-runtime/src/agent_loop.rs index 9a96ca3393..0ac10ae43e 100644 --- a/crates/openfang-runtime/src/agent_loop.rs +++ b/crates/openfang-runtime/src/agent_loop.rs @@ -165,6 +165,30 @@ pub struct AgentLoopResult { pub directives: openfang_types::me...
[ "crates/openfang-runtime/src/agent_loop.rs" ]
[]
true
RightNow-AI/openfang
1,072
issue_to_patch
Channel bridge: prefix outbound messages with agent name ## Feature Request When multiple agents are active and routable via channels (Discord, Telegram, etc.), there's no way for the user to know which agent is responding. The agent name should be visible in the message without requiring system prompt hacks. ## Pro...
feat(channels): optional agent name prefix on outbound messages (#980)
Closes #980. ## What New opt-in per-channel config `prefix_agent_name` on `ChannelOverrides` that wraps the outbound agent response with the responding agent's name so users in multi-agent channels can tell who replied. ``` [platform-architect] Here's my assessment... **[platform-architect]** Here's my assessment......
983519c8e8602a5d0951567aedbff2ee17d4f7f1
607c271a1c1dc5f1bb16af4010d5250716cbd730
diff --git a/crates/openfang-channels/src/bridge.rs b/crates/openfang-channels/src/bridge.rs index c0cb89710a..24b668c3d7 100644 --- a/crates/openfang-channels/src/bridge.rs +++ b/crates/openfang-channels/src/bridge.rs @@ -14,7 +14,7 @@ use dashmap::DashMap; use futures::StreamExt; use openfang_types::agent::AgentId;...
[ "crates/openfang-channels/src/bridge.rs", "crates/openfang-types/src/config.rs" ]
[]
true
RightNow-AI/openfang
1,076
issue_to_patch
openfang config get default_model.base_url returns empty string ## Problem `openfang config get default_model.base_url` returns an empty string even when config.toml has the value set correctly. ```toml # config.toml [default_model] provider = "openai" model = "qwen3-coder-30b/qwen3-coder-30b" base_url = "http://loc...
fix(cli): config get returns base_url from default_model (#905)
Fixes #905. ## What Refactor `openfang config get` to use a pure `lookup_config_value` helper and add unit tests that pin down the behaviour for every scalar under `[default_model]`, including `base_url`. ## Why The existing code path for `config get default_model.base_url` had no unit coverage, so the report that it...
983519c8e8602a5d0951567aedbff2ee17d4f7f1
59c59d91d3e303401f33c99a91cfc8cdc404f680
diff --git a/crates/openfang-cli/src/main.rs b/crates/openfang-cli/src/main.rs index 8aa4b7f0b2..bfdd2692a7 100644 --- a/crates/openfang-cli/src/main.rs +++ b/crates/openfang-cli/src/main.rs @@ -4751,6 +4751,38 @@ fn cmd_config_edit() { } } +/// Outcome of looking up a dotted key path in a parsed TOML config. +...
[ "crates/openfang-cli/src/main.rs" ]
[]
true
RightNow-AI/openfang
1,075
issue_to_patch
Agent context.md not refreshed during active conversation session ## Description When an agent has a `context.md` file that is updated externally (e.g., by a cron job), the updated content is **not reflected in the active conversation session**. The agent continues to use the context from when the session started. #...
fix(runtime): re-read agent context.md per turn so external updates take effect (#843)
## Summary Fixes #843. Agents with a workspace `context.md` file (e.g. MIA-style trading bots whose cron job rewrites the file with live MT5 data every minute) would never see updated content during an active conversation. The file was read once and then cached for the rest of the session. ## What changed - New `ope...
983519c8e8602a5d0951567aedbff2ee17d4f7f1
c6082184ae3e27087093e31cb0d56bcbacf5e871
diff --git a/crates/openfang-kernel/src/heartbeat.rs b/crates/openfang-kernel/src/heartbeat.rs index ddfe0488da..dbec05ae05 100644 --- a/crates/openfang-kernel/src/heartbeat.rs +++ b/crates/openfang-kernel/src/heartbeat.rs @@ -335,6 +335,7 @@ mod tests { exec_policy: None, tool_allowli...
[ "crates/openfang-kernel/src/heartbeat.rs", "crates/openfang-kernel/src/kernel.rs", "crates/openfang-kernel/src/registry.rs", "crates/openfang-kernel/src/wizard.rs", "crates/openfang-runtime/src/agent_context.rs", "crates/openfang-runtime/src/lib.rs", "crates/openfang-runtime/src/prompt_builder.rs", "c...
[]
true
RightNow-AI/openfang
1,074
issue_to_patch
CLI Missing 'hand config' command mentioned in documentation The documentation at https://www.openfang.sh/docs/hands mentions the command: ```bash openfang hand config browser --set headless=true ``` However, this command does not exist in the current CLI. Running `openfang hand --help` shows the following subcomman...
feat(cli): add hand config subcommand (#809)
## Summary Closes #809. The docs at https://www.openfang.sh/docs/hands advertise `openfang hand config browser --set headless=true`, but that command was never wired into the CLI β€” `openfang hand --help` only exposes `list / active / install / activate / deactivate / info / check-deps / install-deps / pause / resume`...
983519c8e8602a5d0951567aedbff2ee17d4f7f1
46e639c2bb4caf9d05a9ab3cfd0ad7c28c61b5bf
diff --git a/crates/openfang-cli/src/main.rs b/crates/openfang-cli/src/main.rs index 8aa4b7f0b2..2831c961d5 100644 --- a/crates/openfang-cli/src/main.rs +++ b/crates/openfang-cli/src/main.rs @@ -440,6 +440,27 @@ enum HandCommands { /// Instance ID (from `hand active`). id: String, }, + /// Get...
[ "crates/openfang-cli/src/main.rs", "crates/openfang-hands/src/registry.rs" ]
[]
true
RightNow-AI/openfang
1,071
issue_to_patch
[Security] - Responsible Disclosure Public Report ### Description On March 21st I made the bug reports that follow this introduction according to the responsible disclosure policy. OpenFang claims to have addressed these issues, but the top issue seems to be inadequately addressed. Passwords are obsolete and should...
fix(api): reject unauth requests from non-loopback by default (#1034)
Fixes #1034 ## What Empty `api_key` used to turn off auth for everyone. If you bound the server to `0.0.0.0` with no key set, anyone on the network could hit `/api/*` and WebSocket endpoints with no credentials. Now an empty key only works for loopback. Non-loopback requests get 401 unless the operator sets `OPENFAN...
983519c8e8602a5d0951567aedbff2ee17d4f7f1
172b7b2c7875f37c64b7213899e12ec6b0e406ac
diff --git a/crates/openfang-api/src/middleware.rs b/crates/openfang-api/src/middleware.rs index 8dc5c722c3..bc2e313d38 100644 --- a/crates/openfang-api/src/middleware.rs +++ b/crates/openfang-api/src/middleware.rs @@ -49,14 +49,23 @@ pub struct AuthState { pub api_key: String, pub auth_enabled: bool, pu...
[ "crates/openfang-api/src/middleware.rs", "crates/openfang-api/src/server.rs", "crates/openfang-api/src/ws.rs", "crates/openfang-api/tests/api_integration_test.rs" ]
[]
diff --git a/crates/openfang-api/tests/api_integration_test.rs b/crates/openfang-api/tests/api_integration_test.rs index d245946e01..b6d3b7c8c2 100644 --- a/crates/openfang-api/tests/api_integration_test.rs +++ b/crates/openfang-api/tests/api_integration_test.rs @@ -834,6 +834,7 @@ async fn start_test_server_with_auth(...
true
RightNow-AI/openfang
1,009
issue_to_patch
Refactor UI navigation and improve visual consistency with SVGs
## Summary <!-- What does this PR do? Link related issues with "Fixes #123". --> Adjustments have been made to the UI details of the OpenFang Web Console to improve overall UI/UX consistency and product experience: 1. Optimized sidebar navigation and adjusted UI element sizes - `Overview` is now the first na...
a26f7626359fe50480244c2304cec533b7df2363
77bef773e5342672b8f1d63789083a2cb1a6d584
diff --git a/crates/openfang-api/static/css/components.css b/crates/openfang-api/static/css/components.css index 7ead14aba4..ff8a74dfd8 100644 --- a/crates/openfang-api/static/css/components.css +++ b/crates/openfang-api/static/css/components.css @@ -23,7 +23,7 @@ .btn:disabled { opacity: 0.4; cursor: not-allowed; tra...
[ "crates/openfang-api/static/css/components.css", "crates/openfang-api/static/css/layout.css", "crates/openfang-api/static/css/theme.css", "crates/openfang-api/static/index_body.html", "crates/openfang-api/static/manifest.json" ]
[]
true
RightNow-AI/openfang
923
issue_to_patch
feat: Add AWS Bedrock LLM provider support with token auth
## Summary Adds AWS Bedrock as a supported LLM provider via the Converse API using Bedrock API Key bearer token authentication. Credentials resolve from `bedrock_api_key` in config or `AWS_BEARER_TOKEN_BEDROCK` env var, with region defaulting to `us-east-1`. ## Changes - New `bedrock.rs` driver implementing...
618e83714c353f51707c8daeb1e5bfbc4e65e047
2fe926c3b914f4fc8adb756cd050691a2dd6ddb5
diff --git a/crates/openfang-cli/src/main.rs b/crates/openfang-cli/src/main.rs index 104286a8ee..e5981de5ce 100644 --- a/crates/openfang-cli/src/main.rs +++ b/crates/openfang-cli/src/main.rs @@ -2414,6 +2414,7 @@ decay_rate = 0.05 ("TOGETHER_API_KEY", "Together", "together"), ("MISTRAL_API_KEY", "Mist...
[ "crates/openfang-cli/src/main.rs", "crates/openfang-cli/src/tui/screens/init_wizard.rs", "crates/openfang-runtime/src/drivers/bedrock.rs", "crates/openfang-runtime/src/drivers/mod.rs" ]
[]
true
RightNow-AI/openfang
945
issue_to_patch
fix: Fix panic due to UTF-8 character boundary errors
## Summary <!-- What does this PR do? Link related issues with "Fixes #123". --> Fix the panic issue when the string contains Chinese or other UTF-8 characters. ## Changes <!-- Brief list of what changed. --> ## Testing - [x] `cargo clippy --workspace --all-targets -- -D warnings` passes - [x] `cargo t...
a78299ed3d59c45f694365334f8d69811c65c522
4565988e2ec3fff78a8420fed88f22c26d26ffdc
diff --git a/crates/openfang-runtime/src/context_budget.rs b/crates/openfang-runtime/src/context_budget.rs index d11f69bd33..e0b43e10dd 100644 --- a/crates/openfang-runtime/src/context_budget.rs +++ b/crates/openfang-runtime/src/context_budget.rs @@ -5,6 +5,7 @@ //! - Layer 2: Context guard that scans all tool results...
[ "crates/openfang-runtime/src/context_budget.rs", "crates/openfang-runtime/src/llm_errors.rs", "crates/openfang-runtime/src/prompt_builder.rs" ]
[]
true
RightNow-AI/openfang
965
issue_to_patch
GHCR image ghcr.io/rightnow-ai/openfang:v0.5.6 returns 401 on unauthenticated pull ### Description Issue occurs on 0.5.6 and 0.5.7 `docker pull ghcr.io/rightnow-ai/openfang:v0.5.6` returns a 401 unauthorized error without any authentication. The package visibility appears to be set to private (the GitHub default whe...
Set GHCR package visibility to public on every release
## What Fixes #961. `docker pull ghcr.io/rightnow-ai/openfang:<tag>` returned 401 for unauthenticated users because GHCR defaults new packages to **private**, even when the repository is public. The release workflow was pushing the image but never setting visibility. ## How Two additions to the `docker` job in `rel...
a78299ed3d59c45f694365334f8d69811c65c522
be149597e628167e58731857c135782bf6e568ca
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cd40328938..759a36e8a5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -235,5 +235,17 @@ jobs: tags: | ghcr.io/rightnow-ai/openfang:latest ghcr.io/rightnow-ai/openfang:...
[ ".github/workflows/release.yml" ]
[]
true
RightNow-AI/openfang
928
issue_to_patch
feat: add Novita AI as LLM provider
## Summary Add [Novita AI](https://novita.ai) as a new LLM provider. Novita offers an OpenAI-compatible API with competitive pricing and a wide selection of open-source models. ### Changes - New Novita provider following existing provider patterns - API key configuration via `NOVITA_API_KEY` environment variable - Su...
a78299ed3d59c45f694365334f8d69811c65c522
4714efb9e42e0503c20ee11893cdbcf6d9635247
diff --git a/.env.example b/.env.example index a740906153..6a3882a224 100644 --- a/.env.example +++ b/.env.example @@ -32,6 +32,9 @@ # Fireworks AI # FIREWORKS_API_KEY=... +# Novita AI (multi-model gateway) +# NOVITA_API_KEY=... + # ─── Local LLM Providers (no API key needed) ───────────────────────── # Ollama ...
[ ".env.example", "crates/openfang-runtime/src/drivers/mod.rs", "crates/openfang-types/src/model_catalog.rs" ]
[]
true
RightNow-AI/openfang
956
issue_to_patch
chore(deps): bump cron from 0.15.0 to 0.16.0
Bumps [cron](https://github.com/zslayton/cron) from 0.15.0 to 0.16.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/zslayton/cron/commits">compare view</a></li> </ul> </details> <br />
c47e15c1ce1b0979fe243f86d23fca8ceea0f9df
6f86f7a8573d5fcc09f686c7e66397bb19bf1c48
diff --git a/Cargo.lock b/Cargo.lock index 72c86512a9..8087ae3cc3 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -139,7 +139,7 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc" dependencies = [ - "windows-s...
[ "Cargo.lock", "crates/openfang-kernel/Cargo.toml" ]
[]
true
RightNow-AI/openfang
1,015
issue_to_patch
feat(i18n): add Russian localization and i18n framework
- Add complete i18n framework with en.json and ru.json locale files - Add i18n.js with language loading, detection, and fallback logic - Localize chat.js: slash commands, Toast messages, welcome message - Localize agents.js: personality presets, profile descriptions - Localize wizard.js: step labels, channel option...
07963779be926d3f501a3fdc9065934668c6cfc8
62b6aa4eb86f63c5befe70215fef18cd66ad2e95
diff --git a/crates/openfang-api/static/i18n/en.json b/crates/openfang-api/static/i18n/en.json new file mode 100644 index 0000000000..79c3bf4d26 --- /dev/null +++ b/crates/openfang-api/static/i18n/en.json @@ -0,0 +1,608 @@ +{ + "app.name": "OpenFang", + "app.version": "v", + + "nav.chat": "Chat", + "nav.monitor": "...
[ "crates/openfang-api/static/i18n/en.json", "crates/openfang-api/static/i18n/i18n.js", "crates/openfang-api/static/i18n/ru.json", "crates/openfang-api/static/js/pages/agents.js", "crates/openfang-api/static/js/pages/chat.js", "crates/openfang-api/static/js/pages/sessions.js", "crates/openfang-api/static/...
[]
true