url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/26563 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26563/labels{/name} | https://api.github.com/repos/facebook/react/issues/26563/comments | https://api.github.com/repos/facebook/react/issues/26563/events | https://github.com/facebook/react/pull/26563 | 1,658,066,219 | PR_kwDOAJy2Ks5NzUD_ | 26,563 | [DevTools] remove backend dependency from the global hook | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Is the goal that we can later inject different backend versions?",
"> Is the goal that we can later inject different backend versions?\r\n\r\nYes!"
] | 2023-04-06 21:25:38 | 2023-04-07 14:16:59 | 2023-04-07 07:35:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26563', 'html_url': 'https://github.com/facebook/react/pull/26563', 'diff_url': 'https://github.com/facebook/react/pull/26563.diff', 'patch_url': 'https://github.com/facebook/react/pull/26563.patch', 'merged_at': datetime.datetime(2023, 4, 7, 7, 35, 36)} | ## Summary
- #26234 is reverted and replaced with a better approach
- introduce a new global devtools variable to decouple the global hook's dependency on backend/console.js, and add it to react-devtools-inline and react-devtools-standalone
With backend dependency removed from the global hook, we make sure it w... | {'url': 'https://api.github.com/repos/facebook/react/issues/26563/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26563/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26562 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26562/labels{/name} | https://api.github.com/repos/facebook/react/issues/26562/comments | https://api.github.com/repos/facebook/react/issues/26562/events | https://github.com/facebook/react/pull/26562 | 1,656,691,497 | PR_kwDOAJy2Ks5Nu4GM | 26,562 | devtools_check_repro.yml: bump github-script version to fix node warning | {'login': 'kbdharun', 'id': 26346867, 'node_id': 'MDQ6VXNlcjI2MzQ2ODY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/26346867?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kbdharun', 'html_url': 'https://github.com/kbdharun', 'followers_url': 'https://api.github.com/users/kbdharun/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @kbdharun! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2023-04-06 05:30:59 | 2024-04-09 23:30:57 | 2024-04-09 23:30:53 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26562', 'html_url': 'https://github.com/facebook/react/pull/26562', 'diff_url': 'https://github.com/facebook/react/pull/26562.diff', 'patch_url': 'https://github.com/facebook/react/pull/26562.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26562/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26562/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26561 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26561/labels{/name} | https://api.github.com/repos/facebook/react/issues/26561/comments | https://api.github.com/repos/facebook/react/issues/26561/events | https://github.com/facebook/react/pull/26561 | 1,656,528,580 | PR_kwDOAJy2Ks5NuWKL | 26,561 | Fix: Move `destroy` field to shared instance object | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4a1cc2ddd035f5c269e82ab6f7686e2e60d3b3ea...94e23756862d5dfb7e5963e2961affde709eaa07\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-06 01:23:25 | 2023-04-06 16:08:06 | 2023-04-06 16:08:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26561', 'html_url': 'https://github.com/facebook/react/pull/26561', 'diff_url': 'https://github.com/facebook/react/pull/26561.diff', 'patch_url': 'https://github.com/facebook/react/pull/26561.patch', 'merged_at': datetime.datetime(2023, 4, 6, 16, 8, 6)} | This fixes the "double free" bug illustrated by the regression test added in the previous commit.
The underlying issue is that `effect.destroy` field is a mutable field but we read it during render. This is a concurrency bug — if we had a borrow checker, it would not allow this.
It's rare in practice today becaus... | {'url': 'https://api.github.com/repos/facebook/react/issues/26561/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26561/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26560 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26560/labels{/name} | https://api.github.com/repos/facebook/react/issues/26560/comments | https://api.github.com/repos/facebook/react/issues/26560/events | https://github.com/facebook/react/pull/26560 | 1,656,421,483 | PR_kwDOAJy2Ks5Nt_Ag | 26,560 | Bugfix: Don't run Effect cleanup twice after bailing out | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"To be clear I don’t think this is the right fix it just illustrates what the issue is. Which is that during the render phase we’re cloning a field (`destroy`) that is not thread safe.\r\n\r\nThe reason reusing the previous list of hooks doesn’t work in a bail out scenario is because the hook list also contains, as... | 2023-04-05 23:11:37 | 2023-04-06 18:14:12 | 2023-04-06 18:13:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26560', 'html_url': 'https://github.com/facebook/react/pull/26560', 'diff_url': 'https://github.com/facebook/react/pull/26560.diff', 'patch_url': 'https://github.com/facebook/react/pull/26560.patch', 'merged_at': None} | This is a bug originally extracted from internal tools at Meta. I further reduced it from the repro @kassens found and @rickhanlonii reduced in https://github.com/facebook/react/pull/26533. The fix was suggested by @acdlite.
| {'url': 'https://api.github.com/repos/facebook/react/issues/26560/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26560/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26559 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26559/labels{/name} | https://api.github.com/repos/facebook/react/issues/26559/comments | https://api.github.com/repos/facebook/react/issues/26559/events | https://github.com/facebook/react/pull/26559 | 1,656,373,041 | PR_kwDOAJy2Ks5Nt0gZ | 26,559 | [DevTools] Replace deprecated `new-window` with `webContents.setWindowOpenHandler()` | {'login': 'Willie-Boy', 'id': 57364413, 'node_id': 'MDQ6VXNlcjU3MzY0NDEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/57364413?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Willie-Boy', 'html_url': 'https://github.com/Willie-Boy', 'followers_url': 'https://api.github.com/users/Willie-Boy/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'mondaychen', 'id': 1001890.0, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/fol... | [{'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/foll... | null | [
"@mondaychen, I believe you might be the right person to review this. Would you mind taking a look when you have a chance? Thank you – and please excuse me if I'm mistaken about the right person! 🙂",
"Thank you!!!!"
] | 2023-04-05 22:15:24 | 2023-04-06 14:02:44 | 2023-04-06 14:02:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26559', 'html_url': 'https://github.com/facebook/react/pull/26559', 'diff_url': 'https://github.com/facebook/react/pull/26559.diff', 'patch_url': 'https://github.com/facebook/react/pull/26559.patch', 'merged_at': datetime.datetime(2023, 4, 6, 14, 2, 24)} | ## Summary
The electron package was recently upgraded from ^11.1.0 to ^23.1.2 (#26337). However, the WebContents `new-window` event – that is used in the react-devtools project – was deprecated in [v12.0.0](https://releases.electronjs.org/release/v12.0.0) and removed in [v22.2.0](https://releases.electronjs.org/rele... | {'url': 'https://api.github.com/repos/facebook/react/issues/26559/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26559/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26558 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26558/labels{/name} | https://api.github.com/repos/facebook/react/issues/26558/comments | https://api.github.com/repos/facebook/react/issues/26558/events | https://github.com/facebook/react/pull/26558 | 1,656,195,244 | PR_kwDOAJy2Ks5NtOcK | 26,558 | Clean up discrete event replaying | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2023-04-05 19:51:43 | 2023-04-05 23:38:21 | 2023-04-05 23:38:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26558', 'html_url': 'https://github.com/facebook/react/pull/26558', 'diff_url': 'https://github.com/facebook/react/pull/26558.diff', 'patch_url': 'https://github.com/facebook/react/pull/26558.patch', 'merged_at': datetime.datetime(2023, 4, 5, 23, 38, 20)} | We no longer replay and discrete events.
I might re-add a form of this but it'll look a little different. | {'url': 'https://api.github.com/repos/facebook/react/issues/26558/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26558/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26557 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26557/labels{/name} | https://api.github.com/repos/facebook/react/issues/26557/comments | https://api.github.com/repos/facebook/react/issues/26557/events | https://github.com/facebook/react/pull/26557 | 1,656,023,294 | PR_kwDOAJy2Ks5Nspsb | 26,557 | [Float][Fiber] Enable Float methods to be called outside of render | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e5708b3ea9190c1285c9081ff338e46be9ff39bc...64257bff7b5aed88fc1464e6b3ea6a9b52b6d8e2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-05 17:29:53 | 2023-04-20 21:40:30 | 2023-04-20 21:40:27 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26557', 'html_url': 'https://github.com/facebook/react/pull/26557', 'diff_url': 'https://github.com/facebook/react/pull/26557.diff', 'patch_url': 'https://github.com/facebook/react/pull/26557.patch', 'merged_at': datetime.datetime(2023, 4, 20, 21, 40, 26)} | Stacked on #26570
Previously we restricted Float methods to only being callable while rendering. This allowed us to make associations between calls and their position in the DOM tree, for instance hoisting preinitialized styles into a ShadowRoot or an iframe Document.
When considering how we are going to support... | {'url': 'https://api.github.com/repos/facebook/react/issues/26557/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26557/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26556 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26556/labels{/name} | https://api.github.com/repos/facebook/react/issues/26556/comments | https://api.github.com/repos/facebook/react/issues/26556/events | https://github.com/facebook/react/issues/26556 | 1,655,686,229 | I_kwDOAJy2Ks5ir8RV | 26,556 | [DevTools Bug] Could not find node with id "364" in commit tree | {'login': 'ismailios', 'id': 26715337, 'node_id': 'MDQ6VXNlcjI2NzE1MzM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/26715337?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ismailios', 'html_url': 'https://github.com/ismailios', 'followers_url': 'https://api.github.com/users/ismailios/followe... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'ismailios', 'id': 26715337.0, 'node_id': 'MDQ6VXNlcjI2NzE1MzM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/26715337?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ismailios', 'html_url': 'https://github.com/ismailios', 'followers_url': 'https://api.github.com/users/ismailios/follo... | [{'login': 'ismailios', 'id': 26715337, 'node_id': 'MDQ6VXNlcjI2NzE1MzM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/26715337?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ismailios', 'html_url': 'https://github.com/ismailios', 'followers_url': 'https://api.github.com/users/ismailios/follow... | null | [
"@ismailios: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code ex... | 2023-04-05 14:03:28 | 2023-04-05 14:03:44 | 2023-04-05 14:03:44 | NONE | null | null | null | ### Website or app
private
### Repro steps
private
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.27.3-28ce1c171
### Error message (automated)
Could not find node with id "364" in commit tree
### Error call stack (... | {'url': 'https://api.github.com/repos/facebook/react/issues/26556/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26556/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26555 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26555/labels{/name} | https://api.github.com/repos/facebook/react/issues/26555/comments | https://api.github.com/repos/facebook/react/issues/26555/events | https://github.com/facebook/react/pull/26555 | 1,655,670,864 | PR_kwDOAJy2Ks5Nre4b | 26,555 | Changes have been updated | {'login': 'sayn-mondal', 'id': 127134808, 'node_id': 'U_kgDOB5PsWA', 'avatar_url': 'https://avatars.githubusercontent.com/u/127134808?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sayn-mondal', 'html_url': 'https://github.com/sayn-mondal', 'followers_url': 'https://api.github.com/users/sayn-mondal/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @sayn-mondal! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order f... | 2023-04-05 13:56:38 | 2024-04-17 05:03:31 | 2024-04-17 05:03:30 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26555', 'html_url': 'https://github.com/facebook/react/pull/26555', 'diff_url': 'https://github.com/facebook/react/pull/26555.diff', 'patch_url': 'https://github.com/facebook/react/pull/26555.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26555/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26555/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26554 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26554/labels{/name} | https://api.github.com/repos/facebook/react/issues/26554/comments | https://api.github.com/repos/facebook/react/issues/26554/events | https://github.com/facebook/react/pull/26554 | 1,655,346,076 | PR_kwDOAJy2Ks5NqYmk | 26,554 | Use native scheduler if defined in global scope | {'login': 'sammy-SC', 'id': 1733610, 'node_id': 'MDQ6VXNlcjE3MzM2MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1733610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammy-SC', 'html_url': 'https://github.com/sammy-SC', 'followers_url': 'https://api.github.com/users/sammy-SC/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4a1cc2ddd035f5c269e82ab6f7686e2e60d3b3ea...d0989c59299c99b4f6f5be57bba33d4cb828a801\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-05 10:21:26 | 2023-05-05 13:01:34 | 2023-05-05 13:01:32 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26554', 'html_url': 'https://github.com/facebook/react/pull/26554', 'diff_url': 'https://github.com/facebook/react/pull/26554.diff', 'patch_url': 'https://github.com/facebook/react/pull/26554.patch', 'merged_at': datetime.datetime(2023, 5, 5, 13, 1, 32)} | React Native in open source should use native scheduler if it is available. | {'url': 'https://api.github.com/repos/facebook/react/issues/26554/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26554/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26553 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26553/labels{/name} | https://api.github.com/repos/facebook/react/issues/26553/comments | https://api.github.com/repos/facebook/react/issues/26553/events | https://github.com/facebook/react/pull/26553 | 1,654,663,062 | PR_kwDOAJy2Ks5NoHA0 | 26,553 | Remove no-fallthrough lint suppressions | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2023-04-04 22:31:37 | 2023-04-05 03:08:34 | 2023-04-05 03:08:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26553', 'html_url': 'https://github.com/facebook/react/pull/26553', 'diff_url': 'https://github.com/facebook/react/pull/26553.diff', 'patch_url': 'https://github.com/facebook/react/pull/26553.patch', 'merged_at': datetime.datetime(2023, 4, 5, 3, 8, 33)} | The lint rule already understands a normal comment. Also a bunch of these were unnecessary.
| {'url': 'https://api.github.com/repos/facebook/react/issues/26553/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26553/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26552 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26552/labels{/name} | https://api.github.com/repos/facebook/react/issues/26552/comments | https://api.github.com/repos/facebook/react/issues/26552/events | https://github.com/facebook/react/pull/26552 | 1,654,410,125 | PR_kwDOAJy2Ks5NnQBt | 26,552 | act: Move didScheduleLegacyUpdate to ensureRootIsScheduled | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9a9da7721e5b73a8af242807e463e2af842c58ee...6b67bbfdb9b27624c51094dcf40dfa427767d3c6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-04 18:54:37 | 2023-04-10 18:44:32 | 2023-04-10 18:40:19 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26552', 'html_url': 'https://github.com/facebook/react/pull/26552', 'diff_url': 'https://github.com/facebook/react/pull/26552.diff', 'patch_url': 'https://github.com/facebook/react/pull/26552.patch', 'merged_at': datetime.datetime(2023, 4, 10, 18, 40, 19)} | `act` uses the `didScheduleLegacyUpdate` field to simulate the behavior of batching in React <17 and below. It's a quirk leftover from a previous implementation, not intentionally designed.
This sets `didScheduleLegacyUpdate` every time a legacy root receives an update as opposed to only when the `executionContext` ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26552/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26552/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26551 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26551/labels{/name} | https://api.github.com/repos/facebook/react/issues/26551/comments | https://api.github.com/repos/facebook/react/issues/26551/events | https://github.com/facebook/react/pull/26551 | 1,654,276,774 | PR_kwDOAJy2Ks5Nmy2W | 26,551 | Put common aliases in Map/Set instead of switch over strings | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: eeabb7312f509eb2094452a4389646000ea8ea14...f9665d5a10f6648623f351b182e80b42a533e1e6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-04 17:21:17 | 2023-04-04 22:06:10 | 2023-04-04 22:06:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26551', 'html_url': 'https://github.com/facebook/react/pull/26551', 'diff_url': 'https://github.com/facebook/react/pull/26551.diff', 'patch_url': 'https://github.com/facebook/react/pull/26551.patch', 'merged_at': datetime.datetime(2023, 4, 4, 22, 6, 10)} | This is a follow up to https://github.com/facebook/react/pull/26546
This is strictly a perf optimization since we know that switches over strings aren't optimally implemented in current engines. Basically they're a sequence of ifs.
As a result, we're better off putting the unusual cases in a Map and the very comm... | {'url': 'https://api.github.com/repos/facebook/react/issues/26551/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26551/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26549 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26549/labels{/name} | https://api.github.com/repos/facebook/react/issues/26549/comments | https://api.github.com/repos/facebook/react/issues/26549/events | https://github.com/facebook/react/pull/26549 | 1,653,914,984 | PR_kwDOAJy2Ks5Nlkzv | 26,549 | Remove revertRemovalOfSiblingPrerendering killswitch | {'login': 'sammy-SC', 'id': 1733610, 'node_id': 'MDQ6VXNlcjE3MzM2MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1733610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sammy-SC', 'html_url': 'https://github.com/sammy-SC', 'followers_url': 'https://api.github.com/users/sammy-SC/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5426af3d50ff706f3ebeb4764f838e0a3812bf9a...18a96dc8ec0c03682236e0a532eb7f8b741c547d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-04 13:38:28 | 2023-04-14 15:55:26 | 2023-04-13 01:05:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26549', 'html_url': 'https://github.com/facebook/react/pull/26549', 'diff_url': 'https://github.com/facebook/react/pull/26549.diff', 'patch_url': 'https://github.com/facebook/react/pull/26549.patch', 'merged_at': datetime.datetime(2023, 4, 13, 1, 5, 17)} | removal of sibling prerendering has been rolled out at Meta. We can delete the flag now. | {'url': 'https://api.github.com/repos/facebook/react/issues/26549/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26549/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26548 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26548/labels{/name} | https://api.github.com/repos/facebook/react/issues/26548/comments | https://api.github.com/repos/facebook/react/issues/26548/events | https://github.com/facebook/react/issues/26548 | 1,653,765,162 | I_kwDOAJy2Ks5iknQq | 26,548 | [DevTools Bug]: DevTools settings are not being saved in the Edge browser | {'login': 'matspiewak', 'id': 59939539, 'node_id': 'MDQ6VXNlcjU5OTM5NTM5', 'avatar_url': 'https://avatars.githubusercontent.com/u/59939539?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/matspiewak', 'html_url': 'https://github.com/matspiewak', 'followers_url': 'https://api.github.com/users/matspiewak/fol... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"I think resetting your browser settings can solve the problem",
"open website in incognito mode and try there. Or just hit ctrl + f5 to clear the browser cache.",
"I will suggest you to use chrome instead of using edge. ",
"> open website in incognito mode and try there. Or just hit ctrl + f5 to clear the br... | 2023-04-04 12:09:08 | 2023-04-13 06:48:24 | 2023-04-13 06:48:24 | NONE | null | null | null | ### Website or app
https://react.dev/
### Repro steps
1. Open DevTools
2. Click View Settings
3. Change one of the options
4. Refresh page
5. No option is being saved
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_... | {'url': 'https://api.github.com/repos/facebook/react/issues/26548/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26548/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26547 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26547/labels{/name} | https://api.github.com/repos/facebook/react/issues/26547/comments | https://api.github.com/repos/facebook/react/issues/26547/events | https://github.com/facebook/react/issues/26547 | 1,653,155,337 | I_kwDOAJy2Ks5iiSYJ | 26,547 | Bug: TypeError: aAttribruteValue.parentNode.getAttribute is not a function | {'login': 'henryspivey', 'id': 6827755, 'node_id': 'MDQ6VXNlcjY4Mjc3NTU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6827755?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/henryspivey', 'html_url': 'https://github.com/henryspivey', 'followers_url': 'https://api.github.com/users/henryspivey/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"hey @henryspivey, i was unable to reproduce this issue, was there any other modifications?",
"> hey @henryspivey, i was unable to reproduce this issue, was there any other modifications?\r\n\r\nNo all the modifications you need to make are outlined above. I guess we can close this because I don't see this any lo... | 2023-04-04 04:32:25 | 2023-04-12 00:16:59 | 2023-04-12 00:16:59 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: v18.2.0
## Steps To Reproduce
1. Create a new project with ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26547/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26547/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26546 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26546/labels{/name} | https://api.github.com/repos/facebook/react/issues/26546/comments | https://api.github.com/repos/facebook/react/issues/26546/events | https://github.com/facebook/react/pull/26546 | 1,653,098,014 | PR_kwDOAJy2Ks5Ni1Q4 | 26,546 | Refactor DOM Bindings Completely Off of DOMProperty Meta Programming | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 7329ea81c154d40800e30104be40f050e8c2af3e...69fa0d888c0542c4f4b7c7d74a759a7df13e748d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-04 03:14:07 | 2023-04-04 15:05:57 | 2023-04-04 15:05:57 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26546', 'html_url': 'https://github.com/facebook/react/pull/26546', 'diff_url': 'https://github.com/facebook/react/pull/26546.diff', 'patch_url': 'https://github.com/facebook/react/pull/26546.patch', 'merged_at': datetime.datetime(2023, 4, 4, 15, 5, 57)} | There are four places we have special cases based off the DOMProperty config:
1) DEV-only: ReactDOMUnknownPropertyHook warns for passing booleans to non-boolean attributes. We just need a simple list of all properties that are affected by that. We could probably move this in under setProp instead and have it covered... | {'url': 'https://api.github.com/repos/facebook/react/issues/26546/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26546/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26545 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26545/labels{/name} | https://api.github.com/repos/facebook/react/issues/26545/comments | https://api.github.com/repos/facebook/react/issues/26545/events | https://github.com/facebook/react/pull/26545 | 1,652,594,048 | PR_kwDOAJy2Ks5NhI7G | 26,545 | Combine retry throttling and suspensey commits | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 58742c21b8c3237e8b66c7df4e200504846a01ae...1b24282e48463d8e92819a42175b53bcf0d9e7cc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-03 18:54:37 | 2023-04-11 15:38:37 | null | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/26545', 'html_url': 'https://github.com/facebook/react/pull/26545', 'diff_url': 'https://github.com/facebook/react/pull/26545.diff', 'patch_url': 'https://github.com/facebook/react/pull/26545.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/26545/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26545/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26544 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26544/labels{/name} | https://api.github.com/repos/facebook/react/issues/26544/comments | https://api.github.com/repos/facebook/react/issues/26544/events | https://github.com/facebook/react/issues/26544 | 1,652,577,439 | I_kwDOAJy2Ks5igFSf | 26,544 | Bug: Newly Rendered `dialog` Elements Wrongly Retain the "Open State" of a Previously Rendered `dialog` | {'login': 'ITenthusiasm', 'id': 47364027, 'node_id': 'MDQ6VXNlcjQ3MzY0MDI3', 'avatar_url': 'https://avatars.githubusercontent.com/u/47364027?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ITenthusiasm', 'html_url': 'https://github.com/ITenthusiasm', 'followers_url': 'https://api.github.com/users/ITenthus... | [{'id': 1983406161, 'node_id': 'MDU6TGFiZWwxOTgzNDA2MTYx', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Expected%20Behavior', 'name': 'Resolution: Expected Behavior', 'color': '8c98d8', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"> this problem doesn't seem to happen for the element's other attributes/properties.\r\n\r\nThis behavior will be observed with any other component. State is persisted if the component type stays the same: https://codesandbox.io/s/host-component-properties-are-persisted-across-re-renders-orxme7\r\n\r\nIf you want ... | 2023-04-03 18:39:55 | 2023-04-03 20:01:16 | 2023-04-03 19:56:17 | NONE | null | null | null | ## The Problem
Currently, a newly rendered `dialog` element can erroneously retain the "open state" a previously rendered `dialog` element if React _thinks_ that the same element is being re-rendered. Interestingly enough, this problem doesn't seem to happen for the element's other attributes/properties.
React ve... | {'url': 'https://api.github.com/repos/facebook/react/issues/26544/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26544/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26543 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26543/labels{/name} | https://api.github.com/repos/facebook/react/issues/26543/comments | https://api.github.com/repos/facebook/react/issues/26543/events | https://github.com/facebook/react/pull/26543 | 1,652,537,698 | PR_kwDOAJy2Ks5Ng8vH | 26,543 | Provide icon to edge devtools. | {'login': 'harrygz889', 'id': 15645169, 'node_id': 'MDQ6VXNlcjE1NjQ1MTY5', 'avatar_url': 'https://avatars.githubusercontent.com/u/15645169?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/harrygz889', 'html_url': 'https://github.com/harrygz889', 'followers_url': 'https://api.github.com/users/harrygz889/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'mondaychen', 'id': 1001890.0, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/fol... | [{'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/foll... | null | [
"Hi Harry, thank you so much for addressing this issue. I feel like it might be safer to limit the icon only provided for Edge cause we've no idea how's other browsers treat this api. Also left a comment there.",
"main.js LGTM, though not sure if we need to modify the ReactVersion file, thank you!",
"I did not ... | 2023-04-03 18:12:11 | 2023-04-11 18:42:14 | 2023-04-11 18:42:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26543', 'html_url': 'https://github.com/facebook/react/pull/26543', 'diff_url': 'https://github.com/facebook/react/pull/26543.diff', 'patch_url': 'https://github.com/facebook/react/pull/26543.patch', 'merged_at': datetime.datetime(2023, 4, 11, 18, 42, 14)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26543/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26543/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26542 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26542/labels{/name} | https://api.github.com/repos/facebook/react/issues/26542/comments | https://api.github.com/repos/facebook/react/issues/26542/events | https://github.com/facebook/react/pull/26542 | 1,652,457,042 | PR_kwDOAJy2Ks5NgrZS | 26,542 | DevTools: Inline references to fiber flags | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Would it be better if all of these flags are defined in the same place at the top of this file?\r\n1. they are easier to maintain in case we had to keep them longer than expected\r\n2. we won't miss any of them when we move those functions to reconciler",
"I inlined them intentionally because even the concept of... | 2023-04-03 17:12:55 | 2023-04-04 15:05:34 | 2023-04-04 15:05:34 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26542', 'html_url': 'https://github.com/facebook/react/pull/26542', 'diff_url': 'https://github.com/facebook/react/pull/26542.diff', 'patch_url': 'https://github.com/facebook/react/pull/26542.patch', 'merged_at': datetime.datetime(2023, 4, 4, 15, 5, 34)} | We shouldn't be referencing internal fields like fiber's `flag` directly of DevTools. It's an implementation detail. However, over the years a few of these have snuck in. Because of how DevTools is currently shipped, where it's expected to be backwards compatible with older versions of React, this prevents us from refa... | {'url': 'https://api.github.com/repos/facebook/react/issues/26542/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26542/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26541 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26541/labels{/name} | https://api.github.com/repos/facebook/react/issues/26541/comments | https://api.github.com/repos/facebook/react/issues/26541/events | https://github.com/facebook/react/pull/26541 | 1,652,314,730 | PR_kwDOAJy2Ks5NgMoW | 26,541 | Optimize some packaging methods and add parameter verification | {'login': 'LockingReal', 'id': 42457717, 'node_id': 'MDQ6VXNlcjQyNDU3NzE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/42457717?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/LockingReal', 'html_url': 'https://github.com/LockingReal', 'followers_url': 'https://api.github.com/users/LockingReal... | [] | closed | false | null | [] | null | [
"Hi @LockingReal! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order f... | 2023-04-03 15:40:55 | 2023-04-03 16:07:52 | 2023-04-03 16:07:52 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26541', 'html_url': 'https://github.com/facebook/react/pull/26541', 'diff_url': 'https://github.com/facebook/react/pull/26541.diff', 'patch_url': 'https://github.com/facebook/react/pull/26541.patch', 'merged_at': None} | I think the method will become more robust ❤ ~ | {'url': 'https://api.github.com/repos/facebook/react/issues/26541/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26541/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26540 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26540/labels{/name} | https://api.github.com/repos/facebook/react/issues/26540/comments | https://api.github.com/repos/facebook/react/issues/26540/events | https://github.com/facebook/react/pull/26540 | 1,652,301,525 | PR_kwDOAJy2Ks5NgJyO | 26,540 | Testing: remove resetModules() where it doesn't cause errors | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b14f8da15598cdc2253529a905421ac795d68ab1...77686efe0c9ff5b854b767f2fb9c634b76cc1538\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-03 15:32:27 | 2023-04-03 15:38:17 | 2023-04-03 15:38:12 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/26540', 'html_url': 'https://github.com/facebook/react/pull/26540', 'diff_url': 'https://github.com/facebook/react/pull/26540.diff', 'patch_url': 'https://github.com/facebook/react/pull/26540.patch', 'merged_at': None} | This PR simply removes `jest.removeModules()` in all tests where it doesn't cause errors. I suspect this might speed up tests.
A benefit besides speed is that accidental top level requires are not creating references to a different instance to other modules anymore.
A downside is that tests are less isolated.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/26540/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26540/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26539 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26539/labels{/name} | https://api.github.com/repos/facebook/react/issues/26539/comments | https://api.github.com/repos/facebook/react/issues/26539/events | https://github.com/facebook/react/pull/26539 | 1,652,107,388 | PR_kwDOAJy2Ks5NffuF | 26,539 | fix[devtools]: use native clipboard api instead of clipboard-js | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 790ebc962de573a37e4755207eba91b07a0fa172...4fd7d9a1cdaf19f47aa9b07f3be1f5090ffb4cd5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-03 13:47:54 | 2023-05-02 08:58:18 | 2023-04-12 10:54:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26539', 'html_url': 'https://github.com/facebook/react/pull/26539', 'diff_url': 'https://github.com/facebook/react/pull/26539.diff', 'patch_url': 'https://github.com/facebook/react/pull/26539.patch', 'merged_at': None} | Fixes https://github.com/facebook/react/issues/26500
## Summary
- Bumping min version for Firefox to 63, the version in which Clipboard API is fully supported
- Using Clipboard API instead of `clipboard-js` lib
## How did you test this change?
- Tested electron app
- Tested `react-devtools-inline` app
---
... | {'url': 'https://api.github.com/repos/facebook/react/issues/26539/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26539/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26538 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26538/labels{/name} | https://api.github.com/repos/facebook/react/issues/26538/comments | https://api.github.com/repos/facebook/react/issues/26538/events | https://github.com/facebook/react/issues/26538 | 1,652,043,582 | I_kwDOAJy2Ks5ieC8- | 26,538 | dropdown not closing on clicking on same icon reactjs | {'login': 'RahulMittal18', 'id': 77724943, 'node_id': 'MDQ6VXNlcjc3NzI0OTQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/77724943?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RahulMittal18', 'html_url': 'https://github.com/RahulMittal18', 'followers_url': 'https://api.github.com/users/Rahul... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"\r\nyou can use the elseif for targeting the same icon when dropdown is active \r\n\r\n```\r\nuseEffect(() => {\r\n let closeDropdown = (e) => {\r\n if (imgRef.current && !imgRef.current.contains(e.target)) {\r\n setIsOpen(false);\r\n } else if (imgRef.current === e.target) {\r\n setIsOpen((prev) ... | 2023-04-03 13:09:13 | 2024-04-17 05:03:33 | 2024-04-17 05:03:32 | NONE | null | null | null | Expected Behavior : When clicked on profile icon, if dropdown is not open,open the dropdown else close the dropdown. And close the dropdown if clicked anywhere outside the dropdown.
Actual Behavior: When clicked on profile icon, if dropdown is not open, the dropdown gets open. And the dropdown is also closing if cl... | {'url': 'https://api.github.com/repos/facebook/react/issues/26538/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26538/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26537 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26537/labels{/name} | https://api.github.com/repos/facebook/react/issues/26537/comments | https://api.github.com/repos/facebook/react/issues/26537/events | https://github.com/facebook/react/issues/26537 | 1,651,581,931 | I_kwDOAJy2Ks5icSPr | 26,537 | Replaying suspended components breaks its-fine's ContextBridge, which can break R3F | {'login': 'hansottowirtz', 'id': 5406212, 'node_id': 'MDQ6VXNlcjU0MDYyMTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5406212?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hansottowirtz', 'html_url': 'https://github.com/hansottowirtz', 'followers_url': 'https://api.github.com/users/hansott... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I've temporarily patched `shouldTimeSlice = false` in the react source code, this fixes it (but also takes away most of the concurrent features I assume).\r\n\r\nIf you want to do this, you probably also have to patch the minified production build, which is a bit harder to do.",
"It seems like the fiber also doe... | 2023-04-03 08:21:21 | 2024-04-17 05:03:34 | 2024-04-17 05:03:33 | CONTRIBUTOR | null | null | null | React version: 18.3.0-next-85de6fde5-20230328
## Steps To Reproduce
1. Use a ContextBridge
2. Make sure `replayFunctionComponent` is triggered.
3. The ContextBridge is empty
## Info
ContextBridge relies on its-fine's ability to get the current fiber, either through `ReactCurrentOwner.current` or `this._re... | {'url': 'https://api.github.com/repos/facebook/react/issues/26537/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26537/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26536 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26536/labels{/name} | https://api.github.com/repos/facebook/react/issues/26536/comments | https://api.github.com/repos/facebook/react/issues/26536/events | https://github.com/facebook/react/issues/26536 | 1,651,133,418 | I_kwDOAJy2Ks5iakvq | 26,536 | Bug: Adjusting state in response to rendering in StrictMode, while also using refs | {'login': 'bellcd', 'id': 46756893, 'node_id': 'MDQ6VXNlcjQ2NzU2ODkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/46756893?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bellcd', 'html_url': 'https://github.com/bellcd', 'followers_url': 'https://api.github.com/users/bellcd/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2023-04-02 23:29:07 | 2024-04-17 05:03:35 | 2024-04-17 05:03:34 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.2.0
We're considering using [this pattern](https://react.de... | {'url': 'https://api.github.com/repos/facebook/react/issues/26536/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26536/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26535 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26535/labels{/name} | https://api.github.com/repos/facebook/react/issues/26535/comments | https://api.github.com/repos/facebook/react/issues/26535/events | https://github.com/facebook/react/pull/26535 | 1,650,899,647 | PR_kwDOAJy2Ks5Nbh2- | 26,535 | Fix suspense replaying forward refs | {'login': 'hansottowirtz', 'id': 5406212, 'node_id': 'MDQ6VXNlcjU0MDYyMTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5406212?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hansottowirtz', 'html_url': 'https://github.com/hansottowirtz', 'followers_url': 'https://api.github.com/users/hansott... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0ae348018d5b3a3f1ccdd92de85d9cc581b2b98d...7875d3dff6b4a0fef673938a717665e98b5f5bf6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-02 10:50:58 | 2023-04-03 07:11:07 | 2023-04-02 22:48:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26535', 'html_url': 'https://github.com/facebook/react/pull/26535', 'diff_url': 'https://github.com/facebook/react/pull/26535.diff', 'patch_url': 'https://github.com/facebook/react/pull/26535.patch', 'merged_at': datetime.datetime(2023, 4, 2, 22, 48, 29)} | Continuation of https://github.com/facebook/react/issues/26420
Fixes https://github.com/facebook/react/issues/26385 and https://github.com/facebook/react/issues/26419 | {'url': 'https://api.github.com/repos/facebook/react/issues/26535/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26535/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26534 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26534/labels{/name} | https://api.github.com/repos/facebook/react/issues/26534/comments | https://api.github.com/repos/facebook/react/issues/26534/events | https://github.com/facebook/react/pull/26534 | 1,650,452,095 | PR_kwDOAJy2Ks5NaHQa | 26,534 | Remove findInstanceBlockingEvent unused parameters | {'login': 'mohammadsiyou', 'id': 39489675, 'node_id': 'MDQ6VXNlcjM5NDg5Njc1', 'avatar_url': 'https://avatars.githubusercontent.com/u/39489675?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mohammadsiyou', 'html_url': 'https://github.com/mohammadsiyou', 'followers_url': 'https://api.github.com/users/moham... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0ae348018d5b3a3f1ccdd92de85d9cc581b2b98d...2f81b0c9fb195349b97841a51187cdebaeba0b63\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-04-01 12:21:23 | 2023-04-04 16:37:15 | 2023-04-04 16:37:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26534', 'html_url': 'https://github.com/facebook/react/pull/26534', 'diff_url': 'https://github.com/facebook/react/pull/26534.diff', 'patch_url': 'https://github.com/facebook/react/pull/26534.patch', 'merged_at': datetime.datetime(2023, 4, 4, 16, 37, 14)} | ## Summary
First three parameters of `findInstanceBlockingEvent` are unused since I think if we remove the unused parameters it makes it easier to know that which parameters is need by `findInstanceBlockingEvent`.
## How did you test this change?
Existing tests.
| {'url': 'https://api.github.com/repos/facebook/react/issues/26534/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26534/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26533 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26533/labels{/name} | https://api.github.com/repos/facebook/react/issues/26533/comments | https://api.github.com/repos/facebook/react/issues/26533/events | https://github.com/facebook/react/pull/26533 | 1,650,240,382 | PR_kwDOAJy2Ks5NZdX0 | 26,533 | Failing test for effect unmount issue | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"In this repro, only `pushEffect()` is called with the destroy function that's marked as \"already called\". I suspect this is an early indicator of incorrect behavior, but it doesn't actually call the second time `safelyCallDestroy`.",
"Fixed by https://github.com/facebook/react/pull/26561"
] | 2023-04-01 01:56:23 | 2024-03-22 17:11:58 | 2024-03-22 17:11:58 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26533', 'html_url': 'https://github.com/facebook/react/pull/26533', 'diff_url': 'https://github.com/facebook/react/pull/26533.diff', 'patch_url': 'https://github.com/facebook/react/pull/26533.patch', 'merged_at': None} | ## Overview
This test fails because an effect destroy function is called twice.
Note: the component that calls destroy twice is the top most Container component (with name="x")
The Scheduler log is:
```
'[A:0]',
'[B:0]',
'[A:1]',
'[B:0]',
'[B:0]',
'[B:1]',
'... | {'url': 'https://api.github.com/repos/facebook/react/issues/26533/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26533/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26532 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26532/labels{/name} | https://api.github.com/repos/facebook/react/issues/26532/comments | https://api.github.com/repos/facebook/react/issues/26532/events | https://github.com/facebook/react/pull/26532 | 1,649,897,817 | PR_kwDOAJy2Ks5NYVvu | 26,532 | [Float] Suspend unstyled content for up to 1 minute | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 888874673f81c08d9c3cfd4a56e2e93fd728894c...14dee24cb18db94fa900f8a9ac9f3e7146e711d9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-31 19:24:59 | 2023-04-08 11:30:23 | 2023-03-31 19:45:46 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26532', 'html_url': 'https://github.com/facebook/react/pull/26532', 'diff_url': 'https://github.com/facebook/react/pull/26532.diff', 'patch_url': 'https://github.com/facebook/react/pull/26532.patch', 'merged_at': datetime.datetime(2023, 3, 31, 19, 45, 46)} | We almost never want to show content before its styles have loaded. But eventually we will give up and allow unstyled content. So this extends the timeout to a full minute. This somewhat arbitrary — big enough that you'd only reach it under extreme circumstances.
Note that, like regular Suspense, the app is still in... | {'url': 'https://api.github.com/repos/facebook/react/issues/26532/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26532/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26531 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26531/labels{/name} | https://api.github.com/repos/facebook/react/issues/26531/comments | https://api.github.com/repos/facebook/react/issues/26531/events | https://github.com/facebook/react/pull/26531 | 1,649,835,851 | PR_kwDOAJy2Ks5NYI4- | 26,531 | Allow transitions to interrupt Suspensey commits | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 09c8d2563300621dc91258a4c2839210e2fbdf0e...179bb4a4c8b25f4b1844b7beea1d436cfdc91593\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-31 18:33:08 | 2023-03-31 19:35:49 | 2023-03-31 19:35:48 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26531', 'html_url': 'https://github.com/facebook/react/pull/26531', 'diff_url': 'https://github.com/facebook/react/pull/26531.diff', 'patch_url': 'https://github.com/facebook/react/pull/26531.patch', 'merged_at': datetime.datetime(2023, 3, 31, 19, 35, 48)} | I originally made it so that a Suspensey commit — i.e. a commit that's waiting for a stylesheet, image, or font to load before proceeding — could not be interrupted by transitions. My reasoning was that Suspensey commits always time out after a short interval, anyway, so if the incoming update isn't urgent, it's better... | {'url': 'https://api.github.com/repos/facebook/react/issues/26531/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26531/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26530 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26530/labels{/name} | https://api.github.com/repos/facebook/react/issues/26530/comments | https://api.github.com/repos/facebook/react/issues/26530/events | https://github.com/facebook/react/issues/26530 | 1,649,662,360 | I_kwDOAJy2Ks5iU9mY | 26,530 | Suggest adding Chinese to the new version of the official website | {'login': 'rjl-cli', 'id': 111716113, 'node_id': 'U_kgDOBqinEQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/111716113?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rjl-cli', 'html_url': 'https://github.com/rjl-cli', 'followers_url': 'https://api.github.com/users/rjl-cli/followers', 'followin... | [] | closed | false | null | [] | null | [
"It's here: https://zh-hans.react.dev/\r\n\r\nWe're going to add a language switcher at some point later.",
"@gaearon Hello gaearon, how to contribute to Chinese document. \r\nIt doesn't look like finished yet. Thanks.",
"@gaearon When will the new version be released? It's been a long time since the last vers... | 2023-03-31 16:19:32 | 2023-04-12 01:32:57 | 2023-03-31 17:12:30 | NONE | null | null | null | Full English users who are not very good at English are not very friendly | {'url': 'https://api.github.com/repos/facebook/react/issues/26530/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26530/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26529 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26529/labels{/name} | https://api.github.com/repos/facebook/react/issues/26529/comments | https://api.github.com/repos/facebook/react/issues/26529/events | https://github.com/facebook/react/pull/26529 | 1,649,471,812 | PR_kwDOAJy2Ks5NW7u0 | 26,529 | added firefox CSP | {'login': 'sherphy', 'id': 77257453, 'node_id': 'MDQ6VXNlcjc3MjU3NDUz', 'avatar_url': 'https://avatars.githubusercontent.com/u/77257453?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sherphy', 'html_url': 'https://github.com/sherphy', 'followers_url': 'https://api.github.com/users/sherphy/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @sherphy! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for u... | 2023-03-31 14:35:35 | 2024-04-17 05:03:36 | 2024-04-17 05:03:36 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26529', 'html_url': 'https://github.com/facebook/react/pull/26529', 'diff_url': 'https://github.com/facebook/react/pull/26529.diff', 'patch_url': 'https://github.com/facebook/react/pull/26529.patch', 'merged_at': None} | This is my first PR ever, I hope I'm doing this correctly!
I just did a small change regarding: https://github.com/facebook/react/issues/26517
## How did you test this change?
I didn't test the change because it's just adding a sentence to README, I hope it doesn't break anything! | {'url': 'https://api.github.com/repos/facebook/react/issues/26529/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26529/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26528 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26528/labels{/name} | https://api.github.com/repos/facebook/react/issues/26528/comments | https://api.github.com/repos/facebook/react/issues/26528/events | https://github.com/facebook/react/pull/26528 | 1,649,207,460 | PR_kwDOAJy2Ks5NWCXp | 26,528 | Revert "Cleanup enableSyncDefaultUpdate flag (#26236)" | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0700dd50bda98f5ee86f2e3adfe5e9906ed1e8e3...9302f254a31f4240bcbb4b88fafe7d35ce4446d9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-31 11:40:17 | 2023-04-04 14:08:32 | 2023-04-04 14:08:14 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26528', 'html_url': 'https://github.com/facebook/react/pull/26528', 'diff_url': 'https://github.com/facebook/react/pull/26528.diff', 'patch_url': 'https://github.com/facebook/react/pull/26528.patch', 'merged_at': datetime.datetime(2023, 4, 4, 14, 8, 14)} | This reverts commit b2ae9ddb3b497d16a7c27c051da1827d08871138.
While the feature flag is fully rolled out, these tests are also testing behavior set with an unstable flag on root, which for now we want to preserve.
Not sure if there's a better way then adding a dynamic feature flag to the www build? | {'url': 'https://api.github.com/repos/facebook/react/issues/26528/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26528/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26527 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26527/labels{/name} | https://api.github.com/repos/facebook/react/issues/26527/comments | https://api.github.com/repos/facebook/react/issues/26527/events | https://github.com/facebook/react/pull/26527 | 1,648,661,559 | PR_kwDOAJy2Ks5NUOTC | 26,527 | changes made | {'login': 'rugwedpatharkar', 'id': 24600067, 'node_id': 'MDQ6VXNlcjI0NjAwMDY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/24600067?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rugwedpatharkar', 'html_url': 'https://github.com/rugwedpatharkar', 'followers_url': 'https://api.github.com/users... | [] | closed | false | null | [] | null | [
"Hi @rugwedpatharkar! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2023-03-31 04:48:11 | 2023-03-31 04:53:13 | 2023-03-31 04:48:45 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26527', 'html_url': 'https://github.com/facebook/react/pull/26527', 'diff_url': 'https://github.com/facebook/react/pull/26527.diff', 'patch_url': 'https://github.com/facebook/react/pull/26527.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26527/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26527/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26526 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26526/labels{/name} | https://api.github.com/repos/facebook/react/issues/26526/comments | https://api.github.com/repos/facebook/react/issues/26526/events | https://github.com/facebook/react/pull/26526 | 1,648,617,543 | PR_kwDOAJy2Ks5NUFF9 | 26,526 | Fix logic around attribute seralization | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ca01f359b9236292c749075bb2fd41bb7b569308...f7304696a1a33c8d482d072de6cb4f20e192e449\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-31 03:41:23 | 2023-04-03 16:34:56 | 2023-04-03 16:34:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26526', 'html_url': 'https://github.com/facebook/react/pull/26526', 'diff_url': 'https://github.com/facebook/react/pull/26526.diff', 'patch_url': 'https://github.com/facebook/react/pull/26526.patch', 'merged_at': datetime.datetime(2023, 4, 3, 16, 34, 53)} | There was a bug in the attribute seralization for stylesheet resources injected by the Fizz runtime. For boolean properties the attribute value was set to an empty string but later immediately set to a string coerced value. This PR fixes that bug and refactors the code paths to be clearer | {'url': 'https://api.github.com/repos/facebook/react/issues/26526/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26526/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26525 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26525/labels{/name} | https://api.github.com/repos/facebook/react/issues/26525/comments | https://api.github.com/repos/facebook/react/issues/26525/events | https://github.com/facebook/react/issues/26525 | 1,648,590,053 | I_kwDOAJy2Ks5iQ3zl | 26,525 | Bug: window.location.search is stale value and not synchronized with useLocation().search | {'login': 'mrdulin', 'id': 17866683, 'node_id': 'MDQ6VXNlcjE3ODY2Njgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17866683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mrdulin', 'html_url': 'https://github.com/mrdulin', 'followers_url': 'https://api.github.com/users/mrdulin/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"If you believe there is a React bug, please produce a sandbox that does not include React Router. One way to do this is to look at React Router source code and simulate something similar.",
"Also, if the issue is specific to 16.x, we're not going to look into a fix.",
"@gaearon OK. Thanks",
"I also replied h... | 2023-03-31 02:59:00 | 2023-03-31 14:31:49 | 2023-03-31 03:27:30 | NONE | null | null | null | React version: 16.14.0
https://github.com/remix-run/react-router/issues/10289 | {'url': 'https://api.github.com/repos/facebook/react/issues/26525/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26525/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26524 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26524/labels{/name} | https://api.github.com/repos/facebook/react/issues/26524/comments | https://api.github.com/repos/facebook/react/issues/26524/events | https://github.com/facebook/react/pull/26524 | 1,648,284,362 | PR_kwDOAJy2Ks5NS_tM | 26,524 | Limit the meaning of "custom element" to not include `is` | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1a1d61fed98a02c9b1bac029d0bc11c3e4db896d...d4e2063509a3460e63f7d89c2c7c7a1f575129ec\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 20:43:03 | 2023-03-30 22:38:50 | 2023-03-30 22:38:50 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26524', 'html_url': 'https://github.com/facebook/react/pull/26524', 'diff_url': 'https://github.com/facebook/react/pull/26524.diff', 'patch_url': 'https://github.com/facebook/react/pull/26524.patch', 'merged_at': datetime.datetime(2023, 3, 30, 22, 38, 50)} | This PR has a bunch of surrounding refactoring. See individual commits.
The main change is that we no longer special case `typeof is === 'string'` as a special case according to the `enableCustomElementPropertySupport` flag.
Effectively this means that you can't use custom properties/events, other than the ones R... | {'url': 'https://api.github.com/repos/facebook/react/issues/26524/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26524/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26523 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26523/labels{/name} | https://api.github.com/repos/facebook/react/issues/26523/comments | https://api.github.com/repos/facebook/react/issues/26523/events | https://github.com/facebook/react/pull/26523 | 1,648,190,565 | PR_kwDOAJy2Ks5NSr13 | 26,523 | Warn for ARIA typos on custom elements | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"combine the functions?",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 73deff0d5162160c0aafa5cd0b87e11143fe9938...922028783ec449a0891ace68ba5001e17fd2beb5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any ... | 2023-03-30 19:28:20 | 2023-03-30 20:31:16 | 2023-03-30 20:31:15 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26523', 'html_url': 'https://github.com/facebook/react/pull/26523', 'diff_url': 'https://github.com/facebook/react/pull/26523.diff', 'patch_url': 'https://github.com/facebook/react/pull/26523.patch', 'merged_at': datetime.datetime(2023, 3, 30, 20, 31, 15)} | Normally we allow any attribute/property on custom elements. However it's a shared namespace. The `aria-` namespace applies to all generic elements which are shared with custom elements. So arguably adding custom extensions there is a really bad idea since it can conflict with future additions.
It's possible there i... | {'url': 'https://api.github.com/repos/facebook/react/issues/26523/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26523/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26522 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26522/labels{/name} | https://api.github.com/repos/facebook/react/issues/26522/comments | https://api.github.com/repos/facebook/react/issues/26522/events | https://github.com/facebook/react/pull/26522 | 1,648,035,273 | PR_kwDOAJy2Ks5NSKlA | 26,522 | refactor[devtools]: forbid editing class instances in props | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ca01f359b9236292c749075bb2fd41bb7b569308...651a028c8e909c4001896f22cc5874b17e124e6f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 17:35:51 | 2023-04-03 10:32:26 | 2023-04-03 10:32:18 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26522', 'html_url': 'https://github.com/facebook/react/pull/26522', 'diff_url': 'https://github.com/facebook/react/pull/26522.diff', 'patch_url': 'https://github.com/facebook/react/pull/26522.patch', 'merged_at': datetime.datetime(2023, 4, 3, 10, 32, 18)} | ## Summary
Fixes https://github.com/facebook/react/issues/24781
Restricting from editing props, which are class instances, because their internals should be opaque.
Proposed changes:
1. Adding new data type `class_instance`: based on prototype chain of an object we will check if its plain or not. If not, then ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26522/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26522/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26521 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26521/labels{/name} | https://api.github.com/repos/facebook/react/issues/26521/comments | https://api.github.com/repos/facebook/react/issues/26521/events | https://github.com/facebook/react/pull/26521 | 1,648,026,018 | PR_kwDOAJy2Ks5NSIjR | 26,521 | Clean up enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0ffc7f632b5cdc2d4ede97b6f8ff55e02183bdf9...36d98a413fc2c66eadde34ae34fd695b1d6d9fd9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 17:29:22 | 2023-03-31 14:25:59 | 2023-03-31 14:25:59 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26521', 'html_url': 'https://github.com/facebook/react/pull/26521', 'diff_url': 'https://github.com/facebook/react/pull/26521.diff', 'patch_url': 'https://github.com/facebook/react/pull/26521.patch', 'merged_at': datetime.datetime(2023, 3, 31, 14, 25, 59)} | This flag is already enabled everywhere except for www, which is blocked by a few tests that assert on the old behavior. Once www is ready, I'll land this. | {'url': 'https://api.github.com/repos/facebook/react/issues/26521/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26521/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26520 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26520/labels{/name} | https://api.github.com/repos/facebook/react/issues/26520/comments | https://api.github.com/repos/facebook/react/issues/26520/events | https://github.com/facebook/react/issues/26520 | 1,648,019,087 | I_kwDOAJy2Ks5iOsaP | 26,520 | [eslint-plugin-react-hooks] New rule to enforce lazy initialization for `useState` | {'login': 'legendkong', 'id': 86101595, 'node_id': 'MDQ6VXNlcjg2MTAxNTk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/86101595?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/legendkong', 'html_url': 'https://github.com/legendkong', 'followers_url': 'https://api.github.com/users/legendkong/fol... | [] | open | false | null | [] | null | [
"This is a valid point",
"+1 up",
"Thanks for putting that rule together! I was looking for a rule like this and stumbled upon this issue. I played around with it a bit and noticed it doesn't identify certain cases, examples:\r\n\r\n```\r\nuseState(a ? b : c());\r\nuseState(a() > b);\r\nuseState(a() || b);\r\n`... | 2023-03-30 17:23:46 | 2024-03-01 18:22:01 | null | NONE | null | null | null | ## Context
It is common to have instances where `React.useState()` code is unnecessarily re-creating its initial state:
Example:
```js
const Component = () => {
const [state, setState] = useState(getInitialHundredItems());
}
```
React's `useState` hooks accepts an `initialState` argument e.g. `React.useSta... | {'url': 'https://api.github.com/repos/facebook/react/issues/26520/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26520/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/26519 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26519/labels{/name} | https://api.github.com/repos/facebook/react/issues/26519/comments | https://api.github.com/repos/facebook/react/issues/26519/events | https://github.com/facebook/react/pull/26519 | 1,647,872,388 | PR_kwDOAJy2Ks5NRnvl | 26,519 | Add Circle CI API token to request header if available | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0ffc7f632b5cdc2d4ede97b6f8ff55e02183bdf9...12ab1be61388d4c7ea1c3db5f6ea9b815655143d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 15:40:30 | 2023-03-30 20:06:57 | 2023-03-30 20:06:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26519', 'html_url': 'https://github.com/facebook/react/pull/26519', 'diff_url': 'https://github.com/facebook/react/pull/26519.diff', 'patch_url': 'https://github.com/facebook/react/pull/26519.patch', 'merged_at': datetime.datetime(2023, 3, 30, 20, 6, 56)} | Follow up of #26499
A Circle CI team member got back to me. It is indeed not necessary, but they had a regression not long ago on fetching without token.
https://discuss.circleci.com/t/is-api-token-required-when-fetching-artifacts/47606/5
To mitigate the impact of this kind of issues, let's add this token to reque... | {'url': 'https://api.github.com/repos/facebook/react/issues/26519/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26519/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26518 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26518/labels{/name} | https://api.github.com/repos/facebook/react/issues/26518/comments | https://api.github.com/repos/facebook/react/issues/26518/events | https://github.com/facebook/react/issues/26518 | 1,647,869,902 | I_kwDOAJy2Ks5iOH_O | 26,518 | Bug: Elements in ErrorBoundary are created twice, one of them becomes an orphan | {'login': 'KurtGokhan', 'id': 6034931, 'node_id': 'MDQ6VXNlcjYwMzQ5MzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6034931?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/KurtGokhan', 'html_url': 'https://github.com/KurtGokhan', 'followers_url': 'https://api.github.com/users/KurtGokhan/follo... | [{'id': 739761016, 'node_id': 'MDU6TGFiZWw3Mzk3NjEwMTY=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Reconciler', 'name': 'Component: Reconciler', 'color': 'f9a798', 'default': False, 'description': None}] | open | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"T... | 2023-03-30 15:38:53 | 2024-04-29 11:04:40 | null | NONE | null | null | null | React version: 18.2.0
Reproducible with [18.3.0-next-85de6fde5-20230328](https://www.npmjs.com/package/react/v/18.3.0-next-85de6fde5-20230328) as well.
As I observed, this is not an issue only in React-DOM. It happens with other renderers too. It can be an issue in the Reconciler or the main React package.
Is... | {'url': 'https://api.github.com/repos/facebook/react/issues/26518/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26518/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/26517 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26517/labels{/name} | https://api.github.com/repos/facebook/react/issues/26517/comments | https://api.github.com/repos/facebook/react/issues/26517/events | https://github.com/facebook/react/issues/26517 | 1,647,625,730 | I_kwDOAJy2Ks5iNMYC | 26,517 | Update react devtools readme - The React Tab Doesn't Show Up - CSP | {'login': 'kfox112', 'id': 3728512, 'node_id': 'MDQ6VXNlcjM3Mjg1MTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3728512?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kfox112', 'html_url': 'https://github.com/kfox112', 'followers_url': 'https://api.github.com/users/kfox112/followers', 'foll... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"Hi!! My first time with open source, and very new to programming in general, sorry in advance if I'm no help! \r\n\r\nI was reading the chain of issues that you provided - from what I can infer, it's an issue on Firefox's side and there is no current solution (apart from some workarounds that don't seem viable lon... | 2023-03-30 13:27:43 | 2024-04-17 05:03:37 | 2024-04-17 05:03:37 | NONE | null | null | null | It would be helpful to update this section of the readme to call out that a content security policy may also be the culprit:
https://github.com/facebook/react/tree/main/packages/react-devtools#the-react-tab-doesnt-show-up
It took me a while to figure this out on my own. We have a CSP which was blocking the loading... | {'url': 'https://api.github.com/repos/facebook/react/issues/26517/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26517/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26516 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26516/labels{/name} | https://api.github.com/repos/facebook/react/issues/26516/comments | https://api.github.com/repos/facebook/react/issues/26516/events | https://github.com/facebook/react/pull/26516 | 1,647,582,214 | PR_kwDOAJy2Ks5NQo3J | 26,516 | Implement public instances for text nodes in Fabric | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 29a3be78bd80372f882ce9d39b12241a97c3d268...c9ac0e3af0cf2159cea35769cfa009a13d4e8978\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 13:03:49 | 2023-04-04 13:43:36 | 2023-04-04 13:43:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26516', 'html_url': 'https://github.com/facebook/react/pull/26516', 'diff_url': 'https://github.com/facebook/react/pull/26516.diff', 'patch_url': 'https://github.com/facebook/react/pull/26516.patch', 'merged_at': datetime.datetime(2023, 4, 4, 13, 43, 35)} | ## Summary
This adds the ability to create public instances for text nodes in Fabric. The implementation for the public instances lives in React Native (as it does for host components after #26437). The logic here just handles their lazy instantiation when requested via `getPublicInstanceFromInternalInstanceHandle`,... | {'url': 'https://api.github.com/repos/facebook/react/issues/26516/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26516/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26515 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26515/labels{/name} | https://api.github.com/repos/facebook/react/issues/26515/comments | https://api.github.com/repos/facebook/react/issues/26515/events | https://github.com/facebook/react/issues/26515 | 1,646,940,143 | I_kwDOAJy2Ks5iKk_v | 26,515 | Is there any roadmap to enable the detection of iframes in React devtools? | {'login': 'IDrissAitHafid', 'id': 31975500, 'node_id': 'MDQ6VXNlcjMxOTc1NTAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/31975500?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/IDrissAitHafid', 'html_url': 'https://github.com/IDrissAitHafid', 'followers_url': 'https://api.github.com/users/ID... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"See https://github.com/facebook/react/issues/18945 for the main discussion around iframe handling.\r\n\r\nMost likely you'll need to do something like this:\r\n\r\n```ts\r\nif (window.parent) {\r\n window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = window.parent.__REACT_DEVTOOLS_GLOBAL_HOOK__;\r\n}\r\n```",
" Thanks for s... | 2023-03-30 05:24:54 | 2024-04-17 05:03:39 | 2024-04-17 05:03:38 | CONTRIBUTOR | null | null | null | I have a component of my application that I inject into different websites as an iframe. I want to use the React devtools to analyze this component, but it doesn't show up in the devtools.
I'm asking if there are any plans to make the React devtools work with iframes in the future. | {'url': 'https://api.github.com/repos/facebook/react/issues/26515/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26515/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26514 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26514/labels{/name} | https://api.github.com/repos/facebook/react/issues/26514/comments | https://api.github.com/repos/facebook/react/issues/26514/events | https://github.com/facebook/react/pull/26514 | 1,646,842,638 | PR_kwDOAJy2Ks5NOJmX | 26,514 | Move ReactDOMFloat to react-dom/src/ | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 85de6fde515148babd36eae2b7384ad8e62b732a...d02e39a39285316fae4b9b8fee1e1c54e99ab4a4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 03:21:23 | 2023-03-30 03:39:25 | 2023-03-30 03:39:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26514', 'html_url': 'https://github.com/facebook/react/pull/26514', 'diff_url': 'https://github.com/facebook/react/pull/26514.diff', 'patch_url': 'https://github.com/facebook/react/pull/26514.patch', 'merged_at': datetime.datetime(2023, 3, 30, 3, 39, 24)} | This is not really part of the bindings, it's more part of the package entry points. /shared/ is not really right neither because it's more like an isomorphic entry point and not some utility. | {'url': 'https://api.github.com/repos/facebook/react/issues/26514/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26514/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26513 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26513/labels{/name} | https://api.github.com/repos/facebook/react/issues/26513/comments | https://api.github.com/repos/facebook/react/issues/26513/events | https://github.com/facebook/react/pull/26513 | 1,646,807,536 | PR_kwDOAJy2Ks5NOCMe | 26,513 | Refactor DOMProperty and CSSProperty | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 29a3be78bd80372f882ce9d39b12241a97c3d268...6b2bc316aa047cd16accad9f95806c5af4c23c89\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-30 02:32:38 | 2023-03-30 20:00:36 | 2023-03-30 18:30:57 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26513', 'html_url': 'https://github.com/facebook/react/pull/26513', 'diff_url': 'https://github.com/facebook/react/pull/26513.diff', 'patch_url': 'https://github.com/facebook/react/pull/26513.patch', 'merged_at': datetime.datetime(2023, 3, 30, 18, 30, 57)} | This is a step towards getting rid of the meta programming in DOMProperty and CSSProperty.
This moves isAttributeNameSafe and isUnitlessNumber to a separate shared modules.
isUnitlessNumber is now a single switch instead of meta-programming. There is a slight behavior change here in that I hard code a specific se... | {'url': 'https://api.github.com/repos/facebook/react/issues/26513/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26513/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26512 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26512/labels{/name} | https://api.github.com/repos/facebook/react/issues/26512/comments | https://api.github.com/repos/facebook/react/issues/26512/events | https://github.com/facebook/react/pull/26512 | 1,646,653,508 | PR_kwDOAJy2Ks5NNhXY | 26,512 | Move update scheduling to microtask | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8310854cebba4d1f404e65ff2064825ee76d78e2...5c1cf56b6ec0b2eb25434e1ed3c0bae7cafca58f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 23:00:09 | 2023-03-31 17:04:09 | 2023-03-31 17:04:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26512', 'html_url': 'https://github.com/facebook/react/pull/26512', 'diff_url': 'https://github.com/facebook/react/pull/26512.diff', 'patch_url': 'https://github.com/facebook/react/pull/26512.patch', 'merged_at': datetime.datetime(2023, 3, 31, 17, 4, 9)} | When React receives new input (via `setState`, a Suspense promise resolution, and so on), it needs to ensure there's a rendering task associated with the update. Most of this happens `ensureRootIsScheduled`.
If a single event contains multiple updates, we end up running the scheduling code once per update. But this ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26512/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/26512/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26511 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26511/labels{/name} | https://api.github.com/repos/facebook/react/issues/26511/comments | https://api.github.com/repos/facebook/react/issues/26511/events | https://github.com/facebook/react/pull/26511 | 1,646,636,421 | PR_kwDOAJy2Ks5NNeCw | 26,511 | Clean up deferRenderPhaseUpdateToNextBatch | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f0aafa1a7e3338871f60ac3ea8c1c92b8671520c...4bb3a5c1bc95dbed93a88ba81ae394a4539d5312\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 22:42:34 | 2023-03-30 18:10:20 | 2023-03-30 18:10:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26511', 'html_url': 'https://github.com/facebook/react/pull/26511', 'diff_url': 'https://github.com/facebook/react/pull/26511.diff', 'patch_url': 'https://github.com/facebook/react/pull/26511.patch', 'merged_at': datetime.datetime(2023, 3, 30, 18, 10, 20)} | This is a change to some undefined behavior that we though we would do at one point but decided not to roll out. It's already disabled everywhere, so this just deletes the branch from the implementation and the tests. | {'url': 'https://api.github.com/repos/facebook/react/issues/26511/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26511/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26510 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26510/labels{/name} | https://api.github.com/repos/facebook/react/issues/26510/comments | https://api.github.com/repos/facebook/react/issues/26510/events | https://github.com/facebook/react/pull/26510 | 1,646,558,207 | PR_kwDOAJy2Ks5NNNaK | 26,510 | Update useMemoCache test to confirm that cache persists across errors | {'login': 'josephsavona', 'id': 6425824, 'node_id': 'MDQ6VXNlcjY0MjU4MjQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6425824?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/josephsavona', 'html_url': 'https://github.com/josephsavona', 'followers_url': 'https://api.github.com/users/josephsavo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Exciting!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f118b7cebf9c15d11c5973bfd40860b5f457df08...61fd2ab65f75c73395fe47d80323bd79dd66aa83\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greate... | 2023-03-29 21:25:37 | 2023-03-30 14:47:24 | 2023-03-30 14:47:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26510', 'html_url': 'https://github.com/facebook/react/pull/26510', 'diff_url': 'https://github.com/facebook/react/pull/26510.diff', 'patch_url': 'https://github.com/facebook/react/pull/26510.patch', 'merged_at': datetime.datetime(2023, 3, 30, 14, 47, 23)} | ## Summary
Updates the `useMemoCache()` tests to validate that the memo cache persists when a component does a setState during render or throws during render. Forget's compilation output follows the general pattern used in this test and is resilient to rendering running partway and then again with different inputs.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/26510/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26510/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26509 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26509/labels{/name} | https://api.github.com/repos/facebook/react/issues/26509/comments | https://api.github.com/repos/facebook/react/issues/26509/events | https://github.com/facebook/react/pull/26509 | 1,646,511,556 | PR_kwDOAJy2Ks5NNDJo | 26,509 | Convert a few more tests to waitFor test helpers | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 90995ef8b0733ca46b1d9a187828d63ff78852bb...bd7542ea292c749f6b072462b4b186741f6d0198\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 20:51:51 | 2023-03-29 21:02:16 | 2023-03-29 21:02:16 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26509', 'html_url': 'https://github.com/facebook/react/pull/26509', 'diff_url': 'https://github.com/facebook/react/pull/26509.diff', 'patch_url': 'https://github.com/facebook/react/pull/26509.patch', 'merged_at': datetime.datetime(2023, 3, 29, 21, 2, 16)} | Continuing my journey to migrate all the Scheduler flush* methods to async versions of the same helpers. | {'url': 'https://api.github.com/repos/facebook/react/issues/26509/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26509/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26508 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26508/labels{/name} | https://api.github.com/repos/facebook/react/issues/26508/comments | https://api.github.com/repos/facebook/react/issues/26508/events | https://github.com/facebook/react/pull/26508 | 1,646,498,727 | PR_kwDOAJy2Ks5NNAZY | 26,508 | Delete "triangle" resuming fuzz tester | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fc90eb636876d54d99ace2773dd4923f3e848106...80d97bee8a85090d920bcb59151d30046b0f32d4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 20:41:25 | 2023-03-29 20:48:03 | 2023-03-29 20:48:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26508', 'html_url': 'https://github.com/facebook/react/pull/26508', 'diff_url': 'https://github.com/facebook/react/pull/26508.diff', 'patch_url': 'https://github.com/facebook/react/pull/26508.patch', 'merged_at': datetime.datetime(2023, 3, 29, 20, 48, 3)} | This deletes the ReactIncrementalTriangle test suite, which I originally added back in 2017 when I was working on Fiber's "resuming" feature. It was meant to simulate a similar scenario as Seb's "Sierpinski Triangle" Fiber demo.
We eventually ended up removing resuming, but we kept this fuzz tester around since it w... | {'url': 'https://api.github.com/repos/facebook/react/issues/26508/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26508/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26507 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26507/labels{/name} | https://api.github.com/repos/facebook/react/issues/26507/comments | https://api.github.com/repos/facebook/react/issues/26507/events | https://github.com/facebook/react/pull/26507 | 1,646,402,504 | PR_kwDOAJy2Ks5NMrcE | 26,507 | Generate safe javascript url instead of throwing with disableJavaScriptURLs is on | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 85de6fde515148babd36eae2b7384ad8e62b732a...6b5a9e92d6834586a2c749749ff801b28c7afa80\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 19:38:34 | 2023-03-30 03:39:03 | 2023-03-30 03:39:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26507', 'html_url': 'https://github.com/facebook/react/pull/26507', 'diff_url': 'https://github.com/facebook/react/pull/26507.diff', 'patch_url': 'https://github.com/facebook/react/pull/26507.patch', 'merged_at': datetime.datetime(2023, 3, 30, 3, 39, 3)} | We currently throw an error when disableJavaScriptURLs is on and trigger an error boundary. I kind of thought that's what would happen with CSP or Trusted Types anyway. However, that's not what happens. Instead, in those environments what happens is that the error is triggered when you try to actually visit those links... | {'url': 'https://api.github.com/repos/facebook/react/issues/26507/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26507/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26506 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26506/labels{/name} | https://api.github.com/repos/facebook/react/issues/26506/comments | https://api.github.com/repos/facebook/react/issues/26506/events | https://github.com/facebook/react/pull/26506 | 1,646,257,221 | PR_kwDOAJy2Ks5NMMgV | 26,506 | [DevTools] webpack 5 + ignore listing backend to avoid confusion | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1f5cdf8c77182fc51910787e48384ec4620dc40d...e4d485f68ebbf486f720e829505bfeaa82214397\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 17:47:18 | 2023-03-29 23:35:13 | null | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/26506', 'html_url': 'https://github.com/facebook/react/pull/26506', 'diff_url': 'https://github.com/facebook/react/pull/26506.diff', 'patch_url': 'https://github.com/facebook/react/pull/26506.patch', 'merged_at': None} | ## Summary
- Upgrade webpack (and related packages) in react-devtools-extension to latest version (v5)
- Add source map for react_devtools_backend.js in production build so that we can use it to do [ignore listing](https://developer.chrome.com/blog/devtools-better-angular-debugging/#ignore-listing-code)
## How d... | {'url': 'https://api.github.com/repos/facebook/react/issues/26506/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26506/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26505 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26505/labels{/name} | https://api.github.com/repos/facebook/react/issues/26505/comments | https://api.github.com/repos/facebook/react/issues/26505/events | https://github.com/facebook/react/issues/26505 | 1,645,948,833 | I_kwDOAJy2Ks5iGy-h | 26,505 | Suggestion: [eslint-plugin-react-hooks] - should not warn/error when RefObject/MutableRefObject passed from outside hook | {'login': 'sekoyo', 'id': 760314, 'node_id': 'MDQ6VXNlcjc2MDMxNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/760314?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sekoyo', 'html_url': 'https://github.com/sekoyo', 'followers_url': 'https://api.github.com/users/sekoyo/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-29 14:34:20 | 2023-03-29 14:37:37 | 2023-03-29 14:37:37 | NONE | null | null | null | ```
"react": "^18.2.0",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
```
## Steps To Reproduce
```ts
function useMyHook(someRef: React.RefObject<HTMLDivElement>) {
useEffect(() => {
if (someRef.current) {
console.log('it exists')
}
}, []) // error/warning
}... | {'url': 'https://api.github.com/repos/facebook/react/issues/26505/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26505/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26504 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26504/labels{/name} | https://api.github.com/repos/facebook/react/issues/26504/comments | https://api.github.com/repos/facebook/react/issues/26504/events | https://github.com/facebook/react/pull/26504 | 1,645,697,569 | PR_kwDOAJy2Ks5NKSWj | 26,504 | chore: use includes replace indexOf | {'login': 'li-jia-nan', 'id': 49217418, 'node_id': 'MDQ6VXNlcjQ5MjE3NDE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/49217418?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/li-jia-nan', 'html_url': 'https://github.com/li-jia-nan', 'followers_url': 'https://api.github.com/users/li-jia-nan/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1cea384480a6dea80128e5e0ddb714df7bea1520...1fad94ce066b64bb9fd7657c68e9aa67682f74b0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 12:21:04 | 2024-04-17 05:03:40 | 2024-04-17 05:03:40 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26504', 'html_url': 'https://github.com/facebook/react/pull/26504', 'diff_url': 'https://github.com/facebook/react/pull/26504.diff', 'patch_url': 'https://github.com/facebook/react/pull/26504.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26504/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26504/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26503 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26503/labels{/name} | https://api.github.com/repos/facebook/react/issues/26503/comments | https://api.github.com/repos/facebook/react/issues/26503/events | https://github.com/facebook/react/pull/26503 | 1,645,680,132 | PR_kwDOAJy2Ks5NKOmL | 26,503 | Experiments | {'login': 'cosminmarcu3', 'id': 122570911, 'node_id': 'U_kgDOB05Inw', 'avatar_url': 'https://avatars.githubusercontent.com/u/122570911?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cosminmarcu3', 'html_url': 'https://github.com/cosminmarcu3', 'followers_url': 'https://api.github.com/users/cosminmarcu3/f... | [] | closed | false | null | [] | null | [
"Hi @cosminmarcu3! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order ... | 2023-03-29 12:11:21 | 2023-03-29 15:25:47 | 2023-03-29 12:12:00 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26503', 'html_url': 'https://github.com/facebook/react/pull/26503', 'diff_url': 'https://github.com/facebook/react/pull/26503.diff', 'patch_url': 'https://github.com/facebook/react/pull/26503.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/26503/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26503/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26502 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26502/labels{/name} | https://api.github.com/repos/facebook/react/issues/26502/comments | https://api.github.com/repos/facebook/react/issues/26502/events | https://github.com/facebook/react/pull/26502 | 1,645,035,273 | PR_kwDOAJy2Ks5NIC7o | 26,502 | [Float][Flight] Flight support for Float | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fd3fb8e3c5d1c977f4bfa73d715143804c69d4b0...54f91f16e5ec68c2cb4cd94dc43dd9f1926e197f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 04:59:39 | 2023-04-22 03:45:57 | 2023-04-22 03:45:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26502', 'html_url': 'https://github.com/facebook/react/pull/26502', 'diff_url': 'https://github.com/facebook/react/pull/26502.diff', 'patch_url': 'https://github.com/facebook/react/pull/26502.patch', 'merged_at': datetime.datetime(2023, 4, 22, 3, 45, 51)} | Stacked on #26557
Supporting Float methods such as ReactDOM.preload() are challenging for flight because it does not have an easy means to convey direct executions in other environments. Because the flight wire format is a JSON-like serialization that is expected to be rendered it currently only describes renderabl... | {'url': 'https://api.github.com/repos/facebook/react/issues/26502/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26502/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26501 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26501/labels{/name} | https://api.github.com/repos/facebook/react/issues/26501/comments | https://api.github.com/repos/facebook/react/issues/26501/events | https://github.com/facebook/react/pull/26501 | 1,644,875,498 | PR_kwDOAJy2Ks5NHhne | 26,501 | Refactor DOM special cases per tags including controlled fields | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5cbe6258bc436b1683080a6d978c27849f1d9a22...08de5b15c423928acc0560df8dbc8af4cf929782\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-29 01:08:53 | 2023-03-29 05:00:37 | 2023-03-29 02:40:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26501', 'html_url': 'https://github.com/facebook/react/pull/26501', 'diff_url': 'https://github.com/facebook/react/pull/26501.diff', 'patch_url': 'https://github.com/facebook/react/pull/26501.patch', 'merged_at': datetime.datetime(2023, 3, 29, 2, 40, 3)} | I use a shared helper when setting properties into a helper whether it's initial or update.
I moved the special cases per tag to commit phase so we can check it only once. This also effectively inlines getHostProps which can be done in a single check per prop key.
The diffProperties operation is simplified to mos... | {'url': 'https://api.github.com/repos/facebook/react/issues/26501/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26501/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26500 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26500/labels{/name} | https://api.github.com/repos/facebook/react/issues/26500/comments | https://api.github.com/repos/facebook/react/issues/26500/events | https://github.com/facebook/react/issues/26500 | 1,644,510,565 | I_kwDOAJy2Ks5iBT1l | 26,500 | [DevTools Bug]: copy operations don't work in Chrome | {'login': 'aynp', 'id': 75756768, 'node_id': 'MDQ6VXNlcjc1NzU2NzY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/75756768?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aynp', 'html_url': 'https://github.com/aynp', 'followers_url': 'https://api.github.com/users/aynp/followers', 'following_url'... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'hoxyq', 'id': 28902667.0, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'followin... | [{'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following... | null | [
"I did not reproduce this issue. Can you let me know which version of Chrome are you using?",
"I have same issue on\r\nChrome: 111.0.5563.146 (Official Build) (arm64) \r\nOS: Mac M1\r\ndev tools version 4.27.3 (3/22/2023)\r\nalso tried dev tools build from main branch.\r\n",
"I'm running Chromium `Version 111.0... | 2023-03-28 19:02:59 | 2023-04-12 15:12:06 | 2023-04-12 15:12:06 | NONE | null | null | null | ### Website or app
https://react.dev
### Repro steps
1. Go to components tab.
2. For any component, try to copy the value in props, hooks etc. to clipboard.
### How often does this bug happen?
Ever... | {'url': 'https://api.github.com/repos/facebook/react/issues/26500/reactions', 'total_count': 4, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/26500/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26499 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26499/labels{/name} | https://api.github.com/repos/facebook/react/issues/26499/comments | https://api.github.com/repos/facebook/react/issues/26499/events | https://github.com/facebook/react/pull/26499 | 1,644,502,062 | PR_kwDOAJy2Ks5NGRhO | 26,499 | Remove unnecessary CIRCLE_CI_API_TOKEN checks | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1f5cdf8c77182fc51910787e48384ec4620dc40d...ff868a849e421280823afa43961c37a5900faa8d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-28 18:55:47 | 2023-03-28 20:31:35 | 2023-03-28 20:31:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26499', 'html_url': 'https://github.com/facebook/react/pull/26499', 'diff_url': 'https://github.com/facebook/react/pull/26499.diff', 'patch_url': 'https://github.com/facebook/react/pull/26499.patch', 'merged_at': datetime.datetime(2023, 3, 28, 20, 31, 35)} | Token is not required for GET | {'url': 'https://api.github.com/repos/facebook/react/issues/26499/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26499/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26498 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26498/labels{/name} | https://api.github.com/repos/facebook/react/issues/26498/comments | https://api.github.com/repos/facebook/react/issues/26498/events | https://github.com/facebook/react/pull/26498 | 1,644,381,007 | PR_kwDOAJy2Ks5NF3n2 | 26,498 | Update Suspense fuzz tests to use `act` | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: fc90eb636876d54d99ace2773dd4923f3e848106...99ea7d9ec0059c23605945aa9d1b7eb97fcbe91f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-28 17:27:07 | 2023-03-28 18:40:29 | 2023-03-28 18:40:28 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26498', 'html_url': 'https://github.com/facebook/react/pull/26498', 'diff_url': 'https://github.com/facebook/react/pull/26498.diff', 'patch_url': 'https://github.com/facebook/react/pull/26498.patch', 'merged_at': datetime.datetime(2023, 3, 28, 18, 40, 28)} | This updates the Suspense fuzz tester to use `act` to recursively flush timers instead of doing it manually.
This still isn't great because ideally the fuzz tester wouldn't fake timers at all. It should resolve promises using a custom queue instead of Jest's fake timer queue, like we've started doing in our other Su... | {'url': 'https://api.github.com/repos/facebook/react/issues/26498/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26498/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26497 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26497/labels{/name} | https://api.github.com/repos/facebook/react/issues/26497/comments | https://api.github.com/repos/facebook/react/issues/26497/events | https://github.com/facebook/react/pull/26497 | 1,643,997,297 | PR_kwDOAJy2Ks5NElTH | 26,497 | Make disableSchedulerTimeoutInWorkLoop a static ff | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"I think we should leave it on there so that there's at least some tests that run with the flag on, to catch any new bugs we might introduce that would further block the change.",
"> I think we should leave it on there so that there's at least some tests that run with the flag on, to catch any new bugs we might i... | 2023-03-28 13:49:15 | 2023-03-28 18:43:06 | 2023-03-28 18:11:53 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26497', 'html_url': 'https://github.com/facebook/react/pull/26497', 'diff_url': 'https://github.com/facebook/react/pull/26497.diff', 'patch_url': 'https://github.com/facebook/react/pull/26497.patch', 'merged_at': datetime.datetime(2023, 3, 28, 18, 11, 52)} | ## Overview
There's a known infinite loop with this but we're not running an experiment any time soon. | {'url': 'https://api.github.com/repos/facebook/react/issues/26497/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26497/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26496 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26496/labels{/name} | https://api.github.com/repos/facebook/react/issues/26496/comments | https://api.github.com/repos/facebook/react/issues/26496/events | https://github.com/facebook/react/issues/26496 | 1,643,509,820 | I_kwDOAJy2Ks5h9fg8 | 26,496 | Bug: | {'login': 'Sumitmaithani', 'id': 86047367, 'node_id': 'MDQ6VXNlcjg2MDQ3MzY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/86047367?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sumitmaithani', 'html_url': 'https://github.com/Sumitmaithani', 'followers_url': 'https://api.github.com/users/Sumit... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-28 09:03:36 | 2023-03-28 09:03:56 | 2023-03-28 09:03:56 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/26496/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26496/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26495 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26495/labels{/name} | https://api.github.com/repos/facebook/react/issues/26495/comments | https://api.github.com/repos/facebook/react/issues/26495/events | https://github.com/facebook/react/issues/26495 | 1,643,242,671 | I_kwDOAJy2Ks5h8eSv | 26,495 | TypeError: Cannot read properties of undefined (reading '_internalRoot') | {'login': '3gwebtrain', 'id': 6211826, 'node_id': 'MDQ6VXNlcjYyMTE4MjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6211826?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/3gwebtrain', 'html_url': 'https://github.com/3gwebtrain', 'followers_url': 'https://api.github.com/users/3gwebtrain/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The error you're seeing suggests that container is undefined, which is causing the error when attempting to access _internalRoot. This could happen if the element with the ID of \"root\" doesn't exist in the HTML document.\r\n\r\nyou could try something like this, this would solve your issue\r\n\r\n```\r\ndocument... | 2023-03-28 05:46:16 | 2023-05-16 16:15:31 | 2023-05-16 16:15:31 | NONE | null | null | null | I am trying to switch the rendering method according to the env flag. getting an error as:
`TypeError: Cannot read properties of undefined (reading '_internalRoot')`
here is my conditional rendering code:
```
import { StrictMode } from "react";
import { createRoot, hydrateRoot } from "react-dom/client";
imp... | {'url': 'https://api.github.com/repos/facebook/react/issues/26495/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26495/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26494 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26494/labels{/name} | https://api.github.com/repos/facebook/react/issues/26494/comments | https://api.github.com/repos/facebook/react/issues/26494/events | https://github.com/facebook/react/pull/26494 | 1,643,134,957 | PR_kwDOAJy2Ks5NBqqn | 26,494 | Codemod more tests to waitFor pattern | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e0bbc2662301e0d6c9a0cd601c22f7f27e1f56b2...20c2806db56ab79c91e4803e7c8d4f2e1f7ba23c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-28 03:24:19 | 2023-03-28 04:03:57 | 2023-03-28 04:03:57 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26494', 'html_url': 'https://github.com/facebook/react/pull/26494', 'diff_url': 'https://github.com/facebook/react/pull/26494.diff', 'patch_url': 'https://github.com/facebook/react/pull/26494.patch', 'merged_at': datetime.datetime(2023, 3, 28, 4, 3, 57)} | Continuing my journey to migrate all the Scheduler flush* methods to async versions of the same helpers.
Many of the remaining tests are related to unstable_toFlushExpired or unstable_flushNumberOfYields.
Getting closer! | {'url': 'https://api.github.com/repos/facebook/react/issues/26494/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26494/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26493 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26493/labels{/name} | https://api.github.com/repos/facebook/react/issues/26493/comments | https://api.github.com/repos/facebook/react/issues/26493/events | https://github.com/facebook/react/pull/26493 | 1,643,079,713 | PR_kwDOAJy2Ks5NBfKJ | 26,493 | Improve tests that deal with microtasks | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8faf751937e9672fb69dac8143dbfb0929caf77e...b2b39f32d758db8a9683729be87dfa2dca55012c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-28 02:03:26 | 2023-03-28 03:17:56 | 2023-03-28 03:17:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26493', 'html_url': 'https://github.com/facebook/react/pull/26493', 'diff_url': 'https://github.com/facebook/react/pull/26493.diff', 'patch_url': 'https://github.com/facebook/react/pull/26493.patch', 'merged_at': datetime.datetime(2023, 3, 28, 3, 17, 56)} | I rewrote some of our tests that deal with microtasks with the aim of making them less coupled to implementation details. This is related to an upcoming change to move update processing into a microtask. | {'url': 'https://api.github.com/repos/facebook/react/issues/26493/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26493/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26492 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26492/labels{/name} | https://api.github.com/repos/facebook/react/issues/26492/comments | https://api.github.com/repos/facebook/react/issues/26492/events | https://github.com/facebook/react/pull/26492 | 1,642,866,102 | PR_kwDOAJy2Ks5NAw_p | 26,492 | [DevTools] browser extension: improve script injection logic | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Will Lighthouse still be able to find these?"
] | 2023-03-27 21:49:31 | 2023-03-30 07:28:30 | 2023-03-28 16:45:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26492', 'html_url': 'https://github.com/facebook/react/pull/26492', 'diff_url': 'https://github.com/facebook/react/pull/26492.diff', 'patch_url': 'https://github.com/facebook/react/pull/26492.patch', 'merged_at': datetime.datetime(2023, 3, 28, 16, 45, 54)} | ## Summary
- Drop extension support for Chrome / Edge <v102 since they have less than 0.1% usage ([see data](https://caniuse.com/usage-table))
- Improve script injection logic when possible so that the scripts injected by the extension are no longer shown in Network (which caused a lot of confusion in the past)
... | {'url': 'https://api.github.com/repos/facebook/react/issues/26492/reactions', 'total_count': 21, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 11, 'confused': 0, 'heart': 10, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26492/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26491 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26491/labels{/name} | https://api.github.com/repos/facebook/react/issues/26491/comments | https://api.github.com/repos/facebook/react/issues/26491/events | https://github.com/facebook/react/pull/26491 | 1,642,625,856 | PR_kwDOAJy2Ks5M_81s | 26,491 | Codemod some expiration tests to waitForExpired | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8342a09927b18725e1dd2a78b9a78b439528a7d1...23637ba22a8cf95b468fe8f56d8d89ee162006dd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-27 18:44:13 | 2023-03-27 19:52:26 | 2023-03-27 19:52:26 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26491', 'html_url': 'https://github.com/facebook/react/pull/26491', 'diff_url': 'https://github.com/facebook/react/pull/26491.diff', 'patch_url': 'https://github.com/facebook/react/pull/26491.patch', 'merged_at': datetime.datetime(2023, 3, 27, 19, 52, 26)} | Continuing my journey to migrate all the Scheduler flush* methods to async versions of the same helpers.
`unstable_flushExpired` is a rarely used helper that is only meant to be used to test a very particular implementation detail (update starvation prevention, or what we sometimes refer to as "expiration").
I've... | {'url': 'https://api.github.com/repos/facebook/react/issues/26491/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26491/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26490 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26490/labels{/name} | https://api.github.com/repos/facebook/react/issues/26490/comments | https://api.github.com/repos/facebook/react/issues/26490/events | https://github.com/facebook/react/pull/26490 | 1,642,457,540 | PR_kwDOAJy2Ks5M_YoL | 26,490 | Remove disableNativeComponentFrames | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8342a09927b18725e1dd2a78b9a78b439528a7d1...0e6d3ecce6cd16eeeb1f26cd521affc5f70457ef\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-27 16:49:53 | 2023-03-28 13:46:28 | 2023-03-28 13:46:27 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26490', 'html_url': 'https://github.com/facebook/react/pull/26490', 'diff_url': 'https://github.com/facebook/react/pull/26490.diff', 'patch_url': 'https://github.com/facebook/react/pull/26490.patch', 'merged_at': datetime.datetime(2023, 3, 28, 13, 46, 27)} | ## Overview
I'm landing this flag internally so we can delete this | {'url': 'https://api.github.com/repos/facebook/react/issues/26490/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26490/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26489 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26489/labels{/name} | https://api.github.com/repos/facebook/react/issues/26489/comments | https://api.github.com/repos/facebook/react/issues/26489/events | https://github.com/facebook/react/pull/26489 | 1,642,334,932 | PR_kwDOAJy2Ks5M--N2 | 26,489 | Remove skipUnmountedBoundaries | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1a1d61fed98a02c9b1bac029d0bc11c3e4db896d...53967c16b1359557d32e6ab879bd583fe840fd6f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-27 15:34:27 | 2023-03-31 00:58:16 | 2023-03-31 00:58:13 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26489', 'html_url': 'https://github.com/facebook/react/pull/26489', 'diff_url': 'https://github.com/facebook/react/pull/26489.diff', 'patch_url': 'https://github.com/facebook/react/pull/26489.patch', 'merged_at': datetime.datetime(2023, 3, 31, 0, 58, 13)} | # Overview
Landing this flag internally, will test this PR in React Native before merging. | {'url': 'https://api.github.com/repos/facebook/react/issues/26489/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26489/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26488 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26488/labels{/name} | https://api.github.com/repos/facebook/react/issues/26488/comments | https://api.github.com/repos/facebook/react/issues/26488/events | https://github.com/facebook/react/pull/26488 | 1,642,327,651 | PR_kwDOAJy2Ks5M-8rr | 26,488 | Remove unused feature flag disableSchedulerTimeoutBasedOnReactExpirationTime | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 768f965de2d4c6be7f688562ef02382478c82e5b...83ce859681a523c84163bbfa752baca827ba3c90\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-27 15:30:21 | 2023-03-27 15:52:08 | 2023-03-27 15:52:03 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26488', 'html_url': 'https://github.com/facebook/react/pull/26488', 'diff_url': 'https://github.com/facebook/react/pull/26488.diff', 'patch_url': 'https://github.com/facebook/react/pull/26488.patch', 'merged_at': datetime.datetime(2023, 3, 27, 15, 52, 2)} | Easy removal as it's completely unused as @rickhanlonii noticed. | {'url': 'https://api.github.com/repos/facebook/react/issues/26488/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26488/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26487 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26487/labels{/name} | https://api.github.com/repos/facebook/react/issues/26487/comments | https://api.github.com/repos/facebook/react/issues/26487/events | https://github.com/facebook/react/pull/26487 | 1,641,800,136 | PR_kwDOAJy2Ks5M9Mi3 | 26,487 | [flow] make Flow suppressions explicit on the error | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 768f965de2d4c6be7f688562ef02382478c82e5b...b78bcb83c11fdb6c153a6efdcafa6a38350607fc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-27 10:03:47 | 2023-03-27 11:54:39 | 2023-03-27 11:43:05 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26487', 'html_url': 'https://github.com/facebook/react/pull/26487', 'diff_url': 'https://github.com/facebook/react/pull/26487.diff', 'patch_url': 'https://github.com/facebook/react/pull/26487.patch', 'merged_at': datetime.datetime(2023, 3, 27, 11, 43, 5)} | Added an explicit type to all $FlowFixMe suppressions to reduce over-suppressions of new errors that might be caused on the same lines.
Also removes suppressions that aren't used (e.g. in a `@noflow` file as they're purely misleading)
Test Plan:
yarn flow-ci | {'url': 'https://api.github.com/repos/facebook/react/issues/26487/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26487/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26486 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26486/labels{/name} | https://api.github.com/repos/facebook/react/issues/26486/comments | https://api.github.com/repos/facebook/react/issues/26486/events | https://github.com/facebook/react/issues/26486 | 1,641,291,858 | I_kwDOAJy2Ks5h1CBS | 26,486 | Bug: | {'login': 'Lijiaoa', 'id': 61399850, 'node_id': 'MDQ6VXNlcjYxMzk5ODUw', 'avatar_url': 'https://avatars.githubusercontent.com/u/61399850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Lijiaoa', 'html_url': 'https://github.com/Lijiaoa', 'followers_url': 'https://api.github.com/users/Lijiaoa/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-27 03:12:43 | 2023-03-27 03:13:03 | 2023-03-27 03:13:03 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/26486/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26486/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26485 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26485/labels{/name} | https://api.github.com/repos/facebook/react/issues/26485/comments | https://api.github.com/repos/facebook/react/issues/26485/events | https://github.com/facebook/react/issues/26485 | 1,641,251,362 | I_kwDOAJy2Ks5h04Ii | 26,485 | Bug: | {'login': 'SuperEnderSlayerr', 'id': 84186594, 'node_id': 'MDQ6VXNlcjg0MTg2NTk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/84186594?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SuperEnderSlayerr', 'html_url': 'https://github.com/SuperEnderSlayerr', 'followers_url': 'https://api.github.com... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Makes sense. The demo right above doesn't show the next player. Though it's not clear whether we need to adjust the sentence or implement showing who's next earlier. Can you open this on https://github.com/reactjs/react.dev instead so that we get the right eyes on this issue? \r\n\r\nThe repo you opened the issue ... | 2023-03-27 02:23:00 | 2023-05-01 05:23:02 | 2023-05-01 05:23:02 | NONE | null | null | null | https://react.dev/learn/tutorial-tic-tac-toe#declaring-a-winner
This section of the tutorial starts with: "Now that you show which player’s turn is next, you should also show when the game is won and there are no more turns to make."
We add the "status" line during this section of the tutorial, so we have not yet s... | {'url': 'https://api.github.com/repos/facebook/react/issues/26485/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26485/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26484 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26484/labels{/name} | https://api.github.com/repos/facebook/react/issues/26484/comments | https://api.github.com/repos/facebook/react/issues/26484/events | https://github.com/facebook/react/issues/26484 | 1,641,163,041 | I_kwDOAJy2Ks5h0ikh | 26,484 | hahaha react | {'login': 'wansingcheng', 'id': 77646914, 'node_id': 'MDQ6VXNlcjc3NjQ2OTE0', 'avatar_url': 'https://avatars.githubusercontent.com/u/77646914?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wansingcheng', 'html_url': 'https://github.com/wansingcheng', 'followers_url': 'https://api.github.com/users/wansingc... | [] | closed | false | null | [] | null | [
"p00p"
] | 2023-03-27 00:22:35 | 2023-03-27 09:48:13 | 2023-03-27 09:48:13 | NONE | null | null | null | library_manager_system springboot 图书管理系统 , 界面简 @codeKK AndroidOpen Source Website https://p.codekk.com/detail/Android/zhangbw409/library_manager_system
Share From App: Dev Tools(Android Developer Tools) | {'url': 'https://api.github.com/repos/facebook/react/issues/26484/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26484/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26483 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26483/labels{/name} | https://api.github.com/repos/facebook/react/issues/26483/comments | https://api.github.com/repos/facebook/react/issues/26483/events | https://github.com/facebook/react/issues/26483 | 1,641,055,407 | I_kwDOAJy2Ks5h0ISv | 26,483 | High Security Vulnerability found in the dependency Minimist | {'login': 'kvaithin', 'id': 68995267, 'node_id': 'MDQ6VXNlcjY4OTk1MjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/68995267?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kvaithin', 'html_url': 'https://github.com/kvaithin', 'followers_url': 'https://api.github.com/users/kvaithin/followers',... | [] | closed | false | null | [] | null | [
"@kvaithin - can't believe you don't have any response here. \r\n\r\n",
"React does not depend on `minimist`.\r\n\r\nhttps://unpkg.com/browse/react@18.2.0/package.json\r\nhttps://unpkg.com/browse/react-dom@18.2.0/package.json\r\nhttps://unpkg.com/browse/scheduler@0.23.0/package.json\r\n\r\nIt's used by some dev-o... | 2023-03-26 19:43:06 | 2023-04-12 14:21:33 | 2023-04-12 14:21:33 | NONE | null | null | null | The latest version of React is using `"minimist": "^1.2.3"`.
This is identified to have a High level security vulnerability.
More information found here.
https://devhub.checkmarx.com/cve-details/CVE-2021-44906/?utm_source=jetbrains&utm_medium=referral&utm_campaign=rider&utm_term=nuget
Would we wanna update ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26483/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26483/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26482 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26482/labels{/name} | https://api.github.com/repos/facebook/react/issues/26482/comments | https://api.github.com/repos/facebook/react/issues/26482/events | https://github.com/facebook/react/pull/26482 | 1,640,875,295 | PR_kwDOAJy2Ks5M6K1S | 26,482 | chore: fix minor comment typo. | {'login': 'dahalapaar', 'id': 112838370, 'node_id': 'U_kgDOBrnG4g', 'avatar_url': 'https://avatars.githubusercontent.com/u/112838370?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dahalapaar', 'html_url': 'https://github.com/dahalapaar', 'followers_url': 'https://api.github.com/users/dahalapaar/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d12bdcda69afd219f4d91cbd60d6fae2a375d35b...fb66d4d453117fcef58b48085eebfba8f7aff2ba\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-26 11:40:42 | 2024-04-17 05:03:41 | 2024-04-17 05:03:41 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26482', 'html_url': 'https://github.com/facebook/react/pull/26482', 'diff_url': 'https://github.com/facebook/react/pull/26482.diff', 'patch_url': 'https://github.com/facebook/react/pull/26482.patch', 'merged_at': None} | ## This PR Includes
- [x] Corrected a minor typo in comments.
## Description
While going through the source code, I found a minor typo in comments. Though it does not have a significant changes and correction, It would be nice not to have typos. | {'url': 'https://api.github.com/repos/facebook/react/issues/26482/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26482/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26481 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26481/labels{/name} | https://api.github.com/repos/facebook/react/issues/26481/comments | https://api.github.com/repos/facebook/react/issues/26481/events | https://github.com/facebook/react/issues/26481 | 1,640,552,327 | I_kwDOAJy2Ks5hyNeH | 26,481 | Bug: State inside custom hook is always undefined, but is present/defined outside. | {'login': 'VadimasKo', 'id': 54241089, 'node_id': 'MDQ6VXNlcjU0MjQxMDg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/54241089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/VadimasKo', 'html_url': 'https://github.com/VadimasKo', 'followers_url': 'https://api.github.com/users/VadimasKo/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-25 15:14:46 | 2023-03-26 18:48:50 | 2023-03-26 18:48:50 | NONE | null | null | null | React version: react: 18.2.0
## Steps To Reproduce
- Run the code provided in github repo, detailed instructions in the Readme.md
- Linux
- Browser independent
Link to code example:
- [Github repo](https://github.com/VadimasKo/infinite-load)
- File `useFetchImages.ts`
```
const useFetchImages... | {'url': 'https://api.github.com/repos/facebook/react/issues/26481/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26481/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26480 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26480/labels{/name} | https://api.github.com/repos/facebook/react/issues/26480/comments | https://api.github.com/repos/facebook/react/issues/26480/events | https://github.com/facebook/react/pull/26480 | 1,640,534,988 | PR_kwDOAJy2Ks5M5JDJ | 26,480 | Add dynamic flag for sibling pre-rendering in RN | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 73b6435ca4e0c3ae3aac8126509a82420a84f0d7...0f58a9d41ac7f6d92e6ffa974382fcab26b49971\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-25 14:18:36 | 2024-01-24 03:50:33 | 2024-01-24 03:50:30 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26480', 'html_url': 'https://github.com/facebook/react/pull/26480', 'diff_url': 'https://github.com/facebook/react/pull/26480.diff', 'patch_url': 'https://github.com/facebook/react/pull/26480.patch', 'merged_at': None} | Need to run an experiment for this rollout too. | {'url': 'https://api.github.com/repos/facebook/react/issues/26480/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26480/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26479 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26479/labels{/name} | https://api.github.com/repos/facebook/react/issues/26479/comments | https://api.github.com/repos/facebook/react/issues/26479/events | https://github.com/facebook/react/pull/26479 | 1,640,494,125 | PR_kwDOAJy2Ks5M5BMU | 26,479 | [Flight] Add BigInt support | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c54b29b44d24f8f8090da9c7ebf569747a444df...849adf3b7ee6bdb5ad95627c2c56b1093e8b9de1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-25 12:11:01 | 2023-03-29 16:24:12 | 2023-03-29 16:23:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26479', 'html_url': 'https://github.com/facebook/react/pull/26479', 'diff_url': 'https://github.com/facebook/react/pull/26479.diff', 'patch_url': 'https://github.com/facebook/react/pull/26479.patch', 'merged_at': datetime.datetime(2023, 3, 29, 16, 23, 43)} |
## Summary
Adds support for sending `BigInt` to Flight and Flight Reply
## How did you test this change?
- added tests
| {'url': 'https://api.github.com/repos/facebook/react/issues/26479/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26479/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26478 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26478/labels{/name} | https://api.github.com/repos/facebook/react/issues/26478/comments | https://api.github.com/repos/facebook/react/issues/26478/events | https://github.com/facebook/react/pull/26478 | 1,640,485,449 | PR_kwDOAJy2Ks5M4_ku | 26,478 | [Flight] Gated test for dropped transport of undefined object values | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c54b29b44d24f8f8090da9c7ebf569747a444df...67c618f7dfaf87aeea2d0c9a2e15e75d904d6cc7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-25 11:39:14 | 2023-03-29 16:27:58 | 2023-03-29 16:27:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26478', 'html_url': 'https://github.com/facebook/react/pull/26478', 'diff_url': 'https://github.com/facebook/react/pull/26478.diff', 'patch_url': 'https://github.com/facebook/react/pull/26478.patch', 'merged_at': datetime.datetime(2023, 3, 29, 16, 27, 55)} | ## Summary
With https://github.com/facebook/react/pull/26349 we now serialize `undefined`. However, deserializing it on the client is currently indistinguishable from the value missing entirely due to how `JSON.parse` treats `undefined` return value of reviver functions.
This leads to inconsistent behavior of the... | {'url': 'https://api.github.com/repos/facebook/react/issues/26478/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26478/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26477 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26477/labels{/name} | https://api.github.com/repos/facebook/react/issues/26477/comments | https://api.github.com/repos/facebook/react/issues/26477/events | https://github.com/facebook/react/issues/26477 | 1,640,438,212 | I_kwDOAJy2Ks5hxxnE | 26,477 | Bug: Unexpected Suspense SSR Component Behavior with useSyncExternalStore in React 18.3.0-next: Rerender and Fallback State Issues | {'login': 'mgiedrius', 'id': 17888786, 'node_id': 'MDQ6VXNlcjE3ODg4Nzg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/17888786?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mgiedrius', 'html_url': 'https://github.com/mgiedrius', 'followers_url': 'https://api.github.com/users/mgiedrius/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2023-03-25 08:55:38 | 2024-04-17 05:03:43 | 2024-04-17 05:03:42 | NONE | null | null | null | The bug relates to https://github.com/facebook/react/issues/26318. In React 18.2.0 this case prints an error but the functionality seems unexpected. In 18.3.0-next-9c54b29b4-20230322 it doesn't print an error, but unexpected functionality still exists.
React version: 18.3.0-next-9c54b29b4-20230322
## Steps To Rep... | {'url': 'https://api.github.com/repos/facebook/react/issues/26477/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26477/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26476 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26476/labels{/name} | https://api.github.com/repos/facebook/react/issues/26476/comments | https://api.github.com/repos/facebook/react/issues/26476/events | https://github.com/facebook/react/pull/26476 | 1,640,406,707 | PR_kwDOAJy2Ks5M4wVQ | 26,476 | updated good first issues section | {'login': 'kethesainikhil', 'id': 70809367, 'node_id': 'MDQ6VXNlcjcwODA5MzY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/70809367?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kethesainikhil', 'html_url': 'https://github.com/kethesainikhil', 'followers_url': 'https://api.github.com/users/ke... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 73b6435ca4e0c3ae3aac8126509a82420a84f0d7...c98cc70d58d0e36e83e64b407a8371562c33285b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-25 06:55:05 | 2024-04-17 05:03:45 | 2024-04-17 05:03:44 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26476', 'html_url': 'https://github.com/facebook/react/pull/26476', 'diff_url': 'https://github.com/facebook/react/pull/26476.diff', 'patch_url': 'https://github.com/facebook/react/pull/26476.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26476/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26476/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26475 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26475/labels{/name} | https://api.github.com/repos/facebook/react/issues/26475/comments | https://api.github.com/repos/facebook/react/issues/26475/events | https://github.com/facebook/react/pull/26475 | 1,640,402,145 | PR_kwDOAJy2Ks5M4vb5 | 26,475 | seperated Good first issues for beginner and intermediate level coders | {'login': 'kethesainikhil', 'id': 70809367, 'node_id': 'MDQ6VXNlcjcwODA5MzY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/70809367?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kethesainikhil', 'html_url': 'https://github.com/kethesainikhil', 'followers_url': 'https://api.github.com/users/ke... | [] | closed | false | null | [] | null | [
"Hi @kethesainikhil! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn orde... | 2023-03-25 06:34:35 | 2023-03-25 06:53:14 | 2023-03-25 06:53:14 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26475', 'html_url': 'https://github.com/facebook/react/pull/26475', 'diff_url': 'https://github.com/facebook/react/pull/26475.diff', 'patch_url': 'https://github.com/facebook/react/pull/26475.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26475/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26475/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26474 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26474/labels{/name} | https://api.github.com/repos/facebook/react/issues/26474/comments | https://api.github.com/repos/facebook/react/issues/26474/events | https://github.com/facebook/react/pull/26474 | 1,640,225,776 | PR_kwDOAJy2Ks5M4LGf | 26,474 | [Flight Plugin] Scan for "use client" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 175962c10c53e5adfcfc02a3d6cc3f487d5a78a0...566e982c36b14c79a0006d5eb882982b2c7999b2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-25 00:13:28 | 2024-02-14 16:01:00 | 2023-03-30 21:05:04 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26474', 'html_url': 'https://github.com/facebook/react/pull/26474', 'diff_url': 'https://github.com/facebook/react/pull/26474.diff', 'patch_url': 'https://github.com/facebook/react/pull/26474.patch', 'merged_at': datetime.datetime(2023, 3, 30, 21, 5, 4)} | ## Summary
Our toy webpack plugin for Server Components is pretty broken right now because, now that `.client.js` convention is gone, it ends up adding every single JS file it can find (including `node_modules`) as a potential async dependency. Instead, it should only look for files with the `'use client'` directive... | {'url': 'https://api.github.com/repos/facebook/react/issues/26474/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/26474/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26473 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26473/labels{/name} | https://api.github.com/repos/facebook/react/issues/26473/comments | https://api.github.com/repos/facebook/react/issues/26473/events | https://github.com/facebook/react/pull/26473 | 1,640,209,976 | PR_kwDOAJy2Ks5M4HfU | 26,473 | Fix remaining CommonJS imports after Rollup upgrade | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 909c6dacfde06b87fa22f2e8506c47124cf982b5...f51ad74b45684ab8a5f55a5471b873f5ce81b327\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-24 23:58:34 | 2024-02-14 16:01:01 | 2023-03-25 00:05:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26473', 'html_url': 'https://github.com/facebook/react/pull/26473', 'diff_url': 'https://github.com/facebook/react/pull/26473.diff', 'patch_url': 'https://github.com/facebook/react/pull/26473.patch', 'merged_at': datetime.datetime(2023, 3, 25, 0, 5, 24)} | Follow-up to https://github.com/facebook/react/pull/26442.
It looks like we missed a few cases where we default import a CommonJS module, which leads to Rollup adding `.default` access, e.g. `require('webpack/lib/Template').default` in the output.
To fix, add the remaining cases to the list of exceptions. Verifie... | {'url': 'https://api.github.com/repos/facebook/react/issues/26473/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26473/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26472 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26472/labels{/name} | https://api.github.com/repos/facebook/react/issues/26472/comments | https://api.github.com/repos/facebook/react/issues/26472/events | https://github.com/facebook/react/pull/26472 | 1,640,207,757 | PR_kwDOAJy2Ks5M4G_I | 26,472 | [TEMP] Bad test | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2023-03-24 23:55:45 | 2023-03-25 03:45:04 | 2023-03-25 03:44:58 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/26472', 'html_url': 'https://github.com/facebook/react/pull/26472', 'diff_url': 'https://github.com/facebook/react/pull/26472.diff', 'patch_url': 'https://github.com/facebook/react/pull/26472.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26472/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26472/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26470 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26470/labels{/name} | https://api.github.com/repos/facebook/react/issues/26470/comments | https://api.github.com/repos/facebook/react/issues/26470/events | https://github.com/facebook/react/pull/26470 | 1,639,894,889 | PR_kwDOAJy2Ks5M3CV2 | 26,470 | React DevTools 4.27.3 -> 4.27.4 | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2023-03-24 19:01:05 | 2023-03-24 19:45:27 | 2023-03-24 19:45:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26470', 'html_url': 'https://github.com/facebook/react/pull/26470', 'diff_url': 'https://github.com/facebook/react/pull/26470.diff', 'patch_url': 'https://github.com/facebook/react/pull/26470.patch', 'merged_at': datetime.datetime(2023, 3, 24, 19, 45, 27)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/26470/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26470/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26469 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26469/labels{/name} | https://api.github.com/repos/facebook/react/issues/26469/comments | https://api.github.com/repos/facebook/react/issues/26469/events | https://github.com/facebook/react/pull/26469 | 1,639,872,963 | PR_kwDOAJy2Ks5M29iJ | 26,469 | [DevTools] missing file name in package.json | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [] | 2023-03-24 18:43:49 | 2023-03-24 18:45:37 | 2023-03-24 18:45:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26469', 'html_url': 'https://github.com/facebook/react/pull/26469', 'diff_url': 'https://github.com/facebook/react/pull/26469.diff', 'patch_url': 'https://github.com/facebook/react/pull/26469.patch', 'merged_at': datetime.datetime(2023, 3, 24, 18, 45, 28)} | resolves https://github.com/facebook/react/pull/26337#issuecomment-1483004732 | {'url': 'https://api.github.com/repos/facebook/react/issues/26469/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26469/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26468 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26468/labels{/name} | https://api.github.com/repos/facebook/react/issues/26468/comments | https://api.github.com/repos/facebook/react/issues/26468/events | https://github.com/facebook/react/pull/26468 | 1,639,633,921 | PR_kwDOAJy2Ks5M2Kcb | 26,468 | Fix Flow types of useEffectEvent | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c54b29b44d24f8f8090da9c7ebf569747a444df...f932f3450913fa48672ca867af405b7d00fb2001\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-24 15:46:35 | 2023-03-25 20:06:49 | 2023-03-25 19:24:00 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26468', 'html_url': 'https://github.com/facebook/react/pull/26468', 'diff_url': 'https://github.com/facebook/react/pull/26468.diff', 'patch_url': 'https://github.com/facebook/react/pull/26468.patch', 'merged_at': datetime.datetime(2023, 3, 25, 19, 24)} | ## Summary
Just copied the types over from the internal types. Type error was hidden by overly broad FlowFixMe. With `$FlowFixMe[not-a-function]` we would've seen the actual issue:
```
Cannot return `dispatcher.useEffectEvent(...)` because `T` [1] is incompatible with undefined [2].Flow(incompatible-return)
``... | {'url': 'https://api.github.com/repos/facebook/react/issues/26468/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26468/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26467 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26467/labels{/name} | https://api.github.com/repos/facebook/react/issues/26467/comments | https://api.github.com/repos/facebook/react/issues/26467/events | https://github.com/facebook/react/issues/26467 | 1,638,825,118 | I_kwDOAJy2Ks5hrnye | 26,467 | Bug: `useEffect()` is called with incorrect context in strict mode | {'login': 'catamphetamine', 'id': 477167, 'node_id': 'MDQ6VXNlcjQ3NzE2Nw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/477167?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/catamphetamine', 'html_url': 'https://github.com/catamphetamine', 'followers_url': 'https://api.github.com/users/catamp... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Ok, I guess that's the intended behavior to prevent components from adding listeners in `useMemo()` calls. Closing.",
"Hi @catamphetamine , what do you mean by `prevent components from adding listeners in useMemo() calls` ? ",
"@Tomassito Hi. I dunno what I meant there. Also, I dunno why the \"Expected behavi... | 2023-03-24 06:44:15 | 2023-10-10 19:27:57 | 2023-03-24 07:11:34 | CONTRIBUTOR | null | null | null | React version: 18.2.0
## Steps To Reproduce
1. Go to the example page
2. Open the "Console"
Link to code example:
https://codesandbox.io/s/react-strictmode-effect-context-bug-demo-i4284t?file=/src/index.js
## The current behavior
The console says:
```
Render Number 1
Is First Number
Render Numb... | {'url': 'https://api.github.com/repos/facebook/react/issues/26467/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26467/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26466 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26466/labels{/name} | https://api.github.com/repos/facebook/react/issues/26466/comments | https://api.github.com/repos/facebook/react/issues/26466/events | https://github.com/facebook/react/issues/26466 | 1,637,950,212 | I_kwDOAJy2Ks5hoSME | 26,466 | When a state is update the whole component is getting Re-rendered instead it should Re-render only those element where the updated state is used | {'login': 'Vikram125609', 'id': 93823479, 'node_id': 'U_kgDOBZeh9w', 'avatar_url': 'https://avatars.githubusercontent.com/u/93823479?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Vikram125609', 'html_url': 'https://github.com/Vikram125609', 'followers_url': 'https://api.github.com/users/Vikram125609/fol... | [] | closed | false | null | [] | null | [
"By default, React re-renders components recursively from where the state was updated. It can skip over parts of your tree (if they're expensive) using [`memo`](https://react.dev/reference/react/memo).\r\n\r\nIn longer term, we'd like to solve this using a compiler — you can read about our progress [here](https://r... | 2023-03-23 17:16:25 | 2023-03-23 17:54:42 | 2023-03-23 17:54:42 | NONE | null | null | null | For eg in the below code when the State Count is Updated it prints in the console
Component Render Count 0
Component Render First 1
Instead of it should print only Component Render Count 0
there is no need to Render the Second Button because the state Count is not used there
```
import { useState } from "r... | {'url': 'https://api.github.com/repos/facebook/react/issues/26466/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26466/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26465 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26465/labels{/name} | https://api.github.com/repos/facebook/react/issues/26465/comments | https://api.github.com/repos/facebook/react/issues/26465/events | https://github.com/facebook/react/issues/26465 | 1,637,001,845 | I_kwDOAJy2Ks5hkqp1 | 26,465 | [DevTools Bug] Cannot add child "1161" to parent "942" because parent node was not found in the Store. | {'login': 'bhanuUdai', 'id': 110327079, 'node_id': 'U_kgDOBpN1Jw', 'avatar_url': 'https://avatars.githubusercontent.com/u/110327079?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bhanuUdai', 'html_url': 'https://github.com/bhanuUdai', 'followers_url': 'https://api.github.com/users/bhanuUdai/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"@bhanuUdai \r\n\r\nCan you please provide an example of the code that reproduces the problem?\r\nSome useful tips on this: https://stackoverflow.com/help/mcve",
"this error is coming with every react application i try to run on browser\n\nOn Mon, Apr 3, 2023 at 4:22 PM Ruslan Lesiutin ***@***.***>\nwrote:\n\n> @... | 2023-03-23 07:36:11 | 2024-03-26 15:03:39 | null | NONE | null | null | null | ### Website or app
chrome on local host
### Repro steps
it happen with every component that i mount
<img width="1470" alt="Screenshot 2023-03-23 at 1 04 00 PM" src="https://user-images.githubusercontent.com/110327079/227134701-d665feca-3326-401e-b957-007c41318be6.png">
### How often does this bug happen?
Every... | {'url': 'https://api.github.com/repos/facebook/react/issues/26465/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26465/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/26464 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26464/labels{/name} | https://api.github.com/repos/facebook/react/issues/26464/comments | https://api.github.com/repos/facebook/react/issues/26464/events | https://github.com/facebook/react/pull/26464 | 1,636,695,286 | PR_kwDOAJy2Ks5MsQ9W | 26,464 | eslint: Add suggestion to remove literals from dependency arrays | {'login': 'mateusmtoledo', 'id': 98076988, 'node_id': 'U_kgDOBdiJPA', 'avatar_url': 'https://avatars.githubusercontent.com/u/98076988?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mateusmtoledo', 'html_url': 'https://github.com/mateusmtoledo', 'followers_url': 'https://api.github.com/users/mateusmtoledo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"The tests for missing dependencies also use literals, so I added the new expected suggestions. I'm not sure whether these dependencies can safely be removed from the tests since the suggested fix completely replaces the dependency array."
] | 2023-03-23 01:08:27 | 2023-09-20 23:52:07 | 2023-09-20 23:47:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26464', 'html_url': 'https://github.com/facebook/react/pull/26464', 'diff_url': 'https://github.com/facebook/react/pull/26464.diff', 'patch_url': 'https://github.com/facebook/react/pull/26464.patch', 'merged_at': None} | ## Summary
Adds a suggestion to remove literals from dependency arrays, as it is marked as a TODO.
## How did you test this change?
- Added tests
- Tested manually in an existing React project
| {'url': 'https://api.github.com/repos/facebook/react/issues/26464/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26464/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26463 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26463/labels{/name} | https://api.github.com/repos/facebook/react/issues/26463/comments | https://api.github.com/repos/facebook/react/issues/26463/events | https://github.com/facebook/react/issues/26463 | 1,636,485,915 | I_kwDOAJy2Ks5hissb | 26,463 | eslint react-hooks/rulesOfHooks: add rule to check for non-function return from useEffect | {'login': 'jlbooker', 'id': 3429673, 'node_id': 'MDQ6VXNlcjM0Mjk2NzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3429673?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jlbooker', 'html_url': 'https://github.com/jlbooker', 'followers_url': 'https://api.github.com/users/jlbooker/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This has nothing to do with rules of hooks. What you want is type checking, that is what TypeScript is for",
"@vkurchatkin Yes, a realize a full and complete solution to this requires a type checking system to fully evaluate the return type. However, it seems there are at least a few cases we could check for wit... | 2023-03-22 20:56:49 | 2024-04-29 11:03:57 | 2024-04-29 11:03:57 | NONE | null | null | null | Feature request: Could we add an eslint rule to eslint-plugin-react-hooks to show an error when a non-function value is returned from within a `useEffect` call?
For the function passed to the `useEffect` hook, valid return statements are:
`return;` (no value)
`return undefined;` (unnecessarily verbose, but still v... | {'url': 'https://api.github.com/repos/facebook/react/issues/26463/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26463/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26462 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26462/labels{/name} | https://api.github.com/repos/facebook/react/issues/26462/comments | https://api.github.com/repos/facebook/react/issues/26462/events | https://github.com/facebook/react/issues/26462 | 1,636,272,574 | I_kwDOAJy2Ks5hh4m- | 26,462 | [DevTools Bug]: 'Unable to find React on the page' in incognito on Firefox | {'login': 'MaxLeiter', 'id': 8675906, 'node_id': 'MDQ6VXNlcjg2NzU5MDY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8675906?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MaxLeiter', 'html_url': 'https://github.com/MaxLeiter', 'followers_url': 'https://api.github.com/users/MaxLeiter/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Duplicate of #16547"
] | 2023-03-22 18:12:35 | 2023-03-28 20:47:28 | 2023-03-28 20:47:28 | NONE | null | null | null | ### Website or app
https://react.dev
### Repro steps
1. Open an incognito tab
2. visit a react 18 website
3. try and use dev tools (I'm on `4.27.1`)
<img width="1728" alt="CleanShot 2023-03-22 at 11 10 16@2x" src="https://user-images.githubusercontent.com/8675906/226998803-79f8e57b-ab7f-46e1-9cad-8744fe92... | {'url': 'https://api.github.com/repos/facebook/react/issues/26462/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26462/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.