url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/26354 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26354/labels{/name} | https://api.github.com/repos/facebook/react/issues/26354/comments | https://api.github.com/repos/facebook/react/issues/26354/events | https://github.com/facebook/react/issues/26354 | 1,616,584,442 | I_kwDOAJy2Ks5gWx76 | 26,354 | Bug: Perfect | {'login': 'JoemonReflections', 'id': 105621339, 'node_id': 'U_kgDOBkunWw', 'avatar_url': 'https://avatars.githubusercontent.com/u/105621339?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoemonReflections', 'html_url': 'https://github.com/JoemonReflections', 'followers_url': 'https://api.github.com/users... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"kmjnhbgvfcdxsz"
] | 2023-03-09 07:23:47 | 2023-03-09 07:24:20 | 2023-03-09 07:24:13 | NONE | null | null | null | React Is Working Perfectly for me | {'url': 'https://api.github.com/repos/facebook/react/issues/26354/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26354/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26353 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26353/labels{/name} | https://api.github.com/repos/facebook/react/issues/26353/comments | https://api.github.com/repos/facebook/react/issues/26353/events | https://github.com/facebook/react/pull/26353 | 1,616,465,304 | PR_kwDOAJy2Ks5Loles | 26,353 | [Float][Fizz]: Don't preload nomodule scripts | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"cc @ijjk",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2b003a5cc6df77f745e1639404f912bd0077a39b...e3e734981d9af4c6ff8fdcaabd685d26fbbbdef1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater... | 2023-03-09 05:43:04 | 2023-03-10 01:19:28 | 2023-03-09 05:59:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26353', 'html_url': 'https://github.com/facebook/react/pull/26353', 'diff_url': 'https://github.com/facebook/react/pull/26353.diff', 'patch_url': 'https://github.com/facebook/react/pull/26353.patch', 'merged_at': datetime.datetime(2023, 3, 9, 5, 59, 43)} | We attempt to preload scripts that we detect during Fizz rendering however when `noModule={true}` we should not because it will force modern browser to fetch scripts they will never execute
Hoisted script resources already don't preload because we just emit the resource immediately. This change currently on affects ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26353/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26353/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26352 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26352/labels{/name} | https://api.github.com/repos/facebook/react/issues/26352/comments | https://api.github.com/repos/facebook/react/issues/26352/events | https://github.com/facebook/react/issues/26352 | 1,616,082,540 | I_kwDOAJy2Ks5gU3Zs | 26,352 | [DevTools Bug]: provide an icon to Edge devtools? | {'login': 'yanlingwang23', 'id': 108438266, 'node_id': 'U_kgDOBnai-g', 'avatar_url': 'https://avatars.githubusercontent.com/u/108438266?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yanlingwang23', 'html_url': 'https://github.com/yanlingwang23', 'followers_url': 'https://api.github.com/users/yanlingwang... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github... | closed | false | null | [] | null | [
"@yanlingwang23: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal cod... | 2023-03-08 23:01:21 | 2023-04-11 18:43:43 | 2023-04-11 18:43:43 | NONE | null | null | null | ### Website or app
Website: https://reactjs.org/
### Repro steps
1. open developer tools in Edge
2. go to settings -> experiment -> enable Focus Mode -> reload DevTools
3. we can see the react extension is loaded as below in devtools:
![image](https://user-images.githubusercontent.com/108438266/223870494-50... | {'url': 'https://api.github.com/repos/facebook/react/issues/26352/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26352/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26351 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26351/labels{/name} | https://api.github.com/repos/facebook/react/issues/26351/comments | https://api.github.com/repos/facebook/react/issues/26351/events | https://github.com/facebook/react/pull/26351 | 1,615,959,648 | PR_kwDOAJy2Ks5Lm20_ | 26,351 | Split out ServerReferenceMetadata into Id and Bound Arguments | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d8e49f2af84c810457eb81ac7fe68fd0fdece859...dcbe7815cbfc2e2d5af0560b800e85d4b2e3c948\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 21:20:11 | 2023-03-09 04:45:55 | 2023-03-09 04:45:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26351', 'html_url': 'https://github.com/facebook/react/pull/26351', 'diff_url': 'https://github.com/facebook/react/pull/26351.diff', 'patch_url': 'https://github.com/facebook/react/pull/26351.patch', 'merged_at': datetime.datetime(2023, 3, 9, 4, 45, 55)} | This is just moving some stuff around and renaming things.
This tuple is opaque to the Flight implementation and we should probably encode it separately as a single string instead of a model object.
The term "Metadata" isn't the same as when used for ClientReferences so it's not really the right term anyway.
I... | {'url': 'https://api.github.com/repos/facebook/react/issues/26351/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26351/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26350 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26350/labels{/name} | https://api.github.com/repos/facebook/react/issues/26350/comments | https://api.github.com/repos/facebook/react/issues/26350/events | https://github.com/facebook/react/pull/26350 | 1,615,941,156 | PR_kwDOAJy2Ks5LmzH6 | 26,350 | Codemod redundant async act scopes | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 037378202f1a99c79ed778a1555b0b2c32974a10...1be3edbfae9a19edb44cacb38bab2f60e42c962d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 21:07:08 | 2023-03-08 21:40:24 | 2023-03-08 21:40:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26350', 'html_url': 'https://github.com/facebook/react/pull/26350', 'diff_url': 'https://github.com/facebook/react/pull/26350.diff', 'patch_url': 'https://github.com/facebook/react/pull/26350.patch', 'merged_at': datetime.datetime(2023, 3, 8, 21, 40, 24)} | Prior to #26347, our internal `act` API (not the public API) behaved differently depending on whether the scope function returned a promise (i.e. was an async function), for historical reasons that no longer apply. Now that this is fixed, I've codemodded all async act scopes that don't contain an await to be sync.
N... | {'url': 'https://api.github.com/repos/facebook/react/issues/26350/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26350/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26349 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26349/labels{/name} | https://api.github.com/repos/facebook/react/issues/26349/comments | https://api.github.com/repos/facebook/react/issues/26349/events | https://github.com/facebook/react/pull/26349 | 1,615,913,787 | PR_kwDOAJy2Ks5Lms_H | 26,349 | [Flight] Add support for returning `undefined` from render | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3706edb81c84ea01e68bfb477537ba9908e1bd70...97322599b43bfe29177281d29fe91936127e4769\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 20:49:23 | 2024-02-15 11:24:35 | 2023-03-09 21:18:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26349', 'html_url': 'https://github.com/facebook/react/pull/26349', 'diff_url': 'https://github.com/facebook/react/pull/26349.diff', 'patch_url': 'https://github.com/facebook/react/pull/26349.patch', 'merged_at': datetime.datetime(2023, 3, 9, 21, 18, 53)} | ## Summary
Adds support for returning `undefined` from Server Components.
Also fixes a bug where rendering an empty fragment would throw the same error as returning undefined.
## How did you test this change?
- [x] test failed with same error message I got when returning undefined from Server Components in a ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26349/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26349/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26348 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26348/labels{/name} | https://api.github.com/repos/facebook/react/issues/26348/comments | https://api.github.com/repos/facebook/react/issues/26348/events | https://github.com/facebook/react/pull/26348 | 1,615,875,029 | PR_kwDOAJy2Ks5Lmk_1 | 26,348 | Use setTimeout to schedule work on the server in Edge environments | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 49f7410467950de57bd1d9509e67de91185f7bad...83b420e8cd5544e322162007ad96c3f51dcfd337\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 20:22:24 | 2023-03-08 21:32:53 | 2023-03-08 20:34:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26348', 'html_url': 'https://github.com/facebook/react/pull/26348', 'diff_url': 'https://github.com/facebook/react/pull/26348.diff', 'patch_url': 'https://github.com/facebook/react/pull/26348.patch', 'merged_at': datetime.datetime(2023, 3, 8, 20, 34, 30)} | We rely heavily on being able to batch rendering after multiple fetches etc. have completed on the server. However, we only do this in the Node.js build. Node.js `setImmediate` has the exact semantics we need. To be after the current cycle of I/O so that we can collect after all those I/O events already in the queue ha... | {'url': 'https://api.github.com/repos/facebook/react/issues/26348/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26348/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26347 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26347/labels{/name} | https://api.github.com/repos/facebook/react/issues/26347/comments | https://api.github.com/repos/facebook/react/issues/26347/events | https://github.com/facebook/react/pull/26347 | 1,615,855,613 | PR_kwDOAJy2Ks5LmgwA | 26,347 | Internal `act`: Call scope function after an async gap | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 83643778bd5805504c87cce90ca997d13bf528d1...ffabc0c349560e7472ad3e9d170b1d88ff9c8fa5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 20:06:14 | 2023-03-08 21:31:45 | 2023-03-08 21:25:13 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26347', 'html_url': 'https://github.com/facebook/react/pull/26347', 'diff_url': 'https://github.com/facebook/react/pull/26347.diff', 'patch_url': 'https://github.com/facebook/react/pull/26347.patch', 'merged_at': datetime.datetime(2023, 3, 8, 21, 25, 13)} | This adds an async gap to our internal implementation of `act` (the one used by our repo, not the public API). Rather than call the provided scope function synchronously when `act` is called, we call it in a separate async task. This is an extra precaution to ensure that our tests do not accidentally rely on work being... | {'url': 'https://api.github.com/repos/facebook/react/issues/26347/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26347/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26346 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26346/labels{/name} | https://api.github.com/repos/facebook/react/issues/26346/comments | https://api.github.com/repos/facebook/react/issues/26346/events | https://github.com/facebook/react/pull/26346 | 1,615,811,503 | PR_kwDOAJy2Ks5LmXtY | 26,346 | Remove timers from ReactDOMSuspensePlaceholder tests | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 44d3807945700de8bb6bdbbf5c4d1ba513303747...67d047c708072675f4da3c0ff70ee455cab67abb\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 19:36:37 | 2023-03-08 19:45:36 | 2023-03-08 19:45:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26346', 'html_url': 'https://github.com/facebook/react/pull/26346', 'diff_url': 'https://github.com/facebook/react/pull/26346.diff', 'patch_url': 'https://github.com/facebook/react/pull/26346.patch', 'merged_at': datetime.datetime(2023, 3, 8, 19, 45, 35)} | Our internal `act` implementation flushes Jest's fake timer queue as a way to force Suspense fallbacks to appear. So we should avoid using timers in our internal tests. | {'url': 'https://api.github.com/repos/facebook/react/issues/26346/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26346/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26345 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26345/labels{/name} | https://api.github.com/repos/facebook/react/issues/26345/comments | https://api.github.com/repos/facebook/react/issues/26345/events | https://github.com/facebook/react/pull/26345 | 1,615,810,422 | PR_kwDOAJy2Ks5LmXeY | 26,345 | Internal test helpers: Use Node's MessageChannel to queue task | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f36ab0e375b6223d4cc5852f649e93c1cb238bac...8be059f58c30d0efbf8136c452af11d67ec69b7b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 19:35:39 | 2023-03-08 20:04:39 | 2023-03-08 20:04:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26345', 'html_url': 'https://github.com/facebook/react/pull/26345', 'diff_url': 'https://github.com/facebook/react/pull/26345.diff', 'patch_url': 'https://github.com/facebook/react/pull/26345.patch', 'merged_at': datetime.datetime(2023, 3, 8, 20, 4, 38)} | To wait for the microtask queue to empty, our internal test helpers schedule an arbitrary task using `setImmediate`. It doesn't matter what kind of task it is, only that it's a separate task from the current one, because by the time it fires, the microtasks for the current event will have already been processed.
The... | {'url': 'https://api.github.com/repos/facebook/react/issues/26345/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26345/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26344 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26344/labels{/name} | https://api.github.com/repos/facebook/react/issues/26344/comments | https://api.github.com/repos/facebook/react/issues/26344/events | https://github.com/facebook/react/pull/26344 | 1,615,600,360 | PR_kwDOAJy2Ks5LlqkI | 26,344 | Move internalAct to internal-test-utils package | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d8144730475cf2d71781e26e300d0d579ac6b8d9...8eb7a943fb559f2609fc62763d16023b988eeb68\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 16:57:23 | 2023-03-08 17:58:32 | 2023-03-08 17:58:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26344', 'html_url': 'https://github.com/facebook/react/pull/26344', 'diff_url': 'https://github.com/facebook/react/pull/26344.diff', 'patch_url': 'https://github.com/facebook/react/pull/26344.patch', 'merged_at': datetime.datetime(2023, 3, 8, 17, 58, 31)} | This is not a public API. We only use it for our internal tests, the ones in this repo. Let's move it to this private package. Practically speaking this will also let us use async/await in the implementation. | {'url': 'https://api.github.com/repos/facebook/react/issues/26344/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26344/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26343 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26343/labels{/name} | https://api.github.com/repos/facebook/react/issues/26343/comments | https://api.github.com/repos/facebook/react/issues/26343/events | https://github.com/facebook/react/pull/26343 | 1,615,516,439 | PR_kwDOAJy2Ks5LlYnE | 26,343 | Build: specify Node.js 16 as minimum for dev | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 161f6ae42cf570d3daec355abcf3b006c58315da...f23ffff50a13eba8186204bb254164366586b6ea\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 15:59:30 | 2023-03-08 17:26:27 | 2023-03-08 17:14:37 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26343', 'html_url': 'https://github.com/facebook/react/pull/26343', 'diff_url': 'https://github.com/facebook/react/pull/26343.diff', 'patch_url': 'https://github.com/facebook/react/pull/26343.patch', 'merged_at': datetime.datetime(2023, 3, 8, 17, 14, 37)} | - Specifies Node 16 as the minimum supported version.
- Remove no longer supported 17.x version (per https://nodejs.dev/en/about/releases/)
- Add 19.x
Test Plan:
(using node 19) as that's what I'm adding)
- yarn build
- yarn test | {'url': 'https://api.github.com/repos/facebook/react/issues/26343/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26343/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26342 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26342/labels{/name} | https://api.github.com/repos/facebook/react/issues/26342/comments | https://api.github.com/repos/facebook/react/issues/26342/events | https://github.com/facebook/react/pull/26342 | 1,615,434,563 | PR_kwDOAJy2Ks5LlHHK | 26,342 | previewOfNewUpdatedReactDoc | {'login': 'faizaniqbalLC', 'id': 102588816, 'node_id': 'U_kgDOBh1hkA', 'avatar_url': 'https://avatars.githubusercontent.com/u/102588816?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/faizaniqbalLC', 'html_url': 'https://github.com/faizaniqbalLC', 'followers_url': 'https://api.github.com/users/faizaniqbal... | [] | closed | false | null | [] | null | [
"Hi @faizaniqbalLC! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order... | 2023-03-08 15:08:50 | 2023-03-17 11:27:19 | 2023-03-08 15:23:07 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26342', 'html_url': 'https://github.com/facebook/react/pull/26342', 'diff_url': 'https://github.com/facebook/react/pull/26342.diff', 'patch_url': 'https://github.com/facebook/react/pull/26342.patch', 'merged_at': None} | I put this snippet because, If a beginner want to learn deep concepts of React Hook then he can try beta version of ReactJs. Thanks & Regards: Muhammad Fizan Iqbal
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26342/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26342/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26341 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26341/labels{/name} | https://api.github.com/repos/facebook/react/issues/26341/comments | https://api.github.com/repos/facebook/react/issues/26341/events | https://github.com/facebook/react/pull/26341 | 1,615,333,179 | PR_kwDOAJy2Ks5LkxOO | 26,341 | Restore definition of NativeMethods as an object for React Native | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: aef930314f55d4b445078f83be53d46028d4574c...e60e211d0d1e1962d8e9682c9d2c293546a8b018\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 14:04:35 | 2023-03-08 14:38:59 | 2023-03-08 14:37:38 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26341', 'html_url': 'https://github.com/facebook/react/pull/26341', 'diff_url': 'https://github.com/facebook/react/pull/26341.diff', 'patch_url': 'https://github.com/facebook/react/pull/26341.patch', 'merged_at': datetime.datetime(2023, 3, 8, 14, 37, 38)} | ## Summary
In #26283, I changed definition of `NativeMethods` from an object to an interface. This is correct but introduces a lot of errors in React Native, so this restores the original definition and exports the fixed type as a separate type so we can gradually migrate in React Native.
## How did you test this... | {'url': 'https://api.github.com/repos/facebook/react/issues/26341/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26341/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26340 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26340/labels{/name} | https://api.github.com/repos/facebook/react/issues/26340/comments | https://api.github.com/repos/facebook/react/issues/26340/events | https://github.com/facebook/react/issues/26340 | 1,615,253,421 | I_kwDOAJy2Ks5gRs-t | 26,340 | [DevTools Bug] Cannot add node "621" because a node with that id is already in the Store. | {'login': 'iprinceroyy', 'id': 84081202, 'node_id': 'MDQ6VXNlcjg0MDgxMjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/84081202?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/iprinceroyy', 'html_url': 'https://github.com/iprinceroyy', 'followers_url': 'https://api.github.com/users/iprinceroyy... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"trying to fix it",
"> trying to fix it\r\n\r\nhey, @5unnyWind have you fixed it?",
"\r\nhey,but I don't seem to be getting the error you're talking about\r\n\r\n",
"I am also experiencing this issue... | 2023-03-08 13:15:00 | 2023-05-23 15:32:59 | null | NONE | null | null | null | ### Website or app
https://github.com/iprinceroyy/crwn-clothing
### Repro steps
Bug report:
1. Clone & run in the local environment.
2. Sign in.
3. Head over to the shop.
4. Add some items to cart.
5. Click on the cart icon.
### How often does this bug happen?
Every time
### DevTools package (automated)
rea... | {'url': 'https://api.github.com/repos/facebook/react/issues/26340/reactions', 'total_count': 12, '+1': 12, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26340/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/26339 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26339/labels{/name} | https://api.github.com/repos/facebook/react/issues/26339/comments | https://api.github.com/repos/facebook/react/issues/26339/events | https://github.com/facebook/react/pull/26339 | 1,614,551,854 | PR_kwDOAJy2Ks5LiLEH | 26,339 | [Internal API only] Delete non-awaited form of act | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 702fc984e68e852c76e0df608cd631a7c2e7763f...edde672360c0c50cb97950513053861fd58bae82\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 02:39:28 | 2023-03-08 16:50:13 | 2023-03-08 16:46:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26339', 'html_url': 'https://github.com/facebook/react/pull/26339', 'diff_url': 'https://github.com/facebook/react/pull/26339.diff', 'patch_url': 'https://github.com/facebook/react/pull/26339.patch', 'merged_at': datetime.datetime(2023, 3, 8, 16, 46, 10)} | **This commit only affects the internal version of `act` that we use in this repo. The public `act` API is unaffected, for now.**
We should always await the result of an `act` call so that any work queued in a microtask has a chance to flush. Neglecting to do this can cause us to miss bugs when testing React behavio... | {'url': 'https://api.github.com/repos/facebook/react/issues/26339/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26339/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26338 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26338/labels{/name} | https://api.github.com/repos/facebook/react/issues/26338/comments | https://api.github.com/repos/facebook/react/issues/26338/events | https://github.com/facebook/react/pull/26338 | 1,614,485,659 | PR_kwDOAJy2Ks5Lh82N | 26,338 | Codemod act -> await act (4/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 161f6ae42cf570d3daec355abcf3b006c58315da...df70e8892c4eb36dc5a9af01ac1fdc2679d83629\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-08 01:33:45 | 2023-03-08 16:36:06 | 2023-03-08 16:36:05 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26338', 'html_url': 'https://github.com/facebook/react/pull/26338', 'diff_url': 'https://github.com/facebook/react/pull/26338.diff', 'patch_url': 'https://github.com/facebook/react/pull/26338.patch', 'merged_at': datetime.datetime(2023, 3, 8, 16, 36, 5)} | Similar to the rationale for `waitFor` (see #26285), we should always await the result of an `act` call so that microtasks have a chance to fire.
This only affects the internal `act` that we use in our repo, for now. In the public `act` API, we don't yet require this; however, we effectively will for any update that... | {'url': 'https://api.github.com/repos/facebook/react/issues/26338/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26338/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26337 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26337/labels{/name} | https://api.github.com/repos/facebook/react/issues/26337/comments | https://api.github.com/repos/facebook/react/issues/26337/events | https://github.com/facebook/react/pull/26337 | 1,613,919,098 | PR_kwDOAJy2Ks5LgDRp | 26,337 | [DevTools] upgrade electron to latest version & security improvements | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 703c67560d1b5e5d32170cd513cda52559933527...b4fe0ad486597b00ae1b0c9e5ac3320b810e0875\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-07 17:40:17 | 2023-03-24 20:00:23 | 2023-03-08 03:31:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26337', 'html_url': 'https://github.com/facebook/react/pull/26337', 'diff_url': 'https://github.com/facebook/react/pull/26337.diff', 'patch_url': 'https://github.com/facebook/react/pull/26337.patch', 'merged_at': datetime.datetime(2023, 3, 8, 3, 31, 55)} | ## Summary
resolves #25667
This PR also resolves several security issues in the standalone app
## How did you test this change?
Tested locally `yarn start` in react-devtools package. Everything works normal
---
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://a... | {'url': 'https://api.github.com/repos/facebook/react/issues/26337/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26337/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26336 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26336/labels{/name} | https://api.github.com/repos/facebook/react/issues/26336/comments | https://api.github.com/repos/facebook/react/issues/26336/events | https://github.com/facebook/react/pull/26336 | 1,613,868,127 | PR_kwDOAJy2Ks5Lf4Hz | 26,336 | Codemod act -> await act (3/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 58605f798803081069971d9a0342ba08563248af...6fe44c23e321319d77c634eade68d60e59658477\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-07 17:09:05 | 2023-03-07 19:39:31 | 2023-03-07 19:39:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26336', 'html_url': 'https://github.com/facebook/react/pull/26336', 'diff_url': 'https://github.com/facebook/react/pull/26336.diff', 'patch_url': 'https://github.com/facebook/react/pull/26336.patch', 'merged_at': datetime.datetime(2023, 3, 7, 19, 39, 31)} | Similar to the rationale for `waitFor` (see #26285), we should always await the result of an `act` call so that microtasks have a chance to fire.
This only affects the internal `act` that we use in our repo, for now. In the public `act` API, we don't yet require this; however, we effectively will for any update that... | {'url': 'https://api.github.com/repos/facebook/react/issues/26336/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26336/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26335 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26335/labels{/name} | https://api.github.com/repos/facebook/react/issues/26335/comments | https://api.github.com/repos/facebook/react/issues/26335/events | https://github.com/facebook/react/pull/26335 | 1,613,723,483 | PR_kwDOAJy2Ks5LfYp0 | 26,335 | Codemod act -> await act (2/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 703c67560d1b5e5d32170cd513cda52559933527...372cf23a397ebe6378a3b1e2a33c7239f5eb3a17\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-07 15:47:21 | 2023-03-07 18:02:32 | 2023-03-07 17:07:30 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26335', 'html_url': 'https://github.com/facebook/react/pull/26335', 'diff_url': 'https://github.com/facebook/react/pull/26335.diff', 'patch_url': 'https://github.com/facebook/react/pull/26335.patch', 'merged_at': datetime.datetime(2023, 3, 7, 17, 7, 30)} | Similar to the rationale for `waitFor` (see #26285), we should always await the result of an `act` call so that microtasks have a chance to fire.
This only affects the internal `act` that we use in our repo, for now. In the public `act` API, we don't yet require this; however, we effectively will for any update that... | {'url': 'https://api.github.com/repos/facebook/react/issues/26335/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26335/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26334 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26334/labels{/name} | https://api.github.com/repos/facebook/react/issues/26334/comments | https://api.github.com/repos/facebook/react/issues/26334/events | https://github.com/facebook/react/pull/26334 | 1,612,745,923 | PR_kwDOAJy2Ks5LcEmz | 26,334 | Codemod act -> await act (1/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b380c24852b43856028167d5355926483f51d9fc...2205d4593376316034abf54f154732d0f6dee23d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-07 05:15:38 | 2023-03-07 15:21:37 | 2023-03-07 15:15:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26334', 'html_url': 'https://github.com/facebook/react/pull/26334', 'diff_url': 'https://github.com/facebook/react/pull/26334.diff', 'patch_url': 'https://github.com/facebook/react/pull/26334.patch', 'merged_at': datetime.datetime(2023, 3, 7, 15, 15, 35)} | Similar to the rationale for `waitFor` (see https://github.com/facebook/react/pull/26285), we should always await the result of an `act` call so that microtasks have a chance to fire.
This only affects the internal `act` that we use in our repo, for now. In the public `act` API, we don't yet require this; however, w... | {'url': 'https://api.github.com/repos/facebook/react/issues/26334/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26334/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26333 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26333/labels{/name} | https://api.github.com/repos/facebook/react/issues/26333/comments | https://api.github.com/repos/facebook/react/issues/26333/events | https://github.com/facebook/react/pull/26333 | 1,612,672,221 | PR_kwDOAJy2Ks5Lb1G4 | 26,333 | Convert class equivlance tests to flushSync | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 978fae4b4f6d5aa28887b530b5c9bf28b1e7b74b...254be599b446c96ff93c30cbfc8e183287b8f412\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-07 03:50:40 | 2023-03-07 15:14:42 | 2023-03-07 15:14:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26333', 'html_url': 'https://github.com/facebook/react/pull/26333', 'diff_url': 'https://github.com/facebook/react/pull/26333.diff', 'patch_url': 'https://github.com/facebook/react/pull/26333.patch', 'merged_at': datetime.datetime(2023, 3, 7, 15, 14, 42)} | There's an old collection of test suites that test class component behavior across ES6 (regular JavaScript classes), CoffeeScript classes, and TypeScript classes. They work by running the same tests in all environments and comparing the results.
Rather than use `act` or `waitFor` in these, I've changed them to use `... | {'url': 'https://api.github.com/repos/facebook/react/issues/26333/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26333/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26332 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26332/labels{/name} | https://api.github.com/repos/facebook/react/issues/26332/comments | https://api.github.com/repos/facebook/react/issues/26332/events | https://github.com/facebook/react/pull/26332 | 1,612,456,759 | PR_kwDOAJy2Ks5LbG2g | 26,332 | Tests for useInsertionEffect's behavior in strict mode. | {'login': 'egonSchiele', 'id': 97219, 'node_id': 'MDQ6VXNlcjk3MjE5', 'avatar_url': 'https://avatars.githubusercontent.com/u/97219?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/egonSchiele', 'html_url': 'https://github.com/egonSchiele', 'followers_url': 'https://api.github.com/users/egonSchiele/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3cad3a54eda7b2d1c670c2d414f33d78a4c3f6af...80535b015de86d5b964bd02e754b62a50f6dc070\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-07 00:20:05 | 2024-04-25 03:03:12 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26332', 'html_url': 'https://github.com/facebook/react/pull/26332', 'diff_url': 'https://github.com/facebook/react/pull/26332.diff', 'patch_url': 'https://github.com/facebook/react/pull/26332.patch', 'merged_at': None} | Tested/linted/prettier'd. The site gave me an error message when I tried to sign the CLA, but I may have already signed it.
## Summary
In strict mode, `useInsertionEffect` does not go through the mount-unmount-mount cycle the way `useEffect` and `useLayoutEffect` do, but I did not see any tests that cover this be... | {'url': 'https://api.github.com/repos/facebook/react/issues/26332/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26332/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26331 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26331/labels{/name} | https://api.github.com/repos/facebook/react/issues/26331/comments | https://api.github.com/repos/facebook/react/issues/26331/events | https://github.com/facebook/react/pull/26331 | 1,612,199,462 | PR_kwDOAJy2Ks5LaPdw | 26,331 | Use content hash for facebook-www builds | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ba353a50a65b9dc433b3fbcd2efaa8b95b9da460...e171514c8c8cef62b816a3b871120591633729e8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 21:01:34 | 2023-03-08 15:32:37 | 2023-03-06 22:13:17 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26331', 'html_url': 'https://github.com/facebook/react/pull/26331', 'diff_url': 'https://github.com/facebook/react/pull/26331.diff', 'patch_url': 'https://github.com/facebook/react/pull/26331.patch', 'merged_at': datetime.datetime(2023, 3, 6, 22, 13, 17)} | Currently, any commit to React causes an internal sync since the Git commit hash is part of the build. This creates a lot more sync commits and noise than necessary, see: https://github.com/facebook/react/commits/builds/facebook-www
This PR changes the version string to be a hash of the target build files instead. T... | {'url': 'https://api.github.com/repos/facebook/react/issues/26331/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26331/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26330 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26330/labels{/name} | https://api.github.com/repos/facebook/react/issues/26330/comments | https://api.github.com/repos/facebook/react/issues/26330/events | https://github.com/facebook/react/pull/26330 | 1,612,156,007 | PR_kwDOAJy2Ks5LaGBM | 26,330 | Codesandbox: upgrade to Node.js 18 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6e1756a5a9bb0d95ec17983f7dc38cd2c2663b39...1aac4d13492e95ffc43bfe92f868886708139de7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 20:29:07 | 2023-03-06 20:38:56 | 2023-03-06 20:38:04 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26330', 'html_url': 'https://github.com/facebook/react/pull/26330', 'diff_url': 'https://github.com/facebook/react/pull/26330.diff', 'patch_url': 'https://github.com/facebook/react/pull/26330.patch', 'merged_at': datetime.datetime(2023, 3, 6, 20, 38, 4)} | Turns out Codesandbox didn't support `String.prototype.replaceAll` in #26329.
This updates the config to use Node.js 18 for Codesandbox builds. | {'url': 'https://api.github.com/repos/facebook/react/issues/26330/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26330/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26329 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26329/labels{/name} | https://api.github.com/repos/facebook/react/issues/26329/comments | https://api.github.com/repos/facebook/react/issues/26329/events | https://github.com/facebook/react/pull/26329 | 1,612,133,308 | PR_kwDOAJy2Ks5LaBIi | 26,329 | Build: make version in build artifacts match | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6e1756a5a9bb0d95ec17983f7dc38cd2c2663b39...c0ae1628d52fa95661cc7ce132702264e9132892\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 20:13:25 | 2023-03-06 20:38:48 | 2023-03-06 20:38:43 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26329', 'html_url': 'https://github.com/facebook/react/pull/26329', 'diff_url': 'https://github.com/facebook/react/pull/26329.diff', 'patch_url': 'https://github.com/facebook/react/pull/26329.patch', 'merged_at': datetime.datetime(2023, 3, 6, 20, 38, 43)} | Some build artifacts contain multiple version strings. It seems like an oversight to me that this `.replace` call just replaces the one that happens to be first. | {'url': 'https://api.github.com/repos/facebook/react/issues/26329/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26329/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26328 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26328/labels{/name} | https://api.github.com/repos/facebook/react/issues/26328/comments | https://api.github.com/repos/facebook/react/issues/26328/events | https://github.com/facebook/react/pull/26328 | 1,611,835,304 | PR_kwDOAJy2Ks5LZA_q | 26,328 | Move suspended render logic to ensureRootIsScheduled | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1528c5ccdf5c61a08adab31116156df6503e26ce...bb38ccd1c954566ea4f0addb975480e7f832370a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 16:51:33 | 2023-03-06 17:27:50 | 2023-03-06 17:27:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26328', 'html_url': 'https://github.com/facebook/react/pull/26328', 'diff_url': 'https://github.com/facebook/react/pull/26328.diff', 'patch_url': 'https://github.com/facebook/react/pull/26328.patch', 'merged_at': datetime.datetime(2023, 3, 6, 17, 27, 49)} | When the work loop is suspended, we shouldn't schedule a new render task until the promise has resolved. When I originally implemented this, I wasn't sure where to put this logic — `ensureRootIsScheduled` is the more natural place for it, but that's also a really hot path, so I chose to do it elsewhere, and left a TODO... | {'url': 'https://api.github.com/repos/facebook/react/issues/26328/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26328/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26327 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26327/labels{/name} | https://api.github.com/repos/facebook/react/issues/26327/comments | https://api.github.com/repos/facebook/react/issues/26327/events | https://github.com/facebook/react/issues/26327 | 1,611,816,108 | I_kwDOAJy2Ks5gElys | 26,327 | Bug: The placeholder is shown on top of the input value. | {'login': 'lazybean', 'id': 529333, 'node_id': 'MDQ6VXNlcjUyOTMzMw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/529333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lazybean', 'html_url': 'https://github.com/lazybean', 'followers_url': 'https://api.github.com/users/lazybean/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I'm not sure this is a react bug or a chrome canary bug.\r\nBut because I cannot repro with simple html I decided to open issue here first.",
"\r\n\r\n\r\nimport \"./styles.css\";\r\nimport React, { useState } from \"react\";\r\nexport default function App() {\r\n const [value, setValue] = useState(\"\");\r\n ... | 2023-03-06 16:38:24 | 2024-04-17 06:04:08 | 2024-04-17 06:04:08 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.2.0 18.3.xxx
## Steps To Reproduce
1. On chrome canary, ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26327/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26327/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26326 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26326/labels{/name} | https://api.github.com/repos/facebook/react/issues/26326/comments | https://api.github.com/repos/facebook/react/issues/26326/events | https://github.com/facebook/react/pull/26326 | 1,611,642,481 | PR_kwDOAJy2Ks5LYWoL | 26,326 | Upgrade Flow to 0.201 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: eb616a12f10a58d5dc0b5898c0a1029aef62d485...ce48faa79e3539fb2548c9f12beb61a7d0a64830\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 15:15:31 | 2023-03-06 15:33:27 | 2023-03-06 15:33:23 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26326', 'html_url': 'https://github.com/facebook/react/pull/26326', 'diff_url': 'https://github.com/facebook/react/pull/26326.diff', 'patch_url': 'https://github.com/facebook/react/pull/26326.patch', 'merged_at': datetime.datetime(2023, 3, 6, 15, 33, 23)} | Small Flow upgrade to keep us current. | {'url': 'https://api.github.com/repos/facebook/react/issues/26326/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26326/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26325 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26325/labels{/name} | https://api.github.com/repos/facebook/react/issues/26325/comments | https://api.github.com/repos/facebook/react/issues/26325/events | https://github.com/facebook/react/pull/26325 | 1,611,569,825 | PR_kwDOAJy2Ks5LYGub | 26,325 | Update node version to v18.14.2 | {'login': 'joaodematte', 'id': 60761706, 'node_id': 'MDQ6VXNlcjYwNzYxNzA2', 'avatar_url': 'https://avatars.githubusercontent.com/u/60761706?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joaodematte', 'html_url': 'https://github.com/joaodematte', 'followers_url': 'https://api.github.com/users/joaodematte... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: eb616a12f10a58d5dc0b5898c0a1029aef62d485...9d0792ec4257dede394306da93c884d8a5afef08\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 14:36:59 | 2023-03-06 18:51:36 | 2023-03-06 18:51:36 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26325', 'html_url': 'https://github.com/facebook/react/pull/26325', 'diff_url': 'https://github.com/facebook/react/pull/26325.diff', 'patch_url': 'https://github.com/facebook/react/pull/26325.patch', 'merged_at': None} | There are some useful features provided by the newest node lts version.
[features](https://nodejs.org/de/blog/announcements/v18-release-announce/#v8-10-1) | {'url': 'https://api.github.com/repos/facebook/react/issues/26325/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26325/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26324 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26324/labels{/name} | https://api.github.com/repos/facebook/react/issues/26324/comments | https://api.github.com/repos/facebook/react/issues/26324/events | https://github.com/facebook/react/pull/26324 | 1,611,562,285 | PR_kwDOAJy2Ks5LYFAo | 26,324 | Update node version to v18.14.2 | {'login': 'joaodematte', 'id': 60761706, 'node_id': 'MDQ6VXNlcjYwNzYxNzA2', 'avatar_url': 'https://avatars.githubusercontent.com/u/60761706?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joaodematte', 'html_url': 'https://github.com/joaodematte', 'followers_url': 'https://api.github.com/users/joaodematte... | [] | closed | false | null | [] | null | [
"Hi @joaodematte! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order f... | 2023-03-06 14:34:20 | 2023-03-06 14:39:15 | 2023-03-06 14:36:05 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26324', 'html_url': 'https://github.com/facebook/react/pull/26324', 'diff_url': 'https://github.com/facebook/react/pull/26324.diff', 'patch_url': 'https://github.com/facebook/react/pull/26324.patch', 'merged_at': None} | There are some useful features provided by the newest node lts version.
[features](https://nodejs.org/de/blog/announcements/v18-release-announce/#v8-10-1) | {'url': 'https://api.github.com/repos/facebook/react/issues/26324/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26324/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26323 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26323/labels{/name} | https://api.github.com/repos/facebook/react/issues/26323/comments | https://api.github.com/repos/facebook/react/issues/26323/events | https://github.com/facebook/react/pull/26323 | 1,611,207,552 | PR_kwDOAJy2Ks5LW4SZ | 26,323 | Refactor ReactFabricHostComponent | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: eb616a12f10a58d5dc0b5898c0a1029aef62d485...3b0f0064fd385933d783922ec8cdf2eb1c1834a6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 11:28:20 | 2023-03-07 14:34:06 | 2023-03-07 14:33:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26323', 'html_url': 'https://github.com/facebook/react/pull/26323', 'diff_url': 'https://github.com/facebook/react/pull/26323.diff', 'patch_url': 'https://github.com/facebook/react/pull/26323.patch', 'merged_at': datetime.datetime(2023, 3, 7, 14, 33, 56)} | ## Summary
This is a small refactor of `ReactFabricHostComponent` to remove unnecessary dependencies, unused methods and type definitions to simplify a larger refactor of the class in a following PR (https://github.com/facebook/react/pull/26321).
## How did you test this change?
Existing unit tests. | {'url': 'https://api.github.com/repos/facebook/react/issues/26323/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26323/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26322 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26322/labels{/name} | https://api.github.com/repos/facebook/react/issues/26322/comments | https://api.github.com/repos/facebook/react/issues/26322/events | https://github.com/facebook/react/pull/26322 | 1,611,204,853 | PR_kwDOAJy2Ks5LW3tB | 26,322 | Remove obsolete `name` property from client reference in Flight Node Register | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: eb616a12f10a58d5dc0b5898c0a1029aef62d485...96b9eefc6b2e59f382aa81917fc6936ab6dd74e2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 11:26:21 | 2023-03-06 17:10:37 | 2023-03-06 17:03:04 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26322', 'html_url': 'https://github.com/facebook/react/pull/26322', 'diff_url': 'https://github.com/facebook/react/pull/26322.diff', 'patch_url': 'https://github.com/facebook/react/pull/26322.patch', 'merged_at': None} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. F... | {'url': 'https://api.github.com/repos/facebook/react/issues/26322/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26322/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26321 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26321/labels{/name} | https://api.github.com/repos/facebook/react/issues/26321/comments | https://api.github.com/repos/facebook/react/issues/26321/events | https://github.com/facebook/react/pull/26321 | 1,611,161,112 | PR_kwDOAJy2Ks5LWuCU | 26,321 | Extracted definition and access to public instances to a separate module in Fabric | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d1ad984db1591b131d16739a24dee4ba44886a09...a51ca5f4e13fd9a55c9cd089f8042b378b3d9613\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 11:04:02 | 2023-03-16 16:09:24 | 2023-03-13 13:25:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26321', 'html_url': 'https://github.com/facebook/react/pull/26321', 'diff_url': 'https://github.com/facebook/react/pull/26321.diff', 'patch_url': 'https://github.com/facebook/react/pull/26321.patch', 'merged_at': datetime.datetime(2023, 3, 13, 13, 25, 43)} | ## Summary
The current definition of `Instance` in Fabric has 2 fields:
- `node`: reference to the native node in the shadow tree.
- `canonical`: public instance provided to users via refs + some internal fields needed by Fabric.
We're currently using `canonical` not only as the public instance, but also to sto... | {'url': 'https://api.github.com/repos/facebook/react/issues/26321/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26321/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26320 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26320/labels{/name} | https://api.github.com/repos/facebook/react/issues/26320/comments | https://api.github.com/repos/facebook/react/issues/26320/events | https://github.com/facebook/react/issues/26320 | 1,611,147,737 | I_kwDOAJy2Ks5gCCnZ | 26,320 | Bug: `useInsertionEffect()` doesn't fire before `useLayoutEffect()` | {'login': 'catamphetamine', 'id': 477167, 'node_id': 'MDQ6VXNlcjQ3NzE2Nw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/477167?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/catamphetamine', 'html_url': 'https://github.com/catamphetamine', 'followers_url': 'https://api.github.com/users/catamp... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"Hi @catamphetamine ,\r\nYou're using strict mode, and `useInsertionEffect` does not mount twice the way `useLayoutEffect` and `useEffect` do. ",
"@egonSchiele \r\n\r\n> You're using strict mode, and `useInsertionEffect` does not mount twice the way `useLayoutEffect` and `useEffect` do.\r\n\r\nThanks, but why doe... | 2023-03-06 10:57:05 | 2024-04-10 20:55:23 | null | CONTRIBUTOR | null | null | null | React version: `18.2`
Next.js version: `13.2.3`
## Steps To Reproduce
1. Go to the demo page (link below). It's a simple Next.js application (it [wasn't](https://gitlab.com/catamphetamine/virtual-scroller/-/issues/33) created by me, I just forked it). The code is:
```js
import { useInsertionEffect, useLayout... | {'url': 'https://api.github.com/repos/facebook/react/issues/26320/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26320/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/26319 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26319/labels{/name} | https://api.github.com/repos/facebook/react/issues/26319/comments | https://api.github.com/repos/facebook/react/issues/26319/events | https://github.com/facebook/react/pull/26319 | 1,611,123,329 | PR_kwDOAJy2Ks5LWl47 | 26,319 | Extract duplicated methods in Fabric and the legacy renderer to a shared module | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 49f7410467950de57bd1d9509e67de91185f7bad...5905887267c42c11b7d131a39da26e9b14d5fb6b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-06 10:39:58 | 2023-03-06 10:59:14 | 2023-03-06 10:51:59 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26319', 'html_url': 'https://github.com/facebook/react/pull/26319', 'diff_url': 'https://github.com/facebook/react/pull/26319.diff', 'patch_url': 'https://github.com/facebook/react/pull/26319.patch', 'merged_at': datetime.datetime(2023, 3, 6, 10, 51, 59)} | ## Summary
The following methods have exactly the same implementation on Fabric and the legacy renderer:
* `findHostInstance_DEPRECATED`
* `findNodeHandle`
* `dispatchCommand`
* `sendAccessibilityEvent`
This just extracts those functions to a common module so they're easier to change (no need to sync changes ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26319/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26319/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26318 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26318/labels{/name} | https://api.github.com/repos/facebook/react/issues/26318/comments | https://api.github.com/repos/facebook/react/issues/26318/events | https://github.com/facebook/react/issues/26318 | 1,610,511,356 | I_kwDOAJy2Ks5f_nP8 | 26,318 | Bug: Error due to `serverSnapshot` and `snapshot` mismatch in `useSyncExternalStore` when used with `Suspense` SSR | {'login': 'mgiedrius', 'id': 17888786, 'node_id': 'MDQ6VXNlcjE3ODg4Nzg2', 'avatar_url': 'https://avatars.githubusercontent.com/u/17888786?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mgiedrius', 'html_url': 'https://github.com/mgiedrius', 'followers_url': 'https://api.github.com/users/mgiedrius/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I'm not seeing any error when opening https://codesandbox.io/s/usesyncexternalstore-suspense-bug-lyoc03?file=/src/App.js:217-241.\r\n\r\nDid you maybe change the codesandbox in the meantime?",
"@eps1lon Hi, I haven't updated the code in Codesandbox. I'm not entirely sure why the error message isn't showing up in... | 2023-03-06 01:59:25 | 2023-03-12 16:35:07 | 2023-03-09 16:34:49 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.2.0
## Steps To Reproduce
1. Use `Suspense` SSR and `use... | {'url': 'https://api.github.com/repos/facebook/react/issues/26318/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26318/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26317 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26317/labels{/name} | https://api.github.com/repos/facebook/react/issues/26317/comments | https://api.github.com/repos/facebook/react/issues/26317/events | https://github.com/facebook/react/pull/26317 | 1,610,427,462 | PR_kwDOAJy2Ks5LUPeh | 26,317 | Fix: Infinite act loop caused by wrong shouldYield | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 106ea1c584d811eda5d328a5f7f856a738c2ca24...fb31042edb60ff0b297eab5a1628ae25e419ff21\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-05 23:40:12 | 2023-03-06 01:24:40 | 2023-03-06 01:24:40 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26317', 'html_url': 'https://github.com/facebook/react/pull/26317', 'diff_url': 'https://github.com/facebook/react/pull/26317.diff', 'patch_url': 'https://github.com/facebook/react/pull/26317.patch', 'merged_at': datetime.datetime(2023, 3, 6, 1, 24, 40)} | Based on a bug report from @bvaughn.
`act` should not consult `shouldYield` when it's performing work, because in a unit testing environment, I/O (such as `setTimeout`) is likely mocked. So the result of `shouldYield` can't be trusted.
In the regression test, I simulate the bug by mocking `shouldYield` to always ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26317/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26317/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26316 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26316/labels{/name} | https://api.github.com/repos/facebook/react/issues/26316/comments | https://api.github.com/repos/facebook/react/issues/26316/events | https://github.com/facebook/react/issues/26316 | 1,610,392,920 | I_kwDOAJy2Ks5f_KVY | 26,316 | Bug: Tests hang when using async act() with "next" and "experimental" release channels | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Out of curiosity, I updated to the \"experimental\" channel and replaced the `throw` mechanism with `use(promise)` – and the async act test still hangs.",
"Fixed via #26317"
] | 2023-03-05 22:28:30 | 2023-03-06 01:29:57 | 2023-03-06 01:29:57 | CONTRIBUTOR | null | null | null | Repro case here:
https://github.com/bvaughn/react-createRoot-Suspense-async-act
```
npm install
npm run test
```
This is stripped down to the point of being a pretty silly test case. I was trying to report a more complicated bug, related to a Suspense cache invalidation, but noticed that I'm having difficulty... | {'url': 'https://api.github.com/repos/facebook/react/issues/26316/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26316/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26315 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26315/labels{/name} | https://api.github.com/repos/facebook/react/issues/26315/comments | https://api.github.com/repos/facebook/react/issues/26315/events | https://github.com/facebook/react/issues/26315 | 1,610,373,646 | I_kwDOAJy2Ks5f_FoO | 26,315 | Bug: useRef cleanup in StrictMode refers to second ref twice | {'login': 'MaciejNiklasinski', 'id': 42110479, 'node_id': 'MDQ6VXNlcjQyMTEwNDc5', 'avatar_url': 'https://avatars.githubusercontent.com/u/42110479?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MaciejNiklasinski', 'html_url': 'https://github.com/MaciejNiklasinski', 'followers_url': 'https://api.github.com... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"@MaciejNiklasinski I think you could add these block inside the `useEffect` function and it will work as you expect:\r\n```\r\n if (ref.current === null) {\r\n const id = map.size; //Symbol();\r\n const handle = { id };\r\n console.log(`Adding Symbol ${id} to map`);\r\n map.set(id, handle);\r\n ref... | 2023-03-05 21:32:42 | 2024-01-30 22:55:46 | 2024-01-12 17:57:51 | NONE | null | null | null | I'm trying to create a handle object, add it to the map and use it as ref. All that should happen on component first render when ref.current === null which according to what I read here is the only exception when directly writing to ref from render function is allowed: https://beta.reactjs.org/reference/react/useRef#av... | {'url': 'https://api.github.com/repos/facebook/react/issues/26315/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26315/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26314 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26314/labels{/name} | https://api.github.com/repos/facebook/react/issues/26314/comments | https://api.github.com/repos/facebook/react/issues/26314/events | https://github.com/facebook/react/issues/26314 | 1,610,150,249 | I_kwDOAJy2Ks5f-PFp | 26,314 | Bug: React Usecallback holding the pervious ref on memory | {'login': 'programmerraja', 'id': 44333589, 'node_id': 'MDQ6VXNlcjQ0MzMzNTg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/44333589?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/programmerraja', 'html_url': 'https://github.com/programmerraja', 'followers_url': 'https://api.github.com/users/pr... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-05 10:51:35 | 2023-03-05 11:24:23 | 2023-03-05 11:24:23 | NONE | null | null | null | React useCallback holds the old value in memory which causes a memory leak
React version: 18.2.0
## Steps To Reproduce
1. This code will create 1000000 arrays of object
2. After running the code the first time and checking the memory size it is about 23.1MB
3. Next click the clean button and click the gar... | {'url': 'https://api.github.com/repos/facebook/react/issues/26314/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26314/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26313 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26313/labels{/name} | https://api.github.com/repos/facebook/react/issues/26313/comments | https://api.github.com/repos/facebook/react/issues/26313/events | https://github.com/facebook/react/pull/26313 | 1,610,072,293 | PR_kwDOAJy2Ks5LTIy3 | 26,313 | Support Iterables in Flight | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"My favorite example of this is ReadableStream which is also an AsyncIterable. So we'll also support AsyncIterable as a ReadableStream.",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f905da22762369975be71da5c13ff96796773039...12e2aee88b950... | 2023-03-05 06:11:36 | 2023-03-09 13:55:01 | 2023-03-05 18:18:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26313', 'html_url': 'https://github.com/facebook/react/pull/26313', 'diff_url': 'https://github.com/facebook/react/pull/26313.diff', 'patch_url': 'https://github.com/facebook/react/pull/26313.patch', 'merged_at': datetime.datetime(2023, 3, 5, 18, 18, 54)} | We support any super type of anything that we can serialize. Meaning that as long as the Type that's passed through is less precise, it means that we can encoded it as any subtype and therefore the incoming type doesn't have to be the subtype in that case. Basically, as long as you're only passing through an `Iterable<... | {'url': 'https://api.github.com/repos/facebook/react/issues/26313/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26313/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26312 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26312/labels{/name} | https://api.github.com/repos/facebook/react/issues/26312/comments | https://api.github.com/repos/facebook/react/issues/26312/events | https://github.com/facebook/react/pull/26312 | 1,609,990,144 | PR_kwDOAJy2Ks5LS5Tx | 26,312 | SchedulerMock.unstable_yieldValue -> SchedulerMock.log | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 25685d8a90dd83d30cee6bd365bcb0115f1a2ff1...e9b68327a75ddd1e7960f32c815779fe2fc2ebd8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 23:48:20 | 2023-03-06 16:09:08 | 2023-03-06 16:09:08 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26312', 'html_url': 'https://github.com/facebook/react/pull/26312', 'diff_url': 'https://github.com/facebook/react/pull/26312.diff', 'patch_url': 'https://github.com/facebook/react/pull/26312.patch', 'merged_at': datetime.datetime(2023, 3, 6, 16, 9, 8)} | (This only affects our own internal repo; it's not a public API.)
I think most of us agree this is a less confusing name. It's possible someone will confuse it with `console.log`. If that becomes a problem we can warn in dev or something. | {'url': 'https://api.github.com/repos/facebook/react/issues/26312/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26312/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26311 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26311/labels{/name} | https://api.github.com/repos/facebook/react/issues/26311/comments | https://api.github.com/repos/facebook/react/issues/26311/events | https://github.com/facebook/react/pull/26311 | 1,609,980,160 | PR_kwDOAJy2Ks5LS3aO | 26,311 | Delete toFlushAndYield test helpers | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 25685d8a90dd83d30cee6bd365bcb0115f1a2ff1...0cba581611bf587610624f23cde0e00cd4cc9cb7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 23:07:40 | 2023-03-06 16:11:34 | 2023-03-06 16:11:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26311', 'html_url': 'https://github.com/facebook/react/pull/26311', 'diff_url': 'https://github.com/facebook/react/pull/26311.diff', 'patch_url': 'https://github.com/facebook/react/pull/26311.patch', 'merged_at': None} | Now that the tests have been codemodded, we can delete toFlushAndYield et al from the codebase. See #26285 for full context.
The mock implementation of Scheduler still exposes some (unstable- prefixed) APIs that can be used for some edge cases, like when testing the mock Scheduler itself. There are only a few tests ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26311/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26311/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26310 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26310/labels{/name} | https://api.github.com/repos/facebook/react/issues/26310/comments | https://api.github.com/repos/facebook/react/issues/26310/events | https://github.com/facebook/react/issues/26310 | 1,609,966,028 | I_kwDOAJy2Ks5f9iHM | 26,310 | Bug: Facebook | {'login': 'Nidiaisabel', 'id': 126986863, 'node_id': 'U_kgDOB5Gqbw', 'avatar_url': 'https://avatars.githubusercontent.com/u/126986863?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Nidiaisabel', 'html_url': 'https://github.com/Nidiaisabel', 'followers_url': 'https://api.github.com/users/Nidiaisabel/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-04 22:09:04 | 2023-03-16 17:26:32 | 2023-03-16 17:26:32 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much fast... | {'url': 'https://api.github.com/repos/facebook/react/issues/26310/reactions', 'total_count': 8, '+1': 0, '-1': 8, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26310/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26309 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26309/labels{/name} | https://api.github.com/repos/facebook/react/issues/26309/comments | https://api.github.com/repos/facebook/react/issues/26309/events | https://github.com/facebook/react/pull/26309 | 1,609,932,810 | PR_kwDOAJy2Ks5LSunt | 26,309 | Codemod tests to waitFor pattern (9/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 64dde70827117fbe15df2a05c618d01d81fcbbf6...d63da768a8a983a1cdc1326907d0f89efa046ac1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 20:22:47 | 2023-03-04 23:12:11 | 2023-03-04 23:06:21 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26309', 'html_url': 'https://github.com/facebook/react/pull/26309', 'diff_url': 'https://github.com/facebook/react/pull/26309.diff', 'patch_url': 'https://github.com/facebook/react/pull/26309.patch', 'merged_at': datetime.datetime(2023, 3, 4, 23, 6, 21)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26309/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26309/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26308 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26308/labels{/name} | https://api.github.com/repos/facebook/react/issues/26308/comments | https://api.github.com/repos/facebook/react/issues/26308/events | https://github.com/facebook/react/pull/26308 | 1,609,919,649 | PR_kwDOAJy2Ks5LSsMj | 26,308 | Codemod tests to waitFor pattern (8/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 3cb5afb82efd56d8af09a942a17ddde5e63d2e80...1d949ac2b14afe98ac12e756d86abebbb857e02c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 19:37:50 | 2023-03-04 23:10:04 | 2023-03-04 23:04:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26308', 'html_url': 'https://github.com/facebook/react/pull/26308', 'diff_url': 'https://github.com/facebook/react/pull/26308.diff', 'patch_url': 'https://github.com/facebook/react/pull/26308.patch', 'merged_at': datetime.datetime(2023, 3, 4, 23, 4, 44)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26308/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26308/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26307 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26307/labels{/name} | https://api.github.com/repos/facebook/react/issues/26307/comments | https://api.github.com/repos/facebook/react/issues/26307/events | https://github.com/facebook/react/pull/26307 | 1,609,910,302 | PR_kwDOAJy2Ks5LSqfv | 26,307 | Codemod tests to waitFor pattern (7/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e98695db918721a08eae0a2dceeb5719c1aa7261...6d1d1c4c4e5ffd50899ccd8f621bd59ccfe32f3a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 19:06:05 | 2023-03-04 23:03:25 | 2023-03-04 23:03:25 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26307', 'html_url': 'https://github.com/facebook/react/pull/26307', 'diff_url': 'https://github.com/facebook/react/pull/26307.diff', 'patch_url': 'https://github.com/facebook/react/pull/26307.patch', 'merged_at': datetime.datetime(2023, 3, 4, 23, 3, 25)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26307/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26307/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26306 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26306/labels{/name} | https://api.github.com/repos/facebook/react/issues/26306/comments | https://api.github.com/repos/facebook/react/issues/26306/events | https://github.com/facebook/react/issues/26306 | 1,609,904,969 | I_kwDOAJy2Ks5f9TNJ | 26,306 | Supporting `Date` objects in `value` for `type=date` input tags | {'login': 'naveen521kk', 'id': 49693820, 'node_id': 'MDQ6VXNlcjQ5NjkzODIw', 'avatar_url': 'https://avatars.githubusercontent.com/u/49693820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/naveen521kk', 'html_url': 'https://github.com/naveen521kk', 'followers_url': 'https://api.github.com/users/naveen521kk... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"The HTML spec says the value has to be a string (see [here](https://html.spec.whatwg.org/multipage/input.html#date-state-(type=date))), and it looks like React strongly wants all values to be strings to comply with this spec.\r\n\r\n[There's a check to make sure the value attribute is a string](https://github.com/... | 2023-03-04 18:50:26 | 2024-04-17 06:04:10 | 2024-04-17 06:04:09 | NONE | null | null | null | Currently, when passing `Date` objects as the `value` parameter, the `Date` object is implicitly converted into a string and the browser can't understand the format. This doesn't set the value in the date picker because of that. See https://codesandbox.io/s/objective-turing-zk9bc1?file=/src/App.js
According to [MDN]... | {'url': 'https://api.github.com/repos/facebook/react/issues/26306/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26306/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26305 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26305/labels{/name} | https://api.github.com/repos/facebook/react/issues/26305/comments | https://api.github.com/repos/facebook/react/issues/26305/events | https://github.com/facebook/react/pull/26305 | 1,609,618,494 | PR_kwDOAJy2Ks5LRx8U | 26,305 | Codemod tests to waitFor pattern (6/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9a52cc8bcd580238f4a8b12036e698823847fd65...28345c31c406ee3661d61960e907766e8573dbf0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 05:32:03 | 2023-03-04 16:52:15 | 2023-03-04 16:45:27 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26305', 'html_url': 'https://github.com/facebook/react/pull/26305', 'diff_url': 'https://github.com/facebook/react/pull/26305.diff', 'patch_url': 'https://github.com/facebook/react/pull/26305.patch', 'merged_at': datetime.datetime(2023, 3, 4, 16, 45, 27)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26305/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26305/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26304 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26304/labels{/name} | https://api.github.com/repos/facebook/react/issues/26304/comments | https://api.github.com/repos/facebook/react/issues/26304/events | https://github.com/facebook/react/pull/26304 | 1,609,597,651 | PR_kwDOAJy2Ks5LRtjN | 26,304 | Convert ReactLazy-test to waitFor pattern | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: faacefb4d0167f8d5973672754fe87afc607397b...cfc88ef35655bf21f7612c55e42d736233d3ab88\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-04 04:30:23 | 2023-03-04 16:44:42 | 2023-03-04 16:44:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26304', 'html_url': 'https://github.com/facebook/react/pull/26304', 'diff_url': 'https://github.com/facebook/react/pull/26304.diff', 'patch_url': 'https://github.com/facebook/react/pull/26304.patch', 'merged_at': datetime.datetime(2023, 3, 4, 16, 44, 42)} | I'm in the process of codemodding our test suite to the waitFor pattern. See #26285 for full context.
This module required a lot of manual changes so I'm doing it as its own PR. The reason is that most of the tests involved simulating an async import by wrapping them in `Promise.resolve()`, which means they would im... | {'url': 'https://api.github.com/repos/facebook/react/issues/26304/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26304/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26303 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26303/labels{/name} | https://api.github.com/repos/facebook/react/issues/26303/comments | https://api.github.com/repos/facebook/react/issues/26303/events | https://github.com/facebook/react/pull/26303 | 1,609,428,408 | PR_kwDOAJy2Ks5LRISI | 26,303 | [Fizz] External runtime: fix bug in processing existing elements | {'login': 'mofeiZ', 'id': 34200447, 'node_id': 'MDQ6VXNlcjM0MjAwNDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/34200447?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mofeiZ', 'html_url': 'https://github.com/mofeiZ', 'followers_url': 'https://api.github.com/users/mofeiZ/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e64a8f4035024ce749bcbcf93b2618e66200a7f7...1e5e9afed48c98268bb5f8d6e764d1b7fa6088a1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 23:43:55 | 2023-03-04 16:27:00 | 2023-03-04 16:26:59 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26303', 'html_url': 'https://github.com/facebook/react/pull/26303', 'diff_url': 'https://github.com/facebook/react/pull/26303.diff', 'patch_url': 'https://github.com/facebook/react/pull/26303.patch', 'merged_at': datetime.datetime(2023, 3, 4, 16, 26, 59)} | ## Summary
Fix bug in how the Fizz external runtime processes existing template elements.
Bug:
- getElementsByTagName returns a HTMLCollection, which is live.
- while iterating over an HTMLCollection, we call handleNode which removes nodes
Fix:
- Call Array.from to copy children of `document.body` before proc... | {'url': 'https://api.github.com/repos/facebook/react/issues/26303/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26303/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26302 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26302/labels{/name} | https://api.github.com/repos/facebook/react/issues/26302/comments | https://api.github.com/repos/facebook/react/issues/26302/events | https://github.com/facebook/react/pull/26302 | 1,609,428,276 | PR_kwDOAJy2Ks5LRIQW | 26,302 | Codemod tests to waitFor pattern (4/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 06460b6fb51e99cfab840424a9514651488b2e99...553c5fa804bb79cdc534722dd31e13e3ea6f3fc3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 23:43:44 | 2023-03-04 02:24:23 | 2023-03-04 02:24:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26302', 'html_url': 'https://github.com/facebook/react/pull/26302', 'diff_url': 'https://github.com/facebook/react/pull/26302.diff', 'patch_url': 'https://github.com/facebook/react/pull/26302.patch', 'merged_at': datetime.datetime(2023, 3, 4, 2, 24, 23)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26302/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26302/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26301 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26301/labels{/name} | https://api.github.com/repos/facebook/react/issues/26301/comments | https://api.github.com/repos/facebook/react/issues/26301/events | https://github.com/facebook/react/pull/26301 | 1,609,341,065 | PR_kwDOAJy2Ks5LQ0g7 | 26,301 | Fix: onContextMenu listener is invoked on disabled buttons in Chrome | {'login': 'osule', 'id': 13223818, 'node_id': 'MDQ6VXNlcjEzMjIzODE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/13223818?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/osule', 'html_url': 'https://github.com/osule', 'followers_url': 'https://api.github.com/users/osule/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @osule! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us ... | 2023-03-03 22:36:35 | 2024-04-17 06:04:11 | 2024-04-17 06:04:11 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26301', 'html_url': 'https://github.com/facebook/react/pull/26301', 'diff_url': 'https://github.com/facebook/react/pull/26301.diff', 'patch_url': 'https://github.com/facebook/react/pull/26301.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26301/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26301/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26300 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26300/labels{/name} | https://api.github.com/repos/facebook/react/issues/26300/comments | https://api.github.com/repos/facebook/react/issues/26300/events | https://github.com/facebook/react/pull/26300 | 1,609,271,148 | PR_kwDOAJy2Ks5LQlm2 | 26,300 | Simplify Webpack References by encoding file path + export name as single id | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5c633a48f9bdc212e27ae026c74148b42cc47efb...7936faa8c9da213912f7e8d7f8b09b0e0ac4dab7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 21:27:45 | 2023-03-06 16:24:32 | 2023-03-05 00:51:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26300', 'html_url': 'https://github.com/facebook/react/pull/26300', 'diff_url': 'https://github.com/facebook/react/pull/26300.diff', 'patch_url': 'https://github.com/facebook/react/pull/26300.patch', 'merged_at': datetime.datetime(2023, 3, 5, 0, 51, 35)} | We always look up these references in a map so it doesn't matter what their value is. It could be a hash for example.
The loaders now encode a single $$id instead of filepath + name.
This changes the react-client-manifest to have a single level. The value inside the map is still split into module id + export name... | {'url': 'https://api.github.com/repos/facebook/react/issues/26300/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26300/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26299 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26299/labels{/name} | https://api.github.com/repos/facebook/react/issues/26299/comments | https://api.github.com/repos/facebook/react/issues/26299/events | https://github.com/facebook/react/pull/26299 | 1,609,264,765 | PR_kwDOAJy2Ks5LQkR4 | 26,299 | Codemod tests to waitFor pattern (3/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5c633a48f9bdc212e27ae026c74148b42cc47efb...e6aa4d2c9ba363853bf56dad9aa628b7572a546a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 21:20:51 | 2023-03-03 22:02:13 | 2023-03-03 22:02:13 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26299', 'html_url': 'https://github.com/facebook/react/pull/26299', 'diff_url': 'https://github.com/facebook/react/pull/26299.diff', 'patch_url': 'https://github.com/facebook/react/pull/26299.patch', 'merged_at': datetime.datetime(2023, 3, 3, 22, 2, 13)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26299/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26299/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26298 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26298/labels{/name} | https://api.github.com/repos/facebook/react/issues/26298/comments | https://api.github.com/repos/facebook/react/issues/26298/events | https://github.com/facebook/react/issues/26298 | 1,609,245,548 | I_kwDOAJy2Ks5f6yNs | 26,298 | Bug: onContextMenu listener is invoked on disabled buttons in Chrome | {'login': 'osule', 'id': 13223818, 'node_id': 'MDQ6VXNlcjEzMjIzODE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/13223818?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/osule', 'html_url': 'https://github.com/osule', 'followers_url': 'https://api.github.com/users/osule/followers', 'following_... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"Works for me; could you post a fiddle link?",
"I can confirm the `onContextMenu` gets triggered on right click when button is `disabled`. \r\nMaybe its something related to these lines of code:\r\nhttps://github.com/facebook/react/blob/8e2bde6f2751aa6335f3cef488c05c3ea08e074a/packages/react-dom-bindings/src/even... | 2023-03-03 21:02:42 | 2024-04-17 06:04:12 | 2024-04-17 06:04:12 | NONE | null | null | null | ## Steps To Reproduce
1. In CRA, declare the App component:
```jsx
import React from 'react';
export default function App() {
return (
<button
type="button"
onContextMenu={() => {console.log(123);}}
disabled
>
Click me
</button>
);
}
```
2. Run the dev... | {'url': 'https://api.github.com/repos/facebook/react/issues/26298/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26298/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26297 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26297/labels{/name} | https://api.github.com/repos/facebook/react/issues/26297/comments | https://api.github.com/repos/facebook/react/issues/26297/events | https://github.com/facebook/react/pull/26297 | 1,609,214,089 | PR_kwDOAJy2Ks5LQZrY | 26,297 | grammatical_mistakes | {'login': 'arin-02', 'id': 90857324, 'node_id': 'MDQ6VXNlcjkwODU3MzI0', 'avatar_url': 'https://avatars.githubusercontent.com/u/90857324?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/arin-02', 'html_url': 'https://github.com/arin-02', 'followers_url': 'https://api.github.com/users/arin-02/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5c633a48f9bdc212e27ae026c74148b42cc47efb...b5fdd281c88b5d8269f221c6e3eeb2d38bb740f4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 20:35:04 | 2023-03-13 17:20:06 | 2023-03-13 17:20:05 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26297', 'html_url': 'https://github.com/facebook/react/pull/26297', 'diff_url': 'https://github.com/facebook/react/pull/26297.diff', 'patch_url': 'https://github.com/facebook/react/pull/26297.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26297/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26297/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26296 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26296/labels{/name} | https://api.github.com/repos/facebook/react/issues/26296/comments | https://api.github.com/repos/facebook/react/issues/26296/events | https://github.com/facebook/react/pull/26296 | 1,609,187,704 | PR_kwDOAJy2Ks5LQT_M | 26,296 | Codemod tests to waitFor pattern (2/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5c633a48f9bdc212e27ae026c74148b42cc47efb...62c01b81eeaad56c915120b53f5760aa6f43cd42\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 20:09:54 | 2023-03-03 22:01:57 | 2023-03-03 22:01:57 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26296', 'html_url': 'https://github.com/facebook/react/pull/26296', 'diff_url': 'https://github.com/facebook/react/pull/26296.diff', 'patch_url': 'https://github.com/facebook/react/pull/26296.patch', 'merged_at': datetime.datetime(2023, 3, 3, 22, 1, 57)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26296/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26296/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26295 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26295/labels{/name} | https://api.github.com/repos/facebook/react/issues/26295/comments | https://api.github.com/repos/facebook/react/issues/26295/events | https://github.com/facebook/react/issues/26295 | 1,609,119,929 | I_kwDOAJy2Ks5f6Ti5 | 26,295 | Bug: Error occurs when returning empty fragment '<></>' on a page | {'login': 'Willienn', 'id': 101187684, 'node_id': 'U_kgDOBggAZA', 'avatar_url': 'https://avatars.githubusercontent.com/u/101187684?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Willienn', 'html_url': 'https://github.com/Willienn', 'followers_url': 'https://api.github.com/users/Willienn/followers', 'foll... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710332294, 'node_id': 'MDU6TGFiZWw3MTAzMzIyOTQ=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"We have this tracked internally. But thanks for flagging. Same applies to returning undefined directly.",
"you don't have to import the fragments , just write in below the return <> hey it will sove this </> just do it ",
"Is it fix?\r\n",
"Fixed in https://github.com/facebook/react/pull/26349"
] | 2023-03-03 19:05:34 | 2023-04-16 09:49:55 | 2023-04-16 09:49:52 | NONE | null | null | null | In was working when i comment a code and see this error
Then i start to test possible ways of reproduce the bug
Notes:
1.using <>{null}</> dont give the error
2.using <>{undefined}</> give the error
React version: 18.2.0
## Steps To Reproduce
1.import { Fragment } from "react";
export default async fun... | {'url': 'https://api.github.com/repos/facebook/react/issues/26295/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26295/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26294 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26294/labels{/name} | https://api.github.com/repos/facebook/react/issues/26294/comments | https://api.github.com/repos/facebook/react/issues/26294/events | https://github.com/facebook/react/pull/26294 | 1,609,114,734 | PR_kwDOAJy2Ks5LQEgs | 26,294 | Add back accidentally deleted test comments | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b72ed698fb5f15e0c33c5017422b8428b01ff12a...bd7ac8b2ce6e4dd44b7fc53279ac3f16ec8735b4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 19:00:56 | 2023-03-03 19:34:42 | 2023-03-03 19:34:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26294', 'html_url': 'https://github.com/facebook/react/pull/26294', 'diff_url': 'https://github.com/facebook/react/pull/26294.diff', 'patch_url': 'https://github.com/facebook/react/pull/26294.patch', 'merged_at': datetime.datetime(2023, 3, 3, 19, 34, 41)} | The codemod I used in #26288 accidentally caused some comments to be deleted. Because not all affected lines included comments, I didn't notice until after landing.
This adds the comments back. | {'url': 'https://api.github.com/repos/facebook/react/issues/26294/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26294/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26293 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26293/labels{/name} | https://api.github.com/repos/facebook/react/issues/26293/comments | https://api.github.com/repos/facebook/react/issues/26293/events | https://github.com/facebook/react/pull/26293 | 1,609,008,480 | PR_kwDOAJy2Ks5LPuEY | 26,293 | [Flight] Send server reference error chunks to the client | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b72ed698fb5f15e0c33c5017422b8428b01ff12a...0a7c2bbad4a12ad306acc501106ccf7b0e4a950f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 17:25:28 | 2023-03-09 09:35:03 | 2023-03-05 03:56:19 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26293', 'html_url': 'https://github.com/facebook/react/pull/26293', 'diff_url': 'https://github.com/facebook/react/pull/26293.diff', 'patch_url': 'https://github.com/facebook/react/pull/26293.patch', 'merged_at': datetime.datetime(2023, 3, 5, 3, 56, 19)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26293/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26293/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26292 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26292/labels{/name} | https://api.github.com/repos/facebook/react/issues/26292/comments | https://api.github.com/repos/facebook/react/issues/26292/events | https://github.com/facebook/react/issues/26292 | 1,608,998,319 | I_kwDOAJy2Ks5f512v | 26,292 | Bug: Native dialog backdrop stylings don't work | {'login': 'anichols-ht', 'id': 111363900, 'node_id': 'U_kgDOBqNHPA', 'avatar_url': 'https://avatars.githubusercontent.com/u/111363900?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anichols-ht', 'html_url': 'https://github.com/anichols-ht', 'followers_url': 'https://api.github.com/users/anichols-ht/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You're running into a hydration error. See the bottom of this page:\r\nhttps://nextjs.org/docs/messages/react-hydration-error\r\n\r\nWith your example, if I put the css for `dialog` in a separate css file, it works just fine.\r\n\r\n### index.jsx\r\n\r\n```js\r\nimport React from \"react\";\r\n\r\nconst App = () =... | 2023-03-03 17:18:11 | 2024-04-08 14:09:32 | 2023-03-03 22:08:50 | NONE | null | null | null | I will be start by saying, it's wholly possible this is user error, cause I can't find any other reports of this issue by googling, but I cannot get backdrop stylings on native dialogs to render in React. In my work project where I noticed this, there are a lot of variables (tailwindcss, react, next, nx, etc.), but her... | {'url': 'https://api.github.com/repos/facebook/react/issues/26292/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26292/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26291 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26291/labels{/name} | https://api.github.com/repos/facebook/react/issues/26291/comments | https://api.github.com/repos/facebook/react/issues/26291/events | https://github.com/facebook/react/pull/26291 | 1,608,717,191 | PR_kwDOAJy2Ks5LOvvG | 26,291 | Extracted definition and access to public instances to a separate module in Fabric | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b72ed698fb5f15e0c33c5017422b8428b01ff12a...b2a5c00d6197ae2074eb49a543128d831af8d95e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 14:10:34 | 2023-03-06 11:03:02 | 2023-03-06 10:50:56 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/26291', 'html_url': 'https://github.com/facebook/react/pull/26291', 'diff_url': 'https://github.com/facebook/react/pull/26291.diff', 'patch_url': 'https://github.com/facebook/react/pull/26291.patch', 'merged_at': None} | ## Summary
The current definition of `Instance` in Fabric has 2 fields:
- `node`: reference to the native node in the shadow tree.
- `canonical`: public instance provided to users via refs.
We're currently using `canonical` not only as the public instance, but also to store internal properties that Fabric needs... | {'url': 'https://api.github.com/repos/facebook/react/issues/26291/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26291/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26290 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26290/labels{/name} | https://api.github.com/repos/facebook/react/issues/26290/comments | https://api.github.com/repos/facebook/react/issues/26290/events | https://github.com/facebook/react/pull/26290 | 1,608,533,249 | PR_kwDOAJy2Ks5LOHbJ | 26,290 | Remove unnecessary (and incorrect) code for compatibility with Paper in the Fabric version of GlobalResponderHandler | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b72ed698fb5f15e0c33c5017422b8428b01ff12a...4bb596b6211f3f04acdb469dd1e0411894a55a60\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 12:18:38 | 2023-03-03 23:55:04 | 2023-03-03 23:39:04 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26290', 'html_url': 'https://github.com/facebook/react/pull/26290', 'diff_url': 'https://github.com/facebook/react/pull/26290.diff', 'patch_url': 'https://github.com/facebook/react/pull/26290.patch', 'merged_at': datetime.datetime(2023, 3, 3, 23, 39, 4)} | ## Summary
I'm working on a refactor of the definition of `Instance` in Fabric and I came across this code that seemed to be for compatibility with Paper, but that it would actually throw an error in that case.
In Paper, `stateNode` is an instance of `ReactNativeFiberHostComponent`, which doesn't have a `canonica... | {'url': 'https://api.github.com/repos/facebook/react/issues/26290/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26290/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26289 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26289/labels{/name} | https://api.github.com/repos/facebook/react/issues/26289/comments | https://api.github.com/repos/facebook/react/issues/26289/events | https://github.com/facebook/react/issues/26289 | 1,608,372,930 | I_kwDOAJy2Ks5f3dLC | 26,289 | Bug: Misbehaving while deployment | {'login': 'starboyvarun', 'id': 26819449, 'node_id': 'MDQ6VXNlcjI2ODE5NDQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/26819449?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/starboyvarun', 'html_url': 'https://github.com/starboyvarun', 'followers_url': 'https://api.github.com/users/starboyv... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This has nothing to do with React. That said, you should update your Node.js",
"@vkurchatkin I have updated the node.js but still giving the same error. When I use ``` npm build ``` its something to do with that.\r\n"
] | 2023-03-03 10:26:37 | 2023-03-06 05:34:53 | 2023-03-06 05:34:52 | NONE | null | null | null | Hi
**Input:**
```
plum@plum-V530S-07ICB:~/dep$ serve -s build
```
**Output:**
file:///usr/local/lib/node_modules/serve/build/main.js:169
const ipAddress = request.socket.remoteAddress?.replace("::ffff:", "") ?? "unknown";
^
SyntaxError: Unexpecte... | {'url': 'https://api.github.com/repos/facebook/react/issues/26289/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26289/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26288 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26288/labels{/name} | https://api.github.com/repos/facebook/react/issues/26288/comments | https://api.github.com/repos/facebook/react/issues/26288/events | https://github.com/facebook/react/pull/26288 | 1,607,860,635 | PR_kwDOAJy2Ks5LL2Gk | 26,288 | Codemod tests to waitFor pattern (1/?) | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e5244673388a58eaf8f02a9e44749bef3ffee615...4b9c9392a6cb04b57cf6a31dcdf4a1cc37ad4ad5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-03 02:59:05 | 2023-03-03 04:26:02 | 2023-03-03 03:34:58 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26288', 'html_url': 'https://github.com/facebook/react/pull/26288', 'diff_url': 'https://github.com/facebook/react/pull/26288.diff', 'patch_url': 'https://github.com/facebook/react/pull/26288.patch', 'merged_at': datetime.datetime(2023, 3, 3, 3, 34, 58)} | This converts some of our test suite to use the `waitFor` test pattern, instead of the `expect(Scheduler).toFlushAndYield` pattern. Most of these changes are automated with jscodeshift, with some slight manual cleanup in certain cases.
See #26285 for full context. | {'url': 'https://api.github.com/repos/facebook/react/issues/26288/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26288/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26287 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26287/labels{/name} | https://api.github.com/repos/facebook/react/issues/26287/comments | https://api.github.com/repos/facebook/react/issues/26287/events | https://github.com/facebook/react/pull/26287 | 1,607,845,350 | PR_kwDOAJy2Ks5LLzAO | 26,287 | [eslint-plugin-react-hooks] Allow hooks inside components declared as member properties | {'login': 'mattdarveniza', 'id': 946261, 'node_id': 'MDQ6VXNlcjk0NjI2MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/946261?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mattdarveniza', 'html_url': 'https://github.com/mattdarveniza', 'followers_url': 'https://api.github.com/users/mattdarve... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2023-03-03 02:36:10 | 2023-09-19 01:11:09 | 2023-09-19 01:11:09 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26287', 'html_url': 'https://github.com/facebook/react/pull/26287', 'diff_url': 'https://github.com/facebook/react/pull/26287.diff', 'patch_url': 'https://github.com/facebook/react/pull/26287.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26287/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26287/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26286 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26286/labels{/name} | https://api.github.com/repos/facebook/react/issues/26286/comments | https://api.github.com/repos/facebook/react/issues/26286/events | https://github.com/facebook/react/issues/26286 | 1,607,787,335 | I_kwDOAJy2Ks5f1ONH | 26,286 | - | {'login': 'addison912', 'id': 20761462, 'node_id': 'MDQ6VXNlcjIwNzYxNDYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/20761462?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/addison912', 'html_url': 'https://github.com/addison912', 'followers_url': 'https://api.github.com/users/addison912/fol... | [] | closed | false | null | [] | null | [] | 2023-03-03 01:20:50 | 2023-03-03 01:24:35 | 2023-03-03 01:24:35 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/26286/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26286/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26285 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26285/labels{/name} | https://api.github.com/repos/facebook/react/issues/26285/comments | https://api.github.com/repos/facebook/react/issues/26285/events | https://github.com/facebook/react/pull/26285 | 1,607,547,498 | PR_kwDOAJy2Ks5LKxjf | 26,285 | New internal testing helpers: waitFor, waitForAll, waitForPaint | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d49e0e0be0941490fe709f80de137516ba4c0ee3...8aadd4fce92ceb42b2596f32363dc6b3e0c9cb9e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-02 21:42:12 | 2023-03-03 03:57:22 | 2023-03-03 02:58:12 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26285', 'html_url': 'https://github.com/facebook/react/pull/26285', 'diff_url': 'https://github.com/facebook/react/pull/26285.diff', 'patch_url': 'https://github.com/facebook/react/pull/26285.patch', 'merged_at': datetime.datetime(2023, 3, 3, 2, 58, 12)} | Over the years, we've gradually aligned on a set of best practices for for testing concurrent React features in this repo. The default in most cases is to use `act`, the same as you would do when testing a real React app. However, because we're testing React itself, as opposed to an app that uses React, our internal te... | {'url': 'https://api.github.com/repos/facebook/react/issues/26285/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26285/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26284 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26284/labels{/name} | https://api.github.com/repos/facebook/react/issues/26284/comments | https://api.github.com/repos/facebook/react/issues/26284/events | https://github.com/facebook/react/issues/26284 | 1,607,428,211 | I_kwDOAJy2Ks5fz2hz | 26,284 | Bug: Lag when updating coordinates of div on mousemove | {'login': 'blnvdanil', 'id': 61459199, 'node_id': 'MDQ6VXNlcjYxNDU5MTk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/61459199?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/blnvdanil', 'html_url': 'https://github.com/blnvdanil', 'followers_url': 'https://api.github.com/users/blnvdanil/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"It seems to be related to the new architecture of `React18`, but I'm not entirely sure. However, there is a workaround available.\r\n\r\nYour code may not be the best approach to rendering two components synchronously using `useRef` and` useState`. The move event will immediately trigger the ref update, changing t... | 2023-03-02 20:16:38 | 2024-04-17 06:04:15 | 2024-04-17 06:04:13 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
There is a noticable delay when updating `div`'s coordinates on mousemove with rea... | {'url': 'https://api.github.com/repos/facebook/react/issues/26284/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26284/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26283 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26283/labels{/name} | https://api.github.com/repos/facebook/react/issues/26283/comments | https://api.github.com/repos/facebook/react/issues/26283/events | https://github.com/facebook/react/pull/26283 | 1,607,126,293 | PR_kwDOAJy2Ks5LJWBF | 26,283 | Fixed incorrect value returned as public instance from reconciler | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d49e0e0be0941490fe709f80de137516ba4c0ee3...90fff0651139c055696b5770b7bbc42ce633117b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-02 16:32:29 | 2023-03-03 09:38:15 | 2023-03-03 09:38:09 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26283', 'html_url': 'https://github.com/facebook/react/pull/26283', 'diff_url': 'https://github.com/facebook/react/pull/26283.diff', 'patch_url': 'https://github.com/facebook/react/pull/26283.patch', 'merged_at': datetime.datetime(2023, 3, 3, 9, 38, 9)} | ## Summary
A few methods in `ReactFiberReconciler` are supposed to return `PublicInstance` values, but they return the `stateNode` from the fiber directly. This assumes that the `stateNode` always matches the public instance (which it does on Web) but that's not the case in React Native, where the public instance is... | {'url': 'https://api.github.com/repos/facebook/react/issues/26283/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26283/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26282 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26282/labels{/name} | https://api.github.com/repos/facebook/react/issues/26282/comments | https://api.github.com/repos/facebook/react/issues/26282/events | https://github.com/facebook/react/pull/26282 | 1,606,956,136 | PR_kwDOAJy2Ks5LIxW1 | 26,282 | Removed unused imperative events implementation from React Native renderer | {'login': 'rubennorte', 'id': 117921, 'node_id': 'MDQ6VXNlcjExNzkyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/117921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubennorte', 'html_url': 'https://github.com/rubennorte', 'followers_url': 'https://api.github.com/users/rubennorte/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 41110021f28100b16c11d6d9a248582c5bb6bc3c...abab75d3e01482843b527a11a0cdfdddb12ad791\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-02 14:54:28 | 2023-03-03 16:03:14 | 2023-03-02 15:54:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26282', 'html_url': 'https://github.com/facebook/react/pull/26282', 'diff_url': 'https://github.com/facebook/react/pull/26282.diff', 'patch_url': 'https://github.com/facebook/react/pull/26282.patch', 'merged_at': datetime.datetime(2023, 3, 2, 15, 54, 52)} | ## Summary
I'm going to start implementing parts of this proposal https://github.com/react-native-community/discussions-and-proposals/pull/607
As part of that implementation I'm going to refactor a few parts of the interface between React and React Native. One of the main problems we have right now is that we hav... | {'url': 'https://api.github.com/repos/facebook/react/issues/26282/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26282/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26281 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26281/labels{/name} | https://api.github.com/repos/facebook/react/issues/26281/comments | https://api.github.com/repos/facebook/react/issues/26281/events | https://github.com/facebook/react/issues/26281 | 1,606,885,461 | I_kwDOAJy2Ks5fxyBV | 26,281 | Bug: Nested roots are not unmounted when calling `root.unmount()` | {'login': 'krzempekk', 'id': 44374710, 'node_id': 'MDQ6VXNlcjQ0Mzc0NzEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/44374710?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/krzempekk', 'html_url': 'https://github.com/krzempekk', 'followers_url': 'https://api.github.com/users/krzempekk/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Example was invalid, this is not actually an issue",
"Do you have an example of an app using multiple nested `createRoot`? The links you provided in the OP are both using React 17. Investigating an issue in my own codebase, and curious how you approached it."
] | 2023-03-02 14:15:28 | 2024-04-27 01:25:14 | 2023-03-02 15:27:10 | NONE | null | null | null | When using multiple nested React roots, un-mounting the top-level one does not result in un-mounting lower-level ones. Any `useEffect` cleanup functions of components in lower-level roots are not called.
React version: 18.2.0 (also reproduced in 17.0.2)
## Steps To Reproduce
*see code examples for details*
... | {'url': 'https://api.github.com/repos/facebook/react/issues/26281/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26281/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26280 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26280/labels{/name} | https://api.github.com/repos/facebook/react/issues/26280/comments | https://api.github.com/repos/facebook/react/issues/26280/events | https://github.com/facebook/react/pull/26280 | 1,606,187,293 | PR_kwDOAJy2Ks5LGKEz | 26,280 | [Float][Fizz][Fiber]: Refactor <style> Resource implementation to group on flush | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b2ae9ddb3b497d16a7c27c051da1827d08871138...5128af254cc0345a07f51fa76348ac233e8144e5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-02 06:28:14 | 2023-03-03 20:50:39 | 2023-03-03 20:50:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26280', 'html_url': 'https://github.com/facebook/react/pull/26280', 'diff_url': 'https://github.com/facebook/react/pull/26280.diff', 'patch_url': 'https://github.com/facebook/react/pull/26280.patch', 'merged_at': datetime.datetime(2023, 3, 3, 20, 50, 35)} | There is a problem with <style> as resource. For css-in-js libs there may be an very large number of these hoistables being created. The number of style tags can grow quickly and to help reduce the prevalence of this FIzz now aggregates all style tags for a given precedence into a single tag. The client can 'hydrate' a... | {'url': 'https://api.github.com/repos/facebook/react/issues/26280/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26280/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26279 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26279/labels{/name} | https://api.github.com/repos/facebook/react/issues/26279/comments | https://api.github.com/repos/facebook/react/issues/26279/events | https://github.com/facebook/react/issues/26279 | 1,606,020,464 | I_kwDOAJy2Ks5fue1w | 26,279 | Bug: Suspense component loses childs hook context on suspension | {'login': '42shadow42', 'id': 6845471, 'node_id': 'MDQ6VXNlcjY4NDU0NzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6845471?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/42shadow42', 'html_url': 'https://github.com/42shadow42', 'followers_url': 'https://api.github.com/users/42shadow42/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It will work with `use` once that is released. Example: https://codesandbox.io/s/elastic-thompson-yejumo",
"Confirmed this works for my use case, thanks for the quick response, I'll be looking forward to it's release.",
"Confirmed it also allows using multiple promises in the same component which is a limitati... | 2023-03-02 02:55:24 | 2023-03-06 04:29:12 | 2023-03-05 00:04:47 | NONE | null | null | null | React version: 18.2.0
## Steps To Reproduce
1. Create a component that store some state
2. Create a promise dependent on that state
3. Throw the promise until it is resolved
4. Wrap the component in suspense
5. Wait for the promise to resolve
6. The component never renders
Link to code example:
[Suspen... | {'url': 'https://api.github.com/repos/facebook/react/issues/26279/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26279/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26278 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26278/labels{/name} | https://api.github.com/repos/facebook/react/issues/26278/comments | https://api.github.com/repos/facebook/react/issues/26278/events | https://github.com/facebook/react/pull/26278 | 1,606,004,089 | PR_kwDOAJy2Ks5LFiky | 26,278 | Add an option to 'react-hooks/exhaustive-deps' effect that configures disallowed dependencies | {'login': 'gaspar09', 'id': 5875536, 'node_id': 'MDQ6VXNlcjU4NzU1MzY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5875536?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaspar09', 'html_url': 'https://github.com/gaspar09', 'followers_url': 'https://api.github.com/users/gaspar09/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 41110021f28100b16c11d6d9a248582c5bb6bc3c...47b6a05a146a92033d41f5dc3c20bd2987519193\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-02 02:34:13 | 2023-03-02 03:04:02 | 2023-03-02 03:04:02 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26278', 'html_url': 'https://github.com/facebook/react/pull/26278', 'diff_url': 'https://github.com/facebook/react/pull/26278.diff', 'patch_url': 'https://github.com/facebook/react/pull/26278.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26278/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26278/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26277 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26277/labels{/name} | https://api.github.com/repos/facebook/react/issues/26277/comments | https://api.github.com/repos/facebook/react/issues/26277/events | https://github.com/facebook/react/issues/26277 | 1,605,761,248 | I_kwDOAJy2Ks5ftfjg | 26,277 | Bug: creating the initial state | {'login': 'Dave-Patsy', 'id': 24628331, 'node_id': 'MDQ6VXNlcjI0NjI4MzMx', 'avatar_url': 'https://avatars.githubusercontent.com/u/24628331?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Dave-Patsy', 'html_url': 'https://github.com/Dave-Patsy', 'followers_url': 'https://api.github.com/users/Dave-Patsy/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"this is an example of passing the initializer function to set state from the react docts beta\r\n\r\n```\r\nimport { useState } from 'react';\r\n\r\nfunction createInitialTodos() {\r\n const initialTodos = [];\r\n for (let i = 0; i < 50; i++) {\r\n initialTodos.push({\r\n id: i,\r\n text: 'Item ' + ... | 2023-03-01 22:29:46 | 2024-04-17 06:04:15 | 2024-04-17 06:04:15 | NONE | null | null | null | React version: "18.2.0"
The bug is failure of state initialization with a function, and not being consistent with the client and server. the fix is to use useEffect with empty dependency to initialize the state when the component is mounted on client.
I undertstand that useEffect is for synchronization, so it makes s... | {'url': 'https://api.github.com/repos/facebook/react/issues/26277/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26277/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26276 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26276/labels{/name} | https://api.github.com/repos/facebook/react/issues/26276/comments | https://api.github.com/repos/facebook/react/issues/26276/events | https://github.com/facebook/react/issues/26276 | 1,605,409,889 | I_kwDOAJy2Ks5fsJxh | 26,276 | test | {'login': 'nuga-dev', 'id': 93000491, 'node_id': 'U_kgDOBYsTKw', 'avatar_url': 'https://avatars.githubusercontent.com/u/93000491?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nuga-dev', 'html_url': 'https://github.com/nuga-dev', 'followers_url': 'https://api.github.com/users/nuga-dev/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2023-03-01 17:52:53 | 2023-03-01 17:52:56 | 2023-03-01 17:52:56 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/26276/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26276/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26275 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26275/labels{/name} | https://api.github.com/repos/facebook/react/issues/26275/comments | https://api.github.com/repos/facebook/react/issues/26275/events | https://github.com/facebook/react/pull/26275 | 1,605,281,627 | PR_kwDOAJy2Ks5LDFiN | 26,275 | Fix: Selective hydration causing incorrect thenable type passed to DevTools | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 67a61d5bd7f731f5eb37d148dfc4ae0515a8c934...d20f72cc728d24320cd7a18c0c4834478f9493db\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-01 16:25:00 | 2023-03-01 18:22:57 | 2023-03-01 16:38:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26275', 'html_url': 'https://github.com/facebook/react/pull/26275', 'diff_url': 'https://github.com/facebook/react/pull/26275.diff', 'patch_url': 'https://github.com/facebook/react/pull/26275.patch', 'merged_at': datetime.datetime(2023, 3, 1, 16, 38, 49)} | Selective hydration is implemented by suspending the current render using a special internal opaque object. This is conceptually similar to suspending with a thenable in userspace, but the opaque object should not leak outside of the reconciler.
We were accidentally passing this object to DevTool's markComponentSusp... | {'url': 'https://api.github.com/repos/facebook/react/issues/26275/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26275/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26274 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26274/labels{/name} | https://api.github.com/repos/facebook/react/issues/26274/comments | https://api.github.com/repos/facebook/react/issues/26274/events | https://github.com/facebook/react/pull/26274 | 1,605,044,278 | PR_kwDOAJy2Ks5LCSS9 | 26,274 | Fixed Issue #26042 ERROR TypeError: Cannot read property 'createElement' of undefined, js engine: hermes | {'login': 'Surendra-Mundvadiya', 'id': 97657580, 'node_id': 'U_kgDOBdIi7A', 'avatar_url': 'https://avatars.githubusercontent.com/u/97657580?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Surendra-Mundvadiya', 'html_url': 'https://github.com/Surendra-Mundvadiya', 'followers_url': 'https://api.github.com/u... | [] | closed | false | null | [] | null | [
"Hi @Surendra-Mundvadiya! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn... | 2023-03-01 14:07:11 | 2023-03-01 20:31:19 | 2023-03-01 20:31:19 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26274', 'html_url': 'https://github.com/facebook/react/pull/26274', 'diff_url': 'https://github.com/facebook/react/pull/26274.diff', 'patch_url': 'https://github.com/facebook/react/pull/26274.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the r... | {'url': 'https://api.github.com/repos/facebook/react/issues/26274/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26274/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26273 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26273/labels{/name} | https://api.github.com/repos/facebook/react/issues/26273/comments | https://api.github.com/repos/facebook/react/issues/26273/events | https://github.com/facebook/react/issues/26273 | 1,604,567,634 | I_kwDOAJy2Ks5fo8JS | 26,273 | Bug: Tests using jest.useFakeTimers gave different results in react 17 and 18. | {'login': 'skahack', 'id': 76637, 'node_id': 'MDQ6VXNlcjc2NjM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/76637?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/skahack', 'html_url': 'https://github.com/skahack', 'followers_url': 'https://api.github.com/users/skahack/followers', 'following_ur... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I think this is a feature: https://reactjs.org/blog/2022/03/29/react-v18.html#new-feature-automatic-batching",
"Thank you. I was able to get it to behave as before.\r\nI don't know if this is the spec, but I'm going to close the Issue since it seems to have already been discussed.\r\n\r\nhttps://codesandbox.io/p... | 2023-03-01 09:11:03 | 2023-03-02 08:51:34 | 2023-03-02 04:57:01 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
I had a test using `jest.FakeTimers` where the results were different between Re... | {'url': 'https://api.github.com/repos/facebook/react/issues/26273/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26273/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26272 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26272/labels{/name} | https://api.github.com/repos/facebook/react/issues/26272/comments | https://api.github.com/repos/facebook/react/issues/26272/events | https://github.com/facebook/react/pull/26272 | 1,604,016,071 | PR_kwDOAJy2Ks5K-yrt | 26,272 | Bump minimist from 1.2.3 to 1.2.6 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 40755c01a68de4b44bc24cca7f03a46140f31d5e...b5248f13c3944c1955718598c6caa860c9fc397b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-01 00:25:47 | 2023-03-02 15:26:13 | 2023-03-02 15:25:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26272', 'html_url': 'https://github.com/facebook/react/pull/26272', 'diff_url': 'https://github.com/facebook/react/pull/26272.diff', 'patch_url': 'https://github.com/facebook/react/pull/26272.patch', 'merged_at': None} | Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.3 to 1.2.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md">minimist's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/minimistjs/minimist/compare/v1.... | {'url': 'https://api.github.com/repos/facebook/react/issues/26272/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26272/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26271 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26271/labels{/name} | https://api.github.com/repos/facebook/react/issues/26271/comments | https://api.github.com/repos/facebook/react/issues/26271/events | https://github.com/facebook/react/pull/26271 | 1,604,015,946 | PR_kwDOAJy2Ks5K-yqA | 26,271 | Bump minimist from 1.2.5 to 1.2.8 in /fixtures/ssr2 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 40755c01a68de4b44bc24cca7f03a46140f31d5e...e01909d632ad3cc382bb7e7eaea201ac1273028e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-03-01 00:25:38 | 2023-03-02 15:26:13 | 2023-03-02 15:25:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26271', 'html_url': 'https://github.com/facebook/react/pull/26271', 'diff_url': 'https://github.com/facebook/react/pull/26271.diff', 'patch_url': 'https://github.com/facebook/react/pull/26271.patch', 'merged_at': None} | Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md">minimist's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/minimistjs/minimist/compare/v1.... | {'url': 'https://api.github.com/repos/facebook/react/issues/26271/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26271/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26270 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26270/labels{/name} | https://api.github.com/repos/facebook/react/issues/26270/comments | https://api.github.com/repos/facebook/react/issues/26270/events | https://github.com/facebook/react/pull/26270 | 1,603,990,397 | PR_kwDOAJy2Ks5K-tam | 26,270 | Bump minimist from 1.2.0 to 1.2.8 in /fixtures/packaging/browserify/dev | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 38509cce9b2f8b2046d2952645879e2f474ca745...95824674de0278037db575608f10c4583871ff31\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-28 23:55:03 | 2023-03-02 15:26:13 | 2023-03-02 15:25:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26270', 'html_url': 'https://github.com/facebook/react/pull/26270', 'diff_url': 'https://github.com/facebook/react/pull/26270.diff', 'patch_url': 'https://github.com/facebook/react/pull/26270.patch', 'merged_at': None} | Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.0 to 1.2.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md">minimist's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/minimistjs/minimist/compare/v1.... | {'url': 'https://api.github.com/repos/facebook/react/issues/26270/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26270/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26269 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26269/labels{/name} | https://api.github.com/repos/facebook/react/issues/26269/comments | https://api.github.com/repos/facebook/react/issues/26269/events | https://github.com/facebook/react/pull/26269 | 1,603,990,333 | PR_kwDOAJy2Ks5K-tZu | 26,269 | Bump minimist from 1.2.0 to 1.2.8 in /fixtures/packaging/browserify/prod | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 38509cce9b2f8b2046d2952645879e2f474ca745...bfa66cff41df35daa5c0f508b706cea51d2692d7\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-28 23:54:58 | 2023-03-02 15:26:13 | 2023-03-02 15:25:42 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26269', 'html_url': 'https://github.com/facebook/react/pull/26269', 'diff_url': 'https://github.com/facebook/react/pull/26269.diff', 'patch_url': 'https://github.com/facebook/react/pull/26269.patch', 'merged_at': None} | Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.0 to 1.2.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md">minimist's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/minimistjs/minimist/compare/v1.... | {'url': 'https://api.github.com/repos/facebook/react/issues/26269/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26269/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26265 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26265/labels{/name} | https://api.github.com/repos/facebook/react/issues/26265/comments | https://api.github.com/repos/facebook/react/issues/26265/events | https://github.com/facebook/react/pull/26265 | 1,603,862,306 | PR_kwDOAJy2Ks5K-R9O | 26,265 | Add preconnect and prefetchDNS to rendering-stub | {'login': 'huozhi', 'id': 4800338, 'node_id': 'MDQ6VXNlcjQ4MDAzMzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4800338?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huozhi', 'html_url': 'https://github.com/huozhi', 'followers_url': 'https://api.github.com/users/huozhi/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b2ae9ddb3b497d16a7c27c051da1827d08871138...2a26dfb745ace6cfdc64ea763d6794d65a47fafd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-28 21:43:27 | 2023-02-28 22:39:08 | 2023-02-28 22:27:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26265', 'html_url': 'https://github.com/facebook/react/pull/26265', 'diff_url': 'https://github.com/facebook/react/pull/26265.diff', 'patch_url': 'https://github.com/facebook/react/pull/26265.patch', 'merged_at': datetime.datetime(2023, 2, 28, 22, 27, 17)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26265/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26265/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26264 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26264/labels{/name} | https://api.github.com/repos/facebook/react/issues/26264/comments | https://api.github.com/repos/facebook/react/issues/26264/events | https://github.com/facebook/react/issues/26264 | 1,603,704,040 | I_kwDOAJy2Ks5flpTo | 26,264 | Bug: Have problems with Provider react-redux | {'login': 'keryaBoks', 'id': 94535983, 'node_id': 'U_kgDOBaKBLw', 'avatar_url': 'https://avatars.githubusercontent.com/u/94535983?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/keryaBoks', 'html_url': 'https://github.com/keryaBoks', 'followers_url': 'https://api.github.com/users/keryaBoks/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You probably have multiple versions of `@types/react` installed. Make sure you only have the version install matching your version of React.\r\n\r\nhttps://github.com/facebook/react/issues/24304 contains a couple of workarounds as well.\r\n\r\nWith https://github.com/microsoft/DefinitelyTyped-tools/issues/433, we ... | 2023-02-28 19:47:46 | 2023-02-28 21:20:36 | 2023-02-28 21:20:35 | NONE | null | null | null | <img width="855" alt="Screenshot 2023-02-28 at 22 46 40" src="https://user-images.githubusercontent.com/94535983/221962428-c1772707-8958-47c6-a11c-5c105ee22955.png">
have such issue using redux-toolkit, the only one solution is use old version of types/react
my current version is "@types/react": "^17.0.39", | {'url': 'https://api.github.com/repos/facebook/react/issues/26264/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26264/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/26263 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26263/labels{/name} | https://api.github.com/repos/facebook/react/issues/26263/comments | https://api.github.com/repos/facebook/react/issues/26263/events | https://github.com/facebook/react/pull/26263 | 1,603,634,587 | PR_kwDOAJy2Ks5K9gqA | 26,263 | [Flight Fixture] Show SSR Support with CSS | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 40755c01a68de4b44bc24cca7f03a46140f31d5e...36845953f0733f33d1f5d31f96ccb3a2e2ddb5cf\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-28 18:55:16 | 2023-03-01 00:44:38 | 2023-03-01 00:44:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26263', 'html_url': 'https://github.com/facebook/react/pull/26263', 'diff_url': 'https://github.com/facebook/react/pull/26263.diff', 'patch_url': 'https://github.com/facebook/react/pull/26263.patch', 'merged_at': datetime.datetime(2023, 3, 1, 0, 44, 38)} | Builds on #26257.
To do this we need access to a manifest for which scripts and CSS are used for each "page" (entrypoint).
The initial script to bootstrap the app is inserted with `bootstrapScripts`. Subsequent content are loaded using the chunks mechanism built-in.
The stylesheets for each pages are prepended... | {'url': 'https://api.github.com/repos/facebook/react/issues/26263/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26263/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26262 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26262/labels{/name} | https://api.github.com/repos/facebook/react/issues/26262/comments | https://api.github.com/repos/facebook/react/issues/26262/events | https://github.com/facebook/react/pull/26262 | 1,603,402,013 | PR_kwDOAJy2Ks5K8thI | 26,262 | Update .mailmap | {'login': 'dixitdesai', 'id': 85556276, 'node_id': 'MDQ6VXNlcjg1NTU2Mjc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/85556276?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dixitdesai', 'html_url': 'https://github.com/dixitdesai', 'followers_url': 'https://api.github.com/users/dixitdesai/fol... | [] | closed | false | null | [] | null | [
"Hi @dixitdesai! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2023-02-28 16:32:24 | 2023-03-02 15:26:03 | 2023-03-02 15:26:03 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26262', 'html_url': 'https://github.com/facebook/react/pull/26262', 'diff_url': 'https://github.com/facebook/react/pull/26262.diff', 'patch_url': 'https://github.com/facebook/react/pull/26262.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26262/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26262/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26261 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26261/labels{/name} | https://api.github.com/repos/facebook/react/issues/26261/comments | https://api.github.com/repos/facebook/react/issues/26261/events | https://github.com/facebook/react/pull/26261 | 1,603,110,477 | PR_kwDOAJy2Ks5K7uP8 | 26,261 | Fix typo hae -> have | {'login': 'apupier', 'id': 1105127, 'node_id': 'MDQ6VXNlcjExMDUxMjc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1105127?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/apupier', 'html_url': 'https://github.com/apupier', 'followers_url': 'https://api.github.com/users/apupier/followers', 'foll... | [] | closed | false | null | [] | null | [
"Hi @apupier! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for u... | 2023-02-28 13:48:42 | 2023-02-28 13:55:16 | 2023-02-28 13:55:15 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26261', 'html_url': 'https://github.com/facebook/react/pull/26261', 'diff_url': 'https://github.com/facebook/react/pull/26261.diff', 'patch_url': 'https://github.com/facebook/react/pull/26261.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26261/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26261/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26260 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26260/labels{/name} | https://api.github.com/repos/facebook/react/issues/26260/comments | https://api.github.com/repos/facebook/react/issues/26260/events | https://github.com/facebook/react/pull/26260 | 1,602,899,842 | PR_kwDOAJy2Ks5K6_gf | 26,260 | Fix test command --sourceMaps flag not enabling inline source maps | {'login': 'XYShaoKang', 'id': 38753204, 'node_id': 'MDQ6VXNlcjM4NzUzMjA0', 'avatar_url': 'https://avatars.githubusercontent.com/u/38753204?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/XYShaoKang', 'html_url': 'https://github.com/XYShaoKang', 'followers_url': 'https://api.github.com/users/XYShaoKang/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b2ae9ddb3b497d16a7c27c051da1827d08871138...c2e75501a570ffa895d150f832c73484eeaf173c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-28 11:51:16 | 2024-04-17 06:04:17 | 2024-04-17 06:04:16 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26260', 'html_url': 'https://github.com/facebook/react/pull/26260', 'diff_url': 'https://github.com/facebook/react/pull/26260.diff', 'patch_url': 'https://github.com/facebook/react/pull/26260.patch', 'merged_at': None} | ## Summary
This issue was encountered when I attempted to debug React using VSCode.
I wanted to initiate debugging of React through testing, so I created the following test file:
```js
// packages/react/src/__tests__/test.js
const React = require('../React')
test('should first', () => {
React.createEle... | {'url': 'https://api.github.com/repos/facebook/react/issues/26260/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26260/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26259 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26259/labels{/name} | https://api.github.com/repos/facebook/react/issues/26259/comments | https://api.github.com/repos/facebook/react/issues/26259/events | https://github.com/facebook/react/issues/26259 | 1,602,434,150 | I_kwDOAJy2Ks5fgzRm | 26,259 | Bug: ErrorBoundary remounts children when errors are caught | {'login': 'fatton139', 'id': 24207217, 'node_id': 'MDQ6VXNlcjI0MjA3MjE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/24207217?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fatton139', 'html_url': 'https://github.com/fatton139', 'followers_url': 'https://api.github.com/users/fatton139/followe... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 739761016, 'node_id': 'MDU6TGFiZWw3Mzk3NjEwMTY=', 'url': 'https://api.github.com/repos/f... | open | false | null | [] | null | [
"I am experiencing this with componentDidUpdate, as well. It gets even weirder, because the ErrorBoundary doesn't receive all of the thrown errors.\r\n\r\nMy own example: https://codesandbox.io/s/bold-brook-63i6vm?file=/src/App.js\r\nNotice that the console shows the error occurred four times, but the Boundary only... | 2023-02-28 06:10:57 | 2024-04-28 14:27:15 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
In the `render` block of a `ErrorBoundary` component the `props.children` is rem... | {'url': 'https://api.github.com/repos/facebook/react/issues/26259/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26259/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/26258 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26258/labels{/name} | https://api.github.com/repos/facebook/react/issues/26258/comments | https://api.github.com/repos/facebook/react/issues/26258/events | https://github.com/facebook/react/pull/26258 | 1,602,113,791 | PR_kwDOAJy2Ks5K4Xpi | 26,258 | Bump minimist from 1.2.5 to 1.2.6 in /scripts/bench | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.\n\nIf you change your mind, j... | 2023-02-27 23:25:53 | 2023-03-02 15:26:33 | 2023-03-02 15:26:18 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26258', 'html_url': 'https://github.com/facebook/react/pull/26258', 'diff_url': 'https://github.com/facebook/react/pull/26258.diff', 'patch_url': 'https://github.com/facebook/react/pull/26258.patch', 'merged_at': None} | Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md">minimist's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/minimistjs/minimist/compare/v1.... | {'url': 'https://api.github.com/repos/facebook/react/issues/26258/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26258/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26257 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26257/labels{/name} | https://api.github.com/repos/facebook/react/issues/26257/comments | https://api.github.com/repos/facebook/react/issues/26257/events | https://github.com/facebook/react/pull/26257 | 1,602,053,254 | PR_kwDOAJy2Ks5K4K3g | 26,257 | [Flight Fixture] Proxy requests through the global server instead of directly | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: b2ae9ddb3b497d16a7c27c051da1827d08871138...dedec0979f3803906a7fef1a12ec99c46df74666\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-27 22:29:42 | 2023-03-01 00:24:17 | 2023-03-01 00:24:17 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26257', 'html_url': 'https://github.com/facebook/react/pull/26257', 'diff_url': 'https://github.com/facebook/react/pull/26257.diff', 'patch_url': 'https://github.com/facebook/react/pull/26257.patch', 'merged_at': datetime.datetime(2023, 3, 1, 0, 24, 17)} | This proxies requests through the global server instead of requesting RSC responses from the regional server. This is a bit closer to idiomatic, and closer to SSR.
This also wires up HMR using the Middleware technique instead of server. This will be an important part of RSC compatibility because there will be a `rea... | {'url': 'https://api.github.com/repos/facebook/react/issues/26257/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26257/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26256 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26256/labels{/name} | https://api.github.com/repos/facebook/react/issues/26256/comments | https://api.github.com/repos/facebook/react/issues/26256/events | https://github.com/facebook/react/pull/26256 | 1,602,038,388 | PR_kwDOAJy2Ks5K4HvI | 26,256 | [Float][Fizz][Fiber] - Do not hoist elements with `itemProp` & hydrate more tolerantly in hoist contexts | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: e98695db918721a08eae0a2dceeb5719c1aa7261...f327f7e9ca4fc1af66e352edccc9448531d67a07\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-27 22:14:11 | 2023-03-06 23:01:01 | 2023-03-06 23:00:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26256', 'html_url': 'https://github.com/facebook/react/pull/26256', 'diff_url': 'https://github.com/facebook/react/pull/26256.diff', 'patch_url': 'https://github.com/facebook/react/pull/26256.patch', 'merged_at': datetime.datetime(2023, 3, 6, 23, 0, 55)} | ## Do not hoist elements with `itemProp`
In HTML `itemprop` signifies a property of an `itemscope` with respect to the Microdata spec (https://html.spec.whatwg.org/multipage/microdata.html#microdata)
additionally `itemprop` is valid on any tag and can even make some tags that are otherwise invalid in the `<body>` ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26256/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26256/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26255 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26255/labels{/name} | https://api.github.com/repos/facebook/react/issues/26255/comments | https://api.github.com/repos/facebook/react/issues/26255/events | https://github.com/facebook/react/pull/26255 | 1,601,282,181 | PR_kwDOAJy2Ks5K1lWl | 26,255 | Add `.nvmrc` to `fixtures/flight` to automatically use Node 18 | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6ff1733e63fdb948ae973a713741b4526102c73c...06a215efb87d3faa55906ebe44d043aae031face\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2023-02-27 14:19:51 | 2023-02-28 07:27:02 | 2023-02-28 07:26:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26255', 'html_url': 'https://github.com/facebook/react/pull/26255', 'diff_url': 'https://github.com/facebook/react/pull/26255.diff', 'patch_url': 'https://github.com/facebook/react/pull/26255.patch', 'merged_at': None} | The requirement for node 18 (global `fetch`) was introduced in f0cf832.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submi... | {'url': 'https://api.github.com/repos/facebook/react/issues/26255/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26255/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26254 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26254/labels{/name} | https://api.github.com/repos/facebook/react/issues/26254/comments | https://api.github.com/repos/facebook/react/issues/26254/events | https://github.com/facebook/react/pull/26254 | 1,601,196,000 | PR_kwDOAJy2Ks5K1ShY | 26,254 | Add support for SyntheticKeyboardEvent `isComposing` | {'login': 'bhbs', 'id': 22282293, 'node_id': 'MDQ6VXNlcjIyMjgyMjkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22282293?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bhbs', 'html_url': 'https://github.com/bhbs', 'followers_url': 'https://api.github.com/users/bhbs/followers', 'following_url'... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Hi @bhbs! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us t... | 2023-02-27 13:30:41 | 2024-04-10 20:55:26 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/26254', 'html_url': 'https://github.com/facebook/react/pull/26254', 'diff_url': 'https://github.com/facebook/react/pull/26254.diff', 'patch_url': 'https://github.com/facebook/react/pull/26254.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/26254/reactions', 'total_count': 12, '+1': 8, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 2, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26254/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/26253 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26253/labels{/name} | https://api.github.com/repos/facebook/react/issues/26253/comments | https://api.github.com/repos/facebook/react/issues/26253/events | https://github.com/facebook/react/issues/26253 | 1,601,158,819 | I_kwDOAJy2Ks5fb76j | 26,253 | Bug: React 18 renders different pages compared to React 17 | {'login': 'roman-zabolotskyi-axon', 'id': 68898159, 'node_id': 'MDQ6VXNlcjY4ODk4MTU5', 'avatar_url': 'https://avatars.githubusercontent.com/u/68898159?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/roman-zabolotskyi-axon', 'html_url': 'https://github.com/roman-zabolotskyi-axon', 'followers_url': 'https:/... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"React 18 sandbox link is accidentally the same as React 17 sandbox.",
"> React 18 sandbox link is accidentally the same as React 17 sandbox.\r\n\r\nThanks, updated."
] | 2023-02-27 13:10:09 | 2023-03-14 13:32:33 | 2023-03-14 13:32:33 | NONE | null | null | null | We're trying to upgrade from `React 17.0.2` to `React 18.2.0`. We don't use any `StrictMode` or SSR. Package upgrade for `react/react-dom` caused the app to render at different times and UI than it used to be before. Simply speaking, we had the following pattern:
`refresh the page -> render loading spinner -> receiv... | {'url': 'https://api.github.com/repos/facebook/react/issues/26253/reactions', 'total_count': 5, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/26253/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/26252 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/26252/labels{/name} | https://api.github.com/repos/facebook/react/issues/26252/comments | https://api.github.com/repos/facebook/react/issues/26252/events | https://github.com/facebook/react/issues/26252 | 1,600,683,728 | I_kwDOAJy2Ks5faH7Q | 26,252 | Bug: dispatch called in a wrong order from useEffect clean | {'login': 'vbezhenar', 'id': 4218339, 'node_id': 'MDQ6VXNlcjQyMTgzMzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4218339?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vbezhenar', 'html_url': 'https://github.com/vbezhenar', 'followers_url': 'https://api.github.com/users/vbezhenar/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2023-02-27 08:08:09 | 2024-04-17 06:04:19 | 2024-04-17 06:04:18 | NONE | null | null | null | I'm writing a hook to work with async promises. It's supposed to abort current promise when useEffect cleans up and work correctly with various scenarios (when old promise ignores signal and resolves after new promise and so on).
So basically I have a state machine with reducer. Promise callbacks and useEffect clean... | {'url': 'https://api.github.com/repos/facebook/react/issues/26252/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/26252/timeline | null | not_planned | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.