url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/24588 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24588/labels{/name} | https://api.github.com/repos/facebook/react/issues/24588/comments | https://api.github.com/repos/facebook/react/issues/24588/events | https://github.com/facebook/react/issues/24588 | 1,242,924,634 | I_kwDOAJy2Ks5KFYZa | 24,588 | Report problems from classes component in react version > 18.0 | {'login': 'quangvinh0708', 'id': 62977701, 'node_id': 'MDQ6VXNlcjYyOTc3NzAx', 'avatar_url': 'https://avatars.githubusercontent.com/u/62977701?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/quangvinh0708', 'html_url': 'https://github.com/quangvinh0708', 'followers_url': 'https://api.github.com/users/quang... | [] | closed | false | null | [] | null | [
"This is expected behavior (in development only) with Strict Mode on. Strict Mode is stricter in 18 and verifies your component is resilient to remounting with existing state. Normally, if your componentDidMount and componentWillUnmount calls are symmetrical, this shouldn’t cause observable issues.\r\n\r\nhttps://r... | 2022-05-20 10:08:02 | 2022-05-20 17:36:09 | 2022-05-20 17:36:09 | NONE | null | null | null | When I build an app just for fun and testing something, and of course like a title, I build it with a class component with a full declaration of lifecycle methods, two of those caused problems are componentDidMount, and the component will unmount.
When the first-time component is mounted to DOM in the browser. Norma... | {'url': 'https://api.github.com/repos/facebook/react/issues/24588/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24588/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24587 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24587/labels{/name} | https://api.github.com/repos/facebook/react/issues/24587/comments | https://api.github.com/repos/facebook/react/issues/24587/events | https://github.com/facebook/react/pull/24587 | 1,242,923,212 | PR_kwDOAJy2Ks44LdMB | 24,587 | Devtools typos and grammar | {'login': 'alexandrutasica', 'id': 350658, 'node_id': 'MDQ6VXNlcjM1MDY1OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/350658?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alexandrutasica', 'html_url': 'https://github.com/alexandrutasica', 'followers_url': 'https://api.github.com/users/ale... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6e2f38f3a4d58f11bbe86ca6f938c27767366967...773ac0f0dbfc0b281e85ee85e46ac8f409680b54\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-20 10:06:57 | 2022-10-03 14:12:39 | 2022-10-03 14:12:39 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24587', 'html_url': 'https://github.com/facebook/react/pull/24587', 'diff_url': 'https://github.com/facebook/react/pull/24587.diff', 'patch_url': 'https://github.com/facebook/react/pull/24587.patch', 'merged_at': None} | Fixed some typos and grammar in the devtools package
Tested the changes with the PR steps one by one.
Filled the CLA. | {'url': 'https://api.github.com/repos/facebook/react/issues/24587/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24587/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24586 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24586/labels{/name} | https://api.github.com/repos/facebook/react/issues/24586/comments | https://api.github.com/repos/facebook/react/issues/24586/events | https://github.com/facebook/react/pull/24586 | 1,242,776,082 | PR_kwDOAJy2Ks44K-T6 | 24,586 | Tests assertion message fix | {'login': 'alexandrutasica', 'id': 350658, 'node_id': 'MDQ6VXNlcjM1MDY1OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/350658?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alexandrutasica', 'html_url': 'https://github.com/alexandrutasica', 'followers_url': 'https://api.github.com/users/ale... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6e2f38f3a4d58f11bbe86ca6f938c27767366967...3b11215f95fbba48b17ef757b1b8676fce50f19f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-20 07:59:23 | 2022-05-20 08:37:04 | 2022-05-20 08:36:18 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/24586', 'html_url': 'https://github.com/facebook/react/pull/24586', 'diff_url': 'https://github.com/facebook/react/pull/24586.diff', 'patch_url': 'https://github.com/facebook/react/pull/24586.patch', 'merged_at': None} | Some tests had typos in naming that could confuse developers when trying to copy them.
Tested the changes with the PR steps one by one.
Filled the CLA. | {'url': 'https://api.github.com/repos/facebook/react/issues/24586/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24586/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24585 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24585/labels{/name} | https://api.github.com/repos/facebook/react/issues/24585/comments | https://api.github.com/repos/facebook/react/issues/24585/events | https://github.com/facebook/react/pull/24585 | 1,242,459,154 | PR_kwDOAJy2Ks44J9az | 24,585 | Track nearest Suspense handler on stack | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a7b192e0f16a5a585796c78cfdb688845d7710a5...396b786877996b7fc2025e2a7f970d5f6acc26ca\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-20 00:34:28 | 2022-06-30 14:03:30 | 2022-06-30 14:03:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24585', 'html_url': 'https://github.com/facebook/react/pull/24585', 'diff_url': 'https://github.com/facebook/react/pull/24585.diff', 'patch_url': 'https://github.com/facebook/react/pull/24585.patch', 'merged_at': datetime.datetime(2022, 6, 30, 14, 3, 29)} | Instead of traversing the return path whenever something suspends to find the nearest Suspense boundary, we can push the Suspense boundary onto the stack before entering its subtree. This doesn't affect the overall algorithm that much, but because we already do all the same logic in the begin phase, we can save some re... | {'url': 'https://api.github.com/repos/facebook/react/issues/24585/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24585/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24584 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24584/labels{/name} | https://api.github.com/repos/facebook/react/issues/24584/comments | https://api.github.com/repos/facebook/react/issues/24584/events | https://github.com/facebook/react/pull/24584 | 1,241,908,117 | PR_kwDOAJy2Ks44IJNS | 24,584 | [DevTools] Remove `string.replaceAll` Call in `@reactVersion` Pragma Functions | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 835d9c9f4724b71b429a6b7aaced6da1448e7fb8...80ea95cd76b5294dc1a67ebfcfa43fcc313ea862\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-19 14:50:41 | 2022-05-19 16:59:36 | 2022-05-19 16:59:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24584', 'html_url': 'https://github.com/facebook/react/pull/24584', 'diff_url': 'https://github.com/facebook/react/pull/24584.diff', 'patch_url': 'https://github.com/facebook/react/pull/24584.patch', 'merged_at': datetime.datetime(2022, 5, 19, 16, 59, 36)} | `string.replaceAll` doesn't exist in our CircleCI Docker environment. We also don't need it in this case because `semver.satisfies` allows for whitespace when specifying a range. This PR removes the unnecessary call. | {'url': 'https://api.github.com/repos/facebook/react/issues/24584/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24584/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24583 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24583/labels{/name} | https://api.github.com/repos/facebook/react/issues/24583/comments | https://api.github.com/repos/facebook/react/issues/24583/events | https://github.com/facebook/react/pull/24583 | 1,241,890,401 | PR_kwDOAJy2Ks44IFkY | 24,583 | [DevTools] Use Inline Snapshots for `storeStressTestSync` | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2022-05-19 14:39:40 | 2022-05-19 14:52:31 | 2022-05-19 14:52:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24583', 'html_url': 'https://github.com/facebook/react/pull/24583', 'diff_url': 'https://github.com/facebook/react/pull/24583.diff', 'patch_url': 'https://github.com/facebook/react/pull/24583.patch', 'merged_at': datetime.datetime(2022, 5, 19, 14, 52, 30)} | Change `storeStressTestSync` to use inline snapshots instead of a snapshot file. We want to do this because some tests are gated and not called in regression tests, and if snapshot tests are not called when there is a corresponding `.snap` file, that test will fail.
Arguably inline snapshots are a better pattern an... | {'url': 'https://api.github.com/repos/facebook/react/issues/24583/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24583/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24582 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24582/labels{/name} | https://api.github.com/repos/facebook/react/issues/24582/comments | https://api.github.com/repos/facebook/react/issues/24582/events | https://github.com/facebook/react/pull/24582 | 1,241,518,583 | PR_kwDOAJy2Ks44G3DF | 24,582 | [devtools-ish] Release script missing node-fetch@2 dependency | {'login': 'blakef', 'id': 49578, 'node_id': 'MDQ6VXNlcjQ5NTc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/49578?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/blakef', 'html_url': 'https://github.com/blakef', 'followers_url': 'https://api.github.com/users/blakef/followers', 'following_url': ... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 357a61324f8d746a7f745dfc57009ba952c7d640...94bc4deebffd4899549238eabf75336dfccfc718\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-19 09:49:02 | 2024-04-17 14:13:50 | 2024-04-17 14:13:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24582', 'html_url': 'https://github.com/facebook/react/pull/24582', 'diff_url': 'https://github.com/facebook/react/pull/24582.diff', 'patch_url': 'https://github.com/facebook/react/pull/24582.patch', 'merged_at': None} | Explicitly add node-fetch as a dependency to run `download-experimental-build.js`
> Accidentally closed out #24571, by nuking my fork. This is identical.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others... | {'url': 'https://api.github.com/repos/facebook/react/issues/24582/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24582/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24581 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24581/labels{/name} | https://api.github.com/repos/facebook/react/issues/24581/comments | https://api.github.com/repos/facebook/react/issues/24581/events | https://github.com/facebook/react/issues/24581 | 1,241,275,559 | I_kwDOAJy2Ks5J_Fyn | 24,581 | [DevTools Bug] Cannot add node "1" because a node with that id is already in the Store. | {'login': 'TrieuLee', 'id': 83015709, 'node_id': 'MDQ6VXNlcjgzMDE1NzA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/83015709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TrieuLee', 'html_url': 'https://github.com/TrieuLee', 'followers_url': 'https://api.github.com/users/TrieuLee/followers',... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'TrieuLee', 'id': 83015709.0, 'node_id': 'MDQ6VXNlcjgzMDE1NzA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/83015709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TrieuLee', 'html_url': 'https://github.com/TrieuLee', 'followers_url': 'https://api.github.com/users/TrieuLee/followers... | [{'login': 'TrieuLee', 'id': 83015709, 'node_id': 'MDQ6VXNlcjgzMDE1NzA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/83015709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TrieuLee', 'html_url': 'https://github.com/TrieuLee', 'followers_url': 'https://api.github.com/users/TrieuLee/followers'... | null | [
"@TrieuLee: We're sorry you've seen this error. ❤️\n\nUnfortunately the URL you provided (\"localhost\") is not publicly accessible. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on... | 2022-05-19 06:17:14 | 2022-05-19 06:17:36 | 2022-05-19 06:17:36 | NONE | null | null | null | ### Website or app
http://localhost:3000/typeofFood
### Repro steps
.
### How often does this bug happen?
Often
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.24.6-ca7a38ae4
### Error message (automated)
Cannot add node "1" because a node with that id is already... | {'url': 'https://api.github.com/repos/facebook/react/issues/24581/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24581/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24580 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24580/labels{/name} | https://api.github.com/repos/facebook/react/issues/24580/comments | https://api.github.com/repos/facebook/react/issues/24580/events | https://github.com/facebook/react/pull/24580 | 1,240,429,261 | PR_kwDOAJy2Ks44DL2e | 24,580 | Add support for rendering BigInt | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4cd788aef03d8f32c03e4dac4d0cf28b220cedfb...a87598f4b60bd29656af60f2f9cc7752e0e64f33\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 19:34:21 | 2024-02-26 18:29:35 | 2024-02-26 18:18:50 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24580', 'html_url': 'https://github.com/facebook/react/pull/24580', 'diff_url': 'https://github.com/facebook/react/pull/24580.diff', 'patch_url': 'https://github.com/facebook/react/pull/24580.patch', 'merged_at': datetime.datetime(2024, 2, 26, 18, 18, 50)} | ## Summary
Closes https://github.com/facebook/react/issues/20492
Adds support for rendering BigInt behind `enableBigIntSupport` (experimental only). This includes support for values of input, option and textarea as BigInt for consistency. Otherwise `<div>{5n}</div>` would work but not `<option>{5n}</option>`.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24580/reactions', 'total_count': 6, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24580/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24579 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24579/labels{/name} | https://api.github.com/repos/facebook/react/issues/24579/comments | https://api.github.com/repos/facebook/react/issues/24579/events | https://github.com/facebook/react/pull/24579 | 1,240,274,390 | PR_kwDOAJy2Ks44CuV3 | 24,579 | [DevTools][Draft] Circle Ci Test | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 835d9c9f4724b71b429a6b7aaced6da1448e7fb8...3a23a757944b5c6732e1b5acfebcb2633bcc953f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 17:27:47 | 2022-06-01 00:18:20 | 2022-06-01 00:18:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24579', 'html_url': 'https://github.com/facebook/react/pull/24579', 'diff_url': 'https://github.com/facebook/react/pull/24579.diff', 'patch_url': 'https://github.com/facebook/react/pull/24579.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/24579/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24579/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24578 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24578/labels{/name} | https://api.github.com/repos/facebook/react/issues/24578/comments | https://api.github.com/repos/facebook/react/issues/24578/events | https://github.com/facebook/react/issues/24578 | 1,240,162,055 | I_kwDOAJy2Ks5J618H | 24,578 | Bug [Flight]: Hydration fails when suspended components introduce new client components | {'login': 'jplhomer', 'id': 848147, 'node_id': 'MDQ6VXNlcjg0ODE0Nw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/848147?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jplhomer', 'html_url': 'https://github.com/jplhomer', 'followers_url': 'https://api.github.com/users/jplhomer/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi @gnoff or @sebmarkbage — curious if either of you could give this a couple minutes of attention when you have a moment, as you can likely determine pretty quickly whether this is a problem in Hydrogen or in React. We'd really appreciate it ❤️ ",
"@jplhomer will check this out today",
"Just a quick update, I... | 2022-05-18 15:47:42 | 2022-05-25 21:12:03 | 2022-05-25 21:12:02 | CONTRIBUTOR | null | null | null | When hydrating a React Server Components (Hydrogen) app, components which suspend on the server and _then_ introduce a new client components in their resolved body cause hydration to fail in the client.
```
S1:"react.suspense"
M2:{"id":"ShopifyProvider-LTE5NjIzODc4MTk","name":"ShopifyProviderClient"}
M3:{"id":"B... | {'url': 'https://api.github.com/repos/facebook/react/issues/24578/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24578/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24577 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24577/labels{/name} | https://api.github.com/repos/facebook/react/issues/24577/comments | https://api.github.com/repos/facebook/react/issues/24577/events | https://github.com/facebook/react/pull/24577 | 1,240,137,753 | PR_kwDOAJy2Ks44CSVt | 24,577 | Add option for source maps when running tests | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a412d787e997da9e47e47886cf7a8fed2ccb6bee...268bbe12f584e61d11c77fa3b20774f9871a2f1e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 15:27:59 | 2022-05-18 17:48:21 | 2022-05-18 17:48:21 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24577', 'html_url': 'https://github.com/facebook/react/pull/24577', 'diff_url': 'https://github.com/facebook/react/pull/24577.diff', 'patch_url': 'https://github.com/facebook/react/pull/24577.patch', 'merged_at': datetime.datetime(2022, 5, 18, 17, 48, 21)} | I added a `--sourceMaps` option to our test command that enables inline source maps. I've kept it disabled by default, since it makes the tests run slower. But it's super useful when attaching to a debugger. | {'url': 'https://api.github.com/repos/facebook/react/issues/24577/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24577/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24576 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24576/labels{/name} | https://api.github.com/repos/facebook/react/issues/24576/comments | https://api.github.com/repos/facebook/react/issues/24576/events | https://github.com/facebook/react/pull/24576 | 1,240,123,833 | PR_kwDOAJy2Ks44CPWd | 24,576 | [DevTools] Add React Version Pragma to Tests | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2022-05-18 15:16:31 | 2022-05-18 16:37:17 | 2022-05-18 16:37:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24576', 'html_url': 'https://github.com/facebook/react/pull/24576', 'diff_url': 'https://github.com/facebook/react/pull/24576.diff', 'patch_url': 'https://github.com/facebook/react/pull/24576.patch', 'merged_at': datetime.datetime(2022, 5, 18, 16, 37, 17)} | This PR adds the `reactVersion` pragma to tests.
Tests without the `reactVersion` pragma won't be run if the `reactVersion` pragma isn't specified.
Tested each React version manually with the pragma to make sure the tests pass | {'url': 'https://api.github.com/repos/facebook/react/issues/24576/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24576/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24575 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24575/labels{/name} | https://api.github.com/repos/facebook/react/issues/24575/comments | https://api.github.com/repos/facebook/react/issues/24575/events | https://github.com/facebook/react/pull/24575 | 1,240,097,681 | PR_kwDOAJy2Ks44CKOA | 24,575 | Remove dependency on build artifacts mirror | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 357a61324f8d746a7f745dfc57009ba952c7d640...615efd535fb4a84883aef028403752ab039ad7c5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 14:58:45 | 2022-05-18 15:13:19 | 2022-05-18 15:13:19 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24575', 'html_url': 'https://github.com/facebook/react/pull/24575', 'diff_url': 'https://github.com/facebook/react/pull/24575.diff', 'patch_url': 'https://github.com/facebook/react/pull/24575.patch', 'merged_at': datetime.datetime(2022, 5, 18, 15, 13, 19)} | This reverts #24106.
There was a regression in CircleCI's artifacts API recently where you could no longer access artifacts without an authorization token. This broke our size reporting CI job because we can't use an authorization token on external PRs without potentially leaking it. As a temporary workaround, I cha... | {'url': 'https://api.github.com/repos/facebook/react/issues/24575/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24575/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24573 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24573/labels{/name} | https://api.github.com/repos/facebook/react/issues/24573/comments | https://api.github.com/repos/facebook/react/issues/24573/events | https://github.com/facebook/react/pull/24573 | 1,239,891,540 | PR_kwDOAJy2Ks44Bd2b | 24,573 | Handle Github rate-limiting response in download-experimental-build.js | {'login': 'blakef', 'id': 49578, 'node_id': 'MDQ6VXNlcjQ5NTc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/49578?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/blakef', 'html_url': 'https://github.com/blakef', 'followers_url': 'https://api.github.com/users/blakef/followers', 'following_url': ... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 357a61324f8d746a7f745dfc57009ba952c7d640...f5611e96600d451b74158e32687a9ae368381120\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 12:35:18 | 2022-05-18 23:12:34 | 2022-05-18 19:14:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24573', 'html_url': 'https://github.com/facebook/react/pull/24573', 'diff_url': 'https://github.com/facebook/react/pull/24573.diff', 'patch_url': 'https://github.com/facebook/react/pull/24573.patch', 'merged_at': datetime.datetime(2022, 5, 18, 19, 14, 27)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24573/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24573/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24572 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24572/labels{/name} | https://api.github.com/repos/facebook/react/issues/24572/comments | https://api.github.com/repos/facebook/react/issues/24572/events | https://github.com/facebook/react/issues/24572 | 1,239,878,637 | I_kwDOAJy2Ks5J5wvt | 24,572 | Bug: absent error message in eslint while using hooks in callbacks | {'login': 'gulevskii', 'id': 83293758, 'node_id': 'MDQ6VXNlcjgzMjkzNzU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/83293758?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gulevskii', 'html_url': 'https://github.com/gulevskii', 'followers_url': 'https://api.github.com/users/gulevskii/followe... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"In the first example you tried to **call/execute** the hook inside a callback and react rightly pointed out the error.\r\nIn the second example you **did not call/execute** the hook but instead **passed its value** to be used by `.map()` function so react doesn't complain there.\r\n\r\nYou can also check the `esli... | 2022-05-18 12:24:21 | 2022-05-18 18:10:34 | 2022-05-18 18:10:26 | NONE | null | null | null | When i'm using react hook inside iteration (first example), i'm getting an error message:
`React Hook "useCustomHook" cannot be called inside a callback. React Hooks must be called in a React function component or a custom React Hook function.eslint[react-hooks/rules-of-hooks](https://reactjs.org/docs/hooks-rules.htm... | {'url': 'https://api.github.com/repos/facebook/react/issues/24572/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24572/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24571 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24571/labels{/name} | https://api.github.com/repos/facebook/react/issues/24571/comments | https://api.github.com/repos/facebook/react/issues/24571/events | https://github.com/facebook/react/pull/24571 | 1,239,869,174 | PR_kwDOAJy2Ks44BZAx | 24,571 | [devtools-ish] Release script missing node-fetch@2 dependency | {'login': 'blakef', 'id': 49578, 'node_id': 'MDQ6VXNlcjQ5NTc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/49578?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/blakef', 'html_url': 'https://github.com/blakef', 'followers_url': 'https://api.github.com/users/blakef/followers', 'following_url': ... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 357a61324f8d746a7f745dfc57009ba952c7d640...94bc4deebffd4899549238eabf75336dfccfc718\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 12:16:40 | 2022-05-18 23:14:58 | 2022-05-18 23:12:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24571', 'html_url': 'https://github.com/facebook/react/pull/24571', 'diff_url': 'https://github.com/facebook/react/pull/24571.diff', 'patch_url': 'https://github.com/facebook/react/pull/24571.patch', 'merged_at': None} | Explicitly add node-fetch as a dependency to run `download-experimental-build.js`
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Be... | {'url': 'https://api.github.com/repos/facebook/react/issues/24571/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24571/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24570 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24570/labels{/name} | https://api.github.com/repos/facebook/react/issues/24570/comments | https://api.github.com/repos/facebook/react/issues/24570/events | https://github.com/facebook/react/issues/24570 | 1,239,740,299 | I_kwDOAJy2Ks5J5O-L | 24,570 | Bug: Automatic batching not working unless I remove React.StrictMode | {'login': 'martinnajjar12', 'id': 56537131, 'node_id': 'MDQ6VXNlcjU2NTM3MTMx', 'avatar_url': 'https://avatars.githubusercontent.com/u/56537131?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/martinnajjar12', 'html_url': 'https://github.com/martinnajjar12', 'followers_url': 'https://api.github.com/users/ma... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Batching is still happening, if you update your `console.log` call to also log out `clicked` and `count` you'll notice that they are both the new expected values after clicking the button, e.g.:\r\n\r\n```js\r\nconsole.log('Rendered!', { clicked, count });\r\n// logs: 'Rendered! { clicked: true, count: 1 } twice\r... | 2022-05-18 10:18:23 | 2022-05-18 14:01:04 | 2022-05-18 14:01:04 | NONE | null | null | null | Automatic batching is not working when the React.StrictMode component is there. If you remove it, Automatic batching will work as expected.
Even when not using any asynchronous event the component is still being re-rendered twice instead of only once.
React version: 18.1.0
## Steps To Reproduce
1. Create a ne... | {'url': 'https://api.github.com/repos/facebook/react/issues/24570/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24570/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24569 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24569/labels{/name} | https://api.github.com/repos/facebook/react/issues/24569/comments | https://api.github.com/repos/facebook/react/issues/24569/events | https://github.com/facebook/react/pull/24569 | 1,239,374,604 | PR_kwDOAJy2Ks43_wHd | 24,569 | Improve the performance of `performance`. | {'login': 'zhangenming', 'id': 21235555, 'node_id': 'MDQ6VXNlcjIxMjM1NTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/21235555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhangenming', 'html_url': 'https://github.com/zhangenming', 'followers_url': 'https://api.github.com/users/zhangenming... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 357a61324f8d746a7f745dfc57009ba952c7d640...40e9162c191a243782c9d825c2d698be0319bc51\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 03:13:48 | 2024-04-11 00:11:49 | null | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24569', 'html_url': 'https://github.com/facebook/react/pull/24569', 'diff_url': 'https://github.com/facebook/react/pull/24569.diff', 'patch_url': 'https://github.com/facebook/react/pull/24569.patch', 'merged_at': None} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. For... | {'url': 'https://api.github.com/repos/facebook/react/issues/24569/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24569/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24568 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24568/labels{/name} | https://api.github.com/repos/facebook/react/issues/24568/comments | https://api.github.com/repos/facebook/react/issues/24568/events | https://github.com/facebook/react/pull/24568 | 1,239,342,507 | PR_kwDOAJy2Ks43_peA | 24,568 | . | {'login': 'zhangenming', 'id': 21235555, 'node_id': 'MDQ6VXNlcjIxMjM1NTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/21235555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhangenming', 'html_url': 'https://github.com/zhangenming', 'followers_url': 'https://api.github.com/users/zhangenming... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 357a61324f8d746a7f745dfc57009ba952c7d640...1373c89bc64df9d1150d557beedb990dc40cced0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-18 02:11:14 | 2022-05-18 02:44:14 | 2022-05-18 02:31:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24568', 'html_url': 'https://github.com/facebook/react/pull/24568', 'diff_url': 'https://github.com/facebook/react/pull/24568.diff', 'patch_url': 'https://github.com/facebook/react/pull/24568.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24568/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24568/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24567 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24567/labels{/name} | https://api.github.com/repos/facebook/react/issues/24567/comments | https://api.github.com/repos/facebook/react/issues/24567/events | https://github.com/facebook/react/issues/24567 | 1,239,282,877 | I_kwDOAJy2Ks5J3fS9 | 24,567 | Bug: Component returning string causes hydration mismatch | {'login': 'subhero24', 'id': 1171150, 'node_id': 'MDQ6VXNlcjExNzExNTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1171150?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/subhero24', 'html_url': 'https://github.com/subhero24', 'followers_url': 'https://api.github.com/users/subhero24/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"possibly related to this hydration issue? https://github.com/facebook/react/issues/24578",
"Can you please create a minimal reproducing case? Thanks.",
"Just a reminder we'll need a reproducing case. Otherwise I'll close this. \r\n",
"I failed to create a minimal reproducing case where the problem also happe... | 2022-05-18 00:14:40 | 2022-05-31 23:13:16 | 2022-05-31 23:13:16 | NONE | null | null | null | I have a component like this:
```javascript
function Component() {
let string = useSuspendingHook()
return string
}
```
On the server I render the component with renderToPipeableStream. When hydrating the component I get a `Hydration failed because the initial UI does not match what was rendered on... | {'url': 'https://api.github.com/repos/facebook/react/issues/24567/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24567/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24565 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24565/labels{/name} | https://api.github.com/repos/facebook/react/issues/24565/comments | https://api.github.com/repos/facebook/react/issues/24565/events | https://github.com/facebook/react/issues/24565 | 1,237,156,196 | I_kwDOAJy2Ks5JvYFk | 24,565 | Bug: React router is stop displaying/ Not properly displaying the component | {'login': 'MustkimKhatik', 'id': 83959074, 'node_id': 'MDQ6VXNlcjgzOTU5MDc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/83959074?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MustkimKhatik', 'html_url': 'https://github.com/MustkimKhatik', 'followers_url': 'https://api.github.com/users/Mustk... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2022-05-16 13:23:45 | 2022-05-16 13:24:48 | 2022-05-16 13:24:48 | NONE | null | null | null | <!--
I was trying to display the different component as we do in react-router-dom but I got to find out it stopped displaying all the components that are inside <BrowserRouter> <Routes> <Route> 'any component' </Route> </Routes> </BrowserRouter>
-->
React version:
## Steps To Reproduce
1.
2.
<!--
code... | {'url': 'https://api.github.com/repos/facebook/react/issues/24565/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24565/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24564 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24564/labels{/name} | https://api.github.com/repos/facebook/react/issues/24564/comments | https://api.github.com/repos/facebook/react/issues/24564/events | https://github.com/facebook/react/issues/24564 | 1,237,077,879 | I_kwDOAJy2Ks5JvE93 | 24,564 | Bug: useEffect is called before custom font is loaded | {'login': 'Mikilll94', 'id': 17653648, 'node_id': 'MDQ6VXNlcjE3NjUzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/17653648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Mikilll94', 'html_url': 'https://github.com/Mikilll94', 'followers_url': 'https://api.github.com/users/Mikilll94/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I'm also facing this issue. We can bypass this by `document.fonts.ready` by including it `useEffect() `\r\n```\r\ndocument.fonts.ready.then(()=>{\r\n // Your useEffect code\r\n });\r\n```",
"> I'm also facing this issue. We can bypass this by `document.fonts.ready` by including it `useEffect() `\r\n> \r\... | 2022-05-16 12:24:01 | 2022-05-23 17:51:12 | 2022-05-23 17:51:12 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.2
## Steps To Reproduce
1. Open this project and run
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24564/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24564/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24563 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24563/labels{/name} | https://api.github.com/repos/facebook/react/issues/24563/comments | https://api.github.com/repos/facebook/react/issues/24563/events | https://github.com/facebook/react/issues/24563 | 1,236,970,794 | I_kwDOAJy2Ks5Juq0q | 24,563 | Bug: Browser-based handling of recoverable errors is to strict - use console instead of the reportError API | {'login': 'gurkerl83', 'id': 301689, 'node_id': 'MDQ6VXNlcjMwMTY4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/301689?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gurkerl83', 'html_url': 'https://github.com/gurkerl83', 'followers_url': 'https://api.github.com/users/gurkerl83/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-05-16 10:51:00 | 2024-04-17 14:13:51 | 2024-04-17 14:13:50 | NONE | null | null | null | React handles recoverable errors in onRecoverableError. Either a custom function is passed to hydrateRoot; otherwise React's default implementation is used, which uses the browser's **reportError** function. **Errors that are recoverable in isolation are always reported to the user in a modal-style error dialogue, and ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24563/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24563/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24562 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24562/labels{/name} | https://api.github.com/repos/facebook/react/issues/24562/comments | https://api.github.com/repos/facebook/react/issues/24562/events | https://github.com/facebook/react/issues/24562 | 1,236,544,253 | I_kwDOAJy2Ks5JtCr9 | 24,562 | Bug: React-v18版本useEffect的问题。 | {'login': 'ZhongYanZhiShi', 'id': 74604296, 'node_id': 'MDQ6VXNlcjc0NjA0Mjk2', 'avatar_url': 'https://avatars.githubusercontent.com/u/74604296?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ZhongYanZhiShi', 'html_url': 'https://github.com/ZhongYanZhiShi', 'followers_url': 'https://api.github.com/users/Zh... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"查看了[官方更新文档](https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-strict-mode)，\r\n说是严格模式会挂载一次和重载一次，这个导致`useEffect`会输出2次`console`。\r\n\r\n> To help surface these issues, React 18 introduces a new development-only check to Strict Mode. This new check will automatically unmount and remount every... | 2022-05-16 02:46:58 | 2022-05-16 03:25:20 | 2022-05-16 03:25:20 | NONE | null | null | null | ## index.js
### test1
```
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';
ReactDOM.render(
<React.StrictMode>
<App />
</React.StrictMode>,
document.getElementById('root')
);
```
### test2
```
import React from 'react';
import ReactDOM from 'react-dom/c... | {'url': 'https://api.github.com/repos/facebook/react/issues/24562/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24562/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24561 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24561/labels{/name} | https://api.github.com/repos/facebook/react/issues/24561/comments | https://api.github.com/repos/facebook/react/issues/24561/events | https://github.com/facebook/react/pull/24561 | 1,236,435,201 | PR_kwDOAJy2Ks4314E3 | 24,561 | Fixed punctuation in scripts/release/README.md | {'login': 'ShadowwLol', 'id': 57680176, 'node_id': 'MDQ6VXNlcjU3NjgwMTc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/57680176?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ShadowwLol', 'html_url': 'https://github.com/ShadowwLol', 'followers_url': 'https://api.github.com/users/ShadowwLol/fol... | [] | closed | false | null | [] | null | [
"Hi @ShadowwLol! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2022-05-15 22:10:53 | 2022-06-08 16:04:46 | 2022-06-08 16:04:46 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24561', 'html_url': 'https://github.com/facebook/react/pull/24561', 'diff_url': 'https://github.com/facebook/react/pull/24561.diff', 'patch_url': 'https://github.com/facebook/react/pull/24561.patch', 'merged_at': None} | ඞ
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24561/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24561/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24560 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24560/labels{/name} | https://api.github.com/repos/facebook/react/issues/24560/comments | https://api.github.com/repos/facebook/react/issues/24560/events | https://github.com/facebook/react/issues/24560 | 1,236,176,597 | I_kwDOAJy2Ks5Jro7V | 24,560 | Bug: When hydrate <Suspense>, it shows loading forever. | {'login': 'nguyenvanthanh97', 'id': 38460321, 'node_id': 'MDQ6VXNlcjM4NDYwMzIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/38460321?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nguyenvanthanh97', 'html_url': 'https://github.com/nguyenvanthanh97', 'followers_url': 'https://api.github.com/us... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"I'm not sure where the hardcoded content in `public/index.html` comes from. When I use `renderToString` I get slightly different content (`<div><!--$!-->Loading<!--/$--></div>`) which produces a recoverable error: https://codesandbox.io/s/hanging-hydrateroot-ou0i4m. But that is expected behavior (see https://githu... | 2022-05-15 03:32:07 | 2023-03-13 11:25:04 | null | NONE | null | null | null | After calling `hydrateRoot`, the import() function was not called. It keeps showing loading.
React version: 18.1.0
Link to code example: https://codesandbox.io/embed/gracious-lederberg-nomtf0
(For mocking server side rendering, I write content in `public/index.html`)
## The current behavior
Always showing lo... | {'url': 'https://api.github.com/repos/facebook/react/issues/24560/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24560/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/24559 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24559/labels{/name} | https://api.github.com/repos/facebook/react/issues/24559/comments | https://api.github.com/repos/facebook/react/issues/24559/events | https://github.com/facebook/react/issues/24559 | 1,236,036,627 | I_kwDOAJy2Ks5JrGwT | 24,559 | [DevTools Bug] Cannot add node "1" because a node with that id is already in the Store. | {'login': 'danbart909', 'id': 53535966, 'node_id': 'MDQ6VXNlcjUzNTM1OTY2', 'avatar_url': 'https://avatars.githubusercontent.com/u/53535966?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/danbart909', 'html_url': 'https://github.com/danbart909', 'followers_url': 'https://api.github.com/users/danbart909/fol... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"@danbart909: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code e... | 2022-05-14 15:57:43 | 2022-05-16 13:33:07 | 2022-05-14 21:35:24 | NONE | null | null | null | ### Website or app
[expo init](https://codesandbox.io/s/new)
### Repro steps
All you have to do is use 'expo init' or 'npx create-react-native-app' and make a fresh app with a blank template. When I open it with 'expo start' or 'npm start' I get this message every time in the debugger.
When I press the 'dis... | {'url': 'https://api.github.com/repos/facebook/react/issues/24559/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24559/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24558 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24558/labels{/name} | https://api.github.com/repos/facebook/react/issues/24558/comments | https://api.github.com/repos/facebook/react/issues/24558/events | https://github.com/facebook/react/issues/24558 | 1,235,966,167 | I_kwDOAJy2Ks5Jq1jX | 24,558 | [Recomendation/Discussion]: Hook-based Context API | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | open | false | null | [] | null | [
"Here's how Vue [`provide()`](https://vuejs.org/guide/components/provide-inject.html) works.",
"IIR the main concern about an approach like this is that it would make hooks less composable. Right now, a context's value is determined by the nearest ancestor Provider in the tree. If there was a way to provide a val... | 2022-05-14 12:48:56 | 2022-05-17 17:50:05 | null | NONE | null | null | null | I would like to say that I'm impressed with how React hooks have revolutionized the React ecosystem, and the Context API. However, I see some major inconsistencies between how the context is read from, and how it is provided. Maybe we we could use a `useProvider(Context, ()=>expr, [deps, ...])` kind of hook (similar to... | {'url': 'https://api.github.com/repos/facebook/react/issues/24558/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24558/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/24557 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24557/labels{/name} | https://api.github.com/repos/facebook/react/issues/24557/comments | https://api.github.com/repos/facebook/react/issues/24557/events | https://github.com/facebook/react/pull/24557 | 1,235,918,745 | PR_kwDOAJy2Ks430bzq | 24,557 | build: add exports field for useSES | {'login': 'huozhi', 'id': 4800338, 'node_id': 'MDQ6VXNlcjQ4MDAzMzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4800338?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huozhi', 'html_url': 'https://github.com/huozhi', 'followers_url': 'https://api.github.com/users/huozhi/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4c03bb6ed01a448185d9a1554229208a9480560d...bc314f610205e1f759fdaf642bc3679bed64a1be\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-14 08:50:42 | 2022-05-27 09:59:17 | 2022-05-27 09:57:37 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24557', 'html_url': 'https://github.com/facebook/react/pull/24557', 'diff_url': 'https://github.com/facebook/react/pull/24557.diff', 'patch_url': 'https://github.com/facebook/react/pull/24557.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24557/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24557/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24556 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24556/labels{/name} | https://api.github.com/repos/facebook/react/issues/24556/comments | https://api.github.com/repos/facebook/react/issues/24556/events | https://github.com/facebook/react/pull/24556 | 1,235,874,264 | PR_kwDOAJy2Ks430TRk | 24,556 | [DevTools] Add jest-cli `--reactVersion` argument | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4c03bb6ed01a448185d9a1554229208a9480560d...21f7fbcabecdf3b32040338b7106e088cd1664fd\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-14 05:11:01 | 2022-05-16 15:30:43 | 2022-05-16 15:30:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24556', 'html_url': 'https://github.com/facebook/react/pull/24556', 'diff_url': 'https://github.com/facebook/react/pull/24556.diff', 'patch_url': 'https://github.com/facebook/react/pull/24556.patch', 'merged_at': datetime.datetime(2022, 5, 16, 15, 30, 43)} | Add `--reactVersion` argument. This argument is only used in DevTools. When this is specified, run only the tests that have the `// @reactVersion` pragma that satisfies the semver version range. Otherwise, run tests as normal | {'url': 'https://api.github.com/repos/facebook/react/issues/24556/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24556/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24555 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24555/labels{/name} | https://api.github.com/repos/facebook/react/issues/24555/comments | https://api.github.com/repos/facebook/react/issues/24555/events | https://github.com/facebook/react/pull/24555 | 1,235,767,032 | PR_kwDOAJy2Ks43z9jZ | 24,555 | [DevTools] ignore tests without reactVersion pragma if REACT_VERSION specified | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2c8a1452b82b9ec5ebfa3f370b31fda19610ae92...51ca7e969aa0a7128f9ec6142a790169290a720d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-13 22:34:02 | 2022-05-14 04:54:51 | 2022-05-14 04:54:50 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24555', 'html_url': 'https://github.com/facebook/react/pull/24555', 'diff_url': 'https://github.com/facebook/react/pull/24555.diff', 'patch_url': 'https://github.com/facebook/react/pull/24555.patch', 'merged_at': datetime.datetime(2022, 5, 14, 4, 54, 50)} | In DevTools tests, if the REACT_VERSION specified, we know this is a regression test (testing older React Versions). Because a lot of tests test the DevTools front end and we don't want to run them in the regression test scenario, we decided to only run tests that have the `// @reactVersion pragma` defined.
Because ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24555/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24555/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24554 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24554/labels{/name} | https://api.github.com/repos/facebook/react/issues/24554/comments | https://api.github.com/repos/facebook/react/issues/24554/events | https://github.com/facebook/react/pull/24554 | 1,235,484,695 | PR_kwDOAJy2Ks43zFxn | 24,554 | [DevTools] Fix formatWithStyles not styling the results if the first argument is an object + Added unit tests | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Let's create separate PRs for the reconciler / react-dom changes? ",
"these aren't intentional changes, looks like just needs a rebase",
"it looks like the commit accidentally got amended into my previous commit so you'll probably want to reset against main and then commit again"
] | 2022-05-13 17:06:41 | 2022-05-13 22:34:34 | 2022-05-13 22:34:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24554', 'html_url': 'https://github.com/facebook/react/pull/24554', 'diff_url': 'https://github.com/facebook/react/pull/24554.diff', 'patch_url': 'https://github.com/facebook/react/pull/24554.patch', 'merged_at': datetime.datetime(2022, 5, 13, 22, 34, 34)} | `formatWithStyles` currently doesn't style the array argument if the first argument is an object. This PR fixes this and also adds unit tests. | {'url': 'https://api.github.com/repos/facebook/react/issues/24554/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24554/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24553 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24553/labels{/name} | https://api.github.com/repos/facebook/react/issues/24553/comments | https://api.github.com/repos/facebook/react/issues/24553/events | https://github.com/facebook/react/issues/24553 | 1,235,342,560 | I_kwDOAJy2Ks5JodTg | 24,553 | Bug: useEffect called twice in Strict Mode | {'login': 'ag-grid-shared', 'id': 53001062, 'node_id': 'MDQ6VXNlcjUzMDAxMDYy', 'avatar_url': 'https://avatars.githubusercontent.com/u/53001062?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ag-grid-shared', 'html_url': 'https://github.com/ag-grid-shared', 'followers_url': 'https://api.github.com/users/ag... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"> this needs to be documented as a breaking change and React 18 is not backwards compatible.\r\n\r\nJust to start with this — React 18 is a major release and is not meant to be fully backwards-compatible. Each major release has breaking changes; otherwise we wouldn't mark them as major. The change is [documented](... | 2022-05-13 14:48:01 | 2024-04-17 14:13:52 | 2024-04-17 14:13:52 | NONE | null | null | null | Since React 18, useEffect is called twice in Strict Mode when zero dependencies.
This is following on from this tweet:
https://twitter.com/dan_abramov/status/1523652274748559360
The purpose of logging this issue is not to report the problem. The purpose of this issue is to present a scenario where the new behavi... | {'url': 'https://api.github.com/repos/facebook/react/issues/24553/reactions', 'total_count': 23, '+1': 23, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24553/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24552 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24552/labels{/name} | https://api.github.com/repos/facebook/react/issues/24552/comments | https://api.github.com/repos/facebook/react/issues/24552/events | https://github.com/facebook/react/issues/24552 | 1,234,811,699 | I_kwDOAJy2Ks5Jmbsz | 24,552 | Bug: Typescript classful React Component inducing Minified React error #130 crash when using setState | {'login': 'bens-schreiber', 'id': 64621941, 'node_id': 'MDQ6VXNlcjY0NjIxOTQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/64621941?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bens-schreiber', 'html_url': 'https://github.com/bens-schreiber', 'followers_url': 'https://api.github.com/users/be... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-05-13 06:48:27 | 2024-04-17 14:13:54 | 2024-04-17 14:13:53 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0
## Steps To Reproduce
1. Create a typescript project... | {'url': 'https://api.github.com/repos/facebook/react/issues/24552/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24552/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24551 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24551/labels{/name} | https://api.github.com/repos/facebook/react/issues/24551/comments | https://api.github.com/repos/facebook/react/issues/24551/events | https://github.com/facebook/react/pull/24551 | 1,234,583,314 | PR_kwDOAJy2Ks43wG_4 | 24,551 | [Fizz] Send errors down to client | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: a2766387efe68b318b23d8c35c70b850d1e6a250...c026c268748a13b3f65f8b1e00a91568f47291ad\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-12 23:35:07 | 2023-05-07 11:36:21 | 2022-05-30 06:07:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24551', 'html_url': 'https://github.com/facebook/react/pull/24551', 'diff_url': 'https://github.com/facebook/react/pull/24551.diff', 'patch_url': 'https://github.com/facebook/react/pull/24551.patch', 'merged_at': datetime.datetime(2022, 5, 30, 6, 7, 10)} | This is a continuation of @salazarm's PR #24202
Errors are now modeled as
1) hash (prod and dev)
2) message (dev only)
3) component stack (dev onlhy)
They are sent in html if already known when flushing (e.g. flushing boundary in fallback)
They are also sent in a script in the client render instruction (e.g.... | {'url': 'https://api.github.com/repos/facebook/react/issues/24551/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24551/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24550 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24550/labels{/name} | https://api.github.com/repos/facebook/react/issues/24550/comments | https://api.github.com/repos/facebook/react/issues/24550/events | https://github.com/facebook/react/issues/24550 | 1,234,518,516 | I_kwDOAJy2Ks5JlUH0 | 24,550 | Bug: exhaustive-deps does not warn about stale ref in a cleanup function returned by arrow function | {'login': 'ybot1122', 'id': 3688288, 'node_id': 'MDQ6VXNlcjM2ODgyODg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3688288?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ybot1122', 'html_url': 'https://github.com/ybot1122', 'followers_url': 'https://api.github.com/users/ybot1122/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-05-12 21:54:41 | 2024-04-17 14:13:55 | 2024-04-17 14:13:55 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.1.0
## Steps To Reproduce
```
function Circle() {
cons... | {'url': 'https://api.github.com/repos/facebook/react/issues/24550/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24550/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24549 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24549/labels{/name} | https://api.github.com/repos/facebook/react/issues/24549/comments | https://api.github.com/repos/facebook/react/issues/24549/events | https://github.com/facebook/react/issues/24549 | 1,234,333,085 | I_kwDOAJy2Ks5Jkm2d | 24,549 | [DevTools Bug]: Chrome Devtools missing from Chrome extensions Webstore - 404 response | {'login': 'minaelee', 'id': 4936954, 'node_id': 'MDQ6VXNlcjQ5MzY5NTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4936954?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/minaelee', 'html_url': 'https://github.com/minaelee', 'followers_url': 'https://api.github.com/users/minaelee/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Edge page is also still up, only affecting Chrome Web Store it seems",
"> Edge page is also still up, only affecting Chrome Web Store it seems\r\n\r\nThank you! ",
"We took it down because we discovered a bug (#24543) in a recent version. Unfortunately un-publishing it seems to be the only way to stop the bugg... | 2022-05-12 18:21:01 | 2022-05-16 19:27:47 | 2022-05-13 13:22:44 | NONE | null | null | null | ### Website or app
https://chrome.google.com/webstore/detail/react-developer-tools/
### Repro steps
The download page for the Chrome React Devtools extension returns 404. I checked the Firefox developer tools download page and that's still up.
### How often does this bug happen?
Every time
### DevTools package (a... | {'url': 'https://api.github.com/repos/facebook/react/issues/24549/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24549/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24548 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24548/labels{/name} | https://api.github.com/repos/facebook/react/issues/24548/comments | https://api.github.com/repos/facebook/react/issues/24548/events | https://github.com/facebook/react/issues/24548 | 1,234,226,847 | I_kwDOAJy2Ks5JkM6f | 24,548 | [DevTools Bug]: console.log() crashes the app | {'login': 'kyrylolvov', 'id': 70720713, 'node_id': 'MDQ6VXNlcjcwNzIwNzEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/70720713?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kyrylolvov', 'html_url': 'https://github.com/kyrylolvov', 'followers_url': 'https://api.github.com/users/kyrylolvov/fol... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Quick solution for this issue can be found here\r\nhttps://github.com/facebook/react/issues/24543"
] | 2022-05-12 16:28:24 | 2022-05-12 16:30:30 | 2022-05-12 16:30:08 | NONE | null | null | null | ### Website or app
Local development
### Repro steps
In order to reproduce it, type `console.log(*any variable or functionality)`
If using console log for printing string, it works with not errors
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version... | {'url': 'https://api.github.com/repos/facebook/react/issues/24548/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24548/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24547 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24547/labels{/name} | https://api.github.com/repos/facebook/react/issues/24547/comments | https://api.github.com/repos/facebook/react/issues/24547/events | https://github.com/facebook/react/pull/24547 | 1,234,106,062 | PR_kwDOAJy2Ks43uhRL | 24,547 | React DevTools 4.24.5 -> 4.24.6 | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2022-05-12 14:50:51 | 2022-05-12 14:52:55 | 2022-05-12 14:52:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24547', 'html_url': 'https://github.com/facebook/react/pull/24547', 'diff_url': 'https://github.com/facebook/react/pull/24547.diff', 'patch_url': 'https://github.com/facebook/react/pull/24547.patch', 'merged_at': datetime.datetime(2022, 5, 12, 14, 52, 55)} | Preparing 4.24.6 bugfix release changelog and package JSONs. | {'url': 'https://api.github.com/repos/facebook/react/issues/24547/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24547/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24546 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24546/labels{/name} | https://api.github.com/repos/facebook/react/issues/24546/comments | https://api.github.com/repos/facebook/react/issues/24546/events | https://github.com/facebook/react/pull/24546 | 1,234,055,670 | PR_kwDOAJy2Ks43uWZh | 24,546 | [devtools] fix a bug in console.log with non-string args | {'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/follo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2022-05-12 14:17:01 | 2022-05-12 14:29:37 | 2022-05-12 14:29:37 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24546', 'html_url': 'https://github.com/facebook/react/pull/24546', 'diff_url': 'https://github.com/facebook/react/pull/24546.diff', 'patch_url': 'https://github.com/facebook/react/pull/24546.patch', 'merged_at': datetime.datetime(2022, 5, 12, 14, 29, 36)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24546/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24546/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24545 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24545/labels{/name} | https://api.github.com/repos/facebook/react/issues/24545/comments | https://api.github.com/repos/facebook/react/issues/24545/events | https://github.com/facebook/react/pull/24545 | 1,233,951,332 | PR_kwDOAJy2Ks43t_ue | 24,545 | Remove enableFlipOffscreenUnhideOrder | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 34da5aa69b0694348fee9c3cd1351ecc70cd5bb1...9db101b0f9a2f9869bbe10142bd1a08448d802c9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-12 13:01:14 | 2022-05-13 14:11:04 | 2022-05-12 16:40:17 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24545', 'html_url': 'https://github.com/facebook/react/pull/24545', 'diff_url': 'https://github.com/facebook/react/pull/24545.diff', 'patch_url': 'https://github.com/facebook/react/pull/24545.patch', 'merged_at': datetime.datetime(2022, 5, 12, 16, 40, 17)} | No reported issues with the flip | {'url': 'https://api.github.com/repos/facebook/react/issues/24545/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24545/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24543 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24543/labels{/name} | https://api.github.com/repos/facebook/react/issues/24543/comments | https://api.github.com/repos/facebook/react/issues/24543/events | https://github.com/facebook/react/issues/24543 | 1,233,742,551 | I_kwDOAJy2Ks5JiWrX | 24,543 | [DevTools Bug]: console.log crashes when I enable DevTools on Chrome | {'login': 'coolwind0202', 'id': 51913600, 'node_id': 'MDQ6VXNlcjUxOTEzNjAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/51913600?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/coolwind0202', 'html_url': 'https://github.com/coolwind0202', 'followers_url': 'https://api.github.com/users/coolwind... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'mondaychen', 'id': 1001890.0, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/fol... | [{'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/foll... | null | [
"The same error happens in my case. Basically I cant use `console.log` becasue it shows the same error. I think it is a bug. Extension was updated just yesterday.\r\n",
"Experiencing the same issue while having the React Developer Tools extension enabled. Disabling the extension prevents the error from occurring.... | 2022-05-12 09:55:13 | 2022-05-13 13:23:52 | 2022-05-12 14:29:36 | NONE | null | null | null | ### Website or app
https://github.com/coolwind0202/web/blob/23877f77e23837a007aada5be363d65290571c88/web/src/components/page/members/IndexPage/IndexPage.tsx#L27
### Repro steps
For checking whenever my project will work correctly, when I run a command `next dev`, errors which are shown below occurred.
![ima... | {'url': 'https://api.github.com/repos/facebook/react/issues/24543/reactions', 'total_count': 6, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24543/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24542 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24542/labels{/name} | https://api.github.com/repos/facebook/react/issues/24542/comments | https://api.github.com/repos/facebook/react/issues/24542/events | https://github.com/facebook/react/pull/24542 | 1,233,247,589 | PR_kwDOAJy2Ks43rs48 | 24,542 | Change copyright from Facebook, Inc to Meta Platforms, Inc | {'login': 'Yahkob', 'id': 5547203, 'node_id': 'MDQ6VXNlcjU1NDcyMDM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5547203?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Yahkob', 'html_url': 'https://github.com/Yahkob', 'followers_url': 'https://api.github.com/users/Yahkob/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"thanks, but we'll do this when our legal dept asks -- we can't make these decisions :)"
] | 2022-05-11 22:35:36 | 2022-05-12 00:48:17 | 2022-05-12 00:48:17 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24542', 'html_url': 'https://github.com/facebook/react/pull/24542', 'diff_url': 'https://github.com/facebook/react/pull/24542.diff', 'patch_url': 'https://github.com/facebook/react/pull/24542.patch', 'merged_at': None} | It feels like Facebook, Inc could still be the correct owner of React (especially since this lives under the `/facebook` project) and I'm unsure of copyright/legal guidelines here but thought it might be worth opening a PR for.
Also - the last time this file was changed it was to remove the year and it was made to ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24542/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24542/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24541 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24541/labels{/name} | https://api.github.com/repos/facebook/react/issues/24541/comments | https://api.github.com/repos/facebook/react/issues/24541/events | https://github.com/facebook/react/pull/24541 | 1,233,048,115 | PR_kwDOAJy2Ks43rCYR | 24,541 | Match Preact behavior for boolean props on custom elements | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8197c73ec334e4430d892cead14aa371f13467a9...ad479ab283ccf34f23d3a8d75ada1217ee5c9dc1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-11 18:44:09 | 2022-05-23 16:21:58 | 2022-05-20 17:10:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24541', 'html_url': 'https://github.com/facebook/react/pull/24541', 'diff_url': 'https://github.com/facebook/react/pull/24541.diff', 'patch_url': 'https://github.com/facebook/react/pull/24541.patch', 'merged_at': datetime.datetime(2022, 5, 20, 17, 10, 43)} |
## Summary
Closes https://github.com/facebook/react/issues/9230 gated behind `enableCustomElementPropertySupport` i.e. `react-dom@experimental`
Implements https://github.com/facebook/react/issues/9230#issuecomment-322007671 with the exception of
```diff
val = true;
<x-foo bool={val}></x-foo>
-// output: ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24541/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24541/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24540 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24540/labels{/name} | https://api.github.com/repos/facebook/react/issues/24540/comments | https://api.github.com/repos/facebook/react/issues/24540/events | https://github.com/facebook/react/issues/24540 | 1,232,970,018 | I_kwDOAJy2Ks5JfaEi | 24,540 | react-devtools standalone app is missing inspector (selector tool) | {'login': 'M0unir', 'id': 2924418, 'node_id': 'MDQ6VXNlcjI5MjQ0MTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2924418?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/M0unir', 'html_url': 'https://github.com/M0unir', 'followers_url': 'https://api.github.com/users/M0unir/followers', 'followin... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github... | open | false | null | [] | null | [
"Hey! Thanks so much for responding. Currently the React DevTools standalone app doesn't have the inspector/selector tool, but we're working on it!\r\n\r\nHowever, it should have the jump to source code integration. How are you setting this up? ",
"Hey! It's amazing that it is in the works as It is such an import... | 2022-05-11 17:27:07 | 2022-05-15 18:40:55 | null | NONE | null | null | null | When running react-devtools as standalone app (not as chrome extension or in react-native), The app is missing the inspector/selector tool.
It is also missing the jump to code integration with vscode. | {'url': 'https://api.github.com/repos/facebook/react/issues/24540/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24540/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/24539 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24539/labels{/name} | https://api.github.com/repos/facebook/react/issues/24539/comments | https://api.github.com/repos/facebook/react/issues/24539/events | https://github.com/facebook/react/issues/24539 | 1,232,414,863 | I_kwDOAJy2Ks5JdSiP | 24,539 | [DevTools Bug]: When inspecting with DevTools, it fails to select correct react component when there are multiple react-dom instances in the application | {'login': 'danielkutt', 'id': 75630590, 'node_id': 'MDQ6VXNlcjc1NjMwNTkw', 'avatar_url': 'https://avatars.githubusercontent.com/u/75630590?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/danielkutt', 'html_url': 'https://github.com/danielkutt', 'followers_url': 'https://api.github.com/users/danielkutt/fol... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'mondaychen', 'id': 1001890.0, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/fol... | [{'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/foll... | null | [] | 2022-05-11 10:41:10 | 2022-06-08 20:01:07 | 2022-06-08 20:01:07 | NONE | null | null | null | ### Website or app
https://codesandbox.io/s/jtiw8m
### Repro steps
When using devtools in the linked codesandbox, I am not able to select react components that are rendered by the micro-fe using the inspect tool.
Steps to reproduce:
1. Go to https://jtiw8m.csb.app/
2. Open React DevTools and click on Ins... | {'url': 'https://api.github.com/repos/facebook/react/issues/24539/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24539/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24538 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24538/labels{/name} | https://api.github.com/repos/facebook/react/issues/24538/comments | https://api.github.com/repos/facebook/react/issues/24538/events | https://github.com/facebook/react/issues/24538 | 1,232,237,963 | I_kwDOAJy2Ks5JcnWL | 24,538 | [DevTools Bug]: Component shown twice in flame graph when using React.memo | {'login': 'MTxx87', 'id': 12138301, 'node_id': 'MDQ6VXNlcjEyMTM4MzAx', 'avatar_url': 'https://avatars.githubusercontent.com/u/12138301?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MTxx87', 'html_url': 'https://github.com/MTxx87', 'followers_url': 'https://api.github.com/users/MTxx87/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'mondaychen', 'id': 1001890.0, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/fol... | [{'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/foll... | null | [
"Also seeing this issue. Same version as above (4.24.3)",
"Hi! Thank you both for reporting this issue. I can reproduce it on my end.\r\n\r\nThis is caused by an internal implementation detail with Fiber. I understand how confusing it is, and it shouldn't be necessary for you (React developers) to learn about the... | 2022-05-11 08:52:21 | 2023-03-28 15:35:12 | 2023-03-28 15:35:11 | NONE | null | null | null | ### Website or app
I cannot provide. Private.
### Versions
- React Developer Tools 4.24.3 (3/30/2022)
- "react": "^17.0.2",
- "react-dom": "^17.0.2",
### Repro steps
I am using react-devtools to profile my app.
When a component is wrapped in React.memo and a custom comparison function is provided, th... | {'url': 'https://api.github.com/repos/facebook/react/issues/24538/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24538/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24537 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24537/labels{/name} | https://api.github.com/repos/facebook/react/issues/24537/comments | https://api.github.com/repos/facebook/react/issues/24537/events | https://github.com/facebook/react/issues/24537 | 1,232,231,174 | I_kwDOAJy2Ks5JclsG | 24,537 | Bug: Use Suspense to load data,refresh for hundreds times | {'login': 'gangganghao6', 'id': 16880429, 'node_id': 'MDQ6VXNlcjE2ODgwNDI5', 'avatar_url': 'https://avatars.githubusercontent.com/u/16880429?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gangganghao6', 'html_url': 'https://github.com/gangganghao6', 'followers_url': 'https://api.github.com/users/ganggang... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Hi, I tried to reproduce the problem you described with minimal code.\r\n\r\n``` javascript\r\nimport { useState, Suspense } from \"react\";\r\nconst Reader = ({ readable }) => readable.read();\r\nclass Readable {\r\n pending = true;\r\n value = 0;\r\n promise = (async () => {\r\n const value = await Promise... | 2022-05-11 08:47:38 | 2024-04-17 14:13:58 | 2024-04-17 14:13:56 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:18.1.0
(My English is poor...)
When i use <Suspense/> to async l... | {'url': 'https://api.github.com/repos/facebook/react/issues/24537/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24537/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24536 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24536/labels{/name} | https://api.github.com/repos/facebook/react/issues/24536/comments | https://api.github.com/repos/facebook/react/issues/24536/events | https://github.com/facebook/react/issues/24536 | 1,232,196,076 | I_kwDOAJy2Ks5JcdHs | 24,536 | Bug: [Streaming] No reliable way to tell whether error is React internal error or boundary error | {'login': 'brillout', 'id': 1005638, 'node_id': 'MDQ6VXNlcjEwMDU2Mzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1005638?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/brillout', 'html_url': 'https://github.com/brillout', 'followers_url': 'https://api.github.com/users/brillout/followers', '... | [{'id': 710332294, 'node_id': 'MDU6TGFiZWw3MTAzMzIyOTQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Server%20Rendering', 'name': 'Component: Server Rendering', 'color': 'd4c5f9', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https:... | closed | false | null | [] | null | [
"We use the following hack in the meantime:\r\n - https://github.com/brillout/react-streaming/blob/dc9d319d98979723e30294c386ec02afe26d7348/src/renderToStream.ts#L161-L163\r\n - https://github.com/brillout/react-streaming/blob/dc9d319d98979723e30294c386ec02afe26d7348/src/renderToStream/createPipeWrapper.ts#L41-L43"... | 2022-05-11 08:22:02 | 2024-04-17 15:13:00 | 2024-04-17 15:13:00 | CONTRIBUTOR | null | null | null | React version: `18.1.0`
## The current behavior
The `onError()` callback of `renderToPipeableStream()` and `renderToReadableStream()` receives boundary errors as well as internal React errors (i.e. React bugs). There isn't a reliable way to tell whether the error is a boundary error or an internal React error.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24536/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24536/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24535 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24535/labels{/name} | https://api.github.com/repos/facebook/react/issues/24535/comments | https://api.github.com/repos/facebook/react/issues/24535/events | https://github.com/facebook/react/pull/24535 | 1,231,752,908 | PR_kwDOAJy2Ks43m2Lh | 24,535 | Add hook warning when going to/from 0 hooks | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 229c86af07302d40b70c41de18106f80fe89836c...b5e48aa723de84c910e6a4d610d6f836c9988512\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-10 22:08:42 | 2022-09-12 19:52:21 | 2022-09-12 19:52:17 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24535', 'html_url': 'https://github.com/facebook/react/pull/24535', 'diff_url': 'https://github.com/facebook/react/pull/24535.diff', 'patch_url': 'https://github.com/facebook/react/pull/24535.patch', 'merged_at': None} | # Overview
Add a hook warning for when we go from 0 to n > 0 hooks or from n > 0 to 0 hooks in a component, such as using an early return like:
```jsx
function App(props) {
if (!props.foo) return;
useEffect(() => {});
return <span>Bar</span>;
}
```
We only add this warning in the new root, sinc... | {'url': 'https://api.github.com/repos/facebook/react/issues/24535/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24535/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24534 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24534/labels{/name} | https://api.github.com/repos/facebook/react/issues/24534/comments | https://api.github.com/repos/facebook/react/issues/24534/events | https://github.com/facebook/react/issues/24534 | 1,231,721,462 | I_kwDOAJy2Ks5JapP2 | 24,534 | Bug: Creating a lazy component in a hook causes infinite loop | {'login': 'wjmao88', 'id': 5618503, 'node_id': 'MDQ6VXNlcjU2MTg1MDM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5618503?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wjmao88', 'html_url': 'https://github.com/wjmao88', 'followers_url': 'https://api.github.com/users/wjmao88/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> It seems rendering a lazy component resets the hook somehow.\r\n\r\nIt does and it is completely expected. Lazy components suspend on first render, which means that all of the parent component state (including memo, etc) is thrown out.\r\n\r\nThat's why you need an external cache for Suspense when using it for d... | 2022-05-10 21:26:51 | 2022-05-11 13:54:27 | 2022-05-11 13:54:26 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.1.0 to 18.2.0.next (latest available on code sandbox)
## St... | {'url': 'https://api.github.com/repos/facebook/react/issues/24534/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24534/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24533 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24533/labels{/name} | https://api.github.com/repos/facebook/react/issues/24533/comments | https://api.github.com/repos/facebook/react/issues/24533/events | https://github.com/facebook/react/pull/24533 | 1,231,700,304 | PR_kwDOAJy2Ks43mrWe | 24,533 | [DevTools] Add Pragma to Only Run Tests if Version Requirement Satisfied | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d20c3af9d11ea4a35bfc76cb44c15af9d42059c4...b0c2356785ea534007c56b2b04c7110d4a30546e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-10 21:03:22 | 2022-05-11 16:01:06 | 2022-05-11 16:01:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24533', 'html_url': 'https://github.com/facebook/react/pull/24533', 'diff_url': 'https://github.com/facebook/react/pull/24533.diff', 'patch_url': 'https://github.com/facebook/react/pull/24533.patch', 'merged_at': datetime.datetime(2022, 5, 11, 16, 1, 6)} | This PR:
* Adds a `transform-react-version-pragma` that transforms `// @reactVersion SEMVER_VERSION` into `_test_react_version(...)` and `_test_react_version_focus(...)` that lets us only run a test if it satisfies the right react version.
* Adds `_test_react_version` and `_test_react_version_focus` to the devtools... | {'url': 'https://api.github.com/repos/facebook/react/issues/24533/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24533/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24532 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24532/labels{/name} | https://api.github.com/repos/facebook/react/issues/24532/comments | https://api.github.com/repos/facebook/react/issues/24532/events | https://github.com/facebook/react/pull/24532 | 1,231,485,824 | PR_kwDOAJy2Ks43mAvD | 24,532 | Move hydration code out of normal Suspense path | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2c68776abe2100bbf749ac4451b90e66f8290f2f...01562b73ccd3eefdc5c0f3ebf028138576c6d9bf\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-10 17:38:59 | 2022-05-25 19:50:22 | 2022-05-25 19:42:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24532', 'html_url': 'https://github.com/facebook/react/pull/24532', 'diff_url': 'https://github.com/facebook/react/pull/24532.diff', 'patch_url': 'https://github.com/facebook/react/pull/24532.patch', 'merged_at': datetime.datetime(2022, 5, 25, 19, 42, 2)} | Shuffling some code around to make it easier to follow. The logic for updating a dehydrated Suspense boundary is significantly different from the logic for a client-rendered Suspense boundary. Most of it was already lifted out into a separate function; this moves the remaining hydration-specific logic out of updateSusp... | {'url': 'https://api.github.com/repos/facebook/react/issues/24532/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24532/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24531 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24531/labels{/name} | https://api.github.com/repos/facebook/react/issues/24531/comments | https://api.github.com/repos/facebook/react/issues/24531/events | https://github.com/facebook/react/issues/24531 | 1,231,429,835 | I_kwDOAJy2Ks5JZiDL | 24,531 | Warning: Internal React error: Expected static flag was missing. Please notify the React team | {'login': 'atarek12', 'id': 67650726, 'node_id': 'MDQ6VXNlcjY3NjUwNzI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/67650726?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/atarek12', 'html_url': 'https://github.com/atarek12', 'followers_url': 'https://api.github.com/users/atarek12/followers',... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"In `const getLayout = Component.getLayout || ((page) => page);` you're effectively conditionally calling a hook since `AboutPage`.getLayout` is defined as \r\n\r\n```\r\n\r\nfunction AboutPageLayout(page) {\r\n useQuery(EXCHANGE_RATES);\r\n\r\n return (\r\n <div>\r\n <header>header</header>\r\n <mai... | 2022-05-10 16:46:42 | 2022-05-10 19:36:13 | 2022-05-10 17:02:14 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
`Warning: Internal React error: Expected static flag was missing. Please notify th... | {'url': 'https://api.github.com/repos/facebook/react/issues/24531/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24531/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24530 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24530/labels{/name} | https://api.github.com/repos/facebook/react/issues/24530/comments | https://api.github.com/repos/facebook/react/issues/24530/events | https://github.com/facebook/react/pull/24530 | 1,231,351,994 | PR_kwDOAJy2Ks43lkNL | 24,530 | Only treat updates to lazy as a new mount in legacy mode | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d20c3af9d11ea4a35bfc76cb44c15af9d42059c4...127414540610a363af10a1ebde2ebcfd2398db77\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-10 15:38:24 | 2022-05-12 12:51:36 | 2022-05-12 12:51:32 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24530', 'html_url': 'https://github.com/facebook/react/pull/24530', 'diff_url': 'https://github.com/facebook/react/pull/24530.diff', 'patch_url': 'https://github.com/facebook/react/pull/24530.patch', 'merged_at': datetime.datetime(2022, 5, 12, 12, 51, 32)} | ## Overview
This should just be an extra safety check. | {'url': 'https://api.github.com/repos/facebook/react/issues/24530/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24530/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24529 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24529/labels{/name} | https://api.github.com/repos/facebook/react/issues/24529/comments | https://api.github.com/repos/facebook/react/issues/24529/events | https://github.com/facebook/react/issues/24529 | 1,231,284,554 | I_kwDOAJy2Ks5JY-lK | 24,529 | Bug: Using an hook in getSnapshot of use-sync-external-store causes an infinite loop and no useful error is shown. | {'login': 'maury91', 'id': 4061875, 'node_id': 'MDQ6VXNlcjQwNjE4NzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4061875?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maury91', 'html_url': 'https://github.com/maury91', 'followers_url': 'https://api.github.com/users/maury91/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"True, I encountered same error message by passing down a `useCallback` as getSnapshot method. That was a mistake which was violating rules of hooks, but error message sent back by React was not clear enough to point quickly the mistake. ",
"This issue has been automatically marked as stale. **If this issue is st... | 2022-05-10 14:50:37 | 2024-04-17 14:13:59 | 2024-04-17 14:13:58 | NONE | null | null | null | use-sync-external-store version: 1.1.0
## Steps To Reproduce
1. Write a hook using useSyncExternalStore
2. Use a hook in getSnapshot
Link to code example: https://codesandbox.io/s/boring-bas-0g2rqi
## The current behavior
It creates an infinite loop, and shows the error:
> Maximum update depth exceed... | {'url': 'https://api.github.com/repos/facebook/react/issues/24529/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24529/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24528 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24528/labels{/name} | https://api.github.com/repos/facebook/react/issues/24528/comments | https://api.github.com/repos/facebook/react/issues/24528/events | https://github.com/facebook/react/issues/24528 | 1,231,005,394 | I_kwDOAJy2Ks5JX6bS | 24,528 | How to make a shareable widget with react 18 (plugin name should be static or shareable in some way)? | {'login': 'mmehmoodahmed', 'id': 48244871, 'node_id': 'MDQ6VXNlcjQ4MjQ0ODcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/48244871?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mmehmoodahmed', 'html_url': 'https://github.com/mmehmoodahmed', 'followers_url': 'https://api.github.com/users/mmehm... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\nCoding Questions\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to brow... | 2022-05-10 11:20:52 | 2022-05-10 13:18:55 | 2022-05-10 12:05:15 | NONE | null | null | null | I am developing a shareable widget with client as react 18 which can be called by using following approach:
OS : windows 10 64 bit
Node: 14.15.3
NPM: 6.14.9
When I try to run the npm run build command then I can see the following index.html page in build directory and there are some js, css plugins and images i... | {'url': 'https://api.github.com/repos/facebook/react/issues/24528/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24528/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24527 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24527/labels{/name} | https://api.github.com/repos/facebook/react/issues/24527/comments | https://api.github.com/repos/facebook/react/issues/24527/events | https://github.com/facebook/react/issues/24527 | 1,230,934,543 | I_kwDOAJy2Ks5JXpIP | 24,527 | Bug: How to get the `useUpdateEffect` custom hook work with the new Strict Mode? | {'login': 'ssmkhrj', 'id': 49264891, 'node_id': 'MDQ6VXNlcjQ5MjY0ODkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/49264891?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ssmkhrj', 'html_url': 'https://github.com/ssmkhrj', 'followers_url': 'https://api.github.com/users/ssmkhrj/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I would not recommend to use a Hook like this because the exact behavior you want to achieve depends on *what you use it for*. Can you give a concrete example of how you're using it? Then I could help show how to fix (if it breaks) that specific pattern.",
"@gaearon This is *not* something I'm using myself, I sa... | 2022-05-10 10:17:46 | 2023-08-25 03:48:26 | 2023-02-06 15:06:55 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: v18
## Steps To Reproduce
I came across this `useUpdateEffe... | {'url': 'https://api.github.com/repos/facebook/react/issues/24527/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24527/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24526 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24526/labels{/name} | https://api.github.com/repos/facebook/react/issues/24526/comments | https://api.github.com/repos/facebook/react/issues/24526/events | https://github.com/facebook/react/pull/24526 | 1,230,911,307 | PR_kwDOAJy2Ks43kFrG | 24,526 | Fix select default option | {'login': 'mmarkelov', 'id': 22371328, 'node_id': 'MDQ6VXNlcjIyMzcxMzI4', 'avatar_url': 'https://avatars.githubusercontent.com/u/22371328?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mmarkelov', 'html_url': 'https://github.com/mmarkelov', 'followers_url': 'https://api.github.com/users/mmarkelov/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d20c3af9d11ea4a35bfc76cb44c15af9d42059c4...4e611b3176ba9e93d7bf8d0586b909e316dc0cb3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-10 09:57:55 | 2024-04-17 14:14:01 | 2024-04-17 14:14:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24526', 'html_url': 'https://github.com/facebook/react/pull/24526', 'diff_url': 'https://github.com/facebook/react/pull/24526.diff', 'patch_url': 'https://github.com/facebook/react/pull/24526.patch', 'merged_at': None} | This is related to #24469
I'm not sure, but this changes from 2016 set default selection for the first non-disabled option, which is lead to inconsistency between pure html and react.
Also there are passed tests which should covered the right logic (we should have unselected options). But the actual browser beha... | {'url': 'https://api.github.com/repos/facebook/react/issues/24526/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24526/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24525 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24525/labels{/name} | https://api.github.com/repos/facebook/react/issues/24525/comments | https://api.github.com/repos/facebook/react/issues/24525/events | https://github.com/facebook/react/pull/24525 | 1,230,294,981 | PR_kwDOAJy2Ks43iFqP | 24,525 | Gate missing static flag check | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d20c3af9d11ea4a35bfc76cb44c15af9d42059c4...26d16a0ed7982862c381d97b70b14a02d46e46c6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-09 21:59:17 | 2022-05-12 13:11:03 | 2022-05-12 13:10:59 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24525', 'html_url': 'https://github.com/facebook/react/pull/24525', 'diff_url': 'https://github.com/facebook/react/pull/24525.diff', 'patch_url': 'https://github.com/facebook/react/pull/24525.patch', 'merged_at': None} | # Overview
This check was added in https://github.com/facebook/react/pull/20807 and is intended for in progress static flag work.
Currently, it fires even when hook counts change from 0 to n > 0. We should warn for that separately, but it also shouldn't fire this warning.
Related: https://github.com/facebook/... | {'url': 'https://api.github.com/repos/facebook/react/issues/24525/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24525/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24524 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24524/labels{/name} | https://api.github.com/repos/facebook/react/issues/24524/comments | https://api.github.com/repos/facebook/react/issues/24524/events | https://github.com/facebook/react/pull/24524 | 1,230,088,915 | PR_kwDOAJy2Ks43hZ6Z | 24,524 | [do not merge]Retain documentElement when appending/removing from Document | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 99eef9e2df7b6aade461a1a958eb3838239e72c4...1818f2946f3155c2debee543039dc1a7b3a2ce25\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-09 18:23:45 | 2022-05-10 17:26:33 | 2022-05-10 17:26:28 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/24524', 'html_url': 'https://github.com/facebook/react/pull/24524', 'diff_url': 'https://github.com/facebook/react/pull/24524.diff', 'patch_url': 'https://github.com/facebook/react/pull/24524.patch', 'merged_at': None} | creating a root or hydrating into a root with a Document container could error in surprising ways because the document root element was not removed when clearing the container and then a new html element was attempting to be appended to the document. Browsers do not allow more than one root element and this errored lea... | {'url': 'https://api.github.com/repos/facebook/react/issues/24524/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24524/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24523 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24523/labels{/name} | https://api.github.com/repos/facebook/react/issues/24523/comments | https://api.github.com/repos/facebook/react/issues/24523/events | https://github.com/facebook/react/pull/24523 | 1,229,962,228 | PR_kwDOAJy2Ks43g_IO | 24,523 | Support document rendering | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d20c3af9d11ea4a35bfc76cb44c15af9d42059c4...0215c835128bee2a22c0bf2a51430140e5739e98\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-09 16:21:15 | 2022-06-03 14:28:46 | 2022-05-10 17:17:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24523', 'html_url': 'https://github.com/facebook/react/pull/24523', 'diff_url': 'https://github.com/facebook/react/pull/24523.diff', 'patch_url': 'https://github.com/facebook/react/pull/24523.patch', 'merged_at': datetime.datetime(2022, 5, 10, 17, 17, 36)} | ## Hydrating into Document
This PR addressed the most fundamental issue identified in #22833. In that issue a hydration mismatch when hydrating into the Document caused a broken application because the client rendered fallback could not append any content to the Document.
This is caused by the fact that a Document ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24523/reactions', 'total_count': 5, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 5, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24523/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24522 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24522/labels{/name} | https://api.github.com/repos/facebook/react/issues/24522/comments | https://api.github.com/repos/facebook/react/issues/24522/events | https://github.com/facebook/react/issues/24522 | 1,229,643,466 | I_kwDOAJy2Ks5JSt7K | 24,522 | [DevTools] Manifest version 2 is deprecated | {'login': 'Bartel-C8', 'id': 76486925, 'node_id': 'MDQ6VXNlcjc2NDg2OTI1', 'avatar_url': 'https://avatars.githubusercontent.com/u/76486925?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Bartel-C8', 'html_url': 'https://github.com/Bartel-C8', 'followers_url': 'https://api.github.com/users/Bartel-C8/followe... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github... | closed | false | {'login': 'mondaychen', 'id': 1001890.0, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/fol... | [{'login': 'mondaychen', 'id': 1001890, 'node_id': 'MDQ6VXNlcjEwMDE4OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1001890?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mondaychen', 'html_url': 'https://github.com/mondaychen', 'followers_url': 'https://api.github.com/users/mondaychen/foll... | null | [
"Redux DevTools issue for reference/inspiration/impact: https://github.com/reduxjs/redux-devtools/issues/1037",
"Hey! Thanks so much for the heads up! We've added it to our plans for this year. 😊",
"@lunaruan I would love to work on this issue. Kindly assign this issue to me. ",
"Hey, sure you can take a sta... | 2022-05-09 12:37:52 | 2023-01-15 04:31:15 | 2022-10-22 02:52:19 | NONE | null | null | null | ### Website or app
https://developer.chrome.com/blog/mv2-transition/
### Repro steps
Use latest React DevTools with Electron (Chromium) (18.2.0 / Chromium 100)
```
(node:80082) ExtensionLoadWarning: Warnings loading extension at ./node_modules/electron-devtools-vendor/extensions/react-developer-tools:
Man... | {'url': 'https://api.github.com/repos/facebook/react/issues/24522/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24522/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24520 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24520/labels{/name} | https://api.github.com/repos/facebook/react/issues/24520/comments | https://api.github.com/repos/facebook/react/issues/24520/events | https://github.com/facebook/react/issues/24520 | 1,229,508,524 | I_kwDOAJy2Ks5JSM-s | 24,520 | Bug: | {'login': 'MrCoul3', 'id': 53871298, 'node_id': 'MDQ6VXNlcjUzODcxMjk4', 'avatar_url': 'https://avatars.githubusercontent.com/u/53871298?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MrCoul3', 'html_url': 'https://github.com/MrCoul3', 'followers_url': 'https://api.github.com/users/MrCoul3/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2022-05-09 10:35:16 | 2022-05-09 17:19:38 | 2022-05-09 17:19:38 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/24520/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24520/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24519 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24519/labels{/name} | https://api.github.com/repos/facebook/react/issues/24519/comments | https://api.github.com/repos/facebook/react/issues/24519/events | https://github.com/facebook/react/issues/24519 | 1,229,462,030 | I_kwDOAJy2Ks5JSBoO | 24,519 | Bug: `validateDOMNesting` Hydration failed | {'login': 'icyJoseph', 'id': 21013447, 'node_id': 'MDQ6VXNlcjIxMDEzNDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/21013447?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/icyJoseph', 'html_url': 'https://github.com/icyJoseph', 'followers_url': 'https://api.github.com/users/icyJoseph/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This seems to be expected behavior? SSR cannot work with improper tag nesting as per the HTML spec, the browser's parser won't accept it, and the whole point of SSR is to have the browser parse the initial document structure for you without using any JS. Client side rendering can work with improper tag nesting b... | 2022-05-09 09:54:10 | 2023-09-24 11:58:20 | 2023-06-01 19:18:27 | NONE | null | null | null | Having an invalid DOM structure, normally triggers `validateDOMNesting`, but when combined with SSR, this also triggers `Hydration failed`, and `There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering`.
I assume the above is a com... | {'url': 'https://api.github.com/repos/facebook/react/issues/24519/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24519/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24518 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24518/labels{/name} | https://api.github.com/repos/facebook/react/issues/24518/comments | https://api.github.com/repos/facebook/react/issues/24518/events | https://github.com/facebook/react/issues/24518 | 1,228,872,273 | I_kwDOAJy2Ks5JPxpR | 24,518 | Default bolean prop named "show or visible" | {'login': 'ShafiqueMalik', 'id': 56837884, 'node_id': 'MDQ6VXNlcjU2ODM3ODg0', 'avatar_url': 'https://avatars.githubusercontent.com/u/56837884?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ShafiqueMalik', 'html_url': 'https://github.com/ShafiqueMalik', 'followers_url': 'https://api.github.com/users/Shafi... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"Duplicate of https://github.com/facebook/react/issues/4373. See https://github.com/facebook/react/issues/4373#issuecomment-133485039 for why this is closed."
] | 2022-05-08 12:12:37 | 2022-05-17 17:48:53 | 2022-05-17 17:48:53 | NONE | null | null | null | Hi reactjs Team, I suggest that, team should add a new prop for every component that purly used to show or hide component conditionally.
i.e
Instead of writing code like this in JSX.
{show && <Component/>}
we simply use like this <Component show={true}/> and that's it. | {'url': 'https://api.github.com/repos/facebook/react/issues/24518/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24518/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24517 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24517/labels{/name} | https://api.github.com/repos/facebook/react/issues/24517/comments | https://api.github.com/repos/facebook/react/issues/24517/events | https://github.com/facebook/react/issues/24517 | 1,228,862,207 | I_kwDOAJy2Ks5JPvL_ | 24,517 | Bug: Toastify is acting like message in UI | {'login': 'sraboni-bhuiyan', 'id': 35885263, 'node_id': 'MDQ6VXNlcjM1ODg1MjYz', 'avatar_url': 'https://avatars.githubusercontent.com/u/35885263?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sraboni-bhuiyan', 'html_url': 'https://github.com/sraboni-bhuiyan', 'followers_url': 'https://api.github.com/users... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"You want to report issues with `react-toastify` in their repository: https://github.com/fkhadra/react-toastify"
] | 2022-05-08 11:22:37 | 2022-05-10 12:59:35 | 2022-05-10 12:59:31 | NONE | null | null | null | I installed react-toastify but it is not working when it is triggered. Rather it is acting like it a text in the website Interface
React version: 18.1.0
## Steps To Reproduce
1. add toastify
2. trigger it with a button or any funtionality
<!--
Your bug will get fixed much faster if we can run your cod... | {'url': 'https://api.github.com/repos/facebook/react/issues/24517/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24517/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24516 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24516/labels{/name} | https://api.github.com/repos/facebook/react/issues/24516/comments | https://api.github.com/repos/facebook/react/issues/24516/events | https://github.com/facebook/react/pull/24516 | 1,228,837,103 | PR_kwDOAJy2Ks43dVxg | 24,516 | Tsering added fileTset.txt | {'login': 'tseringz', 'id': 15078245, 'node_id': 'MDQ6VXNlcjE1MDc4MjQ1', 'avatar_url': 'https://avatars.githubusercontent.com/u/15078245?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tseringz', 'html_url': 'https://github.com/tseringz', 'followers_url': 'https://api.github.com/users/tseringz/followers',... | [] | closed | false | null | [] | null | [
"Hi @tseringz! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2022-05-08 09:19:41 | 2022-05-09 08:26:45 | 2022-05-09 08:26:44 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24516', 'html_url': 'https://github.com/facebook/react/pull/24516', 'diff_url': 'https://github.com/facebook/react/pull/24516.diff', 'patch_url': 'https://github.com/facebook/react/pull/24516.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24516/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24516/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24515 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24515/labels{/name} | https://api.github.com/repos/facebook/react/issues/24515/comments | https://api.github.com/repos/facebook/react/issues/24515/events | https://github.com/facebook/react/issues/24515 | 1,228,585,378 | I_kwDOAJy2Ks5JOrmi | 24,515 | classes prop instead of className | {'login': 'roti', 'id': 919724, 'node_id': 'MDQ6VXNlcjkxOTcyNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/919724?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/roti', 'html_url': 'https://github.com/roti', 'followers_url': 'https://api.github.com/users/roti/followers', 'following_url': 'h... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"Not sure if this might help, but there is a very good library for what you are describing\r\nhttps://www.npmjs.com/package/classnames",
"> Not sure if this might help, but there is a very good library for what you are describing\n> https://www.npmjs.com/package/classnames\n\nPerhaps this library it's widely used... | 2022-05-07 09:53:02 | 2022-05-17 17:59:49 | 2022-05-17 17:59:35 | NONE | null | null | null | It is often the case that multiple CSS classes are used for an element, and sometimes they are dynamically generated. In such situations the client code needs to concatenate them into a string
```
const classes = getCSSClasses();
return (
<div className={classes.class1 + " " + classes.class2}> foo </div>
);
`... | {'url': 'https://api.github.com/repos/facebook/react/issues/24515/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24515/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24514 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24514/labels{/name} | https://api.github.com/repos/facebook/react/issues/24514/comments | https://api.github.com/repos/facebook/react/issues/24514/events | https://github.com/facebook/react/issues/24514 | 1,228,575,690 | I_kwDOAJy2Ks5JOpPK | 24,514 | Bug: Select Element Not Always Resetting To The First Available Option After State Change | {'login': 'fweth', 'id': 22940859, 'node_id': 'MDQ6VXNlcjIyOTQwODU5', 'avatar_url': 'https://avatars.githubusercontent.com/u/22940859?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fweth', 'html_url': 'https://github.com/fweth', 'followers_url': 'https://api.github.com/users/fweth/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-05-07 09:06:13 | 2024-04-17 14:14:02 | 2024-04-17 14:14:01 | NONE | null | null | null | If the option set of an select element is dependent on a state, and there are overlappings between the option sets, then changing to a state such that the new option set contains the currently selected option sometimes resets the select element to the first option and sometimes not. I describe four cases where two of ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24514/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24514/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24513 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24513/labels{/name} | https://api.github.com/repos/facebook/react/issues/24513/comments | https://api.github.com/repos/facebook/react/issues/24513/events | https://github.com/facebook/react/pull/24513 | 1,228,532,326 | PR_kwDOAJy2Ks43ceSJ | 24,513 | Remove the duplicated code of case 'renders an empty fragment' in ReactDOMFiber-test.js | {'login': 'zoyopo', 'id': 22582626, 'node_id': 'MDQ6VXNlcjIyNTgyNjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/22582626?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zoyopo', 'html_url': 'https://github.com/zoyopo', 'followers_url': 'https://api.github.com/users/zoyopo/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4cd788aef03d8f32c03e4dac4d0cf28b220cedfb...44f4def6e2f2d6047aaf5a0644bc4f5f70298701\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-07 05:26:52 | 2024-04-17 14:14:04 | 2024-04-17 14:14:03 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24513', 'html_url': 'https://github.com/facebook/react/pull/24513', 'diff_url': 'https://github.com/facebook/react/pull/24513.diff', 'patch_url': 'https://github.com/facebook/react/pull/24513.patch', 'merged_at': None} | Remove the duplicated code of case 'renders an empty fragment' in ReactDOMFiber-test.js | {'url': 'https://api.github.com/repos/facebook/react/issues/24513/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24513/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24512 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24512/labels{/name} | https://api.github.com/repos/facebook/react/issues/24512/comments | https://api.github.com/repos/facebook/react/issues/24512/events | https://github.com/facebook/react/pull/24512 | 1,228,525,356 | PR_kwDOAJy2Ks43cc-S | 24,512 | Remove the duplicated code of case 'renders an empty fragment' in Re… | {'login': 'zoyopo', 'id': 22582626, 'node_id': 'MDQ6VXNlcjIyNTgyNjI2', 'avatar_url': 'https://avatars.githubusercontent.com/u/22582626?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zoyopo', 'html_url': 'https://github.com/zoyopo', 'followers_url': 'https://api.github.com/users/zoyopo/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/24512/builds/247740) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on comm... | 2022-05-07 04:43:44 | 2022-05-07 05:24:58 | 2022-05-07 05:24:58 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24512', 'html_url': 'https://github.com/facebook/react/pull/24512', 'diff_url': 'https://github.com/facebook/react/pull/24512.diff', 'patch_url': 'https://github.com/facebook/react/pull/24512.patch', 'merged_at': None} | Remove the duplicated code of case 'renders an empty fragment' in ReactDOMFiber-test.js
| {'url': 'https://api.github.com/repos/facebook/react/issues/24512/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24512/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24511 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24511/labels{/name} | https://api.github.com/repos/facebook/react/issues/24511/comments | https://api.github.com/repos/facebook/react/issues/24511/events | https://github.com/facebook/react/issues/24511 | 1,228,472,988 | I_kwDOAJy2Ks5JOQKc | 24,511 | [DevTools Bug]: I believe that UI and UX from React DevTools is a big bug | {'login': 'ComaBerenices', 'id': 92554215, 'node_id': 'U_kgDOBYRD5w', 'avatar_url': 'https://avatars.githubusercontent.com/u/92554215?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ComaBerenices', 'html_url': 'https://github.com/ComaBerenices', 'followers_url': 'https://api.github.com/users/ComaBerenices... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"This isn't really actionable feedback. The React DevTools UI looks different from Vue DevTools UI because they are built to support different frameworks. There is not really any React equivalent for Vue's routing and data management libraries, so it doesn't make sense for dedicated routing or Vuex tabs.\r\n\r\nGoi... | 2022-05-07 00:26:58 | 2022-05-08 00:47:51 | 2022-05-08 00:47:51 | NONE | null | null | null | ### Website or app
https://all.apllications.com
### Repro steps
Hello, community! ✌
I have an big question about the React DevTools, why is so different in comparasion with Vue DevTools ? all is more hard...
See the context, indentify the state's, the components.... 😒
In comparasion with Vue DevTools, the ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24511/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24511/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24510 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24510/labels{/name} | https://api.github.com/repos/facebook/react/issues/24510/comments | https://api.github.com/repos/facebook/react/issues/24510/events | https://github.com/facebook/react/pull/24510 | 1,228,303,656 | PR_kwDOAJy2Ks43buq3 | 24,510 | [DevTools][Bug] Fix Race Condition When Unmounting Fibers | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Nice fix!"
] | 2022-05-06 19:12:30 | 2022-05-08 09:32:56 | 2022-05-06 19:36:03 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24510', 'html_url': 'https://github.com/facebook/react/pull/24510', 'diff_url': 'https://github.com/facebook/react/pull/24510.diff', 'patch_url': 'https://github.com/facebook/react/pull/24510.patch', 'merged_at': datetime.datetime(2022, 5, 6, 19, 36, 3)} | Addresses [this comment](https://github.com/facebook/react/issues/23202#issuecomment-1101180251).
---
When we delete fibers, we will call `onCommitFiberUnmount` on every deleted fiber to also remove them from the element tree. However, there are some cases where fibers aren't deleted but we still want to remove t... | {'url': 'https://api.github.com/repos/facebook/react/issues/24510/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24510/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24509 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24509/labels{/name} | https://api.github.com/repos/facebook/react/issues/24509/comments | https://api.github.com/repos/facebook/react/issues/24509/events | https://github.com/facebook/react/issues/24509 | 1,227,679,573 | I_kwDOAJy2Ks5JLOdV | 24,509 | Bug: Chrome. Controlled and *required* input type="date" - onChange not triggered by pressing clear | {'login': 'ItsLhun', 'id': 66971876, 'node_id': 'MDQ6VXNlcjY2OTcxODc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/66971876?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ItsLhun', 'html_url': 'https://github.com/ItsLhun', 'followers_url': 'https://api.github.com/users/ItsLhun/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This does not seem like a React bug, this is more like a bug with the input element ( or maybe its by design, I am not sure)\r\nhttps://codesandbox.io/s/gracious-visvesvaraya-1d0b3m?file=/index.html:147-155\r\nI tried to reproduce it with just vanilla js and it still does not clear.",
"I second @kkyusufk and wha... | 2022-05-06 10:19:40 | 2024-04-17 14:14:05 | 2024-04-17 14:14:05 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.1 (and prior, also tested on 16.9)
## Steps To Reproduce
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24509/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24509/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24508 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24508/labels{/name} | https://api.github.com/repos/facebook/react/issues/24508/comments | https://api.github.com/repos/facebook/react/issues/24508/events | https://github.com/facebook/react/issues/24508 | 1,227,477,794 | I_kwDOAJy2Ks5JKdMi | 24,508 | Bug: Breaking change of use-subscription from 1.6.0 to 1.7.0 | {'login': 'Jack-Works', 'id': 5390719, 'node_id': 'MDQ6VXNlcjUzOTA3MTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5390719?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Jack-Works', 'html_url': 'https://github.com/Jack-Works', 'followers_url': 'https://api.github.com/users/Jack-Works/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Oops, that's our bad. We haven't considered this change in behavior.\r\n\r\nSince it's already been out for a few weeks, it seems like changing the behavior again risks being more disruptive. So for now we're going to leave this as is and see if we get more complaints.\r\n\r\nSorry!",
"I am encountering this sam... | 2022-05-06 06:38:36 | 2023-10-27 17:16:55 | 2022-05-09 17:30:54 | CONTRIBUTOR | null | null | null | React version: 18.1.0
It looks like use-subscription has changed the internal implementation to `useSyncExternalStore`.
It is causing the following error in our application:
> Warning: The result of getSnapshot should be cached to avoid an infinite loop
> Uncaught Error: Maximum update depth exceeded. This ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24508/reactions', 'total_count': 11, '+1': 11, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24508/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24507 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24507/labels{/name} | https://api.github.com/repos/facebook/react/issues/24507/comments | https://api.github.com/repos/facebook/react/issues/24507/events | https://github.com/facebook/react/pull/24507 | 1,227,034,649 | PR_kwDOAJy2Ks43X2qQ | 24,507 | Unify JSResourceReference Interfaces | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 547b707493735327373a9f8792343f73a5b080da...c98da647873c16ec94613e48d37bf40de9499e09\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-05 18:30:46 | 2022-05-06 18:24:07 | 2022-05-06 18:24:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24507', 'html_url': 'https://github.com/facebook/react/pull/24507', 'diff_url': 'https://github.com/facebook/react/pull/24507.diff', 'patch_url': 'https://github.com/facebook/react/pull/24507.patch', 'merged_at': datetime.datetime(2022, 5, 6, 18, 24, 5)} | ## Summary
Unifies the `JSResourceReference` type interface between Haste and Metro.
## How did you test this change?
Verified Flow type checks succeed:
```
$ cd react
$ yarn
$ yarn run flow dom-relay
$ yarn run flow native-relay
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/24507/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24507/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24506 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24506/labels{/name} | https://api.github.com/repos/facebook/react/issues/24506/comments | https://api.github.com/repos/facebook/react/issues/24506/events | https://github.com/facebook/react/pull/24506 | 1,227,034,123 | PR_kwDOAJy2Ks43X2jM | 24,506 | Add eslint rule to error on reads or writes to refs in render | {'login': 'devongovett', 'id': 19409, 'node_id': 'MDQ6VXNlcjE5NDA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/19409?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/devongovett', 'html_url': 'https://github.com/devongovett', 'followers_url': 'https://api.github.com/users/devongovett/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 547b707493735327373a9f8792343f73a5b080da...18d2eea2dc23eb8c98c205b6e813f66b3d6b9d70\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-05 18:30:13 | 2024-04-17 14:14:07 | 2024-04-17 14:14:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24506', 'html_url': 'https://github.com/facebook/react/pull/24506', 'diff_url': 'https://github.com/facebook/react/pull/24506.diff', 'patch_url': 'https://github.com/facebook/react/pull/24506.patch', 'merged_at': None} | ## Summary
After some discussion on the [useEvent RFC](https://github.com/reactjs/rfcs/pull/220) and on [Twitter](https://twitter.com/dan_abramov/status/1521942250875457536), I and others learned that writing to refs during render is not allowed. This is documented in the [new docs](https://beta.reactjs.org/apis/use... | {'url': 'https://api.github.com/repos/facebook/react/issues/24506/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 4, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24506/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24505 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24505/labels{/name} | https://api.github.com/repos/facebook/react/issues/24505/comments | https://api.github.com/repos/facebook/react/issues/24505/events | https://github.com/facebook/react/pull/24505 | 1,226,997,956 | PR_kwDOAJy2Ks43Xuw9 | 24,505 | [WIP] Add useEvent | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c7e494b55320768863b821be96896b28f0a280ef...4aabc5788eed5011ba2c377a776e74f8918a1b48\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-05 17:53:06 | 2022-09-12 19:52:45 | 2022-09-12 19:52:42 | MEMBER | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/24505', 'html_url': 'https://github.com/facebook/react/pull/24505', 'diff_url': 'https://github.com/facebook/react/pull/24505.diff', 'patch_url': 'https://github.com/facebook/react/pull/24505.patch', 'merged_at': None} | ## Overview
This PR adds a new hook `useEvent` per the RFC [here](https://github.com/reactjs/rfcs/pull/220).
## TODO
- [ ] More tests
- [ ] Mutate in the correct time of the commit phase (currently just an insertion effect)
- [ ] Decide on the error message text for calling it in render
- [ ] Update linter ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24505/reactions', 'total_count': 10, '+1': 10, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24505/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24504 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24504/labels{/name} | https://api.github.com/repos/facebook/react/issues/24504/comments | https://api.github.com/repos/facebook/react/issues/24504/events | https://github.com/facebook/react/issues/24504 | 1,226,945,263 | I_kwDOAJy2Ks5JIbLv | 24,504 | Ad hoc data fetching with Suspense | {'login': 'OliverJAsh', 'id': 921609, 'node_id': 'MDQ6VXNlcjkyMTYwOQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/921609?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/OliverJAsh', 'html_url': 'https://github.com/OliverJAsh', 'followers_url': 'https://api.github.com/users/OliverJAsh/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Does your framework allow refetching or cache invalidation?",
"No, once the data has been fetched, we never attempt to fetch it again—we re-use the cached result from the previous request (which we currently store in Redux).",
"Maybe there are open source frameworks that are on the right path? Or is data fetch... | 2022-05-05 16:56:22 | 2024-04-17 14:14:08 | 2024-04-17 14:14:08 | NONE | null | null | null | .@aaronabramov suggested that I file an issue for this: https://twitter.com/dan_abramov/status/1522207779984793601
---
👋 I have a question about React 18 + Suspense. From the [docs](https://reactjs.org/blog/2022/03/29/react-v18.html):
> Ad hoc data fetching with Suspense is technically possible, but still not... | {'url': 'https://api.github.com/repos/facebook/react/issues/24504/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24504/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24503 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24503/labels{/name} | https://api.github.com/repos/facebook/react/issues/24503/comments | https://api.github.com/repos/facebook/react/issues/24503/events | https://github.com/facebook/react/pull/24503 | 1,226,876,433 | PR_kwDOAJy2Ks43XVbb | 24,503 | React DevTools 4.24.4 -> 4.24.5 | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2022-05-05 15:56:03 | 2024-01-13 15:28:17 | 2022-05-05 17:19:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24503', 'html_url': 'https://github.com/facebook/react/pull/24503', 'diff_url': 'https://github.com/facebook/react/pull/24503.diff', 'patch_url': 'https://github.com/facebook/react/pull/24503.patch', 'merged_at': datetime.datetime(2022, 5, 5, 17, 19, 8)} | Prepare changelog for DevTools bug fix release 4.24.5 | {'url': 'https://api.github.com/repos/facebook/react/issues/24503/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24503/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24502 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24502/labels{/name} | https://api.github.com/repos/facebook/react/issues/24502/comments | https://api.github.com/repos/facebook/react/issues/24502/events | https://github.com/facebook/react/issues/24502 | 1,226,848,998 | I_kwDOAJy2Ks5JIDrm | 24,502 | Bug: useEffect runs twice on component mount (StrictMode, NODE_ENV=development) | {'login': 'cytrowski', 'id': 2965690, 'node_id': 'MDQ6VXNlcjI5NjU2OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2965690?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cytrowski', 'html_url': 'https://github.com/cytrowski', 'followers_url': 'https://api.github.com/users/cytrowski/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | true | null | [] | null | [
"Effects firing twice in `<React.StrictMode />` was added in React 18. \r\n\r\nFor more information, check out [StrictMode: Ensuring reusable state](https://reactjs.org/docs/strict-mode.html#ensuring-reusable-state)\r\n",
"Thank you @eps1lon for clarification. However this is not intuitive and I'd expect this bei... | 2022-05-05 15:38:46 | 2022-06-23 03:42:45 | 2022-05-05 16:11:45 | NONE | resolved | null | null | React version: 18.0.x, 18.1.x, 18.2.x
## Steps To Reproduce
1. Visit provided sandbox
2. Open console and observe logs displayed twice.
3. Click the button and observe the rendering log happens twice, the effect log happens once.
Link to code example: https://codesandbox.io/s/react-18-use-effect-bug-iqn1fx
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24502/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24502/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24501 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24501/labels{/name} | https://api.github.com/repos/facebook/react/issues/24501/comments | https://api.github.com/repos/facebook/react/issues/24501/events | https://github.com/facebook/react/pull/24501 | 1,226,748,782 | PR_kwDOAJy2Ks43W7_h | 24,501 | Fixed possible undefined error in TreeContext reducer | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2022-05-05 14:26:36 | 2022-05-05 15:47:01 | 2022-05-05 15:46:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24501', 'html_url': 'https://github.com/facebook/react/pull/24501', 'diff_url': 'https://github.com/facebook/react/pull/24501.diff', 'patch_url': 'https://github.com/facebook/react/pull/24501.patch', 'merged_at': datetime.datetime(2022, 5, 5, 15, 46, 57)} | Resolves #24441
I don't have a repro for this bug. It's just something that was found in Sentry logs.
Tracing through the `Store` code, I didn't spot how this case would occur– since it seems like it should only be possible if the cached errors/warnings didn't align with the most recent errors/warnings:
https://... | {'url': 'https://api.github.com/repos/facebook/react/issues/24501/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24501/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24500 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24500/labels{/name} | https://api.github.com/repos/facebook/react/issues/24500/comments | https://api.github.com/repos/facebook/react/issues/24500/events | https://github.com/facebook/react/issues/24500 | 1,226,591,924 | I_kwDOAJy2Ks5JHE60 | 24,500 | Suggestion: allow bailing out of setState updater functions | {'login': 'holloway', 'id': 620580, 'node_id': 'MDQ6VXNlcjYyMDU4MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/620580?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/holloway', 'html_url': 'https://github.com/holloway', 'followers_url': 'https://api.github.com/users/holloway/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Apoligies if i'm misunderstanding, but why can't you simply make this check before the setState call? Something like:\r\n\r\n```JS\r\n<button\r\n onClick={() => {\r\n if (oldDirection !== \"left\") {\r\n setDirection((oldDirection) => {\r\n return \"left\";\r\n })}\r\n }}\r\n>\r\n set left... | 2022-05-05 12:13:47 | 2022-05-06 14:29:00 | 2022-05-06 14:28:59 | NONE | null | null | null | My understanding is that React will _always_ trigger a rerender when a value is set in a setState _updater function_. If this is wrong please ignore this suggestion.
-----------------------------------
A useState's setState can take an _updater function_ and it would be useful to conditionally avoid causing a rer... | {'url': 'https://api.github.com/repos/facebook/react/issues/24500/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24500/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24499 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24499/labels{/name} | https://api.github.com/repos/facebook/react/issues/24499/comments | https://api.github.com/repos/facebook/react/issues/24499/events | https://github.com/facebook/react/pull/24499 | 1,226,258,703 | PR_kwDOAJy2Ks43VUWh | 24,499 | expand react-refresh fields to including inner files (#24498) | {'login': 'XHFkindergarten', 'id': 35923415, 'node_id': 'MDQ6VXNlcjM1OTIzNDE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/35923415?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/XHFkindergarten', 'html_url': 'https://github.com/XHFkindergarten', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @XHFkindergarten! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2022-05-05 06:36:36 | 2024-04-17 15:03:38 | 2024-04-17 15:03:38 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24499', 'html_url': 'https://github.com/facebook/react/pull/24499', 'diff_url': 'https://github.com/facebook/react/pull/24499.diff', 'patch_url': 'https://github.com/facebook/react/pull/24499.patch', 'merged_at': None} | ## Summary
more detail can be found in [#24498](https://github.com/facebook/react/issues/24498)
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/24499/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24499/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24498 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24498/labels{/name} | https://api.github.com/repos/facebook/react/issues/24498/comments | https://api.github.com/repos/facebook/react/issues/24498/events | https://github.com/facebook/react/issues/24498 | 1,226,256,411 | I_kwDOAJy2Ks5JFzAb | 24,498 | Bug: react-refresh@13 package.json's exports field change leads to an adapting mistake | {'login': 'XHFkindergarten', 'id': 35923415, 'node_id': 'MDQ6VXNlcjM1OTIzNDE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/35923415?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/XHFkindergarten', 'html_url': 'https://github.com/XHFkindergarten', 'followers_url': 'https://api.github.com/users... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-05-05 06:33:03 | 2024-04-17 15:03:41 | 2024-04-17 15:03:40 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0
*react-refresh version: 13.0.0
## Background
We are r... | {'url': 'https://api.github.com/repos/facebook/react/issues/24498/reactions', 'total_count': 3, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24498/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24497 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24497/labels{/name} | https://api.github.com/repos/facebook/react/issues/24497/comments | https://api.github.com/repos/facebook/react/issues/24497/events | https://github.com/facebook/react/issues/24497 | 1,226,243,034 | I_kwDOAJy2Ks5JFvva | 24,497 | Bug: | {'login': 'vijay-immanent', 'id': 101624639, 'node_id': 'U_kgDOBg6rPw', 'avatar_url': 'https://avatars.githubusercontent.com/u/101624639?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vijay-immanent', 'html_url': 'https://github.com/vijay-immanent', 'followers_url': 'https://api.github.com/users/vijay-im... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | {'login': 'vijay-immanent', 'id': 101624639.0, 'node_id': 'U_kgDOBg6rPw', 'avatar_url': 'https://avatars.githubusercontent.com/u/101624639?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vijay-immanent', 'html_url': 'https://github.com/vijay-immanent', 'followers_url': 'https://api.github.com/users/vijay-... | [{'login': 'vijay-immanent', 'id': 101624639, 'node_id': 'U_kgDOBg6rPw', 'avatar_url': 'https://avatars.githubusercontent.com/u/101624639?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vijay-immanent', 'html_url': 'https://github.com/vijay-immanent', 'followers_url': 'https://api.github.com/users/vijay-i... | null | [
"Possibly related to #24391\r\n\r\nCan you specify which version of React you were using when seeing the error above?\r\n\r\nIt also looks like you have an early return in some cases (`!show`) which would cause your component to _sometimes_ use the state and effect hooks and sometimes not. This is something the `es... | 2022-05-05 06:11:14 | 2022-05-05 18:16:13 | 2022-05-05 18:16:13 | NONE | null | null | null | I didn't notice any deviation from the behavior I expected from the component.
### component:
```
export const Contract: FC<ContractProps> = ({
contract = demo_contract,
hide,
show
}) => {
if (!show) {
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24497/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24497/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24496 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24496/labels{/name} | https://api.github.com/repos/facebook/react/issues/24496/comments | https://api.github.com/repos/facebook/react/issues/24496/events | https://github.com/facebook/react/pull/24496 | 1,226,124,903 | PR_kwDOAJy2Ks43U5Wz | 24,496 | Constrain the container type of createPortal | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0dc4e6663dc875e0f734b1a96b26ebc33902323a...544a1b283eba14794f99ca993a07fbfce02b659e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-05 01:51:06 | 2022-05-05 03:06:24 | 2022-05-05 03:05:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24496', 'html_url': 'https://github.com/facebook/react/pull/24496', 'diff_url': 'https://github.com/facebook/react/pull/24496.diff', 'patch_url': 'https://github.com/facebook/react/pull/24496.patch', 'merged_at': datetime.datetime(2022, 5, 5, 3, 5, 37)} | We already constrained the type of createRoot (can't take document) and hydrateRoot (can't take shadow roots aka fragments). | {'url': 'https://api.github.com/repos/facebook/react/issues/24496/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24496/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24495 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24495/labels{/name} | https://api.github.com/repos/facebook/react/issues/24495/comments | https://api.github.com/repos/facebook/react/issues/24495/events | https://github.com/facebook/react/pull/24495 | 1,226,007,079 | PR_kwDOAJy2Ks43Uhst | 24,495 | [React DevTools][Bug] Don't reset selected element if `elementIndicesWithErrorsOrWarnings` is empty | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"#24501 does the same thing ",
"Oh sorry! I didn’t see this or I wouldn’t have posted my PR"
] | 2022-05-04 21:54:55 | 2022-05-05 15:48:21 | 2022-05-05 15:43:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24495', 'html_url': 'https://github.com/facebook/react/pull/24495', 'diff_url': 'https://github.com/facebook/react/pull/24495.diff', 'patch_url': 'https://github.com/facebook/react/pull/24495.patch', 'merged_at': None} | Perhaps addresses #24441
---
If `elementIndicesWithErrorsOrWarnings` is empty, we shouldn't set the `selectedElementId` or the `selectedElementIndex` to the previous entry because there is no previous entry. | {'url': 'https://api.github.com/repos/facebook/react/issues/24495/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24495/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24494 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24494/labels{/name} | https://api.github.com/repos/facebook/react/issues/24494/comments | https://api.github.com/repos/facebook/react/issues/24494/events | https://github.com/facebook/react/pull/24494 | 1,225,741,119 | PR_kwDOAJy2Ks43TzCA | 24,494 | [React DevTools] Fix `didFiberRender` | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Nice catch 👍🏼 "
] | 2022-05-04 18:40:26 | 2022-05-05 14:08:50 | 2022-05-04 20:25:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24494', 'html_url': 'https://github.com/facebook/react/pull/24494', 'diff_url': 'https://github.com/facebook/react/pull/24494.diff', 'patch_url': 'https://github.com/facebook/react/pull/24494.patch', 'merged_at': datetime.datetime(2022, 5, 4, 20, 25, 27)} | Resolves #24428
---
For fiber types that render user code, we check the `PerformedWork` flag rather than the props, ref, and state to see if the fiber rendered (rather than bailing out/etc.) so we know whether we need to do things like record profile durations. ForwardRef wasn't added to this list, which caused ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24494/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24494/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24493 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24493/labels{/name} | https://api.github.com/repos/facebook/react/issues/24493/comments | https://api.github.com/repos/facebook/react/issues/24493/events | https://github.com/facebook/react/issues/24493 | 1,225,630,522 | I_kwDOAJy2Ks5JDaM6 | 24,493 | Bug: Updaters are NOT called twice for the first time when in Strict Mode | {'login': 'ssmkhrj', 'id': 49264891, 'node_id': 'MDQ6VXNlcjQ5MjY0ODkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/49264891?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ssmkhrj', 'html_url': 'https://github.com/ssmkhrj', 'followers_url': 'https://api.github.com/users/ssmkhrj/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Hi @ssmkhrj,\r\n\r\nI'd like to share my perspective as to why those behaviours take place. In all cases, I've simply added a `debugger;` statement and then opened the _Sources_ tab in the Dev Tools. Note that all the following links to CodeSandbox are forked versions with a `debugger;` added.\r\n\r\n---\r\n\r\nLe... | 2022-05-04 16:51:39 | 2024-04-17 15:03:43 | 2024-04-17 15:03:42 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: v18 & v17
## Steps To Reproduce
Consider the `App` componen... | {'url': 'https://api.github.com/repos/facebook/react/issues/24493/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24493/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24492 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24492/labels{/name} | https://api.github.com/repos/facebook/react/issues/24492/comments | https://api.github.com/repos/facebook/react/issues/24492/events | https://github.com/facebook/react/issues/24492 | 1,224,956,340 | I_kwDOAJy2Ks5JA1m0 | 24,492 | Bug: Getting Invalid Hook Call Error | {'login': 'singhdilip1007', 'id': 18436894, 'node_id': 'MDQ6VXNlcjE4NDM2ODk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/18436894?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/singhdilip1007', 'html_url': 'https://github.com/singhdilip1007', 'followers_url': 'https://api.github.com/users/si... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'singhdilip1007', 'id': 18436894.0, 'node_id': 'MDQ6VXNlcjE4NDM2ODk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/18436894?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/singhdilip1007', 'html_url': 'https://github.com/singhdilip1007', 'followers_url': 'https://api.github.com/users/... | [{'login': 'singhdilip1007', 'id': 18436894, 'node_id': 'MDQ6VXNlcjE4NDM2ODk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/18436894?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/singhdilip1007', 'html_url': 'https://github.com/singhdilip1007', 'followers_url': 'https://api.github.com/users/s... | null | [
"I think you are missing some rule to call hooks, please go through https://reactjs.org/docs/hooks-rules.html",
"I've followed the details with link shared by you, all things are fine as per above. Thanks @ahmadaafaq ",
"@singhdilip1007 Were you able to resolve the issue then or is it still occurring? If you're... | 2022-05-04 06:06:03 | 2022-05-09 05:57:20 | 2022-05-07 16:43:21 | NONE | null | null | null | This is the code I've written to call square web payments SDK with **.Net wit reactJs application**:
```JavaScript
import React from "react";
import {
SquarePaymentsForm,
CreditCardInput
} from "react-square-web-payments-sdk";
const PaymentFormSdk = () => {
return (
<SquarePaymentsForm ap... | {'url': 'https://api.github.com/repos/facebook/react/issues/24492/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24492/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24491 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24491/labels{/name} | https://api.github.com/repos/facebook/react/issues/24491/comments | https://api.github.com/repos/facebook/react/issues/24491/events | https://github.com/facebook/react/pull/24491 | 1,224,726,032 | PR_kwDOAJy2Ks43Qj7r | 24,491 | [ignore] | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [
"Hi @luigipirandello! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2022-05-03 22:19:43 | 2022-05-03 22:42:23 | 2022-05-03 22:41:47 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24491', 'html_url': 'https://github.com/facebook/react/pull/24491', 'diff_url': 'https://github.com/facebook/react/pull/24491.diff', 'patch_url': 'https://github.com/facebook/react/pull/24491.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24491/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24491/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24490 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24490/labels{/name} | https://api.github.com/repos/facebook/react/issues/24490/comments | https://api.github.com/repos/facebook/react/issues/24490/events | https://github.com/facebook/react/pull/24490 | 1,224,718,895 | PR_kwDOAJy2Ks43QibA | 24,490 | [ignore] | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [
"Hi @luigipirandello! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2022-05-03 22:08:12 | 2022-05-03 22:19:13 | 2022-05-03 22:19:13 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24490', 'html_url': 'https://github.com/facebook/react/pull/24490', 'diff_url': 'https://github.com/facebook/react/pull/24490.diff', 'patch_url': 'https://github.com/facebook/react/pull/24490.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24490/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24490/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24489 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24489/labels{/name} | https://api.github.com/repos/facebook/react/issues/24489/comments | https://api.github.com/repos/facebook/react/issues/24489/events | https://github.com/facebook/react/pull/24489 | 1,224,703,396 | PR_kwDOAJy2Ks43Qe5Z | 24,489 | [ignore] | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [
"Hi @luigipirandello! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2022-05-03 21:57:34 | 2022-05-03 22:17:41 | 2022-05-03 22:04:45 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24489', 'html_url': 'https://github.com/facebook/react/pull/24489', 'diff_url': 'https://github.com/facebook/react/pull/24489.diff', 'patch_url': 'https://github.com/facebook/react/pull/24489.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24489/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24489/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24488 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24488/labels{/name} | https://api.github.com/repos/facebook/react/issues/24488/comments | https://api.github.com/repos/facebook/react/issues/24488/events | https://github.com/facebook/react/pull/24488 | 1,224,695,748 | PR_kwDOAJy2Ks43QdI9 | 24,488 | [ignore] | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [
"Hi @luigipirandello! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2022-05-03 21:53:08 | 2022-05-03 21:54:55 | 2022-05-03 21:54:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24488', 'html_url': 'https://github.com/facebook/react/pull/24488', 'diff_url': 'https://github.com/facebook/react/pull/24488.diff', 'patch_url': 'https://github.com/facebook/react/pull/24488.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24488/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24488/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24487 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24487/labels{/name} | https://api.github.com/repos/facebook/react/issues/24487/comments | https://api.github.com/repos/facebook/react/issues/24487/events | https://github.com/facebook/react/pull/24487 | 1,224,687,369 | PR_kwDOAJy2Ks43QbVG | 24,487 | [ignore] | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [] | closed | false | null | [] | null | [
"Hi @luigipirandello! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn ord... | 2022-05-03 21:44:00 | 2022-05-03 21:49:04 | 2022-05-03 21:48:50 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24487', 'html_url': 'https://github.com/facebook/react/pull/24487', 'diff_url': 'https://github.com/facebook/react/pull/24487.diff', 'patch_url': 'https://github.com/facebook/react/pull/24487.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24487/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24487/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24486 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24486/labels{/name} | https://api.github.com/repos/facebook/react/issues/24486/comments | https://api.github.com/repos/facebook/react/issues/24486/events | https://github.com/facebook/react/pull/24486 | 1,224,648,522 | PR_kwDOAJy2Ks43QS_p | 24,486 | [React DevTools] Fix regex for formateWithStyles function | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2022-05-03 21:02:32 | 2022-05-03 22:52:56 | 2022-05-03 22:52:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24486', 'html_url': 'https://github.com/facebook/react/pull/24486', 'diff_url': 'https://github.com/facebook/react/pull/24486.diff', 'patch_url': 'https://github.com/facebook/react/pull/24486.patch', 'merged_at': datetime.datetime(2022, 5, 3, 22, 52, 56)} | The previous regex to detect string substitutions is not quite right, this PR fixes it by:
1. Check to make sure we are starting either at the beginning of the line or we match a character that's not `%` to make sure we capture all the `%` in a row.
2. Make sure there are an odd number of `%` (the first X pairs are e... | {'url': 'https://api.github.com/repos/facebook/react/issues/24486/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24486/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24485 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24485/labels{/name} | https://api.github.com/repos/facebook/react/issues/24485/comments | https://api.github.com/repos/facebook/react/issues/24485/events | https://github.com/facebook/react/pull/24485 | 1,224,633,517 | PR_kwDOAJy2Ks43QP0U | 24,485 | [temp][wont merge] need some logs for codesandbox | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 99eef9e2df7b6aade461a1a958eb3838239e72c4...91e7ccbc6fe97cd6320a0047ab44c8159b6ddd6d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-03 20:45:18 | 2022-05-09 16:43:06 | 2022-05-09 16:42:44 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/24485', 'html_url': 'https://github.com/facebook/react/pull/24485', 'diff_url': 'https://github.com/facebook/react/pull/24485.diff', 'patch_url': 'https://github.com/facebook/react/pull/24485.patch', 'merged_at': None} | Just getting build artifacts with some extra logs in codesandbox for real browser debugging... will close once I'm done
| {'url': 'https://api.github.com/repos/facebook/react/issues/24485/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24485/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.