url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/24484 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24484/labels{/name} | https://api.github.com/repos/facebook/react/issues/24484/comments | https://api.github.com/repos/facebook/react/issues/24484/events | https://github.com/facebook/react/pull/24484 | 1,224,430,436 | PR_kwDOAJy2Ks43Ppay | 24,484 | Fork ReactSymbols | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 99eef9e2df7b6aade461a1a958eb3838239e72c4...c6a4b18501699e223d0445e5e3a0ffa1a975e99e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-03 18:11:20 | 2022-05-03 22:15:41 | 2022-05-03 21:12:24 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24484', 'html_url': 'https://github.com/facebook/react/pull/24484', 'diff_url': 'https://github.com/facebook/react/pull/24484.diff', 'patch_url': 'https://github.com/facebook/react/pull/24484.patch', 'merged_at': datetime.datetime(2022, 5, 3, 21, 12, 24)} | ## Overview
This should unblock DevTools while we land the Symbol polyfill for internal builds. | {'url': 'https://api.github.com/repos/facebook/react/issues/24484/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24484/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24483 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24483/labels{/name} | https://api.github.com/repos/facebook/react/issues/24483/comments | https://api.github.com/repos/facebook/react/issues/24483/events | https://github.com/facebook/react/pull/24483 | 1,224,380,867 | PR_kwDOAJy2Ks43Pfds | 24,483 | Add test for hiding children after layout destroy | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 99eef9e2df7b6aade461a1a958eb3838239e72c4...025c02325db2eb25d5d6a28b0d62598bc922b4db\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-03 17:19:35 | 2022-05-03 18:24:25 | 2022-05-03 18:24:23 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24483', 'html_url': 'https://github.com/facebook/react/pull/24483', 'diff_url': 'https://github.com/facebook/react/pull/24483.diff', 'patch_url': 'https://github.com/facebook/react/pull/24483.patch', 'merged_at': datetime.datetime(2022, 5, 3, 18, 24, 23)} | Adds test for https://github.com/facebook/react/pull/24446 | {'url': 'https://api.github.com/repos/facebook/react/issues/24483/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24483/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24482 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24482/labels{/name} | https://api.github.com/repos/facebook/react/issues/24482/comments | https://api.github.com/repos/facebook/react/issues/24482/events | https://github.com/facebook/react/pull/24482 | 1,224,050,535 | PR_kwDOAJy2Ks43OaEp | 24,482 | React DevTools 4.24.4 -> 4.24.5 | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Sure thing.",
"You should be able to land this now",
"Thank you. Once you and @mondaychen have a chance to decide on whether #24501 is worth landing or not, I'll re-run the changelog generation script."
] | 2022-05-03 12:46:12 | 2022-05-05 14:27:21 | 2022-05-03 16:10:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24482', 'html_url': 'https://github.com/facebook/react/pull/24482', 'diff_url': 'https://github.com/facebook/react/pull/24482.diff', 'patch_url': 'https://github.com/facebook/react/pull/24482.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/24482/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24482/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24481 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24481/labels{/name} | https://api.github.com/repos/facebook/react/issues/24481/comments | https://api.github.com/repos/facebook/react/issues/24481/events | https://github.com/facebook/react/issues/24481 | 1,223,895,360 | I_kwDOAJy2Ks5I8ylA | 24,481 | Fix bug | {'login': 'Shellanmonk', 'id': 101428829, 'node_id': 'U_kgDOBguuXQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/101428829?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Shellanmonk', 'html_url': 'https://github.com/Shellanmonk', 'followers_url': 'https://api.github.com/users/Shellanmonk/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710573595, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Fixed by https://github.com/facebook/react/pull/24477 which hasn't been released yet."
] | 2022-05-03 09:54:50 | 2022-05-03 10:53:01 | 2022-05-03 10:53:01 | NONE | null | null | null | https://github.com/facebook/react/blob/f7cf077cca6524877cb837adb9a8ff54242672b1/packages/react-devtools-shared/src/inspectedElementMutableSource.js#L102-L107 | {'url': 'https://api.github.com/repos/facebook/react/issues/24481/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24481/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24480 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24480/labels{/name} | https://api.github.com/repos/facebook/react/issues/24480/comments | https://api.github.com/repos/facebook/react/issues/24480/events | https://github.com/facebook/react/pull/24480 | 1,223,456,743 | PR_kwDOAJy2Ks43Mniz | 24,480 | Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ce13860281f833de8a3296b7a3dad9caced102e9...710429e5aab0c3c9326f141e1cf47ae7ce6f440f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-05-02 23:19:18 | 2022-05-03 18:42:22 | 2022-05-03 18:07:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24480', 'html_url': 'https://github.com/facebook/react/pull/24480', 'diff_url': 'https://github.com/facebook/react/pull/24480.diff', 'patch_url': 'https://github.com/facebook/react/pull/24480.patch', 'merged_at': datetime.datetime(2022, 5, 3, 18, 7, 47)} | When hydrating a suspense boundary an error or a suspending fiber can often lead to a cascade of hydration errors. While in many cases these errors are simply discarde (e.g. when the root does not commit and we fall back to client rendering) the use of invokeGuardedCallback can lead to many of these errors appearing as... | {'url': 'https://api.github.com/repos/facebook/react/issues/24480/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24480/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24479 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24479/labels{/name} | https://api.github.com/repos/facebook/react/issues/24479/comments | https://api.github.com/repos/facebook/react/issues/24479/events | https://github.com/facebook/react/pull/24479 | 1,223,195,619 | PR_kwDOAJy2Ks43LvNR | 24,479 | Update exhaustive-deps to handle ref in arrow function return | {'login': 'ybot1122', 'id': 3688288, 'node_id': 'MDQ6VXNlcjM2ODgyODg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3688288?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ybot1122', 'html_url': 'https://github.com/ybot1122', 'followers_url': 'https://api.github.com/users/ybot1122/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request has been automatically marked as stale. **If this pull request is still relevant, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.",
"Closing this pull r... | 2022-05-02 18:19:59 | 2024-04-17 15:03:44 | 2024-04-17 15:03:43 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24479', 'html_url': 'https://github.com/facebook/react/pull/24479', 'diff_url': 'https://github.com/facebook/react/pull/24479.diff', 'patch_url': 'https://github.com/facebook/react/pull/24479.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24479/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24479/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24478 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24478/labels{/name} | https://api.github.com/repos/facebook/react/issues/24478/comments | https://api.github.com/repos/facebook/react/issues/24478/events | https://github.com/facebook/react/pull/24478 | 1,223,113,179 | PR_kwDOAJy2Ks43Ldr1 | 24,478 | Update config.yaml | {'login': 'piergiorgioladisa', 'id': 44639444, 'node_id': 'MDQ6VXNlcjQ0NjM5NDQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/44639444?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/piergiorgioladisa', 'html_url': 'https://github.com/piergiorgioladisa', 'followers_url': 'https://api.github.com... | [] | closed | false | null | [] | null | [
"Hi @piergiorgioladisa! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn o... | 2022-05-02 16:55:24 | 2022-05-02 17:04:07 | 2022-05-02 17:04:07 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24478', 'html_url': 'https://github.com/facebook/react/pull/24478', 'diff_url': 'https://github.com/facebook/react/pull/24478.diff', 'patch_url': 'https://github.com/facebook/react/pull/24478.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24478/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24478/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24477 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24477/labels{/name} | https://api.github.com/repos/facebook/react/issues/24477/comments | https://api.github.com/repos/facebook/react/issues/24477/events | https://github.com/facebook/react/pull/24477 | 1,223,062,530 | PR_kwDOAJy2Ks43LTJe | 24,477 | Fixed wrong method call for LRU cache | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Thanks dan."
] | 2022-05-02 16:04:51 | 2022-05-03 01:17:05 | 2022-05-03 01:17:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24477', 'html_url': 'https://github.com/facebook/react/pull/24477', 'diff_url': 'https://github.com/facebook/react/pull/24477.diff', 'patch_url': 'https://github.com/facebook/react/pull/24477.patch', 'merged_at': datetime.datetime(2022, 5, 3, 1, 17, 1)} | Noticed this bug when inspecting a downstream issue problem. DevTools calls a `remove` method but the LRU cache library doesn't actually define a "remove" method, rather it has a `del` method. (Newer versions of the library have a `delete` method.)
Related to https://github.com/RecordReplay/devtools/issues/6318 | {'url': 'https://api.github.com/repos/facebook/react/issues/24477/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24477/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24476 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24476/labels{/name} | https://api.github.com/repos/facebook/react/issues/24476/comments | https://api.github.com/repos/facebook/react/issues/24476/events | https://github.com/facebook/react/issues/24476 | 1,222,563,445 | I_kwDOAJy2Ks5I3tZ1 | 24,476 | Bug: Context provider updates forcing Suspense fallback on hydration | {'login': 'liuyenwei', 'id': 6487551, 'node_id': 'MDQ6VXNlcjY0ODc1NTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6487551?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/liuyenwei', 'html_url': 'https://github.com/liuyenwei', 'followers_url': 'https://api.github.com/users/liuyenwei/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I described exact same problem in this topic:\r\n\r\nhttps://github.com/vercel/next.js/discussions/36582\r\n\r\nMy project uses Next.js and React Query. Can you post a code snippet how exactly you solved it with useMemo? React Query has it's own cache and I still get this error.",
"This is intentional behavior: ... | 2022-05-02 07:14:04 | 2022-12-21 11:52:08 | 2022-06-20 14:49:40 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.1.0
## Steps To Reproduce
1. Set up a ContextProvider a... | {'url': 'https://api.github.com/repos/facebook/react/issues/24476/reactions', 'total_count': 6, '+1': 6, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24476/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24474 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24474/labels{/name} | https://api.github.com/repos/facebook/react/issues/24474/comments | https://api.github.com/repos/facebook/react/issues/24474/events | https://github.com/facebook/react/pull/24474 | 1,222,203,958 | PR_kwDOAJy2Ks43Ido7 | 24,474 | Update config.yaml | {'login': 'piergiorgioladisa', 'id': 44639444, 'node_id': 'MDQ6VXNlcjQ0NjM5NDQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/44639444?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/piergiorgioladisa', 'html_url': 'https://github.com/piergiorgioladisa', 'followers_url': 'https://api.github.com... | [] | closed | false | null | [] | null | [
"Hi @piergiorgioladisa! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn o... | 2022-05-01 16:09:28 | 2022-05-02 11:22:42 | 2022-05-02 11:22:42 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24474', 'html_url': 'https://github.com/facebook/react/pull/24474', 'diff_url': 'https://github.com/facebook/react/pull/24474.diff', 'patch_url': 'https://github.com/facebook/react/pull/24474.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24474/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24474/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24473 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24473/labels{/name} | https://api.github.com/repos/facebook/react/issues/24473/comments | https://api.github.com/repos/facebook/react/issues/24473/events | https://github.com/facebook/react/pull/24473 | 1,222,195,936 | PR_kwDOAJy2Ks43Ib-B | 24,473 | Update config.yml | {'login': 'Parasimpaticki', 'id': 23506393, 'node_id': 'MDQ6VXNlcjIzNTA2Mzkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/23506393?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Parasimpaticki', 'html_url': 'https://github.com/Parasimpaticki', 'followers_url': 'https://api.github.com/users/Pa... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @Parasimpaticki! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn orde... | 2022-05-01 15:43:32 | 2022-09-29 11:25:46 | 2022-09-29 10:51:45 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24473', 'html_url': 'https://github.com/facebook/react/pull/24473', 'diff_url': 'https://github.com/facebook/react/pull/24473.diff', 'patch_url': 'https://github.com/facebook/react/pull/24473.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24473/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24473/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24472 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24472/labels{/name} | https://api.github.com/repos/facebook/react/issues/24472/comments | https://api.github.com/repos/facebook/react/issues/24472/events | https://github.com/facebook/react/issues/24472 | 1,221,878,029 | I_kwDOAJy2Ks5I1GEN | 24,472 | Bug: BrowserRouter does not work in new render function | {'login': 'NKolva', 'id': 48063163, 'node_id': 'MDQ6VXNlcjQ4MDYzMTYz', 'avatar_url': 'https://avatars.githubusercontent.com/u/48063163?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/NKolva', 'html_url': 'https://github.com/NKolva', 'followers_url': 'https://api.github.com/users/NKolva/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"At first sight, i suspected on of the following (or both) - since you are using `root.render`-:\r\n\r\n- The used `react-router-dom` version isn't `concurrent-feautures-compatible`\r\n- `StrictMode` being more strict.\r\n\r\n\r\nThen I suggest the following:\r\n\r\n- Update `react-router-dom` to latest version\r\n... | 2022-04-30 17:13:54 | 2023-05-09 05:07:52 | 2022-05-01 02:14:53 | NONE | null | null | null | React version: 18.1.0
## Steps To Reproduce
1. Install react-router-dom (v. 5.3.0);
2. In root index.tsx(jsx) file, wrap App with BrowserRouter
3. Implement routes in your application
4. Try navigate via pages
## You can try it in my current project:
https://github.com/NKolva/react-ts-starter-kit/tree/bug/... | {'url': 'https://api.github.com/repos/facebook/react/issues/24472/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24472/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24471 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24471/labels{/name} | https://api.github.com/repos/facebook/react/issues/24471/comments | https://api.github.com/repos/facebook/react/issues/24471/events | https://github.com/facebook/react/pull/24471 | 1,221,691,809 | PR_kwDOAJy2Ks43G32p | 24,471 | Fix: Documentation Issues | {'login': 'sr2echa', 'id': 65058816, 'node_id': 'MDQ6VXNlcjY1MDU4ODE2', 'avatar_url': 'https://avatars.githubusercontent.com/u/65058816?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sr2echa', 'html_url': 'https://github.com/sr2echa', 'followers_url': 'https://api.github.com/users/sr2echa/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @sr2echa! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for u... | 2022-04-30 01:59:02 | 2022-09-29 16:49:43 | 2022-09-29 16:46:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24471', 'html_url': 'https://github.com/facebook/react/pull/24471', 'diff_url': 'https://github.com/facebook/react/pull/24471.diff', 'patch_url': 'https://github.com/facebook/react/pull/24471.patch', 'merged_at': datetime.datetime(2022, 9, 29, 16, 46, 53)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24471/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24471/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24470 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24470/labels{/name} | https://api.github.com/repos/facebook/react/issues/24470/comments | https://api.github.com/repos/facebook/react/issues/24470/events | https://github.com/facebook/react/pull/24470 | 1,221,240,071 | PR_kwDOAJy2Ks43Fd51 | 24,470 | Warn when using one-shot iterators as children | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8ee4f529897bc85220ee1dcfc61613da03c71d55...1610922e9dda667315faf8ea2d520d757b4cfef4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-29 16:45:41 | 2024-04-17 15:03:46 | 2024-04-17 15:03:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24470', 'html_url': 'https://github.com/facebook/react/pull/24470', 'diff_url': 'https://github.com/facebook/react/pull/24470.diff', 'patch_url': 'https://github.com/facebook/react/pull/24470.patch', 'merged_at': None} |
## Summary
Closes https://github.com/facebook/react/issues/20707 by adding a warning when using one-shot iterators.
## How did you test this change?
- [x] https://codesandbox.io/s/one-shot-iterators-as-children-cgdvzg issues warning with build from this PR (based on the linked issue + forward porting to Reac... | {'url': 'https://api.github.com/repos/facebook/react/issues/24470/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24470/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24469 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24469/labels{/name} | https://api.github.com/repos/facebook/react/issues/24469/comments | https://api.github.com/repos/facebook/react/issues/24469/events | https://github.com/facebook/react/issues/24469 | 1,220,945,813 | I_kwDOAJy2Ks5IxieV | 24,469 | Bug: `<select size value>` with `value` not matching any `option` results in first option being selected | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"👋 May I work on this if possible as a first issue",
"I would love to work on this as a first timer issue if it's still open"
] | 2022-04-29 14:22:45 | 2023-07-28 16:50:19 | null | COLLABORATOR | null | null | null |
React version: 18.1.0, 17.0.2
## Steps To Reproduce
1. render `<select value="not-an-option" size="2"><option value="an-option">one</option></select>`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction step... | {'url': 'https://api.github.com/repos/facebook/react/issues/24469/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24469/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/24468 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24468/labels{/name} | https://api.github.com/repos/facebook/react/issues/24468/comments | https://api.github.com/repos/facebook/react/issues/24468/events | https://github.com/facebook/react/issues/24468 | 1,220,904,953 | I_kwDOAJy2Ks5IxYf5 | 24,468 | Bug: React 18 doesn't show memory leak warnings | {'login': 'bushblade', 'id': 21976188, 'node_id': 'MDQ6VXNlcjIxOTc2MTg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/21976188?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bushblade', 'html_url': 'https://github.com/bushblade', 'followers_url': 'https://api.github.com/users/bushblade/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Ah sorry guys, just found #24195"
] | 2022-04-29 14:03:46 | 2022-04-29 14:22:57 | 2022-04-29 14:22:57 | NONE | null | null | null | In React 17 if you tried to update state of a component that had been
removed/unmounted then you would get a warning about it letting you know you had
a memory leak.
In React ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24468/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24468/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24467 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24467/labels{/name} | https://api.github.com/repos/facebook/react/issues/24467/comments | https://api.github.com/repos/facebook/react/issues/24467/events | https://github.com/facebook/react/issues/24467 | 1,220,718,586 | I_kwDOAJy2Ks5Iwq_6 | 24,467 | Bug: Page renders twice when use "ReactDOM.createRoot" in the index.tsx in React 18 | {'login': 'voiceu-zuixin', 'id': 77840482, 'node_id': 'MDQ6VXNlcjc3ODQwNDgy', 'avatar_url': 'https://avatars.githubusercontent.com/u/77840482?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/voiceu-zuixin', 'html_url': 'https://github.com/voiceu-zuixin', 'followers_url': 'https://api.github.com/users/voice... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This is expected behavior in React 18 with StrictMode (and will only happen in dev), you can read more about the change to StrictMode here: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-strict-mode",
"> This is expected behavior in React 18 with StrictMode (and will only happen in de... | 2022-04-29 12:36:52 | 2023-02-24 10:31:57 | 2022-04-29 13:39:21 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:18.1.0
## Steps To Reproduce
1. create-react-app test-render... | {'url': 'https://api.github.com/repos/facebook/react/issues/24467/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24467/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24466 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24466/labels{/name} | https://api.github.com/repos/facebook/react/issues/24466/comments | https://api.github.com/repos/facebook/react/issues/24466/events | https://github.com/facebook/react/issues/24466 | 1,220,512,085 | I_kwDOAJy2Ks5Iv4lV | 24,466 | Bug: Differences between "cjs/react.production.min.js" file and "umd/react.production.min.js": "Scheduler" property is missing in object "React. __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED" in "cjs/react.production.min.js" | {'login': 'zhuchuji', 'id': 12730487, 'node_id': 'MDQ6VXNlcjEyNzMwNDg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12730487?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhuchuji', 'html_url': 'https://github.com/zhuchuji', 'followers_url': 'https://api.github.com/users/zhuchuji/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Could you share more details about why you are attempting to access Scheduler from `React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED`?\r\n\r\nBased on the property you may be accessing it from, it seems like an implementation detail if its there or not and shouldn't be depended upon directly.",
"We do no... | 2022-04-29 10:54:03 | 2024-02-11 19:56:44 | 2024-02-11 19:56:43 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
The production file inside "cjs/react.production.min.js" does not contain the code... | {'url': 'https://api.github.com/repos/facebook/react/issues/24466/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24466/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24465 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24465/labels{/name} | https://api.github.com/repos/facebook/react/issues/24465/comments | https://api.github.com/repos/facebook/react/issues/24465/events | https://github.com/facebook/react/issues/24465 | 1,220,123,342 | I_kwDOAJy2Ks5IuZrO | 24,465 | Bug: Page becomes empty when an input is displayed in a "popup" in Chrome on Android | {'login': 'smartpuffindev', 'id': 102975771, 'node_id': 'U_kgDOBiNJGw', 'avatar_url': 'https://avatars.githubusercontent.com/u/102975771?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/smartpuffindev', 'html_url': 'https://github.com/smartpuffindev', 'followers_url': 'https://api.github.com/users/smartpuf... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"It's the most curious thing! Regarding the \"tweak\" with adding 2 or more input fields to the main screen. As I wrote in the description, if there are 2+ input fields present, the bug \"goes away\" (like on the second screenshot). I have just figured out that the input fields must not only be _present_ on the mai... | 2022-04-29 07:40:03 | 2024-04-17 15:03:48 | 2024-04-17 15:03:47 | NONE | null | null | null | Description: Page becomes empty when an input is displayed in a "popup"; works on desktop, doesn't work in Android Chrome. This is a very specific scenario, please see the example repo and steps below. I must say, I'm not 100% sure this is a react problem, and I have already opened [an issue](https://bugs.chromium.org/... | {'url': 'https://api.github.com/repos/facebook/react/issues/24465/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24465/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24464 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24464/labels{/name} | https://api.github.com/repos/facebook/react/issues/24464/comments | https://api.github.com/repos/facebook/react/issues/24464/events | https://github.com/facebook/react/pull/24464 | 1,219,586,857 | PR_kwDOAJy2Ks42_hBK | 24,464 | Remove outdated comments. | {'login': 'zhangenming', 'id': 21235555, 'node_id': 'MDQ6VXNlcjIxMjM1NTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/21235555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhangenming', 'html_url': 'https://github.com/zhangenming', 'followers_url': 'https://api.github.com/users/zhangenming... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9f80a48ad464c9240ea7f9d3f37251559cf7fe7e...62f5703c48e977074db728717fdb716644d6ea3e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-29 01:59:53 | 2022-09-29 16:40:42 | 2022-09-29 16:40:42 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24464', 'html_url': 'https://github.com/facebook/react/pull/24464', 'diff_url': 'https://github.com/facebook/react/pull/24464.diff', 'patch_url': 'https://github.com/facebook/react/pull/24464.patch', 'merged_at': datetime.datetime(2022, 9, 29, 16, 40, 42)} | fixed by https://github.com/facebook/react/pull/20894
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull reque... | {'url': 'https://api.github.com/repos/facebook/react/issues/24464/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24464/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24463 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24463/labels{/name} | https://api.github.com/repos/facebook/react/issues/24463/comments | https://api.github.com/repos/facebook/react/issues/24463/events | https://github.com/facebook/react/pull/24463 | 1,219,457,658 | PR_kwDOAJy2Ks42_Dby | 24,463 | AttemptContinuousHydration only when blockedOn is new | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ce13860281f833de8a3296b7a3dad9caced102e9...ce404fcdf8bc4fe68eaf3c6a2bec948d9d36e2fc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-28 23:43:36 | 2022-10-26 19:55:19 | 2022-04-29 17:07:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24463', 'html_url': 'https://github.com/facebook/react/pull/24463', 'diff_url': 'https://github.com/facebook/react/pull/24463.diff', 'patch_url': 'https://github.com/facebook/react/pull/24463.patch', 'merged_at': None} | Prior to this change accumulateOrCreateContinuousQueuedReplayableEvent would repeatedly AttemptContinuousHydration even if the existingQueuedEvent was blocked on the same boundary as the current event. This led to a cascade of hydration attempts when there should be just one (unless of the blocking boundary changes). t... | {'url': 'https://api.github.com/repos/facebook/react/issues/24463/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24463/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24462 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24462/labels{/name} | https://api.github.com/repos/facebook/react/issues/24462/comments | https://api.github.com/repos/facebook/react/issues/24462/events | https://github.com/facebook/react/pull/24462 | 1,219,411,219 | PR_kwDOAJy2Ks42-44d | 24,462 | Bump cross-fetch from 3.1.4 to 3.1.5 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 15d6bd79b590631af908adf22f8ab3e71f54e93b...4b7e36a508238bae5863febbb3936dd70c57a021\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-28 22:53:35 | 2022-09-08 14:55:42 | 2022-09-08 14:55:36 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24462', 'html_url': 'https://github.com/facebook/react/pull/24462', 'diff_url': 'https://github.com/facebook/react/pull/24462.diff', 'patch_url': 'https://github.com/facebook/react/pull/24462.patch', 'merged_at': datetime.datetime(2022, 9, 8, 14, 55, 35)} | Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/lquixada/cross-fetch/releases">cross-fetch's releases</a>.</em></p>
<blockquote>
<h2>v3.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>chore: updated no... | {'url': 'https://api.github.com/repos/facebook/react/issues/24462/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24462/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24461 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24461/labels{/name} | https://api.github.com/repos/facebook/react/issues/24461/comments | https://api.github.com/repos/facebook/react/issues/24461/events | https://github.com/facebook/react/issues/24461 | 1,219,209,350 | I_kwDOAJy2Ks5Iq6iG | 24,461 | Bug: Chrome devtools does not shows the warnings, only the vscode terminal | {'login': 'tarrga', 'id': 51264983, 'node_id': 'MDQ6VXNlcjUxMjY0OTgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/51264983?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tarrga', 'html_url': 'https://github.com/tarrga', 'followers_url': 'https://api.github.com/users/tarrga/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi @tarrga , this warning are showed by eslint, so if you want to see this warning/errors in devtools you need to figure out how to setup showing eslint errors in browser. So it's not related to React and propose to close the issue."
] | 2022-04-28 19:54:07 | 2022-05-04 09:35:12 | 2022-05-04 09:35:12 | NONE | null | null | null | Hi!
So, for example when I create some state, like const [name, setName] = useState(''), and If I don't use it in the component, then the chrome devtools should this log on the console, but it does not show up the message like 'Line 14:17: 'name' is assigned a value but never used'. It shows up only in the termina... | {'url': 'https://api.github.com/repos/facebook/react/issues/24461/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24461/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24460 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24460/labels{/name} | https://api.github.com/repos/facebook/react/issues/24460/comments | https://api.github.com/repos/facebook/react/issues/24460/events | https://github.com/facebook/react/pull/24460 | 1,219,131,704 | PR_kwDOAJy2Ks4296xj | 24,460 | Remove enablePersistentOffscreenHostContainer flag | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 340060cccd21b47f364646c894a3406b0f0341ba...06b2aa66e36d34d087441efe67dc6ced91a09007\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-28 18:46:49 | 2022-04-28 19:05:42 | 2022-04-28 19:05:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24460', 'html_url': 'https://github.com/facebook/react/pull/24460', 'diff_url': 'https://github.com/facebook/react/pull/24460.diff', 'patch_url': 'https://github.com/facebook/react/pull/24460.patch', 'merged_at': datetime.datetime(2022, 4, 28, 19, 5, 42)} | This was a Fabric-related experiment that we ended up not shipping. | {'url': 'https://api.github.com/repos/facebook/react/issues/24460/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24460/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24459 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24459/labels{/name} | https://api.github.com/repos/facebook/react/issues/24459/comments | https://api.github.com/repos/facebook/react/issues/24459/events | https://github.com/facebook/react/pull/24459 | 1,218,997,376 | PR_kwDOAJy2Ks429eVR | 24,459 | Fix ignored setState in Safari when iframe is touched | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 340060cccd21b47f364646c894a3406b0f0341ba...b7b40cd3e28b4bf3d531fce4d7b58b62dba892c8\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-28 16:41:23 | 2022-05-12 16:58:24 | 2022-05-12 16:58:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24459', 'html_url': 'https://github.com/facebook/react/pull/24459', 'diff_url': 'https://github.com/facebook/react/pull/24459.diff', 'patch_url': 'https://github.com/facebook/react/pull/24459.patch', 'merged_at': datetime.datetime(2022, 5, 12, 16, 58, 18)} | Fixes https://github.com/facebook/react/issues/24458.
Just like https://github.com/facebook/react/issues/22459, this is caused by a Safari bug (https://bugs.webkit.org/show_bug.cgi?id=235322).
Our original solution for https://github.com/facebook/react/issues/22459 was https://github.com/facebook/react/pull/23111... | {'url': 'https://api.github.com/repos/facebook/react/issues/24459/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24459/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24458 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24458/labels{/name} | https://api.github.com/repos/facebook/react/issues/24458/comments | https://api.github.com/repos/facebook/react/issues/24458/events | https://github.com/facebook/react/issues/24458 | 1,218,834,616 | I_kwDOAJy2Ks5IpfC4 | 24,458 | Bug: setState is not flushed if an iframe is added in the same tick in Safari | {'login': 'kh-viewar', 'id': 16537415, 'node_id': 'MDQ6VXNlcjE2NTM3NDE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/16537415?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kh-viewar', 'html_url': 'https://github.com/kh-viewar', 'followers_url': 'https://api.github.com/users/kh-viewar/followe... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 69105358, 'node_id': 'MDU6TGFiZWw2OTEwNTM1OA==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"I suspect this might be https://github.com/facebook/react/issues/22459#issuecomment-1013362245 showing its head again. Can you check the issue repros in desktop Safari as well?",
"> I suspect this might be [#22459 (comment)](https://github.com/facebook/react/issues/22459#issuecomment-1013362245) showing its head... | 2022-04-28 14:39:31 | 2022-05-12 16:58:18 | 2022-05-12 16:58:18 | NONE | null | null | null | Batched state changes are not flushed if the promise code changes the DOM (= attaching an iframe). Reproduceable with Safari.
React version: 18.1.0
## Steps To Reproduce
1. Open [codepen](https://codepen.io/kh-viewar/pen/wvpVLxM) with Safari.
2. Click "Upload"
3. => "Spinner" text does not render while Promi... | {'url': 'https://api.github.com/repos/facebook/react/issues/24458/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24458/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24457 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24457/labels{/name} | https://api.github.com/repos/facebook/react/issues/24457/comments | https://api.github.com/repos/facebook/react/issues/24457/events | https://github.com/facebook/react/issues/24457 | 1,218,530,441 | I_kwDOAJy2Ks5IoUyJ | 24,457 | Bug: Inconsistent error when violating rules of hooks with `useContext` | {'login': 'hlysine', 'id': 25472513, 'node_id': 'MDQ6VXNlcjI1NDcyNTEz', 'avatar_url': 'https://avatars.githubusercontent.com/u/25472513?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hlysine', 'html_url': 'https://github.com/hlysine', 'followers_url': 'https://api.github.com/users/hlysine/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!",
"C... | 2022-04-28 10:32:59 | 2024-04-17 15:03:49 | 2024-04-17 15:03:49 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0
## The current behavior
The following code throws a ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24457/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24457/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24456 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24456/labels{/name} | https://api.github.com/repos/facebook/react/issues/24456/comments | https://api.github.com/repos/facebook/react/issues/24456/events | https://github.com/facebook/react/pull/24456 | 1,218,164,410 | PR_kwDOAJy2Ks426sDo | 24,456 | Fix typo. | {'login': 'zhangenming', 'id': 21235555, 'node_id': 'MDQ6VXNlcjIxMjM1NTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/21235555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhangenming', 'html_url': 'https://github.com/zhangenming', 'followers_url': 'https://api.github.com/users/zhangenming... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9f80a48ad464c9240ea7f9d3f37251559cf7fe7e...d228ca61ce8a07b0d53a5f4483947855d4f07b1e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-28 04:06:10 | 2022-04-28 18:50:06 | 2022-04-28 18:50:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24456', 'html_url': 'https://github.com/facebook/react/pull/24456', 'diff_url': 'https://github.com/facebook/react/pull/24456.diff', 'patch_url': 'https://github.com/facebook/react/pull/24456.patch', 'merged_at': None} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. For... | {'url': 'https://api.github.com/repos/facebook/react/issues/24456/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24456/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24455 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24455/labels{/name} | https://api.github.com/repos/facebook/react/issues/24455/comments | https://api.github.com/repos/facebook/react/issues/24455/events | https://github.com/facebook/react/issues/24455 | 1,217,871,803 | I_kwDOAJy2Ks5Ilz-7 | 24,455 | Bug: v18 - How to deal with useEffect being called twice in Strict Mode? | {'login': 'enoh-barbu', 'id': 24221572, 'node_id': 'MDQ6VXNlcjI0MjIxNTcy', 'avatar_url': 'https://avatars.githubusercontent.com/u/24221572?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/enoh-barbu', 'html_url': 'https://github.com/enoh-barbu', 'followers_url': 'https://api.github.com/users/enoh-barbu/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Usually you’d want to have some kind of cleanup for your effect. It should either cancel your fetch or make sure you ignore its result by setting a variable inside your effect. Once you do this, there should be no actual difference in behavior.\r\n\r\nIf you cancel your fetch in effect cleanup, only one request wi... | 2022-04-27 20:53:59 | 2022-10-19 01:43:29 | 2022-04-28 01:37:04 | NONE | null | null | null | Runnig this code will execute twice the API call
```
import { useEffect } from "react";
import axios from "axios";
export default function App() {
useEffect(() => {
axios.get("https://gorest.co.in/public/v2/users").then(({ data }) => {
console.log(data);
});
}, []);
return <div class... | {'url': 'https://api.github.com/repos/facebook/react/issues/24455/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24455/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24454 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24454/labels{/name} | https://api.github.com/repos/facebook/react/issues/24454/comments | https://api.github.com/repos/facebook/react/issues/24454/events | https://github.com/facebook/react/pull/24454 | 1,217,819,039 | PR_kwDOAJy2Ks425iRA | 24,454 | My first fork huhuh | {'login': 'Toloknov', 'id': 83515015, 'node_id': 'MDQ6VXNlcjgzNTE1MDE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/83515015?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Toloknov', 'html_url': 'https://github.com/Toloknov', 'followers_url': 'https://api.github.com/users/Toloknov/followers',... | [] | closed | false | null | [] | null | [
"Hi @Toloknov! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for ... | 2022-04-27 19:57:39 | 2022-04-27 20:11:53 | 2022-04-27 20:11:53 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24454', 'html_url': 'https://github.com/facebook/react/pull/24454', 'diff_url': 'https://github.com/facebook/react/pull/24454.diff', 'patch_url': 'https://github.com/facebook/react/pull/24454.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24454/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24454/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24453 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24453/labels{/name} | https://api.github.com/repos/facebook/react/issues/24453/comments | https://api.github.com/repos/facebook/react/issues/24453/events | https://github.com/facebook/react/issues/24453 | 1,217,531,690 | I_kwDOAJy2Ks5Ikg8q | 24,453 | Bug: where are create-react-class sources | {'login': 'guimard', 'id': 47256, 'node_id': 'MDQ6VXNlcjQ3MjU2', 'avatar_url': 'https://avatars.githubusercontent.com/u/47256?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/guimard', 'html_url': 'https://github.com/guimard', 'followers_url': 'https://api.github.com/users/guimard/followers', 'following_ur... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hi,\r\nthe \"create-react-class\" is just a drop in replacement for devs that do not use ES6.\r\nthe sources are the same as can be found in React.createClass() found in the documentation. The API is mostly the same between the two",
"It's here: https://github.com/facebook/react/tree/15.6-dev/addons/create-react... | 2022-04-27 15:37:08 | 2022-06-22 08:53:22 | 2022-05-09 12:21:39 | NONE | null | null | null | Hi,
react documentation mentions that _"`React.createClass` is now available as create-react-class"_, but I cant' find create-react-class outside of npmjs, and it looks like a webpack. Where can I find its sources ?
Cheers, | {'url': 'https://api.github.com/repos/facebook/react/issues/24453/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24453/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24452 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24452/labels{/name} | https://api.github.com/repos/facebook/react/issues/24452/comments | https://api.github.com/repos/facebook/react/issues/24452/events | https://github.com/facebook/react/pull/24452 | 1,217,416,122 | PR_kwDOAJy2Ks424NPk | 24,452 | Refactor getLanesToRetrySynchronouslyOnError by removing unreachable code | {'login': 'wtlin1228', 'id': 16910748, 'node_id': 'MDQ6VXNlcjE2OTEwNzQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/16910748?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wtlin1228', 'html_url': 'https://github.com/wtlin1228', 'followers_url': 'https://api.github.com/users/wtlin1228/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9f80a48ad464c9240ea7f9d3f37251559cf7fe7e...7d82231a93d627b99b057c6ee94ad7d2a37cadce\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-27 14:08:35 | 2024-04-17 15:03:52 | 2024-04-17 15:03:50 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24452', 'html_url': 'https://github.com/facebook/react/pull/24452', 'diff_url': 'https://github.com/facebook/react/pull/24452.diff', 'patch_url': 'https://github.com/facebook/react/pull/24452.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24452/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24452/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24451 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24451/labels{/name} | https://api.github.com/repos/facebook/react/issues/24451/comments | https://api.github.com/repos/facebook/react/issues/24451/events | https://github.com/facebook/react/issues/24451 | 1,217,415,368 | I_kwDOAJy2Ks5IkEjI | 24,451 | Bug: Using Strict mode outside Router breaks my app | {'login': 'BiancaArtola', 'id': 21174759, 'node_id': 'MDQ6VXNlcjIxMTc0NzU5', 'avatar_url': 'https://avatars.githubusercontent.com/u/21174759?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BiancaArtola', 'html_url': 'https://github.com/BiancaArtola', 'followers_url': 'https://api.github.com/users/BiancaAr... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"We'd need a reproducing example (sandbox or a GH project) to know what's happening. It's hard to guess otherwise.",
"It's related to this issue: https://stackoverflow.com/questions/71832720/link-tag-inside-browserrouter-changes-only-the-url-but-doesnt-render-the-compo\r\n\r\nLooks like the strict mode on _React ... | 2022-04-27 14:08:00 | 2022-04-28 19:50:00 | 2022-04-28 19:49:59 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
```
"react": "^18.0.0",
"react-dom": "^18.0.0",
"... | {'url': 'https://api.github.com/repos/facebook/react/issues/24451/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24451/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24450 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24450/labels{/name} | https://api.github.com/repos/facebook/react/issues/24450/comments | https://api.github.com/repos/facebook/react/issues/24450/events | https://github.com/facebook/react/issues/24450 | 1,216,957,593 | I_kwDOAJy2Ks5IiUyZ | 24,450 | Bug: Reconsider of #24439 with checked attribute update | {'login': 'zombieJ', 'id': 5378891, 'node_id': 'MDQ6VXNlcjUzNzg4OTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5378891?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zombieJ', 'html_url': 'https://github.com/zombieJ', 'followers_url': 'https://api.github.com/users/zombieJ/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"In this case you would want to implement a custom snapshot serializer that uses properties instead. In any case, it's not an issue with React but your testing strategy."
] | 2022-04-27 07:59:17 | 2022-04-27 09:20:07 | 2022-04-27 09:20:07 | CONTRIBUTOR | null | null | null | As #24439
Since `enzyme` not support React 18 and we use `testing lib` instead. The `jest` `toMatchSnapshot` on `testing lib` only possible to compare html instead of node props compare. Which means when replace `enzyme` with `testing lib`, the snapshot will always be wrong on re-render.
`toMatchSnapshot` will not pr... | {'url': 'https://api.github.com/repos/facebook/react/issues/24450/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24450/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24449 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24449/labels{/name} | https://api.github.com/repos/facebook/react/issues/24449/comments | https://api.github.com/repos/facebook/react/issues/24449/events | https://github.com/facebook/react/pull/24449 | 1,216,479,035 | PR_kwDOAJy2Ks421Drn | 24,449 | Fill in date in changelog for 18.1 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Already did on main :P",
"> Already did on main :P\r\n\r\nOh... oops",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9c25728d10dac574761359f359e34ca1010a8b11...8eb4430467b859e8f64d552a86e88311c847f407\n\n## Critical size changes\n\nInclu... | 2022-04-26 21:08:26 | 2022-04-26 21:13:32 | 2022-04-26 21:09:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24449', 'html_url': 'https://github.com/facebook/react/pull/24449', 'diff_url': 'https://github.com/facebook/react/pull/24449.diff', 'patch_url': 'https://github.com/facebook/react/pull/24449.patch', 'merged_at': datetime.datetime(2022, 4, 26, 21, 9, 9)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/24449/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24449/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24448 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24448/labels{/name} | https://api.github.com/repos/facebook/react/issues/24448/comments | https://api.github.com/repos/facebook/react/issues/24448/events | https://github.com/facebook/react/pull/24448 | 1,216,462,886 | PR_kwDOAJy2Ks421AMd | 24,448 | Bump `@next` versions | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 22edb9f777d27369fd2c1fad378f74e237b6dfd3...5ef1583423b5dde88295f9a992922b3f971e4de1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-26 20:49:57 | 2022-04-26 20:58:54 | 2022-04-26 20:58:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24448', 'html_url': 'https://github.com/facebook/react/pull/24448', 'diff_url': 'https://github.com/facebook/react/pull/24448.diff', 'patch_url': 'https://github.com/facebook/react/pull/24448.patch', 'merged_at': datetime.datetime(2022, 4, 26, 20, 58, 54)} | 18.2 will be the next release | {'url': 'https://api.github.com/repos/facebook/react/issues/24448/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24448/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24447 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24447/labels{/name} | https://api.github.com/repos/facebook/react/issues/24447/comments | https://api.github.com/repos/facebook/react/issues/24447/events | https://github.com/facebook/react/pull/24447 | 1,216,459,682 | PR_kwDOAJy2Ks420_hC | 24,447 | Bump local package.json versions for 18.1 release | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 22edb9f777d27369fd2c1fad378f74e237b6dfd3...157302762d952957ad8fc0c1ac600cb820b004a1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-26 20:46:07 | 2022-04-26 20:58:44 | 2022-04-26 20:58:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24447', 'html_url': 'https://github.com/facebook/react/pull/24447', 'diff_url': 'https://github.com/facebook/react/pull/24447.diff', 'patch_url': 'https://github.com/facebook/react/pull/24447.patch', 'merged_at': datetime.datetime(2022, 4, 26, 20, 58, 44)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/24447/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24447/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24446 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24446/labels{/name} | https://api.github.com/repos/facebook/react/issues/24446/comments | https://api.github.com/repos/facebook/react/issues/24446/events | https://github.com/facebook/react/pull/24446 | 1,216,405,924 | PR_kwDOAJy2Ks4200AN | 24,446 | Hide children of Offscreen after destroy effects | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6bf3deef59a1c910d4cda57409411cb0a6bcd43e...8c2baefb315b7f0e81d957e273892a4f13bee5ba\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-26 19:49:30 | 2022-05-03 14:16:57 | 2022-05-03 14:16:53 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24446', 'html_url': 'https://github.com/facebook/react/pull/24446', 'diff_url': 'https://github.com/facebook/react/pull/24446.diff', 'patch_url': 'https://github.com/facebook/react/pull/24446.patch', 'merged_at': datetime.datetime(2022, 5, 3, 14, 16, 53)} | Will quickly test internally then land the flag everywhere. | {'url': 'https://api.github.com/repos/facebook/react/issues/24446/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24446/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24445 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24445/labels{/name} | https://api.github.com/repos/facebook/react/issues/24445/comments | https://api.github.com/repos/facebook/react/issues/24445/events | https://github.com/facebook/react/pull/24445 | 1,216,358,256 | PR_kwDOAJy2Ks420pqd | 24,445 | React `version` field should match package.json | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd081376665f5f081dcf4bf72f06b7e563c8046d...9153ed7efbbc123539fc27ede53cbefed52dd4ab\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-26 19:00:43 | 2022-04-26 20:28:48 | 2022-04-26 20:28:48 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24445', 'html_url': 'https://github.com/facebook/react/pull/24445', 'diff_url': 'https://github.com/facebook/react/pull/24445.diff', 'patch_url': 'https://github.com/facebook/react/pull/24445.patch', 'merged_at': datetime.datetime(2022, 4, 26, 20, 28, 48)} | The `version` field exported by the React package currently corresponds to the `@next` release for that build. This updates the build script to output the same version that is used in the package.json file.
It works by doing a find-and-replace of the React version after the build has completed. This is a bit weird b... | {'url': 'https://api.github.com/repos/facebook/react/issues/24445/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24445/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24444 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24444/labels{/name} | https://api.github.com/repos/facebook/react/issues/24444/comments | https://api.github.com/repos/facebook/react/issues/24444/events | https://github.com/facebook/react/pull/24444 | 1,216,346,568 | PR_kwDOAJy2Ks420nLf | 24,444 | Bump async from 2.6.3 to 2.6.4 in /fixtures/flight | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Looks like async is up-to-date now, so this is no longer needed."
] | 2022-04-26 18:47:14 | 2022-08-24 01:35:50 | 2022-08-24 01:35:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24444', 'html_url': 'https://github.com/facebook/react/pull/24444', 'diff_url': 'https://github.com/facebook/react/pull/24444.diff', 'patch_url': 'https://github.com/facebook/react/pull/24444.patch', 'merged_at': None} | Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md">async's changelog</a>.</em></p>
<blockquote>
<h1>v2.6.4</h1>
<ul>
<li>Fix potential prototype pollution exploit (<a href="http... | {'url': 'https://api.github.com/repos/facebook/react/issues/24444/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24444/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24443 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24443/labels{/name} | https://api.github.com/repos/facebook/react/issues/24443/comments | https://api.github.com/repos/facebook/react/issues/24443/events | https://github.com/facebook/react/pull/24443 | 1,216,346,458 | PR_kwDOAJy2Ks420nJ4 | 24,443 | Bump async from 2.6.3 to 2.6.4 in /fixtures/concurrent/time-slicing | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8a9e7b6cefb5e7e94333c7d5fe2cca6541776d5b...a5139363f953588578603dd2a8272ec60c0b3ab2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-26 18:47:06 | 2022-09-09 14:56:34 | 2022-09-09 14:56:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24443', 'html_url': 'https://github.com/facebook/react/pull/24443', 'diff_url': 'https://github.com/facebook/react/pull/24443.diff', 'patch_url': 'https://github.com/facebook/react/pull/24443.patch', 'merged_at': datetime.datetime(2022, 9, 9, 14, 56, 21)} | Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md">async's changelog</a>.</em></p>
<blockquote>
<h1>v2.6.4</h1>
<ul>
<li>Fix potential prototype pollution exploit (<a href="http... | {'url': 'https://api.github.com/repos/facebook/react/issues/24443/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24443/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24442 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24442/labels{/name} | https://api.github.com/repos/facebook/react/issues/24442/comments | https://api.github.com/repos/facebook/react/issues/24442/events | https://github.com/facebook/react/pull/24442 | 1,216,337,408 | PR_kwDOAJy2Ks420lQL | 24,442 | Upgrade react-shallow-renderer to support react 18 | {'login': 'saitonakamura', 'id': 1552189, 'node_id': 'MDQ6VXNlcjE1NTIxODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1552189?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/saitonakamura', 'html_url': 'https://github.com/saitonakamura', 'followers_url': 'https://api.github.com/users/saitona... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd4784c8f8c6b17cf45c712db8ed8ed19a622b26...05fe85e21be09ca2954414c122263be5ac73d5fe\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-26 18:37:04 | 2022-04-27 07:42:19 | 2022-04-26 18:45:04 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24442', 'html_url': 'https://github.com/facebook/react/pull/24442', 'diff_url': 'https://github.com/facebook/react/pull/24442.diff', 'patch_url': 'https://github.com/facebook/react/pull/24442.patch', 'merged_at': datetime.datetime(2022, 4, 26, 18, 45, 4)} | To a [minimum version](https://github.com/enzymejs/react-shallow-renderer/commit/984c4a58c2ad917415286750357178a8c1173c68) that supports react 18
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24442/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24442/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24441 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24441/labels{/name} | https://api.github.com/repos/facebook/react/issues/24441/comments | https://api.github.com/repos/facebook/react/issues/24441/events | https://github.com/facebook/react/issues/24441 | 1,216,016,052 | I_kwDOAJy2Ks5Ieu60 | 24,441 | [DevTools Bug]: TreeContext error: Can't access property "id" in undefined | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Not sure if #24495 will fix your issue. Let me know if you can get a repro!"
] | 2022-04-26 14:07:21 | 2022-05-05 15:46:57 | 2022-05-05 15:46:57 | CONTRIBUTOR | null | null | null | ### Website or app
https://app.replay.io/
### Repro steps
Unfortunately I don't know how to reproduce this bug. It was just logged to Sentry.
It seems like there's a logic bug here though:
https://github.com/facebook/react/blob/bd4784c8f8c6b17cf45c712db8ed8ed19a622b26/packages/react-devtools-shared/src/devtools/... | {'url': 'https://api.github.com/repos/facebook/react/issues/24441/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24441/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24440 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24440/labels{/name} | https://api.github.com/repos/facebook/react/issues/24440/comments | https://api.github.com/repos/facebook/react/issues/24440/events | https://github.com/facebook/react/pull/24440 | 1,215,989,758 | PR_kwDOAJy2Ks42zbEl | 24,440 | Add "exports" field to use-sync-external-store's package.json | {'login': 'latin-1', 'id': 44946699, 'node_id': 'MDQ6VXNlcjQ0OTQ2Njk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/44946699?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/latin-1', 'html_url': 'https://github.com/latin-1', 'followers_url': 'https://api.github.com/users/latin-1/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"doesn't this also need `./` and `./package.json`?",
"Oops, it appears I overlooked something. Updated.",
"~~I'm not sure if `\"./src/*\": \"./src/*\"` is necessary for this package. Should I include that in the `package.json` as well?~~",
"What's the motivation for this?",
"This would help support React Na... | 2022-04-26 13:48:21 | 2022-09-11 05:15:27 | 2022-09-11 05:15:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24440', 'html_url': 'https://github.com/facebook/react/pull/24440', 'diff_url': 'https://github.com/facebook/react/pull/24440.diff', 'patch_url': 'https://github.com/facebook/react/pull/24440.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24440/reactions', 'total_count': 10, '+1': 10, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24440/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24439 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24439/labels{/name} | https://api.github.com/repos/facebook/react/issues/24439/comments | https://api.github.com/repos/facebook/react/issues/24439/events | https://github.com/facebook/react/issues/24439 | 1,215,021,316 | I_kwDOAJy2Ks5Ia8EE | 24,439 | Bug: Checked attribute does not update in the dom | {'login': 'stefanylaforest', 'id': 66086002, 'node_id': 'MDQ6VXNlcjY2MDg2MDAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/66086002?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/stefanylaforest', 'html_url': 'https://github.com/stefanylaforest', 'followers_url': 'https://api.github.com/users... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The current behavior is correct.\r\n\r\nThe confusion stems from the browser reporting the _attribute_ values. However, React sets the checked _property_ on the DOM node. Setting a property is the correct way to update something — attributes are primarily meant to reflect the initial HTML that was loaded in the br... | 2022-04-25 20:40:37 | 2022-07-23 02:40:17 | 2022-04-25 20:53:15 | NONE | null | null | null | React version:
## Steps To Reproduce
1. Go to React's [code pen example ](https://codepen.io/gaearon/pen/wgedvV?editors=0010) you can find the link in the documentation [here](https://reactjs.org/docs/forms.html#handling-multiple-inputs)
2. Inspect " is going " checkbox element
3. uncheck the checkbox
<img ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24439/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24439/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24438 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24438/labels{/name} | https://api.github.com/repos/facebook/react/issues/24438/comments | https://api.github.com/repos/facebook/react/issues/24438/events | https://github.com/facebook/react/pull/24438 | 1,214,998,483 | PR_kwDOAJy2Ks42wIqB | 24,438 | Failing test: Switch between zero and non-zero Hooks | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd4784c8f8c6b17cf45c712db8ed8ed19a622b26...86e6b0ea14952f00fbf570c3212299d4d6cb951e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-25 20:18:11 | 2022-09-09 11:36:46 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24438', 'html_url': 'https://github.com/facebook/react/pull/24438', 'diff_url': 'https://github.com/facebook/react/pull/24438.diff', 'patch_url': 'https://github.com/facebook/react/pull/24438.patch', 'merged_at': None} | Rendering Hooks conditionally is not supported. Linter enforces this.
However, people sometimes forget to use the linter. We should hard-error in this case. See https://github.com/facebook/react/issues/24391 for an example.
It looks like we hard-error when the number of Hooks changed, but not between 0 Hooks and ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24438/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24438/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24437 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24437/labels{/name} | https://api.github.com/repos/facebook/react/issues/24437/comments | https://api.github.com/repos/facebook/react/issues/24437/events | https://github.com/facebook/react/issues/24437 | 1,214,960,165 | I_kwDOAJy2Ks5IatIl | 24,437 | [DevTools Bug] Cannot add node "1" because a node with that id is already in the Store. | {'login': 'edapess', 'id': 47182987, 'node_id': 'MDQ6VXNlcjQ3MTgyOTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/47182987?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/edapess', 'html_url': 'https://github.com/edapess', 'followers_url': 'https://api.github.com/users/edapess/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'edapess', 'id': 47182987.0, 'node_id': 'MDQ6VXNlcjQ3MTgyOTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/47182987?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/edapess', 'html_url': 'https://github.com/edapess', 'followers_url': 'https://api.github.com/users/edapess/followers', '... | [{'login': 'edapess', 'id': 47182987, 'node_id': 'MDQ6VXNlcjQ3MTgyOTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/47182987?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/edapess', 'html_url': 'https://github.com/edapess', 'followers_url': 'https://api.github.com/users/edapess/followers', 'f... | null | [
"@edavetisyan I was having the same issue and it turns out I had two instances of React Dev Tools running concurrently. \r\n\r\nWhat I think happened is that when I turned on Sync in Edge, it had installed a second instance of Dev Tools. Notice I have 'components' and 'profiler' showing up twice here. Removing one ... | 2022-04-25 19:40:15 | 2022-09-28 08:01:04 | 2022-09-28 08:00:37 | NONE | null | null | null | ### Website or app
https://github.com/edavetisyan/Recipes
### Repro steps
running react-native debugger
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-core
### DevTools version (automated)
4.14.0-d0ec283819
### Error message (automated)
Cannot add node "1" be... | {'url': 'https://api.github.com/repos/facebook/react/issues/24437/reactions', 'total_count': 19, '+1': 19, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24437/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24436 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24436/labels{/name} | https://api.github.com/repos/facebook/react/issues/24436/comments | https://api.github.com/repos/facebook/react/issues/24436/events | https://github.com/facebook/react/pull/24436 | 1,214,748,451 | PR_kwDOAJy2Ks42vTD7 | 24,436 | Add test case for hydration warning suppression | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd4784c8f8c6b17cf45c712db8ed8ed19a622b26...06b78250e1611ebfcbf2678fef84ed1179e88e81\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-25 16:18:11 | 2022-04-29 21:59:31 | 2022-04-28 22:52:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24436', 'html_url': 'https://github.com/facebook/react/pull/24436', 'diff_url': 'https://github.com/facebook/react/pull/24436.diff', 'patch_url': 'https://github.com/facebook/react/pull/24436.patch', 'merged_at': None} | In #24404 a test case was added for supressing hydration warnings if a preceding component suspends. The test case showed that hydration warnings would still emit after resolution but it did not include a test case for when the resolution led to a complete hydration without errors. This commit adds the additional test ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24436/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24436/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24435 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24435/labels{/name} | https://api.github.com/repos/facebook/react/issues/24435/comments | https://api.github.com/repos/facebook/react/issues/24435/events | https://github.com/facebook/react/pull/24435 | 1,214,734,390 | PR_kwDOAJy2Ks42vP-w | 24,435 | chore: fix incorrect comments | {'login': 'mochalhui', 'id': 49441443, 'node_id': 'MDQ6VXNlcjQ5NDQxNDQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/49441443?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mochalhui', 'html_url': 'https://github.com/mochalhui', 'followers_url': 'https://api.github.com/users/mochalhui/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @mochalhui! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for... | 2022-04-25 16:06:36 | 2022-04-26 02:19:49 | 2022-04-26 02:19:49 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24435', 'html_url': 'https://github.com/facebook/react/pull/24435', 'diff_url': 'https://github.com/facebook/react/pull/24435.diff', 'patch_url': 'https://github.com/facebook/react/pull/24435.patch', 'merged_at': None} | chore: fix incorrect comments
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the... | {'url': 'https://api.github.com/repos/facebook/react/issues/24435/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24435/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24434 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24434/labels{/name} | https://api.github.com/repos/facebook/react/issues/24434/comments | https://api.github.com/repos/facebook/react/issues/24434/events | https://github.com/facebook/react/pull/24434 | 1,214,607,811 | PR_kwDOAJy2Ks42u0ql | 24,434 | Revert #24236 (Don't recreate the same fallback on the client if hydrating suspends) | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"> I commented out the new tests.\r\n\r\nYou can use `@gate FIXME` to declare that they are expected to fail",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 6d3b6d0f408136479d7298f1a14d79e8a12f0c65...d7a9ef36afcb80ff56b994a810f9852c50be5d52... | 2022-04-25 14:35:41 | 2022-04-25 15:16:32 | 2022-04-25 15:16:32 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24434', 'html_url': 'https://github.com/facebook/react/pull/24434', 'diff_url': 'https://github.com/facebook/react/pull/24434.diff', 'patch_url': 'https://github.com/facebook/react/pull/24434.patch', 'merged_at': datetime.datetime(2022, 4, 25, 15, 16, 32)} | Reverts https://github.com/facebook/react/pull/24236. It seems to be the cause of a late mutations regression on WWW. We don't know why but we should revert to unblock the next syncs.
I commented out the new tests. | {'url': 'https://api.github.com/repos/facebook/react/issues/24434/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24434/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24433 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24433/labels{/name} | https://api.github.com/repos/facebook/react/issues/24433/comments | https://api.github.com/repos/facebook/react/issues/24433/events | https://github.com/facebook/react/issues/24433 | 1,214,192,736 | I_kwDOAJy2Ks5IXxxg | 24,433 | Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17? | {'login': 'fahadashiq12', 'id': 44393684, 'node_id': 'MDQ6VXNlcjQ0MzkzNjg0', 'avatar_url': 'https://avatars.githubusercontent.com/u/44393684?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fahadashiq12', 'html_url': 'https://github.com/fahadashiq12', 'followers_url': 'https://api.github.com/users/fahadash... | [] | closed | false | null | [] | null | [
"The message you pasted includes the link which explains what to do."
] | 2022-04-25 09:00:56 | 2022-04-25 13:40:46 | 2022-04-25 13:40:45 | NONE | null | null | null | My browser constantly throws this text in the console screen react-dom.development.js:86 Warning: ReactDOM.render is no longer supported in React 18. Use create root instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot | {'url': 'https://api.github.com/repos/facebook/react/issues/24433/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24433/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24432 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24432/labels{/name} | https://api.github.com/repos/facebook/react/issues/24432/comments | https://api.github.com/repos/facebook/react/issues/24432/events | https://github.com/facebook/react/issues/24432 | 1,213,795,497 | I_kwDOAJy2Ks5IWQyp | 24,432 | [DevTools Bug]: Type '{}' is not assignable to type 'ReactNode' | {'login': 'lucasaugustsof', 'id': 71651661, 'node_id': 'MDQ6VXNlcjcxNjUxNjYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/71651661?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lucasaugustsof', 'html_url': 'https://github.com/lucasaugustsof', 'followers_url': 'https://api.github.com/users/lu... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1168115654, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"You probably have multiple versions of `@types/react` installed. See https://github.com/facebook/react/issues/24304#issuecomment-1094565891 for more information on how to fix this.\r\n\r\nIf this doesn't help, please [open a new issue in the DefinitelyTyped/DefinitelyTyped repository](https://github.com/Definitely... | 2022-04-24 23:07:53 | 2022-04-25 05:47:44 | 2022-04-25 05:47:35 | NONE | null | null | null | ### Website or app
https://github.com/devnautas/happy-app
### Repro steps
Creating a custom component with styled-components
### How often does this bug happen?
Every time
### DevTools package (aut... | {'url': 'https://api.github.com/repos/facebook/react/issues/24432/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24432/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24431 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24431/labels{/name} | https://api.github.com/repos/facebook/react/issues/24431/comments | https://api.github.com/repos/facebook/react/issues/24431/events | https://github.com/facebook/react/issues/24431 | 1,213,526,876 | I_kwDOAJy2Ks5IVPNc | 24,431 | Bug: React 18 + useEffect cleanup runs immediately after render | {'login': 'tianhuil', 'id': 1906321, 'node_id': 'MDQ6VXNlcjE5MDYzMjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1906321?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tianhuil', 'html_url': 'https://github.com/tianhuil', 'followers_url': 'https://api.github.com/users/tianhuil/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"In React 18 effects runs effects twice in strict mode (i.e. effect -> cleanup -> effect), so this is totally expected",
"As was mentioned, this is expected behavior that got introduced in React 18: https://reactjs.org/blog/2022/03/29/react-v18.html#new-strict-mode-behaviors",
"Thanks @vkurchatkin, @eps1lon ",
... | 2022-04-24 04:33:31 | 2022-07-17 18:44:01 | 2022-04-24 09:13:44 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 19
## Steps To Reproduce
Here is a bare-bones react app wit... | {'url': 'https://api.github.com/repos/facebook/react/issues/24431/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24431/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24430 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24430/labels{/name} | https://api.github.com/repos/facebook/react/issues/24430/comments | https://api.github.com/repos/facebook/react/issues/24430/events | https://github.com/facebook/react/issues/24430 | 1,213,504,367 | I_kwDOAJy2Ks5IVJtv | 24,430 | Bug: Hydration mismatch error due to plugins generating script tag on top | {'login': 'yongdamsh', 'id': 4126644, 'node_id': 'MDQ6VXNlcjQxMjY2NDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4126644?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yongdamsh', 'html_url': 'https://github.com/yongdamsh', 'followers_url': 'https://api.github.com/users/yongdamsh/followers... | [{'id': 710332294, 'node_id': 'MDU6TGFiZWw3MTAzMzIyOTQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Server%20Rendering', 'name': 'Component: Server Rendering', 'color': 'd4c5f9', 'default': False, 'description': None}
{'id': 1775955521, 'node_id': 'MDU6TGFiZWwxNzc1OTU1NTIx', 'url': 'https... | open | false | {'login': 'gnoff', 'id': 2716369.0, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_... | [{'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_u... | null | [
"Might be related to (or same as) https://github.com/facebook/react/issues/22833, but let's keep both open for now",
"Is the `hydrateRoot` function expecting the whole html document to be exactly what gets rendered by `renderToPipeableStream`? The best would be to just try to hydrate the React root element where ... | 2022-04-24 02:16:30 | 2024-03-01 22:27:32 | null | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0, 18.1.0-next-fc47cb1b6-20220404 (latest version in codesan... | {'url': 'https://api.github.com/repos/facebook/react/issues/24430/reactions', 'total_count': 83, '+1': 83, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24430/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/24429 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24429/labels{/name} | https://api.github.com/repos/facebook/react/issues/24429/comments | https://api.github.com/repos/facebook/react/issues/24429/events | https://github.com/facebook/react/issues/24429 | 1,213,471,896 | I_kwDOAJy2Ks5IVByY | 24,429 | Bug: useEffect Error | {'login': 'deyviRC', 'id': 68449193, 'node_id': 'MDQ6VXNlcjY4NDQ5MTkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/68449193?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/deyviRC', 'html_url': 'https://github.com/deyviRC', 'followers_url': 'https://api.github.com/users/deyviRC/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Seems to be related to #24431 ",
"Seems to be related to #24431 ",
"This is expected behavior that got introduced in React 18: https://reactjs.org/blog/2022/03/29/react-v18.html#new-strict-mode-behaviors",
"thanks for the answer it's already solved"
] | 2022-04-23 22:50:35 | 2022-04-29 10:23:06 | 2022-04-24 09:14:22 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0
## Steps To Reproduce
1.When I put useEffect and add... | {'url': 'https://api.github.com/repos/facebook/react/issues/24429/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24429/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24428 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24428/labels{/name} | https://api.github.com/repos/facebook/react/issues/24428/comments | https://api.github.com/repos/facebook/react/issues/24428/events | https://github.com/facebook/react/issues/24428 | 1,213,357,566 | I_kwDOAJy2Ks5IUl3- | 24,428 | [DevTools Bug]: forwardRef components not marked as "rendered" if context changed | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'lunaruan', 'id': 2735514.0, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers',... | [{'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', ... | null | [
"Hey, I tried the steps you mentioned with the same version of Dev Tools and it works for me (image attached) on Chrome (Version 100.0.4896.127 (Official Build) (64-bit)), could you also mention the browser and its version along with your operating system and version.\r\n\r\n![image](https://user-images.githubuserc... | 2022-04-23 16:38:15 | 2022-05-04 20:25:28 | 2022-05-04 20:25:28 | COLLABORATOR | null | null | null | ### Website or app
https://codesandbox.io/s/forwardref-context-change-did-not-render-lpdk4t?file=/src/index.js
### Repro steps
1. Goto https://lpdk4t.csb.app/
1. Start profiling
3. Enter "a" into the input
4. Stop profiling
![forwardRef-did-not-render](https://user-images.githubusercontent.com/12292047/164... | {'url': 'https://api.github.com/repos/facebook/react/issues/24428/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24428/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24427 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24427/labels{/name} | https://api.github.com/repos/facebook/react/issues/24427/comments | https://api.github.com/repos/facebook/react/issues/24427/events | https://github.com/facebook/react/pull/24427 | 1,212,830,672 | PR_kwDOAJy2Ks42piMl | 24,427 | Avoid accumulating hydration mismatch errors after the first hydration error | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd081376665f5f081dcf4bf72f06b7e563c8046d...d016d50e633bb8c822db30b265b49f5fd902f155\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-22 21:50:01 | 2022-05-03 18:08:01 | 2022-05-03 17:28:27 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24427', 'html_url': 'https://github.com/facebook/react/pull/24427', 'diff_url': 'https://github.com/facebook/react/pull/24427.diff', 'patch_url': 'https://github.com/facebook/react/pull/24427.patch', 'merged_at': None} | This PR attempts to make reasonably simple interventions to improve the situation with error logging / reporting for hydration errors without introducing significant new runtime costs. It is clear that the larger refactor of hydration is where the most gains will come from in simplifying the error pathways for hydratio... | {'url': 'https://api.github.com/repos/facebook/react/issues/24427/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24427/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24425 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24425/labels{/name} | https://api.github.com/repos/facebook/react/issues/24425/comments | https://api.github.com/repos/facebook/react/issues/24425/events | https://github.com/facebook/react/issues/24425 | 1,211,939,278 | I_kwDOAJy2Ks5IPLnO | 24,425 | Bug: confused with react 18 render twice | {'login': 'mankeheaven', 'id': 17426397, 'node_id': 'MDQ6VXNlcjE3NDI2Mzk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/17426397?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mankeheaven', 'html_url': 'https://github.com/mankeheaven', 'followers_url': 'https://api.github.com/users/mankeheaven... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"how to create a xterm once if render twice?",
"React 18 renders your component twice in development mode. This is done to detect problems with purity. Your component has to be pure. You shouldn't change any variables that were created before your component.\r\n\r\nSee react docs: https://beta.reactjs.org/learn/k... | 2022-04-22 07:31:52 | 2023-04-17 06:32:40 | 2022-04-22 08:35:30 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:18.0.0
with 18
```
import ReactDOM from "react-dom/client";
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24425/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24425/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24424 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24424/labels{/name} | https://api.github.com/repos/facebook/react/issues/24424/comments | https://api.github.com/repos/facebook/react/issues/24424/events | https://github.com/facebook/react/issues/24424 | 1,211,922,388 | I_kwDOAJy2Ks5IPHfU | 24,424 | Question about React.Fragment and dangerouslySetInnerHTML | {'login': 'ly01112020', 'id': 4043937, 'node_id': 'MDQ6VXNlcjQwNDM5Mzc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4043937?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ly01112020', 'html_url': 'https://github.com/ly01112020', 'followers_url': 'https://api.github.com/users/ly01112020/follo... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"The [`dangerouslySetInnerHTML` property](https://reactjs.org/docs/dom-elements.html#dangerouslysetinnerhtml) is something the React DOM renderer supports, specifically for the DOM elements it creates. It's not a general React pattern, and it's not supported by environment-agnostic component types like `Fragment`.\... | 2022-04-22 07:15:07 | 2022-04-23 13:36:33 | 2022-04-23 13:36:20 | NONE | null | null | null |
React version: 17.0.0
React.Fragment Why not dangerouslySetInnerHTML property
| {'url': 'https://api.github.com/repos/facebook/react/issues/24424/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24424/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24423 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24423/labels{/name} | https://api.github.com/repos/facebook/react/issues/24423/comments | https://api.github.com/repos/facebook/react/issues/24423/events | https://github.com/facebook/react/issues/24423 | 1,211,595,764 | I_kwDOAJy2Ks5IN3v0 | 24,423 | Bug: destroy is not function | {'login': 'pignax', 'id': 19655052, 'node_id': 'MDQ6VXNlcjE5NjU1MDUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/19655052?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pignax', 'html_url': 'https://github.com/pignax', 'followers_url': 'https://api.github.com/users/pignax/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"We can’t help without a reproducing case. But what’s happening likely is that you’re returning something that’s not a function from your useEffect. ",
"@[gaearon](https://github.com/gaearon) someone had updated the React version to 18 and there was this problem in the project",
"@pignax You probably returned ... | 2022-04-21 22:02:39 | 2023-03-09 19:06:22 | 2022-04-21 22:10:18 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/24423/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24423/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24422 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24422/labels{/name} | https://api.github.com/repos/facebook/react/issues/24422/comments | https://api.github.com/repos/facebook/react/issues/24422/events | https://github.com/facebook/react/pull/24422 | 1,211,500,548 | PR_kwDOAJy2Ks42lS1M | 24,422 | Update App.js | {'login': 'pignax', 'id': 19655052, 'node_id': 'MDQ6VXNlcjE5NjU1MDUy', 'avatar_url': 'https://avatars.githubusercontent.com/u/19655052?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pignax', 'html_url': 'https://github.com/pignax', 'followers_url': 'https://api.github.com/users/pignax/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd081376665f5f081dcf4bf72f06b7e563c8046d...5959d207408569edde795780752d2de8af9bf8bf\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-21 20:08:19 | 2022-04-21 22:08:39 | 2022-04-21 22:08:39 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24422', 'html_url': 'https://github.com/facebook/react/pull/24422', 'diff_url': 'https://github.com/facebook/react/pull/24422.diff', 'patch_url': 'https://github.com/facebook/react/pull/24422.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24422/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24422/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24421 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24421/labels{/name} | https://api.github.com/repos/facebook/react/issues/24421/comments | https://api.github.com/repos/facebook/react/issues/24421/events | https://github.com/facebook/react/pull/24421 | 1,211,279,412 | PR_kwDOAJy2Ks42kkg_ | 24,421 | forwardRef et al shouldn't affect if props object is reused | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: bd081376665f5f081dcf4bf72f06b7e563c8046d...3b190a6749fbc1f609273803267999394586c71a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-21 16:33:03 | 2022-04-22 18:23:27 | 2022-04-22 18:23:26 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24421', 'html_url': 'https://github.com/facebook/react/pull/24421', 'diff_url': 'https://github.com/facebook/react/pull/24421.diff', 'patch_url': 'https://github.com/facebook/react/pull/24421.patch', 'merged_at': datetime.datetime(2022, 4, 22, 18, 23, 26)} | We don't have strong guarantees that the props object is referentially equal during updates where we can't bail out anyway — like if the props are shallowly equal, but there's a local state or context update in the same batch.
However, as a principle, we should aim to make the behavior consistent across different wa... | {'url': 'https://api.github.com/repos/facebook/react/issues/24421/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24421/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24420 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24420/labels{/name} | https://api.github.com/repos/facebook/react/issues/24420/comments | https://api.github.com/repos/facebook/react/issues/24420/events | https://github.com/facebook/react/issues/24420 | 1,211,203,483 | I_kwDOAJy2Ks5IMX-b | 24,420 | Bug: ERR_PACKAGE_PATH_NOT_EXPORTED | {'login': 'artola', 'id': 11500763, 'node_id': 'MDQ6VXNlcjExNTAwNzYz', 'avatar_url': 'https://avatars.githubusercontent.com/u/11500763?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/artola', 'html_url': 'https://github.com/artola', 'followers_url': 'https://api.github.com/users/artola/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"It is not supported to directly import UMD bundles. Moreover, we will likely remove the UMD bundles in a future major release in favor of ESM ones. Why do you need this?",
"> It is not supported to directly import UMD bundles. Moreover, we will likely remove the UMD bundles in a future major release in favor of ... | 2022-04-21 15:29:06 | 2024-04-17 15:03:53 | 2024-04-17 15:03:52 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18
## Steps To Reproduce
1. Execute in NodeJS the following... | {'url': 'https://api.github.com/repos/facebook/react/issues/24420/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24420/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/24418 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24418/labels{/name} | https://api.github.com/repos/facebook/react/issues/24418/comments | https://api.github.com/repos/facebook/react/issues/24418/events | https://github.com/facebook/react/issues/24418 | 1,211,100,361 | I_kwDOAJy2Ks5IL-zJ | 24,418 | [DevTools Bug]: Error in event handler: Error: Attempting to use a disconnected port object | {'login': 'himankpathak', 'id': 26011845, 'node_id': 'MDQ6VXNlcjI2MDExODQ1', 'avatar_url': 'https://avatars.githubusercontent.com/u/26011845?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/himankpathak', 'html_url': 'https://github.com/himankpathak', 'followers_url': 'https://api.github.com/users/himankpa... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Duplicate issue."
] | 2022-04-21 14:08:39 | 2022-04-21 14:08:59 | 2022-04-21 14:08:59 | NONE | null | null | null | ### Website or app
https://codesandbox.io/s/blissful-raman-2on7k2
### Repro steps
1. Create a react app
```
yarn create react-app test-react
cd test-react
yarn start
```
2. Create `.env.development` file in root.
```
HTTPS=true
PORT=4100
BROWSER=none
```
3. Visit https://localhost:4100/ in Chrome v100.0... | {'url': 'https://api.github.com/repos/facebook/react/issues/24418/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24418/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24417 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24417/labels{/name} | https://api.github.com/repos/facebook/react/issues/24417/comments | https://api.github.com/repos/facebook/react/issues/24417/events | https://github.com/facebook/react/issues/24417 | 1,211,096,168 | I_kwDOAJy2Ks5IL9xo | 24,417 | [DevTools Bug]: Error in event handler: Error: Attempting to use a disconnected port object | {'login': 'himankpathak', 'id': 26011845, 'node_id': 'MDQ6VXNlcjI2MDExODQ1', 'avatar_url': 'https://avatars.githubusercontent.com/u/26011845?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/himankpathak', 'html_url': 'https://github.com/himankpathak', 'followers_url': 'https://api.github.com/users/himankpa... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Hey! Thanks for reporting. This is a known Chrome issue that is targeted to be fixed in v102. Check out #24093 for a list of potential workarounds. Closing this because it's a duplicate.",
"@lunaruan The bug still exists with Chrome 115 and devTool 4.28.0.\r\nCould you provide chromium issue link about it?\r\n",... | 2022-04-21 14:05:31 | 2024-04-26 21:20:01 | 2022-05-04 18:50:47 | NONE | null | null | null | ### Website or app
https://codesandbox.io/s/blissful-raman-2on7k2
### Repro steps
1. Create a react app
```
yarn create react-app test-react
cd test-react
yarn start
```
2. Create `.env.development` file in root.
```
HTTPS=true
PORT=4100
BROWSER=none
```
3. Visit https://localhost:4100/ in Chrome ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24417/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24417/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24416 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24416/labels{/name} | https://api.github.com/repos/facebook/react/issues/24416/comments | https://api.github.com/repos/facebook/react/issues/24416/events | https://github.com/facebook/react/issues/24416 | 1,210,752,425 | I_kwDOAJy2Ks5IKp2p | 24,416 | Bug: useEffect(() =>{},[]) in React18，execute twice | {'login': 'maohui66661', 'id': 7902405, 'node_id': 'MDQ6VXNlcjc5MDI0MDU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7902405?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maohui66661', 'html_url': 'https://github.com/maohui66661', 'followers_url': 'https://api.github.com/users/maohui66661/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I had same problem in 18.0.0",
"I had same problem in 18.0.0",
"I think it is expected behaviour in dev mode when using strict mode. Can you confirm if it executes twice in production mode too? ",
"I have some issues, and it was running normally in production mode.",
"This is expected development-only beha... | 2022-04-21 09:20:09 | 2022-06-16 14:07:26 | 2022-04-21 13:34:08 | NONE | null | null | null | width React18,the callback of useEffect is executed twice,when the dependency array is empty.but width react17.0.2 ,execute once.
React version:18.0.0
## Steps To Reproduce
React18 demo:[https://codesandbox.io/s/happy-leakey-nc6d6u](url)
![image](https://user-images.githubusercontent.com/7902405/164422489-1ed3a... | {'url': 'https://api.github.com/repos/facebook/react/issues/24416/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24416/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24415 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24415/labels{/name} | https://api.github.com/repos/facebook/react/issues/24415/comments | https://api.github.com/repos/facebook/react/issues/24415/events | https://github.com/facebook/react/issues/24415 | 1,210,737,773 | I_kwDOAJy2Ks5IKmRt | 24,415 | Bug: why v17.0.2 react version is 17.0.0 | {'login': '2239559319', 'id': 34960995, 'node_id': 'MDQ6VXNlcjM0OTYwOTk1', 'avatar_url': 'https://avatars.githubusercontent.com/u/34960995?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/2239559319', 'html_url': 'https://github.com/2239559319', 'followers_url': 'https://api.github.com/users/2239559319/fol... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.co... | closed | false | null | [] | null | [
"Duplicate of https://github.com/facebook/react/issues/24079"
] | 2022-04-21 09:07:16 | 2022-04-24 09:42:30 | 2022-04-24 09:42:23 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
[version](https://github.com/facebook/react/blob/v17.0.2/packages/react/package.js... | {'url': 'https://api.github.com/repos/facebook/react/issues/24415/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24415/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24414 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24414/labels{/name} | https://api.github.com/repos/facebook/react/issues/24414/comments | https://api.github.com/repos/facebook/react/issues/24414/events | https://github.com/facebook/react/issues/24414 | 1,210,466,147 | I_kwDOAJy2Ks5IJj9j | 24,414 | Bug: Exception using both input and useState | {'login': 'yh4922', 'id': 18353610, 'node_id': 'MDQ6VXNlcjE4MzUzNjEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/18353610?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yh4922', 'html_url': 'https://github.com/yh4922', 'followers_url': 'https://api.github.com/users/yh4922/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"i would like to work on this one @yh4922 ",
"@khareyash05 I have the codesandbox minimal reproduction code above",
"It's expected behavior.\nhttps://github.com/reactjs/rfcs/pull/201",
"This is expected behavior that's currently not explicitly documented. However, the beta docs have a dedicated section for th... | 2022-04-21 04:03:43 | 2022-04-23 16:16:07 | 2022-04-23 16:16:02 | NONE | null | null | null | ### Reproduction link
[](https://codesandbox.io/s/dai-sou-suo-kuang-antd-4-20-0-alpha-1-forked-s7gyfc?file=/demo.js:16-24)
### Steps to reproduce
Use `const [val, setVal] = useState("");` to bind the input value After calling the `se... | {'url': 'https://api.github.com/repos/facebook/react/issues/24414/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24414/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24413 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24413/labels{/name} | https://api.github.com/repos/facebook/react/issues/24413/comments | https://api.github.com/repos/facebook/react/issues/24413/events | https://github.com/facebook/react/pull/24413 | 1,210,438,254 | PR_kwDOAJy2Ks42h48V | 24,413 | Fix: useDeferredValue should reuse previous value, not revert to initial value | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2022-04-21 03:10:32 | 2022-04-21 03:43:59 | 2022-04-21 03:30:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24413', 'html_url': 'https://github.com/facebook/react/pull/24413', 'diff_url': 'https://github.com/facebook/react/pull/24413.diff', 'patch_url': 'https://github.com/facebook/react/pull/24413.patch', 'merged_at': datetime.datetime(2022, 4, 21, 3, 30, 47)} | During an urgent update, useDeferredValue should reuse the previous value. The regression test I added shows that it was reverting to the initial value instead.
The cause of the bug was trivial: the update path doesn't update the hook's `memoizedState` field. Only the mount path.
None of the existing tests happen... | {'url': 'https://api.github.com/repos/facebook/react/issues/24413/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24413/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24412 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24412/labels{/name} | https://api.github.com/repos/facebook/react/issues/24412/comments | https://api.github.com/repos/facebook/react/issues/24412/events | https://github.com/facebook/react/pull/24412 | 1,210,299,413 | PR_kwDOAJy2Ks42hcUw | 24,412 | remove dead code: workInProgressRootIncludedLanes | {'login': 'sunderls', 'id': 2394070, 'node_id': 'MDQ6VXNlcjIzOTQwNzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2394070?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sunderls', 'html_url': 'https://github.com/sunderls', 'followers_url': 'https://api.github.com/users/sunderls/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"CI failed but I believe it is not related to changes in this PR",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9ae80d6a2bf8f48f20e3d62b9672f21c1ff77bd8...270553123155341b5f96a3b9aab07074584979b2\n\n## Critical size changes\n\nIncludes cri... | 2022-04-20 22:51:46 | 2023-03-19 23:48:16 | 2023-03-19 23:48:16 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24412', 'html_url': 'https://github.com/facebook/react/pull/24412', 'diff_url': 'https://github.com/facebook/react/pull/24412.diff', 'patch_url': 'https://github.com/facebook/react/pull/24412.patch', 'merged_at': None} | ## Summary
I tried to understand how `workInProgressRootIncludedLanes` works and found it is not used anywhere
So I created this PR to delete the dead code
## How did you test this change?
I think the tests and linters should be enough.
```
yarn test
yarn test --prod
yarn lint
yarn flow
```
| {'url': 'https://api.github.com/repos/facebook/react/issues/24412/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24412/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24411 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24411/labels{/name} | https://api.github.com/repos/facebook/react/issues/24411/comments | https://api.github.com/repos/facebook/react/issues/24411/events | https://github.com/facebook/react/pull/24411 | 1,210,023,054 | PR_kwDOAJy2Ks42gjBz | 24,411 | Changelog for 18.1 | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 354772952a8228255cc7e8e32906e427e5255c30...22f6d9fd8cab747c0b3912638939e0f95c576c14\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-20 17:59:35 | 2022-11-29 22:26:49 | 2022-04-26 21:05:29 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24411', 'html_url': 'https://github.com/facebook/react/pull/24411', 'diff_url': 'https://github.com/facebook/react/pull/24411.diff', 'patch_url': 'https://github.com/facebook/react/pull/24411.patch', 'merged_at': datetime.datetime(2022, 4, 26, 21, 5, 29)} | Assumes #24404 is merged.
Needs a date in the header before merge. | {'url': 'https://api.github.com/repos/facebook/react/issues/24411/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24411/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24410 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24410/labels{/name} | https://api.github.com/repos/facebook/react/issues/24410/comments | https://api.github.com/repos/facebook/react/issues/24410/events | https://github.com/facebook/react/pull/24410 | 1,209,906,645 | PR_kwDOAJy2Ks42gL3F | 24,410 | Land enableClientRenderFallbackOnHydrationMismatch | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 354772952a8228255cc7e8e32906e427e5255c30...f7269338efe5ddb9a3e9e99aec501722ae7eedde\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-20 16:12:17 | 2022-04-20 18:09:12 | 2022-04-20 18:09:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24410', 'html_url': 'https://github.com/facebook/react/pull/24410', 'diff_url': 'https://github.com/facebook/react/pull/24410.diff', 'patch_url': 'https://github.com/facebook/react/pull/24410.patch', 'merged_at': datetime.datetime(2022, 4, 20, 18, 9, 11)} | **Will wait to merge until corresponding internal diff has rolled out**
This flag is already enabled on all relevant surfaces. We can remove it. | {'url': 'https://api.github.com/repos/facebook/react/issues/24410/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24410/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24409 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24409/labels{/name} | https://api.github.com/repos/facebook/react/issues/24409/comments | https://api.github.com/repos/facebook/react/issues/24409/events | https://github.com/facebook/react/issues/24409 | 1,209,257,883 | I_kwDOAJy2Ks5IE8-b | 24,409 | useEffect running before DOM is painted *without* useLayoutEffect | {'login': 'b3nten', 'id': 93301057, 'node_id': 'U_kgDOBY-pQQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/93301057?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/b3nten', 'html_url': 'https://github.com/b3nten', 'followers_url': 'https://api.github.com/users/b3nten/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Previously, useEffect would *sometimes* flush synchronously but it was inconsistent. In React 18, it always flushes synchronously if the effect is caused by an intentional user event like click, typing, and so on. So this works as intended.\r\n\r\n`useEffect` is generally used for non-visual things that can either... | 2022-04-20 07:12:04 | 2022-04-20 13:13:57 | 2022-04-20 13:13:33 | NONE | null | null | null | ### Came across strange behavior while building a simple modal with a fade-in CSS animation.
Component's default state is to render null.
When component is mounted, `useEffect(()=>setMounted(true),[])` should trigger a re-render. My understanding is that effects run after the DOM is painted, so the component shou... | {'url': 'https://api.github.com/repos/facebook/react/issues/24409/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24409/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24408 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24408/labels{/name} | https://api.github.com/repos/facebook/react/issues/24408/comments | https://api.github.com/repos/facebook/react/issues/24408/events | https://github.com/facebook/react/issues/24408 | 1,209,243,035 | I_kwDOAJy2Ks5IE5Wb | 24,408 | Bug: checkboxes with check all checkbox | {'login': 'johnmangam', 'id': 815778, 'node_id': 'MDQ6VXNlcjgxNTc3OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/815778?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/johnmangam', 'html_url': 'https://github.com/johnmangam', 'followers_url': 'https://api.github.com/users/johnmangam/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Sorry, it's very hard to read unformatted code, it's not runnable (you have not provided a sandbox), and it's not clear what doesn't work because you haven't specified what the *expected* behavior is. Please use StackOverflow for questions about using React. If you think you found a bug in React, please provide a ... | 2022-04-20 06:55:31 | 2022-04-23 03:11:44 | 2022-04-20 19:23:13 | NONE | null | null | null | Checkall/uncheckall checkbox works but upon clicking the individual checkboxes the behavior isn't as expected
**Code:**
**Grid.cs**
```
Import React,{useContext, useEffect, useState} from ‘react’
Import {row,Col,Button} from ‘react-bootstrap’
Import BootstrapTable from ‘react-bootstrap-tab;e-overlay’
c... | {'url': 'https://api.github.com/repos/facebook/react/issues/24408/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24408/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24407 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24407/labels{/name} | https://api.github.com/repos/facebook/react/issues/24407/comments | https://api.github.com/repos/facebook/react/issues/24407/events | https://github.com/facebook/react/pull/24407 | 1,209,117,189 | PR_kwDOAJy2Ks42dqJt | 24,407 | Land enableLazyElements flag | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4175f05934d3954827c00b7633c1ce8e4e87d227...d78530f93cb820290143f165702517b4609d367d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-20 03:32:24 | 2022-04-20 14:17:53 | 2022-04-20 14:17:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24407', 'html_url': 'https://github.com/facebook/react/pull/24407', 'diff_url': 'https://github.com/facebook/react/pull/24407.diff', 'patch_url': 'https://github.com/facebook/react/pull/24407.patch', 'merged_at': datetime.datetime(2022, 4, 20, 14, 17, 53)} | This flag is already enabled on all relevant surfaces. We can remove it. | {'url': 'https://api.github.com/repos/facebook/react/issues/24407/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24407/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24406 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24406/labels{/name} | https://api.github.com/repos/facebook/react/issues/24406/comments | https://api.github.com/repos/facebook/react/issues/24406/events | https://github.com/facebook/react/pull/24406 | 1,209,114,894 | PR_kwDOAJy2Ks42dpr8 | 24,406 | Land enableSelectiveHydration flag | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 392808a1f7fa2909492a742116ba8b549e862d70...6794f18834163d0ed89256dfb8e3b03945112703\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-20 03:28:22 | 2022-04-20 14:30:07 | 2022-04-20 14:26:26 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24406', 'html_url': 'https://github.com/facebook/react/pull/24406', 'diff_url': 'https://github.com/facebook/react/pull/24406.diff', 'patch_url': 'https://github.com/facebook/react/pull/24406.patch', 'merged_at': datetime.datetime(2022, 4, 20, 14, 26, 25)} | This flag is already enabled on all relevant surfaces. We can remove it. | {'url': 'https://api.github.com/repos/facebook/react/issues/24406/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24406/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24405 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24405/labels{/name} | https://api.github.com/repos/facebook/react/issues/24405/comments | https://api.github.com/repos/facebook/react/issues/24405/events | https://github.com/facebook/react/pull/24405 | 1,209,112,153 | PR_kwDOAJy2Ks42dpJH | 24,405 | Land enableSuspenseServerRenderer flag | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4175f05934d3954827c00b7633c1ce8e4e87d227...1f38d38904b64e90719e8c349ab2a068ccd589da\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-20 03:23:27 | 2022-04-20 14:24:06 | 2022-04-20 14:21:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24405', 'html_url': 'https://github.com/facebook/react/pull/24405', 'diff_url': 'https://github.com/facebook/react/pull/24405.diff', 'patch_url': 'https://github.com/facebook/react/pull/24405.patch', 'merged_at': datetime.datetime(2022, 4, 20, 14, 21, 36)} | This flag is already enabled on all relevant surfaces. We can remove it. | {'url': 'https://api.github.com/repos/facebook/react/issues/24405/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24405/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24404 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24404/labels{/name} | https://api.github.com/repos/facebook/react/issues/24404/comments | https://api.github.com/repos/facebook/react/issues/24404/events | https://github.com/facebook/react/pull/24404 | 1,208,965,209 | PR_kwDOAJy2Ks42dN9v | 24,404 | Suppress hydration warnings when a preceding sibling suspends | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0dc4e6663dc875e0f734b1a96b26ebc33902323a...be1cefa009afd113239d289aa44ca86b3011876e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-19 23:27:41 | 2022-04-26 13:52:00 | 2022-04-20 21:52:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24404', 'html_url': 'https://github.com/facebook/react/pull/24404', 'diff_url': 'https://github.com/facebook/react/pull/24404.diff', 'patch_url': 'https://github.com/facebook/react/pull/24404.patch', 'merged_at': datetime.datetime(2022, 4, 20, 21, 52, 54)} | Before this PR if there was a hydration error thrown in a ConcurrentMode tree the hydration procerss would enter a didSuspend state where further errors would be suppressed.
This did not previously happen however when a promise was thrown which would cause a Suspense boundary to suspend. Since it is typical for ther... | {'url': 'https://api.github.com/repos/facebook/react/issues/24404/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24404/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24403 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24403/labels{/name} | https://api.github.com/repos/facebook/react/issues/24403/comments | https://api.github.com/repos/facebook/react/issues/24403/events | https://github.com/facebook/react/issues/24403 | 1,208,836,223 | I_kwDOAJy2Ks5IDWB_ | 24,403 | React diffing broken when mixing margin and marginTop | {'login': 'johnryan', 'id': 416564, 'node_id': 'MDQ6VXNlcjQxNjU2NA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/416564?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/johnryan', 'html_url': 'https://github.com/johnryan', 'followers_url': 'https://api.github.com/users/johnryan/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is not supported. If you open the console after toggling you will see an error:\r\n\r\n> Removing a style property during rerender (margin) when a conflicting property is set (marginBottom) can lead to styling bugs. To avoid this, don't mix shorthand and non-shorthand properties for the same value; instead, r... | 2022-04-19 20:37:05 | 2022-04-19 21:52:37 | 2022-04-19 21:04:03 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16/17/18
## Steps To Reproduce
1. Apply an inline style wit... | {'url': 'https://api.github.com/repos/facebook/react/issues/24403/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24403/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24402 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24402/labels{/name} | https://api.github.com/repos/facebook/react/issues/24402/comments | https://api.github.com/repos/facebook/react/issues/24402/events | https://github.com/facebook/react/pull/24402 | 1,208,829,862 | PR_kwDOAJy2Ks42cxAJ | 24,402 | Revert "Clean up Selective Hydration / Event Replay flag (#24156)" | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d63cd972454125d4572bb8ffbfeccbdf0c5eb27b...3dba4384f01949fd03c4a903c05cacb63cf4b366\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-19 20:29:38 | 2022-04-26 14:04:05 | 2022-04-19 21:34:31 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24402', 'html_url': 'https://github.com/facebook/react/pull/24402', 'diff_url': 'https://github.com/facebook/react/pull/24402.diff', 'patch_url': 'https://github.com/facebook/react/pull/24402.patch', 'merged_at': datetime.datetime(2022, 4, 19, 21, 34, 31)} | ## Overview
We landed this before the flag was hard coded and this breaks some tests. Reverting so we can unblock the sync and fix the tests separately. | {'url': 'https://api.github.com/repos/facebook/react/issues/24402/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24402/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24401 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24401/labels{/name} | https://api.github.com/repos/facebook/react/issues/24401/comments | https://api.github.com/repos/facebook/react/issues/24401/events | https://github.com/facebook/react/pull/24401 | 1,208,828,168 | PR_kwDOAJy2Ks42cwoz | 24,401 | Temporarily feature flag numeric fallback for symbols | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlon... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d63cd972454125d4572bb8ffbfeccbdf0c5eb27b...becaffd29e28205c20cc74b47c87fcc55ed2c013\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-19 20:27:43 | 2022-04-26 14:04:11 | 2022-04-19 21:34:49 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24401', 'html_url': 'https://github.com/facebook/react/pull/24401', 'diff_url': 'https://github.com/facebook/react/pull/24401.diff', 'patch_url': 'https://github.com/facebook/react/pull/24401.patch', 'merged_at': datetime.datetime(2022, 4, 19, 21, 34, 49)} | ## Overview
We need these until it's safe to remove them in some internal surfaces. | {'url': 'https://api.github.com/repos/facebook/react/issues/24401/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24401/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24400 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24400/labels{/name} | https://api.github.com/repos/facebook/react/issues/24400/comments | https://api.github.com/repos/facebook/react/issues/24400/events | https://github.com/facebook/react/pull/24400 | 1,208,779,904 | PR_kwDOAJy2Ks42cmXo | 24,400 | Bugfix: In legacy mode, call suspended tree's unmount effects when it is deleted | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2bf5eba7247a58aeb7ba23b3b5630d8bf6c2c4da...ca98b3067f6b71500b5e2ba264baea8540ea8852\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-19 19:33:51 | 2022-04-19 21:09:07 | 2022-04-19 21:09:07 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24400', 'html_url': 'https://github.com/facebook/react/pull/24400', 'diff_url': 'https://github.com/facebook/react/pull/24400.diff', 'patch_url': 'https://github.com/facebook/react/pull/24400.patch', 'merged_at': datetime.datetime(2022, 4, 19, 21, 9, 7)} | When a suspended tree switches to a fallback, we unmount the effects. If the suspended tree is then deleted, there's a guard to prevent us from unmounting the effects again (added in ec52a5698e2dfea7050a0b015f0b79abfb2d81b7)
However, in legacy mode, we don't unmount effects when a tree suspends. So if the suspended ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24400/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24400/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24399 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24399/labels{/name} | https://api.github.com/repos/facebook/react/issues/24399/comments | https://api.github.com/repos/facebook/react/issues/24399/events | https://github.com/facebook/react/issues/24399 | 1,208,470,583 | I_kwDOAJy2Ks5IB8w3 | 24,399 | Bug: react-dom@18.0.0 renders dialog with open attribute | {'login': 'dfernandez79', 'id': 1102266, 'node_id': 'MDQ6VXNlcjExMDIyNjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1102266?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dfernandez79', 'html_url': 'https://github.com/dfernandez79', 'followers_url': 'https://api.github.com/users/dfernandez... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710722093, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"\r\nFor now I fixed it by removing the [open] attribute on first load, it seems a bit dirty to me, but it's only temporary.\r\n\r\n```js\r\nimport { useEffect, useRef } from 'react'\r\n\r\nexport const Dialog = () => {\r\n const dialog = useRef(null)\r\n\r\n useEffect(() => {\r\n dialog.current.removeAttribut... | 2022-04-19 14:43:35 | 2022-04-20 23:30:42 | 2022-04-20 17:06:05 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
The HTML `<dialog>` element is rendered with the `open` attribute, preventing th... | {'url': 'https://api.github.com/repos/facebook/react/issues/24399/reactions', 'total_count': 10, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 3, 'heart': 0, 'rocket': 0, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/24399/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24398 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24398/labels{/name} | https://api.github.com/repos/facebook/react/issues/24398/comments | https://api.github.com/repos/facebook/react/issues/24398/events | https://github.com/facebook/react/issues/24398 | 1,208,277,742 | I_kwDOAJy2Ks5IBNru | 24,398 | Bug: Can't type Korean when using input with useTransition. | {'login': 'ginger-kang', 'id': 62840502, 'node_id': 'MDQ6VXNlcjYyODQwNTAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/62840502?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ginger-kang', 'html_url': 'https://github.com/ginger-kang', 'followers_url': 'https://api.github.com/users/ginger-kang... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You can’t use transitions for updating a controlled input’s value. Controlled updates should be synchronous. So if you use a transition, you need two separate pieces of state, like in the docs examples. ",
"Thanks. I missed [this discussion](https://github.com/reactwg/react-18/discussions/100)."
] | 2022-04-19 12:19:55 | 2022-04-20 03:21:08 | 2022-04-19 13:29:44 | NONE | null | null | null | Korean is broken if i use `useTransition` together in controlled mode.
[docs example](https://ko.reactjs.org/docs/concurrent-mode-patterns.html#splitting-high-and-low-priority-state) If you look at this, it looks like a general use case, but if it doesn't work, it seems to be a bug.
I checked that Japanese is not w... | {'url': 'https://api.github.com/repos/facebook/react/issues/24398/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24398/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24397 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24397/labels{/name} | https://api.github.com/repos/facebook/react/issues/24397/comments | https://api.github.com/repos/facebook/react/issues/24397/events | https://github.com/facebook/react/issues/24397 | 1,208,236,786 | I_kwDOAJy2Ks5IBDry | 24,397 | when to use useCallback and useMemo | {'login': 'Luncher', 'id': 5138977, 'node_id': 'MDQ6VXNlcjUxMzg5Nzc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5138977?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Luncher', 'html_url': 'https://github.com/Luncher', 'followers_url': 'https://api.github.com/users/Luncher/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"It depends on the codebase and how large the app is but in general if something is passed into props and is referentially unstable it needs useCallback and useMemo. There are some React influencers who advise against stabilizing props because \"React is fast\" and therefore \"you can just let it rerender.\" I can ... | 2022-04-19 11:42:41 | 2022-04-24 11:25:13 | 2022-04-24 11:25:13 | NONE | null | null | null | I am a fan of React/hooks. As the usage scenarios in business projects gradually increase, I find the useCallback/useMemo hooks are a bit annoying. Whenever I use components developed by others, when I need to pass function props, I will wrap it with useCallback first. But it might work fine without the wrapping.
Th... | {'url': 'https://api.github.com/repos/facebook/react/issues/24397/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24397/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24396 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24396/labels{/name} | https://api.github.com/repos/facebook/react/issues/24396/comments | https://api.github.com/repos/facebook/react/issues/24396/events | https://github.com/facebook/react/pull/24396 | 1,207,435,501 | PR_kwDOAJy2Ks42YbxX | 24,396 | Demo for defaultMuted on video element | {'login': 'MustafaEminn', 'id': 63938499, 'node_id': 'MDQ6VXNlcjYzOTM4NDk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/63938499?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MustafaEminn', 'html_url': 'https://github.com/MustafaEminn', 'followers_url': 'https://api.github.com/users/MustafaE... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 2bf5eba7247a58aeb7ba23b3b5630d8bf6c2c4da...44ce5386f1fafa3ddf94ccdf9c4e56042bdbea7c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-18 20:44:25 | 2023-12-27 21:52:51 | 2023-12-27 21:52:51 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24396', 'html_url': 'https://github.com/facebook/react/pull/24396', 'diff_url': 'https://github.com/facebook/react/pull/24396.diff', 'patch_url': 'https://github.com/facebook/react/pull/24396.patch', 'merged_at': None} | Fixes #10389 (not fixing it's just the label).
@gaearon
## Summary
Just for demo. I have no knowledge on React SSR.
## How did you test this change?
There are three tests. | {'url': 'https://api.github.com/repos/facebook/react/issues/24396/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24396/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24395 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24395/labels{/name} | https://api.github.com/repos/facebook/react/issues/24395/comments | https://api.github.com/repos/facebook/react/issues/24395/events | https://github.com/facebook/react/issues/24395 | 1,207,044,050 | I_kwDOAJy2Ks5H8gfS | 24,395 | Bug: nested react instances failed in Safari | {'login': 'Holybasil', 'id': 21138718, 'node_id': 'MDQ6VXNlcjIxMTM4NzE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/21138718?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Holybasil', 'html_url': 'https://github.com/Holybasil', 'followers_url': 'https://api.github.com/users/Holybasil/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"As a workaround, you can use `flushSync` to force the element to be available immediately:\r\n\r\nhttps://codesandbox.io/s/parent-child-react-forked-hezlbp?file=/index.js\r\n\r\nIn general, this is a non-idiomatic way to create a React tree. Idiomatically, you would pass the child components as props to the parent... | 2022-04-18 13:20:06 | 2022-04-20 17:32:15 | 2022-04-20 17:32:14 | NONE | null | null | null | In a nutshell, I need to have a nested tertiary structure, like:
```js
<div id="root">
// App.js
function App(){
...
return (
<div>
...
<div id="parent" />
...
</div>
)
}
// Parent.js
function Parent(){
return (
<div>
...
<div id="child" />
... | {'url': 'https://api.github.com/repos/facebook/react/issues/24395/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24395/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24394 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24394/labels{/name} | https://api.github.com/repos/facebook/react/issues/24394/comments | https://api.github.com/repos/facebook/react/issues/24394/events | https://github.com/facebook/react/issues/24394 | 1,206,989,821 | I_kwDOAJy2Ks5H8TP9 | 24,394 | Bug: | {'login': 'Nehal333', 'id': 91029765, 'node_id': 'MDQ6VXNlcjkxMDI5NzY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/91029765?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Nehal333', 'html_url': 'https://github.com/Nehal333', 'followers_url': 'https://api.github.com/users/Nehal333/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This seems to have been opened by mistake."
] | 2022-04-18 12:13:25 | 2022-04-18 20:22:37 | 2022-04-18 20:22:37 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much fast... | {'url': 'https://api.github.com/repos/facebook/react/issues/24394/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24394/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24393 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24393/labels{/name} | https://api.github.com/repos/facebook/react/issues/24393/comments | https://api.github.com/repos/facebook/react/issues/24393/events | https://github.com/facebook/react/pull/24393 | 1,206,617,921 | PR_kwDOAJy2Ks42Vt5i | 24,393 | Fix typo in dangerfile.js (insiginificant -> insignificant) | {'login': 'urunsiyabend', 'id': 47708503, 'node_id': 'MDQ6VXNlcjQ3NzA4NTAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/47708503?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/urunsiyabend', 'html_url': 'https://github.com/urunsiyabend', 'followers_url': 'https://api.github.com/users/urunsiya... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @urunsiyabend! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order ... | 2022-04-18 03:30:29 | 2022-06-17 17:43:53 | 2022-06-17 17:43:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24393', 'html_url': 'https://github.com/facebook/react/pull/24393', 'diff_url': 'https://github.com/facebook/react/pull/24393.diff', 'patch_url': 'https://github.com/facebook/react/pull/24393.patch', 'merged_at': datetime.datetime(2022, 6, 17, 17, 43, 52)} | Fix typo in dangerfile.js (insiginificant -> insignificant) | {'url': 'https://api.github.com/repos/facebook/react/issues/24393/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24393/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24392 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24392/labels{/name} | https://api.github.com/repos/facebook/react/issues/24392/comments | https://api.github.com/repos/facebook/react/issues/24392/events | https://github.com/facebook/react/issues/24392 | 1,206,588,152 | I_kwDOAJy2Ks5H6xL4 | 24,392 | Bug: time slice not work in react 18 | {'login': 'yuwanlin', 'id': 18443683, 'node_id': 'MDQ6VXNlcjE4NDQzNjgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/18443683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yuwanlin', 'html_url': 'https://github.com/yuwanlin', 'followers_url': 'https://api.github.com/users/yuwanlin/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710722093, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Interesting. I thought adding startTransition would make it work, but it doesn't: https://stackblitz.com/edit/react-ts-f7zkug?file=index.tsx\r\n\r\nWe'll have a look.",
"In my attempt at your demo, use React.startTransition make it work, and every task cost about 5ms. See video record. In my opinion, default upd... | 2022-04-18 02:32:27 | 2023-09-26 16:42:56 | 2022-09-06 02:58:51 | NONE | null | null | null | in react@16.8.0, a long task will be sliced multi short task, demo: https://stackblitz.com/edit/react-ts-aqwejz
but in react@18.0.0, it will be only a long task, demo: https://stackblitz.com/edit/react-ts... | {'url': 'https://api.github.com/repos/facebook/react/issues/24392/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24392/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24391 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24391/labels{/name} | https://api.github.com/repos/facebook/react/issues/24391/comments | https://api.github.com/repos/facebook/react/issues/24391/events | https://github.com/facebook/react/issues/24391 | 1,206,320,348 | I_kwDOAJy2Ks5H5vzc | 24,391 | Bug: Internal React error: Expected static flag was missing | {'login': 'Developer-Nijat', 'id': 51002164, 'node_id': 'MDQ6VXNlcjUxMDAyMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/51002164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Developer-Nijat', 'html_url': 'https://github.com/Developer-Nijat', 'followers_url': 'https://api.github.com/users... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/l... | open | false | null | [] | null | [
"Please provide a reproducible example. Either on GitHub or a sandbox. Otherwise we can’t really fix this. Thanks!",
"> Please provide a reproducible example. Either on GitHub or a sandbox. Otherwise we can’t really fix this. Thanks!\n\nProbably it is not possible. Because this is the large project and totally co... | 2022-04-17 08:53:53 | 2024-01-11 17:07:26 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: V18.0.0
React router DOM: V5.2.1
## Steps To Reproduce
1. ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24391/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24391/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/24390 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24390/labels{/name} | https://api.github.com/repos/facebook/react/issues/24390/comments | https://api.github.com/repos/facebook/react/issues/24390/events | https://github.com/facebook/react/pull/24390 | 1,206,283,077 | PR_kwDOAJy2Ks42Uraf | 24,390 | i have made changes in security.md | {'login': 'mdazad1508', 'id': 79281821, 'node_id': 'MDQ6VXNlcjc5MjgxODIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/79281821?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mdazad1508', 'html_url': 'https://github.com/mdazad1508', 'followers_url': 'https://api.github.com/users/mdazad1508/fol... | [] | closed | false | null | [] | null | [
"Hi @mdazad1508! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order fo... | 2022-04-17 05:10:14 | 2022-04-17 21:00:09 | 2022-04-17 21:00:09 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24390', 'html_url': 'https://github.com/facebook/react/pull/24390', 'diff_url': 'https://github.com/facebook/react/pull/24390.diff', 'patch_url': 'https://github.com/facebook/react/pull/24390.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/24390/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24390/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24389 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24389/labels{/name} | https://api.github.com/repos/facebook/react/issues/24389/comments | https://api.github.com/repos/facebook/react/issues/24389/events | https://github.com/facebook/react/pull/24389 | 1,206,209,957 | PR_kwDOAJy2Ks42Udrz | 24,389 | explain the rationale for the chosen escaping implemenation in a comment | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d40dc73cf903e8a12fd29e900df2406e7f611c5c...3bca464986a930860d46ba4de4a8afca04c8e7b5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-16 20:29:38 | 2022-04-16 21:29:16 | 2022-04-16 21:29:13 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24389', 'html_url': 'https://github.com/facebook/react/pull/24389', 'diff_url': 'https://github.com/facebook/react/pull/24389.diff', 'patch_url': 'https://github.com/facebook/react/pull/24389.patch', 'merged_at': datetime.datetime(2022, 4, 16, 21, 29, 12)} | Clarifies the why of #24385 with an explanatory comment
| {'url': 'https://api.github.com/repos/facebook/react/issues/24389/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24389/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24388 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24388/labels{/name} | https://api.github.com/repos/facebook/react/issues/24388/comments | https://api.github.com/repos/facebook/react/issues/24388/events | https://github.com/facebook/react/issues/24388 | 1,206,151,279 | I_kwDOAJy2Ks5H5Ghv | 24,388 | Bug: React 18 hydration mismatch with sync external store | {'login': 'tranvansang', 'id': 13043196, 'node_id': 'MDQ6VXNlcjEzMDQzMTk2', 'avatar_url': 'https://avatars.githubusercontent.com/u/13043196?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tranvansang', 'html_url': 'https://github.com/tranvansang', 'followers_url': 'https://api.github.com/users/tranvansang... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1983406161, 'node_id': 'MDU6... | closed | true | null | [] | null | [
"Can I have additional questions here?\r\n\r\nWith the current design, my data library can be easily converted to the immutable pattern, using `useReducer`/`useState` + `useContext`, and get rid of useSyncExternalStore.\r\n\r\nHowever, every time the store gets a change, it notifies all listening `useContext`s.\r\n... | 2022-04-16 16:04:00 | 2022-06-24 15:43:02 | 2022-06-24 15:17:19 | NONE | resolved | null | null | The issue was brought from here https://github.com/facebook/react/issues/15074#issuecomment-1100568596
React version: 18.0.0
It is hard to mimic the hydration behavior with client-only code, I tried my best to reproduce the error here:
https://codesandbox.io/s/react-18-strict-mode-with-subscription-pattern-z... | {'url': 'https://api.github.com/repos/facebook/react/issues/24388/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24388/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24387 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24387/labels{/name} | https://api.github.com/repos/facebook/react/issues/24387/comments | https://api.github.com/repos/facebook/react/issues/24387/events | https://github.com/facebook/react/issues/24387 | 1,206,054,995 | I_kwDOAJy2Ks5H4vBT | 24,387 | Bug: const Hr = () => { return <hr className="hr" />;}; | {'login': 'Kb43551', 'id': 99946675, 'node_id': 'U_kgDOBfUQsw', 'avatar_url': 'https://avatars.githubusercontent.com/u/99946675?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Kb43551', 'html_url': 'https://github.com/Kb43551', 'followers_url': 'https://api.github.com/users/Kb43551/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2022-04-16 08:30:51 | 2022-04-16 08:31:19 | 2022-04-16 08:31:19 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/24387/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24387/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24386 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24386/labels{/name} | https://api.github.com/repos/facebook/react/issues/24386/comments | https://api.github.com/repos/facebook/react/issues/24386/events | https://github.com/facebook/react/issues/24386 | 1,205,845,765 | I_kwDOAJy2Ks5H378F | 24,386 | Bug: `useId()` not consistent between server and client | {'login': 'brillout', 'id': 1005638, 'node_id': 'MDQ6VXNlcjEwMDU2Mzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1005638?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/brillout', 'html_url': 'https://github.com/brillout', 'followers_url': 'https://api.github.com/users/brillout/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You're calling `createRoot` rather than `hydrateRoot`, so there is no hydration.\r\n\r\nHere is a fixed version:\r\n\r\nhttps://stackblitz.com/edit/github-3qdjks-bfxhjg?file=renderer%2F_default.page.client.jsx",
"你好，我将尽快给你回复。"
] | 2022-04-15 19:46:56 | 2022-10-11 06:54:02 | 2022-04-15 19:51:53 | CONTRIBUTOR | null | null | null | Problem: the value returned by the `useId()` hook is different between client and server.
```jsx
import React, { useState, useId } from 'react'
export { Counter }
function Counter() {
// `id` stays the same when clicking on the counter button, as expected.
// `id` is different between client and server,... | {'url': 'https://api.github.com/repos/facebook/react/issues/24386/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24386/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24385 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24385/labels{/name} | https://api.github.com/repos/facebook/react/issues/24385/comments | https://api.github.com/repos/facebook/react/issues/24385/events | https://github.com/facebook/react/pull/24385 | 1,205,783,762 | PR_kwDOAJy2Ks42TSuo | 24,385 | Escape bootstrapScriptContent for javascript embedding into HTML | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 726ba80298dad46b331aca1bcb71ca9b2004ed91...b8e42535e4449bd602b8ccc76b754a58f18a22f6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\... | 2022-04-15 18:30:22 | 2022-04-16 18:29:57 | 2022-04-16 17:47:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/24385', 'html_url': 'https://github.com/facebook/react/pull/24385', 'diff_url': 'https://github.com/facebook/react/pull/24385.diff', 'patch_url': 'https://github.com/facebook/react/pull/24385.patch', 'merged_at': datetime.datetime(2022, 4, 16, 17, 47, 46)} | The previous escape was for Text into HTML and breaks script contents. The new escaping ensures that the script contents cannot prematurely close the host script tag by escaping script open and close string sequences using a unicode escape substitution.
closes: https://github.com/facebook/react/issues/23063 | {'url': 'https://api.github.com/repos/facebook/react/issues/24385/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24385/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/24384 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24384/labels{/name} | https://api.github.com/repos/facebook/react/issues/24384/comments | https://api.github.com/repos/facebook/react/issues/24384/events | https://github.com/facebook/react/issues/24384 | 1,205,702,806 | I_kwDOAJy2Ks5H3ZCW | 24,384 | Bug: Incorrect Hydration Mismatch Detection during Suspense - "Hydration failed because the initial UI does not match what was rendered on the server." | {'login': 'xiel', 'id': 615522, 'node_id': 'MDQ6VXNlcjYxNTUyMg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/615522?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xiel', 'html_url': 'https://github.com/xiel', 'followers_url': 'https://api.github.com/users/xiel/followers', 'following_url': 'h... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 3079053919, 'node_id': 'MDU6TGFiZWwzMDc5MDUzOTE5', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [
"Small repro: https://codesandbox.io/s/sleepy-dan-ghlh1u?file=/pages/_app.js",
"Minimal repro without Next.js: https://codesandbox.io/s/compassionate-night-uzyxv1?file=/src/App.js",
"Seems like a bug. Weird that I can't repro this in tests.",
"Hi, I have seen this error lots of times in https://github.com/fac... | 2022-04-15 16:28:29 | 2023-05-19 07:29:00 | 2022-05-03 19:31:17 | NONE | null | null | null | React version: 18.0.0
## Steps To Reproduce
1. Add a Suspense Boundary
2. Add a **component that will suspend** to load some data (faked).
3. Render at least one **sibling component** _after_ the suspending component.
3. Render server-side using renderToPipeableStream()
4. Render client-side using hydrateRoot... | {'url': 'https://api.github.com/repos/facebook/react/issues/24384/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24384/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24383 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24383/labels{/name} | https://api.github.com/repos/facebook/react/issues/24383/comments | https://api.github.com/repos/facebook/react/issues/24383/events | https://github.com/facebook/react/issues/24383 | 1,205,216,505 | I_kwDOAJy2Ks5H1iT5 | 24,383 | Bug: Error using setInterval in React18 | {'login': 'SnowBDRy', 'id': 30207551, 'node_id': 'MDQ6VXNlcjMwMjA3NTUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/30207551?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SnowBDRy', 'html_url': 'https://github.com/SnowBDRy', 'followers_url': 'https://api.github.com/users/SnowBDRy/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I think you should disable the strict Mode in your index.js",
"> I think you should disable the strict Mode in your index.js\r\n\r\nHowever, the use of StrictMode in react is recommended, so this should not be the best solution😁",
"> I think you should disable the strict Mode in your index.js\r\n\r\nNot reall... | 2022-04-15 03:29:35 | 2022-04-15 14:00:33 | 2022-04-15 14:00:33 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:18
## Steps To Reproduce
1. use setInterval() in componentDi... | {'url': 'https://api.github.com/repos/facebook/react/issues/24383/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24383/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/24382 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/24382/labels{/name} | https://api.github.com/repos/facebook/react/issues/24382/comments | https://api.github.com/repos/facebook/react/issues/24382/events | https://github.com/facebook/react/issues/24382 | 1,205,206,874 | I_kwDOAJy2Ks5H1f9a | 24,382 | Bug: The forwardRef has disabled the defaulProps property of the function component | {'login': 'QMSFish', 'id': 65988868, 'node_id': 'MDQ6VXNlcjY1OTg4ODY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/65988868?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/QMSFish', 'html_url': 'https://github.com/QMSFish', 'followers_url': 'https://api.github.com/users/QMSFish/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You're calling the `XYTextArea` component as a function here:\r\n\r\n```tsx\r\nconst XYTextAreaNew = forwardRef((props, myRef) => XYTextArea(props, myRef))\r\n// ^^^^^^^^^^\r\n```\r\nWhich will bypass the logic that React uses to apply defaultProps. Instead if you ca... | 2022-04-15 03:11:17 | 2022-04-18 01:28:30 | 2022-04-18 01:28:30 | NONE | null | null | null | The function component does not have a ref instance and forwardRef can add a ref instance to the function component but after wrapping with forwardRef the defaulProps property setting of the function component fails
React version: 17.0.2
1.
import XYTextArea from 'XYTextArea.jsx'
const XYTextAreaNew = forwardRe... | {'url': 'https://api.github.com/repos/facebook/react/issues/24382/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/24382/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.