url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/18639 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18639/labels{/name} | https://api.github.com/repos/facebook/react/issues/18639/comments | https://api.github.com/repos/facebook/react/issues/18639/events | https://github.com/facebook/react/pull/18639 | 601,169,002 | MDExOlB1bGxSZXF1ZXN0NDA0NDY4Mjk2 | 18,639 | Clean up modern plugins to remove dead code | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18639/builds/20250) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 15:31:18 | 2020-04-16 19:10:30 | 2020-04-16 19:10:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18639', 'html_url': 'https://github.com/facebook/react/pull/18639', 'diff_url': 'https://github.com/facebook/react/pull/18639.diff', 'patch_url': 'https://github.com/facebook/react/pull/18639.patch', 'merged_at': datetime.datetime(2020, 4, 16, 19, 10, 23)} | This PR is a cut out of #18615, so we break down the amount of changes in that PR, but have the same end goal. Furthermore, this PR requires https://github.com/facebook/react/pull/18638 to land before the CI will pass as this PR removes some files that are dead once that PR is merged.
This PR removes the non-modern ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18639/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18639/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18638 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18638/labels{/name} | https://api.github.com/repos/facebook/react/issues/18638/comments | https://api.github.com/repos/facebook/react/issues/18638/events | https://github.com/facebook/react/pull/18638 | 601,160,069 | MDExOlB1bGxSZXF1ZXN0NDA0NDYwNjA0 | 18,638 | Revert legacy plugin modules | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18638/builds/20202) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 15:22:52 | 2020-04-16 17:46:29 | 2020-04-16 17:46:25 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18638', 'html_url': 'https://github.com/facebook/react/pull/18638', 'diff_url': 'https://github.com/facebook/react/pull/18638.diff', 'patch_url': 'https://github.com/facebook/react/pull/18638.patch', 'merged_at': datetime.datetime(2020, 4, 16, 17, 46, 25)} | This PR is a cut out of #18615, so we break down the amount of changes in that PR, but have the same end goal.
This PR reverts the legacy event plugin modules to work as the did before the modern event system changes were made to the React codebase. Essentially, the changes have been reverted back to what the files ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18638/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18638/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18637 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18637/labels{/name} | https://api.github.com/repos/facebook/react/issues/18637/comments | https://api.github.com/repos/facebook/react/issues/18637/events | https://github.com/facebook/react/pull/18637 | 601,098,586 | MDExOlB1bGxSZXF1ZXN0NDA0NDA3NjQ5 | 18,637 | Create copy of Legacy event plugins for Modern system | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18637/builds/20190) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 14:21:18 | 2020-04-16 15:09:09 | 2020-04-16 15:09:05 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18637', 'html_url': 'https://github.com/facebook/react/pull/18637', 'diff_url': 'https://github.com/facebook/react/pull/18637.diff', 'patch_url': 'https://github.com/facebook/react/pull/18637.patch', 'merged_at': datetime.datetime(2020, 4, 16, 15, 9, 5)} | This PR is a cut out of https://github.com/facebook/react/pull/18615, so we break down the amount of changes in that PR, but have the same end goal.
This PR does four things:
- Creates a copy of the `Legacy` plugin modules with a `Modern` prefix (no content changes at all)
- Links `ReactDOMClientInjection.js` to... | {'url': 'https://api.github.com/repos/facebook/react/issues/18637/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18637/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18636 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18636/labels{/name} | https://api.github.com/repos/facebook/react/issues/18636/comments | https://api.github.com/repos/facebook/react/issues/18636/events | https://github.com/facebook/react/pull/18636 | 601,064,584 | MDExOlB1bGxSZXF1ZXN0NDA0Mzc5MDMw | 18,636 | Unify Flare FocusWithin responder with useFocusWithin | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18636/builds/20230) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 13:41:43 | 2020-04-16 18:35:48 | 2020-04-16 18:35:42 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18636', 'html_url': 'https://github.com/facebook/react/pull/18636', 'diff_url': 'https://github.com/facebook/react/pull/18636.diff', 'patch_url': 'https://github.com/facebook/react/pull/18636.patch', 'merged_at': datetime.datetime(2020, 4, 16, 18, 35, 42)} | This PR unifies the Flare `FocusWithin` responder with the recent `useFocusWithin` responder so the Flare version uses a fake `afterblur` rather the fake `blur`. This means we can easily A/B test the various implementations that rely on this internally. I've also added FocusRegion tests that confirm the functionality m... | {'url': 'https://api.github.com/repos/facebook/react/issues/18636/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18636/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18634 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18634/labels{/name} | https://api.github.com/repos/facebook/react/issues/18634/comments | https://api.github.com/repos/facebook/react/issues/18634/events | https://github.com/facebook/react/pull/18634 | 601,010,372 | MDExOlB1bGxSZXF1ZXN0NDA0MzMzODQy | 18,634 | feat(react-dom): Add enterKeyHint | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18634/builds/20168) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 12:30:53 | 2020-07-27 20:08:11 | 2020-07-27 20:07:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18634', 'html_url': 'https://github.com/facebook/react/pull/18634', 'diff_url': 'https://github.com/facebook/react/pull/18634.diff', 'patch_url': 'https://github.com/facebook/react/pull/18634.patch', 'merged_at': datetime.datetime(2020, 7, 27, 20, 7, 8)} | ## Summary
```diff
-<input enterkeyhint="search" />
+<input enterKeyHint="search" />
```
- [WHATWG spec](https://html.spec.whatwg.org/multipage/interaction.html#attr-enterkeyhint)
- [Chrome Platform Status](https://www.chromestatus.com/feature/5654529808793600)
- supported in chrome 77, safari 13.1, [firefox... | {'url': 'https://api.github.com/repos/facebook/react/issues/18634/reactions', 'total_count': 6, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18634/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18633 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18633/labels{/name} | https://api.github.com/repos/facebook/react/issues/18633/comments | https://api.github.com/repos/facebook/react/issues/18633/events | https://github.com/facebook/react/issues/18633 | 601,002,794 | MDU6SXNzdWU2MDEwMDI3OTQ= | 18,633 | Bug: ReactCurrentOwner.current is null in production mode | {'login': 'CheMingjun', 'id': 18278955, 'node_id': 'MDQ6VXNlcjE4Mjc4OTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/18278955?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/CheMingjun', 'html_url': 'https://github.com/CheMingjun', 'followers_url': 'https://api.github.com/users/CheMingjun/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is not supported — it's a completely internal API."
] | 2020-04-16 12:20:15 | 2020-04-16 13:21:22 | 2020-04-16 13:21:21 | NONE | null | null | null | React version: v16.13.0
I want to get current filber node in my code ,i found it's work in development mode,but failed in production mode
Or,is there another API can i use?
Thanks
| {'url': 'https://api.github.com/repos/facebook/react/issues/18633/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18633/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18632 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18632/labels{/name} | https://api.github.com/repos/facebook/react/issues/18632/comments | https://api.github.com/repos/facebook/react/issues/18632/events | https://github.com/facebook/react/pull/18632 | 600,966,017 | MDExOlB1bGxSZXF1ZXN0NDA0Mjk2MTAw | 18,632 | Fix requiring timers module with non standard require | {'login': 'just-boris', 'id': 812240, 'node_id': 'MDQ6VXNlcjgxMjI0MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/812240?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/just-boris', 'html_url': 'https://github.com/just-boris', 'followers_url': 'https://api.github.com/users/just-boris/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18632/builds/20159) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 11:25:53 | 2020-04-21 07:00:17 | 2020-04-16 11:36:10 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18632', 'html_url': 'https://github.com/facebook/react/pull/18632', 'diff_url': 'https://github.com/facebook/react/pull/18632.diff', 'patch_url': 'https://github.com/facebook/react/pull/18632.patch', 'merged_at': datetime.datetime(2020, 4, 16, 11, 36, 10)} | # Summary
A fix for #18589
## Test Plan
Ran "steps to reproduce" from the report. Fails before and passes after the fix.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18632/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18632/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18630 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18630/labels{/name} | https://api.github.com/repos/facebook/react/issues/18630/comments | https://api.github.com/repos/facebook/react/issues/18630/events | https://github.com/facebook/react/pull/18630 | 600,856,213 | MDExOlB1bGxSZXF1ZXN0NDA0MjA1NTQ0 | 18,630 | refactor import just for more consistent | {'login': 'zhangenming', 'id': 21235555, 'node_id': 'MDQ6VXNlcjIxMjM1NTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/21235555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhangenming', 'html_url': 'https://github.com/zhangenming', 'followers_url': 'https://api.github.com/users/zhangenming... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @zhangenming! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on ... | 2020-04-16 08:41:47 | 2020-04-16 23:07:56 | 2020-04-16 23:07:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18630', 'html_url': 'https://github.com/facebook/react/pull/18630', 'diff_url': 'https://github.com/facebook/react/pull/18630.diff', 'patch_url': 'https://github.com/facebook/react/pull/18630.patch', 'merged_at': None} | .
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18630/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18630/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18629 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18629/labels{/name} | https://api.github.com/repos/facebook/react/issues/18629/comments | https://api.github.com/repos/facebook/react/issues/18629/events | https://github.com/facebook/react/issues/18629 | 600,829,064 | MDU6SXNzdWU2MDA4MjkwNjQ= | 18,629 | Bug: useContext returns default instead of passed value | {'login': 'codebling', 'id': 1073841, 'node_id': 'MDQ6VXNlcjEwNzM4NDE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1073841?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/codebling', 'html_url': 'https://github.com/codebling', 'followers_url': 'https://api.github.com/users/codebling/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is expected because\r\n\r\n```js\r\n <Test1Context.Provider value='not default'>\r\n <span>{React.useContext(Test1Context)}</span>\r\n </Test1Context.Provider>\r\n```\r\n\r\nis the same as \r\n\r\n```js\r\n const ctx = React.useContext(Test1Context)\r\n\r\n <Test1Context.Provider value='not default'>\r... | 2020-04-16 08:00:12 | 2022-03-28 16:20:15 | 2020-04-16 18:39:26 | NONE | null | null | null | Given the following code:
```
const TestContext = React.createContext('default');
export default () => (
<TestContext.Provider value='not default'>
<span>{React.useContext(TestContext)}</span>
</TestContext.Provider>
);
```
The resulting value in `<span>` is "default".
React version:
`react@1... | {'url': 'https://api.github.com/repos/facebook/react/issues/18629/reactions', 'total_count': 7, '+1': 7, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18629/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18628 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18628/labels{/name} | https://api.github.com/repos/facebook/react/issues/18628/comments | https://api.github.com/repos/facebook/react/issues/18628/events | https://github.com/facebook/react/pull/18628 | 600,807,509 | MDExOlB1bGxSZXF1ZXN0NDA0MTY2MTQ3 | 18,628 | Run error replay test again new reconciler | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18628/builds/20131) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 07:22:52 | 2020-04-16 15:08:23 | 2020-04-16 15:08:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18628', 'html_url': 'https://github.com/facebook/react/pull/18628', 'diff_url': 'https://github.com/facebook/react/pull/18628.diff', 'patch_url': 'https://github.com/facebook/react/pull/18628.patch', 'merged_at': datetime.datetime(2020, 4, 16, 15, 8, 23)} | This is one of our few tests of an internal function. Need to import the module that corresponds to the reconciler that's being tested. | {'url': 'https://api.github.com/repos/facebook/react/issues/18628/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18628/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18627 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18627/labels{/name} | https://api.github.com/repos/facebook/react/issues/18627/comments | https://api.github.com/repos/facebook/react/issues/18627/events | https://github.com/facebook/react/pull/18627 | 600,767,459 | MDExOlB1bGxSZXF1ZXN0NDA0MTMzODIx | 18,627 | Remove redundant conditional statements | {'login': 'BetaSu', 'id': 15828041, 'node_id': 'MDQ6VXNlcjE1ODI4MDQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/15828041?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BetaSu', 'html_url': 'https://github.com/BetaSu', 'followers_url': 'https://api.github.com/users/BetaSu/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18627/builds/20368) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 05:54:25 | 2020-04-17 14:09:56 | 2020-04-17 14:09:56 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18627', 'html_url': 'https://github.com/facebook/react/pull/18627', 'diff_url': 'https://github.com/facebook/react/pull/18627.diff', 'patch_url': 'https://github.com/facebook/react/pull/18627.patch', 'merged_at': None} | ## Summary
Remove redundant conditional statements
| {'url': 'https://api.github.com/repos/facebook/react/issues/18627/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18627/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18626 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18626/labels{/name} | https://api.github.com/repos/facebook/react/issues/18626/comments | https://api.github.com/repos/facebook/react/issues/18626/events | https://github.com/facebook/react/pull/18626 | 600,754,534 | MDExOlB1bGxSZXF1ZXN0NDA0MTIzMjkw | 18,626 | Fix CI | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18626/builds/20119) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 05:16:53 | 2020-04-16 05:27:28 | 2020-04-16 05:27:25 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18626', 'html_url': 'https://github.com/facebook/react/pull/18626', 'diff_url': 'https://github.com/facebook/react/pull/18626.diff', 'patch_url': 'https://github.com/facebook/react/pull/18626.patch', 'merged_at': datetime.datetime(2020, 4, 16, 5, 27, 25)} | Follow up for #18624 | {'url': 'https://api.github.com/repos/facebook/react/issues/18626/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18626/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18625 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18625/labels{/name} | https://api.github.com/repos/facebook/react/issues/18625/comments | https://api.github.com/repos/facebook/react/issues/18625/events | https://github.com/facebook/react/pull/18625 | 600,706,365 | MDExOlB1bGxSZXF1ZXN0NDA0MDg1MTU1 | 18,625 | Pressable click fix | {'login': 'nmn', 'id': 3582514, 'node_id': 'MDQ6VXNlcjM1ODI1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3582514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nmn', 'html_url': 'https://github.com/nmn', 'followers_url': 'https://api.github.com/users/nmn/followers', 'following_url': 'htt... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18625/builds/20564) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 02:44:36 | 2020-04-22 20:39:59 | 2020-04-20 22:13:18 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18625', 'html_url': 'https://github.com/facebook/react/pull/18625', 'diff_url': 'https://github.com/facebook/react/pull/18625.diff', 'patch_url': 'https://github.com/facebook/react/pull/18625.patch', 'merged_at': datetime.datetime(2020, 4, 20, 22, 13, 18)} | ## Summary
### Motiation
The custom press tracking has a few bugs:
1. VoiceOver users (and possibly JAWS users) often use a custom keyboard shortcut to trigger clicks, those clicks are currently ignored.
2. On touchscreens, since the click is only ignored on the target itself, if you click on an overlay and it re... | {'url': 'https://api.github.com/repos/facebook/react/issues/18625/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18625/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18624 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18624/labels{/name} | https://api.github.com/repos/facebook/react/issues/18624/comments | https://api.github.com/repos/facebook/react/issues/18624/events | https://github.com/facebook/react/pull/18624 | 600,689,729 | MDExOlB1bGxSZXF1ZXN0NDA0MDcyMjI3 | 18,624 | Fix wrong command in config.yml | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18624/builds/20104) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 01:50:38 | 2020-04-16 05:17:07 | 2020-04-16 04:44:39 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18624', 'html_url': 'https://github.com/facebook/react/pull/18624', 'diff_url': 'https://github.com/facebook/react/pull/18624.diff', 'patch_url': 'https://github.com/facebook/react/pull/18624.patch', 'merged_at': datetime.datetime(2020, 4, 16, 4, 44, 39)} | Oops | {'url': 'https://api.github.com/repos/facebook/react/issues/18624/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18624/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18623 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18623/labels{/name} | https://api.github.com/repos/facebook/react/issues/18623/comments | https://api.github.com/repos/facebook/react/issues/18623/events | https://github.com/facebook/react/pull/18623 | 600,633,311 | MDExOlB1bGxSZXF1ZXN0NDA0MDI2NzM3 | 18,623 | Update nvmrc to the same one used in CI | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18623/builds/20087) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-15 22:48:59 | 2020-04-15 23:03:03 | 2020-04-15 23:03:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18623', 'html_url': 'https://github.com/facebook/react/pull/18623', 'diff_url': 'https://github.com/facebook/react/pull/18623.diff', 'patch_url': 'https://github.com/facebook/react/pull/18623.patch', 'merged_at': datetime.datetime(2020, 4, 15, 23, 3, 3)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/18623/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18623/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18620 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18620/labels{/name} | https://api.github.com/repos/facebook/react/issues/18620/comments | https://api.github.com/repos/facebook/react/issues/18620/events | https://github.com/facebook/react/pull/18620 | 600,606,021 | MDExOlB1bGxSZXF1ZXN0NDA0MDA0MjY0 | 18,620 | Remove redundant expiration time comparisons | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18620/builds/20097) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-15 21:43:10 | 2020-04-17 18:48:06 | 2020-04-17 18:48:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18620', 'html_url': 'https://github.com/facebook/react/pull/18620', 'diff_url': 'https://github.com/facebook/react/pull/18620.diff', 'patch_url': 'https://github.com/facebook/react/pull/18620.patch', 'merged_at': datetime.datetime(2020, 4, 17, 18, 48, 6)} | I'm going through all the expiration times comparisons as part of my refactor and I noticed this one has a redundancy.
Not a huge deal but might as well backport to the current implementation.
I'll keep this PR open in case I find more. | {'url': 'https://api.github.com/repos/facebook/react/issues/18620/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18620/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18619 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18619/labels{/name} | https://api.github.com/repos/facebook/react/issues/18619/comments | https://api.github.com/repos/facebook/react/issues/18619/events | https://github.com/facebook/react/pull/18619 | 600,584,676 | MDExOlB1bGxSZXF1ZXN0NDAzOTg2NTY2 | 18,619 | ADD: disableRemotePlayback attribute for HTML5 videos | {'login': 'tombrowndev', 'id': 36549917, 'node_id': 'MDQ6VXNlcjM2NTQ5OTE3', 'avatar_url': 'https://avatars.githubusercontent.com/u/36549917?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tombrowndev', 'html_url': 'https://github.com/tombrowndev', 'followers_url': 'https://api.github.com/users/tombrowndev... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @tombrowndev! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on ... | 2020-04-15 21:00:11 | 2020-04-16 09:23:49 | 2020-04-16 09:23:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18619', 'html_url': 'https://github.com/facebook/react/pull/18619', 'diff_url': 'https://github.com/facebook/react/pull/18619.diff', 'patch_url': 'https://github.com/facebook/react/pull/18619.patch', 'merged_at': datetime.datetime(2020, 4, 16, 9, 23, 49)} | This is a fix for issue #18618.
Given this has a wide browser support, I think this should be available. | {'url': 'https://api.github.com/repos/facebook/react/issues/18619/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18619/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18618 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18618/labels{/name} | https://api.github.com/repos/facebook/react/issues/18618/comments | https://api.github.com/repos/facebook/react/issues/18618/events | https://github.com/facebook/react/issues/18618 | 600,564,913 | MDU6SXNzdWU2MDA1NjQ5MTM= | 18,618 | Bug: disableRemotePlayback not recognized | {'login': 'tomprats', 'id': 1906547, 'node_id': 'MDQ6VXNlcjE5MDY1NDc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1906547?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tomprats', 'html_url': 'https://github.com/tomprats', 'followers_url': 'https://api.github.com/users/tomprats/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Created a PR #18619",
"@tomprats This has been merged in. Feel free to close the issue,\r\n\r\nCheers",
"Thanks @tombrowndev, appreciate your work!"
] | 2020-04-15 20:22:42 | 2020-04-16 19:54:39 | 2020-04-16 19:54:39 | NONE | null | null | null | Passing `disableRemotePlayback` as an attribute like so:
```
<video disableRemotePlayback={true}>
```
Produces the warning:
> Warning: React does not recognize the `disableRemotePlayback` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `di... | {'url': 'https://api.github.com/repos/facebook/react/issues/18618/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18618/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18617 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18617/labels{/name} | https://api.github.com/repos/facebook/react/issues/18617/comments | https://api.github.com/repos/facebook/react/issues/18617/events | https://github.com/facebook/react/pull/18617 | 600,545,961 | MDExOlB1bGxSZXF1ZXN0NDAzOTU0OTYx | 18,617 | Fix incorrect unmounted state update warning | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'sebmarkbage', 'id': 63648.0, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followe... | [{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/follower... | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18617/builds/20569) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-15 19:47:22 | 2020-04-21 16:51:35 | 2020-04-18 19:18:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18617', 'html_url': 'https://github.com/facebook/react/pull/18617', 'diff_url': 'https://github.com/facebook/react/pull/18617.diff', 'patch_url': 'https://github.com/facebook/react/pull/18617.patch', 'merged_at': datetime.datetime(2020, 4, 18, 19, 18, 20)} | There was a recent report within Facebook of an invalid "_can't perform a React state update on an unmounted component_" warning that was eventually reduced to the fact that the Fiber being warned about was not tracked in the `pendingPassiveHookEffectsUnmount` array, but it's alternate **was**.
Unfortunately, becaus... | {'url': 'https://api.github.com/repos/facebook/react/issues/18617/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18617/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18616 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18616/labels{/name} | https://api.github.com/repos/facebook/react/issues/18616/comments | https://api.github.com/repos/facebook/react/issues/18616/events | https://github.com/facebook/react/issues/18616 | 600,537,991 | MDU6SXNzdWU2MDA1Mzc5OTE= | 18,616 | Bug: window as new portal will break event delegation | {'login': 'hanq08', 'id': 11851678, 'node_id': 'MDQ6VXNlcjExODUxNjc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/11851678?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hanq08', 'html_url': 'https://github.com/hanq08', 'followers_url': 'https://api.github.com/users/hanq08/followers', 'follow... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}] | open | false | null | [] | null | [
"@hanq08 \r\n\r\nYou could achieve it by using an effect and attaching an event listener to the button:\r\n\r\n```js\r\nfunction WindowPortal({ children }) {\r\n const [container, setContainer] = useState(document.createElement(\"div\"));\r\n\r\n useEffect(() => {\r\n const newWindow = window.open(\r\n \"... | 2020-04-15 19:32:36 | 2020-07-13 12:50:45 | null | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: any?
## Steps To Reproduce
1. Button attach to a window por... | {'url': 'https://api.github.com/repos/facebook/react/issues/18616/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18616/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18615 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18615/labels{/name} | https://api.github.com/repos/facebook/react/issues/18615/comments | https://api.github.com/repos/facebook/react/issues/18615/events | https://github.com/facebook/react/pull/18615 | 600,276,055 | MDExOlB1bGxSZXF1ZXN0NDAzNzQyMzM3 | 18,615 | Fork legacy and modern event plugins | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18615/builds/20025) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-15 12:55:15 | 2020-04-16 14:16:51 | 2020-04-16 14:16:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18615', 'html_url': 'https://github.com/facebook/react/pull/18615', 'diff_url': 'https://github.com/facebook/react/pull/18615.diff', 'patch_url': 'https://github.com/facebook/react/pull/18615.patch', 'merged_at': None} | This PR splits apart the event system plugins. In a previous PR, they were renamed with a `Legacy` prefix – this PR takes it further and creates a fork of each plugin for the modern event system, with the `Modern` prefix. In `ReactDOMClientInjection` we now use the right set of corresponding plugins depending if we are... | {'url': 'https://api.github.com/repos/facebook/react/issues/18615/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18615/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18614 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18614/labels{/name} | https://api.github.com/repos/facebook/react/issues/18614/comments | https://api.github.com/repos/facebook/react/issues/18614/events | https://github.com/facebook/react/issues/18614 | 600,173,290 | MDU6SXNzdWU2MDAxNzMyOTA= | 18,614 | Bug: DevTools should grab native setTimeout | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-04-15 09:57:15 | 2020-07-25 07:05:51 | 2020-07-25 07:05:51 | COLLABORATOR | null | null | null | Just noticed this.
<img width="645" alt="Screenshot 2020-04-15 at 10 56 39" src="https://user-images.githubusercontent.com/810438/79324642-cda71800-7f07-11ea-816f-af7a69496c52.png">
I think we should read setTimeout early in DevTools because we don't want the overridden one that goes through indirections. | {'url': 'https://api.github.com/repos/facebook/react/issues/18614/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18614/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18613 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18613/labels{/name} | https://api.github.com/repos/facebook/react/issues/18613/comments | https://api.github.com/repos/facebook/react/issues/18613/events | https://github.com/facebook/react/pull/18613 | 600,050,267 | MDExOlB1bGxSZXF1ZXN0NDAzNTY0NzM0 | 18,613 | Delete mutableSourceFirstPendingUpdateTime | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18613/builds/19937) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-15 06:20:54 | 2020-04-15 14:47:38 | 2020-04-15 14:47:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18613', 'html_url': 'https://github.com/facebook/react/pull/18613', 'diff_url': 'https://github.com/facebook/react/pull/18613.diff', 'patch_url': 'https://github.com/facebook/react/pull/18613.patch', 'merged_at': datetime.datetime(2020, 4, 15, 14, 47, 38)} | Leftover from one of the WIP commits in the last PR
| {'url': 'https://api.github.com/repos/facebook/react/issues/18613/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18613/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18612 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18612/labels{/name} | https://api.github.com/repos/facebook/react/issues/18612/comments | https://api.github.com/repos/facebook/react/issues/18612/events | https://github.com/facebook/react/pull/18612 | 599,912,895 | MDExOlB1bGxSZXF1ZXN0NDAzNDU3OTI5 | 18,612 | Lanes | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18612/builds/23789) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 23:12:07 | 2022-04-09 23:59:47 | 2022-04-03 17:30:51 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18612', 'html_url': 'https://github.com/facebook/react/pull/18612', 'diff_url': 'https://github.com/facebook/react/pull/18612.diff', 'patch_url': 'https://github.com/facebook/react/pull/18612.patch', 'merged_at': None} | ## Not for Merge
Stack of changes related to a refactor of React's internal concurrency and scheduling architecture.
I'm using this draft PR so I can push to something and kick off CI checks. It's not for review, but I'll accept feedback regardless.
This is very large set of changes, and many of the incrementa... | {'url': 'https://api.github.com/repos/facebook/react/issues/18612/reactions', 'total_count': 9, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 5, 'rocket': 1, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/18612/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18611 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18611/labels{/name} | https://api.github.com/repos/facebook/react/issues/18611/comments | https://api.github.com/repos/facebook/react/issues/18611/events | https://github.com/facebook/react/issues/18611 | 599,835,276 | MDU6SXNzdWU1OTk4MzUyNzY= | 18,611 | [Feature Request]: input#value bindings with useState | {'login': 'tomitheninja', 'id': 57364372, 'node_id': 'MDQ6VXNlcjU3MzY0Mzcy', 'avatar_url': 'https://avatars.githubusercontent.com/u/57364372?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tomitheninja', 'html_url': 'https://github.com/tomitheninja', 'followers_url': 'https://api.github.com/users/tomithen... | [] | closed | false | null | [] | null | [
"You can do either like this:\r\n```js\r\nfunction MyComponent() {\r\n const bind = useState('')\r\n // destructure for some other purpose in MyComponent\r\n const [value, setValue] = bind\r\n return (\r\n <input bind={bind} />\r\n // ...\r\n )\r\n}\r\n\r\nfunction input({bind}) {\r\n const [value, setV... | 2020-04-14 20:21:58 | 2020-04-16 23:50:52 | 2020-04-16 23:50:51 | NONE | null | null | null | Hey!
I noticed, many of the popular javascript frameworks support binding a value to a HTMLInputElement.
I think, with the new useState syntax, it became possible to implement this in react with a nice syntax and no breaking changes.
In expressjs the request object also contains the response object. Something ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18611/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18611/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18610 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18610/labels{/name} | https://api.github.com/repos/facebook/react/issues/18610/comments | https://api.github.com/repos/facebook/react/issues/18610/events | https://github.com/facebook/react/issues/18610 | 599,818,733 | MDU6SXNzdWU1OTk4MTg3MzM= | 18,610 | Bug: ReactArt-test fails with new node version | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Build%20Infrastructure', 'name': 'Component: Build Infrastructure', 'color': 'f9d0c4', 'default': False, 'description': None}
{'id': 155984225, 'node_id': 'MDU6TGFiZWwxNTU5ODQyMjU=', 'url': ... | closed | false | null | [] | null | [
"Closed in https://github.com/facebook/react/pull/18623",
"Oh lol I just saw this. Thanks for reporting!",
"Re-opening until the underlying issue is fixed",
"> ## Steps To Reproduce\r\n> 1. Use node 10\r\n\r\nNote that this occurs for v11 and some versions of v12 too (e.g. v12.6) but works with later versions... | 2020-04-14 19:51:22 | 2022-03-05 12:01:23 | 2022-03-05 12:01:14 | COLLABORATOR | null | null | null | ## Steps To Reproduce
0. Use node 10
1. git checkout master
2. yarn test ReactArt
## The current behavior
The following tests fail with `in <anonymous> (at **)` as the stack instead of the full component stack:
- ReactARTComponents › should warn if radius is missing on a Circle component
- ReactARTComponen... | {'url': 'https://api.github.com/repos/facebook/react/issues/18610/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18610/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18609 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18609/labels{/name} | https://api.github.com/repos/facebook/react/issues/18609/comments | https://api.github.com/repos/facebook/react/issues/18609/events | https://github.com/facebook/react/pull/18609 | 599,747,391 | MDExOlB1bGxSZXF1ZXN0NDAzMzI1Njc1 | 18,609 | Move beforeblur phase to prepareForCommit | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18609/builds/19878) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 17:45:43 | 2020-04-14 20:30:58 | 2020-04-14 20:30:55 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18609', 'html_url': 'https://github.com/facebook/react/pull/18609', 'diff_url': 'https://github.com/facebook/react/pull/18609.diff', 'patch_url': 'https://github.com/facebook/react/pull/18609.patch', 'merged_at': datetime.datetime(2020, 4, 14, 20, 30, 54)} | This is a follow up to https://github.com/facebook/react/pull/18564. Specifically, this moves the `beforeblur` logic in `ReactDOMHostConfig`, so that it occurs during `prepareForCommit` – avoiding the issues with conflicting with a partially mutated tree. To do this logic we pass through a helper function to `prepareFo... | {'url': 'https://api.github.com/repos/facebook/react/issues/18609/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18609/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18608 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18608/labels{/name} | https://api.github.com/repos/facebook/react/issues/18608/comments | https://api.github.com/repos/facebook/react/issues/18608/events | https://github.com/facebook/react/pull/18608 | 599,723,392 | MDExOlB1bGxSZXF1ZXN0NDAzMzA3MzQ4 | 18,608 | Add regression tests where sync render causes later concurrent render to expire soon | {'login': 'jddxf', 'id': 11155177, 'node_id': 'MDQ6VXNlcjExMTU1MTc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/11155177?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jddxf', 'html_url': 'https://github.com/jddxf', 'followers_url': 'https://api.github.com/users/jddxf/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18608/builds/36040) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 17:05:52 | 2020-06-30 11:43:00 | 2020-06-30 11:43:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18608', 'html_url': 'https://github.com/facebook/react/pull/18608', 'diff_url': 'https://github.com/facebook/react/pull/18608.diff', 'patch_url': 'https://github.com/facebook/react/pull/18608.patch', 'merged_at': datetime.datetime(2020, 6, 30, 11, 43)} | Currently we only reset `currentEventTime` when we start concurrent render. So `currentEventTime` is retained after sync render. That may make later concurrent render expire soon if enough time has elapsed since the last assignment to `currentEventTime`.
I've thought about resetting `currentEventTime` in `ensureRoot... | {'url': 'https://api.github.com/repos/facebook/react/issues/18608/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18608/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18607 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18607/labels{/name} | https://api.github.com/repos/facebook/react/issues/18607/comments | https://api.github.com/repos/facebook/react/issues/18607/events | https://github.com/facebook/react/pull/18607 | 599,699,600 | MDExOlB1bGxSZXF1ZXN0NDAzMjg3Nzg1 | 18,607 | Experimental test selector API | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18607/builds/24579) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 16:26:10 | 2020-05-05 17:37:59 | 2020-05-05 17:37:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18607', 'html_url': 'https://github.com/facebook/react/pull/18607', 'diff_url': 'https://github.com/facebook/react/pull/18607.diff', 'patch_url': 'https://github.com/facebook/react/pull/18607.patch', 'merged_at': datetime.datetime(2020, 5, 5, 17, 37, 47)} | Adds several new experimental APIs to aid with automated testing.
This is not an RFC, although the PR includes some basic documentation in a similar format.
## Types of selectors
Each of the methods below accepts an array of "selectors" that identifies a path (or paths) through a React tree. There are four bas... | {'url': 'https://api.github.com/repos/facebook/react/issues/18607/reactions', 'total_count': 6, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 6, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18607/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18606 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18606/labels{/name} | https://api.github.com/repos/facebook/react/issues/18606/comments | https://api.github.com/repos/facebook/react/issues/18606/events | https://github.com/facebook/react/issues/18606 | 599,626,041 | MDU6SXNzdWU1OTk2MjYwNDE= | 18,606 | Can repro this in browserstack with Pixel XL and default chrome browser, here's a gif of the behavior (notice after I press spacebar the word disappears): | {'login': 'b823', 'id': 63407550, 'node_id': 'MDQ6VXNlcjYzNDA3NTUw', 'avatar_url': 'https://avatars.githubusercontent.com/u/63407550?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/b823', 'html_url': 'https://github.com/b823', 'followers_url': 'https://api.github.com/users/b823/followers', 'following_url'... | [{'id': 1168115654, 'node_id': 'MDU6TGFiZWwxMTY4MTE1NjU0', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Support%20Redirect', 'name': 'Resolution: Support Redirect', 'color': '106099', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Hey there! We use the issue tracker for bug reports and feature requests for React itself. If you have a support question, please check our [community support resources](https://facebook.github.io/react/community/support.html). If you think this is a bug in React, please file an issue with the information requeste... | 2020-04-14 14:41:51 | 2020-04-14 15:51:46 | 2020-04-14 15:51:41 | NONE | null | null | null | Can repro this in browserstack with Pixel XL and default chrome browser, here's a gif of the behavior (notice after I press spacebar the word disappears):
_Originally posted by @icd2k3 in https://github.com/facebook/draft-js/issues/1077#issue... | {'url': 'https://api.github.com/repos/facebook/react/issues/18606/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18606/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18605 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18605/labels{/name} | https://api.github.com/repos/facebook/react/issues/18605/comments | https://api.github.com/repos/facebook/react/issues/18605/events | https://github.com/facebook/react/pull/18605 | 599,556,609 | MDExOlB1bGxSZXF1ZXN0NDAzMTcxMzE5 | 18,605 | Adds clarity to test renderer expectOne error | {'login': 'iturgeon', 'id': 73480, 'node_id': 'MDQ6VXNlcjczNDgw', 'avatar_url': 'https://avatars.githubusercontent.com/u/73480?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/iturgeon', 'html_url': 'https://github.com/iturgeon', 'followers_url': 'https://api.github.com/users/iturgeon/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18605/builds/19799) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 13:04:18 | 2020-07-14 20:02:59 | 2020-07-14 03:18:17 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18605', 'html_url': 'https://github.com/facebook/react/pull/18605', 'diff_url': 'https://github.com/facebook/react/pull/18605.diff', 'patch_url': 'https://github.com/facebook/react/pull/18605.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18605/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18605/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18604 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18604/labels{/name} | https://api.github.com/repos/facebook/react/issues/18604/comments | https://api.github.com/repos/facebook/react/issues/18604/events | https://github.com/facebook/react/pull/18604 | 599,550,038 | MDExOlB1bGxSZXF1ZXN0NDAzMTY1OTk1 | 18,604 | ReactDOM.useEvent: add useFocus and useFocusWithin interactions | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18604/builds/19886) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 12:53:31 | 2020-04-14 21:06:51 | 2020-04-14 21:06:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18604', 'html_url': 'https://github.com/facebook/react/pull/18604', 'diff_url': 'https://github.com/facebook/react/pull/18604.diff', 'patch_url': 'https://github.com/facebook/react/pull/18604.patch', 'merged_at': datetime.datetime(2020, 4, 14, 21, 6, 47)} | This is a port of the `FocusResponder` and `FocusWithinResponder` from React Flare, to its equivalent hooks – `useFocus` and `useFocusWithin`. The previous `Focus` responder module has been prefixed with `Deprecated` to show that it's a different file, to avoid confusion.
Almost all of the main logic is copy and pas... | {'url': 'https://api.github.com/repos/facebook/react/issues/18604/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18604/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18603 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18603/labels{/name} | https://api.github.com/repos/facebook/react/issues/18603/comments | https://api.github.com/repos/facebook/react/issues/18603/events | https://github.com/facebook/react/issues/18603 | 599,523,005 | MDU6SXNzdWU1OTk1MjMwMDU= | 18,603 | Bug: index.d.ts(1713, 9): The expected type comes from property 'contentEditable' which is declared here on type 'DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>' | {'login': 'HerbertHe', 'id': 30955264, 'node_id': 'MDQ6VXNlcjMwOTU1MjY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/30955264?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/HerbertHe', 'html_url': 'https://github.com/HerbertHe', 'followers_url': 'https://api.github.com/users/HerbertHe/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This issue should've been filed over at DefinitelyTyped though it'll be closed over there anyway because we don't support non-standard attributes.\r\n\r\n> Support plaintext-only for contentEditable\r\n\r\nThis value is currently not part of the living standard. We only type attributes that are part of [the living... | 2020-04-14 12:07:07 | 2020-04-14 14:21:25 | 2020-04-14 14:21:24 | NONE | null | null | null | When I want to use contentEditable attribute as `plaintext-only`, `vscode` showed me that I can not assign `plaintext-only` to contentEditable.
React version: 16.7.0
## Steps To Reproduce
1. add a element `div`
2. assign `plaintext-only` to contentEditable
<!--
Your bug will get fixed much faster if we ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18603/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18603/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18602 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18602/labels{/name} | https://api.github.com/repos/facebook/react/issues/18602/comments | https://api.github.com/repos/facebook/react/issues/18602/events | https://github.com/facebook/react/issues/18602 | 599,393,887 | MDU6SXNzdWU1OTkzOTM4ODc= | 18,602 | Remove unstable_ from unstable_batchedUpdates | {'login': 'davidgilbertson', 'id': 4443482, 'node_id': 'MDQ6VXNlcjQ0NDM0ODI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4443482?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/davidgilbertson', 'html_url': 'https://github.com/davidgilbertson', 'followers_url': 'https://api.github.com/users/d... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"We wouldn’t remove it in a minor, yeah. It might go away in a future major because it would become the default behavior. In that world React Redux could make the helper a no-op that calls through.",
"We'd also likely publish a new React-Redux major with that kind of a change.",
"Ironically, renaming it _would_... | 2020-04-14 08:34:20 | 2020-04-15 00:20:51 | 2020-04-14 11:58:31 | CONTRIBUTOR | null | null | null | With [react-redux 7 now re-exporting `unstable_batchedUpdates` as `batch`](https://github.com/reduxjs/react-redux/releases/tag/v7.0.1), it effectively means that any change to this API would break a lot of websites.
Given that the react-redux team were encouraged to use this API by the React team, is that a hint tha... | {'url': 'https://api.github.com/repos/facebook/react/issues/18602/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18602/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18601 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18601/labels{/name} | https://api.github.com/repos/facebook/react/issues/18601/comments | https://api.github.com/repos/facebook/react/issues/18601/events | https://github.com/facebook/react/issues/18601 | 599,361,124 | MDU6SXNzdWU1OTkzNjExMjQ= | 18,601 | show props in console | {'login': 'hayoungishere', 'id': 48154977, 'node_id': 'MDQ6VXNlcjQ4MTU0OTc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/48154977?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hayoungishere', 'html_url': 'https://github.com/hayoungishere', 'followers_url': 'https://api.github.com/users/hayou... | [] | closed | false | null | [] | null | [
"You could follow this guide.\r\n\r\nhttps://reactjs.org/blog/2019/08/15/new-react-devtools.html",
"Thks! It is so helpful😆😆"
] | 2020-04-14 07:36:47 | 2020-04-14 14:21:47 | 2020-04-14 14:21:47 | NONE | null | null | null | how can i check props on chrome developer tools?
👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18601/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18601/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18600 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18600/labels{/name} | https://api.github.com/repos/facebook/react/issues/18600/comments | https://api.github.com/repos/facebook/react/issues/18600/events | https://github.com/facebook/react/pull/18600 | 599,278,029 | MDExOlB1bGxSZXF1ZXN0NDAyOTU0NzA2 | 18,600 | simplified code | {'login': 'MeSKiL', 'id': 47805585, 'node_id': 'MDQ6VXNlcjQ3ODA1NTg1', 'avatar_url': 'https://avatars.githubusercontent.com/u/47805585?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MeSKiL', 'html_url': 'https://github.com/MeSKiL', 'followers_url': 'https://api.github.com/users/MeSKiL/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @MeSKiL! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behal... | 2020-04-14 03:55:48 | 2020-05-18 12:59:40 | 2020-05-18 12:53:53 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18600', 'html_url': 'https://github.com/facebook/react/pull/18600', 'diff_url': 'https://github.com/facebook/react/pull/18600.diff', 'patch_url': 'https://github.com/facebook/react/pull/18600.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18600/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18600/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18599 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18599/labels{/name} | https://api.github.com/repos/facebook/react/issues/18599/comments | https://api.github.com/repos/facebook/react/issues/18599/events | https://github.com/facebook/react/issues/18599 | 599,273,527 | MDU6SXNzdWU1OTkyNzM1Mjc= | 18,599 | Bug: Failed state update with useTransition with different timeouts | {'login': 'subhero24', 'id': 1171150, 'node_id': 'MDQ6VXNlcjExNzExNTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1171150?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/subhero24', 'html_url': 'https://github.com/subhero24', 'followers_url': 'https://api.github.com/users/subhero24/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710722093, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Can you reproduce this with a build from master?",
"The problem also occurs with a build from master",
"Looked into it. This is the same problem as https://github.com/facebook/react/issues/17332#issuecomment-609994238.\r\n\r\nCurrently, we infer a setState's priority based on where it was called. E.g. by defau... | 2020-04-14 03:41:03 | 2020-06-29 18:41:13 | 2020-04-14 14:30:45 | NONE | null | null | null | React version: 0.0.0-experimental-e5d06e34b
I have a sandbox of the bug here: https://codesandbox.io/s/frosty-bassi-0utfp?file=/src/App.js
The component schedules a state update when a transition starts. When the timeoutMs of the transition is high, everythings works as expected. When the timeoutMs is lowered, bu... | {'url': 'https://api.github.com/repos/facebook/react/issues/18599/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18599/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18598 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18598/labels{/name} | https://api.github.com/repos/facebook/react/issues/18598/comments | https://api.github.com/repos/facebook/react/issues/18598/events | https://github.com/facebook/react/pull/18598 | 599,269,868 | MDExOlB1bGxSZXF1ZXN0NDAyOTQ4NzA3 | 18,598 | remove unnecessary variable comparation | {'login': 'BetaSu', 'id': 15828041, 'node_id': 'MDQ6VXNlcjE1ODI4MDQx', 'avatar_url': 'https://avatars.githubusercontent.com/u/15828041?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BetaSu', 'html_url': 'https://github.com/BetaSu', 'followers_url': 'https://api.github.com/users/BetaSu/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18598/builds/19694) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 03:28:50 | 2020-04-14 13:53:48 | 2020-04-14 13:53:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18598', 'html_url': 'https://github.com/facebook/react/pull/18598', 'diff_url': 'https://github.com/facebook/react/pull/18598.diff', 'patch_url': 'https://github.com/facebook/react/pull/18598.patch', 'merged_at': datetime.datetime(2020, 4, 14, 13, 53, 48)} | ## Summary
Since it will continue when the props are equal in line 767, there is no need to compare whether they are not equal.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18598/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18598/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18597 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18597/labels{/name} | https://api.github.com/repos/facebook/react/issues/18597/comments | https://api.github.com/repos/facebook/react/issues/18597/events | https://github.com/facebook/react/pull/18597 | 599,267,630 | MDExOlB1bGxSZXF1ZXN0NDAyOTQ3MDk4 | 18,597 | Remove `.internal` from more test suites | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18597/builds/19719) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 03:21:57 | 2020-04-14 14:43:01 | 2020-04-14 14:43:01 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18597', 'html_url': 'https://github.com/facebook/react/pull/18597', 'diff_url': 'https://github.com/facebook/react/pull/18597.diff', 'patch_url': 'https://github.com/facebook/react/pull/18597.patch', 'merged_at': datetime.datetime(2020, 4, 14, 14, 43, 1)} | This enables the tests to run against the actual build artifacts | {'url': 'https://api.github.com/repos/facebook/react/issues/18597/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18597/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18596 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18596/labels{/name} | https://api.github.com/repos/facebook/react/issues/18596/comments | https://api.github.com/repos/facebook/react/issues/18596/events | https://github.com/facebook/react/pull/18596 | 599,225,760 | MDExOlB1bGxSZXF1ZXN0NDAyOTE0Mjk5 | 18,596 | Delete flushSuspenseFallbacksInTests flag | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18596/builds/19684) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-14 01:05:39 | 2020-04-14 03:02:19 | 2020-04-14 03:02:19 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18596', 'html_url': 'https://github.com/facebook/react/pull/18596', 'diff_url': 'https://github.com/facebook/react/pull/18596.diff', 'patch_url': 'https://github.com/facebook/react/pull/18596.patch', 'merged_at': datetime.datetime(2020, 4, 14, 3, 2, 19)} | This was meant to be a temporary hack to unblock the `act` work, but it quickly spread throughout our tests.
What it's meant to do is force fallbacks to flush inside `act` even in Concurrent Mode. It does this by wrapping the `setTimeout` call in a check to see if it's in an `act` context. If so, it skips the delay ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18596/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18596/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18595 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18595/labels{/name} | https://api.github.com/repos/facebook/react/issues/18595/comments | https://api.github.com/repos/facebook/react/issues/18595/events | https://github.com/facebook/react/issues/18595 | 599,218,576 | MDU6SXNzdWU1OTkyMTg1NzY= | 18,595 | Delay setting useTransition isPending to true until JND | {'login': 'subhero24', 'id': 1171150, 'node_id': 'MDQ6VXNlcjExNzExNTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1171150?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/subhero24', 'html_url': 'https://github.com/subhero24', 'followers_url': 'https://api.github.com/users/subhero24/followers... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"@subhero24 this is addressed in the Concurrent Mode Patterns docs, check out [Delaying a Pending Indicator](https://reactjs.org/docs/concurrent-mode-patterns.html#delaying-a-pending-indicator). If you have other questions, check out our [community support resources](https://facebook.github.io/react/community/suppo... | 2020-04-14 00:41:05 | 2021-06-22 23:40:58 | 2021-06-22 23:40:58 | NONE | null | null | null | **Do you want to request a feature or report a bug?**
Maybe a feature?
When using Suspense and useTransition, the isPending of useTransition is immediately set to true.
I want to show a spinner when a transition is still pending, but showing it immediately results in a flashing spinner when the underlying promise ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18595/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18595/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18594 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18594/labels{/name} | https://api.github.com/repos/facebook/react/issues/18594/comments | https://api.github.com/repos/facebook/react/issues/18594/events | https://github.com/facebook/react/issues/18594 | 599,159,112 | MDU6SXNzdWU1OTkxNTkxMTI= | 18,594 | feat: allow multiple opaque identifiers in HTML attributes | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 1775955521, 'node_id': 'MDU6TGFiZWwxNzc1OTU1NTIx', 'url': 'https://api.github.com/repos/face... | closed | false | null | [] | null | [
"I like the API of using an array of opaque identifiers. You could make the argument that React should always join arrays passed to DOM attributes with a space, since the HTML spec defines the space as the list delimiter. This would be a breaking change though.\r\n\r\nOne alternative would be iterating through ever... | 2020-04-13 21:54:33 | 2021-12-08 17:40:43 | 2021-12-08 17:40:42 | COLLABORATOR | null | null | null | react version: #17322
Original: https://github.com/facebook/react/pull/17322#issuecomment-613104823
Currently only a single value from `useOpaqueIdentifier` (unreleased) can be passed to HTML attributes. However, there are HTML attributes which support multiple ids (IDREFS) like `aria-labelledby`. This can be used ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18594/reactions', 'total_count': 9, '+1': 9, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18594/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18593 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18593/labels{/name} | https://api.github.com/repos/facebook/react/issues/18593/comments | https://api.github.com/repos/facebook/react/issues/18593/events | https://github.com/facebook/react/pull/18593 | 599,158,698 | MDExOlB1bGxSZXF1ZXN0NDAyODU5OTAx | 18,593 | Fix www tests not running in prod | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18593/builds/19651) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-13 21:53:37 | 2020-04-13 22:53:14 | 2020-04-13 22:53:14 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18593', 'html_url': 'https://github.com/facebook/react/pull/18593', 'diff_url': 'https://github.com/facebook/react/pull/18593.diff', 'patch_url': 'https://github.com/facebook/react/pull/18593.patch', 'merged_at': datetime.datetime(2020, 4, 13, 22, 53, 14)} | I made a mistake when setting these up a while ago. Setting the `NODE_ENV` in the CircleCI config doesn't work because it's also set in the node script command. So it turns out they've been running in prod the whole time. I noticed this when iterating on the new reconciler, which is only enabled in one of the www vari... | {'url': 'https://api.github.com/repos/facebook/react/issues/18593/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18593/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18592 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18592/labels{/name} | https://api.github.com/repos/facebook/react/issues/18592/comments | https://api.github.com/repos/facebook/react/issues/18592/events | https://github.com/facebook/react/pull/18592 | 599,094,814 | MDExOlB1bGxSZXF1ZXN0NDAyODA3MzIx | 18,592 | Fix "missing flag" error for non-boolean types | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18592/builds/19631) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-13 19:46:26 | 2020-04-13 19:57:32 | 2020-04-13 19:57:32 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18592', 'html_url': 'https://github.com/facebook/react/pull/18592', 'diff_url': 'https://github.com/facebook/react/pull/18592.diff', 'patch_url': 'https://github.com/facebook/react/pull/18592.patch', 'merged_at': datetime.datetime(2020, 4, 13, 19, 57, 32)} | Not all test flags are booleans, e.g. the build type | {'url': 'https://api.github.com/repos/facebook/react/issues/18592/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18592/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18591 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18591/labels{/name} | https://api.github.com/repos/facebook/react/issues/18591/comments | https://api.github.com/repos/facebook/react/issues/18591/events | https://github.com/facebook/react/issues/18591 | 599,026,915 | MDU6SXNzdWU1OTkwMjY5MTU= | 18,591 | Bug: Bubbled onFocus handler that triggers an update prevents onChange handler in createRoot | {'login': 'hamlim', 'id': 5579638, 'node_id': 'MDQ6VXNlcjU1Nzk2Mzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5579638?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hamlim', 'html_url': 'https://github.com/hamlim', 'followers_url': 'https://api.github.com/users/hamlim/followers', 'followin... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1205087127, 'node_id': 'MDU6TGFiZWwxMjA1MDg3MTI3', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [
"Thanks for the detailed bug report @hamlim. I verified the same behavior with the latest experimental release as well (`0.0.0-experimental-e5d06e34b`). You can temporarily get around this by flushing the state update in `handleFocus` synchronously [using `ReactDOM.flushSync`](https://codesandbox.io/s/createroot-br... | 2020-04-13 17:40:05 | 2021-07-22 21:15:39 | 2021-02-10 23:48:28 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: I think any experimental version.
Tested using:
* `0.0.0-exper... | {'url': 'https://api.github.com/repos/facebook/react/issues/18591/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18591/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18590 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18590/labels{/name} | https://api.github.com/repos/facebook/react/issues/18590/comments | https://api.github.com/repos/facebook/react/issues/18590/events | https://github.com/facebook/react/issues/18590 | 598,918,402 | MDU6SXNzdWU1OTg5MTg0MDI= | 18,590 | Feature request: Add new syntax for classes | {'login': 'MaxmaxmaximusGitHub', 'id': 60403187, 'node_id': 'MDQ6VXNlcjYwNDAzMTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/60403187?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MaxmaxmaximusGitHub', 'html_url': 'https://github.com/MaxmaxmaximusGitHub', 'followers_url': 'https://api.gith... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"our beloved jsx is high time to develop, because competitors (angular and vue) do not stand still ;)\r\n\r\nyou just look how cool:\r\n```javascript\r\n<ul .users>\r\n {this.props.users.map( user =>\r\n <li .user .banned={ user.isBanned } .admin={ user.isAdmin }>\r\n User { user.name }\r\n </li>\... | 2020-04-13 14:23:14 | 2020-04-13 15:52:43 | 2020-04-13 15:52:13 | NONE | null | null | null | **Attributes names with started a dot symbol is prohibited, so dot is idle idle. dot can be used for syntactic sugar for routine 90% of the operations of assigning classes to elements.**
new JSX class syntax:
1) attr start with dot is class name (intentionally similar to css, yes)
2) if this attr have expression v... | {'url': 'https://api.github.com/repos/facebook/react/issues/18590/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18590/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18589 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18589/labels{/name} | https://api.github.com/repos/facebook/react/issues/18589/comments | https://api.github.com/repos/facebook/react/issues/18589/events | https://github.com/facebook/react/issues/18589 | 598,890,949 | MDU6SXNzdWU1OTg4OTA5NDk= | 18,589 | Bug: react test utils do not work together with esm module | {'login': 'just-boris', 'id': 812240, 'node_id': 'MDQ6VXNlcjgxMjI0MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/812240?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/just-boris', 'html_url': 'https://github.com/just-boris', 'followers_url': 'https://api.github.com/users/just-boris/followe... | [{'id': 139653724, 'node_id': 'MDU6TGFiZWwxMzk2NTM3MjQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Core%20Utilities', 'name': 'Component: Core Utilities', 'color': 'c5def5', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Do you want to submit a PR @just-boris? It sounds like a reasonable thing for us to fix.",
"@aweary, I could, however I am not sure about testing part. What kind of tests would you expect for this?"
] | 2020-04-13 13:31:39 | 2020-04-16 11:36:27 | 2020-04-16 11:36:27 | CONTRIBUTOR | null | null | null | React version: 16.13.1
## Steps To Reproduce
This code works fine when using plain Node.js, but fails: when [esm module](https://github.com/standard-things/esm) is enabled:
```js
const { act } = require('react-dom/test-utils');
act(async () => {
console.log('something');
}).then(
() => console.log('... | {'url': 'https://api.github.com/repos/facebook/react/issues/18589/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18589/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18588 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18588/labels{/name} | https://api.github.com/repos/facebook/react/issues/18588/comments | https://api.github.com/repos/facebook/react/issues/18588/events | https://github.com/facebook/react/issues/18588 | 598,847,714 | MDU6SXNzdWU1OTg4NDc3MTQ= | 18,588 | Feature request: add className object support | {'login': 'MaxmaxmaximusGitHub', 'id': 60403187, 'node_id': 'MDQ6VXNlcjYwNDAzMTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/60403187?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MaxmaxmaximusGitHub', 'html_url': 'https://github.com/MaxmaxmaximusGitHub', 'followers_url': 'https://api.gith... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I will write babel plugin for this for now =) humanity is waiting for the opportunity to set classes normally, and I provide them with a temporary solution."
] | 2020-04-13 11:54:35 | 2020-04-13 14:57:02 | 2020-04-13 14:57:02 | NONE | null | null | null | ```js
<div className={{ chat: true, __active: this.state.active }}></div>
```
like who wants too =) | {'url': 'https://api.github.com/repos/facebook/react/issues/18588/reactions', 'total_count': 4, '+1': 2, '-1': 2, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18588/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18587 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18587/labels{/name} | https://api.github.com/repos/facebook/react/issues/18587/comments | https://api.github.com/repos/facebook/react/issues/18587/events | https://github.com/facebook/react/issues/18587 | 598,818,935 | MDU6SXNzdWU1OTg4MTg5MzU= | 18,587 | Bug: react-hooks/exhaustive-deps not warning about unneeded dep | {'login': 'tonix-tuft', 'id': 10134421, 'node_id': 'MDQ6VXNlcjEwMTM0NDIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/10134421?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tonix-tuft', 'html_url': 'https://github.com/tonix-tuft', 'followers_url': 'https://api.github.com/users/tonix-tuft/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"There is no such thing as \"unneeded dependency\" in useEffect. You might not use a variable, but still want to trigger effect when it changes",
"@vkurchatkin So that kind of warning doesn't apply to `useEffect` hook? Does it mean that it only applies to `useCallback`, `useMemo` hooks and the like, e.g. like in ... | 2020-04-13 10:47:08 | 2020-05-03 21:14:15 | 2020-04-13 16:14:54 | NONE | null | null | null | In the following example:
```jsx
import ReactDOM from "react-dom";
import React, { useEffect } from "react";
import "./styles.css";
function Example() {
const id = 123;
const valueWhichMayChange = Math.random();
useEffect(() => {
return () => {
//valueWhichMayChange === 0.5 &&
docum... | {'url': 'https://api.github.com/repos/facebook/react/issues/18587/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18587/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18586 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18586/labels{/name} | https://api.github.com/repos/facebook/react/issues/18586/comments | https://api.github.com/repos/facebook/react/issues/18586/events | https://github.com/facebook/react/pull/18586 | 598,790,524 | MDExOlB1bGxSZXF1ZXN0NDAyNTY2ODQ5 | 18,586 | DevTools: Switch between "Rendered At" renders using keyboard arrow keys | {'login': 'ChrisDobby', 'id': 434389, 'node_id': 'MDQ6VXNlcjQzNDM4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/434389?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ChrisDobby', 'html_url': 'https://github.com/ChrisDobby', 'followers_url': 'https://api.github.com/users/ChrisDobby/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18586/builds/19634) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-13 09:45:29 | 2020-04-13 20:03:06 | 2020-04-13 20:00:14 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18586', 'html_url': 'https://github.com/facebook/react/pull/18586', 'diff_url': 'https://github.com/facebook/react/pull/18586.diff', 'patch_url': 'https://github.com/facebook/react/pull/18586.patch', 'merged_at': datetime.datetime(2020, 4, 13, 20, 0, 14)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18586/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18586/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18585 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18585/labels{/name} | https://api.github.com/repos/facebook/react/issues/18585/comments | https://api.github.com/repos/facebook/react/issues/18585/events | https://github.com/facebook/react/pull/18585 | 598,702,830 | MDExOlB1bGxSZXF1ZXN0NDAyNDk2MTY3 | 18,585 | Migrate conditional tests to gate pragma | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18585/builds/19643) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-13 06:27:18 | 2020-04-13 21:45:53 | 2020-04-13 21:45:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18585', 'html_url': 'https://github.com/facebook/react/pull/18585', 'diff_url': 'https://github.com/facebook/react/pull/18585.diff', 'patch_url': 'https://github.com/facebook/react/pull/18585.patch', 'merged_at': datetime.datetime(2020, 4, 13, 21, 45, 53)} | ## Based on #18582
I split this up from the previous PR because the changes in here weren't completely automated. I had to manually edit stuff.
I searched through the codebase for this pattern:
```js
describe('test suite', () => {
if (!__EXPERIMENTAL__) { // or some other condition
test("empty test so... | {'url': 'https://api.github.com/repos/facebook/react/issues/18585/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18585/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18584 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18584/labels{/name} | https://api.github.com/repos/facebook/react/issues/18584/comments | https://api.github.com/repos/facebook/react/issues/18584/events | https://github.com/facebook/react/pull/18584 | 598,475,354 | MDExOlB1bGxSZXF1ZXN0NDAyMzMyNjcx | 18,584 | Add keyboard navigation to fibre info sidebar | {'login': 'ChrisDobby', 'id': 434389, 'node_id': 'MDQ6VXNlcjQzNDM4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/434389?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ChrisDobby', 'html_url': 'https://github.com/ChrisDobby', 'followers_url': 'https://api.github.com/users/ChrisDobby/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18584/builds/19542) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-12 12:35:55 | 2020-04-13 08:33:24 | 2020-04-13 08:33:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18584', 'html_url': 'https://github.com/facebook/react/pull/18584', 'diff_url': 'https://github.com/facebook/react/pull/18584.diff', 'patch_url': 'https://github.com/facebook/react/pull/18584.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18584/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18584/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18583 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18583/labels{/name} | https://api.github.com/repos/facebook/react/issues/18583/comments | https://api.github.com/repos/facebook/react/issues/18583/events | https://github.com/facebook/react/issues/18583 | 598,457,648 | MDU6SXNzdWU1OTg0NTc2NDg= | 18,583 | Why is the output executed twice | {'login': 'VitaminCtea', 'id': 35827111, 'node_id': 'MDQ6VXNlcjM1ODI3MTEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/35827111?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/VitaminCtea', 'html_url': 'https://github.com/VitaminCtea', 'followers_url': 'https://api.github.com/users/VitaminCtea... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Your app is running in strict mode (check `src/index.js`). Strict mode helps catch bugs caused by side effects and mutations by intentionally calling twice functions that are supposed to be pure. (If they’re really pure then this should not affect the behavior of your program.)\r\n\r\nIn your example, the function... | 2020-04-12 10:46:03 | 2020-04-12 13:48:43 | 2020-04-12 13:48:42 | NONE | null | null | null | I am simulating the undo and redo functions, but every time I click the undo button, the console prints the result twice instead of every time. What should I do? Is this the react bug? This is also the case with the function component hook count example, where the useEffect callback function prints the same value twice... | {'url': 'https://api.github.com/repos/facebook/react/issues/18583/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18583/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18582 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18582/labels{/name} | https://api.github.com/repos/facebook/react/issues/18582/comments | https://api.github.com/repos/facebook/react/issues/18582/events | https://github.com/facebook/react/pull/18582 | 598,412,213 | MDExOlB1bGxSZXF1ZXN0NDAyMjg4MTA4 | 18,582 | Codemod it.experimental to gate pragma | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18582/builds/19400) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-12 05:07:43 | 2020-04-13 17:29:00 | 2020-04-13 17:29:00 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18582', 'html_url': 'https://github.com/facebook/react/pull/18582', 'diff_url': 'https://github.com/facebook/react/pull/18582.diff', 'patch_url': 'https://github.com/facebook/react/pull/18582.patch', 'merged_at': datetime.datetime(2020, 4, 13, 17, 29)} | Codemods all uses of `it.experimental` to the gate pragma added in #18581.
[**Quick review link**](https://github.com/facebook/react/compare/master...acdlite:remove-it-experimental?w=1) | {'url': 'https://api.github.com/repos/facebook/react/issues/18582/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18582/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18581 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18581/labels{/name} | https://api.github.com/repos/facebook/react/issues/18581/comments | https://api.github.com/repos/facebook/react/issues/18581/events | https://github.com/facebook/react/pull/18581 | 598,408,094 | MDExOlB1bGxSZXF1ZXN0NDAyMjg1MDky | 18,581 | Add pragma for feature testing: @gate | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18581/builds/19605) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-12 04:26:44 | 2020-04-13 19:15:14 | 2020-04-13 17:14:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18581', 'html_url': 'https://github.com/facebook/react/pull/18581', 'diff_url': 'https://github.com/facebook/react/pull/18581.diff', 'patch_url': 'https://github.com/facebook/react/pull/18581.patch', 'merged_at': datetime.datetime(2020, 4, 13, 17, 14, 35)} | ## Alternative to #18574
The `@gate` pragma declares under which conditions a test is expected to pass.
If the gate condition passes, then the test runs normally (same as if there were no pragma).
If the conditional fails, then the test is **expected to fail**. This ensures that all tests run in all environmen... | {'url': 'https://api.github.com/repos/facebook/react/issues/18581/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18581/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18580 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18580/labels{/name} | https://api.github.com/repos/facebook/react/issues/18580/comments | https://api.github.com/repos/facebook/react/issues/18580/events | https://github.com/facebook/react/pull/18580 | 598,347,474 | MDExOlB1bGxSZXF1ZXN0NDAyMjQ0NjYz | 18,580 | Feature: Add support to `exhaustive-deps` rule for any hook ending with `Effect` | {'login': 'airjp73', 'id': 25882770, 'node_id': 'MDQ6VXNlcjI1ODgyNzcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/25882770?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/airjp73', 'html_url': 'https://github.com/airjp73', 'followers_url': 'https://api.github.com/users/airjp73/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18580/builds/19354) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-11 20:43:15 | 2020-05-26 15:12:16 | 2020-05-01 15:57:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18580', 'html_url': 'https://github.com/facebook/react/pull/18580', 'diff_url': 'https://github.com/facebook/react/pull/18580.diff', 'patch_url': 'https://github.com/facebook/react/pull/18580.patch', 'merged_at': datetime.datetime(2020, 5, 1, 15, 57, 25)} | ## Summary
Following up on @gaearon 's comment [here](https://github.com/facebook/react/pull/16912#issuecomment-611724673). My original motivation was to document the `additionalHooks` option in the `exhaustive-deps` lint rule. He suggested an alternate solution by linting any hook ending with `Effect`. This PR adds... | {'url': 'https://api.github.com/repos/facebook/react/issues/18580/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18580/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18579 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18579/labels{/name} | https://api.github.com/repos/facebook/react/issues/18579/comments | https://api.github.com/repos/facebook/react/issues/18579/events | https://github.com/facebook/react/issues/18579 | 598,327,619 | MDU6SXNzdWU1OTgzMjc2MTk= | 18,579 | Update workbox plugin to 5.1.2 resolving ServiceWorker quota exceeded errors | {'login': 'jflayhart', 'id': 6808172, 'node_id': 'MDQ6VXNlcjY4MDgxNzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6808172?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jflayhart', 'html_url': 'https://github.com/jflayhart', 'followers_url': 'https://api.github.com/users/jflayhart/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"haha oops i had too many tabs open, meant to post in CRA!"
] | 2020-04-11 18:46:18 | 2020-04-11 23:15:36 | 2020-04-11 18:51:05 | NONE | null | null | null | Currently our e-commerce site is experiencing millions of ServiceWorker `DOMException: QuotaExceededError` errors, which is blowing through our monthly Rollbar limit 😬. I did some brief research and [found that Google is aware of this issue](https://github.com/GoogleChrome/workbox/pull/1505) and [recommends `purgeOnQu... | {'url': 'https://api.github.com/repos/facebook/react/issues/18579/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18579/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18578 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18578/labels{/name} | https://api.github.com/repos/facebook/react/issues/18578/comments | https://api.github.com/repos/facebook/react/issues/18578/events | https://github.com/facebook/react/issues/18578 | 598,260,864 | MDU6SXNzdWU1OTgyNjA4NjQ= | 18,578 | Component variables are "undefined" | {'login': 'renan2158', 'id': 43219765, 'node_id': 'MDQ6VXNlcjQzMjE5NzY1', 'avatar_url': 'https://avatars.githubusercontent.com/u/43219765?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/renan2158', 'html_url': 'https://github.com/renan2158', 'followers_url': 'https://api.github.com/users/renan2158/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-04-11 12:56:14 | 2020-04-11 19:44:22 | 2020-04-11 19:44:22 | NONE | null | null | null | * React @ `16.13.1`
I'm passing some props to the gallery component through this route:
`<Route path='/gallery' render={props => <Gallery {...props} />} />`
Everything looks fine here. I've tested and all the values of the props are arriving in the component. But when I try to set the values in the component v... | {'url': 'https://api.github.com/repos/facebook/react/issues/18578/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18578/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18577 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18577/labels{/name} | https://api.github.com/repos/facebook/react/issues/18577/comments | https://api.github.com/repos/facebook/react/issues/18577/events | https://github.com/facebook/react/issues/18577 | 598,255,285 | MDU6SXNzdWU1OTgyNTUyODU= | 18,577 | Bug: Type warning on forwarding ref of createPortal | {'login': 'sayjeyhi', 'id': 6254009, 'node_id': 'MDQ6VXNlcjYyNTQwMDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6254009?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sayjeyhi', 'html_url': 'https://github.com/sayjeyhi', 'followers_url': 'https://api.github.com/users/sayjeyhi/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"@sayjeyhi I don't see any type annotations in the sandbox you linked, but it sounds like a TypeScript error. We don't maintain the TypeScript definitions for React. You should report any issues to [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react)."
] | 2020-04-11 12:22:32 | 2020-04-13 18:55:29 | 2020-04-13 18:55:28 | NONE | null | null | null | `forwardRef` for a `createPortal` has a type warning which says :
```bash
Argument type function(*, *): {chilren, implementation, containerInfo, $$typeof, key} is not assignable to parameter type RefForwardingComponent<unkown, {}>
```
Actually I see this warning only on intellij idea platforms, for example :
```... | {'url': 'https://api.github.com/repos/facebook/react/issues/18577/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18577/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18576 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18576/labels{/name} | https://api.github.com/repos/facebook/react/issues/18576/comments | https://api.github.com/repos/facebook/react/issues/18576/events | https://github.com/facebook/react/pull/18576 | 598,178,547 | MDExOlB1bGxSZXF1ZXN0NDAyMTMxODY0 | 18,576 | Store unique ID counter on SSR request object and Add Prefix for separate renders | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18576/builds/25165) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-11 03:18:57 | 2020-05-08 03:46:28 | 2020-05-08 03:46:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18576', 'html_url': 'https://github.com/facebook/react/pull/18576', 'diff_url': 'https://github.com/facebook/react/pull/18576.diff', 'patch_url': 'https://github.com/facebook/react/pull/18576.patch', 'merged_at': datetime.datetime(2020, 5, 8, 3, 46, 27)} | There is a worry that `useOpaqueIdentifier` might run out of unique IDs if running for long enough. This PR moves the unique ID counter so it's generated per server renderer object instead. For people who render different subtrees, this PR adds a `prefix` option to `renderToString`, `renderToStaticMarkup`, `renderToNod... | {'url': 'https://api.github.com/repos/facebook/react/issues/18576/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18576/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18575 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18575/labels{/name} | https://api.github.com/repos/facebook/react/issues/18575/comments | https://api.github.com/repos/facebook/react/issues/18575/events | https://github.com/facebook/react/pull/18575 | 598,151,226 | MDExOlB1bGxSZXF1ZXN0NDAyMTEyMTYx | 18,575 | Fix Component Stacks for IE and Native Classes in Safari | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18575/builds/19295) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-11 00:21:14 | 2020-04-11 16:57:32 | 2020-04-11 02:39:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18575', 'html_url': 'https://github.com/facebook/react/pull/18575', 'diff_url': 'https://github.com/facebook/react/pull/18575.diff', 'patch_url': 'https://github.com/facebook/react/pull/18575.patch', 'merged_at': datetime.datetime(2020, 4, 11, 2, 39, 3)} | This is a follow up to https://github.com/facebook/react/pull/18561
It adds more test cases and includes a fix to Safari since Safari adds another stack frame for the construct call. Polyfills might do something similar so this tries to be resilient by skipping over those.
## Results from fixtures
### Chrome:
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18575/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18575/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18574 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18574/labels{/name} | https://api.github.com/repos/facebook/react/issues/18574/comments | https://api.github.com/repos/facebook/react/issues/18574/events | https://github.com/facebook/react/pull/18574 | 598,128,453 | MDExOlB1bGxSZXF1ZXN0NDAyMDk1ODM5 | 18,574 | Add test helpers for gating by feature | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18574/builds/19280) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-10 22:51:45 | 2020-04-13 19:14:45 | 2020-04-13 19:14:44 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18574', 'html_url': 'https://github.com/facebook/react/pull/18574', 'diff_url': 'https://github.com/facebook/react/pull/18574.diff', 'patch_url': 'https://github.com/facebook/react/pull/18574.patch', 'merged_at': None} | Adds a new test helper, `it.gate`. You pass it the name of a feature flag, and if the flag is enabled, it asserts that the test passes. If the flag is off, it asserts that the test fails. Example:
```js
it.gate('enableNewReconciler', 'test that only passes in new reconciler', () => {
// ... test goes here
});
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18574/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18574/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18573 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18573/labels{/name} | https://api.github.com/repos/facebook/react/issues/18573/comments | https://api.github.com/repos/facebook/react/issues/18573/events | https://github.com/facebook/react/pull/18573 | 598,103,018 | MDExOlB1bGxSZXF1ZXN0NDAyMDc2NTE2 | 18,573 | [temp] DebugTracing | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18573/builds/19274) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-10 21:29:06 | 2020-04-10 22:24:42 | 2020-04-10 22:24:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18573', 'html_url': 'https://github.com/facebook/react/pull/18573', 'diff_url': 'https://github.com/facebook/react/pull/18573.diff', 'patch_url': 'https://github.com/facebook/react/pull/18573.patch', 'merged_at': None} | Just kicking off a build in case my half broken rebase attempt worked. The proper PR is in Brian's branch. This is probably broken | {'url': 'https://api.github.com/repos/facebook/react/issues/18573/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18573/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18572 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18572/labels{/name} | https://api.github.com/repos/facebook/react/issues/18572/comments | https://api.github.com/repos/facebook/react/issues/18572/events | https://github.com/facebook/react/pull/18572 | 598,101,111 | MDExOlB1bGxSZXF1ZXN0NDAyMDc0OTgw | 18,572 | Failing test related to usage of Suspense and Context in memoized component | {'login': 'Tsdevendra1', 'id': 38055748, 'node_id': 'MDQ6VXNlcjM4MDU1NzQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/38055748?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Tsdevendra1', 'html_url': 'https://github.com/Tsdevendra1', 'followers_url': 'https://api.github.com/users/Tsdevendra1... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18572/builds/20310) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-10 21:23:29 | 2020-10-04 07:50:30 | 2020-10-04 07:50:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18572', 'html_url': 'https://github.com/facebook/react/pull/18572', 'diff_url': 'https://github.com/facebook/react/pull/18572.diff', 'patch_url': 'https://github.com/facebook/react/pull/18572.patch', 'merged_at': None} | Failing test as requested related to #17356.
This is a failing test which shows that when useContext and throwing a promise are used in a memoized component, it fails to update after the promise has resolved. | {'url': 'https://api.github.com/repos/facebook/react/issues/18572/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18572/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18571 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18571/labels{/name} | https://api.github.com/repos/facebook/react/issues/18571/comments | https://api.github.com/repos/facebook/react/issues/18571/events | https://github.com/facebook/react/issues/18571 | 597,992,460 | MDU6SXNzdWU1OTc5OTI0NjA= | 18,571 | DevTools: Memo(ForwardRef()) and "Rendered By" List | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"It's especially bad because it breaks the \"rendered by\" chain for inner trees. They \"stop\" at the inner memo() content (unless it's SimpleMemo).\r\n\r\nI think this might also be why RN inspector sometimes shows trees that stop abruptly without going all the way up to the root.",
"I think this not only happe... | 2020-04-10 17:05:56 | 2020-08-10 14:49:11 | 2020-08-10 14:49:11 | COLLABORATOR | null | null | null | If you have `memo(forwardRef(X))`, then the inner component won't have a "rendered by" list. This is because it technically doesn't have an owner. It is artificial.
I think we should ideally set up `_debugOwner` for these Fibers in DEV just so existing tooling can find them. Or special case them in DevTools. | {'url': 'https://api.github.com/repos/facebook/react/issues/18571/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18571/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18570 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18570/labels{/name} | https://api.github.com/repos/facebook/react/issues/18570/comments | https://api.github.com/repos/facebook/react/issues/18570/events | https://github.com/facebook/react/issues/18570 | 597,802,703 | MDU6SXNzdWU1OTc4MDI3MDM= | 18,570 | HTML5 video tag doesn't work properly on iOS | {'login': 'FerusAndBeyond', 'id': 18237033, 'node_id': 'MDQ6VXNlcjE4MjM3MDMz', 'avatar_url': 'https://avatars.githubusercontent.com/u/18237033?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/FerusAndBeyond', 'html_url': 'https://github.com/FerusAndBeyond', 'followers_url': 'https://api.github.com/users/Fe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Duplicate of #10389"
] | 2020-04-10 09:47:09 | 2020-04-13 16:16:40 | 2020-04-13 16:16:39 | NONE | null | null | null | See all comments here: https://github.com/facebook/react/issues/6544 | {'url': 'https://api.github.com/repos/facebook/react/issues/18570/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18570/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18569 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18569/labels{/name} | https://api.github.com/repos/facebook/react/issues/18569/comments | https://api.github.com/repos/facebook/react/issues/18569/events | https://github.com/facebook/react/pull/18569 | 597,663,099 | MDExOlB1bGxSZXF1ZXN0NDAxNzMyMDYy | 18,569 | Overhauled release scripts and docs | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18569/builds/19254) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-10 02:46:52 | 2020-04-10 19:28:44 | 2020-04-10 19:28:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18569', 'html_url': 'https://github.com/facebook/react/pull/18569', 'diff_url': 'https://github.com/facebook/react/pull/18569.diff', 'patch_url': 'https://github.com/facebook/react/pull/18569.patch', 'merged_at': datetime.datetime(2020, 4, 10, 19, 28, 41)} | This PR updates our release script instructions to match our newer release process and CI task names.
It also renames several scripts to more clearly match their purpose:
* `create-next` ->`build-release-locally`
* `prepare-next` -> `prepare-release-from-ci`
* `promote-stable` -> `prepare-release-from-npm`
[**... | {'url': 'https://api.github.com/repos/facebook/react/issues/18569/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18569/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18568 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18568/labels{/name} | https://api.github.com/repos/facebook/react/issues/18568/comments | https://api.github.com/repos/facebook/react/issues/18568/events | https://github.com/facebook/react/pull/18568 | 597,633,128 | MDExOlB1bGxSZXF1ZXN0NDAxNzA5NDQ5 | 18,568 | ESLint rule to forbid cross fork imports | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18568/builds/19142) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-10 00:50:34 | 2020-04-10 01:11:36 | 2020-04-10 01:11:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18568', 'html_url': 'https://github.com/facebook/react/pull/18568', 'diff_url': 'https://github.com/facebook/react/pull/18568.diff', 'patch_url': 'https://github.com/facebook/react/pull/18568.patch', 'merged_at': datetime.datetime(2020, 4, 10, 1, 11, 35)} | Modules that belong to one fork should not import modules that belong to the other fork.
Helps make sure you correctly update imports when syncing changes across implementations.
Also could help protect against code size regressions that might happen if one of the forks accidentally depends on two copies of the s... | {'url': 'https://api.github.com/repos/facebook/react/issues/18568/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18568/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18567 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18567/labels{/name} | https://api.github.com/repos/facebook/react/issues/18567/comments | https://api.github.com/repos/facebook/react/issues/18567/events | https://github.com/facebook/react/pull/18567 | 597,625,454 | MDExOlB1bGxSZXF1ZXN0NDAxNzAzMjI4 | 18,567 | Bubble errors if processing the error itself errors | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18567/builds/19140) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-10 00:19:36 | 2020-04-10 00:40:12 | 2020-04-10 00:40:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18567', 'html_url': 'https://github.com/facebook/react/pull/18567', 'diff_url': 'https://github.com/facebook/react/pull/18567.diff', 'patch_url': 'https://github.com/facebook/react/pull/18567.patch', 'merged_at': datetime.datetime(2020, 4, 10, 0, 40, 11)} | If we've tried completing an incomplete boundary once and failed, we don't need to try again.
Avoids an infinite loop when something causes the error processing to fail. | {'url': 'https://api.github.com/repos/facebook/react/issues/18567/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18567/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18566 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18566/labels{/name} | https://api.github.com/repos/facebook/react/issues/18566/comments | https://api.github.com/repos/facebook/react/issues/18566/events | https://github.com/facebook/react/pull/18566 | 597,617,911 | MDExOlB1bGxSZXF1ZXN0NDAxNjk3MDQ3 | 18,566 | Don't return from perform/completeUnitOfWork | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18566/builds/19137) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 23:53:17 | 2020-04-10 00:12:05 | 2020-04-10 00:12:05 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18566', 'html_url': 'https://github.com/facebook/react/pull/18566', 'diff_url': 'https://github.com/facebook/react/pull/18566.diff', 'patch_url': 'https://github.com/facebook/react/pull/18566.patch', 'merged_at': datetime.datetime(2020, 4, 10, 0, 12, 5)} | Mutate workInProgress instead of returning. We started out returning it but we have since started mutating causing ambivalent behavior of what the methods were supposed to do since they're both mutating and returning. We now always mutate and never return anything from perform and complete. | {'url': 'https://api.github.com/repos/facebook/react/issues/18566/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18566/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18565 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18565/labels{/name} | https://api.github.com/repos/facebook/react/issues/18565/comments | https://api.github.com/repos/facebook/react/issues/18565/events | https://github.com/facebook/react/issues/18565 | 597,605,011 | MDU6SXNzdWU1OTc2MDUwMTE= | 18,565 | useOpaqueIdentifier and multiple React cases | {'login': 'theKashey', 'id': 582410, 'node_id': 'MDQ6VXNlcjU4MjQxMA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/582410?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/theKashey', 'html_url': 'https://github.com/theKashey', 'followers_url': 'https://api.github.com/users/theKashey/followers',... | [{'id': 710332294, 'node_id': 'MDU6TGFiZWw3MTAzMzIyOTQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Server%20Rendering', 'name': 'Component: Server Rendering', 'color': 'd4c5f9', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https:... | closed | false | null | [] | null | [
"Related: #18576",
"`hydrateRoot` and `renderToPipeableStream` accept `identifierPrefix` which lets you have independent IDs if multiple Reacts have to be on the same page."
] | 2020-04-09 23:12:06 | 2022-03-30 00:37:05 | 2022-03-30 00:37:04 | CONTRIBUTOR | null | null | null | React version: experimental
This is a theoretical issue, and is not proven to be a real issue. Written after #17322
## Steps To Reproduce
1. Use multiple independent version of react
2. Get a clash of `id`s
## The current behavior
Every React instance is generating `ids` based on a single counter, which... | {'url': 'https://api.github.com/repos/facebook/react/issues/18565/reactions', 'total_count': 3, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18565/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18564 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18564/labels{/name} | https://api.github.com/repos/facebook/react/issues/18564/comments | https://api.github.com/repos/facebook/react/issues/18564/events | https://github.com/facebook/react/pull/18564 | 597,570,014 | MDExOlB1bGxSZXF1ZXN0NDAxNjU5MTQ1 | 18,564 | Refactor detachFiber to a later stage | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18564/builds/19740) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 21:41:56 | 2020-04-14 17:06:20 | 2020-04-14 17:06:19 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18564', 'html_url': 'https://github.com/facebook/react/pull/18564', 'diff_url': 'https://github.com/facebook/react/pull/18564.diff', 'patch_url': 'https://github.com/facebook/react/pull/18564.patch', 'merged_at': None} | This PR is kind of a follow up to these PRs:
https://github.com/facebook/react/pull/18529
https://github.com/facebook/react/pull/18556
Specifically, in https://github.com/facebook/react/pull/18556, which cleared the `sibling` Fiber field, we encountered a failing internal test. The test related to `onBeforeBlur`... | {'url': 'https://api.github.com/repos/facebook/react/issues/18564/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18564/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18563 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18563/labels{/name} | https://api.github.com/repos/facebook/react/issues/18563/comments | https://api.github.com/repos/facebook/react/issues/18563/events | https://github.com/facebook/react/pull/18563 | 597,541,569 | MDExOlB1bGxSZXF1ZXN0NDAxNjM1MzI3 | 18,563 | Update README.md | {'login': 'hamada-j', 'id': 57291487, 'node_id': 'MDQ6VXNlcjU3MjkxNDg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/57291487?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hamada-j', 'html_url': 'https://github.com/hamada-j', 'followers_url': 'https://api.github.com/users/hamada-j/followers',... | [] | closed | false | null | [] | null | [
"Hi @hamada-j! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-04-09 20:43:18 | 2020-07-19 17:24:25 | 2020-07-19 17:16:51 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18563', 'html_url': 'https://github.com/facebook/react/pull/18563', 'diff_url': 'https://github.com/facebook/react/pull/18563.diff', 'patch_url': 'https://github.com/facebook/react/pull/18563.patch', 'merged_at': None} | new
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1... | {'url': 'https://api.github.com/repos/facebook/react/issues/18563/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18563/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18562 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18562/labels{/name} | https://api.github.com/repos/facebook/react/issues/18562/comments | https://api.github.com/repos/facebook/react/issues/18562/events | https://github.com/facebook/react/pull/18562 | 597,511,576 | MDExOlB1bGxSZXF1ZXN0NDAxNjEwNDky | 18,562 | Revert "Clear more Fiber fields in detachFiber" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18562/builds/19100) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 19:44:52 | 2022-11-29 22:21:46 | 2020-04-09 19:45:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18562', 'html_url': 'https://github.com/facebook/react/pull/18562', 'diff_url': 'https://github.com/facebook/react/pull/18562.diff', 'patch_url': 'https://github.com/facebook/react/pull/18562.patch', 'merged_at': datetime.datetime(2020, 4, 9, 19, 45, 3)} | Reverts facebook/react#18556
This breaks some `beforeblur` + Scopes stuff. | {'url': 'https://api.github.com/repos/facebook/react/issues/18562/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18562/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18561 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18561/labels{/name} | https://api.github.com/repos/facebook/react/issues/18561/comments | https://api.github.com/repos/facebook/react/issues/18561/events | https://github.com/facebook/react/pull/18561 | 597,487,766 | MDExOlB1bGxSZXF1ZXN0NDAxNTkxMjAy | 18,561 | Build Component Stacks from Native Stack Frames | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18561/builds/19253) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 18:59:19 | 2020-04-18 01:10:31 | 2020-04-10 20:32:13 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18561', 'html_url': 'https://github.com/facebook/react/pull/18561', 'diff_url': 'https://github.com/facebook/react/pull/18561.diff', 'patch_url': 'https://github.com/facebook/react/pull/18561.patch', 'merged_at': datetime.datetime(2020, 4, 10, 20, 32, 13)} | Instead of using displayName/name and source location from jsxDEV, this uses a hack to extract the native stack frame of the function. That way it's zero-cost when an error is not hit and we can feel good about including it in production environments too.
It works by calling each function once with invalid input and... | {'url': 'https://api.github.com/repos/facebook/react/issues/18561/reactions', 'total_count': 12, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 10, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/18561/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18560 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18560/labels{/name} | https://api.github.com/repos/facebook/react/issues/18560/comments | https://api.github.com/repos/facebook/react/issues/18560/events | https://github.com/facebook/react/pull/18560 | 597,466,943 | MDExOlB1bGxSZXF1ZXN0NDAxNTc0NDQx | 18,560 | wrapped whole invocation in parentheses | {'login': 'vetrivelcsamy', 'id': 26738977, 'node_id': 'MDQ6VXNlcjI2NzM4OTc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/26738977?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vetrivelcsamy', 'html_url': 'https://github.com/vetrivelcsamy', 'followers_url': 'https://api.github.com/users/vetri... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18560/builds/19081) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 18:19:56 | 2020-04-09 18:28:13 | 2020-04-09 18:28:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18560', 'html_url': 'https://github.com/facebook/react/pull/18560', 'diff_url': 'https://github.com/facebook/react/pull/18560.diff', 'patch_url': 'https://github.com/facebook/react/pull/18560.patch', 'merged_at': None} | Example:
```javascript
(function ( ) {
var hidden_variable;
// This function can have some impact on
// the environment, but introduces no new
// global variables.
}());
```
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough... | {'url': 'https://api.github.com/repos/facebook/react/issues/18560/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18560/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18559 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18559/labels{/name} | https://api.github.com/repos/facebook/react/issues/18559/comments | https://api.github.com/repos/facebook/react/issues/18559/events | https://github.com/facebook/react/pull/18559 | 597,458,535 | MDExOlB1bGxSZXF1ZXN0NDAxNTY3NzU0 | 18,559 | Exclude forwardRef and memo from stack frames | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18559/builds/19080) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 18:03:56 | 2020-04-09 18:42:23 | 2020-04-09 18:42:23 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18559', 'html_url': 'https://github.com/facebook/react/pull/18559', 'diff_url': 'https://github.com/facebook/react/pull/18559.diff', 'patch_url': 'https://github.com/facebook/react/pull/18559.patch', 'merged_at': datetime.datetime(2020, 4, 9, 18, 42, 23)} | We can't patch the row with the new trick. So they won't be called `Memo(Name)` in the stack anymore.
We could give these their own "built-in" stack frame since they're conceptually HoCs. I.e.
```
at Name
at Memo
```
However, from a debugging perspective this is not very useful meta data and quite noisy.... | {'url': 'https://api.github.com/repos/facebook/react/issues/18559/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18559/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18558 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18558/labels{/name} | https://api.github.com/repos/facebook/react/issues/18558/comments | https://api.github.com/repos/facebook/react/issues/18558/events | https://github.com/facebook/react/pull/18558 | 597,457,746 | MDExOlB1bGxSZXF1ZXN0NDAxNTY3MTE1 | 18,558 | Port error boundaries test to yieldValue | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18558/builds/19075) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 18:02:24 | 2020-04-09 18:13:02 | 2020-04-09 18:13:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18558', 'html_url': 'https://github.com/facebook/react/pull/18558', 'diff_url': 'https://github.com/facebook/react/pull/18558.diff', 'patch_url': 'https://github.com/facebook/react/pull/18558.patch', 'merged_at': datetime.datetime(2020, 4, 9, 18, 13, 2)} | Doesn't help now but helps the component error stacks trick. | {'url': 'https://api.github.com/repos/facebook/react/issues/18558/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18558/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18557 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18557/labels{/name} | https://api.github.com/repos/facebook/react/issues/18557/comments | https://api.github.com/repos/facebook/react/issues/18557/events | https://github.com/facebook/react/issues/18557 | 597,439,725 | MDU6SXNzdWU1OTc0Mzk3MjU= | 18,557 | Bug: dangerouslySetInnerHTML fails with ReactDOM.hydrate | {'login': 'timothympace', 'id': 5732252, 'node_id': 'MDQ6VXNlcjU3MzIyNTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5732252?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/timothympace', 'html_url': 'https://github.com/timothympace', 'followers_url': 'https://api.github.com/users/timothympa... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Realizing now that this is likely due to it being invalid HTML. A `<div>` inside a `<p>` tag is invalid html",
"Going to close this issue. There is no issue with something like this as long as the markup is valid 🤦 "
] | 2020-04-09 17:29:27 | 2020-04-09 17:58:13 | 2020-04-09 17:58:02 | NONE | null | null | null | ## Description
`dangerouslySetInnerHTML` fails in some cases with `ReactDOM.hydrate`. In my codesandbox example (linked below), I pre-populate the react `root` with the expected html, and then attempt to hydrate the app. The result is some of the markup disappears. Everything works fine when using `render`, even tho... | {'url': 'https://api.github.com/repos/facebook/react/issues/18557/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18557/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18556 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18556/labels{/name} | https://api.github.com/repos/facebook/react/issues/18556/comments | https://api.github.com/repos/facebook/react/issues/18556/events | https://github.com/facebook/react/pull/18556 | 597,411,833 | MDExOlB1bGxSZXF1ZXN0NDAxNTMwMTkw | 18,556 | Clear more Fiber fields in detachFiber | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18556/builds/19068) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 16:42:40 | 2020-04-09 17:31:41 | 2020-04-09 17:31:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18556', 'html_url': 'https://github.com/facebook/react/pull/18556', 'diff_url': 'https://github.com/facebook/react/pull/18556.diff', 'patch_url': 'https://github.com/facebook/react/pull/18556.patch', 'merged_at': datetime.datetime(2020, 4, 9, 17, 31, 34)} | I noticed that in a few snapshot traces that there were fiber leaks relating to the only paths being either `sibling` or `_debugOwner`. So let's clear both in `detachFiber`. | {'url': 'https://api.github.com/repos/facebook/react/issues/18556/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18556/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18555 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18555/labels{/name} | https://api.github.com/repos/facebook/react/issues/18555/comments | https://api.github.com/repos/facebook/react/issues/18555/events | https://github.com/facebook/react/pull/18555 | 597,318,993 | MDExOlB1bGxSZXF1ZXN0NDAxNDU0MTg3 | 18,555 | Support `additionalProperties` in `react-hooks/exhaustive-deps` | {'login': 'osdnk', 'id': 25709300, 'node_id': 'MDQ6VXNlcjI1NzA5MzAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/25709300?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/osdnk', 'html_url': 'https://github.com/osdnk', 'followers_url': 'https://api.github.com/users/osdnk/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18555/builds/19053) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 14:22:52 | 2020-04-23 15:05:23 | 2020-04-23 15:05:23 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18555', 'html_url': 'https://github.com/facebook/react/pull/18555', 'diff_url': 'https://github.com/facebook/react/pull/18555.diff', 'patch_url': 'https://github.com/facebook/react/pull/18555.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18555/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18555/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18554 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18554/labels{/name} | https://api.github.com/repos/facebook/react/issues/18554/comments | https://api.github.com/repos/facebook/react/issues/18554/events | https://github.com/facebook/react/pull/18554 | 597,304,475 | MDExOlB1bGxSZXF1ZXN0NDAxNDQyMDU1 | 18,554 | Fix fiber memory leak with runAllPassiveEffectDestroysBeforeCreates | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18554/builds/19047) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 14:01:44 | 2020-04-09 14:35:11 | 2020-04-09 14:35:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18554', 'html_url': 'https://github.com/facebook/react/pull/18554', 'diff_url': 'https://github.com/facebook/react/pull/18554.diff', 'patch_url': 'https://github.com/facebook/react/pull/18554.patch', 'merged_at': datetime.datetime(2020, 4, 9, 14, 35, 7)} | This PR should fix the memory leak we saw internally when the `runAllPassiveEffectDestroysBeforeCreates` was enabled. I tested this both on our tests and also on our internal website and tests (with my deletion array collection approach) and can confirm the issue did not come up with that approach so I'm pretty confide... | {'url': 'https://api.github.com/repos/facebook/react/issues/18554/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18554/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18553 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18553/labels{/name} | https://api.github.com/repos/facebook/react/issues/18553/comments | https://api.github.com/repos/facebook/react/issues/18553/events | https://github.com/facebook/react/pull/18553 | 597,203,534 | MDExOlB1bGxSZXF1ZXN0NDAxMzU4Njk5 | 18,553 | Move plugins into their own directory and add Legacy prefix | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18553/builds/19020) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 11:04:24 | 2020-04-09 13:18:37 | 2020-04-09 13:18:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18553', 'html_url': 'https://github.com/facebook/react/pull/18553', 'diff_url': 'https://github.com/facebook/react/pull/18553.diff', 'patch_url': 'https://github.com/facebook/react/pull/18553.patch', 'merged_at': datetime.datetime(2020, 4, 9, 13, 18, 34)} | Let's move the event plugins into their own directory, along with their tests, and prefix them with `Legacy`. The plan is to refactor the plugins so they're inlined and have less overhead/code/Flow typed. The simplest solution is to fork them so we don't break the existing plugins and can keep the legacy plugins workin... | {'url': 'https://api.github.com/repos/facebook/react/issues/18553/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18553/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18552 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18552/labels{/name} | https://api.github.com/repos/facebook/react/issues/18552/comments | https://api.github.com/repos/facebook/react/issues/18552/events | https://github.com/facebook/react/issues/18552 | 597,199,599 | MDU6SXNzdWU1OTcxOTk1OTk= | 18,552 | Bug: Props Does Not Update For Functions Bind In Constructor | {'login': 'git-blame', 'id': 19491679, 'node_id': 'MDQ6VXNlcjE5NDkxNjc5', 'avatar_url': 'https://avatars.githubusercontent.com/u/19491679?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/git-blame', 'html_url': 'https://github.com/git-blame', 'followers_url': 'https://api.github.com/users/git-blame/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Can you try to make an isolated example reproducing it? This sounds like something going bad with your compilation toolchain. Seeing the generated code (which runs in the browser) would also help. ",
"Thanks for the reply. I did some more debugging because some components worked and some didn't. It turns out tha... | 2020-04-09 10:56:59 | 2020-04-09 14:31:20 | 2020-04-09 14:31:20 | NONE | null | null | null | Functions that are bound in component constructor uses initial value of _this.props_ despite later changes to props.
Note: I'm a back-end systems (python, c, etc.) developer who has been asked to help out with UI debugging because we are currently short-staffed. So I admit I don't know all the nuances of React.
R... | {'url': 'https://api.github.com/repos/facebook/react/issues/18552/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18552/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18551 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18551/labels{/name} | https://api.github.com/repos/facebook/react/issues/18551/comments | https://api.github.com/repos/facebook/react/issues/18551/events | https://github.com/facebook/react/pull/18551 | 597,159,802 | MDExOlB1bGxSZXF1ZXN0NDAxMzIyMTgw | 18,551 | Make enableLegacyFBSupport flag dynamic for www | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18551/builds/18993) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 09:47:07 | 2020-04-09 14:31:37 | 2020-04-09 14:31:37 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18551', 'html_url': 'https://github.com/facebook/react/pull/18551', 'diff_url': 'https://github.com/facebook/react/pull/18551.diff', 'patch_url': 'https://github.com/facebook/react/pull/18551.patch', 'merged_at': datetime.datetime(2020, 4, 9, 14, 31, 37)} | I want to work on gradually removing the need for this internally on www, so let's make it dynamic so we can put it behind a GK and control its use better. | {'url': 'https://api.github.com/repos/facebook/react/issues/18551/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18551/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18550 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18550/labels{/name} | https://api.github.com/repos/facebook/react/issues/18550/comments | https://api.github.com/repos/facebook/react/issues/18550/events | https://github.com/facebook/react/pull/18550 | 596,991,217 | MDExOlB1bGxSZXF1ZXN0NDAxMTg0MTYy | 18,550 | Script for syncing changes between forks | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18550/builds/19083) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 03:18:17 | 2020-04-09 18:37:14 | 2020-04-09 18:37:14 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18550', 'html_url': 'https://github.com/facebook/react/pull/18550', 'diff_url': 'https://github.com/facebook/react/pull/18550.diff', 'patch_url': 'https://github.com/facebook/react/pull/18550.patch', 'merged_at': datetime.datetime(2020, 4, 9, 18, 37, 14)} | Adds command `yarn merge-fork`.
```sh
yarn merge-fork --base-dir=packages/react-reconciler/src ReactFiberWorkLoop
```
This will take all the changes in `ReactFiberWorkLoop.new.js` and apply them to `ReactFiberWorkLoop.old.js`.
You can merge multiple modules at a time:
```sh
yarn merge-fork \
--base-di... | {'url': 'https://api.github.com/repos/facebook/react/issues/18550/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18550/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18549 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18549/labels{/name} | https://api.github.com/repos/facebook/react/issues/18549/comments | https://api.github.com/repos/facebook/react/issues/18549/events | https://github.com/facebook/react/pull/18549 | 596,985,713 | MDExOlB1bGxSZXF1ZXN0NDAxMTc5ODUy | 18,549 | Port more tests to the Scheduler.unstable_yieldValue pattern and drop internal.js | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18549/builds/18943) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 02:59:30 | 2020-04-09 03:54:55 | 2020-04-09 03:54:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18549', 'html_url': 'https://github.com/facebook/react/pull/18549', 'diff_url': 'https://github.com/facebook/react/pull/18549.diff', 'patch_url': 'https://github.com/facebook/react/pull/18549.patch', 'merged_at': datetime.datetime(2020, 4, 9, 3, 54, 55)} | This rewrites all the tests that overrides debugRenderPhaseSideEffectsForStrictMode to be agnostic of if they double render. The easiest way to do that is to use Scheduler.unstable_yieldValue pattern. So I converted a bunch of `ops.push(...)` to that.
We also use the pattern where we store `this` in render as a side... | {'url': 'https://api.github.com/repos/facebook/react/issues/18549/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18549/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18548 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18548/labels{/name} | https://api.github.com/repos/facebook/react/issues/18548/comments | https://api.github.com/repos/facebook/react/issues/18548/events | https://github.com/facebook/react/pull/18548 | 596,983,743 | MDExOlB1bGxSZXF1ZXN0NDAxMTc4MzMz | 18,548 | Copy React Reconciler modules to new fork | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18548/builds/18936) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-09 02:52:32 | 2020-04-09 07:33:24 | 2020-04-09 07:33:24 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18548', 'html_url': 'https://github.com/facebook/react/pull/18548', 'diff_url': 'https://github.com/facebook/react/pull/18548.diff', 'patch_url': 'https://github.com/facebook/react/pull/18548.patch', 'merged_at': datetime.datetime(2020, 4, 9, 7, 33, 24)} | Builds on top of #18285. See that PR for context and motivation.
I suggest reviewing commit-by-commit.
- The first commit renames the existing (`.old`) modules. I'll land this to master in its own commit to preserve the history/blame.
- The second commit refactors some of the internal types so they can be shar... | {'url': 'https://api.github.com/repos/facebook/react/issues/18548/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18548/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18547 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18547/labels{/name} | https://api.github.com/repos/facebook/react/issues/18547/comments | https://api.github.com/repos/facebook/react/issues/18547/events | https://github.com/facebook/react/pull/18547 | 596,902,061 | MDExOlB1bGxSZXF1ZXN0NDAxMTEyNDg4 | 18,547 | Disable console.logs in the second render pass of DEV mode double render | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"I was just debugging some internals yesterday and wished we had this.",
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18547/builds/18915) or the icon n... | 2020-04-08 22:29:51 | 2022-03-30 17:38:58 | 2020-04-08 23:43:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18547', 'html_url': 'https://github.com/facebook/react/pull/18547', 'diff_url': 'https://github.com/facebook/react/pull/18547.diff', 'patch_url': 'https://github.com/facebook/react/pull/18547.patch', 'merged_at': datetime.datetime(2020, 4, 8, 23, 43, 51)} | This disables console.log by temporarily patching the global console object during the second render pass when we double render in strict mode in DEV.
I could go either way on this. It is confusing that it double logs warnings, React, legacy react packages or third-party ones. However, if you do have a problem due t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18547/reactions', 'total_count': 57, '+1': 2, '-1': 52, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/18547/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18546 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18546/labels{/name} | https://api.github.com/repos/facebook/react/issues/18546/comments | https://api.github.com/repos/facebook/react/issues/18546/events | https://github.com/facebook/react/issues/18546 | 596,892,119 | MDU6SXNzdWU1OTY4OTIxMTk= | 18,546 | Bug: New Components and Profiler tabs missing in Chrome DevTools | {'login': 'stevehanstudio', 'id': 15229911, 'node_id': 'MDQ6VXNlcjE1MjI5OTEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/15229911?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/stevehanstudio', 'html_url': 'https://github.com/stevehanstudio', 'followers_url': 'https://api.github.com/users/st... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"These tabs only appear if you're viewing a web page that uses React, which the Google extensions store does not :smile: Visit e.g. www.reactjs.org to see the tabs.",
"the Component and Profilers tab still does not show up even after viewing www.reactjs.org "
] | 2020-04-08 22:05:31 | 2020-06-22 07:34:55 | 2020-04-09 22:23:38 | NONE | null | null | null | The new Components and Profiler tabs are missing in Chrome DevTools.
React version: N/A
## Steps To Reproduce
1. Open Chrome
2. Control-Shift-I to open Chrome Developer Tools
## The current behavior
No Components and Profiler tabs. See screenshot
![Screenshot (190)](https://user-images.githubusercontent... | {'url': 'https://api.github.com/repos/facebook/react/issues/18546/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18546/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18545 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18545/labels{/name} | https://api.github.com/repos/facebook/react/issues/18545/comments | https://api.github.com/repos/facebook/react/issues/18545/events | https://github.com/facebook/react/pull/18545 | 596,868,872 | MDExOlB1bGxSZXF1ZXN0NDAxMDg1MjIw | 18,545 | useRef: Warn about reading or writing mutable values during render | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18545/builds/64469) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 21:16:52 | 2020-10-20 15:12:11 | 2020-10-19 20:05:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18545', 'html_url': 'https://github.com/facebook/react/pull/18545', 'diff_url': 'https://github.com/facebook/react/pull/18545.diff', 'patch_url': 'https://github.com/facebook/react/pull/18545.patch', 'merged_at': datetime.datetime(2020, 10, 19, 20, 5)} | This warning is being tested within Facebook behind a feature flag to assess its impact, (e.g. how many warnings does it trigger, how many patterns (like `usePrevious`) does it flush out, do they all have safe alternate patterns, etc.)
I wouldn't recommend upgrading existing code until we have published recommended ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18545/reactions', 'total_count': 22, '+1': 13, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 9} | https://api.github.com/repos/facebook/react/issues/18545/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18544 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18544/labels{/name} | https://api.github.com/repos/facebook/react/issues/18544/comments | https://api.github.com/repos/facebook/react/issues/18544/events | https://github.com/facebook/react/issues/18544 | 596,838,233 | MDU6SXNzdWU1OTY4MzgyMzM= | 18,544 | Bug: Devtools in Firefox does not allow adding props or editing props/state/hooks | {'login': 'hbarcelos', 'id': 16565602, 'node_id': 'MDQ6VXNlcjE2NTY1NjAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16565602?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hbarcelos', 'html_url': 'https://github.com/hbarcelos', 'followers_url': 'https://api.github.com/users/hbarcelos/followe... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Cannot reproduce on windows: \r\n ` ` `\r\n\"react\": \"^16.13.1\"\r\n \"react-dom\": \"^16.13.1\"\r\n ` ` `\r\n\r\n ` ` `\r\nFirefox 74.0 and Firefox 75 latest also tested\r\n ` ` `\r\n\r\n ` ` `\r\nDev-tools 4.6.0\r\n ` ` `\r\n\r\nCould you verify that this issue is specific to Firefox in manjaro/linux?",
"Dis... | 2020-04-08 20:24:37 | 2020-04-17 15:43:14 | 2020-04-17 12:54:04 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Version:
- React @ `16.13.1`
- Firefox @ `75.0` (version for Manjaro Linux)
-... | {'url': 'https://api.github.com/repos/facebook/react/issues/18544/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18544/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18543 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18543/labels{/name} | https://api.github.com/repos/facebook/react/issues/18543/comments | https://api.github.com/repos/facebook/react/issues/18543/events | https://github.com/facebook/react/pull/18543 | 596,586,666 | MDExOlB1bGxSZXF1ZXN0NDAwODU1NTE0 | 18,543 | Help debugging: https://github.com/facebook/react/pull/18542 | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18543/builds/18841) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 13:38:50 | 2020-04-09 17:31:17 | 2020-04-09 17:31:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18543', 'html_url': 'https://github.com/facebook/react/pull/18543', 'diff_url': 'https://github.com/facebook/react/pull/18543.diff', 'patch_url': 'https://github.com/facebook/react/pull/18543.patch', 'merged_at': None} | We don't want to land this, this is purely to help test https://github.com/facebook/react/pull/18542. | {'url': 'https://api.github.com/repos/facebook/react/issues/18543/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18543/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18542 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18542/labels{/name} | https://api.github.com/repos/facebook/react/issues/18542/comments | https://api.github.com/repos/facebook/react/issues/18542/events | https://github.com/facebook/react/pull/18542 | 596,548,396 | MDExOlB1bGxSZXF1ZXN0NDAwODI1MDA1 | 18,542 | Reset nextEffect points with the new passive effect feature flag too | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18542/builds/18836) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 12:42:12 | 2020-04-09 17:16:02 | 2020-04-09 17:16:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18542', 'html_url': 'https://github.com/facebook/react/pull/18542', 'diff_url': 'https://github.com/facebook/react/pull/18542.diff', 'patch_url': 'https://github.com/facebook/react/pull/18542.patch', 'merged_at': None} | Plugs a memory leak. Same as https://github.com/facebook/react/pull/16115, but for the new feature flag. | {'url': 'https://api.github.com/repos/facebook/react/issues/18542/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18542/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18541 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18541/labels{/name} | https://api.github.com/repos/facebook/react/issues/18541/comments | https://api.github.com/repos/facebook/react/issues/18541/events | https://github.com/facebook/react/issues/18541 | 596,522,343 | MDU6SXNzdWU1OTY1MjIzNDM= | 18,541 | [react-hooks/exhaustive-deps] function outside the hook | {'login': 'eshturman', 'id': 34343461, 'node_id': 'MDQ6VXNlcjM0MzQzNDYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/34343461?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eshturman', 'html_url': 'https://github.com/eshturman', 'followers_url': 'https://api.github.com/users/eshturman/followe... | [] | closed | false | null | [] | null | [
"You are free to ignore linter if that's what you want",
"A change in `id` would mean a change in the return value of `getData`, so you *would* want scopes to be re-created any time this happened.",
"@bvaughn but I want that useEffect will be called only 1 time. I'm not interested in further id change",
"> bu... | 2020-04-08 11:56:44 | 2020-04-09 09:39:36 | 2020-04-09 07:39:33 | NONE | null | null | null | Hi! I have some problems with [react-hooks/exhaustive-deps] rule of eslint. Can you help me, please?
<img width="293" alt="Снимок экрана 2020-04-08 в 18 55 09" src="https://user-images.githubusercontent.com/34343461/78781465-7fa38900-79ca-11ea-94fe-2a80ef7c1d2a.png">
I have some effect, which to call function. Li... | {'url': 'https://api.github.com/repos/facebook/react/issues/18541/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18541/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18540 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18540/labels{/name} | https://api.github.com/repos/facebook/react/issues/18540/comments | https://api.github.com/repos/facebook/react/issues/18540/events | https://github.com/facebook/react/pull/18540 | 596,470,399 | MDExOlB1bGxSZXF1ZXN0NDAwNzYwNTI2 | 18,540 | Revert "Revert "Refactor commitPlacement to recursively insert nodes (#17996)"" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18540/builds/18818) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 10:21:56 | 2022-11-29 22:21:45 | 2020-04-08 10:22:03 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18540', 'html_url': 'https://github.com/facebook/react/pull/18540', 'diff_url': 'https://github.com/facebook/react/pull/18540.diff', 'patch_url': 'https://github.com/facebook/react/pull/18540.patch', 'merged_at': datetime.datetime(2020, 4, 8, 10, 22, 3)} | Reverts facebook/react#18517
False alarm. The alert seems unrelated and the timing is a coincidence. | {'url': 'https://api.github.com/repos/facebook/react/issues/18540/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18540/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18539 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18539/labels{/name} | https://api.github.com/repos/facebook/react/issues/18539/comments | https://api.github.com/repos/facebook/react/issues/18539/events | https://github.com/facebook/react/pull/18539 | 596,332,345 | MDExOlB1bGxSZXF1ZXN0NDAwNjQ4MDMw | 18,539 | Fix bailout broken in lazy components due to default props resolving | {'login': 'jddxf', 'id': 11155177, 'node_id': 'MDQ6VXNlcjExMTU1MTc3', 'avatar_url': 'https://avatars.githubusercontent.com/u/11155177?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jddxf', 'html_url': 'https://github.com/jddxf', 'followers_url': 'https://api.github.com/users/jddxf/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18539/builds/18776) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 06:08:44 | 2020-04-08 13:22:38 | 2020-04-08 09:58:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18539', 'html_url': 'https://github.com/facebook/react/pull/18539', 'diff_url': 'https://github.com/facebook/react/pull/18539.diff', 'patch_url': 'https://github.com/facebook/react/pull/18539.patch', 'merged_at': datetime.datetime(2020, 4, 8, 9, 58, 58)} | Fix #17151
We should never compare unresolved props with resolved props. Since comparing resolved props by reference doesn't make sense, we use unresolved props in that case. Otherwise, resolved props are used. | {'url': 'https://api.github.com/repos/facebook/react/issues/18539/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18539/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18538 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18538/labels{/name} | https://api.github.com/repos/facebook/react/issues/18538/comments | https://api.github.com/repos/facebook/react/issues/18538/events | https://github.com/facebook/react/pull/18538 | 596,330,039 | MDExOlB1bGxSZXF1ZXN0NDAwNjQ2MTY5 | 18,538 | Add regression test for #18497 | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18538/builds/35909) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 06:02:30 | 2020-06-30 12:38:42 | 2020-06-30 11:09:06 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18538', 'html_url': 'https://github.com/facebook/react/pull/18538', 'diff_url': 'https://github.com/facebook/react/pull/18538.diff', 'patch_url': 'https://github.com/facebook/react/pull/18538.patch', 'merged_at': datetime.datetime(2020, 6, 30, 11, 9, 6)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/18538/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18538/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18537 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18537/labels{/name} | https://api.github.com/repos/facebook/react/issues/18537/comments | https://api.github.com/repos/facebook/react/issues/18537/events | https://github.com/facebook/react/pull/18537 | 596,255,566 | MDExOlB1bGxSZXF1ZXN0NDAwNTg2NDMw | 18,537 | Bugfix: Render phase update causes remaining updates in same component to be dropped | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18537/builds/18760) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 01:58:35 | 2020-04-08 02:17:03 | 2020-04-08 02:17:02 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18537', 'html_url': 'https://github.com/facebook/react/pull/18537', 'diff_url': 'https://github.com/facebook/react/pull/18537.diff', 'patch_url': 'https://github.com/facebook/react/pull/18537.patch', 'merged_at': datetime.datetime(2020, 4, 8, 2, 17, 2)} | Fixes #18534
Fixes #18486
Render phase updates should not affect the `fiber.expirationTime` field. We don't have to set anything on the fiber because we're going to process the render phase update immediately.
We also shouldn't reset the `expirationTime` field in between render passes because it represents the ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18537/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18537/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18536 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18536/labels{/name} | https://api.github.com/repos/facebook/react/issues/18536/comments | https://api.github.com/repos/facebook/react/issues/18536/events | https://github.com/facebook/react/pull/18536 | 596,230,856 | MDExOlB1bGxSZXF1ZXN0NDAwNTY3MzAx | 18,536 | Improve detachFiber | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18536/builds/18755) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-08 00:33:21 | 2020-04-08 00:45:30 | 2020-04-08 00:45:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18536', 'html_url': 'https://github.com/facebook/react/pull/18536', 'diff_url': 'https://github.com/facebook/react/pull/18536.diff', 'patch_url': 'https://github.com/facebook/react/pull/18536.patch', 'merged_at': datetime.datetime(2020, 4, 8, 0, 45, 24)} | Based off feedback in previous PRs that attempted to address the memory leak issue, we found a better way of handling `detachFiber`. This extracts those changes into this PR. | {'url': 'https://api.github.com/repos/facebook/react/issues/18536/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18536/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.