diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/tchart/model/separator_item.rb b/lib/tchart/model/separator_item.rb index abc1234..def5678 100644 --- a/lib/tchart/model/separator_item.rb +++ b/lib/tchart/model/separator_item.rb @@ -5,22 +5,22 @@ module TChart class SeparatorItem - attr_reader :y_coordinate - attr_reader :length + a...
Convert SeparatorItem to use Coordinates.
diff --git a/lib/toy/middleware/identity_map.rb b/lib/toy/middleware/identity_map.rb index abc1234..def5678 100644 --- a/lib/toy/middleware/identity_map.rb +++ b/lib/toy/middleware/identity_map.rb @@ -1,24 +1,8 @@+require 'rack/body_proxy' + module Toy module Middleware class IdentityMap - class Body - ...
Use rack body proxy for the identity map middleware.
diff --git a/lib/vagrant/ansible_auto/errors.rb b/lib/vagrant/ansible_auto/errors.rb index abc1234..def5678 100644 --- a/lib/vagrant/ansible_auto/errors.rb +++ b/lib/vagrant/ansible_auto/errors.rb @@ -24,10 +24,12 @@ error_key(:invalid_host_type) end + # Class representing {Command} errors ...
Add class docstrings for command error classes
diff --git a/Casks/not-tetris.rb b/Casks/not-tetris.rb index abc1234..def5678 100644 --- a/Casks/not-tetris.rb +++ b/Casks/not-tetris.rb @@ -0,0 +1,10 @@+class NotTetris < Cask + version '2' + sha256 'ddb4df7f9169e1a03cb5f81e67b972cca4470e4925973af452f6e467830aaea8' + + url 'http://stabyourself.net/dl.php?file=notte...
Add Not Tetris 2 cask
diff --git a/Casks/opera-beta.rb b/Casks/opera-beta.rb index abc1234..def5678 100644 --- a/Casks/opera-beta.rb +++ b/Casks/opera-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-beta' do - version '29.0.1795.41' - sha256 'e7f013637993189ee96409fd647bbc00fa94bde544e2604c36cde230ad717063' + version '30.0.1835.18' + sha256 ...
Upgrade Opera Beta.app to v30.0.1835.18
diff --git a/config/environments/test.rb b/config/environments/test.rb index abc1234..def5678 100644 --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -34,4 +34,7 @@ # Print deprecation notices to the stderr config.active_support.deprecation = :stderr + + # Use a different cache store in pr...
Switch to dalli store instead of file store for Rails' cache
diff --git a/app/forms/artefact_form.rb b/app/forms/artefact_form.rb index abc1234..def5678 100644 --- a/app/forms/artefact_form.rb +++ b/app/forms/artefact_form.rb @@ -23,6 +23,7 @@ self end + alias_method :public_send, :__send__ alias_method :send, :__send__ private
Fix displaying of draft tags in forms. An change in one of the gems has meant that the Form facade methods are no longer being called when displaying the form, so draft tags are not being displayed. Adding a public_send alias fixes it.
diff --git a/db/migrate/20160108153344_create_responses.rb b/db/migrate/20160108153344_create_responses.rb index abc1234..def5678 100644 --- a/db/migrate/20160108153344_create_responses.rb +++ b/db/migrate/20160108153344_create_responses.rb @@ -2,6 +2,7 @@ def change create_table :responses do |t| t.integ...
Edit response migration to include question_id
diff --git a/cookbooks/pacman/default.rb b/cookbooks/pacman/default.rb index abc1234..def5678 100644 --- a/cookbooks/pacman/default.rb +++ b/cookbooks/pacman/default.rb @@ -3,6 +3,7 @@ package 'aws-cli' package 'colordiff' package 'ctags' +package 'dhclient' package 'docker' package 'exa' package 'fish'
Use dhclient instead of dhcpcd
diff --git a/db/migrate/20150411000035_fix_identities.rb b/db/migrate/20150411000035_fix_identities.rb index abc1234..def5678 100644 --- a/db/migrate/20150411000035_fix_identities.rb +++ b/db/migrate/20150411000035_fix_identities.rb @@ -11,13 +11,13 @@ # the first LDAP server specified in gitlab.yml / gitlab.rb. ...
Check for table instead of class
diff --git a/script/daemons/sync_all.rb b/script/daemons/sync_all.rb index abc1234..def5678 100644 --- a/script/daemons/sync_all.rb +++ b/script/daemons/sync_all.rb @@ -3,7 +3,6 @@ require 'rubygems' loop do - puts "Fetching at #{ Time.now.to_s(:time) }..." EvernoteNote.sync_all Resource.sync_all_binaries ...
Remove log message for every run
diff --git a/BowerLabs.podspec b/BowerLabs.podspec index abc1234..def5678 100644 --- a/BowerLabs.podspec +++ b/BowerLabs.podspec @@ -1,16 +1,16 @@ Pod::Spec.new do |s| s.name = 'BowerLabs' - s.version = '1.1.2' + s.version = '1.2.0' s.platform = :ios s.license = 'MIT' s.summary = 'Common framework...
Update podspec version and iOS target
diff --git a/BowerLabs.podspec b/BowerLabs.podspec index abc1234..def5678 100644 --- a/BowerLabs.podspec +++ b/BowerLabs.podspec @@ -10,7 +10,7 @@ :tag => s.version.to_s } s.requires_arc = true - s.ios.deployment_target = '8.3' + s.ios.deployment_target = '8.1' s.default_...
Set the deployment target to iOS 8.1.
diff --git a/lib/active_scaffold/bridges/paperclip/lib/paperclip_bridge_helpers.rb b/lib/active_scaffold/bridges/paperclip/lib/paperclip_bridge_helpers.rb index abc1234..def5678 100644 --- a/lib/active_scaffold/bridges/paperclip/lib/paperclip_bridge_helpers.rb +++ b/lib/active_scaffold/bridges/paperclip/lib/paperclip_b...
Check against instance methods rather than class methods before generating delete helpers.
diff --git a/app/controllers/application.rb b/app/controllers/application.rb index abc1234..def5678 100644 --- a/app/controllers/application.rb +++ b/app/controllers/application.rb @@ -1,6 +1,8 @@ # Filters added to this controller will be run for all controllers in the application. # Likewise, all the methods added w...
Add HTTP basic auth with fake backend that authenticates user 'todd'
diff --git a/app/jobs/include_publisher_in_payout_report_job.rb b/app/jobs/include_publisher_in_payout_report_job.rb index abc1234..def5678 100644 --- a/app/jobs/include_publisher_in_payout_report_job.rb +++ b/app/jobs/include_publisher_in_payout_report_job.rb @@ -34,7 +34,7 @@ when UPHOLD potential_payment_...
Fix namespace to use Payout
diff --git a/camper_van.gemspec b/camper_van.gemspec index abc1234..def5678 100644 --- a/camper_van.gemspec +++ b/camper_van.gemspec @@ -20,8 +20,8 @@ s.required_ruby_version = "~> 1.9.2" - s.add_dependency "eventmachine", "~> 0.12.10" - s.add_dependency "firering", "~> 1.2.0" + s.add_dependency "eventmachine"...
Update to latest eventmachine/firering releases Closes #29, closes #35
diff --git a/app/helpers/sessions_helper.rb b/app/helpers/sessions_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sessions_helper.rb +++ b/app/helpers/sessions_helper.rb @@ -0,0 +1,21 @@+module CherryTomato + class SessionsHelper < Sinatra::Base + configure do + enable :sessions + end + + modu...
Add SessionsHelper & UserSession helper methods
diff --git a/app/helpers/template_helper.rb b/app/helpers/template_helper.rb index abc1234..def5678 100644 --- a/app/helpers/template_helper.rb +++ b/app/helpers/template_helper.rb @@ -1,16 +1,33 @@ module TemplateHelper + def template(model: nil, collection: nil, target:, &block) + model_name = if collection.prese...
Allow template to be nested
diff --git a/app/models/concerns/wp_post.rb b/app/models/concerns/wp_post.rb index abc1234..def5678 100644 --- a/app/models/concerns/wp_post.rb +++ b/app/models/concerns/wp_post.rb @@ -12,7 +12,8 @@ end self.wp_id = json['ID'] - self.published_at = json['date'] + # Use gmt date to ignore timezon...
Use gmt date to ignore wordpress timezone settings
diff --git a/app/uploaders/file_uploader.rb b/app/uploaders/file_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/file_uploader.rb +++ b/app/uploaders/file_uploader.rb @@ -1,6 +1,7 @@ # encoding: utf-8 class FileUploader < CarrierWave::Uploader::Base include UploaderHelper + MARKDOWN_PATTERN = %r{\!?\...
Add markdown pattern for uploads to file uploader
diff --git a/app/controllers/api/v2/services_controller.rb b/app/controllers/api/v2/services_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v2/services_controller.rb +++ b/app/controllers/api/v2/services_controller.rb @@ -8,7 +8,7 @@ type = params[:type].to_s.titleize @services =...
Return paratransit services in alphabetic order in the transportation options page.
diff --git a/app/controllers/authentications_controller.rb b/app/controllers/authentications_controller.rb index abc1234..def5678 100644 --- a/app/controllers/authentications_controller.rb +++ b/app/controllers/authentications_controller.rb @@ -1,3 +1,4 @@+require './lib/actions/oauth_signup_action' class Authenticati...
Fix Growstuff::OauthSignupAction not found error when connecting flickr account
diff --git a/app/views/api/v1/stickies/index.json.jbuilder b/app/views/api/v1/stickies/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/v1/stickies/index.json.jbuilder +++ b/app/views/api/v1/stickies/index.json.jbuilder @@ -14,6 +14,7 @@ json.is_deleted sticky.deleted? json.url sticky.p...
Add visual_url to stickies api reposponse
diff --git a/app/workers/trending_groups_refresh_worker.rb b/app/workers/trending_groups_refresh_worker.rb index abc1234..def5678 100644 --- a/app/workers/trending_groups_refresh_worker.rb +++ b/app/workers/trending_groups_refresh_worker.rb @@ -2,7 +2,10 @@ include Sidekiq::Worker include Sidetiq::Schedulable - ...
Switch from minutely(5) to hourly.minute_of_hour Workaround for tobiassvn/sidetiq#31
diff --git a/custodian.gemspec b/custodian.gemspec index abc1234..def5678 100644 --- a/custodian.gemspec +++ b/custodian.gemspec @@ -20,6 +20,7 @@ # specify any dependencies here; for example: s.add_development_dependency "rspec" + s.add_development_dependency "rack-test" s.add_runtime_dependency "thin" s...
Add development dependency on rack-test
diff --git a/restaurant_roulette/app/controllers/text_messages_controller.rb b/restaurant_roulette/app/controllers/text_messages_controller.rb index abc1234..def5678 100644 --- a/restaurant_roulette/app/controllers/text_messages_controller.rb +++ b/restaurant_roulette/app/controllers/text_messages_controller.rb @@ -8,5...
Send text messages with Twilio to hardcoded phone numbers
diff --git a/Purchases.podspec b/Purchases.podspec index abc1234..def5678 100644 --- a/Purchases.podspec +++ b/Purchases.podspec @@ -9,7 +9,7 @@ s.homepage = "http://revenue.cat" s.license = { :type => 'MIT' } - s.author = { "Revenue Cat Inc." => "jacob@revenuecat.com" } + s.author ...
Add public headers to podspec.
diff --git a/cookbooks/cumulus/test/integration/default/serverspec/bonds_spec.rb b/cookbooks/cumulus/test/integration/default/serverspec/bonds_spec.rb index abc1234..def5678 100644 --- a/cookbooks/cumulus/test/integration/default/serverspec/bonds_spec.rb +++ b/cookbooks/cumulus/test/integration/default/serverspec/bonds...
Add tests for cumulus_bond provider
diff --git a/lib/active_mocker/rspec_helper.rb b/lib/active_mocker/rspec_helper.rb index abc1234..def5678 100644 --- a/lib/active_mocker/rspec_helper.rb +++ b/lib/active_mocker/rspec_helper.rb @@ -1,6 +1,7 @@ require 'active_mocker/loaded_mocks' require 'active_mocker/rspec' +ActiveMocker::LoadedMocks.disable_global...
Set defaults for loaded mocks
diff --git a/lib/bipbip/plugin/socket_redis.rb b/lib/bipbip/plugin/socket_redis.rb index abc1234..def5678 100644 --- a/lib/bipbip/plugin/socket_redis.rb +++ b/lib/bipbip/plugin/socket_redis.rb @@ -24,7 +24,7 @@ uri = URI.parse(url) request = Net::HTTP::Get.new(uri) - request['authorization'] = "toke...
Set "authorization" header only if status_token is provided
diff --git a/app/workers/asset_manager_attachment_access_limited_worker.rb b/app/workers/asset_manager_attachment_access_limited_worker.rb index abc1234..def5678 100644 --- a/app/workers/asset_manager_attachment_access_limited_worker.rb +++ b/app/workers/asset_manager_attachment_access_limited_worker.rb @@ -2,21 +2,21 ...
Make access limited asset worker easier to follow
diff --git a/unshorten.gemspec b/unshorten.gemspec index abc1234..def5678 100644 --- a/unshorten.gemspec +++ b/unshorten.gemspec @@ -6,6 +6,7 @@ s.description = 'Get original URLs from shortened ones' s.authors = ["Wu Jun"] s.email = 'quark@lihdd.net' + s.homepage = 'https://github.com/quark-zju/unshor...
Set github as gemspec homepage
diff --git a/lib/sinatra_more/warden_plugin.rb b/lib/sinatra_more/warden_plugin.rb index abc1234..def5678 100644 --- a/lib/sinatra_more/warden_plugin.rb +++ b/lib/sinatra_more/warden_plugin.rb @@ -1,11 +1,32 @@ require File.dirname(__FILE__) + '/support_lite' +require 'warden' unless defined?(Warden) load File.dirname...
Refactor warden plugin strategy to be defined as class instead of block
diff --git a/lib/foodcritic/rake_task.rb b/lib/foodcritic/rake_task.rb index abc1234..def5678 100644 --- a/lib/foodcritic/rake_task.rb +++ b/lib/foodcritic/rake_task.rb @@ -19,7 +19,11 @@ task(name) do puts "Starting Foodcritic linting..." result = FoodCritic::Linter.new.check(default_opti...
Fix a regression when running Foodcritic as a Rake task The Output classes' initializers now [require](https://github.com/acrmp/foodcritic/commit/3c057cb857939b6761effb386fe0b30e9270add2) an output stream argument. Signed-off-by: Jonathan Hartman <5c2dd944dde9e08881bef0894fe7b22a5c9c4b06@p4nt5.com>
diff --git a/devtools.gemspec b/devtools.gemspec index abc1234..def5678 100644 --- a/devtools.gemspec +++ b/devtools.gemspec @@ -14,5 +14,6 @@ gem.test_files = `git ls-files -- spec`.split("\n") gem.extra_rdoc_files = %w[TODO] - gem.add_runtime_dependency('adamantium', '~> 0.0.3') + gem.add_dependency('r...
Add rake to runtime deps closes #3
diff --git a/lib/mongo_rates/rateable.rb b/lib/mongo_rates/rateable.rb index abc1234..def5678 100644 --- a/lib/mongo_rates/rateable.rb +++ b/lib/mongo_rates/rateable.rb @@ -19,7 +19,6 @@ end def average_rating - rateable_ratings = ratings return 0 if ratings.empty? map = %Q(fun...
Fix a few error in average_rating and persons_rating
diff --git a/lib/swagger/docs/methods.rb b/lib/swagger/docs/methods.rb index abc1234..def5678 100644 --- a/lib/swagger/docs/methods.rb +++ b/lib/swagger/docs/methods.rb @@ -16,7 +16,7 @@ end def swagger_models - @swagger_model_dsls + @swagger_model_dsls ||= {} end ...
Fix bug with not having any models declared
diff --git a/lib/brightbox-cli/commands/cloudips-update.rb b/lib/brightbox-cli/commands/cloudips-update.rb index abc1234..def5678 100644 --- a/lib/brightbox-cli/commands/cloudips-update.rb +++ b/lib/brightbox-cli/commands/cloudips-update.rb @@ -5,7 +5,7 @@ c.desc "Set reverse DNS for this cloud ip" c.flag [:r,...
Make reverse DNS wording uninform
diff --git a/lib/netsuite/records/sales_order_item_list.rb b/lib/netsuite/records/sales_order_item_list.rb index abc1234..def5678 100644 --- a/lib/netsuite/records/sales_order_item_list.rb +++ b/lib/netsuite/records/sales_order_item_list.rb @@ -9,6 +9,15 @@ items << SalesOrderItem.new(attributes[:item]) ...
Allow adding items in SalesOrder following same pattern as Invoice
diff --git a/lib/wakame/monitor/agent.rb b/lib/wakame/monitor/agent.rb index abc1234..def5678 100644 --- a/lib/wakame/monitor/agent.rb +++ b/lib/wakame/monitor/agent.rb @@ -23,12 +23,7 @@ def check - if Wakame.environment == :EC2 - require 'wakame/vm_manipulator' - attrs = Wakame::VmManipulator::EC2:...
Simplify the code on feching the vm attributes.
diff --git a/app/helpers/versions_helper.rb b/app/helpers/versions_helper.rb index abc1234..def5678 100644 --- a/app/helpers/versions_helper.rb +++ b/app/helpers/versions_helper.rb @@ -6,7 +6,10 @@ end def friendly_changeset_title(version) - if version.changeset['http_status'] + + if version.changeset['id'...
Include created message in version history
diff --git a/app/models/server/rotations.rb b/app/models/server/rotations.rb index abc1234..def5678 100644 --- a/app/models/server/rotations.rb +++ b/app/models/server/rotations.rb @@ -4,13 +4,9 @@ include RequestCacheable included do - # { - # rotation_name => { - ...
Store rotation data in the database
diff --git a/db/migrate/20090330195815_add_single_access_token_to_users.rb b/db/migrate/20090330195815_add_single_access_token_to_users.rb index abc1234..def5678 100644 --- a/db/migrate/20090330195815_add_single_access_token_to_users.rb +++ b/db/migrate/20090330195815_add_single_access_token_to_users.rb @@ -1,6 +1,12 @...
Create a single_access_token for all existing users
diff --git a/lib/heroku/deploy/tasks/unsafe_migration.rb b/lib/heroku/deploy/tasks/unsafe_migration.rb index abc1234..def5678 100644 --- a/lib/heroku/deploy/tasks/unsafe_migration.rb +++ b/lib/heroku/deploy/tasks/unsafe_migration.rb @@ -3,6 +3,14 @@ include Heroku::Deploy::UI def before_deploy + task "T...
Revert "I don't care about preboot anymore" This reverts commit 314010546a7f07ea6c81710400b0e4f59289aa26.
diff --git a/lib/kmz_compressor/controller_extensions.rb b/lib/kmz_compressor/controller_extensions.rb index abc1234..def5678 100644 --- a/lib/kmz_compressor/controller_extensions.rb +++ b/lib/kmz_compressor/controller_extensions.rb @@ -5,7 +5,7 @@ module ClassMethods def defer_until_kmz_cached(*actions) -...
Switch from around_filter to around_action
diff --git a/lib/travis/build/appliances/update_glibc.rb b/lib/travis/build/appliances/update_glibc.rb index abc1234..def5678 100644 --- a/lib/travis/build/appliances/update_glibc.rb +++ b/lib/travis/build/appliances/update_glibc.rb @@ -6,6 +6,7 @@ class UpdateGlibc < Base def apply sh.fold "f...
Update APT source for builds on GCE
diff --git a/app/mailers/import_mailer.rb b/app/mailers/import_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/import_mailer.rb +++ b/app/mailers/import_mailer.rb @@ -3,11 +3,34 @@ def notify_fail(err_msg) @err_msg = err_msg - mail(to: Settings.mail_tech_support, subject: 'API import failed') + ...
Add app version and environment info to import mailers
diff --git a/lib/specinfra/backend/powershell/command.rb b/lib/specinfra/backend/powershell/command.rb index abc1234..def5678 100644 --- a/lib/specinfra/backend/powershell/command.rb +++ b/lib/specinfra/backend/powershell/command.rb @@ -22,7 +22,7 @@ when Regexp target.source else - ...
Allow forward slashes within PS literal
diff --git a/app/models/renalware/letters.rb b/app/models/renalware/letters.rb index abc1234..def5678 100644 --- a/app/models/renalware/letters.rb +++ b/app/models/renalware/letters.rb @@ -1,7 +1,13 @@ module Renalware module Letters + module_function + def self.table_name_prefix "letter_" end + ...
Use module_function to cast the module patient
diff --git a/app/uploaders/photo_uploader.rb b/app/uploaders/photo_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/photo_uploader.rb +++ b/app/uploaders/photo_uploader.rb @@ -35,7 +35,7 @@ # Add a white list of extensions which are allowed to be uploaded. # For images you might use something like t...
Revert "Remove extension whitelist, as further heroku debugging effort." This reverts commit e40d89c3602292230ec43c2b2af29f8d1a70c9cc.
diff --git a/app/workers/publisher_update.rb b/app/workers/publisher_update.rb index abc1234..def5678 100644 --- a/app/workers/publisher_update.rb +++ b/app/workers/publisher_update.rb @@ -28,6 +28,7 @@ e.title = feature.title e.description = feature.description e.geom = ...
Store geojson properties in event records
diff --git a/app/concerns/couriers/fusionable.rb b/app/concerns/couriers/fusionable.rb index abc1234..def5678 100644 --- a/app/concerns/couriers/fusionable.rb +++ b/app/concerns/couriers/fusionable.rb @@ -37,6 +37,7 @@ notify "Adding to Fusion Tables", photo.key table.select("ROWID", "WHERE nam...
Allow up to 5 queries per second
diff --git a/app/controllers/meals_controller.rb b/app/controllers/meals_controller.rb index abc1234..def5678 100644 --- a/app/controllers/meals_controller.rb +++ b/app/controllers/meals_controller.rb @@ -21,4 +21,8 @@ select_or_create_permit(:meal, :location_attributes, LocationsController.param_names) ...
Initialize meal time to current time
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/posts_controller.rb +++ b/app/controllers/posts_controller.rb @@ -5,7 +5,7 @@ @post = current_site.posts.published.find_by!(public_id: params[:id]) @pages = - if par...
Disable all param on controller ref: #472
diff --git a/app/models/spree/order_decorator.rb b/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/order_decorator.rb +++ b/app/models/spree/order_decorator.rb @@ -11,25 +11,23 @@ return unless promotion_code - joins(:adjustments) - .merge(Spree::Adjustment.eligibl...
Fix query used to filter orders by code used
diff --git a/jredshift.gemspec b/jredshift.gemspec index abc1234..def5678 100644 --- a/jredshift.gemspec +++ b/jredshift.gemspec @@ -23,5 +23,5 @@ spec.add_dependency 'jdbc-postgres', '~> 9.3' spec.add_development_dependency 'bundler', '~> 1.6' - spec.add_development_dependency 'rake', '~> 0' + spec.add_develo...
Set explicit version for rake
diff --git a/test/active_waiter/configuration_test.rb b/test/active_waiter/configuration_test.rb index abc1234..def5678 100644 --- a/test/active_waiter/configuration_test.rb +++ b/test/active_waiter/configuration_test.rb @@ -1,7 +1,7 @@ require 'test_helper' class ConfigurationTest < Minitest::Test - def teardown +...
Fix sporadic build break when affected by leftover config from other tests
diff --git a/doberman.gemspec b/doberman.gemspec index abc1234..def5678 100644 --- a/doberman.gemspec +++ b/doberman.gemspec @@ -21,5 +21,4 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" spec.add_development_dependency "rspec" - spec.add_development_dependency "de...
Remove debugger gem from dependencies.
diff --git a/app/interactors/fetch_exams.rb b/app/interactors/fetch_exams.rb index abc1234..def5678 100644 --- a/app/interactors/fetch_exams.rb +++ b/app/interactors/fetch_exams.rb @@ -8,16 +8,13 @@ client = kosapi_client(faculty_semester) @exams = client.exams.where("course.faculty==#{faculty_semester.faculty...
Refactor extracting of rooms in FetchExams to be less procedural
diff --git a/test/lib/catissue/domain/address_test.rb b/test/lib/catissue/domain/address_test.rb index abc1234..def5678 100644 --- a/test/lib/catissue/domain/address_test.rb +++ b/test/lib/catissue/domain/address_test.rb @@ -1,4 +1,4 @@-require File.join(File.dirname(__FILE__), '..', 'test_case') +require File.dirname(...
Address does not reference the owner.
diff --git a/test/unit/webhookr/ostruct_utils_test.rb b/test/unit/webhookr/ostruct_utils_test.rb index abc1234..def5678 100644 --- a/test/unit/webhookr/ostruct_utils_test.rb +++ b/test/unit/webhookr/ostruct_utils_test.rb @@ -10,22 +10,22 @@ end test "should be an OpenStruct" do - assert(@converted.is_a?(OpenS...
Use specific assertions instead of `assert`.
diff --git a/examples/import_users.rb b/examples/import_users.rb index abc1234..def5678 100644 --- a/examples/import_users.rb +++ b/examples/import_users.rb @@ -0,0 +1,51 @@+require 'bundler/setup' +require 'honey_format' + +csv_string = <<~CSV +Email,Name,Age,Country +john@example.com,John Doe,42,Sweden +jane@example....
Add import users example to examples/
diff --git a/examples/rails/deploy.rb b/examples/rails/deploy.rb index abc1234..def5678 100644 --- a/examples/rails/deploy.rb +++ b/examples/rails/deploy.rb @@ -1,5 +1,2 @@-set :application, "application" - -role :app, "yourhost.com" -role :web, "yourhost.com" -role :db, "yourhost.com", :primary => true +set :user, 'r...
Reduce example capistrano configuration to minimum sprinkle requires
diff --git a/app/helpers/images_helper.rb b/app/helpers/images_helper.rb index abc1234..def5678 100644 --- a/app/helpers/images_helper.rb +++ b/app/helpers/images_helper.rb @@ -5,7 +5,7 @@ if Paperclip::Attachment.default_options[:storage] == :filesystem URI(request.url) + image.attachment.url(version) ...
Fix social share image URL with external storage Co-Authored-By: Pierre Mesure <ff019a5748a52b5641624af88a54a2f0e46a9fb5@mesu.re>
diff --git a/rails_event_store-rspec/lib/rails_event_store/rspec/have_applied.rb b/rails_event_store-rspec/lib/rails_event_store/rspec/have_applied.rb index abc1234..def5678 100644 --- a/rails_event_store-rspec/lib/rails_event_store/rspec/have_applied.rb +++ b/rails_event_store-rspec/lib/rails_event_store/rspec/have_ap...
Kill passing ivars as local vars Issue: #215
diff --git a/app/mappers/drupal_mapper.rb b/app/mappers/drupal_mapper.rb index abc1234..def5678 100644 --- a/app/mappers/drupal_mapper.rb +++ b/app/mappers/drupal_mapper.rb @@ -3,7 +3,7 @@ def self.parse(json) json_map = fields.inject({}) do |agg, (k, v)| agg[k] = v.inject(json) do |iterator, node| - ...
Raise an exception if required fields are missing in the drupal node
diff --git a/app/models/address_record.rb b/app/models/address_record.rb index abc1234..def5678 100644 --- a/app/models/address_record.rb +++ b/app/models/address_record.rb @@ -1,3 +1,5 @@+require "resolv" + class AddressRecord < Record - validates :content, presence: true + validates :content, presence: true, forma...
Make sure addresses are valid IPs
diff --git a/app/models/storytime/blog.rb b/app/models/storytime/blog.rb index abc1234..def5678 100644 --- a/app/models/storytime/blog.rb +++ b/app/models/storytime/blog.rb @@ -1,6 +1,6 @@ module Storytime class Blog < Page - has_many :posts + has_many :posts, dependent: :destroy def self.seed(site, use...
Add dependent: :destroy to Blog
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -1,3 +1,4 @@+Encoding.default_external = 'UTF-8' require 'simplecov' SimpleCov.start do add_filter '/test|deps/'
Set default_external to UTF-8 for GitLab CI
diff --git a/blinkbox-common_mapping.gemspec b/blinkbox-common_mapping.gemspec index abc1234..def5678 100644 --- a/blinkbox-common_mapping.gemspec +++ b/blinkbox-common_mapping.gemspec @@ -1,5 +1,5 @@ # -*- encoding: utf-8 -*- -$LOAD_PATH.unshift(File.join(__dir__, "lib")) +$LOAD_PATH.unshift(File.join(File.dirname(__F...
Fix Travis using 1.9.3 to build gems
diff --git a/smart_polling.gemspec b/smart_polling.gemspec index abc1234..def5678 100644 --- a/smart_polling.gemspec +++ b/smart_polling.gemspec @@ -8,8 +8,8 @@ spec.version = SmartPolling::VERSION spec.authors = ["Mateus Del Bianco"] spec.email = ["mateus@delbianco.net.br"] - spec.summary ...
Update gemspec summary and description
diff --git a/lib/sippy_cup/runner.rb b/lib/sippy_cup/runner.rb index abc1234..def5678 100644 --- a/lib/sippy_cup/runner.rb +++ b/lib/sippy_cup/runner.rb @@ -0,0 +1,37 @@+require 'yaml' + +module SippyCup + class Runner + def initialize(path) + @options = YAML.load_file File.expand_path(path) + end + + de...
Add a Runner class to SippyCup
diff --git a/test/unit/spec/spec_helper.rb b/test/unit/spec/spec_helper.rb index abc1234..def5678 100644 --- a/test/unit/spec/spec_helper.rb +++ b/test/unit/spec/spec_helper.rb @@ -2,7 +2,7 @@ require 'chefspec/server' require 'chefspec/berkshelf' -at_exit { ChefSpec::Coverage.start! } +ChefSpec::Coverage.start! ...
Remove 'at_exit' from coverage call, since in lib. 'start!' already wraps 'Coverage::report!' with at_exit in ChefSpec.
diff --git a/app/views/timer_view_cell.rb b/app/views/timer_view_cell.rb index abc1234..def5678 100644 --- a/app/views/timer_view_cell.rb +++ b/app/views/timer_view_cell.rb @@ -6,11 +6,11 @@ @primaryLabel = UILabel.alloc.init @primaryLabel.textAlignment = UITextAlignmentLeft - @primaryLabel.font = UIFont....
Align text & change font sizes to be more readable
diff --git a/customerio.gemspec b/customerio.gemspec index abc1234..def5678 100644 --- a/customerio.gemspec +++ b/customerio.gemspec @@ -22,4 +22,5 @@ gem.add_development_dependency('rspec') gem.add_development_dependency('webmock') gem.add_development_dependency('addressable', '~> 2.3.6') + gem.add_developmen...
Add JSON dev dependency for webmock webmock should require this itself, but doesn't. Sigh.
diff --git a/db/migrate/20190626175626_add_group_creation_level_to_namespaces.rb b/db/migrate/20190626175626_add_group_creation_level_to_namespaces.rb index abc1234..def5678 100644 --- a/db/migrate/20190626175626_add_group_creation_level_to_namespaces.rb +++ b/db/migrate/20190626175626_add_group_creation_level_to_names...
Add a subgroup_creation_level column to the namespaces table
diff --git a/gh.gemspec b/gh.gemspec index abc1234..def5678 100644 --- a/gh.gemspec +++ b/gh.gemspec @@ -20,11 +20,7 @@ s.add_runtime_dependency 'faraday', '~> 0.8' s.add_runtime_dependency 'backports' s.add_runtime_dependency 'multi_json', '~> 1.0' - if RUBY_VERSION < '2.0' - s.add_runtime_dependency ...
Fix gems to older version I wanted to find a solution to this that would allow newer Rubies to upgrade beyond these older gem versions, but I've already sunk too much time here. See https://github.com/rubygems/rubygems/issues/722
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -8,7 +8,7 @@ depends 'xml' -supports 'fedora', '>= 21' +supports 'fedora', '>= 21.0' supports 'centos', '>= 7.0' supports 'rhel', '>= 7.0' supports 'ubuntu'...
Switch supports fedora "21" to "21.0"
diff --git a/lib/hetchy.rb b/lib/hetchy.rb index abc1234..def5678 100644 --- a/lib/hetchy.rb +++ b/lib/hetchy.rb @@ -6,17 +6,17 @@ :pool, # current pool data :size # size of allocated pool - # Available opts: + # Create a reservoir. # @option opts [Integer] :size Size of r...
Tweak comments; adjust default reservoir size.
diff --git a/config/initializers/bugsnag.rb b/config/initializers/bugsnag.rb index abc1234..def5678 100644 --- a/config/initializers/bugsnag.rb +++ b/config/initializers/bugsnag.rb @@ -1,3 +1,3 @@ Bugsnag.configure do |config| - config.api_key = ENV["RESPONSIVE_BUG_SNAG_KEY"] unless (ENV['MAS_ENVIRONMENT'] == 'qa') + ...
Remove env check as we can do this in puppet now
diff --git a/spec/shoes/sound_spec.rb b/spec/shoes/sound_spec.rb index abc1234..def5678 100644 --- a/spec/shoes/sound_spec.rb +++ b/spec/shoes/sound_spec.rb @@ -1,4 +1,6 @@ require 'shoes/spec_helper' +# To be removed when Sound is converted from module to class +require 'white_shoes' describe Shoes::Sound do let...
Fix spec failure for seed 23311
diff --git a/lib/markdo/cli.rb b/lib/markdo/cli.rb index abc1234..def5678 100644 --- a/lib/markdo/cli.rb +++ b/lib/markdo/cli.rb @@ -10,38 +10,12 @@ def run(command_name = 'help', *args) command = case command_name - when 'add' - AddCommand - when 'edit' - ...
Refactor: Remove case/when covered by open/closed code
diff --git a/lib/plugins/wa.rb b/lib/plugins/wa.rb index abc1234..def5678 100644 --- a/lib/plugins/wa.rb +++ b/lib/plugins/wa.rb @@ -11,8 +11,16 @@ input_array = text.split(/[[:space:]]/) input = input_array.join(' ').downcase response = Nokogiri::XML(open("http://api.wolframalpha.com/v2/query?input=#{URI...
Cut bot response if length greater than 75 characters
diff --git a/lib/vim-flavor.rb b/lib/vim-flavor.rb index abc1234..def5678 100644 --- a/lib/vim-flavor.rb +++ b/lib/vim-flavor.rb @@ -13,6 +13,7 @@ :ShellUtility, :StringExtension, :VERSION, + :Version, :VersionConstraint, ].each do |name| autoload name, "vim-flavor/#{name.to_...
Add a missing autoload declaration
diff --git a/test/unit/spec/default_spec.rb b/test/unit/spec/default_spec.rb index abc1234..def5678 100644 --- a/test/unit/spec/default_spec.rb +++ b/test/unit/spec/default_spec.rb @@ -3,12 +3,17 @@ require_relative 'spec_helper' describe 'system::default' do - before { stub_resources } - describe 'ubuntu' do - ...
Add some basic ChefSpec tests.
diff --git a/etd_model.gemspec b/etd_model.gemspec index abc1234..def5678 100644 --- a/etd_model.gemspec +++ b/etd_model.gemspec @@ -11,7 +11,7 @@ s.summary = 'ETD content model used by the SULAIR Digital Library' s.description = 'Contains classes that define the Fedora content model for electronic theses and ...
Update dor-services dependency to ~> 6.0
diff --git a/spec/CheckfrontAPI_spec.rb b/spec/CheckfrontAPI_spec.rb index abc1234..def5678 100644 --- a/spec/CheckfrontAPI_spec.rb +++ b/spec/CheckfrontAPI_spec.rb @@ -8,9 +8,9 @@ it "can reach the server" do expect(CheckfrontAPI::Client::test_connection).not_to be nil end - - xit "can authenticate" do - ...
Test accessing /account with basic auth
diff --git a/spec/factories/sections.rb b/spec/factories/sections.rb index abc1234..def5678 100644 --- a/spec/factories/sections.rb +++ b/spec/factories/sections.rb @@ -2,6 +2,6 @@ FactoryGirl.define do factory :section do - name { Faker::Lorem.word } + sequence(:name) { |n| "Section #{n}" } end end
Fix failing test by enforcing unique section names
diff --git a/spec/how_is/integration.rb b/spec/how_is/integration.rb index abc1234..def5678 100644 --- a/spec/how_is/integration.rb +++ b/spec/how_is/integration.rb @@ -0,0 +1,29 @@+require 'spec_helper' + +HOW_IS_EXE = File.expand_path('../../exe/how_is', __dir__) + +describe 'Integration Tests' do + context '--help ...
Add tests for --help, -h, --version, and -v.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -27,5 +27,5 @@ source node[:influxdb][:source] checksum node[:influxdb][:versions][arch][ver] config node[:influxdb][:config] - action [:create, :start] + action [:create] e...
Maintain BC, do not start the service
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -22,6 +22,7 @@ package "sqlite3" package "sqlite3-doc" + package "libsqlite3-dev" when "rhel", "fedora"
Include SQLite 3 development files on debian platforms
diff --git a/spec/transport/udp_spec.rb b/spec/transport/udp_spec.rb index abc1234..def5678 100644 --- a/spec/transport/udp_spec.rb +++ b/spec/transport/udp_spec.rb @@ -1,39 +1,42 @@ require 'spec_helper' -describe LIFX::Transport::UDP, integration: true do - subject(:udp) { LIFX::Transport::UDP.new(host, port) } +m...
Use namespaces in UDP spec
diff --git a/fugit.gemspec b/fugit.gemspec index abc1234..def5678 100644 --- a/fugit.gemspec +++ b/fugit.gemspec @@ -18,6 +18,10 @@ Time tools for flor and the floraison project. Cron parsing and occurrence computing. Timestamps and more. }.strip + s.metadata = { + 'changelog_uri' => s.homepage + '/blob/master...
Add Rubygems link to changelog
diff --git a/scss_lint.gemspec b/scss_lint.gemspec index abc1234..def5678 100644 --- a/scss_lint.gemspec +++ b/scss_lint.gemspec @@ -25,7 +25,7 @@ s.required_ruby_version = '>= 1.9.3' - s.add_dependency 'rake', '>= 0.9', '< 11' + s.add_dependency 'rake', '>= 0.9', '< 12' s.add_dependency 'sass', '~> 3.4.15' ...
Update dependencies to allow Rake 11 Resolves #756
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -2,7 +2,7 @@ set :output, File.join(File.expand_path(File.dirname(__FILE__)), "log", "cron_log.log") -job_type :rake, "cd :path && RAILS_ENV=:environment /home/rails/.rvm/b...
Handle rake tasks in cron jobs with bundle exec.
diff --git a/app/validators/not_a_national_archives_url_validator.rb b/app/validators/not_a_national_archives_url_validator.rb index abc1234..def5678 100644 --- a/app/validators/not_a_national_archives_url_validator.rb +++ b/app/validators/not_a_national_archives_url_validator.rb @@ -1,9 +1,14 @@ class NotANationalArch...
Make the not-TNA validator check a parsed URL's host, not just a string - This makes it consistent with how NationalArchivesURLValidator checks for a TNA host.
diff --git a/examples/tree.rb b/examples/tree.rb index abc1234..def5678 100644 --- a/examples/tree.rb +++ b/examples/tree.rb @@ -1,6 +1,6 @@ require './lib/psd' -psd = PSD.new('/Users/ryanlefevre/LayerVault/Turtleworks/Conversation.psd') +psd = PSD.new('examples/images/example.psd') psd.parse! pp psd.tree.to_hash
Change back to example PSD
diff --git a/calculators/cha2ds2/cha2ds2.rb b/calculators/cha2ds2/cha2ds2.rb index abc1234..def5678 100644 --- a/calculators/cha2ds2/cha2ds2.rb +++ b/calculators/cha2ds2/cha2ds2.rb @@ -1,34 +1,22 @@-def get_bool(name) - value = send "field_#{name}" - - begin - value.to_s.to_bool - rescue ArgumentError - ...
Use type helper methods instead of custom method
diff --git a/lib/i18n/workflow.rb b/lib/i18n/workflow.rb index abc1234..def5678 100644 --- a/lib/i18n/workflow.rb +++ b/lib/i18n/workflow.rb @@ -4,7 +4,6 @@ require "i18n/workflow/always_cascade" require "i18n/workflow/exception_handler" require "i18n/workflow/explicit_scope_key" -require "i18n/workflow/translation_h...
Remove require to removed file