diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/moped/read_preference.rb b/lib/moped/read_preference.rb index abc1234..def5678 100644 --- a/lib/moped/read_preference.rb +++ b/lib/moped/read_preference.rb @@ -5,9 +5,17 @@ require "moped/read_preference/secondary_preferred" module Moped + + # Provides behaviour around getting various read preferen...
Add read preference getter rdoc
diff --git a/lib/rubygems/defaults/rbx.rb b/lib/rubygems/defaults/rbx.rb index abc1234..def5678 100644 --- a/lib/rubygems/defaults/rbx.rb +++ b/lib/rubygems/defaults/rbx.rb @@ -13,12 +13,8 @@ File.join Rubinius::GEMS_PATH, Gem::ConfigMap[:ruby_version] end - def self.default_preinstalled_dir - File.join Ru...
Remove obsolete pre-installed gems dir from gem env.
diff --git a/library/open3/popen3_spec.rb b/library/open3/popen3_spec.rb index abc1234..def5678 100644 --- a/library/open3/popen3_spec.rb +++ b/library/open3/popen3_spec.rb @@ -2,27 +2,41 @@ require 'open3' describe "Open3.popen3" do - after :each do - [@in, @out, @err].each do |io| - io.close if io && !io....
Fix leak in the Open3.popen3 spec and add an example
diff --git a/app/controllers/backend/backend_controller.rb b/app/controllers/backend/backend_controller.rb index abc1234..def5678 100644 --- a/app/controllers/backend/backend_controller.rb +++ b/app/controllers/backend/backend_controller.rb @@ -11,7 +11,7 @@ redirect_to cas_auth_path(:redirect => request.fullpath...
Fix FK backend access using CA
diff --git a/app/controllers/timeline_events_controller.rb b/app/controllers/timeline_events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/timeline_events_controller.rb +++ b/app/controllers/timeline_events_controller.rb @@ -7,7 +7,7 @@ before_filter :set_atom show.failure.wants.html { rescue...
Use correct set of timeline events for the atom feed
diff --git a/app/workers/publishing_api_schedule_worker.rb b/app/workers/publishing_api_schedule_worker.rb index abc1234..def5678 100644 --- a/app/workers/publishing_api_schedule_worker.rb +++ b/app/workers/publishing_api_schedule_worker.rb @@ -11,12 +11,12 @@ # Coming soon needs to be sent first, as currently cont...
Rename method for consistency and clarity
diff --git a/db/migrate/20140915123504_move_to_has_and_belongs_to_many_for_ontologies_tasks_end.rb b/db/migrate/20140915123504_move_to_has_and_belongs_to_many_for_ontologies_tasks_end.rb index abc1234..def5678 100644 --- a/db/migrate/20140915123504_move_to_has_and_belongs_to_many_for_ontologies_tasks_end.rb +++ b/db/mi...
Drop column only if it exists.
diff --git a/samples/scripts/selection/checkFreeMemory.rb b/samples/scripts/selection/checkFreeMemory.rb index abc1234..def5678 100644 --- a/samples/scripts/selection/checkFreeMemory.rb +++ b/samples/scripts/selection/checkFreeMemory.rb @@ -1,6 +1,8 @@ require 'java' SelectionUtils = Java::org.ow2.proactive.scriptin...
Define missing variable in selection script sample
diff --git a/app/controllers/documents_controller.rb b/app/controllers/documents_controller.rb index abc1234..def5678 100644 --- a/app/controllers/documents_controller.rb +++ b/app/controllers/documents_controller.rb @@ -1,8 +1,16 @@ class DocumentsController < ApplicationController + include AdminHelper def inde...
Document display user based on group
diff --git a/vim-flavor.gemspec b/vim-flavor.gemspec index abc1234..def5678 100644 --- a/vim-flavor.gemspec +++ b/vim-flavor.gemspec @@ -18,8 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ['lib'] - spec.add_dependency('parslet', '~> 1.7') - spec.add_dependency('...
Update parslet ~> 1.8 and thor ~> 0.20
diff --git a/lib/arsi/arel_tree_manager.rb b/lib/arsi/arel_tree_manager.rb index abc1234..def5678 100644 --- a/lib/arsi/arel_tree_manager.rb +++ b/lib/arsi/arel_tree_manager.rb @@ -2,6 +2,10 @@ module Arsi module ArelTreeManager + AREL_WHERE_SQL_ARITY_1 = ::Arel::VERSION[0].to_i < 7 + # Arel 9 has no engine ...
Switch to checking Arel versions
diff --git a/lib/color-schema-validator.rb b/lib/color-schema-validator.rb index abc1234..def5678 100644 --- a/lib/color-schema-validator.rb +++ b/lib/color-schema-validator.rb @@ -1,6 +1,6 @@ class ColorSchemaValidator < ActiveModel::EachValidator def validate_each(record, attribute, value) - unless value =~ /^#...
Fix regexp to more strong According to the following error on Rails 4: ArgumentError: The provided regular expression is using multiline anchors (^ or $), which may present a security risk. Did you mean to use \A and \z, or forgot to add the :multiline => true option? from /some/where/vendor/bundle/ruby/2.2.0...
diff --git a/lib/moped/protocol/command.rb b/lib/moped/protocol/command.rb index abc1234..def5678 100644 --- a/lib/moped/protocol/command.rb +++ b/lib/moped/protocol/command.rb @@ -13,7 +13,7 @@ # @param [Hash] command the command to run # @param [Hash] additional query options def initialize(databa...
Use string for Protocol::Command collection name
diff --git a/lib/multidb/log_subscriber.rb b/lib/multidb/log_subscriber.rb index abc1234..def5678 100644 --- a/lib/multidb/log_subscriber.rb +++ b/lib/multidb/log_subscriber.rb @@ -1,19 +1,21 @@ module Multidb - module LogSubscriber - extend ActiveSupport::Concern + module LogSubscriberExtension + def sql(event...
Use prepend to change LogSubscriber; add db_name to the payload
diff --git a/lib/specinfra/backend/base.rb b/lib/specinfra/backend/base.rb index abc1234..def5678 100644 --- a/lib/specinfra/backend/base.rb +++ b/lib/specinfra/backend/base.rb @@ -43,11 +43,11 @@ @example = e end - def set_stdout_handler(&block) + def stdout_handler=(block) @stdout_...
Change the methods to set handlers
diff --git a/approvals.gemspec b/approvals.gemspec index abc1234..def5678 100644 --- a/approvals.gemspec +++ b/approvals.gemspec @@ -17,7 +17,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = ["lib"] - s.add_dependency 'rspec', '~> 2.7' + s.add_development...
Make rspec a development dependency
diff --git a/lib/stack_master/validator.rb b/lib/stack_master/validator.rb index abc1234..def5678 100644 --- a/lib/stack_master/validator.rb +++ b/lib/stack_master/validator.rb @@ -11,7 +11,7 @@ def perform StackMaster.stdout.print "#{@stack_definition.stack_name}: " - template_body = TemplateCompiler...
Compress the template when we attempt to validate it
diff --git a/piece.rb b/piece.rb index abc1234..def5678 100644 --- a/piece.rb +++ b/piece.rb @@ -13,4 +13,52 @@ def to_s "#{@type} - #{col}#{row}" end + + def is_pawn? + if @type.eql? Chess::B_PAWN or @type.eql? Chess::W_PAWN then + return true + else + return fa...
Add identity methods to Piece
diff --git a/lib/synapse_payments/users.rb b/lib/synapse_payments/users.rb index abc1234..def5678 100644 --- a/lib/synapse_payments/users.rb +++ b/lib/synapse_payments/users.rb @@ -20,7 +20,6 @@ phone_numbers: phone.is_a?(Array) ? phone : [phone], legal_names: name.is_a?(Array) ? name : [name], ...
Remove note as it doesn't seem to be supported
diff --git a/lib/tasks/feedshub_tasks.rake b/lib/tasks/feedshub_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/feedshub_tasks.rake +++ b/lib/tasks/feedshub_tasks.rake @@ -6,7 +6,8 @@ GitFeedsHandler.update_github_feeds end - task :whenverize do + desc 'add cron task to update feeds' + task whenver...
Add task support for rails 3; CR: DF
diff --git a/lib/twilio-ruby/rest/utils.rb b/lib/twilio-ruby/rest/utils.rb index abc1234..def5678 100644 --- a/lib/twilio-ruby/rest/utils.rb +++ b/lib/twilio-ruby/rest/utils.rb @@ -4,9 +4,9 @@ def twilify(something) if something.is_a? Hash - Hash[*something.to_a.map {|a| [twilify(a[0]).to_sym,...
Change `map` to `map!` to save extra array creation on new array
diff --git a/lib/yarrow/html/asset_tags.rb b/lib/yarrow/html/asset_tags.rb index abc1234..def5678 100644 --- a/lib/yarrow/html/asset_tags.rb +++ b/lib/yarrow/html/asset_tags.rb @@ -2,6 +2,10 @@ module HTML module AssetTags + def config + Yarrow::Configuration.instance + end + # TO...
Embed configuration in asset tag library
diff --git a/lib/fabrication/fabricator.rb b/lib/fabrication/fabricator.rb index abc1234..def5678 100644 --- a/lib/fabrication/fabricator.rb +++ b/lib/fabrication/fabricator.rb @@ -2,7 +2,7 @@ def initialize(class_name, &block) klass = class_for(class_name) - if klass.ancestors.include?(ActiveRecord::Base) ...
Allow it to work without activerecord loaded
diff --git a/lib/io_actors/writer_actor.rb b/lib/io_actors/writer_actor.rb index abc1234..def5678 100644 --- a/lib/io_actors/writer_actor.rb +++ b/lib/io_actors/writer_actor.rb @@ -39,7 +39,7 @@ num_bytes = begin @io.write_nonblock(bytes) - rescue IO::WaitWritable + ...
Handle Errno::EAGAIN errors when writing
diff --git a/ltsv_logger_formatter.gemspec b/ltsv_logger_formatter.gemspec index abc1234..def5678 100644 --- a/ltsv_logger_formatter.gemspec +++ b/ltsv_logger_formatter.gemspec @@ -13,9 +13,7 @@ spec.homepage = 'https://github.com/ryu39/ltsv_logger_formatter' spec.license = 'MIT' - spec.files ...
Remove unnecessary files from gem
diff --git a/lib/lita/handlers/hal_9000.rb b/lib/lita/handlers/hal_9000.rb index abc1234..def5678 100644 --- a/lib/lita/handlers/hal_9000.rb +++ b/lib/lita/handlers/hal_9000.rb @@ -8,13 +8,16 @@ def handle_unhandled(payload:) message = payload[:message] if message.command? - private_mes...
Refactor getting target into separate method
diff --git a/lib/message_broker/message.rb b/lib/message_broker/message.rb index abc1234..def5678 100644 --- a/lib/message_broker/message.rb +++ b/lib/message_broker/message.rb @@ -1,6 +1,8 @@ # encoding: utf-8 # frozen_string_literal: true module MessageBroker + # Message parses raw line recieved from event sourse ...
Add description for Message class
diff --git a/app/models/skill.rb b/app/models/skill.rb index abc1234..def5678 100644 --- a/app/models/skill.rb +++ b/app/models/skill.rb @@ -23,6 +23,7 @@ def increment_current_streak self.current_streak += 1 + self.longest_streak = self.current_streak if self.current_streak > self.longest_streak self....
Add conditional to increment longest streak if current streak becomes larger than longest streak
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -5,5 +5,5 @@ ENV['PATH'] = "#{root}/features/support/bin#{File::PATH_SEPARATOR}#{ENV['PATH']}" Before do - @aruba_timeout_seconds = 60 * 2 + @aruba_timeout_sec...
Increase aruba timeout because installing gems might take a lot of time
diff --git a/lib/rolistic/class_methods.rb b/lib/rolistic/class_methods.rb index abc1234..def5678 100644 --- a/lib/rolistic/class_methods.rb +++ b/lib/rolistic/class_methods.rb @@ -25,7 +25,7 @@ def traits_map return @traits_map if defined?(@traits_map) - @traits_map = {} + @traits_map = {everyth...
Create default trait mapped to Rolistic::Everything
diff --git a/lib/tasks/publishing_api.rake b/lib/tasks/publishing_api.rake index abc1234..def5678 100644 --- a/lib/tasks/publishing_api.rake +++ b/lib/tasks/publishing_api.rake @@ -1,11 +1,28 @@ namespace :publishing_api do - desc "export all whitehall content to draft environment of publishing api" - task :populate_...
Define rake tasks for repopulating case studies into either the draft or live environment.
diff --git a/lib/torkify/log/test_error.rb b/lib/torkify/log/test_error.rb index abc1234..def5678 100644 --- a/lib/torkify/log/test_error.rb +++ b/lib/torkify/log/test_error.rb @@ -1,5 +1,14 @@ module Torkify::Log - class TestError < Struct.new(:filename, :lnum, :text, :type) + class TestError + attr_accessor :fil...
Fix superclass mismatch by using struct
diff --git a/lib/virtus/typecast/object.rb b/lib/virtus/typecast/object.rb index abc1234..def5678 100644 --- a/lib/virtus/typecast/object.rb +++ b/lib/virtus/typecast/object.rb @@ -17,6 +17,51 @@ # @api public def self.to_string(value) value.to_s + end + + # Passthrough given value + ...
Add missing methods to Virtus::Typecast::Object
diff --git a/spec/lib/tasks/gem/bump_task_spec.rb b/spec/lib/tasks/gem/bump_task_spec.rb index abc1234..def5678 100644 --- a/spec/lib/tasks/gem/bump_task_spec.rb +++ b/spec/lib/tasks/gem/bump_task_spec.rb @@ -4,12 +4,12 @@ describe Gem::BumpTask do describe '#task' do subject { Gem::BumpTask.new :major } + b...
Use new rspec expectations sintax
diff --git a/spec/observers/user_observer_spec.rb b/spec/observers/user_observer_spec.rb index abc1234..def5678 100644 --- a/spec/observers/user_observer_spec.rb +++ b/spec/observers/user_observer_spec.rb @@ -2,4 +2,24 @@ describe UserObserver do + describe '#before_validation' do + let(:user) { build(:user, pa...
Add specs for user observer
diff --git a/spec/unit/tables/table_utils_spec.rb b/spec/unit/tables/table_utils_spec.rb index abc1234..def5678 100644 --- a/spec/unit/tables/table_utils_spec.rb +++ b/spec/unit/tables/table_utils_spec.rb @@ -18,6 +18,10 @@ @subject.index_path_to_section_index(given).should == expected end + it "return the or...
Add failing test for index_path_to_section_index util method
diff --git a/app/controllers/root_controller.rb b/app/controllers/root_controller.rb index abc1234..def5678 100644 --- a/app/controllers/root_controller.rb +++ b/app/controllers/root_controller.rb @@ -11,6 +11,6 @@ private def should_list_app?(permission, application) - permission.permissions.include?("s...
Make support app hack slightly less fragile
diff --git a/app/services/post_stream_window.rb b/app/services/post_stream_window.rb index abc1234..def5678 100644 --- a/app/services/post_stream_window.rb +++ b/app/services/post_stream_window.rb @@ -1,6 +1,6 @@ class PostStreamWindow def self.for(topic:, from: (topic.highest_post_number+1), order: :desc, limit: Si...
Use lt/gt or equal to in post stream window
diff --git a/polymorphic_preloader.gemspec b/polymorphic_preloader.gemspec index abc1234..def5678 100644 --- a/polymorphic_preloader.gemspec +++ b/polymorphic_preloader.gemspec @@ -9,6 +9,7 @@ spec.authors = ['Anthony Dmitriyev'] spec.email = ['antstorm@gmail.com'] spec.summary = 'Eager load...
Add gemspec description to fix gem build warnings
diff --git a/app/state.rb b/app/state.rb index abc1234..def5678 100644 --- a/app/state.rb +++ b/app/state.rb @@ -6,16 +6,16 @@ @move_order = [] end - def [](r, c) - @board[r, c] + def [](row, col) + @board[row, col] end - def []=(r, c, value) - i = [r, c] + def []=(row, col, value) + i = [row, col] @mo...
Increase variable verboseness for clarity (ih/2π).(∂ψ/∂t) = (–h2/8π2m)∇2ψ + Vψ
diff --git a/stack.rb b/stack.rb index abc1234..def5678 100644 --- a/stack.rb +++ b/stack.rb @@ -1,26 +1,61 @@ require_relative 'linked_list' # Linked List Version +# class Stack +# attr_reader :stack + +# def initialize +# @stack = LinkedList.new +# end + +# def top +# node = stack.get(0) +# rev...
Add ArrayList version of Stacks
diff --git a/artwork.gemspec b/artwork.gemspec index abc1234..def5678 100644 --- a/artwork.gemspec +++ b/artwork.gemspec @@ -4,20 +4,22 @@ require 'artwork/version' Gem::Specification.new do |spec| - spec.name = "artwork" + spec.name = 'artwork' spec.version = Artwork::VERSION - spec.au...
Update the gemspec with dependencies and descriptions
diff --git a/lib/thinking_sphinx/deltas/sidekiq_delta/tasks.rb b/lib/thinking_sphinx/deltas/sidekiq_delta/tasks.rb index abc1234..def5678 100644 --- a/lib/thinking_sphinx/deltas/sidekiq_delta/tasks.rb +++ b/lib/thinking_sphinx/deltas/sidekiq_delta/tasks.rb @@ -33,6 +33,6 @@ Rake::Task['thinking_sphinx:unlock_deltas']...
Remove reindex reference for the moment.
diff --git a/Casks/tigervnc-viewer.rb b/Casks/tigervnc-viewer.rb index abc1234..def5678 100644 --- a/Casks/tigervnc-viewer.rb +++ b/Casks/tigervnc-viewer.rb @@ -1,6 +1,6 @@ cask :v1 => 'tigervnc-viewer' do - version '1.4.3' - sha256 'e6c2f17092456f04ccce6d923af3103f7e69123c4a0f80e37b56ee3861149cca' + version '1.5.0'...
Update TigerVNC Viewer to v.1.5.0
diff --git a/lib/memory_analyzer/heap_analyzer/parser.rb b/lib/memory_analyzer/heap_analyzer/parser.rb index abc1234..def5678 100644 --- a/lib/memory_analyzer/heap_analyzer/parser.rb +++ b/lib/memory_analyzer/heap_analyzer/parser.rb @@ -27,11 +27,9 @@ end def self.parse_file(file) - File.open(file...
Use File.foreach instead of interating ourselves.
diff --git a/MKLog.podspec b/MKLog.podspec index abc1234..def5678 100644 --- a/MKLog.podspec +++ b/MKLog.podspec @@ -9,7 +9,7 @@ Pod::Spec.new do |s| s.name = "MKLog" - s.version = "0.1.1" + s.version = "0.1.2" s.summary = "Lightweight log with multiple log levels" s....
Increase version number in preparation for release
diff --git a/test/models/area_test.rb b/test/models/area_test.rb index abc1234..def5678 100644 --- a/test/models/area_test.rb +++ b/test/models/area_test.rb @@ -3,4 +3,12 @@ class AreaTest < ActiveSupport::TestCase should have_many(:areas_messages) should have_many(:messages).through(:areas_messages) + + def set...
Add test for getting area geometry
diff --git a/routes/player_counts.rb b/routes/player_counts.rb index abc1234..def5678 100644 --- a/routes/player_counts.rb +++ b/routes/player_counts.rb @@ -22,10 +22,10 @@ app.get '/player_counts-latest.json' do content_type :json - if !redis.exists("latest-counts") + if ...
Fix typo in latest player counts
diff --git a/spec/controllers/comments_controller_spec.rb b/spec/controllers/comments_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/comments_controller_spec.rb +++ b/spec/controllers/comments_controller_spec.rb @@ -1,34 +1,22 @@ require "rails_helper" describe CommentsController do - descr...
Define initial rspec tests for comments controller.
diff --git a/spec/libraries/sign_in_with_callback_spec.rb b/spec/libraries/sign_in_with_callback_spec.rb index abc1234..def5678 100644 --- a/spec/libraries/sign_in_with_callback_spec.rb +++ b/spec/libraries/sign_in_with_callback_spec.rb @@ -20,7 +20,8 @@ let(:instance) { Instance.default } with_tenant(:instance) d...
Replace deprecated Devise sign_in bypass option in tests
diff --git a/BHCDatabase/test/models/medical_condition_funder_test.rb b/BHCDatabase/test/models/medical_condition_funder_test.rb index abc1234..def5678 100644 --- a/BHCDatabase/test/models/medical_condition_funder_test.rb +++ b/BHCDatabase/test/models/medical_condition_funder_test.rb @@ -19,4 +19,12 @@ @medical_con...
Add test for index on medical_condition and funder for a medical condition funder.
diff --git a/bin/rwiki.rb b/bin/rwiki.rb index abc1234..def5678 100644 --- a/bin/rwiki.rb +++ b/bin/rwiki.rb @@ -9,8 +9,8 @@ working_folder = File.join(Dir.pwd, working_folder) end -WIKIR_ROOT = working_folder.freeze -p "Working folder is: #{WIKIR_ROOT}" -Dir.chdir(WIKIR_ROOT) +RWIKI_ROOT = working_folder.freeze +...
Fix typo in constant name.
diff --git a/lib/ello/kinesis_consumer/mailchimp_processor.rb b/lib/ello/kinesis_consumer/mailchimp_processor.rb index abc1234..def5678 100644 --- a/lib/ello/kinesis_consumer/mailchimp_processor.rb +++ b/lib/ello/kinesis_consumer/mailchimp_processor.rb @@ -8,7 +8,7 @@ def user_was_created(record) mailchi...
Add default value for when `followed_categories` is nil
diff --git a/lib/flipper/instrumentation/statsd_subscriber.rb b/lib/flipper/instrumentation/statsd_subscriber.rb index abc1234..def5678 100644 --- a/lib/flipper/instrumentation/statsd_subscriber.rb +++ b/lib/flipper/instrumentation/statsd_subscriber.rb @@ -3,7 +3,6 @@ # that lives in the same directory as this file. Th...
Stop requiring statsd in subscriber Nothing statsd specific is referenced other than the client, but that is just through the class var so no need to require this.
diff --git a/lib/heroku_line_item_billing/models/formation.rb b/lib/heroku_line_item_billing/models/formation.rb index abc1234..def5678 100644 --- a/lib/heroku_line_item_billing/models/formation.rb +++ b/lib/heroku_line_item_billing/models/formation.rb @@ -3,7 +3,7 @@ PRICES = { "1x" => {"cents" => 5, "unit"...
Fix duplicate entry for 2x dynos
diff --git a/spec/features/signin_users_in_spec.rb b/spec/features/signin_users_in_spec.rb index abc1234..def5678 100644 --- a/spec/features/signin_users_in_spec.rb +++ b/spec/features/signin_users_in_spec.rb @@ -19,7 +19,14 @@ end scenario "with invalid credentials" do - + visit "/" + click_link "Sign in"...
Add test for unsuccessful sign in
diff --git a/spec/helpers/ci_status_helper_spec.rb b/spec/helpers/ci_status_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/ci_status_helper_spec.rb +++ b/spec/helpers/ci_status_helper_spec.rb @@ -6,25 +6,54 @@ let(:success_commit) { double("Ci::Pipeline", status: 'success') } let(:failed_commit) {...
Add specs for new ci status helper method
diff --git a/cloudy_ui.rb b/cloudy_ui.rb index abc1234..def5678 100644 --- a/cloudy_ui.rb +++ b/cloudy_ui.rb @@ -2,7 +2,7 @@ require_relative 'cloudy_ui/button' require_relative 'cloudy_ui/slider' - def self.load_images window, load_path=File.join(Dir.pwd, 'cloudy_ui/images') + def self.load_images window, l...
Fix for putting files in subdirectory
diff --git a/spec/models/poll/question_spec.rb b/spec/models/poll/question_spec.rb index abc1234..def5678 100644 --- a/spec/models/poll/question_spec.rb +++ b/spec/models/poll/question_spec.rb @@ -2,13 +2,6 @@ RSpec.describe Poll::Question, type: :model do let(:poll_question) { build(:poll_question) } - - describ...
Remove no longer needed question model tests for valid_answers
diff --git a/ForecastIOClient.podspec b/ForecastIOClient.podspec index abc1234..def5678 100644 --- a/ForecastIOClient.podspec +++ b/ForecastIOClient.podspec @@ -1,24 +1,8 @@-# -# Be sure to run `pod lib lint ForecastIOClient.podspec' to ensure this is a -# valid spec and remove all comments before submitting the spec. ...
Update podspec with summary and remove extra fields.
diff --git a/lib/asciidoctor/latex/inject_html.rb b/lib/asciidoctor/latex/inject_html.rb index abc1234..def5678 100644 --- a/lib/asciidoctor/latex/inject_html.rb +++ b/lib/asciidoctor/latex/inject_html.rb @@ -23,7 +23,7 @@ </style> -<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4...
Change http refernce to jquery at google to https
diff --git a/app/controllers/ajo_register/registrations_controller.rb b/app/controllers/ajo_register/registrations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/ajo_register/registrations_controller.rb +++ b/app/controllers/ajo_register/registrations_controller.rb @@ -24,4 +24,10 @@ def thank_yo...
Add after sign up path
diff --git a/tzinfo_completer.gemspec b/tzinfo_completer.gemspec index abc1234..def5678 100644 --- a/tzinfo_completer.gemspec +++ b/tzinfo_completer.gemspec @@ -4,4 +4,5 @@ s.date = "2008-11-17" s.summary = "Contains the parts of the TZInfo gem not included in the slimmed-down version in ActiveSupport" s.h...
Add files to gem specification
diff --git a/bootstrap_sb_admin_base_v2.gemspec b/bootstrap_sb_admin_base_v2.gemspec index abc1234..def5678 100644 --- a/bootstrap_sb_admin_base_v2.gemspec +++ b/bootstrap_sb_admin_base_v2.gemspec @@ -19,8 +19,6 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"...
Add jquery-rails and font-awesome-rails gems as dependencies
diff --git a/app/mailers/noisy_workflow.rb b/app/mailers/noisy_workflow.rb index abc1234..def5678 100644 --- a/app/mailers/noisy_workflow.rb +++ b/app/mailers/noisy_workflow.rb @@ -19,8 +19,12 @@ def request_fact_check(edition, email_addresses) @edition = edition - mail(:to => email_addresses, - :rep...
Set from/reply-to addresses on fact check requests to proper one
diff --git a/ws/ws_wrapper.rb b/ws/ws_wrapper.rb index abc1234..def5678 100644 --- a/ws/ws_wrapper.rb +++ b/ws/ws_wrapper.rb @@ -0,0 +1,12 @@+module Ldash + # Class that wraps around Faye's ws object so we can send events more easily + class WSWrapper + def initialize(ws) + @ws = ws + end + + def send_r...
Make a class to wrap around Faye's ws object
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -0,0 +1,7 @@+Sidekiq.configure_server do |config| + config.redis = { url: ENV['REDIS_URL'] || 'redis://localhost:6379/12' } +end + +Sid...
Allow REDIS_URL to be set with ENV vars
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -1,7 +1,22 @@ Sidekiq.configure_client do |config| config.client_middleware do |chain| chain.add SidekiqLoggerMiddleware - # ...
Add missing server side unique jobs config As discussed in the previous commit, when we upgraded sidekiq-unique-gems to 7.0 we didn't add in all the required config. Default config was removed from 7.0 of the unique sidekicks job gem. As a result, you have to manually configure the client and server middleware (see h...
diff --git a/lib/tasks/grant_group_self_access.rb b/lib/tasks/grant_group_self_access.rb index abc1234..def5678 100644 --- a/lib/tasks/grant_group_self_access.rb +++ b/lib/tasks/grant_group_self_access.rb @@ -19,7 +19,7 @@ # if group is a council, only that council-group, not the parent-group, # should h...
Tweak to task as there seem to be councils that don't have parent groups.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -36,7 +36,7 @@ def user_owner if current_user != @user flash[:dang...
Modify redirection in the user_owner helper
diff --git a/barge.gemspec b/barge.gemspec index abc1234..def5678 100644 --- a/barge.gemspec +++ b/barge.gemspec @@ -10,7 +10,10 @@ spec.authors = ['Ørjan Blom'] spec.email = %w(blom@blom.tv) spec.homepage = 'https://github.com/blom/barge' - spec.files = Dir['lib/**/*.rb', '[A-Z][A-Z]*'] + +...
Use `git ls-files` for file inclusion
diff --git a/app/models/duckrails/application_state.rb b/app/models/duckrails/application_state.rb index abc1234..def5678 100644 --- a/app/models/duckrails/application_state.rb +++ b/app/models/duckrails/application_state.rb @@ -7,7 +7,8 @@ default_scope { order(id: :desc) } - validates_inclusion_of :singlet...
Add validations to the singleton guard & the mock synchronization token. Refs 16.
diff --git a/app/models/concerns/core/friendly_globalize_sluggable.rb b/app/models/concerns/core/friendly_globalize_sluggable.rb index abc1234..def5678 100644 --- a/app/models/concerns/core/friendly_globalize_sluggable.rb +++ b/app/models/concerns/core/friendly_globalize_sluggable.rb @@ -22,6 +22,7 @@ private ...
Add FIXME annotation to file
diff --git a/spec/tic_tac_toe/rack_spec.rb b/spec/tic_tac_toe/rack_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe/rack_spec.rb +++ b/spec/tic_tac_toe/rack_spec.rb @@ -6,7 +6,8 @@ include Rack::Test::Methods def app - TicTacToe::RackShell.new_shell + app = TicTacToe::RackShell.new_shell + R...
Add a session pool to the top level app tests
diff --git a/app/controllers/payments_handler_controller.rb b/app/controllers/payments_handler_controller.rb index abc1234..def5678 100644 --- a/app/controllers/payments_handler_controller.rb +++ b/app/controllers/payments_handler_controller.rb @@ -21,7 +21,7 @@ params.permit(:method, :amount) end - def...
Add a test withdrawal function
diff --git a/Casks/djay-pro.rb b/Casks/djay-pro.rb index abc1234..def5678 100644 --- a/Casks/djay-pro.rb +++ b/Casks/djay-pro.rb @@ -1,11 +1,11 @@ cask :v1 => 'djay-pro' do - version '1.1.3-201506261526' - sha256 '47bb67196483e684ce3009088886e915fb9e83049fc263d3cc96d38755f5185c' + version '1.2-201508141249' + sha25...
Update djay Pro to 1.2-201508141249
diff --git a/lib/cutaneous/engine.rb b/lib/cutaneous/engine.rb index abc1234..def5678 100644 --- a/lib/cutaneous/engine.rb +++ b/lib/cutaneous/engine.rb @@ -1,14 +1,14 @@ module Cutaneous + # Manages a set of Loaders that render templates class Engine + attr_accessor :loader_class + def initialize(templat...
Make loader class configurable & keep copies of loaders on a per-format basis
diff --git a/app/presenters/tree_builder_template_filter.rb b/app/presenters/tree_builder_template_filter.rb index abc1234..def5678 100644 --- a/app/presenters/tree_builder_template_filter.rb +++ b/app/presenters/tree_builder_template_filter.rb @@ -1,6 +1,6 @@ class TreeBuilderTemplateFilter < TreeBuilderVmsFilter d...
Rename class of leaves for Template filter tree. Rename class of leaves for Template filter tree as earlier renamed elsewhere in the big model rename. https://bugzilla.redhat.com/show_bug.cgi?id=1283642
diff --git a/config/initializers/notifiable_classes.rb b/config/initializers/notifiable_classes.rb index abc1234..def5678 100644 --- a/config/initializers/notifiable_classes.rb +++ b/config/initializers/notifiable_classes.rb @@ -1,3 +1,14 @@ # Set classes that can be notified when # actions happen to them -Inquest::Ap...
Check that the notifiable classes include the Inquest::Notifiable module, and warn if they do not. Record reactor classes in config, as trying to automatically determine them is not working correctly.
diff --git a/puppet-lint-duplicate_class_parameters-check.gemspec b/puppet-lint-duplicate_class_parameters-check.gemspec index abc1234..def5678 100644 --- a/puppet-lint-duplicate_class_parameters-check.gemspec +++ b/puppet-lint-duplicate_class_parameters-check.gemspec @@ -22,7 +22,7 @@ spec.add_development_dependency...
Update rubocop requirement from ~> 0.86.0 to ~> 0.87.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](h...
diff --git a/lib/hdo/search/index.rb b/lib/hdo/search/index.rb index abc1234..def5678 100644 --- a/lib/hdo/search/index.rb +++ b/lib/hdo/search/index.rb @@ -5,13 +5,15 @@ def update_index_on_change_of(*args) singular = self.to_s.downcase plural = singular.pluralize - classes = args.map...
Improve the symbol->class resolution in Hdo::Search::Index
diff --git a/spec/app_spec_helper.rb b/spec/app_spec_helper.rb index abc1234..def5678 100644 --- a/spec/app_spec_helper.rb +++ b/spec/app_spec_helper.rb @@ -26,8 +26,8 @@ # production config / requires else # development or testing only - require 'pry' - require 'awesome_print' + #require 'pry' + #require 'aw...
Remove debug only gem refs.
diff --git a/lib/safely/backtrace.rb b/lib/safely/backtrace.rb index abc1234..def5678 100644 --- a/lib/safely/backtrace.rb +++ b/lib/safely/backtrace.rb @@ -22,16 +22,9 @@ trace_file = File.join( self.trace_directory, "backtrace-#{Time.now.strftime('%Y%m%d%H%M%S')}-#{Process.pid}.log" ) trace_log = Log...
Use `$!` to report the last Exception. The previous method does not work reliably.
diff --git a/lib/static_sync/meta.rb b/lib/static_sync/meta.rb index abc1234..def5678 100644 --- a/lib/static_sync/meta.rb +++ b/lib/static_sync/meta.rb @@ -15,10 +15,11 @@ def for(file) meta = { - :public => true, :key => file, :body => Fil...
Enable checksum validation on upload.
diff --git a/lib/vimrunner/errors.rb b/lib/vimrunner/errors.rb index abc1234..def5678 100644 --- a/lib/vimrunner/errors.rb +++ b/lib/vimrunner/errors.rb @@ -1,6 +1,11 @@ module Vimrunner - class NoSuitableVimError < RuntimeError; end class InvalidCommandError < RuntimeError; end + + class NoSuitableVimError < Run...
Add a more helpful message to NoSuitableVimError
diff --git a/lib/weather_reporter.rb b/lib/weather_reporter.rb index abc1234..def5678 100644 --- a/lib/weather_reporter.rb +++ b/lib/weather_reporter.rb @@ -2,8 +2,13 @@ require 'weather_reporter/http_service/request' require 'weather_reporter/configuration' require 'weather_reporter/error/invalid_path' +require 'wea...
Set require for added validator class
diff --git a/LambdaKit.podspec b/LambdaKit.podspec index abc1234..def5678 100644 --- a/LambdaKit.podspec +++ b/LambdaKit.podspec @@ -6,7 +6,7 @@ s.homepage = 'https://github.com/Reflejo/ClosureKit' s.social_media_url = 'https://twitter.com/fz' s.authors = { 'Martin Conte Mac Donell' => 'reflejo@gmail.com' } - ...
Add version to podspec source
diff --git a/core/lib/spree/testing_support/common_rake.rb b/core/lib/spree/testing_support/common_rake.rb index abc1234..def5678 100644 --- a/core/lib/spree/testing_support/common_rake.rb +++ b/core/lib/spree/testing_support/common_rake.rb @@ -17,7 +17,8 @@ puts "Setting up dummy database..." - sh "bundle e...
Fix database deletion and creation in test_app In some circumstances, creating and deleting the database was failing when running rake test_app. This was likely broken in by bc8efcb5f66057e0a6e91abaf801528c556d28d0 as well as the rails 5 upgrade. Fixes #1491
diff --git a/configs.gemspec b/configs.gemspec index abc1234..def5678 100644 --- a/configs.gemspec +++ b/configs.gemspec @@ -16,6 +16,5 @@ gem.version = Configs::VERSION gem.add_dependency 'activesupport', '>3.0' - gem.add_development_dependency "test-unit" gem.add_development_dependency "rake" end
Remove redundant test-unit gem dependency
diff --git a/db/migrate/20160605114232_create_users.rb b/db/migrate/20160605114232_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20160605114232_create_users.rb +++ b/db/migrate/20160605114232_create_users.rb @@ -3,8 +3,9 @@ create_table :users do |t| t.string :first_name, null: false ...
Add column for password hash
diff --git a/site-cookbooks/1password/recipes/default.rb b/site-cookbooks/1password/recipes/default.rb index abc1234..def5678 100644 --- a/site-cookbooks/1password/recipes/default.rb +++ b/site-cookbooks/1password/recipes/default.rb @@ -1,6 +1,6 @@ directory "#{ENV['HOME']}/Applications" -unless File.exists?("#{ENV['...
Check for 1password also in /Applications
diff --git a/cru_lib.gemspec b/cru_lib.gemspec index abc1234..def5678 100644 --- a/cru_lib.gemspec +++ b/cru_lib.gemspec @@ -17,6 +17,7 @@ spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] + spe...
Add global_registry as a dependency
diff --git a/fluent-plugin-juniper-telemetry.gemspec b/fluent-plugin-juniper-telemetry.gemspec index abc1234..def5678 100644 --- a/fluent-plugin-juniper-telemetry.gemspec +++ b/fluent-plugin-juniper-telemetry.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |s| s.name = "fluent-plugin-juniper-telemetry" ...
Update Gem number to 0.2.9
diff --git a/config/initializers/carrierwave.rb b/config/initializers/carrierwave.rb index abc1234..def5678 100644 --- a/config/initializers/carrierwave.rb +++ b/config/initializers/carrierwave.rb @@ -2,8 +2,6 @@ if Rails.env.production? and Configuration[:aws_access_key] config.fog_credentials = { provid...
Remove host and endpoint from CarrierWave configuration
diff --git a/spec/inputs/character_limited_input_spec.rb b/spec/inputs/character_limited_input_spec.rb index abc1234..def5678 100644 --- a/spec/inputs/character_limited_input_spec.rb +++ b/spec/inputs/character_limited_input_spec.rb @@ -0,0 +1,33 @@+require 'spec_helper' + +RSpec.describe CharacterLimitedInput do + in...
Add specs for custom character limited input
diff --git a/test/features/visit_all_page_test.rb b/test/features/visit_all_page_test.rb index abc1234..def5678 100644 --- a/test/features/visit_all_page_test.rb +++ b/test/features/visit_all_page_test.rb @@ -12,8 +12,10 @@ return if visited.include? current_path visited << current_path all('a').each do |...
Fix when page has external links, test will fail.
diff --git a/spec/factories/recent_view.rb b/spec/factories/recent_view.rb index abc1234..def5678 100644 --- a/spec/factories/recent_view.rb +++ b/spec/factories/recent_view.rb @@ -9,7 +9,14 @@ # select a random record of the given object class o_id do - type.to_s.camelcase.constantize.order('RANDOM()')...
Modify SQL in RecentView factory to support MySQL
diff --git a/lib/auto_html/filters/twitter.rb b/lib/auto_html/filters/twitter.rb index abc1234..def5678 100644 --- a/lib/auto_html/filters/twitter.rb +++ b/lib/auto_html/filters/twitter.rb @@ -2,7 +2,7 @@ require 'net/http' AutoHtml.add_filter(:twitter).with({}) do |text, options| - regex = %r{https://twitter\.com(...
Remove unnecessary grouping from Twitter regex
diff --git a/spec/lj_media/author_spec.rb b/spec/lj_media/author_spec.rb index abc1234..def5678 100644 --- a/spec/lj_media/author_spec.rb +++ b/spec/lj_media/author_spec.rb @@ -0,0 +1,29 @@+require 'spec_helper' + +describe LJMedia::Author do + describe '#new' do + it 'must accept initialization by user id only and...
Add basic spec for Author.
diff --git a/spec/routing/routing_spec.rb b/spec/routing/routing_spec.rb index abc1234..def5678 100644 --- a/spec/routing/routing_spec.rb +++ b/spec/routing/routing_spec.rb @@ -0,0 +1,10 @@+require 'spec_helper' + +describe "path helpers", type: :helper do + it do + member = mock_model(Member, url_name: "Foo_Bar", ...
Add test for path helper