diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/sql/generator/emitter/binary_connective_operation.rb b/lib/sql/generator/emitter/binary_connective_operation.rb index abc1234..def5678 100644 --- a/lib/sql/generator/emitter/binary_connective_operation.rb +++ b/lib/sql/generator/emitter/binary_connective_operation.rb @@ -46,12 +46,7 @@ # ...
Refactor parenthesize? test to be simpler
diff --git a/lib/pdfjs-rails-engine/engine.rb b/lib/pdfjs-rails-engine/engine.rb index abc1234..def5678 100644 --- a/lib/pdfjs-rails-engine/engine.rb +++ b/lib/pdfjs-rails-engine/engine.rb @@ -9,15 +9,17 @@ pdf.js-gh-pages/web/viewer.js pdf.js-gh-pages/build/pdf.js pdf.js-gh-pages/build/pdf.wo...
Update path to static assets
diff --git a/config/initializers/sequel.rb b/config/initializers/sequel.rb index abc1234..def5678 100644 --- a/config/initializers/sequel.rb +++ b/config/initializers/sequel.rb @@ -7,3 +7,5 @@ Sequel::Model.db.extension :pagination Sequel::Model.db.extension :server_block + +Sequel.default_timezone = :utc
Set timezone configuration for Sequel
diff --git a/lib/carrierwave_accessors/orm/activerecord.rb b/lib/carrierwave_accessors/orm/activerecord.rb index abc1234..def5678 100644 --- a/lib/carrierwave_accessors/orm/activerecord.rb +++ b/lib/carrierwave_accessors/orm/activerecord.rb @@ -25,7 +25,7 @@ def write_uploader(column, identifier) ...
Fix case when field is not in hstore/jsonb
diff --git a/CocoaTouchHelpers.podspec b/CocoaTouchHelpers.podspec index abc1234..def5678 100644 --- a/CocoaTouchHelpers.podspec +++ b/CocoaTouchHelpers.podspec @@ -17,7 +17,7 @@ s.default_subspec = 'Core' s.subspec 'Core' do |cs| - cs.source_files = "Main/Src/*.swift", "Main/Src/*.{h,m}", "Main/Src/Categori...
Revert "Swift support fix in podspec file" This reverts commit 616f0bc0dd4c8dabfba2916549021dd4d1f62cb8.
diff --git a/lib/generators/searcher/searcher_generator.rb b/lib/generators/searcher/searcher_generator.rb index abc1234..def5678 100644 --- a/lib/generators/searcher/searcher_generator.rb +++ b/lib/generators/searcher/searcher_generator.rb @@ -23,6 +23,6 @@ private def model_names - ARGV[0..-2].map(&:undersc...
Undo logic that makes no sense with an optional param."
diff --git a/lib/jruby-visualizer/ast_tree_view_builder.rb b/lib/jruby-visualizer/ast_tree_view_builder.rb index abc1234..def5678 100644 --- a/lib/jruby-visualizer/ast_tree_view_builder.rb +++ b/lib/jruby-visualizer/ast_tree_view_builder.rb @@ -13,20 +13,18 @@ node_string = "#{node.node_name}#{node_information} #{n...
Use inner method to remove conditional
diff --git a/alchemy-pg_search.gemspec b/alchemy-pg_search.gemspec index abc1234..def5678 100644 --- a/alchemy-pg_search.gemspec +++ b/alchemy-pg_search.gemspec @@ -14,7 +14,6 @@ spec.license = "BSD" spec.files = `git ls-files`.split($/) - spec.executables = spec.files.grep(%r{^bin/}) { |f| File...
Remove executables line from gemspec
diff --git a/ZXingObjC.podspec b/ZXingObjC.podspec index abc1234..def5678 100644 --- a/ZXingObjC.podspec +++ b/ZXingObjC.podspec @@ -10,7 +10,7 @@ s.source = { :git => "https://github.com/TheLevelUp/ZXingObjC.git", :tag => "2.1.0" } s.source_files = 'ZXingObjC/**/*.{h,m}' - s...
Mark ARC as required in the podspec
diff --git a/test/cases/bind_parameter_test_sqlserver.rb b/test/cases/bind_parameter_test_sqlserver.rb index abc1234..def5678 100644 --- a/test/cases/bind_parameter_test_sqlserver.rb +++ b/test/cases/bind_parameter_test_sqlserver.rb @@ -1,62 +1,33 @@ require 'cases/sqlserver_helper' require 'models/topic' require 'mo...
Fix how we are checking bind tests, can't use coerce since the test methods are defined in an if block
diff --git a/http.gemspec b/http.gemspec index abc1234..def5678 100644 --- a/http.gemspec +++ b/http.gemspec @@ -3,8 +3,8 @@ require 'http/version' Gem::Specification.new do |gem| - gem.authors = %w(Tony Arcieri) - gem.email = %w(tony.arcieri@gmail.com) + gem.authors = ['Tony Arcieri'] + gem....
Replace %w() with [] in gemspec Because sometimes it doesn't worth... ;))
diff --git a/lib/activerecord_reindex/update_document_monkey_patch.rb b/lib/activerecord_reindex/update_document_monkey_patch.rb index abc1234..def5678 100644 --- a/lib/activerecord_reindex/update_document_monkey_patch.rb +++ b/lib/activerecord_reindex/update_document_monkey_patch.rb @@ -17,7 +17,14 @@ def upda...
Fix indexing new associated records
diff --git a/lib/adhearsion/call_controller/output/abstract_player.rb b/lib/adhearsion/call_controller/output/abstract_player.rb index abc1234..def5678 100644 --- a/lib/adhearsion/call_controller/output/abstract_player.rb +++ b/lib/adhearsion/call_controller/output/abstract_player.rb @@ -17,10 +17,6 @@ end ...
[CS] Remove unused method from private API
diff --git a/lib/fog/octocloud/requests/compute/remote_upload_cube.rb b/lib/fog/octocloud/requests/compute/remote_upload_cube.rb index abc1234..def5678 100644 --- a/lib/fog/octocloud/requests/compute/remote_upload_cube.rb +++ b/lib/fog/octocloud/requests/compute/remote_upload_cube.rb @@ -14,7 +14,8 @@ impor...
Extend timeouts on cube upload
diff --git a/spec/factories/meals/cost_factory.rb b/spec/factories/meals/cost_factory.rb index abc1234..def5678 100644 --- a/spec/factories/meals/cost_factory.rb +++ b/spec/factories/meals/cost_factory.rb @@ -3,6 +3,7 @@ FactoryBot.define do factory :meal_cost, class: "Meals::Cost" do meal + association :rei...
802: Add reimbursee to meal cost factory
diff --git a/spec/plugin/_erubis_escaping_spec.rb b/spec/plugin/_erubis_escaping_spec.rb index abc1234..def5678 100644 --- a/spec/plugin/_erubis_escaping_spec.rb +++ b/spec/plugin/_erubis_escaping_spec.rb @@ -1,6 +1,7 @@ require File.expand_path("spec_helper", File.dirname(File.dirname(__FILE__))) begin + require '...
Fix _erubis_escaping spec plugin guard
diff --git a/spec/routing/backend/content_spec.rb b/spec/routing/backend/content_spec.rb index abc1234..def5678 100644 --- a/spec/routing/backend/content_spec.rb +++ b/spec/routing/backend/content_spec.rb @@ -0,0 +1,21 @@+require 'rails_helper' + +describe 'content routes' do + # namespace :content do + # resources...
Prepare for the content routes.
diff --git a/mandel.rb b/mandel.rb index abc1234..def5678 100644 --- a/mandel.rb +++ b/mandel.rb @@ -0,0 +1,30 @@+ +def pixels_for_count(count) + # count > 4 ? '#' : '.' + [' ','.','-','/','|','<','{','%','&','@','#'][count % 10] +end + +acorn = -2.4 +bcorn = -1.2 +size = 3.1 +pixels = [] +(1..150).each do |j| + pix...
Add ruby implementation as "check" The Jack implementation is incredibly slow, and may not actually work so we add a ruby implementation as a check that our impl actually works. This ruby implementation is a direct transliteration of the Jack one (without the boolean logic decompression as I'm pretty sure that rubys'...
diff --git a/POSDataStructures.podspec b/POSDataStructures.podspec index abc1234..def5678 100644 --- a/POSDataStructures.podspec +++ b/POSDataStructures.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = 'POSDataStructures' - s.version = '1.0.0' + s.version = '1.0.1' s.license = 'MIT...
Update library version in podspec.
diff --git a/app/controllers/backend/schemes_controller.rb b/app/controllers/backend/schemes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/backend/schemes_controller.rb +++ b/app/controllers/backend/schemes_controller.rb @@ -1,9 +1,5 @@ module Backend class SchemesController < Backend::BaseContro...
Revert "temporary allowing to update schemes with token auth" This reverts commit 6c5e107737872cb27a4fb746126ea3d4bed8c2dd.
diff --git a/providers/elastic_lb.rb b/providers/elastic_lb.rb index abc1234..def5678 100644 --- a/providers/elastic_lb.rb +++ b/providers/elastic_lb.rb @@ -15,6 +15,8 @@ private def elb - @@elb ||= RightAws::ElbInterface.new(new_resource.aws_access_key, new_resource.aws_secret_access_key, { :logger => Chef::Log })...
Support other regions besides us-east-1
diff --git a/MTBBarcodeScanner.podspec b/MTBBarcodeScanner.podspec index abc1234..def5678 100644 --- a/MTBBarcodeScanner.podspec +++ b/MTBBarcodeScanner.podspec @@ -5,7 +5,7 @@ s.homepage = "https://github.com/mikebuss/MTBBarcodeScanner" s.license = 'MIT' s.author = { "Mike Buss" => "...
Use https link in podspec
diff --git a/lib/chargify_api_ares/resources/transaction.rb b/lib/chargify_api_ares/resources/transaction.rb index abc1234..def5678 100644 --- a/lib/chargify_api_ares/resources/transaction.rb +++ b/lib/chargify_api_ares/resources/transaction.rb @@ -13,5 +13,10 @@ attrs.merge!(:payment_id => self.id) Subscr...
Add blank Taxation and TaxRule classes
diff --git a/api/db/migrate/20120411123334_resize_api_key_field.rb b/api/db/migrate/20120411123334_resize_api_key_field.rb index abc1234..def5678 100644 --- a/api/db/migrate/20120411123334_resize_api_key_field.rb +++ b/api/db/migrate/20120411123334_resize_api_key_field.rb @@ -1,5 +1,7 @@ class ResizeApiKeyField < Activ...
Check if User is defined on ResizeApiKeyField Migration (like others)
diff --git a/vagrant_base/rebar/recipes/default.rb b/vagrant_base/rebar/recipes/default.rb index abc1234..def5678 100644 --- a/vagrant_base/rebar/recipes/default.rb +++ b/vagrant_base/rebar/recipes/default.rb @@ -26,10 +26,11 @@ script "install rebar" do interpreter "bash" - user node.rebar.user + user "root" ...
Fix rebar recipe for Ubuntu 11.04, resolve conflicts
diff --git a/spec/helpers/cloud_volume_helper/textual_summary_spec.rb b/spec/helpers/cloud_volume_helper/textual_summary_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/cloud_volume_helper/textual_summary_spec.rb +++ b/spec/helpers/cloud_volume_helper/textual_summary_spec.rb @@ -10,5 +10,5 @@ attachments ...
Add Status field to spec
diff --git a/lib/specinfra/command/opensuse/base/service.rb b/lib/specinfra/command/opensuse/base/service.rb index abc1234..def5678 100644 --- a/lib/specinfra/command/opensuse/base/service.rb +++ b/lib/specinfra/command/opensuse/base/service.rb @@ -1,7 +1,12 @@ class Specinfra::Command::Opensuse::Base::Service < Specin...
Include other systemd actions and override is_enabled check This PR adds all systemd functions to opensuse and overrides the is_enabled check to ensure we also check for sysv style files in case we don't have a systemd service
diff --git a/config.rb b/config.rb index abc1234..def5678 100644 --- a/config.rb +++ b/config.rb @@ -33,7 +33,7 @@ activate :blog do |blog| blog.prefix = 'blog' blog.layout = 'blog_layout' - blog.permalink = '{title}.html' + blog.permalink = '{title}' blog.summary_separator = /\n\n/ end
Drop the .html blog links
diff --git a/dm-core.gemspec b/dm-core.gemspec index abc1234..def5678 100644 --- a/dm-core.gemspec +++ b/dm-core.gemspec @@ -10,9 +10,7 @@ gem.test_files = `git ls-files -- {spec}/*`.split("\n") gem.extra_rdoc_files = %w[LICENSE README.rdoc] - gem.add_dependency(%q<addressable>, ["~> 2.3"]) - gem.add_dep...
Remove development dependencies from the runtime dependency list * Update addressable to reference the latest stable version
diff --git a/fabychy.gemspec b/fabychy.gemspec index abc1234..def5678 100644 --- a/fabychy.gemspec +++ b/fabychy.gemspec @@ -1,15 +1,15 @@ lib = File.expand_path('../lib', __FILE__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) -require 'rubychy/version' +require 'fabychy/version' Gem::Specification.new d...
Fix the naming for the gem spec
diff --git a/spec/watirspec/watirspec.rake b/spec/watirspec/watirspec.rake index abc1234..def5678 100644 --- a/spec/watirspec/watirspec.rake +++ b/spec/watirspec/watirspec.rake @@ -1,9 +1,9 @@ begin - require 'spec' + require 'rspec' rescue LoadError begin require 'rubygems' - require 'spec' + require...
Fix the rakefile for RSpec 2.
diff --git a/spec/weather_reporter_spec.rb b/spec/weather_reporter_spec.rb index abc1234..def5678 100644 --- a/spec/weather_reporter_spec.rb +++ b/spec/weather_reporter_spec.rb @@ -4,8 +4,4 @@ it "has a version number" do expect(WeatherReporter::VERSION).not_to be nil end - - it "does something useful" do - ...
Remove auto generated test case remove "does something useful" it block
diff --git a/043-substring-divisibility/solution.rb b/043-substring-divisibility/solution.rb index abc1234..def5678 100644 --- a/043-substring-divisibility/solution.rb +++ b/043-substring-divisibility/solution.rb @@ -0,0 +1,45 @@+# The number, 1406357289, is a 0 to 9 pandigital number because it is made up of each of t...
Complete P43, but refactoring badly needed
diff --git a/BHCDatabase/test/models/answer_test.rb b/BHCDatabase/test/models/answer_test.rb index abc1234..def5678 100644 --- a/BHCDatabase/test/models/answer_test.rb +++ b/BHCDatabase/test/models/answer_test.rb @@ -1,7 +1,31 @@ require 'test_helper' class AnswerTest < ActiveSupport::TestCase - # test "the truth" ...
Write model tests for an answer.
diff --git a/app/models/otu.rb b/app/models/otu.rb index abc1234..def5678 100644 --- a/app/models/otu.rb +++ b/app/models/otu.rb @@ -4,11 +4,13 @@ belongs_to :import_job has_one :csv_dataset, :through => :import_job has_many :categorical_trait_values, :dependent => :destroy + has_many :categorical_trait_catego...
Add method to get categorical_traits from Otu
diff --git a/features/step_definitions/website_management_steps.rb b/features/step_definitions/website_management_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/website_management_steps.rb +++ b/features/step_definitions/website_management_steps.rb @@ -1,13 +1,13 @@ Given /^I am logged in as an ...
Use a valid email address for administrator user account in 'I am logged in as an administrator' cucumber step
diff --git a/app/controllers/chat/rooms/messages_controller.rb b/app/controllers/chat/rooms/messages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/chat/rooms/messages_controller.rb +++ b/app/controllers/chat/rooms/messages_controller.rb @@ -9,7 +9,7 @@ end def index - @messages = @room.m...
Use mongo to sort messages instead of ruby
diff --git a/spec/features/show_active_matches_spec.rb b/spec/features/show_active_matches_spec.rb index abc1234..def5678 100644 --- a/spec/features/show_active_matches_spec.rb +++ b/spec/features/show_active_matches_spec.rb @@ -0,0 +1,35 @@+require 'spec_helper' + +feature 'Show active matches in project page' do + b...
Create feature spec for showing active matches Active matches are shown on project page
diff --git a/spec/unit/converters/convert_file_spec.rb b/spec/unit/converters/convert_file_spec.rb index abc1234..def5678 100644 --- a/spec/unit/converters/convert_file_spec.rb +++ b/spec/unit/converters/convert_file_spec.rb @@ -10,6 +10,7 @@ allow(::File).to receive(:dirname).and_return('.') allow(::File).to ...
Change to stub file close
diff --git a/lib/filelock.rb b/lib/filelock.rb index abc1234..def5678 100644 --- a/lib/filelock.rb +++ b/lib/filelock.rb @@ -1,7 +1,7 @@ require 'filelock/version' require 'timeout' -if VERSION <= "1.8.7" +if RUBY_VERSION <= "1.8.7" require 'tempfile' def Filelock(lockname, options = {}, &block)
fix: Use RUBY_VERSION instead of VERSION
diff --git a/lib/justcoin.rb b/lib/justcoin.rb index abc1234..def5678 100644 --- a/lib/justcoin.rb +++ b/lib/justcoin.rb @@ -5,24 +5,34 @@ class Justcoin - DEFAULT_URI = "https://justcoin.com/api/v1" + DEFAULT_URL = "https://justcoin.com/api/v1".freeze attr_reader :key, :options, :client def initialize(...
Allow passing options to Faraday, set adapter
diff --git a/lib/tatooine.rb b/lib/tatooine.rb index abc1234..def5678 100644 --- a/lib/tatooine.rb +++ b/lib/tatooine.rb @@ -13,5 +13,5 @@ require "tatooine/vehicle" module Tatooine - API_BASE = "http://swapi.co/api/" + API_BASE = "https://swapi.co/api/" end
Change swap uri constant from http to https
diff --git a/lib/yubioath.rb b/lib/yubioath.rb index abc1234..def5678 100644 --- a/lib/yubioath.rb +++ b/lib/yubioath.rb @@ -1,4 +1,16 @@+require 'bindata' + module YubiOATH CLA = 0x00 AID = [0xA0, 0x00, 0x00, 0x05, 0x27, 0x21, 0x01, 0x01] + + class Response < BinData::Record + count_bytes_remaining :data_le...
Define a generic Response record which checks the trailing success code
diff --git a/app/helpers/url_helper.rb b/app/helpers/url_helper.rb index abc1234..def5678 100644 --- a/app/helpers/url_helper.rb +++ b/app/helpers/url_helper.rb @@ -10,7 +10,7 @@ if params[:profile].present? options[:profile] = params[:profile] end - elsif @domain.profile and @domain.profile.id...
Allow host to be specified
diff --git a/app/models/taxon.rb b/app/models/taxon.rb index abc1234..def5678 100644 --- a/app/models/taxon.rb +++ b/app/models/taxon.rb @@ -1,6 +1,6 @@ class Taxon < ActiveRecord::Base - belongs_to :taxonomy, inverse_of: :taxons + belongs_to :taxonomy, inverse_of: :taxons, touch: true validates :name, presenc...
Add touch to Taxon belongs_to Taxonomy association
diff --git a/emarsys.gemspec b/emarsys.gemspec index abc1234..def5678 100644 --- a/emarsys.gemspec +++ b/emarsys.gemspec @@ -10,7 +10,7 @@ spec.email = ["daniel.schoppmann@absolventa.de"] spec.description = %q{A Ruby library for interacting with the Emarsys API.} spec.summary = %q{Easy to use ru...
Use Github as gem homepage
diff --git a/kondate.gemspec b/kondate.gemspec index abc1234..def5678 100644 --- a/kondate.gemspec +++ b/kondate.gemspec @@ -23,8 +23,8 @@ spec.add_dependency 'serverspec' spec.add_dependency 'thor' spec.add_dependency 'highline' + spec.add_dependency "rake" spec.add_development_dependency "bundler" - sp...
Move dependency for Rake from development to runtime.
diff --git a/app/views/api/v1/performances/index.json.jbuilder b/app/views/api/v1/performances/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/v1/performances/index.json.jbuilder +++ b/app/views/api/v1/performances/index.json.jbuilder @@ -8,7 +8,7 @@ json.predecessor_host_country predecessor.a...
Speed up /performances API request by sorting appearances after query
diff --git a/test/cli/command/test_dump_fields.rb b/test/cli/command/test_dump_fields.rb index abc1234..def5678 100644 --- a/test/cli/command/test_dump_fields.rb +++ b/test/cli/command/test_dump_fields.rb @@ -0,0 +1,87 @@+# frozen_string_literal: true + +require "helpers" + +# Tests for KBSecret::CLI::Command::DumpFiel...
test/cli: Add tests for `kbsecret dump-fields`
diff --git a/lib/copy_peste/models/analyse_result.rb b/lib/copy_peste/models/analyse_result.rb index abc1234..def5678 100644 --- a/lib/copy_peste/models/analyse_result.rb +++ b/lib/copy_peste/models/analyse_result.rb @@ -6,6 +6,7 @@ field :options, type: Hash embeds_many :results + default_scope -> { asc('_id')...
Fix problem MongoDB indexing data
diff --git a/lib/fpm/cookery/dependency_inspector.rb b/lib/fpm/cookery/dependency_inspector.rb index abc1234..def5678 100644 --- a/lib/fpm/cookery/dependency_inspector.rb +++ b/lib/fpm/cookery/dependency_inspector.rb @@ -32,7 +32,8 @@ :ensure => "present" }) result = Puppet::Resource.indirec...
Check the individual resource status instead of overall status
diff --git a/nexpose.gemspec b/nexpose.gemspec index abc1234..def5678 100644 --- a/nexpose.gemspec +++ b/nexpose.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'nexpose' - s.version = '0.2.0' + s.version = '0.2.1' s.homepage = 'https://...
Bump version to add minor usability improvements.
diff --git a/lib/hexpress/processors/graphviz_dot.rb b/lib/hexpress/processors/graphviz_dot.rb index abc1234..def5678 100644 --- a/lib/hexpress/processors/graphviz_dot.rb +++ b/lib/hexpress/processors/graphviz_dot.rb @@ -4,8 +4,12 @@ module Processors # Turn embedded dot files into embedded SVGs class Graph...
Make GraphvizDot class itself callable
diff --git a/robot-name/robot_name_test.rb b/robot-name/robot_name_test.rb index abc1234..def5678 100644 --- a/robot-name/robot_name_test.rb +++ b/robot-name/robot_name_test.rb @@ -2,6 +2,11 @@ require_relative 'robot_name' class RobotTest < Minitest::Test + COMMAND_QUERY = <<-MSG + Command/Query Separation: + ...
Fix style violations in robot-name Rubocop was complaining about a long line. At first I changed the failure message to be a heredoc, which triggered a "long method" violation. This feels a bit dirty, in that the method is legitimately long, but perhaps it's not too bad to make the message a constant.
diff --git a/robot-name/robot_name_test.rb b/robot-name/robot_name_test.rb index abc1234..def5678 100644 --- a/robot-name/robot_name_test.rb +++ b/robot-name/robot_name_test.rb @@ -3,7 +3,7 @@ class RobotTest < MiniTest::Unit::TestCase def test_has_name - assert_match /\w{2}\d{3}/, Robot.new.name + assert_ma...
Make robo-name test more strict
diff --git a/printnode.gemspec b/printnode.gemspec index abc1234..def5678 100644 --- a/printnode.gemspec +++ b/printnode.gemspec @@ -1,16 +1,16 @@ Gem::Specification.new do |s| - s.name = "printnode" - s.version = "1.0.6" - s.date = "2015-08-19" - s.summary = "PrintNode-Ruby" - s.description = "Ruby AP...
Replace tabs with spaces in gemspec
diff --git a/lib/vagrant/actions/vm/forward_ports.rb b/lib/vagrant/actions/vm/forward_ports.rb index abc1234..def5678 100644 --- a/lib/vagrant/actions/vm/forward_ports.rb +++ b/lib/vagrant/actions/vm/forward_ports.rb @@ -23,7 +23,7 @@ def clear logger.info "Deleting any previously set forwarded por...
Fix forwarded ports destroy method call to use new virtualbox format
diff --git a/tasks/cops_documentation.rake b/tasks/cops_documentation.rake index abc1234..def5678 100644 --- a/tasks/cops_documentation.rake +++ b/tasks/cops_documentation.rake @@ -14,8 +14,3 @@ deps = %w[Bundler Gemspec Layout Lint Metrics Migration Naming Security Style] CopsDocumentationGenerator.new(department...
Remove an obsolete development task This commit removes an obsolete `:generate_cops_documentation` development task. It's been a year since it was introduced in https://github.com/rubocop/rubocop/commit/1905f1b and is no longer in use.
diff --git a/lib/savannah.rb b/lib/savannah.rb index abc1234..def5678 100644 --- a/lib/savannah.rb +++ b/lib/savannah.rb @@ -3,8 +3,93 @@ module Savannah class Main + attr_accessor :router + + def initialize(env={}) + @router = Router.new + end + def call(env) - [200, {}, ["Hello", "Whateve...
Add initial Rack request/response handling classes.
diff --git a/week-4/defining-variables.rb b/week-4/defining-variables.rb index abc1234..def5678 100644 --- a/week-4/defining-variables.rb +++ b/week-4/defining-variables.rb @@ -0,0 +1,39 @@+#Solution Below +first_name = 'Colin' +last_name = 'Razevich' +age = 27 + + + +# RSpec Tests. They are included in this file becau...
Add ruby file for reflection
diff --git a/ext/sha3/extconf.rb b/ext/sha3/extconf.rb index abc1234..def5678 100644 --- a/ext/sha3/extconf.rb +++ b/ext/sha3/extconf.rb @@ -1,13 +1,18 @@ require 'mkmf' +require 'rbconfig' FileUtils.rm "#{$srcdir}/KeccakF-1600-opt.c", :force => true -case 1.size -when 4 # x86 32bit optimized code +build_cpu = RbC...
FIX: Use x86 optimized code only when compiling on a x86 CPU. - Resolves compilation errors on ARM based processor (defaults to reference code).
diff --git a/laravel/recipes/symlink_storage.rb b/laravel/recipes/symlink_storage.rb index abc1234..def5678 100644 --- a/laravel/recipes/symlink_storage.rb +++ b/laravel/recipes/symlink_storage.rb @@ -7,6 +7,7 @@ mv current/storage/* shared rm -rf current/storage ln -s #{deploy[:deploy_to]}/shared #{deplo...
Adjust the permissions of the storage symlink
diff --git a/test/stream/http/auth_test.rb b/test/stream/http/auth_test.rb index abc1234..def5678 100644 --- a/test/stream/http/auth_test.rb +++ b/test/stream/http/auth_test.rb @@ -0,0 +1,68 @@+# encoding: UTF-8 + +require 'vines' +require 'minitest/autorun' + +class HttpAuthTest < MiniTest::Unit::TestCase + def setup...
Add http auth state tests.
diff --git a/examples/sprinkle/sprinkle.rb b/examples/sprinkle/sprinkle.rb index abc1234..def5678 100644 --- a/examples/sprinkle/sprinkle.rb +++ b/examples/sprinkle/sprinkle.rb @@ -1,35 +1,11 @@-#!/usr/bin/env sprinkle -s +#!/usr/bin/env sprinkle -c -s -# Example of a simple Sprinkle script to install a single gem on...
Update Sprinkle example to really be an example of the smallest Sprinkle script possible for deploying a single gem to a remote host, also demonstrates and example of using package recommendations to optionally rely on rubygems
diff --git a/common/patches.rb b/common/patches.rb index abc1234..def5678 100644 --- a/common/patches.rb +++ b/common/patches.rb @@ -1,5 +1,5 @@ class Array def find_property(property, value) - find { |e| e[property.to_s] && e[property.to_s] == value } + find { |e| e.send(property) == value } end end
Fix the find_property patch to work for objects and not just hashes
diff --git a/spec/features/merge_requests/pipelines_spec.rb b/spec/features/merge_requests/pipelines_spec.rb index abc1234..def5678 100644 --- a/spec/features/merge_requests/pipelines_spec.rb +++ b/spec/features/merge_requests/pipelines_spec.rb @@ -41,7 +41,7 @@ scenario 'user visits merge request page' do ...
Use have_no_link to test presence of button
diff --git a/Casks/yourkit-java-profiler.rb b/Casks/yourkit-java-profiler.rb index abc1234..def5678 100644 --- a/Casks/yourkit-java-profiler.rb +++ b/Casks/yourkit-java-profiler.rb @@ -1,6 +1,6 @@ cask :v1 => 'yourkit-java-profiler' do - version '2014-build-14120' - sha256 '88ae356404b150121522a941dbd5efdaa796b29cbbb...
Update Yourkit Java Profiler to 2015-build-15044
diff --git a/gigasecond/gigasecond_test.rb b/gigasecond/gigasecond_test.rb index abc1234..def5678 100644 --- a/gigasecond/gigasecond_test.rb +++ b/gigasecond/gigasecond_test.rb @@ -6,26 +6,26 @@ class GigasecondTest < MiniTest::Unit::TestCase def test_1 - gs = Gigasecond.new(Date.new(2011, 4, 25)) + gs = Gig...
Replace constructor by factory method for more expressiveness in Gigasecond
diff --git a/spec/carthage_cache/archive_installer_spec.rb b/spec/carthage_cache/archive_installer_spec.rb index abc1234..def5678 100644 --- a/spec/carthage_cache/archive_installer_spec.rb +++ b/spec/carthage_cache/archive_installer_spec.rb @@ -14,7 +14,11 @@ let(:archive_path) { File.join(project.tmpdir, project.a...
Add test ensuring installer actually unarchives zip This will be meaningful once we'll implement the check for the zip in the local cache, as we'll ensure that the archive won't be downloaded again
diff --git a/spec/rubocop/cops/cop_spec.rb b/spec/rubocop/cops/cop_spec.rb index abc1234..def5678 100644 --- a/spec/rubocop/cops/cop_spec.rb +++ b/spec/rubocop/cops/cop_spec.rb @@ -8,23 +8,23 @@ let (:cop) { Cop.new } it 'initially has 0 offences' do - cop.offences.size.should == 0 + expect...
Migrate spec from should to expect
diff --git a/spec/support/shell_helpers.rb b/spec/support/shell_helpers.rb index abc1234..def5678 100644 --- a/spec/support/shell_helpers.rb +++ b/spec/support/shell_helpers.rb @@ -20,4 +20,16 @@ end end end + + # Output text to file using `File#puts`, which mimics the behavior of the + # `echo` shell c...
Add 'echo' helper method for cross-platform compatibility
diff --git a/lib/redd/utilities/rate_limiter.rb b/lib/redd/utilities/rate_limiter.rb index abc1234..def5678 100644 --- a/lib/redd/utilities/rate_limiter.rb +++ b/lib/redd/utilities/rate_limiter.rb @@ -4,8 +4,8 @@ module Utilities # Manages rate limiting by sleeping. class RateLimiter - def initialize(g...
Fix bug with rate limit timing.
diff --git a/app/controllers/courses_controller.rb b/app/controllers/courses_controller.rb index abc1234..def5678 100644 --- a/app/controllers/courses_controller.rb +++ b/app/controllers/courses_controller.rb @@ -53,7 +53,7 @@ private def course_params - params.require(:course).permit(:name, :descriptisplits_...
Fix typo in courses controller
diff --git a/app/controllers/admin/problems_controller.rb b/app/controllers/admin/problems_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/problems_controller.rb +++ b/app/controllers/admin/problems_controller.rb @@ -10,11 +10,14 @@ @problem = @contest.problems.create problem_parameters ...
Check for existence of attachment on Problem upload.
diff --git a/app/controllers/api/v1/objects_controller.rb b/app/controllers/api/v1/objects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/objects_controller.rb +++ b/app/controllers/api/v1/objects_controller.rb @@ -8,6 +8,10 @@ File.open("#{@volume}/#{object_name}", "w") do |f| f.wr...
Delete upload token after upload is complete
diff --git a/app/controllers/tracking_lists_controller.rb b/app/controllers/tracking_lists_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tracking_lists_controller.rb +++ b/app/controllers/tracking_lists_controller.rb @@ -6,6 +6,11 @@ before_filter :get_trackable_items_user before_filter :get_tr...
Add show method to Tracking List Controller. Signed-off-by: Chris Toynbee <9bf3774ab19e71b4502fac9bd506468044cb6bd6@gmail.com>
diff --git a/lib/generators/the_moderator/install/install_generator.rb b/lib/generators/the_moderator/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/the_moderator/install/install_generator.rb +++ b/lib/generators/the_moderator/install/install_generator.rb @@ -7,7 +7,7 @@ template 'm...
Rename create_migration method in generator for Rails 4 Rails 4 already has a create_migration method in Rails::Generators::Migration.
diff --git a/core/app/models/spree/gateway/bogus_simple.rb b/core/app/models/spree/gateway/bogus_simple.rb index abc1234..def5678 100644 --- a/core/app/models/spree/gateway/bogus_simple.rb +++ b/core/app/models/spree/gateway/bogus_simple.rb @@ -4,6 +4,14 @@ def payment_profiles_supported? false + end + ...
Add process method to BogusSimple gateway to be able to process payments. Fixes issue where hitting "process" on payments screen breaks with BogusSimple gateway. Fixes #3824
diff --git a/app/controllers/manual_document_attachments_controller.rb b/app/controllers/manual_document_attachments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/manual_document_attachments_controller.rb +++ b/app/controllers/manual_document_attachments_controller.rb @@ -41,6 +41,18 @@ private ...
Use separate services for GDS/non-GDS editors When the User comes to add an attachment, if they were a GDS editor editing a non GDS manual then this would come back with a "Manual not found". This commit fixes that by using a new registry which isn't scoped to an organisation for GDS editors. This approach introduces...
diff --git a/rom-git.gemspec b/rom-git.gemspec index abc1234..def5678 100644 --- a/rom-git.gemspec +++ b/rom-git.gemspec @@ -20,6 +20,7 @@ spec.add_development_dependency "bundler" spec.add_development_dependency "rake" + spec.add_development_dependency "minitest" spec.add_development_dependency "pry" spe...
Add minitest to the gemspec
diff --git a/app/serializers/payment_serializer.rb b/app/serializers/payment_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/payment_serializer.rb +++ b/app/serializers/payment_serializer.rb @@ -2,6 +2,6 @@ attributes :id, :name, :amount, :category_id, :type, :schedule, :upcoming def upcoming -...
Include payment occurences for the next 30 days in `upcoming`
diff --git a/week-4/address/my_solution.rb b/week-4/address/my_solution.rb index abc1234..def5678 100644 --- a/week-4/address/my_solution.rb +++ b/week-4/address/my_solution.rb @@ -6,7 +6,7 @@ # Your Solution Below def make_address(street,city,state,zip) - puts "You live at #{street}, in the beautiful city of #{cit...
Change to p from puts
diff --git a/lib/doorkeeper/oauth/scopes.rb b/lib/doorkeeper/oauth/scopes.rb index abc1234..def5678 100644 --- a/lib/doorkeeper/oauth/scopes.rb +++ b/lib/doorkeeper/oauth/scopes.rb @@ -53,7 +53,7 @@ end def <=>(other) - self.all.sort <=> other.all.sort + self.map(&:to_s).sort <=> other.map(...
Fix for ruby 1.8 (cannot sort arrays of symbols)
diff --git a/db/migrations/016_refactor_filter_paper_tables.rb b/db/migrations/016_refactor_filter_paper_tables.rb index abc1234..def5678 100644 --- a/db/migrations/016_refactor_filter_paper_tables.rb +++ b/db/migrations/016_refactor_filter_paper_tables.rb @@ -0,0 +1,14 @@+::Sequel.migration do + change do + alter_...
Add migration refactoring filter paper tables
diff --git a/lib/octokit/client/statuses.rb b/lib/octokit/client/statuses.rb index abc1234..def5678 100644 --- a/lib/octokit/client/statuses.rb +++ b/lib/octokit/client/statuses.rb @@ -11,7 +11,7 @@ # @param repo [String, Repository, Hash] A GitHub repository # @param sha [String] The SHA1 for the commit ...
Update status.rb - fix link Fixes documentation links in statuses.rb
diff --git a/cookbooks/asdf/default.rb b/cookbooks/asdf/default.rb index abc1234..def5678 100644 --- a/cookbooks/asdf/default.rb +++ b/cookbooks/asdf/default.rb @@ -1,7 +1,7 @@ define :asdf_plugin, git: nil do git_url = params[:git] ? ' ' + params[:git] : nil - execute "asdf plugin-add #{params[:name]}#{git_url}"...
Use absolute path for asdf
diff --git a/rufus-lua.gemspec b/rufus-lua.gemspec index abc1234..def5678 100644 --- a/rufus-lua.gemspec +++ b/rufus-lua.gemspec @@ -11,7 +11,6 @@ s.authors = [ 'John Mettraux', 'Alain Hoang', 'Scott Persinger' ] s.email = [ 'jmettraux@gmail.com' ] s.homepage = 'https://github.com/jmettraux/rufus-lua' - s.ruby...
Drop the rubyforge entry from the gemspec
diff --git a/test/integration/local_transaction_api_test.rb b/test/integration/local_transaction_api_test.rb index abc1234..def5678 100644 --- a/test/integration/local_transaction_api_test.rb +++ b/test/integration/local_transaction_api_test.rb @@ -0,0 +1,48 @@+require 'integration_test_helper' + +class LocalTransactio...
Add Local Transaction integration test.
diff --git a/test/models/concerns/represented_model_test.rb b/test/models/concerns/represented_model_test.rb index abc1234..def5678 100644 --- a/test/models/concerns/represented_model_test.rb +++ b/test/models/concerns/represented_model_test.rb @@ -0,0 +1,26 @@+# encoding: utf-8 + +require 'test_helper' + +class TestRe...
Add missing test class for represented_model concern
diff --git a/app/controllers/api/docs/changelogs.rb b/app/controllers/api/docs/changelogs.rb index abc1234..def5678 100644 --- a/app/controllers/api/docs/changelogs.rb +++ b/app/controllers/api/docs/changelogs.rb @@ -3,6 +3,45 @@ class Changelogs # :nocov: include Swagger::Blocks + + swagger_sche...
Add swagger schema for Changelog
diff --git a/app/controllers/callback_controller.rb b/app/controllers/callback_controller.rb index abc1234..def5678 100644 --- a/app/controllers/callback_controller.rb +++ b/app/controllers/callback_controller.rb @@ -3,8 +3,8 @@ def reload_slug if params["slug"].nil? render status: 422, json: {"errors" =>...
Rename callback user_id to username
diff --git a/app/controllers/features_controller.rb b/app/controllers/features_controller.rb index abc1234..def5678 100644 --- a/app/controllers/features_controller.rb +++ b/app/controllers/features_controller.rb @@ -33,7 +33,6 @@ end def destroy - redirect_to products_path and return unless product_valid? ...
Refactor product validity check for destroying features
diff --git a/db/data_migration/20130429203445_fix_william_pitt_slug.rb b/db/data_migration/20130429203445_fix_william_pitt_slug.rb index abc1234..def5678 100644 --- a/db/data_migration/20130429203445_fix_william_pitt_slug.rb +++ b/db/data_migration/20130429203445_fix_william_pitt_slug.rb @@ -0,0 +1,4 @@+if william_pitt...
Migrate William Pitt to correct name https://www.pivotaltracker.com/story/show/48923019
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,6 +1,7 @@ class HomeController < ApplicationController def show offset = (Asciicast.featured.count * rand).to...
Use decorator for asciicast on homepage
diff --git a/lib/sourcify.rb b/lib/sourcify.rb index abc1234..def5678 100644 --- a/lib/sourcify.rb +++ b/lib/sourcify.rb @@ -5,6 +5,7 @@ require 'parse_tree' require 'parse_tree_extensions' rescue LoadError + raise if RUBY_VERSION == '1.8.6' # support for code scanner in 1.8.6 is too tedious require 'ruby_par...
Enforce ParseTree mode for 1.8.6.
diff --git a/Formula/helium-script.rb b/Formula/helium-script.rb index abc1234..def5678 100644 --- a/Formula/helium-script.rb +++ b/Formula/helium-script.rb @@ -4,7 +4,7 @@ desc "A command line interface to Helium Script." homepage 'https://dev.helium.com/downloads' version '0.1.0' - url 'http://helium-public....
Fix up to use TLS for s3
diff --git a/app/mailers/report_email_sender.rb b/app/mailers/report_email_sender.rb index abc1234..def5678 100644 --- a/app/mailers/report_email_sender.rb +++ b/app/mailers/report_email_sender.rb @@ -1,4 +1,6 @@ class ReportEmailSender + include ApplicationHelper + def initialize(report) @report = report e...
Include view helpers for email generation
diff --git a/app/models/capital_project_type.rb b/app/models/capital_project_type.rb index abc1234..def5678 100644 --- a/app/models/capital_project_type.rb +++ b/app/models/capital_project_type.rb @@ -1,7 +1,7 @@ class CapitalProjectType < ActiveRecord::Base - # Active scope -- always use this scope in forms - scop...
Fix lookup tables to not use a default scope
diff --git a/app/models/spree/product_export.rb b/app/models/spree/product_export.rb index abc1234..def5678 100644 --- a/app/models/spree/product_export.rb +++ b/app/models/spree/product_export.rb @@ -2,7 +2,7 @@ class ProductExport < ActiveRecord::Base has_attached_file :attachment validates_attachment :at...
Fix commit issue for run process
diff --git a/app/services/submission_creator.rb b/app/services/submission_creator.rb index abc1234..def5678 100644 --- a/app/services/submission_creator.rb +++ b/app/services/submission_creator.rb @@ -15,7 +15,7 @@ def call submission_rejector.reject_if_any_rules_broken(submission) - if submission.valid? &&...
[141] Validate all objects before returnig from the SubmissionCreator