diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/freshdesk/models/model.rb b/lib/freshdesk/models/model.rb index abc1234..def5678 100644 --- a/lib/freshdesk/models/model.rb +++ b/lib/freshdesk/models/model.rb @@ -28,7 +28,7 @@ def parse_resource(resource) model = self.new - resource ||= resource[@json_key] + resource = ...
Fix users not working properly
diff --git a/test/integration/content_api_response_test.rb b/test/integration/content_api_response_test.rb index abc1234..def5678 100644 --- a/test/integration/content_api_response_test.rb +++ b/test/integration/content_api_response_test.rb @@ -0,0 +1,42 @@+require_relative "../integration_test_helper" + +class Content...
Add tests to check Content API status response These tests are stubbing all the possible response codes that the Content API might produce and making sure that we're responding consistently within the frontend app.
diff --git a/lib/haml/sass_rails_filter.rb b/lib/haml/sass_rails_filter.rb index abc1234..def5678 100644 --- a/lib/haml/sass_rails_filter.rb +++ b/lib/haml/sass_rails_filter.rb @@ -5,8 +5,9 @@ class SassRailsTemplate < ::Sass::Rails::SassTemplate if Gem::Version.new(Sprockets::VERSION) >= Gem::Version.new('3...
Fix for the case Rails.application.assets is nil cherry-picking @jvenezia's patch in https://github.com/haml/haml/pull/868#issuecomment-242689915.
diff --git a/lib/mobility/active_record.rb b/lib/mobility/active_record.rb index abc1234..def5678 100644 --- a/lib/mobility/active_record.rb +++ b/lib/mobility/active_record.rb @@ -7,13 +7,18 @@ module ActiveRecord require "mobility/active_record/uniqueness_validator" + class QueryMethod < Module + def...
Use module_eval to define query scope, and name module
diff --git a/app/services/git_repository_service.rb b/app/services/git_repository_service.rb index abc1234..def5678 100644 --- a/app/services/git_repository_service.rb +++ b/app/services/git_repository_service.rb @@ -10,6 +10,6 @@ git_repo.update_authentication(:default => {:userid => git_username, :password => g...
Fix rubocop warnings in GitRepositoryService
diff --git a/lib/dissociated_introspection/recording_parent.rb b/lib/dissociated_introspection/recording_parent.rb index abc1234..def5678 100644 --- a/lib/dissociated_introspection/recording_parent.rb +++ b/lib/dissociated_introspection/recording_parent.rb @@ -1,7 +1,5 @@ class RecordingParent < BasicObject - class ...
Remove some extra new lines.
diff --git a/lib/smartsheet/api/middleware/error_translator.rb b/lib/smartsheet/api/middleware/error_translator.rb index abc1234..def5678 100644 --- a/lib/smartsheet/api/middleware/error_translator.rb +++ b/lib/smartsheet/api/middleware/error_translator.rb @@ -0,0 +1,20 @@+require 'faraday' +require_relative '../error'...
Add middleware for capturing and wrapping errors.
diff --git a/lib/princely/asset_support.rb b/lib/princely/asset_support.rb index abc1234..def5678 100644 --- a/lib/princely/asset_support.rb +++ b/lib/princely/asset_support.rb @@ -16,6 +16,7 @@ def asset_file_path(asset) # Remove /assets/ from generated names and try and find a matching asset + Rails...
Fix undefined method 'find_asset' for nil:NilClass error
diff --git a/lib/audit_tables.rb b/lib/audit_tables.rb index abc1234..def5678 100644 --- a/lib/audit_tables.rb +++ b/lib/audit_tables.rb @@ -1,24 +1,32 @@ # frozen_string_literal: true -require 'audit_tables/version' +require 'base' +require 'build_audit_trigger' +require 'change_audit_table' +require 'create_new_audit...
Test against local copy of the gem and change methods
diff --git a/lib/clock_window.rb b/lib/clock_window.rb index abc1234..def5678 100644 --- a/lib/clock_window.rb +++ b/lib/clock_window.rb @@ -30,6 +30,31 @@ exe = "xprop -id $(xprop -root 32x '\t$0' _NET_ACTIVE_WINDOW | cut -f 2) _NET_WM_NAME" format = ->str{ str.match(/.*\"(.*)\"\n\z/)[1][0..60] } ...
Add Darwin (Mac) clause using external osascript
diff --git a/lib/jiraSOAP/url.rb b/lib/jiraSOAP/url.rb index abc1234..def5678 100644 --- a/lib/jiraSOAP/url.rb +++ b/lib/jiraSOAP/url.rb @@ -2,9 +2,10 @@ # MRI by using the URI module. # # For any JIRA entity that has a URL object as an instance variable, you can -# stick what ever type of object you want in the inst...
Tweak some documentation in the URL class
diff --git a/podTest.podspec b/podTest.podspec index abc1234..def5678 100644 --- a/podTest.podspec +++ b/podTest.podspec @@ -21,7 +21,7 @@ s.source = { :git => 'https://github.com/phoenixbox/podTest.git', :tag => s.version.to_s } s.source_files = "FeedbackLoop", "FeedbackLoop/**/*.{h,m}" s.exclude...
Update dependency version on AFNetworking
diff --git a/lib/voting_booth.rb b/lib/voting_booth.rb index abc1234..def5678 100644 --- a/lib/voting_booth.rb +++ b/lib/voting_booth.rb @@ -9,7 +9,7 @@ # to override this if, for instance, you are using devise with an Admin model # and namespace. Default: current_user mattr_accessor :find_voter_block - self.f...
Fix an issue where you couldn't vote under Ruby 1.9.2 and higher. Calling instance_eval yields self to any called lambdas, so voting failed every time we tried to look up current_user (see https://gist.github.com/479572). So instead, we use a Proc.
diff --git a/cookbooks/nagios/attributes/default.rb b/cookbooks/nagios/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/nagios/attributes/default.rb +++ b/cookbooks/nagios/attributes/default.rb @@ -26,9 +26,13 @@ case node['platform_family'] when 'debian' -default['nagios']['plugin_dir'] = '/usr...
Add 32bit RHEL support for the nagios plugins directory Former-commit-id: 73bc64ab57e2e2986ee985041d88b2940822a87a [formerly 4c6d5109c5c343f56ea43ac5b1b69969023b6a46] [formerly 2eb2a13bc4b9ec104dbb8c7b739851482f642e8e [formerly e069b4bb04752849f3dc0c48a6223a0c925f313c [formerly 48457e6f5fd0593a8257cfff2b84db3d7642f6a...
diff --git a/app/controllers/public_pages_controller.rb b/app/controllers/public_pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/public_pages_controller.rb +++ b/app/controllers/public_pages_controller.rb @@ -8,5 +8,6 @@ @profile_user = User.find_by(username: profile_username) not_found...
Add 404 response for a user without a profile
diff --git a/lib/axe/api/results/rule.rb b/lib/axe/api/results/rule.rb index abc1234..def5678 100644 --- a/lib/axe/api/results/rule.rb +++ b/lib/axe/api/results/rule.rb @@ -19,7 +19,7 @@ [ title_message(index+1), helpUrl.prepend(" " * 2), - node_count_message + ...
Prepend indentation in one spot
diff --git a/lib/dm-types/bcrypt_hash.rb b/lib/dm-types/bcrypt_hash.rb index abc1234..def5678 100644 --- a/lib/dm-types/bcrypt_hash.rb +++ b/lib/dm-types/bcrypt_hash.rb @@ -17,7 +17,10 @@ def dump(value) hash = typecast(value) - hash.to_s if hash + return if hash.nil? + hash_string...
Change bcrypt type to dump a utf-8 string if possible * This is required by the yaml adapter to properly serialize the string into something that can be serialized as a string primitive and not a binary string, which is not supported by safe_yaml at the moment.
diff --git a/log-courier.gemspec b/log-courier.gemspec index abc1234..def5678 100644 --- a/log-courier.gemspec +++ b/log-courier.gemspec @@ -6,6 +6,7 @@ gem.homepage = 'https://github.com/driskell/log-courier' gem.authors = ['Jason Woods'] gem.email = ['devel@jasonwoods.me.uk'] + ...
Add license to gem spec and fix documentation on gem build
diff --git a/lib/language_pack/rails3.rb b/lib/language_pack/rails3.rb index abc1234..def5678 100644 --- a/lib/language_pack/rails3.rb +++ b/lib/language_pack/rails3.rb @@ -2,8 +2,6 @@ require "language_pack/rails2" class LanguagePack::Rails3 < LanguagePack::Rails2 - - JS_RUNTIME_PATH = File.expand_path(File.join(F...
Revert "Revert "bundle node into rails 3 slugs :{"" This reverts commit e9cbc0fe01ea3c0df57e4fa07509c3f992d794b0. Conflicts: lib/language_pack/rails3.rb
diff --git a/app/helpers/profile_helper.rb b/app/helpers/profile_helper.rb index abc1234..def5678 100644 --- a/app/helpers/profile_helper.rb +++ b/app/helpers/profile_helper.rb @@ -10,7 +10,7 @@ end def show_profile_social_tab? - Gitlab.config.omniauth.enabled && !current_user.ldap_user? + enabled_social_p...
Check if any social providers are enabled.
diff --git a/app/lib/permission_checker.rb b/app/lib/permission_checker.rb index abc1234..def5678 100644 --- a/app/lib/permission_checker.rb +++ b/app/lib/permission_checker.rb @@ -1,12 +1,21 @@ class PermissionChecker GDS_EDITOR_PERMISSION = "gds_editor" + EDITOR_PERMISSION = "editor" def initialize(user) ...
Add publish and withdraw permission check
diff --git a/lib/nessus/client/policy.rb b/lib/nessus/client/policy.rb index abc1234..def5678 100644 --- a/lib/nessus/client/policy.rb +++ b/lib/nessus/client/policy.rb @@ -4,9 +4,31 @@ module Policy # GET /policy/list def policy_list - resp = get '/policy/list' - resp['reply']['contents...
Add auxiliary methods for parsing
diff --git a/lib/onfido/request_error.rb b/lib/onfido/request_error.rb index abc1234..def5678 100644 --- a/lib/onfido/request_error.rb +++ b/lib/onfido/request_error.rb @@ -1,3 +1,20 @@+=begin +The class will handle response failures coming from Onfido +It's main purpose is to produce meaningful error messages to the u...
Add documentation as to how the request errors can be handled
diff --git a/lib/rdl/types/structural.rb b/lib/rdl/types/structural.rb index abc1234..def5678 100644 --- a/lib/rdl/types/structural.rb +++ b/lib/rdl/types/structural.rb @@ -10,7 +10,7 @@ alias :__new__ :new end - def self.new(*methods) + def self.new(methods) t = @@cache[methods] return...
Put this back so test cases pass.
diff --git a/lib/tasks/refresh_rate.rake b/lib/tasks/refresh_rate.rake index abc1234..def5678 100644 --- a/lib/tasks/refresh_rate.rake +++ b/lib/tasks/refresh_rate.rake @@ -12,7 +12,7 @@ c.symbol = k c.symbol = [8364].pack("U") if k == "EUR" c.symbol = [36].pack("U") if k == "USD" - c.symbol = ...
Correct iso code for pound
diff --git a/app/helpers/geocoder_helper.rb b/app/helpers/geocoder_helper.rb index abc1234..def5678 100644 --- a/app/helpers/geocoder_helper.rb +++ b/app/helpers/geocoder_helper.rb @@ -2,7 +2,12 @@ def result_to_html(result) html_options = {} #html_options[:title] = strip_tags(result[:description]) if resul...
Use the bbox to build the URL if there is one.
diff --git a/app/helpers/services_helper.rb b/app/helpers/services_helper.rb index abc1234..def5678 100644 --- a/app/helpers/services_helper.rb +++ b/app/helpers/services_helper.rb @@ -1,2 +1,13 @@ module ServicesHelper + + def css_class_for_status(status) + { + 'outdated' => 'static', + 'retired' => 'def...
Add method to map css_class to service_version helper
diff --git a/app/models/flms/image_layer.rb b/app/models/flms/image_layer.rb index abc1234..def5678 100644 --- a/app/models/flms/image_layer.rb +++ b/app/models/flms/image_layer.rb @@ -1,6 +1,7 @@ module Flms class ImageLayer < Layer - attr_accessible :image, :image_cache + attr_accessible :image, :image_cache...
Store image resolution to proper attributes instead of width/height
diff --git a/test/attribute_assembler_test.rb b/test/attribute_assembler_test.rb index abc1234..def5678 100644 --- a/test/attribute_assembler_test.rb +++ b/test/attribute_assembler_test.rb @@ -12,6 +12,10 @@ should 'act like the overwritten field' do assert @person.name.is_a?(String) end + + shou...
Verify that changing an attribute's value doesn't break anything
diff --git a/BHCDatabase/test/controllers/initiatives_controller_test.rb b/BHCDatabase/test/controllers/initiatives_controller_test.rb index abc1234..def5678 100644 --- a/BHCDatabase/test/controllers/initiatives_controller_test.rb +++ b/BHCDatabase/test/controllers/initiatives_controller_test.rb @@ -7,9 +7,30 @@ lo...
Improve controller tests for an initiative.
diff --git a/rom-sql.gemspec b/rom-sql.gemspec index abc1234..def5678 100644 --- a/rom-sql.gemspec +++ b/rom-sql.gemspec @@ -20,7 +20,7 @@ spec.add_runtime_dependency "sequel", "~> 4.18" spec.add_runtime_dependency "equalizer", "~> 0.0", ">= 0.0.9" - spec.add_runtime_dependency "rom", "~> 0.6.0", ">= 0.6.0" + ...
Fix rom version spec for beta
diff --git a/test/lib/test_batch_result.rb b/test/lib/test_batch_result.rb index abc1234..def5678 100644 --- a/test/lib/test_batch_result.rb +++ b/test/lib/test_batch_result.rb @@ -0,0 +1,40 @@+require 'test_helper' + +class TestBatchResult < Test::Unit::TestCase + + def setup + @result_created = SalesforceBulk::...
Add a complete test for the BatchResult class.
diff --git a/spec/features/likeable_spec.rb b/spec/features/likeable_spec.rb index abc1234..def5678 100644 --- a/spec/features/likeable_spec.rb +++ b/spec/features/likeable_spec.rb @@ -12,20 +12,28 @@ visit post_path(post) end - scenario 'can be liked then unliked' do + scenario 'can be liked' do + ...
Update spec to wait for the link to appear
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -18,6 +18,7 @@ # Install module and dependencies hosts.each do |host| copy_module_to(host, source: proj_root, module_nam...
Add missing dependency for Beaker tests
diff --git a/config/initializers/metrics.rb b/config/initializers/metrics.rb index abc1234..def5678 100644 --- a/config/initializers/metrics.rb +++ b/config/initializers/metrics.rb @@ -5,7 +5,7 @@ if !Rails.env.test? && File.exists?(metrics_config_file) metrics_config = YAML.load_file(metrics_config_file)[Rails.env]...
Increment queue length to reduce request times.
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -1,7 +1,7 @@ Sidekiq.configure_server do |config| - config.redis = { url: "redis://#{REDIS_HOST}:6379/0" } + config.redis = { url: "re...
Fix errant ENV reference to REDIS_HOST This is just a typo, and a cost of not having CI running. Mea Culpa on both counts.
diff --git a/lib/sequel_secure_password.rb b/lib/sequel_secure_password.rb index abc1234..def5678 100644 --- a/lib/sequel_secure_password.rb +++ b/lib/sequel_secure_password.rb @@ -39,8 +39,8 @@ def validate super - errors.add :password_digest, 'is not present' if blank? password_digest - ...
Add errors on :password when digest is missing
diff --git a/db/migrate/20150113184049_change_datetime_timezones.rb b/db/migrate/20150113184049_change_datetime_timezones.rb index abc1234..def5678 100644 --- a/db/migrate/20150113184049_change_datetime_timezones.rb +++ b/db/migrate/20150113184049_change_datetime_timezones.rb @@ -0,0 +1,34 @@+class ChangeDatetimeTimezo...
Fix AR timezone from local to utc
diff --git a/Casks/webstorm-bundled-jdk.rb b/Casks/webstorm-bundled-jdk.rb index abc1234..def5678 100644 --- a/Casks/webstorm-bundled-jdk.rb +++ b/Casks/webstorm-bundled-jdk.rb @@ -0,0 +1,21 @@+cask :v1 => 'webstorm-bundled-jdk' do + version '10.0.1' + sha256 '8b05be91e5c688908d6bcaab4d1f5ead86912d5b33b332a7dd5964dc9...
Add formula for WebStorm with bundled JDK See #879
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -13,7 +13,7 @@ charset = %w{ 2 3 4 6 7 9 a c d e f g h j k m n p q r t v w x y z} token = (0...3).map{ charset.to_a[rand(charset.size)] }.join REDIS.set(token, params[:text]) - REDIS.expire(token, 60) # 3600 secs = 1 hour +...
Change expiration to 10 minutes
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -24,8 +24,7 @@ end configure do - set :session_secret, ENV['SESSION_SECRET'] if ENV['SESSION_SECRET'] - enable :sessions + use Rack::Session::Pool, :secret => (ENV['SESSION_SECRET'] || 'Default secret... Set the SESSION_SECRET en...
Revert the change to the session management : didn't work on AppFog
diff --git a/test/iruby/mime_test.rb b/test/iruby/mime_test.rb index abc1234..def5678 100644 --- a/test/iruby/mime_test.rb +++ b/test/iruby/mime_test.rb @@ -0,0 +1,32 @@+class IRubyTest::MimeTest < IRubyTest::TestBase + sub_test_case("IRuby::Display") do + def test_display_with_mime_type + html = "<b>Bold Text...
Add a test case to examine mime type handling
diff --git a/config.ru b/config.ru index abc1234..def5678 100644 --- a/config.ru +++ b/config.ru @@ -15,7 +15,7 @@ # ensure Redis is running begin - $redis.info + $redis.ping rescue Redis::CannotConnectError => e fail "Cannot connect to redis at #{REDIS_URL}" end
Change $redis.info as connection test to $redis.ping
diff --git a/0_code_wars/squash_the_bugs.rb b/0_code_wars/squash_the_bugs.rb index abc1234..def5678 100644 --- a/0_code_wars/squash_the_bugs.rb +++ b/0_code_wars/squash_the_bugs.rb @@ -0,0 +1,5 @@+# http://www.codewars.com/kata/56f173a35b91399a05000cb7/ +# --- iteration 1 --- +def find_longest(str) + str.split.map(&:...
Add code wars (8) - squash the bugs
diff --git a/upstart.gemspec b/upstart.gemspec index abc1234..def5678 100644 --- a/upstart.gemspec +++ b/upstart.gemspec @@ -16,5 +16,6 @@ gem.require_paths = ['lib'] gem.add_development_dependency 'rake' + gem.add_development_dependency 'rspec' gem.add_runtime_dependency 'ruby-dbus', '>= 0.7.2' end
Add rspec to development dependencies.
diff --git a/lib/data_cycle/course_queue_sorting.rb b/lib/data_cycle/course_queue_sorting.rb index abc1234..def5678 100644 --- a/lib/data_cycle/course_queue_sorting.rb +++ b/lib/data_cycle/course_queue_sorting.rb @@ -2,7 +2,7 @@ module CourseQueueSorting def queue_for(course) - case average_update_time(course) ...
Use longest update time instead of average for queue sorting After the recent changes to the update process — where courses in the 'long' queue skip the time-consuming step of checking for deletions and page moves among all the edited articles — we now have very few courses in the 'long' queue, and the 'medium' queue ...
diff --git a/app/helpers/collection_helper.rb b/app/helpers/collection_helper.rb index abc1234..def5678 100644 --- a/app/helpers/collection_helper.rb +++ b/app/helpers/collection_helper.rb @@ -5,7 +5,9 @@ if column == 'name' value = resource.send(column) - if value.blank? && alternative_value.pr...
Allow a proc as an alternative table cell value.
diff --git a/cookbooks/storm/recipes/undeploy-nimbus.rb b/cookbooks/storm/recipes/undeploy-nimbus.rb index abc1234..def5678 100644 --- a/cookbooks/storm/recipes/undeploy-nimbus.rb +++ b/cookbooks/storm/recipes/undeploy-nimbus.rb @@ -28,7 +28,6 @@ runit_service "stormui" do action :disable - run_restart false ...
Fix to storm cookbook with new runit.
diff --git a/lib/generator/files/generator_cases.rb b/lib/generator/files/generator_cases.rb index abc1234..def5678 100644 --- a/lib/generator/files/generator_cases.rb +++ b/lib/generator/files/generator_cases.rb @@ -23,8 +23,8 @@ Dir.glob(generator_glob, File::FNM_DOTMATCH) end - def exerci...
Rename exercise_name argument for consistency.
diff --git a/test/test_toc_parser.rb b/test/test_toc_parser.rb index abc1234..def5678 100644 --- a/test/test_toc_parser.rb +++ b/test/test_toc_parser.rb @@ -0,0 +1,35 @@+require 'test_helper' +require_relative '../lib/jekyll-toc' + + +class TestTOCParser < Minitest::Test + SIMPLE_HTML = <<EOL +<h1>Simple H1</h1> +<h2>...
Add basic test case for TOC parser tests: - injecting anchor tags - injecting toc container Signed-off-by: Torbjörn Klatt <279a4cf6d7f8da1ddc113bb946b9273d9d938683@torbjoern-klatt.de>
diff --git a/vendor/extensions/clipped-extension/lib/clipped/engine.rb b/vendor/extensions/clipped-extension/lib/clipped/engine.rb index abc1234..def5678 100644 --- a/vendor/extensions/clipped-extension/lib/clipped/engine.rb +++ b/vendor/extensions/clipped-extension/lib/clipped/engine.rb @@ -1,7 +1,7 @@ require 'acts_a...
Remove paperclip and replace with active storage
diff --git a/BHCDatabase/test/models/removed_initiative_funding_test.rb b/BHCDatabase/test/models/removed_initiative_funding_test.rb index abc1234..def5678 100644 --- a/BHCDatabase/test/models/removed_initiative_funding_test.rb +++ b/BHCDatabase/test/models/removed_initiative_funding_test.rb @@ -1,7 +1,33 @@ require 't...
Add model tests for a removed initiative funder.
diff --git a/middleman-breadcrumbs.gemspec b/middleman-breadcrumbs.gemspec index abc1234..def5678 100644 --- a/middleman-breadcrumbs.gemspec +++ b/middleman-breadcrumbs.gemspec @@ -13,7 +13,7 @@ s.license = 'MIT' s.add_runtime_dependency "middleman", '>= 3.3.5' - ['byebug', ['guard', '~> 2.10.5'], 'guard-minite...
Add Rake as dev dependency.
diff --git a/acceptance/setup/pre_suite/70_install_released_puppetdb.rb b/acceptance/setup/pre_suite/70_install_released_puppetdb.rb index abc1234..def5678 100644 --- a/acceptance/setup/pre_suite/70_install_released_puppetdb.rb +++ b/acceptance/setup/pre_suite/70_install_released_puppetdb.rb @@ -1,8 +1,8 @@ # We skip t...
Revert "(maint) make install_puppetdb and install_puppetdb_terminus versions nil"
diff --git a/aggregate_root/lib/aggregate_root/default_apply_strategy.rb b/aggregate_root/lib/aggregate_root/default_apply_strategy.rb index abc1234..def5678 100644 --- a/aggregate_root/lib/aggregate_root/default_apply_strategy.rb +++ b/aggregate_root/lib/aggregate_root/default_apply_strategy.rb @@ -27,7 +27,7 @@ e...
Split Ruby and Proto namespaces. In Proto events we cannot use :: for namespace delimiters. Dot is used instead.
diff --git a/app/controllers/ecm/pictures/backend/pictures_controller.rb b/app/controllers/ecm/pictures/backend/pictures_controller.rb index abc1234..def5678 100644 --- a/app/controllers/ecm/pictures/backend/pictures_controller.rb +++ b/app/controllers/ecm/pictures/backend/pictures_controller.rb @@ -1,4 +1,21 @@ class ...
Add quick fix for columns hash missing columns on picture update.
diff --git a/features/step_definitions/preview_steps.rb b/features/step_definitions/preview_steps.rb index abc1234..def5678 100644 --- a/features/step_definitions/preview_steps.rb +++ b/features/step_definitions/preview_steps.rb @@ -9,7 +9,7 @@ end When(/^I click the preview button$/) do - find_button("Preview").tr...
Simplify statement in cucumber test steps Use click_button instead of find_button().trigger('click')
diff --git a/models/match.rb b/models/match.rb index abc1234..def5678 100644 --- a/models/match.rb +++ b/models/match.rb @@ -11,7 +11,7 @@ end # Custom methods. - attr_reader :round, :number + attr_reader :number, :round def initialize(string) @replay = false
MatchNumber: Swap around ordering of attr_readers. This isn't very important, but it's alphabetical now! :D
diff --git a/db/migrate/20111019013244_postgresql_photos_id_seq_init.rb b/db/migrate/20111019013244_postgresql_photos_id_seq_init.rb index abc1234..def5678 100644 --- a/db/migrate/20111019013244_postgresql_photos_id_seq_init.rb +++ b/db/migrate/20111019013244_postgresql_photos_id_seq_init.rb @@ -0,0 +1,11 @@+class Post...
Set photos_id_seq properly for PostgreSQL (re: recent "MovePhotosToTheirOwnTable" migration, which neglected to do this).
diff --git a/lib/capistrano/ec2/capistrano_monkey_patch.rb b/lib/capistrano/ec2/capistrano_monkey_patch.rb index abc1234..def5678 100644 --- a/lib/capistrano/ec2/capistrano_monkey_patch.rb +++ b/lib/capistrano/ec2/capistrano_monkey_patch.rb @@ -8,7 +8,11 @@ region: fetch(:region), use_iam_profile: fetc...
Add filter to ensure "running" instances Query only for "running" instances, make sure we're not targeting terminated instances.
diff --git a/lib/filter_factory/active_record/condition.rb b/lib/filter_factory/active_record/condition.rb index abc1234..def5678 100644 --- a/lib/filter_factory/active_record/condition.rb +++ b/lib/filter_factory/active_record/condition.rb @@ -26,7 +26,7 @@ end def all(_obj) - fail NotImplemented...
Use single-quoted strings without interpolation.
diff --git a/config/initializers/prisons.rb b/config/initializers/prisons.rb index abc1234..def5678 100644 --- a/config/initializers/prisons.rb +++ b/config/initializers/prisons.rb @@ -2,7 +2,7 @@ Dir["config/prisons/*.yml"].each { |file| prison = YAML.load_file(file) - unless Rails.env.production? + if ENV['GSI...
Send to maildrop in test or based on env This was being selected for everything but production, but preprod, of course, runs in production mode, so it wasn't working. This fixes that.
diff --git a/lib/homepage_publisher.rb b/lib/homepage_publisher.rb index abc1234..def5678 100644 --- a/lib/homepage_publisher.rb +++ b/lib/homepage_publisher.rb @@ -19,13 +19,14 @@ ], "publishing_app": "frontend", "rendering_app": "frontend", - "public_updated_at": Time.zone.now.iso8601 + ...
Stop sending update_type on publish Sending it on publish has been deprecated in favour of including it when sending a put content.
diff --git a/lib/manageiq/ui/engine.rb b/lib/manageiq/ui/engine.rb index abc1234..def5678 100644 --- a/lib/manageiq/ui/engine.rb +++ b/lib/manageiq/ui/engine.rb @@ -1,6 +1,7 @@ module Manageiq module Ui class Engine < ::Rails::Engine + config.autoload_paths << File.expand_path(File.join('..', '..', '..', '...
Add autoload path for controller mixins.
diff --git a/lib/mongo_oplog_backup.rb b/lib/mongo_oplog_backup.rb index abc1234..def5678 100644 --- a/lib/mongo_oplog_backup.rb +++ b/lib/mongo_oplog_backup.rb @@ -19,5 +19,5 @@ Command.logger = log end - @@log = Logger.new STDOUT + MongoOplogBackup.log = Logger.new STDOUT end
Fix command output not being logged.
diff --git a/XCDLumberjackNSLogger.podspec b/XCDLumberjackNSLogger.podspec index abc1234..def5678 100644 --- a/XCDLumberjackNSLogger.podspec +++ b/XCDLumberjackNSLogger.podspec @@ -1,16 +1,17 @@ Pod::Spec.new do |s| - s.name = "XCDLumberjackNSLogger" - s.version = "1.0.2" - s.summary ...
Add tvOS deployment target in podspec
diff --git a/lib/pg_search/document.rb b/lib/pg_search/document.rb index abc1234..def5678 100644 --- a/lib/pg_search/document.rb +++ b/lib/pg_search/document.rb @@ -1,5 +1,4 @@ require "logger" -require "pg_search/scope" module PgSearch class Document < ActiveRecord::Base
Remove require that is obviated by autoload
diff --git a/lib/rollbar/truncation/strings_strategy.rb b/lib/rollbar/truncation/strings_strategy.rb index abc1234..def5678 100644 --- a/lib/rollbar/truncation/strings_strategy.rb +++ b/lib/rollbar/truncation/strings_strategy.rb @@ -14,11 +14,12 @@ def call(payload) result = nil + new_payload = ...
Clone payload just once in StringsStrategy.
diff --git a/app/actions/reindex_everything.rb b/app/actions/reindex_everything.rb index abc1234..def5678 100644 --- a/app/actions/reindex_everything.rb +++ b/app/actions/reindex_everything.rb @@ -13,7 +13,7 @@ ids << document.id rescue Exception => e counter += 1 - LifecycleMailer.except...
Disable email notifications for reindexing.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -2,16 +2,4 @@ def facet_options(form, facet) form.object.facet_options(facet) end - - def state(document) - st...
Remove unused methods in ApplicationHelper This was moved to the StateHelper
diff --git a/app/inputs/carnival_enum_input.rb b/app/inputs/carnival_enum_input.rb index abc1234..def5678 100644 --- a/app/inputs/carnival_enum_input.rb +++ b/app/inputs/carnival_enum_input.rb @@ -1,6 +1,6 @@ class CarnivalEnumInput < SimpleForm::Inputs::CollectionSelectInput - def input(wrapper_options) + def inpu...
Fix CarnivalEnumInput default nil parameter value in input method
diff --git a/app/models/class_list_snapshot.rb b/app/models/class_list_snapshot.rb index abc1234..def5678 100644 --- a/app/models/class_list_snapshot.rb +++ b/app/models/class_list_snapshot.rb @@ -9,9 +9,14 @@ def self.snapshot_all_workspaces snapshots_taken = [] + puts "ClassListSnapshot.snapshot_all_works...
Add logging for class list snapshot
diff --git a/app/services/csv_generator.rb b/app/services/csv_generator.rb index abc1234..def5678 100644 --- a/app/services/csv_generator.rb +++ b/app/services/csv_generator.rb @@ -1,6 +1,6 @@ class CsvGenerator def to_csv(submissions) - column_names = Submission.column_names + column_names = ["full_name", "em...
Save only user's name and email to genrated csv files
diff --git a/app/use_cases/clone_repository.rb b/app/use_cases/clone_repository.rb index abc1234..def5678 100644 --- a/app/use_cases/clone_repository.rb +++ b/app/use_cases/clone_repository.rb @@ -26,6 +26,7 @@ add_pre_condition(CommitsRequired.new(repository)) add_pre_condition(RepositoryRateLimiting.new(user...
Validate repository clones as well
diff --git a/app/models/permission.rb b/app/models/permission.rb index abc1234..def5678 100644 --- a/app/models/permission.rb +++ b/app/models/permission.rb @@ -1,4 +1,6 @@ class Permission < ActiveRecord::Base + outpost_model + #------------------- # Association has_many :user_permissions
Make Permissions an outpost model
diff --git a/spec/strategies/completion_spec.rb b/spec/strategies/completion_spec.rb index abc1234..def5678 100644 --- a/spec/strategies/completion_spec.rb +++ b/spec/strategies/completion_spec.rb @@ -4,7 +4,7 @@ -> do session. run_command('autoload compinit && compinit'). - run_command('_foo...
Add an extra completion to better exercise choosing first
diff --git a/app/controllers/enrollment_semesters_controller.rb b/app/controllers/enrollment_semesters_controller.rb index abc1234..def5678 100644 --- a/app/controllers/enrollment_semesters_controller.rb +++ b/app/controllers/enrollment_semesters_controller.rb @@ -1,4 +1,6 @@ class EnrollmentSemestersController < Appli...
Add authorization to enrollment semesters Change-Id: I36077e28b1a55fa0b4b3105477aa9977d0f271a5
diff --git a/app/presenters/statistics_filter_json_presenter.rb b/app/presenters/statistics_filter_json_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/statistics_filter_json_presenter.rb +++ b/app/presenters/statistics_filter_json_presenter.rb @@ -1,4 +1,9 @@ class StatisticsFilterJsonPresenter < Docum...
Set the atom and email URLs for the statistics filter
diff --git a/app/views/events/team_scoreboards/show.xml.builder b/app/views/events/team_scoreboards/show.xml.builder index abc1234..def5678 100644 --- a/app/views/events/team_scoreboards/show.xml.builder +++ b/app/views/events/team_scoreboards/show.xml.builder @@ -4,7 +4,8 @@ @team_ranking.ranking.each_with_index do ...
Move members to dedicated field
diff --git a/app/controllers/regions_controller.rb b/app/controllers/regions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/regions_controller.rb +++ b/app/controllers/regions_controller.rb @@ -1,6 +1,4 @@ class RegionsController < ApplicationController - # Include Inherited Resources behaviour - i...
Remove inherited resources from regions controller
diff --git a/app/overrides/contact_us_in_header.rb b/app/overrides/contact_us_in_header.rb index abc1234..def5678 100644 --- a/app/overrides/contact_us_in_header.rb +++ b/app/overrides/contact_us_in_header.rb @@ -1,5 +1,5 @@ Deface::Override.new(:virtual_path => "spree/shared/_main_nav_bar", :name...
Fix override positioning and bootstrap classes
diff --git a/spec/conversion_protocol_spec.rb b/spec/conversion_protocol_spec.rb index abc1234..def5678 100644 --- a/spec/conversion_protocol_spec.rb +++ b/spec/conversion_protocol_spec.rb @@ -1,37 +1,40 @@ require 'spec_helper' describe 'Conversion protocol' do - it "converts a string to a BigDecimal" do - '42'...
Reorganize specs for conversion protocol
diff --git a/spec/factories/delivery_links.rb b/spec/factories/delivery_links.rb index abc1234..def5678 100644 --- a/spec/factories/delivery_links.rb +++ b/spec/factories/delivery_links.rb @@ -2,7 +2,7 @@ FactoryGirl.define do factory :delivery_link do - delivery_id 1 - link_id 1 + delivery + link e...
Fix up tests after adding foreign key constraints
diff --git a/app/services/note_creation_service.rb b/app/services/note_creation_service.rb index abc1234..def5678 100644 --- a/app/services/note_creation_service.rb +++ b/app/services/note_creation_service.rb @@ -39,6 +39,6 @@ usernames = UsernameParser.parse(note.note) return [] if usernames.empty? - sto...
Remove more verbose use of all
diff --git a/app/validators/namespace_validator.rb b/app/validators/namespace_validator.rb index abc1234..def5678 100644 --- a/app/validators/namespace_validator.rb +++ b/app/validators/namespace_validator.rb @@ -24,6 +24,7 @@ projects public repository + robots.txt s search services
Add `robots.txt` to the list of reserved namespaces
diff --git a/lib/generators/templates/keeper.rb b/lib/generators/templates/keeper.rb index abc1234..def5678 100644 --- a/lib/generators/templates/keeper.rb +++ b/lib/generators/templates/keeper.rb @@ -13,13 +13,16 @@ # ES256 - ECDSA using P-256 and SHA-256 # ES384 - ECDSA using P-384 and SHA-384 # ES512 -...
Fix issues with install template being out of date
diff --git a/lib/octocatalog-diff/facts/yaml.rb b/lib/octocatalog-diff/facts/yaml.rb index abc1234..def5678 100644 --- a/lib/octocatalog-diff/facts/yaml.rb +++ b/lib/octocatalog-diff/facts/yaml.rb @@ -21,8 +21,18 @@ fact_file_data = fact_file_string.split(/\n/) fact_file_data[0] = '---' if fact_file_da...
Allow unstructured facts in YAML (e.g. facter output)
diff --git a/lib/similarweb/estimated_visits.rb b/lib/similarweb/estimated_visits.rb index abc1234..def5678 100644 --- a/lib/similarweb/estimated_visits.rb +++ b/lib/similarweb/estimated_visits.rb @@ -1,4 +1,4 @@-require 'Date' +require 'date' module Similarweb module EstimatedVisits def estimated_visits(domai...
Use library date with downcase d
diff --git a/lib/sunat/models/payment_amount.rb b/lib/sunat/models/payment_amount.rb index abc1234..def5678 100644 --- a/lib/sunat/models/payment_amount.rb +++ b/lib/sunat/models/payment_amount.rb @@ -22,7 +22,7 @@ end def build_xml(xml, tag_name) - xml[xml_namespace].send(tag_name, { currencyId: cu...
Fix to set the right tag.
diff --git a/src/org/jruby/duby/duby_command.rb b/src/org/jruby/duby/duby_command.rb index abc1234..def5678 100644 --- a/src/org/jruby/duby/duby_command.rb +++ b/src/org/jruby/duby/duby_command.rb @@ -0,0 +1,17 @@+require 'java' +require 'duby' + +java_package "org.jruby.duby" +class DubyCommand + java_signature "void...
Add a DubyCommand class to be the main class for Duby's executable jar.
diff --git a/zipline.gemspec b/zipline.gemspec index abc1234..def5678 100644 --- a/zipline.gemspec +++ b/zipline.gemspec @@ -15,7 +15,7 @@ gem.require_paths = ["lib"] gem.version = Zipline::VERSION - gem.add_dependency 'zip_tricks', ['>= 4.0.0', '<= 5.0.0'] + gem.add_dependency 'zip_tricks', ['>= 4.2.1',...
Update the gemspec to use zip_tricks version with uniquify duplicate filenames
diff --git a/spec/ruby-progressbar/calculators/length_calculator_spec.rb b/spec/ruby-progressbar/calculators/length_calculator_spec.rb index abc1234..def5678 100644 --- a/spec/ruby-progressbar/calculators/length_calculator_spec.rb +++ b/spec/ruby-progressbar/calculators/length_calculator_spec.rb @@ -4,7 +4,9 @@ class ...
Tests: Fix ruby version check on JRuby
diff --git a/pt_online_migration.gemspec b/pt_online_migration.gemspec index abc1234..def5678 100644 --- a/pt_online_migration.gemspec +++ b/pt_online_migration.gemspec @@ -4,7 +4,7 @@ require 'pt_online_migration/version' Gem::Specification.new do |spec| - spec.name = "pt_online_migration" + spec.name ...
Fix gem name to match readme
diff --git a/test/test_epub.rb b/test/test_epub.rb index abc1234..def5678 100644 --- a/test/test_epub.rb +++ b/test/test_epub.rb @@ -0,0 +1,16 @@+require_relative 'helper' +require 'epub/book' + +class TestEUPB < Test::Unit::TestCase + def setup + @file = 'test/fixtures/book.epub' + end + + def test_parse + bo...
Add test for EPUB module
diff --git a/db/migrate/20160912160750_change_retires_on_to_datetime.rb b/db/migrate/20160912160750_change_retires_on_to_datetime.rb index abc1234..def5678 100644 --- a/db/migrate/20160912160750_change_retires_on_to_datetime.rb +++ b/db/migrate/20160912160750_change_retires_on_to_datetime.rb @@ -0,0 +1,21 @@+class Chan...
Migrate retires_on and retirement_last_warn to datetime https://bugzilla.redhat.com/show_bug.cgi?id=1316632
diff --git a/lib/chef/knife/brightbox_zone_list.rb b/lib/chef/knife/brightbox_zone_list.rb index abc1234..def5678 100644 --- a/lib/chef/knife/brightbox_zone_list.rb +++ b/lib/chef/knife/brightbox_zone_list.rb @@ -0,0 +1,42 @@+# +# Author:: Seth Chisamore (<schisamo@opscode.com>) +# Copyright:: Copyright (c) 2011 Opscod...
Add `knife zone list` subcommand Refs #10
diff --git a/doc/ex/opacity.rb b/doc/ex/opacity.rb index abc1234..def5678 100644 --- a/doc/ex/opacity.rb +++ b/doc/ex/opacity.rb @@ -33,6 +33,5 @@ gc.text( 90,15, '"100%"') gc.draw(canvas) -canvas.matte = false -canvas.write("opacity.gif") +canvas.write("opacity.png") exit
Reset matte channel for better rendering
diff --git a/Casks/biicode.rb b/Casks/biicode.rb index abc1234..def5678 100644 --- a/Casks/biicode.rb +++ b/Casks/biicode.rb @@ -5,7 +5,7 @@ # amazonaws is the official download host per the vendor homepage url "https://s3.amazonaws.com/biibinaries/release/#{version}/bii-macos-64_#{version.gsub('.', '_')}.pkg" ...
Fix homepage to use SSL in Biicode Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/Casks/charles.rb b/Casks/charles.rb index abc1234..def5678 100644 --- a/Casks/charles.rb +++ b/Casks/charles.rb @@ -1,7 +1,7 @@ class Charles < Cask - url 'http://www.charlesproxy.com/assets/release/3.9/charles-proxy-3.9-applejava.dmg' + url 'http://www.charlesproxy.com/assets/release/3.9.1/charles-proxy...
Update Charles to version 3.9.1
diff --git a/lib/hpcloud/commands/account/setup.rb b/lib/hpcloud/commands/account/setup.rb index abc1234..def5678 100644 --- a/lib/hpcloud/commands/account/setup.rb +++ b/lib/hpcloud/commands/account/setup.rb @@ -11,14 +11,14 @@ set up your account. Optionally you can specify your own endpoint to access, but in m...
Fix DEVEX-973: Match prompts to the labels used in the console.