diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/db/migrate/20110109130532_devise_create_users.rb b/db/migrate/20110109130532_devise_create_users.rb index abc1234..def5678 100644 --- a/db/migrate/20110109130532_devise_create_users.rb +++ b/db/migrate/20110109130532_devise_create_users.rb @@ -4,12 +4,10 @@ t.string :name t.string :login ...
Revert "Revert "Removed devise oauth in migration"" This reverts commit 66eaabd008c382a0f4e5bf34a48f89fddd1416f6.
diff --git a/lib/infrataster/rspec.rb b/lib/infrataster/rspec.rb index abc1234..def5678 100644 --- a/lib/infrataster/rspec.rb +++ b/lib/infrataster/rspec.rb @@ -6,23 +6,23 @@ RSpec.configure do |config| config.include Infrataster::Helpers::RSpecHelper + fetch_current_example = RSpec.respond_to?(:current_example) ...
Change how to get current example that return nil in ver 2.14.x
diff --git a/lib/integrity/project.rb b/lib/integrity/project.rb index abc1234..def5678 100644 --- a/lib/integrity/project.rb +++ b/lib/integrity/project.rb @@ -7,9 +7,9 @@ property :id, Integer, :serial => true property :name, String, :nullable => false - property :uri, URI, :nulla...
Allow longer uris and commands in Project
diff --git a/lib/split/cli/session.rb b/lib/split/cli/session.rb index abc1234..def5678 100644 --- a/lib/split/cli/session.rb +++ b/lib/split/cli/session.rb @@ -29,7 +29,7 @@ def config_split! Split.redis = options.fetch :redis_url, ENV.fetch('REDIS_URL', 'localhost:6379') - Split.redis.namespac...
Add a default namespace that isn’t nil
diff --git a/lib/tasks/ember-cli.rake b/lib/tasks/ember-cli.rake index abc1234..def5678 100644 --- a/lib/tasks/ember-cli.rake +++ b/lib/tasks/ember-cli.rake @@ -1,6 +1,6 @@-namespace "ember-cli" do +namespace :ember do desc "Runs `ember build` for each App" - task compile: :install_dependencies do + task compile: ...
Rename rake namespace to ember
diff --git a/natero/lib/natero/base.rb b/natero/lib/natero/base.rb index abc1234..def5678 100644 --- a/natero/lib/natero/base.rb +++ b/natero/lib/natero/base.rb @@ -15,7 +15,10 @@ end def self.endpoint_path - raise NotImplementedError.new('This method needs to be overridden in a child class.') + raise NotI...
Add better error message when a child class doesn't implement endpoint_path.
diff --git a/app/controllers/concerns/sufia/contact_form_controller_behavior.rb b/app/controllers/concerns/sufia/contact_form_controller_behavior.rb index abc1234..def5678 100644 --- a/app/controllers/concerns/sufia/contact_form_controller_behavior.rb +++ b/app/controllers/concerns/sufia/contact_form_controller_behavio...
Refactor contact form to call deliver. the contact form is a MailForm object and doesn't support deliver_now.
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -1,5 +1,3 @@ require 'social_stream' SocialStream::Rails::Common.inflections - -AssetBundler.paths += Array(File.join(File.dirname(__FILE__), 'app', 'assets'))
Remove obsolete reference to AssetBundler
diff --git a/install.rb b/install.rb index abc1234..def5678 100644 --- a/install.rb +++ b/install.rb @@ -24,6 +24,7 @@ else policy :provision, :roles => :provision do NODE_CONFIG['packages'].each do |package, options| + options ||= {} requires package, options.symbolize_keys end ...
Fix when options is nil
diff --git a/config/default_config.rb b/config/default_config.rb index abc1234..def5678 100644 --- a/config/default_config.rb +++ b/config/default_config.rb @@ -9,4 +9,4 @@ CONFIG['url_base'] ||= 'http://' + CONFIG['server_host'] # Set secure to false by default due to ssl requirement -CONFIG['secure'] = 'false' +CO...
Correct way to define default. --HG-- branch : 3.2.0-release
diff --git a/spec/acceptance/support/selenium_find_patch.rb b/spec/acceptance/support/selenium_find_patch.rb index abc1234..def5678 100644 --- a/spec/acceptance/support/selenium_find_patch.rb +++ b/spec/acceptance/support/selenium_find_patch.rb @@ -0,0 +1,15 @@+# REMOVE THIS FILE WHEN +# http://code.google.com/p/seleni...
Patch for Selenium intermittent errors
diff --git a/spec/support/fixtures_generation/prover_output_generator.rb b/spec/support/fixtures_generation/prover_output_generator.rb index abc1234..def5678 100644 --- a/spec/support/fixtures_generation/prover_output_generator.rb +++ b/spec/support/fixtures_generation/prover_output_generator.rb @@ -3,7 +3,7 @@ module ...
Remove MathServe from prover output generator.
diff --git a/rome.rb b/rome.rb index abc1234..def5678 100644 --- a/rome.rb +++ b/rome.rb @@ -1,10 +1,10 @@ class Rome < Formula desc "A shared cache tool for Carthage on S3" homepage "https://github.com/blender/Rome" - url "https://github.com/blender/Rome/releases/download/v0.12.0.31/rome.zip" - sha256 "3ad1d0f...
Update Rome formula to v0.13.0.33
diff --git a/core/app/models/spree/wallet/add_payment_sources_to_wallet.rb b/core/app/models/spree/wallet/add_payment_sources_to_wallet.rb index abc1234..def5678 100644 --- a/core/app/models/spree/wallet/add_payment_sources_to_wallet.rb +++ b/core/app/models/spree/wallet/add_payment_sources_to_wallet.rb @@ -13,7 +13,11...
Update add_after_order_complete for non-PaymentSource sources For any stores using legacy payment sources that do not inherit from PaymentSource.
diff --git a/app/controllers/about_controller.rb b/app/controllers/about_controller.rb index abc1234..def5678 100644 --- a/app/controllers/about_controller.rb +++ b/app/controllers/about_controller.rb @@ -5,7 +5,7 @@ end def projects - @projects = Project.all.sort_by { |p| p.name.downcase } + @projects = P...
Use scope and includes for projects
diff --git a/app/controllers/blogs_controller.rb b/app/controllers/blogs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/blogs_controller.rb +++ b/app/controllers/blogs_controller.rb @@ -1,5 +1,6 @@ class BlogsController < ApplicationController before_filter :authenticate_user! + before_filter :ge...
Update Blog Controller for update Actions Update the Blog controller to include all corresponding actions to update a Blog.
diff --git a/google_analytics.gemspec b/google_analytics.gemspec index abc1234..def5678 100644 --- a/google_analytics.gemspec +++ b/google_analytics.gemspec @@ -1,13 +1,13 @@ spec = Gem::Specification.new do |s| s.name = 'google_analytics' - s.version = '1.1' - s.date = "2008-11-11" + s.version ...
Bump the version, tweak the summary and set the correct home page. Signed-off-by: Collective Idea <59bd0a3ff43b32849b319e645d4798d8a5d1e889@collectiveidea.com>
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -16,6 +16,9 @@ def show find_user + if (current_user != @user) || @user.blank? + redirect_to root_p...
Create if statement that redirects logged in users home if they try to access a profile page that isn't theirs
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,6 +1,13 @@ class UsersController < ApplicationController def create + @user = User.new(user_params) + ...
Make create controller for Users
diff --git a/app/models/riews/filter_criteria.rb b/app/models/riews/filter_criteria.rb index abc1234..def5678 100644 --- a/app/models/riews/filter_criteria.rb +++ b/app/models/riews/filter_criteria.rb @@ -7,7 +7,8 @@ 1 => 'NULL', 2 => 'NOT NULL', 3 => '=', - 4 => 'IN' + ...
Add LIKE operator to query
diff --git a/app/controllers/fae/setup_controller.rb b/app/controllers/fae/setup_controller.rb index abc1234..def5678 100644 --- a/app/controllers/fae/setup_controller.rb +++ b/app/controllers/fae/setup_controller.rb @@ -1,6 +1,7 @@ module Fae class SetupController < ActionController::Base + before_action :chec...
Raise exception if roles do not exist upon first user creation
diff --git a/lib/colossus/configuration.rb b/lib/colossus/configuration.rb index abc1234..def5678 100644 --- a/lib/colossus/configuration.rb +++ b/lib/colossus/configuration.rb @@ -9,7 +9,7 @@ def initialize @ttl = 10 @seconds_before_ttl_check = 2 - @engine = Colossus::Engine::Memory + @engi...
Replace default engine with ThreadSafe
diff --git a/app/models/comment/callbacks.rb b/app/models/comment/callbacks.rb index abc1234..def5678 100644 --- a/app/models/comment/callbacks.rb +++ b/app/models/comment/callbacks.rb @@ -1,6 +1,6 @@ class Comment - def before_save + def before_create self.target ||= project set_status_and_assigned if ...
Revert "Task should assign target, status and assigned on save, not only on create" This reverts commit 6fab90c877ffa0f6f382a34603cb84705ff4a07c.
diff --git a/lib/jekyll-github-metadata.rb b/lib/jekyll-github-metadata.rb index abc1234..def5678 100644 --- a/lib/jekyll-github-metadata.rb +++ b/lib/jekyll-github-metadata.rb @@ -30,6 +30,10 @@ @values ||= Hash.new end + def clear_values! + @values = Hash.new + end + def to_h ...
Add a way to clear out all the values.
diff --git a/mrblib/vec.rb b/mrblib/vec.rb index abc1234..def5678 100644 --- a/mrblib/vec.rb +++ b/mrblib/vec.rb @@ -2,6 +2,7 @@ # Vec クラスのための Array クラス拡張メソッド # class Array + def to_v if size == 0 Vec::new 0.0, 0.0, 0.0 @@ -13,5 +14,14 @@ Vec::new x, y, z end end + + def x; (self[0] ||= ...
Add x, y and x method to Array class.
diff --git a/db/migrate/20110724140336_add_name_scope_sequence_index_on_slugs.rb b/db/migrate/20110724140336_add_name_scope_sequence_index_on_slugs.rb index abc1234..def5678 100644 --- a/db/migrate/20110724140336_add_name_scope_sequence_index_on_slugs.rb +++ b/db/migrate/20110724140336_add_name_scope_sequence_index_on_...
Index on slugs without type - doesn't seem to be used in same clause when looking up scoped slugs.
diff --git a/app/tasks/create_server_task.rb b/app/tasks/create_server_task.rb index abc1234..def5678 100644 --- a/app/tasks/create_server_task.rb +++ b/app/tasks/create_server_task.rb @@ -11,11 +11,11 @@ def process @server = @wizard.create_server - MonitorServer.perform_in(MonitorServer::POLL_INTERVAL.sec...
Monitor server only if build succeeded
diff --git a/test/unit/helpers/filter_routes_helper_test.rb b/test/unit/helpers/filter_routes_helper_test.rb index abc1234..def5678 100644 --- a/test/unit/helpers/filter_routes_helper_test.rb +++ b/test/unit/helpers/filter_routes_helper_test.rb @@ -1,7 +1,7 @@ require 'test_helper' class FilterRoutesHelperTest < Act...
Remove broken test to fix build. This broke the build because this whole file wasn't being included in builds until I renamed the file with a `_test.rb` suffix. The `detailed_guides_filter_path` was actually removed two months ago: 5b2498f841af1dd1fc88015c2cf3da23b0cb7a57
diff --git a/lib/rubycritic/cli/options.rb b/lib/rubycritic/cli/options.rb index abc1234..def5678 100644 --- a/lib/rubycritic/cli/options.rb +++ b/lib/rubycritic/cli/options.rb @@ -24,9 +24,9 @@ file_hash = file_options.to_h argv_hash = argv_options.to_h - file_hash.merge(argv_hash) { |_, file...
Switch to do-end style block to make rubocop happy.
diff --git a/lib/specjour/socket_helper.rb b/lib/specjour/socket_helper.rb index abc1234..def5678 100644 --- a/lib/specjour/socket_helper.rb +++ b/lib/specjour/socket_helper.rb @@ -9,11 +9,11 @@ end def hostname - @hostname ||= Socket.gethostname + Socket.gethostname end def local_ip - ...
Fix rsync "file has vanished" bug By not caching the hostname and ip address, a specjour listener can be left running and will function correctly as it moves from one network (ip) to another. This was a very annoying problem, and thus, a significant fix.
diff --git a/test/integration/help_cookies_test.rb b/test/integration/help_cookies_test.rb index abc1234..def5678 100644 --- a/test/integration/help_cookies_test.rb +++ b/test/integration/help_cookies_test.rb @@ -0,0 +1,23 @@+require "integration_test_helper" + +class HelpCookiesTest < ActionDispatch::IntegrationTest +...
Add integration test for /help/cookies
diff --git a/lib/user_wiki_macro/macros.rb b/lib/user_wiki_macro/macros.rb index abc1234..def5678 100644 --- a/lib/user_wiki_macro/macros.rb +++ b/lib/user_wiki_macro/macros.rb @@ -16,10 +16,21 @@ user = User.find_by_login(username) return nil unless user - content_tag :span, class: "user-wiki-m...
Handle situations without user avatars In case the user has no avatar, simple print the linked login
diff --git a/lib/amf_socket/rpc_request.rb b/lib/amf_socket/rpc_request.rb index abc1234..def5678 100644 --- a/lib/amf_socket/rpc_request.rb +++ b/lib/amf_socket/rpc_request.rb @@ -28,8 +28,6 @@ object = {} object[:type] = 'rpcResponse' object[:response] = {} - object[:response][:command] = command - ...
Remove unused data from rpc responses.
diff --git a/lib/mspec/runner/exception.rb b/lib/mspec/runner/exception.rb index abc1234..def5678 100644 --- a/lib/mspec/runner/exception.rb +++ b/lib/mspec/runner/exception.rb @@ -34,10 +34,9 @@ end def backtrace - @backtrace_filter ||= MSpecScript.config[:backtrace_filter] + @backtrace_filter ||= MSpecSc...
Add a default backtrace_filter in MSpec * Useful when run without a .mspec config file.
diff --git a/lib/feed2email.rb b/lib/feed2email.rb index abc1234..def5678 100644 --- a/lib/feed2email.rb +++ b/lib/feed2email.rb @@ -4,7 +4,7 @@ require 'feed2email/logger' module Feed2Email - CONFIG_DIR = File.expand_path('~/.feed2email') + CONFIG_DIR = File.join(ENV['HOME'], '.feed2email') def self.config ...
Use ENV['HOME'] instead of expanding ~
diff --git a/lib/tasks/refresh_tokens.rake b/lib/tasks/refresh_tokens.rake index abc1234..def5678 100644 --- a/lib/tasks/refresh_tokens.rake +++ b/lib/tasks/refresh_tokens.rake @@ -1,9 +1,9 @@ desc "refresh access tokens for google accounts" task :refresh_tokens => :environment do #Google - Authorization...
Correct refresh access token task. Old one was copypasta
diff --git a/lib/interactor.rb b/lib/interactor.rb index abc1234..def5678 100644 --- a/lib/interactor.rb +++ b/lib/interactor.rb @@ -5,7 +5,6 @@ def self.included(base) base.class_eval do extend ClassMethods - include InstanceMethods attr_reader :context end @@ -17,39 +16,37 @@ end ...
Remove excess module for instance methods
diff --git a/app/models/dessert_location.rb b/app/models/dessert_location.rb index abc1234..def5678 100644 --- a/app/models/dessert_location.rb +++ b/app/models/dessert_location.rb @@ -11,4 +11,16 @@ def self.skip_check_attributes ["visited"] end + + def self.category_split_button_link + Rails.application...
Add map button to dessert locations
diff --git a/app/controllers/api/v1/students_controller.rb b/app/controllers/api/v1/students_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/students_controller.rb +++ b/app/controllers/api/v1/students_controller.rb @@ -9,7 +9,10 @@ if registration.valid? registration.save - r...
Remove password from registration response There does not seem to be a need for sending the password back in plain text [#135156275]
diff --git a/lib/squeezable.rb b/lib/squeezable.rb index abc1234..def5678 100644 --- a/lib/squeezable.rb +++ b/lib/squeezable.rb @@ -3,9 +3,8 @@ def squeeze result = [] previous = nil - iterator = self.each - loop do - a = iterator.next + for i in (0...self.length) + a = self[i] re...
Use for loop instead of iterator for Squeezable.
diff --git a/refinerycms-news.gemspec b/refinerycms-news.gemspec index abc1234..def5678 100644 --- a/refinerycms-news.gemspec +++ b/refinerycms-news.gemspec @@ -13,7 +13,7 @@ s.files = `git ls-files`.split("\n") s.test_files = `git ls-files -- spec/*`.split("\n") - s.add_dependency 'refine...
Use non dev version for Refinery extension versions.
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -3,9 +3,9 @@ namespace :db do desc 'Bootstrap the database for the current RAILS_ENV (create, setup & seed if the database does not exist)' task bootstrap: :environment do + Rake:...
Fix database setup in dev-env The postgres image does not come with pre-configured osem databases per environment. Calling db:create doesn't hurt if the databases already exist, so let's do it every time we bootstrap.
diff --git a/hero_mapper/app/controllers/heroes_controller.rb b/hero_mapper/app/controllers/heroes_controller.rb index abc1234..def5678 100644 --- a/hero_mapper/app/controllers/heroes_controller.rb +++ b/hero_mapper/app/controllers/heroes_controller.rb @@ -13,19 +13,11 @@ # Will need to offset by 100 every call, 15...
Create condition to only save to database when there are new entries
diff --git a/redic.gemspec b/redic.gemspec index abc1234..def5678 100644 --- a/redic.gemspec +++ b/redic.gemspec @@ -6,9 +6,10 @@ s.summary = "Lightweight Redis Client" s.description = "Lightweight Redis Client" s.authors = ["Michel Martens", "Cyril David"] - s.email = ["m...
Update cyx email, and the dependencies.
diff --git a/Casks/protege.rb b/Casks/protege.rb index abc1234..def5678 100644 --- a/Casks/protege.rb +++ b/Casks/protege.rb @@ -2,7 +2,7 @@ version '5.0.0' sha256 'cc5dc98cb41a59fb86a710a61249437f1f9d1b4b79eb989b1ff5055df0722540' - # https://github.com/protegeproject/protege-distribution was verified as offici...
Fix `url` stanza comment for Protégé.
diff --git a/spec/decorators/app_decorator_spec.rb b/spec/decorators/app_decorator_spec.rb index abc1234..def5678 100644 --- a/spec/decorators/app_decorator_spec.rb +++ b/spec/decorators/app_decorator_spec.rb @@ -21,4 +21,18 @@ subject.participating_brigade_links.should == '' end end + + describe '#pictu...
Add more test coverage for app decorator's picture_gallary method
diff --git a/spec/features/manage_comments_spec.rb b/spec/features/manage_comments_spec.rb index abc1234..def5678 100644 --- a/spec/features/manage_comments_spec.rb +++ b/spec/features/manage_comments_spec.rb @@ -1,3 +1,4 @@+# encoding: UTF-8 require 'acceptance_helper' feature 'Managing comments' do
Fix specs for ruby 1.9.
diff --git a/spec/processor/data_processor_spec.rb b/spec/processor/data_processor_spec.rb index abc1234..def5678 100644 --- a/spec/processor/data_processor_spec.rb +++ b/spec/processor/data_processor_spec.rb @@ -0,0 +1,20 @@+require 'spec_helper_lite' +require 'processor/data_processor' + +describe Processor::DataProc...
Add missing tests to DataProcessor
diff --git a/Formula/gsoap.rb b/Formula/gsoap.rb index abc1234..def5678 100644 --- a/Formula/gsoap.rb +++ b/Formula/gsoap.rb @@ -0,0 +1,17 @@+require 'formula' + +class Gsoap < Formula + url 'http://downloads.sourceforge.net/project/gsoap2/gSOAP/gsoap_2.8.6.zip' + homepage 'http://www.cs.fsu.edu/~engelen/soap.html' +...
Add gSOAP formula, version 2.8.6 Closes Homebrew/homebrew#6210. Signed-off-by: Mike McQuaid <a17fed27eaa842282862ff7c1b9c8395a26ac320@mikemcquaid.com>
diff --git a/hephaestus/lib/tasks/process.rake b/hephaestus/lib/tasks/process.rake index abc1234..def5678 100644 --- a/hephaestus/lib/tasks/process.rake +++ b/hephaestus/lib/tasks/process.rake @@ -31,6 +31,12 @@ process(MentionsFinderTask) end + desc 'Run indexer task for all documents available' + task inde...
[hephaestus] Add indexer task to cli tasks
diff --git a/spec/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb b/spec/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb index abc1234..def5678 100644 --- a/spec/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb +++ b/spec/puppet-lint/plugins/check_strings/pu...
Fix the spec name again
diff --git a/spec/support/utilities.rb b/spec/support/utilities.rb index abc1234..def5678 100644 --- a/spec/support/utilities.rb +++ b/spec/support/utilities.rb @@ -2,10 +2,10 @@ match do |events| events.select { |event| event.name.to_s == expected.to_s }.any? end - failure_message_for_should do |events| + ...
Convert specs to RSpec 3.4.4 syntax with Transpec This conversion is done by Transpec 3.2.1 with the following command: transpec * 1 conversion from: failure_message_for_should { } to: failure_message { } * 1 conversion from: failure_message_for_should_not { } to: failure_message_when_negated...
diff --git a/messaging.gemspec b/messaging.gemspec index abc1234..def5678 100644 --- a/messaging.gemspec +++ b/messaging.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'messaging' - s.version = '0.4.1.1' + s.version = '0.5.0.0' s.summary = 'Messaging primitives for Eve...
Package version increased from 0.4.1.1 to 0.5.0.0
diff --git a/db/data_migration/20150615092751_replace_policy_admin_links.rb b/db/data_migration/20150615092751_replace_policy_admin_links.rb index abc1234..def5678 100644 --- a/db/data_migration/20150615092751_replace_policy_admin_links.rb +++ b/db/data_migration/20150615092751_replace_policy_admin_links.rb @@ -20,7 +2...
Increase the batch size of admin URL data migration. Increasing from 50 to 1000 increases the transient memory usage from 350MB to 550MB but decreases the time per 1000 editions from 50s to 30s.
diff --git a/lib/contentful_middleman/version_hash.rb b/lib/contentful_middleman/version_hash.rb index abc1234..def5678 100644 --- a/lib/contentful_middleman/version_hash.rb +++ b/lib/contentful_middleman/version_hash.rb @@ -12,7 +12,7 @@ def write_for_space_with_entries(space_name, entries) sorted_ent...
Use the updated_at value rather than the version to calculate the hash When using the preview api the revision field won't change unless the entry is republished. This meant that even if the data in the entries changed the version hash would stay the same
diff --git a/ruby/lumidatum_client/lumidatum_client.gemspec b/ruby/lumidatum_client/lumidatum_client.gemspec index abc1234..def5678 100644 --- a/ruby/lumidatum_client/lumidatum_client.gemspec +++ b/ruby/lumidatum_client/lumidatum_client.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |spec| spec.name = ...
Fix for dependency installation failure.
diff --git a/spec/routing/catch_all_spec.rb b/spec/routing/catch_all_spec.rb index abc1234..def5678 100644 --- a/spec/routing/catch_all_spec.rb +++ b/spec/routing/catch_all_spec.rb @@ -24,4 +24,13 @@ path: 'foo/bar/baz' ) end + + it 'GET /foo/...
Tweak the catch all routing spec.
diff --git a/lib/generators/mtgextractor_generator.rb b/lib/generators/mtgextractor_generator.rb index abc1234..def5678 100644 --- a/lib/generators/mtgextractor_generator.rb +++ b/lib/generators/mtgextractor_generator.rb @@ -2,10 +2,11 @@ module MTGExtractor class MTGExtractorGenerator < ::Rails::Generators::Base ...
Test working generator with just card class and migration
diff --git a/spec/acceptance/server_spec.rb b/spec/acceptance/server_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/server_spec.rb +++ b/spec/acceptance/server_spec.rb @@ -3,7 +3,11 @@ describe 'stns::server class' do let(:manifest) { <<-EOS - include ::stns::server + class { '::stns::ser...
Customize parameters on acceptance tests
diff --git a/spec/support/spec_perimeter.rb b/spec/support/spec_perimeter.rb index abc1234..def5678 100644 --- a/spec/support/spec_perimeter.rb +++ b/spec/support/spec_perimeter.rb @@ -7,9 +7,9 @@ can :view, String end - subscribe :dining, :eat, :evented - subscribe :puppets, :dress, ->(event) { - @dresse...
Make relaying of events testable
diff --git a/spec/hosts/environment_spec.rb b/spec/hosts/environment_spec.rb index abc1234..def5678 100644 --- a/spec/hosts/environment_spec.rb +++ b/spec/hosts/environment_spec.rb @@ -4,7 +4,8 @@ context 'without an explicit environment setting' do it { should contain_file('environment').with_path('rp_env') } ...
Disable environment override test on Puppet ~> 3.8.5 Broken since PUP-5522 (puppetlabs/puppet@8136aff1), without a clear solution.
diff --git a/manifests/cf-manifest/spec/manifest/release_versions_spec.rb b/manifests/cf-manifest/spec/manifest/release_versions_spec.rb index abc1234..def5678 100644 --- a/manifests/cf-manifest/spec/manifest/release_versions_spec.rb +++ b/manifests/cf-manifest/spec/manifest/release_versions_spec.rb @@ -0,0 +1,23 @@+re...
Add test that release versions match URLs We've hit problems where release URLs get updated, but the corresponding version field doesn't. This adds a test to catch this early.
diff --git a/lib/server_metrics/collectors/network.rb b/lib/server_metrics/collectors/network.rb index abc1234..def5678 100644 --- a/lib/server_metrics/collectors/network.rb +++ b/lib/server_metrics/collectors/network.rb @@ -9,7 +9,7 @@ lines.each do |line| iface, rest = line.split(':', 2).collect { |e| ...
Change from whitelisting to blacklisting interfaces. Exclude only loopback interface by default
diff --git a/lib/carrierwave/storage/webdav.rb b/lib/carrierwave/storage/webdav.rb index abc1234..def5678 100644 --- a/lib/carrierwave/storage/webdav.rb +++ b/lib/carrierwave/storage/webdav.rb @@ -29,7 +29,7 @@ true end def url(options = {}) - "http://files.redcursor.net/#{path}" + ...
Make new file URLS default to main host and https
diff --git a/private_address_check.gemspec b/private_address_check.gemspec index abc1234..def5678 100644 --- a/private_address_check.gemspec +++ b/private_address_check.gemspec @@ -17,7 +17,7 @@ spec.files = Dir.glob("{lib,test}/**/*.rb") + %w[CODE_OF_CONDUCT.md Gemfile LICENSE.txt README.md Rakefile] spec...
Fix error in gemspec with specifying Ruby version
diff --git a/spec/integration/okapi.rb b/spec/integration/okapi.rb index abc1234..def5678 100644 --- a/spec/integration/okapi.rb +++ b/spec/integration/okapi.rb @@ -3,6 +3,7 @@ describe Okapi do class TestClass attr_accessor :username + attr_hider :password def initialize(username, password) @u...
Implement tests for the behaviour
diff --git a/spec/features/phenotype_recommendation_spec.rb b/spec/features/phenotype_recommendation_spec.rb index abc1234..def5678 100644 --- a/spec/features/phenotype_recommendation_spec.rb +++ b/spec/features/phenotype_recommendation_spec.rb @@ -0,0 +1,63 @@+RSpec.feature 'Phenotype recommendation' do + let!(:user)...
Add test for phenotype/variation recommendation
diff --git a/lib/yaccl/model/object_factory.rb b/lib/yaccl/model/object_factory.rb index abc1234..def5678 100644 --- a/lib/yaccl/model/object_factory.rb +++ b/lib/yaccl/model/object_factory.rb @@ -4,8 +4,10 @@ def self.create(repository_id, raw) base_type_id = if raw[:properties] raw[:properti...
Raise when raw body nonsensical.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -4,7 +4,7 @@ validates :username, presence: { message: "Username field can't be left blank"}, length: { in: 4..15, message: 'Username must be between 4-15 characters in length' }, un...
Update User model password validations. Turn off has_secure_password validations to avoid repeat error for empty password field
diff --git a/library/drb/start_service_spec.rb b/library/drb/start_service_spec.rb index abc1234..def5678 100644 --- a/library/drb/start_service_spec.rb +++ b/library/drb/start_service_spec.rb @@ -3,35 +3,26 @@ require 'drb' describe "DRb.start_service" do - before :all do - @port = 9001 + (Process.pid & 7 ) + ...
Fix DRb.start_service to use any available port git-svn-id: ab86ecd26fe50a6a239cacb71380e346f71cee7d@58995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -5,6 +5,8 @@ has_many :comments has_many :votes + validates :name, presence: true, length: {in: 8..20} + validates :email, presence: true end
Include validations for name and email
diff --git a/app/models/vote.rb b/app/models/vote.rb index abc1234..def5678 100644 --- a/app/models/vote.rb +++ b/app/models/vote.rb @@ -1,4 +1,6 @@ class Vote < ActiveRecord::Base belongs_to :user belongs_to :votable, polymorphic: true + + validates :is_up, :user_id, :votable_id, presence: true end
Add validations to Vote model
diff --git a/lib/capybara/rspec/features.rb b/lib/capybara/rspec/features.rb index abc1234..def5678 100644 --- a/lib/capybara/rspec/features.rb +++ b/lib/capybara/rspec/features.rb @@ -1,28 +1,45 @@-module Capybara - module Features - def self.included(base) - base.instance_eval do - alias :background :...
Support RSpec expose_dsl_globally configuration option
diff --git a/lib/halfday/yard/capistrano.rb b/lib/halfday/yard/capistrano.rb index abc1234..def5678 100644 --- a/lib/halfday/yard/capistrano.rb +++ b/lib/halfday/yard/capistrano.rb @@ -1,17 +1,19 @@ Capistrano::Configuration.instance(:must_exist).load do - after 'deploy:create_symlink', 'yard:generate' + if defined...
Stop running yard:generate unless Yard is defined
diff --git a/lib/lyricfy/providers/wikia.rb b/lib/lyricfy/providers/wikia.rb index abc1234..def5678 100644 --- a/lib/lyricfy/providers/wikia.rb +++ b/lib/lyricfy/providers/wikia.rb @@ -17,9 +17,13 @@ private + def prepare_parameter(parameter) + a = parameter.gsub(/\W/, '') + end + def format_par...
Replace any non-word in parameters for Wikia
diff --git a/lib/ws_light/set/random_set.rb b/lib/ws_light/set/random_set.rb index abc1234..def5678 100644 --- a/lib/ws_light/set/random_set.rb +++ b/lib/ws_light/set/random_set.rb @@ -13,9 +13,8 @@ end def generate_set - length = type == :double ? Strip::LENGTH * 2 : Strip::LENGTH set = ...
[BUGFIX] Use existing full_length instance var
diff --git a/vagrant/prompt_example.rb b/vagrant/prompt_example.rb index abc1234..def5678 100644 --- a/vagrant/prompt_example.rb +++ b/vagrant/prompt_example.rb @@ -0,0 +1,15 @@+Vagrant.configure('2') do |config| + + # Use %q to avoid nested here-doc issue with vim-ruby syntax highlighting. + config.vm.provision :she...
Add an example to show how to customize vagrant prompt
diff --git a/test/features/list_overheards_test.rb b/test/features/list_overheards_test.rb index abc1234..def5678 100644 --- a/test/features/list_overheards_test.rb +++ b/test/features/list_overheards_test.rb @@ -2,12 +2,23 @@ class TestListOverheards < FeatureTest def test_visiting_the_home_page_reveals_overheard...
Write test for user searching Overheards First things first, we write a test. Here we're expecting the page to have: 1. Have an input field labeled `Search` 2. A button labeled `Search Overheards` Once the `Search Overheards` button is clicked; we're expecting to *only* see quotes which have the word "Foo" in them.
diff --git a/promo/app/controllers/spree/checkout_controller_decorator.rb b/promo/app/controllers/spree/checkout_controller_decorator.rb index abc1234..def5678 100644 --- a/promo/app/controllers/spree/checkout_controller_decorator.rb +++ b/promo/app/controllers/spree/checkout_controller_decorator.rb @@ -22,19 +22,19 @@...
[promo] Remove excessive respond_with usage in CheckoutControllerDecorator
diff --git a/spec/integration_spec.rb b/spec/integration_spec.rb index abc1234..def5678 100644 --- a/spec/integration_spec.rb +++ b/spec/integration_spec.rb @@ -32,11 +32,11 @@ end before do - described_class.setup(Db.shards_config) + Post.setup(Db.shards_config) end after do - described_class.d...
Test inherited class on integration spec
diff --git a/features/support/steps/cli_steps.rb b/features/support/steps/cli_steps.rb index abc1234..def5678 100644 --- a/features/support/steps/cli_steps.rb +++ b/features/support/steps/cli_steps.rb @@ -5,12 +5,9 @@ def _execute(exec) Dir.chdir(@__root) do Bundler.with_clean_env do - Open3.popen2...
Adjust steps to run on JRuby
diff --git a/symfony/recipes/daemon.rb b/symfony/recipes/daemon.rb index abc1234..def5678 100644 --- a/symfony/recipes/daemon.rb +++ b/symfony/recipes/daemon.rb @@ -16,7 +16,7 @@ if daemon[:symfony].present? and !daemon[:symfony] cmd = "#{daemon[:command]}" else - ...
Move --prod so that command is the last argument
diff --git a/lib/cookbook-release/commit.rb b/lib/cookbook-release/commit.rb index abc1234..def5678 100644 --- a/lib/cookbook-release/commit.rb +++ b/lib/cookbook-release/commit.rb @@ -11,7 +11,7 @@ end def patch? - !!(self[:subject] =~ /\bfix\b/i) + !!(self[:subject] =~ /\bfix\b/i) || !!(self[:subject] =~...
Add bugfix is "patch" level detection
diff --git a/lib/filepicker_rails/engine.rb b/lib/filepicker_rails/engine.rb index abc1234..def5678 100644 --- a/lib/filepicker_rails/engine.rb +++ b/lib/filepicker_rails/engine.rb @@ -10,7 +10,7 @@ initializer 'filepicker_rails.action_controller' do |app| ActiveSupport.on_load(:action_controller) do - ...
Fix helper inclusion for Rails 5 Calling the `helper` method after upgrading to Rails 5 resulted in the following error: undefined method 'helper' for ActionController::API:Class This commit follows the lead of the following commit on another project: https://github.com/weppos/breadcrumbs_on_rails/commit/3a3ac0c0d42...
diff --git a/lib/mdi_cloud_decoder/track.rb b/lib/mdi_cloud_decoder/track.rb index abc1234..def5678 100644 --- a/lib/mdi_cloud_decoder/track.rb +++ b/lib/mdi_cloud_decoder/track.rb @@ -37,7 +37,7 @@ end def method_missing(method_sym, *arguments, &block) - @fields[method_sym.to_s.upcase] if @fields.i...
Return nil if field was not provided
diff --git a/lib/rspec/expect_it/helpers.rb b/lib/rspec/expect_it/helpers.rb index abc1234..def5678 100644 --- a/lib/rspec/expect_it/helpers.rb +++ b/lib/rspec/expect_it/helpers.rb @@ -38,6 +38,14 @@ expect(result) end + def expect_its(method) + ExpectItsExpectationTarget.new(self, method) ...
Revert "Removed `expect_its` and `expect_its!` methods." This reverts commit b38c6267c348d5643f8004ffac5478064edb70cc.
diff --git a/lib/secret_bambino/bambinos.rb b/lib/secret_bambino/bambinos.rb index abc1234..def5678 100644 --- a/lib/secret_bambino/bambinos.rb +++ b/lib/secret_bambino/bambinos.rb @@ -2,6 +2,10 @@ class Bambinos def init(filename) load_from_yaml(filename) + end + + def assigned_bambinos + @ass...
Create list of assigned Bambinos.
diff --git a/lib/tasks/db_create_admin.rake b/lib/tasks/db_create_admin.rake index abc1234..def5678 100644 --- a/lib/tasks/db_create_admin.rake +++ b/lib/tasks/db_create_admin.rake @@ -3,7 +3,8 @@ namespace :db do desc "Create an admin user." task :create_admin, [:password] => :environment do |_t, args| - u = ...
10398: Make create_admin task set pref_lang
diff --git a/lib/tasks/redmine_jenkins.rake b/lib/tasks/redmine_jenkins.rake index abc1234..def5678 100644 --- a/lib/tasks/redmine_jenkins.rake +++ b/lib/tasks/redmine_jenkins.rake @@ -1,18 +1,16 @@+require 'ci/reporter/rake/rspec' + namespace :redmine_jenkins do + + namespace :ci do + ENV["CI_REPORTS"] = Rails.ro...
Add rake task to launch tests
diff --git a/app/helpers/survey_helper.rb b/app/helpers/survey_helper.rb index abc1234..def5678 100644 --- a/app/helpers/survey_helper.rb +++ b/app/helpers/survey_helper.rb @@ -1,5 +1,5 @@ module SurveyHelper def survey_url - 'https://forms.gle/MXbpmLTPdJnVLDdc8' + 'https://forms.gle/KAyvks7aourQmk3q8' end ...
Update survey link to Mk 2 survey
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -10,3 +10,5 @@ append :linked_files, 'config/database.yml' append :linked_dirs, '.bundle', 'log', 'tmp/pids' + +set :passenger_restart_with_sudo, true
Use sudo to restart passenger
diff --git a/app/models/benchmark_type.rb b/app/models/benchmark_type.rb index abc1234..def5678 100644 --- a/app/models/benchmark_type.rb +++ b/app/models/benchmark_type.rb @@ -1,5 +1,5 @@ class BenchmarkType < ActiveRecord::Base - default_scope { order("#{self.table_name} ASC") } + default_scope { order("#{self.tabl...
Add missing column in default scope.
diff --git a/app/services/diff_outputs.rb b/app/services/diff_outputs.rb index abc1234..def5678 100644 --- a/app/services/diff_outputs.rb +++ b/app/services/diff_outputs.rb @@ -9,16 +9,16 @@ File.readlines(filename1).zip(File.readlines(filename2)).each do |line1, line2| line_counter += 1 - stripped_li...
Fix the file differ to handle long outputs.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,6 +2,7 @@ PhotoAlbum::Application.routes.draw do root 'albums#index' + get '/albums', to: redirect('/') get "/auth/:provider/callback" => "sessions#create" delete "/signout" =...
Add redirect from /albums to root
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,4 +1,4 @@-ActionController::Routing::Routes.draw do |map| +Rails.application.routes.draw do |map| map.namespace(:admin_data) do |admin_data|
Fix DEPRECATION WARNING: ActionController::Routing::Routes is deprecated.
diff --git a/breakpoint.gemspec b/breakpoint.gemspec index abc1234..def5678 100644 --- a/breakpoint.gemspec +++ b/breakpoint.gemspec @@ -16,8 +16,8 @@ s.licenses = ["MIT", "GPL-2.0"] # Gem Files - s.files = ["README.markdown"] - s.files += ["CHANGELOG.markdown"] + s.files = ["README.md"] + s.files += ["CHANG...
Fix filenames for README & CHANGELOG in the gemspec.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,9 +1,10 @@ Rails.application.routes.draw do devise_for :users get 'w_elcome/index' + resources :notes + authenticated :user do + root 'notes#index', as: "authenticated_root" + ...
Change root based on if user_signed_in?
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -9,5 +9,5 @@ resources :projects, only: [:create] do collection { get :random } end - get ':username/:repo' => "projects#show", as: :project + get ':username/:repo' => "projects#sh...
Update project url for dot names.
diff --git a/bank_job.gemspec b/bank_job.gemspec index abc1234..def5678 100644 --- a/bank_job.gemspec +++ b/bank_job.gemspec @@ -19,6 +19,7 @@ spec.require_paths = ["lib"] spec.add_runtime_dependency 'mechanize', '~> 2.7' + spec.add_runtime_dependency 'hashie', '~> 2.0.5' spec.add_development_dependency "b...
Add runtime dependency hashie to gemspec
diff --git a/lib/braingasm/options.rb b/lib/braingasm/options.rb index abc1234..def5678 100644 --- a/lib/braingasm/options.rb +++ b/lib/braingasm/options.rb @@ -22,9 +22,9 @@ end end - def self.handle_options(options) - Options[:eof] = 0 if options[:zero] - Options[:eof] = -1 if options[:negative] - ...
Rename method argument for clarification